[GitHub] [hbase] Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator
Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-513665373 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 215 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 256 | branch-2.1 passed | | +1 | compile | 25 | branch-2.1 passed | | +1 | checkstyle | 34 | branch-2.1 passed | | +1 | shadedjars | 232 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 24 | branch-2.1 passed | | 0 | spotbugs | 78 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 77 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 264 | the patch passed | | +1 | compile | 26 | the patch passed | | +1 | javac | 26 | the patch passed | | +1 | checkstyle | 32 | hbase-client: The patch generated 0 new + 58 unchanged - 4 fixed = 58 total (was 62) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 256 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1034 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 21 | the patch passed | | +1 | findbugs | 82 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 195 | hbase-client in the patch passed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 3079 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/22/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/343 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c90c27678f5f 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh | | git revision | branch-2.1 / 60cfdd822b | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/22/testReport/ | | Max. process+thread count | 291 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/22/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #396: HBASE-22718 : Removal of org.apache.hadoop.hbase.util.Counter
Apache-HBase commented on issue #396: HBASE-22718 : Removal of org.apache.hadoop.hbase.util.Counter URL: https://github.com/apache/hbase/pull/396#issuecomment-513663458 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 71 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 308 | master passed | | +1 | compile | 20 | master passed | | +1 | checkstyle | 23 | master passed | | +1 | shadedjars | 259 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 20 | master passed | | 0 | spotbugs | 48 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 46 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 238 | the patch passed | | +1 | compile | 22 | the patch passed | | +1 | javac | 22 | the patch passed | | +1 | checkstyle | 23 | hbase-common: The patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 268 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 797 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 19 | the patch passed | | +1 | findbugs | 53 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 167 | hbase-common in the patch passed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 2675 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-396/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/396 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux ade1c7e0efdd 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-396/out/precommit/personality/provided.sh | | git revision | master / c9293b0b12 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-396/2/testReport/ | | Max. process+thread count | 287 (vs. ulimit of 1) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-396/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #367: region_mover.rb should choose same rsgroup servers as target servers
Apache-HBase commented on issue #367: region_mover.rb should choose same rsgroup servers as target servers URL: https://github.com/apache/hbase/pull/367#issuecomment-513663169 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 1447 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | ||| _ branch-1 Compile Tests _ | ||| _ Patch Compile Tests _ | | -1 | rubocop | 5 | The patch generated 37 new + 354 unchanged - 2 fixed = 391 total (was 356) | | +1 | whitespace | 0 | The patch has no whitespace issues. | ||| _ Other Tests _ | | +1 | asflicense | 18 | The patch does not generate ASF License warnings. | | | | 1539 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-367/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/367 | | Optional Tests | dupname asflicense rubocop | | uname | Linux 949576db39f7 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-367/out/precommit/personality/provided.sh | | git revision | branch-1 / 28de85f | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-367/6/artifact/out/diff-patch-rubocop.txt | | Max. process+thread count | 37 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-367/6/console | | versions | git=1.9.1 maven=3.0.5 rubocop=0.73.0 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes
Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes URL: https://github.com/apache/hbase/pull/374#issuecomment-513662850 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 67 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 237 | master passed | | +1 | compile | 22 | master passed | | +1 | checkstyle | 24 | master passed | | +1 | shadedjars | 258 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 19 | master passed | | 0 | spotbugs | 51 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 49 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 235 | the patch passed | | +1 | compile | 20 | the patch passed | | +1 | javac | 20 | the patch passed | | +1 | checkstyle | 23 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 260 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 733 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 18 | the patch passed | | +1 | findbugs | 54 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 180 | hbase-common in the patch passed. | | +1 | asflicense | 10 | The patch does not generate ASF License warnings. | | | | 2507 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/374 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 0c621ff85b68 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh | | git revision | master / c9293b0b12 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/6/testReport/ | | Max. process+thread count | 347 (vs. ulimit of 1) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/6/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #202: HBASE-22280 Separate read/write handler for priority request(especial…
Apache-HBase commented on issue #202: HBASE-22280 Separate read/write handler for priority request(especial… URL: https://github.com/apache/hbase/pull/202#issuecomment-513659942 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 55 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 265 | master passed | | +1 | compile | 61 | master passed | | +1 | checkstyle | 73 | master passed | | +1 | shadedjars | 301 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 36 | master passed | | 0 | spotbugs | 285 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 282 | master passed | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 167 | root in the patch failed. | | +1 | compile | 53 | the patch passed | | +1 | javac | 53 | the patch passed | | -1 | checkstyle | 71 | hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | -1 | shadedjars | 224 | patch has 11 errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 123 | The patch causes 11 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 246 | The patch causes 11 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 377 | The patch causes 11 errors with Hadoop v3.1.2. | | +1 | javadoc | 36 | the patch passed | | +1 | findbugs | 279 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 57 | hbase-server in the patch failed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 2417 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/202 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux a00bca78553a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-202/out/precommit/personality/provided.sh | | git revision | master / c9293b0b12 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/artifact/out/patch-mvninstall-root.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/artifact/out/diff-checkstyle-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/artifact/out/patch-shadedjars.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/artifact/out/patch-javac-3.1.2.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/testReport/ | | Max. process+thread count | 93 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 opened a new pull request #399: HBASE-22676 Move all the code in hbase-rsgroup to hbase-server and re…
Apache9 opened a new pull request #399: HBASE-22676 Move all the code in hbase-rsgroup to hbase-server and re… URL: https://github.com/apache/hbase/pull/399 …move hbase-rsgroup module This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 closed pull request #397: HBASE-22676 Move all the code in hbase-rsgroup to hbase-server and re…
Apache9 closed pull request #397: HBASE-22676 Move all the code in hbase-rsgroup to hbase-server and re… URL: https://github.com/apache/hbase/pull/397 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #392: HBASE-22714 - Fix opertationTimeout typo
Apache-HBase commented on issue #392: HBASE-22714 - Fix opertationTimeout typo URL: https://github.com/apache/hbase/pull/392#issuecomment-513657739 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 69 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 241 | master passed | | +1 | compile | 24 | master passed | | +1 | checkstyle | 28 | master passed | | +1 | shadedjars | 258 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 20 | master passed | | 0 | spotbugs | 66 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 65 | master passed | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 77 | root in the patch failed. | | -1 | compile | 15 | hbase-client in the patch failed. | | -1 | javac | 15 | hbase-client in the patch failed. | | -1 | checkstyle | 16 | The patch fails to run checkstyle in hbase-client | | +1 | whitespace | 0 | The patch has no whitespace issues. | | -1 | shadedjars | 134 | patch has 118 errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 66 | The patch causes 118 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 132 | The patch causes 118 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 202 | The patch causes 118 errors with Hadoop v3.1.2. | | -1 | javadoc | 12 | hbase-client in the patch failed. | | -1 | findbugs | 15 | hbase-client in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 15 | hbase-client in the patch failed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 1282 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/392 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 864a89ac7a4b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-392/out/precommit/personality/provided.sh | | git revision | master / c9293b0b12 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/2/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/2/artifact/out/patch-compile-hbase-client.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/2/artifact/out/patch-compile-hbase-client.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/2/artifact/out//home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-392/out/maven-patch-checkstyle-hbase-client.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/2/artifact/out/patch-shadedjars.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/2/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/2/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/2/artifact/out/patch-javac-3.1.2.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/2/artifact/out/patch-javadoc-hbase-client.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/2/artifact/out/patch-findbugs-hbase-client.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/2/artifact/out/patch-unit-hbase-client.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/2/testReport/ | | Max. process+thread count | 96 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically gene
[GitHub] [hbase] Apache-HBase commented on issue #336: HBASE-22580 Add a table attribute to make user scan snapshot feature configurable for table
Apache-HBase commented on issue #336: HBASE-22580 Add a table attribute to make user scan snapshot feature configurable for table URL: https://github.com/apache/hbase/pull/336#issuecomment-513657659 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 70 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | -1 | mvninstall | 11 | root in master failed. | | -1 | compile | 54 | hbase-server in master failed. | | +1 | checkstyle | 70 | master passed | | +1 | shadedjars | 264 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 31 | master passed | | 0 | spotbugs | 330 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 34 | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 12 | root in the patch failed. | | -1 | compile | 36 | hbase-server in the patch failed. | | -1 | javac | 36 | hbase-server in the patch failed. | | +1 | checkstyle | 71 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 260 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 10 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 20 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 29 | The patch causes 10 errors with Hadoop v3.1.2. | | +1 | javadoc | 30 | the patch passed | | -1 | findbugs | 33 | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 37 | hbase-server in the patch failed. | | +1 | asflicense | 10 | The patch does not generate ASF License warnings. | | | | 1108 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/10/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/336 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux dd56b1d9c7ed 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-336/out/precommit/personality/provided.sh | | git revision | master / c9293b0b12 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/10/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/10/artifact/out/branch-compile-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/10/artifact/out/branch-findbugs-hbase-server.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/10/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/10/artifact/out/patch-compile-hbase-server.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/10/artifact/out/patch-compile-hbase-server.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/10/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/10/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/10/artifact/out/patch-javac-3.1.2.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/10/artifact/out/patch-findbugs-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/10/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/10/testReport/ | | Max. process+thread count | 87 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-336/10/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log
[GitHub] [hbase] Apache-HBase commented on issue #391: HBASE-22628 Document the custom WAL directory (hbase.wal.dir) usage
Apache-HBase commented on issue #391: HBASE-22628 Document the custom WAL directory (hbase.wal.dir) usage URL: https://github.com/apache/hbase/pull/391#issuecomment-513657447 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 209 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | -1 | mvninstall | 19 | root in master failed. | | -1 | refguide | 473 | branch has 2 errors when building the reference guide. | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 12 | root in the patch failed. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | -1 | refguide | 437 | patch has 2 errors when building the reference guide. | ||| _ Other Tests _ | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 1211 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-391/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/391 | | Optional Tests | dupname asflicense refguide | | uname | Linux ac91dafe0f03 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-391/out/precommit/personality/provided.sh | | git revision | master / c9293b0b12 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-391/2/artifact/out/branch-mvninstall-root.txt | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-391/2/artifact/out/branch-refguide.log | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-391/2/artifact/out/patch-mvninstall-root.txt | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-391/2/artifact/out/patch-refguide.log | | Max. process+thread count | 56 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-391/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-22719) Add debug support for github PR pre commit job
[ https://issues.apache.org/jira/browse/HBASE-22719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-22719. --- Resolution: Fixed Assignee: Duo Zhang Pushed to all active branches. > Add debug support for github PR pre commit job > -- > > Key: HBASE-22719 > URL: https://issues.apache.org/jira/browse/HBASE-22719 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11 > > Attachments: HBASE-22719.patch > > > And we could also remove the JIRA_ISSUE_KEY parameter, as it is useless... -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22719) Add debug support for github PR pre commit job
[ https://issues.apache.org/jira/browse/HBASE-22719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22719: -- Component/s: build > Add debug support for github PR pre commit job > -- > > Key: HBASE-22719 > URL: https://issues.apache.org/jira/browse/HBASE-22719 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Duo Zhang >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11 > > Attachments: HBASE-22719.patch > > > And we could also remove the JIRA_ISSUE_KEY parameter, as it is useless... -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22719) Add debug support for github PR pre commit job
[ https://issues.apache.org/jira/browse/HBASE-22719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22719: -- Fix Version/s: 1.4.11 1.3.6 2.1.6 2.2.1 2.0.6 2.3.0 1.5.0 3.0.0 > Add debug support for github PR pre commit job > -- > > Key: HBASE-22719 > URL: https://issues.apache.org/jira/browse/HBASE-22719 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11 > > Attachments: HBASE-22719.patch > > > And we could also remove the JIRA_ISSUE_KEY parameter, as it is useless... -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22719) Add debug support for github PR pre commit job
[ https://issues.apache.org/jira/browse/HBASE-22719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889941#comment-16889941 ] Duo Zhang commented on HBASE-22719: --- What I pushed to all active branches. > Add debug support for github PR pre commit job > -- > > Key: HBASE-22719 > URL: https://issues.apache.org/jira/browse/HBASE-22719 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Priority: Major > Attachments: HBASE-22719.patch > > > And we could also remove the JIRA_ISSUE_KEY parameter, as it is useless... -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22719) Add debug support for github PR pre commit job
[ https://issues.apache.org/jira/browse/HBASE-22719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22719: -- Attachment: HBASE-22719.patch > Add debug support for github PR pre commit job > -- > > Key: HBASE-22719 > URL: https://issues.apache.org/jira/browse/HBASE-22719 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Priority: Major > Attachments: HBASE-22719.patch > > > And we could also remove the JIRA_ISSUE_KEY parameter, as it is useless... -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #238: HBASE-22410 add the notion of the expected # of servers for non-fixed server sets; report an alternative dead server metric 01
Apache-HBase commented on issue #238: HBASE-22410 add the notion of the expected # of servers for non-fixed server sets; report an alternative dead server metric 01 URL: https://github.com/apache/hbase/pull/238#issuecomment-513654602 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 0 | Docker mode activated. | | -1 | patch | 9 | https://github.com/apache/hbase/pull/238 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/238 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-238/8/console | | versions | git=2.7.4 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #382: HBASE-22692 Added Rubocop definition file to bin directory
Apache-HBase commented on issue #382: HBASE-22692 Added Rubocop definition file to bin directory URL: https://github.com/apache/hbase/pull/382#issuecomment-513654291 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 266 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | yamllint | 0 | yamllint was not available. | | +1 | @author | 0 | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | | +1 | whitespace | 0 | The patch has no whitespace issues. | ||| _ Other Tests _ | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 334 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/382 | | Optional Tests | dupname asflicense yamllint | | uname | Linux 8303c5049865 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-382/out/precommit/personality/provided.sh | | git revision | master / c9293b0b12 | | Max. process+thread count | 47 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #237: HBASE-22408 add dead and unknown server open regions metric to AM 01
Apache-HBase commented on issue #237: HBASE-22408 add dead and unknown server open regions metric to AM 01 URL: https://github.com/apache/hbase/pull/237#issuecomment-513651004 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 0 | Docker mode activated. | | -1 | patch | 8 | https://github.com/apache/hbase/pull/237 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/237 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-237/10/console | | versions | git=2.7.4 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 closed pull request #398: HBASE-22719 for triggering pre commit
Apache9 closed pull request #398: HBASE-22719 for triggering pre commit URL: https://github.com/apache/hbase/pull/398 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #398: HBASE-22719 for triggering pre commit
Apache9 commented on issue #398: HBASE-22719 for triggering pre commit URL: https://github.com/apache/hbase/pull/398#issuecomment-513642795 OK, seems good. Let me commit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #398: HBASE-22719 for triggering pre commit
Apache-HBase commented on issue #398: HBASE-22719 for triggering pre commit URL: https://github.com/apache/hbase/pull/398#issuecomment-513640064 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 32 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ HBASE-22719 Compile Tests _ | | +1 | mvninstall | 246 | HBASE-22719 passed | | +1 | compile | 162 | HBASE-22719 passed | | +1 | shadedjars | 255 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 159 | HBASE-22719 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 237 | the patch passed | | +1 | compile | 158 | the patch passed | | +1 | javac | 158 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 2 | The patch has no ill-formed XML file. | | +1 | shadedjars | 270 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 733 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 156 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 12489 | root in the patch failed. | | +1 | asflicense | 41 | The patch does not generate ASF License warnings. | | | | 15209 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.snapshot.TestExportSnapshotNoCluster | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-398/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/398 | | Optional Tests | dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile | | uname | Linux 6d0c1f06d9df 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-398/out/precommit/personality/provided.sh | | git revision | HBASE-22719 / 00075ea4fc | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-398/2/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-398/2/testReport/ | | Max. process+thread count | 5520 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-398/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd commented on a change in pull request #386: HBASE-22610 [BucketCache] Rename hbase.offheapcache.minblocksize.
Reidd commented on a change in pull request #386: HBASE-22610 [BucketCache] Rename hbase.offheapcache.minblocksize. URL: https://github.com/apache/hbase/pull/386#discussion_r305671401 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheFactory.java ## @@ -17,9 +17,6 @@ */ package org.apache.hadoop.hbase.io.hfile; -import static org.apache.hadoop.hbase.HConstants.BUCKET_CACHE_IOENGINE_KEY; -import static org.apache.hadoop.hbase.HConstants.BUCKET_CACHE_SIZE_KEY; Review comment: Why this two configs got deleted? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22527) [hbck2] Add a master web ui to show the problematic regions
[ https://issues.apache.org/jira/browse/HBASE-22527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22527: --- Attachment: HBASE-22527.branch-2.0.002.patch > [hbck2] Add a master web ui to show the problematic regions > --- > > Key: HBASE-22527 > URL: https://issues.apache.org/jira/browse/HBASE-22527 > Project: HBase > Issue Type: Sub-task > Components: hbase-operator-tools, hbck2 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Attachments: HBASE-22527.branch-2.0.001.patch, > HBASE-22527.branch-2.0.001.patch, HBASE-22527.branch-2.0.002.patch, > HBASE-22527.branch-2.1.001.patch, HBASE-22527.branch-2.1.002.patch, > HBASE-22527.branch-2.1.003.patch, HBASE-22527.master.001.patch, > HBASE-22527.master.002.patch, HBASE-22527.master.003.patch, > HBASE-22527.master.004.patch, HBASE-22527.master.addendum.patch > > > On our cluster which based 2.2.0, we found one problem: there are some opened > regions which had wrong regionserver in meta. The regionserver is not exist. > We used hbck2 to fix them by the following steps. > # disable table > # bypass the stucked close region procedure (as the target regionserver is > not exist) and disable table procedure. > # setRegionState to CLOSED. > # setTableState to DISABLED. > # enable table > We found this problem by scan the hbase:meta. I thought we should add this > feature to hbck2. The we can use hbck2 to find this problem. Thanks. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22527) [hbck2] Add a master web ui to show the problematic regions
[
https://issues.apache.org/jira/browse/HBASE-22527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889899#comment-16889899
]
HBase QA commented on HBASE-22527:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} branch-2.0 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
24s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
9s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
37s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
52s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
6s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} branch-2.0 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
32s{color} | {color:red} hbase-server: The patch generated 65 new + 29
unchanged - 0 fixed = 94 total (was 29) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
10s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
19m 31s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.7 2.8.5 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}184m 59s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
26s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}243m 20s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush |
| | hadoop.hbase.TestRegionRebalancing |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=18.09.7 Server=18.09.7 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/659/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22527 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12975360/HBASE-22527.branch-2.0.001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux d8bdbd232e88 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4
22:49:08 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.0 / 5064fea786 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/659/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| unit |
https://builds.apa
[GitHub] [hbase] JeongDaeKim commented on issue #393: HBASE-22715 Use scan queues/executors for scans, when RWQueueRpcExecutor used
JeongDaeKim commented on issue #393: HBASE-22715 Use scan queues/executors for scans, when RWQueueRpcExecutor used URL: https://github.com/apache/hbase/pull/393#issuecomment-513617843 It seems that failed Tests below are not related to this patch. (and not reproduced in my local test) org.apache.hadoop.hbase.client.TestAdmin1.testRegionStateCleanupFromAMMemoryAfterRegionSplitAndMerge | 10 sec | 1 -- | -- | -- org.apache.hadoop.hbase.client.TestAdmin2.testCreateTableRPCTimeOut | 46 sec | 1 @Apache9 Could you take a look at this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22719) Add debug support for github PR pre commit job
[
https://issues.apache.org/jira/browse/HBASE-22719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889858#comment-16889858
]
Hudson commented on HBASE-22719:
Results for branch HBASE-22719
[build #1 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22719/1/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22719/1//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22719/1//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22719/1//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add debug support for github PR pre commit job
> --
>
> Key: HBASE-22719
> URL: https://issues.apache.org/jira/browse/HBASE-22719
> Project: HBase
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Priority: Major
>
> And we could also remove the JIRA_ISSUE_KEY parameter, as it is useless...
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache9 opened a new pull request #398: HBASE-22719 for triggering pre commit
Apache9 opened a new pull request #398: HBASE-22719 for triggering pre commit URL: https://github.com/apache/hbase/pull/398 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22719) Add debug support for github PR pre commit job
[ https://issues.apache.org/jira/browse/HBASE-22719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889855#comment-16889855 ] Duo Zhang commented on HBASE-22719: --- There is no way to test this in pre commit, so as usual, let me push to a new branch and test it. > Add debug support for github PR pre commit job > -- > > Key: HBASE-22719 > URL: https://issues.apache.org/jira/browse/HBASE-22719 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Priority: Major > > And we could also remove the JIRA_ISSUE_KEY parameter, as it is useless... -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (HBASE-22719) Add debug support for github PR pre commit job
Duo Zhang created HBASE-22719: - Summary: Add debug support for github PR pre commit job Key: HBASE-22719 URL: https://issues.apache.org/jira/browse/HBASE-22719 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang And we could also remove the JIRA_ISSUE_KEY parameter, as it is useless... -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache9 commented on issue #397: HBASE-22676 Move all the code in hbase-rsgroup to hbase-server and re…
Apache9 commented on issue #397: HBASE-22676 Move all the code in hbase-rsgroup to hbase-server and re… URL: https://github.com/apache/hbase/pull/397#issuecomment-513600218 The pre commit failed and I think this is a bug for yetus. We just removed the hbase-rsgroup module but in the javadoc check we still wants to test the module. > 22:41:57 /testptch/hbase/hbase-rsgroup no longer exists. Skipping. 22:41:57 /testptch/patchprocess/precommit/test-patch.sh: line 1690: pushd: /testptch/hbase/hbase-rsgroup: No such file or directory 22:41:57 22:41:57 22:41:57 22:41:57 ASSERT: no offset passed to offset_clock: unit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22527) [hbck2] Add a master web ui to show the problematic regions
[ https://issues.apache.org/jira/browse/HBASE-22527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22527: --- Attachment: HBASE-22527.branch-2.0.001.patch > [hbck2] Add a master web ui to show the problematic regions > --- > > Key: HBASE-22527 > URL: https://issues.apache.org/jira/browse/HBASE-22527 > Project: HBase > Issue Type: Sub-task > Components: hbase-operator-tools, hbck2 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Attachments: HBASE-22527.branch-2.0.001.patch, > HBASE-22527.branch-2.0.001.patch, HBASE-22527.branch-2.1.001.patch, > HBASE-22527.branch-2.1.002.patch, HBASE-22527.branch-2.1.003.patch, > HBASE-22527.master.001.patch, HBASE-22527.master.002.patch, > HBASE-22527.master.003.patch, HBASE-22527.master.004.patch, > HBASE-22527.master.addendum.patch > > > On our cluster which based 2.2.0, we found one problem: there are some opened > regions which had wrong regionserver in meta. The regionserver is not exist. > We used hbck2 to fix them by the following steps. > # disable table > # bypass the stucked close region procedure (as the target regionserver is > not exist) and disable table procedure. > # setRegionState to CLOSED. > # setTableState to DISABLED. > # enable table > We found this problem by scan the hbase:meta. I thought we should add this > feature to hbck2. The we can use hbck2 to find this problem. Thanks. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #394: HBASE-22716:upgrade zookeeper version to 3.5.5
Apache-HBase commented on issue #394: HBASE-22716:upgrade zookeeper version to 3.5.5 URL: https://github.com/apache/hbase/pull/394#issuecomment-513564553 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 33 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | 0 | mvndep | 22 | Maven dependency ordering for branch | | +1 | mvninstall | 243 | master passed | | +1 | compile | 166 | master passed | | +1 | checkstyle | 176 | master passed | | +1 | shadedjars | 253 | branch has no errors when building our shaded downstream artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: . | | +1 | findbugs | 28 | master passed | | +1 | javadoc | 164 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for patch | | +1 | mvninstall | 244 | the patch passed | | +1 | compile | 161 | the patch passed | | +1 | javac | 161 | the patch passed | | +1 | checkstyle | 130 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 2 | The patch has no ill-formed XML file. | | +1 | shadedjars | 276 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 750 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: . | | +1 | findbugs | 40 | the patch passed | | +1 | javadoc | 190 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 9115 | root in the patch failed. | | +1 | asflicense | 64 | The patch does not generate ASF License warnings. | | | | 12396 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.assignment.TestRegionMoveAndAbandon | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-394/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/394 | | JIRA Issue | HBASE-22716 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml | | uname | Linux 0cc8e66acd9b 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 00075ea4fc | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-394/2/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-394/2/testReport/ | | Max. process+thread count | 4845 (vs. ulimit of 1) | | modules | C: hbase-zookeeper . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-394/2/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22716) upgrade zookeeper version to 3.5.5
[
https://issues.apache.org/jira/browse/HBASE-22716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889754#comment-16889754
]
Hadoop QA commented on HBASE-22716:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
33s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
22s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
13s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
44s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
36s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
12m 30s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
10s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}151m 55s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
4s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}206m 36s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.assignment.TestRegionMoveAndAbandon |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=18.09.8 Server=18.09.8 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-394/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/394 |
| JIRA Is
[GitHub] [hbase] Apache-HBase commented on issue #371: HBASE-22648 : Introducing Snapshot TTL
Apache-HBase commented on issue #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#issuecomment-513560868 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 31 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 22 | Maven dependency ordering for branch | | +1 | mvninstall | 241 | master passed | | +1 | compile | 162 | master passed | | +1 | checkstyle | 133 | master passed | | 0 | refguide | 438 | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 | shadedjars | 266 | branch has no errors when building our shaded downstream artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: . | | +1 | findbugs | 531 | master passed | | +1 | javadoc | 273 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for patch | | +1 | mvninstall | 239 | the patch passed | | +1 | compile | 164 | the patch passed | | +1 | cc | 164 | the patch passed | | +1 | javac | 164 | the patch passed | | +1 | checkstyle | 136 | the patch passed | | -1 | rubocop | 8 | The patch generated 3 new + 273 unchanged - 1 fixed = 276 total (was 274) | | +1 | ruby-lint | 1 | There were no new ruby-lint issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 2 | The patch has no ill-formed XML file. | | 0 | refguide | 447 | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 | shadedjars | 269 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 749 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | hbaseprotoc | 414 | the patch passed | | 0 | findbugs | 0 | Skipped patched modules with no Java source: . | | +1 | findbugs | 576 | the patch passed | | +1 | javadoc | 275 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 12560 | root in the patch passed. | | +1 | asflicense | 228 | The patch does not generate ASF License warnings. | | | | 18578 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-371/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/371 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc rubocop ruby_lint | | uname | Linux 7081e9146fad 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 00075ea4fc | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-371/6/artifact/out/branch-site/book.html | | findbugs | v3.1.11 | | rubocop | v0.73.0 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-371/6/artifact/out/diff-patch-rubocop.txt | | ruby-lint | v2.3.1 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-371/6/artifact/out/patch-site/book.html | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-371/6/testReport/ | | Max. process+thread count | 5409 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-common hbase-protocol hbase-client hbase-server hbase-shell . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-371/6/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase
[
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889746#comment-16889746
]
Hudson commented on HBASE-22514:
Results for branch HBASE-22514
[build #22 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/22/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/22//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/22//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/22//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
> Issue Type: Umbrella
> Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch,
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public
> we need to use java api RSGroupAdminClient to manager RSG
> so RSGroupAdminClient should be public
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose
[
https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889743#comment-16889743
]
Hudson commented on HBASE-21879:
Results for branch HBASE-21879
[build #184 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/184/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/184//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/184//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/184//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Read HFile's block to ByteBuffer directly instead of to byte for reducing
> young gc purpose
> --
>
> Key: HBASE-21879
> URL: https://issues.apache.org/jira/browse/HBASE-21879
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-21879.v1.patch, HBASE-21879.v1.patch,
> QPS-latencies-before-HBASE-21879.png, gc-data-before-HBASE-21879.png
>
>
> In HFileBlock#readBlockDataInternal, we have the following:
> {code}
> @VisibleForTesting
> protected HFileBlock readBlockDataInternal(FSDataInputStream is, long offset,
> long onDiskSizeWithHeaderL, boolean pread, boolean verifyChecksum,
> boolean updateMetrics)
> throws IOException {
> // .
> // TODO: Make this ByteBuffer-based. Will make it easier to go to HDFS with
> BBPool (offheap).
> byte [] onDiskBlock = new byte[onDiskSizeWithHeader + hdrSize];
> int nextBlockOnDiskSize = readAtOffset(is, onDiskBlock, preReadHeaderSize,
> onDiskSizeWithHeader - preReadHeaderSize, true, offset +
> preReadHeaderSize, pread);
> if (headerBuf != null) {
> // ...
> }
> // ...
> }
> {code}
> In the read path, we still read the block from hfile to on-heap byte[], then
> copy the on-heap byte[] to offheap bucket cache asynchronously, and in my
> 100% get performance test, I also observed some frequent young gc, The
> largest memory footprint in the young gen should be the on-heap block byte[].
> In fact, we can read HFile's block to ByteBuffer directly instead of to
> byte[] for reducing young gc purpose. we did not implement this before,
> because no ByteBuffer reading interface in the older HDFS client, but 2.7+
> has supported this now, so we can fix this now. I think.
> Will provide an patch and some perf-comparison for this.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22648) Snapshot TTL
[
https://issues.apache.org/jira/browse/HBASE-22648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889738#comment-16889738
]
HBase QA commented on HBASE-22648:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
26s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
27s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
17s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 7m
26s{color} | {color:blue} branch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
27s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 8m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
17s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
13s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
7s{color} | {color:red} The patch generated 3 new + 273 unchanged - 1 fixed =
276 total (was 274) {color} |
| {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green} 0m
1s{color} | {color:green} There were no new ruby-lint issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 7m
18s{color} | {color:blue} patch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
32s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
12m 15s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
6m 21s{color} | {color:green} the patch passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 9m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{c
[jira] [Commented] (HBASE-22718) Remove org.apache.hadoop.hbase.util.Counter
[
https://issues.apache.org/jira/browse/HBASE-22718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889737#comment-16889737
]
HBase QA commented on HBASE-22718:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
35s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
28s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
23s{color} | {color:green} hbase-common: The patch generated 0 new + 0
unchanged - 2 fixed = 0 total (was 2) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
44s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
12m 42s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
54s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 44m 21s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=18.09.8 Server=18.09.8 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/658/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22718 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12975347/HBASE-22718-master.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 4aaee5c8dd7b 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24
10:58:50 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 00075ea4fc |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/658/testReport/ |
| Max. process+thread count | 287 (vs. ulimit of 1) |
| modules | C: hbase-common U: hbase-common |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/658/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
Thi
[GitHub] [hbase] Apache-HBase commented on issue #396: HBASE-22718 : Removal of org.apache.hadoop.hbase.util.Counter
Apache-HBase commented on issue #396: HBASE-22718 : Removal of org.apache.hadoop.hbase.util.Counter URL: https://github.com/apache/hbase/pull/396#issuecomment-513555197 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 146 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 275 | master passed | | +1 | compile | 22 | master passed | | +1 | checkstyle | 24 | master passed | | +1 | shadedjars | 262 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 40 | master passed | | +1 | javadoc | 20 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 239 | the patch passed | | +1 | compile | 22 | the patch passed | | +1 | javac | 22 | the patch passed | | +1 | checkstyle | 23 | hbase-common: The patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 278 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 785 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | findbugs | 47 | the patch passed | | +1 | javadoc | 19 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 173 | hbase-common in the patch passed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 2711 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-396/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/396 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 86d5c168f002 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 00075ea4fc | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-396/1/testReport/ | | Max. process+thread count | 289 (vs. ulimit of 1) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-396/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 opened a new pull request #397: HBASE-22676 Move all the code in hbase-rsgroup to hbase-server and re…
Apache9 opened a new pull request #397: HBASE-22676 Move all the code in hbase-rsgroup to hbase-server and re… URL: https://github.com/apache/hbase/pull/397 …move hbase-rsgroup module This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22676) Move all the code in hbase-rsgroup to hbase-server and remove hbase-rsgroup repo
[ https://issues.apache.org/jira/browse/HBASE-22676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22676: -- Summary: Move all the code in hbase-rsgroup to hbase-server and remove hbase-rsgroup repo (was: Move all code in hbase-rsgroup to hbase-server and remove hbase-rsgroup repo) > Move all the code in hbase-rsgroup to hbase-server and remove hbase-rsgroup > repo > > > Key: HBASE-22676 > URL: https://issues.apache.org/jira/browse/HBASE-22676 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Priority: Major > > Let's do this first and then try to refactor it. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22676) Move all the code in hbase-rsgroup to hbase-server and remove hbase-rsgroup module
[ https://issues.apache.org/jira/browse/HBASE-22676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22676: -- Summary: Move all the code in hbase-rsgroup to hbase-server and remove hbase-rsgroup module (was: Move all the code in hbase-rsgroup to hbase-server and remove hbase-rsgroup repo) > Move all the code in hbase-rsgroup to hbase-server and remove hbase-rsgroup > module > -- > > Key: HBASE-22676 > URL: https://issues.apache.org/jira/browse/HBASE-22676 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Priority: Major > > Let's do this first and then try to refactor it. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22718) Remove org.apache.hadoop.hbase.util.Counter
[ https://issues.apache.org/jira/browse/HBASE-22718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22718: - Fix Version/s: 3.0.0 Attachment: HBASE-22718-master.patch Status: Patch Available (was: In Progress) > Remove org.apache.hadoop.hbase.util.Counter > --- > > Key: HBASE-22718 > URL: https://issues.apache.org/jira/browse/HBASE-22718 > Project: HBase > Issue Type: Task >Affects Versions: 3.0.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-22718-master.patch > > > With usages of LongAdder in place to replace > org.apache.hadoop.hbase.util.Counter, we can safely remove Counter and > associated unit tests -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work started] (HBASE-22718) Remove org.apache.hadoop.hbase.util.Counter
[ https://issues.apache.org/jira/browse/HBASE-22718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-22718 started by Viraj Jasani. > Remove org.apache.hadoop.hbase.util.Counter > --- > > Key: HBASE-22718 > URL: https://issues.apache.org/jira/browse/HBASE-22718 > Project: HBase > Issue Type: Task >Affects Versions: 3.0.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > > With usages of LongAdder in place to replace > org.apache.hadoop.hbase.util.Counter, we can safely remove Counter and > associated unit tests -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] virajjasani opened a new pull request #396: HBASE-22718 : Removal of org.apache.hadoop.hbase.util.Counter
virajjasani opened a new pull request #396: HBASE-22718 : Removal of org.apache.hadoop.hbase.util.Counter URL: https://github.com/apache/hbase/pull/396 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-22718) Remove org.apache.hadoop.hbase.util.Counter
Viraj Jasani created HBASE-22718: Summary: Remove org.apache.hadoop.hbase.util.Counter Key: HBASE-22718 URL: https://issues.apache.org/jira/browse/HBASE-22718 Project: HBase Issue Type: Task Affects Versions: 3.0.0 Reporter: Viraj Jasani Assignee: Viraj Jasani With usages of LongAdder in place to replace org.apache.hadoop.hbase.util.Counter, we can safely remove Counter and associated unit tests -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22676) Move all code in hbase-rsgroup to hbase-server and remove hbase-rsgroup repo
[ https://issues.apache.org/jira/browse/HBASE-22676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22676: -- Summary: Move all code in hbase-rsgroup to hbase-server and remove hbase-rsgroup repo (was: Move RSGroupLoadBalancer to hbase-server) > Move all code in hbase-rsgroup to hbase-server and remove hbase-rsgroup repo > > > Key: HBASE-22676 > URL: https://issues.apache.org/jira/browse/HBASE-22676 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Priority: Major > > And the make it the only top level balancer. The customized balancer will be > used inside each rs group. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22676) Move all code in hbase-rsgroup to hbase-server and remove hbase-rsgroup repo
[ https://issues.apache.org/jira/browse/HBASE-22676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22676: -- Description: Let's do this first and then try to refactor it. (was: And the make it the only top level balancer. The customized balancer will be used inside each rs group.) > Move all code in hbase-rsgroup to hbase-server and remove hbase-rsgroup repo > > > Key: HBASE-22676 > URL: https://issues.apache.org/jira/browse/HBASE-22676 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Priority: Major > > Let's do this first and then try to refactor it. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22648) Snapshot TTL
[ https://issues.apache.org/jira/browse/HBASE-22648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22648: - Attachment: HBASE-22648-master-v8.patch > Snapshot TTL > > > Key: HBASE-22648 > URL: https://issues.apache.org/jira/browse/HBASE-22648 > Project: HBase > Issue Type: New Feature > Components: snapshots >Affects Versions: 3.0.0 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-22648-master-v2.patch, > HBASE-22648-master-v3.patch, HBASE-22648-master-v4.patch, > HBASE-22648-master-v5.patch, HBASE-22648-master-v6.patch, > HBASE-22648-master-v8.patch, HBASE-22648-master.patch, Screen Shot 2019-07-10 > at 8.49.13 PM.png, Screen Shot 2019-07-10 at 8.52.30 PM.png, Screen Shot > 2019-07-10 at 9.06.36 PM.png, Screen Shot 2019-07-16 at 11.06.03 AM.png > > > Snapshots have a lifecycle that is independent from the table from which they > are created. Although data in a table may be stored with TTL the data files > containing them become frozen by the snapshot. Space consumed by expired > cells will not be reclaimed by normal table housekeeping like compaction. > While this is expected it can be inconvenient at scale. When many snapshots > are under management and the data in various tables is expired by TTL some > notion of optional TTL (and optional default TTL) for snapshots could be > useful. It will help prevent the accumulation of junk files by automatically > dropping the snapshot after the assigned TTL, making their data files > eligible for cleaning. More comprehensive snapshot lifecycle management may > be considered in the future but this one case is expected to be immediately > useful given TTls on data are commonly applied for similar convenience. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22648) Snapshot TTL
[ https://issues.apache.org/jira/browse/HBASE-22648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22648: - Attachment: (was: HBASE-22648-master-v7.patch) > Snapshot TTL > > > Key: HBASE-22648 > URL: https://issues.apache.org/jira/browse/HBASE-22648 > Project: HBase > Issue Type: New Feature > Components: snapshots >Affects Versions: 3.0.0 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-22648-master-v2.patch, > HBASE-22648-master-v3.patch, HBASE-22648-master-v4.patch, > HBASE-22648-master-v5.patch, HBASE-22648-master-v6.patch, > HBASE-22648-master.patch, Screen Shot 2019-07-10 at 8.49.13 PM.png, Screen > Shot 2019-07-10 at 8.52.30 PM.png, Screen Shot 2019-07-10 at 9.06.36 PM.png, > Screen Shot 2019-07-16 at 11.06.03 AM.png > > > Snapshots have a lifecycle that is independent from the table from which they > are created. Although data in a table may be stored with TTL the data files > containing them become frozen by the snapshot. Space consumed by expired > cells will not be reclaimed by normal table housekeeping like compaction. > While this is expected it can be inconvenient at scale. When many snapshots > are under management and the data in various tables is expired by TTL some > notion of optional TTL (and optional default TTL) for snapshots could be > useful. It will help prevent the accumulation of junk files by automatically > dropping the snapshot after the assigned TTL, making their data files > eligible for cleaning. More comprehensive snapshot lifecycle management may > be considered in the future but this one case is expected to be immediately > useful given TTls on data are commonly applied for similar convenience. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22710) Wrong result in one case of scan that use raw and versions and filter together
[
https://issues.apache.org/jira/browse/HBASE-22710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889691#comment-16889691
]
Zheng Wang commented on HBASE-22710:
No probelm.
> Wrong result in one case of scan that use raw and versions and filter
> together
> ---
>
> Key: HBASE-22710
> URL: https://issues.apache.org/jira/browse/HBASE-22710
> Project: HBase
> Issue Type: Bug
> Components: Scanners
>Affects Versions: 2.0.0
>Reporter: Zheng Wang
>Assignee: Zheng Hu
>Priority: Major
>
> create 'testScanRaw',\{NAME => 'f', VERSIONS => 1}
>
> put 'testScanRaw','r1','f:q','1'
> put 'testScanRaw','r1','f:q','2'
> put 'testScanRaw','r1','f:q','3'
>
> hbase(main):005:0> scan 'testScanRaw',\{RAW => true, STARTROW => 'r1',
> STOPROW=>'r1',VERSIONS=>2}
> ROW COLUMN+CELL
> r1 column=f:q, timestamp=1563430154757, value=3
> r1 column=f:q, timestamp=1563430153120, value=2
>
> hbase(main):006:0> scan 'testScanRaw',\{RAW => true, STARTROW => 'r1',
> STOPROW=>'r1',VERSIONS=>2,FILTER => "(QualifierFilter (=, 'binary:q'))"}
> ROW COLUMN+CELL
> r1 column=f:q, timestamp=1563430154757, value=3
>
> BTW,the result is right in hbase1.2.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase
[
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889687#comment-16889687
]
Hudson commented on HBASE-22514:
Results for branch HBASE-22514
[build #21 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/21/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/21//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/21//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/21//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
> Issue Type: Umbrella
> Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch,
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public
> we need to use java api RSGroupAdminClient to manager RSG
> so RSGroupAdminClient should be public
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
