[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-517141893 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 79 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 26 | Maven dependency ordering for branch | | +1 | mvninstall | 313 | master passed | | +1 | compile | 89 | master passed | | +1 | checkstyle | 118 | master passed | | +1 | shadedjars | 277 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 57 | master passed | | 0 | spotbugs | 283 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 361 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 310 | the patch passed | | +1 | compile | 80 | the patch passed | | +1 | javac | 80 | the patch passed | | +1 | checkstyle | 112 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 270 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 995 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 70 | the patch passed | | +1 | findbugs | 362 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 110 | hbase-client in the patch passed. | | +1 | unit | 12843 | hbase-server in the patch passed. | | +1 | asflicense | 49 | The patch does not generate ASF License warnings. | | | | 16959 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/55/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 741802692b5c 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / 8cfc46d8d0 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/55/testReport/ | | Max. process+thread count | 4682 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/55/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master)
Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master) URL: https://github.com/apache/hbase/pull/428#issuecomment-517141247 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 76 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 329 | master passed | | +1 | compile | 56 | master passed | | +1 | checkstyle | 87 | master passed | | +1 | shadedjars | 306 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 40 | master passed | | 0 | spotbugs | 254 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 251 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 341 | the patch passed | | +1 | compile | 59 | the patch passed | | +1 | javac | 59 | the patch passed | | +1 | checkstyle | 87 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 306 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1096 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 35 | the patch passed | | +1 | findbugs | 259 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 13084 | hbase-server in the patch passed. | | +1 | asflicense | 26 | The patch does not generate ASF License warnings. | | | | 16859 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/17/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/428 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3ae1e4667567 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh | | git revision | master / 8cfc46d8d0 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/17/testReport/ | | Max. process+thread count | 4363 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/17/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-20821) Re-creating a dropped namespace and contained table inherits previously set space quota settings
[
https://issues.apache.org/jira/browse/HBASE-20821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897803#comment-16897803
]
Shardul Singh commented on HBASE-20821:
---
hi [~elserj]..can you please check this patch..been a long time i
submitted..thanks :)
> Re-creating a dropped namespace and contained table inherits previously set
> space quota settings
>
>
> Key: HBASE-20821
> URL: https://issues.apache.org/jira/browse/HBASE-20821
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.1.0
>Reporter: Nihal Jain
>Assignee: Shardul Singh
>Priority: Major
> Labels: Quota, Space
> Fix For: 3.0.0, 2.1.0
>
> Attachments: HBASE-20821.master.v001patch,
> HBASE-20821.master.v002.patch, HBASE-20821.master.v003.patch
>
>
> As demonstarted in
> [HBASE-20662.master.002.patch|https://issues.apache.org/jira/secure/attachment/12927187/HBASE-20662.master.002.patch]
> re-creating a dropped namespace and contained table inherits previously set
> space quota settings.
> *Steps:*
> * Create a namespace and a table in it
> * Set space quota on namespace
> * Violate namespace quota
> * Drop table and then namespace
> * Re create same namespace and same table
> * Put data into the table (more than the previosuly set namespace quota
> limit)
> {code:java}
> private void setQuotaAndThenDropNamespace(final String namespace,
> SpaceViolationPolicy policy)
> throws Exception {
> Put put = new Put(Bytes.toBytes("to_reject"));
> put.addColumn(Bytes.toBytes(SpaceQuotaHelperForTests.F1),
> Bytes.toBytes("to"),
> Bytes.toBytes("reject"));
> createNamespaceIfNotExist(TEST_UTIL.getAdmin(), namespace);
> // Do puts until we violate space policy
> final TableName tn =
> writeUntilNSSpaceViolationAndVerifyViolation(namespace, policy, put);
> // Now, drop the table
> TEST_UTIL.deleteTable(tn);
> LOG.debug("Successfully deleted table ", tn);
> // Now, drop the namespace
> TEST_UTIL.getAdmin().deleteNamespace(namespace);
> LOG.debug("Successfully deleted the namespace ", namespace);
> // Now re-create the namespace
> createNamespaceIfNotExist(TEST_UTIL.getAdmin(), namespace);
> LOG.debug("Successfully re-created the namespace ", namespace);
> TEST_UTIL.createTable(tn, Bytes.toBytes(SpaceQuotaHelperForTests.F1));
> LOG.debug("Successfully re-created table ", tn);
> // Put some rows now: should not violate as namespace/quota was dropped
> verifyNoViolation(policy, tn, put);
> }
> {code}
> *Expected*: SpaceQuota settings should not exist on the newly re-created
> table and we should be able to put limit less data into the table
> *Actual:* We fail to put data into newly created table as SpaceQuota settings
> (systematically created due to previously added namespace space quota) exist
> on table
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #403: HBASE-22707 [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentMan
Apache-HBase commented on issue #403: HBASE-22707 [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentManager RegionsStateStore URL: https://github.com/apache/hbase/pull/403#issuecomment-517140278 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 102 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 26 | Maven dependency ordering for branch | | +1 | mvninstall | 324 | master passed | | +1 | compile | 89 | master passed | | +1 | checkstyle | 121 | master passed | | +1 | shadedjars | 333 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 59 | master passed | | 0 | spotbugs | 274 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 341 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 335 | the patch passed | | -1 | compile | 41 | hbase-server in the patch failed. | | -1 | javac | 41 | hbase-server in the patch failed. | | +1 | checkstyle | 124 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 305 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1044 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 55 | the patch passed | | +1 | findbugs | 339 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 104 | hbase-client in the patch passed. | | +1 | unit | 12401 | hbase-server in the patch passed. | | +1 | asflicense | 47 | The patch does not generate ASF License warnings. | | | | 16662 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/42/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/403 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c15c7446854f 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-403/out/precommit/personality/provided.sh | | git revision | master / 8cfc46d8d0 | | Default Java | 1.8.0_181 | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/42/artifact/out/patch-compile-hbase-server.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/42/artifact/out/patch-compile-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/42/testReport/ | | Max. process+thread count | 4343 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/42/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22642) Make move operations of RSGroup idempotent
[ https://issues.apache.org/jira/browse/HBASE-22642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897799#comment-16897799 ] Xiaolin Ha commented on HBASE-22642: Thanks [~xucang]! HadoopQA had +1. > Make move operations of RSGroup idempotent > -- > > Key: HBASE-22642 > URL: https://issues.apache.org/jira/browse/HBASE-22642 > Project: HBase > Issue Type: Bug > Components: rsgroup >Reporter: Xiaolin Ha >Assignee: Xiaolin Ha >Priority: Major > > Currently, when moving tables or servers to a group, only groupInfo is > checked. And in RSGroup implementation, groupinfo is written to disk before > regions movements are done. If there are some problems caused move regions > abort, some regions will be on wrong regionservers. What's the worse, retry > the move operation will be rejected because of the correct groupinfo. > We think when moving, not only groupInfo should be checked, but also relevant > region assignments should be checked and corrected. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache9 commented on a change in pull request #426: HBASE-22695 Store the rsgroup of a table in table configuration
Apache9 commented on a change in pull request #426: HBASE-22695 Store the
rsgroup of a table in table configuration
URL: https://github.com/apache/hbase/pull/426#discussion_r309534865
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfo.java
##
@@ -100,23 +117,46 @@ public boolean removeServer(Address hostPort) {
/**
* Get set of tables that are members of the group.
+ * @deprecated Since 3.0.0, will be removed in 4.0.0. The rsgroup
information will be stored in
+ * the configuration of a table so this will be removed.
*/
+ @Deprecated
public SortedSet getTables() {
return tables;
}
+ /**
+ * @deprecated Since 3.0.0, will be removed in 4.0.0. The rsgroup
information will be stored in
+ * the configuration of a table so this will be removed.
+ */
+ @Deprecated
public void addTable(TableName table) {
tables.add(table);
}
+ /**
+ * @deprecated Since 3.0.0, will be removed in 4.0.0. The rsgroup
information will be stored in
+ * the configuration of a table so this will be removed.
+ */
+ @Deprecated
public void addAllTables(Collection arg) {
tables.addAll(arg);
}
+ /**
+ * @deprecated Since 3.0.0, will be removed in 4.0.0. The rsgroup
information will be stored in
+ * the configuration of a table so this will be removed.
+ */
+ @Deprecated
public boolean containsTable(TableName table) {
Review comment:
Yes, I reimplemented the related methods. Please see
RSGroupAdminServer.moveRegionsBetweenGroups.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master)
Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master) URL: https://github.com/apache/hbase/pull/428#issuecomment-517131383 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 91 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 342 | master passed | | +1 | compile | 60 | master passed | | +1 | checkstyle | 90 | master passed | | +1 | shadedjars | 311 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 34 | master passed | | 0 | spotbugs | 283 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 282 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 327 | the patch passed | | +1 | compile | 58 | the patch passed | | +1 | javac | 58 | the patch passed | | +1 | checkstyle | 86 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 297 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1086 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 37 | the patch passed | | +1 | findbugs | 299 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 13563 | hbase-server in the patch failed. | | +1 | asflicense | 26 | The patch does not generate ASF License warnings. | | | | 17442 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.balancer.TestStochasticLoadBalancerRegionReplicaSameHosts | | | hadoop.hbase.master.TestMasterRepairMode | | | hadoop.hbase.master.TestSplitRegionWhileRSCrash | | | hadoop.hbase.master.TestMasterNotCarryTable | | | hadoop.hbase.master.TestDLSFSHLog | | | hadoop.hbase.master.balancer.TestBalancerStatusTagInJMXMetrics | | | hadoop.hbase.master.balancer.TestFavoredNodeTableImport | | | hadoop.hbase.master.TestCloseAnOpeningRegion | | | hadoop.hbase.master.procedure.TestSCPWithMetaWithReplicasWithoutZKCoordinated | | | hadoop.hbase.master.procedure.TestCloneSnapshotProcedure | | | hadoop.hbase.master.balancer.TestRegionLocationFinder | | | hadoop.hbase.master.procedure.TestSCPWithoutMeta | | | hadoop.hbase.master.procedure.TestEnableTableProcedure | | | hadoop.hbase.TestJMXListener | | | hadoop.hbase.master.procedure.TestMasterProcedureSchedulerConcurrency | | | hadoop.hbase.replication.regionserver.TestDrainReplicationQueuesForStandBy | | | hadoop.hbase.master.TestLoadProcedureError | | | hadoop.hbase.tool.TestCanaryTool | | | hadoop.hbase.master.TestMasterMetricsWrapper | | | hadoop.hbase.master.procedure.TestCreateNamespaceProcedure | | | hadoop.hbase.master.procedure.TestMasterObserverPostCalls | | | hadoop.hbase.master.procedure.TestDisableTableProcedure | | | hadoop.hbase.master.TestClusterRestartSplitWithoutZk | | | hadoop.hbase.TestLocalHBaseCluster | | | hadoop.hbase.master.TestMigrateNamespaceTable | | | hadoop.hbase.master.TestMergeTableRegionsWhileRSCrash | | | hadoop.hbase.master.procedure.TestIgnoreUnknownFamily | | | hadoop.hbase.master.procedure.TestModifyTableProcedure | | | hadoop.hbase.master.procedure.TestSCPWithoutMetaWithReplicas | | | hadoop.hbase.replication.regionserver.TestSyncReplicationShipperQuit | | | hadoop.hbase.master.assignment.TestRegionBypass | | | hadoop.hbase.master.TestRetainAssignmentOnRestartSplitWithoutZk | | | hadoop.hbase.master.procedure.TestProcedurePriority | | | hadoop.hbase.replication.TestReplicationDroppedTables | | | hadoop.hbase.master.procedure.TestReopenTableRegionsProcedureBackoff | | | hadoop.hbase.replication.regionserver.TestReplicator | | | hadoop.hbase.master.TestServerCrashProcedureCarryingMetaStuck | | | hadoop.hbase.master.procedure.TestSCPWithMeta | | | hadoop.hbase.tool.TestBulkLoadHFiles | | | hadoop.hbase.master.balancer.TestFavoredStochasticBalancerPickers | | | hadoop.hbase.master.procedure.TestDeleteTableProcedure | | | hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-Gi
[jira] [Commented] (HBASE-22765) add move server & move table command in shell
[
https://issues.apache.org/jira/browse/HBASE-22765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897789#comment-16897789
]
Anoop Sam John commented on HBASE-22765:
Ye seems the RS Group feature can do what u wanted.
> add move server & move table command in shell
> --
>
> Key: HBASE-22765
> URL: https://issues.apache.org/jira/browse/HBASE-22765
> Project: HBase
> Issue Type: Improvement
>Reporter: Junhong Xu
>Assignee: Junhong Xu
>Priority: Major
>
> We add move_server and move_table command in shell internally to fix problems
> like restarting the regionserver etc and find it is very useful, so plan to
> port to branch-2 & branch-1
> {code}
> hbase(main):001:0> move_server
> ERROR: wrong number of arguments (0 for 1)
> Here is some help for this command:
> Move all regions of the source server to a given target server, or randomly to
> other servers if no target server specified
> NOTE:
> A server name is its host, port plus startcode. For example:
> host187.example.com,60020,1289493121758
> Examples:
> hbase> move_server 'SOURCE_SEREVR', 'TARGET_SERVER'
> hbase> move_server 'SOURCE_SERVER'
> hbase(main):002:0> move_table
> ERROR: wrong number of arguments (0 for 1)
> Here is some help for this command:
> Move all regions of the table to a regionserver. All regions will be moved to
> the
> given regionserver if the 'SERVER_NAME' is specified, or to a random
> regionserver if
> 'SERVER_NAME' is absent
> NOTE:
> A server name is its host, port plus startcode. For example:
> host187.example.com,60020,1289493121758
> Examples:
> hbase> move_table 'TABLENAME', 'SERVER_NAME'
> hbase> move_table 'TABLENAME'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #426: HBASE-22695 Store the rsgroup of a table in table configuration
Apache-HBase commented on issue #426: HBASE-22695 Store the rsgroup of a table in table configuration URL: https://github.com/apache/hbase/pull/426#issuecomment-517123569 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 67 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 10 new or modified test files. | ||| _ HBASE-22514 Compile Tests _ | | 0 | mvndep | 22 | Maven dependency ordering for branch | | +1 | mvninstall | 319 | HBASE-22514 passed | | +1 | compile | 111 | HBASE-22514 passed | | +1 | checkstyle | 151 | HBASE-22514 passed | | +1 | shadedjars | 298 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 77 | HBASE-22514 passed | | 0 | spotbugs | 277 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 385 | HBASE-22514 passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 321 | the patch passed | | +1 | compile | 101 | the patch passed | | +1 | javac | 101 | the patch passed | | +1 | checkstyle | 25 | The patch passed checkstyle in hbase-common | | +1 | checkstyle | 34 | The patch passed checkstyle in hbase-client | | +1 | checkstyle | 92 | hbase-server: The patch generated 0 new + 136 unchanged - 15 fixed = 136 total (was 151) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 297 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1022 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 76 | the patch passed | | +1 | findbugs | 412 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 172 | hbase-common in the patch passed. | | +1 | unit | 104 | hbase-client in the patch passed. | | -1 | unit | 13070 | hbase-server in the patch failed. | | +1 | asflicense | 70 | The patch does not generate ASF License warnings. | | | | 17672 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.rsgroup.TestRSGroupsKillRS | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/7/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/426 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux ea70ac98f92b 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-426/out/precommit/personality/provided.sh | | git revision | HBASE-22514 / 1b5f6b5a48 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/7/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/7/testReport/ | | Max. process+thread count | 4510 (vs. ulimit of 1) | | modules | C: hbase-common hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/7/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22761) Caught ArrayIndexOutOfBoundsException while processing event RS_LOG_REPLAY
[
https://issues.apache.org/jira/browse/HBASE-22761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897761#comment-16897761
]
casuallc commented on HBASE-22761:
--
[~wchevreuil] i will deploy [this
version|[https://github.com/wchevreuil/hbase/tree/HBASE-22539],] thanks.
> Caught ArrayIndexOutOfBoundsException while processing event RS_LOG_REPLAY
> --
>
> Key: HBASE-22761
> URL: https://issues.apache.org/jira/browse/HBASE-22761
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.1.1
>Reporter: casuallc
>Priority: Major
> Attachments: tmp
>
>
> RegionServer exists when error happen
> {code:java}
> 2019-07-29 20:51:09,726 INFO [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> wal.WALSplitter: Processed 0 edits across 0 regions; edits skipped=0; log
> file=hdfs://cluster1/hbase/WALs/h2,16020,1564216856546-splitting/h2%2C16020%2C1564216856546.1564398538121,
> length=615233, corrupted=false, progress failed=false
> 2019-07-29 20:51:09,726 INFO [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> handler.WALSplitterHandler: Worker h1,16020,1564404572589 done with task
> org.apache.hadoop.hbase.coordination.ZkSplitLogWorkerCoordination$ZkSplitTaskDetails@577da0d3
> in 84892ms. Status = null
> 2019-07-29 20:51:09,726 ERROR [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> executor.EventHandler: Caught throwable while processing event RS_LOG_REPLAY
> java.lang.ArrayIndexOutOfBoundsException: 16403
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1365)
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1358)
> at
> org.apache.hadoop.hbase.PrivateCellUtil.matchingFamily(PrivateCellUtil.java:735)
> at org.apache.hadoop.hbase.CellUtil.matchingFamily(CellUtil.java:816)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEditFamily(WALEdit.java:143)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEdit(WALEdit.java:148)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:297)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:195)
> at
> org.apache.hadoop.hbase.regionserver.SplitLogWorker$1.exec(SplitLogWorker.java:100)
> at
> org.apache.hadoop.hbase.regionserver.handler.WALSplitterHandler.process(WALSplitterHandler.java:70)
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> 2019-07-29 20:51:09,730 ERROR [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> regionserver.HRegionServer: * ABORTING region server
> h1,16020,1564404572589: Caught throwable while processing event RS_LOG_REPLAY
> *
> java.lang.ArrayIndexOutOfBoundsException: 16403
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1365)
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1358)
> at
> org.apache.hadoop.hbase.PrivateCellUtil.matchingFamily(PrivateCellUtil.java:735)
> at org.apache.hadoop.hbase.CellUtil.matchingFamily(CellUtil.java:816)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEditFamily(WALEdit.java:143)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEdit(WALEdit.java:148)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:297)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:195)
> at
> org.apache.hadoop.hbase.regionserver.SplitLogWorker$1.exec(SplitLogWorker.java:100)
> at
> org.apache.hadoop.hbase.regionserver.handler.WALSplitterHandler.process(WALSplitterHandler.java:70)
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22739) ArrayIndexOutOfBoundsException when balance
[
https://issues.apache.org/jira/browse/HBASE-22739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897759#comment-16897759
]
casuallc commented on HBASE-22739:
--
[~reidchan] not return regions is to avoid other places reuse the array and
change it.
i did not enable rsgroup feature.
RS exists where this error happen, so i think is better to check if removed
region in regions.
> ArrayIndexOutOfBoundsException when balance
> ---
>
> Key: HBASE-22739
> URL: https://issues.apache.org/jira/browse/HBASE-22739
> Project: HBase
> Issue Type: Bug
> Components: Balancer
>Reporter: casuallc
>Priority: Major
> Fix For: 2.1.1
>
>
>
> {code:java}
> 2019-07-25 15:19:59,828 ERROR [master/nna:16000.Chore.1]
> hbase.ScheduledChore: Caught error
> java.lang.ArrayIndexOutOfBoundsException: 3171
> at
> org.apache.hadoop.hbase.master.balancer.BaseLoadBalancer$Cluster.removeRegion(BaseLoadBalancer.java:873)
> at
> org.apache.hadoop.hbase.master.balancer.BaseLoadBalancer$Cluster.doAction(BaseLoadBalancer.java:716)
> at
> org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer.balanceCluster(StochasticLoadBalancer.java:407)
> at
> org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer.balanceCluster(StochasticLoadBalancer.java:318)
> at org.apache.hadoop.hbase.master.HMaster.balance(HMaster.java:1650)
> at org.apache.hadoop.hbase.master.HMaster.balance(HMaster.java:1567)
> at
> org.apache.hadoop.hbase.master.balancer.BalancerChore.chore(BalancerChore.java:49)
> at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:186)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> org.apache.hadoop.hbase.JitterScheduledThreadPoolExecutorImpl$JitteredRunnableScheduledFuture.run(JitterScheduledThreadPoolExecutorImpl.java:111)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
> should check if the regionIndex is valid when removeRegion,
> java:
> hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
> {code:java}
> int[] removeRegion(int[] regions, int regionIndex) {
> //TODO: this maybe costly. Consider using linked lists
> int[] newRegions = new int[regions.length - 1];
> int i = 0;
> for (i = 0; i < regions.length; i++) {
> if (regions[i] == regionIndex) {
> break;
> }
> if (i == regions.length - 1) {
> return Arrays.copyOf(regions, regions.length);
> }
> newRegions[i] = regions[i];
> }
> System.arraycopy(regions, i+1, newRegions, i, newRegions.length - i);
> return newRegions;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-517114298 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 45 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 298 | master passed | | +1 | compile | 56 | master passed | | +1 | checkstyle | 83 | master passed | | +1 | shadedjars | 276 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 35 | master passed | | 0 | spotbugs | 241 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 239 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 302 | the patch passed | | +1 | compile | 56 | the patch passed | | +1 | javac | 56 | the patch passed | | -1 | checkstyle | 80 | hbase-server: The patch generated 1 new + 375 unchanged - 0 fixed = 376 total (was 375) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 281 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 918 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 | javadoc | 35 | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | findbugs | 224 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 8928 | hbase-server in the patch failed. | | +1 | asflicense | 24 | The patch does not generate ASF License warnings. | | | | 12253 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.quotas.TestQuotaAdmin | | | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/20/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/390 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 15e0a2d46f01 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-390/out/precommit/personality/provided.sh | | git revision | master / 35acf3cb78 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/20/artifact/out/diff-checkstyle-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/20/artifact/out/diff-javadoc-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/20/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/20/testReport/ | | Max. process+thread count | 5428 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/20/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-517113676 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 142 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 374 | master passed | | +1 | compile | 27 | master passed | | +1 | checkstyle | 14 | master passed | | +1 | shadedjars | 341 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 23 | master passed | | 0 | spotbugs | 57 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 54 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 424 | the patch passed | | +1 | compile | 31 | the patch passed | | +1 | javac | 31 | the patch passed | | +1 | checkstyle | 15 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 363 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1209 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 27 | the patch passed | | +1 | findbugs | 69 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 618 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 4235 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/45/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 337cfeda996b 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / 8cfc46d8d0 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/45/testReport/ | | Max. process+thread count | 4405 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/45/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #403: HBASE-22707 [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentMan
Apache-HBase commented on issue #403: HBASE-22707 [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentManager RegionsStateStore URL: https://github.com/apache/hbase/pull/403#issuecomment-517113003 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 45 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 23 | Maven dependency ordering for branch | | +1 | mvninstall | 284 | master passed | | +1 | compile | 78 | master passed | | +1 | checkstyle | 104 | master passed | | +1 | shadedjars | 266 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 57 | master passed | | 0 | spotbugs | 231 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 295 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 293 | the patch passed | | +1 | compile | 76 | the patch passed | | +1 | javac | 76 | the patch passed | | +1 | checkstyle | 106 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 270 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 912 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 56 | the patch passed | | +1 | findbugs | 318 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 108 | hbase-client in the patch passed. | | +1 | unit | 8045 | hbase-server in the patch passed. | | +1 | asflicense | 59 | The patch does not generate ASF License warnings. | | | | 11804 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/41/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/403 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f23bca26cd33 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-403/out/precommit/personality/provided.sh | | git revision | master / 35acf3cb78 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/41/testReport/ | | Max. process+thread count | 4918 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/41/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-517112811 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 39 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 22 | Maven dependency ordering for branch | | +1 | mvninstall | 283 | master passed | | +1 | compile | 76 | master passed | | +1 | checkstyle | 100 | master passed | | +1 | shadedjars | 256 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 53 | master passed | | 0 | spotbugs | 230 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 294 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 284 | the patch passed | | +1 | compile | 78 | the patch passed | | +1 | javac | 78 | the patch passed | | +1 | checkstyle | 95 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 253 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 868 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 54 | the patch passed | | +1 | findbugs | 312 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 99 | hbase-client in the patch passed. | | -1 | unit | 8131 | hbase-server in the patch failed. | | +1 | asflicense | 60 | The patch does not generate ASF License warnings. | | | | 11735 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.assignment.TestOpenRegionProcedureHang | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/54/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 059ccdf9ec45 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / 35acf3cb78 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/54/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/54/testReport/ | | Max. process+thread count | 4763 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/54/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator
Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-517106875 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 124 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 342 | branch-2.1 passed | | +1 | compile | 29 | branch-2.1 passed | | +1 | checkstyle | 43 | branch-2.1 passed | | +1 | shadedjars | 290 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 25 | branch-2.1 passed | | 0 | spotbugs | 84 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 81 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 365 | the patch passed | | +1 | compile | 29 | the patch passed | | +1 | javac | 29 | the patch passed | | +1 | checkstyle | 41 | hbase-client: The patch generated 0 new + 58 unchanged - 4 fixed = 58 total (was 62) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 287 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1291 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 23 | the patch passed | | +1 | findbugs | 78 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 201 | hbase-client in the patch passed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 3648 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/31/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/343 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 43f2031016e0 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh | | git revision | branch-2.1 / e68b16a6c1 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/31/testReport/ | | Max. process+thread count | 264 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/31/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-517098047 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 105 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 351 | master passed | | +1 | compile | 26 | master passed | | +1 | checkstyle | 13 | master passed | | +1 | shadedjars | 334 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 21 | master passed | | 0 | spotbugs | 51 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 48 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 340 | the patch passed | | +1 | compile | 29 | the patch passed | | +1 | javac | 29 | the patch passed | | +1 | checkstyle | 14 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 319 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1029 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 20 | the patch passed | | +1 | findbugs | 57 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 496 | hbase-rsgroup in the patch failed. | | +1 | asflicense | 10 | The patch does not generate ASF License warnings. | | | | 3617 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.rsgroup.TestRSGroupsWithACL | | | hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancerWithStochasticLoadBalancerAsInternal | | | hadoop.hbase.rsgroup.TestRSGroupsBasics | | | hadoop.hbase.rsgroup.TestEnableRSGroups | | | hadoop.hbase.rsgroup.TestRSGroupsAdmin2 | | | hadoop.hbase.rsgroup.TestRSGroupsKillRS | | | hadoop.hbase.rsgroup.TestRSGroupsOfflineMode | | | hadoop.hbase.rsgroup.TestRSGroupsAdmin1 | | | hadoop.hbase.rsgroup.TestRSGroupMajorCompactionTTL | | | hadoop.hbase.rsgroup.TestRSGroupsBalance | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/44/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b3e47b286a2e 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / 8cfc46d8d0 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/44/artifact/out/patch-unit-hbase-rsgroup.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/44/testReport/ | | Max. process+thread count | 3203 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/44/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] sunhelly edited a comment on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
sunhelly edited a comment on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-517097771 @xcangCRM I looked through all the failed reports, mostly failed by `NoClassDefFoundError`, and the `NullPointerException` was not a real failure, it's threw by case `testFailedMoveServersTablesAndRepair` but running case is `testFailedMoveBeforeRetryExhaustedWhenMoveTable`.(https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/41/testReport/org.apache.hadoop.hbase.rsgroup/TestRSGroupsAdmin2/testFailedMoveServersTablesAndRepair/) I think there is something wrong of the compiled running codes or in the test platform, such as yetus. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] sunhelly edited a comment on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
sunhelly edited a comment on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-517097771 @xcangCRM I looked through all the failed reports, mostly failed by NoClassDefFoundError, and the NullPointerException was not a real failure, it's threw by case testFailedMoveServersTablesAndRepair but running case is testFailedMoveBeforeRetryExhaustedWhenMoveTable.(https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/41/testReport/org.apache.hadoop.hbase.rsgroup/TestRSGroupsAdmin2/testFailedMoveServersTablesAndRepair/) I think there is something wrong of the compiled running codes or in the test platform, such as yetus. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] sunhelly commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
sunhelly commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-517097771 @xcangCRM I looked through all the failed reports, mostly failed by NoClassDefFoundError, and the NullPointerException was not a real failure, it's threw by case A but running case is B().(https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/41/testReport/org.apache.hadoop.hbase.rsgroup/TestRSGroupsAdmin2/testFailedMoveServersTablesAndRepair/) I think there is something wrong of the compiled running codes or in the test platform, such as yetus. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes
Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes URL: https://github.com/apache/hbase/pull/374#issuecomment-517097228 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 184 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 345 | master passed | | +1 | compile | 22 | master passed | | +1 | checkstyle | 25 | master passed | | +1 | shadedjars | 299 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 20 | master passed | | 0 | spotbugs | 47 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 46 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 298 | the patch passed | | +1 | compile | 24 | the patch passed | | +1 | javac | 24 | the patch passed | | -1 | checkstyle | 26 | hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 296 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1031 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 20 | the patch passed | | +1 | findbugs | 55 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 183 | hbase-common in the patch passed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 3298 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/46/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/374 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 34d821b2c872 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh | | git revision | master / 8cfc46d8d0 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/46/artifact/out/diff-checkstyle-hbase-common.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/46/testReport/ | | Max. process+thread count | 291 (vs. ulimit of 1) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/46/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator
Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-517097062 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 80 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 281 | branch-2.1 passed | | +1 | compile | 26 | branch-2.1 passed | | +1 | checkstyle | 35 | branch-2.1 passed | | +1 | shadedjars | 239 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 25 | branch-2.1 passed | | 0 | spotbugs | 71 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 70 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 284 | the patch passed | | +1 | compile | 25 | the patch passed | | +1 | javac | 25 | the patch passed | | +1 | checkstyle | 33 | hbase-client: The patch generated 0 new + 58 unchanged - 4 fixed = 58 total (was 62) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 235 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1171 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 21 | the patch passed | | +1 | findbugs | 78 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 194 | hbase-client in the patch passed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 3160 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/30/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/343 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9b4c3a5e0a52 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh | | git revision | branch-2.1 / 52f8ec8924 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/30/testReport/ | | Max. process+thread count | 296 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/30/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-517094326 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 67 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 421 | master passed | | +1 | compile | 75 | master passed | | +1 | checkstyle | 105 | master passed | | +1 | shadedjars | 362 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 45 | master passed | | 0 | spotbugs | 339 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 336 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 407 | the patch passed | | +1 | compile | 71 | the patch passed | | +1 | javac | 71 | the patch passed | | -1 | checkstyle | 96 | hbase-server: The patch generated 1 new + 375 unchanged - 0 fixed = 376 total (was 375) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 367 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1214 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 | javadoc | 44 | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | findbugs | 337 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 15976 | hbase-server in the patch failed. | | +1 | asflicense | 31 | The patch does not generate ASF License warnings. | | | | 20445 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/19/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/390 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f59c4979cdbd 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-390/out/precommit/personality/provided.sh | | git revision | master / 4829c18251 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/19/artifact/out/diff-checkstyle-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/19/artifact/out/diff-javadoc-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/19/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/19/testReport/ | | Max. process+thread count | 4604 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/19/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #434: HBASE-22609 [Docs] More detail documentation about...
Apache-HBase commented on issue #434: HBASE-22609 [Docs] More detail documentation about... URL: https://github.com/apache/hbase/pull/434#issuecomment-517091808 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 78 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 | mvninstall | 340 | master passed | | 0 | refguide | 384 | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 328 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | 0 | refguide | 368 | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Other Tests _ | | +1 | asflicense | 15 | The patch does not generate ASF License warnings. | | | | 1571 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/8/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/434 | | Optional Tests | dupname asflicense refguide | | uname | Linux cc7b2da79e58 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-434/out/precommit/personality/provided.sh | | git revision | master / 8cfc46d8d0 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/8/artifact/out/branch-site/book.html | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/8/artifact/out/patch-site/book.html | | Max. process+thread count | 86 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/8/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-517089662 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 113 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 384 | master passed | | +1 | compile | 26 | master passed | | +1 | checkstyle | 15 | master passed | | +1 | shadedjars | 319 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 21 | master passed | | 0 | spotbugs | 49 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 47 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 329 | the patch passed | | +1 | compile | 25 | the patch passed | | +1 | javac | 25 | the patch passed | | +1 | checkstyle | 12 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 293 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 998 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 19 | the patch passed | | +1 | findbugs | 51 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 825 | hbase-rsgroup in the patch failed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 3888 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.rsgroup.TestRSGroupsKillRS | | | hadoop.hbase.rsgroup.TestRSGroupMajorCompactionTTL | | | hadoop.hbase.rsgroup.TestRSGroupsAdmin1 | | | hadoop.hbase.rsgroup.TestRSGroupsBalance | | | hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancerWithStochasticLoadBalancerAsInternal | | | hadoop.hbase.rsgroup.TestRSGroupsBasics | | | hadoop.hbase.rsgroup.TestRSGroupsAdmin2 | | | hadoop.hbase.rsgroup.TestRSGroupsOfflineMode | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/43/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8398b98072af 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / 35acf3cb78 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/43/artifact/out/patch-unit-hbase-rsgroup.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/43/testReport/ | | Max. process+thread count | 4000 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/43/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #432: HBASE-22765 add move_table_to_servers command in shell
Apache-HBase commented on issue #432: HBASE-22765 add move_table_to_servers command in shell URL: https://github.com/apache/hbase/pull/432#issuecomment-517089523 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 60 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 297 | master passed | | +1 | javadoc | 12 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 290 | the patch passed | | -1 | rubocop | 16 | The patch generated 23 new + 454 unchanged - 16 fixed = 477 total (was 470) | | -1 | whitespace | 0 | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 | javadoc | 12 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 100 | hbase-shell in the patch passed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 868 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/15/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/432 | | Optional Tests | dupname asflicense javac javadoc unit rubocop | | uname | Linux 570d7e307fa1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-432/out/precommit/personality/provided.sh | | git revision | master / 8cfc46d8d0 | | Default Java | 1.8.0_181 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/15/artifact/out/diff-patch-rubocop.txt | | whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/15/artifact/out/whitespace-eol.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/15/testReport/ | | Max. process+thread count | 898 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/15/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.73.0 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on a change in pull request #432: HBASE-22765 add move_table_to_servers command in shell
Apache-HBase commented on a change in pull request #432: HBASE-22765 add move_table_to_servers command in shell URL: https://github.com/apache/hbase/pull/432#discussion_r309498931 ## File path: hbase-shell/src/main/ruby/shell/commands/move_table_to_servers.rb ## @@ -0,0 +1,47 @@ +# +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +module Shell + module Commands +class MoveTableToServers < Command + def help +return <<-EOF +Move all regions of the table to a regionserver. All regions will be moved to the +given regionserver if the 'SERVER_NAME' is specified, or to a random regionserver if +'SERVER_NAME' is absent + +NOTE: +A server name is its host, port plus startcode. For example: +host187.example.com,60020,1289493121758 +Examples: + + hbase> move_table_to_servers 'TABLENAME', ['SERVER_NAME1','SERVER_NAME2'] Review comment: whitespace:end of line This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes
Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes URL: https://github.com/apache/hbase/pull/374#issuecomment-517087689 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 88 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 332 | master passed | | +1 | compile | 25 | master passed | | +1 | checkstyle | 31 | master passed | | +1 | shadedjars | 310 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 22 | master passed | | 0 | spotbugs | 58 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 54 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 333 | the patch passed | | +1 | compile | 22 | the patch passed | | +1 | javac | 22 | the patch passed | | -1 | checkstyle | 27 | hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | whitespace | 1 | The patch has no whitespace issues. | | +1 | shadedjars | 293 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1054 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 20 | the patch passed | | +1 | findbugs | 57 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 177 | hbase-common in the patch passed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 3269 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/45/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/374 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 1ac957eda11e 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh | | git revision | master / 35acf3cb78 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/45/artifact/out/diff-checkstyle-hbase-common.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/45/testReport/ | | Max. process+thread count | 258 (vs. ulimit of 1) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/45/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #429: HBASE-22735 : list_regions show basic info for region currently in tr…
Apache-HBase commented on issue #429: HBASE-22735 : list_regions show basic info for region currently in tr… URL: https://github.com/apache/hbase/pull/429#issuecomment-517086935 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 0 | Docker mode activated. | | -1 | patch | 10 | https://github.com/apache/hbase/pull/429 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/429 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/22/console | | versions | git=2.7.4 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT
[
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897692#comment-16897692
]
Andrew Purtell commented on HBASE-22735:
Committed.
I see why admin.rb's getClusterStatus doesn't work in master. It's fine for
now. The next version of the patch that reverts ClusterStatus will have to
address it one way or another.
> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735-master-tmp-justforreview.patch,
> HBASE-22735.branch-1.01.patch, HBASE-22735.branch-1.02.patch,
> HBASE-22735.branch-1.03.patch, HBASE-22735.branch-1.04.patch,
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch,
> HBASE-22735.master.03.patch, HBASE-22735.master.04.patch, Screen Shot
> 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and
> then prints them and some attributes such as the server where they are
> located, current request count, data locality, and such.
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil
> references and just display what we can.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22735) list_regions may throw an error if a region is RIT
[
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-22735:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735-master-tmp-justforreview.patch,
> HBASE-22735.branch-1.01.patch, HBASE-22735.branch-1.02.patch,
> HBASE-22735.branch-1.03.patch, HBASE-22735.branch-1.04.patch,
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch,
> HBASE-22735.master.03.patch, HBASE-22735.master.04.patch, Screen Shot
> 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and
> then prints them and some attributes such as the server where they are
> located, current request count, data locality, and such.
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil
> references and just display what we can.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Comment Edited] (HBASE-22735) list_regions may throw an error if a region is RIT
[
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897681#comment-16897681
]
Andrew Purtell edited comment on HBASE-22735 at 8/1/19 1:37 AM:
Ok, committing
was (Author: apurtell):
Ok, committing
I will make a small change to every patch to use admin.rb#getClusterStatus
instead of creating the clusterstatus in list_regions
> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735-master-tmp-justforreview.patch,
> HBASE-22735.branch-1.01.patch, HBASE-22735.branch-1.02.patch,
> HBASE-22735.branch-1.03.patch, HBASE-22735.branch-1.04.patch,
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch,
> HBASE-22735.master.03.patch, HBASE-22735.master.04.patch, Screen Shot
> 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and
> then prints them and some attributes such as the server where they are
> located, current request count, data locality, and such.
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil
> references and just display what we can.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Comment Edited] (HBASE-22735) list_regions may throw an error if a region is RIT
[
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897681#comment-16897681
]
Andrew Purtell edited comment on HBASE-22735 at 8/1/19 1:34 AM:
Ok, committing
I will make a small change to every patch to use admin.rb#getClusterStatus
instead of creating the clusterstatus in list_regions
was (Author: apurtell):
Ok, committing
> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735-master-tmp-justforreview.patch,
> HBASE-22735.branch-1.01.patch, HBASE-22735.branch-1.02.patch,
> HBASE-22735.branch-1.03.patch, HBASE-22735.branch-1.04.patch,
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch,
> HBASE-22735.master.03.patch, HBASE-22735.master.04.patch, Screen Shot
> 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and
> then prints them and some attributes such as the server where they are
> located, current request count, data locality, and such.
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil
> references and just display what we can.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT
[
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897681#comment-16897681
]
Andrew Purtell commented on HBASE-22735:
Ok, committing
> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735-master-tmp-justforreview.patch,
> HBASE-22735.branch-1.01.patch, HBASE-22735.branch-1.02.patch,
> HBASE-22735.branch-1.03.patch, HBASE-22735.branch-1.04.patch,
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch,
> HBASE-22735.master.03.patch, HBASE-22735.master.04.patch, Screen Shot
> 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and
> then prints them and some attributes such as the server where they are
> located, current request count, data locality, and such.
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil
> references and just display what we can.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22770) TestShell fails on trunk with NameError: missing class name (`org.apache.hadoop.hbase.ClusterStatus')
[
https://issues.apache.org/jira/browse/HBASE-22770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897680#comment-16897680
]
Andrew Purtell commented on HBASE-22770:
Great, thanks!
> TestShell fails on trunk with NameError: missing class name
> (`org.apache.hadoop.hbase.ClusterStatus')
> -
>
> Key: HBASE-22770
> URL: https://issues.apache.org/jira/browse/HBASE-22770
> Project: HBase
> Issue Type: Bug
> Components: shell, test
>Reporter: Andrew Purtell
>Priority: Major
>
> Running shell tests on trunk there are some failures related to use of
> ClusterStatus in admin.rb:
> {noformat}
> Error:
> ^[[48;5;16;38;5;226;1mtest_decommission_regionservers_with_non-existant_server_name(Hbase::CommissioningTest)^[[0m:
> NameError: missing class name (`org.apache.hadoop.hbase.ClusterStatus')
> org/jruby/javasupport/JavaPackage.java:259:in `method_missing'
> /Users/apurtell/src/hbase/hbase-shell/src/main/ruby/hbase/admin.rb:1180:in
> `getRegionServers'
> /Users/apurtell/src/hbase/hbase-shell/src/main/ruby/hbase/admin.rb:1206:in
> `getServerNames'
> src/test/ruby/hbase/admin2_test.rb:386:in `block in
> test_decommission_regionservers_with_non-existant_server_name'
> 383: end
> 384:
> 385: define_test 'decommission regionservers with non-existant
> server name' do
> ^[[48;5;16;38;5;226;1m => 386: server_name = admin.getServerNames([],
> true)[0].getServerName()^[[0m
> 387: assert_raise(ArgumentError) do
> 388: command(:decommission_regionservers, 'dummy')
> 389: end
> {noformat}
> {noformat}
> Error:
> ^[[48;5;16;38;5;226;1mtest_decommission_regionservers_with_server_host_name_and_port(Hbase::CommissioningTest)^[[0m:
> NameError: missing class name (`org.apache.hadoop.hbase.ClusterStatus')
> org/jruby/javasupport/JavaPackage.java:259:in `method_missing'
> /Users/apurtell/src/hbase/hbase-shell/src/main/ruby/hbase/admin.rb:1180:in
> `getRegionServers'
> /Users/apurtell/src/hbase/hbase-shell/src/main/ruby/hbase/admin.rb:1206:in
> `getServerNames'
> src/test/ruby/hbase/admin2_test.rb:371:in `block in
> test_decommission_regionservers_with_server_host_name_and_port'
> 368: end
> 369:
> 370: define_test 'decommission regionservers with server host name
> and port' do
> ^[[48;5;16;38;5;226;1m => 371: server_name = admin.getServerNames([],
> true)[0]^[[0m
> 372: host_name_and_port = server_name.getHostname + ','
> +server_name.getPort.to_s
> 373: server_name_str = server_name.getServerName
> 374: command(:decommission_regionservers, host_name_and_port)
> {noformat}
> {noformat}
> Error:
> ^[[48;5;16;38;5;226;1mtest_decommission_regionservers_with_server_host_name_only(Hbase::CommissioningTest)^[[0m:
> NameError: missing class name (`org.apache.hadoop.hbase.ClusterStatus')
> org/jruby/javasupport/JavaPackage.java:259:in `method_missing'
> /Users/apurtell/src/hbase/hbase-shell/src/main/ruby/hbase/admin.rb:1180:in
> `getRegionServers'
> /Users/apurtell/src/hbase/hbase-shell/src/main/ruby/hbase/admin.rb:1206:in
> `getServerNames'
> src/test/ruby/hbase/admin2_test.rb:356:in `block in
> test_decommission_regionservers_with_server_host_name_only'
> 353: end
> 354:
> 355: define_test 'decommission regionservers with server host name
> only' do
> ^[[48;5;16;38;5;226;1m => 356: server_name = admin.getServerNames([],
> true)[0]^[[0m
> 357: host_name = server_name.getHostname
> 358: server_name_str = server_name.getServerName
> 359: command(:decommission_regionservers, host_name)
> {noformat}
> and so on
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22727) The canary table should be placed on all regionservers
[ https://issues.apache.org/jira/browse/HBASE-22727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22727: --- Issue Type: Improvement (was: Sub-task) Parent: (was: HBASE-22514) > The canary table should be placed on all regionservers > -- > > Key: HBASE-22727 > URL: https://issues.apache.org/jira/browse/HBASE-22727 > Project: HBase > Issue Type: Improvement >Reporter: Duo Zhang >Assignee: chenyang >Priority: Major > > Not within a single rs group. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22727) The canary table should be placed on all regionservers
[ https://issues.apache.org/jira/browse/HBASE-22727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897679#comment-16897679 ] Duo Zhang commented on HBASE-22727: --- You can make this issue out of the sub tasks and target it to the master branch(not HBASE-22514) I think. This is an important improvement, which should also be committed to branch-2 at least. And for the parent issue, the current plan is only land it to master. Thanks [~HB-CY]. > The canary table should be placed on all regionservers > -- > > Key: HBASE-22727 > URL: https://issues.apache.org/jira/browse/HBASE-22727 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: chenyang >Priority: Major > > Not within a single rs group. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #434: HBASE-22609 [Docs] More detail documentation about...
Apache-HBase commented on issue #434: HBASE-22609 [Docs] More detail documentation about... URL: https://github.com/apache/hbase/pull/434#issuecomment-517081703 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 43 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 | mvninstall | 301 | master passed | | 0 | refguide | 323 | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 306 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | 0 | refguide | 326 | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Other Tests _ | | +1 | asflicense | 15 | The patch does not generate ASF License warnings. | | | | 1370 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/7/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/434 | | Optional Tests | dupname asflicense refguide | | uname | Linux 937764e82cef 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-434/out/precommit/personality/provided.sh | | git revision | master / 35acf3cb78 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/7/artifact/out/branch-site/book.html | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/7/artifact/out/patch-site/book.html | | Max. process+thread count | 96 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/7/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #425: HBASE-22737 Add a new admin method and shell cmd to trigger the hbck …
Apache-HBase commented on issue #425: HBASE-22737 Add a new admin method and shell cmd to trigger the hbck … URL: https://github.com/apache/hbase/pull/425#issuecomment-517081648 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 99 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 4 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 24 | Maven dependency ordering for branch | | -1 | mvninstall | 81 | root in master failed. | | -1 | compile | 19 | hbase-client in master failed. | | -1 | compile | 36 | hbase-server in master failed. | | +1 | checkstyle | 122 | master passed | | +1 | shadedjars | 279 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 78 | master passed | | 0 | spotbugs | 151 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 22 | hbase-client in master failed. | | -1 | findbugs | 35 | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | -1 | mvninstall | 83 | root in the patch failed. | | -1 | compile | 21 | hbase-client in the patch failed. | | -1 | compile | 35 | hbase-server in the patch failed. | | -1 | cc | 21 | hbase-client in the patch failed. | | -1 | cc | 35 | hbase-server in the patch failed. | | -1 | javac | 21 | hbase-client in the patch failed. | | -1 | javac | 35 | hbase-server in the patch failed. | | +1 | checkstyle | 8 | The patch passed checkstyle in hbase-protocol-shaded | | +1 | checkstyle | 26 | The patch passed checkstyle in hbase-client | | +1 | checkstyle | 75 | hbase-server: The patch generated 0 new + 136 unchanged - 7 fixed = 136 total (was 143) | | +1 | checkstyle | 10 | The patch passed checkstyle in hbase-shell | | -1 | rubocop | 15 | The patch generated 4 new + 436 unchanged - 1 fixed = 440 total (was 437) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 272 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 54 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 113 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 172 | The patch causes 10 errors with Hadoop v3.1.2. | | -1 | hbaseprotoc | 19 | Patch generated 5 new protoc errors in hbase-client. | | -1 | hbaseprotoc | 39 | Patch generated 10 new protoc errors in hbase-server. | | -1 | hbaseprotoc | 24 | Patch generated 10 new protoc errors in hbase-shell. | | +1 | javadoc | 82 | the patch passed | | -1 | findbugs | 22 | hbase-client in the patch failed. | | -1 | findbugs | 38 | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 | unit | 38 | hbase-protocol-shaded in the patch passed. | | -1 | unit | 20 | hbase-client in the patch failed. | | -1 | unit | 38 | hbase-server in the patch failed. | | -1 | unit | 72 | hbase-shell in the patch failed. | | +1 | asflicense | 36 | The patch does not generate ASF License warnings. | | | | 2540 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.rsgroup.TestShellRSGroups | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/425 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc rubocop | | uname | Linux 6a55ba415733 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-425/out/precommit/personality/provided.sh | | git revision | master / 4829c18251 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/branch-compile-hbase-client.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/branch-compile-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/branch-findbugs-hbase-client.txt | | findbugs | https://builds.apache.org/job/HBase-PreComm
[GitHub] [hbase] Apache-HBase commented on a change in pull request #432: HBASE-22765 add move_table_to_servers command in shell
Apache-HBase commented on a change in pull request #432: HBASE-22765 add move_table_to_servers command in shell URL: https://github.com/apache/hbase/pull/432#discussion_r309491569 ## File path: hbase-shell/src/main/ruby/shell/commands/move_table_to_servers.rb ## @@ -0,0 +1,47 @@ +# +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +module Shell + module Commands +class MoveTableToServers < Command + def help +return <<-EOF +Move all regions of the table to a regionserver. All regions will be moved to the +given regionserver if the 'SERVER_NAME' is specified, or to a random regionserver if +'SERVER_NAME' is absent + +NOTE: +A server name is its host, port plus startcode. For example: +host187.example.com,60020,1289493121758 +Examples: + + hbase> move_table_to_servers 'TABLENAME', ['SERVER_NAME1','SERVER_NAME2'] Review comment: whitespace:end of line This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #432: HBASE-22765 add move_table_to_servers command in shell
Apache-HBase commented on issue #432: HBASE-22765 add move_table_to_servers command in shell URL: https://github.com/apache/hbase/pull/432#issuecomment-517080888 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 75 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 322 | master passed | | +1 | javadoc | 12 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 324 | the patch passed | | -1 | rubocop | 19 | The patch generated 23 new + 454 unchanged - 16 fixed = 477 total (was 470) | | -1 | whitespace | 0 | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 | javadoc | 13 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 242 | hbase-shell in the patch failed. | | +1 | asflicense | 10 | The patch does not generate ASF License warnings. | | | | 1094 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.rsgroup.TestShellRSGroups | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/14/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/432 | | Optional Tests | dupname asflicense javac javadoc unit rubocop | | uname | Linux bb90df9d51c1 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-432/out/precommit/personality/provided.sh | | git revision | master / 35acf3cb78 | | Default Java | 1.8.0_181 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/14/artifact/out/diff-patch-rubocop.txt | | whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/14/artifact/out/whitespace-eol.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/14/artifact/out/patch-unit-hbase-shell.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/14/testReport/ | | Max. process+thread count | 750 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/14/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.73.0 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #429: HBASE-22735 : list_regions show basic info for region currently in tr…
Apache-HBase commented on issue #429: HBASE-22735 : list_regions show basic info for region currently in tr… URL: https://github.com/apache/hbase/pull/429#issuecomment-517079831 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 42 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 299 | master passed | | +1 | javadoc | 12 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 293 | the patch passed | | -1 | rubocop | 4 | The patch generated 11 new + 10 unchanged - 11 fixed = 21 total (was 21) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | javadoc | 11 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 32 | hbase-shell in the patch failed. | | +1 | asflicense | 9 | The patch does not generate ASF License warnings. | | | | 773 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestShellNoCluster | | | hadoop.hbase.client.rsgroup.TestShellRSGroups | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/21/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/429 | | Optional Tests | dupname asflicense javac javadoc unit rubocop | | uname | Linux 1233d903a34c 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-429/out/precommit/personality/provided.sh | | git revision | master / 35acf3cb78 | | Default Java | 1.8.0_181 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/21/artifact/out/diff-patch-rubocop.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/21/artifact/out/patch-unit-hbase-shell.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/21/testReport/ | | Max. process+thread count | 606 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/21/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.73.0 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22363) Remove hardcoded number of read cache block buckets
[
https://issues.apache.org/jira/browse/HBASE-22363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897677#comment-16897677
]
Hudson commented on HBASE-22363:
Results for branch branch-2.2
[build #485 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/485/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/485//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/485//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/485//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove hardcoded number of read cache block buckets
>
>
> Key: HBASE-22363
> URL: https://issues.apache.org/jira/browse/HBASE-22363
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache, BucketCache
>Reporter: Biju Nair
>Assignee: Biju Nair
>Priority: Trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22363.patch, HBASE-22363.patch
>
>
> The number of cache block buckets is hardcoded in the code to 3 since
> currently it supports {{single, multi, memory}} block buckets. Will be good
> to make it dynamic.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22145) windows hbase-env causes hbase cli/etc to ignore HBASE_OPTS
[
https://issues.apache.org/jira/browse/HBASE-22145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897678#comment-16897678
]
Hudson commented on HBASE-22145:
Results for branch branch-2.2
[build #485 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/485/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/485//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/485//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/485//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> windows hbase-env causes hbase cli/etc to ignore HBASE_OPTS
> ---
>
> Key: HBASE-22145
> URL: https://issues.apache.org/jira/browse/HBASE-22145
> Project: HBase
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22145.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22744) Remove deprecated classes around status and load
[
https://issues.apache.org/jira/browse/HBASE-22744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897672#comment-16897672
]
Hudson commented on HBASE-22744:
Results for branch master
[build #1301 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1301/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1301//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1301//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1301//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove deprecated classes around status and load
>
>
> Key: HBASE-22744
> URL: https://issues.apache.org/jira/browse/HBASE-22744
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Major
> Fix For: 3.0.0
>
>
> The client module has three deprecated classes around metrics,
> {{ClusterStatus}}, {{RegionLoad}} and {{ServerLoad}}, which should be removed.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22768) Revert to MPIR 2.9
[
https://issues.apache.org/jira/browse/HBASE-22768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897673#comment-16897673
]
Hudson commented on HBASE-22768:
Results for branch master
[build #1301 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1301/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1301//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1301//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1301//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Revert to MPIR 2.9
> --
>
> Key: HBASE-22768
> URL: https://issues.apache.org/jira/browse/HBASE-22768
> Project: HBase
> Issue Type: Sub-task
> Components: website
>Affects Versions: 3.0.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Major
> Fix For: 3.0.0
>
>
> Currently the mailto: links are broken on the website due to MPIR-380.
> Rollback to version 2.9 until a new Maven Project Info Report Plugin is
> released.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] infraio merged pull request #425: HBASE-22737 Add a new admin method and shell cmd to trigger the hbck …
infraio merged pull request #425: HBASE-22737 Add a new admin method and shell cmd to trigger the hbck … URL: https://github.com/apache/hbase/pull/425 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22363) Remove hardcoded number of read cache block buckets
[
https://issues.apache.org/jira/browse/HBASE-22363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897654#comment-16897654
]
Hudson commented on HBASE-22363:
Results for branch branch-2
[build #2136 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2136/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2136//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2136//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2136//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove hardcoded number of read cache block buckets
>
>
> Key: HBASE-22363
> URL: https://issues.apache.org/jira/browse/HBASE-22363
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache, BucketCache
>Reporter: Biju Nair
>Assignee: Biju Nair
>Priority: Trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22363.patch, HBASE-22363.patch
>
>
> The number of cache block buckets is hardcoded in the code to 3 since
> currently it supports {{single, multi, memory}} block buckets. Will be good
> to make it dynamic.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22145) windows hbase-env causes hbase cli/etc to ignore HBASE_OPTS
[
https://issues.apache.org/jira/browse/HBASE-22145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897655#comment-16897655
]
Hudson commented on HBASE-22145:
Results for branch branch-2
[build #2136 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2136/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2136//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2136//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2136//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> windows hbase-env causes hbase cli/etc to ignore HBASE_OPTS
> ---
>
> Key: HBASE-22145
> URL: https://issues.apache.org/jira/browse/HBASE-22145
> Project: HBase
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22145.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Assigned] (HBASE-22727) The canary table should be placed on all regionservers
[ https://issues.apache.org/jira/browse/HBASE-22727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-22727: -- Assignee: chenyang > The canary table should be placed on all regionservers > -- > > Key: HBASE-22727 > URL: https://issues.apache.org/jira/browse/HBASE-22727 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: chenyang >Priority: Major > > Not within a single rs group. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (HBASE-22775) Enhance logging for peer related operations
[ https://issues.apache.org/jira/browse/HBASE-22775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Cang reassigned HBASE-22775: --- Assignee: Xu Cang > Enhance logging for peer related operations > --- > > Key: HBASE-22775 > URL: https://issues.apache.org/jira/browse/HBASE-22775 > Project: HBase > Issue Type: Improvement >Reporter: Xu Cang >Assignee: Xu Cang >Priority: Minor > > Now we don't have good logging regarding peer operations, for example addPeer > does not log itself: > [https://github.com/apache/hbase/blob/master/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ZKReplicationPeerStorage.java#L102] > This Jira is aiming to enhancing this area -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (HBASE-22775) Enhance logging for peer related operations
Xu Cang created HBASE-22775: --- Summary: Enhance logging for peer related operations Key: HBASE-22775 URL: https://issues.apache.org/jira/browse/HBASE-22775 Project: HBase Issue Type: Improvement Reporter: Xu Cang Now we don't have good logging regarding peer operations, for example addPeer does not log itself: [https://github.com/apache/hbase/blob/master/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ZKReplicationPeerStorage.java#L102] This Jira is aiming to enhancing this area -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-517049795 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 69 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for branch | | +1 | mvninstall | 319 | master passed | | +1 | compile | 80 | master passed | | +1 | checkstyle | 117 | master passed | | +1 | shadedjars | 291 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 55 | master passed | | 0 | spotbugs | 250 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 318 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 324 | the patch passed | | +1 | compile | 81 | the patch passed | | +1 | javac | 81 | the patch passed | | +1 | checkstyle | 119 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 297 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 997 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 56 | the patch passed | | +1 | findbugs | 343 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 105 | hbase-client in the patch passed. | | -1 | unit | 13805 | hbase-server in the patch failed. | | +1 | asflicense | 47 | The patch does not generate ASF License warnings. | | | | 17859 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.TestMasterShutdown | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/53/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 7ee71e5dd35c 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / 4829c18251 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/53/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/53/testReport/ | | Max. process+thread count | 4602 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/53/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master)
Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master) URL: https://github.com/apache/hbase/pull/428#issuecomment-517049325 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 138 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 436 | master passed | | +1 | compile | 73 | master passed | | +1 | checkstyle | 99 | master passed | | +1 | shadedjars | 374 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 47 | master passed | | 0 | spotbugs | 333 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 330 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 414 | the patch passed | | +1 | compile | 79 | the patch passed | | +1 | javac | 79 | the patch passed | | +1 | checkstyle | 101 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 354 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1227 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 35 | the patch passed | | +1 | findbugs | 245 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 13390 | hbase-server in the patch failed. | | +1 | asflicense | 25 | The patch does not generate ASF License warnings. | | | | 17779 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/15/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/428 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 99cb5757572b 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh | | git revision | master / 4829c18251 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/15/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/15/testReport/ | | Max. process+thread count | 4488 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/15/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22145) windows hbase-env causes hbase cli/etc to ignore HBASE_OPTS
[
https://issues.apache.org/jira/browse/HBASE-22145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897579#comment-16897579
]
Hudson commented on HBASE-22145:
Results for branch branch-1
[build #985 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/985/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/985//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/985//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/985//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> windows hbase-env causes hbase cli/etc to ignore HBASE_OPTS
> ---
>
> Key: HBASE-22145
> URL: https://issues.apache.org/jira/browse/HBASE-22145
> Project: HBase
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22145.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22363) Remove hardcoded number of read cache block buckets
[
https://issues.apache.org/jira/browse/HBASE-22363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897578#comment-16897578
]
Hudson commented on HBASE-22363:
Results for branch branch-1
[build #985 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/985/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/985//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/985//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/985//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Remove hardcoded number of read cache block buckets
>
>
> Key: HBASE-22363
> URL: https://issues.apache.org/jira/browse/HBASE-22363
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache, BucketCache
>Reporter: Biju Nair
>Assignee: Biju Nair
>Priority: Trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22363.patch, HBASE-22363.patch
>
>
> The number of cache block buckets is hardcoded in the code to 3 since
> currently it supports {{single, multi, memory}} block buckets. Will be good
> to make it dynamic.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Assigned] (HBASE-22216) "Waiting on master failover to complete" shows 30 to 40 time per milliseconds
[ https://issues.apache.org/jira/browse/HBASE-22216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain reassigned HBASE-22216: -- Assignee: Ankit Jain (was: Ankit Jain) > "Waiting on master failover to complete" shows 30 to 40 time per milliseconds > -- > > Key: HBASE-22216 > URL: https://issues.apache.org/jira/browse/HBASE-22216 > Project: HBase > Issue Type: Bug > Components: logging, Operability, proc-v2 >Affects Versions: 1.3.0 >Reporter: Xu Cang >Assignee: Ankit Jain >Priority: Minor > > "Waiting on master failover to complete" appears 30 to 40 times per > *millisecond* from one host when master is initializing. > This message is too noisy, epecially when there are issues when master init. > Should fix this by either rate-limiting or even revisit is that normal > #executeFromState gets called 30-40 times per ms. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Comment Edited] (HBASE-22567) HBCK2 addMissingRegionsToMeta
[
https://issues.apache.org/jira/browse/HBASE-22567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896609#comment-16896609
]
stack edited comment on HBASE-22567 at 7/31/19 9:35 PM:
-[~wchevreuil] One thing I've noticed working on fixing holes is that if that
after scanning to find SINGLE REGION WIDE holes and then using the hole edges
to create the regioninfo that covers the hole, if I use the new RegionInfo to
try and create the corresponding directory in the filesystem, it fails because
the directory already exists (with any data it may have had in it). I've made
it so if existing directory we just use it rather than create a new one. This
works for the case of a single region missing from table but it won't work for
the case covered here where a bunch of contiguous regions are missing from
hbase:meta but their data is in the fs; in this latter case, the tool added
here will restore data and fill holes. Just something I noticed...-
Above didn't seem right and it isn't. I had bug in my fill holes code. Ignore
the above assertion.
was (Author: stack):
[~wchevreuil] One thing I've noticed working on fixing holes is that if that
after scanning to find SINGLE REGION WIDE holes and then using the hole edges
to create the regioninfo that covers the hole, if I use the new RegionInfo to
try and create the corresponding directory in the filesystem, it fails because
the directory already exists (with any data it may have had in it). I've made
it so if existing directory we just use it rather than create a new one. This
works for the case of a single region missing from table but it won't work for
the case covered here where a bunch of contiguous regions are missing from
hbase:meta but their data is in the fs; in this latter case, the tool added
here will restore data and fill holes. Just something I noticed...
> HBCK2 addMissingRegionsToMeta
> -
>
> Key: HBASE-22567
> URL: https://issues.apache.org/jira/browse/HBASE-22567
> Project: HBase
> Issue Type: New Feature
> Components: hbck2
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
>
> Following latest discussion on HBASE-21745, this proposes an hbck2 command
> that allows for inserting back regions missing in META that still have
> *regioninfo* available in HDFS. Although this is still an interactive and
> simpler version than the old _OfflineMetaRepair_, it still relies on hdfs
> state as the source of truth, and performs META updates mostly independently
> from Master (apart from requiring Meta table been online).
> For a more detailed explanation on this command behaviour, pasting _command
> usage_ text:
> {noformat}
> To be used for scenarios where some regions may be missing in META,
> but there's still a valid 'regioninfo' metadata file on HDFS.
> This is a lighter version of 'OfflineMetaRepair' tool commonly used for
> similar issues on 1.x release line.
> This command needs META to be online. For each table name passed as
> parameter, it performs a diff between regions available in META,
> against existing regions dirs on HDFS. Then, for region dirs with
> no matches in META, it reads regioninfo metadata file and
> re-creates given region in META. Regions are re-created in 'CLOSED'
> state at META table only, but not in Masters' cache, and are not
> assigned either. A rolling Masters restart, followed by a
> hbck2 'assigns' command with all re-inserted regions is required.
> This hbck2 'assigns' command is printed for user convenience.
> WARNING: To avoid potential region overlapping problems due to ongoing
> splits, this command disables given tables while re-inserting regions.
> An example adding missing regions for tables 'table_1' and 'table_2':
> $ HBCK2 addMissingRegionsInMeta table_1 table_2
> Returns hbck2 'assigns' command with all re-inserted regions.{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22145) windows hbase-env causes hbase cli/etc to ignore HBASE_OPTS
[
https://issues.apache.org/jira/browse/HBASE-22145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897537#comment-16897537
]
Hudson commented on HBASE-22145:
Results for branch branch-1.3
[build #897 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/897/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/897//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/897//JDK7_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/897//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> windows hbase-env causes hbase cli/etc to ignore HBASE_OPTS
> ---
>
> Key: HBASE-22145
> URL: https://issues.apache.org/jira/browse/HBASE-22145
> Project: HBase
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22145.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22363) Remove hardcoded number of read cache block buckets
[
https://issues.apache.org/jira/browse/HBASE-22363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897536#comment-16897536
]
Hudson commented on HBASE-22363:
Results for branch branch-1.3
[build #897 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/897/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/897//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/897//JDK7_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/897//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Remove hardcoded number of read cache block buckets
>
>
> Key: HBASE-22363
> URL: https://issues.apache.org/jira/browse/HBASE-22363
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache, BucketCache
>Reporter: Biju Nair
>Assignee: Biju Nair
>Priority: Trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22363.patch, HBASE-22363.patch
>
>
> The number of cache block buckets is hardcoded in the code to 3 since
> currently it supports {{single, multi, memory}} block buckets. Will be good
> to make it dynamic.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #425: HBASE-22737 Add a new admin method and shell cmd to trigger the hbck …
Apache-HBase commented on issue #425: HBASE-22737 Add a new admin method and shell cmd to trigger the hbck … URL: https://github.com/apache/hbase/pull/425#issuecomment-517026993 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 39 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 4 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for branch | | +1 | mvninstall | 292 | master passed | | +1 | compile | 136 | master passed | | +1 | checkstyle | 127 | master passed | | +1 | shadedjars | 270 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 84 | master passed | | 0 | spotbugs | 232 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 447 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 291 | the patch passed | | +1 | compile | 134 | the patch passed | | +1 | cc | 134 | the patch passed | | +1 | javac | 134 | the patch passed | | +1 | checkstyle | 11 | The patch passed checkstyle in hbase-protocol-shaded | | +1 | checkstyle | 31 | The patch passed checkstyle in hbase-client | | +1 | checkstyle | 77 | hbase-server: The patch generated 0 new + 136 unchanged - 7 fixed = 136 total (was 143) | | +1 | checkstyle | 12 | The patch passed checkstyle in hbase-shell | | -1 | rubocop | 14 | The patch generated 4 new + 436 unchanged - 1 fixed = 440 total (was 437) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 270 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 911 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | hbaseprotoc | 131 | the patch passed | | +1 | javadoc | 84 | the patch passed | | +1 | findbugs | 475 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 33 | hbase-protocol-shaded in the patch passed. | | +1 | unit | 97 | hbase-client in the patch passed. | | +1 | unit | 8599 | hbase-server in the patch passed. | | +1 | unit | 82 | hbase-shell in the patch passed. | | +1 | asflicense | 92 | The patch does not generate ASF License warnings. | | | | 13173 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/19/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/425 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc rubocop | | uname | Linux 23ca7d3de008 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-425/out/precommit/personality/provided.sh | | git revision | master / 4829c18251 | | Default Java | 1.8.0_181 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/19/artifact/out/diff-patch-rubocop.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/19/testReport/ | | Max. process+thread count | 4446 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/19/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.73.0 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-517019201 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 36 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 297 | master passed | | +1 | compile | 53 | master passed | | +1 | checkstyle | 77 | master passed | | +1 | shadedjars | 268 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 33 | master passed | | 0 | spotbugs | 248 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 246 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 293 | the patch passed | | +1 | compile | 54 | the patch passed | | +1 | javac | 54 | the patch passed | | -1 | checkstyle | 81 | hbase-server: The patch generated 12 new + 345 unchanged - 0 fixed = 357 total (was 345) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 274 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 908 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 | javadoc | 32 | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | findbugs | 242 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 8432 | hbase-server in the patch failed. | | +1 | asflicense | 22 | The patch does not generate ASF License warnings. | | | | 11709 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestHRegion | | | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/18/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/390 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 4011d80ac23c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-390/out/precommit/personality/provided.sh | | git revision | master / 4829c18251 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/18/artifact/out/diff-checkstyle-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/18/artifact/out/diff-javadoc-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/18/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/18/testReport/ | | Max. process+thread count | 5294 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/18/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #403: HBASE-22707 [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentMan
Apache-HBase commented on issue #403: HBASE-22707 [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentManager RegionsStateStore URL: https://github.com/apache/hbase/pull/403#issuecomment-517015623 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 42 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for branch | | +1 | mvninstall | 283 | master passed | | +1 | compile | 77 | master passed | | +1 | checkstyle | 97 | master passed | | +1 | shadedjars | 260 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 52 | master passed | | 0 | spotbugs | 238 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 301 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 279 | the patch passed | | -1 | compile | 39 | hbase-server in the patch failed. | | -1 | javac | 39 | hbase-server in the patch failed. | | +1 | checkstyle | 98 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 256 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 85 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 170 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 259 | The patch causes 10 errors with Hadoop v3.1.2. | | +1 | javadoc | 56 | the patch passed | | +1 | findbugs | 316 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 106 | hbase-client in the patch passed. | | +1 | unit | 8361 | hbase-server in the patch passed. | | +1 | asflicense | 45 | The patch does not generate ASF License warnings. | | | | 11071 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/40/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/403 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8b93f2dc5e0c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-403/out/precommit/personality/provided.sh | | git revision | master / 4829c18251 | | Default Java | 1.8.0_181 | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/40/artifact/out/patch-compile-hbase-server.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/40/artifact/out/patch-compile-hbase-server.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/40/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/40/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/40/artifact/out/patch-javac-3.1.2.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/40/testReport/ | | Max. process+thread count | 4821 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/40/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] gjacoby126 commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
gjacoby126 commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-517013228 Pushed up fixes to the checkstyle and test failures the CI pipeline found. Haven't yet incorporated the feedback on the coprocessor signature that @apurtell and @anoopsjohn requested -- will do that once I get a clean run. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22731) ReplicationSource and HBaseInterClusterReplicationEndpoint log messages should include a target Peer identifier
[
https://issues.apache.org/jira/browse/HBASE-22731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897511#comment-16897511
]
HBase QA commented on HBASE-22731:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
32s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
55s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
57s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
17m 19s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}210m 8s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
25s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}270m 8s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestAsyncTableAdminApi |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/701/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22731 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12976348/HBASE-22731.master.002.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux ec0e64a538ec 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2
18:22:20 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 24b970ec51 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/701/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBAS
[jira] [Comment Edited] (HBASE-22735) list_regions may throw an error if a region is RIT
[
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897143#comment-16897143
]
Viraj Jasani edited comment on HBASE-22735 at 7/31/19 8:18 PM:
---
Commit reverted for HBASE-22744:
[https://github.com/apache/hbase/commit/24b970ec514b22ebc8bfeb043e301b565db4a59c]
Although the patch should work on master now, based on your suggestion, we can
move forward.
Attaching one patch for reference(HBASE-22735-master-tmp-justforreview.patch),
which doesn't have method refactoring(helper methods in admin) as of now but
contains changes of using latest classes(Metrics classes) and not deprecated
ones.
[^HBASE-22735-master-tmp-justforreview.patch]
was (Author: vjasani):
Commit reverted for HBASE-22744:
[https://github.com/apache/hbase/commit/24b970ec514b22ebc8bfeb043e301b565db4a59c]
Although the patch should work on master now, based on your suggestion, we can
move forward.
Attaching one patch for reference(HBASE-22735-master-tmp-justforreview.patch),
which doesn't have method refactoring as of now but contains changes of using
latest classes(Metrics classes) and not deprecated classes.
[^HBASE-22735-master-tmp-justforreview.patch]
> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735-master-tmp-justforreview.patch,
> HBASE-22735.branch-1.01.patch, HBASE-22735.branch-1.02.patch,
> HBASE-22735.branch-1.03.patch, HBASE-22735.branch-1.04.patch,
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch,
> HBASE-22735.master.03.patch, HBASE-22735.master.04.patch, Screen Shot
> 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and
> then prints them and some attributes such as the server where they are
> located, current request count, data locality, and such.
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil
> references and just display what we can.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Comment Edited] (HBASE-22735) list_regions may throw an error if a region is RIT
[
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897039#comment-16897039
]
Viraj Jasani edited comment on HBASE-22735 at 7/31/19 8:17 PM:
---
Ok, so HBASE-22744 was merged ~20 hr ago.
[~apurtell] I agree with having admin helper methods with impl details and for
master branch, we can get data from ServerMetrics(instead of ServerLoad) etc
with all data retrieval methods in admin.rb.
However, is it fine to move/refactor the above logic as part of this JIRA? If
no, for now, I can keep the above logic with list_regions.rb with updated
classes(focus only on removing deprecated methods so list_regions is not
broken) and with another followup JIRA, I can focus on moving the logic to
admin.rb as helper methods and that patch can just focus on helper
methods(admin.rb) for all branches.
Please let me know your preference.
was (Author: vjasani):
Ok, so HBASE-22744 was merged ~20 hr ago.
[~apurtell] I agree with having admin helper methods with impl details and for
master branch, we can get data from ServerMetrics(instead of ServerLoad),
RegionMetrics(instead of RegionLoad), ClusterMetrics(instead of ClusterStatus),
with all data retrieval methods in admin.rb.
However, is it fine to move/refactor the above logic as part of this JIRA? If
yes, I can work on patch for master and branch-1 having similar
logic(additional work for master due to recent deprecation). If not, for now, I
can keep the above logic with list_regions.rb with updated classes(focus only
on removing deprecated methods so list_regions is alive) and with another
followup JIRA, I can focus on moving all the logic to admin.rb and that patch
can just focus on refactoring for all branches only.
Please let me know your preference.
> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735-master-tmp-justforreview.patch,
> HBASE-22735.branch-1.01.patch, HBASE-22735.branch-1.02.patch,
> HBASE-22735.branch-1.03.patch, HBASE-22735.branch-1.04.patch,
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch,
> HBASE-22735.master.03.patch, HBASE-22735.master.04.patch, Screen Shot
> 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and
> then prints them and some attributes such as the server where they are
> located, current request count, data locality, and such.
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil
> references and just display what we can.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22145) windows hbase-env causes hbase cli/etc to ignore HBASE_OPTS
[
https://issues.apache.org/jira/browse/HBASE-22145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897489#comment-16897489
]
Hudson commented on HBASE-22145:
Results for branch branch-1.4
[build #934 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/934/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/934//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/934//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/934//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> windows hbase-env causes hbase cli/etc to ignore HBASE_OPTS
> ---
>
> Key: HBASE-22145
> URL: https://issues.apache.org/jira/browse/HBASE-22145
> Project: HBase
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22145.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] HorizonNet commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes
HorizonNet commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes URL: https://github.com/apache/hbase/pull/374#issuecomment-517002242 @xcangCRM I'm doing it, as soon as the last Checkstyle issue is resolved (see my comments and build output above). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22363) Remove hardcoded number of read cache block buckets
[
https://issues.apache.org/jira/browse/HBASE-22363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897488#comment-16897488
]
Hudson commented on HBASE-22363:
Results for branch branch-1.4
[build #934 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/934/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/934//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/934//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/934//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Remove hardcoded number of read cache block buckets
>
>
> Key: HBASE-22363
> URL: https://issues.apache.org/jira/browse/HBASE-22363
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache, BucketCache
>Reporter: Biju Nair
>Assignee: Biju Nair
>Priority: Trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22363.patch, HBASE-22363.patch
>
>
> The number of cache block buckets is hardcoded in the code to 3 since
> currently it supports {{single, multi, memory}} block buckets. Will be good
> to make it dynamic.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #403: HBASE-22707 [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentMan
Apache-HBase commented on issue #403: HBASE-22707 [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentManager RegionsStateStore URL: https://github.com/apache/hbase/pull/403#issuecomment-516999000 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 43 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for branch | | +1 | mvninstall | 293 | master passed | | +1 | compile | 78 | master passed | | +1 | checkstyle | 106 | master passed | | +1 | shadedjars | 269 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 58 | master passed | | 0 | spotbugs | 235 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 296 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 293 | the patch passed | | +1 | compile | 75 | the patch passed | | +1 | javac | 75 | the patch passed | | +1 | checkstyle | 109 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 269 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 912 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 56 | the patch passed | | +1 | findbugs | 313 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 107 | hbase-client in the patch passed. | | +1 | unit | 8102 | hbase-server in the patch passed. | | +1 | asflicense | 42 | The patch does not generate ASF License warnings. | | | | 11827 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/39/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/403 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 1c7d85047666 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-403/out/precommit/personality/provided.sh | | git revision | master / 24b970ec51 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/39/testReport/ | | Max. process+thread count | 4853 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/39/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22539) WAL corruption due to early DBBs re-use when Durability.ASYNC_WAL is used
[
https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897444#comment-16897444
]
HBase QA commented on HBASE-22539:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
43s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
35s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
32s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
39s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
7s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
35s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
58s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
6s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
44s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
33s{color} | {color:red} hbase-server: The patch generated 1 new + 247
unchanged - 0 fixed = 248 total (was 247) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
39s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
18m 27s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
7s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}241m
56s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
40s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}315m 0s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/700/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22539 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12976339/HBASE-22539.branch-2.001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux ba40b9ceb95c 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4
22:49:08 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 3e2ca80c89 |
| maven | version: Apache Maven 3.5.4
(1edded09389
[GitHub] [hbase] xcangCRM commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes
xcangCRM commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes URL: https://github.com/apache/hbase/pull/374#issuecomment-516973552 @Braavos96 good work. could you please fix the minor check-style issue that hadoop-qa reported before we merge it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes
Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes URL: https://github.com/apache/hbase/pull/374#issuecomment-516971128 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 90 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 386 | master passed | | +1 | compile | 23 | master passed | | +1 | checkstyle | 27 | master passed | | +1 | shadedjars | 296 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 21 | master passed | | 0 | spotbugs | 53 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 51 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 319 | the patch passed | | +1 | compile | 22 | the patch passed | | +1 | javac | 22 | the patch passed | | -1 | checkstyle | 26 | hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 295 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1001 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 62 | the patch passed | | +1 | findbugs | 74 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 180 | hbase-common in the patch passed. | | +1 | asflicense | 10 | The patch does not generate ASF License warnings. | | | | 3326 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/44/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/374 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 57db74295901 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh | | git revision | master / 4829c18251 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/44/artifact/out/diff-checkstyle-hbase-common.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/44/testReport/ | | Max. process+thread count | 256 (vs. ulimit of 1) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/44/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22642) Make move operations of RSGroup idempotent
[ https://issues.apache.org/jira/browse/HBASE-22642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897438#comment-16897438 ] Xu Cang commented on HBASE-22642: - [~Xiaolin Ha] Thanks! I re-reviewed the patch. Looks good. But there is one unit test's still failing. Could you please take a look? thanks > Make move operations of RSGroup idempotent > -- > > Key: HBASE-22642 > URL: https://issues.apache.org/jira/browse/HBASE-22642 > Project: HBase > Issue Type: Bug > Components: rsgroup >Reporter: Xiaolin Ha >Assignee: Xiaolin Ha >Priority: Major > > Currently, when moving tables or servers to a group, only groupInfo is > checked. And in RSGroup implementation, groupinfo is written to disk before > regions movements are done. If there are some problems caused move regions > abort, some regions will be on wrong regionservers. What's the worse, retry > the move operation will be rejected because of the correct groupinfo. > We think when moving, not only groupInfo should be checked, but also relevant > region assignments should be checked and corrected. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] xcangCRM commented on a change in pull request #387: HBASE-22642 Make move operations of RSGroup idempotent
xcangCRM commented on a change in pull request #387: HBASE-22642 Make move
operations of RSGroup idempotent
URL: https://github.com/apache/hbase/pull/387#discussion_r309372364
##
File path:
hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsAdmin2.java
##
@@ -652,24 +614,156 @@ public boolean evaluate() throws Exception {
RSGroupInfo newGroup) throws IOException{
// get target server to move, which should has more than one regions
// randomly set a region state to SPLITTING to make move fail
-Map> assignMap =
getTableServerRegionMap().get(tableName);
-String rregion = null;
-ServerName toMoveServer = null;
+return randomlySetRegionState(newGroup,
RegionState.State.SPLITTING,tableName);
+ }
+
+ private Pair randomlySetRegionState(RSGroupInfo
groupInfo,
+ RegionState.State state, TableName... tableNames) throws IOException {
+Preconditions.checkArgument(tableNames.length == 1 || tableNames.length ==
2,
+"only support one or two tables");
+Map> assignMap =
getTableServerRegionMap().get(tableNames[0]);
+if(tableNames.length == 2) {
+ Map> assignMap2 =
getTableServerRegionMap().get(tableNames[1]);
+ assignMap2.forEach((k ,v) -> {
+if(!assignMap.containsKey(k)) {
+ assignMap.remove(k);
+}
+ });
+}
+String toCorrectRegionName = null;
+ServerName srcServer = null;
for (ServerName server : assignMap.keySet()) {
- rregion = assignMap.get(server).size() > 1 &&
- !newGroup.containsServer(server.getAddress()) ?
assignMap.get(server).get(0) : null;
- if (rregion != null) {
-toMoveServer = server;
+ toCorrectRegionName = assignMap.get(server).size() >= 1 &&
+ !groupInfo.containsServer(server.getAddress()) ?
assignMap.get(server).get(0) : null;
+ if (toCorrectRegionName != null) {
+srcServer = server;
break;
}
}
-assert toMoveServer != null;
-RegionInfo ri =
TEST_UTIL.getMiniHBaseCluster().getMaster().getAssignmentManager().
-getRegionInfo(Bytes.toBytesBinary(rregion));
+assert srcServer != null;
+RegionInfo toCorrectRegionInfo =
TEST_UTIL.getMiniHBaseCluster().getMaster()
+
.getAssignmentManager().getRegionInfo(Bytes.toBytesBinary(toCorrectRegionName));
RegionStateNode rsn =
TEST_UTIL.getMiniHBaseCluster().getMaster().getAssignmentManager().getRegionStates()
-.getRegionStateNode(ri);
-rsn.setState(RegionState.State.SPLITTING);
-return new Pair<>(toMoveServer, rsn);
+.getRegionStateNode(toCorrectRegionInfo);
+rsn.setState(state);
+return new Pair<>(srcServer, rsn);
+ }
+
+ @Test
+ public void testFailedMoveTablesAndRepair() throws Exception{
Review comment:
thanks for the details. What I meant is, can you put one or two sentences
description for these unit tests you added. thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] xcangCRM commented on a change in pull request #387: HBASE-22642 Make move operations of RSGroup idempotent
xcangCRM commented on a change in pull request #387: HBASE-22642 Make move
operations of RSGroup idempotent
URL: https://github.com/apache/hbase/pull/387#discussion_r309371450
##
File path:
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java
##
@@ -177,10 +177,7 @@ private void checkServersAndTables(Set servers,
Set tables,
+ " does not exist.");
}
RSGroupInfo srcGrp = new RSGroupInfo(tmpSrcGrp);
-if (srcGrp.getName().equals(targetGroupName)) {
Review comment:
ok thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-516968408 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 39 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 289 | master passed | | +1 | compile | 25 | master passed | | +1 | checkstyle | 12 | master passed | | +1 | shadedjars | 260 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 18 | master passed | | 0 | spotbugs | 44 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 41 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 290 | the patch passed | | +1 | compile | 24 | the patch passed | | +1 | javac | 24 | the patch passed | | +1 | checkstyle | 13 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 267 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 662 | The patch causes 10 errors with Hadoop v3.1.2. | | +1 | javadoc | 18 | the patch passed | | +1 | findbugs | 53 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 817 | hbase-rsgroup in the patch failed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 2903 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.rsgroup.TestEnableRSGroups | | | hadoop.hbase.rsgroup.TestRSGroupsWithACL | | | hadoop.hbase.rsgroup.TestRSGroupsOfflineMode | | | hadoop.hbase.rsgroup.TestRSGroupsAdmin1 | | | hadoop.hbase.rsgroup.TestRSGroupsBalance | | | hadoop.hbase.rsgroup.TestRSGroupsBasics | | | hadoop.hbase.rsgroup.TestRSGroupsAdmin2 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/42/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c5a3f3f8d171 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / 4829c18251 | | Default Java | 1.8.0_181 | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/42/artifact/out/patch-javac-3.1.2.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/42/artifact/out/patch-unit-hbase-rsgroup.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/42/testReport/ | | Max. process+thread count | 3310 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/42/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22703) [Balancer] Regions no longer exists but there are 'RegionPlan's in balancer.
[
https://issues.apache.org/jira/browse/HBASE-22703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897430#comment-16897430
]
Xu Cang commented on HBASE-22703:
-
I am thinking it aloud, maybe first step is to add a unit test to reproduce
this issue. It could help understanding why this is happening. thanks
> [Balancer] Regions no longer exists but there are 'RegionPlan's in balancer.
>
>
> Key: HBASE-22703
> URL: https://issues.apache.org/jira/browse/HBASE-22703
> Project: HBase
> Issue Type: Bug
> Components: Balancer
>Affects Versions: 1.4.6
>Reporter: Reid Chan
>Priority: Major
>
> {code}
> 2019-07-17 14:20:00,693 INFO
> [bd-hbase001.bx.momo.com,16000,1561099443129_ChoreService_1] master.HMaster:
> balance
> hri=feed:content,05f92c5b,1561537720857.8f1747020ed2442e93387c770f343596.,
> src=, dest=
> 2019-07-17 14:20:00,693 INFO
> [bd-hbase001.bx.momo.com,16000,1561099443129_ChoreService_1]
> master.AssignmentManager: Ignored moving region not assigned: {ENCODED =>
> 8f1747020ed2442e93387c770f343596, NAME =>
> 'feed:content,05f92c5b,1561537720857.8f1747020ed2442e93387c770f343596.',
> STARTKEY => '05f92c5b', ENDKEY => '06d3a068'}, not in region states
> 2019-07-17 14:20:00,693 INFO
> [bd-hbase001.bx.momo.com,16000,1561099443129_ChoreService_1] master.HMaster:
> balance
> hri=feed:content,a5e7,1561537720857.2c48781dcb5e21490820d5b8f4d50e9f.,
> src=, dest=
> 2019-07-17 14:20:00,693 INFO
> [bd-hbase001.bx.momo.com,16000,1561099443129_ChoreService_1]
> master.AssignmentManager: Ignored moving region not assigned: {ENCODED =>
> 2c48781dcb5e21490820d5b8f4d50e9f, NAME =>
> 'feed:content,a5e7,1561537720857.2c48781dcb5e21490820d5b8f4d50e9f.',
> STARTKEY => 'a5e7', ENDKEY => 'a740d9f4'}, not in region states
> 2019-07-17 14:20:00,693 INFO
> [bd-hbase001.bx.momo.com,16000,1561099443129_ChoreService_1] master.HMaster:
> balance
> hri=feed:content,94e3,1561537720857.0aa7fc2d59fc68d05d4695f3b6834915.,
> src=, dest=
> 2019-07-17 14:20:00,693 INFO
> [bd-hbase001.bx.momo.com,16000,1561099443129_ChoreService_1]
> master.AssignmentManager: Ignored moving region not assigned: {ENCODED =>
> 0aa7fc2d59fc68d05d4695f3b6834915, NAME =>
> 'feed:content,94e3,1561537720857.0aa7fc2d59fc68d05d4695f3b6834915.',
> STARTKEY => '94e3', ENDKEY => '962fc8f0'}, not in region states
> {code}
> These are logs pasted from master log. In fact, table {{feed:content}} and
> its regions no longer exists in cluster, but they seems being kept in
> {{RegionPlan}} or {{Balancer}} forever.
> BTW, the balancer is {{RSGroupBasedLoadBalancer}}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] xcangCRM commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
xcangCRM commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-516963700 Can you please check if the failed unit test is related to the change? If you think it's not, I will take another closer look and merge this change. thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] xcangCRM commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes
xcangCRM commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes URL: https://github.com/apache/hbase/pull/374#issuecomment-516961170 +1 @HorizonNet Are you planning merging this one? thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22145) windows hbase-env causes hbase cli/etc to ignore HBASE_OPTS
[
https://issues.apache.org/jira/browse/HBASE-22145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897408#comment-16897408
]
Hudson commented on HBASE-22145:
Results for branch branch-2.1
[build #1438 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1438/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1438//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1438//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1438//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> windows hbase-env causes hbase cli/etc to ignore HBASE_OPTS
> ---
>
> Key: HBASE-22145
> URL: https://issues.apache.org/jira/browse/HBASE-22145
> Project: HBase
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22145.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22363) Remove hardcoded number of read cache block buckets
[
https://issues.apache.org/jira/browse/HBASE-22363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897407#comment-16897407
]
Hudson commented on HBASE-22363:
Results for branch branch-2.1
[build #1438 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1438/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1438//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1438//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1438//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove hardcoded number of read cache block buckets
>
>
> Key: HBASE-22363
> URL: https://issues.apache.org/jira/browse/HBASE-22363
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache, BucketCache
>Reporter: Biju Nair
>Assignee: Biju Nair
>Priority: Trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22363.patch, HBASE-22363.patch
>
>
> The number of cache block buckets is hardcoded in the code to 3 since
> currently it supports {{single, multi, memory}} block buckets. Will be good
> to make it dynamic.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22731) ReplicationSource and HBaseInterClusterReplicationEndpoint log messages should include a target Peer identifier
[ https://issues.apache.org/jira/browse/HBASE-22731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897396#comment-16897396 ] Xu Cang commented on HBASE-22731: - Very useful stuff. One thing I'd like to see is some example log lines. Thanks. > ReplicationSource and HBaseInterClusterReplicationEndpoint log messages > should include a target Peer identifier > --- > > Key: HBASE-22731 > URL: https://issues.apache.org/jira/browse/HBASE-22731 > Project: HBase > Issue Type: Improvement > Components: Replication >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Minor > Attachments: HBASE-22731.master.001.patch, > HBASE-22731.master.002.patch > > > _ReplicationSource_ and _HBaseInterClusterReplicationEndpoint_ already > include a good number of helpful DEBUG and TRACE log messages to help us > troubleshooting typical replication problems, such as lags or mysteriously > missing edits on target peer. > However, for each configured peer, there will be an individual > _ReplicationSource_/_HBaseInterClusterReplicationEndpoint_ pair running in > parallel, in scenarios where we need to investigate issues within a source to > an specific peer, we can't distinguish from which peer specific > _ReplicationSource_/_HBaseInterClusterReplicationEndpoint._ For such cases it > would be nice to have an identifier for specific peer the given > _ReplicationSource_/_HBaseInterClusterReplicationEndpoint_ is related to. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #432: HBASE-22765 add move_table_to_servers command in shell
Apache-HBase commented on issue #432: HBASE-22765 add move_table_to_servers command in shell URL: https://github.com/apache/hbase/pull/432#issuecomment-516957138 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 63 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | -1 | mvninstall | 12 | root in master failed. | | +1 | javadoc | 10 | master passed | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 13 | root in the patch failed. | | -1 | rubocop | 17 | The patch generated 23 new + 454 unchanged - 16 fixed = 477 total (was 470) | | -1 | whitespace | 0 | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 | javadoc | 11 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 241 | hbase-shell in the patch failed. | | +1 | asflicense | 9 | The patch does not generate ASF License warnings. | | | | 443 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.rsgroup.TestShellRSGroups | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/13/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/432 | | Optional Tests | dupname asflicense javac javadoc unit rubocop | | uname | Linux 1d81e4855c9a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-432/out/precommit/personality/provided.sh | | git revision | master / 4829c18251 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/13/artifact/out/branch-mvninstall-root.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/13/artifact/out/patch-mvninstall-root.txt | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/13/artifact/out/diff-patch-rubocop.txt | | whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/13/artifact/out/whitespace-eol.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/13/artifact/out/patch-unit-hbase-shell.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/13/testReport/ | | Max. process+thread count | 633 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/13/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.73.0 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on a change in pull request #432: HBASE-22765 add move_table_to_servers command in shell
Apache-HBase commented on a change in pull request #432: HBASE-22765 add move_table_to_servers command in shell URL: https://github.com/apache/hbase/pull/432#discussion_r309357213 ## File path: hbase-shell/src/main/ruby/shell/commands/move_table_to_servers.rb ## @@ -0,0 +1,47 @@ +# +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +module Shell + module Commands +class MoveTableToServers < Command + def help +return <<-EOF +Move all regions of the table to a regionserver. All regions will be moved to the +given regionserver if the 'SERVER_NAME' is specified, or to a random regionserver if +'SERVER_NAME' is absent + +NOTE: +A server name is its host, port plus startcode. For example: +host187.example.com,60020,1289493121758 +Examples: + + hbase> move_table_to_servers 'TABLENAME', ['SERVER_NAME1','SERVER_NAME2'] Review comment: whitespace:end of line This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-22768) Revert to MPIR 2.9
[ https://issues.apache.org/jira/browse/HBASE-22768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-22768. --- Resolution: Fixed I made a site rebuild and the email links are working again. Thanks [~stack] for the review! > Revert to MPIR 2.9 > -- > > Key: HBASE-22768 > URL: https://issues.apache.org/jira/browse/HBASE-22768 > Project: HBase > Issue Type: Sub-task > Components: website >Affects Versions: 3.0.0 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Major > Fix For: 3.0.0 > > > Currently the mailto: links are broken on the website due to MPIR-380. > Rollback to version 2.9 until a new Maven Project Info Report Plugin is > released. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #434: HBASE-22609 [Docs] More detail documentation about...
Apache-HBase commented on issue #434: HBASE-22609 [Docs] More detail documentation about... URL: https://github.com/apache/hbase/pull/434#issuecomment-516955942 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 39 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | -1 | mvninstall | 81 | root in master failed. | | -1 | refguide | 296 | branch has 21 errors when building the reference guide. | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 82 | root in the patch failed. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | -1 | refguide | 294 | patch has 21 errors when building the reference guide. | ||| _ Other Tests _ | | +1 | asflicense | 14 | The patch does not generate ASF License warnings. | | | | 856 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/434 | | Optional Tests | dupname asflicense refguide | | uname | Linux 88cb66fd996c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-434/out/precommit/personality/provided.sh | | git revision | master / 4829c18251 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/6/artifact/out/branch-mvninstall-root.txt | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/6/artifact/out/branch-refguide.log | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/6/artifact/out/patch-mvninstall-root.txt | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/6/artifact/out/patch-refguide.log | | Max. process+thread count | 76 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/6/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #432: HBASE-22765 add move_table_to_servers command in shell
Apache-HBase commented on issue #432: HBASE-22765 add move_table_to_servers command in shell URL: https://github.com/apache/hbase/pull/432#issuecomment-516953561 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 65 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | -1 | mvninstall | 12 | root in master failed. | | +1 | javadoc | 10 | master passed | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 12 | root in the patch failed. | | -1 | rubocop | 17 | The patch generated 23 new + 454 unchanged - 16 fixed = 477 total (was 470) | | -1 | whitespace | 0 | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 | javadoc | 11 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 240 | hbase-shell in the patch failed. | | +1 | asflicense | 9 | The patch does not generate ASF License warnings. | | | | 445 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.rsgroup.TestShellRSGroups | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/12/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/432 | | Optional Tests | dupname asflicense javac javadoc unit rubocop | | uname | Linux 3a92b06685d9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-432/out/precommit/personality/provided.sh | | git revision | master / 4829c18251 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/12/artifact/out/branch-mvninstall-root.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/12/artifact/out/patch-mvninstall-root.txt | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/12/artifact/out/diff-patch-rubocop.txt | | whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/12/artifact/out/whitespace-eol.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/12/artifact/out/patch-unit-hbase-shell.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/12/testReport/ | | Max. process+thread count | 637 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-432/12/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.73.0 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on a change in pull request #432: HBASE-22765 add move_table_to_servers command in shell
Apache-HBase commented on a change in pull request #432: HBASE-22765 add move_table_to_servers command in shell URL: https://github.com/apache/hbase/pull/432#discussion_r309352690 ## File path: hbase-shell/src/main/ruby/shell/commands/move_table_to_servers.rb ## @@ -0,0 +1,47 @@ +# +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +module Shell + module Commands +class MoveTableToServers < Command + def help +return <<-EOF +Move all regions of the table to a regionserver. All regions will be moved to the +given regionserver if the 'SERVER_NAME' is specified, or to a random regionserver if +'SERVER_NAME' is absent + +NOTE: +A server name is its host, port plus startcode. For example: +host187.example.com,60020,1289493121758 +Examples: + + hbase> move_table_to_servers 'TABLENAME', ['SERVER_NAME1','SERVER_NAME2'] Review comment: whitespace:end of line This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #429: HBASE-22735 : list_regions show basic info for region currently in tr…
Apache-HBase commented on issue #429: HBASE-22735 : list_regions show basic info for region currently in tr… URL: https://github.com/apache/hbase/pull/429#issuecomment-516953107 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 59 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | -1 | mvninstall | 75 | root in master failed. | | +1 | javadoc | 11 | master passed | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 76 | root in the patch failed. | | -1 | rubocop | 3 | The patch generated 11 new + 10 unchanged - 11 fixed = 21 total (was 21) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | javadoc | 10 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 70 | hbase-shell in the patch failed. | | +1 | asflicense | 10 | The patch does not generate ASF License warnings. | | | | 382 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.rsgroup.TestShellRSGroups | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/20/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/429 | | Optional Tests | dupname asflicense javac javadoc unit rubocop | | uname | Linux 0cbf26490a97 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-429/out/precommit/personality/provided.sh | | git revision | master / 4829c18251 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/20/artifact/out/branch-mvninstall-root.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/20/artifact/out/patch-mvninstall-root.txt | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/20/artifact/out/diff-patch-rubocop.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/20/artifact/out/patch-unit-hbase-shell.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/20/testReport/ | | Max. process+thread count | 634 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/20/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.73.0 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] petersomogyi merged pull request #433: HBASE-22768 Revert to MPIR 2.9
petersomogyi merged pull request #433: HBASE-22768 Revert to MPIR 2.9 URL: https://github.com/apache/hbase/pull/433 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] petersomogyi commented on issue #433: HBASE-22768 Revert to MPIR 2.9
petersomogyi commented on issue #433: HBASE-22768 Revert to MPIR 2.9 URL: https://github.com/apache/hbase/pull/433#issuecomment-516948632 2 test failed but those are unrelated to this change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #433: HBASE-22768 Revert to MPIR 2.9
Apache-HBase commented on issue #433: HBASE-22768 Revert to MPIR 2.9 URL: https://github.com/apache/hbase/pull/433#issuecomment-516948079 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 68 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 333 | master passed | | +1 | compile | 194 | master passed | | +1 | mvnsite | 1280 | master passed | | +1 | shadedjars | 299 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 181 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 325 | the patch passed | | +1 | compile | 194 | the patch passed | | +1 | javac | 194 | the patch passed | | +1 | mvnsite | 1218 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 3 | The patch has no ill-formed XML file. | | +1 | shadedjars | 299 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1034 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 178 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 16618 | root in the patch failed. | | +1 | asflicense | 29 | The patch does not generate ASF License warnings. | | | | 22648 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-433/9/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/433 | | Optional Tests | dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile mvnsite | | uname | Linux 9cc98b845c9d 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-433@2/out/precommit/personality/provided.sh | | git revision | master / 24b970ec51 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-433/9/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-433/9/testReport/ | | Max. process+thread count | 4543 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-433/9/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22363) Remove hardcoded number of read cache block buckets
[
https://issues.apache.org/jira/browse/HBASE-22363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897364#comment-16897364
]
Hudson commented on HBASE-22363:
Results for branch branch-2.0
[build #1817 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1817/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1817//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1817//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1817//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Remove hardcoded number of read cache block buckets
>
>
> Key: HBASE-22363
> URL: https://issues.apache.org/jira/browse/HBASE-22363
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache, BucketCache
>Reporter: Biju Nair
>Assignee: Biju Nair
>Priority: Trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22363.patch, HBASE-22363.patch
>
>
> The number of cache block buckets is hardcoded in the code to 3 since
> currently it supports {{single, multi, memory}} block buckets. Will be good
> to make it dynamic.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22145) windows hbase-env causes hbase cli/etc to ignore HBASE_OPTS
[
https://issues.apache.org/jira/browse/HBASE-22145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897365#comment-16897365
]
Hudson commented on HBASE-22145:
Results for branch branch-2.0
[build #1817 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1817/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1817//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1817//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1817//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> windows hbase-env causes hbase cli/etc to ignore HBASE_OPTS
> ---
>
> Key: HBASE-22145
> URL: https://issues.apache.org/jira/browse/HBASE-22145
> Project: HBase
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22145.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #433: HBASE-22768 Revert to MPIR 2.9
Apache-HBase commented on issue #433: HBASE-22768 Revert to MPIR 2.9 URL: https://github.com/apache/hbase/pull/433#issuecomment-516941854 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 118 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 370 | master passed | | +1 | compile | 196 | master passed | | +1 | mvnsite | 1280 | master passed | | +1 | shadedjars | 301 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 184 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 319 | the patch passed | | +1 | compile | 190 | the patch passed | | +1 | javac | 190 | the patch passed | | +1 | mvnsite | 1224 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 3 | The patch has no ill-formed XML file. | | +1 | shadedjars | 298 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1001 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 | javadoc | 84 | root in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 16750 | root in the patch failed. | | +1 | asflicense | 39 | The patch does not generate ASF License warnings. | | | | 22762 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.TestMasterShutdown | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-433/8/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/433 | | Optional Tests | dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile mvnsite | | uname | Linux 316e4d582d32 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-433/out/precommit/personality/provided.sh | | git revision | master / caa05356a1 | | Default Java | 1.8.0_181 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-433/8/artifact/out/patch-javadoc-root.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-433/8/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-433/8/testReport/ | | Max. process+thread count | 4580 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-433/8/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22761) Caught ArrayIndexOutOfBoundsException while processing event RS_LOG_REPLAY
[
https://issues.apache.org/jira/browse/HBASE-22761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897350#comment-16897350
]
Wellington Chevreuil commented on HBASE-22761:
--
{quote}But I use Durability.SKIP_WAL a lot. Duo Zhang
{quote}
Hum, that raises suspicions. [~casuallc], I had previously put an instrumented
version [here|https://github.com/wchevreuil/hbase/tree/HBASE-22539] with
further logs to help identify these WAL corruptions prior to the log
splitting/replay phases. Let me know if you are interested on applying this in
your environment, at least for a brief period, so that you would be able to
confirm/rule out the issues from HBASE-22539.
> Caught ArrayIndexOutOfBoundsException while processing event RS_LOG_REPLAY
> --
>
> Key: HBASE-22761
> URL: https://issues.apache.org/jira/browse/HBASE-22761
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.1.1
>Reporter: casuallc
>Priority: Major
> Attachments: tmp
>
>
> RegionServer exists when error happen
> {code:java}
> 2019-07-29 20:51:09,726 INFO [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> wal.WALSplitter: Processed 0 edits across 0 regions; edits skipped=0; log
> file=hdfs://cluster1/hbase/WALs/h2,16020,1564216856546-splitting/h2%2C16020%2C1564216856546.1564398538121,
> length=615233, corrupted=false, progress failed=false
> 2019-07-29 20:51:09,726 INFO [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> handler.WALSplitterHandler: Worker h1,16020,1564404572589 done with task
> org.apache.hadoop.hbase.coordination.ZkSplitLogWorkerCoordination$ZkSplitTaskDetails@577da0d3
> in 84892ms. Status = null
> 2019-07-29 20:51:09,726 ERROR [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> executor.EventHandler: Caught throwable while processing event RS_LOG_REPLAY
> java.lang.ArrayIndexOutOfBoundsException: 16403
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1365)
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1358)
> at
> org.apache.hadoop.hbase.PrivateCellUtil.matchingFamily(PrivateCellUtil.java:735)
> at org.apache.hadoop.hbase.CellUtil.matchingFamily(CellUtil.java:816)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEditFamily(WALEdit.java:143)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEdit(WALEdit.java:148)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:297)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:195)
> at
> org.apache.hadoop.hbase.regionserver.SplitLogWorker$1.exec(SplitLogWorker.java:100)
> at
> org.apache.hadoop.hbase.regionserver.handler.WALSplitterHandler.process(WALSplitterHandler.java:70)
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> 2019-07-29 20:51:09,730 ERROR [RS_LOG_REPLAY_OPS-regionserver/h1:16020-0]
> regionserver.HRegionServer: * ABORTING region server
> h1,16020,1564404572589: Caught throwable while processing event RS_LOG_REPLAY
> *
> java.lang.ArrayIndexOutOfBoundsException: 16403
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1365)
> at org.apache.hadoop.hbase.KeyValue.getFamilyLength(KeyValue.java:1358)
> at
> org.apache.hadoop.hbase.PrivateCellUtil.matchingFamily(PrivateCellUtil.java:735)
> at org.apache.hadoop.hbase.CellUtil.matchingFamily(CellUtil.java:816)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEditFamily(WALEdit.java:143)
> at org.apache.hadoop.hbase.wal.WALEdit.isMetaEdit(WALEdit.java:148)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:297)
> at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:195)
> at
> org.apache.hadoop.hbase.regionserver.SplitLogWorker$1.exec(SplitLogWorker.java:100)
> at
> org.apache.hadoop.hbase.regionserver.handler.WALSplitterHandler.process(WALSplitterHandler.java:70)
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22773) when set blockSize option in Performance Evaluation tool, error occurs:ERROR: Unrecognized option/command: --blockSize=131072
[ https://issues.apache.org/jira/browse/HBASE-22773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897337#comment-16897337 ] Xu Cang commented on HBASE-22773: - +1 > when set blockSize option in Performance Evaluation tool, error occurs:ERROR: > Unrecognized option/command: --blockSize=131072 > - > > Key: HBASE-22773 > URL: https://issues.apache.org/jira/browse/HBASE-22773 > Project: HBase > Issue Type: Bug > Components: mapreduce >Affects Versions: 2.1.0, 2.2.0, 2.3.0 > Environment: OS:CentOS7.6 > CPU: 6148 Processor >Reporter: dingwei2019 >Assignee: dingwei2019 >Priority: Minor > Attachments: HBASE-22773.rel-2.1.0.patch > > > I believe "blockSize" is an new options for PE in HBase2.0, when i try to set > the blockSize, error occurs:ERROR: Unrecognized option/command: > --blockSize=131072. > The error occurs because of missing a "continue;" when we match the option > "blockSize". If there isn't a "continue" the program will execute the last > "printUsageAndExit branch". -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] saintstack commented on a change in pull request #425: HBASE-22737 Add a new admin method and shell cmd to trigger the hbck …
saintstack commented on a change in pull request #425: HBASE-22737 Add a new admin method and shell cmd to trigger the hbck … URL: https://github.com/apache/hbase/pull/425#discussion_r309313468 ## File path: hbase-shell/src/main/ruby/shell/commands/hbck_chore_run.rb ## @@ -0,0 +1,36 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +module Shell + module Commands +class HbckChoreRun < Command + def help +<<-EOF +Request HBCK chore to run at master side. + Review comment: Missing 'm' on Filesystem. Fix on commit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
