[jira] [Commented] (HBASE-22780) Missing table descriptor may cause STUCK Region-In-Transition forever

2019-08-03 Thread Xu Cang (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899556#comment-16899556
 ] 

Xu Cang commented on HBASE-22780:
-

looks good! Could you please click the "submit patch"button to submit this 
patch. It will trigger hadoop-qa testing. Thanks!

Also, is that possible to add a unit test? 

> Missing table descriptor may cause STUCK Region-In-Transition  forever
> --
>
> Key: HBASE-22780
> URL: https://issues.apache.org/jira/browse/HBASE-22780
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 2.1.1
>Reporter: yuhuiyang
>Priority: Major
> Attachments: HBASE-22780-branch-2.1-01.patch
>
>
> AssignProcedure plan to open a region R1  on regionserver RS1 and RS1 failed 
> due to missing table descriptor exception (throw new IOException("Missing 
> table descriptor for " + region.getEncodedName()).  If the region is planned 
> to this regionserver RS1 again , it will ignor this request and do nothing . 
> So the region R1 will be in Region-In-Transition state forever even if the 
> missing table descriptor problem has been solved! 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Comment Edited] (HBASE-22780) Missing table descriptor may cause STUCK Region-In-Transition forever

2019-08-03 Thread Xu Cang (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899556#comment-16899556
 ] 

Xu Cang edited comment on HBASE-22780 at 8/4/19 4:52 AM:
-

looks good! Could you please click the "submit patch"button to submit this 
patch. It will trigger hadoop-qa testing. Thanks!

Also, is that possible to add a unit test?  [~yu-huiyang]


was (Author: xucang):
looks good! Could you please click the "submit patch"button to submit this 
patch. It will trigger hadoop-qa testing. Thanks!

Also, is that possible to add a unit test? 

> Missing table descriptor may cause STUCK Region-In-Transition  forever
> --
>
> Key: HBASE-22780
> URL: https://issues.apache.org/jira/browse/HBASE-22780
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 2.1.1
>Reporter: yuhuiyang
>Priority: Major
> Attachments: HBASE-22780-branch-2.1-01.patch
>
>
> AssignProcedure plan to open a region R1  on regionserver RS1 and RS1 failed 
> due to missing table descriptor exception (throw new IOException("Missing 
> table descriptor for " + region.getEncodedName()).  If the region is planned 
> to this regionserver RS1 again , it will ignor this request and do nothing . 
> So the region R1 will be in Region-In-Transition state forever even if the 
> missing table descriptor problem has been solved! 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] Apache-HBase commented on issue #452: HBASE-22790 Added deprecation versions for fields in ByteBuffAllocator

2019-08-03 Thread GitBox
Apache-HBase commented on issue #452: HBASE-22790 Added deprecation versions 
for fields in ByteBuffAllocator
URL: https://github.com/apache/hbase/pull/452#issuecomment-517966745
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 176 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 348 | master passed |
   | +1 | compile | 23 | master passed |
   | +1 | checkstyle | 25 | master passed |
   | +1 | shadedjars | 296 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 22 | master passed |
   | 0 | spotbugs | 47 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 46 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 287 | the patch passed |
   | +1 | compile | 20 | the patch passed |
   | +1 | javac | 20 | the patch passed |
   | +1 | checkstyle | 23 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 264 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1027 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 19 | the patch passed |
   | +1 | findbugs | 55 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 175 | hbase-common in the patch passed. |
   | +1 | asflicense | 13 | The patch does not generate ASF License warnings. |
   | | | 3222 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-452/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/452 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 83ae559ef063 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 
13:14:43 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-452/out/precommit/personality/provided.sh
 |
   | git revision | master / a6f065396a |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-452/1/testReport/
 |
   | Max. process+thread count | 289 (vs. ulimit of 1) |
   | modules | C: hbase-common U: hbase-common |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-452/1/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #451: HBASE-22789 Removed deprecated method from ImmutableBytesWritable

2019-08-03 Thread GitBox
Apache-HBase commented on issue #451: HBASE-22789 Removed deprecated method 
from ImmutableBytesWritable
URL: https://github.com/apache/hbase/pull/451#issuecomment-517966123
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 61 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 288 | master passed |
   | +1 | compile | 22 | master passed |
   | +1 | checkstyle | 24 | master passed |
   | +1 | shadedjars | 272 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 20 | master passed |
   | 0 | spotbugs | 47 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 46 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 290 | the patch passed |
   | +1 | compile | 22 | the patch passed |
   | +1 | javac | 22 | the patch passed |
   | +1 | checkstyle | 25 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 265 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 902 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 21 | the patch passed |
   | +1 | findbugs | 53 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 181 | hbase-common in the patch passed. |
   | +1 | asflicense | 12 | The patch does not generate ASF License warnings. |
   | | | 2875 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-451/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/451 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux be87645b96b6 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-451/out/precommit/personality/provided.sh
 |
   | git revision | master / a6f065396a |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-451/1/testReport/
 |
   | Max. process+thread count | 291 (vs. ulimit of 1) |
   | modules | C: hbase-common U: hbase-common |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-451/1/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #450: HBASE-22788 Removed deprecated methods from Bytes

2019-08-03 Thread GitBox
Apache-HBase commented on issue #450: HBASE-22788 Removed deprecated methods 
from Bytes
URL: https://github.com/apache/hbase/pull/450#issuecomment-517965877
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 75 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 377 | master passed |
   | +1 | compile | 26 | master passed |
   | +1 | checkstyle | 31 | master passed |
   | +1 | shadedjars | 353 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 25 | master passed |
   | 0 | spotbugs | 64 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 61 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 380 | the patch passed |
   | +1 | compile | 25 | the patch passed |
   | +1 | javac | 25 | the patch passed |
   | -1 | checkstyle | 32 | hbase-common: The patch generated 1 new + 83 
unchanged - 5 fixed = 84 total (was 88) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 351 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1167 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 24 | the patch passed |
   | +1 | findbugs | 73 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 205 | hbase-common in the patch passed. |
   | +1 | asflicense | 13 | The patch does not generate ASF License warnings. |
   | | | 3685 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-450/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/450 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 82549caabfd2 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-450/out/precommit/personality/provided.sh
 |
   | git revision | master / a6f065396a |
   | Default Java | 1.8.0_181 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-450/1/artifact/out/diff-checkstyle-hbase-common.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-450/1/testReport/
 |
   | Max. process+thread count | 289 (vs. ulimit of 1) |
   | modules | C: hbase-common U: hbase-common |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-450/1/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #448: HBASE-22786 Fixed Checkstyle issues in tests in hbase-client

2019-08-03 Thread GitBox
Apache-HBase commented on issue #448: HBASE-22786 Fixed Checkstyle issues in 
tests in hbase-client
URL: https://github.com/apache/hbase/pull/448#issuecomment-517965828
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 211 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 18 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 426 | master passed |
   | +1 | compile | 30 | master passed |
   | +1 | checkstyle | 41 | master passed |
   | +1 | shadedjars | 354 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 27 | master passed |
   | 0 | spotbugs | 91 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 88 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 381 | the patch passed |
   | +1 | compile | 30 | the patch passed |
   | +1 | javac | 30 | the patch passed |
   | +1 | checkstyle | 37 | hbase-client: The patch generated 0 new + 0 
unchanged - 77 fixed = 0 total (was 77) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 344 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1189 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 25 | the patch passed |
   | +1 | findbugs | 100 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 123 | hbase-client in the patch passed. |
   | +1 | asflicense | 12 | The patch does not generate ASF License warnings. |
   | | | 3879 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-448/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/448 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 88a1a7241800 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-448/out/precommit/personality/provided.sh
 |
   | git revision | master / a6f065396a |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-448/2/testReport/
 |
   | Max. process+thread count | 294 (vs. ulimit of 1) |
   | modules | C: hbase-client U: hbase-client |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-448/2/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] HorizonNet opened a new pull request #452: HBASE-22790 Added deprecation versions for fields in ByteBuffAllocator

2019-08-03 Thread GitBox
HorizonNet opened a new pull request #452: HBASE-22790 Added deprecation 
versions for fields in ByteBuffAllocator
URL: https://github.com/apache/hbase/pull/452
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Work started] (HBASE-22790) Add deprecation version for hbase.ipc.server.reservoir.initial.buffer.size & hbase.ipc.server.reservoir.initial.max

2019-08-03 Thread Jan Hentschel (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HBASE-22790 started by Jan Hentschel.
-
> Add deprecation version for hbase.ipc.server.reservoir.initial.buffer.size & 
> hbase.ipc.server.reservoir.initial.max
> ---
>
> Key: HBASE-22790
> URL: https://issues.apache.org/jira/browse/HBASE-22790
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
>
> During the deprecation in HBASE-22598 the deprecation version was not added 
> in the documentation. It should be added as a reminder in what version it can 
> be removed.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Created] (HBASE-22790) Add deprecation version for hbase.ipc.server.reservoir.initial.buffer.size & hbase.ipc.server.reservoir.initial.max

2019-08-03 Thread Jan Hentschel (JIRA)
Jan Hentschel created HBASE-22790:
-

 Summary: Add deprecation version for 
hbase.ipc.server.reservoir.initial.buffer.size & 
hbase.ipc.server.reservoir.initial.max
 Key: HBASE-22790
 URL: https://issues.apache.org/jira/browse/HBASE-22790
 Project: HBase
  Issue Type: Improvement
Affects Versions: 3.0.0, 2.3.0
Reporter: Jan Hentschel
Assignee: Jan Hentschel


During the deprecation in HBASE-22598 the deprecation version was not added in 
the documentation. It should be added as a reminder in what version it can be 
removed.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] HorizonNet opened a new pull request #451: HBASE-22789 Removed deprecated method from ImmutableBytesWritable

2019-08-03 Thread GitBox
HorizonNet opened a new pull request #451: HBASE-22789 Removed deprecated 
method from ImmutableBytesWritable
URL: https://github.com/apache/hbase/pull/451
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Work started] (HBASE-22789) Remove deprecated method from ImmutableBytesWritable

2019-08-03 Thread Jan Hentschel (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HBASE-22789 started by Jan Hentschel.
-
> Remove deprecated method from ImmutableBytesWritable
> 
>
> Key: HBASE-22789
> URL: https://issues.apache.org/jira/browse/HBASE-22789
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
>
> {{ImmutableBytesWritable}} contains a deprecated method, which should be 
> removed.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Created] (HBASE-22789) Remove deprecated method from ImmutableBytesWritable

2019-08-03 Thread Jan Hentschel (JIRA)
Jan Hentschel created HBASE-22789:
-

 Summary: Remove deprecated method from ImmutableBytesWritable
 Key: HBASE-22789
 URL: https://issues.apache.org/jira/browse/HBASE-22789
 Project: HBase
  Issue Type: Improvement
Affects Versions: 3.0.0
Reporter: Jan Hentschel
Assignee: Jan Hentschel


{{ImmutableBytesWritable}} contains a deprecated method, which should be 
removed.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22788) Remove deprecated methods from Bytes

2019-08-03 Thread Jan Hentschel (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated HBASE-22788:
--
Release Note: 
Removed the following, deprecated methods from the Bytes class: 

Bytes(ByteString): Removed without a replacement.
getSize(): Use getLength() instead.
toByteString(): Removed without a replacement.
putLongUnsafe(byte[], int, long): Removed without a replacement.
toIntUnsafe(byte[], int): Removed without a replacement.
toShortUnsafe(byte[], int): Removed without a replacement.
toLongUnsafe(byte[], int): Removed without a replacement.
putIntUnsafe(byte[], int, int): Removed without a replacement.
putShortUnsafe(byte[], int, short): Removed without a replacement.
readVLong(byte[], int): Use readAsVLong(byte[],int) instead.
binarySearch(byte[][], byte[], int, int, RawComparator): Use 
binarySearch(byte[][], byte[], int, int) instead.
binarySearch(byte[][], Cell, RawComparator): Use inarySearch(Cell[], Cell, 
CellComparator) instead.

> Remove deprecated methods from Bytes
> 
>
> Key: HBASE-22788
> URL: https://issues.apache.org/jira/browse/HBASE-22788
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
>
> The {{Bytes}} class contains some deprecated methods, which can be removed 
> for 3.0.0.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] HorizonNet opened a new pull request #450: HBASE-22788 Removed deprecated methods from Bytes

2019-08-03 Thread GitBox
HorizonNet opened a new pull request #450: HBASE-22788 Removed deprecated 
methods from Bytes
URL: https://github.com/apache/hbase/pull/450
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Work started] (HBASE-22788) Remove deprecated methods from Bytes

2019-08-03 Thread Jan Hentschel (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HBASE-22788 started by Jan Hentschel.
-
> Remove deprecated methods from Bytes
> 
>
> Key: HBASE-22788
> URL: https://issues.apache.org/jira/browse/HBASE-22788
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
>
> The {{Bytes}} class contains some deprecated methods, which can be removed 
> for 3.0.0.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Created] (HBASE-22788) Remove deprecated methods from Bytes

2019-08-03 Thread Jan Hentschel (JIRA)
Jan Hentschel created HBASE-22788:
-

 Summary: Remove deprecated methods from Bytes
 Key: HBASE-22788
 URL: https://issues.apache.org/jira/browse/HBASE-22788
 Project: HBase
  Issue Type: Improvement
Affects Versions: 3.0.0
Reporter: Jan Hentschel
Assignee: Jan Hentschel


The {{Bytes}} class contains some deprecated methods, which can be removed for 
3.0.0.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] Apache-HBase commented on issue #449: HBASE-22787 Cleaned up tests in hbase-zookeeper

2019-08-03 Thread GitBox
Apache-HBase commented on issue #449: HBASE-22787 Cleaned up tests in 
hbase-zookeeper
URL: https://github.com/apache/hbase/pull/449#issuecomment-517961655
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 62 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 10 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 301 | master passed |
   | +1 | compile | 17 | master passed |
   | +1 | checkstyle | 13 | master passed |
   | +1 | shadedjars | 267 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 16 | master passed |
   | 0 | spotbugs | 34 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 31 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 290 | the patch passed |
   | +1 | compile | 18 | the patch passed |
   | +1 | javac | 18 | the patch passed |
   | +1 | checkstyle | 12 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 264 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 896 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 15 | the patch passed |
   | +1 | findbugs | 41 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 48 | hbase-zookeeper in the patch passed. |
   | +1 | asflicense | 12 | The patch does not generate ASF License warnings. |
   | | | 2674 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-449/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/449 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux dbe68e986885 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-449/out/precommit/personality/provided.sh
 |
   | git revision | master / a6f065396a |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-449/1/testReport/
 |
   | Max. process+thread count | 297 (vs. ulimit of 1) |
   | modules | C: hbase-zookeeper U: hbase-zookeeper |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-449/1/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #448: HBASE-22786 Fixed Checkstyle issues in tests in hbase-client

2019-08-03 Thread GitBox
Apache-HBase commented on issue #448: HBASE-22786 Fixed Checkstyle issues in 
tests in hbase-client
URL: https://github.com/apache/hbase/pull/448#issuecomment-517959591
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 204 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 18 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | -1 | mvninstall | 368 | root in master failed. |
   | +1 | compile | 24 | master passed |
   | +1 | checkstyle | 32 | master passed |
   | +1 | shadedjars | 280 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 22 | master passed |
   | 0 | spotbugs | 73 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 70 | master passed |
   ||| _ Patch Compile Tests _ |
   | -1 | mvninstall | 312 | root in the patch failed. |
   | +1 | compile | 24 | the patch passed |
   | +1 | javac | 24 | the patch passed |
   | +1 | checkstyle | 29 | hbase-client: The patch generated 0 new + 0 
unchanged - 77 fixed = 0 total (was 77) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 300 | patch has no errors when building our shaded 
downstream artifacts. |
   | -1 | hadoopcheck | 146 | The patch causes 10 errors with Hadoop v2.8.5. |
   | -1 | hadoopcheck | 295 | The patch causes 10 errors with Hadoop v2.9.2. |
   | -1 | hadoopcheck | 450 | The patch causes 10 errors with Hadoop v3.1.2. |
   | +1 | javadoc | 19 | the patch passed |
   | +1 | findbugs | 70 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 96 | hbase-client in the patch passed. |
   | +1 | asflicense | 10 | The patch does not generate ASF License warnings. |
   | | | 2385 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-448/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/448 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 48473a9cb3cf 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 
13:14:43 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-448/out/precommit/personality/provided.sh
 |
   | git revision | master / a6f065396a |
   | Default Java | 1.8.0_181 |
   | mvninstall | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-448/1/artifact/out/branch-mvninstall-root.txt
 |
   | mvninstall | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-448/1/artifact/out/patch-mvninstall-root.txt
 |
   | hadoopcheck | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-448/1/artifact/out/patch-javac-2.8.5.txt
 |
   | hadoopcheck | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-448/1/artifact/out/patch-javac-2.9.2.txt
 |
   | hadoopcheck | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-448/1/artifact/out/patch-javac-3.1.2.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-448/1/testReport/
 |
   | Max. process+thread count | 293 (vs. ulimit of 1) |
   | modules | C: hbase-client U: hbase-client |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-448/1/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] HorizonNet opened a new pull request #449: HBASE-22787 Cleaned up tests in hbase-zookeeper

2019-08-03 Thread GitBox
HorizonNet opened a new pull request #449: HBASE-22787 Cleaned up tests in 
hbase-zookeeper
URL: https://github.com/apache/hbase/pull/449
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Work started] (HBASE-22787) Clean up of tests in hbase-zookeeper

2019-08-03 Thread Jan Hentschel (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HBASE-22787 started by Jan Hentschel.
-
> Clean up of tests in hbase-zookeeper
> 
>
> Key: HBASE-22787
> URL: https://issues.apache.org/jira/browse/HBASE-22787
> Project: HBase
>  Issue Type: Improvement
>  Components: Zookeeper
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
>
> The tests in the {{hbase-zookeeper}} module can be cleaned up in several 
> ways, starting with simplifying some of the assertions and reduce the 
> visibility of some fields, methods and helper classes.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Created] (HBASE-22787) Clean up of tests in hbase-zookeeper

2019-08-03 Thread Jan Hentschel (JIRA)
Jan Hentschel created HBASE-22787:
-

 Summary: Clean up of tests in hbase-zookeeper
 Key: HBASE-22787
 URL: https://issues.apache.org/jira/browse/HBASE-22787
 Project: HBase
  Issue Type: Improvement
  Components: Zookeeper
Reporter: Jan Hentschel
Assignee: Jan Hentschel


The tests in the {{hbase-zookeeper}} module can be cleaned up in several ways, 
starting with simplifying some of the assertions and reduce the visibility of 
some fields, methods and helper classes.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] HorizonNet opened a new pull request #448: HBASE-22786 Fixed Checkstyle issues in tests in hbase-client

2019-08-03 Thread GitBox
HorizonNet opened a new pull request #448: HBASE-22786 Fixed Checkstyle issues 
in tests in hbase-client
URL: https://github.com/apache/hbase/pull/448
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #447: HBASE-22785 Fixed Checkstyle issues in exceptions and enhanced Javadoc

2019-08-03 Thread GitBox
Apache-HBase commented on issue #447: HBASE-22785 Fixed Checkstyle issues in 
exceptions and enhanced Javadoc
URL: https://github.com/apache/hbase/pull/447#issuecomment-517955988
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 195 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 338 | master passed |
   | +1 | compile | 23 | master passed |
   | +1 | checkstyle | 34 | master passed |
   | +1 | shadedjars | 293 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 21 | master passed |
   | 0 | spotbugs | 70 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 67 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 322 | the patch passed |
   | +1 | compile | 24 | the patch passed |
   | +1 | javac | 24 | the patch passed |
   | +1 | checkstyle | 33 | hbase-client: The patch generated 0 new + 0 
unchanged - 15 fixed = 0 total (was 15) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 290 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1009 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 22 | the patch passed |
   | +1 | findbugs | 78 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 101 | hbase-client in the patch passed. |
   | +1 | asflicense | 11 | The patch does not generate ASF License warnings. |
   | | | 3283 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/447 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 1fbcf8151a86 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 
18:22:20 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-447/out/precommit/personality/provided.sh
 |
   | git revision | master / a6f065396a |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/1/testReport/
 |
   | Max. process+thread count | 263 (vs. ulimit of 1) |
   | modules | C: hbase-client U: hbase-client |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-447/1/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (HBASE-22786) Fix Checkstyle issues in tests of hbase-client

2019-08-03 Thread Jan Hentschel (JIRA)
Jan Hentschel created HBASE-22786:
-

 Summary: Fix Checkstyle issues in tests of hbase-client
 Key: HBASE-22786
 URL: https://issues.apache.org/jira/browse/HBASE-22786
 Project: HBase
  Issue Type: Improvement
  Components: Client
Reporter: Jan Hentschel
Assignee: Jan Hentschel


The {{hbase-client}} module has some Checkstyle issues in its tests, which 
should get fixed.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Work started] (HBASE-22786) Fix Checkstyle issues in tests of hbase-client

2019-08-03 Thread Jan Hentschel (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HBASE-22786 started by Jan Hentschel.
-
> Fix Checkstyle issues in tests of hbase-client
> --
>
> Key: HBASE-22786
> URL: https://issues.apache.org/jira/browse/HBASE-22786
> Project: HBase
>  Issue Type: Improvement
>  Components: Client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
>
> The {{hbase-client}} module has some Checkstyle issues in its tests, which 
> should get fixed.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] HorizonNet opened a new pull request #447: HBASE-22785 Fixed Checkstyle issues in exceptions and enhanced Javadoc

2019-08-03 Thread GitBox
HorizonNet opened a new pull request #447: HBASE-22785 Fixed Checkstyle issues 
in exceptions and enhanced Javadoc
URL: https://github.com/apache/hbase/pull/447
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (HBASE-22785) Reduce number of Checkstyle issues in client exceptions

2019-08-03 Thread Jan Hentschel (JIRA)
Jan Hentschel created HBASE-22785:
-

 Summary: Reduce number of Checkstyle issues in client exceptions
 Key: HBASE-22785
 URL: https://issues.apache.org/jira/browse/HBASE-22785
 Project: HBase
  Issue Type: Improvement
  Components: Client
Reporter: Jan Hentschel
Assignee: Jan Hentschel


The exceptions in the client module have some Checkstyle issues. Also, the 
Javadocs should be extended and enhanced.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Work started] (HBASE-22785) Reduce number of Checkstyle issues in client exceptions

2019-08-03 Thread Jan Hentschel (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HBASE-22785 started by Jan Hentschel.
-
> Reduce number of Checkstyle issues in client exceptions
> ---
>
> Key: HBASE-22785
> URL: https://issues.apache.org/jira/browse/HBASE-22785
> Project: HBase
>  Issue Type: Improvement
>  Components: Client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
>
> The exceptions in the client module have some Checkstyle issues. Also, the 
> Javadocs should be extended and enhanced.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes…

2019-08-03 Thread GitBox
Apache-HBase commented on issue #446: HBASE-22781 optimize the test case 
TestStoreScanner.testScanSameTimes…
URL: https://github.com/apache/hbase/pull/446#issuecomment-517932302
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 40 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | -1 | mvninstall | 134 | root in master failed. |
   | +1 | compile | 54 | master passed |
   | +1 | checkstyle | 76 | master passed |
   | +1 | shadedjars | 271 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 32 | master passed |
   | 0 | spotbugs | 242 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 240 | master passed |
   ||| _ Patch Compile Tests _ |
   | -1 | mvninstall | 130 | root in the patch failed. |
   | +1 | compile | 51 | the patch passed |
   | +1 | javac | 51 | the patch passed |
   | +1 | checkstyle | 75 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 274 | patch has no errors when building our shaded 
downstream artifacts. |
   | -1 | hadoopcheck | 90 | The patch causes 10 errors with Hadoop v2.8.5. |
   | -1 | hadoopcheck | 177 | The patch causes 10 errors with Hadoop v2.9.2. |
   | -1 | hadoopcheck | 268 | The patch causes 10 errors with Hadoop v3.1.2. |
   | +1 | javadoc | 30 | the patch passed |
   | +1 | findbugs | 241 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 7826 | hbase-server in the patch passed. |
   | +1 | asflicense | 27 | The patch does not generate ASF License warnings. |
   | | | 9847 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/446 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 28d644d0742a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-446/out/precommit/personality/provided.sh
 |
   | git revision | master / a6f065396a |
   | Default Java | 1.8.0_181 |
   | mvninstall | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/1/artifact/out/branch-mvninstall-root.txt
 |
   | mvninstall | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/1/artifact/out/patch-mvninstall-root.txt
 |
   | hadoopcheck | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/1/artifact/out/patch-javac-2.8.5.txt
 |
   | hadoopcheck | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/1/artifact/out/patch-javac-2.9.2.txt
 |
   | hadoopcheck | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/1/artifact/out/patch-javac-3.1.2.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/1/testReport/
 |
   | Max. process+thread count | 4516 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/1/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose

2019-08-03 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899474#comment-16899474
 ] 

Hudson commented on HBASE-21879:


Results for branch HBASE-21879
[build #197 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/197/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/197//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/197//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/197//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Read HFile's block to ByteBuffer directly instead of to byte for reducing 
> young gc purpose
> --
>
> Key: HBASE-21879
> URL: https://issues.apache.org/jira/browse/HBASE-21879
> Project: HBase
>  Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-21879.v1.patch, HBASE-21879.v1.patch, 
> QPS-latencies-before-HBASE-21879.png, gc-data-before-HBASE-21879.png
>
>
> In HFileBlock#readBlockDataInternal,  we have the following: 
> {code}
> @VisibleForTesting
> protected HFileBlock readBlockDataInternal(FSDataInputStream is, long offset,
> long onDiskSizeWithHeaderL, boolean pread, boolean verifyChecksum, 
> boolean updateMetrics)
>  throws IOException {
>  // .
>   // TODO: Make this ByteBuffer-based. Will make it easier to go to HDFS with 
> BBPool (offheap).
>   byte [] onDiskBlock = new byte[onDiskSizeWithHeader + hdrSize];
>   int nextBlockOnDiskSize = readAtOffset(is, onDiskBlock, preReadHeaderSize,
>   onDiskSizeWithHeader - preReadHeaderSize, true, offset + 
> preReadHeaderSize, pread);
>   if (headerBuf != null) {
> // ...
>   }
>   // ...
>  }
> {code}
> In the read path,  we still read the block from hfile to on-heap byte[], then 
> copy the on-heap byte[] to offheap bucket cache asynchronously,  and in my  
> 100% get performance test, I also observed some frequent young gc,  The 
> largest memory footprint in the young gen should be the on-heap block byte[].
> In fact, we can read HFile's block to ByteBuffer directly instead of to 
> byte[] for reducing young gc purpose. we did not implement this before, 
> because no ByteBuffer reading interface in the older HDFS client, but 2.7+ 
> has supported this now,  so we can fix this now. I think. 
> Will provide an patch and some perf-comparison for this. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (HBASE-22724) Add a emoji on the vote table for pre commit result on github

2019-08-03 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899468#comment-16899468
 ] 

Hudson commented on HBASE-22724:


Results for branch HBASE-22724
[build #2 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22724/2/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22724/2//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22724/2//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22724/2//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Add a emoji on the vote table for pre commit result on github
> -
>
> Key: HBASE-22724
> URL: https://issues.apache.org/jira/browse/HBASE-22724
> Project: HBase
>  Issue Type: Improvement
>Reporter: Duo Zhang
>Priority: Major
>
> [~zghaobac] said that the current vote table on github is not good enough, as 
> the colors are almost the same, it is not easy to find out which line is 
> broken.
> Since github can not change the color of the text, he suggested that we add a 
> column at the left most with some emojis to better notify the developpers.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Comment Edited] (HBASE-22784) OldWALs not cleared in a replication slave cluster (cyclic replication bw 2 clusters)

2019-08-03 Thread Solvannan R M (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899460#comment-16899460
 ] 

Solvannan R M edited comment on HBASE-22784 at 8/3/19 1:07 PM:
---

Hi [~wchevreuil],

Thanks for the reply !

We have managed to extract the following information relating to the issue:

*HBase DFS Usage Report:*

We could see the oldWALs size is very high compared to actual data size
{code:java}
hbaseu...@10.216.xxx.xxx~>./hadoop-2.7.3/bin/hdfs dfs -du -h /hbasedata
0 /hbasedata/.tmp
0 /hbasedata/xx
0 /hbasedata/MasterProcWALs
50.3 G /hbasedata/WALs
0 /hbasedata/archive
0 /hbasedata/corrupt
561.4 G /hbasedata/data
0 /hbasedata/hbase
42 /hbasedata/hbase.id
7 /hbasedata/hbase.version
405.9 G /hbasedata/oldWALs
0 /hbasedata/
0 /hbasedata/
0 /hbasedata/x{code}
 

*Zookeeper myQueuesZnodes:*

The replication queues entries are not cleared from zookeeper for a long time
{code:java}
[zk: 10.216.xxx.xxx:2191,10.216.xxx.xxx:2191,10.216.xxx.xxx:2191(CONNECTED) 3] 
get 
/hbase/replication/rs/10.216.xxx.xxx,16020,1554361253037/3/10.216.xxx.xxx%2C16020%2C1554361253037.1564
Display all 179 possibilities? (y or n)
10.216.xxx.xxx%2C16020%2C1554361253037.1554638617629 
10.216.xxx.xxx%2C16020%2C1554361253037.1554485372383

{code}
 

*Status 'replication' output of the regionserver:*
{code:java}
SOURCE: PeerID=1, AgeOfLastShippedOp=0, SizeOfLogQueue=1, 
TimeStampsOfLastShippedOp=Wed May 01 07:40:55 IST 2019, Replication 
Lag=8158202958 PeerID=3, AgeOfLastShippedOp=0, SizeOfLogQueue=1, 
TimeStampsOfLastShippedOp=Thu Jan 01 05:30:00 IST 1970, Replication 
Lag=1564834858373 SINK : AgeOfLastAppliedOp=378, TimeStampsOfLastAppliedOp=Sat 
Aug 03 17:50:44 IST 2019
{code}
 

*Stacktrace of the replicationSource thread:*

We can see the thread has been blocked for a long time.
{code:java}
"main-EventThread.replicationSource,3.replicationSource.10.216.xxx.xxx%2C16020%2C1554360804184,3"
 #10121291 daemon prio=5 os_prio=0 tid=0x7f00e14ea000 nid=0x6d4c0 waiting 
on condition [0x7ef7598c9000]
java.lang.Thread.State: WAITING (parking)
at sun.misc.Unsafe.park(Native Method)
- parking to wait for <0x7ef8889a1b98> (a 
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
at 
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
at java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
at 
org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReaderThread.take(ReplicationSourceWALReaderThread.java:227)
at 
org.apache.hadoop.hbase.replication.regionserver.ReplicationSource$ReplicationSourceShipperThread.run(ReplicationSource.java:550)
{code}
Kindly let us know if you need any specific logs for your analysis.


was (Author: solvannan):
 

 

Hi [~wchevreuil],

Thanks for the reply !

We have managed to extract the following information relating to the issue:

*HBase DFS Usage Report:*

We could see the oldWALs size is very high compared to actual data size
{code:java}
hbaseu...@10.216.xxx.xxx~>./hadoop-2.7.3/bin/hdfs dfs -du -h /hbasedata
0 /hbasedata/.tmp
0 /hbasedata/xx
0 /hbasedata/MasterProcWALs
50.3 G /hbasedata/WALs
0 /hbasedata/archive
0 /hbasedata/corrupt
561.4 G /hbasedata/data
0 /hbasedata/hbase
42 /hbasedata/hbase.id
7 /hbasedata/hbase.version
405.9 G /hbasedata/oldWALs
0 /hbasedata/
0 /hbasedata/
0 /hbasedata/x{code}
 

*Zookeeper myQueuesZnodes:*

The replication queues entries are not cleared from zookeeper for a long time
{code:java}
[zk: 10.216.xxx.xxx:2191,10.216.xxx.xxx:2191,10.216.xxx.xxx:2191(CONNECTED) 3] 
get 
/hbase/replication/rs/10.216.xxx.xxx,16020,1554361253037/3/10.216.xxx.xxx%2C16020%2C1554361253037.1564
Display all 179 possibilities? (y or n)
10.216.xxx.xxx%2C16020%2C1554361253037.1554638617629 
10.216.xxx.xxx%2C16020%2C1554361253037.1554485372383

{code}
 

 

*Status 'replication' output of the regionserver:*

 
{code:java}
SOURCE: PeerID=1, AgeOfLastShippedOp=0, SizeOfLogQueue=1, 
TimeStampsOfLastShippedOp=Wed May 01 07:40:55 IST 2019, Replication 
Lag=8158202958 PeerID=3, AgeOfLastShippedOp=0, SizeOfLogQueue=1, 
TimeStampsOfLastShippedOp=Thu Jan 01 05:30:00 IST 1970, Replication 
Lag=1564834858373 SINK : AgeOfLastAppliedOp=378, TimeStampsOfLastAppliedOp=Sat 
Aug 03 17:50:44 IST 2019
{code}
 

 

 

*Stacktrace of the replicationSource thread:*

We can see the thread has been blocked for a long time.
{code:java}
"main-EventThread.replicationSource,3.replicationSource.10.216.xxx.xxx%2C16020%2C1554360804184,3"
 #10121291 daemon prio=5 os_prio=0 tid=0x7f00e14ea000 nid=0x6d4c0 waiting 
on condition [0x7ef7598c9000]
java.lang.Thread.State: WAITING (parking)
at sun.misc.Unsafe.park(Native Method)
- parking to wait for <0x7ef8889a1b98> (a 

[jira] [Commented] (HBASE-22784) OldWALs not cleared in a replication slave cluster (cyclic replication bw 2 clusters)

2019-08-03 Thread Solvannan R M (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899460#comment-16899460
 ] 

Solvannan R M commented on HBASE-22784:
---

 

 

Hi [~wchevreuil],

Thanks for the reply !

We have managed to extract the following information relating to the issue:

*HBase DFS Usage Report:*

We could see the oldWALs size is very high compared to actual data size
{code:java}
hbaseu...@10.216.xxx.xxx~>./hadoop-2.7.3/bin/hdfs dfs -du -h /hbasedata
0 /hbasedata/.tmp
0 /hbasedata/xx
0 /hbasedata/MasterProcWALs
50.3 G /hbasedata/WALs
0 /hbasedata/archive
0 /hbasedata/corrupt
561.4 G /hbasedata/data
0 /hbasedata/hbase
42 /hbasedata/hbase.id
7 /hbasedata/hbase.version
405.9 G /hbasedata/oldWALs
0 /hbasedata/
0 /hbasedata/
0 /hbasedata/x{code}
 

*Zookeeper myQueuesZnodes:*

The replication queues entries are not cleared from zookeeper for a long time
{code:java}
[zk: 10.216.xxx.xxx:2191,10.216.xxx.xxx:2191,10.216.xxx.xxx:2191(CONNECTED) 3] 
get 
/hbase/replication/rs/10.216.xxx.xxx,16020,1554361253037/3/10.216.xxx.xxx%2C16020%2C1554361253037.1564
Display all 179 possibilities? (y or n)
10.216.xxx.xxx%2C16020%2C1554361253037.1554638617629 
10.216.xxx.xxx%2C16020%2C1554361253037.1554485372383

{code}
 

 

*Status 'replication' output of the regionserver:*

 
{code:java}
SOURCE: PeerID=1, AgeOfLastShippedOp=0, SizeOfLogQueue=1, 
TimeStampsOfLastShippedOp=Wed May 01 07:40:55 IST 2019, Replication 
Lag=8158202958 PeerID=3, AgeOfLastShippedOp=0, SizeOfLogQueue=1, 
TimeStampsOfLastShippedOp=Thu Jan 01 05:30:00 IST 1970, Replication 
Lag=1564834858373 SINK : AgeOfLastAppliedOp=378, TimeStampsOfLastAppliedOp=Sat 
Aug 03 17:50:44 IST 2019
{code}
 

 

 

*Stacktrace of the replicationSource thread:*

We can see the thread has been blocked for a long time.
{code:java}
"main-EventThread.replicationSource,3.replicationSource.10.216.xxx.xxx%2C16020%2C1554360804184,3"
 #10121291 daemon prio=5 os_prio=0 tid=0x7f00e14ea000 nid=0x6d4c0 waiting 
on condition [0x7ef7598c9000]
java.lang.Thread.State: WAITING (parking)
at sun.misc.Unsafe.park(Native Method)
- parking to wait for <0x7ef8889a1b98> (a 
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
at 
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
at java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
at 
org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReaderThread.take(ReplicationSourceWALReaderThread.java:227)
at 
org.apache.hadoop.hbase.replication.regionserver.ReplicationSource$ReplicationSourceShipperThread.run(ReplicationSource.java:550)
{code}
**Kindly let us know if you need any specific logs for your analysis.

 

 

> OldWALs not cleared in a replication slave cluster (cyclic replication bw 2 
> clusters)
> -
>
> Key: HBASE-22784
> URL: https://issues.apache.org/jira/browse/HBASE-22784
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver, Replication
>Affects Versions: 1.4.9, 1.4.10
>Reporter: Solvannan R M
>Priority: Major
>
> When a cluster is passive (receiving edits only via replication) in a cyclic 
> replication setup of 2 clusters, OldWALs size keeps on growing. On analysing, 
> we observed the following behaviour.
>  # New entry is added to WAL (Edit replicated from other cluster).
>  # ReplicationSourceWALReaderThread(RSWALRT) reads and applies the configured 
> filters (due to cyclic replication setup, ClusterMarkingEntryFilter discards 
> new entry from other cluster).
>  # Entry is null, RSWALRT neither updates the batch stats 
> (WALEntryBatch.lastWalPosition) nor puts it in the entryBatchQueue.
>  # ReplicationSource thread is blocked in entryBachQueue.take().
>  # So ReplicationSource#updateLogPosition has never invoked and WAL file is 
> never cleared from ReplicationQueue.
>  # Hence LogCleaner on the master, doesn't deletes the oldWAL files from 
> hadoop.
> NOTE: When a new edit is added via hbase-client, ReplicationSource thread 
> process and clears the oldWAL files from replication queues and hence master 
> cleans up the WALs
> Please provide us a solution
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] Apache9 commented on issue #437: HBASE-22539 WAL corruption due to early DBBs re-use when Durability.A…

2019-08-03 Thread GitBox
Apache9 commented on issue #437: HBASE-22539 WAL corruption due to early DBBs 
re-use when Durability.A…
URL: https://github.com/apache/hbase/pull/437#issuecomment-517922247
 
 
   The failed UT is unrelated. @openinx @wchevreuil Any other concerns? This is 
a critical bug, we should roll new releases soon.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22781) Not suitable params of StoreScanner in the test case TestStoreScanner.testScanSameTimestamp

2019-08-03 Thread Duo Zhang (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899457#comment-16899457
 ] 

Duo Zhang commented on HBASE-22781:
---

I think this is what we expect? For different timestamps obviously we will 
return the one with greater timestamp, as the default maxVersions is 1. Here we 
just want to confirm that even if we have same timestamps, we will still return 
only one kv.

> Not suitable params of StoreScanner in the test case 
> TestStoreScanner.testScanSameTimestamp
> ---
>
> Key: HBASE-22781
> URL: https://issues.apache.org/jira/browse/HBASE-22781
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.0.0
>Reporter: Zheng Wang
>Assignee: Zheng Wang
>Priority: Minor
>
> {code:java}
> public void testScanSameTimestamp() throws IOException {
>   // returns only 1 of these 2 even though same timestamp
>   KeyValue [] kvs = new KeyValue[] {
>   create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
>   create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
>   };
>   List scanners = Arrays.asList(
>   new KeyValueScanner[] {
>   new KeyValueScanFixture(CellComparator.getInstance(), kvs)
>   });
>   Scan scanSpec = new Scan().withStartRow(Bytes.toBytes("R1"));
>   // this only uses maxVersions (default=1) and TimeRange (default=all)
>   try (StoreScanner scan = new StoreScanner(scanSpec, scanInfo, getCols("a"), 
> scanners)) {
> List results = new ArrayList<>();
> assertEquals(true, scan.next(results));
> assertEquals(1, results.size());
> assertEquals(kvs[0], results.get(0));
>   }
> }
> {code}
>  
>  It will not to compare the timestamp of the two cells,because of the 
> 'getCols("a")' limit only one column and one version(default).
> For example,modify the timestamp of the first cell to 2 can also pass.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] bsglz opened a new pull request #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes…

2019-08-03 Thread GitBox
bsglz opened a new pull request #446: HBASE-22781 optimize the test case 
TestStoreScanner.testScanSameTimes…
URL: https://github.com/apache/hbase/pull/446
 
 
   …tamp


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase

2019-08-03 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899442#comment-16899442
 ] 

Hudson commented on HBASE-22514:


Results for branch HBASE-22514
[build #44 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/44/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/44//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/44//JDK8_Nightly_Build_Report_(Hadoop2)/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/44//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
>  Issue Type: Umbrella
>  Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch, 
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public 
> we need to use java api  RSGroupAdminClient  to manager RSG 
> so  RSGroupAdminClient should be public
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (HBASE-22728) Upgrade jackson dependencies in branch-1

2019-08-03 Thread Viraj Jasani (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899436#comment-16899436
 ] 

Viraj Jasani commented on HBASE-22728:
--

The above unit test failure is not observed in local:
{code:java}
[INFO] ---

[INFO]  T E S T S

[INFO] ---

[INFO] Running org.apache.hadoop.hbase.io.hfile.bucket.TestBucketCache

[INFO] Tests run: 30, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.903 
s - in org.apache.hadoop.hbase.io.hfile.bucket.TestBucketCache

[INFO]

[INFO] Results:

[INFO]

[INFO] Tests run: 30, Failures: 0, Errors: 0, Skipped: 0
{code}

> Upgrade jackson dependencies in branch-1
> 
>
> Key: HBASE-22728
> URL: https://issues.apache.org/jira/browse/HBASE-22728
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 1.4.10, 1.3.5
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22728.branch-1.01.patch, 
> HBASE-22728.branch-1.02.patch, HBASE-22728.branch-1.04.patch, 
> HBASE-22728.branch-1.06.patch, dependency_codehaus.out
>
>
> Avoid Jackson versions and dependencies with known CVEs



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[GitHub] [hbase] anoopsjohn commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend

2019-08-03 Thread GitBox
anoopsjohn commented on issue #390: HBASE-22623 - Add RegionObserver 
coprocessor hook for preWALAppend
URL: https://github.com/apache/hbase/pull/390#issuecomment-517914221
 
 
   > > I have not yet incorporated @apurtell 's suggestion to add WALEdit to 
the coprocessor hook, because of the InterfaceAudience.Private notations on 
WALEdit.add
   > 
   > Change the annotation. Raise it here and on the JIRA for feedback. If 
someone does object, then the path forward is clear.
   > 
   > > I personally don't see an issue with adding WALEdit to the coproc (if 
it's OK to write a coproc that adds a column to every Put, why not a coproc 
that adds a Cell to every WALEdit?), but it's not necessary for my purposes, 
and I don't want to add it in just to find out that I need to take it out after 
all.
   > 
   > I do not want to be in the position in the future, now that we are going 
to the trouble of adding a hook, to find out that it is not suitable for 
someone else only because we didn't have the foresight to add WALedit to the 
method signature. It is impossible to know of course all possible potential 
future use cases but this one seems somewhat obvious by omission. @gjacoby126 
@anoopsjohn
   
   You have a point @apurtell .   Ya raise this point in Jira comment for 
better discussion.  For adding extra cells into the WALEdit for an op, there is 
way if used multi/bachMutate() API..  But checking the flow and CP usage for 
append/increment kind of APIs seems that is not really possible.   Also we have 
some other points.. Let m write details under Jira comment.  Same Jira or new 
one for this WALEdit.  The aim is this... For all write APIs there should be 
way to add extra cells in WALEdit alone!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22728) Upgrade jackson dependencies in branch-1

2019-08-03 Thread HBase QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899409#comment-16899409
 ] 

HBase QA commented on HBASE-22728:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 14m 
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
41s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
53s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  4m  
9s{color} | {color:green} branch-1 passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  5m 
15s{color} | {color:green} branch-1 passed with JDK v1.7.0_232 {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  2m 
42s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  3m 
18s{color} | {color:green} branch-1 passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  5m 
48s{color} | {color:green} branch-1 passed with JDK v1.7.0_232 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  4m 
36s{color} | {color:green} the patch passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  4m 
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  5m 
51s{color} | {color:green} the patch passed with JDK v1.7.0_232 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  5m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} xml {color} | {color:red}  0m  3s{color} | 
{color:red} The patch has 19 ill-formed XML file(s). {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  2m 
37s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}  
3m 40s{color} | {color:green} Patch does not cause any errors with Hadoop 2.8.5 
2.9.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  3m 
48s{color} | {color:green} the patch passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  6m  
3s{color} | {color:green} the patch passed with JDK v1.7.0_232 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
29s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  4m  
2s{color} | {color:green} hbase-procedure in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
35s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
32s{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
30s{color} | {color:green} hbase-prefix-tree in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 30m 22s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
19s{color} | 

[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase

2019-08-03 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899397#comment-16899397
 ] 

Hudson commented on HBASE-22514:


Results for branch HBASE-22514
[build #43 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/43/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/43//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/43//JDK8_Nightly_Build_Report_(Hadoop2)/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/43//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
>  Issue Type: Umbrella
>  Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch, 
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public 
> we need to use java api  RSGroupAdminClient  to manager RSG 
> so  RSGroupAdminClient should be public
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)