[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-522865609 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 42 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 321 | master passed | | +1 | compile | 25 | master passed | | +1 | checkstyle | 13 | master passed | | +1 | shadedjars | 259 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 23 | master passed | | 0 | spotbugs | 47 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 44 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 290 | the patch passed | | +1 | compile | 23 | the patch passed | | +1 | javac | 23 | the patch passed | | +1 | checkstyle | 12 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 264 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 904 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 20 | the patch passed | | +1 | findbugs | 50 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 310 | hbase-rsgroup in the patch failed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 2975 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.rsgroup.TestRSGroupsAdmin2 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/104/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux aa975c069d22 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / a59f7d4ffc | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/104/artifact/out/patch-unit-hbase-rsgroup.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/104/testReport/ | | Max. process+thread count | 4535 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/104/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #476: HBASE-11062 hbtop
saintstack commented on a change in pull request #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#discussion_r315508621 ## File path: hbase-hbtop/README.md ## @@ -0,0 +1,247 @@ + + +# hbtop + +## Overview + +`hbtop` is a real-time monitoring tool for HBase like Unix's top command. +It can display summary information as well as metrics per Region/Namespace/Table/RegionServer. +In this tool, you can see the metrics sorted by a selected field and filter the metrics to see only metrics you really want to see. +Also, with the drill-down feature, you can find hot regions easily in a top-down manner. + +## Usage + +You can run hbtop by the following command: + +``` +$ hbase top +``` + +Also, you can specify your own zookeeper quorum and znode parent like the following: + +``` +$ hbase top -Dhbase.client.zookeeper.quorum= -Dzookeeper.znode.parent= +``` + + + +The top screen consists of the summary part and the metrics part. +In the summary part, you can see `HBase Version`, `Cluster ID`, `The number of region servers`, `Region count`, `Average Cluster Load` and `Aggregated Request/s`. +In the metrics part, you can see metrics per Region/Namespace/Table/RegionServer depending on the selected mode. +The top screen is refreshed in a certain period – 3 seconds by default. + +### Scrolling metric records + +You can scroll the metric records in the metrics part. + + + +### Command line arguments + +| Argument | Description | +|---|---| +| -delay arg | The refresh delay (in seconds); default is 3 seconds | +| -help | Print usage; for help while the tool is running press `h` key | +| -mode arg | The mode; `n` (Namespace)`t` (Table)r (Region)`s` (RegionServer), default is `r` (Region) | + +### Modes + +There are the following 4 modes in hbtop: + +| Mode | Description | +|---|---| +| Region | Showing metric records per region | +| Namespace | Showing metric records per namespace | +| Table | Showing metric records per table | +| RegionServer | Showing metric records per region server | + + Region mode + +In Region mode, the default sort field is `#REQ/S`. + +The fields in this mode are as follows: + +| Field | Description | Displayed by default | +|---|---|---| +| RNAME | Region Name | false | +| NAMESPACE | Namespace Name | true | +| TABLE | Table Name | true | +| SCODE | Start Code | false | +| REPID | Replica ID | false | +| REGION | Encoded Region Name | true | +| RS | Short Region Server Name | true | +| LRS | Long Region Server Name | false | +| #REQ/S | Request Count per second | true | +| #READ/S | Read Request Count per second | true | +| #FREAD/S | Filtered Read Request Count per second | true | +| #WRITE/S | Write Request Count per second | true | +| SF | StoreFile Size | true | +| USF | Uncompressed StoreFile Size | false | +| #SF | Number of StoreFiles | true | +| MEMSTORE | MemStore Size | true | +| LOCALITY | Block Locality | true | +| SKEY | Start Key | false | +| #COMPingCELL | Compacting Cell Count | false | +| #COMPedCELL | Compacted Cell Count | false | +| %COMP | Compaction Progress | false | +| LASTMCOMP | Last Major Compaction Time | false | + + Namespace mode + +In Namespace mode, the default sort field is `#REQ/S`. + +The fields in this mode are as follows: + +| Field | Description | Displayed by default | +|---|---|---| +| NAMESPACE | Namespace Name | true | +| #REGION | Region Count | true | +| #REQ/S | Request Count per second | true | +| #READ/S | Read Request Count per second | true | +| #FREAD/S | Filtered Read Request Count per second | true | +| #WRITE/S | Write Request Count per second | true | +| SF | StoreFile Size | true | +| USF | Uncompressed StoreFile Size | false | +| #SF | Number of StoreFiles | true | +| MEMSTORE | MemStore Size | true | + + Table mode + +In Table mode, the default sort field is `#REQ/S`. + +The fields in this mode are as follows: + +| Field | Description | Displayed by default | +|---|---|---| +| NAMESPACE | Namespace Name | true | +| TABLE | Table Name | true | +| #REGION | Region Count | true | +| #REQ/S | Request Count per second | true | +| #READ/S | Read Request Count per second | true | +| #FREAD/S | Filtered Read Request Count per second | true | +| #WRITE/S | Write Request Count per second | true | +| SF | StoreFile Size | true | +| USF | Uncompressed StoreFile Size | false | +| #SF | Number of StoreFiles | true | +| MEMSTORE | MemStore Size | true | + + RegionServer mode + +In RegionServer mode, the default sort field is `#REQ/S`. + +The fields in this mode are as follows: + +| Field | Description | Displayed by default | +|---|---|---| +| RS | Short Region Server Name | true | +| LRS | Long Region Server Name | false | +| #REGION | Region Count | true | +| #REQ/S | Request Count per second | true | +| #READ/S | Read Request Count per second | true |
[GitHub] [hbase] saintstack commented on a change in pull request #476: HBASE-11062 hbtop
saintstack commented on a change in pull request #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#discussion_r315316487 ## File path: hbase-hbtop/README.md ## @@ -0,0 +1,247 @@ + + +# hbtop + +## Overview + +`hbtop` is a real-time monitoring tool for HBase like Unix's top command. +It can display summary information as well as metrics per Region/Namespace/Table/RegionServer. +In this tool, you can see the metrics sorted by a selected field and filter the metrics to see only metrics you really want to see. +Also, with the drill-down feature, you can find hot regions easily in a top-down manner. + +## Usage + +You can run hbtop by the following command: Review comment: s/by/with/g This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #476: HBASE-11062 hbtop
saintstack commented on a change in pull request #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#discussion_r315506547 ## File path: hbase-hbtop/README.md ## @@ -0,0 +1,247 @@ + + +# hbtop + +## Overview + +`hbtop` is a real-time monitoring tool for HBase like Unix's top command. +It can display summary information as well as metrics per Region/Namespace/Table/RegionServer. +In this tool, you can see the metrics sorted by a selected field and filter the metrics to see only metrics you really want to see. +Also, with the drill-down feature, you can find hot regions easily in a top-down manner. + +## Usage + +You can run hbtop by the following command: + +``` +$ hbase top +``` + +Also, you can specify your own zookeeper quorum and znode parent like the following: + +``` +$ hbase top -Dhbase.client.zookeeper.quorum= -Dzookeeper.znode.parent= +``` + + + +The top screen consists of the summary part and the metrics part. Review comment: s/the/a/ as in "of a summary part and of a metrics part." This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #476: HBASE-11062 hbtop
saintstack commented on a change in pull request #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#discussion_r315510199
##
File path: hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/Record.java
##
@@ -0,0 +1,180 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.hbtop;
+
+import java.util.Collection;
+import java.util.Collections;
+import java.util.EnumMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Stream;
+import javax.validation.constraints.NotNull;
+import org.apache.hadoop.hbase.hbtop.field.Field;
+import org.apache.hadoop.hbase.hbtop.field.FieldValue;
+import org.apache.yetus.audience.InterfaceAudience;
+
+
+/**
+ * Represents a record of the metrics in the top screen.
+ */
+@InterfaceAudience.Private
+public class Record implements Map {
+
+ private Map values;
+
+ public static final class Entry implements Map.Entry {
+private final Field key;
+private FieldValue value;
+
+private Entry(Field key, FieldValue value) {
+ this.key = Objects.requireNonNull(key);
+ this.value = Objects.requireNonNull(value);
+}
+
+@Override
+public Field getKey() {
+ return key;
+}
+
+@Override
+public FieldValue getValue() {
+ return value;
+}
+
+@Override
+public FieldValue setValue(FieldValue value) {
+ FieldValue oldValue = this.value;
+ this.value = value;
+ return oldValue;
+}
+ }
+
+ public static Entry entry(Field field, Object value) {
+return new Entry(field, field.newValue(value));
+ }
+
+ public static Entry entry(Field field, FieldValue value) {
+return new Entry(field, value);
+ }
+
+ public static Record ofEntries(List entries) {
+return ofEntries(entries.stream());
+ }
+
+ public static Record ofEntries(Entry... entries) {
+return ofEntries(Stream.of(entries));
+ }
+
+ public static Record ofEntries(Stream entries) {
+return entries
+ .collect(Record::new, (r, e) -> r.put(e.getKey(), e.getValue()), (r1,
r2) -> {});
+ }
+
+ public Record() {
+this(new EnumMap<>(Field.class));
+ }
+
+ private Record(Map values) {
+this.values = values;
+ }
+
+ @Override
+ public int size() {
+return values.size();
+ }
+
+ @Override
+ public boolean isEmpty() {
+return values.isEmpty();
+ }
+
+ @Override
+ public boolean containsKey(Object key) {
+return values.containsKey(key);
+ }
+
+ @Override
+ public boolean containsValue(Object value) {
+return values.containsValue(value);
+ }
+
+ @Override
+ public FieldValue get(Object key) {
+return values.get(key);
+ }
+
+ @Override
+ public FieldValue put(Field key, FieldValue value) {
+return values.put(key, value);
+ }
+
+ public FieldValue put(Field key, Object value) {
+return values.put(key, key.newValue(value));
+ }
+
+ @Override
+ public FieldValue remove(Object key) {
+return values.remove(key);
+ }
+
+ @Override
+ public void putAll(@NotNull Map m) {
+values.putAll(m);
+ }
+
+ @Override
+ public void clear() {
+values.clear();
+ }
+
+ @Override
+ @NotNull
+ public Set keySet() {
+return values.keySet();
+ }
+
+ @Override
+ @NotNull
+ public Collection values() {
+return values.values();
+ }
+
+ @Override
+ @NotNull
+ public Set> entrySet() {
+return values.entrySet();
+ }
+
+ public Record combine(Record o) {
+return ofEntries(values.keySet().stream()
+ .map(k -> {
+switch (k.getFieldValueType()) {
+ case STRING:
+return entry(k, values.get(k));
+ default:
+return entry(k, values.get(k).plus(o.values.get(k)));
+}
+ }));
+ }
+
+ public Record toImmutable() {
+return new Record(Collections.unmodifiableMap(values));
+ }
+}
Review comment:
Back here again. This is good. I like how it implements Map.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries
[GitHub] [hbase] saintstack commented on a change in pull request #476: HBASE-11062 hbtop
saintstack commented on a change in pull request #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#discussion_r315514142
##
File path:
hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/terminal/Terminal.java
##
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.hbtop.terminal;
+
+import edu.umd.cs.findbugs.annotations.Nullable;
+import java.io.Closeable;
+import org.apache.yetus.audience.InterfaceAudience;
+
+
+/**
+ * The terminal interface that is an abstraction of terminal screen.
+ */
+@InterfaceAudience.Private
+public interface Terminal extends Closeable {
+ void clear();
+ void refresh();
+ TerminalSize getSize();
+ @Nullable TerminalSize doResizeIfNecessary();
+ @Nullable KeyPress pollKeyPress();
+ CursorPosition getCursorPosition();
+ void setCursorPosition(int column, int row);
+ void hideCursor();
+ TerminalPrinter getTerminalPrinter(int startRow);
+}
Review comment:
There is terminal in jline... Would it work for this? Follow-on.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #476: HBASE-11062 hbtop
saintstack commented on a change in pull request #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#discussion_r315507748 ## File path: hbase-hbtop/README.md ## @@ -0,0 +1,247 @@ + + +# hbtop + +## Overview + +`hbtop` is a real-time monitoring tool for HBase like Unix's top command. +It can display summary information as well as metrics per Region/Namespace/Table/RegionServer. +In this tool, you can see the metrics sorted by a selected field and filter the metrics to see only metrics you really want to see. +Also, with the drill-down feature, you can find hot regions easily in a top-down manner. + +## Usage + +You can run hbtop by the following command: + +``` +$ hbase top +``` + +Also, you can specify your own zookeeper quorum and znode parent like the following: + +``` +$ hbase top -Dhbase.client.zookeeper.quorum= -Dzookeeper.znode.parent= +``` + + + +The top screen consists of the summary part and the metrics part. +In the summary part, you can see `HBase Version`, `Cluster ID`, `The number of region servers`, `Region count`, `Average Cluster Load` and `Aggregated Request/s`. +In the metrics part, you can see metrics per Region/Namespace/Table/RegionServer depending on the selected mode. +The top screen is refreshed in a certain period – 3 seconds by default. + +### Scrolling metric records + +You can scroll the metric records in the metrics part. + + + +### Command line arguments + +| Argument | Description | +|---|---| +| -delay arg | The refresh delay (in seconds); default is 3 seconds | +| -help | Print usage; for help while the tool is running press `h` key | +| -mode arg | The mode; `n` (Namespace)`t` (Table)r (Region)`s` (RegionServer), default is `r` (Region) | + +### Modes + +There are the following 4 modes in hbtop: + +| Mode | Description | +|---|---| +| Region | Showing metric records per region | +| Namespace | Showing metric records per namespace | +| Table | Showing metric records per table | +| RegionServer | Showing metric records per region server | + + Region mode + +In Region mode, the default sort field is `#REQ/S`. + +The fields in this mode are as follows: + +| Field | Description | Displayed by default | +|---|---|---| +| RNAME | Region Name | false | +| NAMESPACE | Namespace Name | true | +| TABLE | Table Name | true | +| SCODE | Start Code | false | +| REPID | Replica ID | false | +| REGION | Encoded Region Name | true | +| RS | Short Region Server Name | true | +| LRS | Long Region Server Name | false | +| #REQ/S | Request Count per second | true | +| #READ/S | Read Request Count per second | true | +| #FREAD/S | Filtered Read Request Count per second | true | +| #WRITE/S | Write Request Count per second | true | +| SF | StoreFile Size | true | +| USF | Uncompressed StoreFile Size | false | +| #SF | Number of StoreFiles | true | +| MEMSTORE | MemStore Size | true | +| LOCALITY | Block Locality | true | +| SKEY | Start Key | false | +| #COMPingCELL | Compacting Cell Count | false | +| #COMPedCELL | Compacted Cell Count | false | +| %COMP | Compaction Progress | false | +| LASTMCOMP | Last Major Compaction Time | false | + + Namespace mode + +In Namespace mode, the default sort field is `#REQ/S`. + +The fields in this mode are as follows: + +| Field | Description | Displayed by default | +|---|---|---| +| NAMESPACE | Namespace Name | true | +| #REGION | Region Count | true | +| #REQ/S | Request Count per second | true | +| #READ/S | Read Request Count per second | true | +| #FREAD/S | Filtered Read Request Count per second | true | +| #WRITE/S | Write Request Count per second | true | +| SF | StoreFile Size | true | +| USF | Uncompressed StoreFile Size | false | +| #SF | Number of StoreFiles | true | +| MEMSTORE | MemStore Size | true | + + Table mode + +In Table mode, the default sort field is `#REQ/S`. + +The fields in this mode are as follows: + +| Field | Description | Displayed by default | +|---|---|---| +| NAMESPACE | Namespace Name | true | +| TABLE | Table Name | true | +| #REGION | Region Count | true | +| #REQ/S | Request Count per second | true | +| #READ/S | Read Request Count per second | true | +| #FREAD/S | Filtered Read Request Count per second | true | +| #WRITE/S | Write Request Count per second | true | +| SF | StoreFile Size | true | +| USF | Uncompressed StoreFile Size | false | +| #SF | Number of StoreFiles | true | +| MEMSTORE | MemStore Size | true | + + RegionServer mode + +In RegionServer mode, the default sort field is `#REQ/S`. + +The fields in this mode are as follows: + +| Field | Description | Displayed by default | +|---|---|---| +| RS | Short Region Server Name | true | +| LRS | Long Region Server Name | false | +| #REGION | Region Count | true | +| #REQ/S | Request Count per second | true | +| #READ/S | Read Request Count per second | true |
[GitHub] [hbase] saintstack commented on a change in pull request #476: HBASE-11062 hbtop
saintstack commented on a change in pull request #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#discussion_r315316703 ## File path: hbase-hbtop/README.md ## @@ -0,0 +1,247 @@ + + +# hbtop + +## Overview + +`hbtop` is a real-time monitoring tool for HBase like Unix's top command. +It can display summary information as well as metrics per Region/Namespace/Table/RegionServer. +In this tool, you can see the metrics sorted by a selected field and filter the metrics to see only metrics you really want to see. +Also, with the drill-down feature, you can find hot regions easily in a top-down manner. + +## Usage + +You can run hbtop by the following command: + +``` +$ hbase top +``` + +Also, you can specify your own zookeeper quorum and znode parent like the following: Review comment: s/like the following/as follows/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #476: HBASE-11062 hbtop
saintstack commented on a change in pull request #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#discussion_r315514496
##
File path:
hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/terminal/Terminal.java
##
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.hbtop.terminal;
+
+import edu.umd.cs.findbugs.annotations.Nullable;
+import java.io.Closeable;
+import org.apache.yetus.audience.InterfaceAudience;
+
+
+/**
+ * The terminal interface that is an abstraction of terminal screen.
+ */
+@InterfaceAudience.Private
+public interface Terminal extends Closeable {
+ void clear();
+ void refresh();
+ TerminalSize getSize();
+ @Nullable TerminalSize doResizeIfNecessary();
+ @Nullable KeyPress pollKeyPress();
+ CursorPosition getCursorPosition();
+ void setCursorPosition(int column, int row);
+ void hideCursor();
+ TerminalPrinter getTerminalPrinter(int startRow);
+}
Review comment:
Or something like this...
https://github.com/JetBrains/jediterm/blob/master/terminal/src/com/jediterm/terminal/Terminal.java
from the jetbrains terminal emulator...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #476: HBASE-11062 hbtop
saintstack commented on a change in pull request #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#discussion_r315514070
##
File path:
hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/terminal/KeyPress.java
##
@@ -0,0 +1,128 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.hbtop.terminal;
+
+import edu.umd.cs.findbugs.annotations.Nullable;
+import java.util.Objects;
+import org.apache.yetus.audience.InterfaceAudience;
+
+
+/**
+ * Represents the user pressing a key on the keyboard.
+ */
+@InterfaceAudience.Private
+public class KeyPress {
+ public enum Type {
+Character,
+Escape,
+Backspace,
+ArrowLeft,
+ArrowRight,
+ArrowUp,
+ArrowDown,
+Insert,
+Delete,
+Home,
+End,
+PageUp,
+PageDown,
+ReverseTab,
+Tab,
+Enter,
+F1,
+F2,
+F3,
+F4,
+F5,
+F6,
+F7,
+F8,
+F9,
+F10,
+F11,
+F12,
+Unknown
+ }
Review comment:
Yeah, pity couldn't use a terminal lib of some sort. Maybe that'd be a
follow-on?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #476: HBASE-11062 hbtop
saintstack commented on a change in pull request #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#discussion_r315509515
##
File path: hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/Record.java
##
@@ -0,0 +1,180 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.hbtop;
+
+import java.util.Collection;
+import java.util.Collections;
+import java.util.EnumMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Stream;
+import javax.validation.constraints.NotNull;
+import org.apache.hadoop.hbase.hbtop.field.Field;
+import org.apache.hadoop.hbase.hbtop.field.FieldValue;
+import org.apache.yetus.audience.InterfaceAudience;
+
+
+/**
+ * Represents a record of the metrics in the top screen.
+ */
+@InterfaceAudience.Private
+public class Record implements Map {
+
+ private Map values;
+
+ public static final class Entry implements Map.Entry {
+private final Field key;
+private FieldValue value;
Review comment:
Otherwise, will this be read by multiple threads? I suppose it not important
if thread reads an old value because it doesn't notice change made by another
thread?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #476: HBASE-11062 hbtop
saintstack commented on a change in pull request #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#discussion_r315510952
##
File path:
hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/field/FieldValueType.java
##
@@ -0,0 +1,29 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.hbtop.field;
+
+import org.apache.yetus.audience.InterfaceAudience;
+
+
+/**
+ * Represents the type of a {@link FieldValue}.
+ */
+@InterfaceAudience.Private
+public enum FieldValueType {
+ STRING, INTEGER, LONG, FLOAT, SIZE, PERCENT
Review comment:
Almost sql types...
https://docs.oracle.com/javase/8/docs/api/java/sql/Types.html
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #476: HBASE-11062 hbtop
saintstack commented on a change in pull request #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#discussion_r315509008
##
File path: hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/HBTop.java
##
@@ -0,0 +1,141 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.hbtop;
+
+import java.io.InputStream;
+import java.util.Objects;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.conf.Configured;
+import org.apache.hadoop.hbase.HBaseConfiguration;
+import org.apache.hadoop.hbase.hbtop.mode.Mode;
+import org.apache.hadoop.hbase.hbtop.screen.Screen;
+import org.apache.hadoop.util.Tool;
+import org.apache.hadoop.util.ToolRunner;
+import org.apache.log4j.PropertyConfigurator;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hbase.thirdparty.org.apache.commons.cli.CommandLine;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.DefaultParser;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.HelpFormatter;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.Options;
+
+
+/**
+ * A real-time monitoring tool for HBase like Unix top command.
+ */
+@InterfaceAudience.Private
+public class HBTop extends Configured implements Tool {
+
+ private static final Logger LOGGER = LoggerFactory.getLogger(HBTop.class);
+
+ public HBTop() {
+this(HBaseConfiguration.create());
+ }
+
+ public HBTop(Configuration conf) {
+super(Objects.requireNonNull(conf));
+ }
+
+ @Override
+ public int run(String[] args) throws Exception {
+// In order to change the log level forcibly, read a custom log4j
configuration file
+InputStream log4jConfigInputStream = this.getClass().getClassLoader()
+ .getResourceAsStream("log4j-hbtop.properties");
+PropertyConfigurator.configure(log4jConfigInputStream);
+
+long initialRefreshDelay = 3 * 1000;
+Mode initialMode = Mode.REGION;
+try {
+ // Command line options
+ Options opts = new Options();
+ opts.addOption("help", false,
+"Print usage; for help while the tool is running press 'h'");
+ opts.addOption("delay", true,
+"The refresh delay (in seconds); default is 3 seconds");
Review comment:
On this delay, the master is only going to get ClusterMetrics at a
particular rate from RegionServers. A refresh of this client that happens more
frequently than Master update will show no changes?
I suppose users of top are used to this... If no change since last refresh,
they just deal.
Just a comment. Ignore.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #487: HBASE-22844 Fixed Checkstyle violations in client snapshot exceptions
Apache-HBase commented on issue #487: HBASE-22844 Fixed Checkstyle violations in client snapshot exceptions URL: https://github.com/apache/hbase/pull/487#issuecomment-522864610 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 169 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 409 | master passed | | +1 | compile | 28 | master passed | | +1 | checkstyle | 36 | master passed | | +1 | shadedjars | 283 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 24 | master passed | | 0 | spotbugs | 94 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 85 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 319 | the patch passed | | +1 | compile | 23 | the patch passed | | +1 | javac | 23 | the patch passed | | +1 | checkstyle | 28 | hbase-client: The patch generated 0 new + 0 unchanged - 13 fixed = 0 total (was 13) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 322 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 953 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 | javadoc | 20 | hbase-client generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) | | +1 | findbugs | 79 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 104 | hbase-client in the patch passed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 3305 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/20/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/487 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 44ef2a04058d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-487/out/precommit/personality/provided.sh | | git revision | master / a59f7d4ffc | | Default Java | 1.8.0_181 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/20/artifact/out/diff-javadoc-javadoc-hbase-client.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/20/testReport/ | | Max. process+thread count | 290 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/20/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #476: HBASE-11062 hbtop
saintstack commented on a change in pull request #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#discussion_r315513295
##
File path:
hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/mode/ModeStrategy.java
##
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.hbtop.mode;
+
+import edu.umd.cs.findbugs.annotations.Nullable;
+import java.util.List;
+import org.apache.hadoop.hbase.ClusterMetrics;
+import org.apache.hadoop.hbase.hbtop.Record;
+import org.apache.hadoop.hbase.hbtop.field.Field;
+import org.apache.hadoop.hbase.hbtop.field.FieldInfo;
+import org.apache.yetus.audience.InterfaceAudience;
+
+
+/**
+ * An interface for strategy logic for {@link Mode}.
+ */
+@InterfaceAudience.Private
+interface ModeStrategy {
+ List getFieldInfos();
+ Field getDefaultSortField();
+ List getRecords(ClusterMetrics clusterMetrics);
+ @Nullable DrillDownInfo drillDown(Record selectedRecord);
+}
Review comment:
Tried looking.
This has right license but doesn't help https://github.com/beryx/text-io
Article intro'ing it was kinda good though
https://dzone.com/articles/interactive-console-applications-in-java
Laterna looks ideal but has the licensing problem you already turned up.
http://www.pitman.co.za/projects/charva/Licence.html looked good but similar
licensing issue.
https://sourceforge.net/projects/javacurses/files/ is too old.
https://github.com/jline/jline3 has some help but not enough?
Yeah, I don't know enough about this console domain.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #476: HBASE-11062 hbtop
saintstack commented on a change in pull request #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#discussion_r315509334
##
File path: hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/Record.java
##
@@ -0,0 +1,180 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.hbtop;
+
+import java.util.Collection;
+import java.util.Collections;
+import java.util.EnumMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Stream;
+import javax.validation.constraints.NotNull;
+import org.apache.hadoop.hbase.hbtop.field.Field;
+import org.apache.hadoop.hbase.hbtop.field.FieldValue;
+import org.apache.yetus.audience.InterfaceAudience;
+
+
+/**
+ * Represents a record of the metrics in the top screen.
+ */
+@InterfaceAudience.Private
+public class Record implements Map {
+
+ private Map values;
+
+ public static final class Entry implements Map.Entry {
+private final Field key;
+private FieldValue value;
Review comment:
This is settable making this object mutable. Would it be better if objects
of this class were immutable? Just create a new instance when value changes? Or
will that make it more complicated because this Entity is in a chain of
Entities?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #476: HBASE-11062 hbtop
saintstack commented on a change in pull request #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#discussion_r315507850 ## File path: hbase-hbtop/README.md ## @@ -0,0 +1,247 @@ + + +# hbtop + +## Overview + +`hbtop` is a real-time monitoring tool for HBase like Unix's top command. +It can display summary information as well as metrics per Region/Namespace/Table/RegionServer. +In this tool, you can see the metrics sorted by a selected field and filter the metrics to see only metrics you really want to see. +Also, with the drill-down feature, you can find hot regions easily in a top-down manner. + +## Usage + +You can run hbtop by the following command: + +``` +$ hbase top +``` + +Also, you can specify your own zookeeper quorum and znode parent like the following: + +``` +$ hbase top -Dhbase.client.zookeeper.quorum= -Dzookeeper.znode.parent= +``` + + + +The top screen consists of the summary part and the metrics part. +In the summary part, you can see `HBase Version`, `Cluster ID`, `The number of region servers`, `Region count`, `Average Cluster Load` and `Aggregated Request/s`. +In the metrics part, you can see metrics per Region/Namespace/Table/RegionServer depending on the selected mode. +The top screen is refreshed in a certain period – 3 seconds by default. + +### Scrolling metric records + +You can scroll the metric records in the metrics part. + + + +### Command line arguments + +| Argument | Description | +|---|---| +| -delay arg | The refresh delay (in seconds); default is 3 seconds | +| -help | Print usage; for help while the tool is running press `h` key | +| -mode arg | The mode; `n` (Namespace)`t` (Table)r (Region)`s` (RegionServer), default is `r` (Region) | + +### Modes + +There are the following 4 modes in hbtop: + +| Mode | Description | +|---|---| +| Region | Showing metric records per region | +| Namespace | Showing metric records per namespace | +| Table | Showing metric records per table | +| RegionServer | Showing metric records per region server | + + Region mode + +In Region mode, the default sort field is `#REQ/S`. + +The fields in this mode are as follows: + +| Field | Description | Displayed by default | +|---|---|---| +| RNAME | Region Name | false | +| NAMESPACE | Namespace Name | true | +| TABLE | Table Name | true | +| SCODE | Start Code | false | +| REPID | Replica ID | false | +| REGION | Encoded Region Name | true | +| RS | Short Region Server Name | true | +| LRS | Long Region Server Name | false | +| #REQ/S | Request Count per second | true | +| #READ/S | Read Request Count per second | true | +| #FREAD/S | Filtered Read Request Count per second | true | +| #WRITE/S | Write Request Count per second | true | +| SF | StoreFile Size | true | +| USF | Uncompressed StoreFile Size | false | +| #SF | Number of StoreFiles | true | +| MEMSTORE | MemStore Size | true | +| LOCALITY | Block Locality | true | +| SKEY | Start Key | false | +| #COMPingCELL | Compacting Cell Count | false | +| #COMPedCELL | Compacted Cell Count | false | +| %COMP | Compaction Progress | false | +| LASTMCOMP | Last Major Compaction Time | false | + + Namespace mode + +In Namespace mode, the default sort field is `#REQ/S`. + +The fields in this mode are as follows: + +| Field | Description | Displayed by default | +|---|---|---| +| NAMESPACE | Namespace Name | true | +| #REGION | Region Count | true | +| #REQ/S | Request Count per second | true | +| #READ/S | Read Request Count per second | true | +| #FREAD/S | Filtered Read Request Count per second | true | +| #WRITE/S | Write Request Count per second | true | +| SF | StoreFile Size | true | +| USF | Uncompressed StoreFile Size | false | +| #SF | Number of StoreFiles | true | +| MEMSTORE | MemStore Size | true | + + Table mode + +In Table mode, the default sort field is `#REQ/S`. + +The fields in this mode are as follows: + +| Field | Description | Displayed by default | +|---|---|---| +| NAMESPACE | Namespace Name | true | +| TABLE | Table Name | true | +| #REGION | Region Count | true | +| #REQ/S | Request Count per second | true | +| #READ/S | Read Request Count per second | true | +| #FREAD/S | Filtered Read Request Count per second | true | +| #WRITE/S | Write Request Count per second | true | +| SF | StoreFile Size | true | +| USF | Uncompressed StoreFile Size | false | +| #SF | Number of StoreFiles | true | +| MEMSTORE | MemStore Size | true | + + RegionServer mode + +In RegionServer mode, the default sort field is `#REQ/S`. + +The fields in this mode are as follows: + +| Field | Description | Displayed by default | +|---|---|---| +| RS | Short Region Server Name | true | +| LRS | Long Region Server Name | false | +| #REGION | Region Count | true | +| #REQ/S | Request Count per second | true | +| #READ/S | Read Request Count per second | true |
[GitHub] [hbase] saintstack commented on a change in pull request #476: HBASE-11062 hbtop
saintstack commented on a change in pull request #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#discussion_r315510080
##
File path: hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/Record.java
##
@@ -0,0 +1,180 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.hbtop;
+
+import java.util.Collection;
+import java.util.Collections;
+import java.util.EnumMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Stream;
+import javax.validation.constraints.NotNull;
+import org.apache.hadoop.hbase.hbtop.field.Field;
+import org.apache.hadoop.hbase.hbtop.field.FieldValue;
+import org.apache.yetus.audience.InterfaceAudience;
+
+
+/**
+ * Represents a record of the metrics in the top screen.
+ */
+@InterfaceAudience.Private
+public class Record implements Map {
+
+ private Map values;
+
+ public static final class Entry implements Map.Entry {
+private final Field key;
+private FieldValue value;
+
+private Entry(Field key, FieldValue value) {
+ this.key = Objects.requireNonNull(key);
+ this.value = Objects.requireNonNull(value);
+}
+
+@Override
+public Field getKey() {
+ return key;
+}
+
+@Override
+public FieldValue getValue() {
+ return value;
+}
+
+@Override
+public FieldValue setValue(FieldValue value) {
+ FieldValue oldValue = this.value;
+ this.value = value;
+ return oldValue;
+}
+ }
+
+ public static Entry entry(Field field, Object value) {
+return new Entry(field, field.newValue(value));
+ }
+
+ public static Entry entry(Field field, FieldValue value) {
+return new Entry(field, value);
+ }
+
+ public static Record ofEntries(List entries) {
+return ofEntries(entries.stream());
+ }
+
+ public static Record ofEntries(Entry... entries) {
+return ofEntries(Stream.of(entries));
+ }
+
+ public static Record ofEntries(Stream entries) {
+return entries
+ .collect(Record::new, (r, e) -> r.put(e.getKey(), e.getValue()), (r1,
r2) -> {});
+ }
+
+ public Record() {
+this(new EnumMap<>(Field.class));
+ }
+
+ private Record(Map values) {
+this.values = values;
+ }
+
+ @Override
+ public int size() {
+return values.size();
+ }
+
+ @Override
+ public boolean isEmpty() {
+return values.isEmpty();
+ }
+
+ @Override
+ public boolean containsKey(Object key) {
+return values.containsKey(key);
+ }
+
+ @Override
+ public boolean containsValue(Object value) {
+return values.containsValue(value);
+ }
+
+ @Override
+ public FieldValue get(Object key) {
+return values.get(key);
+ }
+
+ @Override
+ public FieldValue put(Field key, FieldValue value) {
+return values.put(key, value);
+ }
+
+ public FieldValue put(Field key, Object value) {
+return values.put(key, key.newValue(value));
+ }
+
+ @Override
+ public FieldValue remove(Object key) {
+return values.remove(key);
+ }
+
+ @Override
+ public void putAll(@NotNull Map m) {
+values.putAll(m);
+ }
+
+ @Override
+ public void clear() {
+values.clear();
Review comment:
Ok if sloppy with values? Won't be multithreaded in console so should be fine
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase
[
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911015#comment-16911015
]
Hudson commented on HBASE-22514:
Results for branch HBASE-22514
[build #67 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/67/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/67//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/67//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/67//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
> Issue Type: Umbrella
> Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch,
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public
> we need to use java api RSGroupAdminClient to manager RSG
> so RSGroupAdminClient should be public
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #511: HBASE-22879 user_permission command failed to show global permission
Apache-HBase commented on issue #511: HBASE-22879 user_permission command failed to show global permission URL: https://github.com/apache/hbase/pull/511#issuecomment-522862216 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 66 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 319 | master passed | | +1 | compile | 21 | master passed | | +1 | checkstyle | 10 | master passed | | +1 | shadedjars | 271 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 13 | master passed | | 0 | spotbugs | 285 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 0 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 303 | the patch passed | | +1 | compile | 22 | the patch passed | | +1 | javac | 22 | the patch passed | | +1 | checkstyle | 10 | the patch passed | | -1 | rubocop | 5 | The patch generated 3 new + 67 unchanged - 3 fixed = 70 total (was 70) | | +1 | whitespace | 1 | The patch has no whitespace issues. | | +1 | shadedjars | 280 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 945 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 12 | the patch passed | | +1 | findbugs | 0 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 603 | hbase-shell in the patch passed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 3260 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/511 | | Optional Tests | dupname asflicense javac javadoc unit rubocop spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 6fe1fa90ea8a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-511/out/precommit/personality/provided.sh | | git revision | master / a59f7d4ffc | | Default Java | 1.8.0_181 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/6/artifact/out/diff-patch-rubocop.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/6/testReport/ | | Max. process+thread count | 2526 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/6/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.74.0 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #498: HBASE-22819 Automatically migrate the rs group config for table after…
Apache-HBase commented on issue #498: HBASE-22819 Automatically migrate the rs group config for table after… URL: https://github.com/apache/hbase/pull/498#issuecomment-522859009 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 100 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ HBASE-22514 Compile Tests _ | | 0 | mvndep | 35 | Maven dependency ordering for branch | | +1 | mvninstall | 357 | HBASE-22514 passed | | +1 | compile | 93 | HBASE-22514 passed | | +1 | checkstyle | 124 | HBASE-22514 passed | | +1 | shadedjars | 334 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 66 | HBASE-22514 passed | | 0 | spotbugs | 293 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 345 | HBASE-22514 passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 331 | the patch passed | | +1 | compile | 86 | the patch passed | | +1 | javac | 86 | the patch passed | | +1 | checkstyle | 115 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 304 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1045 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 58 | the patch passed | | +1 | findbugs | 408 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 203 | hbase-common in the patch passed. | | +1 | unit | 9506 | hbase-server in the patch passed. | | +1 | asflicense | 41 | The patch does not generate ASF License warnings. | | | | 13989 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/9/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/498 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux a15ee86a38fa 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-498/out/precommit/personality/provided.sh | | git revision | HBASE-22514 / 8660b522c7 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/9/testReport/ | | Max. process+thread count | 4031 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/9/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #496: HBASE-22625 documet use scan snapshot feature
Apache-HBase commented on issue #496: HBASE-22625 documet use scan snapshot feature URL: https://github.com/apache/hbase/pull/496#issuecomment-522857885 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 69 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | @author | 0 | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 | mvninstall | 332 | master passed | | 0 | refguide | 333 | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 297 | the patch passed | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | 0 | refguide | 333 | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Other Tests _ | | +1 | asflicense | 62 | The patch does not generate ASF License warnings. | | | | 1488 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/15/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/496 | | Optional Tests | dupname asflicense shellcheck shelldocs refguide | | uname | Linux 3a68d7a55682 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-496/out/precommit/personality/provided.sh | | git revision | master / a59f7d4ffc | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/15/artifact/out/branch-site/book.html | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/15/artifact/out/patch-site/book.html | | Max. process+thread count | 81 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/15/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22882) TestFlushSnapshotFromClient#testConcurrentSnapshottingAttempts is flakey (was written flakey)
[
https://issues.apache.org/jira/browse/HBASE-22882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911005#comment-16911005
]
Hudson commented on HBASE-22882:
Results for branch branch-2.0
[build #1879 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1879/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1879//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1879//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1879//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> TestFlushSnapshotFromClient#testConcurrentSnapshottingAttempts is flakey (was
> written flakey)
> -
>
> Key: HBASE-22882
> URL: https://issues.apache.org/jira/browse/HBASE-22882
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: 22882.txt, Screen Shot 2019-08-19 at 12.46.33 PM.png,
> Screen Shot 2019-08-19 at 12.46.33 PM.png
>
>
> See HBASE-7536 which adds this test. The author and reviewers note the
> indeterminacy of the test. In branch-2.0 it fails 90% of the time on the GCE
> runs. Disabling it. In the original issue, its noted that it would take a
> bunch of work to make it deterministic. Meantime disabling it.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-20952) Re-visit the WAL API
[
https://issues.apache.org/jira/browse/HBASE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911006#comment-16911006
]
Hudson commented on HBASE-20952:
Results for branch HBASE-20952
[build #103 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20952/103/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20952/103//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20952/103//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20952/103//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Re-visit the WAL API
>
>
> Key: HBASE-20952
> URL: https://issues.apache.org/jira/browse/HBASE-20952
> Project: HBase
> Issue Type: Improvement
> Components: wal
>Reporter: Josh Elser
>Priority: Major
> Attachments: 20952.v1.txt
>
>
> Take a step back from the current WAL implementations and think about what an
> HBase WAL API should look like. What are the primitive calls that we require
> to guarantee durability of writes with a high degree of performance?
> The API needs to take the current implementations into consideration. We
> should also have a mind for what is happening in the Ratis LogService (but
> the LogService should not dictate what HBase's WAL API looks like RATIS-272).
> Other "systems" inside of HBase that use WALs are replication and
> backup Replication has the use-case for "tail"'ing the WAL which we
> should provide via our new API. B doesn't do anything fancy (IIRC). We
> should make sure all consumers are generally going to be OK with the API we
> create.
> The API may be "OK" (or OK in a part). We need to also consider other methods
> which were "bolted" on such as {{AbstractFSWAL}} and
> {{WALFileLengthProvider}}. Other corners of "WAL use" (like the
> {{WALSplitter}} should also be looked at to use WAL-APIs only).
> We also need to make sure that adequate interface audience and stability
> annotations are chosen.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #476: HBASE-11062 hbtop
Apache-HBase commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-522855411 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 96 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | 0 | shelldocs | 1 | Shelldocs was not available. | | +1 | hbaseanti | 1 | Patch does not have any anti-patterns. | | +1 | @author | 1 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 22 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 44 | Maven dependency ordering for branch | | +1 | mvninstall | 393 | master passed | | +1 | compile | 174 | master passed | | +1 | checkstyle | 152 | master passed | | +1 | shadedjars | 278 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 179 | master passed | | 0 | spotbugs | 31 | Used deprecated FindBugs config; considering switching to SpotBugs. | | 0 | findbugs | 31 | branch/hbase-assembly no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 307 | the patch passed | | +1 | compile | 179 | the patch passed | | +1 | javac | 179 | the patch passed | | +1 | checkstyle | 155 | the patch passed | | +1 | shellcheck | 2 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 4 | The patch has no ill-formed XML file. | | +1 | shadedjars | 309 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1045 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 201 | the patch passed | | 0 | findbugs | 35 | hbase-assembly has no data from findbugs | ||| _ Other Tests _ | | -1 | unit | 18451 | root in the patch failed. | | +1 | asflicense | 85 | The patch does not generate ASF License warnings. | | | | 24775 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestHRegion | | | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.client.TestCloneSnapshotFromClientNormal | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.client.TestFromClientSide3 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/28/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/476 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux 954fa2fb3c9e 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-476/out/precommit/personality/provided.sh | | git revision | master / 67382809d3 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/28/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/28/testReport/ | | Max. process+thread count | 5012 (vs. ulimit of 1) | | modules | C: hbase-hbtop . hbase-assembly U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/28/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#issuecomment-522852101 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 180 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 75 | Maven dependency ordering for branch | | +1 | mvninstall | 472 | master passed | | +1 | compile | 99 | master passed | | +1 | checkstyle | 143 | master passed | | +1 | shadedjars | 397 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 71 | master passed | | 0 | spotbugs | 323 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 383 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 433 | the patch passed | | +1 | compile | 102 | the patch passed | | +1 | javac | 102 | the patch passed | | +1 | checkstyle | 32 | hbase-common: The patch generated 0 new + 48 unchanged - 2 fixed = 48 total (was 50) | | -1 | checkstyle | 107 | hbase-server: The patch generated 1 new + 48 unchanged - 0 fixed = 49 total (was 48) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 386 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1248 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 66 | the patch passed | | +1 | findbugs | 383 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 205 | hbase-common in the patch passed. | | -1 | unit | 18403 | hbase-server in the patch failed. | | +1 | asflicense | 80 | The patch does not generate ASF License warnings. | | | | 23794 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.tool.TestBulkLoadHFiles | | | hadoop.hbase.mob.compactions.TestMobCompactor | | | hadoop.hbase.regionserver.TestHRegion | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.TestRegionRebalancing | | | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/27/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/479 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 4d6bf6a97f57 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-479/out/precommit/personality/provided.sh | | git revision | master / 67382809d3 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/27/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/27/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/27/testReport/ | | Max. process+thread count | 4772 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/27/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-11062) hbtop
[
https://issues.apache.org/jira/browse/HBASE-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911000#comment-16911000
]
Toshihiro Suzuki commented on HBASE-11062:
--
Thanks [~stack].
{quote}
Add pointer to it up in the release notes for this issue?
{quote}
Yes, I thought after it's committed, I will add the link of the README in the
hbase project. The link in the previous comment is in my repository.
{quote}
Should the README get integrated into the refguide, perhaps as a follow-on?
{quote}
I think we should do that. After it's committed, I will work on it.
> hbtop
> -
>
> Key: HBASE-11062
> URL: https://issues.apache.org/jira/browse/HBASE-11062
> Project: HBase
> Issue Type: New Feature
> Components: hbtop
>Reporter: Andrew Purtell
>Assignee: Toshihiro Suzuki
>Priority: Major
>
> A top-like monitor could be useful for testing, debugging, operations of
> clusters of moderate size, and possibly for diagnosing issues in large
> clusters.
> Consider a curses interface like the one presented by atop
> (http://www.atoptool.nl/images/screenshots/genericw.png) - with aggregate
> metrics collected over a monitoring interval in the upper portion of the
> pane, and a listing of discrete measurements sorted and filtered by various
> criteria in the bottom part of the pane. One might imagine a cluster overview
> with cluster aggregate metrics above and a list of regionservers sorted by
> utilization below; and a regionserver view with process metrics above and a
> list of metrics by operation type below, or a list of client connections, or
> a list of threads, sorted by utilization, throughput, or latency.
> Generically 'htop' is taken but would be distinctive in the HBase context, a
> utility org.apache.hadoop.hbase.HTop
> No need necessarily for a curses interface. Could be an external monitor with
> a web front end as has been discussed before. I do like the idea of a process
> that runs in a terminal because I interact with dev and test HBase clusters
> exclusively by SSH.
> UPDATE:
> The tool name is changed from htop to hbtop.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-522851277 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 103 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 419 | master passed | | +1 | compile | 62 | master passed | | +1 | checkstyle | 97 | master passed | | +1 | shadedjars | 332 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 43 | master passed | | 0 | spotbugs | 258 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 255 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 420 | the patch passed | | +1 | compile | 66 | the patch passed | | +1 | javac | 66 | the patch passed | | +1 | checkstyle | 88 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 331 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1210 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 46 | the patch passed | | +1 | findbugs | 312 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 19031 | hbase-server in the patch failed. | | +1 | asflicense | 27 | The patch does not generate ASF License warnings. | | | | 23303 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.regionserver.TestHRegion | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.client.TestAdmin1 | | | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.tool.TestBulkLoadHFiles | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/34/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/468 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b1805f342f30 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh | | git revision | master / 67382809d3 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/34/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/34/testReport/ | | Max. process+thread count | 4969 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/34/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility
Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility URL: https://github.com/apache/hbase/pull/477#issuecomment-522850640 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 121 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 46 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 501 | master passed | | +1 | compile | 73 | master passed | | +1 | checkstyle | 109 | master passed | | +1 | shadedjars | 357 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 49 | master passed | | 0 | spotbugs | 310 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 307 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 460 | the patch passed | | +1 | compile | 75 | the patch passed | | +1 | javac | 75 | the patch passed | | +1 | checkstyle | 108 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 376 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1394 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 47 | the patch passed | | +1 | findbugs | 333 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 18380 | hbase-server in the patch failed. | | -1 | asflicense | 42 | The patch generated 18 ASF License warnings. | | | | 23269 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestCIIncrementRpcTimeout | | | hadoop.hbase.replication.regionserver.TestSerialReplicationChecker | | | hadoop.hbase.client.TestAsyncSingleRequestRpcRetryingCaller | | | hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster | | | hadoop.hbase.coprocessor.TestMasterObserver | | | hadoop.hbase.replication.TestSyncReplicationStandbyKillMaster | | | hadoop.hbase.client.TestMobSnapshotCloneIndependence | | | hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithRemove | | | hadoop.hbase.replication.TestReplicationKillSlaveRS | | | hadoop.hbase.replication.TestSerialReplication | | | hadoop.hbase.replication.TestReplicationStatusAfterLagging | | | hadoop.hbase.master.procedure.TestProcedurePriority | | | hadoop.hbase.fs.TestBlockReorderMultiBlocks | | | hadoop.hbase.regionserver.TestRegionServerMetrics | | | hadoop.hbase.replication.TestReplicationKillSlaveRSWithSeparateOldWALs | | | hadoop.hbase.regionserver.TestRemoveRegionMetrics | | | hadoop.hbase.master.TestServerCrashProcedureCarryingMetaStuck | | | hadoop.hbase.client.TestMultiParallel | | | hadoop.hbase.client.TestZKAsyncRegistry | | | hadoop.hbase.replication.regionserver.TestRaceWhenCreatingReplicationSource | | | hadoop.hbase.regionserver.TestRegionServerHostname | | | hadoop.hbase.replication.TestReplicationChangingPeerRegionservers | | | hadoop.hbase.client.TestTimestampsFilter | | | hadoop.hbase.replication.TestReplicationSyncUpToolWithBulkLoadedData | | | hadoop.hbase.TestAcidGuaranteesWithBasicPolicy | | | hadoop.hbase.client.TestMetaCache | | | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.replication.TestReplicationStatusSourceStartedTargetStoppedWithRecovery | | | hadoop.hbase.client.TestBlockEvictionFromClient | | | hadoop.hbase.regionserver.throttle.TestFlushWithThroughputController | | | hadoop.hbase.replication.TestReplicationProcedureRetry | | | hadoop.hbase.master.TestMasterFailover | | | hadoop.hbase.replication.regionserver.TestDrainReplicationQueuesForStandBy | | | hadoop.hbase.client.TestAsyncTableScanner | | | hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure | | | hadoop.hbase.replication.regionserver.TestReplicationSink | | | hadoop.hbase.fs.TestBlockReorder | | | hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedureFromClient | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientSimple | | | hadoop.hbase.master.procedure.TestSCPWithoutZKCoordinated | | | hadoop.hbase.client.TestAsyncQuotaAdminApi | | | hadoop.hbase.replication.TestReplicationStatusBothNormalAndRecoveryLagging | | | hadoop.hbase.master.procedure.TestEnableTableProcedure | | | hadoop.hbase.security.visibility.TestVisibilityLabelsReplication | | | hadoop.hbase.master.locking.TestLockProcedure | | |
[GitHub] [hbase] chenxu14 commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
chenxu14 commented on a change in pull request #479: HBASE-22802 Avoid temp
ByteBuffer allocation in FileIOEngine#read
URL: https://github.com/apache/hbase/pull/479#discussion_r315502192
##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/nio/ByteBuff.java
##
@@ -78,6 +79,14 @@ public boolean release() {
return refCnt.release();
}
+ public RefCnt getRefCnt() {
+return this.refCnt;
+ }
+
+ public void setRefCnt(RefCnt refCnt) {
Review comment:
have not find a better way yet, any suggestions?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #510: HBASE-22878 Show table throttle quotas in table jsp
Apache-HBase commented on issue #510: HBASE-22878 Show table throttle quotas in table jsp URL: https://github.com/apache/hbase/pull/510#issuecomment-522846714 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 163 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | 0 | mvndep | 39 | Maven dependency ordering for branch | | +1 | mvninstall | 409 | master passed | | +1 | compile | 100 | master passed | | +1 | checkstyle | 133 | master passed | | +1 | shadedjars | 353 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 69 | master passed | | 0 | spotbugs | 330 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 415 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 19 | Maven dependency ordering for patch | | +1 | mvninstall | 373 | the patch passed | | +1 | compile | 96 | the patch passed | | +1 | javac | 96 | the patch passed | | +1 | checkstyle | 131 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 354 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1185 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 71 | the patch passed | | +1 | findbugs | 428 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 127 | hbase-client in the patch passed. | | -1 | unit | 17849 | hbase-server in the patch failed. | | +1 | asflicense | 51 | The patch does not generate ASF License warnings. | | | | 22857 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.TestReplicationKillSlaveRSWithSeparateOldWALs | | | hadoop.hbase.replication.TestReplicationSmallTests | | | hadoop.hbase.regionserver.TestHRegion | | | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.client.TestFlushFromClient | | | hadoop.hbase.replication.TestReplicationSmallTestsSync | | | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.client.TestFromClientSide3 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/510 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 7e1a393dc4ab 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-510/out/precommit/personality/provided.sh | | git revision | master / 67382809d3 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/4/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/4/testReport/ | | Max. process+thread count | 4887 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation
Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation URL: https://github.com/apache/hbase/pull/478#issuecomment-522846091 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 271 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 34 | Maven dependency ordering for branch | | +1 | mvninstall | 364 | master passed | | +1 | compile | 82 | master passed | | +1 | checkstyle | 103 | master passed | | +1 | shadedjars | 275 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 56 | master passed | | 0 | spotbugs | 249 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 314 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for patch | | +1 | mvninstall | 342 | the patch passed | | +1 | compile | 86 | the patch passed | | +1 | javac | 86 | the patch passed | | +1 | checkstyle | 108 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 329 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 955 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 56 | the patch passed | | +1 | findbugs | 345 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 104 | hbase-client in the patch passed. | | -1 | unit | 17469 | hbase-server in the patch failed. | | +1 | asflicense | 46 | The patch does not generate ASF License warnings. | | | | 21740 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | | hadoop.hbase.master.locking.TestLockProcedure | | | hadoop.hbase.regionserver.TestHRegion | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/25/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/478 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e4d7a1b79c4f 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-478/out/precommit/personality/provided.sh | | git revision | master / 67382809d3 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/25/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/25/testReport/ | | Max. process+thread count | 5083 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/25/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22882) TestFlushSnapshotFromClient#testConcurrentSnapshottingAttempts is flakey (was written flakey)
[ https://issues.apache.org/jira/browse/HBASE-22882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910976#comment-16910976 ] stack commented on HBASE-22882: --- Looks like HBASE-22810 brought on the higher incidence failure. Leaving the patch in place anyways because of above reasoning -- that test was written indeterminate. > TestFlushSnapshotFromClient#testConcurrentSnapshottingAttempts is flakey (was > written flakey) > - > > Key: HBASE-22882 > URL: https://issues.apache.org/jira/browse/HBASE-22882 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: 22882.txt, Screen Shot 2019-08-19 at 12.46.33 PM.png, > Screen Shot 2019-08-19 at 12.46.33 PM.png > > > See HBASE-7536 which adds this test. The author and reviewers note the > indeterminacy of the test. In branch-2.0 it fails 90% of the time on the GCE > runs. Disabling it. In the original issue, its noted that it would take a > bunch of work to make it deterministic. Meantime disabling it. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Comment Edited] (HBASE-22810) Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
[
https://issues.apache.org/jira/browse/HBASE-22810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910973#comment-16910973
]
stack edited comment on HBASE-22810 at 8/20/19 3:54 AM:
Ok. This did not make it into 2.0.6RC1 which just became 2.0.6. I moved fix
version to 2.0.7 though there will be no more releases on branch-2.0.
I just saw this issue and how it breaks TestFlushSnapshotFromClient. I looked
at the TestFlushSnapshotFromClient failures independently and to me the test
looked flakey anyways and was seemingly written flakey in the first place so
just removed it with the below commit. Did not go back to branch-1. After
seeing this issue, I was a mite reactionary.
{code}
commit 05b88af057d35e247bf37b725f2735292f944387 (HEAD -> 2.0, origin/branch-2.0)
Author: stack
Date: Mon Aug 19 14:25:21 2019 -0700
HBASE-22882 TestFlushSnapshotFromClient#testConcurrentSnapshottingAttempts
is flakey (was written flakey)
Addendum; just remove the test altogether
{code}
was (Author: stack):
Ok. This did not make it into 2.0.6RC1 which just became 2.0.6. I moved fix
version to 2.0.7 though there will be no more releases on branch-2.0.
I just saw this issue and how it breaks TestFlushSnapshotFromClient. I looked
at the TestFlushSnapshotFromClient failures independently and to me the test
looked flakey anyways and was seemingly written flakey in the first place so
just removed it with the below commit. Did not go back to branch-1. After
seeing this issue, I was a mite reactionary it seems.
{code}
commit 05b88af057d35e247bf37b725f2735292f944387 (HEAD -> 2.0, origin/branch-2.0)
Author: stack
Date: Mon Aug 19 14:25:21 2019 -0700
HBASE-22882 TestFlushSnapshotFromClient#testConcurrentSnapshottingAttempts
is flakey (was written flakey)
Addendum; just remove the test altogether
{code}
> Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
>
>
> Key: HBASE-22810
> URL: https://issues.apache.org/jira/browse/HBASE-22810
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11, 2.0.7
>
>
> In EventType class, we have the following definition, means taking snapshot
> & restoring snapshot are use the MASTER_TABLE_OPERATIONS Executor now.
> {code}
> /**
>* Messages originating from Client to Master.
>* C_M_SNAPSHOT_TABLE
>* Client asking Master to snapshot an offline table.
>*/
> C_M_SNAPSHOT_TABLE(48, ExecutorType.MASTER_TABLE_OPERATIONS),
> /**
>* Messages originating from Client to Master.
>* C_M_RESTORE_SNAPSHOT
>* Client asking Master to restore a snapshot.
>*/
> C_M_RESTORE_SNAPSHOT (49, ExecutorType.MASTER_TABLE_OPERATIONS),
> {code}
> But when I checked the MASTER_TABLE_OPERATIONS thread pool initialization, I
> see :
> {code}
> private void startServiceThreads() throws IOException{
>// ... some other code initializing
>// We depend on there being only one instance of this executor running
>// at a time. To do concurrency, would need fencing of enable/disable of
>// tables.
>// Any time changing this maxThreads to > 1, pls see the comment at
>// AccessController#postCompletedCreateTableAction
>
> this.executorService.startExecutorService(ExecutorType.MASTER_TABLE_OPERATIONS,
> 1);
>startProcedureExecutor();
> {code}
> That's to say, for CPs enable or disable table sequencely, we will create
> a ThreadPoolExecutor with threadPoolSize=1. Then we actually cann't
> accomplish the snapshoting concurrence even if they are total difference
> tables, says if there are two table snapshoting request, and the Table A cost
> 5min for snapshoting, then the Table B need to wait 5min and once Table A
> finish its snapshot , then Table B will start the snapshot.
> While we've setting the snapshot timeout, so it will be easy to timeout for
> table B snapshoting . Actually, we can create a separate thead pool for
> snapshot operations only.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22810) Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
[
https://issues.apache.org/jira/browse/HBASE-22810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910973#comment-16910973
]
stack commented on HBASE-22810:
---
Ok. This did not make it into 2.0.6RC1 which just became 2.0.6. I moved fix
version to 2.0.7 though there will be no more releases on branch-2.0.
I just saw this issue and how it breaks TestFlushSnapshotFromClient. I looked
at the TestFlushSnapshotFromClient failures independently and to me the test
looked flakey anyways and was seemingly written flakey in the first place so
just removed it with the below commit. Did not go back to branch-1. After
seeing this issue, I was a mite reactionary it seems.
{code}
commit 05b88af057d35e247bf37b725f2735292f944387 (HEAD -> 2.0, origin/branch-2.0)
Author: stack
Date: Mon Aug 19 14:25:21 2019 -0700
HBASE-22882 TestFlushSnapshotFromClient#testConcurrentSnapshottingAttempts
is flakey (was written flakey)
Addendum; just remove the test altogether
{code}
> Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
>
>
> Key: HBASE-22810
> URL: https://issues.apache.org/jira/browse/HBASE-22810
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11, 2.0.7
>
>
> In EventType class, we have the following definition, means taking snapshot
> & restoring snapshot are use the MASTER_TABLE_OPERATIONS Executor now.
> {code}
> /**
>* Messages originating from Client to Master.
>* C_M_SNAPSHOT_TABLE
>* Client asking Master to snapshot an offline table.
>*/
> C_M_SNAPSHOT_TABLE(48, ExecutorType.MASTER_TABLE_OPERATIONS),
> /**
>* Messages originating from Client to Master.
>* C_M_RESTORE_SNAPSHOT
>* Client asking Master to restore a snapshot.
>*/
> C_M_RESTORE_SNAPSHOT (49, ExecutorType.MASTER_TABLE_OPERATIONS),
> {code}
> But when I checked the MASTER_TABLE_OPERATIONS thread pool initialization, I
> see :
> {code}
> private void startServiceThreads() throws IOException{
>// ... some other code initializing
>// We depend on there being only one instance of this executor running
>// at a time. To do concurrency, would need fencing of enable/disable of
>// tables.
>// Any time changing this maxThreads to > 1, pls see the comment at
>// AccessController#postCompletedCreateTableAction
>
> this.executorService.startExecutorService(ExecutorType.MASTER_TABLE_OPERATIONS,
> 1);
>startProcedureExecutor();
> {code}
> That's to say, for CPs enable or disable table sequencely, we will create
> a ThreadPoolExecutor with threadPoolSize=1. Then we actually cann't
> accomplish the snapshoting concurrence even if they are total difference
> tables, says if there are two table snapshoting request, and the Table A cost
> 5min for snapshoting, then the Table B need to wait 5min and once Table A
> finish its snapshot , then Table B will start the snapshot.
> While we've setting the snapshot timeout, so it will be easy to timeout for
> table B snapshoting . Actually, we can create a separate thead pool for
> snapshot operations only.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HBASE-22810) Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
[
https://issues.apache.org/jira/browse/HBASE-22810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-22810:
--
Fix Version/s: (was: 2.0.6)
2.0.7
> Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
>
>
> Key: HBASE-22810
> URL: https://issues.apache.org/jira/browse/HBASE-22810
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11, 2.0.7
>
>
> In EventType class, we have the following definition, means taking snapshot
> & restoring snapshot are use the MASTER_TABLE_OPERATIONS Executor now.
> {code}
> /**
>* Messages originating from Client to Master.
>* C_M_SNAPSHOT_TABLE
>* Client asking Master to snapshot an offline table.
>*/
> C_M_SNAPSHOT_TABLE(48, ExecutorType.MASTER_TABLE_OPERATIONS),
> /**
>* Messages originating from Client to Master.
>* C_M_RESTORE_SNAPSHOT
>* Client asking Master to restore a snapshot.
>*/
> C_M_RESTORE_SNAPSHOT (49, ExecutorType.MASTER_TABLE_OPERATIONS),
> {code}
> But when I checked the MASTER_TABLE_OPERATIONS thread pool initialization, I
> see :
> {code}
> private void startServiceThreads() throws IOException{
>// ... some other code initializing
>// We depend on there being only one instance of this executor running
>// at a time. To do concurrency, would need fencing of enable/disable of
>// tables.
>// Any time changing this maxThreads to > 1, pls see the comment at
>// AccessController#postCompletedCreateTableAction
>
> this.executorService.startExecutorService(ExecutorType.MASTER_TABLE_OPERATIONS,
> 1);
>startProcedureExecutor();
> {code}
> That's to say, for CPs enable or disable table sequencely, we will create
> a ThreadPoolExecutor with threadPoolSize=1. Then we actually cann't
> accomplish the snapshoting concurrence even if they are total difference
> tables, says if there are two table snapshoting request, and the Table A cost
> 5min for snapshoting, then the Table B need to wait 5min and once Table A
> finish its snapshot , then Table B will start the snapshot.
> While we've setting the snapshot timeout, so it will be easy to timeout for
> table B snapshoting . Actually, we can create a separate thead pool for
> snapshot operations only.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #501: HBASE-22699 refactor isMetaClearingException
Apache-HBase commented on issue #501: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/501#issuecomment-522841247 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 58 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 34 | Maven dependency ordering for branch | | +1 | mvninstall | 348 | master passed | | +1 | compile | 78 | master passed | | +1 | checkstyle | 103 | master passed | | +1 | shadedjars | 274 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 57 | master passed | | 0 | spotbugs | 247 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 314 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for patch | | +1 | mvninstall | 332 | the patch passed | | +1 | compile | 77 | the patch passed | | +1 | javac | 77 | the patch passed | | +1 | checkstyle | 101 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 271 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 969 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 58 | the patch passed | | +1 | findbugs | 331 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 106 | hbase-client in the patch passed. | | -1 | unit | 16210 | hbase-server in the patch failed. | | +1 | asflicense | 111 | The patch does not generate ASF License warnings. | | | | 20303 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.regionserver.TestHRegion | | | hadoop.hbase.client.TestMetaCache | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/14/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/501 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux a212252c8b77 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-501/out/precommit/personality/provided.sh | | git revision | master / 67382809d3 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/14/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/14/testReport/ | | Max. process+thread count | 5279 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/14/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22874) Canary should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-22874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22874: -- Fix Version/s: (was: 2.0.6) > Canary should not be IA.Public > -- > > Key: HBASE-22874 > URL: https://issues.apache.org/jira/browse/HBASE-22874 > Project: HBase > Issue Type: Bug > Components: canary >Reporter: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6 > > > It can be marked as IA.LimitedPrivate(TOOLS). -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] Reidddddd commented on issue #507: HBASE-22861 [WAL] Merged region should get its WAL according to WALProvider
Reidd commented on issue #507: HBASE-22861 [WAL] Merged region should get its WAL according to WALProvider URL: https://github.com/apache/hbase/pull/507#issuecomment-522840027 Not related failed UT. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #509: HBASE-22877 WebHDFS based export snapshot will fail if hfile is in archive directory
Apache-HBase commented on issue #509: HBASE-22877 WebHDFS based export snapshot will fail if hfile is in archive directory URL: https://github.com/apache/hbase/pull/509#issuecomment-522838442 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 116 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 360 | master passed | | +1 | compile | 59 | master passed | | +1 | checkstyle | 81 | master passed | | +1 | shadedjars | 288 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 36 | master passed | | 0 | spotbugs | 246 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 245 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 326 | the patch passed | | +1 | compile | 55 | the patch passed | | +1 | javac | 55 | the patch passed | | -1 | checkstyle | 75 | hbase-server: The patch generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 286 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 997 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 33 | the patch passed | | +1 | findbugs | 258 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 16166 | hbase-server in the patch failed. | | +1 | asflicense | 28 | The patch does not generate ASF License warnings. | | | | 19814 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.regionserver.TestHRegion | | | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/509 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2179151ab6e8 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-509/out/precommit/personality/provided.sh | | git revision | master / 67382809d3 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/4/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/4/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/4/testReport/ | | Max. process+thread count | 5110 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)
virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#discussion_r315493334 ## File path: hbase-zookeeper/pom.xml ## @@ -274,6 +284,16 @@ org.apache.hadoop hadoop-common + Review comment: I have committed all the necessary and suggested changes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22883) Duplacate codes of method Threads.newDaemonThreadFactory() and class DaemonThreadFactory
[ https://issues.apache.org/jira/browse/HBASE-22883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-22883: --- Description: Class DaemonThreadFactory can be removed. (was: Class ) > Duplacate codes of method Threads.newDaemonThreadFactory() and class > DaemonThreadFactory > > > Key: HBASE-22883 > URL: https://issues.apache.org/jira/browse/HBASE-22883 > Project: HBase > Issue Type: Improvement >Reporter: Xiaolin Ha >Assignee: Xiaolin Ha >Priority: Minor > > Class DaemonThreadFactory can be removed. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22883) Duplacate codes of method Threads.newDaemonThreadFactory() and class DaemonThreadFactory
[ https://issues.apache.org/jira/browse/HBASE-22883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-22883: --- Description: Class > Duplacate codes of method Threads.newDaemonThreadFactory() and class > DaemonThreadFactory > > > Key: HBASE-22883 > URL: https://issues.apache.org/jira/browse/HBASE-22883 > Project: HBase > Issue Type: Improvement >Reporter: Xiaolin Ha >Assignee: Xiaolin Ha >Priority: Minor > > Class -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (HBASE-22883) Duplacate codes of method Threads.newDaemonThreadFactory() and class DaemonThreadFactory
Xiaolin Ha created HBASE-22883: -- Summary: Duplacate codes of method Threads.newDaemonThreadFactory() and class DaemonThreadFactory Key: HBASE-22883 URL: https://issues.apache.org/jira/browse/HBASE-22883 Project: HBase Issue Type: Improvement Reporter: Xiaolin Ha Assignee: Xiaolin Ha -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] virajjasani commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
virajjasani commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-522836739 Closing the PR as per suggestion by @Reidd If there is any change of thought, please let me know and I will reopen it. Thanks for the review @Reidd @saintstack This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani closed pull request #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
virajjasani closed pull request #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] sunhelly opened a new pull request #512: HBASE-22881 Fix Non-daemon threads in HMaster
sunhelly opened a new pull request #512: HBASE-22881 Fix Non-daemon threads in HMaster URL: https://github.com/apache/hbase/pull/512 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes…
Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes… URL: https://github.com/apache/hbase/pull/446#issuecomment-522835775 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 73 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 361 | master passed | | +1 | compile | 64 | master passed | | +1 | checkstyle | 99 | master passed | | +1 | shadedjars | 314 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 40 | master passed | | 0 | spotbugs | 284 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 282 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 331 | the patch passed | | +1 | compile | 58 | the patch passed | | +1 | javac | 58 | the patch passed | | +1 | checkstyle | 86 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 319 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1091 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 39 | the patch passed | | +1 | findbugs | 288 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 13856 | hbase-server in the patch failed. | | +1 | asflicense | 28 | The patch does not generate ASF License warnings. | | | | 17753 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | | hadoop.hbase.regionserver.TestHRegion | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/57/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/446 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux a073af765642 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-446/out/precommit/personality/provided.sh | | git revision | master / 67382809d3 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/57/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/57/testReport/ | | Max. process+thread count | 4939 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/57/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
Reidd commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-522831447 > would you like me to close this PR? Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-522829886 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 179 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 39 | Maven dependency ordering for branch | | +1 | mvninstall | 416 | master passed | | +1 | compile | 105 | master passed | | +1 | checkstyle | 139 | master passed | | +1 | shadedjars | 382 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 72 | master passed | | 0 | spotbugs | 326 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 412 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 19 | Maven dependency ordering for patch | | +1 | mvninstall | 423 | the patch passed | | +1 | compile | 102 | the patch passed | | +1 | javac | 102 | the patch passed | | +1 | checkstyle | 138 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 391 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1266 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 70 | the patch passed | | +1 | findbugs | 438 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 131 | hbase-client in the patch passed. | | -1 | unit | 18651 | hbase-server in the patch failed. | | +1 | asflicense | 64 | The patch does not generate ASF License warnings. | | | | 23942 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.replication.TestReplicationSmallTests | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.regionserver.TestHRegion | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.replication.TestReplicationKillSlaveRS | | | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | | hadoop.hbase.namespace.TestNamespaceAuditor | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/112/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux a6d7d8e2a5f0 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / 8e488ce9ef | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/112/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/112/testReport/ | | Max. process+thread count | 4894 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/112/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation
Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation URL: https://github.com/apache/hbase/pull/478#issuecomment-522828539 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 96 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 40 | Maven dependency ordering for branch | | +1 | mvninstall | 383 | master passed | | +1 | compile | 91 | master passed | | +1 | checkstyle | 113 | master passed | | +1 | shadedjars | 325 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 73 | master passed | | 0 | spotbugs | 303 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 386 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for patch | | +1 | mvninstall | 386 | the patch passed | | +1 | compile | 109 | the patch passed | | +1 | javac | 109 | the patch passed | | +1 | checkstyle | 130 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 373 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1262 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 70 | the patch passed | | +1 | findbugs | 425 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 118 | hbase-client in the patch passed. | | -1 | unit | 18893 | hbase-server in the patch failed. | | +1 | asflicense | 65 | The patch does not generate ASF License warnings. | | | | 23840 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestCloneSnapshotFromClientNormal | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.regionserver.TestHRegion | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | | hadoop.hbase.namespace.TestNamespaceAuditor | | | hadoop.hbase.replication.TestReplicationSmallTestsSync | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/24/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/478 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 83ff16021a85 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-478@2/out/precommit/personality/provided.sh | | git revision | master / 8e488ce9ef | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/24/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/24/testReport/ | | Max. process+thread count | 5004 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/24/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.
[
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910935#comment-16910935
]
Hadoop QA commented on HBASE-22601:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
5s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
7s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
43s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
55s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
39s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
7s{color} | {color:blue} Used deprecated FindBugs config; considering switching
to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
4s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
45s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
17m 40s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
56s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}213m
59s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
27s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}277m 8s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/14/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/500 |
| JIRA Issue | HBASE-22601 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 274a5c5feebb 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-500/out/precommit/personality/provided.sh
|
| git revision | branch-2 / e9874a6abd |
| Default Java | 1.8.0_181 |
| Test Results |
[GitHub] [hbase] Apache-HBase commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.
Apache-HBase commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/500#issuecomment-522826171 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 80 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2 Compile Tests _ | | +1 | mvninstall | 365 | branch-2 passed | | +1 | compile | 67 | branch-2 passed | | +1 | checkstyle | 103 | branch-2 passed | | +1 | shadedjars | 295 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 39 | branch-2 passed | | 0 | spotbugs | 247 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 244 | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 345 | the patch passed | | +1 | compile | 67 | the patch passed | | +1 | javac | 67 | the patch passed | | +1 | checkstyle | 92 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 285 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1060 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 37 | the patch passed | | +1 | findbugs | 236 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 12839 | hbase-server in the patch passed. | | +1 | asflicense | 27 | The patch does not generate ASF License warnings. | | | | 16628 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/14/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/500 | | JIRA Issue | HBASE-22601 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 274a5c5feebb 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-500/out/precommit/personality/provided.sh | | git revision | branch-2 / e9874a6abd | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/14/testReport/ | | Max. process+thread count | 3846 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/14/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility
Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility URL: https://github.com/apache/hbase/pull/477#issuecomment-522824156 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 37 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 46 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 310 | master passed | | +1 | compile | 52 | master passed | | +1 | checkstyle | 77 | master passed | | +1 | shadedjars | 265 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 35 | master passed | | 0 | spotbugs | 254 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 253 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 290 | the patch passed | | +1 | compile | 53 | the patch passed | | +1 | javac | 53 | the patch passed | | +1 | checkstyle | 74 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 261 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 898 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 32 | the patch passed | | +1 | findbugs | 252 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 19269 | hbase-server in the patch failed. | | -1 | asflicense | 26 | The patch generated 19 ASF License warnings. | | | | 22531 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.TestReplicationStatusSourceStartedTargetStoppedNewOp | | | hadoop.hbase.regionserver.TestRegionReplicasWithRestartScenarios | | | hadoop.hbase.replication.TestReplicationDisableInactivePeer | | | hadoop.hbase.fs.TestBlockReorderMultiBlocks | | | hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint | | | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | | hadoop.hbase.security.visibility.TestDefaultScanLabelGeneratorStack | | | hadoop.hbase.TestSplitMerge | | | hadoop.hbase.replication.TestReplicationWithTags | | | hadoop.hbase.master.TestMirroringTableStateManager | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientSchemaChange | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.regionserver.TestIsDeleteFailure | | | hadoop.hbase.regionserver.TestScannerWithBulkload | | | hadoop.hbase.master.TestMetaShutdownHandler | | | hadoop.hbase.master.TestMetaAssignmentWithStopMaster | | | hadoop.hbase.regionserver.TestEncryptionRandomKeying | | | hadoop.hbase.TestMultiVersions | | | hadoop.hbase.security.visibility.TestVisibilityLabelsOpWithDifferentUsersNoACL | | | hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL | | | hadoop.hbase.procedure.TestProcedureManager | | | hadoop.hbase.security.access.TestAccessController | | | hadoop.hbase.coprocessor.TestPostIncrementAndAppendBeforeWAL | | | hadoop.hbase.security.visibility.TestVisibilityLabelsWithSLGStack | | | hadoop.hbase.client.TestCIBadHostname | | | hadoop.hbase.wal.TestFSHLogCorruptionDueToDanglingByteBuffer | | | hadoop.hbase.fs.TestBlockReorderBlockLocation | | | hadoop.hbase.client.TestRestoreSnapshotFromClientAfterSplittingRegions | | | hadoop.hbase.security.visibility.TestVisibilityLabelsReplication | | | hadoop.hbase.client.TestAsyncTableRegionReplicasGet | | | hadoop.hbase.TestClusterPortAssignment | | | hadoop.hbase.master.TestMasterFileSystem | | | hadoop.hbase.regionserver.TestRegionReplicas | | | hadoop.hbase.client.TestInvalidMutationDurabilityException | | | hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService | | | hadoop.hbase.client.TestRawAsyncScanCursor | | | hadoop.hbase.mob.compactions.TestMobCompactor | | | hadoop.hbase.regionserver.TestHdfsSnapshotHRegion | | | hadoop.hbase.master.procedure.TestSCPWithMetaWithoutZKCoordinated | | | hadoop.hbase.client.TestGetScanPartialResult | | | hadoop.hbase.TestJMXConnectorServer | | | hadoop.hbase.client.TestSnapshotFromClientWithRegionReplicas | | | hadoop.hbase.client.TestSnapshotCloneIndependence | | | hadoop.hbase.client.TestAsyncNonMetaRegionLocator | | | hadoop.hbase.client.TestAsyncSnapshotAdminApi | | | hadoop.hbase.replication.TestSerialSyncReplication | | | hadoop.hbase.TestMetaTableAccessor | | |
[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-522821689 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 39 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 33 | Maven dependency ordering for branch | | +1 | mvninstall | 298 | master passed | | +1 | compile | 94 | master passed | | +1 | checkstyle | 103 | master passed | | +1 | shadedjars | 265 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 70 | master passed | | 0 | spotbugs | 240 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 328 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 290 | the patch passed | | +1 | compile | 102 | the patch passed | | +1 | javac | 102 | the patch passed | | -1 | checkstyle | 71 | hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 266 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 923 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 68 | the patch passed | | -1 | findbugs | 53 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 177 | hbase-common in the patch passed. | | -1 | unit | 9098 | hbase-server in the patch failed. | | +1 | unit | 274 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 73 | The patch does not generate ASF License warnings. | | | | 13370 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.Version.() invokes inefficient new String(String) constructor At Version.java:inefficient new String(String) constructor At Version.java:[line 10] | | Failed junit tests | hadoop.hbase.regionserver.TestHRegion | | | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/59/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/435 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 7e8e68c8cf82 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh | | git revision | master / 67382809d3 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/59/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/59/artifact/out/new-findbugs-hbase-common.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/59/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/59/testReport/ | | Max. process+thread count | 4823 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/59/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (HBASE-22881) Fix Non-daemon threads in HMaster
[ https://issues.apache.org/jira/browse/HBASE-22881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha reassigned HBASE-22881: -- Assignee: Xiaolin Ha > Fix Non-daemon threads in HMaster > - > > Key: HBASE-22881 > URL: https://issues.apache.org/jira/browse/HBASE-22881 > Project: HBase > Issue Type: Bug > Components: master >Reporter: Xiaolin Ha >Assignee: Xiaolin Ha >Priority: Minor > > "pool-8-thread-3" #7252 prio=5 os_prio=0 tid=0x7f91040044c0 nid=0xd71e > waiting on condition [0x7f8f4d209000] >java.lang.Thread.State: WAITING (parking) > at sun.misc.Unsafe.park(Native Method) > - parking to wait for <0x0005c0e49ed0> (a > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject) > at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) > at > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039) > at > java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442) > at > java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) >Locked ownable synchronizers: > - None > "pool-8-thread-2" #7251 prio=5 os_prio=0 tid=0x7f910c010be0 nid=0xd71d > waiting on condition [0x7f8f4daab000] >java.lang.Thread.State: WAITING (parking) > at sun.misc.Unsafe.park(Native Method) > - parking to wait for <0x0005c0e49ed0> (a > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject) > at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) > at > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039) > at > java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442) > at > java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) >Locked ownable synchronizers: > - None > "pool-8-thread-1" #7250 prio=5 os_prio=0 tid=0x7f9119d0 nid=0xd71c > waiting on condition [0x7f8f4da6a000] >java.lang.Thread.State: WAITING (parking) > at sun.misc.Unsafe.park(Native Method) > - parking to wait for <0x0005c0e49ed0> (a > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject) > at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) > at > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039) > at > java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442) > at > java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) >Locked ownable synchronizers: > - None > "pool-5-thread-3" #7248 prio=5 os_prio=0 tid=0x7f9238005ad0 nid=0xd71a > waiting on condition [0x7f8f4cb65000] >java.lang.Thread.State: WAITING (parking) > at sun.misc.Unsafe.park(Native Method) > - parking to wait for <0x0005c0ec51e0> (a > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject) > at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) > at > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039) > at > java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442) > at > java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-522819197 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 36 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 33 | Maven dependency ordering for branch | | +1 | mvninstall | 300 | master passed | | +1 | compile | 73 | master passed | | +1 | checkstyle | 99 | master passed | | +1 | shadedjars | 271 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 52 | master passed | | 0 | spotbugs | 246 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 310 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 289 | the patch passed | | +1 | compile | 74 | the patch passed | | +1 | javac | 74 | the patch passed | | +1 | checkstyle | 96 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 259 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 890 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 51 | the patch passed | | +1 | findbugs | 320 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 103 | hbase-client in the patch passed. | | -1 | unit | 8866 | hbase-server in the patch failed. | | +1 | asflicense | 53 | The patch does not generate ASF License warnings. | | | | 12558 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | | hadoop.hbase.regionserver.TestHRegion | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/113/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 5a71bf5a0373 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / 67382809d3 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/113/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/113/testReport/ | | Max. process+thread count | 4919 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/113/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)
Apache-HBase commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#issuecomment-522818522 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 44 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | 0 | mvndep | 36 | Maven dependency ordering for branch | | +1 | mvninstall | 363 | master passed | | +1 | compile | 186 | master passed | | +1 | shadedjars | 266 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 266 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 312 | the patch passed | | +1 | compile | 190 | the patch passed | | +1 | javac | 190 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 9 | The patch has no ill-formed XML file. | | +1 | shadedjars | 283 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 962 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 258 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 9340 | root in the patch failed. | | +1 | asflicense | 157 | The patch does not generate ASF License warnings. | | | | 13117 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestHRegion | | | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/12/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/505 | | Optional Tests | dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile | | uname | Linux 992dcfe98120 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh | | git revision | master / 67382809d3 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/12/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/12/testReport/ | | Max. process+thread count | 4741 (vs. ulimit of 1) | | modules | C: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/12/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.
[
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910900#comment-16910900
]
Hadoop QA commented on HBASE-22601:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
24s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
7s{color} | {color:blue} Used deprecated FindBugs config; considering switching
to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
4s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
24s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
14m 50s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
1s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}148m 8s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}203m 19s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.security.token.TestZKSecretWatcher |
| | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush |
| | hadoop.hbase.regionserver.TestHRegion |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/16/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/499 |
| JIRA Issue | HBASE-22601 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux f13b10539323 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[GitHub] [hbase] Apache-HBase commented on issue #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.
Apache-HBase commented on issue #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/499#issuecomment-522816824 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 77 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 333 | master passed | | +1 | compile | 53 | master passed | | +1 | checkstyle | 72 | master passed | | +1 | shadedjars | 264 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 34 | master passed | | 0 | spotbugs | 247 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 244 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 289 | the patch passed | | +1 | compile | 53 | the patch passed | | +1 | javac | 53 | the patch passed | | +1 | checkstyle | 74 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 264 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 890 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 32 | the patch passed | | +1 | findbugs | 241 | the patch passed | ||| _ Other Tests _ | | -1 | unit | | hbase-server in the patch failed. | | +1 | asflicense | 24 | The patch does not generate ASF License warnings. | | | | 12199 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.security.token.TestZKSecretWatcher | | | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | | hadoop.hbase.regionserver.TestHRegion | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/16/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/499 | | JIRA Issue | HBASE-22601 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f13b10539323 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-499/out/precommit/personality/provided.sh | | git revision | master / 67382809d3 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/16/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/16/testReport/ | | Max. process+thread count | 4787 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/16/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload
Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/494#issuecomment-522812442 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 41 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ branch-2 Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for branch | | +1 | mvninstall | 312 | branch-2 passed | | +1 | compile | 108 | branch-2 passed | | +1 | checkstyle | 119 | branch-2 passed | | +1 | shadedjars | 242 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 66 | branch-2 passed | | 0 | spotbugs | 171 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 381 | branch-2 passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 285 | the patch passed | | +1 | compile | 111 | the patch passed | | +1 | cc | 111 | the patch passed | | +1 | javac | 111 | the patch passed | | -1 | checkstyle | 76 | hbase-server: The patch generated 1 new + 302 unchanged - 0 fixed = 303 total (was 302) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 243 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 888 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | hbaseprotoc | 98 | the patch passed | | +1 | javadoc | 69 | the patch passed | | -1 | findbugs | 201 | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 34 | hbase-protocol-shaded in the patch passed. | | +1 | unit | 195 | hbase-client in the patch passed. | | +1 | unit | 8115 | hbase-server in the patch passed. | | +1 | asflicense | 68 | The patch does not generate ASF License warnings. | | | | 12338 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 257] | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/16/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/494 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc | | uname | Linux 3fd897ac8b62 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh | | git revision | branch-2 / e9874a6abd | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/16/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/16/artifact/out/new-findbugs-hbase-server.html | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/16/testReport/ | | Max. process+thread count | 4662 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/16/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.
[
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910888#comment-16910888
]
Hadoop QA commented on HBASE-22601:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
38s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
13s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
44s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
37s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
49s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
19s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
16s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
42s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
23m 16s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
6s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}234m
27s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
29s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}311m 42s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.0 Server=19.03.0 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/13/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/500 |
| JIRA Issue | HBASE-22601 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 7bca1b565ecb 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4
22:49:08 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-500/out/precommit/personality/provided.sh
|
| git revision | branch-2 / b7c7b4a570 |
| Default Java | 1.8.0_181 |
| Test Results |
[jira] [Commented] (HBASE-22875) TestShell and TestAdminShell2 are broken
[ https://issues.apache.org/jira/browse/HBASE-22875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910887#comment-16910887 ] Duo Zhang commented on HBASE-22875: --- Thanks [~psomogyi]. > TestShell and TestAdminShell2 are broken > > > Key: HBASE-22875 > URL: https://issues.apache.org/jira/browse/HBASE-22875 > Project: HBase > Issue Type: Bug > Components: shell, test >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.
Apache-HBase commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/500#issuecomment-522811926 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 129 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2 Compile Tests _ | | +1 | mvninstall | 458 | branch-2 passed | | +1 | compile | 73 | branch-2 passed | | +1 | checkstyle | 104 | branch-2 passed | | +1 | shadedjars | 337 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 49 | branch-2 passed | | 0 | spotbugs | 259 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 256 | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 433 | the patch passed | | +1 | compile | 74 | the patch passed | | +1 | javac | 74 | the patch passed | | +1 | checkstyle | 98 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 342 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1396 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 51 | the patch passed | | +1 | findbugs | 246 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 14067 | hbase-server in the patch passed. | | +1 | asflicense | 29 | The patch does not generate ASF License warnings. | | | | 18702 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/13/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/500 | | JIRA Issue | HBASE-22601 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 7bca1b565ecb 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-500/out/precommit/personality/provided.sh | | git revision | branch-2 / b7c7b4a570 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/13/testReport/ | | Max. process+thread count | 4507 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-500/13/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-522809427 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 93 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 373 | master passed | | +1 | compile | 60 | master passed | | +1 | checkstyle | 97 | master passed | | +1 | shadedjars | 304 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 39 | master passed | | 0 | spotbugs | 273 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 270 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 339 | the patch passed | | +1 | compile | 60 | the patch passed | | +1 | javac | 60 | the patch passed | | +1 | checkstyle | 89 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 307 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1096 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 39 | the patch passed | | +1 | findbugs | 290 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 13909 | hbase-server in the patch failed. | | +1 | asflicense | 26 | The patch does not generate ASF License warnings. | | | | 17823 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | | hadoop.hbase.regionserver.TestHRegion | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/33/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/468 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux da2e8b75 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh | | git revision | master / 8e488ce9ef | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/33/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/33/testReport/ | | Max. process+thread count | 4755 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/33/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22874) Canary should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-22874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910873#comment-16910873 ] Duo Zhang commented on HBASE-22874: --- And since you said you want to get something back, then I do not think this is a suitable way to you as there is no way to intercept the input and output of the Tool, unless you do some magic on the Tool it self but this will break the assumption that you can only use the method from the Tool interface. So I think we still need an interface here. Just like the BulkLoadHFiles. Thanks. > Canary should not be IA.Public > -- > > Key: HBASE-22874 > URL: https://issues.apache.org/jira/browse/HBASE-22874 > Project: HBase > Issue Type: Bug > Components: canary >Reporter: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > > It can be marked as IA.LimitedPrivate(TOOLS). -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22874) Canary should not be IA.Public
[
https://issues.apache.org/jira/browse/HBASE-22874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910872#comment-16910872
]
Duo Zhang commented on HBASE-22874:
---
OK, jira is back finnaly.
The IA.Public means all the public API can not be changed unless it is
deprecated for a whole major version, this is a very strong guarantee, so when
providing an IA.Public stuff you need to be very careful.
For IA.LimitedPrivate("TOOLS"), it means that you can invoke it from command
line, with the ToolRunner, and usually we will give it a special name, such as
our 'pe' and 'ltt'. And if want to use the tool in code, typically, the way is
to use it like this
{code:java}
ToolRunner.run(conf, new Tool(), args);
{code}
So the guarantee here is that, it will extends the Tool interface and can be
invoked through the ToolRunner. And maybe we should always provide a default
constructor probably we do not...
> Canary should not be IA.Public
> --
>
> Key: HBASE-22874
> URL: https://issues.apache.org/jira/browse/HBASE-22874
> Project: HBase
> Issue Type: Bug
> Components: canary
>Reporter: Duo Zhang
>Priority: Blocker
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> It can be marked as IA.LimitedPrivate(TOOLS).
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase-operator-tools] asf-ci commented on issue #16: HBASE-22825 [HBCK2] Add a client-side to hbase-operator-tools that ca…
asf-ci commented on issue #16: HBASE-22825 [HBCK2] Add a client-side to hbase-operator-tools that ca… URL: https://github.com/apache/hbase-operator-tools/pull/16#issuecomment-522806164 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build/65/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] jatsakthi commented on issue #16: HBASE-22825 [HBCK2] Add a client-side to hbase-operator-tools that ca…
jatsakthi commented on issue #16: HBASE-22825 [HBCK2] Add a client-side to hbase-operator-tools that ca… URL: https://github.com/apache/hbase-operator-tools/pull/16#issuecomment-522805044 Haven't added UTs, as it would be very similar to what we have in TestMetaFixer. Let me know if we would still like it to be present. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] jatsakthi opened a new pull request #16: HBASE-22825 [HBCK2] Add a client-side to hbase-operator-tools that ca…
jatsakthi opened a new pull request #16: HBASE-22825 [HBCK2] Add a client-side to hbase-operator-tools that ca… URL: https://github.com/apache/hbase-operator-tools/pull/16 …n exploit fixMeta added in server side This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #476: HBASE-11062 hbtop
Apache-HBase commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-522801999 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 43 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | 0 | shelldocs | 1 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 1 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 22 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 34 | Maven dependency ordering for branch | | +1 | mvninstall | 338 | master passed | | +1 | compile | 174 | master passed | | +1 | checkstyle | 158 | master passed | | +1 | shadedjars | 289 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 182 | master passed | | 0 | spotbugs | 26 | Used deprecated FindBugs config; considering switching to SpotBugs. | | 0 | findbugs | 26 | branch/hbase-assembly no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 337 | the patch passed | | +1 | compile | 194 | the patch passed | | +1 | javac | 194 | the patch passed | | +1 | checkstyle | 159 | the patch passed | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 4 | The patch has no ill-formed XML file. | | +1 | shadedjars | 304 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 960 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 203 | the patch passed | | 0 | findbugs | 27 | hbase-assembly has no data from findbugs | ||| _ Other Tests _ | | -1 | unit | 9520 | root in the patch failed. | | +1 | asflicense | 72 | The patch does not generate ASF License warnings. | | | | 15385 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | | hadoop.hbase.regionserver.TestHRegion | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/27/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/476 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux 12754e29974e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-476@2/out/precommit/personality/provided.sh | | git revision | master / 8e488ce9ef | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/27/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/27/testReport/ | | Max. process+thread count | 4685 (vs. ulimit of 1) | | modules | C: hbase-hbtop . hbase-assembly U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/27/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)
Apache-HBase commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#issuecomment-522796445 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 37 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | 0 | mvndep | 35 | Maven dependency ordering for branch | | +1 | mvninstall | 310 | master passed | | +1 | compile | 181 | master passed | | +1 | shadedjars | 279 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 262 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 303 | the patch passed | | +1 | compile | 187 | the patch passed | | +1 | javac | 187 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 10 | The patch has no ill-formed XML file. | | +1 | shadedjars | 275 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 941 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 265 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 10010 | root in the patch failed. | | +1 | asflicense | 164 | The patch does not generate ASF License warnings. | | | | 13696 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestHRegion | | | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/11/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/505 | | Optional Tests | dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile | | uname | Linux a879d01eba97 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh | | git revision | master / 8e488ce9ef | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/11/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/11/testReport/ | | Max. process+thread count | 4694 (vs. ulimit of 1) | | modules | C: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/11/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #509: HBASE-22877 WebHDFS based export snapshot will fail if hfile is in archive directory
Apache-HBase commented on issue #509: HBASE-22877 WebHDFS based export snapshot will fail if hfile is in archive directory URL: https://github.com/apache/hbase/pull/509#issuecomment-522795905 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 33 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 364 | master passed | | +1 | compile | 62 | master passed | | +1 | checkstyle | 93 | master passed | | +1 | shadedjars | 277 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 40 | master passed | | 0 | spotbugs | 282 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 280 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 343 | the patch passed | | +1 | compile | 66 | the patch passed | | +1 | javac | 66 | the patch passed | | -1 | checkstyle | 95 | hbase-server: The patch generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 323 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1085 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 36 | the patch passed | | +1 | findbugs | 324 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 9610 | hbase-server in the patch failed. | | +1 | asflicense | 28 | The patch does not generate ASF License warnings. | | | | 13493 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestHRegion | | | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/509 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 0126ab4d2185 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-509/out/precommit/personality/provided.sh | | git revision | master / 8e488ce9ef | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/3/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/3/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/3/testReport/ | | Max. process+thread count | 4375 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-522794510 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 38 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 1 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 34 | Maven dependency ordering for branch | | +1 | mvninstall | 307 | master passed | | +1 | compile | 94 | master passed | | +1 | checkstyle | 104 | master passed | | +1 | shadedjars | 259 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 68 | master passed | | 0 | spotbugs | 236 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 325 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 300 | the patch passed | | +1 | compile | 103 | the patch passed | | +1 | javac | 103 | the patch passed | | -1 | checkstyle | 77 | hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 277 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 958 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 72 | the patch passed | | -1 | findbugs | 56 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 177 | hbase-common in the patch passed. | | -1 | unit | 8657 | hbase-server in the patch failed. | | +1 | unit | 304 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 62 | The patch does not generate ASF License warnings. | | | | 13053 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.Version.() invokes inefficient new String(String) constructor At Version.java:inefficient new String(String) constructor At Version.java:[line 10] | | Failed junit tests | hadoop.hbase.regionserver.TestHRegion | | | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/58/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/435 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux aed281250e01 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh | | git revision | master / 8e488ce9ef | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/58/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/58/artifact/out/new-findbugs-hbase-common.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/58/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/58/testReport/ | | Max. process+thread count | 4292 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/58/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#issuecomment-522793879 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 108 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 33 | Maven dependency ordering for branch | | +1 | mvninstall | 300 | master passed | | +1 | compile | 75 | master passed | | +1 | checkstyle | 96 | master passed | | +1 | shadedjars | 262 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 54 | master passed | | 0 | spotbugs | 256 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 306 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 284 | the patch passed | | +1 | compile | 73 | the patch passed | | +1 | javac | 73 | the patch passed | | +1 | checkstyle | 22 | hbase-common: The patch generated 0 new + 48 unchanged - 2 fixed = 48 total (was 50) | | -1 | checkstyle | 70 | hbase-server: The patch generated 1 new + 48 unchanged - 0 fixed = 49 total (was 48) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 263 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 898 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 58 | the patch passed | | +1 | findbugs | 287 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 175 | hbase-common in the patch passed. | | -1 | unit | 9092 | hbase-server in the patch failed. | | +1 | asflicense | 41 | The patch does not generate ASF License warnings. | | | | 12888 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | | hadoop.hbase.regionserver.TestHRegion | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/26/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/479 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux abcae28daecf 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-479/out/precommit/personality/provided.sh | | git revision | master / 8e488ce9ef | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/26/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/26/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/26/testReport/ | | Max. process+thread count | 4670 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/26/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #510: HBASE-22878 Show table throttle quotas in table jsp
Apache-HBase commented on issue #510: HBASE-22878 Show table throttle quotas in table jsp URL: https://github.com/apache/hbase/pull/510#issuecomment-522793679 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 39 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | 0 | mvndep | 35 | Maven dependency ordering for branch | | +1 | mvninstall | 310 | master passed | | +1 | compile | 76 | master passed | | +1 | checkstyle | 100 | master passed | | +1 | shadedjars | 269 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 56 | master passed | | 0 | spotbugs | 255 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 326 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 297 | the patch passed | | +1 | compile | 75 | the patch passed | | +1 | javac | 75 | the patch passed | | +1 | checkstyle | 95 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 262 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 920 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 56 | the patch passed | | +1 | findbugs | 324 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 105 | hbase-client in the patch passed. | | -1 | unit | 9045 | hbase-server in the patch failed. | | +1 | asflicense | 49 | The patch does not generate ASF License warnings. | | | | 12856 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | | hadoop.hbase.regionserver.TestHRegion | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/510 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 35ab7989a14c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-510/out/precommit/personality/provided.sh | | git revision | master / 8e488ce9ef | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/3/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/3/testReport/ | | Max. process+thread count | 4472 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #501: HBASE-22699 refactor isMetaClearingException
Apache-HBase commented on issue #501: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/501#issuecomment-522793811 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 36 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 34 | Maven dependency ordering for branch | | +1 | mvninstall | 315 | master passed | | +1 | compile | 78 | master passed | | +1 | checkstyle | 101 | master passed | | +1 | shadedjars | 274 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 56 | master passed | | 0 | spotbugs | 254 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 325 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 302 | the patch passed | | +1 | compile | 84 | the patch passed | | +1 | javac | 84 | the patch passed | | +1 | checkstyle | 102 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 273 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 929 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 54 | the patch passed | | +1 | findbugs | 339 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 107 | hbase-client in the patch passed. | | -1 | unit | 9016 | hbase-server in the patch failed. | | +1 | asflicense | 49 | The patch does not generate ASF License warnings. | | | | 12893 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestHRegion | | | hadoop.hbase.client.TestMetaCache | | | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/13/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/501 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 4e8ae9d285a2 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-501/out/precommit/personality/provided.sh | | git revision | master / 8e488ce9ef | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/13/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/13/testReport/ | | Max. process+thread count | 4740 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/13/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-522792879 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 58 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 420 | master passed | | +1 | compile | 30 | master passed | | +1 | checkstyle | 15 | master passed | | +1 | shadedjars | 363 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 26 | master passed | | 0 | spotbugs | 60 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 57 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 390 | the patch passed | | +1 | compile | 30 | the patch passed | | +1 | javac | 30 | the patch passed | | +1 | checkstyle | 14 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 358 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1165 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 25 | the patch passed | | +1 | findbugs | 67 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 673 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 14 | The patch does not generate ASF License warnings. | | | | 4164 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/103/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux aae794c5812a 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / 67382809d3 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/103/testReport/ | | Max. process+thread count | 4576 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/103/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes…
Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes… URL: https://github.com/apache/hbase/pull/446#issuecomment-522792526 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 92 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 324 | master passed | | +1 | compile | 52 | master passed | | +1 | checkstyle | 73 | master passed | | +1 | shadedjars | 261 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 34 | master passed | | 0 | spotbugs | 261 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 259 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 297 | the patch passed | | +1 | compile | 50 | the patch passed | | +1 | javac | 50 | the patch passed | | +1 | checkstyle | 69 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 264 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 906 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 31 | the patch passed | | +1 | findbugs | 245 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 9139 | hbase-server in the patch failed. | | +1 | asflicense | 24 | The patch does not generate ASF License warnings. | | | | 12480 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | | hadoop.hbase.regionserver.TestHRegion | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/56/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/446 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b8985836192d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-446/out/precommit/personality/provided.sh | | git revision | master / 8e488ce9ef | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/56/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/56/testReport/ | | Max. process+thread count | 4760 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/56/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.
[
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910831#comment-16910831
]
Hadoop QA commented on HBASE-22601:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
37s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
24s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
10s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
9s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
29s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 2s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
10s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}149m 14s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
26s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}204m 24s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush |
| | hadoop.hbase.regionserver.TestHRegion |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/15/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/499 |
| JIRA Issue | HBASE-22601 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 449bd5e5821e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[GitHub] [hbase] Apache-HBase commented on issue #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.
Apache-HBase commented on issue #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/499#issuecomment-522791576 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 37 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 319 | master passed | | +1 | compile | 52 | master passed | | +1 | checkstyle | 77 | master passed | | +1 | shadedjars | 264 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 34 | master passed | | 0 | spotbugs | 250 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 249 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 300 | the patch passed | | +1 | compile | 52 | the patch passed | | +1 | javac | 52 | the patch passed | | +1 | checkstyle | 69 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 269 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 902 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 33 | the patch passed | | +1 | findbugs | 250 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 8954 | hbase-server in the patch failed. | | +1 | asflicense | 26 | The patch does not generate ASF License warnings. | | | | 12264 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | | hadoop.hbase.regionserver.TestHRegion | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/15/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/499 | | JIRA Issue | HBASE-22601 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 449bd5e5821e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-499/out/precommit/personality/provided.sh | | git revision | master / 8e488ce9ef | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/15/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/15/testReport/ | | Max. process+thread count | 4476 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-499/15/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload
Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/494#issuecomment-522790233 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 41 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ branch-2 Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for branch | | +1 | mvninstall | 306 | branch-2 passed | | +1 | compile | 108 | branch-2 passed | | +1 | checkstyle | 121 | branch-2 passed | | +1 | shadedjars | 243 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 66 | branch-2 passed | | 0 | spotbugs | 195 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 418 | branch-2 passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 282 | the patch passed | | +1 | compile | 106 | the patch passed | | +1 | cc | 106 | the patch passed | | +1 | javac | 106 | the patch passed | | -1 | checkstyle | 71 | hbase-server: The patch generated 1 new + 302 unchanged - 0 fixed = 303 total (was 302) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 242 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 874 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | hbaseprotoc | 100 | the patch passed | | +1 | javadoc | 64 | the patch passed | | -1 | findbugs | 204 | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 34 | hbase-protocol-shaded in the patch passed. | | +1 | unit | 201 | hbase-client in the patch passed. | | +1 | unit | 7729 | hbase-server in the patch passed. | | +1 | asflicense | 61 | The patch does not generate ASF License warnings. | | | | 11954 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 257] | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/15/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/494 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc | | uname | Linux fab6be06dd0b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh | | git revision | branch-2 / b7c7b4a570 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/15/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/15/artifact/out/new-findbugs-hbase-server.html | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/15/testReport/ | | Max. process+thread count | 4533 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/15/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes…
Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes… URL: https://github.com/apache/hbase/pull/446#issuecomment-522788865 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 101 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 436 | master passed | | +1 | compile | 74 | master passed | | +1 | checkstyle | 98 | master passed | | +1 | shadedjars | 354 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 41 | master passed | | 0 | spotbugs | 314 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 309 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 397 | the patch passed | | +1 | compile | 68 | the patch passed | | +1 | javac | 68 | the patch passed | | +1 | checkstyle | 93 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 348 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1258 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 42 | the patch passed | | +1 | findbugs | 311 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 19707 | hbase-server in the patch failed. | | +1 | asflicense | 32 | The patch does not generate ASF License warnings. | | | | 24178 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.namespace.TestNamespaceAuditor | | | hadoop.hbase.client.TestCloneSnapshotFromClientNormal | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/55/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/446 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3567bed6a4f3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-446/out/precommit/personality/provided.sh | | git revision | master / 46abaef4be | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/55/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/55/testReport/ | | Max. process+thread count | 4941 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/55/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #487: HBASE-22844 Fixed Checkstyle violations in client snapshot exceptions
Apache-HBase commented on issue #487: HBASE-22844 Fixed Checkstyle violations in client snapshot exceptions URL: https://github.com/apache/hbase/pull/487#issuecomment-522788453 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 177 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 355 | master passed | | +1 | compile | 26 | master passed | | +1 | checkstyle | 31 | master passed | | +1 | shadedjars | 325 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 23 | master passed | | 0 | spotbugs | 77 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 75 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 342 | the patch passed | | +1 | compile | 25 | the patch passed | | +1 | javac | 25 | the patch passed | | +1 | checkstyle | 30 | hbase-client: The patch generated 0 new + 0 unchanged - 13 fixed = 0 total (was 13) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 284 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1087 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 | javadoc | 21 | hbase-client generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) | | +1 | findbugs | 74 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 103 | hbase-client in the patch passed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 3405 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/19/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/487 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e547d516bc7b 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-487/out/precommit/personality/provided.sh | | git revision | master / 67382809d3 | | Default Java | 1.8.0_181 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/19/artifact/out/diff-javadoc-javadoc-hbase-client.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/19/testReport/ | | Max. process+thread count | 295 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/19/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility
Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility URL: https://github.com/apache/hbase/pull/477#issuecomment-522787635 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 33 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 46 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 350 | master passed | | +1 | compile | 60 | master passed | | +1 | checkstyle | 98 | master passed | | +1 | shadedjars | 328 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 39 | master passed | | 0 | spotbugs | 298 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 295 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 354 | the patch passed | | +1 | compile | 61 | the patch passed | | +1 | javac | 61 | the patch passed | | +1 | checkstyle | 97 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 305 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1078 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 38 | the patch passed | | +1 | findbugs | 301 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 19892 | hbase-server in the patch failed. | | -1 | asflicense | 33 | The patch generated 19 ASF License warnings. | | | | 23844 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestRegionServerAbort | | | hadoop.hbase.util.compaction.TestMajorCompactor | | | hadoop.hbase.client.TestAsyncResultScannerCursor | | | hadoop.hbase.master.TestMasterHandlerFullWhenTransitRegion | | | hadoop.hbase.master.assignment.TestWakeUpUnexpectedProcedure | | | hadoop.hbase.replication.TestReplicationSyncUpToolWithBulkLoadedData | | | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.master.TestMirroringTableStateManager | | | hadoop.hbase.TestServerSideScanMetricsFromClientSide | | | hadoop.hbase.tool.TestCanaryTool | | | hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes | | | hadoop.hbase.replication.TestMasterReplication | | | hadoop.hbase.master.procedure.TestCreateTableProcedureMuitipleRegions | | | hadoop.hbase.replication.TestReplicationWithTags | | | hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures | | | hadoop.hbase.client.TestRestoreSnapshotFromClientGetCompactionState | | | hadoop.hbase.client.TestResultSizeEstimation | | | hadoop.hbase.master.TestClusterRestartFailover | | | hadoop.hbase.client.TestDropTimeoutRequest | | | hadoop.hbase.client.TestEnableTable | | | hadoop.hbase.coprocessor.TestMetaTableMetrics | | | hadoop.hbase.mob.compactions.TestMobCompactor | | | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.regionserver.TestRegionOpen | | | hadoop.hbase.master.procedure.TestTableDescriptorModificationFromClient | | | hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL | | | hadoop.hbase.replication.TestPerTableCFReplication | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientGetCompactionState | | | hadoop.hbase.replication.TestAddToSerialReplicationPeer | | | hadoop.hbase.replication.TestReplicationMetricsforUI | | | hadoop.hbase.client.TestCheckAndMutate | | | hadoop.hbase.client.TestAsyncTable | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientClone | | | hadoop.hbase.regionserver.TestNotCleanupCompactedFileWhenRegionWarmup | | | hadoop.hbase.client.TestResultFromCoprocessor | | | hadoop.hbase.quotas.TestFileArchiverNotifierImpl | | | hadoop.hbase.master.balancer.TestBalancerStatusTagInJMXMetrics | | | hadoop.hbase.tool.TestSecureBulkLoadHFilesSplitRecovery | | | hadoop.hbase.master.assignment.TestSplitTableRegionProcedure | | | hadoop.hbase.regionserver.TestCompactorMemLeak | | | hadoop.hbase.replication.TestReplicationDisableInactivePeer | | | hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL | | | hadoop.hbase.client.TestRegionLocator | | | hadoop.hbase.TestClientClusterStatus | | | hadoop.hbase.coprocessor.TestMasterObserverToModifyTableSchema | | | hadoop.hbase.regionserver.wal.TestAsyncProtobufLog | | | hadoop.hbase.coprocessor.TestMasterObserver | | |
[jira] [Commented] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary
[
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910816#comment-16910816
]
HBase QA commented on HBASE-22804:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m
26s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
21s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
8s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
17s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
7s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
53s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
53s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
14m 49s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}235m 35s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}293m 2s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/804/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22804 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12977990/HBASE-22804.branch-2.006.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 6beeb000bc4e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 29ed4157b3 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/804/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/804/testReport/ |
| Max. process+thread count | 4506 (vs. ulimit of 1) |
| modules | C: hbase-server
[GitHub] [hbase] Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-522785423 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 61 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 407 | master passed | | +1 | compile | 73 | master passed | | +1 | checkstyle | 93 | master passed | | +1 | shadedjars | 356 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 45 | master passed | | 0 | spotbugs | 317 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 313 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 406 | the patch passed | | +1 | compile | 77 | the patch passed | | +1 | javac | 77 | the patch passed | | +1 | checkstyle | 104 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 345 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1270 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 41 | the patch passed | | +1 | findbugs | 312 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 18859 | hbase-server in the patch failed. | | +1 | asflicense | 33 | The patch does not generate ASF License warnings. | | | | 23292 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.replication.TestReplicationDisableInactivePeer | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.tool.TestBulkLoadHFiles | | | hadoop.hbase.replication.TestReplicationSmallTestsSync | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/32/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/468 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 28b518d9d2e0 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh | | git revision | master / 46abaef4be | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/32/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/32/testReport/ | | Max. process+thread count | 5018 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/32/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #511: HBASE-22879 user_permission command failed to show global permission
Apache-HBase commented on issue #511: HBASE-22879 user_permission command failed to show global permission URL: https://github.com/apache/hbase/pull/511#issuecomment-522785248 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 83 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 418 | master passed | | +1 | compile | 23 | master passed | | +1 | checkstyle | 12 | master passed | | +1 | shadedjars | 297 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 13 | master passed | | 0 | spotbugs | 312 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 0 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 309 | the patch passed | | +1 | compile | 23 | the patch passed | | +1 | javac | 23 | the patch passed | | +1 | checkstyle | 10 | the patch passed | | -1 | rubocop | 25 | The patch generated 3 new + 67 unchanged - 3 fixed = 70 total (was 70) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 287 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 974 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 13 | the patch passed | | +1 | findbugs | 0 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 615 | hbase-shell in the patch passed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 3511 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/511 | | Optional Tests | dupname asflicense javac javadoc unit rubocop spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 53d5983804fb 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-511/out/precommit/personality/provided.sh | | git revision | master / 67382809d3 | | Default Java | 1.8.0_181 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/5/artifact/out/diff-patch-rubocop.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/5/testReport/ | | Max. process+thread count | 2523 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.74.0 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#issuecomment-522784978 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 78 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 39 | Maven dependency ordering for branch | | +1 | mvninstall | 405 | master passed | | +1 | compile | 95 | master passed | | +1 | checkstyle | 129 | master passed | | +1 | shadedjars | 367 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 71 | master passed | | 0 | spotbugs | 336 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 395 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 34 | Maven dependency ordering for patch | | +1 | mvninstall | 435 | the patch passed | | +1 | compile | 98 | the patch passed | | +1 | javac | 98 | the patch passed | | +1 | checkstyle | 32 | hbase-common: The patch generated 0 new + 48 unchanged - 2 fixed = 48 total (was 50) | | -1 | checkstyle | 98 | hbase-server: The patch generated 1 new + 48 unchanged - 0 fixed = 49 total (was 48) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 360 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1393 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 71 | the patch passed | | +1 | findbugs | 403 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 216 | hbase-common in the patch passed. | | -1 | unit | 17847 | hbase-server in the patch failed. | | +1 | asflicense | 56 | The patch does not generate ASF License warnings. | | | | 23177 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/25/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/479 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f2cf32e999d9 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-479/out/precommit/personality/provided.sh | | git revision | master / 46abaef4be | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/25/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/25/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/25/testReport/ | | Max. process+thread count | 4874 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/25/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-522783237 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 77 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | 0 | shelldocs | 2 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 43 | Maven dependency ordering for branch | | +1 | mvninstall | 326 | master passed | | +1 | compile | 101 | master passed | | +1 | checkstyle | 105 | master passed | | +1 | shadedjars | 298 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 76 | master passed | | 0 | spotbugs | 263 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 358 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 352 | the patch passed | | +1 | compile | 136 | the patch passed | | +1 | javac | 136 | the patch passed | | -1 | checkstyle | 80 | hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 262 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 918 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 70 | the patch passed | | -1 | findbugs | 54 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 170 | hbase-common in the patch passed. | | -1 | unit | 17830 | hbase-server in the patch failed. | | +1 | unit | 503 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 85 | The patch does not generate ASF License warnings. | | | | 22693 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.Version.() invokes inefficient new String(String) constructor At Version.java:inefficient new String(String) constructor At Version.java:[line 10] | | Failed junit tests | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/57/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/435 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c092880db4ff 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh | | git revision | master / 46abaef4be | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/57/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/57/artifact/out/new-findbugs-hbase-common.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/57/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/57/testReport/ | | Max. process+thread count | 4752 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/57/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #496: HBASE-22625 documet use scan snapshot feature
Apache-HBase commented on issue #496: HBASE-22625 documet use scan snapshot feature URL: https://github.com/apache/hbase/pull/496#issuecomment-522782617 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 491 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 1 | Shelldocs was not available. | | +1 | @author | 0 | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 | mvninstall | 354 | master passed | | 0 | refguide | 328 | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 327 | the patch passed | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | 0 | refguide | 328 | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Other Tests _ | | +1 | asflicense | 17 | The patch does not generate ASF License warnings. | | | | 1913 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/14/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/496 | | Optional Tests | dupname asflicense shellcheck shelldocs refguide | | uname | Linux 6dc91efa4151 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-496/out/precommit/personality/provided.sh | | git revision | master / 67382809d3 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/14/artifact/out/branch-site/book.html | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/14/artifact/out/patch-site/book.html | | Max. process+thread count | 96 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/14/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #510: HBASE-22878 Show table throttle quotas in table jsp
Apache-HBase commented on issue #510: HBASE-22878 Show table throttle quotas in table jsp URL: https://github.com/apache/hbase/pull/510#issuecomment-522778663 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 63 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | 0 | mvndep | 35 | Maven dependency ordering for branch | | +1 | mvninstall | 339 | master passed | | +1 | compile | 78 | master passed | | +1 | checkstyle | 106 | master passed | | +1 | shadedjars | 279 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 53 | master passed | | 0 | spotbugs | 250 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 321 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 291 | the patch passed | | +1 | compile | 80 | the patch passed | | +1 | javac | 80 | the patch passed | | +1 | checkstyle | 107 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 281 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 916 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 51 | the patch passed | | +1 | findbugs | 327 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 96 | hbase-client in the patch passed. | | -1 | unit | 17749 | hbase-server in the patch failed. | | +1 | asflicense | 50 | The patch does not generate ASF License warnings. | | | | 21624 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestRestoreSnapshotFromClientClone | | | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.client.TestFromClientSide3 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/510 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8b473e2aeced 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-510/out/precommit/personality/provided.sh | | git revision | master / 46abaef4be | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/2/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/2/testReport/ | | Max. process+thread count | 5125 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-522776622 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 70 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 64 | Maven dependency ordering for branch | | +1 | mvninstall | 315 | master passed | | +1 | compile | 74 | master passed | | +1 | checkstyle | 102 | master passed | | +1 | shadedjars | 278 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 56 | master passed | | 0 | spotbugs | 264 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 332 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 421 | the patch passed | | +1 | compile | 72 | the patch passed | | +1 | javac | 72 | the patch passed | | +1 | checkstyle | 99 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 362 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1047 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 51 | the patch passed | | +1 | findbugs | 321 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 110 | hbase-client in the patch passed. | | -1 | unit | 16856 | hbase-server in the patch failed. | | +1 | asflicense | 41 | The patch does not generate ASF License warnings. | | | | 21085 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.client.TestFromClientSide3 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/111/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 41404e04ed89 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / 46abaef4be | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/111/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/111/testReport/ | | Max. process+thread count | 5014 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/111/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation
Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation URL: https://github.com/apache/hbase/pull/478#issuecomment-522775266 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 80 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 37 | Maven dependency ordering for branch | | +1 | mvninstall | 383 | master passed | | +1 | compile | 104 | master passed | | +1 | checkstyle | 119 | master passed | | +1 | shadedjars | 331 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 67 | master passed | | 0 | spotbugs | 284 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 360 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 325 | the patch passed | | +1 | compile | 83 | the patch passed | | +1 | javac | 83 | the patch passed | | +1 | checkstyle | 112 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 299 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1018 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 60 | the patch passed | | +1 | findbugs | 357 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 112 | hbase-client in the patch passed. | | -1 | unit | 16429 | hbase-server in the patch failed. | | +1 | asflicense | 64 | The patch does not generate ASF License warnings. | | | | 20790 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/23/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/478 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3c59ffa65b5d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-478/out/precommit/personality/provided.sh | | git revision | master / 46abaef4be | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/23/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/23/testReport/ | | Max. process+thread count | 4964 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/23/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #509: HBASE-22877 WebHDFS based export snapshot will fail if hfile is in archive directory
Apache-HBase commented on issue #509: HBASE-22877 WebHDFS based export snapshot will fail if hfile is in archive directory URL: https://github.com/apache/hbase/pull/509#issuecomment-522774355 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 69 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 355 | master passed | | +1 | compile | 58 | master passed | | +1 | checkstyle | 90 | master passed | | +1 | shadedjars | 301 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 38 | master passed | | 0 | spotbugs | 265 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 263 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 349 | the patch passed | | +1 | compile | 79 | the patch passed | | +1 | javac | 79 | the patch passed | | -1 | checkstyle | 99 | hbase-server: The patch generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 408 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1696 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 100 | the patch passed | | +1 | findbugs | 569 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 15512 | hbase-server in the patch failed. | | +1 | asflicense | 39 | The patch does not generate ASF License warnings. | | | | 20652 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/509 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 5d915ecfcae8 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-509/out/precommit/personality/provided.sh | | git revision | master / 46abaef4be | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/2/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/2/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/2/testReport/ | | Max. process+thread count | 4723 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22863) Avoid Jackson versions and dependencies with known CVEs
[
https://issues.apache.org/jira/browse/HBASE-22863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910781#comment-16910781
]
HBase QA commented on HBASE-22863:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
38s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
33s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
0s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
9s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
35s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 20s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
1s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}189m 38s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 2m
47s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}247m 27s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.snapshot.TestExportSnapshotNoCluster |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/803/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22863 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12977987/HBASE-22863.master.001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit shadedjars
hadoopcheck xml compile |
| uname | Linux eb10e1fb6444 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 46abaef4be |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/803/artifact/patchprocess/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/803/testReport/ |
| Max. process+thread count | 5333 (vs. ulimit of 1) |
| modules | C: hbase-server hbase-mapreduce
hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce
hbase-shaded/hbase-shaded-testing-util
hbase-shaded/hbase-shaded-testing-util-tester . U: . |
| Console
[GitHub] [hbase] Apache-HBase commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)
Apache-HBase commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#issuecomment-522766873 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 99 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | 0 | mvndep | 36 | Maven dependency ordering for branch | | +1 | mvninstall | 352 | master passed | | +1 | compile | 202 | master passed | | +1 | shadedjars | 309 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 276 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 333 | the patch passed | | +1 | compile | 202 | the patch passed | | +1 | javac | 202 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 9 | The patch has no ill-formed XML file. | | +1 | shadedjars | 306 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1062 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 270 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 14947 | root in the patch failed. | | +1 | asflicense | 152 | The patch does not generate ASF License warnings. | | | | 19023 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/10/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/505 | | Optional Tests | dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile | | uname | Linux 6a248cd0b89c 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh | | git revision | master / 46abaef4be | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/10/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/10/testReport/ | | Max. process+thread count | 4668 (vs. ulimit of 1) | | modules | C: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/10/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #476: HBASE-11062 hbtop
Apache-HBase commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-522765321 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 46 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | 0 | shelldocs | 2 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 1 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 22 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 63 | Maven dependency ordering for branch | | +1 | mvninstall | 319 | master passed | | +1 | compile | 173 | master passed | | +1 | checkstyle | 148 | master passed | | +1 | shadedjars | 276 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 179 | master passed | | 0 | spotbugs | 28 | Used deprecated FindBugs config; considering switching to SpotBugs. | | 0 | findbugs | 28 | branch/hbase-assembly no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 292 | the patch passed | | +1 | compile | 173 | the patch passed | | +1 | javac | 173 | the patch passed | | +1 | checkstyle | 147 | the patch passed | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 4 | The patch has no ill-formed XML file. | | +1 | shadedjars | 275 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 923 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 196 | the patch passed | | 0 | findbugs | 28 | hbase-assembly has no data from findbugs | ||| _ Other Tests _ | | +1 | unit | 13109 | root in the patch passed. | | +1 | asflicense | 83 | The patch does not generate ASF License warnings. | | | | 18667 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/26/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/476 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux f507b548472b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-476/out/precommit/personality/provided.sh | | git revision | master / 46abaef4be | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/26/testReport/ | | Max. process+thread count | 5486 (vs. ulimit of 1) | | modules | C: hbase-hbtop . hbase-assembly U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/26/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-22882) TestFlushSnapshotFromClient#testConcurrentSnapshottingAttempts is flakey (was written flakey)
[ https://issues.apache.org/jira/browse/HBASE-22882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack resolved HBASE-22882. --- Hadoop Flags: Reviewed Resolution: Fixed Re-resolved after pushing addendum that removes the test. > TestFlushSnapshotFromClient#testConcurrentSnapshottingAttempts is flakey (was > written flakey) > - > > Key: HBASE-22882 > URL: https://issues.apache.org/jira/browse/HBASE-22882 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: 22882.txt, Screen Shot 2019-08-19 at 12.46.33 PM.png, > Screen Shot 2019-08-19 at 12.46.33 PM.png > > > See HBASE-7536 which adds this test. The author and reviewers note the > indeterminacy of the test. In branch-2.0 it fails 90% of the time on the GCE > runs. Disabling it. In the original issue, its noted that it would take a > bunch of work to make it deterministic. Meantime disabling it. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Reopened] (HBASE-22882) TestFlushSnapshotFromClient#testConcurrentSnapshottingAttempts is flakey (was written flakey)
[ https://issues.apache.org/jira/browse/HBASE-22882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack reopened HBASE-22882: --- Reopening to address [~ndimiduk]'s suggestion > TestFlushSnapshotFromClient#testConcurrentSnapshottingAttempts is flakey (was > written flakey) > - > > Key: HBASE-22882 > URL: https://issues.apache.org/jira/browse/HBASE-22882 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: 22882.txt, Screen Shot 2019-08-19 at 12.46.33 PM.png, > Screen Shot 2019-08-19 at 12.46.33 PM.png > > > See HBASE-7536 which adds this test. The author and reviewers note the > indeterminacy of the test. In branch-2.0 it fails 90% of the time on the GCE > runs. Disabling it. In the original issue, its noted that it would take a > bunch of work to make it deterministic. Meantime disabling it. -- This message was sent by Atlassian Jira (v8.3.2#803003)
