[GitHub] [hbase] Apache-HBase commented on issue #476: HBASE-11062 hbtop

2019-08-23 Thread GitBox
Apache-HBase commented on issue #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#issuecomment-524526336
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 303 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | 0 | shelldocs | 1 | Shelldocs was not available. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 1 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 22 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 33 | Maven dependency ordering for branch |
   | +1 | mvninstall | 349 | master passed |
   | +1 | compile | 211 | master passed |
   | +1 | checkstyle | 187 | master passed |
   | +1 | shadedjars | 313 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 201 | master passed |
   | 0 | spotbugs | 30 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | 0 | findbugs | 30 | branch/hbase-assembly no findbugs output file 
(findbugsXml.xml) |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 14 | Maven dependency ordering for patch |
   | +1 | mvninstall | 338 | the patch passed |
   | +1 | compile | 210 | the patch passed |
   | +1 | javac | 210 | the patch passed |
   | +1 | checkstyle | 180 | the patch passed |
   | +1 | shellcheck | 2 | There were no new shellcheck issues. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | xml | 5 | The patch has no ill-formed XML file. |
   | +1 | shadedjars | 307 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1048 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 219 | the patch passed |
   | 0 | findbugs | 31 | hbase-assembly has no data from findbugs |
   ||| _ Other Tests _ |
   | -1 | unit | 15923 | root in the patch failed. |
   | +1 | asflicense | 102 | The patch does not generate ASF License warnings. |
   | | | 22491 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated |
   |   | hadoop.hbase.client.TestMobSnapshotCloneIndependence |
   |   | hadoop.hbase.master.TestMasterShutdown |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/46/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/476 |
   | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc 
unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle |
   | uname | Linux a0a9bd4a7607 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 
10:55:24 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-476/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/46/artifact/out/patch-unit-root.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/46/testReport/
 |
   | Max. process+thread count | 5181 (vs. ulimit of 1) |
   | modules | C: hbase-hbtop . hbase-assembly U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/46/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 
findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #501: HBASE-22699 refactor isMetaClearingException

2019-08-23 Thread GitBox
Apache-HBase commented on issue #501: HBASE-22699 refactor 
isMetaClearingException
URL: https://github.com/apache/hbase/pull/501#issuecomment-524526330
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 42 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 1 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 36 | Maven dependency ordering for branch |
   | +1 | mvninstall | 336 | master passed |
   | +1 | compile | 84 | master passed |
   | +1 | checkstyle | 111 | master passed |
   | +1 | shadedjars | 296 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 62 | master passed |
   | 0 | spotbugs | 260 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 334 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 16 | Maven dependency ordering for patch |
   | +1 | mvninstall | 354 | the patch passed |
   | +1 | compile | 84 | the patch passed |
   | +1 | javac | 84 | the patch passed |
   | +1 | checkstyle | 103 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 289 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 998 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 59 | the patch passed |
   | +1 | findbugs | 369 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 104 | hbase-client in the patch passed. |
   | -1 | unit | 8420 | hbase-server in the patch failed. |
   | +1 | asflicense | 41 | The patch does not generate ASF License warnings. |
   | | | 12550 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.client.TestMultiRespectsLimits |
   |   | hadoop.hbase.client.TestMetaCache |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/32/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/501 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux fa792c915d28 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-501/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/32/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/32/testReport/
 |
   | Max. process+thread count | 4681 (vs. ulimit of 1) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/32/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22460) Reopen a region if store reader references may have leaked

2019-08-23 Thread Viraj Jasani (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914843#comment-16914843
 ] 

Viraj Jasani commented on HBASE-22460:
--

{quote}Doing #1 violates Master being in charge of assign. Doing in Master is 
also the more frugal choice. #1 requires every RS running a monitoring thread. 
Instead we can run one task in Master for whole cluster to look at refcounts 
and it then does the reopen and no chance of it being surprised by 
self-ordained RS reopen.
{quote}
Sure if HMaster is preferred as initiator, good to go with #2.

 
{quote}The master can still be notified the region has closed, and then 
notified again when it has reopened. There may need to be master side changes 
to accommodate this, true.
{quote}
In this case, probably good to go with #2? Although I think no of RPC calls 
might remain same in both cases(#1: each RS->HM and #2: HM->each RS) but since 
#2 involves AM and State machine procedures (with rollback feature etc), may be 
good to pursue #2?

 
{quote}I suppose a hack an operator can do is watch ref count metrics and if 
judged to be indicative of a leak, could alter the table schema
{quote}
The only catch is it will reopen all regions of the table, not the specific one.

 

> Reopen a region if store reader references may have leaked
> --
>
> Key: HBASE-22460
> URL: https://issues.apache.org/jira/browse/HBASE-22460
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
>
> We can leak store reader references if a coprocessor or core function somehow 
> opens a scanner, or wraps one, and then does not take care to call close on 
> the scanner or the wrapped instance. A reasonable mitigation for a reader 
> reference leak would be a fast reopen of the region on the same server 
> (initiated by the RS) This will release all resources, like the refcount, 
> leases, etc. The clients should gracefully ride over this like any other 
> region transition. This reopen would be like what is done during schema 
> change application and ideally would reuse the relevant code. If the refcount 
> is over some ridiculous threshold this mitigation could be triggered along 
> with a fat WARN in the logs. 



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload

2019-08-23 Thread GitBox
Apache-HBase commented on issue #494: HBASE-22380 break circle replication when 
doing bulkload
URL: https://github.com/apache/hbase/pull/494#issuecomment-524525836
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 71 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ branch-2 Compile Tests _ |
   | 0 | mvndep | 16 | Maven dependency ordering for branch |
   | +1 | mvninstall | 392 | branch-2 passed |
   | +1 | compile | 138 | branch-2 passed |
   | +1 | checkstyle | 146 | branch-2 passed |
   | +1 | shadedjars | 303 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 82 | branch-2 passed |
   | 0 | spotbugs | 221 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 467 | branch-2 passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 17 | Maven dependency ordering for patch |
   | +1 | mvninstall | 335 | the patch passed |
   | +1 | compile | 125 | the patch passed |
   | +1 | cc | 125 | the patch passed |
   | +1 | javac | 125 | the patch passed |
   | -1 | checkstyle | 86 | hbase-server: The patch generated 1 new + 302 
unchanged - 0 fixed = 303 total (was 302) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 276 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1037 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | hbaseprotoc | 117 | the patch passed |
   | +1 | javadoc | 76 | the patch passed |
   | -1 | findbugs | 214 | hbase-server generated 1 new + 0 unchanged - 0 fixed 
= 1 total (was 0) |
   ||| _ Other Tests _ |
   | +1 | unit | 42 | hbase-protocol-shaded in the patch passed. |
   | +1 | unit | 211 | hbase-client in the patch passed. |
   | +1 | unit | 16054 | hbase-server in the patch passed. |
   | +1 | asflicense | 71 | The patch does not generate ASF License warnings. |
   | | | 21029 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | FindBugs | module:hbase-server |
   |  |  
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List,
 CellScanner, String, String, String) makes inefficient use of keySet iterator 
instead of entrySet iterator  At ReplicationSink.java:makes inefficient use of 
keySet iterator instead of entrySet iterator  At ReplicationSink.java:[line 
257] |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/27/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/494 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc |
   | uname | Linux c79dceff6567 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
 |
   | git revision | branch-2 / da87ebb481 |
   | Default Java | 1.8.0_181 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/27/artifact/out/diff-checkstyle-hbase-server.txt
 |
   | findbugs | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/27/artifact/out/new-findbugs-hbase-server.html
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/27/testReport/
 |
   | Max. process+thread count | 4470 (vs. ulimit of 1) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/27/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read

2019-08-23 Thread GitBox
Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer 
allocation in FileIOEngine#read
URL: https://github.com/apache/hbase/pull/479#issuecomment-524525543
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 80 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 36 | Maven dependency ordering for branch |
   | +1 | mvninstall | 347 | master passed |
   | +1 | compile | 76 | master passed |
   | +1 | checkstyle | 102 | master passed |
   | +1 | shadedjars | 287 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 52 | master passed |
   | 0 | spotbugs | 244 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 291 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 17 | Maven dependency ordering for patch |
   | +1 | mvninstall | 307 | the patch passed |
   | +1 | compile | 75 | the patch passed |
   | +1 | javac | 75 | the patch passed |
   | +1 | checkstyle | 25 | hbase-common: The patch generated 0 new + 48 
unchanged - 2 fixed = 48 total (was 50) |
   | +1 | checkstyle | 78 | The patch passed checkstyle in hbase-server |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 279 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 948 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | -1 | javadoc | 21 | hbase-common generated 4 new + 0 unchanged - 0 fixed = 
4 total (was 0) |
   | +1 | findbugs | 297 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 180 | hbase-common in the patch passed. |
   | -1 | unit | 17750 | hbase-server in the patch failed. |
   | +1 | asflicense | 48 | The patch does not generate ASF License warnings. |
   | | | 21732 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.master.procedure.TestSCPWithReplicas |
   |   | hadoop.hbase.replication.TestReplicationSmallTests |
   |   | hadoop.hbase.replication.TestReplicationSmallTestsSync |
   |   | hadoop.hbase.replication.TestReplicationKillSlaveRS |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
   |   | hadoop.hbase.master.TestAssignmentManagerMetrics |
   |   | hadoop.hbase.master.procedure.TestProcedurePriority |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/46/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/479 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux ce5a8a005906 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-479/out/precommit/personality/provided.sh
 |
   | git revision | master / a95ee63a70 |
   | Default Java | 1.8.0_181 |
   | javadoc | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/46/artifact/out/diff-javadoc-javadoc-hbase-common.txt
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/46/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/46/testReport/
 |
   | Max. process+thread count | 4866 (vs. ulimit of 1) |
   | modules | C: hbase-common hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/46/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1

2019-08-23 Thread GitBox
Apache-HBase commented on issue #251: HBASE-22114 Port HBASE-15560 
(TinyLFU-based BlockCache) to branch-1
URL: https://github.com/apache/hbase/pull/251#issuecomment-524525431
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 69 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | -1 | hbaseanti | 0 |  The patch appears use Hadoop classification instead 
of HBase. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 2 new or modified test 
files. |
   ||| _ branch-1 Compile Tests _ |
   | 0 | mvndep | 364 | Maven dependency ordering for branch |
   | +1 | mvninstall | 206 | branch-1 passed |
   | +1 | compile | 103 | branch-1 passed with JDK v1.8.0_222 |
   | +1 | compile | 106 | branch-1 passed with JDK v1.7.0_232 |
   | +1 | checkstyle | 414 | branch-1 passed |
   | 0 | refguide | 188 | branch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. |
   | +1 | shadedjars | 165 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 179 | branch-1 passed with JDK v1.8.0_222 |
   | +1 | javadoc | 300 | branch-1 passed with JDK v1.7.0_232 |
   | 0 | spotbugs | 649 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | 0 | findbugs | 16 | branch/hbase-resource-bundle no findbugs output file 
(findbugsXml.xml) |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 14 | Maven dependency ordering for patch |
   | +1 | mvninstall | 123 | the patch passed |
   | +1 | compile | 119 | the patch passed with JDK v1.8.0_222 |
   | +1 | javac | 119 | the patch passed |
   | +1 | compile | 111 | the patch passed with JDK v1.7.0_232 |
   | +1 | javac | 111 | the patch passed |
   | +1 | checkstyle | 9 | The patch passed checkstyle in hbase-resource-bundle 
|
   | +1 | checkstyle | 26 | The patch passed checkstyle in hbase-common |
   | +1 | checkstyle | 86 | hbase-server: The patch generated 0 new + 83 
unchanged - 11 fixed = 83 total (was 94) |
   | +1 | checkstyle | 26 | The patch passed checkstyle in hbase-it |
   | +1 | checkstyle | 275 | root: The patch generated 0 new + 92 unchanged - 
11 fixed = 92 total (was 103) |
   | -1 | checkstyle | 13 | hbase-tinylfu-blockcache: The patch generated 1 new 
+ 0 unchanged - 0 fixed = 1 total (was 0) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | -1 | xml | 0 | The patch has 5 ill-formed XML file(s). |
   | 0 | refguide | 168 | patch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. |
   | -1 | shadedjars | 13 | patch has 7 errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 313 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2. |
   | -1 | javadoc | 12 | hbase-it in the patch failed with JDK v1.8.0_222. |
   | -1 | javadoc | 105 | root in the patch failed with JDK v1.8.0_222. |
   | -1 | javadoc | 10 | hbase-tinylfu-blockcache in the patch failed with JDK 
v1.7.0_232. |
   | 0 | findbugs | 12 | hbase-resource-bundle has no data from findbugs |
   | -1 | findbugs | 11 | hbase-tinylfu-blockcache in the patch failed. |
   ||| _ Other Tests _ |
   | -1 | unit | 12337 | root in the patch failed. |
   | +1 | asflicense | 119 | The patch does not generate ASF License warnings. |
   | | | 18412 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | XML | Parsing Error(s): |
   |   | hbase-common/src/main/resources/hbase-default.xml |
   |   | hbase-it/pom.xml |
   |   | hbase-resource-bundle/src/main/resources/supplemental-models.xml |
   |   | hbase-tinylfu-blockcache/pom.xml |
   |   | pom.xml |
   | Failed junit tests | hadoop.hbase.client.TestAdmin2 |
   |   | hadoop.hbase.client.TestReplicaWithCluster |
   |   | hadoop.hbase.replication.TestReplicationChangingPeerRegionservers |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-251/11/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/251 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml |
   | uname | Linux c8c877a65833 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-251/out/precommit/personality/provided.sh
 |
   | git revision | branch-1 / d832786 |
   | Default Java | 1.7.0_232 |
   | Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 
/usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232 |
   | refguide | 
http

[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent

2019-08-23 Thread GitBox
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of 
RSGroup idempotent
URL: https://github.com/apache/hbase/pull/387#issuecomment-524525278
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 38 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 365 | master passed |
   | +1 | compile | 27 | master passed |
   | +1 | checkstyle | 13 | master passed |
   | +1 | shadedjars | 295 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 20 | master passed |
   | 0 | spotbugs | 46 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 43 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 297 | the patch passed |
   | +1 | compile | 23 | the patch passed |
   | +1 | javac | 23 | the patch passed |
   | +1 | checkstyle | 11 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 272 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 903 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 18 | the patch passed |
   | +1 | findbugs | 49 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 382 | hbase-rsgroup in the patch passed. |
   | +1 | asflicense | 10 | The patch does not generate ASF License warnings. |
   | | | 3119 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/124/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/387 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 3bf5d7399676 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/124/testReport/
 |
   | Max. process+thread count | 4200 (vs. ulimit of 1) |
   | modules | C: hbase-rsgroup U: hbase-rsgroup |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/124/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility

2019-08-23 Thread GitBox
Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods 
from HBaseTestingUtility
URL: https://github.com/apache/hbase/pull/477#issuecomment-524525258
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 118 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 46 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 442 | master passed |
   | +1 | compile | 62 | master passed |
   | +1 | checkstyle | 84 | master passed |
   | +1 | shadedjars | 316 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 45 | master passed |
   | 0 | spotbugs | 269 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 267 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 340 | the patch passed |
   | +1 | compile | 63 | the patch passed |
   | +1 | javac | 63 | the patch passed |
   | +1 | checkstyle | 86 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 300 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1159 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 41 | the patch passed |
   | +1 | findbugs | 326 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 17227 | hbase-server in the patch failed. |
   | -1 | asflicense | 30 | The patch generated 18 ASF License warnings. |
   | | | 21349 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.client.TestCloneSnapshotFromClientNormal 
|
   |   | hadoop.hbase.master.TestSplitRegionWhileRSCrash |
   |   | hadoop.hbase.wal.TestFSHLogProvider |
   |   | hadoop.hbase.client.TestAsyncTableScanner |
   |   | hadoop.hbase.tool.TestSecureBulkLoadHFiles |
   |   | hadoop.hbase.regionserver.TestRegionServerHostname |
   |   | hadoop.hbase.master.TestMasterMetricsWrapper |
   |   | hadoop.hbase.client.TestAsyncBufferMutator |
   |   | hadoop.hbase.client.TestAsyncTableAdminApi3 |
   |   | hadoop.hbase.regionserver.TestHRegionReplayEvents |
   |   | hadoop.hbase.coprocessor.TestRegionObserverScannerOpenHook |
   |   | hadoop.hbase.client.TestAdmin |
   |   | hadoop.hbase.client.TestSplitOrMergeStatus |
   |   | hadoop.hbase.snapshot.TestSnapshotWhenChoreCleaning |
   |   | hadoop.hbase.client.TestScannersFromClientSide2 |
   |   | hadoop.hbase.client.TestServerBusyException |
   |   | hadoop.hbase.client.TestSmallReversedScanner |
   |   | hadoop.hbase.coprocessor.TestPostIncrementAndAppendBeforeWAL |
   |   | hadoop.hbase.filter.TestFilterListOnMini |
   |   | hadoop.hbase.master.TestMasterHandlerFullWhenTransitRegion |
   |   | hadoop.hbase.client.TestTableOperationException |
   |   | hadoop.hbase.io.asyncfs.TestSaslFanOutOneBlockAsyncDFSOutput |
   |   | hadoop.hbase.master.assignment.TestRegionReplicaSplit |
   |   | hadoop.hbase.coprocessor.TestAppendTimeRange |
   |   | hadoop.hbase.coprocessor.TestPassCustomCellViaRegionObserver |
   |   | 
hadoop.hbase.coprocessor.TestRegionObserverForAddingMutationsFromCoprocessors |
   |   | hadoop.hbase.replication.TestSyncReplicationStandbyKillRS |
   |   | hadoop.hbase.client.TestCloneSnapshotFromClientAfterSplittingRegion |
   |   | hadoop.hbase.client.TestCIPutRpcTimeout |
   |   | hadoop.hbase.client.TestSeparateClientZKCluster |
   |   | hadoop.hbase.client.TestAsyncDecommissionAdminApi |
   |   | hadoop.hbase.client.TestFromClientSideNoCodec |
   |   | hadoop.hbase.replication.TestSerialReplication |
   |   | hadoop.hbase.regionserver.TestRegionOpen |
   |   | hadoop.hbase.security.access.TestCellACLs |
   |   | hadoop.hbase.quotas.TestQuotaObserverChoreWithMiniCluster |
   |   | hadoop.hbase.client.TestAsyncTableScanMetrics |
   |   | hadoop.hbase.client.TestAsyncAdminBuilder |
   |   | hadoop.hbase.client.TestAsyncTableLocatePrefetch |
   |   | hadoop.hbase.client.TestMetaWithReplicas |
   |   | hadoop.hbase.regionserver.TestRegionServerReportForDuty |
   |   | 
hadoop.hbase.security.visibility.TestVisibilityLabelsOpWithDifferentUsersNoACL |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
   |   | hadoop.hbase.client.TestBufferedMutator |
   |   | hadoop.hbase.master.procedure.TestSCPWithoutMeta |
   |   | hadoop.hbase.regionserver.TestJoinedScanners |
   |   | hadoop.hbase.master.procedure.TestModifyTableProcedure |
   |   | hadoop.hbase.filter.TestMultiRowRangeFilter |
   |   | hadoop.hbase.coprocessor.TestCoprocessorStop |
   |   | hadoop.hbase.client.TestAsyncResultScannerCursor |
   |   | ha

[jira] [Commented] (HBASE-21400) correct spelling error of 'initilize' in comment

2019-08-23 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-21400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914840#comment-16914840
 ] 

Hudson commented on HBASE-21400:


Results for branch branch-2
[build #2188 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2188/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2188//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2188//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2188//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> correct spelling error of 'initilize' in comment
> 
>
> Key: HBASE-21400
> URL: https://issues.apache.org/jira/browse/HBASE-21400
> Project: HBase
>  Issue Type: Bug
>Reporter: wuguihu
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
> Attachments: 2018-10-27.png, HBASE-21400.branch-2.1.0001.patch
>
>
> When I learned the code of HBase-RPC,I found a spelling error in the comment.
> Is the word "initilize" should be "initialize"?



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #520: HBASE-22766 Code Coverage Improvement: Create Unit Tests for ResultStatsUtil. Added unit tests for ResultStatsUtil to have 100 percent …

2019-08-23 Thread GitBox
Apache-HBase commented on issue #520: HBASE-22766 Code Coverage Improvement: 
Create Unit Tests for ResultStatsUtil. Added unit tests for ResultStatsUtil to 
have 100 percent …
URL: https://github.com/apache/hbase/pull/520#issuecomment-524524291
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 39 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 346 | master passed |
   | +1 | compile | 25 | master passed |
   | +1 | checkstyle | 29 | master passed |
   | +1 | shadedjars | 281 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 23 | master passed |
   | 0 | spotbugs | 75 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 72 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 311 | the patch passed |
   | +1 | compile | 29 | the patch passed |
   | +1 | javac | 29 | the patch passed |
   | +1 | checkstyle | 31 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 299 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1018 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 22 | the patch passed |
   | +1 | findbugs | 77 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 108 | hbase-client in the patch passed. |
   | +1 | asflicense | 12 | The patch does not generate ASF License warnings. |
   | | | 3103 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/13/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/520 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 9b7a6d79d561 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-520/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/13/testReport/
 |
   | Max. process+thread count | 290 (vs. ulimit of 1) |
   | modules | C: hbase-client U: hbase-client |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/13/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #526: HBASE-22895 Fix the flakey TestSpaceQuotas

2019-08-23 Thread GitBox
Apache-HBase commented on issue #526: HBASE-22895 Fix the flakey TestSpaceQuotas
URL: https://github.com/apache/hbase/pull/526#issuecomment-524523446
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 41 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 9 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 361 | master passed |
   | +1 | compile | 61 | master passed |
   | +1 | checkstyle | 82 | master passed |
   | +1 | shadedjars | 290 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 36 | master passed |
   | 0 | spotbugs | 269 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 266 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 323 | the patch passed |
   | +1 | compile | 59 | the patch passed |
   | +1 | javac | 59 | the patch passed |
   | +1 | checkstyle | 79 | hbase-server: The patch generated 0 new + 0 
unchanged - 3 fixed = 0 total (was 3) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 299 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 988 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 41 | the patch passed |
   | +1 | findbugs | 284 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 8618 | hbase-server in the patch passed. |
   | +1 | asflicense | 22 | The patch does not generate ASF License warnings. |
   | | | 12256 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-526/10/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/526 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 527c1c51a701 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-526/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-526/10/testReport/
 |
   | Max. process+thread count | 4881 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-526/10/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #530: HBASE-22806 Recreating a deleted column family brings back the delete…

2019-08-23 Thread GitBox
Apache-HBase commented on issue #530: HBASE-22806 Recreating a deleted column 
family brings back the delete…
URL: https://github.com/apache/hbase/pull/530#issuecomment-524523121
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 38 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 320 | master passed |
   | +1 | compile | 54 | master passed |
   | +1 | checkstyle | 75 | master passed |
   | +1 | shadedjars | 269 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 34 | master passed |
   | 0 | spotbugs | 245 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 243 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 294 | the patch passed |
   | +1 | compile | 53 | the patch passed |
   | +1 | javac | 53 | the patch passed |
   | +1 | checkstyle | 73 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 289 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1002 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 33 | the patch passed |
   | +1 | findbugs | 268 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 8647 | hbase-server in the patch passed. |
   | +1 | asflicense | 23 | The patch does not generate ASF License warnings. |
   | | | 12110 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/7/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/530 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 957d2ccf09d0 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-530/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/7/testReport/
 |
   | Max. process+thread count | 4296 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/7/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent

2019-08-23 Thread GitBox
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of 
RSGroup idempotent
URL: https://github.com/apache/hbase/pull/387#issuecomment-524522791
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 131 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 324 | master passed |
   | +1 | compile | 23 | master passed |
   | +1 | checkstyle | 12 | master passed |
   | +1 | shadedjars | 272 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 21 | master passed |
   | 0 | spotbugs | 51 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 48 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 312 | the patch passed |
   | +1 | compile | 23 | the patch passed |
   | +1 | javac | 23 | the patch passed |
   | +1 | checkstyle | 12 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 288 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 996 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 19 | the patch passed |
   | +1 | findbugs | 54 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 908 | hbase-rsgroup in the patch failed. |
   | +1 | asflicense | 11 | The patch does not generate ASF License warnings. |
   | | | 3833 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.rsgroup.TestRSGroupMajorCompactionTTL |
   |   | hadoop.hbase.rsgroup.TestRSGroupsAdmin2 |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/123/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/387 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux e392b4b9819e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/123/artifact/out/patch-unit-hbase-rsgroup.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/123/testReport/
 |
   | Max. process+thread count | 4506 (vs. ulimit of 1) |
   | modules | C: hbase-rsgroup U: hbase-rsgroup |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/123/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #520: HBASE-22766 Code Coverage Improvement: Create Unit Tests for ResultStatsUtil. Added unit tests for ResultStatsUtil to have 100 percent …

2019-08-23 Thread GitBox
Apache-HBase commented on issue #520: HBASE-22766 Code Coverage Improvement: 
Create Unit Tests for ResultStatsUtil. Added unit tests for ResultStatsUtil to 
have 100 percent …
URL: https://github.com/apache/hbase/pull/520#issuecomment-524522067
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 144 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 435 | master passed |
   | +1 | compile | 24 | master passed |
   | +1 | checkstyle | 31 | master passed |
   | +1 | shadedjars | 299 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 26 | master passed |
   | 0 | spotbugs | 80 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 78 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 403 | the patch passed |
   | +1 | compile | 26 | the patch passed |
   | +1 | javac | 26 | the patch passed |
   | +1 | checkstyle | 30 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 301 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1142 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 23 | the patch passed |
   | +1 | findbugs | 76 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 110 | hbase-client in the patch passed. |
   | +1 | asflicense | 13 | The patch does not generate ASF License warnings. |
   | | | 3625 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/12/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/520 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 44e21f47be85 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 
13:14:43 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-520/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/12/testReport/
 |
   | Max. process+thread count | 290 (vs. ulimit of 1) |
   | modules | C: hbase-client U: hbase-client |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/12/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (HBASE-22911) fewer concurrent github PR builds

2019-08-23 Thread Sean Busbey (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-22911:

Status: Patch Available  (was: In Progress)

> fewer concurrent github PR builds
> -
>
> Key: HBASE-22911
> URL: https://issues.apache.org/jira/browse/HBASE-22911
> Project: HBase
>  Issue Type: Task
>  Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Attachments: HBASE-22911.0.patch
>
>
> we've been regularly getting 4-5 concurrent builds of PRs.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (HBASE-22911) fewer concurrent github PR builds

2019-08-23 Thread Sean Busbey (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914832#comment-16914832
 ] 

Sean Busbey commented on HBASE-22911:
-

v0
  - limit builds to Hadoop since github PRs are involved.
  - only build one at a time for each PR.

> fewer concurrent github PR builds
> -
>
> Key: HBASE-22911
> URL: https://issues.apache.org/jira/browse/HBASE-22911
> Project: HBase
>  Issue Type: Task
>  Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Attachments: HBASE-22911.0.patch
>
>
> we've been regularly getting 4-5 concurrent builds of PRs.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22911) fewer concurrent github PR builds

2019-08-23 Thread Sean Busbey (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-22911:

Attachment: HBASE-22911.0.patch

> fewer concurrent github PR builds
> -
>
> Key: HBASE-22911
> URL: https://issues.apache.org/jira/browse/HBASE-22911
> Project: HBase
>  Issue Type: Task
>  Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Attachments: HBASE-22911.0.patch
>
>
> we've been regularly getting 4-5 concurrent builds of PRs.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #527: HBASE-22880 Move the DirScanPool out and do not use static field

2019-08-23 Thread GitBox
Apache-HBase commented on issue #527: HBASE-22880 Move the DirScanPool out and 
do not use static field
URL: https://github.com/apache/hbase/pull/527#issuecomment-524521639
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 1469 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 6 new or modified test 
files. |
   ||| _ branch-1 Compile Tests _ |
   | +1 | mvninstall | 545 | branch-1 passed |
   | +1 | compile | 51 | branch-1 passed with JDK v1.8.0_222 |
   | +1 | compile | 58 | branch-1 passed with JDK v1.7.0_232 |
   | +1 | checkstyle | 117 | branch-1 passed |
   | +1 | shadedjars | 228 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 43 | branch-1 passed with JDK v1.8.0_222 |
   | +1 | javadoc | 53 | branch-1 passed with JDK v1.7.0_232 |
   | 0 | spotbugs | 231 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 226 | branch-1 passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 164 | the patch passed |
   | +1 | compile | 51 | the patch passed with JDK v1.8.0_222 |
   | +1 | javac | 51 | the patch passed |
   | +1 | compile | 57 | the patch passed with JDK v1.7.0_232 |
   | +1 | javac | 57 | the patch passed |
   | +1 | checkstyle | 122 | hbase-server: The patch generated 0 new + 255 
unchanged - 5 fixed = 255 total (was 260) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 225 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 384 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2. |
   | +1 | javadoc | 36 | the patch passed with JDK v1.8.0_222 |
   | +1 | javadoc | 49 | the patch passed with JDK v1.7.0_232 |
   | +1 | findbugs | 220 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 9964 | hbase-server in the patch passed. |
   | +1 | asflicense | 27 | The patch does not generate ASF License warnings. |
   | | | 14354 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/9/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/527 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux ee62ef010a51 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-527/out/precommit/personality/provided.sh
 |
   | git revision | branch-1 / d832786 |
   | Default Java | 1.7.0_232 |
   | Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 
/usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/9/testReport/
 |
   | Max. process+thread count | 4323 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/9/console |
   | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #501: HBASE-22699 refactor isMetaClearingException

2019-08-23 Thread GitBox
Apache-HBase commented on issue #501: HBASE-22699 refactor 
isMetaClearingException
URL: https://github.com/apache/hbase/pull/501#issuecomment-524521663
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 87 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 33 | Maven dependency ordering for branch |
   | +1 | mvninstall | 323 | master passed |
   | +1 | compile | 77 | master passed |
   | +1 | checkstyle | 105 | master passed |
   | +1 | shadedjars | 275 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 53 | master passed |
   | 0 | spotbugs | 241 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 302 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 15 | Maven dependency ordering for patch |
   | +1 | mvninstall | 314 | the patch passed |
   | +1 | compile | 76 | the patch passed |
   | +1 | javac | 76 | the patch passed |
   | +1 | checkstyle | 104 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 275 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 931 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 53 | the patch passed |
   | +1 | findbugs | 314 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 107 | hbase-client in the patch passed. |
   | -1 | unit | 8357 | hbase-server in the patch failed. |
   | +1 | asflicense | 69 | The patch does not generate ASF License warnings. |
   | | | 12276 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.client.TestMetaCache |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/31/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/501 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux c29b589075fd 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-501/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/31/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/31/testReport/
 |
   | Max. process+thread count | 4997 (vs. ulimit of 1) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/31/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22867) The ForkJoinPool in CleanerChore will spawn thousands of threads in our cluster with thousands table

2019-08-23 Thread Reid Chan (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914826#comment-16914826
 ] 

Reid Chan commented on HBASE-22867:
---

Filed HBASE-22912.

> The ForkJoinPool in CleanerChore will spawn thousands of threads in our 
> cluster with thousands table
> 
>
> Key: HBASE-22867
> URL: https://issues.apache.org/jira/browse/HBASE-22867
> Project: HBase
>  Issue Type: Bug
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Critical
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: 191318.stack, 191318.stack.1, 31162.stack.1
>
>
> The thousands of spawned  threads make the safepoint cost 80+s in our Master 
> JVM processs.
> {code}
> 2019-08-15,19:35:35,861 INFO [main-SendThread(zjy-hadoop-prc-zk02.bj:11000)] 
> org.apache.zookeeper.ClientCnxn: Client session timed out, have not heard 
> from server in 82260ms for sessionid 0x1691332e2d3aae5, closing socket 
> connection and at
> tempting reconnect
> {code}
> The stdout from JVM (can see from here there're 9126 threads & sync cost 80+s)
> {code}
> vmop[threads: total initially_running wait_to_block]
> [time: spin block sync cleanup vmop] page_trap_count
> 32358.859: ForceAsyncSafepoint  [9126 67
> 474]  [ 128 8659687   101]  0
> {code}
> Also we got the jstack: 
> {code}
> $ cat 31162.stack.1  | grep 'ForkJoinPool-1-worker' | wc -l
> 8648
> {code}
> It's a dangerous bug, make it as blocker.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Created] (HBASE-22912) [Backport] HBASE-22867 to branch-1

2019-08-23 Thread Reid Chan (Jira)
Reid Chan created HBASE-22912:
-

 Summary: [Backport] HBASE-22867 to branch-1
 Key: HBASE-22912
 URL: https://issues.apache.org/jira/browse/HBASE-22912
 Project: HBase
  Issue Type: Improvement
Reporter: Reid Chan






--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (HBASE-22852) hbase nightlies leaking gpg-agents

2019-08-23 Thread HBase QA (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914825#comment-16914825
 ] 

HBase QA commented on HBASE-22852:
--

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
42s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  
0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
 0s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
17s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}  2m  7s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/11/artifact/out/Dockerfile
 |
| GITHUB PR | https://github.com/apache/hbase/pull/525 |
| JIRA Issue | HBASE-22852 |
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux cf3090273a0d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-525/out/precommit/personality/provided.sh
 |
| git revision | master / ee9d98611b |
| Max. process+thread count | 46 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/11/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |


This message was automatically generated.



> hbase nightlies leaking gpg-agents
> --
>
> Key: HBASE-22852
> URL: https://issues.apache.org/jira/browse/HBASE-22852
> Project: HBase
>  Issue Type: Bug
>  Components: build
>Reporter: Allen Wittenauer
>Priority: Major
>
> FYI, just triggered yetus master, which includes code to find and kill 
> long-running processes still attached to the Jenkins workspace directory.  It 
> came up with this:
> https://builds.apache.org/view/S-Z/view/Yetus/job/yetus-github-multibranch/job/master/134/console
> {code}
> USER   PID %CPU %MEMVSZ   RSS TTY  STAT START   TIME COMMAND
>  jenkins752  0.0  0.0  93612   584 ?Ss   Aug12   0:00 gpg-agent 
> --homedir 
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_HBASE-20952/downloads-hadoop-2/.gpg
>  --use-standard-socket --daemon
>  Killing 752 ***
> {code}
> (repeat 10s of times, which slightly different dates, pids, versions, etc)
> Also, be aware that any other process running on the node (such as the other 
> executor) has extremely easy access to whatever gpg creds you are using...



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #525: [HBASE-22852] Stop gpg agent daemons in hbase nightlies.

2019-08-23 Thread GitBox
Apache-HBase commented on issue #525: [HBASE-22852] Stop gpg agent daemons in 
hbase nightlies.
URL: https://github.com/apache/hbase/pull/525#issuecomment-524521431
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 42 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | 0 | shelldocs | 0 | Shelldocs was not available. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   ||| _ master Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   | +1 | shellcheck | 0 | There were no new shellcheck issues. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   ||| _ Other Tests _ |
   | +1 | asflicense | 17 | The patch does not generate ASF License warnings. |
   | | | 127 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/11/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/525 |
   | JIRA Issue | HBASE-22852 |
   | Optional Tests | dupname asflicense shellcheck shelldocs |
   | uname | Linux cf3090273a0d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-525/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Max. process+thread count | 46 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/11/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22880) [Backport] HBASE-22871 to branch-1

2019-08-23 Thread Reid Chan (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914824#comment-16914824
 ] 

Reid Chan commented on HBASE-22880:
---

Pushed to branch-1.4 and branch-1.

> [Backport] HBASE-22871 to branch-1
> --
>
> Key: HBASE-22880
> URL: https://issues.apache.org/jira/browse/HBASE-22880
> Project: HBase
>  Issue Type: Improvement
>Reporter: Reid Chan
>Priority: Major
> Fix For: 1.5.0, 1.4.11
>
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Resolved] (HBASE-22880) [Backport] HBASE-22871 to branch-1

2019-08-23 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-22880.
---
Resolution: Fixed

> [Backport] HBASE-22871 to branch-1
> --
>
> Key: HBASE-22880
> URL: https://issues.apache.org/jira/browse/HBASE-22880
> Project: HBase
>  Issue Type: Improvement
>Reporter: Reid Chan
>Priority: Major
> Fix For: 1.5.0, 1.4.11
>
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Reidddddd merged pull request #527: HBASE-22880 Move the DirScanPool out and do not use static field

2019-08-23 Thread GitBox
Reidd merged pull request #527: HBASE-22880 Move the DirScanPool out and do 
not use static field
URL: https://github.com/apache/hbase/pull/527
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Work started] (HBASE-22911) fewer concurrent github PR builds

2019-08-23 Thread Sean Busbey (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HBASE-22911 started by Sean Busbey.
---
> fewer concurrent github PR builds
> -
>
> Key: HBASE-22911
> URL: https://issues.apache.org/jira/browse/HBASE-22911
> Project: HBase
>  Issue Type: Task
>  Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
>
> we've been regularly getting 4-5 concurrent builds of PRs.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Created] (HBASE-22911) fewer concurrent github PR builds

2019-08-23 Thread Sean Busbey (Jira)
Sean Busbey created HBASE-22911:
---

 Summary: fewer concurrent github PR builds
 Key: HBASE-22911
 URL: https://issues.apache.org/jira/browse/HBASE-22911
 Project: HBase
  Issue Type: Task
  Components: build
Reporter: Sean Busbey
Assignee: Sean Busbey


we've been regularly getting 4-5 concurrent builds of PRs.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #509: HBASE-22877 WebHDFS based export snapshot will fail if hfile is in archive directory

2019-08-23 Thread GitBox
Apache-HBase commented on issue #509: HBASE-22877 WebHDFS based export snapshot 
will fail if hfile is in archive directory
URL: https://github.com/apache/hbase/pull/509#issuecomment-524521062
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 42 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 327 | master passed |
   | +1 | compile | 54 | master passed |
   | +1 | checkstyle | 76 | master passed |
   | +1 | shadedjars | 280 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 34 | master passed |
   | 0 | spotbugs | 243 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 242 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 298 | the patch passed |
   | +1 | compile | 54 | the patch passed |
   | +1 | javac | 54 | the patch passed |
   | +1 | checkstyle | 77 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 277 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 946 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 33 | the patch passed |
   | +1 | findbugs | 259 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 8436 | hbase-server in the patch passed. |
   | +1 | asflicense | 32 | The patch does not generate ASF License warnings. |
   | | | 11842 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/21/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/509 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 5e16e514e967 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-509/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/21/testReport/
 |
   | Max. process+thread count | 4615 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/21/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (HBASE-22894) Move testOpenRegionFailedMemoryLeak to dedicated class

2019-08-23 Thread Duo Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-22894:
--
Attachment: HBASE-22894-v2.patch

> Move testOpenRegionFailedMemoryLeak to dedicated class
> --
>
> Key: HBASE-22894
> URL: https://issues.apache.org/jira/browse/HBASE-22894
> Project: HBase
>  Issue Type: Test
>Affects Versions: 3.0.0, 2.2.1, 2.1.6
>Reporter: Bing Xiao
>Assignee: Bing Xiao
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22894-branch-2-v1.patch, 
> HBASE-22894-branch-2.1-v1.patch, HBASE-22894-branch-2.2-v1.patch, 
> HBASE-22894-master-v1.patch, HBASE-22894-v2.patch
>
>
> testOpenRegionFailedMemoryLeak in TestHRegion will cause UT run timeout, so 
> move testOpenRegionFailedMemoryLeak to dedicated class



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #526: HBASE-22895 Fix the flakey TestSpaceQuotas

2019-08-23 Thread GitBox
Apache-HBase commented on issue #526: HBASE-22895 Fix the flakey TestSpaceQuotas
URL: https://github.com/apache/hbase/pull/526#issuecomment-524520329
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 78 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 9 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 367 | master passed |
   | +1 | compile | 62 | master passed |
   | +1 | checkstyle | 96 | master passed |
   | +1 | shadedjars | 309 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 39 | master passed |
   | 0 | spotbugs | 297 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 296 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 445 | the patch passed |
   | +1 | compile | 75 | the patch passed |
   | +1 | javac | 75 | the patch passed |
   | +1 | checkstyle | 100 | hbase-server: The patch generated 0 new + 0 
unchanged - 3 fixed = 0 total (was 3) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 368 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1395 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 47 | the patch passed |
   | +1 | findbugs | 365 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 15950 | hbase-server in the patch failed. |
   | +1 | asflicense | 26 | The patch does not generate ASF License warnings. |
   | | | 20545 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=18.09.7 Server=18.09.7 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-526/6/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/526 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 46d8ee75d0f0 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 
22:49:08 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-526/out/precommit/personality/provided.sh
 |
   | git revision | master / 504fc52187 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-526/6/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-526/6/testReport/
 |
   | Max. process+thread count | 4850 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-526/6/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent

2019-08-23 Thread GitBox
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of 
RSGroup idempotent
URL: https://github.com/apache/hbase/pull/387#issuecomment-52452
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 49 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 433 | master passed |
   | +1 | compile | 32 | master passed |
   | +1 | checkstyle | 16 | master passed |
   | +1 | shadedjars | 369 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 27 | master passed |
   | 0 | spotbugs | 66 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 63 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 367 | the patch passed |
   | +1 | compile | 32 | the patch passed |
   | +1 | javac | 32 | the patch passed |
   | +1 | checkstyle | 14 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 323 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1098 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 23 | the patch passed |
   | +1 | findbugs | 61 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 367 | hbase-rsgroup in the patch passed. |
   | +1 | asflicense | 12 | The patch does not generate ASF License warnings. |
   | | | 3694 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/122/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/387 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 26caed331c67 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/122/testReport/
 |
   | Max. process+thread count | 4346 (vs. ulimit of 1) |
   | modules | C: hbase-rsgroup U: hbase-rsgroup |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/122/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22852) hbase nightlies leaking gpg-agents

2019-08-23 Thread HBase QA (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914810#comment-16914810
 ] 

HBase QA commented on HBASE-22852:
--

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m 
57s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  
1s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
 2s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
25s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}  3m 34s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/10/artifact/out/Dockerfile
 |
| GITHUB PR | https://github.com/apache/hbase/pull/525 |
| JIRA Issue | HBASE-22852 |
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux 12f8abd8cc0b 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-525/out/precommit/personality/provided.sh
 |
| git revision | master / ee9d98611b |
| Max. process+thread count | 51 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/10/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |


This message was automatically generated.



> hbase nightlies leaking gpg-agents
> --
>
> Key: HBASE-22852
> URL: https://issues.apache.org/jira/browse/HBASE-22852
> Project: HBase
>  Issue Type: Bug
>  Components: build
>Reporter: Allen Wittenauer
>Priority: Major
>
> FYI, just triggered yetus master, which includes code to find and kill 
> long-running processes still attached to the Jenkins workspace directory.  It 
> came up with this:
> https://builds.apache.org/view/S-Z/view/Yetus/job/yetus-github-multibranch/job/master/134/console
> {code}
> USER   PID %CPU %MEMVSZ   RSS TTY  STAT START   TIME COMMAND
>  jenkins752  0.0  0.0  93612   584 ?Ss   Aug12   0:00 gpg-agent 
> --homedir 
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_HBASE-20952/downloads-hadoop-2/.gpg
>  --use-standard-socket --daemon
>  Killing 752 ***
> {code}
> (repeat 10s of times, which slightly different dates, pids, versions, etc)
> Also, be aware that any other process running on the node (such as the other 
> executor) has extremely easy access to whatever gpg creds you are using...



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #525: [HBASE-22852] Stop gpg agent daemons in hbase nightlies.

2019-08-23 Thread GitBox
Apache-HBase commented on issue #525: [HBASE-22852] Stop gpg agent daemons in 
hbase nightlies.
URL: https://github.com/apache/hbase/pull/525#issuecomment-524519130
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 117 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | 0 | shelldocs | 1 | Shelldocs was not available. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   ||| _ master Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   | +1 | shellcheck | 2 | There were no new shellcheck issues. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   ||| _ Other Tests _ |
   | +1 | asflicense | 25 | The patch does not generate ASF License warnings. |
   | | | 214 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/10/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/525 |
   | JIRA Issue | HBASE-22852 |
   | Optional Tests | dupname asflicense shellcheck shelldocs |
   | uname | Linux 12f8abd8cc0b 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-525/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Max. process+thread count | 51 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/10/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…

2019-08-23 Thread GitBox
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts 
of TokenUtil off into a Clien…
URL: https://github.com/apache/hbase/pull/361#issuecomment-524519115
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 40 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 1 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 2 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 36 | Maven dependency ordering for branch |
   | +1 | mvninstall | 341 | master passed |
   | +1 | compile | 95 | master passed |
   | +1 | checkstyle | 113 | master passed |
   | +1 | shadedjars | 319 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 75 | master passed |
   | 0 | spotbugs | 261 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 335 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 16 | Maven dependency ordering for patch |
   | +1 | mvninstall | 307 | the patch passed |
   | +1 | compile | 84 | the patch passed |
   | +1 | javac | 84 | the patch passed |
   | +1 | checkstyle | 102 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 275 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 989 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 73 | the patch passed |
   | +1 | findbugs | 433 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 120 | hbase-client in the patch passed. |
   | +1 | unit | 9717 | hbase-server in the patch passed. |
   | +1 | asflicense | 48 | The patch does not generate ASF License warnings. |
   | | | 14001 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/129/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/361 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 93dbe5ddcb07 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/129/testReport/
 |
   | Max. process+thread count | 4674 (vs. ulimit of 1) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/129/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #520: HBASE-22766 Code Coverage Improvement: Create Unit Tests for ResultStatsUtil. Added unit tests for ResultStatsUtil to have 100 percent …

2019-08-23 Thread GitBox
Apache-HBase commented on issue #520: HBASE-22766 Code Coverage Improvement: 
Create Unit Tests for ResultStatsUtil. Added unit tests for ResultStatsUtil to 
have 100 percent …
URL: https://github.com/apache/hbase/pull/520#issuecomment-524518900
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 57 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 369 | master passed |
   | +1 | compile | 27 | master passed |
   | +1 | checkstyle | 34 | master passed |
   | +1 | shadedjars | 296 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 27 | master passed |
   | 0 | spotbugs | 79 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 76 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 416 | the patch passed |
   | +1 | compile | 26 | the patch passed |
   | +1 | javac | 26 | the patch passed |
   | +1 | checkstyle | 31 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 282 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1045 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 22 | the patch passed |
   | +1 | findbugs | 80 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 105 | hbase-client in the patch passed. |
   | +1 | asflicense | 13 | The patch does not generate ASF License warnings. |
   | | | 3288 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/11/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/520 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux f4cee581a39f 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-520/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/11/testReport/
 |
   | Max. process+thread count | 293 (vs. ulimit of 1) |
   | modules | C: hbase-client U: hbase-client |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/11/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #476: HBASE-11062 hbtop

2019-08-23 Thread GitBox
Apache-HBase commented on issue #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#issuecomment-524518876
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 86 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | 0 | shelldocs | 2 | Shelldocs was not available. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 1 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 22 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 65 | Maven dependency ordering for branch |
   | +1 | mvninstall | 375 | master passed |
   | +1 | compile | 186 | master passed |
   | +1 | checkstyle | 157 | master passed |
   | +1 | shadedjars | 288 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 186 | master passed |
   | 0 | spotbugs | 31 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | 0 | findbugs | 31 | branch/hbase-assembly no findbugs output file 
(findbugsXml.xml) |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 15 | Maven dependency ordering for patch |
   | +1 | mvninstall | 376 | the patch passed |
   | +1 | compile | 197 | the patch passed |
   | +1 | javac | 197 | the patch passed |
   | +1 | checkstyle | 160 | the patch passed |
   | +1 | shellcheck | 1 | There were no new shellcheck issues. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | xml | 9 | The patch has no ill-formed XML file. |
   | +1 | shadedjars | 324 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1081 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 202 | the patch passed |
   | 0 | findbugs | 36 | hbase-assembly has no data from findbugs |
   ||| _ Other Tests _ |
   | -1 | unit | 18399 | root in the patch failed. |
   | +1 | asflicense | 83 | The patch does not generate ASF License warnings. |
   | | | 24804 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
   |   | hadoop.hbase.master.TestAssignmentManagerMetrics |
   |   | hadoop.hbase.master.procedure.TestSCPWithReplicas |
   |   | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/45/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/476 |
   | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc 
unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle |
   | uname | Linux a3a1f5bf6ffa 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 
13:14:43 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-476/out/precommit/personality/provided.sh
 |
   | git revision | master / 43f53c1a23 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/45/artifact/out/patch-unit-root.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/45/testReport/
 |
   | Max. process+thread count | 5218 (vs. ulimit of 1) |
   | modules | C: hbase-hbtop . hbase-assembly U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/45/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 
findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent

2019-08-23 Thread GitBox
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of 
RSGroup idempotent
URL: https://github.com/apache/hbase/pull/387#issuecomment-524518641
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 80 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 369 | master passed |
   | +1 | compile | 25 | master passed |
   | +1 | checkstyle | 13 | master passed |
   | +1 | shadedjars | 286 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 20 | master passed |
   | 0 | spotbugs | 51 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 50 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 304 | the patch passed |
   | +1 | compile | 23 | the patch passed |
   | +1 | javac | 23 | the patch passed |
   | +1 | checkstyle | 12 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 278 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 967 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 23 | the patch passed |
   | +1 | findbugs | 59 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 659 | hbase-rsgroup in the patch passed. |
   | +1 | asflicense | 10 | The patch does not generate ASF License warnings. |
   | | | 3587 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/121/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/387 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux a460aa812738 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/121/testReport/
 |
   | Max. process+thread count | 4453 (vs. ulimit of 1) |
   | modules | C: hbase-rsgroup U: hbase-rsgroup |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/121/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…

2019-08-23 Thread GitBox
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if 
their RSGroup has no highest ve…
URL: https://github.com/apache/hbase/pull/435#issuecomment-524518213
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 39 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | 0 | shelldocs | 0 | Shelldocs was not available. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 33 | Maven dependency ordering for branch |
   | +1 | mvninstall | 338 | master passed |
   | +1 | compile | 95 | master passed |
   | +1 | checkstyle | 106 | master passed |
   | +1 | shadedjars | 260 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 69 | master passed |
   | 0 | spotbugs | 234 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 321 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 15 | Maven dependency ordering for patch |
   | +1 | mvninstall | 286 | the patch passed |
   | +1 | compile | 94 | the patch passed |
   | +1 | javac | 94 | the patch passed |
   | -1 | checkstyle | 72 | hbase-server: The patch generated 1 new + 9 
unchanged - 0 fixed = 10 total (was 9) |
   | +1 | shellcheck | 0 | There were no new shellcheck issues. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 268 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 924 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 68 | the patch passed |
   | -1 | findbugs | 55 | hbase-common generated 1 new + 0 unchanged - 0 fixed 
= 1 total (was 0) |
   ||| _ Other Tests _ |
   | +1 | unit | 180 | hbase-common in the patch passed. |
   | +1 | unit | 8823 | hbase-server in the patch passed. |
   | +1 | unit | 279 | hbase-rsgroup in the patch passed. |
   | +1 | asflicense | 60 | The patch does not generate ASF License warnings. |
   | | | 13116 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | FindBugs | module:hbase-common |
   |  |  org.apache.hadoop.hbase.Version.() 
invokes inefficient new String(String) constructor  At Version.java:inefficient 
new String(String) constructor  At Version.java:[line 10] |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/75/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/435 |
   | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc 
unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 3685380a089e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Default Java | 1.8.0_181 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/75/artifact/out/diff-checkstyle-hbase-server.txt
 |
   | findbugs | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/75/artifact/out/new-findbugs-hbase-common.html
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/75/testReport/
 |
   | Max. process+thread count | 4746 (vs. ulimit of 1) |
   | modules | C: hbase-common hbase-server hbase-rsgroup U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/75/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 
findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22867) The ForkJoinPool in CleanerChore will spawn thousands of threads in our cluster with thousands table

2019-08-23 Thread Reid Chan (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914803#comment-16914803
 ] 

Reid Chan commented on HBASE-22867:
---

{quote}Should this fix be backported too? (There are some Java 8 idioms in the 
patch, a simple cherry pick won't work.)
{quote}
Yes, will try.

> The ForkJoinPool in CleanerChore will spawn thousands of threads in our 
> cluster with thousands table
> 
>
> Key: HBASE-22867
> URL: https://issues.apache.org/jira/browse/HBASE-22867
> Project: HBase
>  Issue Type: Bug
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Critical
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: 191318.stack, 191318.stack.1, 31162.stack.1
>
>
> The thousands of spawned  threads make the safepoint cost 80+s in our Master 
> JVM processs.
> {code}
> 2019-08-15,19:35:35,861 INFO [main-SendThread(zjy-hadoop-prc-zk02.bj:11000)] 
> org.apache.zookeeper.ClientCnxn: Client session timed out, have not heard 
> from server in 82260ms for sessionid 0x1691332e2d3aae5, closing socket 
> connection and at
> tempting reconnect
> {code}
> The stdout from JVM (can see from here there're 9126 threads & sync cost 80+s)
> {code}
> vmop[threads: total initially_running wait_to_block]
> [time: spin block sync cleanup vmop] page_trap_count
> 32358.859: ForceAsyncSafepoint  [9126 67
> 474]  [ 128 8659687   101]  0
> {code}
> Also we got the jstack: 
> {code}
> $ cat 31162.stack.1  | grep 'ForkJoinPool-1-worker' | wc -l
> 8648
> {code}
> It's a dangerous bug, make it as blocker.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility

2019-08-23 Thread GitBox
Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods 
from HBaseTestingUtility
URL: https://github.com/apache/hbase/pull/477#issuecomment-524516987
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 76 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 46 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 484 | master passed |
   | +1 | compile | 78 | master passed |
   | +1 | checkstyle | 119 | master passed |
   | +1 | shadedjars | 371 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 48 | master passed |
   | 0 | spotbugs | 312 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 309 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 421 | the patch passed |
   | +1 | compile | 73 | the patch passed |
   | +1 | javac | 73 | the patch passed |
   | +1 | checkstyle | 107 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 369 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1398 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 47 | the patch passed |
   | +1 | findbugs | 327 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 18738 | hbase-server in the patch failed. |
   | -1 | asflicense | 43 | The patch generated 35 ASF License warnings. |
   | | | 23553 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.master.assignment.TestRegionReplicaSplit 
|
   |   | hadoop.hbase.regionserver.wal.TestLogRollPeriod |
   |   | hadoop.hbase.util.TestHBaseFsckEncryption |
   |   | hadoop.hbase.client.TestCIGetRpcTimeout |
   |   | hadoop.hbase.master.procedure.TestSCPWithMetaWithReplicas |
   |   | hadoop.hbase.client.TestScanWithoutFetchingData |
   |   | hadoop.hbase.client.TestTableOperationException |
   |   | hadoop.hbase.coprocessor.TestRegionObserverBypass |
   |   | 
hadoop.hbase.security.visibility.TestVisibilityLabelsOnNewVersionBehaviorTable |
   |   | hadoop.hbase.wal.TestWALSplitBoundedLogWriterCreation |
   |   | hadoop.hbase.replication.TestReplicationSyncUpToolWithBulkLoadedData |
   |   | 
hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint |
   |   | hadoop.hbase.regionserver.TestFSErrorsExposed |
   |   | hadoop.hbase.snapshot.TestConcurrentFlushSnapshotFromClient |
   |   | hadoop.hbase.client.TestAsyncTableNoncedRetry |
   |   | hadoop.hbase.tool.TestSecureBulkLoadHFiles |
   |   | hadoop.hbase.regionserver.wal.TestWALReplayCompressed |
   |   | hadoop.hbase.master.procedure.TestSplitWALProcedure |
   |   | hadoop.hbase.client.TestScannersFromClientSide |
   |   | hadoop.hbase.master.procedure.TestMasterProcedureEvents |
   |   | hadoop.hbase.master.TestMasterRepairMode |
   |   | hadoop.hbase.client.TestAsyncTableScanMetrics |
   |   | hadoop.hbase.coprocessor.TestWALObserver |
   |   | hadoop.hbase.client.TestFromClientSideScanExcpetion |
   |   | hadoop.hbase.master.assignment.TestRegionBypass |
   |   | hadoop.hbase.master.procedure.TestDeleteTableProcedure |
   |   | hadoop.hbase.master.TestWarmupRegion |
   |   | hadoop.hbase.regionserver.TestRowTooBig |
   |   | hadoop.hbase.TestLocalHBaseCluster |
   |   | hadoop.hbase.client.TestCIGetOperationTimeout |
   |   | hadoop.hbase.master.procedure.TestSCPWithoutMeta |
   |   | 
hadoop.hbase.master.procedure.TestSCPWithMetaWithReplicasWithoutZKCoordinated |
   |   | hadoop.hbase.replication.TestReplicationStatusAfterLagging |
   |   | 
hadoop.hbase.client.TestMobCloneSnapshotFromClientCloneLinksAfterDelete |
   |   | hadoop.hbase.master.cleaner.TestLogsCleaner |
   |   | 
hadoop.hbase.replication.TestSyncReplicationMoreLogsInLocalCopyToRemote |
   |   | 
hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService |
   |   | hadoop.hbase.replication.TestSyncReplicationActive |
   |   | hadoop.hbase.client.TestAsyncTableLocatePrefetch |
   |   | hadoop.hbase.client.TestAdmin2 |
   |   | hadoop.hbase.regionserver.TestRegionFavoredNodes |
   |   | hadoop.hbase.master.assignment.TestSCPGetRegionsRace |
   |   | hadoop.hbase.TestClusterBootOrder |
   |   | hadoop.hbase.master.TestCatalogJanitorCluster |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
   |   | hadoop.hbase.master.TestGetReplicationLoad |
   |   | 
hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService 
|
   |   | hadoop.hbase.client.TestAdmin |
   |   | hadoop.hbase.client.TestAsyncMe

[jira] [Commented] (HBASE-21996) Set locale for javadoc

2019-08-23 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-21996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914800#comment-16914800
 ] 

Hudson commented on HBASE-21996:


SUCCESS: Integrated in Jenkins build HBase-1.3-IT #628 (See 
[https://builds.apache.org/job/HBase-1.3-IT/628/])
HBASE-21996 Set locale for javadoc (jan.hentschel: rev 
249383e1add4400faad967c6eee23b87df9f6431)
* (edit) pom.xml


> Set locale for javadoc
> --
>
> Key: HBASE-21996
> URL: https://issues.apache.org/jira/browse/HBASE-21996
> Project: HBase
>  Issue Type: Improvement
>  Components: documentation
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2
>
> Attachments: HBASE-21996.master.001.patch
>
>
> Headers in generated javadoc could have different language based on the 
> user's locale.
> For example the published 2.1 javadoc's headers are in Chinese while 2.0 is 
> in English.
> 2.0: 
> [https://hbase.apache.org/2.0/apidocs/org/apache/hadoop/hbase/client/HTable.html]
> 2.1: 
> [https://hbase.apache.org/2.1/apidocs/org/apache/hadoop/hbase/client/HTable.html]



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #501: HBASE-22699 refactor isMetaClearingException

2019-08-23 Thread GitBox
Apache-HBase commented on issue #501: HBASE-22699 refactor 
isMetaClearingException
URL: https://github.com/apache/hbase/pull/501#issuecomment-524516638
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 38 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 1 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 33 | Maven dependency ordering for branch |
   | +1 | mvninstall | 309 | master passed |
   | +1 | compile | 74 | master passed |
   | +1 | checkstyle | 102 | master passed |
   | +1 | shadedjars | 292 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 67 | master passed |
   | 0 | spotbugs | 255 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 329 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 15 | Maven dependency ordering for patch |
   | +1 | mvninstall | 313 | the patch passed |
   | +1 | compile | 83 | the patch passed |
   | +1 | javac | 83 | the patch passed |
   | +1 | checkstyle | 104 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 282 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1044 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 56 | the patch passed |
   | +1 | findbugs | 351 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 104 | hbase-client in the patch passed. |
   | -1 | unit | 8585 | hbase-server in the patch failed. |
   | +1 | asflicense | 42 | The patch does not generate ASF License warnings. |
   | | | 12628 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.client.TestMetaCache |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/30/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/501 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 83ed6cab5151 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-501/out/precommit/personality/provided.sh
 |
   | git revision | master / a95ee63a70 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/30/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/30/testReport/
 |
   | Max. process+thread count | 4898 (vs. ulimit of 1) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/30/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #520: HBASE-22766 Code Coverage Improvement: Create Unit Tests for ResultStatsUtil. Added unit tests for ResultStatsUtil to have 100 percent …

2019-08-23 Thread GitBox
Apache-HBase commented on issue #520: HBASE-22766 Code Coverage Improvement: 
Create Unit Tests for ResultStatsUtil. Added unit tests for ResultStatsUtil to 
have 100 percent …
URL: https://github.com/apache/hbase/pull/520#issuecomment-524516196
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 38 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 333 | master passed |
   | +1 | compile | 23 | master passed |
   | +1 | checkstyle | 31 | master passed |
   | +1 | shadedjars | 294 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 23 | master passed |
   | 0 | spotbugs | 75 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 72 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 308 | the patch passed |
   | +1 | compile | 23 | the patch passed |
   | +1 | javac | 23 | the patch passed |
   | +1 | checkstyle | 30 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 284 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 972 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 19 | the patch passed |
   | +1 | findbugs | 76 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 113 | hbase-client in the patch passed. |
   | +1 | asflicense | 13 | The patch does not generate ASF License warnings. |
   | | | 3028 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/10/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/520 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 78019242dc04 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 
09:17:01 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-520/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/10/testReport/
 |
   | Max. process+thread count | 291 (vs. ulimit of 1) |
   | modules | C: hbase-client U: hbase-client |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/10/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #524: HBASE-22846 Internal Error 500 when Using HBASE REST API to Create Na…

2019-08-23 Thread GitBox
Apache-HBase commented on issue #524: HBASE-22846 Internal Error 500 when Using 
HBASE REST API to Create Na…
URL: https://github.com/apache/hbase/pull/524#issuecomment-524516224
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 139 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ branch-2.1 Compile Tests _ |
   | +1 | mvninstall | 529 | branch-2.1 passed |
   | +1 | compile | 70 | branch-2.1 passed |
   | +1 | checkstyle | 55 | branch-2.1 passed |
   | +1 | shadedjars | 330 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 25 | branch-2.1 passed |
   | 0 | spotbugs | 64 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 60 | branch-2.1 passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 316 | the patch passed |
   | +1 | compile | 30 | the patch passed |
   | +1 | javac | 31 | the patch passed |
   | -1 | checkstyle | 17 | hbase-rest: The patch generated 1 new + 9 unchanged 
- 0 fixed = 10 total (was 9) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 270 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1360 | Patch does not cause any errors with Hadoop 
2.7.7 2.8.5 or 3.0.3 3.1.2. |
   | +1 | javadoc | 24 | the patch passed |
   | +1 | findbugs | 66 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 341 | hbase-rest in the patch failed. |
   | +1 | asflicense | 13 | The patch does not generate ASF License warnings. |
   | | | 4067 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.rest.TestNamespacesInstanceResource |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/5/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/524 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux ea9ff6f31a8b 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 
10:55:24 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-524/out/precommit/personality/provided.sh
 |
   | git revision | branch-2.1 / 751330c06d |
   | Default Java | 1.8.0_181 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/5/artifact/out/diff-checkstyle-hbase-rest.txt
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/5/artifact/out/patch-unit-hbase-rest.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/5/testReport/
 |
   | Max. process+thread count | 2249 (vs. ulimit of 1) |
   | modules | C: hbase-rest U: hbase-rest |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/5/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #519: HBASE-22744 Removed deprecated status and load classes in client module

2019-08-23 Thread GitBox
Apache-HBase commented on issue #519: HBASE-22744 Removed deprecated status and 
load classes in client module
URL: https://github.com/apache/hbase/pull/519#issuecomment-524516048
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 40 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 6 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 63 | Maven dependency ordering for branch |
   | +1 | mvninstall | 318 | master passed |
   | +1 | compile | 122 | master passed |
   | +1 | checkstyle | 127 | master passed |
   | +1 | shadedjars | 266 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 88 | master passed |
   | 0 | spotbugs | 243 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 389 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 15 | Maven dependency ordering for patch |
   | +1 | mvninstall | 301 | the patch passed |
   | +1 | compile | 120 | the patch passed |
   | +1 | javac | 120 | the patch passed |
   | +1 | checkstyle | 28 | hbase-client: The patch generated 0 new + 180 
unchanged - 3 fixed = 180 total (was 183) |
   | +1 | checkstyle | 10 | The patch passed checkstyle in hbase-zookeeper |
   | +1 | checkstyle | 71 | The patch passed checkstyle in hbase-server |
   | +1 | checkstyle | 14 | The patch passed checkstyle in hbase-rest |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 262 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 910 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 85 | the patch passed |
   | +1 | findbugs | 446 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 99 | hbase-client in the patch passed. |
   | +1 | unit | 48 | hbase-zookeeper in the patch passed. |
   | +1 | unit | 8809 | hbase-server in the patch passed. |
   | +1 | unit | 262 | hbase-rest in the patch passed. |
   | +1 | asflicense | 89 | The patch does not generate ASF License warnings. |
   | | | 13391 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-519/8/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/519 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 1129e4892843 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-519/out/precommit/personality/provided.sh
 |
   | git revision | master / 504fc52187 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-519/8/testReport/
 |
   | Max. process+thread count | 4827 (vs. ulimit of 1) |
   | modules | C: hbase-client hbase-zookeeper hbase-server hbase-rest U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-519/8/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #512: HBASE-22881 Fix non-daemon threads in hbase server implementation

2019-08-23 Thread GitBox
Apache-HBase commented on issue #512: HBASE-22881 Fix non-daemon threads in 
hbase server implementation
URL: https://github.com/apache/hbase/pull/512#issuecomment-524516004
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 39 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 36 | Maven dependency ordering for branch |
   | +1 | mvninstall | 332 | master passed |
   | +1 | compile | 112 | master passed |
   | +1 | checkstyle | 142 | master passed |
   | +1 | shadedjars | 287 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 83 | master passed |
   | 0 | spotbugs | 100 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 412 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 16 | Maven dependency ordering for patch |
   | +1 | mvninstall | 317 | the patch passed |
   | +1 | compile | 106 | the patch passed |
   | +1 | javac | 106 | the patch passed |
   | -1 | checkstyle | 72 | hbase-server: The patch generated 2 new + 150 
unchanged - 2 fixed = 152 total (was 152) |
   | -1 | checkstyle | 37 | hbase-thrift: The patch generated 2 new + 0 
unchanged - 0 fixed = 2 total (was 0) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 297 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 986 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 82 | the patch passed |
   | +1 | findbugs | 408 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 177 | hbase-common in the patch passed. |
   | +1 | unit | 8446 | hbase-server in the patch passed. |
   | +1 | unit | 216 | hbase-thrift in the patch passed. |
   | +1 | asflicense | 61 | The patch does not generate ASF License warnings. |
   | | | 13092 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-512/19/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/512 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 1e3cdc4a3b3c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-512/out/precommit/personality/provided.sh
 |
   | git revision | master / 504fc52187 |
   | Default Java | 1.8.0_181 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-512/19/artifact/out/diff-checkstyle-hbase-server.txt
 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-512/19/artifact/out/diff-checkstyle-hbase-thrift.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-512/19/testReport/
 |
   | Max. process+thread count | 4908 (vs. ulimit of 1) |
   | modules | C: hbase-common hbase-server hbase-thrift U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-512/19/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] saintstack commented on issue #525: [HBASE-22852] Stop gpg agent daemons in hbase nightlies.

2019-08-23 Thread GitBox
saintstack commented on issue #525: [HBASE-22852] Stop gpg agent daemons in 
hbase nightlies.
URL: https://github.com/apache/hbase/pull/525#issuecomment-524515571
 
 
   What you think @busbey ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #510: HBASE-22878 Show table throttle quotas in table jsp

2019-08-23 Thread GitBox
Apache-HBase commented on issue #510: HBASE-22878 Show table throttle quotas in 
table jsp
URL: https://github.com/apache/hbase/pull/510#issuecomment-524515390
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 43 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 33 | Maven dependency ordering for branch |
   | +1 | mvninstall | 309 | master passed |
   | +1 | compile | 76 | master passed |
   | +1 | checkstyle | 99 | master passed |
   | +1 | shadedjars | 270 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 57 | master passed |
   | 0 | spotbugs | 243 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 315 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 15 | Maven dependency ordering for patch |
   | +1 | mvninstall | 287 | the patch passed |
   | +1 | compile | 74 | the patch passed |
   | +1 | javac | 74 | the patch passed |
   | +1 | checkstyle | 96 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 262 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 887 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 55 | the patch passed |
   | +1 | findbugs | 344 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 99 | hbase-client in the patch passed. |
   | +1 | unit | 8786 | hbase-server in the patch passed. |
   | +1 | asflicense | 44 | The patch does not generate ASF License warnings. |
   | | | 12517 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/20/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/510 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 4ab58c4e9143 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-510/out/precommit/personality/provided.sh
 |
   | git revision | master / 504fc52187 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/20/testReport/
 |
   | Max. process+thread count | 4917 (vs. ulimit of 1) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/20/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…

2019-08-23 Thread GitBox
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts 
of TokenUtil off into a Clien…
URL: https://github.com/apache/hbase/pull/361#issuecomment-524515301
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 102 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 2 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 34 | Maven dependency ordering for branch |
   | +1 | mvninstall | 343 | master passed |
   | +1 | compile | 85 | master passed |
   | +1 | checkstyle | 115 | master passed |
   | +1 | shadedjars | 341 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 57 | master passed |
   | 0 | spotbugs | 269 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 344 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 17 | Maven dependency ordering for patch |
   | +1 | mvninstall | 348 | the patch passed |
   | +1 | compile | 110 | the patch passed |
   | +1 | javac | 110 | the patch passed |
   | +1 | checkstyle | 133 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 343 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1062 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 69 | the patch passed |
   | +1 | findbugs | 310 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 103 | hbase-client in the patch passed. |
   | -1 | unit | 17304 | hbase-server in the patch failed. |
   | +1 | asflicense | 47 | The patch does not generate ASF License warnings. |
   | | | 21700 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.master.assignment.TestOpenRegionProcedureHang |
   |   | hadoop.hbase.client.TestAsyncTableGetMultiThreaded |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/128/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/361 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 86ba83078857 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
 |
   | git revision | master / 43f53c1a23 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/128/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/128/testReport/
 |
   | Max. process+thread count | 5132 (vs. ulimit of 1) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/128/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #526: HBASE-22895 Fix the flakey TestSpaceQuotas

2019-08-23 Thread GitBox
Apache-HBase commented on issue #526: HBASE-22895 Fix the flakey TestSpaceQuotas
URL: https://github.com/apache/hbase/pull/526#issuecomment-524514915
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 45 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 9 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 397 | master passed |
   | +1 | compile | 71 | master passed |
   | +1 | checkstyle | 82 | master passed |
   | +1 | shadedjars | 316 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 52 | master passed |
   | 0 | spotbugs | 344 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 342 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 352 | the patch passed |
   | +1 | compile | 63 | the patch passed |
   | +1 | javac | 63 | the patch passed |
   | +1 | checkstyle | 94 | hbase-server: The patch generated 0 new + 0 
unchanged - 3 fixed = 0 total (was 3) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 357 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1033 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 39 | the patch passed |
   | +1 | findbugs | 281 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 9547 | hbase-server in the patch passed. |
   | +1 | asflicense | 30 | The patch does not generate ASF License warnings. |
   | | | 13508 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-526/7/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/526 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 81f0997aad46 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-526/out/precommit/personality/provided.sh
 |
   | git revision | master / 504fc52187 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-526/7/testReport/
 |
   | Max. process+thread count | 4849 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-526/7/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #530: HBASE-22806 Recreating a deleted column family brings back the delete…

2019-08-23 Thread GitBox
Apache-HBase commented on issue #530: HBASE-22806 Recreating a deleted column 
family brings back the delete…
URL: https://github.com/apache/hbase/pull/530#issuecomment-524514851
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 34 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 413 | master passed |
   | +1 | compile | 77 | master passed |
   | +1 | checkstyle | 113 | master passed |
   | +1 | shadedjars | 368 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 45 | master passed |
   | 0 | spotbugs | 321 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 320 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 387 | the patch passed |
   | +1 | compile | 75 | the patch passed |
   | +1 | javac | 75 | the patch passed |
   | +1 | checkstyle | 116 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 382 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1254 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 45 | the patch passed |
   | +1 | findbugs | 335 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 9545 | hbase-server in the patch passed. |
   | +1 | asflicense | 28 | The patch does not generate ASF License warnings. |
   | | | 13993 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/5/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/530 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 4e12fa64b0bf 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 
10:55:24 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-530/out/precommit/personality/provided.sh
 |
   | git revision | master / 504fc52187 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/5/testReport/
 |
   | Max. process+thread count | 4683 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/5/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #509: HBASE-22877 WebHDFS based export snapshot will fail if hfile is in archive directory

2019-08-23 Thread GitBox
Apache-HBase commented on issue #509: HBASE-22877 WebHDFS based export snapshot 
will fail if hfile is in archive directory
URL: https://github.com/apache/hbase/pull/509#issuecomment-524514808
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 40 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 331 | master passed |
   | +1 | compile | 53 | master passed |
   | +1 | checkstyle | 76 | master passed |
   | +1 | shadedjars | 278 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 34 | master passed |
   | 0 | spotbugs | 242 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 240 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 305 | the patch passed |
   | +1 | compile | 53 | the patch passed |
   | +1 | javac | 53 | the patch passed |
   | +1 | checkstyle | 70 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 263 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 915 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 33 | the patch passed |
   | +1 | findbugs | 248 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 8657 | hbase-server in the patch failed. |
   | +1 | asflicense | 24 | The patch does not generate ASF License warnings. |
   | | | 11980 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.security.token.TestZKSecretWatcher |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/20/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/509 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 4ab83ca2d982 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-509/out/precommit/personality/provided.sh
 |
   | git revision | master / 504fc52187 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/20/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/20/testReport/
 |
   | Max. process+thread count | 4710 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/20/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22852) hbase nightlies leaking gpg-agents

2019-08-23 Thread HBase QA (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914793#comment-16914793
 ] 

HBase QA commented on HBASE-22852:
--

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m  
1s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  
1s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
 1s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
20s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}  2m 47s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/9/artifact/out/Dockerfile
 |
| GITHUB PR | https://github.com/apache/hbase/pull/525 |
| JIRA Issue | HBASE-22852 |
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux e302a0a58a44 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-525/out/precommit/personality/provided.sh
 |
| git revision | master / ee9d98611b |
| Max. process+thread count | 51 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/9/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |


This message was automatically generated.



> hbase nightlies leaking gpg-agents
> --
>
> Key: HBASE-22852
> URL: https://issues.apache.org/jira/browse/HBASE-22852
> Project: HBase
>  Issue Type: Bug
>  Components: build
>Reporter: Allen Wittenauer
>Priority: Major
>
> FYI, just triggered yetus master, which includes code to find and kill 
> long-running processes still attached to the Jenkins workspace directory.  It 
> came up with this:
> https://builds.apache.org/view/S-Z/view/Yetus/job/yetus-github-multibranch/job/master/134/console
> {code}
> USER   PID %CPU %MEMVSZ   RSS TTY  STAT START   TIME COMMAND
>  jenkins752  0.0  0.0  93612   584 ?Ss   Aug12   0:00 gpg-agent 
> --homedir 
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_HBASE-20952/downloads-hadoop-2/.gpg
>  --use-standard-socket --daemon
>  Killing 752 ***
> {code}
> (repeat 10s of times, which slightly different dates, pids, versions, etc)
> Also, be aware that any other process running on the node (such as the other 
> executor) has extremely easy access to whatever gpg creds you are using...



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #525: [HBASE-22852] Stop gpg agent daemons in hbase nightlies.

2019-08-23 Thread GitBox
Apache-HBase commented on issue #525: [HBASE-22852] Stop gpg agent daemons in 
hbase nightlies.
URL: https://github.com/apache/hbase/pull/525#issuecomment-524514462
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 61 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | 0 | shelldocs | 1 | Shelldocs was not available. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   ||| _ master Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   | +1 | shellcheck | 1 | There were no new shellcheck issues. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   ||| _ Other Tests _ |
   | +1 | asflicense | 20 | The patch does not generate ASF License warnings. |
   | | | 167 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/9/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/525 |
   | JIRA Issue | HBASE-22852 |
   | Optional Tests | dupname asflicense shellcheck shelldocs |
   | uname | Linux e302a0a58a44 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-525/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Max. process+thread count | 51 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/9/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read

2019-08-23 Thread GitBox
Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer 
allocation in FileIOEngine#read
URL: https://github.com/apache/hbase/pull/479#issuecomment-524514124
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 226 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 33 | Maven dependency ordering for branch |
   | +1 | mvninstall | 317 | master passed |
   | +1 | compile | 81 | master passed |
   | +1 | checkstyle | 105 | master passed |
   | +1 | shadedjars | 289 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 58 | master passed |
   | 0 | spotbugs | 267 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 318 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 16 | Maven dependency ordering for patch |
   | +1 | mvninstall | 303 | the patch passed |
   | +1 | compile | 77 | the patch passed |
   | +1 | javac | 77 | the patch passed |
   | +1 | checkstyle | 24 | hbase-common: The patch generated 0 new + 48 
unchanged - 2 fixed = 48 total (was 50) |
   | +1 | checkstyle | 75 | The patch passed checkstyle in hbase-server |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 302 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1041 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | -1 | javadoc | 23 | hbase-common generated 4 new + 0 unchanged - 0 fixed = 
4 total (was 0) |
   | +1 | findbugs | 354 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 177 | hbase-common in the patch passed. |
   | -1 | unit | 17684 | hbase-server in the patch failed. |
   | +1 | asflicense | 69 | The patch does not generate ASF License warnings. |
   | | | 22097 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.master.TestAssignmentManagerMetrics |
   |   | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/45/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/479 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux f3a2e09c8e48 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 
13:14:43 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-479/out/precommit/personality/provided.sh
 |
   | git revision | master / 43f53c1a23 |
   | Default Java | 1.8.0_181 |
   | javadoc | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/45/artifact/out/diff-javadoc-javadoc-hbase-common.txt
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/45/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/45/testReport/
 |
   | Max. process+thread count | 4854 (vs. ulimit of 1) |
   | modules | C: hbase-common hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/45/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22464) Improvements to hbase-vote script

2019-08-23 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914789#comment-16914789
 ] 

Hudson commented on HBASE-22464:


Results for branch master
[build #1356 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1356/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1356//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1356//JDK8_Nightly_Build_Report_(Hadoop2)/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1356//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Improvements to hbase-vote script
> -
>
> Key: HBASE-22464
> URL: https://issues.apache.org/jira/browse/HBASE-22464
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.9, 1.3.4, 2.3.0, 2.1.4
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2
>
> Attachments: HBASE-22464.branch-1.patch, HBASE-22464.v01.patch, 
> HBASE-22464.v02.patch, HBASE-22464.v03.patch, HBASE-22464.v04.patch, 
> HBASE-22464.v05.patch, HBASE-22464.v06.patch, HBASE-22464.v07.patch
>
>
> This Jira proposes to add the following two improvements:
>  # wget -N option for checking timestamp of downloaded RC files, if the local 
> copy of downloaded file is identical on the server, that file will be ignored.
>  # mvn -fn to never fail running the tests, previously with option -fae I 
> could not get the whole suite to run w/out failing.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #510: HBASE-22878 Show table throttle quotas in table jsp

2019-08-23 Thread GitBox
Apache-HBase commented on issue #510: HBASE-22878 Show table throttle quotas in 
table jsp
URL: https://github.com/apache/hbase/pull/510#issuecomment-524513733
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 64 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 63 | Maven dependency ordering for branch |
   | +1 | mvninstall | 434 | master passed |
   | +1 | compile | 93 | master passed |
   | +1 | checkstyle | 125 | master passed |
   | +1 | shadedjars | 365 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 67 | master passed |
   | 0 | spotbugs | 311 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 392 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 15 | Maven dependency ordering for patch |
   | +1 | mvninstall | 414 | the patch passed |
   | +1 | compile | 97 | the patch passed |
   | +1 | javac | 97 | the patch passed |
   | +1 | checkstyle | 144 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 380 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1307 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 72 | the patch passed |
   | +1 | findbugs | 427 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 131 | hbase-client in the patch passed. |
   | -1 | unit | 19249 | hbase-server in the patch failed. |
   | +1 | asflicense | 55 | The patch does not generate ASF License warnings. |
   | | | 24399 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
   |   | hadoop.hbase.master.TestAssignmentManagerMetrics |
   |   | hadoop.hbase.replication.TestReplicationSmallTests |
   |   | hadoop.hbase.replication.TestReplicationSmallTestsSync |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
   |   | hadoop.hbase.tool.TestSecureBulkLoadHFiles |
   |   | hadoop.hbase.client.TestCloneSnapshotFromClientNormal |
   |   | hadoop.hbase.replication.TestReplicationKillSlaveRS |
   |   | hadoop.hbase.tool.TestBulkLoadHFiles |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/19/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/510 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 4d0c83299552 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-510/out/precommit/personality/provided.sh
 |
   | git revision | master / 43f53c1a23 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/19/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/19/testReport/
 |
   | Max. process+thread count | 4665 (vs. ulimit of 1) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/19/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] saintstack commented on a change in pull request #494: HBASE-22380 break circle replication when doing bulkload

2019-08-23 Thread GitBox
saintstack commented on a change in pull request #494: HBASE-22380 break circle 
replication when doing bulkload
URL: https://github.com/apache/hbase/pull/494#discussion_r317342649
 
 

 ##
 File path: 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoadReplication.java
 ##
 @@ -0,0 +1,237 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import static org.apache.hadoop.hbase.HConstants.REPLICATION_CLUSTER_ID;
+import static org.apache.hadoop.hbase.HConstants.REPLICATION_CONF_DIR;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.util.List;
+import java.util.Optional;
+import java.util.concurrent.atomic.AtomicInteger;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FSDataOutputStream;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.Cell;
+import org.apache.hadoop.hbase.CellBuilder;
+import org.apache.hadoop.hbase.CellBuilderFactory;
+import org.apache.hadoop.hbase.CellBuilderType;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.KeyValue;
+import org.apache.hadoop.hbase.client.Get;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.coprocessor.ObserverContext;
+import org.apache.hadoop.hbase.coprocessor.RegionCoprocessor;
+import org.apache.hadoop.hbase.coprocessor.RegionCoprocessorEnvironment;
+import org.apache.hadoop.hbase.coprocessor.RegionObserver;
+import org.apache.hadoop.hbase.io.hfile.HFile;
+import org.apache.hadoop.hbase.io.hfile.HFileContext;
+import org.apache.hadoop.hbase.replication.ReplicationPeerConfig;
+import org.apache.hadoop.hbase.replication.TestReplicationBase;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.testclassification.ReplicationTests;
+import org.apache.hadoop.hbase.tool.BulkLoadHFilesTool;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.util.Pair;
+import org.apache.hadoop.hdfs.MiniDFSCluster;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
+import org.junit.rules.TestName;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Integration test for bulk load replication. Defines two clusters, with two 
way replication.
+ * Performs a bulk load on cluster defined by UTIL1 first, asserts the Cell on 
the bulk loaded file
+ * gets into the related table in UTIL1, then also validates the same got 
replicated to cluster
+ * UTIL2. Then, bulk loads another file into UTIL2, and checks if related 
values are present on
+ * UTIL2, and also gets replicated to UTIL1.
+ * It also defines a preBulkLoad coprocessor that is added to all test table 
regions on each of the
+ * clusters, in order to count amount of times bulk load actually gets 
invoked. This is to certify
+ * we are not entered in the infinite loop condition addressed by HBASE-22380.
+ */
+@Category({ ReplicationTests.class, MediumTests.class})
+public class TestBulkLoadReplication extends TestReplicationBase {
+
+  @ClassRule
+  public static final HBaseClassTestRule CLASS_RULE =
+HBaseClassTestRule.forClass(TestBulkLoadReplication.class);
+
+  protected static final Logger LOG =
+LoggerFactory.getLogger(TestBulkLoadReplication.class);
+
+  private static final String SRC_REP_CLUSTER_ID = "src";
+  private static final String DEST_REP_CLUSTER_ID = "dest";
+  private static final String PEER_ID = "1";
+  private static final AtomicInteger BULK_LOADS_COUNT = new AtomicInteger(0);
+
+  @Rule
+  public TestName name = new TestName();
+
+  @ClassRule
+  public static TemporaryFolder testFolder = new TemporaryFolder();
+
+  @BeforeClass
+  public static void setUpBeforeClass() throws Exception {
+

[GitHub] [hbase] saintstack commented on a change in pull request #494: HBASE-22380 break circle replication when doing bulkload

2019-08-23 Thread GitBox
saintstack commented on a change in pull request #494: HBASE-22380 break circle 
replication when doing bulkload
URL: https://github.com/apache/hbase/pull/494#discussion_r317342774
 
 

 ##
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
 ##
 @@ -2364,6 +2364,14 @@ public UpdateFavoredNodesResponse 
updateFavoredNodes(RpcController controller,
   public BulkLoadHFileResponse bulkLoadHFile(final RpcController controller,
   final BulkLoadHFileRequest request) throws ServiceException {
 long start = EnvironmentEdgeManager.currentTime();
+if(request.getClusterId() != null &&
+request.getClusterId().equals(this.regionServer.clusterId)){
+  return BulkLoadHFileResponse.newBuilder().setLoaded(true).build();
+}
+String clusterId = request.getClusterId();
 
 Review comment:
   nit. Do this a few lines higher and then you can replace a few 
request.getClusterId() calls.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #501: HBASE-22699 refactor isMetaClearingException

2019-08-23 Thread GitBox
Apache-HBase commented on issue #501: HBASE-22699 refactor 
isMetaClearingException
URL: https://github.com/apache/hbase/pull/501#issuecomment-524513343
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 58 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 35 | Maven dependency ordering for branch |
   | +1 | mvninstall | 303 | master passed |
   | +1 | compile | 76 | master passed |
   | +1 | checkstyle | 100 | master passed |
   | +1 | shadedjars | 290 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 56 | master passed |
   | 0 | spotbugs | 255 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 323 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 15 | Maven dependency ordering for patch |
   | +1 | mvninstall | 308 | the patch passed |
   | +1 | compile | 80 | the patch passed |
   | +1 | javac | 80 | the patch passed |
   | +1 | checkstyle | 107 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 289 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 984 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 54 | the patch passed |
   | +1 | findbugs | 336 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 104 | hbase-client in the patch passed. |
   | -1 | unit | 19132 | hbase-server in the patch failed. |
   | +1 | asflicense | 39 | The patch does not generate ASF License warnings. |
   | | | 23088 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.master.TestAssignmentManagerMetrics |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
   |   | hadoop.hbase.client.TestAsyncTableAdminApi |
   |   | hadoop.hbase.client.TestAsyncReplicationAdminApiWithClusters |
   |   | hadoop.hbase.replication.TestReplicationSmallTests |
   |   | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory |
   |   | hadoop.hbase.client.TestMetaCache |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/29/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/501 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 0ac40901bb0a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-501/out/precommit/personality/provided.sh
 |
   | git revision | master / 43f53c1a23 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/29/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/29/testReport/
 |
   | Max. process+thread count | 4994 (vs. ulimit of 1) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/29/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent

2019-08-23 Thread GitBox
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of 
RSGroup idempotent
URL: https://github.com/apache/hbase/pull/387#issuecomment-524512860
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 41 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 411 | master passed |
   | +1 | compile | 33 | master passed |
   | +1 | checkstyle | 19 | master passed |
   | +1 | shadedjars | 344 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 25 | master passed |
   | 0 | spotbugs | 60 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 58 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 400 | the patch passed |
   | +1 | compile | 37 | the patch passed |
   | +1 | javac | 37 | the patch passed |
   | +1 | checkstyle | 18 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 364 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1219 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 30 | the patch passed |
   | +1 | findbugs | 70 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 540 | hbase-rsgroup in the patch passed. |
   | +1 | asflicense | 13 | The patch does not generate ASF License warnings. |
   | | | 4112 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/120/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/387 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 7165c882999a 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 
10:55:24 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/120/testReport/
 |
   | Max. process+thread count | 4364 (vs. ulimit of 1) |
   | modules | C: hbase-rsgroup U: hbase-rsgroup |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/120/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes…

2019-08-23 Thread GitBox
Apache-HBase commented on issue #446: HBASE-22781 optimize the test case 
TestStoreScanner.testScanSameTimes…
URL: https://github.com/apache/hbase/pull/446#issuecomment-524512689
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 60 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 417 | master passed |
   | +1 | compile | 73 | master passed |
   | +1 | checkstyle | 96 | master passed |
   | +1 | shadedjars | 360 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 45 | master passed |
   | 0 | spotbugs | 327 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 324 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 382 | the patch passed |
   | +1 | compile | 68 | the patch passed |
   | +1 | javac | 68 | the patch passed |
   | +1 | checkstyle | 99 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 367 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1192 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 42 | the patch passed |
   | +1 | findbugs | 322 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 15874 | hbase-server in the patch failed. |
   | +1 | asflicense | 35 | The patch does not generate ASF License warnings. |
   | | | 20213 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
   |   | hadoop.hbase.master.TestMasterShutdown |
   |   | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/72/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/446 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux dad802c047d9 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 
05:29:03 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-446/out/precommit/personality/provided.sh
 |
   | git revision | master / 43f53c1a23 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/72/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/72/testReport/
 |
   | Max. process+thread count | 4687 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/72/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22380) break circle replication when doing bulkload

2019-08-23 Thread Anoop Sam John (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914780#comment-16914780
 ] 

Anoop Sam John commented on HBASE-22380:


[~wchevreuil].   I mean why the user/client need to pass clusterId?  When the 
bulk load req comes to the 1st cluster, that RS can add its clusterId in the 
WALEdit cell.  That can be passed to the next cluster while doing replication. 
Only passing the 1st clusterId through all the clusters might not be enough.  
We need to add current clusterId into the existing list while passing to next.  
And same way check to see whether this cluster already saw/handled this 
replication or not.

> break circle replication when doing bulkload
> 
>
> Key: HBASE-22380
> URL: https://issues.apache.org/jira/browse/HBASE-22380
> Project: HBase
>  Issue Type: Bug
>  Components: Replication
>Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.5, 2.3.0, 2.1.5, 1.3.5
>Reporter: chenxu
>Assignee: Wellington Chevreuil
>Priority: Critical
>  Labels: bulkload
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.1.7, 2.2.2
>
>
> when enabled master-master bulkload replication, HFiles will be replicated 
> circularly between two clusters



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #529: HBASE-22904 NPE occurs when RS send space quota usage report during HMaster init

2019-08-23 Thread GitBox
Apache-HBase commented on issue #529: HBASE-22904 NPE occurs when RS send space 
quota usage report during HMaster init
URL: https://github.com/apache/hbase/pull/529#issuecomment-524511517
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 37 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 343 | master passed |
   | +1 | compile | 58 | master passed |
   | +1 | checkstyle | 78 | master passed |
   | +1 | shadedjars | 291 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 35 | master passed |
   | 0 | spotbugs | 246 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 244 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 315 | the patch passed |
   | +1 | compile | 56 | the patch passed |
   | +1 | javac | 56 | the patch passed |
   | +1 | checkstyle | 77 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 288 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 971 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 35 | the patch passed |
   | +1 | findbugs | 257 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 8248 | hbase-server in the patch passed. |
   | +1 | asflicense | 29 | The patch does not generate ASF License warnings. |
   | | | 11740 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-529/5/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/529 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 21387206c031 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 
09:17:01 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-529/out/precommit/personality/provided.sh
 |
   | git revision | master / 504fc52187 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-529/5/testReport/
 |
   | Max. process+thread count | 4758 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-529/5/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload

2019-08-23 Thread GitBox
Apache-HBase commented on issue #494: HBASE-22380 break circle replication when 
doing bulkload
URL: https://github.com/apache/hbase/pull/494#issuecomment-524511329
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 61 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ branch-2 Compile Tests _ |
   | 0 | mvndep | 14 | Maven dependency ordering for branch |
   | +1 | mvninstall | 349 | branch-2 passed |
   | +1 | compile | 114 | branch-2 passed |
   | +1 | checkstyle | 121 | branch-2 passed |
   | +1 | shadedjars | 243 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 70 | branch-2 passed |
   | 0 | spotbugs | 214 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 439 | branch-2 passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 16 | Maven dependency ordering for patch |
   | +1 | mvninstall | 314 | the patch passed |
   | +1 | compile | 122 | the patch passed |
   | +1 | cc | 122 | the patch passed |
   | +1 | javac | 122 | the patch passed |
   | -1 | checkstyle | 84 | hbase-server: The patch generated 1 new + 302 
unchanged - 0 fixed = 303 total (was 302) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 261 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1075 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | hbaseprotoc | 106 | the patch passed |
   | +1 | javadoc | 74 | the patch passed |
   | -1 | findbugs | 220 | hbase-server generated 1 new + 0 unchanged - 0 fixed 
= 1 total (was 0) |
   ||| _ Other Tests _ |
   | +1 | unit | 36 | hbase-protocol-shaded in the patch passed. |
   | +1 | unit | 195 | hbase-client in the patch passed. |
   | -1 | unit | 15590 | hbase-server in the patch failed. |
   | +1 | asflicense | 65 | The patch does not generate ASF License warnings. |
   | | | 20326 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | FindBugs | module:hbase-server |
   |  |  
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List,
 CellScanner, String, String, String) makes inefficient use of keySet iterator 
instead of entrySet iterator  At ReplicationSink.java:makes inefficient use of 
keySet iterator instead of entrySet iterator  At ReplicationSink.java:[line 
257] |
   | Failed junit tests | 
hadoop.hbase.regionserver.TestCompactionInDeadRegionServer |
   |   | 
hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/26/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/494 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc |
   | uname | Linux c11957e84cee 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
 |
   | git revision | branch-2 / 2bd4aa2d0b |
   | Default Java | 1.8.0_181 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/26/artifact/out/diff-checkstyle-hbase-server.txt
 |
   | findbugs | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/26/artifact/out/new-findbugs-hbase-server.html
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/26/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/26/testReport/
 |
   | Max. process+thread count | 4094 (vs. ulimit of 1) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/26/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


W

[GitHub] [hbase] Apache-HBase commented on issue #529: HBASE-22904 NPE occurs when RS send space quota usage report during HMaster init

2019-08-23 Thread GitBox
Apache-HBase commented on issue #529: HBASE-22904 NPE occurs when RS send space 
quota usage report during HMaster init
URL: https://github.com/apache/hbase/pull/529#issuecomment-524510697
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 89 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 513 | master passed |
   | +1 | compile | 75 | master passed |
   | +1 | checkstyle | 109 | master passed |
   | +1 | shadedjars | 397 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 45 | master passed |
   | 0 | spotbugs | 322 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 319 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 396 | the patch passed |
   | +1 | compile | 67 | the patch passed |
   | +1 | javac | 67 | the patch passed |
   | +1 | checkstyle | 88 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 370 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1299 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 42 | the patch passed |
   | +1 | findbugs | 329 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 19412 | hbase-server in the patch failed. |
   | +1 | asflicense | 48 | The patch does not generate ASF License warnings. |
   | | | 24088 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
   |   | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
   |   | hadoop.hbase.tool.TestSecureBulkLoadHFiles |
   |   | hadoop.hbase.master.procedure.TestProcedurePriority |
   |   | hadoop.hbase.client.TestAsyncTableAdminApi |
   |   | hadoop.hbase.namespace.TestNamespaceAuditor |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-529/4/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/529 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 4d5665d78b01 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-529/out/precommit/personality/provided.sh
 |
   | git revision | master / 2d4580106a |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-529/4/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-529/4/testReport/
 |
   | Max. process+thread count | 4697 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-529/4/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #520: HBASE-22766 Code Coverage Improvement: Create Unit Tests for ResultStatsUtil. Added unit tests for ResultStatsUtil to have 100 percent …

2019-08-23 Thread GitBox
Apache-HBase commented on issue #520: HBASE-22766 Code Coverage Improvement: 
Create Unit Tests for ResultStatsUtil. Added unit tests for ResultStatsUtil to 
have 100 percent …
URL: https://github.com/apache/hbase/pull/520#issuecomment-524510137
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 115 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 352 | master passed |
   | +1 | compile | 25 | master passed |
   | +1 | checkstyle | 32 | master passed |
   | +1 | shadedjars | 285 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 24 | master passed |
   | 0 | spotbugs | 78 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 77 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 368 | the patch passed |
   | +1 | compile | 27 | the patch passed |
   | +1 | javac | 27 | the patch passed |
   | +1 | checkstyle | 31 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 289 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1135 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 23 | the patch passed |
   | +1 | findbugs | 80 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 104 | hbase-client in the patch passed. |
   | +1 | asflicense | 11 | The patch does not generate ASF License warnings. |
   | | | 3361 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/9/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/520 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 01232405efd6 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-520/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/9/testReport/
 |
   | Max. process+thread count | 294 (vs. ulimit of 1) |
   | modules | C: hbase-client U: hbase-client |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/9/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22852) hbase nightlies leaking gpg-agents

2019-08-23 Thread HBase QA (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914779#comment-16914779
 ] 

HBase QA commented on HBASE-22852:
--

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  2m 
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  
0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
 1s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
47s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}  5m  3s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/8/artifact/out/Dockerfile
 |
| GITHUB PR | https://github.com/apache/hbase/pull/525 |
| JIRA Issue | HBASE-22852 |
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux a3c596748fd5 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 
10:55:24 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-525/out/precommit/personality/provided.sh
 |
| git revision | master / ee9d98611b |
| Max. process+thread count | 46 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/8/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |


This message was automatically generated.



> hbase nightlies leaking gpg-agents
> --
>
> Key: HBASE-22852
> URL: https://issues.apache.org/jira/browse/HBASE-22852
> Project: HBase
>  Issue Type: Bug
>  Components: build
>Reporter: Allen Wittenauer
>Priority: Major
>
> FYI, just triggered yetus master, which includes code to find and kill 
> long-running processes still attached to the Jenkins workspace directory.  It 
> came up with this:
> https://builds.apache.org/view/S-Z/view/Yetus/job/yetus-github-multibranch/job/master/134/console
> {code}
> USER   PID %CPU %MEMVSZ   RSS TTY  STAT START   TIME COMMAND
>  jenkins752  0.0  0.0  93612   584 ?Ss   Aug12   0:00 gpg-agent 
> --homedir 
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_HBASE-20952/downloads-hadoop-2/.gpg
>  --use-standard-socket --daemon
>  Killing 752 ***
> {code}
> (repeat 10s of times, which slightly different dates, pids, versions, etc)
> Also, be aware that any other process running on the node (such as the other 
> executor) has extremely easy access to whatever gpg creds you are using...



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #525: [HBASE-22852] Stop gpg agent daemons in hbase nightlies.

2019-08-23 Thread GitBox
Apache-HBase commented on issue #525: [HBASE-22852] Stop gpg agent daemons in 
hbase nightlies.
URL: https://github.com/apache/hbase/pull/525#issuecomment-524509967
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 133 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | 0 | shelldocs | 0 | Shelldocs was not available. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   ||| _ master Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   | +1 | shellcheck | 1 | There were no new shellcheck issues. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   ||| _ Other Tests _ |
   | +1 | asflicense | 47 | The patch does not generate ASF License warnings. |
   | | | 303 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/8/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/525 |
   | JIRA Issue | HBASE-22852 |
   | Optional Tests | dupname asflicense shellcheck shelldocs |
   | uname | Linux a3c596748fd5 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 
10:55:24 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-525/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Max. process+thread count | 46 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/8/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #476: HBASE-11062 hbtop

2019-08-23 Thread GitBox
Apache-HBase commented on issue #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#issuecomment-524509887
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 111 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | 0 | shelldocs | 1 | Shelldocs was not available. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 1 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 22 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 30 | Maven dependency ordering for branch |
   | +1 | mvninstall | 390 | master passed |
   | +1 | compile | 227 | master passed |
   | +1 | checkstyle | 188 | master passed |
   | +1 | shadedjars | 356 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 229 | master passed |
   | 0 | spotbugs | 1140 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | 0 | findbugs | 36 | branch/hbase-assembly no findbugs output file 
(findbugsXml.xml) |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 17 | Maven dependency ordering for patch |
   | +1 | mvninstall | 380 | the patch passed |
   | +1 | compile | 232 | the patch passed |
   | +1 | javac | 232 | the patch passed |
   | +1 | checkstyle | 179 | the patch passed |
   | +1 | shellcheck | 2 | There were no new shellcheck issues. |
   | +1 | whitespace | 1 | The patch has no whitespace issues. |
   | +1 | xml | 5 | The patch has no ill-formed XML file. |
   | +1 | shadedjars | 354 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1198 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 253 | the patch passed |
   | 0 | findbugs | 35 | hbase-assembly has no data from findbugs |
   ||| _ Other Tests _ |
   | -1 | unit | 17966 | root in the patch failed. |
   | +1 | asflicense | 84 | The patch does not generate ASF License warnings. |
   | | | 25091 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated |
   |   | hadoop.hbase.client.TestAdmin1 |
   |   | hadoop.hbase.client.TestAsyncTableAdminApi |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/44/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/476 |
   | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc 
unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle |
   | uname | Linux eb3b2207b323 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 
05:29:03 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-476/out/precommit/personality/provided.sh
 |
   | git revision | master / 2d4580106a |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/44/artifact/out/patch-unit-root.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/44/testReport/
 |
   | Max. process+thread count | 4755 (vs. ulimit of 1) |
   | modules | C: hbase-hbtop hbase-assembly . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/44/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 
findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read

2019-08-23 Thread GitBox
Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer 
allocation in FileIOEngine#read
URL: https://github.com/apache/hbase/pull/479#issuecomment-524509642
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 77 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 34 | Maven dependency ordering for branch |
   | +1 | mvninstall | 371 | master passed |
   | +1 | compile | 83 | master passed |
   | +1 | checkstyle | 109 | master passed |
   | +1 | shadedjars | 292 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 58 | master passed |
   | 0 | spotbugs | 271 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 322 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 16 | Maven dependency ordering for patch |
   | +1 | mvninstall | 316 | the patch passed |
   | +1 | compile | 83 | the patch passed |
   | +1 | javac | 83 | the patch passed |
   | +1 | checkstyle | 24 | hbase-common: The patch generated 0 new + 48 
unchanged - 2 fixed = 48 total (was 50) |
   | +1 | checkstyle | 79 | The patch passed checkstyle in hbase-server |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 290 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1066 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | -1 | javadoc | 19 | hbase-common generated 4 new + 0 unchanged - 0 fixed = 
4 total (was 0) |
   | +1 | findbugs | 302 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 172 | hbase-common in the patch passed. |
   | -1 | unit | 20680 | hbase-server in the patch failed. |
   | +1 | asflicense | 59 | The patch does not generate ASF License warnings. |
   | | | 24904 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
   |   | hadoop.hbase.replication.TestReplicationChangingPeerRegionservers |
   |   | hadoop.hbase.client.TestAdmin1 |
   |   | hadoop.hbase.client.TestCloneSnapshotFromClientNormal |
   |   | hadoop.hbase.client.TestAsyncTableAdminApi |
   |   | hadoop.hbase.replication.TestReplicationSmallTestsSync |
   |   | hadoop.hbase.tool.TestSecureBulkLoadHFiles |
   |   | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory |
   |   | hadoop.hbase.replication.TestReplicationSyncUpTool |
   |   | hadoop.hbase.replication.TestReplicationSmallTests |
   |   | hadoop.hbase.master.assignment.TestOpenRegionProcedureHang |
   |   | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated |
   |   | hadoop.hbase.TestRegionRebalancing |
   |   | hadoop.hbase.replication.TestReplicationKillSlaveRS |
   |   | hadoop.hbase.replication.TestMasterReplication |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
   |   | 
hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL
 |
   |   | hadoop.hbase.master.TestAssignmentManagerMetrics |
   |   | hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/44/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/479 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 1ba8272eac74 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 
13:14:43 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-479/out/precommit/personality/provided.sh
 |
   | git revision | master / 2d4580106a |
   | Default Java | 1.8.0_181 |
   | javadoc | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/44/artifact/out/diff-javadoc-javadoc-hbase-common.txt
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/44/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/44/testReport/
 |
   | Max. process+thread count | 4999 (vs. ulimit of 1) |
   | modules | C: hbase-common hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/44/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
 

[jira] [Commented] (HBASE-22464) Improvements to hbase-vote script

2019-08-23 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914777#comment-16914777
 ] 

Hudson commented on HBASE-22464:


Results for branch branch-2
[build #2187 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2187/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2187//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2187//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2187//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Improvements to hbase-vote script
> -
>
> Key: HBASE-22464
> URL: https://issues.apache.org/jira/browse/HBASE-22464
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.9, 1.3.4, 2.3.0, 2.1.4
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2
>
> Attachments: HBASE-22464.branch-1.patch, HBASE-22464.v01.patch, 
> HBASE-22464.v02.patch, HBASE-22464.v03.patch, HBASE-22464.v04.patch, 
> HBASE-22464.v05.patch, HBASE-22464.v06.patch, HBASE-22464.v07.patch
>
>
> This Jira proposes to add the following two improvements:
>  # wget -N option for checking timestamp of downloaded RC files, if the local 
> copy of downloaded file is identical on the server, that file will be ignored.
>  # mvn -fn to never fail running the tests, previously with option -fae I 
> could not get the whole suite to run w/out failing.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #526: HBASE-22895 Fix the flakey TestSpaceQuotas

2019-08-23 Thread GitBox
Apache-HBase commented on issue #526: HBASE-22895 Fix the flakey TestSpaceQuotas
URL: https://github.com/apache/hbase/pull/526#issuecomment-524509360
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 38 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 9 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 343 | master passed |
   | +1 | compile | 57 | master passed |
   | +1 | checkstyle | 78 | master passed |
   | +1 | shadedjars | 288 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 38 | master passed |
   | 0 | spotbugs | 269 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 266 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 310 | the patch passed |
   | +1 | compile | 58 | the patch passed |
   | +1 | javac | 58 | the patch passed |
   | +1 | checkstyle | 77 | hbase-server: The patch generated 0 new + 0 
unchanged - 3 fixed = 0 total (was 3) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 292 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 945 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 39 | the patch passed |
   | +1 | findbugs | 252 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 8732 | hbase-server in the patch passed. |
   | +1 | asflicense | 25 | The patch does not generate ASF License warnings. |
   | | | 12232 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-526/5/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/526 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 7ae1cd655c2f 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-526/out/precommit/personality/provided.sh
 |
   | git revision | master / 504fc52187 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-526/5/testReport/
 |
   | Max. process+thread count | 4922 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-526/5/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22464) Improvements to hbase-vote script

2019-08-23 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914774#comment-16914774
 ] 

Hudson commented on HBASE-22464:


Results for branch branch-2.2
[build #536 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/536/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/536//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/536//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/536//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Improvements to hbase-vote script
> -
>
> Key: HBASE-22464
> URL: https://issues.apache.org/jira/browse/HBASE-22464
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.9, 1.3.4, 2.3.0, 2.1.4
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2
>
> Attachments: HBASE-22464.branch-1.patch, HBASE-22464.v01.patch, 
> HBASE-22464.v02.patch, HBASE-22464.v03.patch, HBASE-22464.v04.patch, 
> HBASE-22464.v05.patch, HBASE-22464.v06.patch, HBASE-22464.v07.patch
>
>
> This Jira proposes to add the following two improvements:
>  # wget -N option for checking timestamp of downloaded RC files, if the local 
> copy of downloaded file is identical on the server, that file will be ignored.
>  # mvn -fn to never fail running the tests, previously with option -fae I 
> could not get the whole suite to run w/out failing.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #509: HBASE-22877 WebHDFS based export snapshot will fail if hfile is in archive directory

2019-08-23 Thread GitBox
Apache-HBase commented on issue #509: HBASE-22877 WebHDFS based export snapshot 
will fail if hfile is in archive directory
URL: https://github.com/apache/hbase/pull/509#issuecomment-524508898
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 55 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 434 | master passed |
   | +1 | compile | 72 | master passed |
   | +1 | checkstyle | 100 | master passed |
   | +1 | shadedjars | 380 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 48 | master passed |
   | 0 | spotbugs | 324 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 320 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 431 | the patch passed |
   | +1 | compile | 76 | the patch passed |
   | +1 | javac | 76 | the patch passed |
   | +1 | checkstyle | 104 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 370 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1291 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 46 | the patch passed |
   | +1 | findbugs | 332 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 16175 | hbase-server in the patch passed. |
   | +1 | asflicense | 32 | The patch does not generate ASF License warnings. |
   | | | 20737 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/19/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/509 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 46b9dfa4924c 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 
05:29:03 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-509/out/precommit/personality/provided.sh
 |
   | git revision | master / 43f53c1a23 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/19/testReport/
 |
   | Max. process+thread count | 4496 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/19/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility

2019-08-23 Thread GitBox
Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods 
from HBaseTestingUtility
URL: https://github.com/apache/hbase/pull/477#issuecomment-524508321
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 124 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 46 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 386 | master passed |
   | +1 | compile | 64 | master passed |
   | +1 | checkstyle | 104 | master passed |
   | +1 | shadedjars | 305 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 37 | master passed |
   | 0 | spotbugs | 274 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 272 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 332 | the patch passed |
   | +1 | compile | 60 | the patch passed |
   | +1 | javac | 60 | the patch passed |
   | +1 | checkstyle | 94 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 302 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1041 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 35 | the patch passed |
   | +1 | findbugs | 277 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 19622 | hbase-server in the patch failed. |
   | -1 | asflicense | 33 | The patch generated 52 ASF License warnings. |
   | | | 23520 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.filter.TestFilterWithScanLimits |
   |   | hadoop.hbase.replication.TestReplicationKillMasterRS |
   |   | hadoop.hbase.master.TestMirroringTableStateManager |
   |   | hadoop.hbase.master.TestMasterFileSystem |
   |   | hadoop.hbase.master.assignment.TestAssignmentOnRSCrash |
   |   | hadoop.hbase.master.TestDeadServer |
   |   | hadoop.hbase.client.TestAsyncAdminWithRegionReplicas |
   |   | 
hadoop.hbase.client.TestMobCloneSnapshotFromClientCloneLinksAfterDelete |
   |   | hadoop.hbase.regionserver.wal.TestWALReplay |
   |   | hadoop.hbase.client.TestCIPutRpcTimeout |
   |   | hadoop.hbase.client.TestRawAsyncTablePartialScan |
   |   | hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd |
   |   | hadoop.hbase.master.TestRetainAssignmentOnRestart |
   |   | 
hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService |
   |   | hadoop.hbase.client.TestSnapshotWithAcl |
   |   | hadoop.hbase.filter.TestFuzzyRowAndColumnRangeFilter |
   |   | hadoop.hbase.util.TestFSUtils |
   |   | hadoop.hbase.client.TestAsyncClusterAdminApi2 |
   |   | hadoop.hbase.master.procedure.TestMasterObserverPostCalls |
   |   | hadoop.hbase.regionserver.TestScannerWithCorruptHFile |
   |   | hadoop.hbase.master.procedure.TestModifyNamespaceProcedure |
   |   | hadoop.hbase.util.TestCoprocessorScanPolicy |
   |   | hadoop.hbase.master.assignment.TestRegionStateStore |
   |   | hadoop.hbase.security.visibility.TestDefaultScanLabelGeneratorStack |
   |   | hadoop.hbase.master.TestRetainAssignmentOnRestartSplitWithoutZk |
   |   | hadoop.hbase.tool.TestBulkLoadHFiles |
   |   | hadoop.hbase.security.access.TestNamespaceCommands |
   |   | hadoop.hbase.client.TestAsyncTableAdminApi |
   |   | hadoop.hbase.replication.regionserver.TestSerialReplicationEndpoint |
   |   | hadoop.hbase.client.TestIllegalTableDescriptor |
   |   | hadoop.hbase.replication.TestRemoveFromSerialReplicationPeer |
   |   | hadoop.hbase.client.TestAdmin2 |
   |   | hadoop.hbase.util.compaction.TestMajorCompactor |
   |   | hadoop.hbase.TestAcidGuaranteesWithBasicPolicy |
   |   | hadoop.hbase.snapshot.TestSnapshotClientRetries |
   |   | hadoop.hbase.client.TestAsyncTableScanMetrics |
   |   | hadoop.hbase.client.TestAsyncTableRegionReplicasScan |
   |   | hadoop.hbase.master.procedure.TestCreateNamespaceProcedure |
   |   | hadoop.hbase.replication.TestReplicationSyncUpTool |
   |   | hadoop.hbase.replication.TestSyncReplicationNewRSJoinBetweenRefreshes |
   |   | hadoop.hbase.quotas.TestQuotaObserverChoreWithMiniCluster |
   |   | hadoop.hbase.client.TestMultiParallel |
   |   | hadoop.hbase.client.TestAsyncTableNoncedRetry |
   |   | hadoop.hbase.client.TestCIBadHostname |
   |   | hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster |
   |   | hadoop.hbase.replication.TestNamespaceReplication |
   |   | hadoop.hbase.client.TestAvoidCellReferencesIntoShippedBlocks |
   |   | hadoop.hbase.replication.TestReplicationChangingPeerRegionservers |
   |   | hadoop.hbase.coprocessor.TestPassCustomCellViaRegionObser

[GitHub] [hbase] Apache-HBase commented on issue #524: HBASE-22846 Internal Error 500 when Using HBASE REST API to Create Na…

2019-08-23 Thread GitBox
Apache-HBase commented on issue #524: HBASE-22846 Internal Error 500 when Using 
HBASE REST API to Create Na…
URL: https://github.com/apache/hbase/pull/524#issuecomment-524508198
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 85 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ branch-2.1 Compile Tests _ |
   | +1 | mvninstall | 358 | branch-2.1 passed |
   | +1 | compile | 33 | branch-2.1 passed |
   | +1 | checkstyle | 20 | branch-2.1 passed |
   | +1 | shadedjars | 265 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 24 | branch-2.1 passed |
   | 0 | spotbugs | 63 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 61 | branch-2.1 passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 315 | the patch passed |
   | +1 | compile | 33 | the patch passed |
   | +1 | javac | 33 | the patch passed |
   | -1 | checkstyle | 18 | hbase-rest: The patch generated 1 new + 9 unchanged 
- 0 fixed = 10 total (was 9) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 267 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1339 | Patch does not cause any errors with Hadoop 
2.7.7 2.8.5 or 3.0.3 3.1.2. |
   | +1 | javadoc | 24 | the patch passed |
   | +1 | findbugs | 68 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 354 | hbase-rest in the patch failed. |
   | +1 | asflicense | 13 | The patch does not generate ASF License warnings. |
   | | | 3681 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.rest.TestNamespacesInstanceResource |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/4/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/524 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 87430ad80b69 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 
10:55:24 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-524/out/precommit/personality/provided.sh
 |
   | git revision | branch-2.1 / 751330c06d |
   | Default Java | 1.8.0_181 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/4/artifact/out/diff-checkstyle-hbase-rest.txt
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/4/artifact/out/patch-unit-hbase-rest.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/4/testReport/
 |
   | Max. process+thread count | 2234 (vs. ulimit of 1) |
   | modules | C: hbase-rest U: hbase-rest |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/4/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #519: HBASE-22744 Removed deprecated status and load classes in client module

2019-08-23 Thread GitBox
Apache-HBase commented on issue #519: HBASE-22744 Removed deprecated status and 
load classes in client module
URL: https://github.com/apache/hbase/pull/519#issuecomment-524507747
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 65 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 6 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 35 | Maven dependency ordering for branch |
   | +1 | mvninstall | 346 | master passed |
   | +1 | compile | 126 | master passed |
   | +1 | checkstyle | 135 | master passed |
   | +1 | shadedjars | 264 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 88 | master passed |
   | 0 | spotbugs | 242 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 389 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 14 | Maven dependency ordering for patch |
   | +1 | mvninstall | 323 | the patch passed |
   | +1 | compile | 126 | the patch passed |
   | +1 | javac | 126 | the patch passed |
   | +1 | checkstyle | 32 | hbase-client: The patch generated 0 new + 180 
unchanged - 3 fixed = 180 total (was 183) |
   | +1 | checkstyle | 11 | The patch passed checkstyle in hbase-zookeeper |
   | +1 | checkstyle | 72 | The patch passed checkstyle in hbase-server |
   | +1 | checkstyle | 15 | The patch passed checkstyle in hbase-rest |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 261 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1051 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 85 | the patch passed |
   | +1 | findbugs | 418 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 98 | hbase-client in the patch passed. |
   | +1 | unit | 47 | hbase-zookeeper in the patch passed. |
   | -1 | unit | 15805 | hbase-server in the patch failed. |
   | +1 | unit | 490 | hbase-rest in the patch passed. |
   | +1 | asflicense | 96 | The patch does not generate ASF License warnings. |
   | | | 20837 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.master.assignment.TestOpenRegionProcedureHang |
   |   | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated |
   |   | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
   |   | hadoop.hbase.replication.TestReplicationSmallTestsSync |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-519/7/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/519 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 18b9784d8b00 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 
13:14:43 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-519/out/precommit/personality/provided.sh
 |
   | git revision | master / 2d4580106a |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-519/7/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-519/7/testReport/
 |
   | Max. process+thread count | 5220 (vs. ulimit of 1) |
   | modules | C: hbase-client hbase-zookeeper hbase-server hbase-rest U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-519/7/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] jatsakthi opened a new pull request #531: HBASE-22910 Enable TestMultiVersionConcurrencyControl

2019-08-23 Thread GitBox
jatsakthi opened a new pull request #531: HBASE-22910 Enable 
TestMultiVersionConcurrencyControl
URL: https://github.com/apache/hbase/pull/531
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (HBASE-22910) Enable TestMultiVersionConcurrencyControl

2019-08-23 Thread Sakthi (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sakthi updated HBASE-22910:
---
Component/s: test

> Enable TestMultiVersionConcurrencyControl
> -
>
> Key: HBASE-22910
> URL: https://issues.apache.org/jira/browse/HBASE-22910
> Project: HBase
>  Issue Type: Task
>  Components: test
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Major
>
> The TestMultiVersionConcurrencyControl doesn't have the test annotation. Not 
> sure why.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Created] (HBASE-22910) Enable TestMultiVersionConcurrencyControl

2019-08-23 Thread Sakthi (Jira)
Sakthi created HBASE-22910:
--

 Summary: Enable TestMultiVersionConcurrencyControl
 Key: HBASE-22910
 URL: https://issues.apache.org/jira/browse/HBASE-22910
 Project: HBase
  Issue Type: Task
Reporter: Sakthi
Assignee: Sakthi


The TestMultiVersionConcurrencyControl doesn't have the test annotation. Not 
sure why.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (HBASE-22852) hbase nightlies leaking gpg-agents

2019-08-23 Thread HBase QA (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914767#comment-16914767
 ] 

HBase QA commented on HBASE-22852:
--

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m 
54s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  
0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
 1s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
18s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}  3m 28s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/7/artifact/out/Dockerfile
 |
| GITHUB PR | https://github.com/apache/hbase/pull/525 |
| JIRA Issue | HBASE-22852 |
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux 0d9682e7e5f5 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 
18:22:20 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-525/out/precommit/personality/provided.sh
 |
| git revision | master / ee9d98611b |
| Max. process+thread count | 46 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/7/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |


This message was automatically generated.



> hbase nightlies leaking gpg-agents
> --
>
> Key: HBASE-22852
> URL: https://issues.apache.org/jira/browse/HBASE-22852
> Project: HBase
>  Issue Type: Bug
>  Components: build
>Reporter: Allen Wittenauer
>Priority: Major
>
> FYI, just triggered yetus master, which includes code to find and kill 
> long-running processes still attached to the Jenkins workspace directory.  It 
> came up with this:
> https://builds.apache.org/view/S-Z/view/Yetus/job/yetus-github-multibranch/job/master/134/console
> {code}
> USER   PID %CPU %MEMVSZ   RSS TTY  STAT START   TIME COMMAND
>  jenkins752  0.0  0.0  93612   584 ?Ss   Aug12   0:00 gpg-agent 
> --homedir 
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_HBASE-20952/downloads-hadoop-2/.gpg
>  --use-standard-socket --daemon
>  Killing 752 ***
> {code}
> (repeat 10s of times, which slightly different dates, pids, versions, etc)
> Also, be aware that any other process running on the node (such as the other 
> executor) has extremely easy access to whatever gpg creds you are using...



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #525: [HBASE-22852] Stop gpg agent daemons in hbase nightlies.

2019-08-23 Thread GitBox
Apache-HBase commented on issue #525: [HBASE-22852] Stop gpg agent daemons in 
hbase nightlies.
URL: https://github.com/apache/hbase/pull/525#issuecomment-524507217
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 114 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | 0 | shelldocs | 0 | Shelldocs was not available. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   ||| _ master Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   | +1 | shellcheck | 1 | There were no new shellcheck issues. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   ||| _ Other Tests _ |
   | +1 | asflicense | 18 | The patch does not generate ASF License warnings. |
   | | | 208 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/7/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/525 |
   | JIRA Issue | HBASE-22852 |
   | Optional Tests | dupname asflicense shellcheck shelldocs |
   | uname | Linux 0d9682e7e5f5 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 
18:22:20 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-525/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Max. process+thread count | 46 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/7/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #526: HBASE-22895 Fix the flakey TestSpaceQuotas

2019-08-23 Thread GitBox
Apache-HBase commented on issue #526: HBASE-22895 Fix the flakey TestSpaceQuotas
URL: https://github.com/apache/hbase/pull/526#issuecomment-524506954
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 67 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 9 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 339 | master passed |
   | +1 | compile | 62 | master passed |
   | +1 | checkstyle | 80 | master passed |
   | +1 | shadedjars | 305 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 38 | master passed |
   | 0 | spotbugs | 256 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 254 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 294 | the patch passed |
   | +1 | compile | 53 | the patch passed |
   | +1 | javac | 53 | the patch passed |
   | +1 | checkstyle | 73 | hbase-server: The patch generated 0 new + 0 
unchanged - 3 fixed = 0 total (was 3) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 270 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1009 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 36 | the patch passed |
   | +1 | findbugs | 258 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 17001 | hbase-server in the patch failed. |
   | +1 | asflicense | 69 | The patch does not generate ASF License warnings. |
   | | | 20578 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
   |   | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory |
   |   | hadoop.hbase.tool.TestBulkLoadHFiles |
   |   | hadoop.hbase.master.assignment.TestOpenRegionProcedureHang |
   |   | hadoop.hbase.master.TestAssignmentManagerMetrics |
   |   | hadoop.hbase.master.procedure.TestSCPWithReplicas |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-526/4/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/526 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 9f66b9352f50 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-526/out/precommit/personality/provided.sh
 |
   | git revision | master / 2d4580106a |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-526/4/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-526/4/testReport/
 |
   | Max. process+thread count | 4779 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-526/4/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (HBASE-22905) Avoid temp ByteBuffer allocation in BlockingRpcConnection#writeRequest

2019-08-23 Thread chenxu (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chenxu updated HBASE-22905:
---
Issue Type: Improvement  (was: Bug)

> Avoid temp ByteBuffer allocation in BlockingRpcConnection#writeRequest
> --
>
> Key: HBASE-22905
> URL: https://issues.apache.org/jira/browse/HBASE-22905
> Project: HBase
>  Issue Type: Improvement
>Reporter: chenxu
>Priority: Major
>
> Currently BlockingRpcConnection use ByteBufferOutputStream to serialize 
> CellBlock which involve temp ByteBuffer allocation, we can replace it with 
> netty’s ByteBufOutputStream, just like what 
> NettyRpcDuplexHandler#writeRequest doing



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent

2019-08-23 Thread GitBox
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of 
RSGroup idempotent
URL: https://github.com/apache/hbase/pull/387#issuecomment-524506714
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 236 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 430 | master passed |
   | +1 | compile | 28 | master passed |
   | +1 | checkstyle | 16 | master passed |
   | +1 | shadedjars | 349 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 26 | master passed |
   | 0 | spotbugs | 60 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 58 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 413 | the patch passed |
   | +1 | compile | 30 | the patch passed |
   | +1 | javac | 30 | the patch passed |
   | +1 | checkstyle | 16 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 344 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1245 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 20 | the patch passed |
   | +1 | findbugs | 55 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 558 | hbase-rsgroup in the patch passed. |
   | +1 | asflicense | 11 | The patch does not generate ASF License warnings. |
   | | | 4244 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/119/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/387 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 63f85635b93a 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 
22:49:08 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/119/testReport/
 |
   | Max. process+thread count | 4501 (vs. ulimit of 1) |
   | modules | C: hbase-rsgroup U: hbase-rsgroup |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/119/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #529: HBASE-22904 NPE occurs when RS send space quota usage report during HMaster init

2019-08-23 Thread GitBox
Apache-HBase commented on issue #529: HBASE-22904 NPE occurs when RS send space 
quota usage report during HMaster init
URL: https://github.com/apache/hbase/pull/529#issuecomment-524506585
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 211 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 332 | master passed |
   | +1 | compile | 54 | master passed |
   | +1 | checkstyle | 79 | master passed |
   | +1 | shadedjars | 280 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 35 | master passed |
   | 0 | spotbugs | 255 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 253 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 301 | the patch passed |
   | +1 | compile | 56 | the patch passed |
   | +1 | javac | 56 | the patch passed |
   | +1 | checkstyle | 74 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 274 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 937 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 35 | the patch passed |
   | +1 | findbugs | 254 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 18714 | hbase-server in the patch failed. |
   | +1 | asflicense | 24 | The patch does not generate ASF License warnings. |
   | | | 22282 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.master.TestAssignmentManagerMetrics |
   |   | hadoop.hbase.master.procedure.TestSCPWithReplicas |
   |   | hadoop.hbase.replication.TestReplicationKillSlaveRS |
   |   | hadoop.hbase.namespace.TestNamespaceAuditor |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
   |   | hadoop.hbase.replication.TestReplicationSmallTestsSync |
   |   | hadoop.hbase.tool.TestSecureBulkLoadHFiles |
   |   | hadoop.hbase.client.TestCloneSnapshotFromClientNormal |
   |   | hadoop.hbase.replication.TestReplicationSmallTests |
   |   | hadoop.hbase.tool.TestBulkLoadHFiles |
   |   | hadoop.hbase.replication.TestReplicationSyncUpTool |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-529/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/529 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 2faf256885d9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-529/out/precommit/personality/provided.sh
 |
   | git revision | master / 2d4580106a |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-529/3/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-529/3/testReport/
 |
   | Max. process+thread count | 5210 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-529/3/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #512: HBASE-22881 Fix non-daemon threads in hbase server implementation

2019-08-23 Thread GitBox
Apache-HBase commented on issue #512: HBASE-22881 Fix non-daemon threads in 
hbase server implementation
URL: https://github.com/apache/hbase/pull/512#issuecomment-524506566
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 83 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 40 | Maven dependency ordering for branch |
   | +1 | mvninstall | 322 | master passed |
   | +1 | compile | 110 | master passed |
   | +1 | checkstyle | 139 | master passed |
   | +1 | shadedjars | 318 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 92 | master passed |
   | 0 | spotbugs | 90 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 401 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 17 | Maven dependency ordering for patch |
   | +1 | mvninstall | 348 | the patch passed |
   | +1 | compile | 112 | the patch passed |
   | +1 | javac | 112 | the patch passed |
   | -1 | checkstyle | 76 | hbase-server: The patch generated 2 new + 150 
unchanged - 2 fixed = 152 total (was 152) |
   | -1 | checkstyle | 36 | hbase-thrift: The patch generated 2 new + 0 
unchanged - 0 fixed = 2 total (was 0) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 275 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1049 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 84 | the patch passed |
   | +1 | findbugs | 402 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 183 | hbase-common in the patch passed. |
   | -1 | unit | 16879 | hbase-server in the patch failed. |
   | +1 | unit | 451 | hbase-thrift in the patch passed. |
   | +1 | asflicense | 81 | The patch does not generate ASF License warnings. |
   | | | 22006 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory 
|
   |   | hadoop.hbase.client.TestAsyncTableAdminApi3 |
   |   | hadoop.hbase.namespace.TestNamespaceAuditor |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-512/17/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/512 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 6d0c0d2e13da 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-512/out/precommit/personality/provided.sh
 |
   | git revision | master / 2d4580106a |
   | Default Java | 1.8.0_181 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-512/17/artifact/out/diff-checkstyle-hbase-server.txt
 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-512/17/artifact/out/diff-checkstyle-hbase-thrift.txt
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-512/17/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-512/17/testReport/
 |
   | Max. process+thread count | 5054 (vs. ulimit of 1) |
   | modules | C: hbase-common hbase-server hbase-thrift U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-512/17/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #509: HBASE-22877 WebHDFS based export snapshot will fail if hfile is in archive directory

2019-08-23 Thread GitBox
Apache-HBase commented on issue #509: HBASE-22877 WebHDFS based export snapshot 
will fail if hfile is in archive directory
URL: https://github.com/apache/hbase/pull/509#issuecomment-524505885
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 101 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 371 | master passed |
   | +1 | compile | 58 | master passed |
   | +1 | checkstyle | 83 | master passed |
   | +1 | shadedjars | 289 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 37 | master passed |
   | 0 | spotbugs | 268 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 264 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 330 | the patch passed |
   | +1 | compile | 54 | the patch passed |
   | +1 | javac | 54 | the patch passed |
   | +1 | checkstyle | 84 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 291 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1007 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 39 | the patch passed |
   | +1 | findbugs | 318 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 17536 | hbase-server in the patch failed. |
   | +1 | asflicense | 36 | The patch does not generate ASF License warnings. |
   | | | 21300 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
   |   | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory |
   |   | hadoop.hbase.master.TestAssignmentManagerMetrics |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/18/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/509 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux b5d0bb956ab9 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 
08:28:49 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-509/out/precommit/personality/provided.sh
 |
   | git revision | master / 2d4580106a |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/18/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/18/testReport/
 |
   | Max. process+thread count | 4549 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/18/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22852) hbase nightlies leaking gpg-agents

2019-08-23 Thread HBase QA (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914754#comment-16914754
 ] 

HBase QA commented on HBASE-22852:
--

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
58s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  
0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
 0s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
17s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}  2m 27s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/6/artifact/out/Dockerfile
 |
| GITHUB PR | https://github.com/apache/hbase/pull/525 |
| JIRA Issue | HBASE-22852 |
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux 91e5b6988ce1 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-525/out/precommit/personality/provided.sh
 |
| git revision | master / ee9d98611b |
| Max. process+thread count | 51 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/6/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |


This message was automatically generated.



> hbase nightlies leaking gpg-agents
> --
>
> Key: HBASE-22852
> URL: https://issues.apache.org/jira/browse/HBASE-22852
> Project: HBase
>  Issue Type: Bug
>  Components: build
>Reporter: Allen Wittenauer
>Priority: Major
>
> FYI, just triggered yetus master, which includes code to find and kill 
> long-running processes still attached to the Jenkins workspace directory.  It 
> came up with this:
> https://builds.apache.org/view/S-Z/view/Yetus/job/yetus-github-multibranch/job/master/134/console
> {code}
> USER   PID %CPU %MEMVSZ   RSS TTY  STAT START   TIME COMMAND
>  jenkins752  0.0  0.0  93612   584 ?Ss   Aug12   0:00 gpg-agent 
> --homedir 
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_HBASE-20952/downloads-hadoop-2/.gpg
>  --use-standard-socket --daemon
>  Killing 752 ***
> {code}
> (repeat 10s of times, which slightly different dates, pids, versions, etc)
> Also, be aware that any other process running on the node (such as the other 
> executor) has extremely easy access to whatever gpg creds you are using...



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #525: [HBASE-22852] Stop gpg agent daemons in hbase nightlies.

2019-08-23 Thread GitBox
Apache-HBase commented on issue #525: [HBASE-22852] Stop gpg agent daemons in 
hbase nightlies.
URL: https://github.com/apache/hbase/pull/525#issuecomment-524505058
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 58 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | 0 | shelldocs | 0 | Shelldocs was not available. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   ||| _ master Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   | +1 | shellcheck | 0 | There were no new shellcheck issues. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   ||| _ Other Tests _ |
   | +1 | asflicense | 17 | The patch does not generate ASF License warnings. |
   | | | 147 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/6/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/525 |
   | JIRA Issue | HBASE-22852 |
   | Optional Tests | dupname asflicense shellcheck shelldocs |
   | uname | Linux 91e5b6988ce1 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-525/out/precommit/personality/provided.sh
 |
   | git revision | master / ee9d98611b |
   | Max. process+thread count | 51 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/6/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #530: HBASE-22806 Recreating a deleted column family brings back the delete…

2019-08-23 Thread GitBox
Apache-HBase commented on issue #530: HBASE-22806 Recreating a deleted column 
family brings back the delete…
URL: https://github.com/apache/hbase/pull/530#issuecomment-524504947
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 63 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 323 | master passed |
   | +1 | compile | 53 | master passed |
   | +1 | checkstyle | 73 | master passed |
   | +1 | shadedjars | 263 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 34 | master passed |
   | 0 | spotbugs | 236 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 234 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 288 | the patch passed |
   | +1 | compile | 54 | the patch passed |
   | +1 | javac | 54 | the patch passed |
   | +1 | checkstyle | 78 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 283 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 944 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 32 | the patch passed |
   | +1 | findbugs | 239 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 15550 | hbase-server in the patch failed. |
   | +1 | asflicense | 66 | The patch does not generate ASF License warnings. |
   | | | 18974 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/4/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/530 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux ea448e3a98dc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-530/out/precommit/personality/provided.sh
 |
   | git revision | master / 2d4580106a |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/4/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/4/testReport/
 |
   | Max. process+thread count | 5184 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/4/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22464) Improvements to hbase-vote script

2019-08-23 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914752#comment-16914752
 ] 

Hudson commented on HBASE-22464:


Results for branch branch-2.1
[build #1514 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1514/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1514//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1514//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1514//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Improvements to hbase-vote script
> -
>
> Key: HBASE-22464
> URL: https://issues.apache.org/jira/browse/HBASE-22464
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.9, 1.3.4, 2.3.0, 2.1.4
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2
>
> Attachments: HBASE-22464.branch-1.patch, HBASE-22464.v01.patch, 
> HBASE-22464.v02.patch, HBASE-22464.v03.patch, HBASE-22464.v04.patch, 
> HBASE-22464.v05.patch, HBASE-22464.v06.patch, HBASE-22464.v07.patch
>
>
> This Jira proposes to add the following two improvements:
>  # wget -N option for checking timestamp of downloaded RC files, if the local 
> copy of downloaded file is identical on the server, that file will be ignored.
>  # mvn -fn to never fail running the tests, previously with option -fae I 
> could not get the whole suite to run w/out failing.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #510: HBASE-22878 Show table throttle quotas in table jsp

2019-08-23 Thread GitBox
Apache-HBase commented on issue #510: HBASE-22878 Show table throttle quotas in 
table jsp
URL: https://github.com/apache/hbase/pull/510#issuecomment-524504302
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 67 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 34 | Maven dependency ordering for branch |
   | +1 | mvninstall | 356 | master passed |
   | +1 | compile | 78 | master passed |
   | +1 | checkstyle | 106 | master passed |
   | +1 | shadedjars | 278 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 61 | master passed |
   | 0 | spotbugs | 265 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 335 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 15 | Maven dependency ordering for patch |
   | +1 | mvninstall | 306 | the patch passed |
   | +1 | compile | 80 | the patch passed |
   | +1 | javac | 80 | the patch passed |
   | +1 | checkstyle | 107 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 310 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1063 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 59 | the patch passed |
   | +1 | findbugs | 340 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 96 | hbase-client in the patch passed. |
   | -1 | unit | 15859 | hbase-server in the patch failed. |
   | +1 | asflicense | 52 | The patch does not generate ASF License warnings. |
   | | | 20047 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
   |   | hadoop.hbase.master.TestAssignmentManagerMetrics |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/18/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/510 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 22d2162f3aca 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 
13:14:43 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-510/out/precommit/personality/provided.sh
 |
   | git revision | master / 2d4580106a |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/18/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/18/testReport/
 |
   | Max. process+thread count | 5117 (vs. ulimit of 1) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/18/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #519: HBASE-22744 Removed deprecated status and load classes in client module

2019-08-23 Thread GitBox
Apache-HBase commented on issue #519: HBASE-22744 Removed deprecated status and 
load classes in client module
URL: https://github.com/apache/hbase/pull/519#issuecomment-524504066
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 95 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 6 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 34 | Maven dependency ordering for branch |
   | +1 | mvninstall | 349 | master passed |
   | +1 | compile | 131 | master passed |
   | +1 | checkstyle | 157 | master passed |
   | +1 | shadedjars | 305 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 95 | master passed |
   | 0 | spotbugs | 276 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 435 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 15 | Maven dependency ordering for patch |
   | +1 | mvninstall | 332 | the patch passed |
   | +1 | compile | 149 | the patch passed |
   | +1 | javac | 149 | the patch passed |
   | +1 | checkstyle | 37 | hbase-client: The patch generated 0 new + 180 
unchanged - 3 fixed = 180 total (was 183) |
   | +1 | checkstyle | 12 | The patch passed checkstyle in hbase-zookeeper |
   | +1 | checkstyle | 90 | The patch passed checkstyle in hbase-server |
   | +1 | checkstyle | 19 | The patch passed checkstyle in hbase-rest |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 302 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1037 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 97 | the patch passed |
   | +1 | findbugs | 480 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 108 | hbase-client in the patch passed. |
   | +1 | unit | 49 | hbase-zookeeper in the patch passed. |
   | -1 | unit | 14436 | hbase-server in the patch failed. |
   | +1 | unit | 589 | hbase-rest in the patch passed. |
   | +1 | asflicense | 104 | The patch does not generate ASF License warnings. |
   | | | 19916 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-519/6/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/519 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 56958aec85ce 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 
18:22:20 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-519/out/precommit/personality/provided.sh
 |
   | git revision | master / 2d4580106a |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-519/6/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-519/6/testReport/
 |
   | Max. process+thread count | 4870 (vs. ulimit of 1) |
   | modules | C: hbase-client hbase-zookeeper hbase-server hbase-rest U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-519/6/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #530: HBASE-22806 Recreating a deleted column family brings back the delete…

2019-08-23 Thread GitBox
Apache-HBase commented on issue #530: HBASE-22806 Recreating a deleted column 
family brings back the delete…
URL: https://github.com/apache/hbase/pull/530#issuecomment-524503055
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 71 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 363 | master passed |
   | +1 | compile | 57 | master passed |
   | +1 | checkstyle | 74 | master passed |
   | +1 | shadedjars | 297 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 34 | master passed |
   | 0 | spotbugs | 258 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 249 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 306 | the patch passed |
   | +1 | compile | 57 | the patch passed |
   | +1 | javac | 57 | the patch passed |
   | +1 | checkstyle | 74 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 301 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1031 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 31 | the patch passed |
   | +1 | findbugs | 257 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 16147 | hbase-server in the patch failed. |
   | +1 | asflicense | 29 | The patch does not generate ASF License warnings. |
   | | | 19806 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.master.TestAssignmentManagerMetrics |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
   |   | hadoop.hbase.master.assignment.TestOpenRegionProcedureHang |
   |   | hadoop.hbase.replication.TestReplicationSmallTestsSync |
   |   | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/530 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 995b7b853279 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 
13:14:43 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-530/out/precommit/personality/provided.sh
 |
   | git revision | master / 2d4580106a |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/3/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/3/testReport/
 |
   | Max. process+thread count | 4932 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/3/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes…

2019-08-23 Thread GitBox
Apache-HBase commented on issue #446: HBASE-22781 optimize the test case 
TestStoreScanner.testScanSameTimes…
URL: https://github.com/apache/hbase/pull/446#issuecomment-524502245
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 91 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 373 | master passed |
   | +1 | compile | 62 | master passed |
   | +1 | checkstyle | 93 | master passed |
   | +1 | shadedjars | 325 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 40 | master passed |
   | 0 | spotbugs | 271 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 267 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 332 | the patch passed |
   | +1 | compile | 56 | the patch passed |
   | +1 | javac | 56 | the patch passed |
   | +1 | checkstyle | 87 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 301 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1027 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 35 | the patch passed |
   | +1 | findbugs | 270 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 14926 | hbase-server in the patch failed. |
   | +1 | asflicense | 25 | The patch does not generate ASF License warnings. |
   | | | 18711 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.client.TestMobSnapshotCloneIndependence |
   |   | hadoop.hbase.client.TestAsyncTableAdminApi |
   |   | hadoop.hbase.client.TestRestoreSnapshotFromClientClone |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/71/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/446 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux d8391e28cd40 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 
10:55:24 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-446/out/precommit/personality/provided.sh
 |
   | git revision | master / 2d4580106a |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/71/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/71/testReport/
 |
   | Max. process+thread count | 4742 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/71/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #520: HBASE-22766 Code Coverage Improvement: Create Unit Tests for ResultStatsUtil. Added unit tests for ResultStatsUtil to have 100 percent …

2019-08-23 Thread GitBox
Apache-HBase commented on issue #520: HBASE-22766 Code Coverage Improvement: 
Create Unit Tests for ResultStatsUtil. Added unit tests for ResultStatsUtil to 
have 100 percent …
URL: https://github.com/apache/hbase/pull/520#issuecomment-524502071
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 43 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 345 | master passed |
   | +1 | compile | 24 | master passed |
   | +1 | checkstyle | 31 | master passed |
   | +1 | shadedjars | 289 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 26 | master passed |
   | 0 | spotbugs | 76 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 74 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 323 | the patch passed |
   | +1 | compile | 26 | the patch passed |
   | +1 | javac | 26 | the patch passed |
   | +1 | checkstyle | 29 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 287 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 982 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 23 | the patch passed |
   | +1 | findbugs | 79 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 106 | hbase-client in the patch passed. |
   | +1 | asflicense | 11 | The patch does not generate ASF License warnings. |
   | | | 3078 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/8/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/520 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 6c5863bf22a0 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-520/out/precommit/personality/provided.sh
 |
   | git revision | master / 504fc52187 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/8/testReport/
 |
   | Max. process+thread count | 291 (vs. ulimit of 1) |
   | modules | C: hbase-client U: hbase-client |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/8/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] infraio commented on a change in pull request #498: HBASE-22819 Automatically migrate the rs group config for table after…

2019-08-23 Thread GitBox
infraio commented on a change in pull request #498: HBASE-22819 Automatically 
migrate the rs group config for table after…
URL: https://github.com/apache/hbase/pull/498#discussion_r317337542
 
 

 ##
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
 ##
 @@ -356,9 +388,90 @@ public synchronized void removeServers(Set 
servers) throws IOException
 return RSGroupInfoList;
   }
 
-  @Override
-  public void refresh() throws IOException {
-refresh(false);
+  private void migrate(Collection groupList) {
+TableDescriptors tds = masterServices.getTableDescriptors();
+for (RSGroupInfo groupInfo : groupList) {
+  if (groupInfo.getName().equals(RSGroupInfo.DEFAULT_GROUP)) {
+continue;
+  }
+  SortedSet failedTables = new TreeSet<>();
+  for (TableName tableName : groupInfo.getTables()) {
+LOG.info("Migrating {} in group {}", tableName, groupInfo.getName());
+TableDescriptor oldTd;
+try {
+  oldTd = tds.get(tableName);
+} catch (IOException e) {
+  LOG.warn("Failed to migrate {} in group {}", tableName, 
groupInfo.getName(), e);
+  failedTables.add(tableName);
+  continue;
+}
+if (oldTd == null) {
+  continue;
+}
+if (oldTd.getRegionServerGroup().isPresent()) {
+  // either we have already migrated it or that user has set the rs 
group using the new
+  // code which will set the group directly on table descriptor, skip.
+  LOG.debug("Skip migrating {} since it is already in group {}", 
tableName,
+oldTd.getRegionServerGroup().get());
+  continue;
+}
+TableDescriptor newTd = TableDescriptorBuilder.newBuilder(oldTd)
+  .setRegionServerGroup(groupInfo.getName()).build();
+// This is a bit tricky. Since we know that the region server group 
config in
+// TableDescriptor will only be used at master side, it is fine to 
just update the table
+// descriptor on file system and also the cache, without reopening all 
the regions. This
+// will be much faster than the normal modifyTable. And when 
upgrading, we will update
+// master first and then region server, so after all the region 
servers has been reopened,
+// the new TableDescriptor will be loaded.
+try {
+  tds.add(newTd);
+} catch (IOException e) {
+  LOG.warn("Failed to migrate {} in group {}", tableName, 
groupInfo.getName(), e);
+  failedTables.add(tableName);
+  continue;
+}
+  }
+  LOG.info("Done migrating {}, failed tables {}", groupInfo.getName(), 
failedTables);
+  synchronized (RSGroupInfoManagerImpl.this) {
+Map rsGroupMap = holder.groupName2Group;
+RSGroupInfo currentInfo = rsGroupMap.get(groupInfo.getName());
+if (currentInfo != null) {
+  RSGroupInfo newInfo =
+new RSGroupInfo(currentInfo.getName(), currentInfo.getServers(), 
failedTables);
+  Map newGroupMap = new HashMap<>(rsGroupMap);
+  newGroupMap.put(groupInfo.getName(), newInfo);
+  try {
+flushConfig(newGroupMap);
+  } catch (IOException e) {
+LOG.warn("Failed to persist rs group", e);
+  }
+}
+  }
+}
+  }
+
+  // Migrate the table rs group info from RSGroupInfo into the table descriptor
+  // Notice that we do not want to block the initialize so this will be done 
in background, and
+  // during the migrating, the rs group info maybe incomplete and cause region 
to be misplaced.
+  private void migrate() {
+Thread migrateThread = new Thread(MIGRATE_THREAD_NAME) {
+
+  @Override
+  public void run() {
+LOG.info("Start migrating table rs group config");
+while (!masterServices.isStopped()) {
+  Collection groups = holder.groupName2Group.values();
+  boolean hasTables = groups.stream().anyMatch(r -> 
!r.getTables().isEmpty());
 
 Review comment:
   When restart master again, how to avoid migrate again?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


  1   2   3   >