[jira] [Resolved] (HBASE-22798) Release 2.1.6
[ https://issues.apache.org/jira/browse/HBASE-22798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-22798. --- Resolution: Fixed All works are done. > Release 2.1.6 > - > > Key: HBASE-22798 > URL: https://issues.apache.org/jira/browse/HBASE-22798 > Project: HBase > Issue Type: Umbrella >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22964) Fix flaky TestClusterRestartFailover and TestClusterRestartFailoverSplitWithoutZk
[ https://issues.apache.org/jira/browse/HBASE-22964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22964: --- Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to branch-2.2, branch-2 and master. Thanks [~Apache9] for reviewing. > Fix flaky TestClusterRestartFailover and > TestClusterRestartFailoverSplitWithoutZk > - > > Key: HBASE-22964 > URL: https://issues.apache.org/jira/browse/HBASE-22964 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.2 > > Attachments: HBASE-22964.branch-2.2.001.patch, > HBASE-22964.branch-2.2.001.patch > > > The ut failed because serverNode is null. And I checked the failed log, the > SCP already finished when try to test. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22923) hbase:meta is assigned to localhost when we downgrade the hbase version
[ https://issues.apache.org/jira/browse/HBASE-22923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925357#comment-16925357 ] Anoop Sam John commented on HBASE-22923: bq.1.Down grade all servers in HBASE_META first Is this order imp? The versions in nodes of system group can be kept higher only while panning this upgrade/downgrade? Can u explain why this sequence was a must? > hbase:meta is assigned to localhost when we downgrade the hbase version > --- > > Key: HBASE-22923 > URL: https://issues.apache.org/jira/browse/HBASE-22923 > Project: HBase > Issue Type: Bug >Affects Versions: 1.4.8 >Reporter: wenbang >Priority: Major > > When we downgrade the hbase version(rsgroup enable), we found that the > hbase:meta table could not be assigned. > {code:java} > master.AssignmentManager: Failed assignment of hbase:meta,,1.1588230740 to > localhost,1,1, trying to assign elsewhere instead; try=1 of 10 > java.io.IOException: Call to localhost/127.0.0.1:1 failed on local exception: > org.apache.hadoop.hbase.ipc.FailedServerException: This server is in the > failed servers list: localhost/127.0.0.1:1 > {code} > hbase group list: > HBASE_META group(hbase:meta and other system tables) > default group > 1.Down grade all servers in HBASE_META first > 2.higher version servers is in default > 3.hbase:meta assigned to localhost > For system table, we assign them to a server with highest version. > AssignmentManager#getExcludedServersForSystemTable > But did not consider the rsgroup. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22964) Fix flaky TestClusterRestartFailover and TestClusterRestartFailoverSplitWithoutZk
[ https://issues.apache.org/jira/browse/HBASE-22964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925355#comment-16925355 ] HBase QA commented on HBASE-22964: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 45s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} | || || || || {color:brown} branch-2.2 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 5s{color} | {color:green} branch-2.2 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 56s{color} | {color:green} branch-2.2 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 21s{color} | {color:green} branch-2.2 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 22s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 23s{color} | {color:green} branch-2.2 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 34s{color} | {color:green} branch-2.2 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 9s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 7s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 15m 14s{color} | {color:green} Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green}156m 4s{color} | {color:green} hbase-server in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 33s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}206m 58s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/PreCommit-HBASE-Build/877/artifact/patchprocess/Dockerfile | | JIRA Issue | HBASE-22964 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12979805/HBASE-22964.branch-2.2.001.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f8dbee786257 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.2 / 9158a4ae90 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/877/testReport/ | | Max. process+thread count | 4798 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/877/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. > Fix
[jira] [Commented] (HBASE-22989) Missing null check for item2RegionMap during bulkload phase
[ https://issues.apache.org/jira/browse/HBASE-22989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925352#comment-16925352 ] Hudson commented on HBASE-22989: Results for branch master [build #1413 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1413/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/1413//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1413//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1413//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Missing null check for item2RegionMap during bulkload phase > --- > > Key: HBASE-22989 > URL: https://issues.apache.org/jira/browse/HBASE-22989 > Project: HBase > Issue Type: Bug > Components: tooling >Affects Versions: 3.0.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0 > > > During BulkLoad phase, Map is updated based on > loading groups atomically. null check for map.remove() in case the map is > null is missing. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22796) [HBCK2] Add fix of overlaps to fixMeta hbck Service
[ https://issues.apache.org/jira/browse/HBASE-22796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22796: -- Attachment: HBASE-22796.master.004.patch > [HBCK2] Add fix of overlaps to fixMeta hbck Service > --- > > Key: HBASE-22796 > URL: https://issues.apache.org/jira/browse/HBASE-22796 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: Sakthi >Priority: Major > Attachments: HBASE-22796.master.001.patch, > HBASE-22796.master.002.patch, HBASE-22796.master.003.patch, > HBASE-22796.master.004.patch > > > fixMeta currently does holes in meta only courtesy of HBASE-22771 which added > fixMeta to hbck Service; missing was fix of overlaps too. This JIRA is about > adding fix of overlaps to general fixMeta call. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22903) alter_status command is broken
[ https://issues.apache.org/jira/browse/HBASE-22903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22903: - Component/s: (was: Admin) metrics > alter_status command is broken > -- > > Key: HBASE-22903 > URL: https://issues.apache.org/jira/browse/HBASE-22903 > Project: HBase > Issue Type: Bug > Components: asyncclient, metrics, shell >Affects Versions: 3.0.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-22903.master.000.patch, > HBASE-22903.master.001.patch, HBASE-22903.master.002.patch, > HBASE-22903.master.005.patch, HBASE-22903.master.006.patch > > > This is applicable to master branch only: > {code:java} > > alter_status 't1' > ERROR: undefined method `getAlterStatus' for > # > {code} > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22900) No longer include multiple httpcore and httpclient versions in binary package
[ https://issues.apache.org/jira/browse/HBASE-22900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925329#comment-16925329 ] Hudson commented on HBASE-22900: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #638 (See [https://builds.apache.org/job/HBase-1.3-IT/638/]) HBASE-22900 Multiple httpcore and httpclient versions included in binary (busbey: rev 64c0ac5dd4e2dac664c58cbe309a9d8b4a69c4c9) * (edit) pom.xml > No longer include multiple httpcore and httpclient versions in binary package > - > > Key: HBASE-22900 > URL: https://issues.apache.org/jira/browse/HBASE-22900 > Project: HBase > Issue Type: Bug > Components: build, dependencies >Affects Versions: 1.3.5 >Reporter: Andrew Purtell >Assignee: Rabi Kumar K C >Priority: Minor > Fix For: 1.3.6, 1.4.11 > > > We are including multiple versions of httpcore and httpclient in the binary > package. > {noformat} > httpclient-4.1.2.jar > httpclient-4.2.5.jar > httpclient-4.4.1.jar > httpcore-4.1.2.jar > httpcore-4.2.4.jar > httpcore-4.4.1.jar > {noformat} -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22991) Release 1.4.11
[ https://issues.apache.org/jira/browse/HBASE-22991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925325#comment-16925325 ] Sean Busbey commented on HBASE-22991: - moved out or resolved things still targeting 1.4.11. > Release 1.4.11 > -- > > Key: HBASE-22991 > URL: https://issues.apache.org/jira/browse/HBASE-22991 > Project: HBase > Issue Type: Task > Components: community >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > Fix For: 1.4.11 > > Attachments: Flaky_20Test_20Report.zip > > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22900) No longer include multiple httpcore and httpclient versions in binary package
[ https://issues.apache.org/jira/browse/HBASE-22900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-22900: Component/s: dependencies build > No longer include multiple httpcore and httpclient versions in binary package > - > > Key: HBASE-22900 > URL: https://issues.apache.org/jira/browse/HBASE-22900 > Project: HBase > Issue Type: Bug > Components: build, dependencies >Affects Versions: 1.3.5 >Reporter: Andrew Purtell >Assignee: Rabi Kumar K C >Priority: Minor > Fix For: 1.3.6, 1.4.11 > > > We are including multiple versions of httpcore and httpclient in the binary > package. > {noformat} > httpclient-4.1.2.jar > httpclient-4.2.5.jar > httpclient-4.4.1.jar > httpcore-4.1.2.jar > httpcore-4.2.4.jar > httpcore-4.4.1.jar > {noformat} -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Resolved] (HBASE-22900) No longer include multiple httpcore and httpclient versions in binary package
[ https://issues.apache.org/jira/browse/HBASE-22900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey resolved HBASE-22900. - Release Note: only a single version of httpclient 4 and httpcore 4 are included in the binary tarball now. previously, multiple minor versions were included and which got used would depend on classpath ordering. Resolution: Fixed > No longer include multiple httpcore and httpclient versions in binary package > - > > Key: HBASE-22900 > URL: https://issues.apache.org/jira/browse/HBASE-22900 > Project: HBase > Issue Type: Bug >Affects Versions: 1.3.5 >Reporter: Andrew Purtell >Assignee: Rabi Kumar K C >Priority: Minor > Fix For: 1.3.6, 1.4.11 > > > We are including multiple versions of httpcore and httpclient in the binary > package. > {noformat} > httpclient-4.1.2.jar > httpclient-4.2.5.jar > httpclient-4.4.1.jar > httpcore-4.1.2.jar > httpcore-4.2.4.jar > httpcore-4.4.1.jar > {noformat} -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22900) No longer include multiple httpcore and httpclient versions in binary package
[ https://issues.apache.org/jira/browse/HBASE-22900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-22900: Summary: No longer include multiple httpcore and httpclient versions in binary package (was: Multiple httpcore and httpclient versions included in binary package (branch-1.3)) > No longer include multiple httpcore and httpclient versions in binary package > - > > Key: HBASE-22900 > URL: https://issues.apache.org/jira/browse/HBASE-22900 > Project: HBase > Issue Type: Bug >Affects Versions: 1.3.5 >Reporter: Andrew Purtell >Assignee: Rabi Kumar K C >Priority: Minor > Fix For: 1.3.6, 1.4.11 > > > We are including multiple versions of httpcore and httpclient in the binary > package. > {noformat} > httpclient-4.1.2.jar > httpclient-4.2.5.jar > httpclient-4.4.1.jar > httpcore-4.1.2.jar > httpcore-4.2.4.jar > httpcore-4.4.1.jar > {noformat} -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] busbey closed pull request #563: HBASE-22900.branch-1.3
busbey closed pull request #563: HBASE-22900.branch-1.3 URL: https://github.com/apache/hbase/pull/563 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #593: HBASE-22927 Upgrade Mockito version for jdk11
Apache9 commented on issue #593: HBASE-22927 Upgrade Mockito version for jdk11 URL: https://github.com/apache/hbase/pull/593#issuecomment-529279106 OK, seems good. Only one question, why not just upgrade to 2.28.2? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22859) [HBCK2] Fix the orphan regions on filesystem
[ https://issues.apache.org/jira/browse/HBASE-22859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925307#comment-16925307 ] HBase QA commented on HBASE-22859: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 4m 8s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange} 0m 0s{color} | {color:orange} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 6s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 56s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 50s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m 6s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 7m 39s{color} | {color:blue} branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m 52s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: . {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 55s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m 10s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 17s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 33s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 46s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m 46s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 33s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 6m 47s{color} | {color:blue} patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m 1s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 21m 18s{color} | {color:green} Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: . {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 0s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m 33s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}275m 54s{color} | {color:red} root in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 59s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}382m 58s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests |
[jira] [Commented] (HBASE-22992) Blog post for hbtop on hbase.apache.org
[ https://issues.apache.org/jira/browse/HBASE-22992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925297#comment-16925297 ] Toshihiro Suzuki commented on HBASE-22992: -- The README is already markdown: https://github.com/apache/hbase/blob/master/hbase-hbtop/README.md Are there anything I need to do here? > Blog post for hbtop on hbase.apache.org > --- > > Key: HBASE-22992 > URL: https://issues.apache.org/jira/browse/HBASE-22992 > Project: HBase > Issue Type: Sub-task >Reporter: Toshihiro Suzuki >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22992) Blog post for hbtop on hbase.apache.org
[ https://issues.apache.org/jira/browse/HBASE-22992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925294#comment-16925294 ] Toshihiro Suzuki commented on HBASE-22992: -- CC: [~stack] > Blog post for hbtop on hbase.apache.org > --- > > Key: HBASE-22992 > URL: https://issues.apache.org/jira/browse/HBASE-22992 > Project: HBase > Issue Type: Sub-task >Reporter: Toshihiro Suzuki >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (HBASE-22992) Blog post for hbtop on hbase.apache.org
Toshihiro Suzuki created HBASE-22992: Summary: Blog post for hbtop on hbase.apache.org Key: HBASE-22992 URL: https://issues.apache.org/jira/browse/HBASE-22992 Project: HBase Issue Type: Sub-task Reporter: Toshihiro Suzuki -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-11062) hbtop
[ https://issues.apache.org/jira/browse/HBASE-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925293#comment-16925293 ] Toshihiro Suzuki commented on HBASE-11062: -- Pushed the addendum to master, branch-2, branch-2.1 and branch-2.2. Closing this Jira. > hbtop > - > > Key: HBASE-11062 > URL: https://issues.apache.org/jira/browse/HBASE-11062 > Project: HBase > Issue Type: New Feature > Components: hbtop >Reporter: Andrew Purtell >Assignee: Toshihiro Suzuki >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > Attachments: HBASE-11062-master-addendum-v1.patch > > > A top-like monitor could be useful for testing, debugging, operations of > clusters of moderate size, and possibly for diagnosing issues in large > clusters. > Consider a curses interface like the one presented by atop > (http://www.atoptool.nl/images/screenshots/genericw.png) - with aggregate > metrics collected over a monitoring interval in the upper portion of the > pane, and a listing of discrete measurements sorted and filtered by various > criteria in the bottom part of the pane. One might imagine a cluster overview > with cluster aggregate metrics above and a list of regionservers sorted by > utilization below; and a regionserver view with process metrics above and a > list of metrics by operation type below, or a list of client connections, or > a list of threads, sorted by utilization, throughput, or latency. > Generically 'htop' is taken but would be distinctive in the HBase context, a > utility org.apache.hadoop.hbase.HTop > No need necessarily for a curses interface. Could be an external monitor with > a web front end as has been discussed before. I do like the idea of a process > that runs in a terminal because I interact with dev and test HBase clusters > exclusively by SSH. > UPDATE: > The tool name is changed from htop to hbtop. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-11062) hbtop
[ https://issues.apache.org/jira/browse/HBASE-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-11062: - Resolution: Fixed Status: Resolved (was: Patch Available) > hbtop > - > > Key: HBASE-11062 > URL: https://issues.apache.org/jira/browse/HBASE-11062 > Project: HBase > Issue Type: New Feature > Components: hbtop >Reporter: Andrew Purtell >Assignee: Toshihiro Suzuki >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > Attachments: HBASE-11062-master-addendum-v1.patch > > > A top-like monitor could be useful for testing, debugging, operations of > clusters of moderate size, and possibly for diagnosing issues in large > clusters. > Consider a curses interface like the one presented by atop > (http://www.atoptool.nl/images/screenshots/genericw.png) - with aggregate > metrics collected over a monitoring interval in the upper portion of the > pane, and a listing of discrete measurements sorted and filtered by various > criteria in the bottom part of the pane. One might imagine a cluster overview > with cluster aggregate metrics above and a list of regionservers sorted by > utilization below; and a regionserver view with process metrics above and a > list of metrics by operation type below, or a list of client connections, or > a list of threads, sorted by utilization, throughput, or latency. > Generically 'htop' is taken but would be distinctive in the HBase context, a > utility org.apache.hadoop.hbase.HTop > No need necessarily for a curses interface. Could be an external monitor with > a web front end as has been discussed before. I do like the idea of a process > that runs in a terminal because I interact with dev and test HBase clusters > exclusively by SSH. > UPDATE: > The tool name is changed from htop to hbtop. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22380) break circle replication when doing bulkload
[ https://issues.apache.org/jira/browse/HBASE-22380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-22380: Fix Version/s: (was: 1.4.11) 1.4.12 > break circle replication when doing bulkload > > > Key: HBASE-22380 > URL: https://issues.apache.org/jira/browse/HBASE-22380 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.5, 2.3.0, 2.1.5, 1.3.5 >Reporter: chenxu >Assignee: Wellington Chevreuil >Priority: Critical > Labels: bulkload > Fix For: 3.0.0, 1.5.0, 2.3.0, 2.1.7, 2.2.2, 1.4.12 > > > when enabled master-master bulkload replication, HFiles will be replicated > circularly between two clusters -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-11062) hbtop
[ https://issues.apache.org/jira/browse/HBASE-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925289#comment-16925289 ] Toshihiro Suzuki commented on HBASE-11062: -- [~Apache9] Thank you for reviewing. Will push the addendum to the branches. {quote} Make new issue for working on blog post. Can be subissue of this one. Write it up in markdown. I can push it or if we figure how to get you perms before then, you can (still trying to figure it... I thought PMC chair could but doesn't look like it). {quote} [~stack] Sure. Will make new issue for this as a sub-issue of this. Thanks. > hbtop > - > > Key: HBASE-11062 > URL: https://issues.apache.org/jira/browse/HBASE-11062 > Project: HBase > Issue Type: New Feature > Components: hbtop >Reporter: Andrew Purtell >Assignee: Toshihiro Suzuki >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > Attachments: HBASE-11062-master-addendum-v1.patch > > > A top-like monitor could be useful for testing, debugging, operations of > clusters of moderate size, and possibly for diagnosing issues in large > clusters. > Consider a curses interface like the one presented by atop > (http://www.atoptool.nl/images/screenshots/genericw.png) - with aggregate > metrics collected over a monitoring interval in the upper portion of the > pane, and a listing of discrete measurements sorted and filtered by various > criteria in the bottom part of the pane. One might imagine a cluster overview > with cluster aggregate metrics above and a list of regionservers sorted by > utilization below; and a regionserver view with process metrics above and a > list of metrics by operation type below, or a list of client connections, or > a list of threads, sorted by utilization, throughput, or latency. > Generically 'htop' is taken but would be distinctive in the HBase context, a > utility org.apache.hadoop.hbase.HTop > No need necessarily for a curses interface. Could be an external monitor with > a web front end as has been discussed before. I do like the idea of a process > that runs in a terminal because I interact with dev and test HBase clusters > exclusively by SSH. > UPDATE: > The tool name is changed from htop to hbtop. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22964) Fix flaky TestClusterRestartFailover and TestClusterRestartFailoverSplitWithoutZk
[ https://issues.apache.org/jira/browse/HBASE-22964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925287#comment-16925287 ] Guanghao Zhang commented on HBASE-22964: Retry. > Fix flaky TestClusterRestartFailover and > TestClusterRestartFailoverSplitWithoutZk > - > > Key: HBASE-22964 > URL: https://issues.apache.org/jira/browse/HBASE-22964 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.2 > > Attachments: HBASE-22964.branch-2.2.001.patch, > HBASE-22964.branch-2.2.001.patch > > > The ut failed because serverNode is null. And I checked the failed log, the > SCP already finished when try to test. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22964) Fix flaky TestClusterRestartFailover and TestClusterRestartFailoverSplitWithoutZk
[ https://issues.apache.org/jira/browse/HBASE-22964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22964: --- Attachment: HBASE-22964.branch-2.2.001.patch > Fix flaky TestClusterRestartFailover and > TestClusterRestartFailoverSplitWithoutZk > - > > Key: HBASE-22964 > URL: https://issues.apache.org/jira/browse/HBASE-22964 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.2 > > Attachments: HBASE-22964.branch-2.2.001.patch, > HBASE-22964.branch-2.2.001.patch > > > The ut failed because serverNode is null. And I checked the failed log, the > SCP already finished when try to test. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] busbey commented on issue #565: [HBASE-22874] Canary should not be IA.Public
busbey commented on issue #565: [HBASE-22874] Canary should not be IA.Public URL: https://github.com/apache/hbase/pull/565#issuecomment-529267084 I don't see anything in the git log that obviously relates to this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22874) Define a public interface for Canary and move existing implementation to LimitedPrivate
[ https://issues.apache.org/jira/browse/HBASE-22874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925286#comment-16925286 ] Sean Busbey commented on HBASE-22874: - updated title with the current consensus. brought it down to Critical since Canary is not currently IA.Public AFAIK. also moved it out of 1.4.11. > Define a public interface for Canary and move existing implementation to > LimitedPrivate > --- > > Key: HBASE-22874 > URL: https://issues.apache.org/jira/browse/HBASE-22874 > Project: HBase > Issue Type: Bug > Components: canary >Reporter: Duo Zhang >Assignee: Rushabh S Shah >Priority: Critical > Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 2.1.7, 2.2.2, 1.4.12 > > > It can be marked as IA.LimitedPrivate(TOOLS). -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22874) Define a public interface for Canary and move existing implementation to LimitedPrivate
[ https://issues.apache.org/jira/browse/HBASE-22874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-22874: Priority: Critical (was: Blocker) > Define a public interface for Canary and move existing implementation to > LimitedPrivate > --- > > Key: HBASE-22874 > URL: https://issues.apache.org/jira/browse/HBASE-22874 > Project: HBase > Issue Type: Bug > Components: canary >Reporter: Duo Zhang >Assignee: Rushabh S Shah >Priority: Critical > Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2 > > > It can be marked as IA.LimitedPrivate(TOOLS). -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22874) Define a public interface for Canary and move existing implementation to LimitedPrivate
[ https://issues.apache.org/jira/browse/HBASE-22874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-22874: Summary: Define a public interface for Canary and move existing implementation to LimitedPrivate (was: Canary should not be IA.Public) > Define a public interface for Canary and move existing implementation to > LimitedPrivate > --- > > Key: HBASE-22874 > URL: https://issues.apache.org/jira/browse/HBASE-22874 > Project: HBase > Issue Type: Bug > Components: canary >Reporter: Duo Zhang >Assignee: Rushabh S Shah >Priority: Blocker > Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2 > > > It can be marked as IA.LimitedPrivate(TOOLS). -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22874) Define a public interface for Canary and move existing implementation to LimitedPrivate
[ https://issues.apache.org/jira/browse/HBASE-22874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-22874: Fix Version/s: (was: 1.4.11) 1.4.12 > Define a public interface for Canary and move existing implementation to > LimitedPrivate > --- > > Key: HBASE-22874 > URL: https://issues.apache.org/jira/browse/HBASE-22874 > Project: HBase > Issue Type: Bug > Components: canary >Reporter: Duo Zhang >Assignee: Rushabh S Shah >Priority: Critical > Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 2.1.7, 2.2.2, 1.4.12 > > > It can be marked as IA.LimitedPrivate(TOOLS). -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-20993) [Auth] IPC client fallback to simple auth allowed doesn't work
[ https://issues.apache.org/jira/browse/HBASE-20993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-20993: Fix Version/s: (was: 1.4.11) > [Auth] IPC client fallback to simple auth allowed doesn't work > -- > > Key: HBASE-20993 > URL: https://issues.apache.org/jira/browse/HBASE-20993 > Project: HBase > Issue Type: Bug > Components: Client, IPC/RPC, security >Affects Versions: 1.2.6, 1.3.2, 1.2.7, 1.4.7 >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Critical > Fix For: 1.5.0, 1.3.6 > > Attachments: HBASE-20993.001.patch, > HBASE-20993.003.branch-1.flowchart.png, HBASE-20993.branch-1.002.patch, > HBASE-20993.branch-1.003.patch, HBASE-20993.branch-1.004.patch, > HBASE-20993.branch-1.005.patch, HBASE-20993.branch-1.006.patch, > HBASE-20993.branch-1.007.patch, HBASE-20993.branch-1.008.patch, > HBASE-20993.branch-1.009.patch, HBASE-20993.branch-1.009.patch, > HBASE-20993.branch-1.010.patch, HBASE-20993.branch-1.011.patch, > HBASE-20993.branch-1.012.patch, HBASE-20993.branch-1.013.patch, > HBASE-20993.branch-1.2.001.patch, HBASE-20993.branch-1.wip.002.patch, > HBASE-20993.branch-1.wip.patch, yetus-local-testpatch-output-009.txt > > > It is easily reproducible. > client's hbase-site.xml: hadoop.security.authentication:kerberos, > hbase.security.authentication:kerberos, > hbase.ipc.client.fallback-to-simple-auth-allowed:true, keytab and principal > are right set > A simple auth hbase cluster, a kerberized hbase client application. > application trying to r/w/c/d table will have following exception: > {code} > javax.security.sasl.SaslException: GSS initiate failed [Caused by > GSSException: No valid credentials provided (Mechanism level: Failed to find > any Kerberos tgt)] > at > com.sun.security.sasl.gsskerb.GssKrb5Client.evaluateChallenge(GssKrb5Client.java:211) > at > org.apache.hadoop.hbase.security.HBaseSaslRpcClient.saslConnect(HBaseSaslRpcClient.java:179) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.setupSaslConnection(RpcClientImpl.java:617) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.access$700(RpcClientImpl.java:162) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection$2.run(RpcClientImpl.java:743) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection$2.run(RpcClientImpl.java:740) > at java.security.AccessController.doPrivileged(Native Method) > at javax.security.auth.Subject.doAs(Subject.java:422) > at > org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1628) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.setupIOstreams(RpcClientImpl.java:740) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.writeRequest(RpcClientImpl.java:906) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.tracedWriteRequest(RpcClientImpl.java:873) > at > org.apache.hadoop.hbase.ipc.RpcClientImpl.call(RpcClientImpl.java:1241) > at > org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:227) > at > org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:336) > at > org.apache.hadoop.hbase.protobuf.generated.MasterProtos$MasterService$BlockingStub.isMasterRunning(MasterProtos.java:58383) > at > org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$MasterServiceStubMaker.isMasterRunning(ConnectionManager.java:1592) > at > org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$StubMaker.makeStubNoRetries(ConnectionManager.java:1530) > at > org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$StubMaker.makeStub(ConnectionManager.java:1552) > at > org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$MasterServiceStubMaker.makeStub(ConnectionManager.java:1581) > at > org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.getKeepAliveMasterService(ConnectionManager.java:1738) > at > org.apache.hadoop.hbase.client.MasterCallable.prepare(MasterCallable.java:38) > at > org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:134) > at > org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:4297) > at > org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:4289) > at > org.apache.hadoop.hbase.client.HBaseAdmin.createTableAsyncV2(HBaseAdmin.java:753) > at > org.apache.hadoop.hbase.client.HBaseAdmin.createTable(HBaseAdmin.java:674) > at >
[jira] [Updated] (HBASE-21903) Backport major compaction tool HBASE-19528 from to 1.4 and 1.3
[ https://issues.apache.org/jira/browse/HBASE-21903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-21903: Fix Version/s: (was: 1.4.11) 1.4.12 > Backport major compaction tool HBASE-19528 from to 1.4 and 1.3 > -- > > Key: HBASE-21903 > URL: https://issues.apache.org/jira/browse/HBASE-21903 > Project: HBase > Issue Type: Task > Components: Client, Compaction, tooling >Affects Versions: 1.3.3, 1.4.9 >Reporter: Thiruvel Thirumoolan >Assignee: Thiruvel Thirumoolan >Priority: Major > Fix For: 1.3.6, 1.4.12 > > Attachments: HBASE-21903-branch-1.3-addendum.patch > > > Our internal deployments are based on branch-1.3. We will be using the major > compaction tool HBASE-19528 from [~churromorales] and the enhancements on top > of it HBASE-21883 on our 1.3 clusters. I would like to backport HBASE-19528 > to 1.3 and hence 1.4 as well. Since its a standalone tool without any other > dependency or code changes, I believe that should be ok. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22991) Release 1.4.11
[ https://issues.apache.org/jira/browse/HBASE-22991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925283#comment-16925283 ] Sean Busbey commented on HBASE-22991: - attaching current flaky report. looks okay. {{TestSnapshotFromMaster}} shows a 25% failure rate, but it looks like master not starting up in time for the test. > Release 1.4.11 > -- > > Key: HBASE-22991 > URL: https://issues.apache.org/jira/browse/HBASE-22991 > Project: HBase > Issue Type: Task > Components: community >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > Fix For: 1.4.11 > > Attachments: Flaky_20Test_20Report.zip > > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22991) Release 1.4.11
[ https://issues.apache.org/jira/browse/HBASE-22991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-22991: Attachment: Flaky_20Test_20Report.zip > Release 1.4.11 > -- > > Key: HBASE-22991 > URL: https://issues.apache.org/jira/browse/HBASE-22991 > Project: HBase > Issue Type: Task > Components: community >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > Fix For: 1.4.11 > > Attachments: Flaky_20Test_20Report.zip > > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22991) Release 1.4.11
[ https://issues.apache.org/jira/browse/HBASE-22991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925282#comment-16925282 ] Sean Busbey commented on HBASE-22991: - looks like 1.4.12 is already in jira. doing a pass of issues still in 1.4.11 now. > Release 1.4.11 > -- > > Key: HBASE-22991 > URL: https://issues.apache.org/jira/browse/HBASE-22991 > Project: HBase > Issue Type: Task > Components: community >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > Fix For: 1.4.11 > > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work started] (HBASE-22991) Release 1.4.11
[ https://issues.apache.org/jira/browse/HBASE-22991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-22991 started by Sean Busbey. --- > Release 1.4.11 > -- > > Key: HBASE-22991 > URL: https://issues.apache.org/jira/browse/HBASE-22991 > Project: HBase > Issue Type: Task > Components: community >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > Fix For: 1.4.11 > > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (HBASE-22991) Release 1.4.11
Sean Busbey created HBASE-22991: --- Summary: Release 1.4.11 Key: HBASE-22991 URL: https://issues.apache.org/jira/browse/HBASE-22991 Project: HBase Issue Type: Task Components: community Reporter: Sean Busbey Assignee: Sean Busbey Fix For: 1.4.11 -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22989) Missing null check for item2RegionMap during bulkload phase
[ https://issues.apache.org/jira/browse/HBASE-22989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22989: -- Component/s: tooling > Missing null check for item2RegionMap during bulkload phase > --- > > Key: HBASE-22989 > URL: https://issues.apache.org/jira/browse/HBASE-22989 > Project: HBase > Issue Type: Bug > Components: tooling >Affects Versions: 3.0.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0 > > > During BulkLoad phase, Map is updated based on > loading groups atomically. null check for map.remove() in case the map is > null is missing. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22989) Missing null check for item2RegionMap during bulkload phase
[ https://issues.apache.org/jira/browse/HBASE-22989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22989: -- Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to master. Thanks [~vjasani] for contributing. > Missing null check for item2RegionMap during bulkload phase > --- > > Key: HBASE-22989 > URL: https://issues.apache.org/jira/browse/HBASE-22989 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0 > > > During BulkLoad phase, Map is updated based on > loading groups atomically. null check for map.remove() in case the map is > null is missing. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] Apache9 merged pull request #596: HBASE-22989 : null check for item2RegionMap while removing LoadQueueItem
Apache9 merged pull request #596: HBASE-22989 : null check for item2RegionMap while removing LoadQueueItem URL: https://github.com/apache/hbase/pull/596 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-22990) Parallelize listing phase from beginning of LoadIncrementalHFiles
Lavinia-Stefania Sirbu created HBASE-22990: -- Summary: Parallelize listing phase from beginning of LoadIncrementalHFiles Key: HBASE-22990 URL: https://issues.apache.org/jira/browse/HBASE-22990 Project: HBase Issue Type: Improvement Reporter: Lavinia-Stefania Sirbu Assignee: Lavinia-Stefania Sirbu -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22796) [HBCK2] Add fix of overlaps to fixMeta hbck Service
[ https://issues.apache.org/jira/browse/HBASE-22796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925260#comment-16925260 ] HBase QA commented on HBASE-22796: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 41s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 48s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 14s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 41s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 25s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 21s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 54s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 17s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 57s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 16s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 12s{color} | {color:red} hbase-server: The patch generated 6 new + 6 unchanged - 0 fixed = 12 total (was 6) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 33s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 15m 6s{color} | {color:green} Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 47s{color} | {color:green} hbase-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 31m 0s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 29s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 90m 35s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.master.TestMetaFixerNoCluster | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/PreCommit-HBASE-Build/876/artifact/patchprocess/Dockerfile | | JIRA Issue | HBASE-22796 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12979789/HBASE-22796.master.003.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 1e6f485f6952 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 693f201f3d |
[jira] [Updated] (HBASE-22796) [HBCK2] Add fix of overlaps to fixMeta hbck Service
[ https://issues.apache.org/jira/browse/HBASE-22796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22796: -- Attachment: HBASE-22796.master.003.patch > [HBCK2] Add fix of overlaps to fixMeta hbck Service > --- > > Key: HBASE-22796 > URL: https://issues.apache.org/jira/browse/HBASE-22796 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: Sakthi >Priority: Major > Attachments: HBASE-22796.master.001.patch, > HBASE-22796.master.002.patch, HBASE-22796.master.003.patch > > > fixMeta currently does holes in meta only courtesy of HBASE-22771 which added > fixMeta to hbck Service; missing was fix of overlaps too. This JIRA is about > adding fix of overlaps to general fixMeta call. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22796) [HBCK2] Add fix of overlaps to fixMeta hbck Service
[ https://issues.apache.org/jira/browse/HBASE-22796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925255#comment-16925255 ] HBase QA commented on HBASE-22796: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 42s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 1s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 29s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 56s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 16s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 40s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 28s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 18s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 17s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 17s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 12s{color} | {color:red} hbase-server: The patch generated 7 new + 6 unchanged - 0 fixed = 13 total (was 6) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 29s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 15m 15s{color} | {color:green} Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 38s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 48s{color} | {color:green} hbase-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 30m 8s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 29s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 90m 22s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.master.TestMetaFixerNoCluster | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/PreCommit-HBASE-Build/874/artifact/patchprocess/Dockerfile | | JIRA Issue | HBASE-22796 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12979786/HBASE-22796.master.002.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f6d277f41bcc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 693f201f3d |
[jira] [Commented] (HBASE-22963) Netty ByteBuf leak in rpc client implementation
[ https://issues.apache.org/jira/browse/HBASE-22963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925253#comment-16925253 ] Hudson commented on HBASE-22963: Results for branch branch-2 [build #2238 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2238/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2238//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2238//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2238//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Netty ByteBuf leak in rpc client implementation > --- > > Key: HBASE-22963 > URL: https://issues.apache.org/jira/browse/HBASE-22963 > Project: HBase > Issue Type: Bug > Components: rpc >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > > {noformat} > 2019-08-31 21:48:27,067 ERROR [RS-EventLoopGroup-6-3] > util.ResourceLeakDetector(317): LEAK: ByteBuf.release() was not called before > it's garbage-collected. See > http://netty.io/wiki/reference-counted-objects.html for more information. > Recent access records: > Created at: > > org.apache.hbase.thirdparty.io.netty.buffer.UnpooledByteBufAllocator.newDirectBuffer(UnpooledByteBufAllocator.java:96) > > org.apache.hbase.thirdparty.io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:187) > > org.apache.hbase.thirdparty.io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:178) > > org.apache.hbase.thirdparty.io.netty.buffer.Unpooled.directBuffer(Unpooled.java:125) > > org.apache.hadoop.hbase.ipc.NettyRpcConnection.(NettyRpcConnection.java:96) > > org.apache.hadoop.hbase.ipc.NettyRpcClient.createConnection(NettyRpcClient.java:74) > > org.apache.hadoop.hbase.ipc.NettyRpcClient.createConnection(NettyRpcClient.java:40) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient.getConnection(AbstractRpcClient.java:364) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient.callMethod(AbstractRpcClient.java:433) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$300(AbstractRpcClient.java:97) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient$RpcChannelImplementation.callMethod(AbstractRpcClient.java:605) > > org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$Stub.scan(ClientProtos.java:42345) > > org.apache.hadoop.hbase.client.AsyncClientScanner.callOpenScanner(AsyncClientScanner.java:152) > > org.apache.hadoop.hbase.client.AsyncSingleRequestRpcRetryingCaller.call(AsyncSingleRequestRpcRetryingCaller.java:82) > > org.apache.hadoop.hbase.client.AsyncSingleRequestRpcRetryingCaller.lambda$doCall$7(AsyncSingleRequestRpcRetryingCaller.java:115) > > org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) > > java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) > > java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) > > java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) > > java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) > > org.apache.hadoop.hbase.client.AsyncRegionLocator.lambda$getRegionLocation$3(AsyncRegionLocator.java:124) > > org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) > > java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) > > java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) > > java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) > > java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) > > org.apache.hadoop.hbase.client.ConnectionUtils.lambda$getOrFetch$6(ConnectionUtils.java:573) > > org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) > > java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) > >
[jira] [Commented] (HBASE-11062) hbtop
[ https://issues.apache.org/jira/browse/HBASE-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925249#comment-16925249 ] stack commented on HBASE-11062: --- [~brfrn169] Make new issue for working on blog post. Can be subissue of this one. Write it up in markdown. I can push it or if we figure how to get you perms before then, you can (still trying to figure it... I thought PMC chair could but doesn't look like it). Thanks. > hbtop > - > > Key: HBASE-11062 > URL: https://issues.apache.org/jira/browse/HBASE-11062 > Project: HBase > Issue Type: New Feature > Components: hbtop >Reporter: Andrew Purtell >Assignee: Toshihiro Suzuki >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > Attachments: HBASE-11062-master-addendum-v1.patch > > > A top-like monitor could be useful for testing, debugging, operations of > clusters of moderate size, and possibly for diagnosing issues in large > clusters. > Consider a curses interface like the one presented by atop > (http://www.atoptool.nl/images/screenshots/genericw.png) - with aggregate > metrics collected over a monitoring interval in the upper portion of the > pane, and a listing of discrete measurements sorted and filtered by various > criteria in the bottom part of the pane. One might imagine a cluster overview > with cluster aggregate metrics above and a list of regionservers sorted by > utilization below; and a regionserver view with process metrics above and a > list of metrics by operation type below, or a list of client connections, or > a list of threads, sorted by utilization, throughput, or latency. > Generically 'htop' is taken but would be distinctive in the HBase context, a > utility org.apache.hadoop.hbase.HTop > No need necessarily for a curses interface. Could be an external monitor with > a web front end as has been discussed before. I do like the idea of a process > that runs in a terminal because I interact with dev and test HBase clusters > exclusively by SSH. > UPDATE: > The tool name is changed from htop to hbtop. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22963) Netty ByteBuf leak in rpc client implementation
[ https://issues.apache.org/jira/browse/HBASE-22963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925246#comment-16925246 ] Hudson commented on HBASE-22963: Results for branch branch-2.2 [build #585 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/585/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/585//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/585//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/585//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Netty ByteBuf leak in rpc client implementation > --- > > Key: HBASE-22963 > URL: https://issues.apache.org/jira/browse/HBASE-22963 > Project: HBase > Issue Type: Bug > Components: rpc >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > > {noformat} > 2019-08-31 21:48:27,067 ERROR [RS-EventLoopGroup-6-3] > util.ResourceLeakDetector(317): LEAK: ByteBuf.release() was not called before > it's garbage-collected. See > http://netty.io/wiki/reference-counted-objects.html for more information. > Recent access records: > Created at: > > org.apache.hbase.thirdparty.io.netty.buffer.UnpooledByteBufAllocator.newDirectBuffer(UnpooledByteBufAllocator.java:96) > > org.apache.hbase.thirdparty.io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:187) > > org.apache.hbase.thirdparty.io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:178) > > org.apache.hbase.thirdparty.io.netty.buffer.Unpooled.directBuffer(Unpooled.java:125) > > org.apache.hadoop.hbase.ipc.NettyRpcConnection.(NettyRpcConnection.java:96) > > org.apache.hadoop.hbase.ipc.NettyRpcClient.createConnection(NettyRpcClient.java:74) > > org.apache.hadoop.hbase.ipc.NettyRpcClient.createConnection(NettyRpcClient.java:40) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient.getConnection(AbstractRpcClient.java:364) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient.callMethod(AbstractRpcClient.java:433) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$300(AbstractRpcClient.java:97) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient$RpcChannelImplementation.callMethod(AbstractRpcClient.java:605) > > org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$Stub.scan(ClientProtos.java:42345) > > org.apache.hadoop.hbase.client.AsyncClientScanner.callOpenScanner(AsyncClientScanner.java:152) > > org.apache.hadoop.hbase.client.AsyncSingleRequestRpcRetryingCaller.call(AsyncSingleRequestRpcRetryingCaller.java:82) > > org.apache.hadoop.hbase.client.AsyncSingleRequestRpcRetryingCaller.lambda$doCall$7(AsyncSingleRequestRpcRetryingCaller.java:115) > > org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) > > java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) > > java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) > > java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) > > java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) > > org.apache.hadoop.hbase.client.AsyncRegionLocator.lambda$getRegionLocation$3(AsyncRegionLocator.java:124) > > org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) > > java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) > > java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) > > java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) > > java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) > > org.apache.hadoop.hbase.client.ConnectionUtils.lambda$getOrFetch$6(ConnectionUtils.java:573) > > org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) > > java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) > >
[jira] [Commented] (HBASE-22963) Netty ByteBuf leak in rpc client implementation
[ https://issues.apache.org/jira/browse/HBASE-22963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925245#comment-16925245 ] Hudson commented on HBASE-22963: Results for branch branch-2.1 [build #1574 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1574/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1574//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1574//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1574//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Netty ByteBuf leak in rpc client implementation > --- > > Key: HBASE-22963 > URL: https://issues.apache.org/jira/browse/HBASE-22963 > Project: HBase > Issue Type: Bug > Components: rpc >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > > {noformat} > 2019-08-31 21:48:27,067 ERROR [RS-EventLoopGroup-6-3] > util.ResourceLeakDetector(317): LEAK: ByteBuf.release() was not called before > it's garbage-collected. See > http://netty.io/wiki/reference-counted-objects.html for more information. > Recent access records: > Created at: > > org.apache.hbase.thirdparty.io.netty.buffer.UnpooledByteBufAllocator.newDirectBuffer(UnpooledByteBufAllocator.java:96) > > org.apache.hbase.thirdparty.io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:187) > > org.apache.hbase.thirdparty.io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:178) > > org.apache.hbase.thirdparty.io.netty.buffer.Unpooled.directBuffer(Unpooled.java:125) > > org.apache.hadoop.hbase.ipc.NettyRpcConnection.(NettyRpcConnection.java:96) > > org.apache.hadoop.hbase.ipc.NettyRpcClient.createConnection(NettyRpcClient.java:74) > > org.apache.hadoop.hbase.ipc.NettyRpcClient.createConnection(NettyRpcClient.java:40) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient.getConnection(AbstractRpcClient.java:364) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient.callMethod(AbstractRpcClient.java:433) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$300(AbstractRpcClient.java:97) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient$RpcChannelImplementation.callMethod(AbstractRpcClient.java:605) > > org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$Stub.scan(ClientProtos.java:42345) > > org.apache.hadoop.hbase.client.AsyncClientScanner.callOpenScanner(AsyncClientScanner.java:152) > > org.apache.hadoop.hbase.client.AsyncSingleRequestRpcRetryingCaller.call(AsyncSingleRequestRpcRetryingCaller.java:82) > > org.apache.hadoop.hbase.client.AsyncSingleRequestRpcRetryingCaller.lambda$doCall$7(AsyncSingleRequestRpcRetryingCaller.java:115) > > org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) > > java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) > > java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) > > java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) > > java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) > > org.apache.hadoop.hbase.client.AsyncRegionLocator.lambda$getRegionLocation$3(AsyncRegionLocator.java:124) > > org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) > > java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) > > java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) > > java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) > > java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) > > org.apache.hadoop.hbase.client.ConnectionUtils.lambda$getOrFetch$6(ConnectionUtils.java:573) > > org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) > > java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) > >
[jira] [Commented] (HBASE-22859) [HBCK2] Fix the orphan regions on filesystem
[ https://issues.apache.org/jira/browse/HBASE-22859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925241#comment-16925241 ] stack commented on HBASE-22859: --- .004 addresses issue found by [~psomogyi] (thanks) > [HBCK2] Fix the orphan regions on filesystem > > > Key: HBASE-22859 > URL: https://issues.apache.org/jira/browse/HBASE-22859 > Project: HBase > Issue Type: Sub-task > Components: documentation, hbck2 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > Attachments: HBASE-22859.master.001.patch > > > Plan to add this feature to HBCK2 tool firstly. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22859) [HBCK2] Fix the orphan regions on filesystem
[ https://issues.apache.org/jira/browse/HBASE-22859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22859: -- Attachment: HBASE-22859.master.001.patch > [HBCK2] Fix the orphan regions on filesystem > > > Key: HBASE-22859 > URL: https://issues.apache.org/jira/browse/HBASE-22859 > Project: HBase > Issue Type: Sub-task > Components: documentation, hbck2 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > Attachments: HBASE-22859.master.001.patch > > > Plan to add this feature to HBCK2 tool firstly. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22859) [HBCK2] Fix the orphan regions on filesystem
[ https://issues.apache.org/jira/browse/HBASE-22859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22859: -- Attachment: (was: HBASE-22859.master.003.patch) > [HBCK2] Fix the orphan regions on filesystem > > > Key: HBASE-22859 > URL: https://issues.apache.org/jira/browse/HBASE-22859 > Project: HBase > Issue Type: Sub-task > Components: documentation, hbck2 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > > Plan to add this feature to HBCK2 tool firstly. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22859) [HBCK2] Fix the orphan regions on filesystem
[ https://issues.apache.org/jira/browse/HBASE-22859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22859: -- Attachment: (was: HBASE-22859.master.001.patch) > [HBCK2] Fix the orphan regions on filesystem > > > Key: HBASE-22859 > URL: https://issues.apache.org/jira/browse/HBASE-22859 > Project: HBase > Issue Type: Sub-task > Components: documentation, hbck2 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > > Plan to add this feature to HBCK2 tool firstly. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22859) [HBCK2] Fix the orphan regions on filesystem
[ https://issues.apache.org/jira/browse/HBASE-22859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22859: -- Attachment: (was: HBASE-22859.master.002.patch) > [HBCK2] Fix the orphan regions on filesystem > > > Key: HBASE-22859 > URL: https://issues.apache.org/jira/browse/HBASE-22859 > Project: HBase > Issue Type: Sub-task > Components: documentation, hbck2 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > > Plan to add this feature to HBCK2 tool firstly. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22796) [HBCK2] Add fix of overlaps to fixMeta hbck Service
[ https://issues.apache.org/jira/browse/HBASE-22796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22796: -- Status: Patch Available (was: Open) > [HBCK2] Add fix of overlaps to fixMeta hbck Service > --- > > Key: HBASE-22796 > URL: https://issues.apache.org/jira/browse/HBASE-22796 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: Sakthi >Priority: Major > Attachments: HBASE-22796.master.001.patch, > HBASE-22796.master.002.patch > > > fixMeta currently does holes in meta only courtesy of HBASE-22771 which added > fixMeta to hbck Service; missing was fix of overlaps too. This JIRA is about > adding fix of overlaps to general fixMeta call. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22796) [HBCK2] Add fix of overlaps to fixMeta hbck Service
[ https://issues.apache.org/jira/browse/HBASE-22796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925239#comment-16925239 ] stack commented on HBASE-22796: --- .002 is better; more tests found a few bugs and more interesting scenarios. > [HBCK2] Add fix of overlaps to fixMeta hbck Service > --- > > Key: HBASE-22796 > URL: https://issues.apache.org/jira/browse/HBASE-22796 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: Sakthi >Priority: Major > Attachments: HBASE-22796.master.001.patch, > HBASE-22796.master.002.patch > > > fixMeta currently does holes in meta only courtesy of HBASE-22771 which added > fixMeta to hbck Service; missing was fix of overlaps too. This JIRA is about > adding fix of overlaps to general fixMeta call. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22796) [HBCK2] Add fix of overlaps to fixMeta hbck Service
[ https://issues.apache.org/jira/browse/HBASE-22796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22796: -- Attachment: HBASE-22796.master.002.patch > [HBCK2] Add fix of overlaps to fixMeta hbck Service > --- > > Key: HBASE-22796 > URL: https://issues.apache.org/jira/browse/HBASE-22796 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: Sakthi >Priority: Major > Attachments: HBASE-22796.master.001.patch, > HBASE-22796.master.002.patch > > > fixMeta currently does holes in meta only courtesy of HBASE-22771 which added > fixMeta to hbck Service; missing was fix of overlaps too. This JIRA is about > adding fix of overlaps to general fixMeta call. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22618) Provide a way to have Heterogeneous deployment
[ https://issues.apache.org/jira/browse/HBASE-22618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925235#comment-16925235 ] Pierre Zemb commented on HBASE-22618: - Yes I can do that! How can I provide you some Release Notes? > Provide a way to have Heterogeneous deployment > -- > > Key: HBASE-22618 > URL: https://issues.apache.org/jira/browse/HBASE-22618 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0, 2.2.0, 2.2.1, 2.1.6, 1.4.11, 2.1.7 >Reporter: Pierre Zemb >Assignee: Pierre Zemb >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0 > > Attachments: HBASE-22618.branch-1.001.patch, > HBASE-22618.branch-1.002.patch, HBASE-22618.branch-2.001.patch, > HBASE-22618.master.001.patch > > > Hi, > We wouls like to open the discussion about bringing the possibility to have > regions deployed on {color:#22}Heterogeneous deployment{color}, i.e Hbase > cluster running different kind of hardware. > h2. Why? > * Cloud deployments means that we may not be able to have the same hardware > throughout the years > * Some tables may need special requirements such as SSD whereas others > should be using hard-drives > * {color:#22} {color}*in our usecase*{color:#22}(single table, > dedicated HBase and Hadoop tuned for our usecase, good key > distribution){color}*, the number of regions per RS was the real limit for > us*{color:#22}.{color} > h2. Our usecase > We found out that *in our usecase*(single table, dedicated HBase and Hadoop > tuned for our usecase, good key distribution)*, the number of regions per RS > was the real limit for us*. > Over the years, due to historical reasons and also the need to benchmark new > machines, we ended-up with differents groups of hardware: some servers can > handle only 180 regions, whereas the biggest can handle more than 900. > Because of such a difference, we had to disable the LoadBalancing to avoid > the {{roundRobinAssigmnent}}. We developed some internal tooling which are > responsible for load balancing regions across RegionServers. That was 1.5 > year ago. > h2. Our Proof-of-concept > We did work on a Proof-of-concept > [here|https://github.com/PierreZ/hbase/blob/dev/hbase14/balancer/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/HeterogeneousBalancer.java], > and some early tests > [here|https://github.com/PierreZ/hbase/blob/dev/hbase14/balancer/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/HeterogeneousBalancer.java], > > [here|https://github.com/PierreZ/hbase/blob/dev/hbase14/balancer/hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestHeterogeneousBalancerBalance.java], > and > [here|https://github.com/PierreZ/hbase/blob/dev/hbase14/balancer/hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestHeterogeneousBalancerRules.java]. > We wrote the balancer for our use-case, which means that: > * there is one table > * there is no region-replica > * good key dispersion > * there is no regions on master > A rule file is loaded before balancing. It contains lines of rules. A rule is > composed of a regexp for hostname, and a limit. For example, we could have: > > {quote}rs[0-9] 200 > rs1[0-9] 50 > {quote} > > RegionServers with hostname matching the first rules will have a limit of > 200, and the others 50. If there's no match, a default is set. > Thanks to the rule, we have two informations: the max number of regions for > this cluster, and the rules for each servers. {{HeterogeneousBalancer}} will > try to balance regions according to their capacity. > Let's take an example. Let's say that we have 20 RS: > * 10 RS, named through {{rs0}} to {{rs9}} loaded with 60 regions each, and > each can handle 200 regions. > * 10 RS, named through {{rs10}} to {{rs19}} loaded with 60 regions each, and > each can support 50 regions. > Based on the following rules: > > {quote}rs[0-9] 200 > rs1[0-9] 50 > {quote} > > The second group is overloaded, whereas the first group has plenty of space. > We know that we can handle at maximum *2500 regions* (200*10 + 50*10) and we > have currently *1200 regions* (60*20). {{HeterogeneousBalancer}} will > understand that the cluster is *full at 48.0%* (1200/2500). Based on this > information, we will then *try to put all the RegionServers to ~48% of load > according to the rules.* In this case, it will move regions from the second > group to the first. > The balancer will: > * compute how many regions needs to be moved. In our example, by moving 36 > regions on rs10, we could go from 120.0% to 46.0% > * select regions with lowest data-locality > * try to find an appropriate RS for the region. We will take the lowest > available RS. > h2. Other implementations and ideas >
[GitHub] [hbase] Apache-HBase commented on issue #594: HBASE-8458 Support for batch version of checkAndPut() and checkAndDelete()
Apache-HBase commented on issue #594: HBASE-8458 Support for batch version of checkAndPut() and checkAndDelete() URL: https://github.com/apache/hbase/pull/594#issuecomment-529231248 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 1s | No case conflicting files found. | | :blue_heart: | prototool | 0m 0s | prototool was not available. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ branch-2 Compile Tests _ | | :blue_heart: | mvndep | 0m 15s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 5m 57s | branch-2 passed | | :green_heart: | compile | 2m 1s | branch-2 passed | | :green_heart: | checkstyle | 2m 18s | branch-2 passed | | :green_heart: | shadedjars | 4m 11s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 1m 17s | branch-2 passed | | :blue_heart: | spotbugs | 3m 9s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 6m 55s | branch-2 passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 15s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 5m 0s | the patch passed | | :green_heart: | compile | 2m 3s | the patch passed | | :green_heart: | cc | 2m 3s | the patch passed | | :green_heart: | javac | 2m 3s | the patch passed | | :green_heart: | checkstyle | 2m 20s | the patch passed | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 4m 21s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 15m 47s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | hbaseprotoc | 1m 55s | the patch passed | | :green_heart: | javadoc | 1m 14s | the patch passed | | :green_heart: | findbugs | 7m 45s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 0m 41s | hbase-protocol-shaded in the patch passed. | | :green_heart: | unit | 3m 39s | hbase-client in the patch passed. | | :broken_heart: | unit | 176m 44s | hbase-server in the patch failed. | | :green_heart: | asflicense | 1m 30s | The patch does not generate ASF License warnings. | | | | 253m 51s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.regionserver.TestWALEntryStream | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-594/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/594 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool | | uname | Linux ef30042b166f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-594/out/precommit/personality/provided.sh | | git revision | branch-2 / 1568e05507 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-594/3/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-594/3/testReport/ | | Max. process+thread count | 4796 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-594/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22963) Netty ByteBuf leak in rpc client implementation
[ https://issues.apache.org/jira/browse/HBASE-22963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925224#comment-16925224 ] Hudson commented on HBASE-22963: Results for branch master [build #1412 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1412/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/1412//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1412//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1412//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Netty ByteBuf leak in rpc client implementation > --- > > Key: HBASE-22963 > URL: https://issues.apache.org/jira/browse/HBASE-22963 > Project: HBase > Issue Type: Bug > Components: rpc >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > > {noformat} > 2019-08-31 21:48:27,067 ERROR [RS-EventLoopGroup-6-3] > util.ResourceLeakDetector(317): LEAK: ByteBuf.release() was not called before > it's garbage-collected. See > http://netty.io/wiki/reference-counted-objects.html for more information. > Recent access records: > Created at: > > org.apache.hbase.thirdparty.io.netty.buffer.UnpooledByteBufAllocator.newDirectBuffer(UnpooledByteBufAllocator.java:96) > > org.apache.hbase.thirdparty.io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:187) > > org.apache.hbase.thirdparty.io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:178) > > org.apache.hbase.thirdparty.io.netty.buffer.Unpooled.directBuffer(Unpooled.java:125) > > org.apache.hadoop.hbase.ipc.NettyRpcConnection.(NettyRpcConnection.java:96) > > org.apache.hadoop.hbase.ipc.NettyRpcClient.createConnection(NettyRpcClient.java:74) > > org.apache.hadoop.hbase.ipc.NettyRpcClient.createConnection(NettyRpcClient.java:40) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient.getConnection(AbstractRpcClient.java:364) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient.callMethod(AbstractRpcClient.java:433) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$300(AbstractRpcClient.java:97) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient$RpcChannelImplementation.callMethod(AbstractRpcClient.java:605) > > org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$Stub.scan(ClientProtos.java:42345) > > org.apache.hadoop.hbase.client.AsyncClientScanner.callOpenScanner(AsyncClientScanner.java:152) > > org.apache.hadoop.hbase.client.AsyncSingleRequestRpcRetryingCaller.call(AsyncSingleRequestRpcRetryingCaller.java:82) > > org.apache.hadoop.hbase.client.AsyncSingleRequestRpcRetryingCaller.lambda$doCall$7(AsyncSingleRequestRpcRetryingCaller.java:115) > > org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) > > java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) > > java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) > > java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) > > java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) > > org.apache.hadoop.hbase.client.AsyncRegionLocator.lambda$getRegionLocation$3(AsyncRegionLocator.java:124) > > org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) > > java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) > > java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) > > java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) > > java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) > > org.apache.hadoop.hbase.client.ConnectionUtils.lambda$getOrFetch$6(ConnectionUtils.java:573) > > org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) > > java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) > > java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736)
[jira] [Commented] (HBASE-22964) Fix flaky TestClusterRestartFailover and TestClusterRestartFailoverSplitWithoutZk
[ https://issues.apache.org/jira/browse/HBASE-22964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925220#comment-16925220 ] HBase QA commented on HBASE-22964: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 46s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} | || || || || {color:brown} branch-2.2 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 12s{color} | {color:green} branch-2.2 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 53s{color} | {color:green} branch-2.2 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 18s{color} | {color:green} branch-2.2 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 2s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 15s{color} | {color:green} branch-2.2 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 35s{color} | {color:green} branch-2.2 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 47s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 15s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 0s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 14m 47s{color} | {color:green} Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 32s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green}146m 22s{color} | {color:green} hbase-server in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 28s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}195m 57s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/PreCommit-HBASE-Build/873/artifact/patchprocess/Dockerfile | | JIRA Issue | HBASE-22964 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12979775/HBASE-22964.branch-2.2.001.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 467957d56095 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.2 / caef72c233 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/873/testReport/ | | Max. process+thread count | 4634 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/873/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. > Fix
[jira] [Commented] (HBASE-22964) Fix flaky TestClusterRestartFailover and TestClusterRestartFailoverSplitWithoutZk
[ https://issues.apache.org/jira/browse/HBASE-22964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925204#comment-16925204 ] Hudson commented on HBASE-22964: Results for branch branch-2 [build #2237 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2237/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2237//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2237//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2237//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Fix flaky TestClusterRestartFailover and > TestClusterRestartFailoverSplitWithoutZk > - > > Key: HBASE-22964 > URL: https://issues.apache.org/jira/browse/HBASE-22964 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.2 > > Attachments: HBASE-22964.branch-2.2.001.patch > > > The ut failed because serverNode is null. And I checked the failed log, the > SCP already finished when try to test. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22964) Fix flaky TestClusterRestartFailover and TestClusterRestartFailoverSplitWithoutZk
[ https://issues.apache.org/jira/browse/HBASE-22964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925187#comment-16925187 ] Hudson commented on HBASE-22964: Results for branch master [build #1411 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1411/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/1411//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1411//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1411//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Fix flaky TestClusterRestartFailover and > TestClusterRestartFailoverSplitWithoutZk > - > > Key: HBASE-22964 > URL: https://issues.apache.org/jira/browse/HBASE-22964 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.2 > > Attachments: HBASE-22964.branch-2.2.001.patch > > > The ut failed because serverNode is null. And I checked the failed log, the > SCP already finished when try to test. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Resolved] (HBASE-22963) Netty ByteBuf leak in rpc client implementation
[ https://issues.apache.org/jira/browse/HBASE-22963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-22963. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.1+. Thanks [~stack] for reviewing. > Netty ByteBuf leak in rpc client implementation > --- > > Key: HBASE-22963 > URL: https://issues.apache.org/jira/browse/HBASE-22963 > Project: HBase > Issue Type: Bug > Components: rpc >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > > {noformat} > 2019-08-31 21:48:27,067 ERROR [RS-EventLoopGroup-6-3] > util.ResourceLeakDetector(317): LEAK: ByteBuf.release() was not called before > it's garbage-collected. See > http://netty.io/wiki/reference-counted-objects.html for more information. > Recent access records: > Created at: > > org.apache.hbase.thirdparty.io.netty.buffer.UnpooledByteBufAllocator.newDirectBuffer(UnpooledByteBufAllocator.java:96) > > org.apache.hbase.thirdparty.io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:187) > > org.apache.hbase.thirdparty.io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:178) > > org.apache.hbase.thirdparty.io.netty.buffer.Unpooled.directBuffer(Unpooled.java:125) > > org.apache.hadoop.hbase.ipc.NettyRpcConnection.(NettyRpcConnection.java:96) > > org.apache.hadoop.hbase.ipc.NettyRpcClient.createConnection(NettyRpcClient.java:74) > > org.apache.hadoop.hbase.ipc.NettyRpcClient.createConnection(NettyRpcClient.java:40) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient.getConnection(AbstractRpcClient.java:364) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient.callMethod(AbstractRpcClient.java:433) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$300(AbstractRpcClient.java:97) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient$RpcChannelImplementation.callMethod(AbstractRpcClient.java:605) > > org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$Stub.scan(ClientProtos.java:42345) > > org.apache.hadoop.hbase.client.AsyncClientScanner.callOpenScanner(AsyncClientScanner.java:152) > > org.apache.hadoop.hbase.client.AsyncSingleRequestRpcRetryingCaller.call(AsyncSingleRequestRpcRetryingCaller.java:82) > > org.apache.hadoop.hbase.client.AsyncSingleRequestRpcRetryingCaller.lambda$doCall$7(AsyncSingleRequestRpcRetryingCaller.java:115) > > org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) > > java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) > > java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) > > java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) > > java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) > > org.apache.hadoop.hbase.client.AsyncRegionLocator.lambda$getRegionLocation$3(AsyncRegionLocator.java:124) > > org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) > > java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) > > java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) > > java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) > > java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) > > org.apache.hadoop.hbase.client.ConnectionUtils.lambda$getOrFetch$6(ConnectionUtils.java:573) > > org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) > > java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) > > java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) > > java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) > > java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) > > org.apache.hadoop.hbase.client.ZKAsyncRegistry.tryComplete(ZKAsyncRegistry.java:123) > > org.apache.hadoop.hbase.client.ZKAsyncRegistry.lambda$getMetaRegionLocation$1(ZKAsyncRegistry.java:165) > > org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) > > java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) > > java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) > > java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) > >
[jira] [Updated] (HBASE-22963) Netty ByteBuf leak in rpc client implementation
[ https://issues.apache.org/jira/browse/HBASE-22963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22963: -- Fix Version/s: 2.2.2 2.1.7 2.3.0 3.0.0 > Netty ByteBuf leak in rpc client implementation > --- > > Key: HBASE-22963 > URL: https://issues.apache.org/jira/browse/HBASE-22963 > Project: HBase > Issue Type: Bug > Components: rpc >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > > {noformat} > 2019-08-31 21:48:27,067 ERROR [RS-EventLoopGroup-6-3] > util.ResourceLeakDetector(317): LEAK: ByteBuf.release() was not called before > it's garbage-collected. See > http://netty.io/wiki/reference-counted-objects.html for more information. > Recent access records: > Created at: > > org.apache.hbase.thirdparty.io.netty.buffer.UnpooledByteBufAllocator.newDirectBuffer(UnpooledByteBufAllocator.java:96) > > org.apache.hbase.thirdparty.io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:187) > > org.apache.hbase.thirdparty.io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:178) > > org.apache.hbase.thirdparty.io.netty.buffer.Unpooled.directBuffer(Unpooled.java:125) > > org.apache.hadoop.hbase.ipc.NettyRpcConnection.(NettyRpcConnection.java:96) > > org.apache.hadoop.hbase.ipc.NettyRpcClient.createConnection(NettyRpcClient.java:74) > > org.apache.hadoop.hbase.ipc.NettyRpcClient.createConnection(NettyRpcClient.java:40) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient.getConnection(AbstractRpcClient.java:364) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient.callMethod(AbstractRpcClient.java:433) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$300(AbstractRpcClient.java:97) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient$RpcChannelImplementation.callMethod(AbstractRpcClient.java:605) > > org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$Stub.scan(ClientProtos.java:42345) > > org.apache.hadoop.hbase.client.AsyncClientScanner.callOpenScanner(AsyncClientScanner.java:152) > > org.apache.hadoop.hbase.client.AsyncSingleRequestRpcRetryingCaller.call(AsyncSingleRequestRpcRetryingCaller.java:82) > > org.apache.hadoop.hbase.client.AsyncSingleRequestRpcRetryingCaller.lambda$doCall$7(AsyncSingleRequestRpcRetryingCaller.java:115) > > org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) > > java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) > > java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) > > java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) > > java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) > > org.apache.hadoop.hbase.client.AsyncRegionLocator.lambda$getRegionLocation$3(AsyncRegionLocator.java:124) > > org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) > > java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) > > java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) > > java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) > > java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) > > org.apache.hadoop.hbase.client.ConnectionUtils.lambda$getOrFetch$6(ConnectionUtils.java:573) > > org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) > > java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) > > java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) > > java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) > > java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) > > org.apache.hadoop.hbase.client.ZKAsyncRegistry.tryComplete(ZKAsyncRegistry.java:123) > > org.apache.hadoop.hbase.client.ZKAsyncRegistry.lambda$getMetaRegionLocation$1(ZKAsyncRegistry.java:165) > > org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) > > java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) > > java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) > > java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) > >
[jira] [Updated] (HBASE-22963) Netty ByteBuf leak in rpc client implementation
[ https://issues.apache.org/jira/browse/HBASE-22963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22963: -- Component/s: rpc > Netty ByteBuf leak in rpc client implementation > --- > > Key: HBASE-22963 > URL: https://issues.apache.org/jira/browse/HBASE-22963 > Project: HBase > Issue Type: Bug > Components: rpc >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > {noformat} > 2019-08-31 21:48:27,067 ERROR [RS-EventLoopGroup-6-3] > util.ResourceLeakDetector(317): LEAK: ByteBuf.release() was not called before > it's garbage-collected. See > http://netty.io/wiki/reference-counted-objects.html for more information. > Recent access records: > Created at: > > org.apache.hbase.thirdparty.io.netty.buffer.UnpooledByteBufAllocator.newDirectBuffer(UnpooledByteBufAllocator.java:96) > > org.apache.hbase.thirdparty.io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:187) > > org.apache.hbase.thirdparty.io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:178) > > org.apache.hbase.thirdparty.io.netty.buffer.Unpooled.directBuffer(Unpooled.java:125) > > org.apache.hadoop.hbase.ipc.NettyRpcConnection.(NettyRpcConnection.java:96) > > org.apache.hadoop.hbase.ipc.NettyRpcClient.createConnection(NettyRpcClient.java:74) > > org.apache.hadoop.hbase.ipc.NettyRpcClient.createConnection(NettyRpcClient.java:40) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient.getConnection(AbstractRpcClient.java:364) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient.callMethod(AbstractRpcClient.java:433) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$300(AbstractRpcClient.java:97) > > org.apache.hadoop.hbase.ipc.AbstractRpcClient$RpcChannelImplementation.callMethod(AbstractRpcClient.java:605) > > org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$Stub.scan(ClientProtos.java:42345) > > org.apache.hadoop.hbase.client.AsyncClientScanner.callOpenScanner(AsyncClientScanner.java:152) > > org.apache.hadoop.hbase.client.AsyncSingleRequestRpcRetryingCaller.call(AsyncSingleRequestRpcRetryingCaller.java:82) > > org.apache.hadoop.hbase.client.AsyncSingleRequestRpcRetryingCaller.lambda$doCall$7(AsyncSingleRequestRpcRetryingCaller.java:115) > > org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) > > java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) > > java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) > > java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) > > java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) > > org.apache.hadoop.hbase.client.AsyncRegionLocator.lambda$getRegionLocation$3(AsyncRegionLocator.java:124) > > org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) > > java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) > > java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) > > java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) > > java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) > > org.apache.hadoop.hbase.client.ConnectionUtils.lambda$getOrFetch$6(ConnectionUtils.java:573) > > org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) > > java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) > > java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) > > java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) > > java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) > > org.apache.hadoop.hbase.client.ZKAsyncRegistry.tryComplete(ZKAsyncRegistry.java:123) > > org.apache.hadoop.hbase.client.ZKAsyncRegistry.lambda$getMetaRegionLocation$1(ZKAsyncRegistry.java:165) > > org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) > > java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) > > java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) > > java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) > > java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) > > org.apache.hadoop.hbase.client.ZKAsyncRegistry.lambda$getAndConvert$0(ZKAsyncRegistry.java:81) > >
[GitHub] [hbase] petersomogyi commented on issue #589: HBASE-22979 Call ChunkCreator.initialize is TestHRegionWithInMemoryFlush
petersomogyi commented on issue #589: HBASE-22979 Call ChunkCreator.initialize is TestHRegionWithInMemoryFlush URL: https://github.com/apache/hbase/pull/589#issuecomment-529207155 I just noticed a typo in the commit message. It can be fixed on merging PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose
[ https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925183#comment-16925183 ] Hudson commented on HBASE-21879: Results for branch HBASE-21879 [build #234 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/234/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/234//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/234//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/234//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Read HFile's block to ByteBuffer directly instead of to byte for reducing > young gc purpose > -- > > Key: HBASE-21879 > URL: https://issues.apache.org/jira/browse/HBASE-21879 > Project: HBase > Issue Type: Improvement >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-21879.v1.patch, HBASE-21879.v1.patch, > QPS-latencies-before-HBASE-21879.png, gc-data-before-HBASE-21879.png > > > In HFileBlock#readBlockDataInternal, we have the following: > {code} > @VisibleForTesting > protected HFileBlock readBlockDataInternal(FSDataInputStream is, long offset, > long onDiskSizeWithHeaderL, boolean pread, boolean verifyChecksum, > boolean updateMetrics) > throws IOException { > // . > // TODO: Make this ByteBuffer-based. Will make it easier to go to HDFS with > BBPool (offheap). > byte [] onDiskBlock = new byte[onDiskSizeWithHeader + hdrSize]; > int nextBlockOnDiskSize = readAtOffset(is, onDiskBlock, preReadHeaderSize, > onDiskSizeWithHeader - preReadHeaderSize, true, offset + > preReadHeaderSize, pread); > if (headerBuf != null) { > // ... > } > // ... > } > {code} > In the read path, we still read the block from hfile to on-heap byte[], then > copy the on-heap byte[] to offheap bucket cache asynchronously, and in my > 100% get performance test, I also observed some frequent young gc, The > largest memory footprint in the young gen should be the on-heap block byte[]. > In fact, we can read HFile's block to ByteBuffer directly instead of to > byte[] for reducing young gc purpose. we did not implement this before, > because no ByteBuffer reading interface in the older HDFS client, but 2.7+ > has supported this now, so we can fix this now. I think. > Will provide an patch and some perf-comparison for this. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22979) Call ChunkCreator.initialize in TestHRegionWithInMemoryFlush
[ https://issues.apache.org/jira/browse/HBASE-22979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-22979: -- Summary: Call ChunkCreator.initialize in TestHRegionWithInMemoryFlush (was: Call ChunkCreator.initialize is TestHRegionWithInMemoryFlush) > Call ChunkCreator.initialize in TestHRegionWithInMemoryFlush > > > Key: HBASE-22979 > URL: https://issues.apache.org/jira/browse/HBASE-22979 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 2.3.0, 2.2.1 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Critical > > TestHRegionWithInMemoryFlush is failing 100% on branch-2.2+. > Refactor of TestHRegion in HBASE-22896 did not update the overridden > initHRegion method in this test. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] busbey commented on issue #565: [HBASE-22874] Canary should not be IA.Public
busbey commented on issue #565: [HBASE-22874] Canary should not be IA.Public URL: https://github.com/apache/hbase/pull/565#issuecomment-529206214 It usually means a commit got pushed to master that says it's fixed. I don't see anything obvious but haven't gotten to look much. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22964) Fix flaky TestClusterRestartFailover and TestClusterRestartFailoverSplitWithoutZk
[ https://issues.apache.org/jira/browse/HBASE-22964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925177#comment-16925177 ] Guanghao Zhang commented on HBASE-22964: Attach a patch for branch-2.2. The different is choose a server which not carry hbase:namespace table to test. > Fix flaky TestClusterRestartFailover and > TestClusterRestartFailoverSplitWithoutZk > - > > Key: HBASE-22964 > URL: https://issues.apache.org/jira/browse/HBASE-22964 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.2 > > Attachments: HBASE-22964.branch-2.2.001.patch > > > The ut failed because serverNode is null. And I checked the failed log, the > SCP already finished when try to test. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22964) Fix flaky TestClusterRestartFailover and TestClusterRestartFailoverSplitWithoutZk
[ https://issues.apache.org/jira/browse/HBASE-22964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22964: --- Fix Version/s: 2.2.2 2.3.0 3.0.0 > Fix flaky TestClusterRestartFailover and > TestClusterRestartFailoverSplitWithoutZk > - > > Key: HBASE-22964 > URL: https://issues.apache.org/jira/browse/HBASE-22964 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.2 > > Attachments: HBASE-22964.branch-2.2.001.patch > > > The ut failed because serverNode is null. And I checked the failed log, the > SCP already finished when try to test. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22964) Fix flaky TestClusterRestartFailover and TestClusterRestartFailoverSplitWithoutZk
[ https://issues.apache.org/jira/browse/HBASE-22964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22964: --- Attachment: HBASE-22964.branch-2.2.001.patch > Fix flaky TestClusterRestartFailover and > TestClusterRestartFailoverSplitWithoutZk > - > > Key: HBASE-22964 > URL: https://issues.apache.org/jira/browse/HBASE-22964 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Attachments: HBASE-22964.branch-2.2.001.patch > > > The ut failed because serverNode is null. And I checked the failed log, the > SCP already finished when try to test. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22964) Fix flaky TestClusterRestartFailover and TestClusterRestartFailoverSplitWithoutZk
[ https://issues.apache.org/jira/browse/HBASE-22964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22964: --- Status: Patch Available (was: Open) > Fix flaky TestClusterRestartFailover and > TestClusterRestartFailoverSplitWithoutZk > - > > Key: HBASE-22964 > URL: https://issues.apache.org/jira/browse/HBASE-22964 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Attachments: HBASE-22964.branch-2.2.001.patch > > > The ut failed because serverNode is null. And I checked the failed log, the > SCP already finished when try to test. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] Apache9 merged pull request #577: HBASE-22963 Netty ByteBuf leak in rpc client implementation
Apache9 merged pull request #577: HBASE-22963 Netty ByteBuf leak in rpc client implementation URL: https://github.com/apache/hbase/pull/577 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #577: HBASE-22963 Netty ByteBuf leak in rpc client implementation
Apache9 commented on issue #577: HBASE-22963 Netty ByteBuf leak in rpc client implementation URL: https://github.com/apache/hbase/pull/577#issuecomment-529204615 Tried locally, the failed UTs are not related. Let me commit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-11062) hbtop
[ https://issues.apache.org/jira/browse/HBASE-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925171#comment-16925171 ] Duo Zhang commented on HBASE-11062: --- +1. > hbtop > - > > Key: HBASE-11062 > URL: https://issues.apache.org/jira/browse/HBASE-11062 > Project: HBase > Issue Type: New Feature > Components: hbtop >Reporter: Andrew Purtell >Assignee: Toshihiro Suzuki >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > Attachments: HBASE-11062-master-addendum-v1.patch > > > A top-like monitor could be useful for testing, debugging, operations of > clusters of moderate size, and possibly for diagnosing issues in large > clusters. > Consider a curses interface like the one presented by atop > (http://www.atoptool.nl/images/screenshots/genericw.png) - with aggregate > metrics collected over a monitoring interval in the upper portion of the > pane, and a listing of discrete measurements sorted and filtered by various > criteria in the bottom part of the pane. One might imagine a cluster overview > with cluster aggregate metrics above and a list of regionservers sorted by > utilization below; and a regionserver view with process metrics above and a > list of metrics by operation type below, or a list of client connections, or > a list of threads, sorted by utilization, throughput, or latency. > Generically 'htop' is taken but would be distinctive in the HBase context, a > utility org.apache.hadoop.hbase.HTop > No need necessarily for a curses interface. Could be an external monitor with > a web front end as has been discussed before. I do like the idea of a process > that runs in a terminal because I interact with dev and test HBase clusters > exclusively by SSH. > UPDATE: > The tool name is changed from htop to hbtop. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22964) Fix flaky TestClusterRestartFailover and TestClusterRestartFailoverSplitWithoutZk
[ https://issues.apache.org/jira/browse/HBASE-22964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925147#comment-16925147 ] Guanghao Zhang commented on HBASE-22964: Not cherry-picked to branch-2.2. TestClusterRestartFailoverSplitWithoutZk failed. Let me dig. > Fix flaky TestClusterRestartFailover and > TestClusterRestartFailoverSplitWithoutZk > - > > Key: HBASE-22964 > URL: https://issues.apache.org/jira/browse/HBASE-22964 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > > The ut failed because serverNode is null. And I checked the failed log, the > SCP already finished when try to test. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase
[ https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925144#comment-16925144 ] Hudson commented on HBASE-22514: Results for branch HBASE-22514 [build #97 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/97/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/97//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/97//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/97//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (x) {color:red}-1 client integration test{color} --Failed when running client tests on top of Hadoop 2. [see log for details|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/97//artifact/output-integration/hadoop-2.log]. (note that this means we didn't run on Hadoop 3) > Move rsgroup feature into core of HBase > --- > > Key: HBASE-22514 > URL: https://issues.apache.org/jira/browse/HBASE-22514 > Project: HBase > Issue Type: Umbrella > Components: Admin, Client, rsgroup >Reporter: Yechao Chen >Assignee: Duo Zhang >Priority: Major > Attachments: HBASE-22514.master.001.patch, > image-2019-05-31-18-25-38-217.png > > > The class RSGroupAdminClient is not public > we need to use java api RSGroupAdminClient to manager RSG > so RSGroupAdminClient should be public > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] infraio merged pull request #574: HBASE-22964 Fix flaky TestClusterRestartFailover and TestClusterResta…
infraio merged pull request #574: HBASE-22964 Fix flaky TestClusterRestartFailover and TestClusterResta… URL: https://github.com/apache/hbase/pull/574 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (HBASE-22888) Use separate classe to deal with streaming read and pread
[ https://issues.apache.org/jira/browse/HBASE-22888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925117#comment-16925117 ] chenxu edited comment on HBASE-22888 at 9/8/19 9:01 AM: Thank you for the valueable comments, [~anoop.hbase] {quote}Do we really need to do this copy? The stream reader's block index reader can directly refer to the pread HFileReader's block index reader? {quote} I think it's necessary, Otherwise we need to call readMultiLevelIndexRoot and readRootIndex in all StreamReader, and read the index from HFile again {quote}Checking the E2E reader creation flow, I can see it will again call the CP hooks around the StoreFileReader creation! May be even that is not needed really? More over can we do this clone stuff within the HFileReader itself? Same way would have been best for StoreFileReader also so that we can avoid the CP hooks calls {quote} The CP hooks may be required by the upper layer?Want to know if removal will have an impact on upper-layer applications such as phoenix. was (Author: javaman_chen): Thank you for the valueable comments, [~anoop.hbase] bq. Do we really need to do this copy? The stream reader's block index reader can directly refer to the pread HFileReader's block index reader? I think it's necessary, Otherwise we need to call readMultiLevelIndexRoot and readRootIndex in all StreamReader read the index info from HFile again bq. Checking the E2E reader creation flow, I can see it will again call the CP hooks around the StoreFileReader creation! May be even that is not needed really? More over can we do this clone stuff within the HFileReader itself? Same way would have been best for StoreFileReader also so that we can avoid the CP hooks calls The CP hooks may be required by the upper layer?Want to know if removal will have an impact on upper-layer applications such as phoenix. > Use separate classe to deal with streaming read and pread > - > > Key: HBASE-22888 > URL: https://issues.apache.org/jira/browse/HBASE-22888 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: chenxu >Assignee: chenxu >Priority: Major > > When switching pread to stream read, new HFileReaderImpl will be create, but > the two different readers do not share informations with each other. maybe we > can divide HFileReaderImpl into two different class, such as HFilePreadReader > and HFileStreamReader. When constructing HFileStreamReader, it will copy some > stuffs (fileInfo, index, etc) from an already existing Reader, and no need to > do prefetch operations. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22888) Use separate classe to deal with streaming read and pread
[ https://issues.apache.org/jira/browse/HBASE-22888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925117#comment-16925117 ] chenxu commented on HBASE-22888: Thank you for the valueable comments, [~anoop.hbase] bq. Do we really need to do this copy? The stream reader's block index reader can directly refer to the pread HFileReader's block index reader? I think it's necessary, Otherwise we need to call readMultiLevelIndexRoot and readRootIndex in all StreamReader read the index info from HFile again bq. Checking the E2E reader creation flow, I can see it will again call the CP hooks around the StoreFileReader creation! May be even that is not needed really? More over can we do this clone stuff within the HFileReader itself? Same way would have been best for StoreFileReader also so that we can avoid the CP hooks calls The CP hooks may be required by the upper layer?Want to know if removal will have an impact on upper-layer applications such as phoenix. > Use separate classe to deal with streaming read and pread > - > > Key: HBASE-22888 > URL: https://issues.apache.org/jira/browse/HBASE-22888 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: chenxu >Assignee: chenxu >Priority: Major > > When switching pread to stream read, new HFileReaderImpl will be create, but > the two different readers do not share informations with each other. maybe we > can divide HFileReaderImpl into two different class, such as HFilePreadReader > and HFileStreamReader. When constructing HFileStreamReader, it will copy some > stuffs (fileInfo, index, etc) from an already existing Reader, and no need to > do prefetch operations. -- This message was sent by Atlassian Jira (v8.3.2#803003)