[GitHub] [hbase] anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts

2019-09-29 Thread GitBox
anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts URL: https://github.com/apache/hbase/pull/600#discussion_r329415290 ## File path: src/main/asciidoc/_chapters/hbase-default.adoc ## @@ -2161,3 +2161,36 @@

[GitHub] [hbase] anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts

2019-09-29 Thread GitBox
anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts URL: https://github.com/apache/hbase/pull/600#discussion_r329410317 ## File path:

[GitHub] [hbase] anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts

2019-09-29 Thread GitBox
anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts URL: https://github.com/apache/hbase/pull/600#discussion_r329405980 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -1901,4 +1901,26

[GitHub] [hbase] anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts

2019-09-29 Thread GitBox
anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts URL: https://github.com/apache/hbase/pull/600#discussion_r329415004 ## File path: src/main/asciidoc/_chapters/hbase-default.adoc ## @@ -2161,3 +2161,36 @@

[GitHub] [hbase] anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts

2019-09-29 Thread GitBox
anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts URL: https://github.com/apache/hbase/pull/600#discussion_r329406607 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionsRecoveryChore.java

[GitHub] [hbase] anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts

2019-09-29 Thread GitBox
anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts URL: https://github.com/apache/hbase/pull/600#discussion_r329406547 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionsRecoveryChore.java

[GitHub] [hbase] anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts

2019-09-29 Thread GitBox
anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts URL: https://github.com/apache/hbase/pull/600#discussion_r329410092 ## File path:

[GitHub] [hbase] anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts

2019-09-29 Thread GitBox
anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts URL: https://github.com/apache/hbase/pull/600#discussion_r329406161 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionsRecoveryChore.java

[GitHub] [hbase] anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts

2019-09-29 Thread GitBox
anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts URL: https://github.com/apache/hbase/pull/600#discussion_r329404445 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -1901,4 +1901,26

[GitHub] [hbase] anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts

2019-09-29 Thread GitBox
anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts URL: https://github.com/apache/hbase/pull/600#discussion_r329410420 ## File path:

[GitHub] [hbase] anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts

2019-09-29 Thread GitBox
anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts URL: https://github.com/apache/hbase/pull/600#discussion_r329406742 ## File path:

[GitHub] [hbase] anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts

2019-09-29 Thread GitBox
anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts URL: https://github.com/apache/hbase/pull/600#discussion_r329404290 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@

[GitHub] [hbase] anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts

2019-09-29 Thread GitBox
anoopsjohn commented on a change in pull request #600: HBASE-22460 : Reopen regions with very high Store Ref Counts URL: https://github.com/apache/hbase/pull/600#discussion_r329405498 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ##

[GitHub] [hbase] karthikhw opened a new pull request #674: HBASE-23095 Reuse FileStatus in StoreFileInfo

2019-09-29 Thread GitBox
karthikhw opened a new pull request #674: HBASE-23095 Reuse FileStatus in StoreFileInfo URL: https://github.com/apache/hbase/pull/674 We found this performance issue when taking a snapshot on large MOB table where MOB compaction is disabled more than 3 months, is due to MOB data loss

[jira] [Created] (HBASE-23095) Reuse FileStatus in StoreFileInfo

2019-09-29 Thread Karthik Palanisamy (Jira)
Karthik Palanisamy created HBASE-23095: -- Summary: Reuse FileStatus in StoreFileInfo Key: HBASE-23095 URL: https://issues.apache.org/jira/browse/HBASE-23095 Project: HBase Issue Type:

[jira] [Updated] (HBASE-23094) Wrong log message in simpleRegionNormaliser while checking if merge is enabled.

2019-09-29 Thread Sanjeet Nishad (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjeet Nishad updated HBASE-23094: --- Issue Type: Bug (was: Improvement) > Wrong log message in simpleRegionNormaliser while

[jira] [Assigned] (HBASE-23079) RegionRemoteProcedureBase should override setTimeoutFailure

2019-09-29 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-23079: - Assignee: Duo Zhang (was: Xiaolin Ha) > RegionRemoteProcedureBase should override

[GitHub] [hbase] Apache9 merged pull request #672: HBASE-23079 RegionRemoteProcedureBase should override setTimeoutFailure

2019-09-29 Thread GitBox
Apache9 merged pull request #672: HBASE-23079 RegionRemoteProcedureBase should override setTimeoutFailure URL: https://github.com/apache/hbase/pull/672 This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (HBASE-23078) BaseLoadBalancer should consider region replicas when randomAssignment and roundRobinAssignment

2019-09-29 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940634#comment-16940634 ] Guanghao Zhang commented on HBASE-23078: Pushed to branch-2.2+. UT failure when cherry-pick to

[GitHub] [hbase] virajjasani commented on issue #611: HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command

2019-09-29 Thread GitBox
virajjasani commented on issue #611: HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command URL: https://github.com/apache/hbase/pull/611#issuecomment-536379942 Thanks for the review, updated the PR based on comments, please take a look @openinx Some

[jira] [Commented] (HBASE-22965) RS Crash due to DBE reference to an reused ByteBuff

2019-09-29 Thread Zheng Hu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940596#comment-16940596 ] Zheng Hu commented on HBASE-22965: -- Pushed to all 2.x branches, Thanks [~javaman_chen] for

[jira] [Resolved] (HBASE-22965) RS Crash due to DBE reference to an reused ByteBuff

2019-09-29 Thread Zheng Hu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Hu resolved HBASE-22965. -- Hadoop Flags: Reviewed Resolution: Fixed > RS Crash due to DBE reference to an reused ByteBuff

[jira] [Updated] (HBASE-22965) RS Crash due to DBE reference to an reused ByteBuff

2019-09-29 Thread Zheng Hu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Hu updated HBASE-22965: - Fix Version/s: 2.2.2 2.1.7 2.3.0 3.0.0 > RS

[jira] [Commented] (HBASE-23080) Purge LoadBalancer.BOGUS_SERVER_NAME in rsgroup

2019-09-29 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940595#comment-16940595 ] Xiaolin Ha commented on HBASE-23080: We can randomly choose DEFAULT group servers instead of 

[jira] [Commented] (HBASE-23078) BaseLoadBalancer should consider region replicas when randomAssignment and roundRobinAssignment

2019-09-29 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940594#comment-16940594 ] Hudson commented on HBASE-23078: Results for branch branch-2 [build #2306 on

[GitHub] [hbase] openinx merged pull request #603: HBASE-22965 RS Crash due to DBE reference to an reused ByteBuff

2019-09-29 Thread GitBox
openinx merged pull request #603: HBASE-22965 RS Crash due to DBE reference to an reused ByteBuff URL: https://github.com/apache/hbase/pull/603 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HBASE-23079) RegionRemoteProcedureBase should override setTimeoutFailure

2019-09-29 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940590#comment-16940590 ] Xiaolin Ha commented on HBASE-23079: Got it. So it's because the ORP be marked as WAITING_TIMEOUT

[jira] [Commented] (HBASE-23078) BaseLoadBalancer should consider region replicas when randomAssignment and roundRobinAssignment

2019-09-29 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940579#comment-16940579 ] Hudson commented on HBASE-23078: Results for branch branch-2.2 [build #645 on

[jira] [Commented] (HBASE-23084) Assertion "Added a key not lexically larger than previous" or "prevKey followed by a smaller key" caused abortion of RS

2019-09-29 Thread ranpanfeng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940578#comment-16940578 ] ranpanfeng commented on HBASE-23084: [~javaman_chen]  yes, FAST_DIFF is enabled in default.

[jira] [Commented] (HBASE-23087) Remove the deprecated bulkload method in AsyncClusterConnection

2019-09-29 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940575#comment-16940575 ] Hudson commented on HBASE-23087: Results for branch master [build #1487 on

[jira] [Commented] (HBASE-23078) BaseLoadBalancer should consider region replicas when randomAssignment and roundRobinAssignment

2019-09-29 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940576#comment-16940576 ] Hudson commented on HBASE-23078: Results for branch master [build #1487 on

[jira] [Commented] (HBASE-23035) Retain region to the last RegionServer make the failover slower

2019-09-29 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940573#comment-16940573 ] Hudson commented on HBASE-23035: Results for branch master [build #1487 on

[jira] [Commented] (HBASE-23054) Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm

2019-09-29 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940574#comment-16940574 ] Hudson commented on HBASE-23054: Results for branch master [build #1487 on

[GitHub] [hbase] Apache-HBase commented on issue #611: HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command

2019-09-29 Thread GitBox
Apache-HBase commented on issue #611: HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command URL: https://github.com/apache/hbase/pull/611#issuecomment-536351338 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment

[jira] [Commented] (HBASE-23093) Avoid Optional Anti-Patterns

2019-09-29 Thread HBase QA (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940562#comment-16940562 ] HBase QA commented on HBASE-23093: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[GitHub] [hbase] Apache-HBase commented on issue #673: HBASE-23093 : Avoid Optional Anti-Pattern where possible

2019-09-29 Thread GitBox
Apache-HBase commented on issue #673: HBASE-23093 : Avoid Optional Anti-Pattern where possible URL: https://github.com/apache/hbase/pull/673#issuecomment-536349600 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #673: HBASE-23093 : Avoid Optional Anti-Pattern where possible

2019-09-29 Thread GitBox
Apache-HBase commented on issue #673: HBASE-23093 : Avoid Optional Anti-Pattern where possible URL: https://github.com/apache/hbase/pull/673#issuecomment-536339538 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #672: HBASE-23079 RegionRemoteProcedureBase should override setTimeoutFailure

2019-09-29 Thread GitBox
Apache-HBase commented on issue #672: HBASE-23079 RegionRemoteProcedureBase should override setTimeoutFailure URL: https://github.com/apache/hbase/pull/672#issuecomment-536334831 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Updated] (HBASE-23093) Avoid Optional Anti-Patterns

2019-09-29 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-23093: - Attachment: HBASE-23093.master.000.patch > Avoid Optional Anti-Patterns >

[GitHub] [hbase] virajjasani commented on a change in pull request #611: HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command

2019-09-29 Thread GitBox
virajjasani commented on a change in pull request #611: HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command URL: https://github.com/apache/hbase/pull/611#discussion_r329349422 ## File path: hbase-shell/src/main/ruby/hbase/admin.rb ## @@

[GitHub] [hbase] virajjasani commented on a change in pull request #611: HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command

2019-09-29 Thread GitBox
virajjasani commented on a change in pull request #611: HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command URL: https://github.com/apache/hbase/pull/611#discussion_r329364321 ## File path: hbase-shell/src/main/ruby/hbase/admin.rb ## @@

[GitHub] [hbase] busbey commented on issue #671: HBASE-23092 Make the RM tooling in dev-tools/create-release generic

2019-09-29 Thread GitBox
busbey commented on issue #671: HBASE-23092 Make the RM tooling in dev-tools/create-release generic URL: https://github.com/apache/hbase/pull/671#issuecomment-536313059 Can we make the project a parameter instead of an env variable?

[jira] [Updated] (HBASE-23093) Avoid Optional Anti-Patterns

2019-09-29 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-23093: - Fix Version/s: 1.6.0 2.3.0 3.0.0 Status: Patch

[jira] [Work started] (HBASE-23093) Avoid Optional Anti-Patterns

2019-09-29 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23093 started by Viraj Jasani. > Avoid Optional Anti-Patterns > > >

[GitHub] [hbase] virajjasani opened a new pull request #673: HBASE-23093 : Avoid Optional Anti-Pattern where possible

2019-09-29 Thread GitBox
virajjasani opened a new pull request #673: HBASE-23093 : Avoid Optional Anti-Pattern where possible URL: https://github.com/apache/hbase/pull/673 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase-site] brfrn169 commented on issue #2: HBASE-22986 Add documentation for hbtop

2019-09-29 Thread GitBox
brfrn169 commented on issue #2: HBASE-22986 Add documentation for hbtop URL: https://github.com/apache/hbase-site/pull/2#issuecomment-536300771 Thank you! @petersomogyi This is an automated message from the Apache Git

[jira] [Updated] (HBASE-23079) RegionRemoteProcedureBase should override setTimeoutFailure

2019-09-29 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23079: -- Summary: RegionRemoteProcedureBase should override setTimeoutFailure (was: OpenRegionProcedure

[GitHub] [hbase] Apache9 opened a new pull request #672: HBASE-23079 RegionRemoteProcedureBase should override setTimeoutFailure

2019-09-29 Thread GitBox
Apache9 opened a new pull request #672: HBASE-23079 RegionRemoteProcedureBase should override setTimeoutFailure URL: https://github.com/apache/hbase/pull/672 This is an automated message from the Apache Git Service. To

[GitHub] [hbase-site] brfrn169 merged pull request #2: HBASE-22986 Add documentation for hbtop

2019-09-29 Thread GitBox
brfrn169 merged pull request #2: HBASE-22986 Add documentation for hbtop URL: https://github.com/apache/hbase-site/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (HBASE-23079) OpenRegionProcedure should override setTimeoutFailure

2019-09-29 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23079: -- Summary: OpenRegionProcedure should override setTimeoutFailure (was: SCP fails when PE executes

[GitHub] [hbase-site] brfrn169 commented on issue #2: HBASE-22986 Add documentation for hbtop

2019-09-29 Thread GitBox
brfrn169 commented on issue #2: HBASE-22986 Add documentation for hbtop URL: https://github.com/apache/hbase-site/pull/2#issuecomment-536296067 Sure. Will do that. This is an automated message from the Apache Git Service. To

[GitHub] [hbase-site] brfrn169 opened a new pull request #2: HBASE-22986 Add documentation for hbtop

2019-09-29 Thread GitBox
brfrn169 opened a new pull request #2: HBASE-22986 Add documentation for hbtop URL: https://github.com/apache/hbase-site/pull/2 Add images for documentation of hbtop. This is an automated message from the Apache Git Service.

[jira] [Commented] (HBASE-23084) Assertion "Added a key not lexically larger than previous" or "prevKey followed by a smaller key" caused abortion of RS

2019-09-29 Thread chenxu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940375#comment-16940375 ] chenxu commented on HBASE-23084: Is the phoenix table enabled FAST_DIFF encoding? Is there any crash

[jira] [Updated] (HBASE-23094) Wrong log message in simpleRegionNormaliser while checking if merge is enabled.

2019-09-29 Thread Sanjeet Nishad (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjeet Nishad updated HBASE-23094: --- Description: {color:#9876aa}In the following log message :{color}

[jira] [Created] (HBASE-23094) Wrong log message in simpleRegionNormaliser while checking if merge is enabled.

2019-09-29 Thread Sanjeet Nishad (Jira)
Sanjeet Nishad created HBASE-23094: -- Summary: Wrong log message in simpleRegionNormaliser while checking if merge is enabled. Key: HBASE-23094 URL: https://issues.apache.org/jira/browse/HBASE-23094

[jira] [Commented] (HBASE-22986) Add documentation for hbtop

2019-09-29 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940362#comment-16940362 ] Toshihiro Suzuki commented on HBASE-22986: -- [~psomogyi] Sure. Thank you! > Add documentation

[jira] [Commented] (HBASE-23045) currentPath may be stitched in a loop in replication source code.

2019-09-29 Thread Zheng Hu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940361#comment-16940361 ] Zheng Hu commented on HBASE-23045: -- Yeah, mind provide a UT to reproduce this bug ? will be appreciate

[GitHub] [hbase] openinx commented on issue #611: HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command

2019-09-29 Thread GitBox
openinx commented on issue #611: HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command URL: https://github.com/apache/hbase/pull/611#issuecomment-536286197 BTW, please also take a look the HBaseQA, seems checkstyles & ruby has some problem now, please

[GitHub] [hbase] virajjasani commented on a change in pull request #611: HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command

2019-09-29 Thread GitBox
virajjasani commented on a change in pull request #611: HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command URL: https://github.com/apache/hbase/pull/611#discussion_r329349422 ## File path: hbase-shell/src/main/ruby/hbase/admin.rb ## @@

[GitHub] [hbase] openinx commented on a change in pull request #611: HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command

2019-09-29 Thread GitBox
openinx commented on a change in pull request #611: HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command URL: https://github.com/apache/hbase/pull/611#discussion_r329349104 ## File path: hbase-shell/src/main/ruby/hbase/admin.rb ## @@

[GitHub] [hbase] openinx commented on a change in pull request #611: HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command

2019-09-29 Thread GitBox
openinx commented on a change in pull request #611: HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command URL: https://github.com/apache/hbase/pull/611#discussion_r329348889 ## File path:

[GitHub] [hbase] openinx commented on a change in pull request #611: HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command

2019-09-29 Thread GitBox
openinx commented on a change in pull request #611: HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command URL: https://github.com/apache/hbase/pull/611#discussion_r329348946 ## File path: hbase-shell/src/main/ruby/hbase/admin.rb ## @@

[GitHub] [hbase] virajjasani removed a comment on issue #611: HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command

2019-09-29 Thread GitBox
virajjasani removed a comment on issue #611: HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command URL: https://github.com/apache/hbase/pull/611#issuecomment-535439447 @Reidd Please review if you are available Thanks

[GitHub] [hbase] virajjasani commented on issue #611: HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command

2019-09-29 Thread GitBox
virajjasani commented on issue #611: HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command URL: https://github.com/apache/hbase/pull/611#issuecomment-536283825 @Apache9 could you please review this PR?

[GitHub] [hbase] virajjasani removed a comment on issue #611: HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command

2019-09-29 Thread GitBox
virajjasani removed a comment on issue #611: HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command URL: https://github.com/apache/hbase/pull/611#issuecomment-536049986 Requesting your review @saintstack

[jira] [Commented] (HBASE-23093) Avoid Optional Anti-Patterns

2019-09-29 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940341#comment-16940341 ] Viraj Jasani commented on HBASE-23093: -- {quote}if we do not use Optional field, then we need to

[jira] [Commented] (HBASE-23093) Avoid Optional Anti-Patterns

2019-09-29 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940339#comment-16940339 ] Duo Zhang commented on HBASE-23093: --- I agree that Optional should not be used as parameter as it

[jira] [Commented] (HBASE-22986) Add documentation for hbtop

2019-09-29 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940334#comment-16940334 ] Peter Somogyi commented on HBASE-22986: --- Pull requests work there as well. > Add documentation

[jira] [Updated] (HBASE-23093) Avoid Optional Anti-Patterns

2019-09-29 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-23093: - Description: Optional should be used as a return type only. It's a neat solution for handling

[jira] [Created] (HBASE-23093) Avoid Optional Anti-Patterns

2019-09-29 Thread Viraj Jasani (Jira)
Viraj Jasani created HBASE-23093: Summary: Avoid Optional Anti-Patterns Key: HBASE-23093 URL: https://issues.apache.org/jira/browse/HBASE-23093 Project: HBase Issue Type: Improvement

[GitHub] [hbase] infraio merged pull request #663: HBASE-23078 BaseLoadBalancer should consider region replicas when ran…

2019-09-29 Thread GitBox
infraio merged pull request #663: HBASE-23078 BaseLoadBalancer should consider region replicas when ran… URL: https://github.com/apache/hbase/pull/663 This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] infraio commented on issue #663: HBASE-23078 BaseLoadBalancer should consider region replicas when ran…

2019-09-29 Thread GitBox
infraio commented on issue #663: HBASE-23078 BaseLoadBalancer should consider region replicas when ran… URL: https://github.com/apache/hbase/pull/663#issuecomment-536274537 The failed ut not related and passed. This is an

[GitHub] [hbase] Apache-HBase commented on issue #626: HBASE-23017 Verify the file integrity in persistent IOEngine

2019-09-29 Thread GitBox
Apache-HBase commented on issue #626: HBASE-23017 Verify the file integrity in persistent IOEngine URL: https://github.com/apache/hbase/pull/626#issuecomment-536273697 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HBASE-23084) Assertion "Added a key not lexically larger than previous" or "prevKey followed by a smaller key" caused abortion of RS

2019-09-29 Thread ranpanfeng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940283#comment-16940283 ] ranpanfeng commented on HBASE-23084: [~zhangduo] I am sure that out-of-order adjacent keys is just

[jira] [Commented] (HBASE-23079) SCP fails when PE executes rollback of ORP

2019-09-29 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940278#comment-16940278 ] Duo Zhang commented on HBASE-23079: --- Oh, checked the code, the TimeoutIOException should be created by

[jira] [Updated] (HBASE-23079) SCP fails when PE executes rollback of ORP

2019-09-29 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23079: -- Component/s: amv2 > SCP fails when PE executes rollback of ORP >

[jira] [Updated] (HBASE-23079) SCP fails when PE executes rollback of ORP

2019-09-29 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23079: -- Fix Version/s: 2.2.2 2.3.0 3.0.0 > SCP fails when PE executes

[jira] [Updated] (HBASE-23079) SCP fails when PE executes rollback of ORP

2019-09-29 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23079: -- Priority: Blocker (was: Major) > SCP fails when PE executes rollback of ORP >

[jira] [Commented] (HBASE-23079) SCP fails when PE executes rollback of ORP

2019-09-29 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940273#comment-16940273 ] Duo Zhang commented on HBASE-23079: --- {quote} Duo Zhang you showed failed at

[jira] [Commented] (HBASE-23079) SCP fails when PE executes rollback of ORP

2019-09-29 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940270#comment-16940270 ] Xiaolin Ha commented on HBASE-23079: In production environments, there may occur Master and RS crash

[GitHub] [hbase] Apache9 commented on a change in pull request #581: HBASE-22888 Share some stuffs with the initial reader when new stream reader created

2019-09-29 Thread GitBox
Apache9 commented on a change in pull request #581: HBASE-22888 Share some stuffs with the initial reader when new stream reader created URL: https://github.com/apache/hbase/pull/581#discussion_r329341747 ## File path:

[GitHub] [hbase] Apache9 commented on a change in pull request #581: HBASE-22888 Share some stuffs with the initial reader when new stream reader created

2019-09-29 Thread GitBox
Apache9 commented on a change in pull request #581: HBASE-22888 Share some stuffs with the initial reader when new stream reader created URL: https://github.com/apache/hbase/pull/581#discussion_r329341416 ## File path:

[GitHub] [hbase] Apache9 commented on a change in pull request #581: HBASE-22888 Share some stuffs with the initial reader when new stream reader created

2019-09-29 Thread GitBox
Apache9 commented on a change in pull request #581: HBASE-22888 Share some stuffs with the initial reader when new stream reader created URL: https://github.com/apache/hbase/pull/581#discussion_r329341320 ## File path:

[GitHub] [hbase] Apache9 commented on a change in pull request #581: HBASE-22888 Share some stuffs with the initial reader when new stream reader created

2019-09-29 Thread GitBox
Apache9 commented on a change in pull request #581: HBASE-22888 Share some stuffs with the initial reader when new stream reader created URL: https://github.com/apache/hbase/pull/581#discussion_r329341718 ## File path:

[jira] [Commented] (HBASE-23079) SCP fails when PE executes rollback of ORP

2019-09-29 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940268#comment-16940268 ] Xiaolin Ha commented on HBASE-23079: [~zhangduo] you showed failed at 

[GitHub] [hbase] Apache-HBase commented on issue #671: HBASE-23092 Make the RM tooling in dev-tools/create-release generic

2019-09-29 Thread GitBox
Apache-HBase commented on issue #671: HBASE-23092 Make the RM tooling in dev-tools/create-release generic URL: https://github.com/apache/hbase/pull/671#issuecomment-536255631 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HBASE-23054) Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm

2019-09-29 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940256#comment-16940256 ] Hudson commented on HBASE-23054: Results for branch branch-2.1 [build #1649 on

[GitHub] [hbase] saintstack opened a new pull request #671: HBASE-23092 Make the RM tooling in dev-tools/create-release generic

2019-09-29 Thread GitBox
saintstack opened a new pull request #671: HBASE-23092 Make the RM tooling in dev-tools/create-release generic URL: https://github.com/apache/hbase/pull/671 Make the scripts generic. Set PROJECT environment variable and away you go; e.g. set it to hbase-operator-tools or to

[jira] [Created] (HBASE-23092) Make the RM tooling in dev-tools/create-release generic

2019-09-29 Thread Michael Stack (Jira)
Michael Stack created HBASE-23092: - Summary: Make the RM tooling in dev-tools/create-release generic Key: HBASE-23092 URL: https://issues.apache.org/jira/browse/HBASE-23092 Project: HBase