[GitHub] [hbase] Apache-HBase commented on issue #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1
Apache-HBase commented on issue #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1 URL: https://github.com/apache/hbase/pull/251#issuecomment-537796056 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 9m 56s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :broken_heart: | hbaseanti | 0m 0s | The patch appears use Hadoop classification instead of HBase. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ branch-1 Compile Tests _ | | :blue_heart: | mvndep | 6m 23s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 3m 28s | branch-1 passed | | :green_heart: | compile | 1m 49s | branch-1 passed with JDK v1.8.0_222 | | :green_heart: | compile | 1m 57s | branch-1 passed with JDK v1.7.0_232 | | :green_heart: | checkstyle | 8m 44s | branch-1 passed | | :blue_heart: | refguide | 3m 38s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | :green_heart: | shadedjars | 3m 5s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 3m 11s | branch-1 passed with JDK v1.8.0_222 | | :green_heart: | javadoc | 5m 29s | branch-1 passed with JDK v1.7.0_232 | | :blue_heart: | spotbugs | 11m 28s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :blue_heart: | findbugs | 0m 18s | branch/hbase-resource-bundle no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 20s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 2m 4s | the patch passed | | :green_heart: | compile | 1m 54s | the patch passed with JDK v1.8.0_222 | | :green_heart: | javac | 1m 54s | the patch passed | | :green_heart: | compile | 1m 57s | the patch passed with JDK v1.7.0_232 | | :green_heart: | javac | 1m 57s | the patch passed | | :green_heart: | checkstyle | 0m 10s | The patch passed checkstyle in hbase-resource-bundle | | :green_heart: | checkstyle | 0m 30s | The patch passed checkstyle in hbase-common | | :green_heart: | checkstyle | 1m 44s | hbase-server: The patch generated 0 new + 78 unchanged - 11 fixed = 78 total (was 89) | | :green_heart: | checkstyle | 0m 30s | The patch passed checkstyle in hbase-it | | :green_heart: | checkstyle | 5m 49s | root: The patch generated 0 new + 87 unchanged - 11 fixed = 87 total (was 98) | | :broken_heart: | checkstyle | 0m 13s | hbase-tinylfu-blockcache: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :broken_heart: | xml | 0m 1s | The patch has 5 ill-formed XML file(s). | | :blue_heart: | refguide | 3m 13s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | :broken_heart: | shadedjars | 0m 15s | patch has 7 errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 5m 8s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | :broken_heart: | javadoc | 0m 12s | hbase-it in the patch failed with JDK v1.8.0_222. | | :broken_heart: | javadoc | 1m 46s | root in the patch failed with JDK v1.8.0_222. | | :broken_heart: | javadoc | 0m 11s | hbase-tinylfu-blockcache in the patch failed with JDK v1.7.0_232. | | :blue_heart: | findbugs | 0m 11s | hbase-resource-bundle has no data from findbugs | | :broken_heart: | findbugs | 0m 12s | hbase-tinylfu-blockcache in the patch failed. | ||| _ Other Tests _ | | :green_heart: | unit | 163m 56s | root in the patch passed. | | :green_heart: | asflicense | 2m 9s | The patch does not generate ASF License warnings. | | | | 282m 54s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | hbase-common/src/main/resources/hbase-default.xml | | | hbase-it/pom.xml | | | hbase-resource-bundle/src/main/resources/supplemental-models.xml | | | hbase-tinylfu-blockcache/pom.xml | | | pom.xml | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-251/20/artifact/out/Dockerfile | | GITHUB PR |
[jira] [Commented] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize in table.jsp
[ https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943342#comment-16943342 ] Karthik Palanisamy commented on HBASE-23115: Found the same issue on another page, rsgroup_jsp. Will post new commit shortly. > Unit change for StoreFileSize and MemStoreSize in table.jsp > --- > > Key: HBASE-23115 > URL: https://issues.apache.org/jira/browse/HBASE-23115 > Project: HBase > Issue Type: Bug > Components: metrics, UI >Affects Versions: 3.0.0 >Reporter: Karthik Palanisamy >Assignee: Karthik Palanisamy >Priority: Minor > Attachments: Units.pdf > > > StoreFileSize and MemstoreSize usually returned in MBs (link1, link2) but > table.jsp page have inaccurate unit. The reason is table.jsp (link3) use > org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform > longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on > length. The concern here (link4) is computation (ByteVal/1024/1024) will > output always lesser than 1 for store contains few bytes or few kbs. Also, > typecast will not round up to its nearest value. > I think the best option is changing unit in table.jsp instead of changing > code, otherwise we may end up doing many refactors from getMemStoreSizeMB, > setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB, > setStorefileSizeMB,.. > > Please find the attachment, a simple example is posted. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] karthikhw commented on issue #682: HBASE-23115 Unit change for StoreFileSize and MemstoreSize (table.jsp)
karthikhw commented on issue #682: HBASE-23115 Unit change for StoreFileSize and MemstoreSize (table.jsp) URL: https://github.com/apache/hbase/pull/682#issuecomment-537787086 The last commit is similar to previous one but in "Table Stat" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23066) Allow cache on write during compactions when prefetching is enabled
[ https://issues.apache.org/jira/browse/HBASE-23066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943319#comment-16943319 ] ramkrishna.s.vasudevan commented on HBASE-23066: [~jacob.leblanc] Can you create a PR using github? That will trigger the CI for running the tests. And it is easy to merge the patch too. > Allow cache on write during compactions when prefetching is enabled > --- > > Key: HBASE-23066 > URL: https://issues.apache.org/jira/browse/HBASE-23066 > Project: HBase > Issue Type: Improvement > Components: Compaction, regionserver >Affects Versions: 1.4.10 >Reporter: Jacob LeBlanc >Assignee: Jacob LeBlanc >Priority: Minor > Fix For: 1.5.0, 2.3.0 > > Attachments: HBASE-23066.patch, performance_results.png, > prefetchCompactedBlocksOnWrite.patch > > > In cases where users care a lot about read performance for tables that are > small enough to fit into a cache (or the cache is large enough), > prefetchOnOpen can be enabled to make the entire table available in cache > after the initial region opening is completed. Any new data can also be > guaranteed to be in cache with the cacheBlocksOnWrite setting. > However, the missing piece is when all blocks are evicted after a compaction. > We found very poor performance after compactions for tables under heavy read > load and a slower backing filesystem (S3). After a compaction the prefetching > threads need to compete with threads servicing read requests and get > constantly blocked as a result. > This is a proposal to introduce a new cache configuration option that would > cache blocks on write during compaction for any column family that has > prefetch enabled. This would virtually guarantee all blocks are kept in cache > after the initial prefetch on open is completed allowing for guaranteed > steady read performance despite a slow backing file system. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #683: HBASE-23110 Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm" to branch-1
Apache-HBase commented on issue #683: HBASE-23110 Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm" to branch-1 URL: https://github.com/apache/hbase/pull/683#issuecomment-53622 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 1m 20s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ branch-1 Compile Tests _ | | :green_heart: | mvninstall | 8m 36s | branch-1 passed | | :green_heart: | compile | 0m 40s | branch-1 passed with JDK v1.8.0_222 | | :green_heart: | compile | 0m 44s | branch-1 passed with JDK v1.7.0_232 | | :green_heart: | checkstyle | 1m 30s | branch-1 passed | | :green_heart: | shadedjars | 2m 57s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 35s | branch-1 passed with JDK v1.8.0_222 | | :green_heart: | javadoc | 0m 41s | branch-1 passed with JDK v1.7.0_232 | | :blue_heart: | spotbugs | 2m 48s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 2m 46s | branch-1 passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 2m 0s | the patch passed | | :green_heart: | compile | 0m 40s | the patch passed with JDK v1.8.0_222 | | :green_heart: | javac | 0m 40s | the patch passed | | :green_heart: | compile | 0m 45s | the patch passed with JDK v1.7.0_232 | | :green_heart: | javac | 0m 45s | the patch passed | | :broken_heart: | checkstyle | 1m 29s | hbase-server: The patch generated 1 new + 1 unchanged - 1 fixed = 2 total (was 2) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 2m 47s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 5m 0s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | :green_heart: | javadoc | 0m 32s | the patch passed with JDK v1.8.0_222 | | :green_heart: | javadoc | 0m 41s | the patch passed with JDK v1.7.0_232 | | :broken_heart: | findbugs | 2m 51s | hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | ||| _ Other Tests _ | | :broken_heart: | unit | 156m 34s | hbase-server in the patch failed. | | :green_heart: | asflicense | 0m 38s | The patch does not generate ASF License warnings. | | | | 197m 30s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | Unread field:LossyCounting.java:[line 56] | | | Unread field:LossyCounting.java:[line 57] | | Failed junit tests | hadoop.hbase.regionserver.TestRegionServerHostname | | | hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-683/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/683 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux bfca61c45b83 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-683/out/precommit/personality/provided.sh | | git revision | branch-1 / 0ffbf9c | | Default Java | 1.7.0_232 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_222 /usr/lib/jvm/zulu-7-amd64:1.7.0_232 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-683/1/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-683/1/artifact/out/new-findbugs-hbase-server.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-683/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-683/1/testReport/ | | Max. process+thread count | 4113 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-683/1/console |
[jira] [Commented] (HBASE-23112) [hbase-operator-tools] fixMeta in hbck2 is porcelain, in hbck1 it was plumbing; fix
[
https://issues.apache.org/jira/browse/HBASE-23112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943313#comment-16943313
]
Michael Stack commented on HBASE-23112:
---
Yeah. That no longer holds. Will fix that too. Wondering if we should label
usage with porcelain or plumbing tags or we should make a tool called 'fixMeta'
and another called 'filesystem'; i.e. break out porcelain commands as
standalone scripts?
> [hbase-operator-tools] fixMeta in hbck2 is porcelain, in hbck1 it was
> plumbing; fix
> ---
>
> Key: HBASE-23112
> URL: https://issues.apache.org/jira/browse/HBASE-23112
> Project: HBase
> Issue Type: Bug
> Components: hbase-operator-tools
>Reporter: Michael Stack
>Priority: Major
>
> From [~daisuke.kobayashi]:
> {code}
> Daisuke Kobayashi 6:45 PM
> ... One confusion here is fixMeta in hbck1 was a plumbing command whereas the
> new fixMeta in hbck2 is a porcelain command which fixes several issues behind
> the scene. Wonder if it's a good naming. Sorry for bothering you!
> if you don't wanna change the command name, it'd be better to have a clear
> documentation.
> {code}
> How about we add note to usage that makes it clear it is not same as hbck1
> and in the README where we talk about difference between hbck1 and hbck2, we
> talk up this command in particular; that users need to be careful expecting
> hbck1 behaviors even in case where commands are similarly named?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #682: HBASE-23115 Unit change for StoreFileSize and MemstoreSize (table.jsp)
Apache-HBase commented on issue #682: HBASE-23115 Unit change for StoreFileSize and MemstoreSize (table.jsp) URL: https://github.com/apache/hbase/pull/682#issuecomment-537748552 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :yellow_heart: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | :green_heart: | mvninstall | 5m 28s | master passed | | :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 5m 4s | the patch passed | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | javadoc | 0m 40s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 161m 44s | hbase-server in the patch passed. | | :green_heart: | asflicense | 0m 35s | The patch does not generate ASF License warnings. | | | | 175m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-682/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/682 | | Optional Tests | dupname asflicense javac javadoc unit | | uname | Linux dd8690e451bb 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-682/out/precommit/personality/provided.sh | | git revision | master / 7ee6d59ef8 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-682/1/testReport/ | | Max. process+thread count | 4483 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-682/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule
Apache-HBase commented on issue #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule URL: https://github.com/apache/hbase/pull/677#issuecomment-537744666 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 34s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | :green_heart: | mvninstall | 5m 27s | master passed | | :green_heart: | compile | 0m 55s | master passed | | :green_heart: | checkstyle | 1m 22s | master passed | | :green_heart: | shadedjars | 4m 37s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 39s | master passed | | :blue_heart: | spotbugs | 4m 11s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 4m 9s | master passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 4m 59s | the patch passed | | :green_heart: | compile | 0m 55s | the patch passed | | :green_heart: | javac | 0m 55s | the patch passed | | :broken_heart: | checkstyle | 1m 20s | hbase-server: The patch generated 17 new + 86 unchanged - 19 fixed = 103 total (was 105) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 4m 37s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 15m 43s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 0m 34s | the patch passed | | :green_heart: | findbugs | 4m 8s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 161m 34s | hbase-server in the patch passed. | | :green_heart: | asflicense | 0m 35s | The patch does not generate ASF License warnings. | | | | 218m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-677/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/677 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e02a6dfc3045 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-677/out/precommit/personality/provided.sh | | git revision | master / 7ee6d59ef8 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-677/3/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-677/3/testReport/ | | Max. process+thread count | 4915 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-677/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23112) [hbase-operator-tools] fixMeta in hbck2 is porcelain, in hbck1 it was plumbing; fix
[
https://issues.apache.org/jira/browse/HBASE-23112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943274#comment-16943274
]
Daisuke Kobayashi commented on HBASE-23112:
---
Thanks for raising this Stack! Yea, it'd be nice to have better explanation
regarding that change. In addition to that, given that the current HBCK2 has
both porcelain and plumbing commands, should we rethink, or reword, the
following philosophy too?
{code}
HBCK2 performs a single discrete 'fix' task each time it is run. It does not
presume a tool can analyze all about the running cluster and then repair 'all
problems' found as hbck1 used suggest. HBCK2 is a tool that is more in the vein
of plumbing than porcelain.
{code}
> [hbase-operator-tools] fixMeta in hbck2 is porcelain, in hbck1 it was
> plumbing; fix
> ---
>
> Key: HBASE-23112
> URL: https://issues.apache.org/jira/browse/HBASE-23112
> Project: HBase
> Issue Type: Bug
> Components: hbase-operator-tools
>Reporter: Michael Stack
>Priority: Major
>
> From [~daisuke.kobayashi]:
> {code}
> Daisuke Kobayashi 6:45 PM
> ... One confusion here is fixMeta in hbck1 was a plumbing command whereas the
> new fixMeta in hbck2 is a porcelain command which fixes several issues behind
> the scene. Wonder if it's a good naming. Sorry for bothering you!
> if you don't wanna change the command name, it'd be better to have a clear
> documentation.
> {code}
> How about we add note to usage that makes it clear it is not same as hbck1
> and in the README where we talk about difference between hbck1 and hbck2, we
> talk up this command in particular; that users need to be careful expecting
> hbck1 behaviors even in case where commands are similarly named?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] apurtell commented on issue #683: HBASE-23110 Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm" to branch-1
apurtell commented on issue #683: HBASE-23110 Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm" to branch-1 URL: https://github.com/apache/hbase/pull/683#issuecomment-537741651 [INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running org.apache.hadoop.hbase.util.TestLossyCounting [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.881 s - in org.apache.hadoop.hbase.util.TestLossyCounting [INFO] Running org.apache.hadoop.hbase.coprocessor.TestMetaTableMetrics [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 36.004 s - in org.apache.hadoop.hbase.coprocessor.TestMetaTableMetrics This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23110) Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm" to branch-1
[ https://issues.apache.org/jira/browse/HBASE-23110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943269#comment-16943269 ] Andrew Kyle Purtell commented on HBASE-23110: - Opened PR#683 > Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and > fix LossyCounting algorithm" to branch-1 > - > > Key: HBASE-23110 > URL: https://issues.apache.org/jira/browse/HBASE-23110 > Project: HBase > Issue Type: Sub-task > Components: metrics >Reporter: Duo Zhang >Assignee: Andrew Kyle Purtell >Priority: Major > Fix For: 1.5.0, 1.4.11 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23110) Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm" to branch-1
[ https://issues.apache.org/jira/browse/HBASE-23110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-23110: Status: Patch Available (was: Open) > Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and > fix LossyCounting algorithm" to branch-1 > - > > Key: HBASE-23110 > URL: https://issues.apache.org/jira/browse/HBASE-23110 > Project: HBase > Issue Type: Sub-task > Components: metrics >Reporter: Duo Zhang >Assignee: Andrew Kyle Purtell >Priority: Major > Fix For: 1.5.0, 1.4.11 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] apurtell opened a new pull request #683: HBASE-23110 Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm" to branch-1
apurtell opened a new pull request #683: HBASE-23110 Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm" to branch-1 URL: https://github.com/apache/hbase/pull/683 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943265#comment-16943265
]
Bharath Vissapragada edited comment on HBASE-23116 at 10/3/19 12:39 AM:
[~apurtell] Thanks. I'll submit a PR for master and will figure out the back
port mechanics for 1.x and 2.x branches.
was (Author: bharathv):
[~apurtell] Thanks. I'll submit a PR for master and will figure out the back
port mechanics to 1.x and 2.x branches.
> LoadBalancer should log table name when balancing per table
> ---
>
> Key: HBASE-23116
> URL: https://issues.apache.org/jira/browse/HBASE-23116
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.5.0
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2
>
>
> The load balancer logs lines like these:
> {noformat}
> 2019-10-02 23:18:47,664 INFO [46493_ChoreService_6]
> balancer.StochasticLoadBalancer - Skipping load balancing because balanced
> cluster; total cost is 46.68964334022376, sum multiplier is 1087.0 min cost
> which need balance is 0.05
> {noformat}
> When balancing per table it would be useful if the table name was also
> printed in the log line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943265#comment-16943265
]
Bharath Vissapragada commented on HBASE-23116:
--
[~apurtell] Thanks. I'll submit a PR for master and will figure out the back
port mechanics to 1.x and 2.x branches.
> LoadBalancer should log table name when balancing per table
> ---
>
> Key: HBASE-23116
> URL: https://issues.apache.org/jira/browse/HBASE-23116
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.5.0
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2
>
>
> The load balancer logs lines like these:
> {noformat}
> 2019-10-02 23:18:47,664 INFO [46493_ChoreService_6]
> balancer.StochasticLoadBalancer - Skipping load balancing because balanced
> cluster; total cost is 46.68964334022376, sum multiplier is 1087.0 min cost
> which need balance is 0.05
> {noformat}
> When balancing per table it would be useful if the table name was also
> printed in the log line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943264#comment-16943264
]
Andrew Kyle Purtell commented on HBASE-23116:
-
[~bharathv] Have at it! I assigned this to you. I also added you as a
contributor on the project so in the future you can assign issues to yourself.
> LoadBalancer should log table name when balancing per table
> ---
>
> Key: HBASE-23116
> URL: https://issues.apache.org/jira/browse/HBASE-23116
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.5.0
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2
>
>
> The load balancer logs lines like these:
> {noformat}
> 2019-10-02 23:18:47,664 INFO [46493_ChoreService_6]
> balancer.StochasticLoadBalancer - Skipping load balancing because balanced
> cluster; total cost is 46.68964334022376, sum multiplier is 1087.0 min cost
> which need balance is 0.05
> {noformat}
> When balancing per table it would be useful if the table name was also
> printed in the log line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell reassigned HBASE-23116:
---
Assignee: Bharath Vissapragada
> LoadBalancer should log table name when balancing per table
> ---
>
> Key: HBASE-23116
> URL: https://issues.apache.org/jira/browse/HBASE-23116
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.5.0
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2
>
>
> The load balancer logs lines like these:
> {noformat}
> 2019-10-02 23:18:47,664 INFO [46493_ChoreService_6]
> balancer.StochasticLoadBalancer - Skipping load balancing because balanced
> cluster; total cost is 46.68964334022376, sum multiplier is 1087.0 min cost
> which need balance is 0.05
> {noformat}
> When balancing per table it would be useful if the table name was also
> printed in the log line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943263#comment-16943263
]
Bharath Vissapragada commented on HBASE-23116:
--
[~apurtell] I'm new to the HBase project and I'm poking around in the code.
This seems like a newbie task that helps me understand the review process. Can
I assign it to myself?
> LoadBalancer should log table name when balancing per table
> ---
>
> Key: HBASE-23116
> URL: https://issues.apache.org/jira/browse/HBASE-23116
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.5.0
>Reporter: Andrew Kyle Purtell
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2
>
>
> The load balancer logs lines like these:
> {noformat}
> 2019-10-02 23:18:47,664 INFO [46493_ChoreService_6]
> balancer.StochasticLoadBalancer - Skipping load balancing because balanced
> cluster; total cost is 46.68964334022376, sum multiplier is 1087.0 min cost
> which need balance is 0.05
> {noformat}
> When balancing per table it would be useful if the table name was also
> printed in the log line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HBASE-23116) LoadBalancer should log table name when balancing per table
Andrew Kyle Purtell created HBASE-23116:
---
Summary: LoadBalancer should log table name when balancing per
table
Key: HBASE-23116
URL: https://issues.apache.org/jira/browse/HBASE-23116
Project: HBase
Issue Type: Improvement
Affects Versions: 1.5.0
Reporter: Andrew Kyle Purtell
Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2
The load balancer logs lines like these:
{noformat}
2019-10-02 23:18:47,664 INFO [46493_ChoreService_6]
balancer.StochasticLoadBalancer - Skipping load balancing because balanced
cluster; total cost is 46.68964334022376, sum multiplier is 1087.0 min cost
which need balance is 0.05
{noformat}
When balancing per table it would be useful if the table name was also printed
in the log line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22380) break circle replication when doing bulkload
[
https://issues.apache.org/jira/browse/HBASE-22380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943248#comment-16943248
]
Hudson commented on HBASE-22380:
Results for branch branch-1.3
[build #993 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/993/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/993//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/993//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/993//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> break circle replication when doing bulkload
>
>
> Key: HBASE-22380
> URL: https://issues.apache.org/jira/browse/HBASE-22380
> Project: HBase
> Issue Type: Bug
> Components: Replication
>Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.5, 2.3.0, 2.1.5, 1.3.5
>Reporter: chenxu
>Assignee: Wellington Chevreuil
>Priority: Critical
> Labels: bulkload
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
> Attachments: HBASE-22380.branch-2.1.0001.patch,
> HBASE-22380.branch-2.1.0003.patch, HBASE-22380.branch-2.1.0004.patch
>
>
> when enabled master-master bulkload replication, HFiles will be replicated
> circularly between two clusters
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-11062) hbtop
[
https://issues.apache.org/jira/browse/HBASE-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943246#comment-16943246
]
Hudson commented on HBASE-11062:
Results for branch branch-1.3
[build #993 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/993/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/993//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/993//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/993//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> hbtop
> -
>
> Key: HBASE-11062
> URL: https://issues.apache.org/jira/browse/HBASE-11062
> Project: HBase
> Issue Type: New Feature
> Components: hbtop
>Reporter: Andrew Kyle Purtell
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
> Attachments: HBASE-11062-master-addendum-v1.patch
>
>
> A top-like monitor could be useful for testing, debugging, operations of
> clusters of moderate size, and possibly for diagnosing issues in large
> clusters.
> Consider a curses interface like the one presented by atop
> (http://www.atoptool.nl/images/screenshots/genericw.png) - with aggregate
> metrics collected over a monitoring interval in the upper portion of the
> pane, and a listing of discrete measurements sorted and filtered by various
> criteria in the bottom part of the pane. One might imagine a cluster overview
> with cluster aggregate metrics above and a list of regionservers sorted by
> utilization below; and a regionserver view with process metrics above and a
> list of metrics by operation type below, or a list of client connections, or
> a list of threads, sorted by utilization, throughput, or latency.
> Generically 'htop' is taken but would be distinctive in the HBase context, a
> utility org.apache.hadoop.hbase.HTop
> No need necessarily for a curses interface. Could be an external monitor with
> a web front end as has been discussed before. I do like the idea of a process
> that runs in a terminal because I interact with dev and test HBase clusters
> exclusively by SSH.
> UPDATE:
> The tool name is changed from htop to hbtop.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22988) Backport HBASE-11062 "hbtop" to branch-1
[
https://issues.apache.org/jira/browse/HBASE-22988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943245#comment-16943245
]
Hudson commented on HBASE-22988:
Results for branch branch-1.3
[build #993 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/993/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/993//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/993//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/993//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Backport HBASE-11062 "hbtop" to branch-1
>
>
> Key: HBASE-22988
> URL: https://issues.apache.org/jira/browse/HBASE-22988
> Project: HBase
> Issue Type: Sub-task
> Components: backport, hbtop
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22988-branch-1.patch
>
>
> Backport parent issue to branch-1.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23101) Backport HBASE-22380 to branch-1
[
https://issues.apache.org/jira/browse/HBASE-23101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943247#comment-16943247
]
Hudson commented on HBASE-23101:
Results for branch branch-1.3
[build #993 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/993/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/993//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/993//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/993//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Backport HBASE-22380 to branch-1
>
>
> Key: HBASE-23101
> URL: https://issues.apache.org/jira/browse/HBASE-23101
> Project: HBase
> Issue Type: Sub-task
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-16213) A new HFileBlock structure for fast random get
[ https://issues.apache.org/jira/browse/HBASE-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943237#comment-16943237 ] Jean-Marc Spaggiari commented on HBASE-16213: - Is there any follow-up JIRA fot V2 and V3? > A new HFileBlock structure for fast random get > -- > > Key: HBASE-16213 > URL: https://issues.apache.org/jira/browse/HBASE-16213 > Project: HBase > Issue Type: New Feature > Components: Performance >Reporter: Lijin Bin >Assignee: Lijin Bin >Priority: Major > Fix For: 1.4.0, 2.0.0 > > Attachments: HBASE-16213-master_v1.patch, > HBASE-16213-master_v3.patch, HBASE-16213-master_v4.patch, > HBASE-16213-master_v5.patch, HBASE-16213-master_v6.patch, > HBASE-16213.branch-1.v1.patch, HBASE-16213.branch-1.v4.patch, > HBASE-16213.branch-1.v4.patch, HBASE-16213.patch, > HBASE-16213_branch1_v3.patch, HBASE-16213_v2.patch, hfile-cpu.png, > hfile_block_performance.pptx, hfile_block_performance2.pptx, > hfile_block_performance_E2E.pptx > > > HFileBlock store cells sequential, current when to get a row from the block, > it scan from the first cell until the row's cell. > The new structure store every row's start offset with data, so it can find > the exact row with binarySearch. > I use EncodedSeekPerformanceTest test the performance. > First use ycsb write 100w data, every row have only one qualifier, and > valueLength=16B/64/256B/1k. > Then use EncodedSeekPerformanceTest to test random read 1w or 100w row, and > also record HFileBlock's dataSize/dataWithMetaSize in the encoding. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] karthikhw commented on a change in pull request #674: HBASE-23095 Reuse FileStatus in StoreFileInfo
karthikhw commented on a change in pull request #674: HBASE-23095 Reuse
FileStatus in StoreFileInfo
URL: https://github.com/apache/hbase/pull/674#discussion_r330809819
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java
##
@@ -109,6 +111,11 @@
*/
public StoreFileInfo(final Configuration conf, final FileSystem fs, final
Path initialPath)
throws IOException {
+this(conf, fs, initialPath, null, null);
+ }
+
+ private StoreFileInfo(final Configuration conf, final FileSystem fs, final
Path initialPath,
+ final Long createdTimestamp, final Long size) throws IOException {
Review comment:
Appreciate Duo @Apache9 if you get some time for review :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize in table.jsp
[ https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943218#comment-16943218 ] Karthik Palanisamy commented on HBASE-23115: Sorry for the spamming messages, it looks to me links are not reflecting correctly. link1 : [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668] link2 : [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1656|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668] link3 : [https://github.com/apache/hbase/blob/master/hbase-server/src/main/resources/hbase-webapps/master/table.jsp#L488] link4 : [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668] > Unit change for StoreFileSize and MemStoreSize in table.jsp > --- > > Key: HBASE-23115 > URL: https://issues.apache.org/jira/browse/HBASE-23115 > Project: HBase > Issue Type: Bug > Components: metrics, UI >Affects Versions: 3.0.0 >Reporter: Karthik Palanisamy >Assignee: Karthik Palanisamy >Priority: Minor > Attachments: Units.pdf > > > StoreFileSize and MemstoreSize usually returned in MBs (link1, link2) but > table.jsp page have inaccurate unit. The reason is table.jsp (link3) use > org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform > longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on > length. The concern here (link4) is computation (ByteVal/1024/1024) will > output always lesser than 1 for store contains few bytes or few kbs. Also, > typecast will not round up to its nearest value. > I think the best option is changing unit in table.jsp instead of changing > code, otherwise we may end up doing many refactors from getMemStoreSizeMB, > setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB, > setStorefileSizeMB,.. > > Please find the attachment, a simple example is posted. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize in table.jsp
[ https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthik Palanisamy updated HBASE-23115: --- Description: StoreFileSize and MemstoreSize usually returned in MBs (link1, link2) but table.jsp page have inaccurate unit. The reason is table.jsp (link3) use org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on length. The concern here (link4) is computation (ByteVal/1024/1024) will output always lesser than 1 for store contains few bytes or few kbs. Also, typecast will not round up to its nearest value. I think the best option is changing unit in table.jsp instead of changing code, otherwise we may end up doing many refactors from getMemStoreSizeMB, setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB, setStorefileSizeMB,.. Please find the attachment, a simple example is posted. was: StoreFileSize and MemstoreSize usually returned in MBs ([link|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668%7Chttps://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java%23L1668]] ], [link| [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1656|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1656]] ]) but table.jsp page have inaccurate unit. The reason is table.jsp ([link| [https://github.com/apache/hbase/blob/master/hbase-server/src/main/resources/hbase-webapps/master/table.jsp#L488] ]) use org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on length. The concern [here| [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668] ] is computation (ByteVal/1024/1024) will output always lesser than 1 for store contains few bytes or few kbs. Also, typecast will not round up to its nearest value. I think the best option is changing unit in table.jsp instead of changing code, otherwise we may end up doing many refactors from getMemStoreSizeMB, setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB, setStorefileSizeMB,.. Please find the attachment, a simple example is posted. > Unit change for StoreFileSize and MemStoreSize in table.jsp > --- > > Key: HBASE-23115 > URL: https://issues.apache.org/jira/browse/HBASE-23115 > Project: HBase > Issue Type: Bug > Components: metrics, UI >Affects Versions: 3.0.0 >Reporter: Karthik Palanisamy >Assignee: Karthik Palanisamy >Priority: Minor > Attachments: Units.pdf > > > StoreFileSize and MemstoreSize usually returned in MBs (link1, link2) but > table.jsp page have inaccurate unit. The reason is table.jsp (link3) use > org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform > longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on > length. The concern here (link4) is computation (ByteVal/1024/1024) will > output always lesser than 1 for store contains few bytes or few kbs. Also, > typecast will not round up to its nearest value. > I think the best option is changing unit in table.jsp instead of changing > code, otherwise we may end up doing many refactors from getMemStoreSizeMB, > setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB, > setStorefileSizeMB,.. > > Please find the attachment, a simple example is posted. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize in table.jsp
[ https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthik Palanisamy updated HBASE-23115: --- Description: StoreFileSize and MemstoreSize usually returned in MBs ([link|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668%7Chttps://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java%23L1668]] ], [link| [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1656|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1656]] ]) but table.jsp page have inaccurate unit. The reason is table.jsp ([link| [https://github.com/apache/hbase/blob/master/hbase-server/src/main/resources/hbase-webapps/master/table.jsp#L488] ]) use org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on length. The concern [here| [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668] ] is computation (ByteVal/1024/1024) will output always lesser than 1 for store contains few bytes or few kbs. Also, typecast will not round up to its nearest value. I think the best option is changing unit in table.jsp instead of changing code, otherwise we may end up doing many refactors from getMemStoreSizeMB, setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB, setStorefileSizeMB,.. Please find the attachment, a simple example is posted. was: StoreFileSize and MemstoreSize usually returned in MBs ([link|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668]]] , [link|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1656]]) but table.jsp page have inaccurate unit. The reason is table.jsp ([link|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/resources/hbase-webapps/master/table.jsp#L488|https://github.com/apache/hbase/blob/master/hbase-server/src/main/resources/hbase-webapps/master/table.jsp#L488]]]) use org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on length. The concern [here|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668]] is computation (ByteVal/1024/1024) will output always lesser than 1 for store contains few bytes or few kbs. Also, typecast will not round up to its nearest value. I think the best option is changing unit in table.jsp instead of changing code, otherwise we may end up doing many refactors from getMemStoreSizeMB, setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB, setStorefileSizeMB,.. Please find the attachment, a simple example is posted. > Unit change for StoreFileSize and MemStoreSize in table.jsp > --- > > Key: HBASE-23115 > URL: https://issues.apache.org/jira/browse/HBASE-23115 > Project: HBase > Issue Type: Bug > Components: metrics, UI >Affects Versions: 3.0.0 >Reporter: Karthik Palanisamy >Assignee: Karthik Palanisamy >Priority: Minor > Attachments: Units.pdf > > > StoreFileSize and MemstoreSize usually returned in MBs > ([link|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668%7Chttps://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java%23L1668]] > ], [link| > [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1656|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1656]] > ]) but table.jsp page have inaccurate unit. The reason is table.jsp ([link| > [https://github.com/apache/hbase/blob/master/hbase-server/src/main/resources/hbase-webapps/master/table.jsp#L488] > ]) use
[jira] [Updated] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize in table.jsp
[ https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthik Palanisamy updated HBASE-23115: --- Description: StoreFileSize and MemstoreSize usually returned in MBs ([link|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668]]] , [link|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1656]]) but table.jsp page have inaccurate unit. The reason is table.jsp ([link|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/resources/hbase-webapps/master/table.jsp#L488|https://github.com/apache/hbase/blob/master/hbase-server/src/main/resources/hbase-webapps/master/table.jsp#L488]]]) use org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on length. The concern [here|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668]] is computation (ByteVal/1024/1024) will output always lesser than 1 for store contains few bytes or few kbs. Also, typecast will not round up to its nearest value. I think the best option is changing unit in table.jsp instead of changing code, otherwise we may end up doing many refactors from getMemStoreSizeMB, setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB, setStorefileSizeMB,.. Please find the attachment, a simple example is posted. was: StoreFileSize and MemstoreSize usually returned in MBs ([link|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668]], [link|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1656]]) but table.jsp page have inaccurate unit. The reason is table.jsp ([link|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/resources/hbase-webapps/master/table.jsp#L488]]) use org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on length. The concern [here|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668]] is computation (ByteVal/1024/1024) will output always lesser than 1 for store contains few bytes or few kbs. Also, typecast will not round up to its nearest value. I think the best option is changing unit in table.jsp instead of changing code, otherwise we may end up doing many refactors from getMemStoreSizeMB, setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB, setStorefileSizeMB,.. Please find the attachment, a simple example is posted. > Unit change for StoreFileSize and MemStoreSize in table.jsp > --- > > Key: HBASE-23115 > URL: https://issues.apache.org/jira/browse/HBASE-23115 > Project: HBase > Issue Type: Bug > Components: metrics, UI >Affects Versions: 3.0.0 >Reporter: Karthik Palanisamy >Assignee: Karthik Palanisamy >Priority: Minor > Attachments: Units.pdf > > > StoreFileSize and MemstoreSize usually returned in MBs > ([link|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668]]] > , > [link|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1656]]) > but table.jsp page have inaccurate unit. The reason is table.jsp > ([link|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/resources/hbase-webapps/master/table.jsp#L488|https://github.com/apache/hbase/blob/master/hbase-server/src/main/resources/hbase-webapps/master/table.jsp#L488]]]) > use org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform > longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on > length. The concern > [here|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668]] > is computation (ByteVal/1024/1024) will output always lesser than 1 for > store contains few bytes or few kbs. Also, typecast will not round up to its > nearest value. > I think the best option is changing unit in table.jsp instead of changing >
[GitHub] [hbase] karthikhw opened a new pull request #682: HBASE-23115 Unit change for StoreFileSize and MemstoreSize (table.jsp)
karthikhw opened a new pull request #682: HBASE-23115 Unit change for StoreFileSize and MemstoreSize (table.jsp) URL: https://github.com/apache/hbase/pull/682 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize in table.jsp
Karthik Palanisamy created HBASE-23115: -- Summary: Unit change for StoreFileSize and MemStoreSize in table.jsp Key: HBASE-23115 URL: https://issues.apache.org/jira/browse/HBASE-23115 Project: HBase Issue Type: Bug Components: metrics, UI Affects Versions: 3.0.0 Reporter: Karthik Palanisamy Assignee: Karthik Palanisamy Attachments: Units.pdf StoreFileSize and MemstoreSize usually returned in MBs ([link|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668]], [link|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1656]]) but table.jsp page have inaccurate unit. The reason is table.jsp ([link|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/resources/hbase-webapps/master/table.jsp#L488]]) use org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on length. The concern [here|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668]] is computation (ByteVal/1024/1024) will output always lesser than 1 for store contains few bytes or few kbs. Also, typecast will not round up to its nearest value. I think the best option is changing unit in table.jsp instead of changing code, otherwise we may end up doing many refactors from getMemStoreSizeMB, setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB, setStorefileSizeMB,.. Please find the attachment, a simple example is posted. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] PierreZ commented on issue #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule
PierreZ commented on issue #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule URL: https://github.com/apache/hbase/pull/677#issuecomment-537695399 I need to add a few more tests before it can be merged, for example load the rule file from HDFS, and more cases on the balancing itself. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23106) [HBCK2/hbase-operator-tools] Add a WAL verifier
[ https://issues.apache.org/jira/browse/HBASE-23106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943179#comment-16943179 ] Michael Stack commented on HBASE-23106: --- The files under the recovered.edits folder could use this too. They have same format. > [HBCK2/hbase-operator-tools] Add a WAL verifier > --- > > Key: HBASE-23106 > URL: https://issues.apache.org/jira/browse/HBASE-23106 > Project: HBase > Issue Type: Sub-task >Reporter: Michael Stack >Priority: Major > > We had a WALPlayer that loads edits up into hbase cluster but what I wanted > yesterday was a WAL verifier so I could find the bad WAL messing me up. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-22380) break circle replication when doing bulkload
[ https://issues.apache.org/jira/browse/HBASE-22380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943145#comment-16943145 ] Hudson commented on HBASE-22380: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #648 (See [https://builds.apache.org/job/HBase-1.3-IT/648/]) HBASE-23101 Backport HBASE-22380 to branch-1 (apurtell: rev 84f95fc18c6ff7fdc4bf0a39eaa23c94079be643) * (add) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoadReplication.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/SecureBulkLoadClient.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java * (edit) hbase-protocol/src/main/protobuf/SecureBulkLoad.proto * (edit) hbase-protocol/src/main/protobuf/WAL.proto * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoad.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java * (edit) hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java * (edit) hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/SecureBulkLoadProtos.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * (edit) hbase-protocol/src/main/protobuf/Client.proto * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/SecureBulkLoadEndpoint.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java * (edit) hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/WALProtos.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HFileReplicator.java > break circle replication when doing bulkload > > > Key: HBASE-22380 > URL: https://issues.apache.org/jira/browse/HBASE-22380 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.5, 2.3.0, 2.1.5, 1.3.5 >Reporter: chenxu >Assignee: Wellington Chevreuil >Priority: Critical > Labels: bulkload > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > Attachments: HBASE-22380.branch-2.1.0001.patch, > HBASE-22380.branch-2.1.0003.patch, HBASE-22380.branch-2.1.0004.patch > > > when enabled master-master bulkload replication, HFiles will be replicated > circularly between two clusters -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23101) Backport HBASE-22380 to branch-1
[ https://issues.apache.org/jira/browse/HBASE-23101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943144#comment-16943144 ] Hudson commented on HBASE-23101: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #648 (See [https://builds.apache.org/job/HBase-1.3-IT/648/]) HBASE-23101 Backport HBASE-22380 to branch-1 (apurtell: rev 84f95fc18c6ff7fdc4bf0a39eaa23c94079be643) * (add) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoadReplication.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/SecureBulkLoadClient.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java * (edit) hbase-protocol/src/main/protobuf/SecureBulkLoad.proto * (edit) hbase-protocol/src/main/protobuf/WAL.proto * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoad.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java * (edit) hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java * (edit) hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/SecureBulkLoadProtos.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * (edit) hbase-protocol/src/main/protobuf/Client.proto * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/SecureBulkLoadEndpoint.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java * (edit) hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/WALProtos.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HFileReplicator.java > Backport HBASE-22380 to branch-1 > > > Key: HBASE-23101 > URL: https://issues.apache.org/jira/browse/HBASE-23101 > Project: HBase > Issue Type: Sub-task >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Blocker > Fix For: 1.5.0, 1.3.6, 1.4.11 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23101) Backport HBASE-22380 to branch-1
[ https://issues.apache.org/jira/browse/HBASE-23101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943134#comment-16943134 ] Andrew Kyle Purtell commented on HBASE-23101: - Pushed to branch-1, branch-1.4, and branch-1.3. branch-1.4 just needed regen of protobuf. branch-1.3 needed that plus minor fixups in LoadIncrementalHFiles and RSRpcServices. > Backport HBASE-22380 to branch-1 > > > Key: HBASE-23101 > URL: https://issues.apache.org/jira/browse/HBASE-23101 > Project: HBase > Issue Type: Sub-task >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Blocker > Fix For: 1.5.0, 1.3.6, 1.4.11 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23101) Backport HBASE-22380 to branch-1
[ https://issues.apache.org/jira/browse/HBASE-23101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell resolved HBASE-23101. - Fix Version/s: 1.4.11 1.3.6 Hadoop Flags: Reviewed Resolution: Fixed > Backport HBASE-22380 to branch-1 > > > Key: HBASE-23101 > URL: https://issues.apache.org/jira/browse/HBASE-23101 > Project: HBase > Issue Type: Sub-task >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Blocker > Fix For: 1.5.0, 1.3.6, 1.4.11 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #681: HBASE-23114 Use archiveArtifacts in Jenkinsfiles
Apache-HBase commented on issue #681: HBASE-23114 Use archiveArtifacts in Jenkinsfiles URL: https://github.com/apache/hbase/pull/681#issuecomment-537661284 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 3m 2s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :blue_heart: | shelldocs | 0m 0s | Shelldocs was not available. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | :blue_heart: | mvndep | 0m 34s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 10s | Maven dependency ordering for patch | | :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | :blue_heart: | asflicense | 0m 0s | ASF License check generated no output? | | | | 4m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-681/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/681 | | Optional Tests | dupname asflicense shellcheck shelldocs | | uname | Linux 8345341eca24 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-681/out/precommit/personality/provided.sh | | git revision | master / 7ee6d59ef8 | | Max. process+thread count | 47 (vs. ulimit of 1) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-681/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase
[
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943129#comment-16943129
]
Hudson commented on HBASE-22514:
Results for branch HBASE-22514
[build #135 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/135/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/135//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/135//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/135//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/135//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
> Issue Type: Umbrella
> Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch,
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public
> we need to use java api RSGroupAdminClient to manager RSG
> so RSGroupAdminClient should be public
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #681: HBASE-23114 Use archiveArtifacts in Jenkinsfiles
Apache-HBase commented on issue #681: HBASE-23114 Use archiveArtifacts in Jenkinsfiles URL: https://github.com/apache/hbase/pull/681#issuecomment-537658687 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 0s | Docker mode activated. | | :broken_heart: | docker | 2m 5s | Docker failed to build yetus/hbase:1cb4f687c1. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/681 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-681/1/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #680: HBASE-23101 Backport HBASE-22380 to branch-1
Apache-HBase commented on issue #680: HBASE-23101 Backport HBASE-22380 to branch-1 URL: https://github.com/apache/hbase/pull/680#issuecomment-537657502 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 51s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :blue_heart: | prototool | 0m 1s | prototool was not available. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. | ||| _ branch-1 Compile Tests _ | | :blue_heart: | mvndep | 6m 27s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 3m 57s | branch-1 passed | | :green_heart: | compile | 1m 36s | branch-1 passed with JDK v1.8.0_222 | | :green_heart: | compile | 1m 44s | branch-1 passed with JDK v1.7.0_232 | | :green_heart: | checkstyle | 5m 39s | branch-1 passed | | :green_heart: | shadedjars | 2m 57s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 1m 3s | branch-1 passed with JDK v1.8.0_222 | | :green_heart: | javadoc | 1m 18s | branch-1 passed with JDK v1.7.0_232 | | :blue_heart: | spotbugs | 2m 37s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 6m 5s | branch-1 passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 14s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 1m 58s | the patch passed | | :green_heart: | compile | 1m 24s | the patch passed with JDK v1.8.0_222 | | :green_heart: | cc | 1m 24s | the patch passed | | :green_heart: | javac | 1m 24s | the patch passed | | :green_heart: | compile | 1m 34s | the patch passed with JDK v1.7.0_232 | | :green_heart: | cc | 1m 34s | the patch passed | | :green_heart: | javac | 1m 34s | the patch passed | | :broken_heart: | checkstyle | 0m 48s | hbase-client: The patch generated 16 new + 463 unchanged - 0 fixed = 479 total (was 463) | | :broken_heart: | checkstyle | 1m 49s | hbase-server: The patch generated 5 new + 734 unchanged - 2 fixed = 739 total (was 736) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 2m 45s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 4m 59s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | :green_heart: | hbaseprotoc | 1m 54s | the patch passed | | :broken_heart: | javadoc | 0m 20s | hbase-client-jdk1.8.0_222 with JDK v1.8.0_222 generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13) | | :broken_heart: | javadoc | 0m 24s | hbase-client-jdk1.7.0_232 with JDK v1.7.0_232 generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13) | | :green_heart: | findbugs | 6m 50s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 0m 30s | hbase-protocol in the patch passed. | | :green_heart: | unit | 2m 44s | hbase-client in the patch passed. | | :broken_heart: | unit | 121m 11s | hbase-server in the patch failed. | | :green_heart: | asflicense | 1m 11s | The patch does not generate ASF License warnings. | | | | 190m 39s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.TestMasterOperationsForRegionReplicas | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-680/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/680 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool | | uname | Linux 8d81e7f7b703 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-680/out/precommit/personality/provided.sh | | git revision | branch-1 / dd9eadb | | Default Java | 1.7.0_232 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_222 /usr/lib/jvm/zulu-7-amd64:1.7.0_232 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-680/1/artifact/out/diff-checkstyle-hbase-client.txt | | checkstyle |
[GitHub] [hbase] petersomogyi opened a new pull request #681: HBASE-23114 Use archiveArtifacts in Jenkinsfiles
petersomogyi opened a new pull request #681: HBASE-23114 Use archiveArtifacts in Jenkinsfiles URL: https://github.com/apache/hbase/pull/681 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-23114) Use archiveArtifacts in Jenkinsfiles
Peter Somogyi created HBASE-23114:
-
Summary: Use archiveArtifacts in Jenkinsfiles
Key: HBASE-23114
URL: https://issues.apache.org/jira/browse/HBASE-23114
Project: HBase
Issue Type: Improvement
Reporter: Peter Somogyi
Assignee: Peter Somogyi
The used archive step is deprecated:
{{The archive step is deprecated, please use archiveArtifacts instead.}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23109) [hbase-operator-tools] Fix checkstyle issues
[ https://issues.apache.org/jira/browse/HBASE-23109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-23109: -- Resolution: Fixed Status: Resolved (was: Patch Available) Merged #39 to master. > [hbase-operator-tools] Fix checkstyle issues > > > Key: HBASE-23109 > URL: https://issues.apache.org/jira/browse/HBASE-23109 > Project: HBase > Issue Type: Improvement > Components: hbase-operator-tools >Affects Versions: hbase-operator-tools-1.0.0 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Minor > Fix For: hbase-operator-tools-1.1.0 > > > Checkstyle reports 17 violations for hbase-operator-tools. IntelliJ reports > some other code improvement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase-operator-tools] petersomogyi merged pull request #39: HBASE-23109 Fix checkstyle issues
petersomogyi merged pull request #39: HBASE-23109 Fix checkstyle issues URL: https://github.com/apache/hbase-operator-tools/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #678: HBASE-23107 Avoid temp byte array creation when doing cacheDataOnWrite
Apache-HBase commented on issue #678: HBASE-23107 Avoid temp byte array creation when doing cacheDataOnWrite URL: https://github.com/apache/hbase/pull/678#issuecomment-537632320 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 1m 51s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | :blue_heart: | mvndep | 0m 41s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 6m 40s | master passed | | :green_heart: | compile | 1m 23s | master passed | | :green_heart: | checkstyle | 1m 59s | master passed | | :green_heart: | shadedjars | 5m 27s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 56s | master passed | | :blue_heart: | spotbugs | 4m 50s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 5m 44s | master passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 16s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 7m 12s | the patch passed | | :green_heart: | compile | 1m 33s | the patch passed | | :green_heart: | javac | 1m 33s | the patch passed | | :green_heart: | checkstyle | 0m 29s | The patch passed checkstyle in hbase-common | | :green_heart: | checkstyle | 1m 44s | hbase-server: The patch generated 0 new + 51 unchanged - 1 fixed = 51 total (was 52) | | :broken_heart: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | :green_heart: | shadedjars | 5m 40s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 17m 20s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 0m 57s | the patch passed | | :green_heart: | findbugs | 5m 27s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 2m 56s | hbase-common in the patch passed. | | :broken_heart: | unit | 295m 18s | hbase-server in the patch failed. | | :green_heart: | asflicense | 0m 56s | The patch does not generate ASF License warnings. | | | | 371m 48s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.balancer.TestStochasticLoadBalancerRegionReplicaSameHosts | | | hadoop.hbase.master.TestMasterShutdown | | | hadoop.hbase.client.TestMobSnapshotCloneIndependence | | | hadoop.hbase.master.balancer.TestStochasticLoadBalancerRegionReplicaHighReplication | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-678/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/678 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux cea581fd47ab 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-678/out/precommit/personality/provided.sh | | git revision | master / 2ebdcbc3b0 | | Default Java | 1.8.0_181 | | whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-678/1/artifact/out/whitespace-eol.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-678/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-678/1/testReport/ | | Max. process+thread count | 5299 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-678/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.
[GitHub] [hbase] apurtell closed pull request #680: HBASE-23101 Backport HBASE-22380 to branch-1
apurtell closed pull request #680: HBASE-23101 Backport HBASE-22380 to branch-1 URL: https://github.com/apache/hbase/pull/680 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23101) Backport HBASE-22380 to branch-1
[ https://issues.apache.org/jira/browse/HBASE-23101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943080#comment-16943080 ] Andrew Kyle Purtell commented on HBASE-23101: - WAL and replication unit tests pass. New unit TestBulkLoadReplication passes. RAT passes. In an offline discussion [~larsh] suggested removing the old methods so they aren't accidentally called. A possible follow on issue as it would be relevant for other branches besides the branch-1s too, and this issue is just for backport. Committing > Backport HBASE-22380 to branch-1 > > > Key: HBASE-23101 > URL: https://issues.apache.org/jira/browse/HBASE-23101 > Project: HBase > Issue Type: Sub-task >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Blocker > Fix For: 1.5.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-11062) hbtop
[ https://issues.apache.org/jira/browse/HBASE-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943068#comment-16943068 ] Hudson commented on HBASE-11062: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #647 (See [https://builds.apache.org/job/HBase-1.3-IT/647/]) HBASE-22988 Backport HBASE-11062 "hbtop" to branch-1 (apurtell: rev a3fe1e30478045b97e647f48f95f56b092daf6b6) * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/terminal/AbstractTerminalPrinter.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/terminal/KeyPress.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/terminal/impl/TestKeyPress.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/mode/ModeScreenView.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/field/TestFieldValue.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/top/FilterDisplayModeScreenPresenter.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/top/Paging.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/top/MessageModeScreenPresenter.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/mode/TestModeBase.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/top/Summary.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/screen/top/TestFilterDisplayModeScreenPresenter.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/screen/top/TestTopScreenModel.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/screen/mode/TestModeScreenPresenter.java * (add) hbase-hbtop/pom.xml * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/Record.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/HBTop.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/terminal/impl/TestTerminalPrinter.java * (edit) hbase-assembly/pom.xml * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/mode/TableModeStrategy.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/top/TopScreenView.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/terminal/impl/KeyPressGenerator.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/terminal/impl/ScreenBuffer.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/mode/TestTableMode.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/mode/TestRequestCountPerSecond.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/RecordFilter.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/mode/RequestCountPerSecond.java * (edit) pom.xml * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/Screen.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/screen/field/TestFieldScreenPresenter.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/mode/RegionModeStrategy.java * (edit) bin/hbase * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/field/FieldValue.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/terminal/Terminal.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/ScreenView.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/TestRecord.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/screen/help/TestHelpScreenPresenter.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/top/TopScreenPresenter.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/field/FieldInfo.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/mode/ModeScreenPresenter.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/mode/NamespaceModeStrategy.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/help/HelpScreenPresenter.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/mode/TestRegionMode.java * (add) conf/log4j-hbtop.properties * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/screen/top/TestPaging.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/mode/TestRegionServerMode.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/TestUtils.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/terminal/impl/TerminalImpl.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/mode/TestNamespaceMode.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/field/Size.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/mode/DrillDownInfo.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/screen/top/TestMessageModeScreenPresenter.java * (add)
[jira] [Commented] (HBASE-22988) Backport HBASE-11062 "hbtop" to branch-1
[ https://issues.apache.org/jira/browse/HBASE-22988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943067#comment-16943067 ] Hudson commented on HBASE-22988: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #647 (See [https://builds.apache.org/job/HBase-1.3-IT/647/]) HBASE-22988 Backport HBASE-11062 "hbtop" to branch-1 (apurtell: rev a3fe1e30478045b97e647f48f95f56b092daf6b6) * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/mode/NamespaceModeStrategy.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/screen/top/TestPaging.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/terminal/KeyPress.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/mode/ModeStrategy.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/terminal/Color.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/terminal/impl/TestKeyPress.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/field/TestFieldValue.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/top/TopScreenPresenter.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/field/FieldInfo.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/field/FieldScreenView.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/field/FieldScreenPresenter.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/terminal/Terminal.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/screen/top/TestFilterDisplayModeScreenPresenter.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/mode/RegionModeStrategy.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/TestRecord.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/screen/top/TestTopScreenModel.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/screen/help/TestHelpScreenPresenter.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/mode/ModeScreenPresenter.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/terminal/impl/TerminalPrinterImpl.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/Screen.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/terminal/Attributes.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/screen/top/TestMessageModeScreenPresenter.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/mode/RegionServerModeStrategy.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/mode/TableModeStrategy.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/mode/TestNamespaceMode.java * (add) conf/log4j-hbtop.properties * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/mode/ModeScreenView.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/mode/TestRegionServerMode.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/Record.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/top/TopScreenModel.java * (edit) pom.xml * (edit) bin/hbase * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/help/CommandDescription.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/mode/Mode.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/screen/top/TestInputModeScreenPresenter.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/field/FieldValue.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/field/Size.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/mode/DrillDownInfo.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/top/FilterDisplayModeScreenPresenter.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/terminal/impl/KeyPressGenerator.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/help/HelpScreenPresenter.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/terminal/impl/ScreenBuffer.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/top/MessageModeScreenPresenter.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/top/Paging.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/top/FilterDisplayModeScreenView.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/help/HelpScreenView.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/top/Header.java * (add) hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/RecordFilter.java * (add) hbase-hbtop/src/test/java/org/apache/hadoop/hbase/hbtop/screen/field/TestFieldScreenPresenter.java * (add)
[jira] [Commented] (HBASE-22988) Backport HBASE-11062 "hbtop" to branch-1
[ https://issues.apache.org/jira/browse/HBASE-22988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943056#comment-16943056 ] Andrew Kyle Purtell commented on HBASE-22988: - Pushed to branch-1.3 and branch-1.4. branch-1.3 required a trivial fixup in hbase-hbtop/src/test/.../TestUtils.java to account for a difference in ClusterStatus constructor. > Backport HBASE-11062 "hbtop" to branch-1 > > > Key: HBASE-22988 > URL: https://issues.apache.org/jira/browse/HBASE-22988 > Project: HBase > Issue Type: Sub-task > Components: backport, hbtop >Reporter: Toshihiro Suzuki >Assignee: Toshihiro Suzuki >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22988-branch-1.patch > > > Backport parent issue to branch-1. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-22988) Backport HBASE-11062 "hbtop" to branch-1
[ https://issues.apache.org/jira/browse/HBASE-22988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell resolved HBASE-22988. - Fix Version/s: 1.4.11 1.3.6 Hadoop Flags: Reviewed Assignee: Toshihiro Suzuki (was: Andrew Kyle Purtell) Resolution: Fixed > Backport HBASE-11062 "hbtop" to branch-1 > > > Key: HBASE-22988 > URL: https://issues.apache.org/jira/browse/HBASE-22988 > Project: HBase > Issue Type: Sub-task > Components: backport, hbtop >Reporter: Toshihiro Suzuki >Assignee: Toshihiro Suzuki >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22988-branch-1.patch > > > Backport parent issue to branch-1. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #679: HBASE-23113 IPC Netty Optimization
Apache-HBase commented on issue #679: HBASE-23113 IPC Netty Optimization URL: https://github.com/apache/hbase/pull/679#issuecomment-537600159 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 49s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :yellow_heart: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | :blue_heart: | mvndep | 0m 38s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 6m 40s | master passed | | :green_heart: | compile | 1m 36s | master passed | | :green_heart: | checkstyle | 2m 24s | master passed | | :green_heart: | shadedjars | 5m 49s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 1m 6s | master passed | | :blue_heart: | spotbugs | 5m 8s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 6m 33s | master passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 17s | Maven dependency ordering for patch | | :broken_heart: | mvninstall | 3m 41s | root in the patch failed. | | :green_heart: | compile | 1m 46s | the patch passed | | :green_heart: | javac | 1m 46s | the patch passed | | :broken_heart: | checkstyle | 0m 36s | hbase-client: The patch generated 3 new + 12 unchanged - 0 fixed = 15 total (was 12) | | :broken_heart: | checkstyle | 1m 41s | hbase-server: The patch generated 259 new + 11 unchanged - 0 fixed = 270 total (was 11) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :broken_heart: | shadedjars | 4m 40s | patch has 11 errors when building our shaded downstream artifacts. | | :broken_heart: | hadoopcheck | 2m 37s | The patch causes 11 errors with Hadoop v2.8.5. | | :broken_heart: | hadoopcheck | 5m 19s | The patch causes 11 errors with Hadoop v2.9.2. | | :broken_heart: | hadoopcheck | 8m 6s | The patch causes 11 errors with Hadoop v3.1.2. | | :green_heart: | javadoc | 1m 1s | the patch passed | | :green_heart: | findbugs | 6m 27s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 1m 59s | hbase-client in the patch passed. | | :broken_heart: | unit | 1m 10s | hbase-server in the patch failed. | | :green_heart: | asflicense | 0m 23s | The patch does not generate ASF License warnings. | | | | 59m 11s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-679/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/679 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3d6953c0a365 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-679/out/precommit/personality/provided.sh | | git revision | master / 7ee6d59ef8 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-679/1/artifact/out/patch-mvninstall-root.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-679/1/artifact/out/diff-checkstyle-hbase-client.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-679/1/artifact/out/diff-checkstyle-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-679/1/artifact/out/patch-shadedjars.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-679/1/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-679/1/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-679/1/artifact/out/patch-javac-3.1.2.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-679/1/artifact/out/patch-unit-hbase-server.txt | | Test Results |
[jira] [Commented] (HBASE-23101) Backport HBASE-22380 to branch-1
[ https://issues.apache.org/jira/browse/HBASE-23101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943001#comment-16943001 ] Andrew Kyle Purtell commented on HBASE-23101: - lgtm, will apply if local tests check out > Backport HBASE-22380 to branch-1 > > > Key: HBASE-23101 > URL: https://issues.apache.org/jira/browse/HBASE-23101 > Project: HBase > Issue Type: Sub-task >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Blocker > Fix For: 1.5.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (HBASE-22988) Backport HBASE-11062 "hbtop" to branch-1
[ https://issues.apache.org/jira/browse/HBASE-22988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942997#comment-16942997 ] Andrew Purtell edited comment on HBASE-22988 at 10/2/19 5:17 PM: - I thought I resolved this. I guess I just closed the PR. I wasn't planning to apply this further back than branch-1 this but it does apply easily to 1.4, and 1.3 with a minor fixup. No objection, let me do that. was (Author: apurtell): I thought I resolved this. I guess I just closed the PR. I wasn't planning to backport this but it does apply easily to 1.4, and 1.3 with a minor fixup. No objection, let me do that. > Backport HBASE-11062 "hbtop" to branch-1 > > > Key: HBASE-22988 > URL: https://issues.apache.org/jira/browse/HBASE-22988 > Project: HBase > Issue Type: Sub-task > Components: backport, hbtop >Reporter: Toshihiro Suzuki >Assignee: Andrew Purtell >Priority: Major > Fix For: 1.5.0 > > Attachments: HBASE-22988-branch-1.patch > > > Backport parent issue to branch-1. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-22988) Backport HBASE-11062 "hbtop" to branch-1
[ https://issues.apache.org/jira/browse/HBASE-22988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942997#comment-16942997 ] Andrew Purtell commented on HBASE-22988: I thought I resolved this. I guess I just closed the PR. I wasn't planning to backport this but it does apply easily to 1.4, and 1.3 with a minor fixup. No objection, let me do that. > Backport HBASE-11062 "hbtop" to branch-1 > > > Key: HBASE-22988 > URL: https://issues.apache.org/jira/browse/HBASE-22988 > Project: HBase > Issue Type: Sub-task > Components: backport, hbtop >Reporter: Toshihiro Suzuki >Assignee: Andrew Purtell >Priority: Major > Fix For: 1.5.0 > > Attachments: HBASE-22988-branch-1.patch > > > Backport parent issue to branch-1. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23110) Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm" to branch-1
[ https://issues.apache.org/jira/browse/HBASE-23110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-23110: Fix Version/s: 1.5.0 > Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and > fix LossyCounting algorithm" to branch-1 > - > > Key: HBASE-23110 > URL: https://issues.apache.org/jira/browse/HBASE-23110 > Project: HBase > Issue Type: Sub-task > Components: metrics >Reporter: Duo Zhang >Assignee: Andrew Kyle Purtell >Priority: Major > Fix For: 1.5.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23110) Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm" to branch-1
[ https://issues.apache.org/jira/browse/HBASE-23110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-23110: Fix Version/s: 1.4.11 > Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and > fix LossyCounting algorithm" to branch-1 > - > > Key: HBASE-23110 > URL: https://issues.apache.org/jira/browse/HBASE-23110 > Project: HBase > Issue Type: Sub-task > Components: metrics >Reporter: Duo Zhang >Assignee: Andrew Kyle Purtell >Priority: Major > Fix For: 1.5.0, 1.4.11 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23110) Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm" to branch-1
[ https://issues.apache.org/jira/browse/HBASE-23110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942994#comment-16942994 ] Andrew Kyle Purtell commented on HBASE-23110: - [~zhangduo] OK > Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and > fix LossyCounting algorithm" to branch-1 > - > > Key: HBASE-23110 > URL: https://issues.apache.org/jira/browse/HBASE-23110 > Project: HBase > Issue Type: Sub-task > Components: metrics >Reporter: Duo Zhang >Assignee: Andrew Kyle Purtell >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-23110) Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm" to branch-1
[ https://issues.apache.org/jira/browse/HBASE-23110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell reassigned HBASE-23110: --- Assignee: Andrew Kyle Purtell > Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and > fix LossyCounting algorithm" to branch-1 > - > > Key: HBASE-23110 > URL: https://issues.apache.org/jira/browse/HBASE-23110 > Project: HBase > Issue Type: Sub-task > Components: metrics >Reporter: Duo Zhang >Assignee: Andrew Kyle Purtell >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23099) [HBOSS] Raise hadoop dependency version to 3.2.1
[ https://issues.apache.org/jira/browse/HBASE-23099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-23099. -- Resolution: Fixed Pushed to master. Thanks for reviewing this, [~elserj]! > [HBOSS] Raise hadoop dependency version to 3.2.1 > > > Key: HBASE-23099 > URL: https://issues.apache.org/jira/browse/HBASE-23099 > Project: HBase > Issue Type: Improvement > Components: hboss >Affects Versions: 1.0.0-alpha1 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Major > Fix For: 1.0.0-alpha2 > > > There's been some changes on S3Guard that comes with hadoop 3.2.1 and > upcoming versions, such as HADOOP-16085, HADOOP-16233 and HADOOP-16380, among > other recent commits. Some of these required additional properties or > modified S3A expected behaviour for a few FS contract tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23099) [HBOSS] Raise hadoop dependency version to 3.2.1
[ https://issues.apache.org/jira/browse/HBASE-23099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-23099: - Component/s: hboss Fix Version/s: 1.0.0-alpha2 Affects Version/s: 1.0.0-alpha1 > [HBOSS] Raise hadoop dependency version to 3.2.1 > > > Key: HBASE-23099 > URL: https://issues.apache.org/jira/browse/HBASE-23099 > Project: HBase > Issue Type: Improvement > Components: hboss >Affects Versions: 1.0.0-alpha1 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Major > Fix For: 1.0.0-alpha2 > > > There's been some changes on S3Guard that comes with hadoop 3.2.1 and > upcoming versions, such as HADOOP-16085, HADOOP-16233 and HADOOP-16380, among > other recent commits. Some of these required additional properties or > modified S3A expected behaviour for a few FS contract tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase-filesystem] wchevreuil merged pull request #9: HBASE-23099 - [HBOSS] Raise hadoop dependency version to 3.2.1
wchevreuil merged pull request #9: HBASE-23099 - [HBOSS] Raise hadoop dependency version to 3.2.1 URL: https://github.com/apache/hbase-filesystem/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work started] (HBASE-23101) Backport HBASE-22380 to branch-1
[ https://issues.apache.org/jira/browse/HBASE-23101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23101 started by Wellington Chevreuil. > Backport HBASE-22380 to branch-1 > > > Key: HBASE-23101 > URL: https://issues.apache.org/jira/browse/HBASE-23101 > Project: HBase > Issue Type: Sub-task >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Blocker > Fix For: 1.5.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23101) Backport HBASE-22380 to branch-1
[ https://issues.apache.org/jira/browse/HBASE-23101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942964#comment-16942964 ] Wellington Chevreuil commented on HBASE-23101: -- Thanks [~apurtell], I believe I have a branch-1 working version of HBASE-22380, had submitted it in the given PR. > Backport HBASE-22380 to branch-1 > > > Key: HBASE-23101 > URL: https://issues.apache.org/jira/browse/HBASE-23101 > Project: HBase > Issue Type: Sub-task >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Blocker > Fix For: 1.5.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] wchevreuil opened a new pull request #680: HBASE-23101 Backport HBASE-22380 to branch-1
wchevreuil opened a new pull request #680: HBASE-23101 Backport HBASE-22380 to branch-1 URL: https://github.com/apache/hbase/pull/680 Right, had come with a branch-1 version of HBASE-22380. Compiled and ran some replication related UTs passing. Let's see what pre-commit says. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] SteNicholas opened a new pull request #679: HBASE-23113 IPC Netty Optimization
SteNicholas opened a new pull request #679: HBASE-23113 IPC Netty Optimization URL: https://github.com/apache/hbase/pull/679 Netty options in IPC Server/Client optimization: 1.SO_BACKLOG setting:Two queues are maintained in the Linux system kernel: syns queue and accept queue. The first is a semi-join queue that saves the connections to the synrecv state after receiving the client syn. The default netty is 128,io.netty.util.NetUtil#SOMAXCONN , and then read /proc/sys/net/core /somaxconn to continue to determine, and then there are some system level coverage logic.In some scenarios, if the client is far redundant to the server and the connection is established, it may not be enough. This value should not be too large, otherwise it will not prevent SYN-Flood attacks. The current value has been changed to 1024. After setting, the value set by yourself is equivalent to setting the upper limit because of the setting of the system and the size of the system. If some settings of the Linux system operation and maintenance are wrong, it can be avoided at the code level.At present, our Linux level is usually set to 128, and the final calculation will be set to 128. 2.WRITE_BUFFER_WATER_MARK setting:After WRITEBUFFERWATERMARK sets the maximum and minimum Buffer that can be temporarily stored on a connection, isWritable returns unwritable if the amount of data waiting to be sent for the connection is greater than the set value. In this way, the client can no longer send, preventing this amount of continuous backlog, and eventually the client may hang. If this happens, it is usually caused by slow processing on the server side. This value can effectively protect the client. At this point the data was not sent. 3.SO_REUSEADDR - Port multiplexing (allowing multiple sockets to listen on the same IP+ port): For time-wait links, it ensures that the server restarts successfully. In the case where some servers start up very quickly, it can prevent startup failure. Netty decoder in IPC Server optimization: Netty provides a convenient decoding tool class ByteToMessageDecoder, as shown in the top half of the figure, this class has accumulate bulk unpacking capability, can read bytes from the socket as much as possible, and then synchronously call the decode method to decode the business object. And compose a List. Finally, the traversal traverses the List and submits it to ChannelPipeline for processing. Here we made a small change, as shown in the bottom half of the figure, the content to be submitted is changed from a single command to the entire List, which reduces the number of pipeline executions and improves throughput. This mode has no advantage in low-concurrency scenarios, and has a significant performance boost in boost throughput in high-concurrency scenarios. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-23113) IPC Netty Optimization
Nicholas Jiang created HBASE-23113: -- Summary: IPC Netty Optimization Key: HBASE-23113 URL: https://issues.apache.org/jira/browse/HBASE-23113 Project: HBase Issue Type: Improvement Reporter: Nicholas Jiang Assignee: Nicholas Jiang Attachments: Decoder.jpeg Netty options in IPC Server/Client optimization: 1.SO_BACKLOG setting:Two queues are maintained in the Linux system kernel: syns queue and accept queue. The first is a semi-join queue that saves the connections to the synrecv state after receiving the client syn. The default netty is 128,io.netty.util.NetUtil#SOMAXCONN , and then read /proc/sys/net/core /somaxconn to continue to determine, and then there are some system level coverage logic.In some scenarios, if the client is far redundant to the server and the connection is established, it may not be enough. This value should not be too large, otherwise it will not prevent SYN-Flood attacks. The current value has been changed to 1024. After setting, the value set by yourself is equivalent to setting the upper limit because of the setting of the system and the size of the system. If some settings of the Linux system operation and maintenance are wrong, it can be avoided at the code level.At present, our Linux level is usually set to 128, and the final calculation will be set to 128. 2.WRITE_BUFFER_WATER_MARK setting:After WRITEBUFFERWATERMARK sets the maximum and minimum Buffer that can be temporarily stored on a connection, isWritable returns unwritable if the amount of data waiting to be sent for the connection is greater than the set value. In this way, the client can no longer send, preventing this amount of continuous backlog, and eventually the client may hang. If this happens, it is usually caused by slow processing on the server side. This value can effectively protect the client. At this point the data was not sent. 3.SO_REUSEADDR - Port multiplexing (allowing multiple sockets to listen on the same IP+ port): For time-wait links, it ensures that the server restarts successfully. In the case where some servers start up very quickly, it can prevent startup failure. Netty decoder in IPC Server optimization: Netty provides a convenient decoding tool class ByteToMessageDecoder, as shown in the top half of the figure, this class has accumulate bulk unpacking capability, can read bytes from the socket as much as possible, and then synchronously call the decode method to decode the business object. And compose a List. Finally, the traversal traverses the List and submits it to ChannelPipeline for processing. Here we made a small change, as shown in the bottom half of the figure, the content to be submitted is changed from a single command to the entire List, which reduces the number of pipeline executions and improves throughput. This mode has no advantage in low-concurrency scenarios, and has a significant performance boost in boost throughput in high-concurrency scenarios. !Decoder.jpeg! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23092) Make the RM tooling in dev-tools/create-release generic
[ https://issues.apache.org/jira/browse/HBASE-23092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-23092. --- Fix Version/s: 3.0.0 Hadoop Flags: Reviewed Assignee: Michael Stack Resolution: Fixed Merged. Thanks for the reviews [~busbey] and [~psomogyi] > Make the RM tooling in dev-tools/create-release generic > --- > > Key: HBASE-23092 > URL: https://issues.apache.org/jira/browse/HBASE-23092 > Project: HBase > Issue Type: Task > Environment: >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0 > > > The dev-tools/create-release scripts were originally about creating hbase > core RCs (Original idea and script versions were copied over from apache > spark). Subsequently, they were checked into hbase-operator-tools repo and > genericized so they worked in that context. Today, after a few mods, the > create-release scripts from hbase-operator-tools w/ some edits generated an > RC of hbase-thirdparty. > This issue is edits on the dev-tools/create-tools on master branch so the > scripts can create RCs across these three repos at least (with more to > follow). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] saintstack merged pull request #671: HBASE-23092 Make the RM tooling in dev-tools/create-release generic
saintstack merged pull request #671: HBASE-23092 Make the RM tooling in dev-tools/create-release generic URL: https://github.com/apache/hbase/pull/671 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-23112) [hbase-operator-tools] fixMeta in hbck2 is porcelain, in hbck1 it was plumbing; fix
Michael Stack created HBASE-23112:
-
Summary: [hbase-operator-tools] fixMeta in hbck2 is porcelain, in
hbck1 it was plumbing; fix
Key: HBASE-23112
URL: https://issues.apache.org/jira/browse/HBASE-23112
Project: HBase
Issue Type: Bug
Components: hbase-operator-tools
Reporter: Michael Stack
>From [~daisuke.kobayashi]:
{code}
Daisuke Kobayashi 6:45 PM
... One confusion here is fixMeta in hbck1 was a plumbing command whereas the
new fixMeta in hbck2 is a porcelain command which fixes several issues behind
the scene. Wonder if it's a good naming. Sorry for bothering you!
if you don't wanna change the command name, it'd be better to have a clear
documentation.
{code}
How about we add note to usage that makes it clear it is not same as hbck1 and
in the README where we talk about difference between hbck1 and hbck2, we talk
up this command in particular; that users need to be careful expecting hbck1
behaviors even in case where commands are similarly named?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule
Apache-HBase commented on issue #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule URL: https://github.com/apache/hbase/pull/677#issuecomment-537546748 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | :green_heart: | mvninstall | 6m 45s | master passed | | :green_heart: | compile | 0m 57s | master passed | | :green_heart: | checkstyle | 1m 33s | master passed | | :green_heart: | shadedjars | 4m 54s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 40s | master passed | | :blue_heart: | spotbugs | 4m 32s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 4m 30s | master passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 5m 25s | the patch passed | | :green_heart: | compile | 0m 55s | the patch passed | | :green_heart: | javac | 0m 55s | the patch passed | | :broken_heart: | checkstyle | 1m 26s | hbase-server: The patch generated 17 new + 86 unchanged - 19 fixed = 103 total (was 105) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 4m 59s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 17m 23s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 0m 35s | the patch passed | | :green_heart: | findbugs | 4m 43s | the patch passed | ||| _ Other Tests _ | | :broken_heart: | unit | 30m 0s | hbase-server in the patch failed. | | :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 92m 23s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.balancer.TestStochasticLoadBalancerHeterogeneousCostRules | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-677/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/677 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux cd5f63a28f70 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-677/out/precommit/personality/provided.sh | | git revision | master / 2ebdcbc3b0 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-677/2/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-677/2/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-677/2/testReport/ | | Max. process+thread count | 669 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-677/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23055) Alter hbase:meta
[
https://issues.apache.org/jira/browse/HBASE-23055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942855#comment-16942855
]
Hudson commented on HBASE-23055:
Results for branch master
[build #1490 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1490/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1490//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1490//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1490//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Alter hbase:meta
>
>
> Key: HBASE-23055
> URL: https://issues.apache.org/jira/browse/HBASE-23055
> Project: HBase
> Issue Type: Task
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0
>
>
> hbase:meta is currently hardcoded. Its schema cannot be change.
> This issue is about allowing edits to hbase:meta schema. It will allow our
> being able to set encodings such as the block-with-indexes which will help
> quell CPU usage on host carrying hbase:meta. A dynamic hbase:meta is first
> step on road to being able to split meta.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22988) Backport HBASE-11062 "hbtop" to branch-1
[ https://issues.apache.org/jira/browse/HBASE-22988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942830#comment-16942830 ] Toshihiro Suzuki commented on HBASE-22988: -- Thank you for committing [~apurtell] Do we need to backport it to branch-1.4? If no, please close this Jira. Thanks. > Backport HBASE-11062 "hbtop" to branch-1 > > > Key: HBASE-22988 > URL: https://issues.apache.org/jira/browse/HBASE-22988 > Project: HBase > Issue Type: Sub-task > Components: backport, hbtop >Reporter: Toshihiro Suzuki >Assignee: Andrew Kyle Purtell >Priority: Major > Fix For: 1.5.0 > > Attachments: HBASE-22988-branch-1.patch > > > Backport parent issue to branch-1. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HBASE-23111) Put up 2.1.7RC0
[ https://issues.apache.org/jira/browse/HBASE-23111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23111 started by Duo Zhang. - > Put up 2.1.7RC0 > --- > > Key: HBASE-23111 > URL: https://issues.apache.org/jira/browse/HBASE-23111 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23108) Generate CHANGES.md and RELEASENOTES.md for 2.1.7
[ https://issues.apache.org/jira/browse/HBASE-23108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23108: -- Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to branch-2.1 > Generate CHANGES.md and RELEASENOTES.md for 2.1.7 > - > > Key: HBASE-23108 > URL: https://issues.apache.org/jira/browse/HBASE-23108 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.1.7 > > Attachments: HBASE-23108-branch-2.1.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23111) Put up 2.1.7RC0
Duo Zhang created HBASE-23111: - Summary: Put up 2.1.7RC0 Key: HBASE-23111 URL: https://issues.apache.org/jira/browse/HBASE-23111 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-23111) Put up 2.1.7RC0
[ https://issues.apache.org/jira/browse/HBASE-23111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-23111: - Assignee: Duo Zhang > Put up 2.1.7RC0 > --- > > Key: HBASE-23111 > URL: https://issues.apache.org/jira/browse/HBASE-23111 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] chenxu14 opened a new pull request #678: HBASE-23107 Avoid temp byte array creation when doing cacheDataOnWrite
chenxu14 opened a new pull request #678: HBASE-23107 Avoid temp byte array creation when doing cacheDataOnWrite URL: https://github.com/apache/hbase/pull/678 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23102) Improper Usage of Map putIfAbsent
[
https://issues.apache.org/jira/browse/HBASE-23102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942771#comment-16942771
]
Rabi Kumar K C commented on HBASE-23102:
[~wchevreuil] If ticket is about changing putIfAbsent to ComputeIfAbsent on the
given classes then maybe I can take this up. Is it Okay [~belugabehr]??
> Improper Usage of Map putIfAbsent
> -
>
> Key: HBASE-23102
> URL: https://issues.apache.org/jira/browse/HBASE-23102
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.3.0
>Reporter: David Mollitor
>Priority: Minor
> Labels: newbie, noob
>
> When using {{Map#putIfAbsent}}, the argument should not be a {{new}} object.
> Otherwise, if the item is present, the object that was instantiated is
> immediately thrown away. Instead, use {{Map#computeIfAbsent}} so that the
> object is only instantiated if it is needed.
> There exists a good example in the {{Map}} JavaDoc:
> https://docs.oracle.com/javase/8/docs/api/java/util/Map.html#computeIfAbsent-K-java.util.function.Function-
>
> h2. Locations
> https://github.com/apache/hbase/blob/9370347efea5b09e2fa8f4e5d82fa32491e1181b/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaCache.java#L227-L236
> https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/StoreHotnessProtector.java#L124-L129
> https://github.com/apache/hbase/blob/1170f28122d9d36e511ba504a5263ec62e11ef6a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java#L555
> https://github.com/apache/hbase/blob/4ca760fe9dd373b8d8a4c48db15e42424920653c/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java#L584-L586
> https://github.com/apache/hbase/blob/4ca760fe9dd373b8d8a4c48db15e42424920653c/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java#L585
> https://github.com/apache/hbase/blob/5b01e613fbbb92e243e99a1d199b4ffbb21ed2d9/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java#L834
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23108) Generate CHANGES.md and RELEASENOTES.md for 2.1.7
[
https://issues.apache.org/jira/browse/HBASE-23108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942766#comment-16942766
]
HBase QA commented on HBASE-23108:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
47s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:blue}0{color} | {color:blue} markdownlint {color} | {color:blue} 0m
0s{color} | {color:blue} markdownlint was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} branch-2.1 Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 2m 34s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=18.09.7 Server=18.09.7 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/941/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-23108 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12981980/HBASE-23108-branch-2.1.patch
|
| Optional Tests | dupname asflicense markdownlint |
| uname | Linux 5978603f69fe 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.1 / 28e326feb8 |
| Max. process+thread count | 45 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/941/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.0 https://yetus.apache.org |
This message was automatically generated.
> Generate CHANGES.md and RELEASENOTES.md for 2.1.7
> -
>
> Key: HBASE-23108
> URL: https://issues.apache.org/jira/browse/HBASE-23108
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.1.7
>
> Attachments: HBASE-23108-branch-2.1.patch
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23108) Generate CHANGES.md and RELEASENOTES.md for 2.1.7
[ https://issues.apache.org/jira/browse/HBASE-23108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23108: -- Status: Patch Available (was: Reopened) > Generate CHANGES.md and RELEASENOTES.md for 2.1.7 > - > > Key: HBASE-23108 > URL: https://issues.apache.org/jira/browse/HBASE-23108 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.1.7 > > Attachments: HBASE-23108-branch-2.1.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23108) Generate CHANGES.md and RELEASENOTES.md for 2.1.7
[ https://issues.apache.org/jira/browse/HBASE-23108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23108: -- Attachment: HBASE-23108-branch-2.1.patch > Generate CHANGES.md and RELEASENOTES.md for 2.1.7 > - > > Key: HBASE-23108 > URL: https://issues.apache.org/jira/browse/HBASE-23108 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.1.7 > > Attachments: HBASE-23108-branch-2.1.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (HBASE-23108) Generate CHANGES.md and RELEASENOTES.md for 2.1.7
[ https://issues.apache.org/jira/browse/HBASE-23108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reopened HBASE-23108: --- > Generate CHANGES.md and RELEASENOTES.md for 2.1.7 > - > > Key: HBASE-23108 > URL: https://issues.apache.org/jira/browse/HBASE-23108 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.1.7 > > Attachments: HBASE-23108-branch-2.1.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #581: HBASE-22888 Share some stuffs with the initial reader when new stream reader created
Apache-HBase commented on issue #581: HBASE-22888 Share some stuffs with the initial reader when new stream reader created URL: https://github.com/apache/hbase/pull/581#issuecomment-537465210 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 0s | Docker mode activated. | | :broken_heart: | patch | 0m 6s | https://github.com/apache/hbase/pull/581 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/581 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-581/10/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] chenxu14 commented on a change in pull request #581: HBASE-22888 Share some stuffs with the initial reader when new stream reader created
chenxu14 commented on a change in pull request #581: HBASE-22888 Share some
stuffs with the initial reader when new stream reader created
URL: https://github.com/apache/hbase/pull/581#discussion_r330514039
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
##
@@ -497,88 +503,65 @@ HFileBlock readBlock(long offset, long onDiskBlockSize,
* implementation should take care of thread safety.
*/
void unbufferStream();
+
+/**
+ * Copy some stuffs(fileInfo, index, etc) from an existing Reader,
+ * mainly used by HFileStreamReader.
+ */
+void copyFields(Reader reader) throws IOException;
}
/**
* Method returns the reader given the specified arguments.
* TODO This is a bad abstraction. See HBASE-6635.
*
- * @param path hfile's path
- * @param fsdis stream of path's file
- * @param size max size of the trailer.
+ * @param context Reader context info
* @param cacheConf Cache configuation values, cannot be null.
- * @param hfs
- * @param primaryReplicaReader true if this is a reader for primary replica
+ * @param conf Configuration
* @return an appropriate instance of HFileReader
* @throws IOException If file is invalid, will throw CorruptHFileException
flavored IOException
*/
@edu.umd.cs.findbugs.annotations.SuppressWarnings(value="SF_SWITCH_FALLTHROUGH",
justification="Intentional")
- private static Reader openReader(Path path, FSDataInputStreamWrapper fsdis,
long size,
- CacheConfig cacheConf, HFileSystem hfs, boolean primaryReplicaReader,
Configuration conf)
- throws IOException {
-FixedFileTrailer trailer = null;
+ public static Reader createReader(ReaderContext context,
+ CacheConfig cacheConf, Configuration conf) throws IOException {
try {
- boolean isHBaseChecksum = fsdis.shouldUseHBaseChecksum();
+ context.validateFields();
Review comment:
Check this in ReaderContextBuilder#build
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] chenxu14 commented on a change in pull request #581: HBASE-22888 Share some stuffs with the initial reader when new stream reader created
chenxu14 commented on a change in pull request #581: HBASE-22888 Share some
stuffs with the initial reader when new stream reader created
URL: https://github.com/apache/hbase/pull/581#discussion_r330513774
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java
##
@@ -0,0 +1,213 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.io.hfile;
+
+import java.io.IOException;
+import java.security.Key;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.io.crypto.Cipher;
+import org.apache.hadoop.hbase.io.crypto.Encryption;
+import org.apache.hadoop.hbase.io.hfile.HFile.FileInfo;
+import org.apache.hadoop.hbase.io.hfile.HFile.Reader;
+import org.apache.hadoop.hbase.security.EncryptionUtil;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Implementation of {@link HFile.Reader} to deal with pread.
+ */
+@InterfaceAudience.Private
+public class HFilePreadReader extends HFileReaderImpl {
+ private static final Logger LOG =
LoggerFactory.getLogger(HFileReaderImpl.class);
+
+ /**
+ * The iterator will track all blocks in load-on-open section, since we use
the
+ * {@link org.apache.hadoop.hbase.io.ByteBuffAllocator} to manage the
ByteBuffers in block now,
+ * so we must ensure that deallocate all ByteBuffers in the end.
+ */
+ private final HFileBlock.BlockIterator blockIter;
+
+ public HFilePreadReader(ReaderContext context, FixedFileTrailer trailer,
+ CacheConfig cacheConf, Configuration conf) throws IOException {
+super(context, cacheConf, conf);
+this.trailer = trailer;
+this.compressAlgo = trailer.getCompressionCodec();
+// Comparator class name is stored in the trailer in version 2.
+this.comparator = trailer.createComparator();
+checkFileVersion();
+this.hfileContext = createHFileContext(context, trailer, conf);
+this.fsBlockReader = new HFileBlock.FSReaderImpl(context, hfileContext,
+cacheConf.getByteBuffAllocator());
+// Initialize an block iterator, and parse load-on-open blocks in the
following.
+this.blockIter =
fsBlockReader.blockRange(trailer.getLoadOnOpenDataOffset(),
+ fileSize - trailer.getTrailerSize());
+
+dataBlockIndexReader = new
HFileBlockIndex.CellBasedKeyBlockIndexReader(comparator,
+trailer.getNumDataIndexLevels());
+metaBlockIndexReader = new HFileBlockIndex.ByteArrayKeyBlockIndexReader(1);
+// Data index. We also read statistics about the block index written after
+// the root level.
+dataBlockIndexReader.readMultiLevelIndexRoot(
+blockIter.nextBlockWithBlockType(BlockType.ROOT_INDEX),
+trailer.getDataIndexCount());
+// Meta index.
+metaBlockIndexReader.readRootIndex(
+blockIter.nextBlockWithBlockType(BlockType.ROOT_INDEX),
+trailer.getMetaIndexCount());
+loadFileInfo();
Review comment:
Move the code to HFileInfo
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (HBASE-23108) Generate CHANGES.md and RELEASENOTES.md for 2.1.7
[ https://issues.apache.org/jira/browse/HBASE-23108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23108: -- Fix Version/s: 2.1.7 > Generate CHANGES.md and RELEASENOTES.md for 2.1.7 > - > > Key: HBASE-23108 > URL: https://issues.apache.org/jira/browse/HBASE-23108 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.1.7 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23108) Generate CHANGES.md and RELEASENOTES.md for 2.1.7
[ https://issues.apache.org/jira/browse/HBASE-23108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23108: -- Component/s: documentation > Generate CHANGES.md and RELEASENOTES.md for 2.1.7 > - > > Key: HBASE-23108 > URL: https://issues.apache.org/jira/browse/HBASE-23108 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23108) Generate CHANGES.md and RELEASENOTES.md for 2.1.7
[ https://issues.apache.org/jira/browse/HBASE-23108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-23108. --- Assignee: Duo Zhang Resolution: Fixed Temporary resolve for generating changes.md. > Generate CHANGES.md and RELEASENOTES.md for 2.1.7 > - > > Key: HBASE-23108 > URL: https://issues.apache.org/jira/browse/HBASE-23108 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase-operator-tools] asf-ci commented on issue #39: HBASE-23109 Fix checkstyle issues
asf-ci commented on issue #39: HBASE-23109 Fix checkstyle issues URL: https://github.com/apache/hbase-operator-tools/pull/39#issuecomment-537460735 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build/112/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23110) Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm" to branch-1
[ https://issues.apache.org/jira/browse/HBASE-23110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942747#comment-16942747 ] Duo Zhang commented on HBASE-23110: --- Ping [~apurtell]. Please use this issue for backporting HBASE-23054. Thanks a lot. > Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and > fix LossyCounting algorithm" to branch-1 > - > > Key: HBASE-23110 > URL: https://issues.apache.org/jira/browse/HBASE-23110 > Project: HBase > Issue Type: Sub-task > Components: metrics >Reporter: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23110) Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm" to branch-1
[ https://issues.apache.org/jira/browse/HBASE-23110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23110: -- Component/s: metrics > Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and > fix LossyCounting algorithm" to branch-1 > - > > Key: HBASE-23110 > URL: https://issues.apache.org/jira/browse/HBASE-23110 > Project: HBase > Issue Type: Sub-task > Components: metrics >Reporter: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23054) Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm
[ https://issues.apache.org/jira/browse/HBASE-23054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-23054. --- Resolution: Fixed > Remove synchronization block from MetaTableMetrics and fix LossyCounting > algorithm > -- > > Key: HBASE-23054 > URL: https://issues.apache.org/jira/browse/HBASE-23054 > Project: HBase > Issue Type: Bug > Components: metrics >Affects Versions: 2.1.5 >Reporter: Ankit Singhal >Assignee: Ankit Singhal >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > Attachments: HBASE-23054.master.001.patch, > HBASE-23054.master.002.patch > > > While trying to use LossyCounting for HBASE-15519 , found following bugs in > current implementation > – Remove synchronization block from MetaTableMetrics to avoid congestion at > the code > – Fix license format > – Fix LossyCounting algorithm as per > [http://www.vldb.org/conf/2002/S10P03.pdf > |http://www.vldb.org/conf/2002/S10P03.pdf] > -- Avoid doing sweep on every insert in LossyCounting > – Remove extra redundant data structures from MetaTableMetrics. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23110) Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm" to branch-1
Duo Zhang created HBASE-23110: - Summary: Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm" to branch-1 Key: HBASE-23110 URL: https://issues.apache.org/jira/browse/HBASE-23110 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23054) Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm
[ https://issues.apache.org/jira/browse/HBASE-23054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23054: -- Component/s: metrics > Remove synchronization block from MetaTableMetrics and fix LossyCounting > algorithm > -- > > Key: HBASE-23054 > URL: https://issues.apache.org/jira/browse/HBASE-23054 > Project: HBase > Issue Type: Bug > Components: metrics >Affects Versions: 2.1.5 >Reporter: Ankit Singhal >Assignee: Ankit Singhal >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > Attachments: HBASE-23054.master.001.patch, > HBASE-23054.master.002.patch > > > While trying to use LossyCounting for HBASE-15519 , found following bugs in > current implementation > – Remove synchronization block from MetaTableMetrics to avoid congestion at > the code > – Fix license format > – Fix LossyCounting algorithm as per > [http://www.vldb.org/conf/2002/S10P03.pdf > |http://www.vldb.org/conf/2002/S10P03.pdf] > -- Avoid doing sweep on every insert in LossyCounting > – Remove extra redundant data structures from MetaTableMetrics. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-22935) TaskMonitor warns MonitoredRPCHandler task may be stuck when it recently started
[
https://issues.apache.org/jira/browse/HBASE-22935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-22935:
--
Fix Version/s: (was: 2.1.6)
2.1.7
> TaskMonitor warns MonitoredRPCHandler task may be stuck when it recently
> started
>
>
> Key: HBASE-22935
> URL: https://issues.apache.org/jira/browse/HBASE-22935
> Project: HBase
> Issue Type: Bug
> Components: logging
>Affects Versions: 3.0.0, 1.4.0, 1.5.0, 1.3.3, 2.0.0
>Reporter: David Manning
>Assignee: David Manning
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 1.3.6, 1.4.11, 2.1.7
>
> Attachments: HBASE-22935.master.001.patch
>
>
> After setting {{hbase.taskmonitor.rpc.warn.time}} to 18, the logs show
> WARN messages such as these
> {noformat}
> 2019-08-08 21:50:02,601 WARN [read for TaskMonitor] monitoring.TaskMonitor -
> Task may be stuck: RpcServer.FifoWFPBQ.default.handler=4,queue=4,port=60020:
> status=Servicing call from :55164: Scan, state=RUNNING,
> startTime=1563305858103, completionTime=-1, queuetimems=1565301002599,
> starttimems=1565301002599, clientaddress=, remoteport=55164,
> packetlength=370, rpcMethod=Scan
> {noformat}
> Notice that the first {{starttimems}} is far in the past. The second
> {{starttimems}} and the {{queuetimems}} are much closer to the log timestamp
> than 180 seconds. I think this is because the warnTime is initialized to the
> time that MonitoredTaskImpl is created, but never updated until we write a
> warn message to the log.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23109) [hbase-operator-tools] Fix checkstyle issues
[ https://issues.apache.org/jira/browse/HBASE-23109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-23109: -- Status: Patch Available (was: Open) > [hbase-operator-tools] Fix checkstyle issues > > > Key: HBASE-23109 > URL: https://issues.apache.org/jira/browse/HBASE-23109 > Project: HBase > Issue Type: Improvement > Components: hbase-operator-tools >Affects Versions: hbase-operator-tools-1.0.0 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Minor > Fix For: hbase-operator-tools-1.1.0 > > > Checkstyle reports 17 violations for hbase-operator-tools. IntelliJ reports > some other code improvement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase-operator-tools] petersomogyi opened a new pull request #39: HBASE-23109 Fix checkstyle issues
petersomogyi opened a new pull request #39: HBASE-23109 Fix checkstyle issues URL: https://github.com/apache/hbase-operator-tools/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-23109) [hbase-operator-tools] Fix checkstyle issues
Peter Somogyi created HBASE-23109: - Summary: [hbase-operator-tools] Fix checkstyle issues Key: HBASE-23109 URL: https://issues.apache.org/jira/browse/HBASE-23109 Project: HBase Issue Type: Improvement Components: hbase-operator-tools Affects Versions: hbase-operator-tools-1.0.0 Reporter: Peter Somogyi Assignee: Peter Somogyi Fix For: hbase-operator-tools-1.1.0 Checkstyle reports 17 violations for hbase-operator-tools. IntelliJ reports some other code improvement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
