[jira] [Commented] (HBASE-23133) hbase-thirdparty create enforcer rule that ensures we build w/ correct jvm version
[ https://issues.apache.org/jira/browse/HBASE-23133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946548#comment-16946548 ] Duo Zhang commented on HBASE-23133: --- We have a jave version rule but only for min version, let's make it 1.8.0 only? > hbase-thirdparty create enforcer rule that ensures we build w/ correct jvm > version > -- > > Key: HBASE-23133 > URL: https://issues.apache.org/jira/browse/HBASE-23133 > Project: HBase > Issue Type: Sub-task >Reporter: Michael Stack >Priority: Major > > See parent. A build of an RC w/ jdk10 though source target is 1.8 doesn't > work. Add an enforcer to ensure we don't build an RC in this manner again. > The do-release-docker.sh create-release script rather than the do-release.sh > should be used building RCs to avoid this kind of issue but for the case > where it is not used, an enforcer would prevent this problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23094) Wrong log message in simpleRegionNormaliser while checking if merge is enabled.
[
https://issues.apache.org/jira/browse/HBASE-23094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946545#comment-16946545
]
Hudson commented on HBASE-23094:
Results for branch branch-2.1
[build #1668 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1668/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1668//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1668//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1668//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Wrong log message in simpleRegionNormaliser while checking if merge is
> enabled.
> ---
>
> Key: HBASE-23094
> URL: https://issues.apache.org/jira/browse/HBASE-23094
> Project: HBase
> Issue Type: Bug
>Reporter: Sanjeet Nishad
>Assignee: Sanjeet Nishad
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.2.2, 1.3.7, 2.1.8
>
> Attachments: HBASE-23094.001.patch, HBASE-23094.master.001.patch
>
>
> {color:#9876aa}In the following log message :{color}
> {color:#9876aa}LOG{color}.debug({color:#6a8759}"Unable to determine whether
> split is enabled"{color}{color:#cc7832}, {color}e){color:#cc7832};{color}
> {color:#cc7832}it should be "Unable to determine whether *merge* is
> enabled{color}" while checking if merge is enabled.
>
> It can lead to confusion while debugging through logs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23133) hbase-thirdparty create enforcer rule that ensures we build w/ correct jvm version
[ https://issues.apache.org/jira/browse/HBASE-23133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-23133: -- Description: See parent. A build of an RC w/ jdk10 though source target is 1.8 doesn't work. Add an enforcer to ensure we don't build an RC in this manner again. The do-release-docker.sh create-release script rather than the do-release.sh should be used building RCs to avoid this kind of issue but for the case where it is not used, an enforcer would prevent this problem. (was: See parent. A build of an RC w/ jdk10 though source target is 1.8 won't work. Add an enforcer to ensure we don't build an RC mistakenly. The do-release-docker.sh create-release script should be used building RCs to avoid this kind of issue but in case it isn't, an enforcer would prevent the issue.) > hbase-thirdparty create enforcer rule that ensures we build w/ correct jvm > version > -- > > Key: HBASE-23133 > URL: https://issues.apache.org/jira/browse/HBASE-23133 > Project: HBase > Issue Type: Sub-task >Reporter: Michael Stack >Priority: Major > > See parent. A build of an RC w/ jdk10 though source target is 1.8 doesn't > work. Add an enforcer to ensure we don't build an RC in this manner again. > The do-release-docker.sh create-release script rather than the do-release.sh > should be used building RCs to avoid this kind of issue but for the case > where it is not used, an enforcer would prevent this problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23133) hbase-thirdparty create enforcer rule that ensures we build w/ correct jvm version
Michael Stack created HBASE-23133: - Summary: hbase-thirdparty create enforcer rule that ensures we build w/ correct jvm version Key: HBASE-23133 URL: https://issues.apache.org/jira/browse/HBASE-23133 Project: HBase Issue Type: Sub-task Reporter: Michael Stack See parent. A build of an RC w/ jdk10 though source target is 1.8 won't work. Add an enforcer to ensure we don't build an RC mistakenly. The do-release-docker.sh create-release script should be used building RCs to avoid this kind of issue but in case it isn't, an enforcer would prevent the issue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23132) Squash hbase-thirdparty-3.1.0; was compiled w/ jdk10 so "NoSuchMethodError: java.nio.ByteBuffer.*"
[ https://issues.apache.org/jira/browse/HBASE-23132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946539#comment-16946539 ] Michael Stack commented on HBASE-23132: --- Added subtask to add enforcer rule. > Squash hbase-thirdparty-3.1.0; was compiled w/ jdk10 so "NoSuchMethodError: > java.nio.ByteBuffer.*" > -- > > Key: HBASE-23132 > URL: https://issues.apache.org/jira/browse/HBASE-23132 > Project: HBase > Issue Type: Bug >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: hbase-thirdparty-3.1.1 > > > Tried to use the hbase-thirdparty lib. Ran into this issue > https://github.com/eclipse/jetty.project/issues/3244 when I tried to update > core to use the new hbase-thirdparty (A single failed unit test, > TestProtobufUtil, complained of missing ByteBuffer position method when > buffer was offheap). Pushed a recompiled artifact, one that uses the 3.1.0 > tag., built with jdk8 and that works if local repo but can't override > published artifaict. Let me make a new one. > Need an issue else the RC scripts fail. Let this be it. Resovling against > hbase-thirdparty-3.1.1. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23132) Squash hbase-thirdparty-3.1.0; was compiled w/ jdk10 so "NoSuchMethodError: java.nio.ByteBuffer.*"
[ https://issues.apache.org/jira/browse/HBASE-23132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946533#comment-16946533 ] Duo Zhang commented on HBASE-23132: --- Let's just add a enforcer rule? > Squash hbase-thirdparty-3.1.0; was compiled w/ jdk10 so "NoSuchMethodError: > java.nio.ByteBuffer.*" > -- > > Key: HBASE-23132 > URL: https://issues.apache.org/jira/browse/HBASE-23132 > Project: HBase > Issue Type: Bug >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: hbase-thirdparty-3.1.1 > > > Tried to use the hbase-thirdparty lib. Ran into this issue > https://github.com/eclipse/jetty.project/issues/3244 when I tried to update > core to use the new hbase-thirdparty (A single failed unit test, > TestProtobufUtil, complained of missing ByteBuffer position method when > buffer was offheap). Pushed a recompiled artifact, one that uses the 3.1.0 > tag., built with jdk8 and that works if local repo but can't override > published artifaict. Let me make a new one. > Need an issue else the RC scripts fail. Let this be it. Resovling against > hbase-thirdparty-3.1.1. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #40: HBASE-23112 [hbase-operator-tools] fixMeta in hbck2 is porcelain, in …
saintstack commented on a change in pull request #40: HBASE-23112 [hbase-operator-tools] fixMeta in hbck2 is porcelain, in … URL: https://github.com/apache/hbase-operator-tools/pull/40#discussion_r332349970 ## File path: hbase-hbck2/README.md ## @@ -159,7 +160,9 @@ Command: fixMeta Do a server-side fixing of bad or inconsistent state in hbase:meta. - Repairs 'holes' and 'overlaps' in hbase:meta. + Critical that hbase:meta is first made healthy before making any + other repairs. Fix 'holes', 'overlaps', etc. Is NOT same as the + _hbck1_ command named similarily. SEE ALSO: reportMissingRegionsInMeta Review comment: You are right in that it creates an empty region to match the hole or overlap found in hbase:meta. What it does not do is look around in hdfs to try and match hdfs content w/ the hole that is being plugged or moving data around in hdfs to fill the overlap. I think talking of HDFS side-effects when describing fixMeta will give the wrong impression, that we will be doing reconcile w/ HDFS content which we are explicitly not doing in this command. Not sure how better to say this boss. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22992) Blog post for hbtop on hbase.apache.org
[ https://issues.apache.org/jira/browse/HBASE-22992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946525#comment-16946525 ] Michael Stack commented on HBASE-22992: --- Thanks [~brfrn169] ... updated blog w/ your suggestion Seems to work https://blogs.apache.org/hbase/entry/introduction-hbtop-a-real-time > Blog post for hbtop on hbase.apache.org > --- > > Key: HBASE-22992 > URL: https://issues.apache.org/jira/browse/HBASE-22992 > Project: HBase > Issue Type: Sub-task >Reporter: Toshihiro Suzuki >Assignee: Toshihiro Suzuki >Priority: Major > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase-operator-tools] daisukebe commented on a change in pull request #40: HBASE-23112 [hbase-operator-tools] fixMeta in hbck2 is porcelain, in …
daisukebe commented on a change in pull request #40: HBASE-23112 [hbase-operator-tools] fixMeta in hbck2 is porcelain, in … URL: https://github.com/apache/hbase-operator-tools/pull/40#discussion_r332348658 ## File path: hbase-hbck2/README.md ## @@ -159,7 +160,9 @@ Command: fixMeta Do a server-side fixing of bad or inconsistent state in hbase:meta. - Repairs 'holes' and 'overlaps' in hbase:meta. + Critical that hbase:meta is first made healthy before making any + other repairs. Fix 'holes', 'overlaps', etc. Is NOT same as the + _hbck1_ command named similarily. SEE ALSO: reportMissingRegionsInMeta Review comment: > It does not fix holes and overlaps in HDFS -- intentionally. Ohk, per my reading of the code, https://github.com/apache/hbase/blob/branch-2.2/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaFixer.java#L83-L108, it appears to be creating an empty region in the filesystem and then put the entry to meta. I was apparently misunderstanding? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-23130) Add 2.1.7 to download page
[ https://issues.apache.org/jira/browse/HBASE-23130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-23130. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to master. Thanks [~meiyi] for reviewing. > Add 2.1.7 to download page > -- > > Key: HBASE-23130 > URL: https://issues.apache.org/jira/browse/HBASE-23130 > Project: HBase > Issue Type: Sub-task > Components: website >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-23130) Add 2.1.7 to download page
[ https://issues.apache.org/jira/browse/HBASE-23130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-23130: - Assignee: Duo Zhang > Add 2.1.7 to download page > -- > > Key: HBASE-23130 > URL: https://issues.apache.org/jira/browse/HBASE-23130 > Project: HBase > Issue Type: Sub-task > Components: website >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 merged pull request #697: HBASE-23130 Add 2.1.7 to download page
Apache9 merged pull request #697: HBASE-23130 Add 2.1.7 to download page URL: https://github.com/apache/hbase/pull/697 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23132) Squash hbase-thirdparty-3.1.0; was compiled w/ jdk10 so "NoSuchMethodError: java.nio.ByteBuffer.*"
[ https://issues.apache.org/jira/browse/HBASE-23132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946521#comment-16946521 ] Michael Stack commented on HBASE-23132: --- bq. We got a jira tracking making sure we have an enforcer rule or something checking the jdk used to build to catch this in the future? Could. Yeah. Or just use the docker build which is there to make sure we never have this kind of environmental pollution. > Squash hbase-thirdparty-3.1.0; was compiled w/ jdk10 so "NoSuchMethodError: > java.nio.ByteBuffer.*" > -- > > Key: HBASE-23132 > URL: https://issues.apache.org/jira/browse/HBASE-23132 > Project: HBase > Issue Type: Bug >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: hbase-thirdparty-3.1.1 > > > Tried to use the hbase-thirdparty lib. Ran into this issue > https://github.com/eclipse/jetty.project/issues/3244 when I tried to update > core to use the new hbase-thirdparty (A single failed unit test, > TestProtobufUtil, complained of missing ByteBuffer position method when > buffer was offheap). Pushed a recompiled artifact, one that uses the 3.1.0 > tag., built with jdk8 and that works if local repo but can't override > published artifaict. Let me make a new one. > Need an issue else the RC scripts fail. Let this be it. Resovling against > hbase-thirdparty-3.1.1. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #40: HBASE-23112 [hbase-operator-tools] fixMeta in hbck2 is porcelain, in …
saintstack commented on a change in pull request #40: HBASE-23112 [hbase-operator-tools] fixMeta in hbck2 is porcelain, in … URL: https://github.com/apache/hbase-operator-tools/pull/40#discussion_r332346970 ## File path: hbase-hbck2/README.md ## @@ -159,7 +160,9 @@ Command: fixMeta Do a server-side fixing of bad or inconsistent state in hbase:meta. - Repairs 'holes' and 'overlaps' in hbase:meta. + Critical that hbase:meta is first made healthy before making any + other repairs. Fix 'holes', 'overlaps', etc. Is NOT same as the + _hbck1_ command named similarily. SEE ALSO: reportMissingRegionsInMeta Review comment: There is no reporting apart from Master UI in hbase2. No equivalent tool. We'd have to write one for those older releases. It would be different though because the report would not be generated by the catalogjanitor but by a tool reading hbase:meta remote running the code we recently added to catalogjanitor. So, the fixMeta fixes holes and overlaps in meta. It does not fix holes and overlaps in HDFS -- intentionally. Idea is you'd fix meta then if any orphan data in HDFS, you'd ask HBase to adopt it using the bulk load tool to load it up (The filesystem command would note the orphan data/regions). Shout if I should add more. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23132) Squash hbase-thirdparty-3.1.0; was compiled w/ jdk10 so "NoSuchMethodError: java.nio.ByteBuffer.*"
[ https://issues.apache.org/jira/browse/HBASE-23132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946498#comment-16946498 ] Sean Busbey commented on HBASE-23132: - We got a jira tracking making sure we have an enforcer rule or something checking the jdk used to build to catch this in the future? > Squash hbase-thirdparty-3.1.0; was compiled w/ jdk10 so "NoSuchMethodError: > java.nio.ByteBuffer.*" > -- > > Key: HBASE-23132 > URL: https://issues.apache.org/jira/browse/HBASE-23132 > Project: HBase > Issue Type: Bug >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: hbase-thirdparty-3.1.1 > > > Tried to use the hbase-thirdparty lib. Ran into this issue > https://github.com/eclipse/jetty.project/issues/3244 when I tried to update > core to use the new hbase-thirdparty (A single failed unit test, > TestProtobufUtil, complained of missing ByteBuffer position method when > buffer was offheap). Pushed a recompiled artifact, one that uses the 3.1.0 > tag., built with jdk8 and that works if local repo but can't override > published artifaict. Let me make a new one. > Need an issue else the RC scripts fail. Let this be it. Resovling against > hbase-thirdparty-3.1.1. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-22986) Add documentation for hbtop
[ https://issues.apache.org/jira/browse/HBASE-22986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946497#comment-16946497 ] Toshihiro Suzuki commented on HBASE-22986: -- Please change the blog. Thank you [~stack] I commented it in the following in HBASE-22992: https://issues.apache.org/jira/browse/HBASE-22992?focusedCommentId=16945342&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16945342 > Add documentation for hbtop > --- > > Key: HBASE-22986 > URL: https://issues.apache.org/jira/browse/HBASE-22986 > Project: HBase > Issue Type: Sub-task > Components: documentation, hbtop >Reporter: Toshihiro Suzuki >Assignee: Toshihiro Suzuki >Priority: Minor > Fix For: 3.0.0 > > > We already have README for hbtop, so we can make the refguide refer to this: > [https://github.com/apache/hbase/blob/master/hbase-hbtop/README.md] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23132) Squash hbase-thirdparty-3.1.0; was compiled w/ jdk10 so "NoSuchMethodError: java.nio.ByteBuffer.*"
[ https://issues.apache.org/jira/browse/HBASE-23132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-23132. --- Fix Version/s: hbase-thirdparty-3.1.1 Assignee: Michael Stack Resolution: Fixed Resolving so this release has one issue at least. > Squash hbase-thirdparty-3.1.0; was compiled w/ jdk10 so "NoSuchMethodError: > java.nio.ByteBuffer.*" > -- > > Key: HBASE-23132 > URL: https://issues.apache.org/jira/browse/HBASE-23132 > Project: HBase > Issue Type: Bug >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: hbase-thirdparty-3.1.1 > > > Tried to use the hbase-thirdparty lib. Ran into this issue > https://github.com/eclipse/jetty.project/issues/3244 when I tried to update > core to use the new hbase-thirdparty (A single failed unit test, > TestProtobufUtil, complained of missing ByteBuffer position method when > buffer was offheap). Pushed a recompiled artifact, one that uses the 3.1.0 > tag., built with jdk8 and that works if local repo but can't override > published artifaict. Let me make a new one. > Need an issue else the RC scripts fail. Let this be it. Resovling against > hbase-thirdparty-3.1.1. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23132) Squash hbase-thirdparty-3.1.0; was compiled w/ jdk10 so "NoSuchMethodError: java.nio.ByteBuffer.*"
Michael Stack created HBASE-23132: - Summary: Squash hbase-thirdparty-3.1.0; was compiled w/ jdk10 so "NoSuchMethodError: java.nio.ByteBuffer.*" Key: HBASE-23132 URL: https://issues.apache.org/jira/browse/HBASE-23132 Project: HBase Issue Type: Bug Reporter: Michael Stack Tried to use the hbase-thirdparty lib. Ran into this issue https://github.com/eclipse/jetty.project/issues/3244 when I tried to update core to use the new hbase-thirdparty (A single failed unit test, TestProtobufUtil, complained of missing ByteBuffer position method when buffer was offheap). Pushed a recompiled artifact, one that uses the 3.1.0 tag., built with jdk8 and that works if local repo but can't override published artifaict. Let me make a new one. Need an issue else the RC scripts fail. Let this be it. Resovling against hbase-thirdparty-3.1.1. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase-operator-tools] daisukebe commented on a change in pull request #40: HBASE-23112 [hbase-operator-tools] fixMeta in hbck2 is porcelain, in …
daisukebe commented on a change in pull request #40: HBASE-23112 [hbase-operator-tools] fixMeta in hbck2 is porcelain, in … URL: https://github.com/apache/hbase-operator-tools/pull/40#discussion_r332338066 ## File path: hbase-hbck2/README.md ## @@ -159,7 +160,9 @@ Command: fixMeta Do a server-side fixing of bad or inconsistent state in hbase:meta. - Repairs 'holes' and 'overlaps' in hbase:meta. + Critical that hbase:meta is first made healthy before making any + other repairs. Fix 'holes', 'overlaps', etc. Is NOT same as the + _hbck1_ command named similarily. SEE ALSO: reportMissingRegionsInMeta Review comment: Thanks Stack! Reviewed the latest one and I'm still wondering if the Master UI is the only one way to recognize the inconsistency. Is there an equivalent tool developed in the command line? > Fixes 'holes', 'overlaps', etc Does it make sense to you to change the sentence to `Fixes 'holes', 'overlaps' in HDFS, etc`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #697: HBASE-23130 Add 2.1.7 to download page
Apache-HBase commented on issue #697: HBASE-23130 Add 2.1.7 to download page URL: https://github.com/apache/hbase/pull/697#issuecomment-539321366 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 34s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | :green_heart: | mvninstall | 5m 25s | master passed | | :green_heart: | mvnsite | 17m 47s | master passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 5m 9s | the patch passed | | :green_heart: | mvnsite | 17m 38s | the patch passed | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | ||| _ Other Tests _ | | :green_heart: | asflicense | 0m 22s | The patch does not generate ASF License warnings. | | | | 48m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-697/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/697 | | Optional Tests | dupname asflicense mvnsite xml | | uname | Linux 2a1a1a5ccec8 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-697/out/precommit/personality/provided.sh | | git revision | master / 10180e232e | | Max. process+thread count | 96 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-697/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1
Apache-HBase commented on issue #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1 URL: https://github.com/apache/hbase/pull/251#issuecomment-539321121 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 16m 16s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :broken_heart: | hbaseanti | 0m 0s | The patch appears use Hadoop classification instead of HBase. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ branch-1 Compile Tests _ | | :blue_heart: | mvndep | 1m 41s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 7m 19s | branch-1 passed | | :green_heart: | compile | 1m 51s | branch-1 passed with JDK v1.8.0_222 | | :green_heart: | compile | 2m 1s | branch-1 passed with JDK v1.7.0_232 | | :green_heart: | checkstyle | 8m 47s | branch-1 passed | | :blue_heart: | refguide | 3m 46s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | :green_heart: | shadedjars | 3m 9s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 3m 13s | branch-1 passed with JDK v1.8.0_222 | | :green_heart: | javadoc | 5m 29s | branch-1 passed with JDK v1.7.0_232 | | :blue_heart: | spotbugs | 2m 44s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :blue_heart: | findbugs | 0m 17s | branch/hbase-resource-bundle no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 21s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 2m 7s | the patch passed | | :broken_heart: | compile | 0m 8s | root in the patch failed with JDK v1.8.0_222. | | :broken_heart: | javac | 0m 8s | root in the patch failed with JDK v1.8.0_222. | | :green_heart: | compile | 1m 58s | the patch passed with JDK v1.7.0_232 | | :green_heart: | javac | 1m 58s | the patch passed | | :green_heart: | checkstyle | 0m 10s | The patch passed checkstyle in hbase-resource-bundle | | :green_heart: | checkstyle | 0m 30s | The patch passed checkstyle in hbase-common | | :green_heart: | checkstyle | 1m 41s | hbase-server: The patch generated 0 new + 78 unchanged - 11 fixed = 78 total (was 89) | | :green_heart: | checkstyle | 0m 31s | The patch passed checkstyle in hbase-it | | :green_heart: | checkstyle | 5m 56s | root: The patch generated 0 new + 87 unchanged - 11 fixed = 87 total (was 98) | | :broken_heart: | checkstyle | 0m 5s | The patch fails to run checkstyle in hbase-tinylfu-blockcache | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :broken_heart: | xml | 0m 0s | The patch has 5 ill-formed XML file(s). | | :blue_heart: | refguide | 3m 15s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | :green_heart: | shadedjars | 3m 4s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 5m 17s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | :broken_heart: | javadoc | 0m 13s | hbase-it in the patch failed with JDK v1.8.0_222. | | :broken_heart: | javadoc | 0m 8s | root in the patch failed with JDK v1.8.0_222. | | :broken_heart: | javadoc | 0m 6s | hbase-tinylfu-blockcache in the patch failed with JDK v1.8.0_222. | | :broken_heart: | javadoc | 0m 6s | hbase-tinylfu-blockcache in the patch failed with JDK v1.7.0_232. | | :blue_heart: | findbugs | 0m 11s | hbase-resource-bundle has no data from findbugs | | :broken_heart: | findbugs | 0m 8s | hbase-tinylfu-blockcache in the patch failed. | ||| _ Other Tests _ | | :broken_heart: | unit | 165m 52s | root in the patch failed. | | :green_heart: | asflicense | 2m 33s | The patch does not generate ASF License warnings. | | | | 290m 55s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | hbase-common/src/main/resources/hbase-default.xml | | | hbase-it/pom.xml | | | hbase-resource-bundle/src/main/resources/supplemental-models.xml | | | hbase-tinylfu-blockcache/pom.xml | | | pom.xml | | Failed junit tests | hadoop.hbase.client.TestAdmin1 | | Subsystem | Report/Notes | |--:|:-
[jira] [Commented] (HBASE-22986) Add documentation for hbtop
[ https://issues.apache.org/jira/browse/HBASE-22986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946482#comment-16946482 ] Michael Stack commented on HBASE-22986: --- Do I need to change the blog [~brfrn169]? Or just wait? Thanks. > Add documentation for hbtop > --- > > Key: HBASE-22986 > URL: https://issues.apache.org/jira/browse/HBASE-22986 > Project: HBase > Issue Type: Sub-task > Components: documentation, hbtop >Reporter: Toshihiro Suzuki >Assignee: Toshihiro Suzuki >Priority: Minor > Fix For: 3.0.0 > > > We already have README for hbtop, so we can make the refguide refer to this: > [https://github.com/apache/hbase/blob/master/hbase-hbtop/README.md] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23129) Move core to use hbase-thirdparty-3.1.0
[ https://issues.apache.org/jira/browse/HBASE-23129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946476#comment-16946476 ] Michael Stack commented on HBASE-23129: --- Hmm. Tried to use the hbase-thirdparty lib. Ran into this issue https://github.com/eclipse/jetty.project/issues/3244 when I tried to update core to use the new hbase-thirdparty (A single failed unit test, TestProtobufUtil, complained of missing ByteBuffer position method when buffer was offheap). Pushed a recompiled artifact, one that uses the 3.1.0 tag., built with jdk8 but still not working. Works if I compile hbase-thirdparty locally w/ jdk8. Will come back to this. > Move core to use hbase-thirdparty-3.1.0 > --- > > Key: HBASE-23129 > URL: https://issues.apache.org/jira/browse/HBASE-23129 > Project: HBase > Issue Type: Sub-task >Reporter: Michael Stack >Priority: Major > > hbase-thirdparty was just released. Have core move to use the lib. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-22986) Add documentation for hbtop
[ https://issues.apache.org/jira/browse/HBASE-22986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki resolved HBASE-22986. -- Resolution: Fixed > Add documentation for hbtop > --- > > Key: HBASE-22986 > URL: https://issues.apache.org/jira/browse/HBASE-22986 > Project: HBase > Issue Type: Sub-task > Components: documentation, hbtop >Reporter: Toshihiro Suzuki >Assignee: Toshihiro Suzuki >Priority: Minor > Fix For: 3.0.0 > > > We already have README for hbtop, so we can make the refguide refer to this: > [https://github.com/apache/hbase/blob/master/hbase-hbtop/README.md] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] brfrn169 merged pull request #693: HBASE-22986 Add documentation for hbtop
brfrn169 merged pull request #693: HBASE-22986 Add documentation for hbtop URL: https://github.com/apache/hbase/pull/693 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] brfrn169 commented on issue #693: HBASE-22986 Add documentation for hbtop
brfrn169 commented on issue #693: HBASE-22986 Add documentation for hbtop URL: https://github.com/apache/hbase/pull/693#issuecomment-539313626 Thank you for reviewing this! @petersomogyi This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23120) Fix ref guide - Release process
[
https://issues.apache.org/jira/browse/HBASE-23120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-23120:
--
Fix Version/s: (was: 2.1.7)
2.1.8
> Fix ref guide - Release process
> ---
>
> Key: HBASE-23120
> URL: https://issues.apache.org/jira/browse/HBASE-23120
> Project: HBase
> Issue Type: Sub-task
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0, 2.2.2, 2.1.8
>
>
> The example is of a sample ~/.m2/settings.xml file.
> {code:java}
>
> {code}
> is not a proper comment.
> Also I think here,
> {code:java}
>
> {code}
> the double hyphened --list-keys shouldn't be used. It leads to FATAL error
> like the one below:
> {code:java}
> [FATAL] Non-parseable settings
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-22903) alter_status command is broken
[
https://issues.apache.org/jira/browse/HBASE-22903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-22903:
--
Fix Version/s: (was: 2.1.7)
2.1.8
> alter_status command is broken
> --
>
> Key: HBASE-22903
> URL: https://issues.apache.org/jira/browse/HBASE-22903
> Project: HBase
> Issue Type: Bug
> Components: metrics, shell
>Affects Versions: 3.0.0
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.2, 2.1.8
>
> Attachments: HBASE-22903.branch-2.000.patch,
> HBASE-22903.branch-2.1.000.patch
>
>
> This is applicable to master branch only:
> {code:java}
> > alter_status 't1'
> ERROR: undefined method `getAlterStatus' for
> #
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache9 opened a new pull request #697: HBASE-23130 Add 2.1.7 to download page
Apache9 opened a new pull request #697: HBASE-23130 Add 2.1.7 to download page URL: https://github.com/apache/hbase/pull/697 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23130) Add 2.1.7 to download page
[ https://issues.apache.org/jira/browse/HBASE-23130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23130: -- Component/s: website > Add 2.1.7 to download page > -- > > Key: HBASE-23130 > URL: https://issues.apache.org/jira/browse/HBASE-23130 > Project: HBase > Issue Type: Sub-task > Components: website >Reporter: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23130) Add 2.1.7 to download page
[ https://issues.apache.org/jira/browse/HBASE-23130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23130: -- Fix Version/s: 3.0.0 > Add 2.1.7 to download page > -- > > Key: HBASE-23130 > URL: https://issues.apache.org/jira/browse/HBASE-23130 > Project: HBase > Issue Type: Sub-task > Components: website >Reporter: Duo Zhang >Priority: Major > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23131) Set version as 2.1.8-SNAPSHOT in branch-2.1
[ https://issues.apache.org/jira/browse/HBASE-23131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23131: -- Component/s: pom build > Set version as 2.1.8-SNAPSHOT in branch-2.1 > --- > > Key: HBASE-23131 > URL: https://issues.apache.org/jira/browse/HBASE-23131 > Project: HBase > Issue Type: Sub-task > Components: build, pom >Reporter: Duo Zhang >Priority: Major > Fix For: 2.1.8 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 opened a new pull request #696: HBASE-23131 Set version as 2.1.8-SNAPSHOT in branch-2.1
Apache9 opened a new pull request #696: HBASE-23131 Set version as 2.1.8-SNAPSHOT in branch-2.1 URL: https://github.com/apache/hbase/pull/696 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23131) Set version as 2.1.8-SNAPSHOT in branch-2.1
[ https://issues.apache.org/jira/browse/HBASE-23131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23131: -- Fix Version/s: 2.1.8 > Set version as 2.1.8-SNAPSHOT in branch-2.1 > --- > > Key: HBASE-23131 > URL: https://issues.apache.org/jira/browse/HBASE-23131 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Priority: Major > Fix For: 2.1.8 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23131) Set version as 2.1.8-SNAPSHOT in branch-2.1
Duo Zhang created HBASE-23131: - Summary: Set version as 2.1.8-SNAPSHOT in branch-2.1 Key: HBASE-23131 URL: https://issues.apache.org/jira/browse/HBASE-23131 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23130) Add 2.1.7 to download page
Duo Zhang created HBASE-23130: - Summary: Add 2.1.7 to download page Key: HBASE-23130 URL: https://issues.apache.org/jira/browse/HBASE-23130 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23111) Put up 2.1.7RC0
[ https://issues.apache.org/jira/browse/HBASE-23111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-23111. --- Resolution: Fixed Done. > Put up 2.1.7RC0 > --- > > Key: HBASE-23111 > URL: https://issues.apache.org/jira/browse/HBASE-23111 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-22903) alter_status command is broken
[
https://issues.apache.org/jira/browse/HBASE-22903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946382#comment-16946382
]
Zheng Hu commented on HBASE-22903:
--
Committed to all branch-2.x, Thanks [~vjasani] for contributing.
> alter_status command is broken
> --
>
> Key: HBASE-22903
> URL: https://issues.apache.org/jira/browse/HBASE-22903
> Project: HBase
> Issue Type: Bug
> Components: metrics, shell
>Affects Versions: 3.0.0
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
> Attachments: HBASE-22903.branch-2.000.patch,
> HBASE-22903.branch-2.1.000.patch
>
>
> This is applicable to master branch only:
> {code:java}
> > alter_status 't1'
> ERROR: undefined method `getAlterStatus' for
> #
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-22903) alter_status command is broken
[
https://issues.apache.org/jira/browse/HBASE-22903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zheng Hu updated HBASE-22903:
-
Hadoop Flags: Reviewed
Resolution: Fixed
Status: Resolved (was: Patch Available)
> alter_status command is broken
> --
>
> Key: HBASE-22903
> URL: https://issues.apache.org/jira/browse/HBASE-22903
> Project: HBase
> Issue Type: Bug
> Components: metrics, shell
>Affects Versions: 3.0.0
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
> Attachments: HBASE-22903.branch-2.000.patch,
> HBASE-22903.branch-2.1.000.patch
>
>
> This is applicable to master branch only:
> {code:java}
> > alter_status 't1'
> ERROR: undefined method `getAlterStatus' for
> #
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-22903) alter_status command is broken
[
https://issues.apache.org/jira/browse/HBASE-22903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zheng Hu updated HBASE-22903:
-
Fix Version/s: 2.2.2
2.1.7
2.3.0
> alter_status command is broken
> --
>
> Key: HBASE-22903
> URL: https://issues.apache.org/jira/browse/HBASE-22903
> Project: HBase
> Issue Type: Bug
> Components: metrics, shell
>Affects Versions: 3.0.0
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
> Attachments: HBASE-22903.branch-2.000.patch,
> HBASE-22903.branch-2.1.000.patch
>
>
> This is applicable to master branch only:
> {code:java}
> > alter_status 't1'
> ERROR: undefined method `getAlterStatus' for
> #
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22903) alter_status command is broken
[
https://issues.apache.org/jira/browse/HBASE-22903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946378#comment-16946378
]
Zheng Hu commented on HBASE-22903:
--
Sorry about the delay, we have a long vacation in China since Oct 1. Fine, Let
me got this resovled. Thanks [~vjasani].
> alter_status command is broken
> --
>
> Key: HBASE-22903
> URL: https://issues.apache.org/jira/browse/HBASE-22903
> Project: HBase
> Issue Type: Bug
> Components: metrics, shell
>Affects Versions: 3.0.0
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-22903.branch-2.000.patch,
> HBASE-22903.branch-2.1.000.patch
>
>
> This is applicable to master branch only:
> {code:java}
> > alter_status 't1'
> ERROR: undefined method `getAlterStatus' for
> #
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23094) Wrong log message in simpleRegionNormaliser while checking if merge is enabled.
[
https://issues.apache.org/jira/browse/HBASE-23094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946377#comment-16946377
]
Hudson commented on HBASE-23094:
Results for branch branch-2.2
[build #654 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/654/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/654//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/654//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/654//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Wrong log message in simpleRegionNormaliser while checking if merge is
> enabled.
> ---
>
> Key: HBASE-23094
> URL: https://issues.apache.org/jira/browse/HBASE-23094
> Project: HBase
> Issue Type: Bug
>Reporter: Sanjeet Nishad
>Assignee: Sanjeet Nishad
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.2.2, 1.3.7, 2.1.8
>
> Attachments: HBASE-23094.001.patch, HBASE-23094.master.001.patch
>
>
> {color:#9876aa}In the following log message :{color}
> {color:#9876aa}LOG{color}.debug({color:#6a8759}"Unable to determine whether
> split is enabled"{color}{color:#cc7832}, {color}e){color:#cc7832};{color}
> {color:#cc7832}it should be "Unable to determine whether *merge* is
> enabled{color}" while checking if merge is enabled.
>
> It can lead to confusion while debugging through logs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23125) TestRSGroupsAdmin2 is flaky
[
https://issues.apache.org/jira/browse/HBASE-23125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946376#comment-16946376
]
Hudson commented on HBASE-23125:
Results for branch branch-2.2
[build #654 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/654/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/654//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/654//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/654//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestRSGroupsAdmin2 is flaky
> ---
>
> Key: HBASE-23125
> URL: https://issues.apache.org/jira/browse/HBASE-23125
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.2, 2.1.8
>
> Attachments: HBASE-23125.patch
>
>
> https://builds.apache.org/job/HBase-Flaky-Tests/job/master/4450/testReport/org.apache.hadoop.hbase.rsgroup/TestRSGroupsAdmin2/testFailedMoveServersTablesAndRepair/
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin2.randomlySetRegionState(TestRSGroupsAdmin2.java:627)
> at
> org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin2.testFailedMoveServersTablesAndRepair(TestRSGroupsAdmin2.java:754)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23094) Wrong log message in simpleRegionNormaliser while checking if merge is enabled.
[
https://issues.apache.org/jira/browse/HBASE-23094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946368#comment-16946368
]
Hudson commented on HBASE-23094:
Results for branch branch-2
[build #2315 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2315/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2315//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2315//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2315//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Wrong log message in simpleRegionNormaliser while checking if merge is
> enabled.
> ---
>
> Key: HBASE-23094
> URL: https://issues.apache.org/jira/browse/HBASE-23094
> Project: HBase
> Issue Type: Bug
>Reporter: Sanjeet Nishad
>Assignee: Sanjeet Nishad
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.2.2, 1.3.7, 2.1.8
>
> Attachments: HBASE-23094.001.patch, HBASE-23094.master.001.patch
>
>
> {color:#9876aa}In the following log message :{color}
> {color:#9876aa}LOG{color}.debug({color:#6a8759}"Unable to determine whether
> split is enabled"{color}{color:#cc7832}, {color}e){color:#cc7832};{color}
> {color:#cc7832}it should be "Unable to determine whether *merge* is
> enabled{color}" while checking if merge is enabled.
>
> It can lead to confusion while debugging through logs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23125) TestRSGroupsAdmin2 is flaky
[
https://issues.apache.org/jira/browse/HBASE-23125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946367#comment-16946367
]
Hudson commented on HBASE-23125:
Results for branch branch-2
[build #2315 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2315/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2315//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2315//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2315//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestRSGroupsAdmin2 is flaky
> ---
>
> Key: HBASE-23125
> URL: https://issues.apache.org/jira/browse/HBASE-23125
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.2, 2.1.8
>
> Attachments: HBASE-23125.patch
>
>
> https://builds.apache.org/job/HBase-Flaky-Tests/job/master/4450/testReport/org.apache.hadoop.hbase.rsgroup/TestRSGroupsAdmin2/testFailedMoveServersTablesAndRepair/
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin2.randomlySetRegionState(TestRSGroupsAdmin2.java:627)
> at
> org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin2.testFailedMoveServersTablesAndRepair(TestRSGroupsAdmin2.java:754)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] joshelser commented on a change in pull request #675: HBASE-23085: Network and Data related Actions
joshelser commented on a change in pull request #675: HBASE-23085: Network and
Data related Actions
URL: https://github.com/apache/hbase/pull/675#discussion_r332289576
##
File path:
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/DeleteDataFilesAction.java
##
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.chaos.actions;
+
+import org.apache.commons.lang3.RandomUtils;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.LocatedFileStatus;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.fs.RemoteIterator;
+import org.apache.hadoop.hbase.util.CommonFSUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Action deletes region server data.
+ */
+public class DeleteDataFilesAction extends Action {
Review comment:
Same concern with this one as the corrupt data files action.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #675: HBASE-23085: Network and Data related Actions
joshelser commented on a change in pull request #675: HBASE-23085: Network and
Data related Actions
URL: https://github.com/apache/hbase/pull/675#discussion_r332286383
##
File path:
hbase-it/src/test/java/org/apache/hadoop/hbase/HBaseClusterManager.java
##
@@ -159,6 +169,38 @@ public void execute() throws IOException {
}
}
+ /**
+ * Executes commands over SSH
+ */
+ protected class RemoteSudoShell extends Shell.ShellCommandExecutor {
Review comment:
I'm reminded of
https://unix.stackexchange.com/questions/122616/why-do-i-need-a-tty-to-run-sudo-if-i-can-sudo-without-a-password
It assume this would require the same config?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #675: HBASE-23085: Network and Data related Actions
joshelser commented on a change in pull request #675: HBASE-23085: Network and
Data related Actions
URL: https://github.com/apache/hbase/pull/675#discussion_r332288951
##
File path:
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CorruptDataFilesAction.java
##
@@ -0,0 +1,69 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.chaos.actions;
+
+import org.apache.commons.lang3.RandomUtils;
+import org.apache.hadoop.fs.FSDataOutputStream;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.LocatedFileStatus;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.fs.RemoteIterator;
+import org.apache.hadoop.hbase.util.CommonFSUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Action corrupts region server data.
+ */
+public class CorruptDataFilesAction extends Action {
Review comment:
Neat idea, but how could we tell via automation when a file was expectedly
corrupted vs. unexpectedly?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #675: HBASE-23085: Network and Data related Actions
joshelser commented on a change in pull request #675: HBASE-23085: Network and
Data related Actions
URL: https://github.com/apache/hbase/pull/675#discussion_r332288669
##
File path:
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CommandAction.java
##
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.chaos.actions;
+
+import java.io.IOException;
+
+import org.apache.hadoop.hbase.DistributedHBaseCluster;
+import org.apache.hadoop.hbase.HBaseCluster;
+import org.apache.hadoop.hbase.HBaseClusterManager;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Base class for performing Actions based on linux commands requiring sudo
privileges
+ */
+abstract public class CommandAction extends Action {
+ private static final Logger LOG =
LoggerFactory.getLogger(CommandAction.class);
+
+ protected long timeout;
+ protected HBaseClusterManager clusterManager;
+
+ public CommandAction(long timeout) {
+this.timeout = timeout;
+ }
+
+ @Override
+ public void init(ActionContext context) throws IOException {
+super.init(context);
+HBaseCluster cluster = context.getHBaseCluster();
+if(cluster != null && cluster instanceof DistributedHBaseCluster){
+ Object manager = ((DistributedHBaseCluster)cluster).getClusterManager();
+ if(manager != null && manager instanceof HBaseClusterManager){
+clusterManager = (HBaseClusterManager) manager;
+ }
+}
+ }
+
+ @Override
+ public void perform() throws Exception {
+if(clusterManager == null){
Review comment:
Any reason to not have this in `init()`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #675: HBASE-23085: Network and Data related Actions
joshelser commented on a change in pull request #675: HBASE-23085: Network and
Data related Actions
URL: https://github.com/apache/hbase/pull/675#discussion_r332288416
##
File path:
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CommandAction.java
##
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.chaos.actions;
+
+import java.io.IOException;
+
+import org.apache.hadoop.hbase.DistributedHBaseCluster;
+import org.apache.hadoop.hbase.HBaseCluster;
+import org.apache.hadoop.hbase.HBaseClusterManager;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Base class for performing Actions based on linux commands requiring sudo
privileges
+ */
+abstract public class CommandAction extends Action {
Review comment:
Agree with Balazs.
I don't think you'd need to propagate the full suffix to child classes. Make
this `SudoCommandAction` and leave `AddCpuLoadAction` (or whatever it was,
exactly) as it is.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #675: HBASE-23085: Network and Data related Actions
joshelser commented on a change in pull request #675: HBASE-23085: Network and
Data related Actions
URL: https://github.com/apache/hbase/pull/675#discussion_r332289377
##
File path:
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CorruptPackagesCommandAction.java
##
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.chaos.actions;
+
+import java.io.IOException;
+
+import org.apache.hadoop.hbase.ServerName;
+import org.apache.hadoop.hbase.chaos.monkies.PolicyBasedChaosMonkey;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ *
+ * Corrupt network packages on a random regionserver.
+ */
+public class CorruptPackagesCommandAction extends CommandAction {
+ private static final Logger LOG =
LoggerFactory.getLogger(CorruptPackagesCommandAction.class);
+ private float ratio;
+ private long duration;
+
+ /**
+ * Corrupt network packages on a random regionserver.
+ *
+ * @param ratio the ratio of packages corrupted
+ * @param duration the time this issue persists in milliseconds
+ * @param timeout the timeout for executing required commands on the region
server in milliseconds
+ */
+ public CorruptPackagesCommandAction(float ratio, long duration, long
timeout) {
+super(timeout);
+this.ratio = ratio;
+this.duration = duration;
+ }
+
+ protected void localPerform() throws IOException {
+LOG.info("Starting to execute CorruptPackagesCommandAction");
+ServerName server =
PolicyBasedChaosMonkey.selectRandomItem(getCurrentServers());
+String hostname = server.getHostname();
+
+try {
+ clusterManager.execSudoWithRetries(hostname, timeout, getCommand("add"));
+ Thread.sleep(duration);
+} catch (InterruptedException e) {
+ LOG.debug("Failed to run the command for the full duration", e);
+} finally {
+ clusterManager.execSudoWithRetries(hostname, timeout, getCommand("del"));
+}
+
+LOG.info("Finished to execute CorruptPackagesCommandAction");
+ }
+
+ private String getCommand(String operation){
+return String.format("tc qdisc %s dev eth0 root netem corrupt %s%%",
operation, ratio * 100);
Review comment:
Probably need to allow the network device to be specified, both for
predictable network interface names and bonds.
https://www.freedesktop.org/wiki/Software/systemd/PredictableNetworkInterfaceNames/
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1
Apache-HBase commented on issue #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1 URL: https://github.com/apache/hbase/pull/251#issuecomment-539253513 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 9m 47s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 1s | No case conflicting files found. | | :broken_heart: | hbaseanti | 0m 0s | The patch appears use Hadoop classification instead of HBase. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ branch-1 Compile Tests _ | | :blue_heart: | mvndep | 1m 38s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 7m 19s | branch-1 passed | | :green_heart: | compile | 1m 48s | branch-1 passed with JDK v1.8.0_222 | | :green_heart: | compile | 1m 57s | branch-1 passed with JDK v1.7.0_232 | | :green_heart: | checkstyle | 8m 44s | branch-1 passed | | :blue_heart: | refguide | 3m 37s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | :green_heart: | shadedjars | 3m 8s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 3m 10s | branch-1 passed with JDK v1.8.0_222 | | :green_heart: | javadoc | 5m 29s | branch-1 passed with JDK v1.7.0_232 | | :blue_heart: | spotbugs | 2m 47s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :blue_heart: | findbugs | 0m 17s | branch/hbase-resource-bundle no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 23s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 2m 37s | the patch passed | | :broken_heart: | compile | 0m 8s | root in the patch failed with JDK v1.8.0_222. | | :broken_heart: | javac | 0m 8s | root in the patch failed with JDK v1.8.0_222. | | :green_heart: | compile | 2m 13s | the patch passed with JDK v1.7.0_232 | | :green_heart: | javac | 2m 13s | the patch passed | | :green_heart: | checkstyle | 0m 11s | The patch passed checkstyle in hbase-resource-bundle | | :green_heart: | checkstyle | 0m 33s | The patch passed checkstyle in hbase-common | | :green_heart: | checkstyle | 1m 51s | hbase-server: The patch generated 0 new + 78 unchanged - 11 fixed = 78 total (was 89) | | :green_heart: | checkstyle | 0m 32s | The patch passed checkstyle in hbase-it | | :green_heart: | checkstyle | 5m 53s | root: The patch generated 0 new + 87 unchanged - 11 fixed = 87 total (was 98) | | :broken_heart: | checkstyle | 0m 4s | The patch fails to run checkstyle in hbase-tinylfu-blockcache | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :broken_heart: | xml | 0m 0s | The patch has 5 ill-formed XML file(s). | | :blue_heart: | refguide | 3m 14s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | :green_heart: | shadedjars | 3m 1s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 5m 12s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | :broken_heart: | javadoc | 0m 12s | hbase-it in the patch failed with JDK v1.8.0_222. | | :broken_heart: | javadoc | 0m 8s | root in the patch failed with JDK v1.8.0_222. | | :broken_heart: | javadoc | 0m 6s | hbase-tinylfu-blockcache in the patch failed with JDK v1.8.0_222. | | :broken_heart: | javadoc | 0m 7s | hbase-tinylfu-blockcache in the patch failed with JDK v1.7.0_232. | | :blue_heart: | findbugs | 0m 12s | hbase-resource-bundle has no data from findbugs | | :broken_heart: | findbugs | 0m 8s | hbase-tinylfu-blockcache in the patch failed. | ||| _ Other Tests _ | | :green_heart: | unit | 176m 7s | root in the patch passed. | | :green_heart: | asflicense | 2m 10s | The patch does not generate ASF License warnings. | | | | 294m 35s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | hbase-common/src/main/resources/hbase-default.xml | | | hbase-it/pom.xml | | | hbase-resource-bundle/src/main/resources/supplemental-models.xml | | | hbase-tinylfu-blockcache/pom.xml | | | pom.xml | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.2 Server=19.03.2 base: https:/
[GitHub] [hbase] joshelser commented on a change in pull request #661: HBASE-15519 Add per-user metrics with lossy counting
joshelser commented on a change in pull request #661: HBASE-15519 Add per-user
metrics with lossy counting
URL: https://github.com/apache/hbase/pull/661#discussion_r332271718
##
File path:
hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsUserSourceImpl.java
##
@@ -0,0 +1,76 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.regionserver;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotEquals;
+import static org.junit.Assert.assertTrue;
+
+import org.apache.hadoop.hbase.CompatibilitySingletonFactory;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.testclassification.MetricsTests;
+import org.apache.hadoop.hbase.testclassification.SmallTests;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+@Category({MetricsTests.class, SmallTests.class})
+public class TestMetricsUserSourceImpl {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestMetricsUserSourceImpl.class);
+
+ @Test
+ public void testCompareToHashCodeEquals() throws Exception {
+MetricsRegionServerSourceFactory fact
+ =
CompatibilitySingletonFactory.getInstance(MetricsRegionServerSourceFactory.class);
+
+MetricsUserSource one = fact.createUser("ONE");
+MetricsUserSource oneClone = fact.createUser("ONE");
+MetricsUserSource two = fact.createUser("TWO");
+
+assertEquals(0, one.compareTo(oneClone));
+assertEquals(one.hashCode(), oneClone.hashCode());
+assertNotEquals(one, two);
+
+assertTrue(one.compareTo(two) != 0);
+assertTrue(two.compareTo(one) != 0);
+assertTrue(two.compareTo(one) != one.compareTo(two));
+assertTrue(two.compareTo(two) == 0);
Review comment:
nit: `assertEquals` and `assertNotEquals` would give better error messages.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-23094) Wrong log message in simpleRegionNormaliser while checking if merge is enabled.
[
https://issues.apache.org/jira/browse/HBASE-23094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946333#comment-16946333
]
Hudson commented on HBASE-23094:
Results for branch branch-1.3
[build #999 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/999/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/999//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/999//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/999//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Wrong log message in simpleRegionNormaliser while checking if merge is
> enabled.
> ---
>
> Key: HBASE-23094
> URL: https://issues.apache.org/jira/browse/HBASE-23094
> Project: HBase
> Issue Type: Bug
>Reporter: Sanjeet Nishad
>Assignee: Sanjeet Nishad
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.2.2, 1.3.7, 2.1.8
>
> Attachments: HBASE-23094.001.patch, HBASE-23094.master.001.patch
>
>
> {color:#9876aa}In the following log message :{color}
> {color:#9876aa}LOG{color}.debug({color:#6a8759}"Unable to determine whether
> split is enabled"{color}{color:#cc7832}, {color}e){color:#cc7832};{color}
> {color:#cc7832}it should be "Unable to determine whether *merge* is
> enabled{color}" while checking if merge is enabled.
>
> It can lead to confusion while debugging through logs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #695: HBASE-23129 Move core to use hbase-thirdparty-3.1.0
Apache-HBase commented on issue #695: HBASE-23129 Move core to use hbase-thirdparty-3.1.0 URL: https://github.com/apache/hbase/pull/695#issuecomment-539245769 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 1m 14s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :yellow_heart: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | :blue_heart: | mvndep | 0m 44s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 5m 44s | master passed | | :green_heart: | compile | 3m 14s | master passed | | :green_heart: | shadedjars | 5m 3s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 3m 13s | master passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 24s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 5m 35s | the patch passed | | :green_heart: | compile | 3m 17s | the patch passed | | :green_heart: | javac | 3m 17s | the patch passed | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | :green_heart: | shadedjars | 4m 56s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 17m 15s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 3m 11s | the patch passed | ||| _ Other Tests _ | | :broken_heart: | unit | 10m 3s | root in the patch failed. | | :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. | | | | 71m 11s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.shaded.protobuf.TestProtobufUtil | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-695/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/695 | | Optional Tests | dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile | | uname | Linux d941bf3d7f2e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-695/out/precommit/personality/provided.sh | | git revision | master / 10180e232e | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-695/1/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-695/1/testReport/ | | Max. process+thread count | 282 (vs. ulimit of 1) | | modules | C: hbase-common . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-695/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-21856) Consider Causal Replication Ordering
[ https://issues.apache.org/jira/browse/HBASE-21856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946309#comment-16946309 ] Bharath Vissapragada commented on HBASE-21856: -- I'm kinda curious how this relates to HBASE-20046. It looks to me like the intent here is same. Thoughts? (or am I missing something?) > Consider Causal Replication Ordering > > > Key: HBASE-21856 > URL: https://issues.apache.org/jira/browse/HBASE-21856 > Project: HBase > Issue Type: Brainstorming > Components: Replication >Reporter: Lars Hofhansl >Priority: Major > Labels: Replication > > We've had various efforts to improve the ordering guarantees for HBase > replication, most notably Serial Replication. > I think in many cases guaranteeing a Total Replication Order is not required, > but a simpler Causal Replication Order is sufficient. > Specifically we would guarantee causal ordering for a single Rowkey. Any > changes to a Row - Puts, Deletes, etc - would be replicated in the exact > order in which they occurred in the source system. > Unlike total ordering this can be accomplished with only local region server > control. > I don't have a full design in mind, let's discuss here. It should be > sufficient to to the following: > # RegionServers only adopt the replication queues from other RegionServers > for regions they (now) own. This requires log splitting for replication. > # RegionServers ship all edits for queues adopted from other servers before > any of their "own" edits are shipped. > It's probably a bit more involved, but should be much cheaper that the total > ordering provided by serial replication. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #694: HBASE-23128 Restore Region interface compatibility
Apache-HBase commented on issue #694: HBASE-23128 Restore Region interface compatibility URL: https://github.com/apache/hbase/pull/694#issuecomment-539226196 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :yellow_heart: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-1 Compile Tests _ | | :green_heart: | mvninstall | 8m 22s | branch-1 passed | | :green_heart: | compile | 0m 42s | branch-1 passed with JDK v1.8.0_222 | | :green_heart: | compile | 0m 48s | branch-1 passed with JDK v1.7.0_232 | | :green_heart: | checkstyle | 1m 53s | branch-1 passed | | :green_heart: | shadedjars | 3m 7s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 37s | branch-1 passed with JDK v1.8.0_222 | | :green_heart: | javadoc | 0m 40s | branch-1 passed with JDK v1.7.0_232 | | :blue_heart: | spotbugs | 3m 1s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 2m 59s | branch-1 passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 2m 2s | the patch passed | | :green_heart: | compile | 0m 41s | the patch passed with JDK v1.8.0_222 | | :green_heart: | javac | 0m 41s | the patch passed | | :green_heart: | compile | 0m 46s | the patch passed with JDK v1.7.0_232 | | :green_heart: | javac | 0m 46s | the patch passed | | :broken_heart: | checkstyle | 1m 48s | hbase-server: The patch generated 3 new + 374 unchanged - 0 fixed = 377 total (was 374) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 3m 4s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 5m 9s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | :green_heart: | javadoc | 0m 30s | the patch passed with JDK v1.8.0_222 | | :green_heart: | javadoc | 0m 41s | the patch passed with JDK v1.7.0_232 | | :green_heart: | findbugs | 3m 4s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 119m 47s | hbase-server in the patch passed. | | :green_heart: | asflicense | 0m 28s | The patch does not generate ASF License warnings. | | | | 161m 25s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-694/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/694 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f8eb9d19ec2c 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-694/out/precommit/personality/provided.sh | | git revision | branch-1 / 3966d0f | | Default Java | 1.7.0_232 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_222 /usr/lib/jvm/zulu-7-amd64:1.7.0_232 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-694/1/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-694/1/testReport/ | | Max. process+thread count | 4049 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-694/1/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack opened a new pull request #695: HBASE-23129 Move core to use hbase-thirdparty-3.1.0
saintstack opened a new pull request #695: HBASE-23129 Move core to use hbase-thirdparty-3.1.0 URL: https://github.com/apache/hbase/pull/695 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-23100) Make a 3.1.0 hbase-thirdparty release
[ https://issues.apache.org/jira/browse/HBASE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-23100. --- Fix Version/s: 3.0.0 Resolution: Fixed Resolving as done. > Make a 3.1.0 hbase-thirdparty release > - > > Key: HBASE-23100 > URL: https://issues.apache.org/jira/browse/HBASE-23100 > Project: HBase > Issue Type: Task > Components: hbase-thirdparty >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0 > > > Make a hbase-thirdparty release. 3.0.0 broke out a gson module out of the > miscellaneous where it used live. 3.1.0 is about updating the dependencies in > hbase-thirdparty. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23129) Move core to use hbase-thirdparty-3.1.0
Michael Stack created HBASE-23129: - Summary: Move core to use hbase-thirdparty-3.1.0 Key: HBASE-23129 URL: https://issues.apache.org/jira/browse/HBASE-23129 Project: HBase Issue Type: Sub-task Reporter: Michael Stack hbase-thirdparty was just released. Have core move to use the lib. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23100) Make a 3.1.0 hbase-thirdparty release
[ https://issues.apache.org/jira/browse/HBASE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946276#comment-16946276 ] Michael Stack commented on HBASE-23100: --- RC3 VOTE passed. Released artifact in repository.apache.org. Added rel/3.1.0 tag at 3.1.0RC3. In apache.dist, did $ svn mv dev/hbase/3.1.0RC3 release/hbase/hbase-thirdparty-3.1.0 Did NOT send out notice. No one cares but us on dev. Filing subtask to update our core repo so it pulls in new lib. > Make a 3.1.0 hbase-thirdparty release > - > > Key: HBASE-23100 > URL: https://issues.apache.org/jira/browse/HBASE-23100 > Project: HBase > Issue Type: Task > Components: hbase-thirdparty >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > > Make a hbase-thirdparty release. 3.0.0 broke out a gson module out of the > miscellaneous where it used live. 3.1.0 is about updating the dependencies in > hbase-thirdparty. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HBASE-21776) Duplicate "Set storagePolicy" debug logging
[ https://issues.apache.org/jira/browse/HBASE-21776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-21776 started by Sandeep Pal. --- > Duplicate "Set storagePolicy" debug logging > --- > > Key: HBASE-21776 > URL: https://issues.apache.org/jira/browse/HBASE-21776 > Project: HBase > Issue Type: Bug > Components: Compaction >Affects Versions: 1.5.0 >Reporter: Andrew Kyle Purtell >Assignee: Sandeep Pal >Priority: Trivial > Labels: branch-1 > Fix For: 1.6.0, 1.5.1 > > > An example: > 2019-01-25 02:57:15,831 DEBUG > [regionserver/ip-172-31-13-83.us-west-2.compute.internal/172.31.13.83:8120-longCompactions-1548384634805] > util.CommonFSUtils: Set storagePolicy=HOT for > path=hdfs://ip-172-31-5-95.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestBigLinkedList/16899cdfdb4ab217208f4108ad0c4803/.tmp/meta > 2019-01-25 02:57:15,831 DEBUG > [regionserver/ip-172-31-13-83.us-west-2.compute.internal/172.31.13.83:8120-longCompactions-1548384634805] > util.CommonFSUtils: Set storagePolicy=HOT for > path=hdfs://ip-172-31-5-95.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestBigLinkedList/16899cdfdb4ab217208f4108ad0c4803/.tmp/meta > Seen most often during compactions. Ideally we only log once per directory > per flush or compaction. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HBASE-22126) TestBlocksRead is flaky
[ https://issues.apache.org/jira/browse/HBASE-22126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-22126 started by Sandeep Pal. --- > TestBlocksRead is flaky > --- > > Key: HBASE-22126 > URL: https://issues.apache.org/jira/browse/HBASE-22126 > Project: HBase > Issue Type: Test > Components: test >Affects Versions: 1.5.0 >Reporter: Andrew Kyle Purtell >Assignee: Sandeep Pal >Priority: Major > Labels: branch-1 > Fix For: 1.6.0, 1.5.1 > > > TestBlocksRead does not fail when invoked by itself but is flaky when run as > part of the suite. > Some kind of race during setup. > [ERROR] > testBlocksStoredWhenCachingDisabled(org.apache.hadoop.hbase.regionserver.TestBlocksRead) > Time elapsed: 0.19 s <<< ERROR! > java.net.ConnectException: Call From $HOST/$IP to localhost:59658 failed on > connection exception: java.net.ConnectException: Connection refused; For more > details see: http://wiki.apache.org/hadoop/ConnectionRefused > at > org.apache.hadoop.hbase.regionserver.TestBlocksRead.initHRegion(TestBlocksRead.java:112) > at > org.apache.hadoop.hbase.regionserver.TestBlocksRead.testBlocksStoredWhenCachingDisabled(TestBlocksRead.java:389) > Caused by: java.net.ConnectException: Connection refused > at > org.apache.hadoop.hbase.regionserver.TestBlocksRead.initHRegion(TestBlocksRead.java:112) > at > org.apache.hadoop.hbase.regionserver.TestBlocksRead.testBlocksStoredWhenCachingDisabled(TestBlocksRead.java:389) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23094) Wrong log message in simpleRegionNormaliser while checking if merge is enabled.
[
https://issues.apache.org/jira/browse/HBASE-23094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946200#comment-16946200
]
Hudson commented on HBASE-23094:
Results for branch branch-1.4
[build #1048 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1048/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1048//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1048//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1048//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Wrong log message in simpleRegionNormaliser while checking if merge is
> enabled.
> ---
>
> Key: HBASE-23094
> URL: https://issues.apache.org/jira/browse/HBASE-23094
> Project: HBase
> Issue Type: Bug
>Reporter: Sanjeet Nishad
>Assignee: Sanjeet Nishad
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.2.2, 1.3.7, 2.1.8
>
> Attachments: HBASE-23094.001.patch, HBASE-23094.master.001.patch
>
>
> {color:#9876aa}In the following log message :{color}
> {color:#9876aa}LOG{color}.debug({color:#6a8759}"Unable to determine whether
> split is enabled"{color}{color:#cc7832}, {color}e){color:#cc7832};{color}
> {color:#cc7832}it should be "Unable to determine whether *merge* is
> enabled{color}" while checking if merge is enabled.
>
> It can lead to confusion while debugging through logs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-23128) Restore Region interface compatibility
[
https://issues.apache.org/jira/browse/HBASE-23128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell resolved HBASE-23128.
-
Resolution: Fixed
> Restore Region interface compatibility
> ---
>
> Key: HBASE-23128
> URL: https://issues.apache.org/jira/browse/HBASE-23128
> Project: HBase
> Issue Type: Bug
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Blocker
> Fix For: 1.5.0
>
>
> Adding methods to a Public interface is ok for a minor release, removing
> methods is not. We need to restore
> {code}
> abstract method boolean bulkLoadHFiles (
> Collection>, boolean, Region.BulkLoadListener)
> {code}
> to the Region interface in order to maintain binary compatibility.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] apurtell closed pull request #694: HBASE-23128 Restore Region interface compatibility
apurtell closed pull request #694: HBASE-23128 Restore Region interface compatibility URL: https://github.com/apache/hbase/pull/694 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23128) Restore Region interface compatibility
[
https://issues.apache.org/jira/browse/HBASE-23128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946161#comment-16946161
]
Andrew Kyle Purtell commented on HBASE-23128:
-
I'm going to merge the PR as soon as the compat report verifies the issue with
Region is fixed so I can get out the 1.5.0 RC4 but we can always circle back if
there's something that needs changing.
> Restore Region interface compatibility
> ---
>
> Key: HBASE-23128
> URL: https://issues.apache.org/jira/browse/HBASE-23128
> Project: HBase
> Issue Type: Bug
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Blocker
> Fix For: 1.5.0
>
>
> Adding methods to a Public interface is ok for a minor release, removing
> methods is not. We need to restore
> {code}
> abstract method boolean bulkLoadHFiles (
> Collection>, boolean, Region.BulkLoadListener)
> {code}
> to the Region interface in order to maintain binary compatibility.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] apurtell commented on issue #694: HBASE-23128 Restore Region interface compatibility
apurtell commented on issue #694: HBASE-23128 Restore Region interface compatibility URL: https://github.com/apache/hbase/pull/694#issuecomment-539166376 I'm going to merge this as soon as the compat report verifies the issue with Region is fixed so I can get out the 1.5.0 RC4 but we can always circle back if there's something that needs changing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] apurtell opened a new pull request #694: HBASE-23128 Restore Region interface compatibility
apurtell opened a new pull request #694: HBASE-23128 Restore Region interface compatibility URL: https://github.com/apache/hbase/pull/694 Restore and deprecate Region#bulkLoadHFiles(Collection>, boolean, Region.BulkLoadListener). Warn if invoked. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23128) Restore Region interface compatibility
[
https://issues.apache.org/jira/browse/HBASE-23128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-23128:
Description:
Adding methods to a Public interface is ok for a minor release, removing
methods is not. We need to restore
{code}
abstract method boolean bulkLoadHFiles (
Collection>, boolean, Region.BulkLoadListener)
{code}
to the Region interface in order to maintain binary compatibility.
was:
Adding methods to a Public interface is ok for a minor release, removing
methods is not. We need to restore
abstract method boolean bulkLoadHFiles ( Collection>,
boolean, Region.BulkLoadListener )
in order to maintain binary compatibility.
> Restore Region interface compatibility
> ---
>
> Key: HBASE-23128
> URL: https://issues.apache.org/jira/browse/HBASE-23128
> Project: HBase
> Issue Type: Bug
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Blocker
> Fix For: 1.5.0
>
>
> Adding methods to a Public interface is ok for a minor release, removing
> methods is not. We need to restore
> {code}
> abstract method boolean bulkLoadHFiles (
> Collection>, boolean, Region.BulkLoadListener)
> {code}
> to the Region interface in order to maintain binary compatibility.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23128) Restore Region interface compatibility
[ https://issues.apache.org/jira/browse/HBASE-23128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-23128: Fix Version/s: 1.5.0 > Restore Region interface compatibility > --- > > Key: HBASE-23128 > URL: https://issues.apache.org/jira/browse/HBASE-23128 > Project: HBase > Issue Type: Bug >Reporter: Andrew Kyle Purtell >Priority: Trivial > Fix For: 1.5.0 > > > Adding methods to a Public interface is ok for a minor release, removing > methods is not. We need to restore > abstract method boolean bulkLoadHFiles ( Collection>, > boolean, Region.BulkLoadListener ) > in order to maintain binary compatibility. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23128) Restore Region interface compatibility
[ https://issues.apache.org/jira/browse/HBASE-23128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-23128: Priority: Blocker (was: Trivial) > Restore Region interface compatibility > --- > > Key: HBASE-23128 > URL: https://issues.apache.org/jira/browse/HBASE-23128 > Project: HBase > Issue Type: Bug >Reporter: Andrew Kyle Purtell >Priority: Blocker > Fix For: 1.5.0 > > > Adding methods to a Public interface is ok for a minor release, removing > methods is not. We need to restore > abstract method boolean bulkLoadHFiles ( Collection>, > boolean, Region.BulkLoadListener ) > in order to maintain binary compatibility. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23128) Restore Region interface compatibility
Andrew Kyle Purtell created HBASE-23128: --- Summary: Restore Region interface compatibility Key: HBASE-23128 URL: https://issues.apache.org/jira/browse/HBASE-23128 Project: HBase Issue Type: Bug Reporter: Andrew Kyle Purtell Adding methods to a Public interface is ok for a minor release, removing methods is not. We need to restore abstract method boolean bulkLoadHFiles ( Collection>, boolean, Region.BulkLoadListener ) in order to maintain binary compatibility. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-23128) Restore Region interface compatibility
[ https://issues.apache.org/jira/browse/HBASE-23128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell reassigned HBASE-23128: --- Assignee: Andrew Kyle Purtell > Restore Region interface compatibility > --- > > Key: HBASE-23128 > URL: https://issues.apache.org/jira/browse/HBASE-23128 > Project: HBase > Issue Type: Bug >Reporter: Andrew Kyle Purtell >Assignee: Andrew Kyle Purtell >Priority: Blocker > Fix For: 1.5.0 > > > Adding methods to a Public interface is ok for a minor release, removing > methods is not. We need to restore > abstract method boolean bulkLoadHFiles ( Collection>, > boolean, Region.BulkLoadListener ) > in order to maintain binary compatibility. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-22487) getMostLoadedRegions is unused
[
https://issues.apache.org/jira/browse/HBASE-22487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-22487:
Fix Version/s: (was: 1.5.0)
> getMostLoadedRegions is unused
> --
>
> Key: HBASE-22487
> URL: https://issues.apache.org/jira/browse/HBASE-22487
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Reporter: Clay B.
>Assignee: Clay B.
>Priority: Trivial
> Fix For: 3.0.0, 2.2.0, 1.4.10, 2.3.0, 1.3.5, 2.1.6
>
> Attachments: 0001-HBASE-22487-getMostLoadedRegions-is-unused.patch
>
>
> Reading {{HRegionServer.java}}, I noticed the function
> {{getMostLoadedRegions}} this seems to replicate functionality found now in
> the {{StochasticLoadBalancer.}} Further, it seems the only consumer of this
> function was removed in HBASE-805.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-22392) Remove extra/useless +
[
https://issues.apache.org/jira/browse/HBASE-22392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-22392:
Fix Version/s: (was: 1.5.0)
> Remove extra/useless +
> ---
>
> Key: HBASE-22392
> URL: https://issues.apache.org/jira/browse/HBASE-22392
> Project: HBase
> Issue Type: Improvement
>Reporter: puleya7
>Assignee: puleya7
>Priority: Trivial
> Fix For: 3.0.0, 2.2.0, 1.4.10, 2.3.0, 2.0.6, 2.1.5, 1.3.5
>
> Attachments: HBASE-22392.branch-1.001.patch,
> HBASE-22392.master.001.patch
>
>
> {code:java}
> [HRegion.java]
> LOG.info("Flushing " + + storesToFlush.size() + "/" + stores.size() + "
> column families," +
> [HStore.java]
> ", sequenceid=" + +storeFile.getReader().getSequenceID() + ", filesize="
> [LoadIncrementalHFiles.java]
> LOG.info("Split occurred while grouping HFiles, retry attempt " + +count + "
> with " +{code}
>
> Has 3 extra/useless "+".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-22429) hbase-vote download step requires URL to end with '/'
[ https://issues.apache.org/jira/browse/HBASE-22429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-22429: Fix Version/s: (was: 1.5.0) > hbase-vote download step requires URL to end with '/' > -- > > Key: HBASE-22429 > URL: https://issues.apache.org/jira/browse/HBASE-22429 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Kyle Purtell >Assignee: Tak-Lon (Stephen) Wu >Priority: Trivial > Fix For: 3.0.0, 2.2.0, 1.4.10, 2.3.0, 1.3.5 > > > The hbase-vote script's download step requires the sourcedir URL be > terminated with a path separator or else the retrieval will escape the > candidate's directory and mirror way too much. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-22125) Fix more instances in make_rc.sh where we need -Dhttps.protocols=TLSv1.2
[ https://issues.apache.org/jira/browse/HBASE-22125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-22125: Fix Version/s: (was: 1.5.0) > Fix more instances in make_rc.sh where we need -Dhttps.protocols=TLSv1.2 > > > Key: HBASE-22125 > URL: https://issues.apache.org/jira/browse/HBASE-22125 > Project: HBase > Issue Type: Bug >Reporter: Andrew Kyle Purtell >Assignee: Andrew Kyle Purtell >Priority: Trivial > Fix For: 1.4.10, 1.3.4, 1.2.12 > > Attachments: HBASE-22125-branch-1.patch > > > make_rc.sh on branch-1 is missing some places where we need to define the > system property https.protocols=TLSv1.2 in order for JDK 7 to succeed in > accessing Maven resources. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-21818) Incorrect list item in javadoc
[
https://issues.apache.org/jira/browse/HBASE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-21818:
Fix Version/s: (was: 1.5.0)
> Incorrect list item in javadoc
> --
>
> Key: HBASE-21818
> URL: https://issues.apache.org/jira/browse/HBASE-21818
> Project: HBase
> Issue Type: Improvement
> Components: documentation, master
>Affects Versions: 1.1.0
> Environment: has nothing to do with env
>Reporter: qiang Liu
>Assignee: qiang Liu
>Priority: Trivial
> Labels: easyfix, javadoc
> Fix For: 1.4.10, 1.3.4
>
> Attachments: HBASE-21818.branch-1.001.patch,
> HBASE-21818.branch-1.002.patch, HBASE-21818.branch-1.003.patch,
> HBASE-21818.branch-1.004.patch, HBASE-21818.branch-1.005.patch,
> HBASE-21818.branch-1.006.patch, blankLineOfJavaDoc.png
>
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> the java doc of this function type a as ，so dispaly a blanck line
> {code:java}
> //org.apache.hadoop.hbase.master.HMaster#finishActiveMasterInitialization
> {code}
> paste the function and it's doc here , please look the line "Ensure
> assignment of meta/namespace regions"
>
>
> {code:java}
> /**
> * Finish initialization of HMaster after becoming the primary master.
> *
> *
> * Initialize master components - file system manager, server manager,
> * assignment manager, region server tracker, etc
> * Start necessary service threads - balancer, catalog janior,
> * executor services, etc
> * Set cluster as UP in ZooKeeper
> * Wait for RegionServers to check-in
> * Split logs and perform data recovery, if necessary
> * Ensure assignment of meta/namespace regions
> * Handle either fresh cluster start or master failover
> *
> *
> * @throws IOException
> * @throws InterruptedException
> * @throws KeeperException
> * @throws CoordinatedStateException
> */
> private void finishActiveMasterInitialization(MonitoredTask status)
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-21766) TestSimpleRpcScheduler is flaky (branch-1)
[ https://issues.apache.org/jira/browse/HBASE-21766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-21766: Fix Version/s: (was: 1.5.0) > TestSimpleRpcScheduler is flaky (branch-1) > -- > > Key: HBASE-21766 > URL: https://issues.apache.org/jira/browse/HBASE-21766 > Project: HBase > Issue Type: Bug > Components: rpc, test >Affects Versions: 1.5.0 >Reporter: Andrew Kyle Purtell >Assignee: Andrew Kyle Purtell >Priority: Trivial > Fix For: 1.4.10, 1.3.4 > > Attachments: HBASE-21766-branch-1.patch > > > Trivial fix for flakiness in TestSimpleRpcScheduler when test host is under > load. See patch. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-22430) hbase-vote should tee build and test output to console
[ https://issues.apache.org/jira/browse/HBASE-22430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-22430: Fix Version/s: (was: 1.5.0) > hbase-vote should tee build and test output to console > -- > > Key: HBASE-22430 > URL: https://issues.apache.org/jira/browse/HBASE-22430 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Kyle Purtell >Assignee: Andrew Kyle Purtell >Priority: Trivial > Fix For: 3.0.0, 2.2.0, 1.4.10, 2.3.0, 1.3.5 > > Attachments: HBASE-22430.patch, HBASE-22430.patch > > > The hbase-vote script should tee the build and test output to console in > addition to the output file so the user does not become suspicious about > progress. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-22540) [Memstore] Correct counters in MemStoreChunkPool
[ https://issues.apache.org/jira/browse/HBASE-22540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-22540: Fix Version/s: (was: 1.5.0) > [Memstore] Correct counters in MemStoreChunkPool > > > Key: HBASE-22540 > URL: https://issues.apache.org/jira/browse/HBASE-22540 > Project: HBase > Issue Type: Improvement >Affects Versions: 1.4.6 >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > Fix For: 1.4.10 > > > As title reads. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-22533) TestAccessController3 is flaky (branch-1)
[ https://issues.apache.org/jira/browse/HBASE-22533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-22533: Fix Version/s: (was: 1.5.0) > TestAccessController3 is flaky (branch-1) > - > > Key: HBASE-22533 > URL: https://issues.apache.org/jira/browse/HBASE-22533 > Project: HBase > Issue Type: Bug >Reporter: Andrew Kyle Purtell >Assignee: Andrew Kyle Purtell >Priority: Minor > Fix For: 1.4.10, 1.3.5 > > Attachments: HBASE-22533-branch-1.patch > > > Wait for table create to complete before taking further action in security > tests. Avoid a noisy NPE if test initialization fails. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (HBASE-22903) alter_status command is broken
[
https://issues.apache.org/jira/browse/HBASE-22903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943359#comment-16943359
]
Viraj Jasani edited comment on HBASE-22903 at 10/7/19 6:40 PM:
---
{quote}branch-2.000 should work for branch-2 and 2.2, and branch-2.1.000 for
branch-2.1
{quote}
[~openinx] could you please help with branch-2.x commits?
Thank you
was (Author: vjasani):
{quote}branch-2.000 should work for branch-2 and 2.2, and branch-2.1.000 for
branch-2.1
{quote}
[~openinx] could you please help with branch-2.x commits?
Thank you
> alter_status command is broken
> --
>
> Key: HBASE-22903
> URL: https://issues.apache.org/jira/browse/HBASE-22903
> Project: HBase
> Issue Type: Bug
> Components: metrics, shell
>Affects Versions: 3.0.0
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-22903.branch-2.000.patch,
> HBASE-22903.branch-2.1.000.patch
>
>
> This is applicable to master branch only:
> {code:java}
> > alter_status 't1'
> ERROR: undefined method `getAlterStatus' for
> #
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-22384) Formatting issues in administration section of book
[ https://issues.apache.org/jira/browse/HBASE-22384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-22384: Fix Version/s: (was: 1.5.0) > Formatting issues in administration section of book > --- > > Key: HBASE-22384 > URL: https://issues.apache.org/jira/browse/HBASE-22384 > Project: HBase > Issue Type: Improvement > Components: community, documentation >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Fix For: 3.0.0, 2.2.0, 1.4.10, 2.3.0, 2.0.6, 2.1.5, 1.3.5 > > > The administration section in the book (64.3.2. Administration) has some > formatting issues. Due to that issues the list count is not accurate, as well > as the indentation of some code snippets. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-22449) https everywhere in Maven metadata
[ https://issues.apache.org/jira/browse/HBASE-22449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-22449: Fix Version/s: (was: 1.5.0) > https everywhere in Maven metadata > -- > > Key: HBASE-22449 > URL: https://issues.apache.org/jira/browse/HBASE-22449 > Project: HBase > Issue Type: Task >Reporter: Andrew Kyle Purtell >Assignee: Andrew Kyle Purtell >Priority: Minor > Fix For: 3.0.0, 2.2.0, 1.4.10, 2.3.0, 2.1.5, 1.3.5 > > Attachments: HBASE-22449.patch > > > There will be some attention paid to insecure URLs used for retrieval of > build dependencies. While our build does not have direct exposure to this we > do have some insecure URLs pointing to secondary resources like JIRA, mailing > list archives, hbase.apache.org, and the online book. Make these https too. > I left the license header text alone, although there is a URL to the ASL 2 > license embedded there. If we are going to update that, let's do that as a > separate task because just about every file is going to be touched. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-22474) Add --mvn-custom-repo parameter to yetus calls
[ https://issues.apache.org/jira/browse/HBASE-22474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-22474: Fix Version/s: (was: 1.5.0) > Add --mvn-custom-repo parameter to yetus calls > -- > > Key: HBASE-22474 > URL: https://issues.apache.org/jira/browse/HBASE-22474 > Project: HBase > Issue Type: Improvement >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Minor > Fix For: 3.0.0, 2.2.0, 1.4.10, 2.0.6, 2.1.5, 1.3.5 > > > PreCommit validation from yetus uses a shared .m2 repository. By adding > --mvn-custom-repo and --jenkins paramters yetus will use a custom .m2 > directory for executions for PR validations. > [https://yetus.apache.org/documentation/0.9.0/precommit-buildtools/] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-22391) Fix flaky tests from TestFromClientSide
[ https://issues.apache.org/jira/browse/HBASE-22391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-22391: Fix Version/s: (was: 1.5.0) > Fix flaky tests from TestFromClientSide > --- > > Key: HBASE-22391 > URL: https://issues.apache.org/jira/browse/HBASE-22391 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 3.0.0, 1.5.0, 2.0.5 >Reporter: Xu Cang >Assignee: Xu Cang >Priority: Minor > Fix For: 1.4.10, 1.3.5 > > Attachments: HBASE-22391-branch-1.001.patch > > > tests in TestFromClientSide.java in general are flaky due to the reason that > after createTable, they did not wait for table to be ready before adding data > into table. > Found this issue when working on HBASE-22274 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-22225) Profiler tab on Master/RS UI not working w/o comprehensive message
[
https://issues.apache.org/jira/browse/HBASE-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-5:
Fix Version/s: (was: 1.5.0)
> Profiler tab on Master/RS UI not working w/o comprehensive message
> --
>
> Key: HBASE-5
> URL: https://issues.apache.org/jira/browse/HBASE-5
> Project: HBase
> Issue Type: Improvement
> Components: UI
>Affects Versions: 1.5.0
>Reporter: Yu Li
>Assignee: Andrew Kyle Purtell
>Priority: Minor
> Fix For: 3.0.0, 2.2.0, 1.4.10, 2.3.0, 2.1.5, 1.3.5
>
> Attachments: HBASE-5-branch-1.patch, HBASE-5.patch, Screen
> Shot 2019-04-26 at 4.50.01 PM.jpg
>
>
> As titled, when checking 1.5.0 RC3 binary package, clicking the "Profiler"
> tab on HMaster/RegionServer web UI, it complains page not found error like
> below:
> {noformat}
> Problem accessing /prof. Reason:
> NOT_FOUND
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-21963) Add a script for building and verifying release candidate
[
https://issues.apache.org/jira/browse/HBASE-21963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-21963:
Fix Version/s: (was: 1.5.0)
> Add a script for building and verifying release candidate
> -
>
> Key: HBASE-21963
> URL: https://issues.apache.org/jira/browse/HBASE-21963
> Project: HBase
> Issue Type: Test
> Components: community, scripts
>Affects Versions: 3.0.0, 2.1.3
>Reporter: Tak-Lon (Stephen) Wu
>Assignee: Tak-Lon (Stephen) Wu
>Priority: Minor
> Fix For: 3.0.0, 2.2.0, 1.4.10, 1.3.4, 2.3.0, 2.0.6, 1.2.12, 2.1.5
>
> Attachments: HBASE-21963.master.001.patch,
> HBASE-21963.master.002.patch, HBASE-21963.master.003.patch,
> HBASE-21963.master.004.patch, HBASE-21963.master.005.patch,
> HBASE-21963.master.006.patch
>
>
> During the release vote for HBase 2.1.3RC1, a driver/helper script was
> mentioned and can potentially help contributors prepare to vote for a release
> candidate. As recommended, we decided to move toward this tool to under
> {{dev-support/}}
> Here the driver script provides the following automation:
> 1. Import and check publisher key(s)
> 2. Checksum of sources and binaries
> 3. Signature of sources and binaries
> 4. Rat check
> 5. Built from source
> 6. Verify unit tests
> {code}
> # example usage
> $ bash dev-support/hbase-vote.sh -s
> https://dist.apache.org/repos/dist/dev/hbase/hbase-1.5.0RC2/
> $ bash dev-support/hbase-vote.sh -h
> hbase-vote. A script for standard vote which verifies the following items
> 1. Checksum of sources and binaries
> 2. Signature of sources and binaries
> 3. Rat check
> 4. Built from source
> 5. Unit tests
> Usage: hbase-vote.sh -s | --source [-k | --key ] [-f |
> --keys-file-url ]
>hbase-vote.sh -h | --help
> -h | --help Show this screen.
> -s | --source '' A URL pointing to the release candidate
> sources and binaries
> e.g.
> https://dist.apache.org/repos/dist/dev/hbase/hbase-RC0/
> -k | --key '' A signature of the public key, e.g. 9AD2AE49
> -f | --keys-file-url '' the URL of the key file, default is
> http://www.apache.org/dist/hbase/KEYS
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-22379) Fix Markdown for "Voting on Release Candidates" in book
[ https://issues.apache.org/jira/browse/HBASE-22379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-22379: Fix Version/s: (was: 1.5.0) > Fix Markdown for "Voting on Release Candidates" in book > --- > > Key: HBASE-22379 > URL: https://issues.apache.org/jira/browse/HBASE-22379 > Project: HBase > Issue Type: Improvement > Components: community, documentation >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Fix For: 3.0.0, 2.2.0, 1.4.10, 2.3.0, 2.0.6, 2.1.5, 1.3.5 > > > The Markdown in the section "Voting on Release Candidates" of the HBase book > seems to be broken. It looks like that there should be a quote, which isn't > displayed correctly. Same is true for the formatting of the Maven RAT command. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-22358) Change rubocop configuration for method length
[ https://issues.apache.org/jira/browse/HBASE-22358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-22358: Fix Version/s: (was: 1.5.0) > Change rubocop configuration for method length > -- > > Key: HBASE-22358 > URL: https://issues.apache.org/jira/browse/HBASE-22358 > Project: HBase > Issue Type: Improvement > Components: community, shell >Reporter: Jan Hentschel >Assignee: Murtaza Hassan >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0, 2.2.0, 1.4.10, 2.3.0, 2.0.6, 2.1.5, 1.3.5 > > > rubocop currently uses a maximum method length for the Ruby code of 10, which > is way too restrictive. In Checkstyle we're using 150 lines per method. Don't > know if it needs to be that much, but something between 50 and 75 seems to be > more realistic, especially for test cases. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-21884) Fix box/unbox findbugs warning in secure bulk load
[
https://issues.apache.org/jira/browse/HBASE-21884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-21884:
Fix Version/s: (was: 1.5.0)
> Fix box/unbox findbugs warning in secure bulk load
> --
>
> Key: HBASE-21884
> URL: https://issues.apache.org/jira/browse/HBASE-21884
> Project: HBase
> Issue Type: Task
>Affects Versions: 3.0.0, 1.5.0, 2.2.0, 2.1.1, 2.0.3, 2.1.2, 2.0.4, 1.4.10,
> 1.3.4, 1.2.11, 2.3.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Minor
> Fix For: 3.0.0, 2.2.0, 1.4.10, 2.0.5, 1.3.4, 1.2.11, 2.3.0, 2.1.4
>
> Attachments: HBASE-21884-branch-1.v0.patch,
> HBASE-21884-master.v0.patch, HBASE-21884-master.v1.patch
>
>
> {code}
> ReasonTests
> FindBugs module:hbase-server
> Boxed value is unboxed and then immediately reboxed in
> org.apache.hadoop.hbase.security.access.SecureBulkLoadEndpoint.incrementUgiReference(UserGroupInformation)
> At SecureBulkLoadEndpoint.java:then immediately reboxed in
> org.apache.hadoop.hbase.security.access.SecureBulkLoadEndpoint.incrementUgiReference(UserGroupInformation)
> At SecureBulkLoadEndpoint.java:[line 268]
> {code}
> Looking at branch-2 and master I suspect we're doing the same wasteful
> operation but findbugs can't see it through the lambda definition.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-22274) Cell size limit check on append should consider cell's previous size.
[
https://issues.apache.org/jira/browse/HBASE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-22274:
Fix Version/s: (was: 1.5.0)
> Cell size limit check on append should consider cell's previous size.
> -
>
> Key: HBASE-22274
> URL: https://issues.apache.org/jira/browse/HBASE-22274
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.0.0, 1.3.5
>Reporter: Xu Cang
>Assignee: Xu Cang
>Priority: Minor
> Fix For: 3.0.0, 2.2.0, 1.4.10, 2.3.0, 2.1.5
>
> Attachments: HBASE-22274-branch-1.001.patch,
> HBASE-22274-branch-1.002.patch, HBASE-22274-branch-1.003.patch,
> HBASE-22274-branch-1.003.patch, HBASE-22274-branch-1.004.patch,
> HBASE-22274-branch-1.005.patch, HBASE-22274-master.001.patch,
> HBASE-22274-master.002.patch, HBASE-22274-master.002.patch,
> HBASE-22274-master.003.patch
>
>
> Now we have cell size limit check based on this parameter
> *hbase.server.keyvalue.maxsize*
> One case was missing: appending to a cell only take append op's cell size
> into account against this limit check. we should check against the potential
> final cell size after the append.'
> It's easy to reproduce this :
>
> Apply this diff
>
> {code:java}
> diff --git
> a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
>
> b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
> index 5a285ef6ba..8633177ebe 100644 ---
> a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
> +++
> b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
> @@ -6455,7 +6455,7
> - t.append(new Append(ROW).addColumn(FAMILY, QUALIFIER, new byte[10 *
> 1024]));
> + t.append(new Append(ROW).addColumn(FAMILY, QUALIFIER, new byte[2 * 1024]));
> {code}
>
> Fix is to add this check in #reckonDeltas in HRegion class, where we have
> already got the appended cell's size.
> Will throw DoNotRetryIOException if checks is failed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-22070) Checking restoreDir in RestoreSnapshotHelper
[ https://issues.apache.org/jira/browse/HBASE-22070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-22070: Fix Version/s: (was: 1.5.0) > Checking restoreDir in RestoreSnapshotHelper > - > > Key: HBASE-22070 > URL: https://issues.apache.org/jira/browse/HBASE-22070 > Project: HBase > Issue Type: Bug > Components: snapshots >Affects Versions: 2.0.0 >Reporter: Vincent Choi >Assignee: Vincent Choi >Priority: Minor > Fix For: 3.0.0, 2.2.0, 1.4.10, 1.3.4, 2.3.0, 2.0.6, 2.1.5 > > Attachments: > 0001-fixed-a-bug-of-checking-if-restoreDir-is-subDir-of-r.patch, > HBASE-22070-master-001.patch, HBASE-22070.patch > > > The restoreDir shouldn't be a sub directory of rootDir. The code check it > with a prefix check > "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath())". But it > goes error in some reasonable cases. > eg: rootDir = hdfs://user/hbase restoreDir = hdfs://user/hbase_restore. So I > think it's more reasonable to chang the code to > "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath() + "/" )". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-22106) Log cause of the failure when coprocessor specification parsing fails.
[
https://issues.apache.org/jira/browse/HBASE-22106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-22106:
Fix Version/s: (was: 1.5.0)
> Log cause of the failure when coprocessor specification parsing fails.
> --
>
> Key: HBASE-22106
> URL: https://issues.apache.org/jira/browse/HBASE-22106
> Project: HBase
> Issue Type: Bug
> Components: logging
>Affects Versions: 1.4.9
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Minor
> Fix For: 1.4.10, 1.3.4
>
> Attachments: HBASE-22106.branch-1.4.001.patch
>
>
> {code}
> 2019-02-15 22:56:33,008 ERROR [RS_OPEN_REGION-n79:16020-16]
> regionserver.RegionCoprocessorHost: Malformed table coprocessor
> specification: key=coprocessor$2, spec:
> |org.apache.phoenix.coprocessor.UngroupedAggregateRegionObserver|805306366|
> 2019-02-16 00:39:33,651 ERROR [RS_OPEN_REGION-n76:16020-14]
> regionserver.RegionCoprocessorHost: Malformed table coprocessor
> specification: key=coprocessor$1, spec:
> |org.apache.phoenix.coprocessor.ScanRegionObserver|805306366|
> 2019-02-16 00:39:33,651 ERROR [RS_OPEN_REGION-n76:16020-19]
> regionserver.RegionCoprocessorHost: Malformed table coprocessor
> specification: key=coprocessor$1, spec:
> |org.apache.phoenix.coprocessor.ScanRegionObserver|805306366|
> {code}
> I checked the same coprocessor specification(logged in exception) with the
> code and it is parsed successfully. And even after the restart , regionserver
> also didn't complain about it.
> I think we should be logging the cause of the exception while parsing table
> descriptor for the coprocessor for better debugging.
> https://github.com/apache/hbase/blob/branch-1.4/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java#L318
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-22375) Promote AccessChecker to LimitedPrivate(Coprocessor)
[ https://issues.apache.org/jira/browse/HBASE-22375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-22375: Fix Version/s: (was: 1.5.0) > Promote AccessChecker to LimitedPrivate(Coprocessor) > > > Key: HBASE-22375 > URL: https://issues.apache.org/jira/browse/HBASE-22375 > Project: HBase > Issue Type: Task > Components: Coprocessors, security >Reporter: Andrew Kyle Purtell >Assignee: Andrew Kyle Purtell >Priority: Minor > Fix For: 3.0.0, 2.2.0, 1.4.10, 2.3.0, 2.1.5, 1.3.5 > > Attachments: HBASE-22375-branch-1.patch, HBASE-22375.patch > > > We refactored access checking so other components can reuse permissions > checks formerly encapsulated by the AccessController coprocessor. The new API > is AccessChecker. Currently it is marked Private but I propose to promote > this to LimitedPrivate(Coprocessor) with Evolving status. > Unless there is an objection I will make this change. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-22062) Backport HBASE-20917 addendum to branch-1 & branch-1.4
[ https://issues.apache.org/jira/browse/HBASE-22062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-22062: Fix Version/s: (was: 1.5.0) > Backport HBASE-20917 addendum to branch-1 & branch-1.4 > -- > > Key: HBASE-22062 > URL: https://issues.apache.org/jira/browse/HBASE-22062 > Project: HBase > Issue Type: Bug >Reporter: Sakthi >Assignee: Sakthi >Priority: Minor > Fix For: 1.4.10 > > Attachments: HBASE-22062.branch-1.4.001.patch > > > The original patch is present in the 2 branches but the addendum is missing > from the 2 branches. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-21815) Make isTrackingMetrics and getMetrics of ScannerContext public
[ https://issues.apache.org/jira/browse/HBASE-21815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-21815: Fix Version/s: (was: 1.5.0) > Make isTrackingMetrics and getMetrics of ScannerContext public > -- > > Key: HBASE-21815 > URL: https://issues.apache.org/jira/browse/HBASE-21815 > Project: HBase > Issue Type: New Feature >Affects Versions: 1.4.9 >Reporter: Chen Feng >Assignee: Chen Feng >Priority: Minor > Fix For: 3.0.0, 2.2.0, 1.4.10, 2.3.0, 2.1.5, 1.3.5 > > Attachments: HBASE-21815.patch > > > HBASE-5980 provides the ability to return the number of rows scanned. > Leveraging such ability in observers (e.g. PHOENIX-5117) requires some > members of *ScannerContext* being public. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-21645) Perform sanity check and disallow table creation/modification with region replication < 1
[ https://issues.apache.org/jira/browse/HBASE-21645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-21645: Fix Version/s: (was: 1.5.0) > Perform sanity check and disallow table creation/modification with region > replication < 1 > - > > Key: HBASE-21645 > URL: https://issues.apache.org/jira/browse/HBASE-21645 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0, 1.5.0, 2.1.1, 2.1.2 >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Fix For: 3.0.0, 2.2.0, 1.4.10, 2.1.3, 2.0.5 > > Attachments: HBASE-21645.master.001.patch, > HBASE-21645.master.001.patch, HBASE-21645.master.002.patch > > > We should perform sanity check and disallow table creation with region > replication < 1 or modification of an existing table with new region > replication value < 1. -- This message was sent by Atlassian Jira (v8.3.4#803005)
