[jira] [Commented] (HBASE-23313) [hbck2] setRegionState should update Master in-memory state too
[ https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125566#comment-17125566 ] Duo Zhang commented on HBASE-23313: --- For RegionInfo, the regionName and encodedName should be generated according to other fields, so passing it through the proto message is not necessary. I think encoded name is used elsewhere, for example, in RegionSpecifier? As a region name and a encoded region name can both be used as an identifier of a region. For me, I suggest we just remove the field, since it has not been published yet. Thanks. > [hbck2] setRegionState should update Master in-memory state too > --- > > Key: HBASE-23313 > URL: https://issues.apache.org/jira/browse/HBASE-23313 > Project: HBase > Issue Type: Bug > Components: hbck2 >Affects Versions: 2.1.7, 2.2.2 >Reporter: Michael Stack >Assignee: Wellington Chevreuil >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0 > > > setRegionState changes the hbase:meta table info:state column. It does not > alter the Master's in-memory state. This means you have to kill Master and > have another assume Active Master role of a state-change to be noticed. > Better if the setRegionState just went via Master and updated Master and > hbase:meta. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring
Apache-HBase commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-638611816 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 39s | master passed | | +1 :green_heart: | checkstyle | 0m 39s | master passed | | +0 :ok: | refguide | 4m 56s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | spotbugs | 1m 14s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 24s | the patch passed | | -0 :warning: | checkstyle | 0m 14s | hbase-http: The patch generated 9 new + 7 unchanged - 0 fixed = 16 total (was 7) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +0 :ok: | refguide | 4m 48s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | hadoopcheck | 11m 8s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 1m 33s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. | | | | 40m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1814 | | Optional Tests | dupname asflicense refguide xml hadoopcheck spotbugs hbaseanti checkstyle | | uname | Linux 3f1e3ecafe01 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 08c97d3a87 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/artifact/yetus-general-check/output/branch-site/book.html | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-http.txt | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/artifact/yetus-general-check/output/patch-site/book.html | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-http U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring
Apache-HBase commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-638610040 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 8s | master passed | | +1 :green_heart: | compile | 0m 55s | master passed | | +1 :green_heart: | shadedjars | 7m 9s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 26s | hbase-common in master failed. | | -0 :warning: | javadoc | 0m 20s | hbase-http in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 7s | the patch passed | | +1 :green_heart: | compile | 1m 1s | the patch passed | | +1 :green_heart: | javac | 1m 1s | the patch passed | | +1 :green_heart: | shadedjars | 7m 4s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 18s | hbase-common in the patch failed. | | -0 :warning: | javadoc | 0m 18s | hbase-http in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 6s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 0m 57s | hbase-http in the patch passed. | | | | 34m 28s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1814 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 568fd4c3316b 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 08c97d3a87 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/testReport/ | | Max. process+thread count | 390 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-http U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring
Apache-HBase commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-638607456 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 38s | master passed | | +1 :green_heart: | compile | 0m 44s | master passed | | +1 :green_heart: | shadedjars | 5m 33s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 23s | the patch passed | | +1 :green_heart: | compile | 0m 44s | the patch passed | | +1 :green_heart: | javac | 0m 44s | the patch passed | | +1 :green_heart: | shadedjars | 5m 32s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 21s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 0m 40s | hbase-http in the patch passed. | | | | 25m 17s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1814 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 96636e988c5e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 08c97d3a87 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/testReport/ | | Max. process+thread count | 494 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-http U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1802: HBASE-24444 Should shutdown mini cluster after class in TestMetaAssignmentWithStopMaster
Apache-HBase commented on pull request #1802: URL: https://github.com/apache/hbase/pull/1802#issuecomment-638602336 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 41s | master passed | | +1 :green_heart: | compile | 0m 57s | master passed | | +1 :green_heart: | shadedjars | 5m 37s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 36s | the patch passed | | +1 :green_heart: | compile | 0m 56s | the patch passed | | +1 :green_heart: | javac | 0m 56s | the patch passed | | +1 :green_heart: | shadedjars | 5m 34s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 152m 1s | hbase-server in the patch passed. | | | | 176m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1802/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1802 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 8b92af357b1a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 60c9ae58fb | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1802/2/testReport/ | | Max. process+thread count | 3584 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1802/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] mmpataki commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring
mmpataki commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-638600476 @saintstack I have made the changes, could you please review them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1802: HBASE-24444 Should shutdown mini cluster after class in TestMetaAssignmentWithStopMaster
Apache-HBase commented on pull request #1802: URL: https://github.com/apache/hbase/pull/1802#issuecomment-638600634 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 29s | master passed | | +1 :green_heart: | compile | 1m 7s | master passed | | +1 :green_heart: | shadedjars | 6m 0s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 49s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 11s | the patch passed | | +1 :green_heart: | compile | 1m 6s | the patch passed | | +1 :green_heart: | javac | 1m 6s | the patch passed | | +1 :green_heart: | shadedjars | 6m 20s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 50s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 142m 16s | hbase-server in the patch passed. | | | | 169m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1802/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1802 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 851c08efbfb8 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 60c9ae58fb | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1802/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1802/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1802/2/testReport/ | | Max. process+thread count | 3796 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1802/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1722: HBASE-24359 Optionally ignore edits for deleted CFs for replication
Apache-HBase commented on pull request #1722: URL: https://github.com/apache/hbase/pull/1722#issuecomment-638599687 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 24s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 29s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 4s | master passed | | +1 :green_heart: | compile | 1m 28s | master passed | | +1 :green_heart: | shadedjars | 5m 50s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 19s | hbase-common in master failed. | | -0 :warning: | javadoc | 0m 39s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 1s | the patch passed | | +1 :green_heart: | compile | 1m 27s | the patch passed | | +1 :green_heart: | javac | 1m 27s | the patch passed | | +1 :green_heart: | shadedjars | 5m 46s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 17s | hbase-common in the patch failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 28s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 125m 21s | hbase-server in the patch passed. | | | | 155m 57s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1722/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1722 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 44a84849ba6f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 60c9ae58fb | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1722/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1722/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1722/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1722/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1722/5/testReport/ | | Max. process+thread count | 4447 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1722/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-23313) [hbck2] setRegionState should update Master in-memory state too
[ https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125534#comment-17125534 ] Michael Stack edited comment on HBASE-23313 at 6/4/20, 4:36 AM: I made remark in PR on this new field. Thought it interesting it wasn't there already. Didn't realize it not used. You thinking it shouldn't be there; that it should be calculated on deserialization rather than carried in pb? Maybe that is what we do regardless of this addition? was (Author: stack): I made remark in PR on this new field. Thought it interesting it wasn't there already. Didn't realize it not used. You thinking it shouldn't be there; that it should be calculated on deserialization rather than carried in pb? > [hbck2] setRegionState should update Master in-memory state too > --- > > Key: HBASE-23313 > URL: https://issues.apache.org/jira/browse/HBASE-23313 > Project: HBase > Issue Type: Bug > Components: hbck2 >Affects Versions: 2.1.7, 2.2.2 >Reporter: Michael Stack >Assignee: Wellington Chevreuil >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0 > > > setRegionState changes the hbase:meta table info:state column. It does not > alter the Master's in-memory state. This means you have to kill Master and > have another assume Active Master role of a state-change to be noticed. > Better if the setRegionState just went via Master and updated Master and > hbase:meta. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23313) [hbck2] setRegionState should update Master in-memory state too
[ https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125534#comment-17125534 ] Michael Stack commented on HBASE-23313: --- I made remark in PR on this new field. Thought it interesting it wasn't there already. Didn't realize it not used. You thinking it shouldn't be there; that it should be calculated on deserialization rather than carried in pb? > [hbck2] setRegionState should update Master in-memory state too > --- > > Key: HBASE-23313 > URL: https://issues.apache.org/jira/browse/HBASE-23313 > Project: HBase > Issue Type: Bug > Components: hbck2 >Affects Versions: 2.1.7, 2.2.2 >Reporter: Michael Stack >Assignee: Wellington Chevreuil >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0 > > > setRegionState changes the hbase:meta table info:state column. It does not > alter the Master's in-memory state. This means you have to kill Master and > have another assume Active Master role of a state-change to be noticed. > Better if the setRegionState just went via Master and updated Master and > hbase:meta. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24205) Create metric to know the number of reads that happens from memstore
[ https://issues.apache.org/jira/browse/HBASE-24205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125533#comment-17125533 ] ramkrishna.s.vasudevan commented on HBASE-24205: bq.Will make it awkward summing by table Summing per region and per table is bit awkward like we need to group them using a map. Rest of the metrics is just summations. This is ok I believe considering the simplicity of the patch. bq.The name will be long (smile). Its like making 'something already long longer' (smile). It will just add the Store_. But I think we need to do that or we should be giving the details per region per store under an Mbean only. > Create metric to know the number of reads that happens from memstore > > > Key: HBASE-24205 > URL: https://issues.apache.org/jira/browse/HBASE-24205 > Project: HBase > Issue Type: Improvement > Components: metrics >Affects Versions: 3.0.0-alpha-1 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.6 > > Attachments: screenshot.png, screenshot_tablevscf.png > > > A metric to identify number of reads that were served from memstore (atleast > if the gets can be accounted for) then it gives a value addition to know if > among the reads how much was targeted at the most recent data. > Currently the existing metric framework at region level should be enough but > we can also add a metric per store level. That will be more granular. > We can also expose this via HbTop. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24205) Create metric to know the number of reads that happens from memstore
[ https://issues.apache.org/jira/browse/HBASE-24205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125532#comment-17125532 ] ramkrishna.s.vasudevan commented on HBASE-24205: bq.Aggregated at region level means it will consider all CFs/Stores under that region. Say we have 2 store (CFs) under region and one having read pattern of recent data and other not, the aggregated at region level will not be a real insight. Previously the patch had per store per region detail. The only thing was to make use of it, we had to aggregate it at the consumer side. Now that is also aggregated as region vs store - with a value. So if we add all the region vs store metric value should be equal to table vs store metric. (for that specific store). > Create metric to know the number of reads that happens from memstore > > > Key: HBASE-24205 > URL: https://issues.apache.org/jira/browse/HBASE-24205 > Project: HBase > Issue Type: Improvement > Components: metrics >Affects Versions: 3.0.0-alpha-1 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.6 > > Attachments: screenshot.png, screenshot_tablevscf.png > > > A metric to identify number of reads that were served from memstore (atleast > if the gets can be accounted for) then it gives a value addition to know if > among the reads how much was targeted at the most recent data. > Currently the existing metric framework at region level should be enough but > we can also add a metric per store level. That will be more granular. > We can also expose this via HbTop. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange
[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125531#comment-17125531 ] Duo Zhang commented on HBASE-24500: --- Revert from branch-2.3+. Will open a new PR once the question on HBASE-23313 has been resolved. > The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange > --- > > Key: HBASE-24500 > URL: https://issues.apache.org/jira/browse/HBASE-24500 > Project: HBase > Issue Type: Task > Components: Client, read replicas >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.6 > > > In this method, we will copy all the fields, including RegionName and > EncodedRegionName of the RegionInfo, so after we changed some other fields > like start key or stop key or replica id, and then create a new RegionInfo, > the RegionName of the RegionInfo will not be regenerated and cause problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23313) [hbck2] setRegionState should update Master in-memory state too
[ https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125530#comment-17125530 ] Duo Zhang commented on HBASE-23313: --- Could someone explain a bit about the newly added region_encoded_name field in the RegionInfo proto, and also the ProtobufUtil.toProtoRegionInfo method? The method is not used in HBase, and I searched in the repo of hbase-operator-tools through github search, also no reference. The 2.3.0 RC0 is very close, we need to hurry up on the API clean up. Thanks. > [hbck2] setRegionState should update Master in-memory state too > --- > > Key: HBASE-23313 > URL: https://issues.apache.org/jira/browse/HBASE-23313 > Project: HBase > Issue Type: Bug > Components: hbck2 >Affects Versions: 2.1.7, 2.2.2 >Reporter: Michael Stack >Assignee: Wellington Chevreuil >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0 > > > setRegionState changes the hbase:meta table info:state column. It does not > alter the Master's in-memory state. This means you have to kill Master and > have another assume Active Master role of a state-change to be noticed. > Better if the setRegionState just went via Master and updated Master and > hbase:meta. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange
[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125526#comment-17125526 ] Duo Zhang commented on HBASE-24500: --- Oh shit, seems we use the ProtobufUtil.toProtoRegionInfo in HBCK2, let me check. > The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange > --- > > Key: HBASE-24500 > URL: https://issues.apache.org/jira/browse/HBASE-24500 > Project: HBase > Issue Type: Task > Components: Client, read replicas >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.6 > > > In this method, we will copy all the fields, including RegionName and > EncodedRegionName of the RegionInfo, so after we changed some other fields > like start key or stop key or replica id, and then create a new RegionInfo, > the RegionName of the RegionInfo will not be regenerated and cause problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange
[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24500: -- Priority: Blocker (was: Critical) > The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange > --- > > Key: HBASE-24500 > URL: https://issues.apache.org/jira/browse/HBASE-24500 > Project: HBase > Issue Type: Task > Components: Client, read replicas >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Blocker > Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.6 > > > In this method, we will copy all the fields, including RegionName and > EncodedRegionName of the RegionInfo, so after we changed some other fields > like start key or stop key or replica id, and then create a new RegionInfo, > the RegionName of the RegionInfo will not be regenerated and cause problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange
[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125523#comment-17125523 ] Duo Zhang commented on HBASE-24500: --- oh, wait a minute, we do not have encoded name for RegionInfo proto on branch-2.2. Let me check when we introduced this field in proto. > The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange > --- > > Key: HBASE-24500 > URL: https://issues.apache.org/jira/browse/HBASE-24500 > Project: HBase > Issue Type: Task > Components: Client, read replicas >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.6 > > > In this method, we will copy all the fields, including RegionName and > EncodedRegionName of the RegionInfo, so after we changed some other fields > like start key or stop key or replica id, and then create a new RegionInfo, > the RegionName of the RegionInfo will not be regenerated and cause problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24038) Add a metric to show the locality of ssd in table.jsp
[ https://issues.apache.org/jira/browse/HBASE-24038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang updated HBASE-24038: --- Attachment: HBASE-24038-screenshot.png > Add a metric to show the locality of ssd in table.jsp > - > > Key: HBASE-24038 > URL: https://issues.apache.org/jira/browse/HBASE-24038 > Project: HBase > Issue Type: New Feature > Components: metrics >Reporter: Zheng Wang >Assignee: Zheng Wang >Priority: Major > Attachments: HBASE-24038-screenshot.png > > > If a hdfs block has a replica on local hdd and a replica on remote ssd, then > the local one is first priority, so i think it is useful to show the locality > of ssd, especially when use the ONE_SSD storagy policy. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] bsglz commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp
bsglz commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-638587744 Posted a screenshot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region
Apache9 commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-638580779 @saintstack Any other concerns on the patch here? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 merged pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …
Apache9 merged pull request #1840: URL: https://github.com/apache/hbase/pull/1840 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure
Apache9 commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-638573746 > Maybe an alternative would be to improve the message in tasks and explicitly say "noticed an SCP, waiting for processing". Don't know if such verbosity would be useful though? Good. Waiting for your new patch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1722: HBASE-24359 Optionally ignore edits for deleted CFs for replication
Apache-HBase commented on pull request #1722: URL: https://github.com/apache/hbase/pull/1722#issuecomment-638569340 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 27s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 30s | master passed | | +1 :green_heart: | checkstyle | 1m 25s | master passed | | +1 :green_heart: | spotbugs | 2m 36s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 17s | the patch passed | | -0 :warning: | checkstyle | 1m 4s | hbase-server: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 10m 55s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 54s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. | | | | 36m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1722/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1722 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 73e922fbd657 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 60c9ae58fb | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1722/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1722/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1802: HBASE-24444 Should shutdown mini cluster after class in TestMetaAssignmentWithStopMaster
Apache-HBase commented on pull request #1802: URL: https://github.com/apache/hbase/pull/1802#issuecomment-638565490 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 28s | master passed | | +1 :green_heart: | checkstyle | 1m 7s | master passed | | +1 :green_heart: | spotbugs | 1m 58s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 20s | the patch passed | | +1 :green_heart: | checkstyle | 1m 1s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 8s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 10s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 32m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1802/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1802 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 3cff623f3a38 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 60c9ae58fb | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1802/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #1837: HBASE-24496 The tab of Base Stats not actived by default in table.jsp
bsglz commented on pull request #1837: URL: https://github.com/apache/hbase/pull/1837#issuecomment-638557813 > Please either add a test or post a screenshot at the jira. The patch LGTM. Posted two screenshots at the jira. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-24496) The tab of Base Stats not actived by default in table.jsp
[ https://issues.apache.org/jira/browse/HBASE-24496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang updated HBASE-24496: --- Attachment: HBASE-24496-afterpatch.png HBASE-24496-beforepatch.png > The tab of Base Stats not actived by default in table.jsp > - > > Key: HBASE-24496 > URL: https://issues.apache.org/jira/browse/HBASE-24496 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 3.0.0-alpha-1 >Reporter: Zheng Wang >Assignee: Zheng Wang >Priority: Major > Attachments: HBASE-24496-afterpatch.png, HBASE-24496-beforepatch.png > > > This bug was introduced by HBASE-21404, it expect to resovle the active issue > of nav bar, but impact other areas. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] bsglz commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp
bsglz commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-638549983 The mvninstall failture ofmaster seems not related to this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1749: HBASE-24367 ScheduledChore log elapsed timespan in a human-friendly format
Apache-HBase commented on pull request #1749: URL: https://github.com/apache/hbase/pull/1749#issuecomment-638545825 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 34s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 11s | master passed | | +1 :green_heart: | checkstyle | 0m 27s | master passed | | +1 :green_heart: | spotbugs | 0m 50s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 46s | the patch passed | | -0 :warning: | checkstyle | 0m 23s | hbase-common: The patch generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 40s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 0m 50s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 34m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1749 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 458a1b4fe89c 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 60c9ae58fb | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1749: HBASE-24367 ScheduledChore log elapsed timespan in a human-friendly format
Apache-HBase commented on pull request #1749: URL: https://github.com/apache/hbase/pull/1749#issuecomment-638543615 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 13s | master passed | | +1 :green_heart: | compile | 0m 24s | master passed | | +1 :green_heart: | shadedjars | 6m 14s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 47s | the patch passed | | +1 :green_heart: | compile | 0m 21s | the patch passed | | +1 :green_heart: | javac | 0m 21s | the patch passed | | +1 :green_heart: | shadedjars | 6m 3s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 20s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 45s | hbase-common in the patch passed. | | | | 28m 13s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1749 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 475dd7ef5dd9 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 60c9ae58fb | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/2/testReport/ | | Max. process+thread count | 222 (vs. ulimit of 12500) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1749: HBASE-24367 ScheduledChore log elapsed timespan in a human-friendly format
Apache-HBase commented on pull request #1749: URL: https://github.com/apache/hbase/pull/1749#issuecomment-638543364 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 44s | master passed | | +1 :green_heart: | compile | 0m 24s | master passed | | +1 :green_heart: | shadedjars | 6m 25s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 18s | hbase-common in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 29s | the patch passed | | +1 :green_heart: | compile | 0m 25s | the patch passed | | +1 :green_heart: | javac | 0m 25s | the patch passed | | +1 :green_heart: | shadedjars | 6m 23s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 15s | hbase-common in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 45s | hbase-common in the patch passed. | | | | 27m 30s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1749 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux eb3341f8bcc4 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 60c9ae58fb | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/2/testReport/ | | Max. process+thread count | 200 (vs. ulimit of 12500) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1749/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24412) Canary support check only one column family per RegionTask
[
https://issues.apache.org/jira/browse/HBASE-24412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125445#comment-17125445
]
Hudson commented on HBASE-24412:
Results for branch branch-2
[build #2689 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Canary support check only one column family per RegionTask
> --
>
> Key: HBASE-24412
> URL: https://issues.apache.org/jira/browse/HBASE-24412
> Project: HBase
> Issue Type: Improvement
> Components: canary
>Reporter: niuyulin
>Assignee: niuyulin
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-21406) "status 'replication'" should not show SINK if the cluster does not act as sink
[
https://issues.apache.org/jira/browse/HBASE-21406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125447#comment-17125447
]
Hudson commented on HBASE-21406:
Results for branch branch-2
[build #2689 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> "status 'replication'" should not show SINK if the cluster does not act as
> sink
> ---
>
> Key: HBASE-21406
> URL: https://issues.apache.org/jira/browse/HBASE-21406
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0-alpha-1, 2.3.0, 2.4.0, 2.2.5
>Reporter: Daisuke Kobayashi
>Assignee: Wellington Chevreuil
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.4.0
>
> Attachments: HBASE-21406-branch-1.001.patch,
> HBASE-21406-master.001.patch, HBASE-21406-master.002.patch, Screen Shot
> 2018-10-31 at 18.12.54.png
>
>
> When replicating in 1 way, from source to target, {{status 'replication'}} on
> source always dumps SINK with meaningless metrics. It only makes sense when
> running the command on target cluster.
> {{status 'replication'}} on source, for example. {{AgeOfLastAppliedOp}} is
> always zero and {{TimeStampsOfLastAppliedOp}} does not get updated from the
> time the RS started since it's not acting as sink.
> {noformat}
> source-1.com
>SOURCE: PeerID=1, AgeOfLastShippedOp=0, SizeOfLogQueue=0,
> TimeStampsOfLastShippedOp=Mon Oct 29 23:44:14 PDT 2018, Replication Lag=0
>SINK : AgeOfLastAppliedOp=0, TimeStampsOfLastAppliedOp=Thu Oct 25
> 23:56:53 PDT 2018
> {noformat}
> {{status 'replication'}} on target works as expected. SOURCE is empty as it's
> not acting as source:
> {noformat}
> target-1.com
>SOURCE:
>SINK : AgeOfLastAppliedOp=70, TimeStampsOfLastAppliedOp=Mon Oct 29
> 23:44:08 PDT 2018
> {noformat}
> This is because {{getReplicationLoadSink}}, called in {{admin.rb}}, always
> returns a value (not null).
> 1.X
> https://github.com/apache/hbase/blob/rel/1.4.0/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java#L194-L204
> 2.X
> https://github.com/apache/hbase/blob/rel/2.0.0/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java#L392-L399
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24309) Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly
[
https://issues.apache.org/jira/browse/HBASE-24309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125448#comment-17125448
]
Hudson commented on HBASE-24309:
Results for branch branch-2
[build #2689 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Avoid introducing log4j and slf4j-log4j dependencies for modules other than
> hbase-assembly
> --
>
> Key: HBASE-24309
> URL: https://issues.apache.org/jira/browse/HBASE-24309
> Project: HBase
> Issue Type: Sub-task
> Components: logging, pom
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> In general, a library should not force the down stream users to use a
> specific logging framework, and this is why there is a slf4j library.
> For HBase, since we also publish the testing-util module which almost depends
> on all other sub modules, we should not introduce logging dependencies other
> than slf4j-api in these modules. We should only add log4j dependencies in
> hbase-assembly and ship it with our binary distribution.
> This is also important for switching to log4j2.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[
https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125446#comment-17125446
]
Hudson commented on HBASE-24492:
Results for branch branch-2
[build #2689 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> ProtobufLogReader.readNext does not need looping
>
>
> Key: HBASE-24492
> URL: https://issues.apache.org/jira/browse/HBASE-24492
> Project: HBase
> Issue Type: Task
> Components: Replication, wal
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.4.0
>
>
> ProtobufLogReader.readNext is using infinite while loop for the whole method,
> however it returns value or throws errors in single execution. while(true)
> was part of initial code and with better improvements in the method, this
> loop has not been removed yet.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-24501) Backport to branch-1 HBASE-15785 Unnecessary lock in ByteBufferArray
[ https://issues.apache.org/jira/browse/HBASE-24501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-24501. Fix Version/s: 1.7.0 Resolution: Fixed Pushed to branch-1. Thanks [~tangtianhang] for contributing. > Backport to branch-1 HBASE-15785 Unnecessary lock in ByteBufferArray > > > Key: HBASE-24501 > URL: https://issues.apache.org/jira/browse/HBASE-24501 > Project: HBase > Issue Type: Improvement > Components: regionserver, Scanners >Reporter: tianhang tang >Assignee: tianhang tang >Priority: Minor > Fix For: 1.7.0 > > > Backport [HBASE-15785|https://issues.apache.org/jira/browse/HBASE-15785] to > branch-1 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] infraio merged pull request #1842: HBASE-24501 Backport to branch-1 HBASE-15785 Unnecessary lock in Byte…
infraio merged pull request #1842: URL: https://github.com/apache/hbase/pull/1842 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] timoha commented on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure
timoha commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-638533674 That's a good point @Apache9, I guess it would add sort of "continuity" to show that the task is still ongoing during master failover in case the procedure hasn't actually finished. However, I think there's an unwanted side effect here in case the procedure has actually completed by previous master (was marked done) and SCP not being actually scheduled for a while. As an operator, if I were to notice that there's SCP, I would freak out and try to see why my regionserver failed and then try to look at the logs (and in this case nothing is logged about it new master), and then try to look at procedure list (also without finding anything there). So, I guess in that case it would be more expected to show SCP in task when it's is actually being executed rather than "pending execution"? Maybe an alternative would be to improve the message in tasks and explicitly say "noticed an SCP, waiting for processing". Don't know if such verbosity would be useful though? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 edited a comment on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure
Apache9 edited a comment on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-638530854 And I got the reason why there is a currentRunningState field. We will call setNextState after scheduling sub procedures, so when updating progress, if we just use the state machine state by calling getCurrentState, we will set the message in the TaskMonitor to the next state, which is a bit confusing to users. So I think we could add another flag to updateProgress, to indicate whether the procedure is complete, and when calling after excuting the SERVER_CRASH_FINISH, we set this flag to true to let the method complete the procedure in the TaskMonitor. And also, in deserialization method, we could check the 'ProcedureState'(not the state of the state machine), if it is SUCCESS or FAILED, then we just skip calling updateProgress, so it will not have stale SCPs. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure
Apache9 commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-638530854 And I got the reason why there is a currentRunningState field. We will call setNextState after scheduling sub procedures, so when updating progress, if we just use the recorded current state, we will set the message in the TaskMonitor to the next state, which is a bit confusing to users. So I think we could add another flag to updateProgress, to indicate whether the procedure is complete, and when calling after excuting the SERVER_CRASH_FINISH, we set this flag to true to let the method complete the procedure in the TaskMonitor. And also, in deserialization method, we could check the 'ProcedureState'(not the state of the state machine), if it is SUCCESS or FAILED, then we just skip calling updateProgress, so it will not have stale SCPs. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure
Apache9 commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-638527858 > Thanks for suggestion @Apache9, but I don't think that's going to work for the case of state being `SERVER_CRASH_FINISH`. With such code change, `executeFromState` will end up calling `updateProgress(true)` at the beginning of the function marking the task as done. Whereas it should be actually marking the task as done when switch `case SERVER_CRASH_FINISH` is called. > > Also, could you please explain a rationale about adding a task during procedure deserialization? If procedure has finished during run of previous, what is the value in displaying it in tasks as "completed" when a new master comes after replaying the logs? In other words, should a simple fact of deserialization have such a side effect on tasks or should actual procedure execution drive the tasks updates instead? I think unless you call update progress, otherwise the procedure will not show up in the TaskMonitor? The updateProgress call in deserialization is something like an initialization. If there are so many SCPs, maybe it is possible that one of the SCPs can not be scheduled for a long time, then if you do not all updateProgress in deserialization, you can not see its current status for a long tim, until it gets scheduled. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-21905) TestFIFOCompactionPolicy is flaky
[ https://issues.apache.org/jira/browse/HBASE-21905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-21905: - Fix Version/s: 2.4.0 3.0.0-alpha-1 Resolution: Fixed Status: Resolved (was: Patch Available) Committed to branch-1/2/master. Not committed to branch-2.3 since we are very close to cutting an RC. Didn't want to introduce new code at this point. > TestFIFOCompactionPolicy is flaky > - > > Key: HBASE-21905 > URL: https://issues.apache.org/jira/browse/HBASE-21905 > Project: HBase > Issue Type: Test > Components: test >Affects Versions: 3.0.0-alpha-1, 1.5.0, 2.3.0 >Reporter: Andrew Kyle Purtell >Assignee: Bharath Vissapragada >Priority: Major > Labels: branch-1 > Fix For: 3.0.0-alpha-1, 1.7.0, 2.4.0 > > Attachments: > org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy-output.txt, > testFIFOCompactionPolicyExpiredEmptyHFiles-failure-log.txt > > > java.lang.IllegalArgumentException , overlaps with > For example: > [ERROR] > testFIFOCompactionPolicyExpiredEmptyHFiles(org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy) > Time elapsed: 3.321 s <<< ERROR! > java.io.IOException: > java.io.IOException: > [hdfs://localhost:41525/user/apurtell/test-data/734de07d-1f22-46a9-a1f5-96ad4578450b/data/default/testFIFOCompactionPolicyExpiredEmptyHFiles/c4f673438e09d7ef5a9b79b363639cde/f/c0c5836c1f714f78847cf00326586b69, > > hdfs://localhost:41525/user/apurtell/test-data/734de07d-1f22-46a9-a1f5-96ad4578450b/data/default/testFIFOCompactionPolicyExpiredEmptyHFiles/c4f673438e09d7ef5a9b79b363639cde/f/c65648691f614b2d8dd4b586c5923bfe] > overlaps with > [hdfs://localhost:41525/user/apurtell/test-data/734de07d-1f22-46a9-a1f5-96ad4578450b/data/default/testFIFOCompactionPolicyExpiredEmptyHFiles/c4f673438e09d7ef5a9b79b363639cde/f/c0c5836c1f714f78847cf00326586b69] > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2438) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:297) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > Caused by: java.lang.IllegalArgumentException: > [hdfs://localhost:41525/user/apurtell/test-data/734de07d-1f22-46a9-a1f5-96ad4578450b/data/default/testFIFOCompactionPolicyExpiredEmptyHFiles/c4f673438e09d7ef5a9b79b363639cde/f/c0c5836c1f714f78847cf00326586b69, > > hdfs://localhost:41525/user/apurtell/test-data/734de07d-1f22-46a9-a1f5-96ad4578450b/data/default/testFIFOCompactionPolicyExpiredEmptyHFiles/c4f673438e09d7ef5a9b79b363639cde/f/c65648691f614b2d8dd4b586c5923bfe] > overlaps with > [hdfs://localhost:41525/user/apurtell/test-data/734de07d-1f22-46a9-a1f5-96ad4578450b/data/default/testFIFOCompactionPolicyExpiredEmptyHFiles/c4f673438e09d7ef5a9b79b363639cde/f/c0c5836c1f714f78847cf00326586b69] > at > com.google.common.base.Preconditions.checkArgument(Preconditions.java:119) > at > org.apache.hadoop.hbase.regionserver.HStore.addToCompactingFiles(HStore.java:1824) > at > org.apache.hadoop.hbase.regionserver.HStore.requestCompaction(HStore.java:1798) > at > org.apache.hadoop.hbase.regionserver.CompactSplitThread.selectCompaction(CompactSplitThread.java:415) > at > org.apache.hadoop.hbase.regionserver.CompactSplitThread.requestCompactionInternal(CompactSplitThread.java:388) > at > org.apache.hadoop.hbase.regionserver.CompactSplitThread.requestCompactionInternal(CompactSplitThread.java:317) > at > org.apache.hadoop.hbase.regionserver.CompactSplitThread.requestCompaction(CompactSplitThread.java:306) > at > org.apache.hadoop.hbase.regionserver.RSRpcServices.compactRegion(RSRpcServices.java:1513) > at > org.apache.hadoop.hbase.protobuf.generated.AdminProtos$AdminService$2.callBlockingMethod(AdminProtos.java:23649) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2380) > ... 3 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1833: Backport "HBASE-24418 Consolidate Normalizer implementations" to branch-2
Apache-HBase commented on pull request #1833: URL: https://github.com/apache/hbase/pull/1833#issuecomment-638522363 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 30s | branch-2 passed | | +1 :green_heart: | compile | 2m 8s | branch-2 passed | | +1 :green_heart: | shadedjars | 5m 7s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 3s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 9s | the patch passed | | +1 :green_heart: | compile | 2m 11s | the patch passed | | +1 :green_heart: | javac | 2m 11s | the patch passed | | +1 :green_heart: | shadedjars | 5m 2s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 35s | hbase-server generated 25 new + 1 unchanged - 0 fixed = 26 total (was 1) | | -0 :warning: | javadoc | 2m 5s | root generated 25 new + 16 unchanged - 0 fixed = 41 total (was 16) | ||| _ Other Tests _ | | -1 :x: | unit | 290m 14s | root in the patch failed. | | | | 321m 25s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1833 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 1aab68483977 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 8c9c670aaa | | Default Java | 1.8.0_232 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-root.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/testReport/ | | Max. process+thread count | 7494 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
ndimiduk commented on a change in pull request #1844: URL: https://github.com/apache/hbase/pull/1844#discussion_r434920380 ## File path: src/main/asciidoc/_chapters/configuration.adoc ## @@ -97,55 +97,76 @@ This section lists required services and some required system configuration. [[java]] .Java -The following table summarizes the recommendation of the HBase community wrt deploying on various -Java versions. A icon:check-circle[role="green"] symbol is meant to indicate a base level of +The following table summarizes the recommendations of the HBase community with respect to deploying +on various Java versions. The icon:check-circle[role="green"] symbol indicates a base level of testing and willingness to help diagnose and address issues you might run into. Similarly, an entry -of icon:exclamation-circle[role="yellow"] or icon:times-circle[role="red"] generally means that -should you run into an issue the community is likely to ask you to change the Java environment -before proceeding to help. In some cases, specific guidance on limitations (e.g. whether compiling -/ unit tests work, specific operational issues, etc) will also be noted. +of icon:exclamation-circle[role="yellow"] means that, should you run into an issue, the community +is likely to ask you to change the Java environment rather than proceeding to help on that Java +version. This applies categorically to Non-LTS releases (see below). The +icon:times-circle[role="red"] means that support has been dropped for this version or has been +attempted and is known to not work. For combinations of newer JDK with older HBase releases, it's +likely that there are known compatibility issues that cannot be addressed under our compatibility +guarantees, making that combination impossible. In some cases, specific guidance on limitations +(e.g. whether compiling / unit tests work, specific operational issues, etc) will also be noted. + +.Long-Term Support JDKs are Recommended +[WARNING] + +HBase recommends downstream users rely on JDK releases that are marked as Long-Term Supported +(LTS), either from the OpenJDK project or vendors. At the time of this writing, the following JDK +releases are NOT LTS releases and are NOT supported by the Apache HBase community: JDK9, JDK10, Review comment: Yeah you're right. "support" is not a great term, the the world of enterprise software. "You're unlikely to find receptive community engagement" is a bit long-winded, but honest. The earlier phrasing wasn't mine, but I'll try again with it as a model. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
ndimiduk commented on a change in pull request #1844: URL: https://github.com/apache/hbase/pull/1844#discussion_r434919844 ## File path: src/main/asciidoc/_chapters/configuration.adoc ## @@ -97,55 +97,76 @@ This section lists required services and some required system configuration. [[java]] .Java -The following table summarizes the recommendation of the HBase community wrt deploying on various -Java versions. A icon:check-circle[role="green"] symbol is meant to indicate a base level of +The following table summarizes the recommendations of the HBase community with respect to deploying +on various Java versions. The icon:check-circle[role="green"] symbol indicates a base level of testing and willingness to help diagnose and address issues you might run into. Similarly, an entry -of icon:exclamation-circle[role="yellow"] or icon:times-circle[role="red"] generally means that -should you run into an issue the community is likely to ask you to change the Java environment -before proceeding to help. In some cases, specific guidance on limitations (e.g. whether compiling -/ unit tests work, specific operational issues, etc) will also be noted. +of icon:exclamation-circle[role="yellow"] means that, should you run into an issue, the community +is likely to ask you to change the Java environment rather than proceeding to help on that Java +version. This applies categorically to Non-LTS releases (see below). The +icon:times-circle[role="red"] means that support has been dropped for this version or has been +attempted and is known to not work. For combinations of newer JDK with older HBase releases, it's +likely that there are known compatibility issues that cannot be addressed under our compatibility +guarantees, making that combination impossible. In some cases, specific guidance on limitations +(e.g. whether compiling / unit tests work, specific operational issues, etc) will also be noted. + +.Long-Term Support JDKs are Recommended +[WARNING] + +HBase recommends downstream users rely on JDK releases that are marked as Long-Term Supported +(LTS), either from the OpenJDK project or vendors. At the time of this writing, the following JDK +releases are NOT LTS releases and are NOT supported by the Apache HBase community: JDK9, JDK10, +JDK12, JDK13, and JDK14. Community discussion around this decision is recorded on +link:https://issues.apache.org/jira/browse/HBASE-20264[HBASE-20264]. + -.Long Term Support JDKs are recommended +.HotSpot vs. OpenJ9 [TIP] -HBase recommends downstream users rely on JDK releases that are marked as Long Term Supported (LTS) -either from the OpenJDK project or vendors. As of March 2018 that means Java 8 is the only -applicable version and that the next likely version to see testing will be Java 11 near Q3 2018. +At this time, all testing performed by the Apache HBase project runs on the HotSpot variant of the +JVM. When selecting your JDK distribution, please take this into consideration. .Java support by release line -[cols="6*^.^", options="header"] +[cols="4*^.^", options="header"] |=== -|HBase Version -|JDK 7 -|JDK 8 -|JDK 9 (Non-LTS) -|JDK 10 (Non-LTS) -|JDK 11 - -|2.1+ +|Java Version +|HBase 1.3+ +|HBase 2.1+ +|HBase 2.3+ + +|JDK6 +|icon:times-circle[role="red"] |icon:times-circle[role="red"] +|icon:times-circle[role="red"] + +|JDK7 +|icon:check-circle[role="green"] +|icon:times-circle[role="red"] +|icon:times-circle[role="red"] + +|JDK8 |icon:check-circle[role="green"] Review comment: We're talking about runtime support here. You're right though, the language is not clear. Let me take another swing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-24418) Consolidate Normalizer implementations
[
https://issues.apache.org/jira/browse/HBASE-24418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-24418:
-
Release Note:
This change extends the Normalizer with a handful of new configurations. The
configuration points supported are:
* `hbase.normalizer.split.enabled` Whether to split a region as part of
normalization. Default: `true`.
* `hbase.normalizer.merge.enabled` Whether to merge a region as part of
normalization. Default `true`.
* `hbase.normalizer.min.region.count` The minimum number of regions in a table
to consider it for merge normalization. Default: 3.
* `hbase.normalizer.merge.min_region_age.days` The minimum age for a region to
be considered for a merge, in days. Default: 3.
* `hbase.normalizer.merge.min_region_size.mb` The minimum size for a region to
be considered for a merge, in whole MBs. Default: 1.
> Consolidate Normalizer implementations
> --
>
> Key: HBASE-24418
> URL: https://issues.apache.org/jira/browse/HBASE-24418
> Project: HBase
> Issue Type: Task
> Components: master, Normalizer
>Affects Versions: 3.0.0-alpha-1, 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> After HBASE-22285, we have two implementations of {{RegionNormalizer}}, that
> have different feature sets and different configurations. I think these can
> be combined into a single implementation, with clear, decoupled configuration
> parameters. At least on branch-2.3, there's too many subsequent changes for
> HBASE-22285 to revert cleanly, so I'll use this ticket to consolidate the
> implementations.
> If you have issues with the current normalizer, speak up here and we can
> include them, or add them as sub-tasks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] clarax commented on pull request #1843: HBASE-24268 REST and Thrift server do not handle the "doAs" parameter case insensitively
clarax commented on pull request #1843: URL: https://github.com/apache/hbase/pull/1843#issuecomment-638518587 It is great that you are tackling this. Could you please add a test in the PR or a screenshot at the lira for validation? Otherwise LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-24418) Consolidate Normalizer implementations
[
https://issues.apache.org/jira/browse/HBASE-24418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk resolved HBASE-24418.
--
Resolution: Fixed
> Consolidate Normalizer implementations
> --
>
> Key: HBASE-24418
> URL: https://issues.apache.org/jira/browse/HBASE-24418
> Project: HBase
> Issue Type: Task
> Components: master, Normalizer
>Affects Versions: 3.0.0-alpha-1, 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> After HBASE-22285, we have two implementations of {{RegionNormalizer}}, that
> have different feature sets and different configurations. I think these can
> be combined into a single implementation, with clear, decoupled configuration
> parameters. At least on branch-2.3, there's too many subsequent changes for
> HBASE-22285 to revert cleanly, so I'll use this ticket to consolidate the
> implementations.
> If you have issues with the current normalizer, speak up here and we can
> include them, or add them as sub-tasks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24418) Consolidate Normalizer implementations
[
https://issues.apache.org/jira/browse/HBASE-24418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-24418:
-
Fix Version/s: 3.0.0-alpha-1
> Consolidate Normalizer implementations
> --
>
> Key: HBASE-24418
> URL: https://issues.apache.org/jira/browse/HBASE-24418
> Project: HBase
> Issue Type: Task
> Components: master, Normalizer
>Affects Versions: 3.0.0-alpha-1, 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Blocker
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> After HBASE-22285, we have two implementations of {{RegionNormalizer}}, that
> have different feature sets and different configurations. I think these can
> be combined into a single implementation, with clear, decoupled configuration
> parameters. At least on branch-2.3, there's too many subsequent changes for
> HBASE-22285 to revert cleanly, so I'll use this ticket to consolidate the
> implementations.
> If you have issues with the current normalizer, speak up here and we can
> include them, or add them as sub-tasks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24418) Consolidate Normalizer implementations
[
https://issues.apache.org/jira/browse/HBASE-24418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-24418:
-
Priority: Major (was: Blocker)
> Consolidate Normalizer implementations
> --
>
> Key: HBASE-24418
> URL: https://issues.apache.org/jira/browse/HBASE-24418
> Project: HBase
> Issue Type: Task
> Components: master, Normalizer
>Affects Versions: 3.0.0-alpha-1, 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> After HBASE-22285, we have two implementations of {{RegionNormalizer}}, that
> have different feature sets and different configurations. I think these can
> be combined into a single implementation, with clear, decoupled configuration
> parameters. At least on branch-2.3, there's too many subsequent changes for
> HBASE-22285 to revert cleanly, so I'll use this ticket to consolidate the
> implementations.
> If you have issues with the current normalizer, speak up here and we can
> include them, or add them as sub-tasks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] ndimiduk merged pull request #1834: Backport "HBASE-24418 Consolidate Normalizer implementations" to branch-2.3
ndimiduk merged pull request #1834: URL: https://github.com/apache/hbase/pull/1834 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk merged pull request #1833: Backport "HBASE-24418 Consolidate Normalizer implementations" to branch-2
ndimiduk merged pull request #1833: URL: https://github.com/apache/hbase/pull/1833 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] joshelser commented on pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME
joshelser commented on pull request #1847: URL: https://github.com/apache/hbase/pull/1847#issuecomment-638516756 Thanks Nick! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-24280) Hadoop2 and Hadoop3 profiles being activated simultaneously causing test failures
[
https://issues.apache.org/jira/browse/HBASE-24280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk resolved HBASE-24280.
--
Resolution: Fixed
Pushed addendum to branch-2 and branch-2.3.
> Hadoop2 and Hadoop3 profiles being activated simultaneously causing test
> failures
> -
>
> Key: HBASE-24280
> URL: https://issues.apache.org/jira/browse/HBASE-24280
> Project: HBase
> Issue Type: Bug
>Reporter: Josh Elser
>Assignee: Istvan Toth
>Priority: Major
> Fix For: 2.3.0
>
> Attachments: HBASE-24280.master.001.patch,
> TEST-org.apache.hadoop.hbase.rest.TestSecureRESTServer.xml
>
>
> [~ndimiduk] pointed out that, after this change went in, TestSecureRESTServer
> started failing with Hadoop3 on branch-2.3
> https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/56/
> Of course, I ran this with 1.8.0_241 and Maven 3.6.33 and it passed :) {{mvn
> clean package -Dtest=TestSecureRESTServer -Dhadoop.profile=3.0
> -DfailIfNoTests=false}}
> FYI [~stoty] in case you can repro a failure and want to dig in. Feel free to
> re-assign.
> It looks like we didn't have a nightly run of branch-2.2 due to docker
> container build issues. Will be interesting to see if it fails there. It did
> not fail the master nightly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] z-york commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…
z-york commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-638516415 Looks good to me. Thanks for the changes. Let's wait to see if @ndimiduk has any further comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk merged pull request #1848: Backport "HBASE-24309 ADDENDUM remove redundant dependency" to branch-2.3
ndimiduk merged pull request #1848: URL: https://github.com/apache/hbase/pull/1848 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] clarax commented on pull request #1819: HBASE-24478 The regionInfo parameter for MasterProcedureScheduler#wai…
clarax commented on pull request #1819: URL: https://github.com/apache/hbase/pull/1819#issuecomment-638516537 You are right since regionInfo is an HBase entity. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk opened a new pull request #1849: Revert inadvertent merge commit and re-apply HBASE-24280 ADDENDUM to branch-2
ndimiduk opened a new pull request #1849: URL: https://github.com/apache/hbase/pull/1849 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk merged pull request #1849: Revert inadvertent merge commit and re-apply HBASE-24280 ADDENDUM to branch-2
ndimiduk merged pull request #1849: URL: https://github.com/apache/hbase/pull/1849 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] z-york commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…
z-york commented on a change in pull request #1791:
URL: https://github.com/apache/hbase/pull/1791#discussion_r434912178
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java
##
@@ -383,25 +385,38 @@ public static SnapshotDescription
readSnapshotInfo(FileSystem fs, Path snapshotD
}
/**
- * Move the finished snapshot to its final, publicly visible directory -
this marks the snapshot
- * as 'complete'.
- * @param snapshot description of the snapshot being tabken
- * @param rootdir root directory of the hbase installation
- * @param workingDir directory where the in progress snapshot was built
- * @param fs {@link FileSystem} where the snapshot was built
- * @throws org.apache.hadoop.hbase.snapshot.SnapshotCreationException if the
- * snapshot could not be moved
+ * Commits the snapshot process by moving the working snapshot
+ * to the finalized filepath
+ *
+ * @param snapshotDir The file path of the completed snapshots
+ * @param workingDir The file path of the in progress snapshots
+ * @param fs The file system of the completed snapshots
+ * @param workingDirFs The file system of the in progress snapshots
+ * @param conf Configuration
+ *
+ * @throws SnapshotCreationException if the snapshot could not be moved
* @throws IOException the filesystem could not be reached
*/
- public static void completeSnapshot(SnapshotDescription snapshot, Path
rootdir, Path workingDir,
- FileSystem fs) throws SnapshotCreationException, IOException {
-Path finishedDir = getCompletedSnapshotDir(snapshot, rootdir);
-LOG.debug("Snapshot is done, just moving the snapshot from " + workingDir
+ " to "
-+ finishedDir);
-if (!fs.rename(workingDir, finishedDir)) {
- throw new SnapshotCreationException(
- "Failed to move working directory(" + workingDir + ") to completed
directory("
- + finishedDir + ").", ProtobufUtil.createSnapshotDesc(snapshot));
+ public static void completeSnapshot(Path snapshotDir, Path workingDir,
FileSystem fs,
Review comment:
I think this is okay for now... maybe in the future we can pull these
non-snapshotDescription utility methods to a new file.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] ndimiduk opened a new pull request #1848: Backport "HBASE-24309 ADDENDUM remove redundant dependency" to branch-2.3
ndimiduk opened a new pull request #1848: URL: https://github.com/apache/hbase/pull/1848 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME
ndimiduk commented on pull request #1847: URL: https://github.com/apache/hbase/pull/1847#issuecomment-638513526 wtf GitHub made a merge commit? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bharathv merged pull request #1829: HBASE-21905: [FIFOCompaction] Don't compact already inflight store files
bharathv merged pull request #1829: URL: https://github.com/apache/hbase/pull/1829 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk merged pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME
ndimiduk merged pull request #1847: URL: https://github.com/apache/hbase/pull/1847 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME
ndimiduk commented on pull request #1847: URL: https://github.com/apache/hbase/pull/1847#issuecomment-638510142 JDK11 Hadoop3 passed over on my PR. Merging this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1833: Backport "HBASE-24418 Consolidate Normalizer implementations" to branch-2
Apache-HBase commented on pull request #1833: URL: https://github.com/apache/hbase/pull/1833#issuecomment-638504153 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 37s | branch-2 passed | | +1 :green_heart: | compile | 3m 0s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 28s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 17s | root in branch-2 failed. | | -0 :warning: | javadoc | 0m 16s | hbase-common in branch-2 failed. | | -0 :warning: | javadoc | 0m 39s | hbase-server in branch-2 failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 16s | the patch passed | | +1 :green_heart: | compile | 2m 56s | the patch passed | | +1 :green_heart: | javac | 2m 56s | the patch passed | | +1 :green_heart: | shadedjars | 6m 27s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 15s | hbase-common in the patch failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 14s | root in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 224m 31s | root in the patch passed. | | | | 258m 48s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1833 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ee8e6fe70eeb 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 8c9c670aaa | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/testReport/ | | Max. process+thread count | 6084 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…
Apache-HBase commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-638501372 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 18s | master passed | | +1 :green_heart: | compile | 1m 19s | master passed | | +1 :green_heart: | shadedjars | 6m 56s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 47s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 11s | the patch passed | | +1 :green_heart: | compile | 1m 19s | the patch passed | | +1 :green_heart: | javac | 1m 19s | the patch passed | | +1 :green_heart: | shadedjars | 7m 0s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 47s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 207m 13s | hbase-server in the patch passed. | | | | 239m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1791/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1791 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux afee4a7af76b 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0078268203 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1791/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1791/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1791/4/testReport/ | | Max. process+thread count | 3037 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1791/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder
Apache-HBase commented on pull request #1818: URL: https://github.com/apache/hbase/pull/1818#issuecomment-638497943 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 41s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 28s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 9s | master passed | | +1 :green_heart: | compile | 1m 28s | master passed | | +1 :green_heart: | shadedjars | 6m 13s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 0s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 3s | the patch passed | | +1 :green_heart: | compile | 1m 27s | the patch passed | | +1 :green_heart: | javac | 1m 27s | the patch passed | | +1 :green_heart: | shadedjars | 6m 11s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 58s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 10s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 227m 44s | hbase-server in the patch passed. | | | | 258m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1818/9/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1818 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 42ff66bc253d 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0078268203 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1818/9/testReport/ | | Max. process+thread count | 2798 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1818/9/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-23963) Split TestFromClientSide; it takes too long to complete timing out
[
https://issues.apache.org/jira/browse/HBASE-23963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125365#comment-17125365
]
Hudson commented on HBASE-23963:
Results for branch branch-2.2
[build #884 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/884/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/884//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/884//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/884//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Split TestFromClientSide; it takes too long to complete timing out
> --
>
> Key: HBASE-23963
> URL: https://issues.apache.org/jira/browse/HBASE-23963
> Project: HBase
> Issue Type: Test
> Components: test
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
> Attachments: Screen Shot 2020-03-11 at 7.43.27 AM.png
>
>
> The TestFromClientSide test was parameterized recently so we'd run full sweet
> with one of three registries. Test now often takes longer than max 13 minutes
> allowed. Split the test.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24412) Canary support check only one column family per RegionTask
[
https://issues.apache.org/jira/browse/HBASE-24412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125363#comment-17125363
]
Hudson commented on HBASE-24412:
Results for branch branch-2.2
[build #884 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/884/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/884//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/884//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/884//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Canary support check only one column family per RegionTask
> --
>
> Key: HBASE-24412
> URL: https://issues.apache.org/jira/browse/HBASE-24412
> Project: HBase
> Issue Type: Improvement
> Components: canary
>Reporter: niuyulin
>Assignee: niuyulin
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24467) Backport HBASE-23963: Split TestFromClientSide; it takes too long to complete timing out
[
https://issues.apache.org/jira/browse/HBASE-24467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125364#comment-17125364
]
Hudson commented on HBASE-24467:
Results for branch branch-2.2
[build #884 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/884/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/884//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/884//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/884//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Backport HBASE-23963: Split TestFromClientSide; it takes too long to complete
> timing out
>
>
> Key: HBASE-24467
> URL: https://issues.apache.org/jira/browse/HBASE-24467
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.2.5
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 2.2.6
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder
Apache-HBase commented on pull request #1818: URL: https://github.com/apache/hbase/pull/1818#issuecomment-638494590 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 40s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 2s | master passed | | +1 :green_heart: | compile | 1m 48s | master passed | | +1 :green_heart: | shadedjars | 6m 35s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 31s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 45s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 44s | the patch passed | | +1 :green_heart: | compile | 1m 45s | the patch passed | | +1 :green_heart: | javac | 1m 45s | the patch passed | | +1 :green_heart: | shadedjars | 6m 39s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 32s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 52s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 36s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 214m 3s | hbase-server in the patch passed. | | | | 249m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1818/9/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1818 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 147dc92b4149 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0078268203 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1818/9/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1818/9/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1818/9/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1818/9/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1818/9/testReport/ | | Max. process+thread count | 3087 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1818/9/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1834: Backport "HBASE-24418 Consolidate Normalizer implementations" to branch-2.3
Apache-HBase commented on pull request #1834: URL: https://github.com/apache/hbase/pull/1834#issuecomment-638475141 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 24s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 53s | branch-2.3 passed | | +1 :green_heart: | compile | 2m 22s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 5m 26s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 11s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 31s | the patch passed | | +1 :green_heart: | compile | 2m 20s | the patch passed | | +1 :green_heart: | javac | 2m 20s | the patch passed | | +1 :green_heart: | shadedjars | 5m 28s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 35s | hbase-server generated 25 new + 1 unchanged - 0 fixed = 26 total (was 1) | | -0 :warning: | javadoc | 2m 24s | root generated 25 new + 16 unchanged - 0 fixed = 41 total (was 16) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 386m 11s | root in the patch passed. | | | | 419m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1834 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 7ccefd3fcb07 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / 6ffa36b061 | | Default Java | 1.8.0_232 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/testReport/ | | Max. process+thread count | 3399 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1834/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…
Apache-HBase commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-638474023 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 48s | master passed | | +1 :green_heart: | compile | 0m 57s | master passed | | +1 :green_heart: | shadedjars | 5m 36s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 29s | the patch passed | | +1 :green_heart: | compile | 0m 54s | the patch passed | | +1 :green_heart: | javac | 0m 54s | the patch passed | | +1 :green_heart: | shadedjars | 5m 31s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 139m 28s | hbase-server in the patch passed. | | | | 163m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1791/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1791 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 5120ea93e01a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0078268203 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1791/4/testReport/ | | Max. process+thread count | 3771 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1791/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-24010) HBase shell list_peers command is displayed incorrectly
[
https://issues.apache.org/jira/browse/HBASE-24010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125292#comment-17125292
]
Michael Stack edited comment on HBASE-24010 at 6/3/20, 8:42 PM:
If of use, here is how it used look in old days when you listed peers:
{code}
hbase(main):001:0> list_peers
PEER_ID CLUSTER_KEY ENDPOINT_CLASSNAME STATE TABLE_CFS
1
web2-zk0001.example.org,web2-zk0002.example.org,web2-zk0003.example.org:2181:/hbase
nil DISABLED nil
1 row(s) in 0.1110 seconds
{code}
I confirm this is a problem:
{code}
hbase(main):001:0>
hbase(main):002:0* list_peers
PEER_ID CLUSTER_KEY ENDPOINT_CLASSNAME STATE REPLICATE_ALL NAMESPACES
TABLE_CFS BANDWIDTH SERIAL
1
hdpe-zk0001.example.org,hdpe-zk0002.example.org,hdpe-zk0003.example.org:2181:/hbase
DISABLED true 0 false
1 row(s)
Took 0.3990 seconds
=> #
{code}
was (Author: stack):
If of use, here is how it used look in old days when you listed peers:
{code}
hbase(main):001:0> list_peers
PEER_ID CLUSTER_KEY ENDPOINT_CLASSNAME STATE TABLE_CFS
1
web2-zk0001.example.org,web2-zk0002..example.org,web2-zk0003..example.org:2181:/hbase
nil DISABLED nil
1 row(s) in 0.1110 seconds
{code}
I confirm this is a problem:
{code}
hbase(main):001:0>
hbase(main):002:0* list_peers
PEER_ID CLUSTER_KEY ENDPOINT_CLASSNAME STATE REPLICATE_ALL NAMESPACES
TABLE_CFS BANDWIDTH SERIAL
1
hdpe-zk0001.example.org,hdpe-zk0002.example.org,hdpe-zk0003.example.org:2181:/hbase
DISABLED true 0 false
1 row(s)
Took 0.3990 seconds
=> #
{code}
> HBase shell list_peers command is displayed incorrectly
> ---
>
> Key: HBASE-24010
> URL: https://issues.apache.org/jira/browse/HBASE-24010
> Project: HBase
> Issue Type: Bug
> Components: shell
>Reporter: song XinCun
>Assignee: song XinCun
>Priority: Major
>
> In 2.X version, I found hbase shell list_peers command displays java object
> id not the human readable peer messages
> {code:java}
> hbase(main):002:0> list_peers
> PEER_ID CLUSTER_KEY ENDPOINT_CLASSNAME STATE REPLICATE_ALL NAMESPACES
> TABLE_CFS BANDWIDTH SERIAL
> 0 row(s)
> Took 0.3336 seconds
> => #
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (HBASE-24010) HBase shell list_peers command is displayed incorrectly
[
https://issues.apache.org/jira/browse/HBASE-24010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125292#comment-17125292
]
Michael Stack edited comment on HBASE-24010 at 6/3/20, 8:41 PM:
If of use, here is how it used look in old days when you listed peers:
{code}
hbase(main):001:0> list_peers
PEER_ID CLUSTER_KEY ENDPOINT_CLASSNAME STATE TABLE_CFS
1
web2-zk0001.example.org,web2-zk0002..example.org,web2-zk0003..example.org:2181:/hbase
nil DISABLED nil
1 row(s) in 0.1110 seconds
{code}
I confirm this is a problem:
{code}
hbase(main):001:0>
hbase(main):002:0* list_peers
PEER_ID CLUSTER_KEY ENDPOINT_CLASSNAME STATE REPLICATE_ALL NAMESPACES
TABLE_CFS BANDWIDTH SERIAL
1
hdpe-zk0001.example.org,hdpe-zk0002.example.org,hdpe-zk0003.example.org:2181:/hbase
DISABLED true 0 false
1 row(s)
Took 0.3990 seconds
=> #
{code}
was (Author: stack):
If of use, here is how it used look in old days when you listed peers:
{code}
hbase(main):001:0> list_peers
PEER_ID CLUSTER_KEY ENDPOINT_CLASSNAME STATE TABLE_CFS
1
web2-zk0001.example.org,web2-zk0002..example.org,web2-zk0003..example.org:2181:/hbase
nil DISABLED nil
1 row(s) in 0.1110 seconds
{code}
I confirm this is a problem:
{code}
hbase(main):001:0>
hbase(main):002:0* list_peers
PEER_ID CLUSTER_KEY ENDPOINT_CLASSNAME STATE REPLICATE_ALL NAMESPACES
TABLE_CFS BANDWIDTH SERIAL
1
hdpe-zk0001.example.org,hdpe-zk0002.example.org,hdpe-zk0003.hdp.parsec.apple.com:2181:/hbase
DISABLED true 0 false
1 row(s)
Took 0.3990 seconds
=> #
{code}
> HBase shell list_peers command is displayed incorrectly
> ---
>
> Key: HBASE-24010
> URL: https://issues.apache.org/jira/browse/HBASE-24010
> Project: HBase
> Issue Type: Bug
> Components: shell
>Reporter: song XinCun
>Assignee: song XinCun
>Priority: Major
>
> In 2.X version, I found hbase shell list_peers command displays java object
> id not the human readable peer messages
> {code:java}
> hbase(main):002:0> list_peers
> PEER_ID CLUSTER_KEY ENDPOINT_CLASSNAME STATE REPLICATE_ALL NAMESPACES
> TABLE_CFS BANDWIDTH SERIAL
> 0 row(s)
> Took 0.3336 seconds
> => #
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-13583) AOT compile our JRuby
[ https://issues.apache.org/jira/browse/HBASE-13583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125300#comment-17125300 ] Nick Dimiduk commented on HBASE-13583: -- bq. which means we'll get neither startup speedup or java method invocation validation. :( > AOT compile our JRuby > - > > Key: HBASE-13583 > URL: https://issues.apache.org/jira/browse/HBASE-13583 > Project: HBase > Issue Type: Improvement > Components: build, scripts, shell >Reporter: Nick Dimiduk >Priority: Major > Attachments: HBASE-13583.patch, HBASE-13583.v2.patch, > HBASE-13583.v3.patch, HBASE-13583.v4.patch > > > Our Jruby code seems to not keep up well with Java changes. We should > investigate adding a compilation step for our shell and the rb scripts in bin > to ensure they're calling methods that exist on classes that exist. This > looks like as good a starting point as any: > https://github.com/jruby/jruby/wiki/GeneratingJavaClasses -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-13583) AOT compile our JRuby
[ https://issues.apache.org/jira/browse/HBASE-13583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125299#comment-17125299 ] Nick Dimiduk commented on HBASE-13583: -- Not sure if it helps here, but looks like there's a tool called [warbler|https://github.com/jruby/warbler] that assists with AOT-compilation. I do prefer an approach that makes use of a maven plugin, though. > AOT compile our JRuby > - > > Key: HBASE-13583 > URL: https://issues.apache.org/jira/browse/HBASE-13583 > Project: HBase > Issue Type: Improvement > Components: build, scripts, shell >Reporter: Nick Dimiduk >Priority: Major > Attachments: HBASE-13583.patch, HBASE-13583.v2.patch, > HBASE-13583.v3.patch, HBASE-13583.v4.patch > > > Our Jruby code seems to not keep up well with Java changes. We should > investigate adding a compilation step for our shell and the rb scripts in bin > to ensure they're calling methods that exist on classes that exist. This > looks like as good a starting point as any: > https://github.com/jruby/jruby/wiki/GeneratingJavaClasses -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (HBASE-24010) HBase shell list_peers command is displayed incorrectly
[
https://issues.apache.org/jira/browse/HBASE-24010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125292#comment-17125292
]
Michael Stack edited comment on HBASE-24010 at 6/3/20, 8:28 PM:
If of use, here is how it used look in old days when you listed peers:
{code}
hbase(main):001:0> list_peers
PEER_ID CLUSTER_KEY ENDPOINT_CLASSNAME STATE TABLE_CFS
1
web2-zk0001.example.org,web2-zk0002..example.org,web2-zk0003..example.org:2181:/hbase
nil DISABLED nil
1 row(s) in 0.1110 seconds
{code}
I confirm this is a problem:
{code}
hbase(main):001:0>
hbase(main):002:0* list_peers
PEER_ID CLUSTER_KEY ENDPOINT_CLASSNAME STATE REPLICATE_ALL NAMESPACES
TABLE_CFS BANDWIDTH SERIAL
1
hdpe-zk0001.example.org,hdpe-zk0002.example.org,hdpe-zk0003.hdp.parsec.apple.com:2181:/hbase
DISABLED true 0 false
1 row(s)
Took 0.3990 seconds
=> #
{code}
was (Author: stack):
If of use, here is how it used look in old days when you listed peers:
{code}
hbase(main):001:0> list_peers
PEER_ID CLUSTER_KEY ENDPOINT_CLASSNAME STATE TABLE_CFS
1
web2-zk0001.bot.parsec.example.org,web2-zk0002..example.org,web2-zk0003..example.org:2181:/hbase
nil DISABLED nil
1 row(s) in 0.1110 seconds
{code}
I confirm this is a problem:
{code}
hbase(main):001:0>
hbase(main):002:0* list_peers
PEER_ID CLUSTER_KEY ENDPOINT_CLASSNAME STATE REPLICATE_ALL NAMESPACES
TABLE_CFS BANDWIDTH SERIAL
1
hdpe-zk0001.hdp.parsec.apple.com,hdpe-zk0002.hdp.parsec.apple.com,hdpe-zk0003.hdp.parsec.apple.com:2181:/hbase
DISABLED true 0 false
1 row(s)
Took 0.3990 seconds
=> #
{code}
> HBase shell list_peers command is displayed incorrectly
> ---
>
> Key: HBASE-24010
> URL: https://issues.apache.org/jira/browse/HBASE-24010
> Project: HBase
> Issue Type: Bug
> Components: shell
>Reporter: song XinCun
>Assignee: song XinCun
>Priority: Major
>
> In 2.X version, I found hbase shell list_peers command displays java object
> id not the human readable peer messages
> {code:java}
> hbase(main):002:0> list_peers
> PEER_ID CLUSTER_KEY ENDPOINT_CLASSNAME STATE REPLICATE_ALL NAMESPACES
> TABLE_CFS BANDWIDTH SERIAL
> 0 row(s)
> Took 0.3336 seconds
> => #
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24010) HBase shell list_peers command is displayed incorrectly
[
https://issues.apache.org/jira/browse/HBASE-24010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125292#comment-17125292
]
Michael Stack commented on HBASE-24010:
---
If of use, here is how it used look in old days when you listed peers:
{code}
hbase(main):001:0> list_peers
PEER_ID CLUSTER_KEY ENDPOINT_CLASSNAME STATE TABLE_CFS
1
web2-zk0001.bot.parsec.example.org,web2-zk0002..example.org,web2-zk0003..example.org:2181:/hbase
nil DISABLED nil
1 row(s) in 0.1110 seconds
{code}
I confirm this is a problem:
{code}
hbase(main):001:0>
hbase(main):002:0* list_peers
PEER_ID CLUSTER_KEY ENDPOINT_CLASSNAME STATE REPLICATE_ALL NAMESPACES
TABLE_CFS BANDWIDTH SERIAL
1
hdpe-zk0001.hdp.parsec.apple.com,hdpe-zk0002.hdp.parsec.apple.com,hdpe-zk0003.hdp.parsec.apple.com:2181:/hbase
DISABLED true 0 false
1 row(s)
Took 0.3990 seconds
=> #
{code}
> HBase shell list_peers command is displayed incorrectly
> ---
>
> Key: HBASE-24010
> URL: https://issues.apache.org/jira/browse/HBASE-24010
> Project: HBase
> Issue Type: Bug
> Components: shell
>Reporter: song XinCun
>Assignee: song XinCun
>Priority: Major
>
> In 2.X version, I found hbase shell list_peers command displays java object
> id not the human readable peer messages
> {code:java}
> hbase(main):002:0> list_peers
> PEER_ID CLUSTER_KEY ENDPOINT_CLASSNAME STATE REPLICATE_ALL NAMESPACES
> TABLE_CFS BANDWIDTH SERIAL
> 0 row(s)
> Took 0.3336 seconds
> => #
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1833: Backport "HBASE-24418 Consolidate Normalizer implementations" to branch-2
Apache-HBase commented on pull request #1833: URL: https://github.com/apache/hbase/pull/1833#issuecomment-638431632 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 41s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 14s | branch-2 passed | | +1 :green_heart: | checkstyle | 2m 38s | branch-2 passed | | +0 :ok: | refguide | 12m 5s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | spotbugs | 12m 29s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 6s | the patch passed | | +1 :green_heart: | checkstyle | 2m 40s | root: The patch generated 0 new + 103 unchanged - 1 fixed = 103 total (was 104) | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +0 :ok: | refguide | 7m 19s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | hadoopcheck | 12m 30s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 12m 43s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 37s | The patch does not generate ASF License warnings. | | | | 82m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1833 | | Optional Tests | dupname asflicense shellcheck shelldocs refguide xml spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux a70fbec69cb0 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 8c9c670aaa | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-general-check/output/branch-site/book.html | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/artifact/yetus-general-check/output/patch-site/book.html | | Max. process+thread count | 122 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1833/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …
Apache-HBase commented on pull request #1840: URL: https://github.com/apache/hbase/pull/1840#issuecomment-638427495 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 44s | master passed | | +1 :green_heart: | compile | 1m 25s | master passed | | +1 :green_heart: | shadedjars | 5m 32s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 2s | master passed | | -0 :warning: | patch | 6m 55s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 27s | the patch passed | | +1 :green_heart: | compile | 1m 20s | the patch passed | | +1 :green_heart: | javac | 1m 20s | the patch passed | | +1 :green_heart: | shadedjars | 5m 30s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 59s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 6s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 152m 30s | hbase-server in the patch passed. | | | | 180m 17s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1840/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1840 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux bea17df67885 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0078268203 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1840/3/testReport/ | | Max. process+thread count | 3822 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1840/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …
Apache-HBase commented on pull request #1840: URL: https://github.com/apache/hbase/pull/1840#issuecomment-638424719 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 18s | master passed | | +1 :green_heart: | compile | 1m 38s | master passed | | +1 :green_heart: | shadedjars | 5m 58s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 30s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 43s | hbase-server in master failed. | | -0 :warning: | patch | 7m 32s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 8s | the patch passed | | +1 :green_heart: | compile | 1m 37s | the patch passed | | +1 :green_heart: | javac | 1m 37s | the patch passed | | +1 :green_heart: | shadedjars | 6m 2s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 27s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 51s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 28s | hbase-client in the patch passed. | | -1 :x: | unit | 143m 49s | hbase-server in the patch failed. | | | | 174m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1840/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1840 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 872bc3c28170 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0078268203 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1840/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1840/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1840/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1840/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1840/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1840/3/testReport/ | | Max. process+thread count | 3907 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1840/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
virajjasani commented on a change in pull request #1844: URL: https://github.com/apache/hbase/pull/1844#discussion_r434805966 ## File path: src/main/asciidoc/_chapters/configuration.adoc ## @@ -97,55 +97,76 @@ This section lists required services and some required system configuration. [[java]] .Java -The following table summarizes the recommendation of the HBase community wrt deploying on various -Java versions. A icon:check-circle[role="green"] symbol is meant to indicate a base level of +The following table summarizes the recommendations of the HBase community with respect to deploying +on various Java versions. The icon:check-circle[role="green"] symbol indicates a base level of testing and willingness to help diagnose and address issues you might run into. Similarly, an entry -of icon:exclamation-circle[role="yellow"] or icon:times-circle[role="red"] generally means that -should you run into an issue the community is likely to ask you to change the Java environment -before proceeding to help. In some cases, specific guidance on limitations (e.g. whether compiling -/ unit tests work, specific operational issues, etc) will also be noted. +of icon:exclamation-circle[role="yellow"] means that, should you run into an issue, the community +is likely to ask you to change the Java environment rather than proceeding to help on that Java +version. This applies categorically to Non-LTS releases (see below). The +icon:times-circle[role="red"] means that support has been dropped for this version or has been +attempted and is known to not work. For combinations of newer JDK with older HBase releases, it's +likely that there are known compatibility issues that cannot be addressed under our compatibility +guarantees, making that combination impossible. In some cases, specific guidance on limitations +(e.g. whether compiling / unit tests work, specific operational issues, etc) will also be noted. + +.Long-Term Support JDKs are Recommended +[WARNING] + +HBase recommends downstream users rely on JDK releases that are marked as Long-Term Supported +(LTS), either from the OpenJDK project or vendors. At the time of this writing, the following JDK +releases are NOT LTS releases and are NOT supported by the Apache HBase community: JDK9, JDK10, +JDK12, JDK13, and JDK14. Community discussion around this decision is recorded on +link:https://issues.apache.org/jira/browse/HBASE-20264[HBASE-20264]. + -.Long Term Support JDKs are recommended +.HotSpot vs. OpenJ9 [TIP] -HBase recommends downstream users rely on JDK releases that are marked as Long Term Supported (LTS) -either from the OpenJDK project or vendors. As of March 2018 that means Java 8 is the only -applicable version and that the next likely version to see testing will be Java 11 near Q3 2018. +At this time, all testing performed by the Apache HBase project runs on the HotSpot variant of the +JVM. When selecting your JDK distribution, please take this into consideration. .Java support by release line -[cols="6*^.^", options="header"] +[cols="4*^.^", options="header"] |=== -|HBase Version -|JDK 7 -|JDK 8 -|JDK 9 (Non-LTS) -|JDK 10 (Non-LTS) -|JDK 11 - -|2.1+ +|Java Version +|HBase 1.3+ +|HBase 2.1+ +|HBase 2.3+ + +|JDK6 +|icon:times-circle[role="red"] |icon:times-circle[role="red"] +|icon:times-circle[role="red"] + +|JDK7 +|icon:check-circle[role="green"] +|icon:times-circle[role="red"] +|icon:times-circle[role="red"] + +|JDK8 |icon:check-circle[role="green"] Review comment: Although this doesn't mean that users can't compile 1.3+ with JDK 1.8, but branch-1 is still not 1.8 compatible source code wise. I am not sure whether this means we should mark this `red` (we can run clusters on Java 8 env but code is not compatible) Edit: Looks like we are not talking about source code compatibility but LTS versions for deployment only. So yeah, good to keep this `green` because deployment is supported with JDK 1.8. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
virajjasani commented on a change in pull request #1844: URL: https://github.com/apache/hbase/pull/1844#discussion_r434805966 ## File path: src/main/asciidoc/_chapters/configuration.adoc ## @@ -97,55 +97,76 @@ This section lists required services and some required system configuration. [[java]] .Java -The following table summarizes the recommendation of the HBase community wrt deploying on various -Java versions. A icon:check-circle[role="green"] symbol is meant to indicate a base level of +The following table summarizes the recommendations of the HBase community with respect to deploying +on various Java versions. The icon:check-circle[role="green"] symbol indicates a base level of testing and willingness to help diagnose and address issues you might run into. Similarly, an entry -of icon:exclamation-circle[role="yellow"] or icon:times-circle[role="red"] generally means that -should you run into an issue the community is likely to ask you to change the Java environment -before proceeding to help. In some cases, specific guidance on limitations (e.g. whether compiling -/ unit tests work, specific operational issues, etc) will also be noted. +of icon:exclamation-circle[role="yellow"] means that, should you run into an issue, the community +is likely to ask you to change the Java environment rather than proceeding to help on that Java +version. This applies categorically to Non-LTS releases (see below). The +icon:times-circle[role="red"] means that support has been dropped for this version or has been +attempted and is known to not work. For combinations of newer JDK with older HBase releases, it's +likely that there are known compatibility issues that cannot be addressed under our compatibility +guarantees, making that combination impossible. In some cases, specific guidance on limitations +(e.g. whether compiling / unit tests work, specific operational issues, etc) will also be noted. + +.Long-Term Support JDKs are Recommended +[WARNING] + +HBase recommends downstream users rely on JDK releases that are marked as Long-Term Supported +(LTS), either from the OpenJDK project or vendors. At the time of this writing, the following JDK +releases are NOT LTS releases and are NOT supported by the Apache HBase community: JDK9, JDK10, +JDK12, JDK13, and JDK14. Community discussion around this decision is recorded on +link:https://issues.apache.org/jira/browse/HBASE-20264[HBASE-20264]. + -.Long Term Support JDKs are recommended +.HotSpot vs. OpenJ9 [TIP] -HBase recommends downstream users rely on JDK releases that are marked as Long Term Supported (LTS) -either from the OpenJDK project or vendors. As of March 2018 that means Java 8 is the only -applicable version and that the next likely version to see testing will be Java 11 near Q3 2018. +At this time, all testing performed by the Apache HBase project runs on the HotSpot variant of the +JVM. When selecting your JDK distribution, please take this into consideration. .Java support by release line -[cols="6*^.^", options="header"] +[cols="4*^.^", options="header"] |=== -|HBase Version -|JDK 7 -|JDK 8 -|JDK 9 (Non-LTS) -|JDK 10 (Non-LTS) -|JDK 11 - -|2.1+ +|Java Version +|HBase 1.3+ +|HBase 2.1+ +|HBase 2.3+ + +|JDK6 +|icon:times-circle[role="red"] |icon:times-circle[role="red"] +|icon:times-circle[role="red"] + +|JDK7 +|icon:check-circle[role="green"] +|icon:times-circle[role="red"] +|icon:times-circle[role="red"] + +|JDK8 |icon:check-circle[role="green"] Review comment: Although this doesn't mean that users can't compile 1.3+ with JDK 1.8, but branch-1 is still not 1.8 compatible source code wise. I am not sure whether this means we should mark this `red` (we can run clusters on Java 8 env but code is not compatible) Edit: Looks like we are not talking about source code compatibility but LTS versions only. So, maybe good to keep this `green`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
virajjasani commented on a change in pull request #1844: URL: https://github.com/apache/hbase/pull/1844#discussion_r434805966 ## File path: src/main/asciidoc/_chapters/configuration.adoc ## @@ -97,55 +97,76 @@ This section lists required services and some required system configuration. [[java]] .Java -The following table summarizes the recommendation of the HBase community wrt deploying on various -Java versions. A icon:check-circle[role="green"] symbol is meant to indicate a base level of +The following table summarizes the recommendations of the HBase community with respect to deploying +on various Java versions. The icon:check-circle[role="green"] symbol indicates a base level of testing and willingness to help diagnose and address issues you might run into. Similarly, an entry -of icon:exclamation-circle[role="yellow"] or icon:times-circle[role="red"] generally means that -should you run into an issue the community is likely to ask you to change the Java environment -before proceeding to help. In some cases, specific guidance on limitations (e.g. whether compiling -/ unit tests work, specific operational issues, etc) will also be noted. +of icon:exclamation-circle[role="yellow"] means that, should you run into an issue, the community +is likely to ask you to change the Java environment rather than proceeding to help on that Java +version. This applies categorically to Non-LTS releases (see below). The +icon:times-circle[role="red"] means that support has been dropped for this version or has been +attempted and is known to not work. For combinations of newer JDK with older HBase releases, it's +likely that there are known compatibility issues that cannot be addressed under our compatibility +guarantees, making that combination impossible. In some cases, specific guidance on limitations +(e.g. whether compiling / unit tests work, specific operational issues, etc) will also be noted. + +.Long-Term Support JDKs are Recommended +[WARNING] + +HBase recommends downstream users rely on JDK releases that are marked as Long-Term Supported +(LTS), either from the OpenJDK project or vendors. At the time of this writing, the following JDK +releases are NOT LTS releases and are NOT supported by the Apache HBase community: JDK9, JDK10, +JDK12, JDK13, and JDK14. Community discussion around this decision is recorded on +link:https://issues.apache.org/jira/browse/HBASE-20264[HBASE-20264]. + -.Long Term Support JDKs are recommended +.HotSpot vs. OpenJ9 [TIP] -HBase recommends downstream users rely on JDK releases that are marked as Long Term Supported (LTS) -either from the OpenJDK project or vendors. As of March 2018 that means Java 8 is the only -applicable version and that the next likely version to see testing will be Java 11 near Q3 2018. +At this time, all testing performed by the Apache HBase project runs on the HotSpot variant of the +JVM. When selecting your JDK distribution, please take this into consideration. .Java support by release line -[cols="6*^.^", options="header"] +[cols="4*^.^", options="header"] |=== -|HBase Version -|JDK 7 -|JDK 8 -|JDK 9 (Non-LTS) -|JDK 10 (Non-LTS) -|JDK 11 - -|2.1+ +|Java Version +|HBase 1.3+ +|HBase 2.1+ +|HBase 2.3+ + +|JDK6 +|icon:times-circle[role="red"] |icon:times-circle[role="red"] +|icon:times-circle[role="red"] + +|JDK7 +|icon:check-circle[role="green"] +|icon:times-circle[role="red"] +|icon:times-circle[role="red"] + +|JDK8 |icon:check-circle[role="green"] Review comment: Although this doesn't mean that users can't compile 1.3+ with JDK 1.8, but branch-1 is still not 1.8 compatible source code wise. I am not sure whether this means we should mark this `red` (we can run clusters on Java 8 env but code is not compatible) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
virajjasani commented on a change in pull request #1844: URL: https://github.com/apache/hbase/pull/1844#discussion_r434805966 ## File path: src/main/asciidoc/_chapters/configuration.adoc ## @@ -97,55 +97,76 @@ This section lists required services and some required system configuration. [[java]] .Java -The following table summarizes the recommendation of the HBase community wrt deploying on various -Java versions. A icon:check-circle[role="green"] symbol is meant to indicate a base level of +The following table summarizes the recommendations of the HBase community with respect to deploying +on various Java versions. The icon:check-circle[role="green"] symbol indicates a base level of testing and willingness to help diagnose and address issues you might run into. Similarly, an entry -of icon:exclamation-circle[role="yellow"] or icon:times-circle[role="red"] generally means that -should you run into an issue the community is likely to ask you to change the Java environment -before proceeding to help. In some cases, specific guidance on limitations (e.g. whether compiling -/ unit tests work, specific operational issues, etc) will also be noted. +of icon:exclamation-circle[role="yellow"] means that, should you run into an issue, the community +is likely to ask you to change the Java environment rather than proceeding to help on that Java +version. This applies categorically to Non-LTS releases (see below). The +icon:times-circle[role="red"] means that support has been dropped for this version or has been +attempted and is known to not work. For combinations of newer JDK with older HBase releases, it's +likely that there are known compatibility issues that cannot be addressed under our compatibility +guarantees, making that combination impossible. In some cases, specific guidance on limitations +(e.g. whether compiling / unit tests work, specific operational issues, etc) will also be noted. + +.Long-Term Support JDKs are Recommended +[WARNING] + +HBase recommends downstream users rely on JDK releases that are marked as Long-Term Supported +(LTS), either from the OpenJDK project or vendors. At the time of this writing, the following JDK +releases are NOT LTS releases and are NOT supported by the Apache HBase community: JDK9, JDK10, +JDK12, JDK13, and JDK14. Community discussion around this decision is recorded on +link:https://issues.apache.org/jira/browse/HBASE-20264[HBASE-20264]. + -.Long Term Support JDKs are recommended +.HotSpot vs. OpenJ9 [TIP] -HBase recommends downstream users rely on JDK releases that are marked as Long Term Supported (LTS) -either from the OpenJDK project or vendors. As of March 2018 that means Java 8 is the only -applicable version and that the next likely version to see testing will be Java 11 near Q3 2018. +At this time, all testing performed by the Apache HBase project runs on the HotSpot variant of the +JVM. When selecting your JDK distribution, please take this into consideration. .Java support by release line -[cols="6*^.^", options="header"] +[cols="4*^.^", options="header"] |=== -|HBase Version -|JDK 7 -|JDK 8 -|JDK 9 (Non-LTS) -|JDK 10 (Non-LTS) -|JDK 11 - -|2.1+ +|Java Version +|HBase 1.3+ +|HBase 2.1+ +|HBase 2.3+ + +|JDK6 +|icon:times-circle[role="red"] |icon:times-circle[role="red"] +|icon:times-circle[role="red"] + +|JDK7 +|icon:check-circle[role="green"] +|icon:times-circle[role="red"] +|icon:times-circle[role="red"] + +|JDK8 |icon:check-circle[role="green"] Review comment: Although this doesn't mean that users can't compile 1.3+ with JDK 1.8, but branch-1 is still not 1.8 compatible source code wise. I am not sure whether this means we should mark this `red` because ppl can run clusters on Java 8 env. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24255) GCRegionProcedure doesn't assign region from RegionServer leading to orphans
[ https://issues.apache.org/jira/browse/HBASE-24255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125257#comment-17125257 ] Huaxiang Sun commented on HBASE-24255: -- My comments regarding with merge is wrong (merge is done manually), normalizer can merge regions as well. At this moment, no effort is being made regarding with this jira. [~timoha], we are going to resolve it with "cannot reproduce". If this pops again, we can reopen this Jira with more concrete steps/logs. Please speak out if you have different opinion, thanks. > GCRegionProcedure doesn't assign region from RegionServer leading to orphans > > > Key: HBASE-24255 > URL: https://issues.apache.org/jira/browse/HBASE-24255 > Project: HBase > Issue Type: Bug > Components: proc-v2, Region Assignment, regionserver >Affects Versions: 2.2.4 > Environment: hbase 2.2.4 > hadoop 3.1.3 >Reporter: Andrey Elenskiy >Priority: Major > > We've found ourselves in a situation where parents of merged or split regions > needed to be opened again on a regionserver due to having to recover from > cluster meltdown (HBCK2's fixMeta kicks off GCMultipleMergedRegionsProcedure > which requiters all regions to be merged to be open). Then, when a > GCProcedure is kicked of to clean a parent region up by > GCMultipleMergedRegionsProcedure, it ends up deleting it from hbase:meta, but > doesn't unassign it from RegionServer leading for it to show up in "Orphan > Regions on RegionServer" in hbck tab of HBase Master. Also, the hbase client > doesn't detect that the region is closed either because it's still > technically open on a regionserver (it doesn't reread hbase:meta all the > time). The only way to recover from this is to restart regionserver which > isn't idea as it can lead to other issues in clusters with region > inconsistencies. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] virajjasani commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
virajjasani commented on a change in pull request #1844: URL: https://github.com/apache/hbase/pull/1844#discussion_r434793703 ## File path: src/main/asciidoc/_chapters/configuration.adoc ## @@ -97,55 +97,76 @@ This section lists required services and some required system configuration. [[java]] .Java -The following table summarizes the recommendation of the HBase community wrt deploying on various -Java versions. A icon:check-circle[role="green"] symbol is meant to indicate a base level of +The following table summarizes the recommendations of the HBase community with respect to deploying +on various Java versions. The icon:check-circle[role="green"] symbol indicates a base level of testing and willingness to help diagnose and address issues you might run into. Similarly, an entry -of icon:exclamation-circle[role="yellow"] or icon:times-circle[role="red"] generally means that -should you run into an issue the community is likely to ask you to change the Java environment -before proceeding to help. In some cases, specific guidance on limitations (e.g. whether compiling -/ unit tests work, specific operational issues, etc) will also be noted. +of icon:exclamation-circle[role="yellow"] means that, should you run into an issue, the community +is likely to ask you to change the Java environment rather than proceeding to help on that Java +version. This applies categorically to Non-LTS releases (see below). The +icon:times-circle[role="red"] means that support has been dropped for this version or has been +attempted and is known to not work. For combinations of newer JDK with older HBase releases, it's +likely that there are known compatibility issues that cannot be addressed under our compatibility +guarantees, making that combination impossible. In some cases, specific guidance on limitations +(e.g. whether compiling / unit tests work, specific operational issues, etc) will also be noted. + +.Long-Term Support JDKs are Recommended +[WARNING] + +HBase recommends downstream users rely on JDK releases that are marked as Long-Term Supported +(LTS), either from the OpenJDK project or vendors. At the time of this writing, the following JDK +releases are NOT LTS releases and are NOT supported by the Apache HBase community: JDK9, JDK10, +JDK12, JDK13, and JDK14. Community discussion around this decision is recorded on +link:https://issues.apache.org/jira/browse/HBASE-20264[HBASE-20264]. + -.Long Term Support JDKs are recommended +.HotSpot vs. OpenJ9 [TIP] -HBase recommends downstream users rely on JDK releases that are marked as Long Term Supported (LTS) -either from the OpenJDK project or vendors. As of March 2018 that means Java 8 is the only -applicable version and that the next likely version to see testing will be Java 11 near Q3 2018. +At this time, all testing performed by the Apache HBase project runs on the HotSpot variant of the +JVM. When selecting your JDK distribution, please take this into consideration. .Java support by release line -[cols="6*^.^", options="header"] +[cols="4*^.^", options="header"] |=== -|HBase Version -|JDK 7 -|JDK 8 -|JDK 9 (Non-LTS) -|JDK 10 (Non-LTS) -|JDK 11 - -|2.1+ +|Java Version +|HBase 1.3+ +|HBase 2.1+ +|HBase 2.3+ + +|JDK6 +|icon:times-circle[role="red"] |icon:times-circle[role="red"] +|icon:times-circle[role="red"] + +|JDK7 +|icon:check-circle[role="green"] +|icon:times-circle[role="red"] +|icon:times-circle[role="red"] + +|JDK8 |icon:check-circle[role="green"] Review comment: JDK8 should be `red` for HBase 1.3+ right? branch-1.3 and 1.4 have `maven-compiler-plugin` source and target as 1.7. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…
Apache-HBase commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-638411813 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 47s | master passed | | +1 :green_heart: | checkstyle | 1m 9s | master passed | | +1 :green_heart: | spotbugs | 2m 1s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 25s | the patch passed | | -0 :warning: | checkstyle | 1m 6s | hbase-server: The patch generated 5 new + 38 unchanged - 4 fixed = 43 total (was 42) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 13s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 37s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 35m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1791/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1791 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux ad3ca0482ebd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0078268203 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1791/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1791/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] huaxiangsun commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…
huaxiangsun commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-638405644 @z-york I uploaded a new patch which addresses some of your comments, put up explain for rest of your comments. Please let me know if there is anything missing, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder
Apache-HBase commented on pull request #1818: URL: https://github.com/apache/hbase/pull/1818#issuecomment-638395777 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 36s | master passed | | +1 :green_heart: | checkstyle | 1m 33s | master passed | | +1 :green_heart: | spotbugs | 2m 56s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 18s | the patch passed | | -0 :warning: | checkstyle | 0m 27s | hbase-client: The patch generated 2 new + 15 unchanged - 0 fixed = 17 total (was 15) | | -0 :warning: | checkstyle | 1m 2s | hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 3s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 3m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. | | | | 36m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1818/9/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1818 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 95b6748c7a0d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0078268203 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1818/9/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1818/9/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1818/9/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24205) Create metric to know the number of reads that happens from memstore
[ https://issues.apache.org/jira/browse/HBASE-24205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125220#comment-17125220 ] Anoop Sam John commented on HBASE-24205: Aggregated at region level means it will consider all CFs/Stores under that region. Say we have 2 store (CFs) under region and one having read pattern of recent data and other not, the aggregated at region level will not be a real insight. I want to know which CF is having recent data read pattern. Now comes to table level aggregate. This is not like cf -> region -> table that way of aggregate path. Instead what it tells is on a given table for a given CF what is the memstore read vs file read. So just looking at this one aggregated metric I can know for this CF in a table the pattern is recent data read while on the other its not. This reduces the need to look at N store metric and do aggregate on my own. > Create metric to know the number of reads that happens from memstore > > > Key: HBASE-24205 > URL: https://issues.apache.org/jira/browse/HBASE-24205 > Project: HBase > Issue Type: Improvement > Components: metrics >Affects Versions: 3.0.0-alpha-1 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.6 > > Attachments: screenshot.png, screenshot_tablevscf.png > > > A metric to identify number of reads that were served from memstore (atleast > if the gets can be accounted for) then it gives a value addition to know if > among the reads how much was targeted at the most recent data. > Currently the existing metric framework at region level should be enough but > we can also add a metric per store level. That will be more granular. > We can also expose this via HbTop. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] ndimiduk commented on pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME
ndimiduk commented on pull request #1847: URL: https://github.com/apache/hbase/pull/1847#issuecomment-638385363 Testing with #1833 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] huaxiangsun commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…
huaxiangsun commented on a change in pull request #1791:
URL: https://github.com/apache/hbase/pull/1791#discussion_r434772239
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotHFileCleaner.java
##
@@ -93,12 +94,17 @@ public void setConf(final Configuration conf) {
DEFAULT_HFILE_CACHE_REFRESH_PERIOD);
final FileSystem fs = CommonFSUtils.getCurrentFileSystem(conf);
Path rootDir = CommonFSUtils.getRootDir(conf);
- cache = new SnapshotFileCache(fs, rootDir, cacheRefreshPeriod,
cacheRefreshPeriod,
- "snapshot-hfile-cleaner-cache-refresher", new
SnapshotFileCache.SnapshotFileInspector() {
+ Path workingDir =
SnapshotDescriptionUtils.getWorkingSnapshotDir(rootDir, conf);
+ FileSystem workingFs = workingDir.getFileSystem(conf);
+
+ cache = new SnapshotFileCache(fs, rootDir, workingFs, workingDir,
cacheRefreshPeriod,
+cacheRefreshPeriod, "snapshot-hfile-cleaner-cache-refresher",
+new SnapshotFileCache.SnapshotFileInspector() {
@Override
-public Collection filesUnderSnapshot(final Path
snapshotDir)
+public Collection filesUnderSnapshot(final FileSystem
workingFs,
Review comment:
Yeah, let me change it back to fs, workingFs is misleading.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] huaxiangsun commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…
huaxiangsun commented on a change in pull request #1791:
URL: https://github.com/apache/hbase/pull/1791#discussion_r434769865
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java
##
@@ -383,25 +385,38 @@ public static SnapshotDescription
readSnapshotInfo(FileSystem fs, Path snapshotD
}
/**
- * Move the finished snapshot to its final, publicly visible directory -
this marks the snapshot
- * as 'complete'.
- * @param snapshot description of the snapshot being tabken
- * @param rootdir root directory of the hbase installation
- * @param workingDir directory where the in progress snapshot was built
- * @param fs {@link FileSystem} where the snapshot was built
- * @throws org.apache.hadoop.hbase.snapshot.SnapshotCreationException if the
- * snapshot could not be moved
+ * Commits the snapshot process by moving the working snapshot
+ * to the finalized filepath
+ *
+ * @param snapshotDir The file path of the completed snapshots
+ * @param workingDir The file path of the in progress snapshots
+ * @param fs The file system of the completed snapshots
+ * @param workingDirFs The file system of the in progress snapshots
+ * @param conf Configuration
+ *
+ * @throws SnapshotCreationException if the snapshot could not be moved
* @throws IOException the filesystem could not be reached
*/
- public static void completeSnapshot(SnapshotDescription snapshot, Path
rootdir, Path workingDir,
- FileSystem fs) throws SnapshotCreationException, IOException {
-Path finishedDir = getCompletedSnapshotDir(snapshot, rootdir);
-LOG.debug("Snapshot is done, just moving the snapshot from " + workingDir
+ " to "
-+ finishedDir);
-if (!fs.rename(workingDir, finishedDir)) {
- throw new SnapshotCreationException(
- "Failed to move working directory(" + workingDir + ") to completed
directory("
- + finishedDir + ").", ProtobufUtil.createSnapshotDesc(snapshot));
+ public static void completeSnapshot(Path snapshotDir, Path workingDir,
FileSystem fs,
Review comment:
completeSnapshot() is being used by some other test classes besides
TakeSnapshotHandler. What it does is doing a few checks and do a rename/copy (
a static utility method). SnapshotDescriptionUtils is a class which aggregates
set of utility methods, though the name is kind of misleading, it already has a
set of utility methods beyond SnapshotDescription. Putting a static utility
method in TakeSnapshotHandler does not seem a good fit to me, what do you think?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] saintstack commented on a change in pull request #1825: HBASE-24189 WALSplit recreates region dirs for deleted table with rec…
saintstack commented on a change in pull request #1825:
URL: https://github.com/apache/hbase/pull/1825#discussion_r434763752
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java
##
@@ -285,23 +286,35 @@ boolean splitLogFile(FileStatus logfile,
CancelableProgressable reporter) throws
String encodedRegionNameAsStr = Bytes.toString(region);
lastFlushedSequenceId =
lastFlushedSequenceIds.get(encodedRegionNameAsStr);
if (lastFlushedSequenceId == null) {
- if (sequenceIdChecker != null) {
-RegionStoreSequenceIds ids =
sequenceIdChecker.getLastSequenceId(region);
-Map maxSeqIdInStores = new
TreeMap<>(Bytes.BYTES_COMPARATOR);
-for (StoreSequenceId storeSeqId : ids.getStoreSequenceIdList()) {
- maxSeqIdInStores.put(storeSeqId.getFamilyName().toByteArray(),
-storeSeqId.getSequenceId());
+ if (!(isRegionDirPresentUnderRoot(entry.getKey().getTableName(),
encodedRegionNameAsStr))) {
+// The region directory itself is not present in the FS. This
indicates that
+// the region/table is already removed. We can just skip all the
edits for this
+// region. Setting lastFlushedSequenceId as Long.MAX_VALUE so that
all edits
+// will get skipped by the seqId check below.
+// See more details at
https://issues.apache.org/jira/browse/HBASE-24189
+LOG.debug(
+"Region {} seems not available in the FS. Just skipping all
edits for this region",
Review comment:
Don't say 'seems'. LOG this at info level I think. You don't need the
word 'region' in the log... it is plain from context {} is not on the FS;
skipping all edits.
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java
##
@@ -285,23 +286,35 @@ boolean splitLogFile(FileStatus logfile,
CancelableProgressable reporter) throws
String encodedRegionNameAsStr = Bytes.toString(region);
lastFlushedSequenceId =
lastFlushedSequenceIds.get(encodedRegionNameAsStr);
if (lastFlushedSequenceId == null) {
- if (sequenceIdChecker != null) {
-RegionStoreSequenceIds ids =
sequenceIdChecker.getLastSequenceId(region);
-Map maxSeqIdInStores = new
TreeMap<>(Bytes.BYTES_COMPARATOR);
-for (StoreSequenceId storeSeqId : ids.getStoreSequenceIdList()) {
- maxSeqIdInStores.put(storeSeqId.getFamilyName().toByteArray(),
-storeSeqId.getSequenceId());
+ if (!(isRegionDirPresentUnderRoot(entry.getKey().getTableName(),
encodedRegionNameAsStr))) {
+// The region directory itself is not present in the FS. This
indicates that
+// the region/table is already removed. We can just skip all the
edits for this
+// region. Setting lastFlushedSequenceId as Long.MAX_VALUE so that
all edits
+// will get skipped by the seqId check below.
+// See more details at
https://issues.apache.org/jira/browse/HBASE-24189
+LOG.debug(
+"Region {} seems not available in the FS. Just skipping all
edits for this region",
+encodedRegionNameAsStr);
+lastFlushedSequenceId = Long.MAX_VALUE;
Review comment:
If the Region no longer exists, should we even be adding state for it in
here other than perhaps local state to save having to do expensive lookups
again?
The comment here exposes some of the soft logic this change depends upon; we
are looking at FS and whether a dir is present or not, we then suppose Region
present or not.
I think we should be asking the Master. If it is racy around split/merge,
then its a bug given Master transitions are meant to be locked down--not racy.
What you think Anoop?
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java
##
@@ -285,23 +286,35 @@ boolean splitLogFile(FileStatus logfile,
CancelableProgressable reporter) throws
String encodedRegionNameAsStr = Bytes.toString(region);
lastFlushedSequenceId =
lastFlushedSequenceIds.get(encodedRegionNameAsStr);
if (lastFlushedSequenceId == null) {
- if (sequenceIdChecker != null) {
-RegionStoreSequenceIds ids =
sequenceIdChecker.getLastSequenceId(region);
-Map maxSeqIdInStores = new
TreeMap<>(Bytes.BYTES_COMPARATOR);
-for (StoreSequenceId storeSeqId : ids.getStoreSequenceIdList()) {
- maxSeqIdInStores.put(storeSeqId.getFamilyName().toByteArray(),
-storeSeqId.getSequenceId());
+ if (!(isRegionDirPresentUnderRoot(entry.getKey().getTableName(),
encodedRegionNameAsStr))) {
+// The region directory itself is not present in the FS. This
indicates that
+// the region/table is already removed. We can just skip all
[GitHub] [hbase] Apache-HBase commented on pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME
Apache-HBase commented on pull request #1847: URL: https://github.com/apache/hbase/pull/1847#issuecomment-638372347 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 6s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 3m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1847/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1847 | | Optional Tests | | | uname | Linux b7cdb95c96ac 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 8c9c670aaa | | Max. process+thread count | 46 (vs. ulimit of 12500) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1847/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME
Apache-HBase commented on pull request #1847: URL: https://github.com/apache/hbase/pull/1847#issuecomment-638371496 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 6s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 2m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1847/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1847 | | Optional Tests | | | uname | Linux f96e998fab0c 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 8c9c670aaa | | Max. process+thread count | 51 (vs. ulimit of 12500) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1847/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME
Apache-HBase commented on pull request #1847: URL: https://github.com/apache/hbase/pull/1847#issuecomment-638371296 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 6s | Maven dependency ordering for patch | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? | | | | 2m 13s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1847/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1847 | | Optional Tests | dupname asflicense shellcheck shelldocs | | uname | Linux e6fc89e1a762 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 8c9c670aaa | | Max. process+thread count | 47 (vs. ulimit of 12500) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1847/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder
virajjasani commented on a change in pull request #1818:
URL: https://github.com/apache/hbase/pull/1818#discussion_r434758421
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ImmutableScan.java
##
@@ -0,0 +1,543 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.client;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Map;
+import java.util.NavigableSet;
+import org.apache.hadoop.hbase.exceptions.DeserializationException;
+import org.apache.hadoop.hbase.filter.Filter;
+import org.apache.hadoop.hbase.io.TimeRange;
+import org.apache.hadoop.hbase.security.access.Permission;
+import org.apache.hadoop.hbase.security.visibility.Authorizations;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Immutable version of Scan
+ */
+@InterfaceAudience.Private
+public final class ImmutableScan extends Scan {
+
+ private final Scan delegateScan;
+
+ /**
+ * Create Immutable instance of Scan from given Scan object
+ *
+ * @param scan Copy all values from Scan
+ * @throws IOException From parent constructor
+ */
+ public ImmutableScan(Scan scan) throws IOException {
Review comment:
Ohh, what a miss :(
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
