[GitHub] [hbase] Apache-HBase commented on pull request #1862: HBASE-24466 Release scripts in docker mode should be able to use a named volume for maven repo

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1862: URL: https://github.com/apache/hbase/pull/1862#issuecomment-639982995 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #1862: HBASE-24466 Release scripts in docker mode should be able to use a named volume for maven repo

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1862: URL: https://github.com/apache/hbase/pull/1862#issuecomment-639982792 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] busbey commented on pull request #1862: HBASE-24466 Release scripts in docker mode should be able to use a named volume for maven repo

2020-06-05 Thread GitBox
busbey commented on pull request #1862: URL: https://github.com/apache/hbase/pull/1862#issuecomment-639981765 good catch from shellcheck. should have been a -1. This is an automated message from the Apache Git Service. To

[GitHub] [hbase] Apache-HBase commented on pull request #1862: HBASE-24466 Release scripts in docker mode should be able to use a named volume for maven repo

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1862: URL: https://github.com/apache/hbase/pull/1862#issuecomment-639981444 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #1862: HBASE-24466 Release scripts in docker mode should be able to use a named volume for maven repo

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1862: URL: https://github.com/apache/hbase/pull/1862#issuecomment-639981309 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] busbey commented on pull request #1862: HBASE-24466 Release scripts in docker mode should be able to use a named volume for maven repo

2020-06-05 Thread GitBox
busbey commented on pull request #1862: URL: https://github.com/apache/hbase/pull/1862#issuecomment-639981159 as noted on jira, this only got like a ~15% improvement in the release candidate creation time. This is an

[GitHub] [hbase] busbey opened a new pull request #1862: HBASE-24466 Release scripts in docker mode should be able to use a named volume for maven repo

2020-06-05 Thread GitBox
busbey opened a new pull request #1862: URL: https://github.com/apache/hbase/pull/1862 * add an option to specify a docker volume to use for the local maven repo * if we are reusing a maven repo path then remove our package space when we start

[GitHub] [hbase] Apache-HBase commented on pull request #1861: HBASE-24511 Ability to configure timeout between RPC retry to RS from…

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1861: URL: https://github.com/apache/hbase/pull/1861#issuecomment-639969181 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bsglz commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-06-05 Thread GitBox
bsglz commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-639968883 @virajjasani @wchevreuil Could you help to review it, thanks. This is an automated message from the Apache Git

[GitHub] [hbase] bsglz commented on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-05 Thread GitBox
bsglz commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-639965667 The rest javadoc issues seems not related to this RP. @Apache9 Please take a look if you have time, thanks. This

[GitHub] [hbase] busbey commented on a change in pull request #1727: HBASE-17756 We should have better introspection of HFiles

2020-06-05 Thread GitBox
busbey commented on a change in pull request #1727: URL: https://github.com/apache/hbase/pull/1727#discussion_r436226259 ## File path: hbase-shaded/hbase-shaded-mapreduce/pom.xml ## @@ -164,6 +164,10 @@ javax.servlet.jsp javax.servlet.jsp-api

[GitHub] [hbase-native-client] bharathv commented on a change in pull request #3: HBASE-24400: Download folly, wangle, zookeeper, and protobuf

2020-06-05 Thread GitBox
bharathv commented on a change in pull request #3: URL: https://github.com/apache/hbase-native-client/pull/3#discussion_r436221065 ## File path: CMakeLists.txt ## @@ -25,15 +25,108 @@ set(PROJECT_VERSION_PATCH 0) set(BUILD_SHARED_LIBS ON) ## set our cmake module path

[GitHub] [hbase] Apache-HBase commented on pull request #1861: HBASE-24511 Ability to configure timeout between RPC retry to RS from…

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1861: URL: https://github.com/apache/hbase/pull/1861#issuecomment-639901300 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] sguggilam commented on pull request #1861: HBASE-24511 Ability to configure timeout between RPC retry to RS from…

2020-06-05 Thread GitBox
sguggilam commented on pull request #1861: URL: https://github.com/apache/hbase/pull/1861#issuecomment-639894308 Created a separate PR as per the suggestion in https://github.com/apache/hbase/pull/1828 @apurtell @virajjasani @Apache9 Please review

[GitHub] [hbase] Apache-HBase commented on pull request #1861: HBASE-24511 Ability to configure timeout between RPC retry to RS from…

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1861: URL: https://github.com/apache/hbase/pull/1861#issuecomment-639893691 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #251: URL: https://github.com/apache/hbase/pull/251#issuecomment-639852928 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s

[GitHub] [hbase] saintstack commented on pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas…

2020-06-05 Thread GitBox
saintstack commented on pull request #746: URL: https://github.com/apache/hbase/pull/746#issuecomment-639822431 @zhaoyim mind addressing the conflicts and the last comment by Duo? Thanks. This is an automated message from

[GitHub] [hbase] Apache-HBase commented on pull request #1860: HBASE-24380 : Provide WAL splitting journal logging

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1860: URL: https://github.com/apache/hbase/pull/1860#issuecomment-639820253 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on pull request #715: HBASE-22940 Fix snapshot NoNode error

2020-06-05 Thread GitBox
saintstack commented on pull request #715: URL: https://github.com/apache/hbase/pull/715#issuecomment-639820464 See comment above @wchevreuil This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache-HBase commented on pull request #1860: HBASE-24380 : Provide WAL splitting journal logging

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1860: URL: https://github.com/apache/hbase/pull/1860#issuecomment-639820724 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on pull request #662: HBASE-22942 move Snapshot verification to procedure

2020-06-05 Thread GitBox
saintstack commented on pull request #662: URL: https://github.com/apache/hbase/pull/662#issuecomment-639820150 Closing. No progress. Make a new PR if I have this wrong. Thanks. This is an automated message from the Apache

[GitHub] [hbase] saintstack closed pull request #662: HBASE-22942 move Snapshot verification to procedure

2020-06-05 Thread GitBox
saintstack closed pull request #662: URL: https://github.com/apache/hbase/pull/662 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] saintstack commented on pull request #571: HBASE-20821 Space Quota: Re-creating a dropped namespace and contained table inherits previously set space quota settings

2020-06-05 Thread GitBox
saintstack commented on pull request #571: URL: https://github.com/apache/hbase/pull/571#issuecomment-639817759 Closing. No progress. Make a new PR if I have this wrong. Thanks. This is an automated message from the Apache

[GitHub] [hbase] saintstack closed pull request #571: HBASE-20821 Space Quota: Re-creating a dropped namespace and contained table inherits previously set space quota settings

2020-06-05 Thread GitBox
saintstack closed pull request #571: URL: https://github.com/apache/hbase/pull/571 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] esteban commented on a change in pull request #1858: HBASE-24506 async client deadlock

2020-06-05 Thread GitBox
esteban commented on a change in pull request #1858: URL: https://github.com/apache/hbase/pull/1858#discussion_r436155356 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java ## @@ -253,52 +268,38 @@ public void operationComplete(Future

[GitHub] [hbase] esteban commented on a change in pull request #1858: HBASE-24506 async client deadlock

2020-06-05 Thread GitBox
esteban commented on a change in pull request #1858: URL: https://github.com/apache/hbase/pull/1858#discussion_r436153301 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java ## @@ -146,45 +163,43 @@ private void established(Channel ch)

[GitHub] [hbase] esteban commented on a change in pull request #1858: HBASE-24506 async client deadlock

2020-06-05 Thread GitBox
esteban commented on a change in pull request #1858: URL: https://github.com/apache/hbase/pull/1858#discussion_r436153505 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java ## @@ -253,52 +268,38 @@ public void operationComplete(Future

[GitHub] [hbase] esteban commented on a change in pull request #1858: HBASE-24506 async client deadlock

2020-06-05 Thread GitBox
esteban commented on a change in pull request #1858: URL: https://github.com/apache/hbase/pull/1858#discussion_r436153126 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java ## @@ -146,45 +163,43 @@ private void established(Channel ch)

[jira] [Commented] (HBASE-24499) Use a client property for SaslConnection MAX_ATTEMPTS (currently hardcoded to 5)

2020-06-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127077#comment-17127077 ] Hudson commented on HBASE-24499: Results for branch branch-1.4 [build #1228 on

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-06-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127075#comment-17127075 ] Hudson commented on HBASE-11288: Results for branch HBASE-11288.splittable-meta [build #4 on

[GitHub] [hbase] Apache-HBase commented on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-639781243 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1861: HBASE-24511 Ability to configure timeout between RPC retry to RS from…

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1861: URL: https://github.com/apache/hbase/pull/1861#issuecomment-639779326 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] bharathv commented on a change in pull request #1858: HBASE-24506 async client deadlock

2020-06-05 Thread GitBox
bharathv commented on a change in pull request #1858: URL: https://github.com/apache/hbase/pull/1858#discussion_r436123009 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java ## @@ -73,40 +73,53 @@ private static final Logger LOG =

[GitHub] [hbase] sguggilam opened a new pull request #1861: HBASE-24511 Ability to configure timeout between RPC retry to RS from…

2020-06-05 Thread GitBox
sguggilam opened a new pull request #1861: URL: https://github.com/apache/hbase/pull/1861 … master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] Apache-HBase commented on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-639742148 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-639729329 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Comment Edited] (HBASE-24482) [hbase-operator-tools] build of hbck2 fails with HBase branch-2.3, due to missing dependencies

2020-06-05 Thread Matthew Foley (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127022#comment-17127022 ] Matthew Foley edited comment on HBASE-24482 at 6/5/20, 7:13 PM: As an

[jira] [Comment Edited] (HBASE-24482) [hbase-operator-tools] build of hbck2 fails with HBase branch-2.3, due to missing dependencies

2020-06-05 Thread Matthew Foley (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127022#comment-17127022 ] Matthew Foley edited comment on HBASE-24482 at 6/5/20, 7:11 PM: As an

[GitHub] [hbase] Apache-HBase commented on pull request #1782: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1782: URL: https://github.com/apache/hbase/pull/1782#issuecomment-639726872 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Comment Edited] (HBASE-24482) [hbase-operator-tools] build of hbck2 fails with HBase branch-2.3, due to missing dependencies

2020-06-05 Thread Matthew Foley (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127022#comment-17127022 ] Matthew Foley edited comment on HBASE-24482 at 6/5/20, 7:10 PM: As an

[jira] [Commented] (HBASE-24482) [hbase-operator-tools] build of hbck2 fails with HBase branch-2.3, due to missing dependencies

2020-06-05 Thread Matthew Foley (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127022#comment-17127022 ] Matthew Foley commented on HBASE-24482: --- As an experiment, I changed 

[jira] [Updated] (HBASE-24482) [hbase-operator-tools] build of hbck2 fails with HBase branch-2.3, due to missing dependencies

2020-06-05 Thread Matthew Foley (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew Foley updated HBASE-24482: -- Attachment: HBASE-24482_missing_symbols_part_2.log > [hbase-operator-tools] build of hbck2

[jira] [Updated] (HBASE-24482) [hbase-operator-tools] build of hbck2 fails with HBase branch-2.3, due to missing dependencies

2020-06-05 Thread Matthew Foley (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew Foley updated HBASE-24482: -- Description: If we do a local build of the current HBase branch-2.3 as version

[GitHub] [hbase] Apache-HBase commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1844: URL: https://github.com/apache/hbase/pull/1844#issuecomment-639721510 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-24482) [hbase-operator-tools] build of hbck2 fails with HBase branch-2.3, due to missing dependencies

2020-06-05 Thread Matthew Foley (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew Foley updated HBASE-24482: -- Summary: [hbase-operator-tools] build of hbck2 fails with HBase branch-2.3, due to missing

[GitHub] [hbase] Apache-HBase commented on pull request #1860: HBASE-24380 : Provide WAL splitting journal logging

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1860: URL: https://github.com/apache/hbase/pull/1860#issuecomment-639716940 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1844: URL: https://github.com/apache/hbase/pull/1844#issuecomment-639708973 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1859: HBASE-24510 Remove HBaseTestCase amd GenericTestUtils

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1859: URL: https://github.com/apache/hbase/pull/1859#issuecomment-639705912 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1844: URL: https://github.com/apache/hbase/pull/1844#issuecomment-639705935 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1743: HBASE-24403 FsDelegationToken Should Cache Token After Acquired A New One

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-639696005 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1859: HBASE-24510 Remove HBaseTestCase amd GenericTestUtils

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1859: URL: https://github.com/apache/hbase/pull/1859#issuecomment-639692342 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-24380) Improve WAL splitting log lines to enable sessionization

2020-06-05 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24380: - Status: Patch Available (was: Open) > Improve WAL splitting log lines to enable sessionization

[GitHub] [hbase] sguggilam closed pull request #1828: HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-05 Thread GitBox
sguggilam closed pull request #1828: URL: https://github.com/apache/hbase/pull/1828 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #1749: HBASE-24367 ScheduledChore log elapsed timespan in a human-friendly format

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1749: URL: https://github.com/apache/hbase/pull/1749#issuecomment-639687343 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1749: HBASE-24367 ScheduledChore log elapsed timespan in a human-friendly format

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1749: URL: https://github.com/apache/hbase/pull/1749#issuecomment-639686175 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1749: HBASE-24367 ScheduledChore log elapsed timespan in a human-friendly format

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1749: URL: https://github.com/apache/hbase/pull/1749#issuecomment-639681763 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] virajjasani opened a new pull request #1860: HBASE-24380 : Provide WAL splitting journal logging

2020-06-05 Thread GitBox
virajjasani opened a new pull request #1860: URL: https://github.com/apache/hbase/pull/1860 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase] Apache-HBase commented on pull request #1830: HBASE-24491 Remove HRegionInfo

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1830: URL: https://github.com/apache/hbase/pull/1830#issuecomment-639671522 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] ndimiduk commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-05 Thread GitBox
ndimiduk commented on pull request #1844: URL: https://github.com/apache/hbase/pull/1844#issuecomment-639667285 @busbey > the intro paragraph explains the warning sign designation but it is not used at all Oh you're right. Since I pulled out the non-LTS releases, that

[GitHub] [hbase] busbey commented on a change in pull request #1858: HBASE-24506 async client deadlock

2020-06-05 Thread GitBox
busbey commented on a change in pull request #1858: URL: https://github.com/apache/hbase/pull/1858#discussion_r436074273 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java ## @@ -146,45 +163,43 @@ private void established(Channel ch)

[jira] [Commented] (HBASE-24507) Remove HTableDescriptor and HColumnDescriptor

2020-06-05 Thread Geoffrey Jacoby (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126979#comment-17126979 ] Geoffrey Jacoby commented on HBASE-24507: - I understand that HTableDescriptor and

[GitHub] [hbase] Apache-HBase commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-639664953 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-24506) async client deadlock

2020-06-05 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-24506: Affects Version/s: 2.4.0 2.3.0 3.0.0-alpha-1

[jira] [Updated] (HBASE-24506) async client deadlock

2020-06-05 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-24506: Fix Version/s: 2.2.6 2.3.0 3.0.0-alpha-1 > async client

[jira] [Updated] (HBASE-24506) async client deadlock

2020-06-05 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-24506: Priority: Blocker (was: Critical) > async client deadlock > - > >

[GitHub] [hbase] Apache-HBase commented on pull request #1782: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1782: URL: https://github.com/apache/hbase/pull/1782#issuecomment-639655822 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] sguggilam commented on a change in pull request #1828: HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-05 Thread GitBox
sguggilam commented on a change in pull request #1828: URL: https://github.com/apache/hbase/pull/1828#discussion_r436061999 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java ## @@ -233,13 +233,19 @@ public void run()

[jira] [Commented] (HBASE-24511) Ability to configure timeout between RPC retry to RS from master

2020-06-05 Thread Sandeep Guggilam (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126966#comment-17126966 ] Sandeep Guggilam commented on HBASE-24511: -- [~apurtell] FYI > Ability to configure timeout

[jira] [Created] (HBASE-24511) Ability to configure timeout between RPC retry to RS from master

2020-06-05 Thread Sandeep Guggilam (Jira)
Sandeep Guggilam created HBASE-24511: Summary: Ability to configure timeout between RPC retry to RS from master Key: HBASE-24511 URL: https://issues.apache.org/jira/browse/HBASE-24511 Project:

[GitHub] [hbase] apurtell commented on pull request #1749: HBASE-24367 ScheduledChore log elapsed timespan in a human-friendly format

2020-06-05 Thread GitBox
apurtell commented on pull request #1749: URL: https://github.com/apache/hbase/pull/1749#issuecomment-639649279 Push just now addresses review feedback and fixes the checkstyle warning. This is an automated message from the

[GitHub] [hbase] Apache-HBase commented on pull request #1743: HBASE-24403 FsDelegationToken Should Cache Token After Acquired A New One

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-639649558 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24380) Improve WAL splitting log lines to enable sessionization

2020-06-05 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126961#comment-17126961 ] Viraj Jasani commented on HBASE-24380: -- Sure, let me take it up. > Improve WAL splitting log lines

[jira] [Assigned] (HBASE-24380) Improve WAL splitting log lines to enable sessionization

2020-06-05 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HBASE-24380: Assignee: Viraj Jasani > Improve WAL splitting log lines to enable sessionization >

[jira] [Commented] (HBASE-24446) Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-05 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126960#comment-17126960 ] Viraj Jasani commented on HBASE-24446: -- Sure, will take care of this in future. Thanks > Use

[GitHub] [hbase] apurtell commented on pull request #1749: HBASE-24367 ScheduledChore log elapsed timespan in a human-friendly format

2020-06-05 Thread GitBox
apurtell commented on pull request #1749: URL: https://github.com/apache/hbase/pull/1749#issuecomment-639643519 No new patch yet. Sorry, have been away doing other things. Apologies for the noise after rebase. This is an

[jira] [Comment Edited] (HBASE-24380) Improve WAL splitting log lines to enable sessionization

2020-06-05 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126958#comment-17126958 ] Andrew Kyle Purtell edited comment on HBASE-24380 at 6/5/20, 5:14 PM:

[jira] [Commented] (HBASE-24380) Improve WAL splitting log lines to enable sessionization

2020-06-05 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126958#comment-17126958 ] Andrew Kyle Purtell commented on HBASE-24380: - {quote}Maybe we can also pass MonitorTask

[GitHub] [hbase] apurtell commented on a change in pull request #1828: HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-05 Thread GitBox
apurtell commented on a change in pull request #1828: URL: https://github.com/apache/hbase/pull/1828#discussion_r436053515 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java ## @@ -233,13 +233,19 @@ public void run() {

[GitHub] [hbase] apurtell commented on pull request #1835: HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-05 Thread GitBox
apurtell commented on pull request #1835: URL: https://github.com/apache/hbase/pull/1835#issuecomment-639639087 Belated +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (HBASE-24446) Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-05 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126954#comment-17126954 ] Andrew Kyle Purtell commented on HBASE-24446: - So this has only been committed to branch-1?

[GitHub] [hbase] Apache-HBase commented on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-639636121 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] busbey commented on a change in pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-06-05 Thread GitBox
busbey commented on a change in pull request #1814: URL: https://github.com/apache/hbase/pull/1814#discussion_r436044150 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -1727,6 +1727,16 @@ possible configurations would overwhelm and obscure the

[GitHub] [hbase] mmpataki commented on a change in pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-06-05 Thread GitBox
mmpataki commented on a change in pull request #1814: URL: https://github.com/apache/hbase/pull/1814#discussion_r436029458 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -1727,6 +1727,16 @@ possible configurations would overwhelm and obscure the

[GitHub] [hbase] Apache-HBase commented on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-639613406 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1859: HBASE-24510 Remove HBaseTestCase amd GenericTestUtils

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1859: URL: https://github.com/apache/hbase/pull/1859#issuecomment-639611038 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-639610817 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] mmpataki commented on a change in pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-06-05 Thread GitBox
mmpataki commented on a change in pull request #1814: URL: https://github.com/apache/hbase/pull/1814#discussion_r436029458 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -1727,6 +1727,16 @@ possible configurations would overwhelm and obscure the

[GitHub] [hbase] Apache-HBase commented on pull request #1830: HBASE-24491 Remove HRegionInfo

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1830: URL: https://github.com/apache/hbase/pull/1830#issuecomment-639609587 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] sguggilam commented on a change in pull request #1828: HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-05 Thread GitBox
sguggilam commented on a change in pull request #1828: URL: https://github.com/apache/hbase/pull/1828#discussion_r436018339 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java ## @@ -233,13 +233,19 @@ public void run()

[jira] [Commented] (HBASE-24505) Reimplement Hbck.setRegionStateInMeta

2020-06-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126910#comment-17126910 ] Hudson commented on HBASE-24505: Results for branch master [build #1748 on

[jira] [Commented] (HBASE-24359) Optionally ignore edits for deleted CFs for replication.

2020-06-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126907#comment-17126907 ] Hudson commented on HBASE-24359: Results for branch master [build #1748 on

[jira] [Commented] (HBASE-24504) refactor call setupCluster/tearDownCluster in TestTableSnapshotInputFormat

2020-06-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126911#comment-17126911 ] Hudson commented on HBASE-24504: Results for branch master [build #1748 on

[jira] [Commented] (HBASE-24458) release scripts using docker should specify needed disk consistency

2020-06-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126909#comment-17126909 ] Hudson commented on HBASE-24458: Results for branch master [build #1748 on

[jira] [Commented] (HBASE-24456) Immutable Scan as unmodifiable subclass or wrapper of Scan

2020-06-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126908#comment-17126908 ] Hudson commented on HBASE-24456: Results for branch master [build #1748 on

[jira] [Commented] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange

2020-06-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126912#comment-17126912 ] Hudson commented on HBASE-24500: Results for branch master [build #1748 on

[GitHub] [hbase] sguggilam commented on a change in pull request #1828: HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-05 Thread GitBox
sguggilam commented on a change in pull request #1828: URL: https://github.com/apache/hbase/pull/1828#discussion_r436014652 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java ## @@ -233,13 +233,19 @@ public void run()

[jira] [Updated] (HBASE-24510) Remove HBaseTestCase amd GenericTestUtils

2020-06-05 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24510: -- Summary: Remove HBaseTestCase amd GenericTestUtils (was: Remove HBaseTestCase) > Remove

[jira] [Comment Edited] (HBASE-24245) Failed to write replication wal position

2020-06-05 Thread Alex Batyrshin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126892#comment-17126892 ] Alex Batyrshin edited comment on HBASE-24245 at 6/5/20, 3:44 PM: - Looks

[jira] [Updated] (HBASE-24510) Remove HBaseTestCase amd GenericTestUtils

2020-06-05 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24510: -- Description: It is still a junit3 style test base, let's remove it. GenericTestUtils is also

[GitHub] [hbase] Apache-HBase commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-05 Thread GitBox
Apache-HBase commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-639586775 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

  1   2   3   >