[GitHub] [hbase] Apache-HBase commented on pull request #2167: HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableRelativePath method
Apache-HBase commented on pull request #2167: URL: https://github.com/apache/hbase/pull/2167#issuecomment-667838016 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 50s | master passed | | +1 :green_heart: | compile | 0m 27s | master passed | | +1 :green_heart: | shadedjars | 5m 59s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 19s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 39s | the patch passed | | +1 :green_heart: | compile | 0m 26s | the patch passed | | +1 :green_heart: | javac | 0m 26s | the patch passed | | +1 :green_heart: | shadedjars | 5m 30s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 18s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 10m 33s | hbase-mapreduce in the patch passed. | | | | 33m 17s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2167/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2167 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 16248f5deec7 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9a1bad84bf | | Default Java | 1.8.0_232 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2167/4/testReport/ | | Max. process+thread count | 4751 (vs. ulimit of 12500) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2167/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2167: HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableRelativePath method
Apache-HBase commented on pull request #2167: URL: https://github.com/apache/hbase/pull/2167#issuecomment-667837704 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 13s | master passed | | +1 :green_heart: | compile | 0m 28s | master passed | | +1 :green_heart: | shadedjars | 5m 47s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 23s | hbase-mapreduce in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 3s | the patch passed | | +1 :green_heart: | compile | 0m 28s | the patch passed | | +1 :green_heart: | javac | 0m 28s | the patch passed | | +1 :green_heart: | shadedjars | 5m 48s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 20s | hbase-mapreduce in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 9m 16s | hbase-mapreduce in the patch passed. | | | | 32m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2167/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2167 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 7d6c473a9149 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9a1bad84bf | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2167/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2167/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2167/4/testReport/ | | Max. process+thread count | 4874 (vs. ulimit of 12500) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2167/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-24704) Make the Table Schema easier to view even there are multiple families
[ https://issues.apache.org/jira/browse/HBASE-24704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang updated HBASE-24704: --- Release Note: Improve the layout of column family from vertical to horizontal in table UI. > Make the Table Schema easier to view even there are multiple families > - > > Key: HBASE-24704 > URL: https://issues.apache.org/jira/browse/HBASE-24704 > Project: HBase > Issue Type: Improvement > Components: UI >Reporter: Zheng Wang >Assignee: Zheng Wang >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.1, 1.7.0, 2.4.0 > > Attachments: HBASE-24704-beforepatch.png, > HBASE-24704-branch1-afterpatch.png, HBASE-24704-branch2-afterpatch.png, > HBASE-24704-master-afterpatch.png > > > Currently we display the column family as vertical, it is not easy to view, > my proposal is to display them as horizontal. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] utf7 commented on a change in pull request #2167: HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableRelativePath method
utf7 commented on a change in pull request #2167: URL: https://github.com/apache/hbase/pull/2167#discussion_r464209802 ## File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java ## @@ -376,16 +369,15 @@ private WriterLength getNewWriter(byte[] tableName, byte[] family, Configuration DataBlockEncoding encoding = overriddenEncoding; encoding = encoding == null ? datablockEncodingMap.get(tableAndFamily) : encoding; encoding = encoding == null ? DataBlockEncoding.NONE : encoding; -HFileContextBuilder contextBuilder = new HFileContextBuilder() - .withCompression(compression).withChecksumType(HStore.getChecksumType(conf)) - .withBytesPerCheckSum(HStore.getBytesPerChecksum(conf)).withBlockSize(blockSize) - .withColumnFamily(family).withTableName(tableName); +HFileContextBuilder contextBuilder = new HFileContextBuilder().withCompression(compression) Review comment: i move the compression set config to here and has been use hbase-eclipse-format format the code here This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] utf7 commented on a change in pull request #2167: HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableRelativePath method
utf7 commented on a change in pull request #2167:
URL: https://github.com/apache/hbase/pull/2167#discussion_r464207581
##
File path:
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java
##
@@ -222,6 +222,7 @@ public RegionLocator getRegionLocator() {
private final Map writers = new
TreeMap<>(Bytes.BYTES_COMPARATOR);
private final Map previousRows = new
TreeMap<>(Bytes.BYTES_COMPARATOR);
private final long now = EnvironmentEdgeManager.currentTime();
+ private byte[] tableNameBytes = Bytes.toBytes(writeTableNames);
Review comment:
yes，i want to make code simple, so just keep init no matter multiple or
not
It is a good ponit to use use writeMultipleTables check,will address it
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (HBASE-20717) Implement CCSMap - a better concurrent map with compacted data structure
[ https://issues.apache.org/jira/browse/HBASE-20717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Li reassigned HBASE-20717: - Assignee: Reid Chan (was: Chance Li) Thanks for taking over the task [~reidchan], I'm reassigning this to you. Could you create the sub-tasks according to the plan and link the PRs relatively? Thanks. > Implement CCSMap - a better concurrent map with compacted data structure > > > Key: HBASE-20717 > URL: https://issues.apache.org/jira/browse/HBASE-20717 > Project: HBase > Issue Type: Sub-task >Reporter: Yu Li >Assignee: Reid Chan >Priority: Major > > As described in HBASE-20312, we will implement the base data structure of > CCSMap and relative unit tests in this task. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24211) Create table is slow in large cluster when AccessController is enabled.
[
https://issues.apache.org/jira/browse/HBASE-24211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mohammad Arshad updated HBASE-24211:
Component/s: Performance
> Create table is slow in large cluster when AccessController is enabled.
> ---
>
> Key: HBASE-24211
> URL: https://issues.apache.org/jira/browse/HBASE-24211
> Project: HBase
> Issue Type: Bug
> Components: Performance
>Affects Versions: 1.3.6, master, 2.2.4
>Reporter: Mohammad Arshad
>Assignee: Mohammad Arshad
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0, 1.7.0
>
>
> *Problem:*
> In HBase 1.3.x large, performance test, cluster (100 RS, 60k tables, 600k
> regions) a simple table creation takes around 150 seconds. The time taken
> varies but still takes lot of time.
> *Analysis:*
> 1. When HBase creates a table , it calls AssignmentManager#assign(final
> ServerName destination, final List regions)
> In AssignmentManager#assign，it calls asyncSetOfflineInZooKeeper(state, cb,
> destination), and waits in below code loop for 2 minutes.
> {code:java}
> if (useZKForAssignment) {
> // Wait until all unassigned nodes have been put up and watchers
> set.
> int total = states.size();
> for (int oldCounter = 0; !server.isStopped();) {
> int count = counter.get();
> if (oldCounter != count) {
> LOG.debug(destination.toString() + " unassigned znodes=" +
> count +
> " of total=" + total + "; oldCounter=" + oldCounter);
> oldCounter = count;
> }
> if (count >= total) break;
> Thread.sleep(5);
> }
> }
> {code}
> 2. asyncSetOfflineInZooKeeper creates a znode under
> /hbase/region-in-transition/ and calls exist to ensure that znode is created.
> This is simple operation should not take much time. Then where the time it
> taken!!!
> 3. ZooKeeper client API process watcher notification and async API response
> through a queue one by one.
> If there is a delay in any watcher/response processing by the client, in
> this case HBase, all other response processing is delayed. Then it appears as
> if API call has taken more time.
> Same thing happen in this issue.
> Watcher processing for znode creation under /hbase/acl took most of the time
> and delayed /hbase/region-in-transition/region znode creation processing.
> This is why wait in loop was too long.
> 4. Watcher processing for znode creation under hbase/acl/ calls
> ZKPermissionWatcher#nodeChildrenChanged, which internally calls
> ZKUtil.getChildDataAndWatchForNewChildren
> *which calls ZooKeeper's getData API, in this use case, 60k times which
> takes most of the time.*
> *Solutions:*
> Move getChildDataAndWatchForNewChildren call into the async code block in
> ZKPermissionWatcher#nodeChildrenChanged.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-21721) reduce write#syncs() times
[
https://issues.apache.org/jira/browse/HBASE-21721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anoop Sam John updated HBASE-21721:
---
Fix Version/s: 2.2.6
2.4.0
1.7.0
2.3.1
3.0.0-alpha-1
> reduce write#syncs() times
> --
>
> Key: HBASE-21721
> URL: https://issues.apache.org/jira/browse/HBASE-21721
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.3.1, 2.1.1, master, 2.2.3
>Reporter: Bo Cui
>Assignee: Bo Cui
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.1, 1.7.0, 2.4.0, 2.2.6
>
>
> the number of write#syncs can be reduced by updating the
> highestUnsyncedSequence：
> before write#sync(), get the current highestUnsyncedSequence
> after write#sync, highestSyncedSequence=highestUnsyncedSequence
>
> {code:title=FSHLog.java|borderStyle=solid}
> // Some comments here
> public void run()
> {
> long currentSequence;
> while (!isInterrupted()) {
> int syncCount = 0;
> try {
> while (true) {
> ...
> try {
> Trace.addTimelineAnnotation("syncing writer");
> long unSyncedFlushSeq = highestUnsyncedSequence;
> writer.sync();
> Trace.addTimelineAnnotation("writer synced");
> if( unSyncedFlushSeq > currentSequence ) currentSequence =
> unSyncedFlushSeq;
> currentSequence = updateHighestSyncedSequence(currentSequence);
> } catch (IOException e) {
> LOG.error("Error syncing, request close of WAL", e);
> lastException = e;
> } catch (Exception e) {
>...
> }
> }
> {code}
> Add code
> long unSyncedFlushSeq = highestUnsyncedSequence;
> if( unSyncedFlushSeq > currentSequence ) currentSequence = unSyncedFlushSeq;
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HBASE-21721) reduce write#syncs() times
[
https://issues.apache.org/jira/browse/HBASE-21721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anoop Sam John reassigned HBASE-21721:
--
Assignee: Bo Cui
> reduce write#syncs() times
> --
>
> Key: HBASE-21721
> URL: https://issues.apache.org/jira/browse/HBASE-21721
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.3.1, 2.1.1, master, 2.2.3
>Reporter: Bo Cui
>Assignee: Bo Cui
>Priority: Major
>
> the number of write#syncs can be reduced by updating the
> highestUnsyncedSequence：
> before write#sync(), get the current highestUnsyncedSequence
> after write#sync, highestSyncedSequence=highestUnsyncedSequence
>
> {code:title=FSHLog.java|borderStyle=solid}
> // Some comments here
> public void run()
> {
> long currentSequence;
> while (!isInterrupted()) {
> int syncCount = 0;
> try {
> while (true) {
> ...
> try {
> Trace.addTimelineAnnotation("syncing writer");
> long unSyncedFlushSeq = highestUnsyncedSequence;
> writer.sync();
> Trace.addTimelineAnnotation("writer synced");
> if( unSyncedFlushSeq > currentSequence ) currentSequence =
> unSyncedFlushSeq;
> currentSequence = updateHighestSyncedSequence(currentSequence);
> } catch (IOException e) {
> LOG.error("Error syncing, request close of WAL", e);
> lastException = e;
> } catch (Exception e) {
>...
> }
> }
> {code}
> Add code
> long unSyncedFlushSeq = highestUnsyncedSequence;
> if( unSyncedFlushSeq > currentSequence ) currentSequence = unSyncedFlushSeq;
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24713) RS startup with FSHLog throws NPE after HBASE-21751
[
https://issues.apache.org/jira/browse/HBASE-24713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169726#comment-17169726
]
Anoop Sam John commented on HBASE-24713:
branch-2?
> RS startup with FSHLog throws NPE after HBASE-21751
> ---
>
> Key: HBASE-24713
> URL: https://issues.apache.org/jira/browse/HBASE-24713
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 2.1.6
>Reporter: ramkrishna.s.vasudevan
>Assignee: Gaurav Kanade
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.1, 2.2.6
>
>
> Every RS startup creates this NPE
> {code}
> [sync.1] wal.FSHLog: UNEXPECTED
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.regionserver.wal.FSHLog$SyncRunner.run(FSHLog.java:582)
> at java.lang.Thread.run(Thread.java:748)
> 2020-07-07 10:51:23,208 WARN [regionserver/x:16020] wal.FSHLog: Failed
> sync-before-close but no outstanding appends; closing
> WALjava.lang.NullPointerException
> {code}
> the reason is that the Disruptor frameworks starts the Syncrunner thread but
> the init of the writer happens after that. A simple null check in the
> Syncrunner will help here .
> No major damage happens though since we handle Throwable Exception. It will
> good to solve this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24805) HBaseTestingUtility.getConnection should be threadsafe
[
https://issues.apache.org/jira/browse/HBASE-24805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169719#comment-17169719
]
Hudson commented on HBASE-24805:
Results for branch branch-2
[build #2766 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2766/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2766/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2756/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2742/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2765/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> HBaseTestingUtility.getConnection should be threadsafe
> --
>
> Key: HBASE-24805
> URL: https://issues.apache.org/jira/browse/HBASE-24805
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
>
> the current javadoc for getConnection carries a thread safety warning:
> {code}
> /**
> * Get a Connection to the cluster. Not thread-safe (This class needs a
> lot of work to make it
> * thread-safe).
> * @return A Connection that can be shared. Don't close. Will be closed on
> shutdown of cluster.
> */
>public Connection getConnection() throws IOException {
> {code}
> We then ignore that warning across our test base. We should make the method
> threadsafe since the intention is to share a single Connection across all
> users of the HTU instance.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-24326) Removal from streamReaders can be done in finally
[ https://issues.apache.org/jira/browse/HBASE-24326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan resolved HBASE-24326. Resolution: Won't Fix Since branch 2.1 is EOLed closing this JIRA as won't fix. > Removal from streamReaders can be done in finally > - > > Key: HBASE-24326 > URL: https://issues.apache.org/jira/browse/HBASE-24326 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 2.1.6 >Reporter: ramkrishna.s.vasudevan >Assignee: Sambit Mohapatra >Priority: Major > Fix For: 2.1.10 > > > As part of the fix for https://issues.apache.org/jira/browse/HBASE-21551 we > removed the storeReaders from the set inside the try block. > The code there seems to catch IOException. But if you drill down and see how > the actual readers are closed - FSDataInputStreamWrapper#close() uses > IOUtils.closeQuietly where we swallow the IOException (So ideally IOException > will not be thrown). But there are cases we endup getting other type of > RuntimeExceptions which may fail the close() and we endup not removing the > storeReader from the Set. So it is safe to always remove it in finally. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24704) Make the Table Schema easier to view even there are multiple families
[
https://issues.apache.org/jira/browse/HBASE-24704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169720#comment-17169720
]
Hudson commented on HBASE-24704:
Results for branch branch-2
[build #2766 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2766/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2766/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2756/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2742/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2765/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Make the Table Schema easier to view even there are multiple families
> -
>
> Key: HBASE-24704
> URL: https://issues.apache.org/jira/browse/HBASE-24704
> Project: HBase
> Issue Type: Improvement
> Components: UI
>Reporter: Zheng Wang
>Assignee: Zheng Wang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.1, 1.7.0, 2.4.0
>
> Attachments: HBASE-24704-beforepatch.png,
> HBASE-24704-branch1-afterpatch.png, HBASE-24704-branch2-afterpatch.png,
> HBASE-24704-master-afterpatch.png
>
>
> Currently we display the column family as vertical, it is not easy to view,
> my proposal is to display them as horizontal.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-24713) RS startup with FSHLog throws NPE after HBASE-21751
[
https://issues.apache.org/jira/browse/HBASE-24713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan resolved HBASE-24713.
Fix Version/s: 2.2.6
2.3.1
3.0.0-alpha-1
Hadoop Flags: Reviewed
Resolution: Fixed
Pushed to branch-2.2, branch-2.3 and master. Thanks for all the reviews.
> RS startup with FSHLog throws NPE after HBASE-21751
> ---
>
> Key: HBASE-24713
> URL: https://issues.apache.org/jira/browse/HBASE-24713
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 2.1.6
>Reporter: ramkrishna.s.vasudevan
>Assignee: Gaurav Kanade
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.1, 2.2.6
>
>
> Every RS startup creates this NPE
> {code}
> [sync.1] wal.FSHLog: UNEXPECTED
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.regionserver.wal.FSHLog$SyncRunner.run(FSHLog.java:582)
> at java.lang.Thread.run(Thread.java:748)
> 2020-07-07 10:51:23,208 WARN [regionserver/x:16020] wal.FSHLog: Failed
> sync-before-close but no outstanding appends; closing
> WALjava.lang.NullPointerException
> {code}
> the reason is that the Disruptor frameworks starts the Syncrunner thread but
> the init of the writer happens after that. A simple null check in the
> Syncrunner will help here .
> No major damage happens though since we handle Throwable Exception. It will
> good to solve this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] ramkrish86 merged pull request #2133: Cherry pick HBASE-24713 RS startup with FSHLog throws NPE after HBASE-21751
ramkrish86 merged pull request #2133: URL: https://github.com/apache/hbase/pull/2133 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ramkrish86 merged pull request #2134: Cherry pick HBASE-24713 RS startup with FSHLog throws NPE after HBASE-21751
ramkrish86 merged pull request #2134: URL: https://github.com/apache/hbase/pull/2134 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ramkrish86 merged pull request #2125: HBASE-24713 RS startup with FSHLog throws NPE after HBASE-21751
ramkrish86 merged pull request #2125: URL: https://github.com/apache/hbase/pull/2125 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ramkrish86 commented on pull request #2125: HBASE-24713 RS startup with FSHLog throws NPE after HBASE-21751
ramkrish86 commented on pull request #2125: URL: https://github.com/apache/hbase/pull/2125#issuecomment-667796627 Test case failure is unrelated to this fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24800) Enhance ACL region initialization
[
https://issues.apache.org/jira/browse/HBASE-24800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169698#comment-17169698
]
Anoop Sam John commented on HBASE-24800:
60K table? !
So here zk level call, optimization is proposed. I have 2 other aspects to
mention.
- We use zk as a way to notify all RSs to update their cache of the table
permission details when the ACL table is updated. But we end up writing all ACL
table detail into zk also. With these many tables like cases, its lot of data
in the zk. Should we think of a way where we can just inform about the ACL
content change to RSs and each RS read the latest changed content from ACL
region in order to update its cache? This read can be time range based if every
RS track the latest TS of its local ACL cache content.
- Per RS we keep the ACL detail cached in RS. How big this is growing in ur
cases with these many tables? Per RS you might have regions from so many tables
also right? Even for the local cache we need some cap for the heap usage?
> Enhance ACL region initialization
> -
>
> Key: HBASE-24800
> URL: https://issues.apache.org/jira/browse/HBASE-24800
> Project: HBase
> Issue Type: Improvement
> Components: acl, MTTR
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Major
>
> RegionServer persist ACL table entries into Zookeeper during ACL region open,
> {code}
> private void initialize(RegionCoprocessorEnvironment e) throws
> IOException {
> final Region region = e.getRegion();
> Configuration conf = e.getConfiguration();
> Map> tables =
> PermissionStorage.loadAll(region);
> // For each table, write out the table's permissions to the respective
> // znode for that table.
> for (Map.Entry> t:
> tables.entrySet()) {
> byte[] entry = t.getKey();
> ListMultimap perms = t.getValue();
> byte[] serialized = PermissionStorage.writePermissionsAsBytes(perms,
> conf);
> zkPermissionWatcher.writeToZookeeper(entry, serialized);
> }
> initialized = true;
> }
> {code}
> Currently RegionServer send 2 RPC (one to create the table path and another
> to set the data) for each table sequentially.
> {code}
> try {
> ZKUtil.createWithParents(watcher, zkNode);
> ZKUtil.updateExistingNodeData(watcher, zkNode, permsData, -1);
> } catch (KeeperException e) {
> LOG.error("Failed updating permissions for entry '" +
> entryName + "'", e);
> watcher.abort("Failed writing node "+zkNode+" to zookeeper", e);
> }
> {code}
> If a cluster have huge number of tables then ACL region open will take time.
> Example, it took ~9 min to write 60k tables ACL into ZK.
> We should send ZK Ops in a single multi() to enhance this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] busbey opened a new pull request #2188: HBASE-24805 HBaseTestingUtility.getConnection should be threadsafe (branch-1)
busbey opened a new pull request #2188: URL: https://github.com/apache/hbase/pull/2188 * refactor how we use connection to rely on the access method * refactor initialization and cleanup of the shared connection * incompatibly change HCTU's Configuration member variable to be final so it can be safely accessed from multiple threads. Closes #2180 adapted for jdk7 (cherry picked from commit 86ebbdd8a2df89de37c2c3bd50e64292eaf28b11) (cherry picked from commit 0806349adab338330428c900588234d7f6fcfcc2) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] anoopsjohn commented on a change in pull request #2167: HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableRelativePath method
anoopsjohn commented on a change in pull request #2167:
URL: https://github.com/apache/hbase/pull/2167#discussion_r464174854
##
File path:
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java
##
@@ -222,6 +222,7 @@ public RegionLocator getRegionLocator() {
private final Map writers = new
TreeMap<>(Bytes.BYTES_COMPARATOR);
private final Map previousRows = new
TreeMap<>(Bytes.BYTES_COMPARATOR);
private final long now = EnvironmentEdgeManager.currentTime();
+ private byte[] tableNameBytes = Bytes.toBytes(writeTableNames);
Review comment:
Should we do this under writeMultipleTables check?
private byte[] tableNameBytes = (writeMultipleTables)? null:
Bytes.toBytes(writeTableNames);
##
File path:
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java
##
@@ -274,39 +270,36 @@ public void write(ImmutableBytesWritable row, V cell)
throws IOException {
// create a new WAL writer, if necessary
if (wl == null || wl.writer == null) {
+ InetSocketAddress[] favoredNodes = null;
if (conf.getBoolean(LOCALITY_SENSITIVE_CONF_KEY,
DEFAULT_LOCALITY_SENSITIVE)) {
HRegionLocation loc = null;
-
+String tableName = Bytes.toString(tableNameBytes);
if (tableName != null) {
try (Connection connection =
ConnectionFactory.createConnection(conf);
- RegionLocator locator =
-
connection.getRegionLocator(TableName.valueOf(tableName))) {
+RegionLocator locator =
connection.getRegionLocator(TableName.valueOf(tableName))) {
loc = locator.getRegionLocation(rowKey);
} catch (Throwable e) {
-LOG.warn("Something wrong locating rowkey {} in {}",
- Bytes.toString(rowKey), tableName, e);
+LOG.warn("Something wrong locating rowkey {} in {}",
Bytes.toString(rowKey),
+ tableName, e);
loc = null;
- } }
-
+ }
+}
Review comment:
Here also.
##
File path:
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java
##
@@ -274,39 +270,36 @@ public void write(ImmutableBytesWritable row, V cell)
throws IOException {
// create a new WAL writer, if necessary
if (wl == null || wl.writer == null) {
+ InetSocketAddress[] favoredNodes = null;
if (conf.getBoolean(LOCALITY_SENSITIVE_CONF_KEY,
DEFAULT_LOCALITY_SENSITIVE)) {
HRegionLocation loc = null;
-
+String tableName = Bytes.toString(tableNameBytes);
Review comment:
Looks like a format issue here?
##
File path:
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java
##
@@ -376,16 +369,15 @@ private WriterLength getNewWriter(byte[] tableName,
byte[] family, Configuration
DataBlockEncoding encoding = overriddenEncoding;
encoding = encoding == null ? datablockEncodingMap.get(tableAndFamily)
: encoding;
encoding = encoding == null ? DataBlockEncoding.NONE : encoding;
-HFileContextBuilder contextBuilder = new HFileContextBuilder()
-
.withCompression(compression).withChecksumType(HStore.getChecksumType(conf))
-
.withBytesPerCheckSum(HStore.getBytesPerChecksum(conf)).withBlockSize(blockSize)
- .withColumnFamily(family).withTableName(tableName);
+HFileContextBuilder contextBuilder = new
HFileContextBuilder().withCompression(compression)
Review comment:
Pls check format issue at these changed/added lines once.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] WenFeiYi opened a new pull request #2187: HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll
WenFeiYi opened a new pull request #2187: URL: https://github.com/apache/hbase/pull/2187 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] WenFeiYi closed pull request #2157: HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll
WenFeiYi closed pull request #2157: URL: https://github.com/apache/hbase/pull/2157 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] utf7 commented on pull request #2167: HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableRelativePath method
utf7 commented on pull request #2167: URL: https://github.com/apache/hbase/pull/2167#issuecomment-667767166 The code hash finished , mind have a look, thanks @anoopsjohn @pankaj72981 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24704) Make the Table Schema easier to view even there are multiple families
[ https://issues.apache.org/jira/browse/HBASE-24704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169669#comment-17169669 ] Zheng Wang commented on HBASE-24704: Thanks a lot. [~vjasani] > Make the Table Schema easier to view even there are multiple families > - > > Key: HBASE-24704 > URL: https://issues.apache.org/jira/browse/HBASE-24704 > Project: HBase > Issue Type: Improvement > Components: UI >Reporter: Zheng Wang >Assignee: Zheng Wang >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.1, 1.7.0, 2.4.0 > > Attachments: HBASE-24704-beforepatch.png, > HBASE-24704-branch1-afterpatch.png, HBASE-24704-branch2-afterpatch.png, > HBASE-24704-master-afterpatch.png > > > Currently we display the column family as vertical, it is not easy to view, > my proposal is to display them as horizontal. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 commented on a change in pull request #2186: HBAE-24507 Remove HTableDescriptor and HColumnDescriptor
Apache9 commented on a change in pull request #2186:
URL: https://github.com/apache/hbase/pull/2186#discussion_r464155114
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
##
@@ -41,10 +41,17 @@
/**
* Utilities for adding/removing constraints from a table.
*
+<<< HEAD
* Since {@link TableDescriptor} is immutable now, you should use {@link
TableDescriptorBuilder}.
* And when disabling or removing constraints, you could use
* {@link TableDescriptorBuilder#newBuilder(TableDescriptor)} to clone the old
* {@link TableDescriptor} and then pass it the below methods.
+===
+ * Constraints can be added on table load time, via the {@link
HTableDescriptor}.
+ *
+ * NOTE: this class is NOT thread safe. Concurrent setting/enabling/disabling
of
+ * constraints can cause constraints to be run at incorrect times or not at
all.
+>>> 210f1e7388... tmp
Review comment:
Let me check.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase-native-client] phrocker commented on a change in pull request #12: HBASE-24810: Download Boost with other dependencies
phrocker commented on a change in pull request #12:
URL: https://github.com/apache/hbase-native-client/pull/12#discussion_r464141390
##
File path: cmake/DownloadBoost.cmake
##
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+## Download Boost.
+## SOURCE_DIR is typically the cmake source directory
+## BINARY_DIR is the build directory, typically 'build'
+## Sets BOOST_ROOT, search prefix for FindBoost.
+
+function(download_boost SOURCE_DIR BUILD_DIR BOOST_LIBS)
+ set(BOOST_DOWNLOAD_DIR "${BUILD_DIR}/dependencies/boost-download")
+ set(BOOST_SOURCE_DIR "${BUILD_DIR}/dependencies/boost-src")
+ set(BOOST_INSTALL_DIR "${BUILD_DIR}/dependencies/boost-install")
+
+ # Only compile and install the needed libs.
+ set(LIBS_TO_COMPILE "")
+ foreach(lib ${BOOST_LIBS})
+string(APPEND LIBS_TO_COMPILE --with-${lib} " ")
+ endforeach()
+
+ separate_arguments(BUILD_CMD UNIX_COMMAND "./b2 ${LIBS_TO_COMPILE} install")
+
+ ExternalProject_Add(boost
+ URL
"https://dl.bintray.com/boostorg/release/1.65.1/source/boost_1_65_1.tar.gz";
Review comment:
Does this build a static lib?
##
File path: cmake/boost/local/FindBoost.cmake
##
@@ -0,0 +1,36 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Stubs to allow us to find Boost libs
+
+set(Boost_INCLUDE_DIRS "${BOOST_ROOT}/include" CACHE STRING "" FORCE)
+set(Boost_INCLUDE_DIR "${BOOST_ROOT}/include" CACHE STRING "" FORCE)
+
+set(Boost_LIBRARIES "" CACHE STRING "" FORCE)
+foreach(COMPONENT ${Boost_FIND_COMPONENTS})
+ list(APPEND Boost_LIBRARIES
"${BOOST_ROOT}/lib/${BYPRODUCT_PREFIX}boost_${COMPONENT}${BYPRODUCT_SHARED_SUFFIX}")
Review comment:
Given BYPRODUCT_SHARED_SUFFIX, will the install ensure these shared
objects are available for the distributed binary?
##
File path: cmake/DownloadBoost.cmake
##
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+## Download Boost.
+## SOURCE_DIR is typically the cmake source directory
+## BINARY_DIR is the build directory, typically 'build'
+## Sets BOOST_ROOT, search prefix for FindBoost.
+
+function(download_boost SOURCE_DIR BUILD_DIR BOOST_LIBS)
+ set(BOOST_DOWNLOAD_DIR "${BUILD_DIR}/dependencies/boost-download")
+ set(BOOST_SOURCE_DIR "${BUILD_DIR}/dependencies/boost-src")
+ set(BOOST_INSTALL_DIR "${BUILD_DIR}/dependencies/boost-install")
+
+ # Only compile and install the needed libs.
+ set(LIBS_TO_COMPILE "")
+ foreach(lib ${BOOST_LIBS})
+string(APPEND LIBS_TO_COMPILE --with-${lib} " ")
+ endforeach()
+
+ separate_arguments(BUILD_CMD UNIX_COMMAND "./b2 ${LIBS_TO_COMPILE} install")
+
+ ExternalProject_Add(boost
Review comment:
Does this significantly add to the build t
[GitHub] [hbase-native-client] bharathv merged pull request #13: HBASE-24642 (addendum): Do not run the container as root
bharathv merged pull request #13: URL: https://github.com/apache/hbase-native-client/pull/13 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-native-client] Apache-HBase commented on pull request #13: HBASE-24642 (addendum): Do not run the container as root
Apache-HBase commented on pull request #13: URL: https://github.com/apache/hbase-native-client/pull/13#issuecomment-667739938 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 701 | Docker mode activated. | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 | CMakeLists.txt | 1063 | master passed | ||| _ Patch Compile Tests _ | | +1 | CMakeLists.txt | 284 | the patch passed | ||| _ Other Tests _ | | | | 2063 | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-13/1/artifact/hbase-native-client-precommit/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-native-client/pull/13 | | Optional Tests | | | uname | Linux securecluster 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | cmake | | Personality | bin/hbase-native-client-personality.sh | | git revision | master / 7281fc6 | | Max. process+thread count | 76 (vs. ulimit of 1000) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-13/1/console | | versions | git=2.7.4 cmake=cmake version 3.5.1 make=GNU Make 4.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-native-client] Apache-HBase commented on pull request #13: HBASE-24642 (addendum): Do not run the container as root
Apache-HBase commented on pull request #13: URL: https://github.com/apache/hbase-native-client/pull/13#issuecomment-667735956 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-13/1/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-native-client] bharathv opened a new pull request #13: HBASE-24642 (addendum): Do not run the container as root
bharathv opened a new pull request #13: URL: https://github.com/apache/hbase-native-client/pull/13 This pollutes the permissions of output artifacts thus affecting the final cleanup. This can potentially fill up disks on jenkins machines. Also adds some additional debugging information related to the env. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on a change in pull request #2186: HBAE-24507 Remove HTableDescriptor and HColumnDescriptor
saintstack commented on a change in pull request #2186:
URL: https://github.com/apache/hbase/pull/2186#discussion_r464127581
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
##
@@ -73,8 +80,19 @@ private Constraints() {
/**
* Enable constraints on a table.
*
+<<< HEAD
* Currently, if you attempt to add a constraint to the table, then
Constraints will automatically
* be turned on.
+===
+ * Currently, if you attempt to add a constraint to the table, then
+ * Constraints will automatically be turned on.
+ *
+ * @param desc
+ * table description to add the processor
+ * @throws IOException
+ * If the {@link ConstraintProcessor} CP couldn't be added to the
+ * table.
+>>> 210f1e7388... tmp
Review comment:
Ditto
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
##
@@ -41,10 +41,17 @@
/**
* Utilities for adding/removing constraints from a table.
*
+<<< HEAD
* Since {@link TableDescriptor} is immutable now, you should use {@link
TableDescriptorBuilder}.
* And when disabling or removing constraints, you could use
* {@link TableDescriptorBuilder#newBuilder(TableDescriptor)} to clone the old
* {@link TableDescriptor} and then pass it the below methods.
+===
+ * Constraints can be added on table load time, via the {@link
HTableDescriptor}.
+ *
+ * NOTE: this class is NOT thread safe. Concurrent setting/enabling/disabling
of
+ * constraints can cause constraints to be run at incorrect times or not at
all.
+>>> 210f1e7388... tmp
Review comment:
Fix?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase-native-client] Apache-HBase commented on pull request #12: HBASE-24810: Download Boost with other dependencies
Apache-HBase commented on pull request #12: URL: https://github.com/apache/hbase-native-client/pull/12#issuecomment-667726794 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 317 | Docker mode activated. | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | -1 | CMakeLists.txt | 1057 | root in master failed. | | -1 | compile | 6 | root in master failed. | ||| _ Patch Compile Tests _ | | +1 | CMakeLists.txt | 281 | the patch passed | | -1 | compile | 581 | root in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 21 | root in the patch failed. | | | | 2281 | | | Reason | Tests | |---:|:--| | Failed CTEST tests | exception-test | | | scan-test | | | request-converter-test | | | async-rpc-retrying-test | | | scanner-test | | | location-cache-test | | | rpc-test | | | client-deserializer-test | | | increment-test | | | delete-test | | | location-cache-retry-test | | | zk-util-test | | | bytes-util-test | | | server-name-test | | | concurrent-map-test | | | get-test | | | user-util-test | | | cell-test | | | table-name-test | | | configuration-test | | | region-info-deserializer-test | | | hbase-configuration-test | | | zk-deserializer-test | | | client-test | | | async-batch-rpc-retrying-test | | | scan-result-cache-test | | | put-test | | | connection-pool-test | | | append-test | | | time-range-test | | | client-serializer-test | | | result-test | | | filter-test | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-12/2/artifact/hbase-native-client-precommit/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-native-client/pull/12 | | JIRA Issue | HBASE-24810 | | Optional Tests | compile unit | | uname | Linux securecluster 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | cmake | | Personality | bin/hbase-native-client-personality.sh | | git revision | master / 7281fc6 | | CMakeLists.txt | https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-12/2/artifact/hbase-native-client-precommit/output/branch-CMakeLists.txt-root.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-12/2/artifact/hbase-native-client-precommit/output/branch-compile-root.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-12/2/artifact/hbase-native-client-precommit/output/patch-compile-root.txt | | CTEST | https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-12/2/artifact/hbase-native-client-precommit/output/patch-root-ctest.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-12/2/artifact/hbase-native-client-precommit/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-12/2/testReport/ | | Max. process+thread count | 75 (vs. ulimit of 1000) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-12/2/console | | versions | git=2.7.4 cmake=cmake version 3.5.1 make=GNU Make 4.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-native-client] Apache-HBase commented on pull request #12: HBASE-24810: Download Boost with other dependencies
Apache-HBase commented on pull request #12: URL: https://github.com/apache/hbase-native-client/pull/12#issuecomment-667723037 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-12/2/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-native-client] Apache-HBase commented on pull request #12: HBASE-24810: Download Boost with other dependencies
Apache-HBase commented on pull request #12: URL: https://github.com/apache/hbase-native-client/pull/12#issuecomment-667721416 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 932 | Docker mode activated. | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | -1 | CMakeLists.txt | 1056 | root in master failed. | | -1 | compile | 6 | root in master failed. | ||| _ Patch Compile Tests _ | | +1 | CMakeLists.txt | 291 | the patch passed | | -1 | compile | 340 | root in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 20 | root in the patch failed. | | | | 2661 | | | Reason | Tests | |---:|:--| | Failed CTEST tests | location-cache-test | | | filter-test | | | async-rpc-retrying-test | | | location-cache-retry-test | | | hbase-configuration-test | | | table-name-test | | | delete-test | | | client-test | | | client-serializer-test | | | scan-test | | | request-converter-test | | | concurrent-map-test | | | zk-util-test | | | result-test | | | exception-test | | | user-util-test | | | server-name-test | | | zk-deserializer-test | | | get-test | | | put-test | | | configuration-test | | | increment-test | | | cell-test | | | connection-pool-test | | | append-test | | | bytes-util-test | | | scanner-test | | | time-range-test | | | scan-result-cache-test | | | client-deserializer-test | | | rpc-test | | | region-info-deserializer-test | | | async-batch-rpc-retrying-test | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-12/1/artifact/hbase-native-client-precommit/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-native-client/pull/12 | | JIRA Issue | HBASE-24810 | | Optional Tests | compile unit | | uname | Linux securecluster 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | cmake | | Personality | bin/hbase-native-client-personality.sh | | git revision | master / 7281fc6 | | CMakeLists.txt | https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-12/1/artifact/hbase-native-client-precommit/output/branch-CMakeLists.txt-root.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-12/1/artifact/hbase-native-client-precommit/output/branch-compile-root.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-12/1/artifact/hbase-native-client-precommit/output/patch-compile-root.txt | | CTEST | https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-12/1/artifact/hbase-native-client-precommit/output/patch-root-ctest.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-12/1/artifact/hbase-native-client-precommit/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-12/1/testReport/ | | Max. process+thread count | 111 (vs. ulimit of 1000) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-12/1/console | | versions | git=2.7.4 cmake=cmake version 3.5.1 make=GNU Make 4.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-native-client] Apache-HBase commented on pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly
Apache-HBase commented on pull request #6: URL: https://github.com/apache/hbase-native-client/pull/6#issuecomment-667720871 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 961 | Docker mode activated. | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | -1 | CMakeLists.txt | 1055 | root in master failed. | | -1 | compile | 4 | root in master failed. | ||| _ Patch Compile Tests _ | | +1 | CMakeLists.txt | 291 | the patch passed | | -1 | compile | 36 | root in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 5 | root in the patch failed. | | | | 2371 | | | Reason | Tests | |---:|:--| | Failed CTEST tests | location-cache-test | | | filter-test | | | async-rpc-retrying-test | | | location-cache-retry-test | | | hbase-configuration-test | | | table-name-test | | | delete-test | | | client-test | | | client-serializer-test | | | scan-test | | | request-converter-test | | | concurrent-map-test | | | zk-util-test | | | result-test | | | exception-test | | | user-util-test | | | server-name-test | | | zk-deserializer-test | | | get-test | | | put-test | | | configuration-test | | | increment-test | | | cell-test | | | connection-pool-test | | | append-test | | | bytes-util-test | | | scanner-test | | | time-range-test | | | scan-result-cache-test | | | client-deserializer-test | | | rpc-test | | | region-info-deserializer-test | | | async-batch-rpc-retrying-test | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/1/artifact/hbase-native-client-precommit/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-native-client/pull/6 | | JIRA Issue | HBASE-23105 | | Optional Tests | compile unit | | uname | Linux securecluster 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | cmake | | Personality | bin/hbase-native-client-personality.sh | | git revision | master / 7281fc6 | | CMakeLists.txt | https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/1/artifact/hbase-native-client-precommit/output/branch-CMakeLists.txt-root.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/1/artifact/hbase-native-client-precommit/output/branch-compile-root.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/1/artifact/hbase-native-client-precommit/output/patch-compile-root.txt | | CTEST | https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/1/artifact/hbase-native-client-precommit/output/patch-root-ctest.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/1/artifact/hbase-native-client-precommit/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/1/testReport/ | | Max. process+thread count | 76 (vs. ulimit of 1000) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/1/console | | versions | git=2.7.4 cmake=cmake version 3.5.1 make=GNU Make 4.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24704) Make the Table Schema easier to view even there are multiple families
[ https://issues.apache.org/jira/browse/HBASE-24704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169630#comment-17169630 ] Viraj Jasani commented on HBASE-24704: -- Thanks [~filtertip], merged changes to master, branch-2, branch-2.3, branch-1. > Make the Table Schema easier to view even there are multiple families > - > > Key: HBASE-24704 > URL: https://issues.apache.org/jira/browse/HBASE-24704 > Project: HBase > Issue Type: Improvement > Components: UI >Reporter: Zheng Wang >Assignee: Zheng Wang >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.1, 1.7.0, 2.4.0 > > Attachments: HBASE-24704-beforepatch.png, > HBASE-24704-branch1-afterpatch.png, HBASE-24704-branch2-afterpatch.png, > HBASE-24704-master-afterpatch.png > > > Currently we display the column family as vertical, it is not easy to view, > my proposal is to display them as horizontal. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169628#comment-17169628 ] Lars Hofhansl commented on HBASE-24742: --- Re: Tests. This is purely an internal optimization of another optimization (no kidding) with no functional impact. For the SEEK optimization we have tests that assert the number of SEEKs vs SKIPs during scanning. I cannot think of any useful additional tests. Lemme perhaps check if there are SEEK vs SKIP tests with ROWCOL BFs enabled. Or [~bharathv], could you also perhaps have a look as I'm off the next few weeks. > Improve performance of SKIP vs SEEK logic > - > > Key: HBASE-24742 > URL: https://issues.apache.org/jira/browse/HBASE-24742 > Project: HBase > Issue Type: Bug > Components: Performance, regionserver >Affects Versions: 3.0.0-alpha-1, 1.7.0, 2.4.0 >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.1, 1.7.0, 2.4.0, 2.1.10, 2.2.6 > > Attachments: 24742-master.txt, hbase-1.6-regression-flame-graph.png, > hbase-24742-branch-1.txt > > > In our testing of HBase 1.3 against the current tip of branch-1 we saw a 30% > slowdown in scanning scenarios. > We tracked it back to HBASE-17958 and HBASE-19863. > Both add comparisons to one of the tightest HBase has. > [~bharathv] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase-native-client] Apache-HBase commented on pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly
Apache-HBase commented on pull request #6: URL: https://github.com/apache/hbase-native-client/pull/6#issuecomment-667716818 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-6/1/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-native-client] Apache-HBase commented on pull request #12: HBASE-24810: Download Boost with other dependencies
Apache-HBase commented on pull request #12: URL: https://github.com/apache/hbase-native-client/pull/12#issuecomment-667716817 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job/HBase/job/hbase-native-client-github-precommit/job/PR-12/1/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2186: HBAE-24507 Remove HTableDescriptor and HColumnDescriptor
Apache-HBase commented on pull request #2186: URL: https://github.com/apache/hbase/pull/2186#issuecomment-667715730 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 25s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 11s | master passed | | +1 :green_heart: | compile | 4m 38s | master passed | | +1 :green_heart: | shadedjars | 6m 50s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 19s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 10s | the patch passed | | +1 :green_heart: | compile | 4m 37s | the patch passed | | +1 :green_heart: | javac | 4m 37s | the patch passed | | +1 :green_heart: | shadedjars | 6m 36s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 41s | hbase-server generated 4 new + 28 unchanged - 0 fixed = 32 total (was 28) | | -0 :warning: | javadoc | 0m 19s | hbase-mapreduce generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 6s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 190m 25s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 15m 3s | hbase-mapreduce in the patch passed. | | +1 :green_heart: | unit | 4m 53s | hbase-thrift in the patch passed. | | -1 :x: | unit | 3m 56s | hbase-endpoint in the patch failed. | | +1 :green_heart: | unit | 12m 52s | hbase-backup in the patch passed. | | +1 :green_heart: | unit | 1m 37s | hbase-it in the patch passed. | | +1 :green_heart: | unit | 5m 31s | hbase-rest in the patch passed. | | +1 :green_heart: | unit | 1m 35s | hbase-shaded-client-project in the patch passed. | | | | 280m 59s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2186 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 87332078a44c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 86ebbdd8a2 | | Default Java | 1.8.0_232 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-mapreduce.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-endpoint.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/testReport/ | | Max. process+thread count | 5084 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-archetypes/hbase-shaded-client-project U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2186: HBAE-24507 Remove HTableDescriptor and HColumnDescriptor
Apache-HBase commented on pull request #2186: URL: https://github.com/apache/hbase/pull/2186#issuecomment-667709470 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 45s | master passed | | +1 :green_heart: | compile | 5m 0s | master passed | | +1 :green_heart: | shadedjars | 5m 46s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 18s | hbase-shaded-client-project in master failed. | | -0 :warning: | javadoc | 0m 20s | hbase-backup in master failed. | | -0 :warning: | javadoc | 0m 25s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 20s | hbase-mapreduce in master failed. | | -0 :warning: | javadoc | 0m 21s | hbase-rest in master failed. | | -0 :warning: | javadoc | 0m 39s | hbase-server in master failed. | | -0 :warning: | javadoc | 0m 50s | hbase-thrift in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 57s | the patch passed | | +1 :green_heart: | compile | 4m 39s | the patch passed | | +1 :green_heart: | javac | 4m 39s | the patch passed | | +1 :green_heart: | shadedjars | 5m 44s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 25s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 21s | hbase-mapreduce in the patch failed. | | -0 :warning: | javadoc | 0m 51s | hbase-thrift in the patch failed. | | -0 :warning: | javadoc | 0m 20s | hbase-backup in the patch failed. | | -0 :warning: | javadoc | 0m 20s | hbase-rest in the patch failed. | | -0 :warning: | javadoc | 0m 16s | hbase-shaded-client-project in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 7s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 137m 25s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 11m 5s | hbase-mapreduce in the patch passed. | | +1 :green_heart: | unit | 4m 51s | hbase-thrift in the patch passed. | | -1 :x: | unit | 3m 14s | hbase-endpoint in the patch failed. | | +1 :green_heart: | unit | 11m 33s | hbase-backup in the patch passed. | | +1 :green_heart: | unit | 1m 12s | hbase-it in the patch passed. | | +1 :green_heart: | unit | 3m 20s | hbase-rest in the patch passed. | | +1 :green_heart: | unit | 1m 8s | hbase-shaded-client-project in the patch passed. | | | | 220m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2186 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux cab1bf237c00 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 86ebbdd8a2 | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-archetypes_hbase-shaded-client-project.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-backup.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-jdk
[jira] [Resolved] (HBASE-24704) Make the Table Schema easier to view even there are multiple families
[ https://issues.apache.org/jira/browse/HBASE-24704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-24704. -- Fix Version/s: 2.4.0 1.7.0 2.3.1 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed > Make the Table Schema easier to view even there are multiple families > - > > Key: HBASE-24704 > URL: https://issues.apache.org/jira/browse/HBASE-24704 > Project: HBase > Issue Type: Improvement > Components: UI >Reporter: Zheng Wang >Assignee: Zheng Wang >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.1, 1.7.0, 2.4.0 > > Attachments: HBASE-24704-beforepatch.png, > HBASE-24704-branch1-afterpatch.png, HBASE-24704-branch2-afterpatch.png, > HBASE-24704-master-afterpatch.png > > > Currently we display the column family as vertical, it is not easy to view, > my proposal is to display them as horizontal. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] virajjasani closed pull request #2185: HBASE-24704 Make the Table Schema easier to view even there are multi…
virajjasani closed pull request #2185: URL: https://github.com/apache/hbase/pull/2185 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani closed pull request #2182: HBASE-24704 Make the Table Schema easier to view even there are multi…
virajjasani closed pull request #2182: URL: https://github.com/apache/hbase/pull/2182 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani closed pull request #2042: HBASE-24704 Make the Table Schema easier to view even there are multi…
virajjasani closed pull request #2042: URL: https://github.com/apache/hbase/pull/2042 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-native-client] bharathv commented on pull request #12: HBASE-24810: Download Boost with other dependencies
bharathv commented on pull request #12: URL: https://github.com/apache/hbase-native-client/pull/12#issuecomment-667697757 Looks like a g++ crash due to memory issue, especially after my last change that does a multi-threaded make. Let me try bumping up the docker mem limit. `g++: internal compiler error: Killed (program cc1plus) Please submit a full bug report, with preprocessed source if appropriate. See for instructions. Makefile:1965: recipe for target 'experimental/JSONSchema.lo' failed` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-native-client] Apache-HBase commented on pull request #12: HBASE-24810: Download Boost with other dependencies
Apache-HBase commented on pull request #12: URL: https://github.com/apache/hbase-native-client/pull/12#issuecomment-667696954 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 315 | Docker mode activated. | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | -1 | CMakeLists.txt | 1060 | root in master failed. | | -1 | compile | 6 | root in master failed. | ||| _ Patch Compile Tests _ | | +1 | CMakeLists.txt | 278 | the patch passed | | -1 | compile | 361 | root in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 31 | root in the patch failed. | | | | 2069 | | | Reason | Tests | |---:|:--| | Failed CTEST tests | hbase-configuration-test | | | server-name-test | | | client-deserializer-test | | | location-cache-test | | | concurrent-map-test | | | rpc-test | | | scanner-test | | | cell-test | | | result-test | | | connection-pool-test | | | scan-result-cache-test | | | location-cache-retry-test | | | append-test | | | zk-util-test | | | get-test | | | user-util-test | | | region-info-deserializer-test | | | time-range-test | | | bytes-util-test | | | client-serializer-test | | | async-rpc-retrying-test | | | scan-test | | | put-test | | | configuration-test | | | request-converter-test | | | client-test | | | table-name-test | | | filter-test | | | increment-test | | | delete-test | | | async-batch-rpc-retrying-test | | | zk-deserializer-test | | | exception-test | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-12/1/artifact/hbase-native-client-precommit/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-native-client/pull/12 | | JIRA Issue | HBASE-24810 | | Optional Tests | compile unit | | uname | Linux securecluster 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | cmake | | Personality | bin/hbase-native-client-personality.sh | | git revision | master / 7281fc6 | | CMakeLists.txt | https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-12/1/artifact/hbase-native-client-precommit/output/branch-CMakeLists.txt-root.txt | | compile | https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-12/1/artifact/hbase-native-client-precommit/output/branch-compile-root.txt | | compile | https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-12/1/artifact/hbase-native-client-precommit/output/patch-compile-root.txt | | CTEST | https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-12/1/artifact/hbase-native-client-precommit/output/patch-root-ctest.txt | | unit | https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-12/1/artifact/hbase-native-client-precommit/output/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-12/1/testReport/ | | Max. process+thread count | 111 (vs. ulimit of 1000) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-12/1/console | | versions | git=2.7.4 cmake=cmake version 3.5.1 make=GNU Make 4.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-native-client] Apache-HBase commented on pull request #12: HBASE-24810: Download Boost with other dependencies
Apache-HBase commented on pull request #12: URL: https://github.com/apache/hbase-native-client/pull/12#issuecomment-667692988 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/hbase-native-client-github-precommit/job/PR-12/1/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-native-client] bharathv commented on pull request #12: HBASE-24810: Download Boost with other dependencies
bharathv commented on pull request #12: URL: https://github.com/apache/hbase-native-client/pull/12#issuecomment-667692999 @joshelser @phrocker FYI With this change, all the tests pass for me locally since the boost dependency issue is fixed. Lets see what the precommit has to say. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-native-client] bharathv opened a new pull request #12: HBASE-24810: Download Boost with other dependencies
bharathv opened a new pull request #12: URL: https://github.com/apache/hbase-native-client/pull/12 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2186: HBAE-24507 Remove HTableDescriptor and HColumnDescriptor
Apache-HBase commented on pull request #2186: URL: https://github.com/apache/hbase/pull/2186#issuecomment-667692113 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 44s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 16s | master passed | | +1 :green_heart: | checkstyle | 4m 20s | master passed | | +1 :green_heart: | spotbugs | 8m 45s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 22s | the patch passed | | -0 :warning: | checkstyle | 0m 33s | hbase-client: The patch generated 1 new + 76 unchanged - 70 fixed = 77 total (was 146) | | -0 :warning: | checkstyle | 1m 32s | hbase-server: The patch generated 7 new + 766 unchanged - 105 fixed = 773 total (was 871) | | +1 :green_heart: | checkstyle | 0m 20s | hbase-mapreduce: The patch generated 0 new + 63 unchanged - 2 fixed = 63 total (was 65) | | +1 :green_heart: | checkstyle | 0m 48s | hbase-thrift: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | +1 :green_heart: | checkstyle | 0m 14s | The patch passed checkstyle in hbase-endpoint | | +1 :green_heart: | checkstyle | 0m 16s | hbase-backup: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | +1 :green_heart: | checkstyle | 0m 20s | The patch passed checkstyle in hbase-it | | +1 :green_heart: | checkstyle | 0m 17s | hbase-rest: The patch generated 0 new + 1 unchanged - 4 fixed = 1 total (was 5) | | +1 :green_heart: | checkstyle | 0m 12s | The patch passed checkstyle in hbase-shaded-client-project | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 14m 13s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 10m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 38s | The patch does not generate ASF License warnings. | | | | 66m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2186 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux eb3184272009 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 86ebbdd8a2 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-archetypes/hbase-shaded-client-project U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2186/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-24810) Download Boost when DOWNLOAD_DEPENDENCIES flag is set
[
https://issues.apache.org/jira/browse/HBASE-24810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bharath Vissapragada updated HBASE-24810:
-
Labels: client native (was: )
> Download Boost when DOWNLOAD_DEPENDENCIES flag is set
> -
>
> Key: HBASE-24810
> URL: https://issues.apache.org/jira/browse/HBASE-24810
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Affects Versions: master
>Reporter: Bharath Vissapragada
>Assignee: Bharath Vissapragada
>Priority: Major
> Labels: client, native
>
> HBASE-24539 added a boost dependency on {{dll:program_location}} that is
> 1_61_0+. However the default boost installed by various package managers
> across linux distros is different. For ex: the docker that builds on top of
> ubuntu-16.04 pulls in 1_5x_x version of boost dev and that broke the build.
> The ask is to bring boost under DOWNLOAD_DEPENDENCIES flag so that we can
> standardize across versions easily.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HBASE-24810) Download Boost when DOWNLOAD_DEPENDENCIES flag is set
Bharath Vissapragada created HBASE-24810:
Summary: Download Boost when DOWNLOAD_DEPENDENCIES flag is set
Key: HBASE-24810
URL: https://issues.apache.org/jira/browse/HBASE-24810
Project: HBase
Issue Type: Sub-task
Components: build
Affects Versions: master
Reporter: Bharath Vissapragada
Assignee: Bharath Vissapragada
HBASE-24539 added a boost dependency on {{dll:program_location}} that is
1_61_0+. However the default boost installed by various package managers across
linux distros is different. For ex: the docker that builds on top of
ubuntu-16.04 pulls in 1_5x_x version of boost dev and that broke the build. The
ask is to bring boost under DOWNLOAD_DEPENDENCIES flag so that we can
standardize across versions easily.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] virajjasani commented on pull request #2180: HBASE-24805 HBaseTestingUtility.getConnection should be threadsafe
virajjasani commented on pull request #2180: URL: https://github.com/apache/hbase/pull/2180#issuecomment-667686708 > I do not know why the precommit job on ci-hadoop ran multiple jobs for this PR, but in run number 2 this was the failure @busbey this was my doing, I did it for the same reason on test failure i.e "could not figure out if the test failure was relevant as per stdout and stderr" and hence thought of triggering another build. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 opened a new pull request #2186: HBAE-24507 Remove HTableDescriptor and HColumnDescriptor
Apache9 opened a new pull request #2186: URL: https://github.com/apache/hbase/pull/2186 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2184: HBASE-24680 Refactor the checkAndMutate code on the server side
Apache-HBase commented on pull request #2184: URL: https://github.com/apache/hbase/pull/2184#issuecomment-667673862 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 38s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 53s | branch-2 passed | | +1 :green_heart: | checkstyle | 2m 29s | branch-2 passed | | +1 :green_heart: | spotbugs | 4m 30s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 31s | the patch passed | | +1 :green_heart: | checkstyle | 0m 10s | The patch passed checkstyle in hbase-hadoop-compat | | +1 :green_heart: | checkstyle | 0m 12s | The patch passed checkstyle in hbase-hadoop2-compat | | +1 :green_heart: | checkstyle | 0m 36s | The patch passed checkstyle in hbase-client | | +1 :green_heart: | checkstyle | 1m 16s | hbase-server: The patch generated 0 new + 428 unchanged - 22 fixed = 428 total (was 450) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 54s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 4m 31s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 50s | The patch does not generate ASF License warnings. | | | | 44m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2184/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2184 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux e876845d42da 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 0806349ada | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-hadoop-compat hbase-hadoop2-compat hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2184/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24805) HBaseTestingUtility.getConnection should be threadsafe
[
https://issues.apache.org/jira/browse/HBASE-24805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169536#comment-17169536
]
Hudson commented on HBASE-24805:
Results for branch master
[build #1801 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1801/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1801/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1801/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1801/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1801//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> HBaseTestingUtility.getConnection should be threadsafe
> --
>
> Key: HBASE-24805
> URL: https://issues.apache.org/jira/browse/HBASE-24805
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
>
> the current javadoc for getConnection carries a thread safety warning:
> {code}
> /**
> * Get a Connection to the cluster. Not thread-safe (This class needs a
> lot of work to make it
> * thread-safe).
> * @return A Connection that can be shared. Don't close. Will be closed on
> shutdown of cluster.
> */
>public Connection getConnection() throws IOException {
> {code}
> We then ignore that warning across our test base. We should make the method
> threadsafe since the intention is to share a single Connection across all
> users of the HTU instance.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24695) FSHLog - close the current WAL file in a background thread
[
https://issues.apache.org/jira/browse/HBASE-24695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169532#comment-17169532
]
Hudson commented on HBASE-24695:
Results for branch master
[build #1801 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1801/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1801/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1801/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1801/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1801//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> FSHLog - close the current WAL file in a background thread
> --
>
> Key: HBASE-24695
> URL: https://issues.apache.org/jira/browse/HBASE-24695
> Project: HBase
> Issue Type: Improvement
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.4.0
>
>
> We have this as a TODO in code already
> {code}
> // It is at the safe point. Swap out writer from under the blocked writer
> thread.
> // TODO: This is close is inline with critical section. Should happen
> in background?
> if (this.writer != null) {
> oldFileLen = this.writer.getLength();
> try {
> TraceUtil.addTimelineAnnotation("closing writer");
> this.writer.close();
> TraceUtil.addTimelineAnnotation("writer closed");
> this.closeErrorCount.set(0);
> }
> {code}
> This close call in critical section and writes are blocked. Lets move this
> close call into another WALCloser thread.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24680) Refactor the checkAndMutate code on the server side
[
https://issues.apache.org/jira/browse/HBASE-24680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169533#comment-17169533
]
Hudson commented on HBASE-24680:
Results for branch master
[build #1801 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1801/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1801/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1801/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1801/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1801//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Refactor the checkAndMutate code on the server side
> ---
>
> Key: HBASE-24680
> URL: https://issues.apache.org/jira/browse/HBASE-24680
> Project: HBase
> Issue Type: Sub-task
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.4.0
>
>
> Refactor the checkAndMutate code on the server side by using the
> CheckAndMutate class (introduced in HBASE-8458) and the CheckAndMutateResult
> class (introduced in HBASE-24650).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24476) release scripts should provide timing information
[
https://issues.apache.org/jira/browse/HBASE-24476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169535#comment-17169535
]
Hudson commented on HBASE-24476:
Results for branch master
[build #1801 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1801/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1801/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1801/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1801/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1801//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> release scripts should provide timing information
> -
>
> Key: HBASE-24476
> URL: https://issues.apache.org/jira/browse/HBASE-24476
> Project: HBase
> Issue Type: Improvement
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Minor
> Fix For: 3.0.0-alpha-1
>
>
> right now I can get timing from the individual maven commands but it would be
> nice to get higher level times.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24572) release scripts should try to use a keyid when refering to GPG keys.
[
https://issues.apache.org/jira/browse/HBASE-24572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169534#comment-17169534
]
Hudson commented on HBASE-24572:
Results for branch master
[build #1801 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1801/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1801/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1801/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1801/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1801//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> release scripts should try to use a keyid when refering to GPG keys.
>
>
> Key: HBASE-24572
> URL: https://issues.apache.org/jira/browse/HBASE-24572
> Project: HBase
> Issue Type: Task
> Components: build, community
>Reporter: Nick Dimiduk
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 3.0.0-alpha-1
>
>
> Right now the template us substituting the release manager's email address in
> for the variable {{GPG_KEY}}. I think it doesn't hurt to make note of the
> email address, but what we really want here is the key's fingerprint, or some
> meaningly identifiable portion of it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
