[GitHub] [hbase] pankaj72981 edited a comment on pull request #2324: HBASE-24937 table.rb use LocalDateTime to replace Instant

2020-09-03 Thread GitBox
pankaj72981 edited a comment on pull request #2324: URL: https://github.com/apache/hbase/pull/2324#issuecomment-686916094 > Sorry guys. Got sick in the past few days, still recovering... No problem Duo, Get well soon. I'm not sure why "continuous-integration/jenkins/pr-merge"

[GitHub] [hbase] pankaj72981 commented on pull request #2324: HBASE-24937 table.rb use LocalDateTime to replace Instant

2020-09-03 Thread GitBox
pankaj72981 commented on pull request #2324: URL: https://github.com/apache/hbase/pull/2324#issuecomment-686916094 > Sorry guys. Got sick in the past few days, still recovering... No problem Duo, Get well soon. I'm not sure why "continuous-integration/jenkins/pr-merge" check

[GitHub] [hbase] Apache-HBase commented on pull request #2350: HBASE-24759 Refuse to update configuration of default group

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2350: URL: https://github.com/apache/hbase/pull/2350#issuecomment-686900812 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2350: HBASE-24759 Refuse to update configuration of default group

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2350: URL: https://github.com/apache/hbase/pull/2350#issuecomment-686900124 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2350: HBASE-24759 Refuse to update configuration of default group

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2350: URL: https://github.com/apache/hbase/pull/2350#issuecomment-686899791 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2280: URL: https://github.com/apache/hbase/pull/2280#issuecomment-686898811 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] busbey commented on a change in pull request #2191: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…

2020-09-03 Thread GitBox
busbey commented on a change in pull request #2191: URL: https://github.com/apache/hbase/pull/2191#discussion_r483374802 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java ## @@ -626,14 +626,10 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #2345: HBASE-24974: Provide a flexibility to print only row key and filter for multiple tables in the WALPrettyPrinter

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2345: URL: https://github.com/apache/hbase/pull/2345#issuecomment-686894811 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2111: HBASE-24683 Add a basic ReplicationServer which only implement Replic…

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2111: URL: https://github.com/apache/hbase/pull/2111#issuecomment-686891182 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ddupg opened a new pull request #2350: HBASE-24759 Refuse to update configuration of default group

2020-09-03 Thread GitBox
ddupg opened a new pull request #2350: URL: https://github.com/apache/hbase/pull/2350 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] sandeepvinayak commented on pull request #2345: HBASE-24974: Provide a flexibility to print only row key and filter for multiple tables in the WALPrettyPrinter

2020-09-03 Thread GitBox
sandeepvinayak commented on pull request #2345: URL: https://github.com/apache/hbase/pull/2345#issuecomment-686885618 @virajjasani @wchevreuil Addressed your comments and tested it locally. This is an automated message

[GitHub] [hbase] Apache9 commented on pull request #2328: HBASE-24925 SCP reduce unnecessary get requests

2020-09-03 Thread GitBox
Apache9 commented on pull request #2328: URL: https://github.com/apache/hbase/pull/2328#issuecomment-686884566 > > So you mean we should all the table states in memory? For now it is cached on demand. > > yeah, but on-demand generates a large number of rpc requests. normally, all

[GitHub] [hbase] Apache9 commented on pull request #2324: HBASE-24937 table.rb use LocalDateTime to replace Instant

2020-09-03 Thread GitBox
Apache9 commented on pull request #2324: URL: https://github.com/apache/hbase/pull/2324#issuecomment-686883211 Sorry guys. Got sick in the past few days, still recovering... This is an automated message from the Apache Git

[GitHub] [hbase] sandeepvinayak commented on a change in pull request #2345: HBASE-24974: Provide a flexibility to print only row key and filter for multiple tables in the WALPrettyPrinter

2020-09-03 Thread GitBox
sandeepvinayak commented on a change in pull request #2345: URL: https://github.com/apache/hbase/pull/2345#discussion_r483365950 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java ## @@ -79,9 +81,12 @@ private boolean outputJSON;

[GitHub] [hbase] bsglz commented on a change in pull request #2326: HBASE-24967 The table.jsp cost long time to load if the table include…

2020-09-03 Thread GitBox
bsglz commented on a change in pull request #2326: URL: https://github.com/apache/hbase/pull/2326#discussion_r483346288 ## File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp ## @@ -655,12 +656,14 @@ <% if

[jira] [Updated] (HBASE-24971) Upgrade JQuery to 3.5.1

2020-09-03 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24971: --- Fix Version/s: (was: 2.2.7) 2.2.6 > Upgrade JQuery to 3.5.1 >

[jira] [Updated] (HBASE-24892) config 'hbase.hregion.memstore.mslab.indexchunksize' not be used

2020-09-03 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24892: --- Fix Version/s: (was: 2.2.7) 2.2.6 > config

[jira] [Updated] (HBASE-24898) Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-09-03 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24898: --- Fix Version/s: (was: 2.2.7) 2.2.6 > Use

[jira] [Updated] (HBASE-24913) Refactor TestJMXConnectorServer

2020-09-03 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24913: --- Fix Version/s: (was: 2.2.7) 2.2.6 > Refactor TestJMXConnectorServer

[jira] [Resolved] (HBASE-24656) [Flakey Tests] branch-2 TestMasterNoCluster.testStopDuringStart

2020-09-03 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-24656. Fix Version/s: 2.2.6 Resolution: Fixed Cherry-picked to branch-2.2. > [Flakey

[jira] [Reopened] (HBASE-24656) [Flakey Tests] branch-2 TestMasterNoCluster.testStopDuringStart

2020-09-03 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reopened HBASE-24656: Reopen for branch-2.2. > [Flakey Tests] branch-2 TestMasterNoCluster.testStopDuringStart >

[jira] [Commented] (HBASE-24940) runCatalogJanitor() API should return -1 to indicate already running status

2020-09-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190453#comment-17190453 ] Hudson commented on HBASE-24940: Results for branch master [build #34 on

[jira] [Resolved] (HBASE-24980) Fix dead links in HBase book

2020-09-03 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-24980. Fix Version/s: (was: 2.3.2) 3.0.0-alpha-1 Resolution: Fixed

[jira] [Assigned] (HBASE-24980) Fix dead links in HBase book

2020-09-03 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-24980: -- Assignee: echohlne > Fix dead links in HBase book > > >

[GitHub] [hbase] infraio merged pull request #2349: HBASE-24980 Fix dead links in HBase book

2020-09-03 Thread GitBox
infraio merged pull request #2349: URL: https://github.com/apache/hbase/pull/2349 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (HBASE-24759) Refuse to update configuration of default group

2020-09-03 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190444#comment-17190444 ] Guanghao Zhang commented on HBASE-24759: [~Ddupg] Same problem. The RSGroup impl is

[GitHub] [hbase] infraio merged pull request #2126: HBASE-24759 Refuse to update configuration of default group

2020-09-03 Thread GitBox
infraio merged pull request #2126: URL: https://github.com/apache/hbase/pull/2126 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] infraio commented on a change in pull request #2326: HBASE-24967 The table.jsp cost long time to load if the table include…

2020-09-03 Thread GitBox
infraio commented on a change in pull request #2326: URL: https://github.com/apache/hbase/pull/2326#discussion_r483317183 ## File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp ## @@ -655,12 +656,14 @@ <% if

[GitHub] [hbase] infraio commented on a change in pull request #2347: HBASE-24979 : Client operation timeout test for batch requests

2020-09-03 Thread GitBox
infraio commented on a change in pull request #2347: URL: https://github.com/apache/hbase/pull/2347#discussion_r483315658 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/TestClientOperationTimeout.java ## @@ -117,37 +124,78 @@ public static void tearDown()

[GitHub] [hbase] infraio commented on a change in pull request #2347: HBASE-24979 : Client operation timeout test for batch requests

2020-09-03 Thread GitBox
infraio commented on a change in pull request #2347: URL: https://github.com/apache/hbase/pull/2347#discussion_r483315277 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/TestClientOperationTimeout.java ## @@ -117,37 +124,78 @@ public static void tearDown()

[jira] [Commented] (HBASE-24921) Add help output for shell "magic" commands

2020-09-03 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190426#comment-17190426 ] Nick Dimiduk commented on HBASE-24921: -- [~UselessCoder] of course, please help yourself! > Add

[jira] [Commented] (HBASE-24940) runCatalogJanitor() API should return -1 to indicate already running status

2020-09-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190409#comment-17190409 ] Hudson commented on HBASE-24940: Results for branch branch-2.3 [build #28 on

[GitHub] [hbase] Apache-HBase commented on pull request #2312: HBASE-23935 : Backport HBASE-22978 with subtasks & HBASE-24718 to branch-1

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2312: URL: https://github.com/apache/hbase/pull/2312#issuecomment-686776007 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 12m

[jira] [Resolved] (HBASE-19352) Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags

2020-09-03 Thread Esteban Gutierrez (Jira)
[ https://issues.apache.org/jira/browse/HBASE-19352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Esteban Gutierrez resolved HBASE-19352. --- Fix Version/s: 2.2.6 2.4.0 2.3.3

[GitHub] [hbase] bharathv commented on pull request #2345: HBASE-24974: Provide a flexibility to print only row key and filter for multiple tables in the WALPrettyPrinter

2020-09-03 Thread GitBox
bharathv commented on pull request #2345: URL: https://github.com/apache/hbase/pull/2345#issuecomment-686732725 Fine by me. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hbase] sandeepvinayak commented on pull request #2345: HBASE-24974: Provide a flexibility to print only row key and filter for multiple tables in the WALPrettyPrinter

2020-09-03 Thread GitBox
sandeepvinayak commented on pull request #2345: URL: https://github.com/apache/hbase/pull/2345#issuecomment-686717549 @bharathv Initially though of that but regex evaluation for each WALEntry is going to be an expensive operation? On the other hand searching is Set is O(1). What do you

[GitHub] [hbase] sandeepvinayak edited a comment on pull request #2345: HBASE-24974: Provide a flexibility to print only row key and filter for multiple tables in the WALPrettyPrinter

2020-09-03 Thread GitBox
sandeepvinayak edited a comment on pull request #2345: URL: https://github.com/apache/hbase/pull/2345#issuecomment-686717549 @bharathv Initially though of that but regex evaluation for each WALEntry is going to be an expensive operation? On the other hand searching is HashSet is O(1).

[jira] [Work started] (HBASE-19352) Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags

2020-09-03 Thread Esteban Gutierrez (Jira)
[ https://issues.apache.org/jira/browse/HBASE-19352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-19352 started by Esteban Gutierrez. - > Port HADOOP-10379: Protect authentication cookies with the

[GitHub] [hbase] apurtell commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-09-03 Thread GitBox
apurtell commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-686694208 I was so focused on limit that I didn't see the other issues here too, although this idea was reflected in other feedback. The Admin API should be fully generic:

[GitHub] [hbase] virajjasani commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-09-03 Thread GitBox
virajjasani commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-686667507 I am considering to use the same filter based approach I did for the slow log method in Admin.java, where a `LogEntryFilter` can express a limit. `LogEntryFilter` expresses

[GitHub] [hbase] esteban merged pull request #2348: HBASE-19352 Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags

2020-09-03 Thread GitBox
esteban merged pull request #2348: URL: https://github.com/apache/hbase/pull/2348 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2349: HBASE-24980 Fix dead links in HBase book

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2349: URL: https://github.com/apache/hbase/pull/2349#issuecomment-686657140 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2348: HBASE-19352 Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2348: URL: https://github.com/apache/hbase/pull/2348#issuecomment-686648942 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2348: HBASE-19352 Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2348: URL: https://github.com/apache/hbase/pull/2348#issuecomment-686648128 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2348: HBASE-19352 Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2348: URL: https://github.com/apache/hbase/pull/2348#issuecomment-686647596 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ankitjain64 commented on pull request #2284: HBASE-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-09-03 Thread GitBox
ankitjain64 commented on pull request #2284: URL: https://github.com/apache/hbase/pull/2284#issuecomment-686641195 @saintstack Can you please have a look at this patch whenever you get a chance? I have addressed all your comments. Thanks

[jira] [Updated] (HBASE-24980) Fix dead links in HBase book

2020-09-03 Thread echohlne (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] echohlne updated HBASE-24980: - Description: 1. 

[jira] [Updated] (HBASE-24980) Fix dead links in HBase book

2020-09-03 Thread echohlne (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] echohlne updated HBASE-24980: - Description: 1. 

[jira] [Updated] (HBASE-24980) Fix dead links in HBase book

2020-09-03 Thread echohlne (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] echohlne updated HBASE-24980: - Description: 1. 

[jira] [Updated] (HBASE-24980) Fix dead links in HBase book

2020-09-03 Thread echohlne (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] echohlne updated HBASE-24980: - Description: 1. 

[GitHub] [hbase] Apache-HBase commented on pull request #2348: HBASE-19352 Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2348: URL: https://github.com/apache/hbase/pull/2348#issuecomment-686633709 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2349: HBASE-24980

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2349: URL: https://github.com/apache/hbase/pull/2349#issuecomment-686632467 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2348: HBASE-19352 Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2348: URL: https://github.com/apache/hbase/pull/2348#issuecomment-686632618 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2349: HBASE-24980

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2349: URL: https://github.com/apache/hbase/pull/2349#issuecomment-686632814 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2348: HBASE-19352 Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2348: URL: https://github.com/apache/hbase/pull/2348#issuecomment-686632388 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] akiyamaneko opened a new pull request #2349: HBASE-24980

2020-09-03 Thread GitBox
akiyamaneko opened a new pull request #2349: URL: https://github.com/apache/hbase/pull/2349 Fix dead links in HBase book This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (HBASE-24980) Fix dead links in HBase book

2020-09-03 Thread echohlne (Jira)
echohlne created HBASE-24980: Summary: Fix dead links in HBase book Key: HBASE-24980 URL: https://issues.apache.org/jira/browse/HBASE-24980 Project: HBase Issue Type: Bug Components:

[GitHub] [hbase] apurtell commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-09-03 Thread GitBox
apurtell commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-686629676 Who is the consumer of the Admin API? This is where all of this is ultimately exposed. The consumer of the Admin API is an admin level user. They import

[GitHub] [hbase] Apache-HBase commented on pull request #2348: HBASE-19352 Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2348: URL: https://github.com/apache/hbase/pull/2348#issuecomment-686617405 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2348: HBASE-19352 Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2348: URL: https://github.com/apache/hbase/pull/2348#issuecomment-686616588 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2348: HBASE-19352 Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2348: URL: https://github.com/apache/hbase/pull/2348#issuecomment-686616116 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-20985) add two attributes when we do normalization

2020-09-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190262#comment-17190262 ] Hudson commented on HBASE-20985: Results for branch branch-1 [build #19 on

[jira] [Commented] (HBASE-24940) runCatalogJanitor() API should return -1 to indicate already running status

2020-09-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190263#comment-17190263 ] Hudson commented on HBASE-24940: Results for branch branch-1 [build #19 on

[jira] [Commented] (HBASE-24970) Backport HBASE-20985 to branch-1

2020-09-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190261#comment-17190261 ] Hudson commented on HBASE-24970: Results for branch branch-1 [build #19 on

[GitHub] [hbase] Apache-HBase commented on pull request #2348: HBASE-19352 Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2348: URL: https://github.com/apache/hbase/pull/2348#issuecomment-686600607 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #2348: HBASE-19352 Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2348: URL: https://github.com/apache/hbase/pull/2348#issuecomment-686599058 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2348: HBASE-19352 Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2348: URL: https://github.com/apache/hbase/pull/2348#issuecomment-686597669 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2342: HBASE-24960 reduce invalid subprocedure task

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2342: URL: https://github.com/apache/hbase/pull/2342#issuecomment-686596797 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] esteban commented on pull request #2348: HBASE-19352 Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags

2020-09-03 Thread GitBox
esteban commented on pull request #2348: URL: https://github.com/apache/hbase/pull/2348#issuecomment-686581363 Latest commit uses `addPrivilegedServlet` instead of `addUnprivilegedServlet` for test. This is an automated

[GitHub] [hbase] esteban opened a new pull request #2348: HBASE-19352 Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags

2020-09-03 Thread GitBox
esteban opened a new pull request #2348: URL: https://github.com/apache/hbase/pull/2348 Patch adds setHttpOnly(true) and setSecure(true) when creating a new servlet via `HttpServer#addInternalServlet` This is an automated

[jira] [Commented] (HBASE-24973) Remove read point parameter in method StoreFlush#performFlush and StoreFlush#createScanner

2020-09-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190233#comment-17190233 ] Hudson commented on HBASE-24973: Results for branch branch-2 [build #31 on

[jira] [Commented] (HBASE-24971) Upgrade JQuery to 3.5.1

2020-09-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190229#comment-17190229 ] Hudson commented on HBASE-24971: Results for branch branch-2 [build #31 on

[jira] [Commented] (HBASE-24964) Remove MetaTableAccessor.tableExists

2020-09-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190230#comment-17190230 ] Hudson commented on HBASE-24964: Results for branch branch-2 [build #31 on

[jira] [Commented] (HBASE-24831) Avoid invoke Counter using reflection in SnapshotInputFormat

2020-09-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190231#comment-17190231 ] Hudson commented on HBASE-24831: Results for branch branch-2 [build #31 on

[GitHub] [hbase] infraio commented on a change in pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-09-03 Thread GitBox
infraio commented on a change in pull request #2322: URL: https://github.com/apache/hbase/pull/2322#discussion_r483046581 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java ## @@ -968,6 +968,19 @@ private RegionLocations

[GitHub] [hbase] Apache-HBase commented on pull request #2342: HBASE-24960 reduce invalid subprocedure task

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2342: URL: https://github.com/apache/hbase/pull/2342#issuecomment-686546964 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2347: HBASE-24979 : Client operation timeout test for batch requests

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2347: URL: https://github.com/apache/hbase/pull/2347#issuecomment-686530567 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2347: HBASE-24979 : Client operation timeout test for batch requests

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2347: URL: https://github.com/apache/hbase/pull/2347#issuecomment-686524875 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2342: HBASE-24960 reduce invalid subprocedure task

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2342: URL: https://github.com/apache/hbase/pull/2342#issuecomment-686460200 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2347: HBASE-24979 : Client operation timeout test for batch requests

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2347: URL: https://github.com/apache/hbase/pull/2347#issuecomment-686449513 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2346: HBASE-24925 SCP reduce unnecessary get requests

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2346: URL: https://github.com/apache/hbase/pull/2346#issuecomment-686447503 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Work started] (HBASE-24979) Include batch mutatations in client operation timeout tests

2020-09-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24979 started by Viraj Jasani. > Include batch mutatations in client operation timeout tests >

[GitHub] [hbase] Apache-HBase commented on pull request #2342: HBASE-24960 reduce invalid subprocedure task

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2342: URL: https://github.com/apache/hbase/pull/2342#issuecomment-686440516 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] virajjasani opened a new pull request #2347: HBASE-24979 : Client operation timeout test for batch requests

2020-09-03 Thread GitBox
virajjasani opened a new pull request #2347: URL: https://github.com/apache/hbase/pull/2347 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase] Apache-HBase commented on pull request #2245: HBASE-24857:Fix several problems when starting webUI

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2245: URL: https://github.com/apache/hbase/pull/2245#issuecomment-686431214 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Assigned] (HBASE-24979) Include batch mutatations in client operation timeout tests

2020-09-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HBASE-24979: Assignee: Viraj Jasani > Include batch mutatations in client operation timeout tests >

[jira] [Created] (HBASE-24979) Include batch mutatations in client operation timeout tests

2020-09-03 Thread Viraj Jasani (Jira)
Viraj Jasani created HBASE-24979: Summary: Include batch mutatations in client operation timeout tests Key: HBASE-24979 URL: https://issues.apache.org/jira/browse/HBASE-24979 Project: HBase

[jira] [Resolved] (HBASE-24940) runCatalogJanitor() API should return -1 to indicate already running status

2020-09-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-24940. -- Fix Version/s: 2.3.2 2.4.0 1.7.0

[jira] [Commented] (HBASE-24940) runCatalogJanitor() API should return -1 to indicate already running status

2020-09-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190059#comment-17190059 ] Viraj Jasani commented on HBASE-24940: -- Merged changes to master, branch-2, branch-2.3 and

[GitHub] [hbase] Apache-HBase commented on pull request #2346: HBASE-24925 SCP reduce unnecessary get requests

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2346: URL: https://github.com/apache/hbase/pull/2346#issuecomment-686414702 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2342: HBASE-24960 reduce invalid subprocedure task

2020-09-03 Thread GitBox
Apache-HBase commented on pull request #2342: URL: https://github.com/apache/hbase/pull/2342#issuecomment-686405359 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani closed pull request #2331: HBASE-24940: runCatalogJanitor() API should return -1 to indicate already running status

2020-09-03 Thread GitBox
virajjasani closed pull request #2331: URL: https://github.com/apache/hbase/pull/2331 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] virajjasani commented on a change in pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-09-03 Thread GitBox
virajjasani commented on a change in pull request #2261: URL: https://github.com/apache/hbase/pull/2261#discussion_r482698935 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/BalancerDecisionRequest.java ## @@ -0,0 +1,64 @@ +/* + * + * Licensed to the

[GitHub] [hbase] virajjasani commented on a change in pull request #2345: HBASE-24974: Provide a flexibility to print only row key and filter for multiple tables in the WALPrettyPrinter

2020-09-03 Thread GitBox
virajjasani commented on a change in pull request #2345: URL: https://github.com/apache/hbase/pull/2345#discussion_r482856361 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java ## @@ -274,7 +289,8 @@ public void processFile(final

[GitHub] [hbase] virajjasani commented on a change in pull request #2343: HBASE-24962 Optimize BufferNode Lock

2020-09-03 Thread GitBox
virajjasani commented on a change in pull request #2343: URL: https://github.com/apache/hbase/pull/2343#discussion_r482817164 ## File path: hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/RemoteProcedureDispatcher.java ## @@ -298,6 +299,8 @@ default boolean

[jira] [Updated] (HBASE-24978) Remove QuotaCache.java SuppressWarnings annotation

2020-09-03 Thread qiang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] qiang Liu updated HBASE-24978: -- Attachment: HBASE-24978.master.v01.patch Status: Patch Available (was: Open) > Remove

[GitHub] [hbase] pankaj72981 commented on pull request #2324: HBASE-24937 table.rb use LocalDateTime to replace Instant

2020-09-03 Thread GitBox
pankaj72981 commented on pull request #2324: URL: https://github.com/apache/hbase/pull/2324#issuecomment-686372409 @Apache9 QA is successful now, how to trigger "continuous-integration/jenkins/pr-merge"? This is an

[GitHub] [hbase] wchevreuil commented on a change in pull request #2345: HBASE-24974: Provide a flexibility to print only row key and filter for multiple tables in the WALPrettyPrinter

2020-09-03 Thread GitBox
wchevreuil commented on a change in pull request #2345: URL: https://github.com/apache/hbase/pull/2345#discussion_r482819637 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java ## @@ -147,11 +153,13 @@ public void setSequenceFilter(long

[jira] [Updated] (HBASE-24978) Remove QuotaCache.java SuppressWarnings annotation

2020-09-03 Thread qiang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] qiang Liu updated HBASE-24978: -- Description: map check key exist mistakenly use contains insteadof containsKey cause the warning,

[jira] [Updated] (HBASE-24978) Remove QuotaCache.java SuppressWarnings annotation

2020-09-03 Thread qiang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] qiang Liu updated HBASE-24978: -- Description: map check key exist mistakenly use contains insteadof containsKey cause the warning,

  1   2   >