[GitHub] [hbase] virajjasani commented on a change in pull request #2540: HBASE-24628 Region normalizer now respects a rate limit (HMaster chore shutdown NPE ADDENDUM)

2020-10-13 Thread GitBox
virajjasani commented on a change in pull request #2540: URL: https://github.com/apache/hbase/pull/2540#discussion_r504416607 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -1638,7 +1638,9 @@ private void stopChores() {

[jira] [Commented] (HBASE-25065) WAL archival to be done by a separate thread

2020-10-13 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213604#comment-17213604 ] ramkrishna.s.vasudevan commented on HBASE-25065: [~zhangduo] Thanks for pointing out. I

[jira] [Commented] (HBASE-24609) Move MetaTableAccessor out of hbase-client

2020-10-13 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213599#comment-17213599 ] Michael Stack commented on HBASE-24609: --- bq. Maybe we need to open a discuss thread on dev and

[jira] [Commented] (HBASE-24609) Move MetaTableAccessor out of hbase-client

2020-10-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213597#comment-17213597 ] Duo Zhang commented on HBASE-24609: --- Yes, please. Maybe we need to open a discuss thread on dev and

[GitHub] [hbase] Apache-HBase commented on pull request #2540: HBASE-24628 Region normalizer now respects a rate limit (HMaster chore shutdown NPE ADDENDUM)

2020-10-13 Thread GitBox
Apache-HBase commented on pull request #2540: URL: https://github.com/apache/hbase/pull/2540#issuecomment-708147889 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24609) Move MetaTableAccessor out of hbase-client

2020-10-13 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213592#comment-17213592 ] Michael Stack commented on HBASE-24609: --- Want me to do the FN deprecate ? I can work on that if it

[GitHub] [hbase] saintstack commented on a change in pull request #2537: HBASE-24977 Meta table shouldn't be modified as read only

2020-10-13 Thread GitBox
saintstack commented on a change in pull request #2537: URL: https://github.com/apache/hbase/pull/2537#discussion_r504391227 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/TableDescriptorChecker.java ## @@ -150,6 +151,12 @@ public static void

[GitHub] [hbase] saintstack commented on pull request #2537: HBASE-24977 Meta table shouldn't be modified as read only

2020-10-13 Thread GitBox
saintstack commented on pull request #2537: URL: https://github.com/apache/hbase/pull/2537#issuecomment-708145397 > Yeah, unset will work here. But should we allow admin to alter meta with read-only which will break availability? Please provide your opinion, I'm OK with the current

[jira] [Commented] (HBASE-24609) Move MetaTableAccessor out of hbase-client

2020-10-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213587#comment-17213587 ] Duo Zhang commented on HBASE-24609: --- {quote} The FN balancer hasn't worked in years if it ever worked.

[GitHub] [hbase] pankaj72981 commented on pull request #2537: HBASE-24977 Meta table shouldn't be modified as read only

2020-10-13 Thread GitBox
pankaj72981 commented on pull request #2537: URL: https://github.com/apache/hbase/pull/2537#issuecomment-708143200 > If you set the table read-only, you can unset it and make it writable again? Yeah, unset will work here. But should we allow admin to alter meta with read-only which

[jira] [Commented] (HBASE-24609) Move MetaTableAccessor out of hbase-client

2020-10-13 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213571#comment-17213571 ] Michael Stack commented on HBASE-24609: --- bq. bq. bq. Is this plan written down anywhere? bq.

[jira] [Commented] (HBASE-24875) Remove the force param for unassign since it dose not take effect any more

2020-10-13 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213570#comment-17213570 ] Sean Busbey commented on HBASE-24875: - yes. that one is removed already in HBase 3 (and I think it

[GitHub] [hbase] Apache-HBase commented on pull request #2540: HBASE-24628 Region normalizer now respects a rate limit (HMaster chore shutdown NPE ADDENDUM)

2020-10-13 Thread GitBox
Apache-HBase commented on pull request #2540: URL: https://github.com/apache/hbase/pull/2540#issuecomment-708131654 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-25185) Remove the usage of MetaTableAccessor in hbase-balancer

2020-10-13 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25185: - Summary: Remove the usage of MetaTableAccessor in hbase-balancer Key: HBASE-25185 URL: https://issues.apache.org/jira/browse/HBASE-25185 Project: HBase Issue

[GitHub] [hbase] infraio commented on pull request #2532: HBASE-25177 Try create table with 100 regions for branch-2.2 nightly …

2020-10-13 Thread GitBox
infraio commented on pull request #2532: URL: https://github.com/apache/hbase/pull/2532#issuecomment-708126931 I tried it locally. And it passed. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] infraio commented on pull request #2532: HBASE-25177 Try create table with 100 regions for branch-2.2 nightly …

2020-10-13 Thread GitBox
infraio commented on pull request #2532: URL: https://github.com/apache/hbase/pull/2532#issuecomment-708126746 This is just an attempt and I don't know the reason, too. If 100 regions passed, then I will change it to 1000 regions back. This means the reason is related to regions number.

[jira] [Created] (HBASE-25184) Move RegionLocationFinder to hbase-balancer

2020-10-13 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25184: - Summary: Move RegionLocationFinder to hbase-balancer Key: HBASE-25184 URL: https://issues.apache.org/jira/browse/HBASE-25184 Project: HBase Issue Type: Sub-task

[jira] [Commented] (HBASE-24875) Remove the force param for unassign since it dose not take effect any more

2020-10-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213548#comment-17213548 ] Duo Zhang commented on HBASE-24875: --- Oh, you mean the CP related interface? > Remove the force param

[jira] [Commented] (HBASE-24875) Remove the force param for unassign since it dose not take effect any more

2020-10-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213546#comment-17213546 ] Duo Zhang commented on HBASE-24875: --- This is not an incompatible change? We haven't removed the method

[jira] [Updated] (HBASE-14067) bundle ruby files for hbase shell into a jar.

2020-10-13 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-14067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-14067: Resolution: Fixed Status: Resolved (was: Patch Available) > bundle ruby files for hbase

[jira] [Created] (HBASE-25183) Move more balancer related classes to hbase-balancer

2020-10-13 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25183: - Summary: Move more balancer related classes to hbase-balancer Key: HBASE-25183 URL: https://issues.apache.org/jira/browse/HBASE-25183 Project: HBase Issue Type:

[jira] [Resolved] (HBASE-24875) Remove the force param for unassign since it dose not take effect any more

2020-10-13 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey resolved HBASE-24875. - Release Note: The "force" flag to various unassign commands (java api, shell, etc) has been

[jira] [Resolved] (HBASE-24875) Remove the force param for unassign since it dose not take effect any more

2020-10-13 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey resolved HBASE-24875. - Hadoop Flags: Incompatible change Resolution: Fixed > Remove the force param for unassign

[jira] [Reopened] (HBASE-24875) Remove the force param for unassign since it dose not take effect any more

2020-10-13 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey reopened HBASE-24875: - > Remove the force param for unassign since it dose not take effect any more >

[jira] [Updated] (HBASE-11686) Shell code should create a binding / irb workspace instead of polluting the root namespace

2020-10-13 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-11686: Hadoop Flags: Incompatible change,Reviewed (was: Reviewed) > Shell code should create a binding

[jira] [Reopened] (HBASE-24875) Remove the force param for unassign since it dose not take effect any more

2020-10-13 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey reopened HBASE-24875: - > Remove the force param for unassign since it dose not take effect any more >

[jira] [Updated] (HBASE-24875) Remove the force param for unassign since it dose not take effect any more

2020-10-13 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-24875: Fix Version/s: 2.4.0 > Remove the force param for unassign since it dose not take effect any more

[jira] [Updated] (HBASE-24806) Small Updates to Functionality of Shell IRB Workspace

2020-10-13 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-24806: Fix Version/s: 2.4.0 > Small Updates to Functionality of Shell IRB Workspace >

[jira] [Updated] (HBASE-11686) Shell code should create a binding / irb workspace instead of polluting the root namespace

2020-10-13 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-11686: Fix Version/s: 2.4.0 > Shell code should create a binding / irb workspace instead of polluting

[GitHub] [hbase] ddupg commented on a change in pull request #2521: HBASE-25117 ReplicationSourceShipper thread can not be finished

2020-10-13 Thread GitBox
ddupg commented on a change in pull request #2521: URL: https://github.com/apache/hbase/pull/2521#discussion_r504359216 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java ## @@ -691,6 +691,9 @@ public void

[jira] [Commented] (HBASE-25065) WAL archival to be done by a separate thread

2020-10-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213520#comment-17213520 ] Duo Zhang commented on HBASE-25065: --- [~ram_krish] Any feedbacks? If still no response today I will

[jira] [Commented] (HBASE-24609) Move MetaTableAccessor out of hbase-client

2020-10-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213519#comment-17213519 ] Duo Zhang commented on HBASE-24609: --- {quote} Is this plan written down anywhere? {quote} No, but I

[jira] [Updated] (HBASE-24943) Cleanup unnecessary usages of MetaTableAccessor

2020-10-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24943: -- Description: For simplify the implementation of splittable meta. In general, MetaTableAccessor can

[jira] [Updated] (HBASE-24943) Cleanup unnecessary usages of MetaTableAccessor

2020-10-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24943: -- Description: For simplify the implementation of splittable meta. In general, MetaTableAccessor can

[jira] [Commented] (HBASE-24609) Move MetaTableAccessor out of hbase-client

2020-10-13 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213511#comment-17213511 ] Michael Stack commented on HBASE-24609: --- bq. The plan is to move it to hbase-server... Is this

[GitHub] [hbase] Apache-HBase commented on pull request #2540: HBASE-24628 Region normalizer now respects a rate limit (HMaster chore shutdown NPE ADDENDUM)

2020-10-13 Thread GitBox
Apache-HBase commented on pull request #2540: URL: https://github.com/apache/hbase/pull/2540#issuecomment-708095851 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on pull request #2540: HBASE-24628 Region normalizer now respects a rate limit (HMaster chore shutdown NPE ADDENDUM)

2020-10-13 Thread GitBox
Apache9 commented on pull request #2540: URL: https://github.com/apache/hbase/pull/2540#issuecomment-708084210 OK, tried locally, a simple null check could fix the problem. This is an automated message from the Apache Git

[GitHub] [hbase] Apache9 commented on pull request #2540: HBASE-24628 Region normalizer now respects a rate limit (HMaster chore shutdown NPE ADDENDUM)

2020-10-13 Thread GitBox
Apache9 commented on pull request #2540: URL: https://github.com/apache/hbase/pull/2540#issuecomment-708084067 And in general, I think the design here is a bit strange. If we define RegionNormalizerManager as a separated feature, then we should schedule chore and cancel it in

[GitHub] [hbase] Apache9 commented on a change in pull request #2540: HBASE-24628 Region normalizer now respects a rate limit (HMaster chore shutdown NPE ADDENDUM)

2020-10-13 Thread GitBox
Apache9 commented on a change in pull request #2540: URL: https://github.com/apache/hbase/pull/2540#discussion_r504332554 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -1638,7 +1638,9 @@ private void stopChores() {

[jira] [Commented] (HBASE-24609) Move MetaTableAccessor out of hbase-client

2020-10-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213500#comment-17213500 ] Duo Zhang commented on HBASE-24609: --- {quote} Why move MetaTableAccessor to hbase-balancer? The

[GitHub] [hbase] saintstack commented on a change in pull request #1943: HBASE-24609 Move MetaTableAccessor out of hbase-client

2020-10-13 Thread GitBox
saintstack commented on a change in pull request #1943: URL: https://github.com/apache/hbase/pull/1943#discussion_r504301057 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java ## @@ -2176,13 +1606,9 @@ private static void

[GitHub] [hbase] ndimiduk commented on pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-13 Thread GitBox
ndimiduk commented on pull request #2523: URL: https://github.com/apache/hbase/pull/2523#issuecomment-708048058 @virajjasani to the best of my knowledge, the `ConfigurationObserver` classes facilitate reloading values from configuration on disk. I think the workflow is (1) operator writes

[jira] [Commented] (HBASE-25156) TestMasterFailover.testSimpleMasterFailover is flaky

2020-10-13 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213465#comment-17213465 ] Nick Dimiduk commented on HBASE-25156: -- Addendum is posted on HBASE-24628. I'll revert the addendum

[GitHub] [hbase] ndimiduk opened a new pull request #2540: HBASE-24628 Region normalizer now respects a rate limit (HMaster chore shutdown NPE ADDENDUM)

2020-10-13 Thread GitBox
ndimiduk opened a new pull request #2540: URL: https://github.com/apache/hbase/pull/2540 I think this variable is null for backup masters. `initializeZKBasedSystemTrackers` only called when a master transitions to active. I don't know why it impacts this test though, as an NPE in the

[jira] [Commented] (HBASE-24628) Region normalizer now respects a rate limit

2020-10-13 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213445#comment-17213445 ] Nick Dimiduk commented on HBASE-24628: -- Thank [~zhangduo] let me look. > Region normalizer now

[GitHub] [hbase] saintstack commented on pull request #2537: HBASE-24977 Meta table shouldn't be modified as read only

2020-10-13 Thread GitBox
saintstack commented on pull request #2537: URL: https://github.com/apache/hbase/pull/2537#issuecomment-708024224 If you set the table read-only, you can unset it and make it writable again? This is an automated message from

[jira] [Created] (HBASE-25182) Validate earlier coprocessors against HBase 3.0+

2020-10-13 Thread Sean Busbey (Jira)
Sean Busbey created HBASE-25182: --- Summary: Validate earlier coprocessors against HBase 3.0+ Key: HBASE-25182 URL: https://issues.apache.org/jira/browse/HBASE-25182 Project: HBase Issue Type:

[jira] [Resolved] (HBASE-25144) Add Hadoop-3.3.0 to personality hadoopcheck

2020-10-13 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-25144. -- Resolution: Fixed > Add Hadoop-3.3.0 to personality hadoopcheck >

[jira] [Commented] (HBASE-24609) Move MetaTableAccessor out of hbase-client

2020-10-13 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213379#comment-17213379 ] Michael Stack commented on HBASE-24609: --- A few questions after looking at this (belatedly)

[jira] [Commented] (HBASE-25017) Attach a design doc to code base

2020-10-13 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213352#comment-17213352 ] Michael Stack commented on HBASE-25017: --- The linked PR seems to be for another issue? > Attach a

[jira] [Commented] (HBASE-25007) Make HBCK2 work for 'root table'

2020-10-13 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213349#comment-17213349 ] Michael Stack commented on HBASE-25007: --- bq. Add a new HBCK option to scan meta and fix the

[jira] [Commented] (HBASE-25065) WAL archival to be done by a separate thread

2020-10-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213279#comment-17213279 ] Hudson commented on HBASE-25065: Results for branch branch-2 [build #76 on

[jira] [Commented] (HBASE-25169) Update documentation about meta region replica

2020-10-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213281#comment-17213281 ] Hudson commented on HBASE-25169: Results for branch branch-2 [build #76 on

[jira] [Commented] (HBASE-25164) Make ModifyTableProcedure support changing meta replica count

2020-10-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213280#comment-17213280 ] Hudson commented on HBASE-25164: Results for branch branch-2 [build #76 on

[GitHub] [hbase] pankaj72981 commented on pull request #2537: HBASE-24977 Meta table shouldn't be modified as read only

2020-10-13 Thread GitBox
pankaj72981 commented on pull request #2537: URL: https://github.com/apache/hbase/pull/2537#issuecomment-707897577 > Since there is no damage to meta if you set it to read only I'm neutral on this... Yes, it won't damage meta but impacts the internal region assignment. IMO, it will

[jira] [Commented] (HBASE-25168) Unify WAL name timestamp parsers

2020-10-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213241#comment-17213241 ] Hudson commented on HBASE-25168: Results for branch branch-2.3 [build #82 on

[GitHub] [hbase] asfgit closed pull request #2515: HBASE-14067 bundle ruby files for hbase shell into a jar.

2020-10-13 Thread GitBox
asfgit closed pull request #2515: URL: https://github.com/apache/hbase/pull/2515 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] busbey commented on a change in pull request #2539: HBASE-25181 Configure hash algorithm in wrapped encryption keys

2020-10-13 Thread GitBox
busbey commented on a change in pull request #2539: URL: https://github.com/apache/hbase/pull/2539#discussion_r504073569 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -1339,6 +1339,19 @@ /** Configuration key for the algorithm used

[jira] [Commented] (HBASE-25007) Make HBCK2 work for 'root table'

2020-10-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213192#comment-17213192 ] Duo Zhang commented on HBASE-25007: --- What do you think about the above approach sir? [~stack]. Add a

[jira] [Work started] (HBASE-25063) Fan out the edits to root to backup masters

2020-10-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25063 started by Duo Zhang. - > Fan out the edits to root to backup masters >

[GitHub] [hbase] busbey commented on pull request #2515: HBASE-14067 bundle ruby files for hbase shell into a jar.

2020-10-13 Thread GitBox
busbey commented on pull request #2515: URL: https://github.com/apache/hbase/pull/2515#issuecomment-707833925 yeah they're all spotty failures all over the place. I think the flaky infra needs a bigger window so it can catch rarer issues in the hbase-server module. I'll do another

[GitHub] [hbase] nyl3532016 commented on a change in pull request #2538: HBASE-25176 MasterStoppedException should be moved to hbase-client module

2020-10-13 Thread GitBox
nyl3532016 commented on a change in pull request #2538: URL: https://github.com/apache/hbase/pull/2538#discussion_r504011398 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/MasterStoppedException.java ## @@ -0,0 +1,28 @@ +/** + * Licensed to the

[GitHub] [hbase] Apache9 commented on a change in pull request #2538: HBASE-25176 MasterStoppedException should be moved to hbase-client module

2020-10-13 Thread GitBox
Apache9 commented on a change in pull request #2538: URL: https://github.com/apache/hbase/pull/2538#discussion_r503984012 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/MasterStoppedException.java ## @@ -0,0 +1,28 @@ +/** + * Licensed to the

[GitHub] [hbase] virajjasani commented on a change in pull request #2538: HBASE-25176 MasterStoppedException should be moved to hbase-client module

2020-10-13 Thread GitBox
virajjasani commented on a change in pull request #2538: URL: https://github.com/apache/hbase/pull/2538#discussion_r503980175 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/MasterStoppedException.java ## @@ -0,0 +1,28 @@ +/** + * Licensed to the

[GitHub] [hbase] Apache9 commented on a change in pull request #2538: HBASE-25176 MasterStoppedException should be moved to hbase-client module

2020-10-13 Thread GitBox
Apache9 commented on a change in pull request #2538: URL: https://github.com/apache/hbase/pull/2538#discussion_r503978031 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/MasterStoppedException.java ## @@ -0,0 +1,28 @@ +/** + * Licensed to the

[GitHub] [hbase] Apache-HBase commented on pull request #2447: HBASE-25063 Fan out the edits to root to backup masters

2020-10-13 Thread GitBox
Apache-HBase commented on pull request #2447: URL: https://github.com/apache/hbase/pull/2447#issuecomment-707739652 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 merged pull request #2534: Backport HBASE-25093 the RSGroupBasedLoadBalancer#retainAssignment throws NPE

2020-10-13 Thread GitBox
Apache9 merged pull request #2534: URL: https://github.com/apache/hbase/pull/2534 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache9 commented on a change in pull request #2169: HBASE-24792 LogRoller.walRollFinished fix

2020-10-13 Thread GitBox
Apache9 commented on a change in pull request #2169: URL: https://github.com/apache/hbase/pull/2169#discussion_r503930282 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractWALRoller.java ## @@ -255,22 +248,29 @@ public void close() { private

[GitHub] [hbase] Apache-HBase commented on pull request #2537: HBASE-24977 Meta table shouldn't be modified as read only

2020-10-13 Thread GitBox
Apache-HBase commented on pull request #2537: URL: https://github.com/apache/hbase/pull/2537#issuecomment-707706074 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2447: HBASE-25063 Fan out the edits to root to backup masters

2020-10-13 Thread GitBox
Apache-HBase commented on pull request #2447: URL: https://github.com/apache/hbase/pull/2447#issuecomment-707704344 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2538: HBASE-25176 MasterStoppedException should be moved to hbase-client module

2020-10-13 Thread GitBox
Apache-HBase commented on pull request #2538: URL: https://github.com/apache/hbase/pull/2538#issuecomment-707704071 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2538: HBASE-25176 MasterStoppedException should be moved to hbase-client module

2020-10-13 Thread GitBox
Apache-HBase commented on pull request #2538: URL: https://github.com/apache/hbase/pull/2538#issuecomment-707703447 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 commented on a change in pull request #2521: HBASE-25117 ReplicationSourceShipper thread can not be finished

2020-10-13 Thread GitBox
Apache9 commented on a change in pull request #2521: URL: https://github.com/apache/hbase/pull/2521#discussion_r503889463 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java ## @@ -691,6 +691,9 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #2537: HBASE-24977 Meta table shouldn't be modified as read only

2020-10-13 Thread GitBox
Apache-HBase commented on pull request #2537: URL: https://github.com/apache/hbase/pull/2537#issuecomment-707676158 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] symat commented on pull request #2539: HBASE-25181 Configure hash algorithm in wrapped encryption keys

2020-10-13 Thread GitBox
symat commented on pull request #2539: URL: https://github.com/apache/hbase/pull/2539#issuecomment-707673569 I added back the public methods, @wchevreuil please take a look! I'm not sure about the deprecation of the methods we don't use anymore in the HBase code. Personally I'm OK

[jira] [Assigned] (HBASE-25173) Remove owner related methods in TableDescriptor/TableDescriptorBuilder

2020-10-13 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wenfeiyi666 reassigned HBASE-25173: --- Assignee: wenfeiyi666 > Remove owner related methods in

[GitHub] [hbase] WenFeiYi commented on a change in pull request #2169: HBASE-24792 LogRoller.walRollFinished fix

2020-10-13 Thread GitBox
WenFeiYi commented on a change in pull request #2169: URL: https://github.com/apache/hbase/pull/2169#discussion_r503853552 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractWALRoller.java ## @@ -255,22 +250,32 @@ public void close() { private

[GitHub] [hbase] symat commented on a change in pull request #2539: HBASE-25181 Configure hash algorithm in wrapped encryption keys

2020-10-13 Thread GitBox
symat commented on a change in pull request #2539: URL: https://github.com/apache/hbase/pull/2539#discussion_r503852147 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Encryption.java ## @@ -127,96 +128,48 @@ public static Cipher

[GitHub] [hbase] Apache-HBase commented on pull request #2539: HBASE-25181 Configure hash algorithm in wrapped encryption keys

2020-10-13 Thread GitBox
Apache-HBase commented on pull request #2539: URL: https://github.com/apache/hbase/pull/2539#issuecomment-707654286 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] wchevreuil commented on a change in pull request #2539: HBASE-25181 Configure hash algorithm in wrapped encryption keys

2020-10-13 Thread GitBox
wchevreuil commented on a change in pull request #2539: URL: https://github.com/apache/hbase/pull/2539#discussion_r503838423 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Encryption.java ## @@ -127,96 +128,48 @@ public static Cipher

[GitHub] [hbase] Apache-HBase commented on pull request #2539: HBASE-25181 Configure hash algorithm in wrapped encryption keys

2020-10-13 Thread GitBox
Apache-HBase commented on pull request #2539: URL: https://github.com/apache/hbase/pull/2539#issuecomment-707649337 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2539: HBASE-25181 Configure hash algorithm in wrapped encryption keys

2020-10-13 Thread GitBox
Apache-HBase commented on pull request #2539: URL: https://github.com/apache/hbase/pull/2539#issuecomment-707649243 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache9 commented on pull request #2537: HBASE-24977 Meta table shouldn't be modified as read only

2020-10-13 Thread GitBox
Apache9 commented on pull request #2537: URL: https://github.com/apache/hbase/pull/2537#issuecomment-707642182 Since there is no damage to meta if you set it to read only I'm neutral on this... This is an automated message

[GitHub] [hbase] Apache-HBase commented on pull request #2538: HBASE-25176 MasterStoppedException should be moved to hbase-client module

2020-10-13 Thread GitBox
Apache-HBase commented on pull request #2538: URL: https://github.com/apache/hbase/pull/2538#issuecomment-707641973 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2447: HBASE-25063 Fan out the edits to root to backup masters

2020-10-13 Thread GitBox
Apache-HBase commented on pull request #2447: URL: https://github.com/apache/hbase/pull/2447#issuecomment-707641526 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2313: HBASE-24900 Make retain assignment configurable during SCP

2020-10-13 Thread GitBox
Apache-HBase commented on pull request #2313: URL: https://github.com/apache/hbase/pull/2313#issuecomment-707629426 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Work started] (HBASE-25181) Configure hash algorithm in wrapped encryption keys

2020-10-13 Thread Mate Szalay-Beko (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25181 started by Mate Szalay-Beko. > Configure hash algorithm in wrapped encryption keys >

[GitHub] [hbase] symat opened a new pull request #2539: HBASE-25181 Configure hash algorithm in wrapped encryption keys

2020-10-13 Thread GitBox
symat opened a new pull request #2539: URL: https://github.com/apache/hbase/pull/2539 Currently we are using MD5 hash algorithm to store a hash for encryption keys. This hash is needed to verify the secret key of the subject. (e.g. making sure that the same secret key is used during

[GitHub] [hbase] nyl3532016 opened a new pull request #2538: HBASE-25176 MasterStoppedException should be moved to hbase-client module

2020-10-13 Thread GitBox
nyl3532016 opened a new pull request #2538: URL: https://github.com/apache/hbase/pull/2538 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase] Apache-HBase commented on pull request #2537: HBASE-24977 Meta table shouldn't be modified as read only

2020-10-13 Thread GitBox
Apache-HBase commented on pull request #2537: URL: https://github.com/apache/hbase/pull/2537#issuecomment-707610137 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on pull request #2532: HBASE-25177 Try create table with 100 regions for branch-2.2 nightly …

2020-10-13 Thread GitBox
virajjasani commented on pull request #2532: URL: https://github.com/apache/hbase/pull/2532#issuecomment-707606406 > What is the reason that we can not create 1000 regions? Subscribed, I am also interested to know.

[GitHub] [hbase] virajjasani commented on pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-13 Thread GitBox
virajjasani commented on pull request #2523: URL: https://github.com/apache/hbase/pull/2523#issuecomment-707605198 We used to have 2 types of hot config reload: 1. `_switch` commands (e.g `balancer_switch`) which uses znode to update config on/off values and hence, even after master

[GitHub] [hbase] virajjasani edited a comment on pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-13 Thread GitBox
virajjasani edited a comment on pull request #2523: URL: https://github.com/apache/hbase/pull/2523#issuecomment-707605198 We used to have 2 types of hot config reload: 1. `_switch` commands (e.g `balancer_switch`) which uses znode to update config on/off values and hence, even after

[jira] [Created] (HBASE-25181) Configure hash algorithm in wrapped encryption keys

2020-10-13 Thread Mate Szalay-Beko (Jira)
Mate Szalay-Beko created HBASE-25181: Summary: Configure hash algorithm in wrapped encryption keys Key: HBASE-25181 URL: https://issues.apache.org/jira/browse/HBASE-25181 Project: HBase

[jira] [Updated] (HBASE-24977) Meta table shouldn't be modified as read only

2020-10-13 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-24977: - Status: Patch Available (was: In Progress) > Meta table shouldn't be modified as read only >

[jira] [Work started] (HBASE-24977) Meta table shouldn't be modified as read only

2020-10-13 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24977 started by Pankaj Kumar. > Meta table shouldn't be modified as read only >

[GitHub] [hbase] pankaj72981 opened a new pull request #2537: HBASE-24977 Meta table shouldn't be modified as read only

2020-10-13 Thread GitBox
pankaj72981 opened a new pull request #2537: URL: https://github.com/apache/hbase/pull/2537 Added a sanity check for meta table before modifying the table schema This is an automated message from the Apache Git Service. To

[jira] [Updated] (HBASE-24977) Meta table shouldn't be modified as read only

2020-10-13 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-24977: - Summary: Meta table shouldn't be modified as read only (was: Meta table shouldn't be allowed

[jira] [Reopened] (HBASE-24628) Region normalizer now respects a rate limit

2020-10-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reopened HBASE-24628: --- This breaks TestMasterFailover.testSimpleMasterFailover, please see the last comment on HBASE-25156.

[jira] [Commented] (HBASE-25156) TestMasterFailover.testSimpleMasterFailover is flaky

2020-10-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17212937#comment-17212937 ] Duo Zhang commented on HBASE-25156: --- {quote} 2020-10-13 16:23:01,042 ERROR [M:0;zhangduo-ubuntu:37069]

  1   2   >