[GitHub] [hbase] ramkrish86 commented on a change in pull request #2419: HBASE-25050 - We initialize Filesystems more than once.

2020-10-18 Thread GitBox
ramkrish86 commented on a change in pull request #2419: URL: https://github.com/apache/hbase/pull/2419#discussion_r507471545 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java ## @@ -82,11 +82,9 @@ public HFileSystem(Configuration conf,

[jira] [Commented] (HBASE-25200) Try enlarge the flaky test timeout for branch-2.2

2020-10-18 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216437#comment-17216437 ] Duo Zhang commented on HBASE-25200: --- Let's find out the error builds and delete them... But you need

[jira] [Commented] (HBASE-25200) Try enlarge the flaky test timeout for branch-2.2

2020-10-18 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216432#comment-17216432 ] Guanghao Zhang commented on HBASE-25200: I thought the flakey test's reason is that: # Too many

[jira] [Resolved] (HBASE-25195) [branch-1] getNumOpenConnections is not effective

2020-10-18 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-25195. --- Hadoop Flags: Reviewed Resolution: Fixed > [branch-1] getNumOpenConnections is not effective

[GitHub] [hbase] Reidddddd merged pull request #2557: HBASE-25195 [branch-1] getNumOpenConnections is not effective

2020-10-18 Thread GitBox
Reidd merged pull request #2557: URL: https://github.com/apache/hbase/pull/2557 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (HBASE-25202) Compress the surefire report for flaky tests jenkins job

2020-10-18 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25202: - Summary: Compress the surefire report for flaky tests jenkins job Key: HBASE-25202 URL: https://issues.apache.org/jira/browse/HBASE-25202 Project: HBase Issue

[jira] [Resolved] (HBASE-25093) the RSGroupBasedLoadBalancer#retainAssignment throws NPE

2020-10-18 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] niuyulin resolved HBASE-25093. -- Resolution: Fixed > the RSGroupBasedLoadBalancer#retainAssignment throws NPE >

[jira] [Commented] (HBASE-25093) the RSGroupBasedLoadBalancer#retainAssignment throws NPE

2020-10-18 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216415#comment-17216415 ] niuyulin commented on HBASE-25093: -- Thanks for [~zhangduo] reviewing > the

[jira] [Updated] (HBASE-25201) YouAreDeadException should be moved to hbase-server module

2020-10-18 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] niuyulin updated HBASE-25201: - Description: Since it will be thrown from the region server reports, it will not be propagated to

[GitHub] [hbase] Apache9 merged pull request #2553: BackPort HBASE-25093 the RSGroupBasedLoadBalancer#retainAssignment throws NPE

2020-10-18 Thread GitBox
Apache9 merged pull request #2553: URL: https://github.com/apache/hbase/pull/2553 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (HBASE-25201) YouAreDeadException should be moved to hbase-server module

2020-10-18 Thread niuyulin (Jira)
niuyulin created HBASE-25201: Summary: YouAreDeadException should be moved to hbase-server module Key: HBASE-25201 URL: https://issues.apache.org/jira/browse/HBASE-25201 Project: HBase Issue

[GitHub] [hbase] Apache9 commented on pull request #2437: HBASE-25053 WAL replay should ignore 0-length files

2020-10-18 Thread GitBox
Apache9 commented on pull request #2437: URL: https://github.com/apache/hbase/pull/2437#issuecomment-711474584 I‘m OK with merging. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] nyl3532016 commented on pull request #2437: HBASE-25053 WAL replay should ignore 0-length files

2020-10-18 Thread GitBox
nyl3532016 commented on pull request #2437: URL: https://github.com/apache/hbase/pull/2437#issuecomment-711472666 > @Apache9 @saintstack This PR can be merged and closed? @saintstack please have a look, thanks This is

[jira] [Commented] (HBASE-25093) the RSGroupBasedLoadBalancer#retainAssignment throws NPE

2020-10-18 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216408#comment-17216408 ] niuyulin commented on HBASE-25093: -- [~zhangduo] PR for 2.3 has submitted, mind help to review it ? >

[jira] [Commented] (HBASE-25200) Try enlarge the flaky test timeout for branch-2.2

2020-10-18 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216407#comment-17216407 ] Duo Zhang commented on HBASE-25200: --- I would say let's fix the flaky tests first, and then delete the

[jira] [Updated] (HBASE-25200) Try enlarge the flaky test timeout for branch-2.2

2020-10-18 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-25200: --- Description: Now there are too many flaky tests to run. And the flaky test job cannot

[jira] [Assigned] (HBASE-25200) Try enlarge the flaky test timeout for branch-2.2

2020-10-18 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-25200: -- Assignee: Guanghao Zhang > Try enlarge the flaky test timeout for branch-2.2 >

[jira] [Updated] (HBASE-25200) Try enlarge the flaky test timeout for branch-2.2

2020-10-18 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-25200: --- Description: Now there are too many flaky tests to run. And the flaky test job cannot

[GitHub] [hbase] infraio opened a new pull request #2563: HBASE-25200 Try enlarge the flaky test timeout for branch-2.2

2020-10-18 Thread GitBox
infraio opened a new pull request #2563: URL: https://github.com/apache/hbase/pull/2563 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (HBASE-25200) Try enlarge the flaky test timeout for branch-2.2

2020-10-18 Thread Guanghao Zhang (Jira)
Guanghao Zhang created HBASE-25200: -- Summary: Try enlarge the flaky test timeout for branch-2.2 Key: HBASE-25200 URL: https://issues.apache.org/jira/browse/HBASE-25200 Project: HBase Issue

[jira] [Updated] (HBASE-25199) Remove HStore#getStoreHomedir

2020-10-18 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-25199: -- Status: Patch Available (was: In Progress) > Remove HStore#getStoreHomedir >

[GitHub] [hbase] HorizonNet opened a new pull request #2562: HBASE-25199 Remove deprecated HStore#getStoreHomedir methods

2020-10-18 Thread GitBox
HorizonNet opened a new pull request #2562: URL: https://github.com/apache/hbase/pull/2562 Remove the deprecated methods HStore#getStoreHomedir(Path, RegionInfo, byte[]) and HStore#getStoreHomedir(Path, String, byte[]).

[jira] [Created] (HBASE-25199) Remove HStore#getStoreHomedir

2020-10-18 Thread Jan Hentschel (Jira)
Jan Hentschel created HBASE-25199: - Summary: Remove HStore#getStoreHomedir Key: HBASE-25199 URL: https://issues.apache.org/jira/browse/HBASE-25199 Project: HBase Issue Type: Sub-task

[jira] [Work started] (HBASE-25199) Remove HStore#getStoreHomedir

2020-10-18 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25199 started by Jan Hentschel. - > Remove HStore#getStoreHomedir > - > >

[jira] [Updated] (HBASE-25198) Remove RpcSchedulerFactory#create(Configuration, PriorityFunction)

2020-10-18 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-25198: -- Status: Patch Available (was: In Progress) > Remove

[GitHub] [hbase] HorizonNet opened a new pull request #2561: HBASE-25198 Remove deprecated RpcSchedulerFactory#create

2020-10-18 Thread GitBox
HorizonNet opened a new pull request #2561: URL: https://github.com/apache/hbase/pull/2561 Remove the deprecated RpcSchedulerFactory#create(Configuration, PriorityFunction) method from the interface and in all implementing classes.

[jira] [Work started] (HBASE-25198) Remove RpcSchedulerFactory#create(Configuration, PriorityFunction)

2020-10-18 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25198 started by Jan Hentschel. - > Remove RpcSchedulerFactory#create(Configuration, PriorityFunction) >

[jira] [Created] (HBASE-25198) Remove RpcSchedulerFactory#create(Configuration, PriorityFunction)

2020-10-18 Thread Jan Hentschel (Jira)
Jan Hentschel created HBASE-25198: - Summary: Remove RpcSchedulerFactory#create(Configuration, PriorityFunction) Key: HBASE-25198 URL: https://issues.apache.org/jira/browse/HBASE-25198 Project: HBase

[jira] [Updated] (HBASE-25197) Remove SingletonCoprocessorService

2020-10-18 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-25197: -- Status: Patch Available (was: In Progress) > Remove SingletonCoprocessorService >

[GitHub] [hbase] HorizonNet opened a new pull request #2560: HBASE-25197 Remove SingletonCoprocessorService interface

2020-10-18 Thread GitBox
HorizonNet opened a new pull request #2560: URL: https://github.com/apache/hbase/pull/2560 Remove the SingletonCoprocessorService interface targeted for removal in 3.0.0. This is an automated message from the Apache Git

[jira] [Work started] (HBASE-25197) Remove SingletonCoprocessorService

2020-10-18 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25197 started by Jan Hentschel. - > Remove SingletonCoprocessorService > -- >

[jira] [Created] (HBASE-25197) Remove SingletonCoprocessorService

2020-10-18 Thread Jan Hentschel (Jira)
Jan Hentschel created HBASE-25197: - Summary: Remove SingletonCoprocessorService Key: HBASE-25197 URL: https://issues.apache.org/jira/browse/HBASE-25197 Project: HBase Issue Type: Sub-task

[jira] [Updated] (HBASE-25196) Document deprecation of HConstants#REPLICATION_DROP_ON_DELETED_TABLE_KEY

2020-10-18 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-25196: -- Status: Patch Available (was: In Progress) > Document deprecation of

[GitHub] [hbase] HorizonNet opened a new pull request #2559: HBASE-25196 Add deprecation documentation to HConstants

2020-10-18 Thread GitBox
HorizonNet opened a new pull request #2559: URL: https://github.com/apache/hbase/pull/2559 Add the documentation when HConstants#REPLICATION_DROP_ON_DELETED_TABLE_KEY was deprecated and when it is expected to be removed.

[jira] [Created] (HBASE-25196) Document deprecation of HConstants#REPLICATION_DROP_ON_DELETED_TABLE_KEY

2020-10-18 Thread Jan Hentschel (Jira)
Jan Hentschel created HBASE-25196: - Summary: Document deprecation of HConstants#REPLICATION_DROP_ON_DELETED_TABLE_KEY Key: HBASE-25196 URL: https://issues.apache.org/jira/browse/HBASE-25196 Project:

[jira] [Work started] (HBASE-25196) Document deprecation of HConstants#REPLICATION_DROP_ON_DELETED_TABLE_KEY

2020-10-18 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25196 started by Jan Hentschel. - > Document deprecation of HConstants#REPLICATION_DROP_ON_DELETED_TABLE_KEY >

[jira] [Updated] (HBASE-25174) Remove deprecated fields in HConstants which should be removed in 3.0.0

2020-10-18 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-25174: -- Hadoop Flags: Incompatible change Status: Patch Available (was: In Progress) >

[GitHub] [hbase] HorizonNet opened a new pull request #2558: HBASE-25174 Remove deprecated fields in HConstants

2020-10-18 Thread GitBox
HorizonNet opened a new pull request #2558: URL: https://github.com/apache/hbase/pull/2558 Remove the deprecated fields, which can be removed in 3.0.0. Marked the constant OLDEST_TIMESTAMP as InterfaceAudience.Private as it is only use in classes, which are also marked as

[jira] [Commented] (HBASE-25194) Do not publish workspace in flaky find job

2020-10-18 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216264#comment-17216264 ] Duo Zhang commented on HBASE-25194: --- I've created a feature branch and create a special jenkins job

[GitHub] [hbase] semensanyok commented on pull request #2554: HBASE-24490 Revisit onlineRegions and onlineRegionsLock in HRegionServer

2020-10-18 Thread GitBox
semensanyok commented on pull request #2554: URL: https://github.com/apache/hbase/pull/2554#issuecomment-711165679 I believe here is flakey test failure for jdk11 branch? org.apache.hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController2

[GitHub] [hbase] Apache-HBase commented on pull request #2555: HBASE-25193: Add support for row prefix in the WAL Pretty Printer

2020-10-18 Thread GitBox
Apache-HBase commented on pull request #2555: URL: https://github.com/apache/hbase/pull/2555#issuecomment-711144244 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25195) [branch-1] getNumOpenConnections is not effective

2020-10-18 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-25195: -- Description: In MetricsHBaseServerWrapperImpl {code} @Override public int getNumOpenConnections()

[jira] [Updated] (HBASE-25195) [branch-1] getNumOpenConnections is not effective

2020-10-18 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-25195: -- Environment: (was: In MetricsHBaseServerWrapperImpl {code} @Override public int

[GitHub] [hbase] Apache-HBase commented on pull request #2557: HBASE-25195 [branch-1] getNumOpenConnections is not effective

2020-10-18 Thread GitBox
Apache-HBase commented on pull request #2557: URL: https://github.com/apache/hbase/pull/2557#issuecomment-711141722 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] virajjasani commented on a change in pull request #2557: HBASE-25195 [branch-1] getNumOpenConnections is not effective

2020-10-18 Thread GitBox
virajjasani commented on a change in pull request #2557: URL: https://github.com/apache/hbase/pull/2557#discussion_r507056870 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerWrapperImpl.java ## @@ -68,7 +68,7 @@ public int

[GitHub] [hbase] Apache-HBase commented on pull request #2556: HBASE-25193: Add support for row prefix in the WAL Pretty Printer

2020-10-18 Thread GitBox
Apache-HBase commented on pull request #2556: URL: https://github.com/apache/hbase/pull/2556#issuecomment-711139354 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #2556: HBASE-25193: Add support for row prefix in the WAL Pretty Printer

2020-10-18 Thread GitBox
Apache-HBase commented on pull request #2556: URL: https://github.com/apache/hbase/pull/2556#issuecomment-711137974 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2555: HBASE-25193: Add support for row prefix in the WAL Pretty Printer

2020-10-18 Thread GitBox
Apache-HBase commented on pull request #2555: URL: https://github.com/apache/hbase/pull/2555#issuecomment-711129187 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Reidddddd opened a new pull request #2557: HBASE-25195 [branch-1] getNumOpenConnections is not effective

2020-10-18 Thread GitBox
Reidd opened a new pull request #2557: URL: https://github.com/apache/hbase/pull/2557 https://issues.apache.org/jira/browse/HBASE-25195 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (HBASE-25195) [branch-1] getNumOpenConnections is not effective

2020-10-18 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216113#comment-17216113 ] Reid Chan commented on HBASE-25195: --- branch-2+ don't have this issue. > [branch-1]

[jira] [Created] (HBASE-25195) [branch-1] getNumOpenConnections is not effective

2020-10-18 Thread Reid Chan (Jira)
Reid Chan created HBASE-25195: - Summary: [branch-1] getNumOpenConnections is not effective Key: HBASE-25195 URL: https://issues.apache.org/jira/browse/HBASE-25195 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #2556: HBASE-25193: Add support for row prefix in the WAL Pretty Printer

2020-10-18 Thread GitBox
Apache-HBase commented on pull request #2556: URL: https://github.com/apache/hbase/pull/2556#issuecomment-711126385 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Work started] (HBASE-25194) Do not publish workspace in flaky find job

2020-10-18 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25194 started by Duo Zhang. - > Do not publish workspace in flaky find job >

[jira] [Updated] (HBASE-25194) Do not publish workspace in flaky find job

2020-10-18 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25194: -- Description: As said in the parent issue. And I tried to use the publishHTML target on jenkins job

[jira] [Updated] (HBASE-25194) Do not publish workspace in flaky find job

2020-10-18 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25194: -- Description: As said in the parent issue. And I tried to use the publishHTML target on jenkins job

[jira] [Created] (HBASE-25194) Do not publish workspace in flaky find job

2020-10-18 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25194: - Summary: Do not publish workspace in flaky find job Key: HBASE-25194 URL: https://issues.apache.org/jira/browse/HBASE-25194 Project: HBase Issue Type: Sub-task

[jira] [Commented] (HBASE-24936) review Jenkins build artifacts

2020-10-18 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216109#comment-17216109 ] Duo Zhang commented on HBASE-24936: --- OK, I think the problem is the reportDir... At least in

[GitHub] [hbase] sandeepvinayak opened a new pull request #2556: HBASE-25193: Add support for row prefix in the WAL Pretty Printer

2020-10-18 Thread GitBox
sandeepvinayak opened a new pull request #2556: URL: https://github.com/apache/hbase/pull/2556 Currently, the WAL Pretty Printer has an option to filter the keys with an exact match of row. However, it is super useful sometimes to have a row key prefix instead of an exact match.