[GitHub] [hbase] Apache-HBase commented on pull request #2655: HBASE-25127 Enhance PerformanceEvaluation to profile meta replica performance.
Apache-HBase commented on pull request #2655: URL: https://github.com/apache/hbase/pull/2655#issuecomment-727528884 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 10s | branch-2 passed | | +1 :green_heart: | compile | 0m 55s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 44s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 46s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 47s | the patch passed | | +1 :green_heart: | compile | 0m 52s | the patch passed | | +1 :green_heart: | javac | 0m 52s | the patch passed | | +1 :green_heart: | shadedjars | 6m 34s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 42s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 31s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 16m 0s | hbase-mapreduce in the patch passed. | | | | 46m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2655/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2655 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f5887ba5ebb7 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 4b9a14d9f3 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2655/1/testReport/ | | Max. process+thread count | 3307 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-mapreduce U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2655/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2655: HBASE-25127 Enhance PerformanceEvaluation to profile meta replica performance.
Apache-HBase commented on pull request #2655: URL: https://github.com/apache/hbase/pull/2655#issuecomment-727528482 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 13s | branch-2 passed | | +1 :green_heart: | compile | 0m 59s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 42s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 51s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 55s | the patch passed | | +1 :green_heart: | compile | 0m 59s | the patch passed | | +1 :green_heart: | javac | 0m 59s | the patch passed | | +1 :green_heart: | shadedjars | 6m 42s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 50s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 28s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 10m 56s | hbase-mapreduce in the patch passed. | | | | 42m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2655/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2655 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 1118bc674b5c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 4b9a14d9f3 | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2655/1/testReport/ | | Max. process+thread count | 3552 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-mapreduce U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2655/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2655: HBASE-25127 Enhance PerformanceEvaluation to profile meta replica performance.
Apache-HBase commented on pull request #2655: URL: https://github.com/apache/hbase/pull/2655#issuecomment-727528209 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 10s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 1s | branch-2 passed | | +1 :green_heart: | spotbugs | 2m 5s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 38s | the patch passed | | +1 :green_heart: | checkstyle | 0m 58s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 13m 19s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 47s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. | | | | 39m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2655/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2655 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 5b575a394a89 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 4b9a14d9f3 | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-mapreduce U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2655/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] clarax commented on pull request #2655: HBASE-25127 Enhance PerformanceEvaluation to profile meta replica performance.
clarax commented on pull request #2655: URL: https://github.com/apache/hbase/pull/2655#issuecomment-727525070 Back port to branch 2 with added changed to open access to MetaAccessor.makeDeleteFromRegionInfo. This change was part of https://issues.apache.org/jira/browse/HBASE-24633 checked into master but not back ported. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] clarax opened a new pull request #2655: HBASE-25127 Enhance PerformanceEvaluation to profile meta replica performance.
clarax opened a new pull request #2655: URL: https://github.com/apache/hbase/pull/2655 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] clarax closed pull request #2654: Branch 2
clarax closed pull request #2654: URL: https://github.com/apache/hbase/pull/2654 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] clarax opened a new pull request #2654: Branch 2
clarax opened a new pull request #2654: URL: https://github.com/apache/hbase/pull/2654 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-18070) Enable memstore replication for meta replica
[ https://issues.apache.org/jira/browse/HBASE-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17232161#comment-17232161 ] Andrew Kyle Purtell commented on HBASE-18070: - 👍 > Enable memstore replication for meta replica > > > Key: HBASE-18070 > URL: https://issues.apache.org/jira/browse/HBASE-18070 > Project: HBase > Issue Type: New Feature >Reporter: Hua Xiang >Assignee: Huaxiang Sun >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.4.0, HBASE-18070, HBASE-18070.branch-2 > > > Based on the current doc, memstore replication is not enabled for meta > replica. Memstore replication will be a good improvement for meta replica. > Create jira to track this effort (feasibility, design, implementation, etc). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-18070) Enable memstore replication for meta replica
[ https://issues.apache.org/jira/browse/HBASE-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17232160#comment-17232160 ] Michael Stack commented on HBASE-18070: --- Sorry for being unclear [~apurtell] . Was thinking of merging to branch-2 just after merging to master (Monday night I hope). I put up notice on dev list this morning. That work sir? > Enable memstore replication for meta replica > > > Key: HBASE-18070 > URL: https://issues.apache.org/jira/browse/HBASE-18070 > Project: HBase > Issue Type: New Feature >Reporter: Hua Xiang >Assignee: Huaxiang Sun >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.4.0, HBASE-18070, HBASE-18070.branch-2 > > > Based on the current doc, memstore replication is not enabled for meta > replica. Memstore replication will be a good improvement for meta replica. > Create jira to track this effort (feasibility, design, implementation, etc). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-18070) Enable memstore replication for meta replica
[ https://issues.apache.org/jira/browse/HBASE-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17232130#comment-17232130 ] Andrew Kyle Purtell commented on HBASE-18070: - I’m not sure I follow exactly. Can you tell me assuming the test results are acceptable when or if you plan to merge this to branch-2? > Enable memstore replication for meta replica > > > Key: HBASE-18070 > URL: https://issues.apache.org/jira/browse/HBASE-18070 > Project: HBase > Issue Type: New Feature >Reporter: Hua Xiang >Assignee: Huaxiang Sun >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.4.0, HBASE-18070, HBASE-18070.branch-2 > > > Based on the current doc, memstore replication is not enabled for meta > replica. Memstore replication will be a good improvement for meta replica. > Create jira to track this effort (feasibility, design, implementation, etc). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25127) Enhance PerformanceEvaluation to profile meta replica performance.
[ https://issues.apache.org/jira/browse/HBASE-25127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25127: -- Fix Version/s: (was: 2.4.0) > Enhance PerformanceEvaluation to profile meta replica performance. > -- > > Key: HBASE-25127 > URL: https://issues.apache.org/jira/browse/HBASE-25127 > Project: HBase > Issue Type: Sub-task >Reporter: Huaxiang Sun >Assignee: Clara Xiong >Priority: Major > Fix For: 3.0.0-alpha-1 > > Attachments: Screen Shot 2020-11-13 at 5.30.11 PM.png > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25127) Enhance PerformanceEvaluation to profile meta replica performance.
[ https://issues.apache.org/jira/browse/HBASE-25127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17232120#comment-17232120 ] Michael Stack commented on HBASE-25127: --- Oh, reverted from branch-2 for now. It fails to compile. We can deal w/ backport later. Removing 2.4.0 from fix version for now. > Enhance PerformanceEvaluation to profile meta replica performance. > -- > > Key: HBASE-25127 > URL: https://issues.apache.org/jira/browse/HBASE-25127 > Project: HBase > Issue Type: Sub-task >Reporter: Huaxiang Sun >Assignee: Clara Xiong >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0 > > Attachments: Screen Shot 2020-11-13 at 5.30.11 PM.png > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25127) Enhance PerformanceEvaluation to profile meta replica performance.
[ https://issues.apache.org/jira/browse/HBASE-25127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17232115#comment-17232115 ] Clara Xiong commented on HBASE-25127: - Thank you Stack. Before test: |hbase:meta,,1.1588230740|node135|449,741,042| |hbase:meta,,1_0001.534574363|node135|105,998,821| |hbase:meta,,1_0002.1657623790|node135|106,028,871| |hbase:meta,,1_0003.1072483532|node011|105,991,787| After test run: hbase pe -Dhbase.locator.meta.replicas.mode=LoadBalance --nomapreduce --rows=10 metaRandomRead 80 |base:meta,,1.1588230740|node135|457,129,447| |hbase:meta,,1_0001.534574363|node135|119,333,539| |hbase:meta,,1_0002.1657623790|node135|119,362,874| |hbase:meta,,1_0003.1072483532|node011|119,322,271| Delta: |base:meta,,1.1588230740|node135|7,388,405| |hbase:meta,,1_0001.534574363|node135|13,334,718| |hbase:meta,,1_0002.1657623790|node135|13,334,003| |hbase:meta,,1_0003.1072483532|node011|13,330,484| > Enhance PerformanceEvaluation to profile meta replica performance. > -- > > Key: HBASE-25127 > URL: https://issues.apache.org/jira/browse/HBASE-25127 > Project: HBase > Issue Type: Sub-task >Reporter: Huaxiang Sun >Assignee: Clara Xiong >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0 > > Attachments: Screen Shot 2020-11-13 at 5.30.11 PM.png > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25127) Enhance PerformanceEvaluation to profile meta replica performance.
[ https://issues.apache.org/jira/browse/HBASE-25127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17232112#comment-17232112 ] Michael Stack commented on HBASE-25127: --- I merged the associated PR to master and branch-2. > Enhance PerformanceEvaluation to profile meta replica performance. > -- > > Key: HBASE-25127 > URL: https://issues.apache.org/jira/browse/HBASE-25127 > Project: HBase > Issue Type: Sub-task >Reporter: Huaxiang Sun >Assignee: Clara Xiong >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0 > > Attachments: Screen Shot 2020-11-13 at 5.30.11 PM.png > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] saintstack merged pull request #2644: HBASE-25127 Enhance PerformanceEvaluation to profile meta replica performance.
saintstack merged pull request #2644: URL: https://github.com/apache/hbase/pull/2644 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-25273) fix typo in StripeStoreFileManager java doc
[ https://issues.apache.org/jira/browse/HBASE-25273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel resolved HBASE-25273. --- Fix Version/s: 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed Pushed to master. Thanks [~hossein] for the contribution. > fix typo in StripeStoreFileManager java doc > --- > > Key: HBASE-25273 > URL: https://issues.apache.org/jira/browse/HBASE-25273 > Project: HBase > Issue Type: Improvement >Reporter: Hossein Zolfi >Priority: Major > Fix For: 3.0.0-alpha-1 > > > See StripeCompactionPolicy on how the stripes are determined; this class > doesn't care. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] HorizonNet merged pull request #2653: HBASE-25273 fix typo in StripeStoreFileManager java doc
HorizonNet merged pull request #2653: URL: https://github.com/apache/hbase/pull/2653 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25127) Enhance PerformanceEvaluation to profile meta replica performance.
[ https://issues.apache.org/jira/browse/HBASE-25127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17232088#comment-17232088 ] Michael Stack commented on HBASE-25127: --- Do you have a picture of the UI read requests showing how the reads are distributed across replicas and primary [~clarax98007] ? (Generally we don't resolve until the PR lands, FYI – let me merge it) > Enhance PerformanceEvaluation to profile meta replica performance. > -- > > Key: HBASE-25127 > URL: https://issues.apache.org/jira/browse/HBASE-25127 > Project: HBase > Issue Type: Sub-task >Reporter: Huaxiang Sun >Assignee: Clara Xiong >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0 > > Attachments: Screen Shot 2020-11-13 at 5.30.11 PM.png > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-25284) Check-in "Enable memstore replication..." design
[ https://issues.apache.org/jira/browse/HBASE-25284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25284. --- Fix Version/s: 2.4.0 3.0.0-alpha-1 Assignee: Michael Stack Resolution: Fixed Pushed to master and branch-2. > Check-in "Enable memstore replication..." design > > > Key: HBASE-25284 > URL: https://issues.apache.org/jira/browse/HBASE-25284 > Project: HBase > Issue Type: Sub-task >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0 > > > Add the design doc under dev-support/design-docs -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-25284) Check-in "Enable memstore replication..." design
Michael Stack created HBASE-25284: - Summary: Check-in "Enable memstore replication..." design Key: HBASE-25284 URL: https://issues.apache.org/jira/browse/HBASE-25284 Project: HBase Issue Type: Sub-task Reporter: Michael Stack Add the design doc under dev-support/design-docs -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-25283) Undo meta replica specialization inside of the region replica framework
Michael Stack created HBASE-25283:
-
Summary: Undo meta replica specialization inside of the region
replica framework
Key: HBASE-25283
URL: https://issues.apache.org/jira/browse/HBASE-25283
Project: HBase
Issue Type: Improvement
Components: read replicas
Reporter: Michael Stack
Filing an issue to capture a [~zhangduo] suggestion made in PR that was then
carried to a comment over in the design document attached to HBASE-18070 only
it is deserving of its own issue.
{quote}
I do not like that we have a specialized implementation for meta replica inside
the region replica framework. They are almost the same so they should share the
same code base. I think this enhancement could also be applied to normal
RegionReplicaReplicationEndpoint, what we need is the config for the max
distance between different secondary replicas. For normal region replicas, the
value will be small, which means we will soon block the replication if any
replicas are slow, to save memory. For meta replicas, we could have a large
default value to let the good replicas catch up fast.
{quote}
Lets use this issue to fill out more on what [~zhangduo] suggests above.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25255) Master fails to initialize when creating rs group table
[
https://issues.apache.org/jira/browse/HBASE-25255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17232010#comment-17232010
]
Hudson commented on HBASE-25255:
Results for branch master
[build #125 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/125/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/125/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/125/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/125/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Master fails to initialize when creating rs group table
> ---
>
> Key: HBASE-25255
> URL: https://issues.apache.org/jira/browse/HBASE-25255
> Project: HBase
> Issue Type: Bug
> Components: master, rsgroup
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Critical
> Fix For: 3.0.0-alpha-1, 2.4.0, 2.2.7, 2.3.4
>
> Attachments:
> TEST-org.apache.hadoop.hbase.rsgroup.TestRSGroupsKillRS.xml
>
>
> Saw this when setup TestRSGroupsKillRS
> {noformat}
> 2020-11-07 16:29:54,565 ERROR [master/e476f4f509a7:0:becomeActiveMaster]
> helpers.MarkerIgnoringBase(159): Failed to become active master
> java.lang.AssertionError
> at
> org.apache.hadoop.hbase.master.assignment.RegionStateNode.setProcedure(RegionStateNode.java:198)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.createAssignProcedure(AssignmentManager.java:647)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.lambda$null$6(AssignmentManager.java:878)
> at
> java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
> at
> java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
> at
> java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1382)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482)
> at
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
> at
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
> at
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
> at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
> at
> java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:272)
> at
> java.util.HashMap$EntrySpliterator.forEachRemaining(HashMap.java:1699)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482)
> at
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
> at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:546)
> at
> java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:260)
> at
> java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:505)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.createAssignProcedures(AssignmentManager.java:879)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.createRoundRobinAssignProcedures(AssignmentManager.java:759)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.createRoundRobinAssignProcedures(AssignmentManager.java:775)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.processOfflineRegions(AssignmentManager.java:1513)
> at
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1012)
> at
> org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2116)
> at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:515)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2653: HBASE-25273 fix typo in StripeStoreFileManager java doc
Apache-HBase commented on pull request #2653: URL: https://github.com/apache/hbase/pull/2653#issuecomment-727186435 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 44s | master passed | | +1 :green_heart: | compile | 0m 59s | master passed | | +1 :green_heart: | shadedjars | 6m 39s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 25s | the patch passed | | +1 :green_heart: | compile | 0m 58s | the patch passed | | +1 :green_heart: | javac | 0m 57s | the patch passed | | +1 :green_heart: | shadedjars | 6m 36s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 139m 9s | hbase-server in the patch passed. | | | | 165m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2653/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2653 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2be14b122ad6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 09aaa68be4 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2653/1/testReport/ | | Max. process+thread count | 4796 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2653/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2653: HBASE-25273 fix typo in StripeStoreFileManager java doc
Apache-HBase commented on pull request #2653: URL: https://github.com/apache/hbase/pull/2653#issuecomment-727185734 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 15s | master passed | | +1 :green_heart: | compile | 1m 5s | master passed | | +1 :green_heart: | shadedjars | 6m 42s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 5s | the patch passed | | +1 :green_heart: | compile | 1m 5s | the patch passed | | +1 :green_heart: | javac | 1m 5s | the patch passed | | +1 :green_heart: | shadedjars | 6m 46s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 132m 11s | hbase-server in the patch passed. | | | | 160m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2653/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2653 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 76e4233b952c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 09aaa68be4 | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2653/1/testReport/ | | Max. process+thread count | 4586 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2653/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2653: HBASE-25273 fix typo in StripeStoreFileManager java doc
Apache-HBase commented on pull request #2653: URL: https://github.com/apache/hbase/pull/2653#issuecomment-727169665 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 28s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 11s | master passed | | +1 :green_heart: | checkstyle | 1m 13s | master passed | | +1 :green_heart: | spotbugs | 2m 7s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 44s | the patch passed | | +1 :green_heart: | checkstyle | 1m 11s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 18m 54s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 2m 17s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 43m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2653/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2653 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 2089b898d5ac 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 09aaa68be4 | | Max. process+thread count | 84 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2653/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] empire commented on a change in pull request #2646: HBASE-25273 fix typo in StripeStoreFileManager java doc
empire commented on a change in pull request #2646: URL: https://github.com/apache/hbase/pull/2646#discussion_r523392529 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFileManager.java ## @@ -56,7 +56,7 @@ * When L0 is compacted, it's split into the files corresponding to existing stripe boundaries, * that can thus be added to stripes. * When scan or get happens, it only has to read the files from the corresponding stripes. - * See StripeCompationPolicy on how the stripes are determined; this class doesn't care. + * See StripeCompactionPolicy on how the stripes are determined; this class doesn't care. Review comment: I've done your comment in that pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] empire commented on a change in pull request #2646: HBASE-25273 fix typo in StripeStoreFileManager java doc
empire commented on a change in pull request #2646: URL: https://github.com/apache/hbase/pull/2646#discussion_r523392507 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFileManager.java ## @@ -56,7 +56,7 @@ * When L0 is compacted, it's split into the files corresponding to existing stripe boundaries, * that can thus be added to stripes. * When scan or get happens, it only has to read the files from the corresponding stripes. - * See StripeCompationPolicy on how the stripes are determined; this class doesn't care. + * See StripeCompactionPolicy on how the stripes are determined; this class doesn't care. Review comment: @HorizonNet, I made a mistake and this pull request was closed and a [new pull request](https://github.com/apache/hbase/pull/2653) is opened. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25273) fix typo in StripeStoreFileManager java doc
[ https://issues.apache.org/jira/browse/HBASE-25273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hossein Zolfi updated HBASE-25273: -- External issue URL: https://github.com/apache/hbase/pull/2653 (was: https://github.com/apache/hbase/pull/2646) > fix typo in StripeStoreFileManager java doc > --- > > Key: HBASE-25273 > URL: https://issues.apache.org/jira/browse/HBASE-25273 > Project: HBase > Issue Type: Improvement >Reporter: Hossein Zolfi >Priority: Major > > See StripeCompactionPolicy on how the stripes are determined; this class > doesn't care. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] empire opened a new pull request #2653: HBASE-25273 fix typo in StripeStoreFileManager java doc
empire opened a new pull request #2653: URL: https://github.com/apache/hbase/pull/2653 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
