[GitHub] [hbase] cuibo01 commented on pull request #2690: HBASE-24395 backport HBASE-20589

2020-11-21 Thread GitBox
cuibo01 commented on pull request #2690: URL: https://github.com/apache/hbase/pull/2690#issuecomment-731706228 ![image](https://user-images.githubusercontent.com/36881649/99896840-3e4cb900-2ccf-11eb-83fb-222fd85f85d6.png)

[GitHub] [hbase] Apache-HBase commented on pull request #2630: HBASE-25242 Add Increment/Append support to RowMutations

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2630: URL: https://github.com/apache/hbase/pull/2630#issuecomment-731705982 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Assigned] (HBASE-24395) ServerName#getHostname() is case sensitive

2020-11-21 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui reassigned HBASE-24395: -- Assignee: Bo Cui > ServerName#getHostname() is case sensitive >

[GitHub] [hbase] Apache-HBase commented on pull request #2630: HBASE-25242 Add Increment/Append support to RowMutations

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2630: URL: https://github.com/apache/hbase/pull/2630#issuecomment-731702162 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2688: HBASE-25311 UI throws NPE

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2688: URL: https://github.com/apache/hbase/pull/2688#issuecomment-731694716 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2630: HBASE-25242 Add Increment/Append support to RowMutations

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2630: URL: https://github.com/apache/hbase/pull/2630#issuecomment-731692206 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-23035) Retain region to the last RegionServer make the failover slower

2020-11-21 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-23035: Component/s: amv2 > Retain region to the last RegionServer make the failover slower >

[jira] [Updated] (HBASE-21565) Delete dead server from dead server list too early leads to concurrent Server Crash Procedures(SCP) for a same server

2020-11-21 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-21565: Component/s: amv2 > Delete dead server from dead server list too early leads to concurrent Server

[GitHub] [hbase] saintstack commented on a change in pull request #2690: HBASE-24395 backport HBASE-20589

2020-11-21 Thread GitBox
saintstack commented on a change in pull request #2690: URL: https://github.com/apache/hbase/pull/2690#discussion_r528271857 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java ## @@ -1251,9 +1251,7 @@ protected void

[GitHub] [hbase] brfrn169 commented on pull request #2630: HBASE-25242 Add Increment/Append support to RowMutations

2020-11-21 Thread GitBox
brfrn169 commented on pull request #2630: URL: https://github.com/apache/hbase/pull/2630#issuecomment-731673410 I made a mistake and the compile in the last QA failed.. Just fixed it and pushed the latest patch. This is an

[jira] [Commented] (HBASE-25284) Check-in "Enable memstore replication..." design

2020-11-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236830#comment-17236830 ] Hudson commented on HBASE-25284: Results for branch branch-2 [build #107 on

[GitHub] [hbase] Apache-HBase commented on pull request #2688: HBASE-25311 UI throws NPE

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2688: URL: https://github.com/apache/hbase/pull/2688#issuecomment-731664744 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2630: HBASE-25242 Add Increment/Append support to RowMutations

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2630: URL: https://github.com/apache/hbase/pull/2630#issuecomment-731662752 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2630: HBASE-25242 Add Increment/Append support to RowMutations

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2630: URL: https://github.com/apache/hbase/pull/2630#issuecomment-731662701 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2630: HBASE-25242 Add Increment/Append support to RowMutations

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2630: URL: https://github.com/apache/hbase/pull/2630#issuecomment-731661920 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] cuibo01 closed pull request #2689: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

2020-11-21 Thread GitBox
cuibo01 closed pull request #2689: URL: https://github.com/apache/hbase/pull/2689 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] cuibo01 closed pull request #2689: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

2020-11-21 Thread GitBox
cuibo01 closed pull request #2689: URL: https://github.com/apache/hbase/pull/2689 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] cuibo01 commented on a change in pull request #2688: HBASE-25311 UI throws NPE

2020-11-21 Thread GitBox
cuibo01 commented on a change in pull request #2688: URL: https://github.com/apache/hbase/pull/2688#discussion_r528264879 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -3621,8 +3621,15 @@ public ReplicationPeerManager

[GitHub] [hbase] brfrn169 commented on pull request #2630: HBASE-25242 Add Increment/Append support to RowMutations

2020-11-21 Thread GitBox
brfrn169 commented on pull request #2630: URL: https://github.com/apache/hbase/pull/2630#issuecomment-731659869 I just changed the patch regarding the following: - Add testing for Append and keep the last else branch throwing DoNotRetryIOException - Use DoNotRetryIOException instead

[GitHub] [hbase] Apache-HBase commented on pull request #2689: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2689: URL: https://github.com/apache/hbase/pull/2689#issuecomment-731637535 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2678: HBASE-25083 further HBase 1.y releases should have Hadoop 2.10 as a minimum version.

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2678: URL: https://github.com/apache/hbase/pull/2678#issuecomment-731636614 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2689: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2689: URL: https://github.com/apache/hbase/pull/2689#issuecomment-731630451 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2689: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2689: URL: https://github.com/apache/hbase/pull/2689#issuecomment-731614097 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on a change in pull request #2688: HBASE-25311 UI throws NPE

2020-11-21 Thread GitBox
virajjasani commented on a change in pull request #2688: URL: https://github.com/apache/hbase/pull/2688#discussion_r528223952 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -3621,8 +3621,15 @@ public ReplicationPeerManager

[jira] [Commented] (HBASE-25280) [meta replicas] ArrayIndexOutOfBoundsException in ZKConnectionRegistry

2020-11-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236748#comment-17236748 ] Hudson commented on HBASE-25280: Results for branch branch-2 [build #106 on

[jira] [Commented] (HBASE-25055) Add ReplicationSource for meta WALs; add enable/disable when hbase:meta assigned to RS

2020-11-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236746#comment-17236746 ] Hudson commented on HBASE-25055: Results for branch branch-2 [build #106 on

[jira] [Commented] (HBASE-25151) warmupRegion frustrates registering WALs on the catalog replicationsource

2020-11-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236747#comment-17236747 ] Hudson commented on HBASE-25151: Results for branch branch-2 [build #106 on

[jira] [Commented] (HBASE-25291) Document how to enable the meta replica load balance mode for the client and clean up around hbase:meta read replicas

2020-11-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236750#comment-17236750 ] Hudson commented on HBASE-25291: Results for branch branch-2 [build #106 on

[jira] [Commented] (HBASE-25126) Add load balance logic in hbase-client to distribute read load over meta replica regions.

2020-11-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236749#comment-17236749 ] Hudson commented on HBASE-25126: Results for branch branch-2 [build #106 on

[jira] [Commented] (HBASE-25068) Pass WALFactory to Replication so it knows of all WALProviders, not just default/user-space

2020-11-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236745#comment-17236745 ] Hudson commented on HBASE-25068: Results for branch branch-2 [build #106 on

[GitHub] [hbase] Apache-HBase commented on pull request #2511: HBASE-24960 reduce invalid subprocedure task

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2511: URL: https://github.com/apache/hbase/pull/2511#issuecomment-731608764 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2689: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2689: URL: https://github.com/apache/hbase/pull/2689#issuecomment-731607935 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-18070) Enable memstore replication for meta replica

2020-11-21 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-18070. --- Fix Version/s: (was: HBASE-18070.branch-2) (was: HBASE-18070)

[jira] [Commented] (HBASE-18070) Enable memstore replication for meta replica

2020-11-21 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236729#comment-17236729 ] Michael Stack commented on HBASE-18070: --- The last subtask has just been committed – updating the

[jira] [Resolved] (HBASE-25284) Check-in "Enable memstore replication..." design

2020-11-21 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25284. --- Hadoop Flags: Reviewed Resolution: Fixed Re-resolving after updating the already

[jira] [Commented] (HBASE-25284) Check-in "Enable memstore replication..." design

2020-11-21 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236725#comment-17236725 ] Michael Stack commented on HBASE-25284: --- I updated again to pick up the new fixes and then pushed.

[GitHub] [hbase] saintstack merged pull request #2680: HBASE-25284 Check-in "Enable memstore replication..." design; ADDENDUM

2020-11-21 Thread GitBox
saintstack merged pull request #2680: URL: https://github.com/apache/hbase/pull/2680 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #2680: HBASE-25284 Check-in "Enable memstore replication..." design; ADDENDUM

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2680: URL: https://github.com/apache/hbase/pull/2680#issuecomment-731602828 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2680: HBASE-25284 Check-in "Enable memstore replication..." design; ADDENDUM

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2680: URL: https://github.com/apache/hbase/pull/2680#issuecomment-731602788 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2680: HBASE-25284 Check-in "Enable memstore replication..." design; ADDENDUM

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2680: URL: https://github.com/apache/hbase/pull/2680#issuecomment-731602724 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] brfrn169 commented on a change in pull request #2630: HBASE-25242 Add Increment/Append support to RowMutations

2020-11-21 Thread GitBox
brfrn169 commented on a change in pull request #2630: URL: https://github.com/apache/hbase/pull/2630#discussion_r528213068 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CheckAndMutate.java ## @@ -60,7 +53,7 @@ */ @InterfaceAudience.Public

[GitHub] [hbase] saintstack commented on pull request #2680: HBASE-25284 Check-in "Enable memstore replication..." design; ADDENDUM

2020-11-21 Thread GitBox
saintstack commented on pull request #2680: URL: https://github.com/apache/hbase/pull/2680#issuecomment-731602570 Updated the PR w/ latest edits. Let me merge. Thanks for the reviews lads. This is an automated message from

[GitHub] [hbase] Apache-HBase commented on pull request #2511: HBASE-24960 reduce invalid subprocedure task

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2511: URL: https://github.com/apache/hbase/pull/2511#issuecomment-731600915 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2689: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2689: URL: https://github.com/apache/hbase/pull/2689#issuecomment-731600233 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 commented on a change in pull request #2630: HBASE-25242 Add Increment/Append support to RowMutations

2020-11-21 Thread GitBox
Apache9 commented on a change in pull request #2630: URL: https://github.com/apache/hbase/pull/2630#discussion_r528207034 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ResponseConverter.java ## @@ -158,52 +156,30 @@ public static

[GitHub] [hbase] Apache9 commented on a change in pull request #2630: HBASE-25242 Add Increment/Append support to RowMutations

2020-11-21 Thread GitBox
Apache9 commented on a change in pull request #2630: URL: https://github.com/apache/hbase/pull/2630#discussion_r528205873 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java ## @@ -620,8 +622,22 @@ private CheckAndMutateResult

[jira] [Commented] (HBASE-25313) [branch-1] Fix the broken pre-commit

2020-11-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236683#comment-17236683 ] Hudson commented on HBASE-25313: Results for branch branch-1 [build #56 on

[GitHub] [hbase] Apache9 commented on a change in pull request #2630: HBASE-25242 Add Increment/Append support to RowMutations

2020-11-21 Thread GitBox
Apache9 commented on a change in pull request #2630: URL: https://github.com/apache/hbase/pull/2630#discussion_r528205625 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CheckAndMutate.java ## @@ -60,7 +53,7 @@ */ @InterfaceAudience.Public

[GitHub] [hbase] Apache9 commented on a change in pull request #2630: HBASE-25242 Add Increment/Append support to RowMutations

2020-11-21 Thread GitBox
Apache9 commented on a change in pull request #2630: URL: https://github.com/apache/hbase/pull/2630#discussion_r528205391 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java ## @@ -3657,9 +3657,10 @@ public static CheckAndMutate

[GitHub] [hbase] Apache-HBase commented on pull request #2689: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2689: URL: https://github.com/apache/hbase/pull/2689#issuecomment-731585302 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2511: HBASE-24960 reduce invalid subprocedure task

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2511: URL: https://github.com/apache/hbase/pull/2511#issuecomment-731584179 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2511: HBASE-24960 reduce invalid subprocedure task

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2511: URL: https://github.com/apache/hbase/pull/2511#issuecomment-731578669 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2688: HBASE-25311 UI throws NPE

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2688: URL: https://github.com/apache/hbase/pull/2688#issuecomment-731577441 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2688: HBASE-25311 UI throws NPE

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2688: URL: https://github.com/apache/hbase/pull/2688#issuecomment-731576832 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2689: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2689: URL: https://github.com/apache/hbase/pull/2689#issuecomment-731572210 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2690: HBASE-24395 backport HBASE-20589

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2690: URL: https://github.com/apache/hbase/pull/2690#issuecomment-731571751 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[jira] [Updated] (HBASE-25281) Bulkload split hfile too many times due to unreasonable split point

2020-11-21 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] niuyulin updated HBASE-25281: - Description:

[GitHub] [hbase] Apache-HBase commented on pull request #2511: HBASE-24960 reduce invalid subprocedure task

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2511: URL: https://github.com/apache/hbase/pull/2511#issuecomment-731567556 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25281) Bulkload split hfile too many times due to unreasonable split point

2020-11-21 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] niuyulin updated HBASE-25281: - Description:

[jira] [Updated] (HBASE-25281) Bulkload split hfile too many times due to unreasonable split point

2020-11-21 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] niuyulin updated HBASE-25281: - Description:

[GitHub] [hbase] Apache-HBase commented on pull request #2689: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2689: URL: https://github.com/apache/hbase/pull/2689#issuecomment-731566085 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25213) Should request Compaction when bulkLoadHFiles is done

2020-11-21 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236642#comment-17236642 ] niuyulin commented on HBASE-25213: -- of course, I have submitted another PR for branch-2 [~zghao] >

[GitHub] [hbase] nyl3532016 commented on pull request #2684: Backport HBASE-25213 Should request Compaction after bulkLoadHFiles is done

2020-11-21 Thread GitBox
nyl3532016 commented on pull request #2684: URL: https://github.com/apache/hbase/pull/2684#issuecomment-731565809 test failed not related. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] wchevreuil commented on a change in pull request #2667: HBASE-25281 Bulkload split hfile too many times due to unreasonable split point

2020-11-21 Thread GitBox
wchevreuil commented on a change in pull request #2667: URL: https://github.com/apache/hbase/pull/2667#discussion_r528182565 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/tool/BulkLoadHFilesTool.java ## @@ -647,51 +684,24 @@ private String getUniqueName() {

[GitHub] [hbase] Apache-HBase commented on pull request #2688: HBASE-25311 UI throws NPE

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2688: URL: https://github.com/apache/hbase/pull/2688#issuecomment-731562787 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2688: HBASE-25311 UI throws NPE

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2688: URL: https://github.com/apache/hbase/pull/2688#issuecomment-731558509 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2688: HBASE-25311 UI throws NPE

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2688: URL: https://github.com/apache/hbase/pull/2688#issuecomment-731558378 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] cuibo01 opened a new pull request #2511: HBASE-24960 reduce invalid subprocedure task

2020-11-21 Thread GitBox
cuibo01 opened a new pull request #2511: URL: https://github.com/apache/hbase/pull/2511 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] cuibo01 removed a comment on pull request #2511: HBASE-24960 reduce invalid subprocedure task

2020-11-21 Thread GitBox
cuibo01 removed a comment on pull request #2511: URL: https://github.com/apache/hbase/pull/2511#issuecomment-731556733 > 我的评论从+1更改为修正检查样式并测试投诉。谢谢。 > Changed my review from +1 to fix the checkstyle and test complaints. Thanks.

[GitHub] [hbase] cuibo01 closed pull request #2511: HBASE-24960 reduce invalid subprocedure task

2020-11-21 Thread GitBox
cuibo01 closed pull request #2511: URL: https://github.com/apache/hbase/pull/2511 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] cuibo01 commented on pull request #2511: HBASE-24960 reduce invalid subprocedure task

2020-11-21 Thread GitBox
cuibo01 commented on pull request #2511: URL: https://github.com/apache/hbase/pull/2511#issuecomment-731556733 > 我的评论从+1更改为修正检查样式并测试投诉。谢谢。 > Changed my review from +1 to fix the checkstyle and test complaints. Thanks.

[jira] [Commented] (HBASE-24395) ServerName#getHostname() is case sensitive

2020-11-21 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236622#comment-17236622 ] Bo Cui commented on HBASE-24395: [https://github.com/apache/hbase/pull/2690] update >

[GitHub] [hbase] cuibo01 opened a new pull request #2690: HBASE-24395 backport HBASE-20589

2020-11-21 Thread GitBox
cuibo01 opened a new pull request #2690: URL: https://github.com/apache/hbase/pull/2690 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] Apache-HBase commented on pull request #2511: HBASE-24960 reduce invalid subprocedure task

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2511: URL: https://github.com/apache/hbase/pull/2511#issuecomment-731552920 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2689: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2689: URL: https://github.com/apache/hbase/pull/2689#issuecomment-731550915 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization

2020-11-21 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236614#comment-17236614 ] Bo Cui commented on HBASE-24924: {quote} You still do not answer my question... How could this happen

[GitHub] [hbase] cuibo01 commented on a change in pull request #2352: HBASE-24925 SCP reduce unnecessary get requests

2020-11-21 Thread GitBox
cuibo01 commented on a change in pull request #2352: URL: https://github.com/apache/hbase/pull/2352#discussion_r528169267 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableStateManager.java ## @@ -318,4 +326,39 @@ protected void

[GitHub] [hbase] cuibo01 commented on a change in pull request #2352: HBASE-24925 SCP reduce unnecessary get requests

2020-11-21 Thread GitBox
cuibo01 commented on a change in pull request #2352: URL: https://github.com/apache/hbase/pull/2352#discussion_r528168990 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java ## @@ -1556,6 +1556,7 @@ public RegionInfo

[jira] [Updated] (HBASE-23340) hmaster /hbase/replication/rs session expired (hbase replication default value is true, we don't use ) causes logcleaner can not clean oldWALs, which resulits in oldWA

2020-11-21 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui updated HBASE-23340: --- Status: Patch Available (was: Open) > hmaster /hbase/replication/rs session expired (hbase replication

[jira] [Updated] (HBASE-25311) ui throws NPE

2020-11-21 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui updated HBASE-25311: --- Status: Patch Available (was: Open) > ui throws NPE > - > > Key: HBASE-25311 >

[GitHub] [hbase] cuibo01 opened a new pull request #2689: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

2020-11-21 Thread GitBox
cuibo01 opened a new pull request #2689: URL: https://github.com/apache/hbase/pull/2689 …ication default value is true, we don't use ) causes logcleaner can not clean oldWALs, which resulits in oldWALs too large (more than 2TB)

[GitHub] [hbase] Apache-HBase commented on pull request #2688: HBASE-25311 UI throws NPE

2020-11-21 Thread GitBox
Apache-HBase commented on pull request #2688: URL: https://github.com/apache/hbase/pull/2688#issuecomment-731525655 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m