cuibo01 commented on pull request #2690:
URL: https://github.com/apache/hbase/pull/2690#issuecomment-731706228
![image](https://user-images.githubusercontent.com/36881649/99896840-3e4cb900-2ccf-11eb-83fb-222fd85f85d6.png)
Apache-HBase commented on pull request #2630:
URL: https://github.com/apache/hbase/pull/2630#issuecomment-731705982
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
[
https://issues.apache.org/jira/browse/HBASE-24395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bo Cui reassigned HBASE-24395:
--
Assignee: Bo Cui
> ServerName#getHostname() is case sensitive
>
Apache-HBase commented on pull request #2630:
URL: https://github.com/apache/hbase/pull/2630#issuecomment-731702162
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2688:
URL: https://github.com/apache/hbase/pull/2688#issuecomment-731694716
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2630:
URL: https://github.com/apache/hbase/pull/2630#issuecomment-731692206
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
[
https://issues.apache.org/jira/browse/HBASE-23035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-23035:
Component/s: amv2
> Retain region to the last RegionServer make the failover slower
>
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-21565:
Component/s: amv2
> Delete dead server from dead server list too early leads to concurrent Server
saintstack commented on a change in pull request #2690:
URL: https://github.com/apache/hbase/pull/2690#discussion_r528271857
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##
@@ -1251,9 +1251,7 @@ protected void
brfrn169 commented on pull request #2630:
URL: https://github.com/apache/hbase/pull/2630#issuecomment-731673410
I made a mistake and the compile in the last QA failed.. Just fixed it and
pushed the latest patch.
This is an
[
https://issues.apache.org/jira/browse/HBASE-25284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236830#comment-17236830
]
Hudson commented on HBASE-25284:
Results for branch branch-2
[build #107 on
Apache-HBase commented on pull request #2688:
URL: https://github.com/apache/hbase/pull/2688#issuecomment-731664744
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2630:
URL: https://github.com/apache/hbase/pull/2630#issuecomment-731662752
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2630:
URL: https://github.com/apache/hbase/pull/2630#issuecomment-731662701
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2630:
URL: https://github.com/apache/hbase/pull/2630#issuecomment-731661920
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
cuibo01 closed pull request #2689:
URL: https://github.com/apache/hbase/pull/2689
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
cuibo01 closed pull request #2689:
URL: https://github.com/apache/hbase/pull/2689
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
cuibo01 commented on a change in pull request #2688:
URL: https://github.com/apache/hbase/pull/2688#discussion_r528264879
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##
@@ -3621,8 +3621,15 @@ public ReplicationPeerManager
brfrn169 commented on pull request #2630:
URL: https://github.com/apache/hbase/pull/2630#issuecomment-731659869
I just changed the patch regarding the following:
- Add testing for Append and keep the last else branch throwing
DoNotRetryIOException
- Use DoNotRetryIOException instead
Apache-HBase commented on pull request #2689:
URL: https://github.com/apache/hbase/pull/2689#issuecomment-731637535
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2678:
URL: https://github.com/apache/hbase/pull/2678#issuecomment-731636614
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m
Apache-HBase commented on pull request #2689:
URL: https://github.com/apache/hbase/pull/2689#issuecomment-731630451
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2689:
URL: https://github.com/apache/hbase/pull/2689#issuecomment-731614097
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
virajjasani commented on a change in pull request #2688:
URL: https://github.com/apache/hbase/pull/2688#discussion_r528223952
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##
@@ -3621,8 +3621,15 @@ public ReplicationPeerManager
[
https://issues.apache.org/jira/browse/HBASE-25280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236748#comment-17236748
]
Hudson commented on HBASE-25280:
Results for branch branch-2
[build #106 on
[
https://issues.apache.org/jira/browse/HBASE-25055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236746#comment-17236746
]
Hudson commented on HBASE-25055:
Results for branch branch-2
[build #106 on
[
https://issues.apache.org/jira/browse/HBASE-25151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236747#comment-17236747
]
Hudson commented on HBASE-25151:
Results for branch branch-2
[build #106 on
[
https://issues.apache.org/jira/browse/HBASE-25291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236750#comment-17236750
]
Hudson commented on HBASE-25291:
Results for branch branch-2
[build #106 on
[
https://issues.apache.org/jira/browse/HBASE-25126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236749#comment-17236749
]
Hudson commented on HBASE-25126:
Results for branch branch-2
[build #106 on
[
https://issues.apache.org/jira/browse/HBASE-25068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236745#comment-17236745
]
Hudson commented on HBASE-25068:
Results for branch branch-2
[build #106 on
Apache-HBase commented on pull request #2511:
URL: https://github.com/apache/hbase/pull/2511#issuecomment-731608764
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2689:
URL: https://github.com/apache/hbase/pull/2689#issuecomment-731607935
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
[
https://issues.apache.org/jira/browse/HBASE-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack resolved HBASE-18070.
---
Fix Version/s: (was: HBASE-18070.branch-2)
(was: HBASE-18070)
[
https://issues.apache.org/jira/browse/HBASE-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236729#comment-17236729
]
Michael Stack commented on HBASE-18070:
---
The last subtask has just been committed – updating the
[
https://issues.apache.org/jira/browse/HBASE-25284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack resolved HBASE-25284.
---
Hadoop Flags: Reviewed
Resolution: Fixed
Re-resolving after updating the already
[
https://issues.apache.org/jira/browse/HBASE-25284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236725#comment-17236725
]
Michael Stack commented on HBASE-25284:
---
I updated again to pick up the new fixes and then pushed.
saintstack merged pull request #2680:
URL: https://github.com/apache/hbase/pull/2680
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Apache-HBase commented on pull request #2680:
URL: https://github.com/apache/hbase/pull/2680#issuecomment-731602828
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2680:
URL: https://github.com/apache/hbase/pull/2680#issuecomment-731602788
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2680:
URL: https://github.com/apache/hbase/pull/2680#issuecomment-731602724
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
brfrn169 commented on a change in pull request #2630:
URL: https://github.com/apache/hbase/pull/2630#discussion_r528213068
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/CheckAndMutate.java
##
@@ -60,7 +53,7 @@
*/
@InterfaceAudience.Public
saintstack commented on pull request #2680:
URL: https://github.com/apache/hbase/pull/2680#issuecomment-731602570
Updated the PR w/ latest edits. Let me merge. Thanks for the reviews lads.
This is an automated message from
Apache-HBase commented on pull request #2511:
URL: https://github.com/apache/hbase/pull/2511#issuecomment-731600915
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2689:
URL: https://github.com/apache/hbase/pull/2689#issuecomment-731600233
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache9 commented on a change in pull request #2630:
URL: https://github.com/apache/hbase/pull/2630#discussion_r528207034
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ResponseConverter.java
##
@@ -158,52 +156,30 @@ public static
Apache9 commented on a change in pull request #2630:
URL: https://github.com/apache/hbase/pull/2630#discussion_r528205873
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##
@@ -620,8 +622,22 @@ private CheckAndMutateResult
[
https://issues.apache.org/jira/browse/HBASE-25313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236683#comment-17236683
]
Hudson commented on HBASE-25313:
Results for branch branch-1
[build #56 on
Apache9 commented on a change in pull request #2630:
URL: https://github.com/apache/hbase/pull/2630#discussion_r528205625
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/CheckAndMutate.java
##
@@ -60,7 +53,7 @@
*/
@InterfaceAudience.Public
Apache9 commented on a change in pull request #2630:
URL: https://github.com/apache/hbase/pull/2630#discussion_r528205391
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java
##
@@ -3657,9 +3657,10 @@ public static CheckAndMutate
Apache-HBase commented on pull request #2689:
URL: https://github.com/apache/hbase/pull/2689#issuecomment-731585302
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2511:
URL: https://github.com/apache/hbase/pull/2511#issuecomment-731584179
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2511:
URL: https://github.com/apache/hbase/pull/2511#issuecomment-731578669
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2688:
URL: https://github.com/apache/hbase/pull/2688#issuecomment-731577441
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2688:
URL: https://github.com/apache/hbase/pull/2688#issuecomment-731576832
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2689:
URL: https://github.com/apache/hbase/pull/2689#issuecomment-731572210
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2690:
URL: https://github.com/apache/hbase/pull/2690#issuecomment-731571751
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 6m
[
https://issues.apache.org/jira/browse/HBASE-25281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
niuyulin updated HBASE-25281:
-
Description:
Apache-HBase commented on pull request #2511:
URL: https://github.com/apache/hbase/pull/2511#issuecomment-731567556
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
[
https://issues.apache.org/jira/browse/HBASE-25281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
niuyulin updated HBASE-25281:
-
Description:
[
https://issues.apache.org/jira/browse/HBASE-25281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
niuyulin updated HBASE-25281:
-
Description:
Apache-HBase commented on pull request #2689:
URL: https://github.com/apache/hbase/pull/2689#issuecomment-731566085
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
[
https://issues.apache.org/jira/browse/HBASE-25213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236642#comment-17236642
]
niuyulin commented on HBASE-25213:
--
of course, I have submitted another PR for branch-2 [~zghao]
>
nyl3532016 commented on pull request #2684:
URL: https://github.com/apache/hbase/pull/2684#issuecomment-731565809
test failed not related.
This is an automated message from the Apache Git Service.
To respond to the message,
wchevreuil commented on a change in pull request #2667:
URL: https://github.com/apache/hbase/pull/2667#discussion_r528182565
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/BulkLoadHFilesTool.java
##
@@ -647,51 +684,24 @@ private String getUniqueName() {
Apache-HBase commented on pull request #2688:
URL: https://github.com/apache/hbase/pull/2688#issuecomment-731562787
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2688:
URL: https://github.com/apache/hbase/pull/2688#issuecomment-731558509
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2688:
URL: https://github.com/apache/hbase/pull/2688#issuecomment-731558378
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
cuibo01 opened a new pull request #2511:
URL: https://github.com/apache/hbase/pull/2511
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
cuibo01 removed a comment on pull request #2511:
URL: https://github.com/apache/hbase/pull/2511#issuecomment-731556733
> 我的评论从+1更改为修正检查样式并测试投诉。谢谢。
> Changed my review from +1 to fix the checkstyle and test complaints.
Thanks.
cuibo01 closed pull request #2511:
URL: https://github.com/apache/hbase/pull/2511
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
cuibo01 commented on pull request #2511:
URL: https://github.com/apache/hbase/pull/2511#issuecomment-731556733
> 我的评论从+1更改为修正检查样式并测试投诉。谢谢。
> Changed my review from +1 to fix the checkstyle and test complaints.
Thanks.
[
https://issues.apache.org/jira/browse/HBASE-24395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236622#comment-17236622
]
Bo Cui commented on HBASE-24395:
[https://github.com/apache/hbase/pull/2690]
update
>
cuibo01 opened a new pull request #2690:
URL: https://github.com/apache/hbase/pull/2690
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Apache-HBase commented on pull request #2511:
URL: https://github.com/apache/hbase/pull/2511#issuecomment-731552920
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2689:
URL: https://github.com/apache/hbase/pull/2689#issuecomment-731550915
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
[
https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236614#comment-17236614
]
Bo Cui commented on HBASE-24924:
{quote}
You still do not answer my question...
How could this happen
cuibo01 commented on a change in pull request #2352:
URL: https://github.com/apache/hbase/pull/2352#discussion_r528169267
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableStateManager.java
##
@@ -318,4 +326,39 @@ protected void
cuibo01 commented on a change in pull request #2352:
URL: https://github.com/apache/hbase/pull/2352#discussion_r528168990
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
##
@@ -1556,6 +1556,7 @@ public RegionInfo
[
https://issues.apache.org/jira/browse/HBASE-23340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bo Cui updated HBASE-23340:
---
Status: Patch Available (was: Open)
> hmaster /hbase/replication/rs session expired (hbase replication
[
https://issues.apache.org/jira/browse/HBASE-25311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bo Cui updated HBASE-25311:
---
Status: Patch Available (was: Open)
> ui throws NPE
> -
>
> Key: HBASE-25311
>
cuibo01 opened a new pull request #2689:
URL: https://github.com/apache/hbase/pull/2689
…ication default value is true, we don't use ) causes logcleaner can not
clean oldWALs, which resulits in oldWALs too large (more than 2TB)
Apache-HBase commented on pull request #2688:
URL: https://github.com/apache/hbase/pull/2688#issuecomment-731525655
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
82 matches
Mail list logo