[GitHub] [hbase] virajjasani commented on a change in pull request #2705: HBASE-25237 : 'hbase master stop' shuts down the cluster, not the master only

2020-11-25 Thread GitBox
virajjasani commented on a change in pull request #2705: URL: https://github.com/apache/hbase/pull/2705#discussion_r530833131 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java ## @@ -139,7 +148,15 @@ public int run(String args[])

[GitHub] [hbase] Apache-HBase commented on pull request #2710: test visible for testing

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2710: URL: https://github.com/apache/hbase/pull/2710#issuecomment-734137230 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2710: test visible for testing

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2710: URL: https://github.com/apache/hbase/pull/2710#issuecomment-734135923 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25242) Add Increment/Append support to RowMutations

2020-11-25 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239102#comment-17239102 ] Toshihiro Suzuki commented on HBASE-25242: -- Pushed to master. And I created a PR for branch-2.

[GitHub] [hbase] brfrn169 opened a new pull request #2711: HBASE-25242 Add Increment/Append support to RowMutations

2020-11-25 Thread GitBox
brfrn169 opened a new pull request #2711: URL: https://github.com/apache/hbase/pull/2711 Signed-off-by: Duo Zhang Signed-off-by: Andrew Purtell This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache-HBase commented on pull request #2710: test visible for testing

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2710: URL: https://github.com/apache/hbase/pull/2710#issuecomment-734124153 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2703: HBASE-25324 Remove unnecessary array to list conversion in SplitLogManager

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2703: URL: https://github.com/apache/hbase/pull/2703#issuecomment-734123004 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on a change in pull request #2669: HBASE-25292 Improve InetSocketAddress usage discipline

2020-11-25 Thread GitBox
Apache9 commented on a change in pull request #2669: URL: https://github.com/apache/hbase/pull/2669#discussion_r530805655 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java ## @@ -128,32 +129,17 @@ public static void

[GitHub] [hbase] Apache-HBase commented on pull request #2710: test visible for testing

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2710: URL: https://github.com/apache/hbase/pull/2710#issuecomment-734119518 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2710: test visible for testing

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2710: URL: https://github.com/apache/hbase/pull/2710#issuecomment-734114266 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] symat commented on pull request #2676: HBASE-25263 Change encryption key generation algorithm used in the HBase shell

2020-11-25 Thread GitBox
symat commented on pull request #2676: URL: https://github.com/apache/hbase/pull/2676#issuecomment-734114214 thanks for the review @petersomogyi! I fixed the checkstyle issue. This is an automated message from the Apache Git

[GitHub] [hbase] Apache-HBase commented on pull request #2710: test visible for testing

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2710: URL: https://github.com/apache/hbase/pull/2710#issuecomment-734114068 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25307) ThreadLocal pooling leads to NullPointerException

2020-11-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239095#comment-17239095 ] Duo Zhang commented on HBASE-25307: --- Checked the code again, all the places where we access the

[GitHub] [hbase] Apache-HBase commented on pull request #2699: HBASE-25287 Forgetting to unbuffer streams results in many CLOSE_WAIT…

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2699: URL: https://github.com/apache/hbase/pull/2699#issuecomment-734113395 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] Apache-HBase commented on pull request #2699: HBASE-25287 Forgetting to unbuffer streams results in many CLOSE_WAIT…

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2699: URL: https://github.com/apache/hbase/pull/2699#issuecomment-734112114 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2675: HBASE-25277 postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2675: URL: https://github.com/apache/hbase/pull/2675#issuecomment-734111955 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] Apache-HBase commented on pull request #2703: HBASE-25324 Remove unnecessary array to list conversion in SplitLogManager

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2703: URL: https://github.com/apache/hbase/pull/2703#issuecomment-734105018 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 12m

[GitHub] [hbase] Apache-HBase commented on pull request #2699: HBASE-25287 Forgetting to unbuffer streams results in many CLOSE_WAIT…

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2699: URL: https://github.com/apache/hbase/pull/2699#issuecomment-734092713 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24640) Purge use of VisibleForTesting

2020-11-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239072#comment-17239072 ] Hudson commented on HBASE-24640: Results for branch branch-1 [build #59 on

[GitHub] [hbase] Apache-HBase commented on pull request #2699: HBASE-25287 Forgetting to unbuffer streams results in many CLOSE_WAIT…

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2699: URL: https://github.com/apache/hbase/pull/2699#issuecomment-734088991 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #2703: HBASE-25324 Remove unnecessary array to list conversion in SplitLogManager

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2703: URL: https://github.com/apache/hbase/pull/2703#issuecomment-734077678 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25332) two NPEs

2020-11-25 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25332: -- Summary: two NPEs (was: One pontential NPE) > two NPEs > > > Key: HBASE-25332 >

[jira] [Updated] (HBASE-25332) One pontential NPE

2020-11-25 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25332: -- Description: * getData can return null at 

[GitHub] [hbase] gjacoby126 commented on pull request #2707: [HBASE-25328] Make some Tag related classes annotation as LimitatePrivate.

2020-11-25 Thread GitBox
gjacoby126 commented on pull request #2707: URL: https://github.com/apache/hbase/pull/2707#issuecomment-734076588 Question: would it be possible to do the following? 1. Mark sufficient existing APIs to create/read from Tags in coproc as LimitedPrivate(COPROC) to unblock existing

[jira] [Commented] (HBASE-25333) Add a yetus check to disable usage of VisibleForTesting annotation on IA.Public and IA.LimitedPrivate classes

2020-11-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239066#comment-17239066 ] Hudson commented on HBASE-25333: Results for branch HBASE-25333 [build #1 on

[GitHub] [hbase] Apache-HBase commented on pull request #2710: test visible for testing

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2710: URL: https://github.com/apache/hbase/pull/2710#issuecomment-734071028 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2710: test visible for testing

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2710: URL: https://github.com/apache/hbase/pull/2710#issuecomment-734068254 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2710: test visible for testing

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2710: URL: https://github.com/apache/hbase/pull/2710#issuecomment-734067780 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] brfrn169 merged pull request #2630: HBASE-25242 Add Increment/Append support to RowMutations

2020-11-25 Thread GitBox
brfrn169 merged pull request #2630: URL: https://github.com/apache/hbase/pull/2630 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] brfrn169 commented on pull request #2630: HBASE-25242 Add Increment/Append support to RowMutations

2020-11-25 Thread GitBox
brfrn169 commented on pull request #2630: URL: https://github.com/apache/hbase/pull/2630#issuecomment-734067225 I don't think the failed UTs are related to this change. The failed UTs were successful locally. I will merge this PR.

[jira] [Updated] (HBASE-25332) One pontential NPE

2020-11-25 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25332: -- Description: * getData can return null at 

[jira] [Updated] (HBASE-25332) One pontential NPE

2020-11-25 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25332: -- Description: * getData can return null at 

[jira] [Updated] (HBASE-25332) One pontential NPE

2020-11-25 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25332: -- Description: * getData can return null at 

[jira] [Updated] (HBASE-25332) One pontential NPE

2020-11-25 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25332: -- Description: * getData can return null at 

[jira] [Updated] (HBASE-25332) One pontential NPE

2020-11-25 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25332: -- Description: * getData can return null at 

[jira] [Updated] (HBASE-25332) One pontential NPE

2020-11-25 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25332: -- Description: * getData can return null at 

[jira] [Updated] (HBASE-25332) One pontential NPE

2020-11-25 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25332: -- Description: * getData can return null at 

[jira] [Updated] (HBASE-25332) One pontential NPE

2020-11-25 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25332: -- Description: * getData can return null at 

[GitHub] [hbase] Apache9 opened a new pull request #2710: test visible for testing

2020-11-25 Thread GitBox
Apache9 opened a new pull request #2710: URL: https://github.com/apache/hbase/pull/2710 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (HBASE-25332) One pontential NPE

2020-11-25 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25332: -- Description: * peek can return null at

[jira] [Updated] (HBASE-25332) One pontential NPE

2020-11-25 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25332: -- Description: * peek can return null at 

[jira] [Updated] (HBASE-25332) One pontential NPE

2020-11-25 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25332: -- Description: * peek can return null at 

[jira] [Updated] (HBASE-25332) One pontential NPE

2020-11-25 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25332: -- Description: * peek can return null at

[jira] [Updated] (HBASE-25332) One pontential NPE

2020-11-25 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25332: -- Description: * peek can return null at

[jira] [Assigned] (HBASE-25333) Add a yetus check to disable usage of VisibleForTesting annotation on IA.Public and IA.LimitedPrivate classes

2020-11-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-25333: - Assignee: Duo Zhang > Add a yetus check to disable usage of VisibleForTesting annotation on >

[GitHub] [hbase] Apache-HBase commented on pull request #2699: HBASE-25287 Forgetting to unbuffer streams results in many CLOSE_WAIT…

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2699: URL: https://github.com/apache/hbase/pull/2699#issuecomment-734058051 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[jira] [Work started] (HBASE-25333) Add a yetus check to disable usage of VisibleForTesting annotation on IA.Public and IA.LimitedPrivate classes

2020-11-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25333 started by Duo Zhang. - > Add a yetus check to disable usage of VisibleForTesting annotation on > IA.Public

[GitHub] [hbase] Apache-HBase commented on pull request #2630: HBASE-25242 Add Increment/Append support to RowMutations

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2630: URL: https://github.com/apache/hbase/pull/2630#issuecomment-734056811 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #2630: HBASE-25242 Add Increment/Append support to RowMutations

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2630: URL: https://github.com/apache/hbase/pull/2630#issuecomment-734056370 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2681: HBASE-25308 [branch-1] Consume Guava from hbase-thirdparty hbase-shaded-miscellaneous

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2681: URL: https://github.com/apache/hbase/pull/2681#issuecomment-734052457 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25333) Add a yetus check to disable usage of VisibleForTesting annotation on IA.Public and IA.LimitedPrivate classes

2020-11-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239045#comment-17239045 ] Duo Zhang commented on HBASE-25333: --- This is a shell script which could be used to filter out the

[GitHub] [hbase] Apache-HBase commented on pull request #2703: HBASE-25324 Remove unnecessary array to list conversion in SplitLogManager

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2703: URL: https://github.com/apache/hbase/pull/2703#issuecomment-734049289 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 9m

[GitHub] [hbase] sunhelly edited a comment on pull request #2699: HBASE-25287 Forgetting to unbuffer streams results in many CLOSE_WAIT…

2020-11-25 Thread GitBox
sunhelly edited a comment on pull request #2699: URL: https://github.com/apache/hbase/pull/2699#issuecomment-734046820 @Apache9 Yes, it's right. `initMetaAndIndex` is also used somewhere else. Then I think `initTrailerAndContext` also needs to add a finally. PR has been updated.

[GitHub] [hbase] sunhelly commented on pull request #2699: HBASE-25287 Forgetting to unbuffer streams results in many CLOSE_WAIT…

2020-11-25 Thread GitBox
sunhelly commented on pull request #2699: URL: https://github.com/apache/hbase/pull/2699#issuecomment-734046820 @Apache9 Yes, it's right. `initMetaAndIndex` is also used somewhere else. But I think `initTrailerAndContext` also needs to add a finally. PR has been updated.

[GitHub] [hbase] Apache-HBase commented on pull request #2669: HBASE-25292 Improve InetSocketAddress usage discipline

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2669: URL: https://github.com/apache/hbase/pull/2669#issuecomment-734046168 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-25333) Add a yetus check to disable usage of VisibleForTesting annotation on IA.Public and IA.LimitedPrivate classes

2020-11-25 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25333: - Summary: Add a yetus check to disable usage of VisibleForTesting annotation on IA.Public and IA.LimitedPrivate classes Key: HBASE-25333 URL:

[jira] [Created] (HBASE-25332) One pontential NPE

2020-11-25 Thread lujie (Jira)
lujie created HBASE-25332: - Summary: One pontential NPE Key: HBASE-25332 URL: https://issues.apache.org/jira/browse/HBASE-25332 Project: HBase Issue Type: Bug Reporter: lujie peek can

[jira] [Commented] (HBASE-24640) Purge use of VisibleForTesting

2020-11-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239026#comment-17239026 ] Duo Zhang commented on HBASE-24640: --- My point is that this is a common thing in java world so if we do

[GitHub] [hbase] Apache-HBase commented on pull request #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #251: URL: https://github.com/apache/hbase/pull/251#issuecomment-734038249 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s

[jira] [Commented] (HBASE-24640) Purge use of VisibleForTesting

2020-11-25 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239013#comment-17239013 ] Andrew Kyle Purtell commented on HBASE-24640: - VisibleForTesting binds us to Guava for no

[jira] [Commented] (HBASE-24640) Purge use of VisibleForTesting

2020-11-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239010#comment-17239010 ] Duo Zhang commented on HBASE-24640: --- I would say that on a IA.Private class it is fine to add

[GitHub] [hbase] Apache-HBase commented on pull request #2669: HBASE-25292 Improve InetSocketAddress usage discipline

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2669: URL: https://github.com/apache/hbase/pull/2669#issuecomment-734028108 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2671: HBASE-25292 [branch-1] Improve InetSocketAddress usage discipline

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2671: URL: https://github.com/apache/hbase/pull/2671#issuecomment-734027261 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 8m

[GitHub] [hbase] Apache-HBase commented on pull request #2670: HBASE-25292 [branch-2] Improve InetSocketAddress usage discipline

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2670: URL: https://github.com/apache/hbase/pull/2670#issuecomment-734025856 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #2675: HBASE-25277 postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2675: URL: https://github.com/apache/hbase/pull/2675#issuecomment-734024785 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2697: HBASE-24640 [branch-1] Purge use of VisibleForTesting

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2697: URL: https://github.com/apache/hbase/pull/2697#issuecomment-734023701 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2630: HBASE-25242 Add Increment/Append support to RowMutations

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2630: URL: https://github.com/apache/hbase/pull/2630#issuecomment-734023616 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] apurtell commented on pull request #2681: HBASE-25308 [branch-1] Consume Guava from hbase-thirdparty hbase-shaded-miscellaneous

2020-11-25 Thread GitBox
apurtell commented on pull request #2681: URL: https://github.com/apache/hbase/pull/2681#issuecomment-734015516 Rebased and updated after HBASE-24640 This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] brfrn169 commented on pull request #2630: HBASE-25242 Add Increment/Append support to RowMutations

2020-11-25 Thread GitBox
brfrn169 commented on pull request #2630: URL: https://github.com/apache/hbase/pull/2630#issuecomment-734006919 I don't think the failed UTs in the last QA are related to this patch, but I will trigger QA again just in case.

[GitHub] [hbase] Apache-HBase commented on pull request #2675: HBASE-25277 postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2675: URL: https://github.com/apache/hbase/pull/2675#issuecomment-733999746 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2670: HBASE-25292 [branch-2] Improve InetSocketAddress usage discipline

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2670: URL: https://github.com/apache/hbase/pull/2670#issuecomment-733993490 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #2669: HBASE-25292 Improve InetSocketAddress usage discipline

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2669: URL: https://github.com/apache/hbase/pull/2669#issuecomment-733990315 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] shahrs87 edited a comment on pull request #2707: [HBASE-25328] Make some Tag related classes annotation as LimitatePrivate.

2020-11-25 Thread GitBox
shahrs87 edited a comment on pull request #2707: URL: https://github.com/apache/hbase/pull/2707#issuecomment-733974388 > We should not be exposing entire PrivateCellUtil even for CPs. There is a Cell util public and CP exposed version. For CPs to handle tags, if we need new APIs, lets

[GitHub] [hbase] shahrs87 commented on pull request #2707: [HBASE-25328] Make some Tag related classes annotation as LimitatePrivate.

2020-11-25 Thread GitBox
shahrs87 commented on pull request #2707: URL: https://github.com/apache/hbase/pull/2707#issuecomment-733974388 > We should not be exposing entire PrivateCellUtil even for CPs. There is a Cell util public and CP exposed version. For CPs to handle tags, if we need new APIs, lets target

[jira] [Updated] (HBASE-24640) Purge use of VisibleForTesting

2020-11-25 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-24640: Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was:

[GitHub] [hbase] apurtell merged pull request #2697: HBASE-24640 [branch-1] Purge use of VisibleForTesting

2020-11-25 Thread GitBox
apurtell merged pull request #2697: URL: https://github.com/apache/hbase/pull/2697 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] apurtell merged pull request #2696: HBASE-24640 [branch-2] Purge use of VisibleForTesting

2020-11-25 Thread GitBox
apurtell merged pull request #2696: URL: https://github.com/apache/hbase/pull/2696 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2675: HBASE-25277 postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2675: URL: https://github.com/apache/hbase/pull/2675#issuecomment-733969192 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] apurtell merged pull request #2695: HBASE-24640 Purge use of VisibleForTesting

2020-11-25 Thread GitBox
apurtell merged pull request #2695: URL: https://github.com/apache/hbase/pull/2695 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] apurtell edited a comment on pull request #2697: HBASE-24640 [branch-1] Purge use of VisibleForTesting

2020-11-25 Thread GitBox
apurtell edited a comment on pull request #2697: URL: https://github.com/apache/hbase/pull/2697#issuecomment-733967159 Let me make another pass to fix up checkstyle and ensure VisibleForTesting is really gone. In one precommit it seems to have come back somewhere.

[GitHub] [hbase] apurtell commented on pull request #2697: HBASE-24640 [branch-1] Purge use of VisibleForTesting

2020-11-25 Thread GitBox
apurtell commented on pull request #2697: URL: https://github.com/apache/hbase/pull/2697#issuecomment-733967159 Let me make another pass to fix up checkstyle and insure VisibleForTesting is really gone. In one precommit it seems to have come back somewhere.

[GitHub] [hbase] Apache-HBase commented on pull request #2675: HBASE-25277 postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2675: URL: https://github.com/apache/hbase/pull/2675#issuecomment-733951984 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2675: HBASE-25277 postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2675: URL: https://github.com/apache/hbase/pull/2675#issuecomment-733946660 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] busbey commented on a change in pull request #2709: HBASE-25307 ThreadLocal pooling leads to NullPointerException (#2685)

2020-11-25 Thread GitBox
busbey commented on a change in pull request #2709: URL: https://github.com/apache/hbase/pull/2709#discussion_r530608405 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java ## @@ -270,58 +195,16 @@ public static PoolType fuzzyMatch(String name) {

[GitHub] [hbase] Apache-HBase commented on pull request #2630: HBASE-25242 Add Increment/Append support to RowMutations

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2630: URL: https://github.com/apache/hbase/pull/2630#issuecomment-733914197 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] busbey commented on a change in pull request #2709: HBASE-25307 ThreadLocal pooling leads to NullPointerException (#2685)

2020-11-25 Thread GitBox
busbey commented on a change in pull request #2709: URL: https://github.com/apache/hbase/pull/2709#discussion_r530594859 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java ## @@ -270,58 +195,16 @@ public static PoolType fuzzyMatch(String name) {

[GitHub] [hbase] Apache-HBase commented on pull request #2675: HBASE-25277 postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-11-25 Thread GitBox
Apache-HBase commented on pull request #2675: URL: https://github.com/apache/hbase/pull/2675#issuecomment-733898521 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] busbey commented on a change in pull request #2709: HBASE-25307 ThreadLocal pooling leads to NullPointerException (#2685)

2020-11-25 Thread GitBox
busbey commented on a change in pull request #2709: URL: https://github.com/apache/hbase/pull/2709#discussion_r530585606 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java ## @@ -270,58 +195,16 @@ public static PoolType fuzzyMatch(String name) {

[jira] [Commented] (HBASE-25323) Fix potential NPE when the zookeeper path of RegionServerTracker does not exist when start

2020-11-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238866#comment-17238866 ] Hudson commented on HBASE-25323: Results for branch branch-2.2 [build #123 on

[jira] [Commented] (HBASE-25325) Remove unused class ClusterSchemaException

2020-11-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238857#comment-17238857 ] Hudson commented on HBASE-25325: Results for branch branch-2 [build #111 on

[jira] [Commented] (HBASE-25281) Bulkload split hfile too many times due to unreasonable split point

2020-11-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238856#comment-17238856 ] Hudson commented on HBASE-25281: Results for branch branch-2 [build #111 on

[jira] [Commented] (HBASE-25323) Fix potential NPE when the zookeeper path of RegionServerTracker does not exist when start

2020-11-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238858#comment-17238858 ] Hudson commented on HBASE-25323: Results for branch branch-2 [build #111 on

[jira] [Commented] (HBASE-25278) Add option to toggle CACHE_BLOCKS in count.rb

2020-11-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238853#comment-17238853 ] Hudson commented on HBASE-25278: Results for branch branch-2 [build #111 on

[jira] [Commented] (HBASE-25050) We initialize Filesystems more than once.

2020-11-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238852#comment-17238852 ] Hudson commented on HBASE-25050: Results for branch branch-2 [build #111 on

[jira] [Commented] (HBASE-25213) Should request Compaction when bulkLoadHFiles is done

2020-11-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238855#comment-17238855 ] Hudson commented on HBASE-25213: Results for branch branch-2 [build #111 on

[jira] [Commented] (HBASE-24268) REST and Thrift server do not handle the "doAs" parameter case insensitively

2020-11-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238854#comment-17238854 ] Hudson commented on HBASE-24268: Results for branch branch-2 [build #111 on

[jira] [Commented] (HBASE-25187) Improve SizeCachedKV variants initialization

2020-11-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238851#comment-17238851 ] Hudson commented on HBASE-25187: Results for branch branch-2 [build #111 on

[GitHub] [hbase] pankaj72981 commented on a change in pull request #2675: HBASE-25277 postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-11-25 Thread GitBox
pankaj72981 commented on a change in pull request #2675: URL: https://github.com/apache/hbase/pull/2675#discussion_r530555483 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java ## @@ -299,6 +304,11 @@ public

[GitHub] [hbase-filesystem] wchevreuil opened a new pull request #18: HBASE-25331 [HBOSS] TreeLockManager should log warnings about lock co…

2020-11-25 Thread GitBox
wchevreuil opened a new pull request #18: URL: https://github.com/apache/hbase-filesystem/pull/18 …ntention periodically Change-Id: I2e88d8647531928b30ba29e730b5a83b86cf4eb4 This is an automated message from the

[jira] [Created] (HBASE-25331) [HBOSS] TreeLockManager should log warnings about lock contention periodically

2020-11-25 Thread Wellington Chevreuil (Jira)
Wellington Chevreuil created HBASE-25331: Summary: [HBOSS] TreeLockManager should log warnings about lock contention periodically Key: HBASE-25331 URL: https://issues.apache.org/jira/browse/HBASE-25331

  1   2   >