[GitHub] [hbase] Apache-HBase commented on pull request #2728: HBASE-25334 TestRSGroupsFallback.testFallback is flaky

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2728: URL: https://github.com/apache/hbase/pull/2728#issuecomment-740450284 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40

[GitHub] [hbase] ramkrish86 commented on pull request #2664: HBASE-24850 - CellComparator perf improvement

2020-12-07 Thread GitBox
ramkrish86 commented on pull request #2664: URL: https://github.com/apache/hbase/pull/2664#issuecomment-740445961 In the latest commit apart from having the ContiguousCellComparator, We also found that the bulk load performance was slower inspite of overall improving the comparator perform

[jira] [Commented] (HBASE-25346) hbase2.x the performance is lower than hbase 1.x ?

2020-12-07 Thread nilonealex (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245713#comment-17245713 ] nilonealex commented on HBASE-25346: yes ,the same > hbase2.x the performance is lo

[jira] [Commented] (HBASE-21874) Bucket cache on Persistent memory

2020-12-07 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245711#comment-17245711 ] Anoop Sam John commented on HBASE-21874: Ya this is not supported as per this Ji

[GitHub] [hbase] Apache-HBase commented on pull request #2738: HBASE-25363 Improve performance of HFileLinkCleaner by using ReadWrit…

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2738: URL: https://github.com/apache/hbase/pull/2738#issuecomment-740406495 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17

[jira] [Updated] (HBASE-25363) Improve performance of HFileLinkCleaner by using ReadWriteLock instead of synchronize

2020-12-07 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-25363: --- Issue Type: Improvement (was: Test) > Improve performance of HFileLinkCleaner by using ReadWriteLoc

[jira] [Assigned] (HBASE-25371) When openRegion fails during initial verification(before initializing and setting seq num), exception is observed during region close.

2020-12-07 Thread Sanjeet Nishad (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjeet Nishad reassigned HBASE-25371: -- Assignee: Sanjeet Nishad > When openRegion fails during initial verification(before i

[jira] [Updated] (HBASE-25371) When openRegion fails during initial verification(before initializing and setting seq num), exception is observed during region close.

2020-12-07 Thread Ajeet Rai (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajeet Rai updated HBASE-25371: -- Component/s: Region Assignment > When openRegion fails during initial verification(before initializing

[jira] [Created] (HBASE-25371) When openRegion fails during initial verification(before initializing and setting seq num), exception is observed during region close.

2020-12-07 Thread Ajeet Rai (Jira)
Ajeet Rai created HBASE-25371: - Summary: When openRegion fails during initial verification(before initializing and setting seq num), exception is observed during region close. Key: HBASE-25371 URL: https://issues.apac

[GitHub] [hbase] GeorryHuang commented on pull request #2741: HBASE-25364 Redo the getMidPoint() in HFileWriterImpl to get rid of t…

2020-12-07 Thread GitBox
GeorryHuang commented on pull request #2741: URL: https://github.com/apache/hbase/pull/2741#issuecomment-740378200 @saintstack Thanks for reviewing This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HBASE-21874) Bucket cache on Persistent memory

2020-12-07 Thread shenshengli (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245645#comment-17245645 ] shenshengli commented on HBASE-21874: - I see this comment in the code: {quote}// TOD

[GitHub] [hbase] Apache-HBase commented on pull request #2737: HBASE-25362 Fix quoting in hbase-vote to avoid voting build failures

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2737: URL: https://github.com/apache/hbase/pull/2737#issuecomment-740308075 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 2

[GitHub] [hbase] Apache-HBase commented on pull request #2737: HBASE-25362 Fix quoting in hbase-vote to avoid voting build failures

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2737: URL: https://github.com/apache/hbase/pull/2737#issuecomment-740307745 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[jira] [Created] (HBASE-25370) Fix flaky test TestClassFinder#testClassFinderDefaultsToOwnPackage

2020-12-07 Thread Adam Wang (Jira)
Adam Wang created HBASE-25370: - Summary: Fix flaky test TestClassFinder#testClassFinderDefaultsToOwnPackage Key: HBASE-25370 URL: https://issues.apache.org/jira/browse/HBASE-25370 Project: HBase

[GitHub] [hbase] z-york commented on pull request #2737: HBASE-25362 Fix quoting in hbase-vote to avoid voting build failures

2020-12-07 Thread GitBox
z-york commented on pull request #2737: URL: https://github.com/apache/hbase/pull/2737#issuecomment-740307035 + UNIT_TEST_PASSED=1 + popd ~/workspace/apache/rctest + print_when_exit + cat ++ (( SIGNATURE_PASSED )) ++ echo ok ++ (( CHECKSUM_PASSED ))

[GitHub] [hbase] shenshengli commented on pull request #1087: HBASE-23734 Backport [HBASE-21874 Bucket cache on Persistent memory] …

2020-12-07 Thread GitBox
shenshengli commented on pull request #1087: URL: https://github.com/apache/hbase/pull/1087#issuecomment-740303574 Only one directory can be configured here, but multiple hardware is usually used, such as 1T (8*128G) App Direct, in which case I want to configure 512G bucketCache, must pool

[GitHub] [hbase] z-york commented on pull request #2737: HBASE-25362 Fix quoting in hbase-vote to avoid voting build failures

2020-12-07 Thread GitBox
z-york commented on pull request #2737: URL: https://github.com/apache/hbase/pull/2737#issuecomment-740300627 > Looks like the -D argument isn't being passed to maven correctly... maybe that trailing space is causing issue? Yup, looks like when I switched it to +=() it is now correct

[GitHub] [hbase] z-york commented on pull request #2737: HBASE-25362 Fix quoting in hbase-vote to avoid voting build failures

2020-12-07 Thread GitBox
z-york commented on pull request #2737: URL: https://github.com/apache/hbase/pull/2737#issuecomment-740298759 Weird, it was working when I tested it before, but must have been broken by some of the shellcheck changes I did. Let me dig in. --

[GitHub] [hbase] Apache-HBase commented on pull request #2745: [HBASE-25246] Backup/Restore hbase cell tags.

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2745: URL: https://github.com/apache/hbase/pull/2745#issuecomment-740297480 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3

[GitHub] [hbase-connectors] Dieken commented on a change in pull request #72: [HBASE-25357] allow specifying binary row key range to pre-split regions

2020-12-07 Thread GitBox
Dieken commented on a change in pull request #72: URL: https://github.com/apache/hbase-connectors/pull/72#discussion_r537942618 ## File path: spark/hbase-spark/src/main/scala/org/apache/hadoop/hbase/spark/DefaultSource.scala ## @@ -150,12 +151,10 @@ case class HBaseRelation (

[GitHub] [hbase] ndimiduk commented on pull request #2737: HBASE-25362 Fix quoting in hbase-vote to avoid voting build failures

2020-12-07 Thread GitBox
ndimiduk commented on pull request #2737: URL: https://github.com/apache/hbase/pull/2737#issuecomment-740267232 I think this isn't right either, @z-york . ``` $ caffeinate env JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home bash -x ~/repos/apache/hba

[GitHub] [hbase] Apache-HBase commented on pull request #2737: HBASE-25362 Fix quoting in hbase-vote to avoid voting build failures

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2737: URL: https://github.com/apache/hbase/pull/2737#issuecomment-740255955 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 14

[GitHub] [hbase] Apache-HBase commented on pull request #2737: HBASE-25362 Fix quoting in hbase-vote to avoid voting build failures

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2737: URL: https://github.com/apache/hbase/pull/2737#issuecomment-740255912 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 19

[GitHub] [hbase] Apache-HBase commented on pull request #2737: HBASE-25362 Fix quoting in hbase-vote to avoid voting build failures

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2737: URL: https://github.com/apache/hbase/pull/2737#issuecomment-740255205 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] Apache-HBase commented on pull request #2745: [HBASE-25246] Backup/Restore hbase cell tags.

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2745: URL: https://github.com/apache/hbase/pull/2745#issuecomment-740249938 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5

[GitHub] [hbase] Apache-HBase commented on pull request #2737: HBASE-25362 Fix quoting in hbase-vote to avoid voting build failures

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2737: URL: https://github.com/apache/hbase/pull/2737#issuecomment-740247324 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 38

[GitHub] [hbase] Apache-HBase commented on pull request #2737: HBASE-25362 Fix quoting in hbase-vote to avoid voting build failures

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2737: URL: https://github.com/apache/hbase/pull/2737#issuecomment-740247029 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 11

[GitHub] [hbase] Apache-HBase commented on pull request #2737: HBASE-25362 Fix quoting in hbase-vote to avoid voting build failures

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2737: URL: https://github.com/apache/hbase/pull/2737#issuecomment-740246192 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] z-york commented on pull request #2737: HBASE-25362 Fix quoting in hbase-vote to avoid voting build failures

2020-12-07 Thread GitBox
z-york commented on pull request #2737: URL: https://github.com/apache/hbase/pull/2737#issuecomment-740243230 Should be good to review now. I tested locally with -x and it looks like everything is being passed correctly now.

[GitHub] [hbase] Apache-HBase commented on pull request #2737: HBASE-25362 Fix quoting in hbase-vote to avoid voting build failures

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2737: URL: https://github.com/apache/hbase/pull/2737#issuecomment-740237362 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 5

[GitHub] [hbase] Apache-HBase commented on pull request #2737: HBASE-25362 Fix quoting in hbase-vote to avoid voting build failures

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2737: URL: https://github.com/apache/hbase/pull/2737#issuecomment-740237158 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 21

[GitHub] [hbase] Apache-HBase commented on pull request #2737: HBASE-25362 Fix quoting in hbase-vote to avoid voting build failures

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2737: URL: https://github.com/apache/hbase/pull/2737#issuecomment-740236663 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[jira] [Commented] (HBASE-25368) Filter out more invalid encoded name in isEncodedRegionName(byte[] regionName)

2020-12-07 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245566#comment-17245566 ] Huaxiang Sun commented on HBASE-25368: -- It is better to fix it in RawAsyncHBaseAdmi

[GitHub] [hbase] Apache-HBase commented on pull request #2737: HBASE-25362 Fix quoting in hbase-vote to avoid voting build failures

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2737: URL: https://github.com/apache/hbase/pull/2737#issuecomment-740227940 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 12

[GitHub] [hbase] Apache-HBase commented on pull request #2737: HBASE-25362 Fix quoting in hbase-vote to avoid voting build failures

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2737: URL: https://github.com/apache/hbase/pull/2737#issuecomment-740227868 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 9

[GitHub] [hbase] Apache-HBase commented on pull request #2737: HBASE-25362 Fix quoting in hbase-vote to avoid voting build failures

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2737: URL: https://github.com/apache/hbase/pull/2737#issuecomment-740227147 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] z-york commented on pull request #2737: HBASE-25362 Fix quoting in hbase-vote to avoid voting build failures

2020-12-07 Thread GitBox
z-york commented on pull request #2737: URL: https://github.com/apache/hbase/pull/2737#issuecomment-740208041 Haha no worries, I just got around to figuring out why hbase-vote was failing for me for the past couple releases :) I'll add the array support shortly! ---

[GitHub] [hbase] ndimiduk closed pull request #2746: HBASE-25085 hbase-vote.sh mvn invocation broken with empty MVN_PROPERTIES variable

2020-12-07 Thread GitBox
ndimiduk closed pull request #2746: URL: https://github.com/apache/hbase/pull/2746 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hbase] ndimiduk commented on pull request #2746: HBASE-25085 hbase-vote.sh mvn invocation broken with empty MVN_PROPERTIES variable

2020-12-07 Thread GitBox
ndimiduk commented on pull request #2746: URL: https://github.com/apache/hbase/pull/2746#issuecomment-740206463 Closing as duplicate of HBASE-25362 / #2737 This is an automated message from the Apache Git Service. To respond

[jira] [Resolved] (HBASE-25369) hbase-vote.sh mvn invocation broken with empty MVN_PROPERTIES variable

2020-12-07 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-25369. -- Fix Version/s: (was: 3.0.0-alpha-1) Resolution: Duplicate > hbase-vote.sh mvn invoc

[jira] [Work stopped] (HBASE-25369) hbase-vote.sh mvn invocation broken with empty MVN_PROPERTIES variable

2020-12-07 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25369 stopped by Nick Dimiduk. > hbase-vote.sh mvn invocation broken with empty MVN_PROPERTIES variable >

[GitHub] [hbase] ndimiduk commented on pull request #2737: HBASE-25362 Fix quoting in hbase-vote to avoid voting build failures

2020-12-07 Thread GitBox
ndimiduk commented on pull request #2737: URL: https://github.com/apache/hbase/pull/2737#issuecomment-740205643 Bah, sorry I didn't see this one and instead filed HBASE-25369 / #2746 . I think @busbey 's proposed solution is more correct than my `eval` solution. --

[GitHub] [hbase] Apache-HBase commented on pull request #2746: HBASE-25085 hbase-vote.sh mvn invocation broken with empty MVN_PROPERTIES variable

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2746: URL: https://github.com/apache/hbase/pull/2746#issuecomment-740194427 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 21

[GitHub] [hbase] Apache-HBase commented on pull request #2746: HBASE-25085 hbase-vote.sh mvn invocation broken with empty MVN_PROPERTIES variable

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2746: URL: https://github.com/apache/hbase/pull/2746#issuecomment-740193890 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14

[GitHub] [hbase] Apache-HBase commented on pull request #2746: HBASE-25085 hbase-vote.sh mvn invocation broken with empty MVN_PROPERTIES variable

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2746: URL: https://github.com/apache/hbase/pull/2746#issuecomment-740193377 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[jira] [Commented] (HBASE-25369) hbase-vote.sh mvn invocation broken with empty MVN_PROPERTIES variable

2020-12-07 Thread Zach York (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245533#comment-17245533 ] Zach York commented on HBASE-25369: --- Duplicates HBASE-25362 > hbase-vote.sh mvn invoc

[GitHub] [hbase] Apache-HBase commented on pull request #2746: HBASE-25085 hbase-vote.sh mvn invocation broken with empty MVN_PROPERTIES variable

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2746: URL: https://github.com/apache/hbase/pull/2746#issuecomment-740190105 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 43

[GitHub] [hbase] Apache-HBase commented on pull request #2746: HBASE-25085 hbase-vote.sh mvn invocation broken with empty MVN_PROPERTIES variable

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2746: URL: https://github.com/apache/hbase/pull/2746#issuecomment-740189850 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5

[GitHub] [hbase] Apache-HBase commented on pull request #2746: HBASE-25085 hbase-vote.sh mvn invocation broken with empty MVN_PROPERTIES variable

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2746: URL: https://github.com/apache/hbase/pull/2746#issuecomment-740189514 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[GitHub] [hbase] ndimiduk opened a new pull request #2746: HBASE-25085 hbase-vote.sh mvn invocation broken with empty MVN_PROPERTIES variable

2020-12-07 Thread GitBox
ndimiduk opened a new pull request #2746: URL: https://github.com/apache/hbase/pull/2746 Use `eval` to execute a command string built from component parts. This provokes bash to build the command arguments by interpreting the final string, instead of accepting them one-by-one. --

[jira] [Work started] (HBASE-25369) hbase-vote.sh mvn invocation broken with empty MVN_PROPERTIES variable

2020-12-07 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25369 started by Nick Dimiduk. > hbase-vote.sh mvn invocation broken with empty MVN_PROPERTIES variable >

[jira] [Created] (HBASE-25369) hbase-vote.sh mvn invocation broken with empty MVN_PROPERTIES variable

2020-12-07 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-25369: Summary: hbase-vote.sh mvn invocation broken with empty MVN_PROPERTIES variable Key: HBASE-25369 URL: https://issues.apache.org/jira/browse/HBASE-25369 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #2745: [HBASE-25246] Backup/Restore hbase cell tags.

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2745: URL: https://github.com/apache/hbase/pull/2745#issuecomment-740185605 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[GitHub] [hbase] Apache-HBase commented on pull request #2745: [HBASE-25246] Backup/Restore hbase cell tags.

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2745: URL: https://github.com/apache/hbase/pull/2745#issuecomment-740157926 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3

[jira] [Updated] (HBASE-24673) TransitionRegionStateProcedure of non-meta regions should yield when meta is unavailable

2020-12-07 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24673: - Affects Version/s: 2.3.0 > TransitionRegionStateProcedure of non-meta regions should yield when

[jira] [Assigned] (HBASE-25368) Filter out more invalid encoded name in isEncodedRegionName(byte[] regionName)

2020-12-07 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun reassigned HBASE-25368: Assignee: Huaxiang Sun > Filter out more invalid encoded name in isEncodedRegionName(byte

[jira] [Created] (HBASE-25368) Filter out more invalid encoded name in isEncodedRegionName(byte[] regionName)

2020-12-07 Thread Huaxiang Sun (Jira)
Huaxiang Sun created HBASE-25368: Summary: Filter out more invalid encoded name in isEncodedRegionName(byte[] regionName) Key: HBASE-25368 URL: https://issues.apache.org/jira/browse/HBASE-25368 Proje

[jira] [Commented] (HBASE-20515) Cleanup ProcedureExecutor#stop and #join interaction/dependency

2020-12-07 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245466#comment-17245466 ] Michael Stack commented on HBASE-20515: --- I've not looked at this in a while. Do yo

[GitHub] [hbase] saintstack commented on a change in pull request #2726: HBASE-25293 Followup jira to address the client handling issue when c…

2020-12-07 Thread GitBox
saintstack commented on a change in pull request #2726: URL: https://github.com/apache/hbase/pull/2726#discussion_r537762925 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceSimpleSelector.java ## @@ -262,16 +261,16 @@ private vo

[GitHub] [hbase] Apache-HBase commented on pull request #2745: [HBASE-25246] Backup/Restore hbase cell tags.

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2745: URL: https://github.com/apache/hbase/pull/2745#issuecomment-740122349 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s

[GitHub] [hbase] saintstack commented on a change in pull request #2741: HBASE-25364 Redo the getMidPoint() in HFileWriterImpl to get rid of t…

2020-12-07 Thread GitBox
saintstack commented on a change in pull request #2741: URL: https://github.com/apache/hbase/pull/2741#discussion_r537740722 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterImpl.java ## @@ -366,8 +366,6 @@ private void finishBlock() throws

[GitHub] [hbase] pankaj72981 merged pull request #2675: HBASE-25277 postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-12-07 Thread GitBox
pankaj72981 merged pull request #2675: URL: https://github.com/apache/hbase/pull/2675 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [hbase] pankaj72981 commented on pull request #2675: HBASE-25277 postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-12-07 Thread GitBox
pankaj72981 commented on pull request #2675: URL: https://github.com/apache/hbase/pull/2675#issuecomment-740063419 UT failures are not related. This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [hbase] Apache-HBase commented on pull request #2745: [HBASE-25246] Backup/Restore hbase cell tags.

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2745: URL: https://github.com/apache/hbase/pull/2745#issuecomment-740044946 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30

[GitHub] [hbase] shahrs87 opened a new pull request #2745: [HBASE-25246] Backup/Restore hbase cell tags.

2020-12-07 Thread GitBox
shahrs87 opened a new pull request #2745: URL: https://github.com/apache/hbase/pull/2745 @anoopsjohn I have added a boolean flag (encodeTags/decodeTags) in [ProtobufUtil](https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/Protobuf

[jira] [Created] (HBASE-25367) Sort broken after Change 'State time' in UI

2020-12-07 Thread Akshay Sudheer (Jira)
Akshay Sudheer created HBASE-25367: -- Summary: Sort broken after Change 'State time' in UI Key: HBASE-25367 URL: https://issues.apache.org/jira/browse/HBASE-25367 Project: HBase Issue Type: B

[GitHub] [hbase] Apache9 commented on pull request #2739: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

2020-12-07 Thread GitBox
Apache9 commented on pull request #2739: URL: https://github.com/apache/hbase/pull/2739#issuecomment-739956977 Oh, could you please confirm that in HMaster, we will pass in the Map when creating log cleaner? I think we will do this for hfile cleaner, but not sure about log cleaner... ---

[jira] [Updated] (HBASE-25366) [Documentation] Fix spelling error in sync_replication.adoc

2020-12-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25366: -- Resolution: Fixed Status: Resolved (was: Patch Available) Merged to master. Thanks [~SWH12]

[GitHub] [hbase] Apache9 commented on a change in pull request #2738: HBASE-25363 Improve performance of HFileLinkCleaner by using ReadWrit…

2020-12-07 Thread GitBox
Apache9 commented on a change in pull request #2738: URL: https://github.com/apache/hbase/pull/2738#discussion_r537548207 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/HFileLinkCleaner.java ## @@ -44,71 +45,79 @@ private static final Logger

[GitHub] [hbase] Apache-HBase commented on pull request #2716: HBASE-25336 Use Address instead of InetSocketAddress in RpcClient imp…

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2716: URL: https://github.com/apache/hbase/pull/2716#issuecomment-739947223 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[jira] [Updated] (HBASE-25366) [Documentation] Fix spelling error in sync_replication.adoc

2020-12-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25366: -- Fix Version/s: 3.0.0-alpha-1 > [Documentation] Fix spelling error in sync_replication.adoc > -

[GitHub] [hbase] Apache-HBase commented on pull request #2716: HBASE-25336 Use Address instead of InetSocketAddress in RpcClient imp…

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2716: URL: https://github.com/apache/hbase/pull/2716#issuecomment-739943428 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5

[GitHub] [hbase] Apache9 merged pull request #2744: HBASE-25366 [Documentation] Fix spelling error in sync_replication.adoc

2020-12-07 Thread GitBox
Apache9 merged pull request #2744: URL: https://github.com/apache/hbase/pull/2744 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Updated] (HBASE-25366) [Documentation] Fix spelling error in sync_replication.adoc

2020-12-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25366: -- Summary: [Documentation] Fix spelling error in sync_replication.adoc (was: [Documentation] Fix spelli

[jira] [Assigned] (HBASE-25366) [Documentation] Fix spelling error

2020-12-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-25366: - Assignee: wenhao > [Documentation] Fix spelling error > -- > >

[GitHub] [hbase] Apache-HBase commented on pull request #2716: HBASE-25336 Use Address instead of InetSocketAddress in RpcClient imp…

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2716: URL: https://github.com/apache/hbase/pull/2716#issuecomment-739940961 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3

[jira] [Updated] (HBASE-25337) The stub in AsyncConnectionImpl.rsStubs and adminSubs never gets cleaned up

2020-12-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25337: -- Description: Currently there is no way for us to remove the unused stub in these two maps, and after

[jira] [Updated] (HBASE-25336) Use Address instead of InetSocketAddress in RpcClient implementation

2020-12-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25336: -- Fix Version/s: 2.5.0 3.0.0-alpha-1 > Use Address instead of InetSocketAddress in Rp

[jira] [Resolved] (HBASE-25336) Use Address instead of InetSocketAddress in RpcClient implementation

2020-12-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25336. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to master and branch-2. Thanks [~zghao] for r

[GitHub] [hbase] Apache9 merged pull request #2716: HBASE-25336 Use Address instead of InetSocketAddress in RpcClient imp…

2020-12-07 Thread GitBox
Apache9 merged pull request #2716: URL: https://github.com/apache/hbase/pull/2716 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Commented] (HBASE-15273) Advance Hybrid Cloud Architecture (AHA) - Advance HBase (Umbrella) JIRA

2020-12-07 Thread Dinesh S. Atreya (Jira)
[ https://issues.apache.org/jira/browse/HBASE-15273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245190#comment-17245190 ] Dinesh S. Atreya commented on HBASE-15273: -- Other pertinent Jira is https://iss

[GitHub] [hbase] Apache-HBase commented on pull request #2675: HBASE-25277 postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2675: URL: https://github.com/apache/hbase/pull/2675#issuecomment-739857429 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s

[GitHub] [hbase] Apache-HBase commented on pull request #2675: HBASE-25277 postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2675: URL: https://github.com/apache/hbase/pull/2675#issuecomment-739856442 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 11

[jira] [Commented] (HBASE-24637) Reseek regression related to filter SKIP hinting

2020-12-07 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245133#comment-17245133 ] ramkrishna.s.vasudevan commented on HBASE-24637: I have attached a PPt t

[jira] [Updated] (HBASE-24637) Reseek regression related to filter SKIP hinting

2020-12-07 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-24637: --- Attachment: seeksVsSkip_ppt.pptx > Reseek regression related to filter SKIP

[GitHub] [hbase] Apache-HBase commented on pull request #2742: HBASE-25365 The log in move_servers_rsgroup is incorrect

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2742: URL: https://github.com/apache/hbase/pull/2742#issuecomment-739839038 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7

[jira] [Commented] (HBASE-20515) Cleanup ProcedureExecutor#stop and #join interaction/dependency

2020-12-07 Thread Shroff Amrith Nayak (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245092#comment-17245092 ] Shroff Amrith Nayak commented on HBASE-20515: - Additionally, I have observed

[GitHub] [hbase] Apache-HBase commented on pull request #2675: HBASE-25277 postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2675: URL: https://github.com/apache/hbase/pull/2675#issuecomment-739786004 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15

[GitHub] [hbase] Apache-HBase commented on pull request #2742: HBASE-25365 The log in move_servers_rsgroup is incorrect

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2742: URL: https://github.com/apache/hbase/pull/2742#issuecomment-739781697 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[GitHub] [hbase] Apache9 commented on pull request #2729: Remove the use of term segregate

2020-12-07 Thread GitBox
Apache9 commented on pull request #2729: URL: https://github.com/apache/hbase/pull/2729#issuecomment-739763325 And we need a jira issue? This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [hbase] virajjasani commented on pull request #2729: Remove the use of term segregate

2020-12-07 Thread GitBox
virajjasani commented on pull request #2729: URL: https://github.com/apache/hbase/pull/2729#issuecomment-739762986 Also, please create HBase Jira and assign HBASE-x Jira number in PR title. This is an automated message f

[GitHub] [hbase] virajjasani commented on pull request #2729: Remove the use of term segregate

2020-12-07 Thread GitBox
virajjasani commented on pull request #2729: URL: https://github.com/apache/hbase/pull/2729#issuecomment-739762530 @sethsawant once the compilation error is fixed by correcting spelling mistake, this PR can be merged soon. Thanks

[GitHub] [hbase] pankaj72981 commented on a change in pull request #2675: HBASE-25277 postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-12-07 Thread GitBox
pankaj72981 commented on a change in pull request #2675: URL: https://github.com/apache/hbase/pull/2675#discussion_r537314879 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java ## @@ -102,6 +102,11 @@ // optimization: no

[GitHub] [hbase] Apache-HBase commented on pull request #2744: HBASE-25366 [Documentation] Update sync_replication.adoc

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2744: URL: https://github.com/apache/hbase/pull/2744#issuecomment-739750337 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 43

[GitHub] [hbase] Apache-HBase commented on pull request #2743: HBASE-25365 The log in move_servers_rsgroup is incorrect

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2743: URL: https://github.com/apache/hbase/pull/2743#issuecomment-739749234 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47

[jira] [Commented] (HBASE-22120) Replace HTrace with OpenTracing

2020-12-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245039#comment-17245039 ] Duo Zhang commented on HBASE-22120: --- Anyway, let me try to make use of OpenTelemetry.

[GitHub] [hbase] Apache-HBase commented on pull request #2743: HBASE-25365 The log in move_servers_rsgroup is incorrect

2020-12-07 Thread GitBox
Apache-HBase commented on pull request #2743: URL: https://github.com/apache/hbase/pull/2743#issuecomment-739747044 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 20