[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding HStoreContext

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-749986720 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30

[jira] [Commented] (HBASE-25432) we should add security checks for setTableStateInMeta

2020-12-22 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253928#comment-17253928 ] lujie commented on HBASE-25432: --- yes, i will try my best to fix it. > we should add secur

[jira] [Commented] (HBASE-25432) we should add security checks for setTableStateInMeta

2020-12-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253920#comment-17253920 ] Viraj Jasani commented on HBASE-25432: -- We should ensure rpc implementation uses ac

[jira] [Comment Edited] (HBASE-25432) we should add security checks for setTableStateInMeta

2020-12-22 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253911#comment-17253911 ] lujie edited comment on HBASE-25432 at 12/23/20, 6:44 AM: -- We a

[jira] [Commented] (HBASE-25432) we should add security checks for setTableStateInMeta

2020-12-22 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253911#comment-17253911 ] lujie commented on HBASE-25432: --- We also find that Hbck.fixMeta also lack of security chec

[GitHub] [hbase] saintstack commented on a change in pull request #2800: HBASE-25249 Adding HStoreContext

2020-12-22 Thread GitBox
saintstack commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r547688417 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java ## @@ -136,4 +140,26 @@ public static OptionalLong getMax

[jira] [Commented] (HBASE-25424) Find a way to config OpenTelemetry tracing without directly depending on opentelemetry-sdk

2020-12-22 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253897#comment-17253897 ] ramkrishna.s.vasudevan commented on HBASE-25424: I also believe that we

[jira] [Commented] (HBASE-25424) Find a way to config OpenTelemetry tracing without directly depending on opentelemetry-sdk

2020-12-22 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253896#comment-17253896 ] ramkrishna.s.vasudevan commented on HBASE-25424: [~zhangduo] One Quick

[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding HStoreContext

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-749940604 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] Apache-HBase commented on pull request #2804: HBASE-25437 Update refguide RC section; point at the dev-tools/create…

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2804: URL: https://github.com/apache/hbase/pull/2804#issuecomment-749935631 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[GitHub] [hbase] Apache-HBase commented on pull request #2804: HBASE-25437 Update refguide RC section; point at the dev-tools/create…

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2804: URL: https://github.com/apache/hbase/pull/2804#issuecomment-749931631 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3

[GitHub] [hbase] Apache-HBase commented on pull request #2804: HBASE-25437 Update refguide RC section; point at the dev-tools/create…

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2804: URL: https://github.com/apache/hbase/pull/2804#issuecomment-749931495 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[GitHub] [hbase] Apache-HBase commented on pull request #2806: HBASE-24573 do-release should sign the commits and tag it creates

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2806: URL: https://github.com/apache/hbase/pull/2806#issuecomment-749930747 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [hbase] Apache-HBase commented on pull request #2806: HBASE-24573 do-release should sign the commits and tag it creates

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2806: URL: https://github.com/apache/hbase/pull/2806#issuecomment-749930665 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding HStoreContext

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-749928195 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14

[GitHub] [hbase] Apache-HBase commented on pull request #2804: HBASE-25437 Update refguide RC section; point at the dev-tools/create…

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2804: URL: https://github.com/apache/hbase/pull/2804#issuecomment-749924637 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] Apache-HBase commented on pull request #2804: HBASE-25437 Update refguide RC section; point at the dev-tools/create…

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2804: URL: https://github.com/apache/hbase/pull/2804#issuecomment-749920679 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2

[GitHub] [hbase] Apache-HBase commented on pull request #2804: HBASE-25437 Update refguide RC section; point at the dev-tools/create…

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2804: URL: https://github.com/apache/hbase/pull/2804#issuecomment-749920539 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[jira] [Commented] (HBASE-25424) Find a way to config OpenTelemetry tracing without directly depending on opentelemetry-sdk

2020-12-22 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253882#comment-17253882 ] Duo Zhang commented on HBASE-25424: --- Or maybe another way is to attach opentelemetry i

[GitHub] [hbase] Apache-HBase commented on pull request #2806: HBASE-24573 do-release should sign the commits and tag it creates

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2806: URL: https://github.com/apache/hbase/pull/2806#issuecomment-749917217 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34

[GitHub] [hbase] Apache-HBase commented on pull request #2806: HBASE-24573 do-release should sign the commits and tag it creates

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2806: URL: https://github.com/apache/hbase/pull/2806#issuecomment-749917162 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[jira] [Updated] (HBASE-25424) Find a way to config OpenTelemetry tracing without directly depending on opentelemetry-sdk

2020-12-22 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25424: -- Description: According to the document of OpenTelemetry, for all the modules which could be depended

[jira] [Resolved] (HBASE-25401) Add trace support for async call in rpc client

2020-12-22 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25401. --- Fix Version/s: HBASE-22120 Resolution: Fixed Merged to branch HBASE-22120. Thanks [~zghao] f

[GitHub] [hbase] Apache9 merged pull request #2790: HBASE-25401 Add trace support for async call in rpc client

2020-12-22 Thread GitBox
Apache9 merged pull request #2790: URL: https://github.com/apache/hbase/pull/2790 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding HStoreContext

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-749905442 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[jira] [Commented] (HBASE-25407) list_regions make potential sensitive information disclosure

2020-12-22 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253845#comment-17253845 ] lujie commented on HBASE-25407: ---   [~vjasani]   {code:java} As far as this one is concer

[GitHub] [hbase] Apache-HBase commented on pull request #2807: HBASE-25438 Update create-release mvn in Dockerfile; its 3.6.0; make …

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2807: URL: https://github.com/apache/hbase/pull/2807#issuecomment-749880792 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s

[GitHub] [hbase] Apache-HBase commented on pull request #2807: HBASE-25438 Update create-release mvn in Dockerfile; its 3.6.0; make …

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2807: URL: https://github.com/apache/hbase/pull/2807#issuecomment-749880719 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [hbase] saintstack opened a new pull request #2807: HBASE-25438 Update create-release mvn in Dockerfile; its 3.6.0; make …

2020-12-22 Thread GitBox
saintstack opened a new pull request #2807: URL: https://github.com/apache/hbase/pull/2807 …it 3.6.3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (HBASE-25438) Update create-release mvn in Dockerfile; its 3.6.0; make it 3.6.3

2020-12-22 Thread Michael Stack (Jira)
Michael Stack created HBASE-25438: - Summary: Update create-release mvn in Dockerfile; its 3.6.0; make it 3.6.3 Key: HBASE-25438 URL: https://issues.apache.org/jira/browse/HBASE-25438 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding HStoreContext

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-749862873 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding HStoreContext

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-749850298 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s

[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding HStoreContext

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-749848750 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31

[GitHub] [hbase] Apache-HBase commented on pull request #2806: HBASE-24573 do-release should sign the commits and tag it creates

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2806: URL: https://github.com/apache/hbase/pull/2806#issuecomment-749842435 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [hbase] saintstack commented on pull request #2806: HBASE-24573 do-release should sign the commits and tag it creates

2020-12-22 Thread GitBox
saintstack commented on pull request #2806: URL: https://github.com/apache/hbase/pull/2806#issuecomment-749841964 Testing shows this seems to do the right thing ``` tag 2.4.1-rm_test2RC8 Tagger: stack Date: Tue Dec 22 23:37:31 2020 + via create-release

[GitHub] [hbase] saintstack opened a new pull request #2806: HBASE-24573 do-release should sign the commits and tag it creates

2020-12-22 Thread GitBox
saintstack opened a new pull request #2806: URL: https://github.com/apache/hbase/pull/2806 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] saintstack closed pull request #2805: HBASE-24573 do-release should sign the commits and tag it creates

2020-12-22 Thread GitBox
saintstack closed pull request #2805: URL: https://github.com/apache/hbase/pull/2805 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2805: HBASE-24573 do-release should sign the commits and tag it creates

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2805: URL: https://github.com/apache/hbase/pull/2805#issuecomment-749806660 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [hbase] Apache-HBase commented on pull request #2805: HBASE-24573 do-release should sign the commits and tag it creates

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2805: URL: https://github.com/apache/hbase/pull/2805#issuecomment-749806505 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43

[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding HStoreContext

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-749802781 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31

[GitHub] [hbase] Apache-HBase commented on pull request #2805: HBASE-24573 do-release should sign the commits and tag it creates

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2805: URL: https://github.com/apache/hbase/pull/2805#issuecomment-749796083 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 37

[GitHub] [hbase] Apache-HBase commented on pull request #2805: HBASE-24573 do-release should sign the commits and tag it creates

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2805: URL: https://github.com/apache/hbase/pull/2805#issuecomment-749796005 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 34

[GitHub] [hbase] Apache-HBase commented on pull request #2805: HBASE-24573 do-release should sign the commits and tag it creates

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2805: URL: https://github.com/apache/hbase/pull/2805#issuecomment-749795741 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31

[GitHub] [hbase] taklwu commented on pull request #2800: HBASE-25249 Adding HStoreContext

2020-12-22 Thread GitBox
taklwu commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-749784957 @apurtell requested changes updated. I shouldn't rebase and squash for the updated changes, will be providing a new diff on top of the first/original change next time

[GitHub] [hbase] Apache-HBase commented on pull request #2805: HBASE-24573 do-release should sign the commits and tag it creates

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2805: URL: https://github.com/apache/hbase/pull/2805#issuecomment-749783753 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 32

[GitHub] [hbase] Apache-HBase commented on pull request #2804: HBASE-25437 Update refguide RC section; point at the dev-tools/create…

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2804: URL: https://github.com/apache/hbase/pull/2804#issuecomment-749783335 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26

[GitHub] [hbase] Apache-HBase commented on pull request #2805: HBASE-24573 do-release should sign the commits and tag it creates

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2805: URL: https://github.com/apache/hbase/pull/2805#issuecomment-749783151 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[GitHub] [hbase] Apache-HBase commented on pull request #2805: HBASE-24573 do-release should sign the commits and tag it creates

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2805: URL: https://github.com/apache/hbase/pull/2805#issuecomment-749783085 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[GitHub] [hbase] saintstack opened a new pull request #2805: HBASE-24573 do-release should sign the commits and tag it creates

2020-12-22 Thread GitBox
saintstack opened a new pull request #2805: URL: https://github.com/apache/hbase/pull/2805 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] Apache-HBase commented on pull request #2804: HBASE-25437 Update refguide RC section; point at the dev-tools/create…

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2804: URL: https://github.com/apache/hbase/pull/2804#issuecomment-749778238 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3

[GitHub] [hbase] Apache-HBase commented on pull request #2804: HBASE-25437 Update refguide RC section; point at the dev-tools/create…

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2804: URL: https://github.com/apache/hbase/pull/2804#issuecomment-749777998 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] saintstack opened a new pull request #2804: HBASE-25437 Update refguide RC section; point at the dev-tools/create…

2020-12-22 Thread GitBox
saintstack opened a new pull request #2804: URL: https://github.com/apache/hbase/pull/2804 …-releases/README.txt rather than repeat its content M dev-support/create-release/README.txt Remove redundant text. Add some extra help around figuring state of gpg-agent. M dev-s

[jira] [Created] (HBASE-25437) Update refguide RC section; point at the dev-tools/create-releases/README.txt rather than repeat its content

2020-12-22 Thread Michael Stack (Jira)
Michael Stack created HBASE-25437: - Summary: Update refguide RC section; point at the dev-tools/create-releases/README.txt rather than repeat its content Key: HBASE-25437 URL: https://issues.apache.org/jira/browse

[jira] [Commented] (HBASE-25432) we should add security checks for setTableStateInMeta

2020-12-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253727#comment-17253727 ] Viraj Jasani commented on HBASE-25432: -- Thanks for filing this [~xiaoheipangzi]. I

[jira] [Updated] (HBASE-25432) we should add security checks for setTableStateInMeta

2020-12-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-25432: - Fix Version/s: 2.4.1 2.5.0 2.3.4 1.7.0

[jira] [Commented] (HBASE-25277) postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-12-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253726#comment-17253726 ] Hudson commented on HBASE-25277: Results for branch branch-2.2 [build #140 on b

[GitHub] [hbase] Apache-HBase commented on pull request #2757: HBASE-25379 Make retry pause time configurable for regionserver short operation RPC (reportRegionStateTransition/reportProcedureDone)

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2757: URL: https://github.com/apache/hbase/pull/2757#issuecomment-749741213 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 47

[jira] [Commented] (HBASE-24764) Add support of adding base peer configs via hbase-site.xml for all replication peers.

2020-12-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253689#comment-17253689 ] Hudson commented on HBASE-24764: Results for branch branch-2.3 [build #130 on b

[jira] [Commented] (HBASE-25383) HBase doesn't update and remove the peer config from hbase.replication.source.custom.walentryfilters if the config is already set on the peer.

2020-12-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253688#comment-17253688 ] Hudson commented on HBASE-25383: Results for branch branch-2.3 [build #130 on b

[jira] [Issue Comment Deleted] (HBASE-25432) we should add security checks for setTableStateInMeta

2020-12-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-25432: - Comment: was deleted (was: [~xiaoheipangzi] Did you have access control set up properly before

[jira] [Commented] (HBASE-25432) we should add security checks for setTableStateInMeta

2020-12-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253677#comment-17253677 ] Viraj Jasani commented on HBASE-25432: -- [~xiaoheipangzi] Did you have access contro

[GitHub] [hbase] Apache-HBase commented on pull request #2757: HBASE-25379 Make retry pause time configurable for regionserver short operation RPC (reportRegionStateTransition/reportProcedureDone)

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2757: URL: https://github.com/apache/hbase/pull/2757#issuecomment-749706631 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[jira] [Commented] (HBASE-25425) Some notes on RawCell

2020-12-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253673#comment-17253673 ] Hudson commented on HBASE-25425: Results for branch branch-2 [build #136 on bui

[jira] [Commented] (HBASE-24620) Add a ClusterManager which submits command to ZooKeeper and its Agent which picks and execute those Commands.

2020-12-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253672#comment-17253672 ] Hudson commented on HBASE-24620: Results for branch branch-2 [build #136 on bui

[jira] [Commented] (HBASE-25407) list_regions make potential sensitive information disclosure

2020-12-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253674#comment-17253674 ] Viraj Jasani commented on HBASE-25407: -- FYI [~apurtell] > list_regions make potent

[jira] [Commented] (HBASE-25407) list_regions make potential sensitive information disclosure

2020-12-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253671#comment-17253671 ] Viraj Jasani commented on HBASE-25407: -- [~xiaoheipangzi]  First of all, thanks for

[jira] [Updated] (HBASE-25407) list_regions make potential sensitive information disclosure

2020-12-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-25407: - Fix Version/s: (was: 2.4.1) (was: 2.5.0) (was:

[jira] [Commented] (HBASE-24850) CellComparator perf improvement

2020-12-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253652#comment-17253652 ] Michael Stack commented on HBASE-24850: --- +1 for backports > CellComparator perf i

[GitHub] [hbase] Apache-HBase commented on pull request #2757: HBASE-25379 Make retry pause time configurable for regionserver short operation RPC (reportRegionStateTransition/reportProcedureDone)

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2757: URL: https://github.com/apache/hbase/pull/2757#issuecomment-749642153 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 47

[GitHub] [hbase] Apache-HBase commented on pull request #2752: HBASE-25374 Make REST Client connection and socket time out configurable

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2752: URL: https://github.com/apache/hbase/pull/2752#issuecomment-749638080 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26

[GitHub] [hbase] Apache-HBase commented on pull request #2752: HBASE-25374 Make REST Client connection and socket time out configurable

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2752: URL: https://github.com/apache/hbase/pull/2752#issuecomment-749634135 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s

[GitHub] [hbase] Apache-HBase commented on pull request #2752: HBASE-25374 Make REST Client connection and socket time out configurable

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2752: URL: https://github.com/apache/hbase/pull/2752#issuecomment-749633199 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s

[GitHub] [hbase] Apache-HBase commented on pull request #2802: HBASE-24850 CellComparator perf improvement

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2802: URL: https://github.com/apache/hbase/pull/2802#issuecomment-749613155 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s

[jira] [Updated] (HBASE-25379) Make retry pause time configurable for regionserver short operation RPC (reportRegionStateTransition/reportProcedureDone)

2020-12-22 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-25379: - Summary: Make retry pause time configurable for regionserver short operation RPC (reportRegionSt

[GitHub] [hbase] pankaj72981 commented on pull request #2757: HBASE-25379 Make intial pause time configurable for regionserver while sending reportRegionStateTransition

2020-12-22 Thread GitBox
pankaj72981 commented on pull request #2757: URL: https://github.com/apache/hbase/pull/2757#issuecomment-749609981 Addressed the review comments, please check. This is an automated message from the Apache Git Service. To resp

[GitHub] [hbase] pankaj72981 commented on a change in pull request #2757: HBASE-25379 Make intial pause time configurable for regionserver while sending reportRegionStateTransition

2020-12-22 Thread GitBox
pankaj72981 commented on a change in pull request #2757: URL: https://github.com/apache/hbase/pull/2757#discussion_r544084954 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java ## @@ -2436,10 +2442,8 @@ public boolean reportRegionS

[GitHub] [hbase] Apache-HBase commented on pull request #2802: HBASE-24850 CellComparator perf improvement

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2802: URL: https://github.com/apache/hbase/pull/2802#issuecomment-749609693 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[GitHub] [hbase] Apache-HBase commented on pull request #2790: HBASE-25401 Add trace support for async call in rpc client

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2790: URL: https://github.com/apache/hbase/pull/2790#issuecomment-749609418 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s

[jira] [Commented] (HBASE-24620) Add a ClusterManager which submits command to ZooKeeper and its Agent which picks and execute those Commands.

2020-12-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253551#comment-17253551 ] Hudson commented on HBASE-24620: Results for branch branch-1 [build #68 on buil

[jira] [Updated] (HBASE-25421) There is no limit on the column family length when creating a table

2020-12-22 Thread LiDingSheng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LiDingSheng updated HBASE-25421: Summary: There is no limit on the column family length when creating a table (was: There is no li

[GitHub] [hbase] Apache-HBase commented on pull request #2802: HBASE-24850 CellComparator perf improvement

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2802: URL: https://github.com/apache/hbase/pull/2802#issuecomment-749546597 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41

[GitHub] [hbase] Apache-HBase commented on pull request #2803: HBASE-25431 MAX_FILESIZE and MEMSTORE_FLUSHSIZE should not be set negative number

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2803: URL: https://github.com/apache/hbase/pull/2803#issuecomment-749535785 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 13

[jira] [Commented] (HBASE-25371) When openRegion fails during initial verification(before initializing and setting seq num), exception is observed during region close.

2020-12-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253483#comment-17253483 ] Hudson commented on HBASE-25371: Results for branch master [build #164 on build

[jira] [Commented] (HBASE-25425) Some notes on RawCell

2020-12-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253482#comment-17253482 ] Hudson commented on HBASE-25425: Results for branch master [build #164 on build

[jira] [Commented] (HBASE-24620) Add a ClusterManager which submits command to ZooKeeper and its Agent which picks and execute those Commands.

2020-12-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253481#comment-17253481 ] Hudson commented on HBASE-24620: Results for branch master [build #164 on build

[jira] [Commented] (HBASE-25084) RegexStringComparator in ParseFilter should support case-insensitive regexes

2020-12-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253480#comment-17253480 ] Hudson commented on HBASE-25084: Results for branch master [build #164 on build

[jira] [Commented] (HBASE-24850) CellComparator perf improvement

2020-12-22 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253474#comment-17253474 ] Pankaj Kumar commented on HBASE-24850: -- Would be great if we bring this to branch-2

[GitHub] [hbase] Apache-HBase commented on pull request #2790: HBASE-25401 Add trace support for async call in rpc client

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2790: URL: https://github.com/apache/hbase/pull/2790#issuecomment-749529636 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32

[GitHub] [hbase] Apache-HBase commented on pull request #2803: HBASE-25431 MAX_FILESIZE and MEMSTORE_FLUSHSIZE should not be set negative number

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2803: URL: https://github.com/apache/hbase/pull/2803#issuecomment-749513197 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s

[GitHub] [hbase] Apache-HBase commented on pull request #2790: HBASE-25401 Add trace support for async call in rpc client

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2790: URL: https://github.com/apache/hbase/pull/2790#issuecomment-749484258 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10

[jira] [Updated] (HBASE-25432) we should add security checks for setTableStateInMeta

2020-12-22 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25432: -- Description: (was: t) > we should add security checks for setTableStateInMeta > --

[jira] [Updated] (HBASE-25432) we should add security checks for setTableStateInMeta

2020-12-22 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25432: -- Priority: Blocker (was: Major) > we should add security checks for setTableStateInMeta >

[jira] [Updated] (HBASE-25432) we should add security checks for setTableStateInMeta

2020-12-22 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25432: -- Description: t > we should add security checks for setTableStateInMeta > -

[jira] [Reopened] (HBASE-25383) HBase doesn't update and remove the peer config from hbase.replication.source.custom.walentryfilters if the config is already set on the peer.

2020-12-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reopened HBASE-25383: -- Reverting commit from branch-2.3 as HBASE-24743 is not present and this change has dependency on

[jira] [Resolved] (HBASE-25383) HBase doesn't update and remove the peer config from hbase.replication.source.custom.walentryfilters if the config is already set on the peer.

2020-12-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-25383. -- Fix Version/s: (was: 2.3.4) Resolution: Fixed > HBase doesn't update and remove the

[jira] [Resolved] (HBASE-24764) Add support of adding base peer configs via hbase-site.xml for all replication peers.

2020-12-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-24764. -- Fix Version/s: (was: 2.3.4) Resolution: Fixed > Add support of adding base peer con

[jira] [Updated] (HBASE-25432) we should add security checks for setTableStateInMeta

2020-12-22 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25432: -- Description: (was: setTableStateInMeta is public, that means anyone can call it.) > we should add securit

[jira] [Reopened] (HBASE-24764) Add support of adding base peer configs via hbase-site.xml for all replication peers.

2020-12-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reopened HBASE-24764: -- Reverting commit from branch-2.3 as HBASE-24743 is not present. > Add support of adding base peer

[GitHub] [hbase] Apache-HBase commented on pull request #2803: HBASE-25431 MAX_FILESIZE and MEMSTORE_FLUSHSIZE should not be set negative number

2020-12-22 Thread GitBox
Apache-HBase commented on pull request #2803: URL: https://github.com/apache/hbase/pull/2803#issuecomment-749460512 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[jira] [Commented] (HBASE-24764) Add support of adding base peer configs via hbase-site.xml for all replication peers.

2020-12-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253378#comment-17253378 ] Hudson commented on HBASE-24764: Results for branch branch-2.3 [build #129 on b

  1   2   >