[GitHub] [hbase] lujiefsi edited a comment on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta
lujiefsi edited a comment on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-751138386 It seems that everything is ok, The only question is can we add the fix for [HBASE-25441](https://issues.apache.org/jira/browse/HBASE-25441) in this pull reqeust? Then I want to summay the reason why previous UT fails, hope this can help others who write UT about AccessController. 1. In the first version, I use _'TEST_UTIL.getHbck'_ to get client: _'getHbck'_, then use its '_getConnection_' to obtain the connection(**be careful here**). This connection is _systemUserConnection_(see TestAccessController#278), that means if you use this connection, the user passed to RPCServer are always the system user, i.e. who run the UT, hence permission check are always passed. 2. In the second version, i use _ConnectionFactory.createConnection(TEST_UTIL.getConfiguration()_ to obtain the connection and use this connection to gain the hbck, i can pass the user who really call the command to RPCServer. Checking the test log we can see that _AccessDeniedException_ is thrown, But UT still can not see it. After checking the code, i found that the exception **are warped into _RemoteWithExtrasException_** who are not handled in method _SecureTestUtil@verifyDenied_.. Other UT call the command on RPCServer directly, not through the RPC, so they do not meet this problem. In future, if we want to add more test about RPC security, we need address this problem. I have fixed this bug in this pull request by unwaping the _RemoteWithExtrasException_. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] lujiefsi edited a comment on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta
lujiefsi edited a comment on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-751138386 It seems that everything is ok, The only question is can we add the fix for [HBASE-25441](https://issues.apache.org/jira/browse/HBASE-25441) in this pull reqeust? Then I want to summay the reason why previous UT fails, hope this can help others who write UT about AccessController. 1. In the first version, I use _'TEST_UTIL.getHbck'_ to get client: _'getHbck'_, then use its '_getConnection_' to obtain the connection(**be careful here**). This connection is _systemUserConnection_(see TestAccessController#278), that means if you use this connection, the user passed to RPCServer are always the system user, i.e. who run the UT, hence permission check are always passed. 2. In the second version, i use _ConnectionFactory.createConnection(TEST_UTIL.getConfiguration()_, to obtain the connection and use this connection to gain the hbck, i can pass the user who really call the command to RPCServer. Checking the test log we can see that _AccessDeniedException_ is thrown, But UT still can not see it. After checking the code, i found that the exception **are warped into _RemoteWithExtrasException_** who are not handled in method _SecureTestUtil@verifyDenied_.. Other UT call the command on RPCServer directly, not through the RPC, so they do not meet this problem. In future, if we want to add more test about RPC security, we need address this problem. I have fixed this bug in this pull request by unwaping the _RemoteWithExtrasException_. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] lujiefsi edited a comment on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta
lujiefsi edited a comment on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-751138386 It seems that everything is ok, The only question is can we add the fix for [HBASE-25441](https://issues.apache.org/jira/browse/HBASE-25441) in this pull reqeust? Then I want to summay the reason why previous UT fails, hope this can help others who write UT about AccessController. 1. In the first version, I use _'TEST_UTIL.getHbck'_ to get client. _'getHbck'_ and use its '_getConnection_' to obtain the connection(**be careful here**). This connection is _systemUserConnection_(see TestAccessController#278), that means if you use this connection, the user passed to RPCServer are always the system user, i.e. who run the UT, hence permission check are always passed. 2. In the second version, i use _ConnectionFactory.createConnection(TEST_UTIL.getConfiguration()_, to obtain the connection and use this connection to gain the hbck, i can pass the user who really call the command to RPCServer. Checking the test log we can see that _AccessDeniedException_ is thrown, But UT still can not see it. After checking the code, i found that the exception **are warped into _RemoteWithExtrasException_** who are not handled in method _SecureTestUtil@verifyDenied_.. Other UT call the command on RPCServer directly, not through the RPC, so they do not meet this problem. In future, if we want to add more test about RPC security, we need address this problem. I have fixed this bug in this pull request by unwaping the _RemoteWithExtrasException_. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] lujiefsi edited a comment on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta
lujiefsi edited a comment on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-751138386 It seems that everything is ok, The only question is can we add the fix for [HBASE-25441](https://issues.apache.org/jira/browse/HBASE-25441) in this pull reqeust? Then I want to summay the reason why previous UT fails, hope this can help others who write UT about AccessController. 1. In the first version, I use _'TEST_UTIL.getHbck'_ to get client. _'getHbck'_ use '_getConnection_' to obtain the connection(**be careful here**). This connection is _systemUserConnection_(see TestAccessController#278), that means if you use this connection, the user passed to RPCServer are always the system user, i.e. who run the UT, hence permission check are always passed. 2. In the second version, i use _ConnectionFactory.createConnection(TEST_UTIL.getConfiguration()_, to obtain the connection and use this connection to gain the hbck, i can pass the user who really call the command to RPCServer. Checking the test log we can see that _AccessDeniedException_ is thrown, But UT still can not see it. After checking the code, i found that the exception **are warped into _RemoteWithExtrasException_** who are not handled in method _SecureTestUtil@verifyDenied_.. Other UT call the command on RPCServer directly, not through the RPC, so they do not meet this problem. In future, if we want to add more test about RPC security, we need address this problem. I have fixed this bug in this pull request by unwaping the _RemoteWithExtrasException_. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-25445) SplitWALRemoteProcedure failed to archive split WAL
mokai created HBASE-25445: - Summary: SplitWALRemoteProcedure failed to archive split WAL Key: HBASE-25445 URL: https://issues.apache.org/jira/browse/HBASE-25445 Project: HBase Issue Type: Bug Components: wal Affects Versions: 2.2.3, 3.0.0-alpha-1, 2.4.1 Reporter: mokai If 'hbase.wal.dir' and 'hbase.rootdir' are configured to diffrent filesystem, SplitWALRemoteProcedure archived split WAL failed since SplitWALManager using wrong fs instance. SplitWALManager should use WAL corresponding fs instance. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25444) Add a filter with containing semantic
[ https://issues.apache.org/jira/browse/HBASE-25444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junsheng Tan updated HBASE-25444: - Description: Say we want to check whether a cell value is within a set of values. If the size of the set is 1000, we need to create 1000 SingleColumnValueFilter with CompareOperator.EQUAL and wrap them with a FilterListWithOR. The scan performance of these filters would be very bad. But if we have a set filter, we just need to create only one filter with 1000 values. And the containing operation could be implemented as O(1) or O(log( n )). This `SetFilter` is general and useful in my opinion, so would the community consider to implement a `SetFilter`? was: Say we want to check whether a cell value is within a set of values. If the size of the set is 1000, we need to create 1000 SingleColumnValueFilter with CompareOperator.EQUAL and wrap them with a FilterListWithOR. The scan performance of these filters would be very bad. But if we have a set filter, we just need to create only one filter with 1000 values. And the containing operation could be implemented as O(1) or O(log(n)). This `SetFilter` is general and useful in my opinion, so would the community consider to implement a `SetFilter`? > Add a filter with containing semantic > - > > Key: HBASE-25444 > URL: https://issues.apache.org/jira/browse/HBASE-25444 > Project: HBase > Issue Type: New Feature > Components: Filters >Affects Versions: 3.0.0-alpha-1 >Reporter: Junsheng Tan >Priority: Major > > Say we want to check whether a cell value is within a set of values. > If the size of the set is 1000, we need to create 1000 > SingleColumnValueFilter with CompareOperator.EQUAL and wrap them with a > FilterListWithOR. The scan performance of these filters would be very bad. > But if we have a set filter, we just need to create only one filter with 1000 > values. And the containing operation could be implemented as O(1) or O(log( > n )). > This `SetFilter` is general and useful in my opinion, so would the community > consider to implement a `SetFilter`? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-25444) Add a filter with containing semantic
Junsheng Tan created HBASE-25444: Summary: Add a filter with containing semantic Key: HBASE-25444 URL: https://issues.apache.org/jira/browse/HBASE-25444 Project: HBase Issue Type: New Feature Components: Filters Affects Versions: 3.0.0-alpha-1 Reporter: Junsheng Tan Say we want to check whether a cell value is within a set of values. If the size of the set is 1000, we need to create 1000 SingleColumnValueFilter with CompareOperator.EQUAL and wrap them with a FilterListWithOR. The scan performance of these filters would be very bad. But if we have a set filter, we just need to create only one filter with 1000 values. And the containing operation could be implemented as O(1) or O(log(n)). This `SetFilter` is general and useful in my opinion, so would the community consider to implement a `SetFilter`? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-25443) Improve the experience of using the Master webpage by change the loading process of snapshot list to asynchronous
[ https://issues.apache.org/jira/browse/HBASE-25443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yulin Niu resolved HBASE-25443. --- Resolution: Fixed > Improve the experience of using the Master webpage by change the loading > process of snapshot list to asynchronous > - > > Key: HBASE-25443 > URL: https://issues.apache.org/jira/browse/HBASE-25443 > Project: HBase > Issue Type: Improvement > Components: master, UI >Affects Versions: 3.0.0-alpha-1 >Reporter: Zhuoyue Huang >Assignee: Zhuoyue Huang >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.5.0 > > Attachments: image-2020-12-24-13-17-17-213.png > > > Background: When there are many snapshots, loading the master webpage is very > slow, which affects the experience. (Our cluster has more than 3000 > snapshots, and it takes about 10 seconds to load the master webpage each time) > > 1. The snapshot list is not in the master memory, hdfs need to be scanned > when loading > 2. Changing the process of loading snapshots to asynchronous can improve the > experience > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25443) Improve the experience of using the Master webpage by change the loading process of snapshot list to asynchronous
[ https://issues.apache.org/jira/browse/HBASE-25443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yulin Niu updated HBASE-25443: -- Fix Version/s: 2.5.0 > Improve the experience of using the Master webpage by change the loading > process of snapshot list to asynchronous > - > > Key: HBASE-25443 > URL: https://issues.apache.org/jira/browse/HBASE-25443 > Project: HBase > Issue Type: Improvement > Components: master, UI >Affects Versions: 3.0.0-alpha-1 >Reporter: Zhuoyue Huang >Assignee: Zhuoyue Huang >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.5.0 > > Attachments: image-2020-12-24-13-17-17-213.png > > > Background: When there are many snapshots, loading the master webpage is very > slow, which affects the experience. (Our cluster has more than 3000 > snapshots, and it takes about 10 seconds to load the master webpage each time) > > 1. The snapshot list is not in the master memory, hdfs need to be scanned > when loading > 2. Changing the process of loading snapshots to asynchronous can improve the > experience > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25443) Improve the experience of using the Master webpage by change the loading process of snapshot list to asynchronous
[ https://issues.apache.org/jira/browse/HBASE-25443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254707#comment-17254707 ] Yulin Niu commented on HBASE-25443: --- push to master and branch-2, thanks [~GeorryHuang]'s contributing > Improve the experience of using the Master webpage by change the loading > process of snapshot list to asynchronous > - > > Key: HBASE-25443 > URL: https://issues.apache.org/jira/browse/HBASE-25443 > Project: HBase > Issue Type: Improvement > Components: master, UI >Affects Versions: 3.0.0-alpha-1 >Reporter: Zhuoyue Huang >Assignee: Zhuoyue Huang >Priority: Minor > Fix For: 3.0.0-alpha-1 > > Attachments: image-2020-12-24-13-17-17-213.png > > > Background: When there are many snapshots, loading the master webpage is very > slow, which affects the experience. (Our cluster has more than 3000 > snapshots, and it takes about 10 seconds to load the master webpage each time) > > 1. The snapshot list is not in the master memory, hdfs need to be scanned > when loading > 2. Changing the process of loading snapshots to asynchronous can improve the > experience > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] nyl3532016 merged pull request #2811: HBASE-25443 Improve the experience of using the Master webpage by cha…
nyl3532016 merged pull request #2811: URL: https://github.com/apache/hbase/pull/2811 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client
Apache-HBase commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-751145766 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-22120 Compile Tests _ | | +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 25s | HBASE-22120 passed | | +1 :green_heart: | checkstyle | 1m 56s | HBASE-22120 passed | | +1 :green_heart: | spotbugs | 12m 27s | HBASE-22120 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 27s | the patch passed | | +1 :green_heart: | checkstyle | 1m 57s | root: The patch generated 0 new + 20 unchanged - 3 fixed = 20 total (was 23) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 16m 53s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | -1 :x: | spotbugs | 1m 11s | hbase-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | -1 :x: | spotbugs | 9m 3s | root generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 52s | The patch does not generate ASF License warnings. | | | | 63m 54s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-client | | | There is an apparent infinite recursive loop in org.apache.hadoop.hbase.client.RawAsyncTableImpl.getSpanName(String) At RawAsyncTableImpl.java:recursive loop in org.apache.hadoop.hbase.client.RawAsyncTableImpl.getSpanName(String) At RawAsyncTableImpl.java:[line 236] | | FindBugs | module:root | | | There is an apparent infinite recursive loop in org.apache.hadoop.hbase.client.RawAsyncTableImpl.getSpanName(String) At RawAsyncTableImpl.java:recursive loop in org.apache.hadoop.hbase.client.RawAsyncTableImpl.getSpanName(String) At RawAsyncTableImpl.java:[line 236] | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2813 | | Optional Tests | dupname asflicense hadoopcheck xml spotbugs hbaseanti checkstyle | | uname | Linux 4820199debe8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-22120 / 91f8aafb95 | | spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/2/artifact/yetus-general-check/output/new-spotbugs-hbase-client.html | | spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/2/artifact/yetus-general-check/output/new-spotbugs-root.html | | Max. process+thread count | 137 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client
Apache-HBase commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-751143314 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 19s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-22120 Compile Tests _ | | +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 2s | HBASE-22120 passed | | +1 :green_heart: | compile | 2m 50s | HBASE-22120 passed | | +1 :green_heart: | shadedjars | 7m 5s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 10s | HBASE-22120 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 2s | the patch passed | | +1 :green_heart: | compile | 2m 49s | the patch passed | | +1 :green_heart: | javac | 2m 49s | the patch passed | | +1 :green_heart: | shadedjars | 6m 54s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 10s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 5m 2s | root in the patch failed. | | | | 45m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2813 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 31bc5961a918 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-22120 / 91f8aafb95 | | Default Java | AdoptOpenJDK-11.0.6+10 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/2/testReport/ | | Max. process+thread count | 540 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client
Apache-HBase commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-751142929 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-22120 Compile Tests _ | | +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 45s | HBASE-22120 passed | | +1 :green_heart: | compile | 2m 25s | HBASE-22120 passed | | +1 :green_heart: | shadedjars | 7m 5s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 23s | HBASE-22120 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 26s | the patch passed | | +1 :green_heart: | compile | 2m 21s | the patch passed | | +1 :green_heart: | javac | 2m 21s | the patch passed | | +1 :green_heart: | shadedjars | 6m 59s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 23s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 6m 5s | root in the patch failed. | | | | 42m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2813 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 35544a30a6df 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-22120 / 91f8aafb95 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/2/testReport/ | | Max. process+thread count | 844 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] lujiefsi edited a comment on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta
lujiefsi edited a comment on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-751138386 It seems that everything is ok, The only question is can we add the fix for [HBASE-25441](https://issues.apache.org/jira/browse/HBASE-25441) in this pull reqeust? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] lujiefsi commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta
lujiefsi commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-751138386 It seems that every is ok, The only question is can we add the fix for [HBASE-25441](https://issues.apache.org/jira/browse/HBASE-25441) in this pull reqeust? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client
Apache-HBase commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-751072613 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-22120 Compile Tests _ | | +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 47s | HBASE-22120 passed | | +1 :green_heart: | compile | 2m 22s | HBASE-22120 passed | | +1 :green_heart: | shadedjars | 7m 4s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 24s | HBASE-22120 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 25s | the patch passed | | +1 :green_heart: | compile | 2m 27s | the patch passed | | +1 :green_heart: | javac | 2m 27s | the patch passed | | +1 :green_heart: | shadedjars | 7m 0s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 27s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 269m 2s | root in the patch failed. | | | | 306m 12s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2813 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4b1b900cd8ee 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-22120 / 91f8aafb95 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/1/testReport/ | | Max. process+thread count | 3818 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client
Apache-HBase commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-750950484 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-22120 Compile Tests _ | | +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 16s | HBASE-22120 passed | | +1 :green_heart: | compile | 2m 49s | HBASE-22120 passed | | +1 :green_heart: | shadedjars | 7m 1s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 9s | HBASE-22120 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 59s | the patch passed | | +1 :green_heart: | compile | 2m 51s | the patch passed | | +1 :green_heart: | javac | 2m 52s | the patch passed | | +1 :green_heart: | shadedjars | 7m 3s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 10s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 143m 49s | root in the patch failed. | | | | 184m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2813 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 8a32407c4c22 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-22120 / 91f8aafb95 | | Default Java | AdoptOpenJDK-11.0.6+10 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/1/testReport/ | | Max. process+thread count | 4691 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client
Apache-HBase commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-750932418 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-22120 Compile Tests _ | | +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 45s | HBASE-22120 passed | | +1 :green_heart: | checkstyle | 1m 58s | HBASE-22120 passed | | +1 :green_heart: | spotbugs | 12m 29s | HBASE-22120 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 27s | the patch passed | | -0 :warning: | checkstyle | 1m 57s | root: The patch generated 5 new + 19 unchanged - 3 fixed = 24 total (was 22) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 17m 9s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | -1 :x: | spotbugs | 0m 55s | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | -1 :x: | spotbugs | 9m 12s | root generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 54s | The patch does not generate ASF License warnings. | | | | 64m 52s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | The method name org.apache.hadoop.hbase.trace.TraceUtil.CreateRemoteSpan(String, Context) doesn't start with a lower case letter At TraceUtil.java:doesn't start with a lower case letter At TraceUtil.java:[line 50] | | FindBugs | module:root | | | The method name org.apache.hadoop.hbase.trace.TraceUtil.CreateRemoteSpan(String, Context) doesn't start with a lower case letter At TraceUtil.java:doesn't start with a lower case letter At TraceUtil.java:[line 50] | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2813 | | Optional Tests | dupname asflicense hadoopcheck xml spotbugs hbaseanti checkstyle | | uname | Linux 9766d010e367 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-22120 / 91f8aafb95 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt | | spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/1/artifact/yetus-general-check/output/new-spotbugs-hbase-common.html | | spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/1/artifact/yetus-general-check/output/new-spotbugs-root.html | | Max. process+thread count | 137 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2813/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 opened a new pull request #2813: HBASE-23898 Add trace support for simple apis in async client
Apache9 opened a new pull request #2813: URL: https://github.com/apache/hbase/pull/2813 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta
Apache-HBase commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750906261 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 28s | master passed | | +1 :green_heart: | compile | 0m 57s | master passed | | +1 :green_heart: | shadedjars | 6m 35s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 29s | the patch passed | | +1 :green_heart: | compile | 0m 55s | the patch passed | | +1 :green_heart: | javac | 0m 55s | the patch passed | | +1 :green_heart: | shadedjars | 6m 33s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 147m 17s | hbase-server in the patch passed. | | | | 173m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2809/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2809 | | JIRA Issue | HBASE-25432 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 022bb7c0b8c4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / dcb38f47db | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2809/4/testReport/ | | Max. process+thread count | 4218 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2809/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta
Apache-HBase commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750903308 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 9s | master passed | | +1 :green_heart: | compile | 1m 4s | master passed | | +1 :green_heart: | shadedjars | 6m 52s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 44s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 11s | the patch passed | | +1 :green_heart: | compile | 1m 8s | the patch passed | | +1 :green_heart: | javac | 1m 8s | the patch passed | | +1 :green_heart: | shadedjars | 6m 47s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 132m 11s | hbase-server in the patch passed. | | | | 160m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2809/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2809 | | JIRA Issue | HBASE-25432 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2cb90dc48f0b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / dcb38f47db | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2809/4/testReport/ | | Max. process+thread count | 3641 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2809/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta
Apache-HBase commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750875108 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 12s | master passed | | +1 :green_heart: | checkstyle | 1m 13s | master passed | | +1 :green_heart: | spotbugs | 2m 11s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 45s | the patch passed | | +1 :green_heart: | checkstyle | 1m 10s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 19m 6s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 2m 20s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 43m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2809/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2809 | | JIRA Issue | HBASE-25432 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux fd19efdb05d8 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / dcb38f47db | | Max. process+thread count | 84 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2809/4/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] lujiefsi commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta
lujiefsi commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750866026 rebase the commit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] lujiefsi commented on pull request #2810: HBASE-25441:add security check for stopServer
lujiefsi commented on pull request #2810: URL: https://github.com/apache/hbase/pull/2810#issuecomment-750854934 It seems that error is not related to this patch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta
Apache-HBase commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750850478 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 30s | master passed | | +1 :green_heart: | compile | 1m 22s | master passed | | +1 :green_heart: | shadedjars | 9m 3s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 48s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 2s | the patch passed | | +1 :green_heart: | compile | 1m 27s | the patch passed | | +1 :green_heart: | javac | 1m 27s | the patch passed | | +1 :green_heart: | shadedjars | 7m 39s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 44s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 132m 57s | hbase-server in the patch failed. | | | | 167m 25s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2809/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2809 | | JIRA Issue | HBASE-25432 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 665237e0f6e3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / dcb38f47db | | Default Java | AdoptOpenJDK-11.0.6+10 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2809/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2809/3/testReport/ | | Max. process+thread count | 4045 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2809/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta
Apache-HBase commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750849732 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 51s | master passed | | +1 :green_heart: | compile | 0m 58s | master passed | | +1 :green_heart: | shadedjars | 6m 39s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 31s | the patch passed | | +1 :green_heart: | compile | 0m 56s | the patch passed | | +1 :green_heart: | javac | 0m 56s | the patch passed | | +1 :green_heart: | shadedjars | 6m 35s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 138m 47s | hbase-server in the patch passed. | | | | 164m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2809/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2809 | | JIRA Issue | HBASE-25432 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b2fc4813d340 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / dcb38f47db | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2809/3/testReport/ | | Max. process+thread count | 4886 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2809/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-25424) Find a way to config OpenTelemetry tracing without directly depending on opentelemetry-sdk
[ https://issues.apache.org/jira/browse/HBASE-25424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25424. --- Fix Version/s: HBASE-22120 Hadoop Flags: Reviewed Resolution: Fixed Merged to branch HBASE-22120. Thanks [~zghao] for reviewing. > Find a way to config OpenTelemetry tracing without directly depending on > opentelemetry-sdk > -- > > Key: HBASE-25424 > URL: https://issues.apache.org/jira/browse/HBASE-25424 > Project: HBase > Issue Type: Sub-task > Components: dependencies, tracing >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: HBASE-22120 > > Attachments: jaeger.png > > > According to the document of OpenTelemetry, for all the modules which could > be depended by downstream users, we should only depend on opentelemetry-api. > But the open telemetry propagator must be initialized programmatically, so we > need to have a module to implement the code and introduce dependency on > opentelemetry-sdk, and we need to call it before doing anything when starting > master, regionserver, and so on. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 merged pull request #2808: HBASE-25424 Find a way to config OpenTelemetry tracing without direct…
Apache9 merged pull request #2808: URL: https://github.com/apache/hbase/pull/2808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta
Apache-HBase commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750815577 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 7s | master passed | | +1 :green_heart: | checkstyle | 1m 14s | master passed | | +1 :green_heart: | spotbugs | 2m 18s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 48s | the patch passed | | +1 :green_heart: | checkstyle | 1m 10s | the patch passed | | +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 19m 6s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 2m 21s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 43m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2809/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2809 | | JIRA Issue | HBASE-25432 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux e3f55488a35e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / dcb38f47db | | Max. process+thread count | 84 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2809/3/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25443) Improve the experience of using the Master webpage by change the loading process of snapshot list to asynchronous
[ https://issues.apache.org/jira/browse/HBASE-25443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254473#comment-17254473 ] Anoop Sam John commented on HBASE-25443: +1.. I was about to raise this improvement. You will work on a PR? Thanks > Improve the experience of using the Master webpage by change the loading > process of snapshot list to asynchronous > - > > Key: HBASE-25443 > URL: https://issues.apache.org/jira/browse/HBASE-25443 > Project: HBase > Issue Type: Improvement > Components: master, UI >Affects Versions: 3.0.0-alpha-1 >Reporter: Zhuoyue Huang >Assignee: Zhuoyue Huang >Priority: Minor > Fix For: 3.0.0-alpha-1 > > Attachments: image-2020-12-24-13-17-17-213.png > > > Background: When there are many snapshots, loading the master webpage is very > slow, which affects the experience. (Our cluster has more than 3000 > snapshots, and it takes about 10 seconds to load the master webpage each time) > > 1. The snapshot list is not in the master memory, hdfs need to be scanned > when loading > 2. Changing the process of loading snapshots to asynchronous can improve the > experience > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2808: HBASE-25424 Find a way to config OpenTelemetry tracing without direct…
Apache-HBase commented on pull request #2808: URL: https://github.com/apache/hbase/pull/2808#issuecomment-750807626 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 13s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-22120 Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 25s | HBASE-22120 passed | | +1 :green_heart: | compile | 2m 26s | HBASE-22120 passed | | +1 :green_heart: | shadedjars | 6m 58s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 21s | HBASE-22120 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 26s | the patch passed | | +1 :green_heart: | compile | 2m 19s | the patch passed | | +1 :green_heart: | javac | 2m 19s | the patch passed | | +1 :green_heart: | shadedjars | 6m 50s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 19s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 317m 32s | root in the patch failed. | | | | 351m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2808/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2808 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 5f20a1483d07 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-22120 / bd745da477 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2808/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2808/4/testReport/ | | Max. process+thread count | 4278 (vs. ulimit of 3) | | modules | C: hbase-assembly . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2808/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] nyl3532016 commented on pull request #2741: HBASE-25364 Redo the getMidPoint() in HFileWriterImpl to get rid of t…
nyl3532016 commented on pull request #2741: URL: https://github.com/apache/hbase/pull/2741#issuecomment-750804058 > @nyl3532016 You good w/ this change? If so, would like to add you as a sign-off. Thanks. @saintstack, I am good with the patch after @GeorryHuang amend a bit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta
Apache-HBase commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750802183 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 51s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 42s | master passed | | +1 :green_heart: | compile | 1m 35s | master passed | | +1 :green_heart: | shadedjars | 9m 21s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 50s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 6s | the patch passed | | +1 :green_heart: | compile | 1m 31s | the patch passed | | +1 :green_heart: | javac | 1m 31s | the patch passed | | +1 :green_heart: | shadedjars | 7m 28s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 142m 5s | hbase-server in the patch passed. | | | | 178m 5s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2809/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2809 | | JIRA Issue | HBASE-25432 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b732c40b3386 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / dcb38f47db | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2809/2/testReport/ | | Max. process+thread count | 3678 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2809/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta
Apache-HBase commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750798217 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 48s | master passed | | +1 :green_heart: | compile | 0m 57s | master passed | | +1 :green_heart: | shadedjars | 6m 32s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 30s | the patch passed | | +1 :green_heart: | compile | 0m 56s | the patch passed | | +1 :green_heart: | javac | 0m 56s | the patch passed | | +1 :green_heart: | shadedjars | 6m 36s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 34s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 138m 7s | hbase-server in the patch failed. | | | | 164m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2809/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2809 | | JIRA Issue | HBASE-25432 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 03227aeed62c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / dcb38f47db | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2809/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2809/2/testReport/ | | Max. process+thread count | 5002 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2809/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
