[GitHub] [hbase] Apache-HBase commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-26 Thread GitBox
Apache-HBase commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-751437198 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2815: HBASE-24751 Display Task completion time and/or processing duration o…

2020-12-26 Thread GitBox
Apache-HBase commented on pull request #2815: URL: https://github.com/apache/hbase/pull/2815#issuecomment-751430278 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] GeorryHuang opened a new pull request #2815: HBASE-24751 Display Task completion time and/or processing duration o…

2020-12-26 Thread GitBox
GeorryHuang opened a new pull request #2815: URL: https://github.com/apache/hbase/pull/2815 …n Web UI ![image](https://user-images.githubusercontent.com/6973910/103164796-946ec800-484a-11eb-9d48-881709c29436.png)

[jira] [Commented] (HBASE-24751) Display Task completion time and/or processing duration on Web UI

2020-12-26 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255165#comment-17255165 ] Zhuoyue Huang commented on HBASE-24751: --- If the task is completed, display the completion time,

[jira] [Updated] (HBASE-24751) Display Task completion time and/or processing duration on Web UI

2020-12-26 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoyue Huang updated HBASE-24751: -- Attachment: image-2020-12-27-13-40-33-490.png > Display Task completion time and/or

[jira] [Updated] (HBASE-24751) Display Task completion time and/or processing duration on Web UI

2020-12-26 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoyue Huang updated HBASE-24751: -- Attachment: image-2020-12-27-13-38-45-744.png > Display Task completion time and/or

[jira] [Assigned] (HBASE-24751) Display Task completion time and/or processing duration on Web UI

2020-12-26 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoyue Huang reassigned HBASE-24751: - Assignee: Zhuoyue Huang > Display Task completion time and/or processing duration on

[GitHub] [hbase] Apache-HBase commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client

2020-12-26 Thread GitBox
Apache-HBase commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-751406025 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client

2020-12-26 Thread GitBox
Apache-HBase commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-751394680 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client

2020-12-26 Thread GitBox
Apache-HBase commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-751372198 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client

2020-12-26 Thread GitBox
Apache9 commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-751368554 Use span attribute to store the table name, region name, rpc method and so on instead of including them in the span name.

[GitHub] [hbase] Apache-HBase commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-26 Thread GitBox
Apache-HBase commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-751363332 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-26 Thread GitBox
Apache-HBase commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-751362399 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] lujiefsi edited a comment on pull request #2810: HBASE-25441:add security check for RSRpcSever

2020-12-26 Thread GitBox
lujiefsi edited a comment on pull request #2810: URL: https://github.com/apache/hbase/pull/2810#issuecomment-751358242 I have checked belong APIs that need add security check, these APIs will change RS's state without authorization. Please check | API | Severity | symptom | |

[GitHub] [hbase] lujiefsi edited a comment on pull request #2810: HBASE-25441:add security check for RSRpcSever

2020-12-26 Thread GitBox
lujiefsi edited a comment on pull request #2810: URL: https://github.com/apache/hbase/pull/2810#issuecomment-751358242 I have checked belong APIs that need add security check, these APIs will change RS's state without authorization. Please check clearSlowLogsResponses

[GitHub] [hbase] lujiefsi commented on pull request #2810: HBASE-25441:add security check for stopServer

2020-12-26 Thread GitBox
lujiefsi commented on pull request #2810: URL: https://github.com/apache/hbase/pull/2810#issuecomment-751358242 I have checked belong API that need add security check, please check clearSlowLogsResponses clearRegionBlockCache updateConfiguration

[GitHub] [hbase] Apache-HBase commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client

2020-12-26 Thread GitBox
Apache-HBase commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-751357209 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25441) add security check for some APIs in RSRpcServices

2020-12-26 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25441: -- Description: clearSlowLogsResponses clearRegionBlockCache updateConfiguration

[GitHub] [hbase] Apache-HBase commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-26 Thread GitBox
Apache-HBase commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-751352374 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client

2020-12-26 Thread GitBox
Apache-HBase commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-751352312 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-25441) add security check for some APIs in RSRpcServices

2020-12-26 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25441: -- Description: clearSlowLogsResponses clearRegionBlockCache updateConfiguration was:

[jira] [Updated] (HBASE-25441) add security check for some APIs in RSRpcServices

2020-12-26 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25441: -- Description: clearSlowLogsResponses clearRegionBlockCache was: getLogEntries clearSlowLogsResponses

[GitHub] [hbase] Apache-HBase commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-26 Thread GitBox
Apache-HBase commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-751348855 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-26 Thread GitBox
Apache-HBase commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-751347915 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25441) add security check for some APIs in RSRpcServices

2020-12-26 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25441: -- Description: getLogEntries clearSlowLogsResponses stopServer   Actually, "stopServer" has "preStop" check

[jira] [Updated] (HBASE-25441) add security check for some APIs in RSRpcServices

2020-12-26 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25441: -- Description: getLogEntries clearSlowLogsResponses stopServer   Actually, "stopServer" has "preStop" check

[jira] [Updated] (HBASE-25441) add security check for some APIs in RSRpcServices

2020-12-26 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25441: -- Description: getLogEntries clearSlowLogsResponses stopServer   Actually, "stopServer" has "preStop" check

[jira] [Updated] (HBASE-25441) add security check for some APIs in RSRpcServices

2020-12-26 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25441: -- Description: getLogEntries clearSlowLogsResponses stopServer   Actually, "stopServer" has "preStop" check

[GitHub] [hbase] lujiefsi commented on pull request #2810: HBASE-25441:add security check for stopServer

2020-12-26 Thread GitBox
lujiefsi commented on pull request #2810: URL: https://github.com/apache/hbase/pull/2810#issuecomment-751344081 > > @virajjasani @Apache9 @joshelser > > I found that there are also some other API has annotation "ADMIN_QOS" on RSRPCServices ,like executeProcedures > >

[jira] [Updated] (HBASE-25441) add security check for some APIs in RSRpcServices

2020-12-26 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25441: -- Description: getLogEntries clearSlowLogsResponses was: stopServer getLogEntries clearSlowLogsResponses

[GitHub] [hbase] virajjasani edited a comment on pull request #2810: HBASE-25441:add security check for stopServer

2020-12-26 Thread GitBox
virajjasani edited a comment on pull request #2810: URL: https://github.com/apache/hbase/pull/2810#issuecomment-751321209 > @virajjasani @Apache9 @joshelser > I found that there are also some other API has annotation "ADMIN_QOS" on RSRPCServices ,like executeProcedures >

[GitHub] [hbase] Apache-HBase commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client

2020-12-26 Thread GitBox
Apache-HBase commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-751340062 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-26 Thread GitBox
Apache-HBase commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-751339719 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Updated] (HBASE-25441) add security check for some APIs in RSRpcServices

2020-12-26 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25441: -- Description: stopServer getLogEntries clearSlowLogsResponses > add security check for some APIs in

[jira] [Updated] (HBASE-25441) add security check for some APIs in RSRpcServices

2020-12-26 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25441: -- Summary: add security check for some APIs in RSRpcServices (was: Unauthorized client can shutdown the

[jira] [Updated] (HBASE-25448) c++库编译不通过

2020-12-26 Thread lichaozhong (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lichaozhong updated HBASE-25448: Environment: thrift编译环境：msys2，按照thrift中READE-MSYS2.md中的说明，使用pacman安装的依赖环境， $ pacman --needed -S

[jira] [Created] (HBASE-25448) c++库编译不通过

2020-12-26 Thread lichaozhong (Jira)
lichaozhong created HBASE-25448: --- Summary: c++库编译不通过 Key: HBASE-25448 URL: https://issues.apache.org/jira/browse/HBASE-25448 Project: HBase Issue Type: Bug Components: Thrift