Apache-HBase commented on pull request #2836:
URL: https://github.com/apache/hbase/pull/2836#issuecomment-752880991
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
cuibo01 commented on pull request #2824:
URL: https://github.com/apache/hbase/pull/2824#issuecomment-752878534
According to the JVM specifications, the subsequent actions of OOM are
"undefined behaviors", that is, after OOM occurs, it is uncertain what must be
or will not be done.
lujiefsi commented on pull request #2834:
URL: https://github.com/apache/hbase/pull/2834#issuecomment-752876807
> ```
> [ERROR]
Apache-HBase commented on pull request #2833:
URL: https://github.com/apache/hbase/pull/2833#issuecomment-752872413
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2835:
URL: https://github.com/apache/hbase/pull/2835#issuecomment-752868239
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
virajjasani commented on pull request #2834:
URL: https://github.com/apache/hbase/pull/2834#issuecomment-752868087
```
[ERROR]
Apache-HBase commented on pull request #2836:
URL: https://github.com/apache/hbase/pull/2836#issuecomment-752868049
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2836:
URL: https://github.com/apache/hbase/pull/2836#issuecomment-752866837
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2834:
URL: https://github.com/apache/hbase/pull/2834#issuecomment-752866471
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2835:
URL: https://github.com/apache/hbase/pull/2835#issuecomment-752866283
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2835:
URL: https://github.com/apache/hbase/pull/2835#issuecomment-752866192
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m
Apache-HBase commented on pull request #2836:
URL: https://github.com/apache/hbase/pull/2836#issuecomment-752866160
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2834:
URL: https://github.com/apache/hbase/pull/2834#issuecomment-752865981
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2834:
URL: https://github.com/apache/hbase/pull/2834#issuecomment-752864964
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
lujiefsi commented on pull request #2833:
URL: https://github.com/apache/hbase/pull/2833#issuecomment-752862335
> +1, keep backports ready? Thanks
done.
This is an automated message from the Apache Git Service.
To
lujiefsi opened a new pull request #2836:
URL: https://github.com/apache/hbase/pull/2836
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
lujiefsi opened a new pull request #2835:
URL: https://github.com/apache/hbase/pull/2835
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
lujiefsi opened a new pull request #2834:
URL: https://github.com/apache/hbase/pull/2834
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
leyangyueshan commented on a change in pull request #2823:
URL: https://github.com/apache/hbase/pull/2823#discussion_r550407297
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java
##
@@ -53,6 +54,8 @@
private Timer
Apache-HBase commented on pull request #2821:
URL: https://github.com/apache/hbase/pull/2821#issuecomment-752860261
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
virajjasani commented on pull request #2822:
URL: https://github.com/apache/hbase/pull/2822#issuecomment-752850561
My bad, I missed it. Build results look good now.
This is an automated message from the Apache Git Service.
Apache-HBase commented on pull request #2833:
URL: https://github.com/apache/hbase/pull/2833#issuecomment-752846206
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
[
https://issues.apache.org/jira/browse/HBASE-25422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie resolved HBASE-25422.
---
Resolution: Duplicate
> update_all_config should not be executed by non-admin user!!!
>
lujiefsi opened a new pull request #2833:
URL: https://github.com/apache/hbase/pull/2833
@virajjasani it seems that we miss setRegionStateInMeta, fix it and will
backport after review!
This is an automated message from the
Apache-HBase commented on pull request #2822:
URL: https://github.com/apache/hbase/pull/2822#issuecomment-752836988
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2822:
URL: https://github.com/apache/hbase/pull/2822#issuecomment-752836035
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
cuibo01 edited a comment on pull request #2824:
URL: https://github.com/apache/hbase/pull/2824#issuecomment-752833905
when throw "unable to create new native thread", the Thread does not run,
jvm does not call uncaughtExceptionHandler
cuibo01 commented on pull request #2824:
URL: https://github.com/apache/hbase/pull/2824#issuecomment-752833905
when throw "unable to create new native thread", the Thread does not run,
uncaughtExceptionHandler is invalid.
[
https://issues.apache.org/jira/browse/HBASE-25456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-25456:
--
Description: [Viraj
Jasani|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=vjasani] it
seems
[
https://issues.apache.org/jira/browse/HBASE-25456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-25456:
--
Description: [Viraj
Jasani|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=vjasani] it
seems
[
https://issues.apache.org/jira/browse/HBASE-25456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-25456:
--
Description: @
> setRegionStateInMeta need security check
>
>
>
lujie created HBASE-25456:
-
Summary: setRegionStateInMeta need security check
Key: HBASE-25456
URL: https://issues.apache.org/jira/browse/HBASE-25456
Project: HBase
Issue Type: Bug
Apache9 commented on pull request #2824:
URL: https://github.com/apache/hbase/pull/2824#issuecomment-752825371
> if we don't have a better way to solve the issue or circumvent the issue,
we can fix timeoutThread first, and at least the Proc is correct.
OK. Then since TimeoutExecutor
Apache-HBase commented on pull request #2821:
URL: https://github.com/apache/hbase/pull/2821#issuecomment-752824012
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
[
https://issues.apache.org/jira/browse/HBASE-25452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256789#comment-17256789
]
Hudson commented on HBASE-25452:
Results for branch branch-2.4
[build #18 on
cuibo01 commented on pull request #2824:
URL: https://github.com/apache/hbase/pull/2824#issuecomment-752819455
if we don't have a better way to solve the issue or circumvent the issue, we
can fix timeoutThread first, and at least the Proc is correct.
cuibo01 removed a comment on pull request #2824:
URL: https://github.com/apache/hbase/pull/2824#issuecomment-752817713
According to the communication with the maintenance, this problem that jvm
does not exit exists in many OS components. No better solution is available.
cuibo01 commented on pull request #2824:
URL: https://github.com/apache/hbase/pull/2824#issuecomment-752817713
According to the communication with the maintenance, this problem that jvm
does not exit exists in many OS components. No better solution is available.
cuibo01 edited a comment on pull request #2824:
URL: https://github.com/apache/hbase/pull/2824#issuecomment-752816204
analyze and verify the java native code, some OMME can not cause the JVM to
exit, like "java.lang.OutOfMemoryError: Direct buffer memory",
"java.lang.OutOfMemoryError:
cuibo01 edited a comment on pull request #2824:
URL: https://github.com/apache/hbase/pull/2824#issuecomment-752816204
analyze and verify the java native code, some OMME can not be the JVM exit,
like "java.lang.OutOfMemoryError: Direct buffer memory",
"java.lang.OutOfMemoryError: unable to
Apache-HBase commented on pull request #2822:
URL: https://github.com/apache/hbase/pull/2822#issuecomment-752816365
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
cuibo01 commented on pull request #2824:
URL: https://github.com/apache/hbase/pull/2824#issuecomment-752816204
analyze and verify the java native code, some OMME do not cause the JVM to
exit, like "java.lang.OutOfMemoryError: Direct buffer memory",
"java.lang.OutOfMemoryError: unable to
Apache-HBase commented on pull request #2821:
URL: https://github.com/apache/hbase/pull/2821#issuecomment-752816174
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
[
https://issues.apache.org/jira/browse/HBASE-25449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256774#comment-17256774
]
Michael Stack commented on HBASE-25449:
---
bq. this can easily be ignored
Do you mean, users
Apache9 commented on a change in pull request #2825:
URL: https://github.com/apache/hbase/pull/2825#discussion_r550372045
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##
@@ -832,7 +832,7 @@ private void
saintstack commented on pull request #2821:
URL: https://github.com/apache/hbase/pull/2821#issuecomment-752810577
Thanks for the feedback @anoopsjohn and @shenshengli . Let me rerun unit
tests to make sure the PR is not responsible for test failures.
saintstack commented on pull request #2822:
URL: https://github.com/apache/hbase/pull/2822#issuecomment-752809897
@virajjasani there is an explanation in the above... check it out.
Let me rerun the tests. The failures look like flakies. Rerunning to make
sure.
saintstack commented on pull request #2824:
URL: https://github.com/apache/hbase/pull/2824#issuecomment-752809514
Agree. If OOME, process should go down... die. We can't keep going. It is a
fatal condition.
This is an
saintstack commented on a change in pull request #2825:
URL: https://github.com/apache/hbase/pull/2825#discussion_r550368884
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##
@@ -832,7 +832,7 @@ private void
saintstack commented on a change in pull request #2828:
URL: https://github.com/apache/hbase/pull/2828#discussion_r550367007
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java
##
@@ -18,6 +18,7 @@
package
[
https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani resolved HBASE-25441.
--
Hadoop Flags: Reviewed
Resolution: Fixed
Thanks for the contribution [~xiaoheipangzi].
virajjasani merged pull request #2832:
URL: https://github.com/apache/hbase/pull/2832
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
virajjasani merged pull request #2829:
URL: https://github.com/apache/hbase/pull/2829
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
virajjasani merged pull request #2830:
URL: https://github.com/apache/hbase/pull/2830
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
virajjasani merged pull request #2831:
URL: https://github.com/apache/hbase/pull/2831
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
virajjasani merged pull request #2810:
URL: https://github.com/apache/hbase/pull/2810
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/HBASE-25452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256648#comment-17256648
]
Hudson commented on HBASE-25452:
Results for branch branch-2
[build #141 on
[
https://issues.apache.org/jira/browse/HBASE-25379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256647#comment-17256647
]
Hudson commented on HBASE-25379:
Results for branch branch-2
[build #141 on
Apache-HBase commented on pull request #2831:
URL: https://github.com/apache/hbase/pull/2831#issuecomment-752714955
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2830:
URL: https://github.com/apache/hbase/pull/2830#issuecomment-752713559
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2832:
URL: https://github.com/apache/hbase/pull/2832#issuecomment-752712202
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 7m
Apache-HBase commented on pull request #2830:
URL: https://github.com/apache/hbase/pull/2830#issuecomment-752711824
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2829:
URL: https://github.com/apache/hbase/pull/2829#issuecomment-752709582
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2831:
URL: https://github.com/apache/hbase/pull/2831#issuecomment-752709022
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2829:
URL: https://github.com/apache/hbase/pull/2829#issuecomment-752704863
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
[
https://issues.apache.org/jira/browse/HBASE-25452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256608#comment-17256608
]
Hudson commented on HBASE-25452:
Results for branch branch-2.3
[build #134 on
Apache-HBase commented on pull request #2830:
URL: https://github.com/apache/hbase/pull/2830#issuecomment-752672338
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m
Apache-HBase commented on pull request #2831:
URL: https://github.com/apache/hbase/pull/2831#issuecomment-752669473
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2829:
URL: https://github.com/apache/hbase/pull/2829#issuecomment-752667099
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2828:
URL: https://github.com/apache/hbase/pull/2828#issuecomment-752664746
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
lujiefsi opened a new pull request #2832:
URL: https://github.com/apache/hbase/pull/2832
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Apache-HBase commented on pull request #2828:
URL: https://github.com/apache/hbase/pull/2828#issuecomment-752661157
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2828:
URL: https://github.com/apache/hbase/pull/2828#issuecomment-752660646
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
lujiefsi opened a new pull request #2831:
URL: https://github.com/apache/hbase/pull/2831
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
lujiefsi opened a new pull request #2830:
URL: https://github.com/apache/hbase/pull/2830
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
lujiefsi opened a new pull request #2829:
URL: https://github.com/apache/hbase/pull/2829
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Apache9 opened a new pull request #2828:
URL: https://github.com/apache/hbase/pull/2828
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
lujiefsi closed pull request #2827:
URL: https://github.com/apache/hbase/pull/2827
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Apache-HBase commented on pull request #2827:
URL: https://github.com/apache/hbase/pull/2827#issuecomment-752649302
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
lujiefsi opened a new pull request #2827:
URL: https://github.com/apache/hbase/pull/2827
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Apache9 commented on a change in pull request #2825:
URL: https://github.com/apache/hbase/pull/2825#discussion_r550210345
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##
@@ -832,7 +832,7 @@ private void
lujiefsi edited a comment on pull request #2810:
URL: https://github.com/apache/hbase/pull/2810#issuecomment-752637590
> backport
I will do it as soon as possiable
This is an automated message from the Apache Git
lujiefsi commented on pull request #2810:
URL: https://github.com/apache/hbase/pull/2810#issuecomment-752637590
> backport
I wll do it as soon as possiable
This is an automated message from the Apache Git Service.
To
virajjasani commented on pull request #2822:
URL: https://github.com/apache/hbase/pull/2822#issuecomment-752635389
> How does this relate to HBASE-25435 and #2823 ? Does this have to go in
before #2823? You add a bunch of hardcoding in here and then over in #2823 you
try and make it
[
https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani updated HBASE-25441:
-
Fix Version/s: 2.4.1
2.5.0
2.3.4
1.7.0
virajjasani commented on pull request #2810:
URL: https://github.com/apache/hbase/pull/2810#issuecomment-752633806
@lujiefsi Can you keep backport PRs ready? For changes this sensitive (where
you already discovered the importance of overriding `isOnline()` in HMaster),
we better get QA
[
https://issues.apache.org/jira/browse/HBASE-25454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-25454:
--
Component/s: tracing
> Add trace support for connection registry
>
[
https://issues.apache.org/jira/browse/HBASE-25452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256512#comment-17256512
]
Hudson commented on HBASE-25452:
Results for branch master
[build #168 on
[
https://issues.apache.org/jira/browse/HBASE-25379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256511#comment-17256511
]
Hudson commented on HBASE-25379:
Results for branch master
[build #168 on
lujiefsi commented on pull request #2810:
URL: https://github.com/apache/hbase/pull/2810#issuecomment-752420867
explain why UT fails and why make changes:
(1) rpcPreCheck will first check whether server is online by _'isOnline'_
method, but HMaster do not have such method, so it always
[
https://issues.apache.org/jira/browse/HBASE-25434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xijiawen updated HBASE-25434:
-
Priority: Major (was: Critical)
> SlowDelete & SlowPut metric value should use updateDelete &
Apache-HBase commented on pull request #2810:
URL: https://github.com/apache/hbase/pull/2810#issuecomment-752415776
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2810:
URL: https://github.com/apache/hbase/pull/2810#issuecomment-752415001
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Duo Zhang created HBASE-25455:
-
Summary: Add trace support for HRegion read/write operation
Key: HBASE-25455
URL: https://issues.apache.org/jira/browse/HBASE-25455
Project: HBase
Issue Type:
Duo Zhang created HBASE-25454:
-
Summary: Add trace support for connection registry
Key: HBASE-25454
URL: https://issues.apache.org/jira/browse/HBASE-25454
Project: HBase
Issue Type: Sub-task
Duo Zhang created HBASE-25453:
-
Summary: Add trace support for scan operation
Key: HBASE-25453
URL: https://issues.apache.org/jira/browse/HBASE-25453
Project: HBase
Issue Type: Sub-task
Apache-HBase commented on pull request #2810:
URL: https://github.com/apache/hbase/pull/2810#issuecomment-752378058
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2813:
URL: https://github.com/apache/hbase/pull/2813#issuecomment-752366492
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
98 matches
Mail list logo
