[jira] [Commented] (HBASE-25447) remoteProc is suspended due to OOM ERROR

2021-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258729#comment-17258729 ] Hudson commented on HBASE-25447: Results for branch master [build #175 on

[jira] [Commented] (HBASE-25457) Possible race in AsyncConnectionImpl between getChoreService and close

2021-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258728#comment-17258728 ] Hudson commented on HBASE-25457: Results for branch master [build #175 on

[jira] [Commented] (HBASE-25445) SplitWALRemoteProcedure failed to archive split WAL

2021-01-04 Thread mokai (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258691#comment-17258691 ] mokai commented on HBASE-25445: --- Got it. Thanks for the PR. > SplitWALRemoteProcedure failed to archive

[jira] [Commented] (HBASE-25445) SplitWALRemoteProcedure failed to archive split WAL

2021-01-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258685#comment-17258685 ] Viraj Jasani commented on HBASE-25445: -- [~mokai87] To avoid misunderstanding, we should assign Jira

[GitHub] [hbase] Apache-HBase commented on pull request #2844: HBASE-25445: Use WAL FS instead of master FS in SplitWALManager

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2844: URL: https://github.com/apache/hbase/pull/2844#issuecomment-754415158 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] Apache-HBase commented on pull request #2844: HBASE-25445: Use WAL FS instead of master FS in SplitWALManager

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2844: URL: https://github.com/apache/hbase/pull/2844#issuecomment-754409106 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] dasanjan1296 commented on pull request #2844: HBASE-25445: Use WAL FS instead of master FS in SplitWALManager

2021-01-04 Thread GitBox
dasanjan1296 commented on pull request #2844: URL: https://github.com/apache/hbase/pull/2844#issuecomment-754405883 @ramkrish86 I have added some testing details in the corresponding [JIRA](https://issues.apache.org/jira/projects/HBASE/issues/HBASE-25445) for reproducing the error.

[GitHub] [hbase] Apache-HBase commented on pull request #2843: HBASE-25461 when the cluster has many tables, UI can be opened quickly

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2843: URL: https://github.com/apache/hbase/pull/2843#issuecomment-754405005 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Assigned] (HBASE-25460) Expose drainingServers as cluster metric

2021-01-04 Thread Abhey Rana (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhey Rana reassigned HBASE-25460: -- Assignee: Abhey Rana > Expose drainingServers as cluster metric >

[jira] [Commented] (HBASE-25445) SplitWALRemoteProcedure failed to archive split WAL

2021-01-04 Thread Anjan Das (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258665#comment-17258665 ] Anjan Das commented on HBASE-25445: --- [~vjasani] [~mokai87] I have raised a PR with the fix. Please

[GitHub] [hbase] dasanjan1296 closed pull request #2844: HBASE-25445: Use WAL FS instead of master FS in SplitWALManager

2021-01-04 Thread GitBox
dasanjan1296 closed pull request #2844: URL: https://github.com/apache/hbase/pull/2844 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (HBASE-25460) Expose drainingServers as cluster metric

2021-01-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-25460: - Affects Version/s: 2.4.0 > Expose drainingServers as cluster metric >

[GitHub] [hbase] dasanjan1296 opened a new pull request #2844: HBASE-25445: Use WAL FS instead of master FS in SplitWALManager

2021-01-04 Thread GitBox
dasanjan1296 opened a new pull request #2844: URL: https://github.com/apache/hbase/pull/2844 - If 'hbase.wal.dir' and 'hbase.rootdir' are configured to different filesystem instances, SplitWALRemoteProcedure archived split WAL failed since SplitWALManager using wrong fs instance.

[jira] [Updated] (HBASE-25445) SplitWALRemoteProcedure failed to archive split WAL

2021-01-04 Thread Anjan Das (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anjan Das updated HBASE-25445: -- Description: If 'hbase.wal.dir' and 'hbase.rootdir' are configured to different filesystem, 

[jira] [Updated] (HBASE-25445) SplitWALRemoteProcedure failed to archive split WAL

2021-01-04 Thread Anjan Das (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anjan Das updated HBASE-25445: -- Description: If 'hbase.wal.dir' and 'hbase.rootdir' are configured to different filesystem, 

[GitHub] [hbase] cuibo01 opened a new pull request #2843: HBASE-25461 when the cluster has many tables, UI can be opened quickly

2021-01-04 Thread GitBox
cuibo01 opened a new pull request #2843: URL: https://github.com/apache/hbase/pull/2843 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (HBASE-25445) SplitWALRemoteProcedure failed to archive split WAL

2021-01-04 Thread Anjan Das (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anjan Das updated HBASE-25445: -- Description: If 'hbase.wal.dir' and 'hbase.rootdir' are configured to different filesystem, 

[jira] [Updated] (HBASE-25445) SplitWALRemoteProcedure failed to archive split WAL

2021-01-04 Thread Anjan Das (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anjan Das updated HBASE-25445: -- Attachment: ServerCrashWrongFSError.png > SplitWALRemoteProcedure failed to archive split WAL >

[jira] [Work started] (HBASE-25445) SplitWALRemoteProcedure failed to archive split WAL

2021-01-04 Thread Anjan Das (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25445 started by Anjan Das. - > SplitWALRemoteProcedure failed to archive split WAL >

[jira] [Updated] (HBASE-25461) when the cluster has many tables, UI can't be opened quickly

2021-01-04 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-25461: - Summary: when the cluster has many tables, UI can't be opened quickly (was: when the cluster

[GitHub] [hbase] leyangyueshan edited a comment on pull request #2837: HBASE-25434 SlowDelete & SlowPut metric value should use updateDelete…

2021-01-04 Thread GitBox
leyangyueshan edited a comment on pull request #2837: URL: https://github.com/apache/hbase/pull/2837#issuecomment-754344918 @saintstack @virajjasani Could you help to review this pr? This is an automated message from the

[GitHub] [hbase] leyangyueshan commented on pull request #2837: HBASE-25434 SlowDelete & SlowPut metric value should use updateDelete…

2021-01-04 Thread GitBox
leyangyueshan commented on pull request #2837: URL: https://github.com/apache/hbase/pull/2837#issuecomment-754344918 @saintstack @virajjasani please review ! thanks! This is an automated message from the Apache Git

[GitHub] [hbase] leyangyueshan commented on pull request #2842: HBASE-25459 WAL can't be cleaned with phoenix5

2021-01-04 Thread GitBox
leyangyueshan commented on pull request #2842: URL: https://github.com/apache/hbase/pull/2842#issuecomment-754343634 - [ ] This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hbase] leyangyueshan closed pull request #2842: HBASE-25459 WAL can't be cleaned with phoenix5

2021-01-04 Thread GitBox
leyangyueshan closed pull request #2842: URL: https://github.com/apache/hbase/pull/2842 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] leyangyueshan commented on pull request #2842: HBASE-25459 WAL can't be cleaned with phoenix5

2021-01-04 Thread GitBox
leyangyueshan commented on pull request #2842: URL: https://github.com/apache/hbase/pull/2842#issuecomment-754342388 > I don't think we should add logic dealing with the specifics of a 3rd party project (phoenix) into hbase wal handling. > > What about changing HBase WALFactory to

[jira] [Commented] (HBASE-25457) Possible race in AsyncConnectionImpl between getChoreService and close

2021-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258624#comment-17258624 ] Hudson commented on HBASE-25457: Results for branch branch-2.4 [build #22 on

[jira] [Commented] (HBASE-25435) Slow metric value can be configured

2021-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258623#comment-17258623 ] Hudson commented on HBASE-25435: Results for branch branch-2.4 [build #22 on

[jira] [Assigned] (HBASE-25461) when the cluster has many tables, UI can be opened quickly

2021-01-04 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui reassigned HBASE-25461: -- Assignee: Bo Cui > when the cluster has many tables, UI can be opened quickly >

[jira] [Created] (HBASE-25461) when the cluster has many tables, UI can be opened quickly

2021-01-04 Thread Bo Cui (Jira)
Bo Cui created HBASE-25461: -- Summary: when the cluster has many tables, UI can be opened quickly Key: HBASE-25461 URL: https://issues.apache.org/jira/browse/HBASE-25461 Project: HBase Issue Type:

[GitHub] [hbase] z-york commented on pull request #2800: HBASE-25249 Adding StoreContext

2021-01-04 Thread GitBox
z-york commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-754322209 LGTM. +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] taklwu commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

2021-01-04 Thread GitBox
taklwu commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r551656699 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStoreContext.java ## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache

[GitHub] [hbase] taklwu commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

2021-01-04 Thread GitBox
taklwu commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r551656590 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -2559,7 +2572,7 @@ public boolean needsCompaction() { *

[GitHub] [hbase] taklwu commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

2021-01-04 Thread GitBox
taklwu commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r551656408 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -474,33 +501,14 @@ public long getBlockingFileCount() {

[GitHub] [hbase] caroliney14 commented on pull request #2762: HBASE-25329 Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-04 Thread GitBox
caroliney14 commented on pull request #2762: URL: https://github.com/apache/hbase/pull/2762#issuecomment-754316224 @virajjasani @bharathv do you mind taking a look at this? thanks! This is an automated message from the

[GitHub] [hbase] caroliney14 commented on pull request #2770: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-01-04 Thread GitBox
caroliney14 commented on pull request #2770: URL: https://github.com/apache/hbase/pull/2770#issuecomment-754316052 @virajjasani @bharathv do you mind taking a look at this and sharing your thoughts? thanks! This is an

[jira] [Updated] (HBASE-25460) Expose drainingServers as cluster metric

2021-01-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-25460: - Description: Due to some reason, we had significantly high number of servers put in

[GitHub] [hbase] apurtell commented on pull request #2714: HBASE-25333 Add a yetus check to disable usage of VisibleForTesting a…

2021-01-04 Thread GitBox
apurtell commented on pull request #2714: URL: https://github.com/apache/hbase/pull/2714#issuecomment-754165376 @Apache9 Yes the issue is mostly the dependency on Guava. For documenting why a method is visible, unless there is some static analysis (which we don't have and don't use) an

[jira] [Commented] (HBASE-25435) Slow metric value can be configured

2021-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258434#comment-17258434 ] Hudson commented on HBASE-25435: Results for branch branch-2 [build #146 on

[jira] [Updated] (HBASE-25460) Expose drainingServers as cluster metric

2021-01-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-25460: - Fix Version/s: 2.5.0 1.7.0 3.0.0-alpha-1 > Expose

[jira] [Updated] (HBASE-25460) Expose drainingServers as cluster metric

2021-01-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-25460: - Affects Version/s: 1.6.0 > Expose drainingServers as cluster metric >

[jira] [Created] (HBASE-25460) Expose drainingServers as cluster metric

2021-01-04 Thread Viraj Jasani (Jira)
Viraj Jasani created HBASE-25460: Summary: Expose drainingServers as cluster metric Key: HBASE-25460 URL: https://issues.apache.org/jira/browse/HBASE-25460 Project: HBase Issue Type: New

[GitHub] [hbase] Apache-HBase commented on pull request #2313: HBASE-24900 Make retain assignment configurable during SCP

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2313: URL: https://github.com/apache/hbase/pull/2313#issuecomment-754148230 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2313: HBASE-24900 Make retain assignment configurable during SCP

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2313: URL: https://github.com/apache/hbase/pull/2313#issuecomment-754147518 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24813) ReplicationSource should clear buffer usage on ReplicationSourceManager upon termination

2021-01-04 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258356#comment-17258356 ] Josh Elser commented on HBASE-24813: This should be re-resolved since the bug was addressed in

[jira] [Commented] (HBASE-25435) Slow metric value can be configured

2021-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258328#comment-17258328 ] Hudson commented on HBASE-25435: Results for branch branch-2.3 [build #138 on

[GitHub] [hbase] Apache-HBase commented on pull request #2313: HBASE-24900 Make retain assignment configurable during SCP

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2313: URL: https://github.com/apache/hbase/pull/2313#issuecomment-754080913 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Commented] (HBASE-25447) remoteProc is suspended due to OOM ERROR

2021-01-04 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258292#comment-17258292 ] Pankaj Kumar commented on HBASE-25447: -- Ping [~zghao], [~ndimiduk] & [~andrew.purt...@gmail.com] 

[jira] [Commented] (HBASE-25447) remoteProc is suspended due to OOM ERROR

2021-01-04 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258291#comment-17258291 ] Pankaj Kumar commented on HBASE-25447: -- Pushed to master & branch-2, thanks [~zhangduo] & [~stack] 

[jira] [Updated] (HBASE-25447) remoteProc is suspended due to OOM ERROR

2021-01-04 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-25447: - Fix Version/s: 2.5.0 3.0.0-alpha-1 > remoteProc is suspended due to OOM

[GitHub] [hbase] pankaj72981 merged pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2021-01-04 Thread GitBox
pankaj72981 merged pull request #2824: URL: https://github.com/apache/hbase/pull/2824 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache9 merged pull request #2839: HBASE-25457 Possible race in AsyncConnectionImpl between getChoreServ…

2021-01-04 Thread GitBox
Apache9 merged pull request #2839: URL: https://github.com/apache/hbase/pull/2839 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2839: HBASE-25457 Possible race in AsyncConnectionImpl between getChoreServ…

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2839: URL: https://github.com/apache/hbase/pull/2839#issuecomment-754022194 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2839: HBASE-25457 Possible race in AsyncConnectionImpl between getChoreServ…

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2839: URL: https://github.com/apache/hbase/pull/2839#issuecomment-754016926 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2839: HBASE-25457 Possible race in AsyncConnectionImpl between getChoreServ…

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2839: URL: https://github.com/apache/hbase/pull/2839#issuecomment-754016644 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25439) Add BYTE unit in PrettyPrinter.Unit

2021-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258198#comment-17258198 ] Hudson commented on HBASE-25439: Results for branch master [build #174 on

[jira] [Comment Edited] (HBASE-25130) Masters in-memory serverHoldings map is not cleared during hbck repair

2021-01-04 Thread Rahul Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258189#comment-17258189 ] Rahul Kumar edited comment on HBASE-25130 at 1/4/21, 1:01 PM: -- Possible

[jira] [Commented] (HBASE-25130) Masters in-memory serverHoldings map is not cleared during hbck repair

2021-01-04 Thread Rahul Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258189#comment-17258189 ] Rahul Kumar commented on HBASE-25130: - Possible approaches I could think of tackling the above

[GitHub] [hbase] Apache-HBase commented on pull request #2842: HBASE-25459 WAL can't be cleaned with phoenix5

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2842: URL: https://github.com/apache/hbase/pull/2842#issuecomment-753946956 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #2842: HBASE-25459 WAL can't be cleaned with phoenix5

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2842: URL: https://github.com/apache/hbase/pull/2842#issuecomment-753937204 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2840: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2840: URL: https://github.com/apache/hbase/pull/2840#issuecomment-753935314 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] Apache-HBase commented on pull request #2842: HBASE-25459 WAL can't be cleaned with phoenix5

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2842: URL: https://github.com/apache/hbase/pull/2842#issuecomment-753934910 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2840: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2840: URL: https://github.com/apache/hbase/pull/2840#issuecomment-753932761 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2840: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2840: URL: https://github.com/apache/hbase/pull/2840#issuecomment-753932640 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25456) setRegionStateInMeta need security check

2021-01-04 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25456: -- Release Note: setRegionStateInMeta can be accessed only through Admin rights > setRegionStateInMeta need

[jira] [Updated] (HBASE-25432) we should add security checks for setTableStateInMeta and fixMeta

2021-01-04 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25432: -- Release Note: setTableStateInMeta and fixMeta can be accessed only through Admin rights > we should add

[jira] [Updated] (HBASE-25432) we should add security checks for setTableStateInMeta and fixMeta

2021-01-04 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25432: -- Description: setTableStateInMeta and fixMeta can be accessed only through Admin rights > we should add

[GitHub] [hbase] Apache-HBase commented on pull request #2842: HBASE-25459 WAL can't be cleaned with phoenix5

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2842: URL: https://github.com/apache/hbase/pull/2842#issuecomment-753915889 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[jira] [Commented] (HBASE-25211) Rack awareness in region_mover

2021-01-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258145#comment-17258145 ] Viraj Jasani commented on HBASE-25211: -- PR is open for review: 

[jira] [Comment Edited] (HBASE-25441) add security check for some APIs in RSRpcServices

2021-01-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258144#comment-17258144 ] Viraj Jasani edited comment on HBASE-25441 at 1/4/21, 11:10 AM:

[jira] [Commented] (HBASE-25441) add security check for some APIs in RSRpcServices

2021-01-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258144#comment-17258144 ] Viraj Jasani commented on HBASE-25441: -- [~xiaoheipangzi] can you please take care of updating

[GitHub] [hbase] virajjasani commented on a change in pull request #2839: HBASE-25457 Possible race in AsyncConnectionImpl between getChoreServ…

2021-01-04 Thread GitBox
virajjasani commented on a change in pull request #2839: URL: https://github.com/apache/hbase/pull/2839#discussion_r551248865 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java ## @@ -187,6 +185,9 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #2842: HBASE-25459 WAL can't be cleaned with phoenix5

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2842: URL: https://github.com/apache/hbase/pull/2842#issuecomment-753906284 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Assigned] (HBASE-25441) add security check for some APIs in RSRpcServices

2021-01-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HBASE-25441: Assignee: lujie > add security check for some APIs in RSRpcServices >

[jira] [Updated] (HBASE-25441) add security check for some APIs in RSRpcServices

2021-01-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-25441: - Release Note: RsRpcServices APIs that can be accessed only through Admin rights: - stopServer -

[jira] [Commented] (HBASE-25441) add security check for some APIs in RSRpcServices

2021-01-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258138#comment-17258138 ] Viraj Jasani commented on HBASE-25441: -- {quote}All need Admin access level right? {quote} That's

[GitHub] [hbase] Apache-HBase commented on pull request #2842: HBASE-25459 WAL can't be cleaned with phoenix5

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2842: URL: https://github.com/apache/hbase/pull/2842#issuecomment-753903594 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Assigned] (HBASE-25459) WAL can't be cleaned with phoenix5

2021-01-04 Thread xijiawen (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xijiawen reassigned HBASE-25459: Assignee: xijiawen > WAL can't be cleaned with phoenix5 > -- > >

[GitHub] [hbase] nyl3532016 commented on a change in pull request #2814: HBASE-25442 Refactor MultiVersionConcurrencyControl: replace readWaiters.notifyAll() with WriteEntry.notify()

2021-01-04 Thread GitBox
nyl3532016 commented on a change in pull request #2814: URL: https://github.com/apache/hbase/pull/2814#discussion_r551230988 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiVersionConcurrencyControl.java ## @@ -185,7 +191,7 @@ public void

[GitHub] [hbase] leyangyueshan opened a new pull request #2842: HBASE-25459 WAL can't be cleaned with phoenix5

2021-01-04 Thread GitBox
leyangyueshan opened a new pull request #2842: URL: https://github.com/apache/hbase/pull/2842 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] Apache-HBase commented on pull request #2841: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit (addendum)

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2841: URL: https://github.com/apache/hbase/pull/2841#issuecomment-753874804 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2841: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit (addendum)

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2841: URL: https://github.com/apache/hbase/pull/2841#issuecomment-753871931 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2841: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit (addendum)

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2841: URL: https://github.com/apache/hbase/pull/2841#issuecomment-753871046 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2840: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2840: URL: https://github.com/apache/hbase/pull/2840#issuecomment-753868116 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2840: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2840: URL: https://github.com/apache/hbase/pull/2840#issuecomment-753864982 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-25459) WAL can't be cleaned with phoenix5

2021-01-04 Thread xijiawen (Jira)
xijiawen created HBASE-25459: Summary: WAL can't be cleaned with phoenix5 Key: HBASE-25459 URL: https://issues.apache.org/jira/browse/HBASE-25459 Project: HBase Issue Type: Bug

[GitHub] [hbase] Apache-HBase commented on pull request #2838: HBASE-25458 HRegion methods cleanup

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2838: URL: https://github.com/apache/hbase/pull/2838#issuecomment-753859392 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[jira] [Commented] (HBASE-25439) Add BYTE unit in PrettyPrinter.Unit

2021-01-04 Thread Baiqiang Zhao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258088#comment-17258088 ] Baiqiang Zhao commented on HBASE-25439: --- When backport to branch-2, I found MEMSTORE_FLUSHSIZE is

[GitHub] [hbase] ZhaoBQ opened a new pull request #2841: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit (addendum)

2021-01-04 Thread GitBox
ZhaoBQ opened a new pull request #2841: URL: https://github.com/apache/hbase/pull/2841 MEMSTORE_FLUSHSIZE is missing in TableDescriptorBuilder.getUnit This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] Apache-HBase commented on pull request #2838: HBASE-25458 HRegion methods cleanup

2021-01-04 Thread GitBox
Apache-HBase commented on pull request #2838: URL: https://github.com/apache/hbase/pull/2838#issuecomment-753853713 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ZhaoBQ opened a new pull request #2840: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit

2021-01-04 Thread GitBox
ZhaoBQ opened a new pull request #2840: URL: https://github.com/apache/hbase/pull/2840 backport [HBASE-25439](https://issues.apache.org/jira/browse/HBASE-25439) to branch-2 This is an automated message from the Apache Git

[jira] [Commented] (HBASE-25441) add security check for some APIs in RSRpcServices

2021-01-04 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258054#comment-17258054 ] Anoop Sam John commented on HBASE-25441: Can add a Release notes? API names and expected rights