[GitHub] [hbase] Apache-HBase commented on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-756600287 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2858: HBASE-25482 Improve SimpleRegionNormalizer#getAverageRegionSizeMb

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2858: URL: https://github.com/apache/hbase/pull/2858#issuecomment-756600150 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding StoreContext

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-756598611 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] cuibo01 opened a new pull request #2859: HBASE-25483 set the loadMeta log level to debug

2021-01-07 Thread GitBox
cuibo01 opened a new pull request #2859: URL: https://github.com/apache/hbase/pull/2859 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] Apache9 merged pull request #2857: HBASE-25481 Add host and port attribute when tracing rpc call at clie…

2021-01-07 Thread GitBox
Apache9 merged pull request #2857: URL: https://github.com/apache/hbase/pull/2857 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-756593181 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2857: HBASE-25481 Add host and port attribute when tracing rpc call at clie…

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2857: URL: https://github.com/apache/hbase/pull/2857#issuecomment-756590040 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2857: HBASE-25481 Add host and port attribute when tracing rpc call at clie…

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2857: URL: https://github.com/apache/hbase/pull/2857#issuecomment-756586409 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Assigned] (HBASE-25483) set the loadMeta log level to debug.

2021-01-07 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui reassigned HBASE-25483: -- Assignee: Bo Cui > set the loadMeta log level to debug. > > >

[GitHub] [hbase] Apache-HBase commented on pull request #2853: HBASE-25471 Move RegionScannerImpl out of HRegion

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2853: URL: https://github.com/apache/hbase/pull/2853#issuecomment-756583946 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 commented on a change in pull request #2853: HBASE-25471 Move RegionScannerImpl out of HRegion

2021-01-07 Thread GitBox
Apache9 commented on a change in pull request #2853: URL: https://github.com/apache/hbase/pull/2853#discussion_r553770251 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -4039,7 +4031,7 @@ private static Get toGet(final

[jira] [Commented] (HBASE-25483) set the loadMeta log level to debug.

2021-01-07 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261044#comment-17261044 ] Pankaj Kumar commented on HBASE-25483: -- Nice one [~Bo Cui], pls raise PR. > set the loadMeta log

[GitHub] [hbase] ZhaoBQ opened a new pull request #2858: HBASE-25482 Improve SimpleRegionNormalizer#getAverageRegionSizeMb

2021-01-07 Thread GitBox
ZhaoBQ opened a new pull request #2858: URL: https://github.com/apache/hbase/pull/2858 [HBASE-25482](https://issues.apache.org/jira/browse/HBASE-25482) If the table is set NormalizerTargetRegionSize, we take NormalizerTargetRegionSize as avgRegionSize and return it. So the totalSizeMb

[jira] [Created] (HBASE-25483) set the loadMeta log level to debug.

2021-01-07 Thread Bo Cui (Jira)
Bo Cui created HBASE-25483: -- Summary: set the loadMeta log level to debug. Key: HBASE-25483 URL: https://issues.apache.org/jira/browse/HBASE-25483 Project: HBase Issue Type: Improvement

[GitHub] [hbase] Apache-HBase commented on pull request #2853: HBASE-25471 Move RegionScannerImpl out of HRegion

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2853: URL: https://github.com/apache/hbase/pull/2853#issuecomment-756579573 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-25482) Improve SimpleRegionNormalizer#getAverageRegionSizeMb

2021-01-07 Thread Baiqiang Zhao (Jira)
Baiqiang Zhao created HBASE-25482: - Summary: Improve SimpleRegionNormalizer#getAverageRegionSizeMb Key: HBASE-25482 URL: https://issues.apache.org/jira/browse/HBASE-25482 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #2848: HBASE-25459 WAL can't be cleaned in some scenes

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2848: URL: https://github.com/apache/hbase/pull/2848#issuecomment-756574112 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] infraio commented on a change in pull request #2853: HBASE-25471 Move RegionScannerImpl out of HRegion

2021-01-07 Thread GitBox
infraio commented on a change in pull request #2853: URL: https://github.com/apache/hbase/pull/2853#discussion_r553758795 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -4039,7 +4031,7 @@ private static Get toGet(final

[GitHub] [hbase] Apache-HBase commented on pull request #2511: HBASE-24960 reduce invalid subprocedure task

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2511: URL: https://github.com/apache/hbase/pull/2511#issuecomment-756565548 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2021-01-07 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261018#comment-17261018 ] Viraj Jasani commented on HBASE-23887: -- Let me know if you have any doubts. On high level, we can

[jira] [Comment Edited] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2021-01-07 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260764#comment-17260764 ] Viraj Jasani edited comment on HBASE-23887 at 1/8/21, 5:43 AM: --- [~pustota] 

[GitHub] [hbase] Apache-HBase commented on pull request #2848: HBASE-25459 WAL can't be cleaned in some scenes

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2848: URL: https://github.com/apache/hbase/pull/2848#issuecomment-756554177 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding StoreContext

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-756552901 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-756548614 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2511: HBASE-24960 reduce invalid subprocedure task

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2511: URL: https://github.com/apache/hbase/pull/2511#issuecomment-756546577 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2857: HBASE-25481 Add host and port attribute when tracing rpc call at clie…

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2857: URL: https://github.com/apache/hbase/pull/2857#issuecomment-756544243 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2856: test error prone check

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2856: URL: https://github.com/apache/hbase/pull/2856#issuecomment-756541297 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 8m

[GitHub] [hbase] Apache-HBase commented on pull request #2856: test error prone check

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2856: URL: https://github.com/apache/hbase/pull/2856#issuecomment-756541059 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2853: HBASE-25471 Move RegionScannerImpl out of HRegion

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2853: URL: https://github.com/apache/hbase/pull/2853#issuecomment-756541011 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] caroliney14 commented on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-01-07 Thread GitBox
caroliney14 commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-756540324 @Apache9 @bharathv Thanks for the suggestion. I looked at the code some more and I believe we only need to remove the `checkAndRecordNewServer()` line from `ServerManager`'s

[jira] [Commented] (HBASE-25032) Wait for region server to become online before adding it to online servers in Master

2021-01-07 Thread Caroline (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260986#comment-17260986 ] Caroline commented on HBASE-25032: -- [~bharathv] Thanks for the explanation, I think that makes sense. I

[GitHub] [hbase] Apache-HBase commented on pull request #2856: test error prone check

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2856: URL: https://github.com/apache/hbase/pull/2856#issuecomment-756538980 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2856: test error prone check

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2856: URL: https://github.com/apache/hbase/pull/2856#issuecomment-756529822 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 opened a new pull request #2857: HBASE-25481 Add host and port attribute when tracing rpc call at clie…

2021-01-07 Thread GitBox
Apache9 opened a new pull request #2857: URL: https://github.com/apache/hbase/pull/2857 …nt side This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Work started] (HBASE-25481) Add host and port attribute when tracing rpc call at client side

2021-01-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25481 started by Duo Zhang. - > Add host and port attribute when tracing rpc call at client side >

[GitHub] [hbase] Apache-HBase commented on pull request #2856: test error prone check

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2856: URL: https://github.com/apache/hbase/pull/2856#issuecomment-756527704 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Updated] (HBASE-25401) Add trace support for async call in rpc client

2021-01-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25401: -- Component/s: rpc > Add trace support for async call in rpc client >

[jira] [Created] (HBASE-25481) Add host and port attribute when tracing rpc call at client side

2021-01-07 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25481: - Summary: Add host and port attribute when tracing rpc call at client side Key: HBASE-25481 URL: https://issues.apache.org/jira/browse/HBASE-25481 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #2848: HBASE-25459 WAL can't be cleaned in some scenes

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2848: URL: https://github.com/apache/hbase/pull/2848#issuecomment-756521129 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2511: HBASE-24960 reduce invalid subprocedure task

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2511: URL: https://github.com/apache/hbase/pull/2511#issuecomment-756517261 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25449) 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml

2021-01-07 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260929#comment-17260929 ] Josh Elser commented on HBASE-25449: I'll plan to merge this to all active 2.x+ branches tomorrow.

[GitHub] [hbase] shenshengli commented on a change in pull request #2816: HBASE-25449 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml

2021-01-07 Thread GitBox
shenshengli commented on a change in pull request #2816: URL: https://github.com/apache/hbase/pull/2816#discussion_r553698140 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -1463,15 +1463,15 @@ possible configurations would overwhelm and obscure the

[GitHub] [hbase] shenshengli commented on a change in pull request #2816: HBASE-25449 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml

2021-01-07 Thread GitBox
shenshengli commented on a change in pull request #2816: URL: https://github.com/apache/hbase/pull/2816#discussion_r553697215 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -1463,15 +1463,15 @@ possible configurations would overwhelm and obscure the

[GitHub] [hbase] Apache-HBase commented on pull request #2856: test error prone check

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2856: URL: https://github.com/apache/hbase/pull/2856#issuecomment-756497532 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #2856: test error prone check

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2856: URL: https://github.com/apache/hbase/pull/2856#issuecomment-756496947 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2856: test error prone check

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2856: URL: https://github.com/apache/hbase/pull/2856#issuecomment-756494607 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on pull request #2854: HBASE-25333 Add maven enforcer rule to ban VisibleForTesting imports

2021-01-07 Thread GitBox
Apache9 commented on pull request #2854: URL: https://github.com/apache/hbase/pull/2854#issuecomment-756486286 Ping @apurtell. And @petersomogyi FYI. This is an automated message from the Apache Git Service. To

[jira] [Commented] (HBASE-25473) [create-release] checkcompatibility.py failing with "KeyError: 'binary'"

2021-01-07 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260882#comment-17260882 ] Michael Stack commented on HBASE-25473: --- Still fails cryptic even w/ debug in it and the shaded

[jira] [Created] (HBASE-25480) NPE when getting metrics of backup master

2021-01-07 Thread Andrey Elenskiy (Jira)
Andrey Elenskiy created HBASE-25480: --- Summary: NPE when getting metrics of backup master Key: HBASE-25480 URL: https://issues.apache.org/jira/browse/HBASE-25480 Project: HBase Issue Type:

[jira] [Commented] (HBASE-25473) [create-release] checkcompatibility.py failing with "KeyError: 'binary'"

2021-01-07 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260849#comment-17260849 ] Michael Stack commented on HBASE-25473: --- The hbase-shaded-testing-util jar just fails when you

[jira] [Commented] (HBASE-25445) Old WALs archive fails in procedure based WAL split

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260810#comment-17260810 ] Hudson commented on HBASE-25445: Results for branch branch-2.3 [build #141 on

[jira] [Commented] (HBASE-25441) add security check for some APIs in RSRpcServices

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260777#comment-17260777 ] Hudson commented on HBASE-25441: Results for branch branch-2.2 [build #146 on

[jira] [Commented] (HBASE-25467) Fix error prone problems on branch-2.2

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260778#comment-17260778 ] Hudson commented on HBASE-25467: Results for branch branch-2.2 [build #146 on

[jira] [Commented] (HBASE-25445) Old WALs archive fails in procedure based WAL split

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260775#comment-17260775 ] Hudson commented on HBASE-25445: Results for branch branch-2.2 [build #146 on

[jira] [Commented] (HBASE-25432) we should add security checks for setTableStateInMeta and fixMeta

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260776#comment-17260776 ] Hudson commented on HBASE-25432: Results for branch branch-2.2 [build #146 on

[jira] [Commented] (HBASE-25447) remoteProc is suspended due to OOM ERROR

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260774#comment-17260774 ] Hudson commented on HBASE-25447: Results for branch branch-2.2 [build #146 on

[jira] [Commented] (HBASE-25287) Forgetting to unbuffer streams results in many CLOSE_WAIT sockets when loading files

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260771#comment-17260771 ] Hudson commented on HBASE-25287: Results for branch branch-1 [build #74 on

[jira] [Commented] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2021-01-07 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260769#comment-17260769 ] Viraj Jasani commented on HBASE-23887: -- Please feel free to create a new PR. Current PR has some

[jira] [Commented] (HBASE-25445) Old WALs archive fails in procedure based WAL split

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260768#comment-17260768 ] Hudson commented on HBASE-25445: Results for branch branch-2 [build #150 on

[jira] [Commented] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2021-01-07 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260764#comment-17260764 ] Viraj Jasani commented on HBASE-23887: -- [~pustota] Let's just make this an extended LruCache rather

[GitHub] [hbase] Apache-HBase commented on pull request #1257: HBASE 23887 Up to 3x increase BlockCache performance

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #1257: URL: https://github.com/apache/hbase/pull/1257#issuecomment-756335604 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1257: HBASE 23887 Up to 3x increase BlockCache performance

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #1257: URL: https://github.com/apache/hbase/pull/1257#issuecomment-756335040 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1257: HBASE 23887 Up to 3x increase BlockCache performance

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #1257: URL: https://github.com/apache/hbase/pull/1257#issuecomment-756332977 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25445) Old WALs archive fails in procedure based WAL split

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260737#comment-17260737 ] Hudson commented on HBASE-25445: Results for branch branch-2.4 [build #25 on

[jira] [Commented] (HBASE-25447) remoteProc is suspended due to OOM ERROR

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260736#comment-17260736 ] Hudson commented on HBASE-25447: Results for branch branch-2.4 [build #25 on

[jira] [Work started] (HBASE-25479) [connectors] Purge use of VisibleForTesting

2021-01-07 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25479 started by Peter Somogyi. - > [connectors] Purge use of VisibleForTesting >

[GitHub] [hbase-connectors] petersomogyi opened a new pull request #77: HBASE-25479 Purge use of VisibleForTesting

2021-01-07 Thread GitBox
petersomogyi opened a new pull request #77: URL: https://github.com/apache/hbase-connectors/pull/77 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Created] (HBASE-25479) [connectors] Purge use of VisibleForTesting

2021-01-07 Thread Peter Somogyi (Jira)
Peter Somogyi created HBASE-25479: - Summary: [connectors] Purge use of VisibleForTesting Key: HBASE-25479 URL: https://issues.apache.org/jira/browse/HBASE-25479 Project: HBase Issue Type:

[jira] [Commented] (HBASE-25445) Old WALs archive fails in procedure based WAL split

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260709#comment-17260709 ] Hudson commented on HBASE-25445: Results for branch master [build #178 on

[GitHub] [hbase] Apache-HBase commented on pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2855: URL: https://github.com/apache/hbase/pull/2855#issuecomment-756297281 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-24357) Move hbase-filesystem to hbase-thirdparty-3.3.0

2021-01-07 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-24357. --- Fix Version/s: (was: hbase-filesystem-1.0.0-alpha2) Resolution: Won't Fix The

[jira] [Created] (HBASE-25478) Implement retries when enabling tables in TestRegionReplicaReplicationEndpoint

2021-01-07 Thread Christine Feng (Jira)
Christine Feng created HBASE-25478: -- Summary: Implement retries when enabling tables in TestRegionReplicaReplicationEndpoint Key: HBASE-25478 URL: https://issues.apache.org/jira/browse/HBASE-25478

[jira] [Commented] (HBASE-25473) [create-release] checkcompatibility.py failing with "KeyError: 'binary'"

2021-01-07 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260695#comment-17260695 ] Michael Stack commented on HBASE-25473: --- See below for when I run:

[jira] [Commented] (HBASE-25445) Old WALs archive fails in procedure based WAL split

2021-01-07 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260694#comment-17260694 ] Huaxiang Sun commented on HBASE-25445: -- Thanks [~vjasani], [~dasanjan1296], and [~mokai87]! > Old

[GitHub] [hbase] Apache-HBase commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-756272561 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-756271977 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-25468) Update git-jira-audit fallback_actions file with recent exceptions

2021-01-07 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-25468. -- Resolution: Fixed > Update git-jira-audit fallback_actions file with recent exceptions >

[GitHub] [hbase] Apache-HBase commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-756271573 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ndimiduk commented on pull request #2852: HBASE-25468 Update git-jira-audit fallback_actions file with recent exceptions

2021-01-07 Thread GitBox
ndimiduk commented on pull request #2852: URL: https://github.com/apache/hbase/pull/2852#issuecomment-756271389 Thanks @huaxiangsun ! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] ndimiduk merged pull request #2852: HBASE-25468 Update git-jira-audit fallback_actions file with recent exceptions

2021-01-07 Thread GitBox
ndimiduk merged pull request #2852: URL: https://github.com/apache/hbase/pull/2852 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] ndimiduk commented on pull request #2852: HBASE-25468 Update git-jira-audit fallback_actions file with recent exceptions

2021-01-07 Thread GitBox
ndimiduk commented on pull request #2852: URL: https://github.com/apache/hbase/pull/2852#issuecomment-756268006 This commit addresses all malformed commit messages as of yesterday afternoon PST. This is an automated message

[jira] [Resolved] (HBASE-25467) Fix error prone problems on branch-2.2

2021-01-07 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-25467. --- Fix Version/s: 2.2.7 Resolution: Fixed Pushed to branch-2.2. > Fix error prone

[GitHub] [hbase] petersomogyi merged pull request #2850: HBASE-25467 Fix error prone problems on branch-2.2

2021-01-07 Thread GitBox
petersomogyi merged pull request #2850: URL: https://github.com/apache/hbase/pull/2850 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase-filesystem] petersomogyi commented on pull request #19: HBASE-25477 Purge use of VisibleForTesting

2021-01-07 Thread GitBox
petersomogyi commented on pull request #19: URL: https://github.com/apache/hbase-filesystem/pull/19#issuecomment-756264226 Thanks @wchevreuil for the quick review! This is an automated message from the Apache Git Service. To

[jira] [Resolved] (HBASE-25477) [filesystem] Purge use of VisibleForTesting

2021-01-07 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-25477. -- Resolution: Fixed > [filesystem] Purge use of VisibleForTesting >

[jira] [Updated] (HBASE-25477) [filesystem] Purge use of VisibleForTesting

2021-01-07 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-25477: - Fix Version/s: hbase-filesystem-1.0.0-alpha2 > [filesystem] Purge use of

[GitHub] [hbase-filesystem] wchevreuil merged pull request #19: HBASE-25477 Purge use of VisibleForTesting

2021-01-07 Thread GitBox
wchevreuil merged pull request #19: URL: https://github.com/apache/hbase-filesystem/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase] Apache-HBase commented on pull request #2856: test error prone check

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2856: URL: https://github.com/apache/hbase/pull/2856#issuecomment-756248314 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase-filesystem] petersomogyi opened a new pull request #19: HBASE-25477 Purge use of VisibleForTesting

2021-01-07 Thread GitBox
petersomogyi opened a new pull request #19: URL: https://github.com/apache/hbase-filesystem/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hbase] Apache-HBase commented on pull request #2856: test error prone check

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2856: URL: https://github.com/apache/hbase/pull/2856#issuecomment-756239355 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2856: test error prone check

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2856: URL: https://github.com/apache/hbase/pull/2856#issuecomment-756239165 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-25477) [filesystem] Purge use of VisibleForTesting

2021-01-07 Thread Peter Somogyi (Jira)
Peter Somogyi created HBASE-25477: - Summary: [filesystem] Purge use of VisibleForTesting Key: HBASE-25477 URL: https://issues.apache.org/jira/browse/HBASE-25477 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2855: URL: https://github.com/apache/hbase/pull/2855#issuecomment-756228533 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] petersomogyi commented on a change in pull request #2850: HBASE-25467 Fix error prone problems on branch-2.2

2021-01-07 Thread GitBox
petersomogyi commented on a change in pull request #2850: URL: https://github.com/apache/hbase/pull/2850#discussion_r553409589 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java ## @@ -68,7 +68,7 @@ * */ @InterfaceAudience.Public

[GitHub] [hbase] virajjasani commented on a change in pull request #2850: HBASE-25467 Fix error prone problems on branch-2.2

2021-01-07 Thread GitBox
virajjasani commented on a change in pull request #2850: URL: https://github.com/apache/hbase/pull/2850#discussion_r553400462 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java ## @@ -68,7 +68,7 @@ * */ @InterfaceAudience.Public

[GitHub] [hbase] Apache9 opened a new pull request #2856: test error prone check

2021-01-07 Thread GitBox
Apache9 opened a new pull request #2856: URL: https://github.com/apache/hbase/pull/2856 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] Apache-HBase commented on pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2855: URL: https://github.com/apache/hbase/pull/2855#issuecomment-756149468 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2511: HBASE-24960 reduce invalid subprocedure task

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2511: URL: https://github.com/apache/hbase/pull/2511#issuecomment-756136013 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Assigned] (HBASE-25476) Enable error prone check in pre commit

2021-01-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-25476: - Assignee: Duo Zhang > Enable error prone check in pre commit >

[jira] [Updated] (HBASE-25476) Enable error prone check in pre commit

2021-01-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25476: -- Component/s: build > Enable error prone check in pre commit > --

  1   2   >