[jira] [Updated] (HBASE-25568) Upgrade Thrift jar to fix CVE-2020-13949

2021-03-24 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-25568: - Fix Version/s: (was: 2.3.5) 2.3.6 > Upgrade Thrift jar to fix

[jira] [Commented] (HBASE-25537) Misleading Range metrcis

2021-03-24 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308399#comment-17308399 ] Huaxiang Sun commented on HBASE-25537: -- Moved to 2.3.6. > Misleading Range metrcis >

[jira] [Updated] (HBASE-25537) Misleading Range metrcis

2021-03-24 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-25537: - Fix Version/s: (was: 2.3.5) 2.3.6 > Misleading Range metrcis >

[jira] [Updated] (HBASE-25433) There is no limit on the table name length when creating a table

2021-03-24 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-25433: - Fix Version/s: (was: 2.3.5) 2.3.6 > There is no limit on the table name

[jira] [Commented] (HBASE-25433) There is no limit on the table name length when creating a table

2021-03-24 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308397#comment-17308397 ] Huaxiang Sun commented on HBASE-25433: -- Moved to 2.3.6. > There is no limit on the table name

[jira] [Commented] (HBASE-25034) Table regions details on master GUI display slowly.

2021-03-24 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308395#comment-17308395 ] Huaxiang Sun commented on HBASE-25034: -- Move to 2.3.6. > Table regions details on master GUI

[jira] [Updated] (HBASE-25034) Table regions details on master GUI display slowly.

2021-03-24 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-25034: - Fix Version/s: 2.3.6 > Table regions details on master GUI display slowly. >

[jira] [Updated] (HBASE-25034) Table regions details on master GUI display slowly.

2021-03-24 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-25034: - Fix Version/s: (was: 2.3.5) > Table regions details on master GUI display slowly. >

[GitHub] [hbase] Apache-HBase commented on pull request #3083: HBASE-25568 Upgrade Thrift jar to fix CVE-2020-13949 (branch-2)

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #3083: URL: https://github.com/apache/hbase/pull/3083#issuecomment-806369946 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on pull request #3091: HBASE-25693 NPE getting metrics from standby masters (MetricsMasterWrapperImpl.getMergePlanCount)

2021-03-24 Thread GitBox
virajjasani commented on pull request #3091: URL: https://github.com/apache/hbase/pull/3091#issuecomment-806366793 Belated +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hbase] Apache-HBase commented on pull request #3092: HBASE-25695 Link to the filter on hbase:meta from user tables panel o…

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #3092: URL: https://github.com/apache/hbase/pull/3092#issuecomment-806364491 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] saintstack opened a new pull request #3092: HBASE-25695 Link to the filter on hbase:meta from user tables panel o…

2021-03-24 Thread GitBox
saintstack opened a new pull request #3092: URL: https://github.com/apache/hbase/pull/3092 …n master page -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[jira] [Created] (HBASE-25695) Link to the filter on hbase:meta from user tables panel on master page

2021-03-24 Thread Michael Stack (Jira)
Michael Stack created HBASE-25695: - Summary: Link to the filter on hbase:meta from user tables panel on master page Key: HBASE-25695 URL: https://issues.apache.org/jira/browse/HBASE-25695 Project:

[GitHub] [hbase] Apache-HBase commented on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-806357346 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3091: HBASE-25693 NPE getting metrics from standby masters (MetricsMasterWrapperImpl.getMergePlanCount)

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #3091: URL: https://github.com/apache/hbase/pull/3091#issuecomment-806350813 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-25568) Upgrade Thrift jar to fix CVE-2020-13949

2021-03-24 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-25568: - Fix Version/s: 2.4.3 2.3.5 2.2.7 > Upgrade Thrift jar to

[GitHub] [hbase] Apache-HBase commented on pull request #3091: HBASE-25693 NPE getting metrics from standby masters (MetricsMasterWrapperImpl.getMergePlanCount)

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #3091: URL: https://github.com/apache/hbase/pull/3091#issuecomment-806348731 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] pankaj72981 merged pull request #3085: HBASE-25568 Upgrade Thrift jar to fix CVE-2020-13949 (branch-2.3)

2021-03-24 Thread GitBox
pankaj72981 merged pull request #3085: URL: https://github.com/apache/hbase/pull/3085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] pankaj72981 commented on pull request #3085: HBASE-25568 Upgrade Thrift jar to fix CVE-2020-13949 (branch-2.3)

2021-03-24 Thread GitBox
pankaj72981 commented on pull request #3085: URL: https://github.com/apache/hbase/pull/3085#issuecomment-806348414 Test case failure is not related, test case is passing locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] pankaj72981 merged pull request #3084: HBASE-25568 Upgrade Thrift jar to fix CVE-2020-13949 (branch-2.4)

2021-03-24 Thread GitBox
pankaj72981 merged pull request #3084: URL: https://github.com/apache/hbase/pull/3084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] pankaj72981 merged pull request #3086: HBASE-25568 Upgrade Thrift jar to fix CVE-2020-13949 (branch-2.2)

2021-03-24 Thread GitBox
pankaj72981 merged pull request #3086: URL: https://github.com/apache/hbase/pull/3086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] Apache-HBase commented on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-806335570 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] ZhaoBQ commented on pull request #3074: HBASE-25687 Backport "HBASE-25681 Add a switch for server/table query…

2021-03-24 Thread GitBox
ZhaoBQ commented on pull request #3074: URL: https://github.com/apache/hbase/pull/3074#issuecomment-806333629 The failed seems unrelated.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2771: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #2771: URL: https://github.com/apache/hbase/pull/2771#issuecomment-806322520 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Commented] (HBASE-25693) NPE getting metrics from standby masters (MetricsMasterWrapperImpl.getMergePlanCount)

2021-03-24 Thread Baiqiang Zhao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308297#comment-17308297 ] Baiqiang Zhao commented on HBASE-25693: --- This is duplicate of HBASE-25480. So should HBASE-25480

[jira] [Updated] (HBASE-25693) NPE getting metrics from standby masters (MetricsMasterWrapperImpl.getMergePlanCount)

2021-03-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25693: Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was:

[GitHub] [hbase] apurtell edited a comment on pull request #3091: HBASE-25693 NPE getting metrics from standby masters (MetricsMasterWrapperImpl.getMergePlanCount)

2021-03-24 Thread GitBox
apurtell edited a comment on pull request #3091: URL: https://github.com/apache/hbase/pull/3091#issuecomment-806307739 Who is @shahrs87 ? There is no name associated with your GitHub account so I couldn't find your name for a signed-off-by line. You might want to add something. --

[GitHub] [hbase] apurtell commented on pull request #3091: HBASE-25693 NPE getting metrics from standby masters (MetricsMasterWrapperImpl.getMergePlanCount)

2021-03-24 Thread GitBox
apurtell commented on pull request #3091: URL: https://github.com/apache/hbase/pull/3091#issuecomment-806307739 Who is @shahrs87 ? There is no name associated with your GitHub account so I couldn't look you up for a signed-off-by line. You might want to add something. -- This is an

[GitHub] [hbase] apurtell merged pull request #3091: HBASE-25693 NPE getting metrics from standby masters (MetricsMasterWrapperImpl.getMergePlanCount)

2021-03-24 Thread GitBox
apurtell merged pull request #3091: URL: https://github.com/apache/hbase/pull/3091 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hbase] apurtell commented on pull request #3091: HBASE-25693 NPE getting metrics from standby masters (MetricsMasterWrapperImpl.getMergePlanCount)

2021-03-24 Thread GitBox
apurtell commented on pull request #3091: URL: https://github.com/apache/hbase/pull/3091#issuecomment-806306841 Thanks for the reviews everyone! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (HBASE-25694) Improve the shell's 'status replication' command

2021-03-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25694: Description: The output of the shell's 'status "replication"' command could use

[jira] [Updated] (HBASE-25694) Improve the shell's 'status replication' command output

2021-03-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25694: Summary: Improve the shell's 'status replication' command output (was: Improve

[jira] [Updated] (HBASE-25694) Improve the shell's 'status replication' command

2021-03-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25694: Description: The output of the shell's 'status "replication"' command could use

[jira] [Updated] (HBASE-25694) Improve the shell's 'status replication' command

2021-03-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25694: Summary: Improve the shell's 'status replication' command (was: Shell's 'status

[jira] [Created] (HBASE-25694) Shell's 'status replication' command could use some cleanup

2021-03-24 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-25694: --- Summary: Shell's 'status replication' command could use some cleanup Key: HBASE-25694 URL: https://issues.apache.org/jira/browse/HBASE-25694 Project:

[GitHub] [hbase] Apache-HBase commented on pull request #2770: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #2770: URL: https://github.com/apache/hbase/pull/2770#issuecomment-806305305 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2771: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #2771: URL: https://github.com/apache/hbase/pull/2771#issuecomment-806300705 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-25590) Bulkload replication HFileRefs cannot be cleared in some cases where set exclude-namespace/exclude-table-cfs

2021-03-24 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-25590: - Fix Version/s: 2.3.5 3.0.0-alpha-1 > Bulkload replication HFileRefs cannot

[GitHub] [hbase] Apache-HBase commented on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-806296412 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2771: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #2771: URL: https://github.com/apache/hbase/pull/2771#issuecomment-806295059 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3091: HBASE-25693 NPE getting metrics from standby masters (MetricsMasterWrapperImpl.getMergePlanCount)

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #3091: URL: https://github.com/apache/hbase/pull/3091#issuecomment-806280161 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25693) NPE getting metrics from standby masters (MetricsMasterWrapperImpl.getMergePlanCount)

2021-03-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25693: Status: Patch Available (was: Open) > NPE getting metrics from standby masters

[GitHub] [hbase] apurtell opened a new pull request #3091: HBASE-25693 NPE getting metrics from standby masters (MetricsMasterWrapperImpl.getMergePlanCount)

2021-03-24 Thread GitBox
apurtell opened a new pull request #3091: URL: https://github.com/apache/hbase/pull/3091 When a metrics source is configured in the metrics properties file for a standby master, because the master is not in the active role, getRegionNormalizerManager() returns null and some methods of

[jira] [Commented] (HBASE-25693) NPE getting metrics from standby masters (MetricsMasterWrapperImpl.getMergePlanCount)

2021-03-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308244#comment-17308244 ] Andrew Kyle Purtell commented on HBASE-25693: - This is happening when the file metrics

[jira] [Assigned] (HBASE-25693) NPE getting metrics from standby masters (MetricsMasterWrapperImpl.getMergePlanCount)

2021-03-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell reassigned HBASE-25693: --- Assignee: Andrew Kyle Purtell > NPE getting metrics from standby masters

[jira] [Created] (HBASE-25693) NPE getting metrics from standby masters (MetricsMasterWrapperImpl.getMergePlanCount)

2021-03-24 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-25693: --- Summary: NPE getting metrics from standby masters (MetricsMasterWrapperImpl.getMergePlanCount) Key: HBASE-25693 URL:

[GitHub] [hbase] Apache-HBase commented on pull request #2770: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #2770: URL: https://github.com/apache/hbase/pull/2770#issuecomment-806254611 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-806252374 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3090: HBASE-25692 Always try to close the WAL reader when we catch any exce…

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #3090: URL: https://github.com/apache/hbase/pull/3090#issuecomment-806244074 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3090: HBASE-25692 Always try to close the WAL reader when we catch any exce…

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #3090: URL: https://github.com/apache/hbase/pull/3090#issuecomment-806240801 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] caroliney14 commented on a change in pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-03-24 Thread GitBox
caroliney14 commented on a change in pull request #2769: URL: https://github.com/apache/hbase/pull/2769#discussion_r600924948 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java ## @@ -1050,7 +1050,7 @@ public void run() {

[GitHub] [hbase] Apache-HBase commented on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-806233038 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-806231742 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-806230925 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2771: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #2771: URL: https://github.com/apache/hbase/pull/2771#issuecomment-806224612 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2770: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #2770: URL: https://github.com/apache/hbase/pull/2770#issuecomment-806219149 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-806210819 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-806209222 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] huaxiangsun merged pull request #3089: HBASE-25691 Test failure: TestVerifyBucketCacheFile.testRetrieveFromFile

2021-03-24 Thread GitBox
huaxiangsun merged pull request #3089: URL: https://github.com/apache/hbase/pull/3089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] huaxiangsun commented on pull request #3089: HBASE-25691 Test failure: TestVerifyBucketCacheFile.testRetrieveFromFile

2021-03-24 Thread GitBox
huaxiangsun commented on pull request #3089: URL: https://github.com/apache/hbase/pull/3089#issuecomment-806204071 The test failure is to read the xml file, it is not related with the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] huaxiangsun merged pull request #3088: HBASE-25691 Test failure: TestVerifyBucketCacheFile.testRetrieveFromFile

2021-03-24 Thread GitBox
huaxiangsun merged pull request #3088: URL: https://github.com/apache/hbase/pull/3088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] huaxiangsun merged pull request #3087: HBASE-25691 Test failure: TestVerifyBucketCacheFile.testRetrieveFromFile

2021-03-24 Thread GitBox
huaxiangsun merged pull request #3087: URL: https://github.com/apache/hbase/pull/3087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] saintstack commented on a change in pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-03-24 Thread GitBox
saintstack commented on a change in pull request #2769: URL: https://github.com/apache/hbase/pull/2769#discussion_r600870882 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java ## @@ -1050,7 +1050,7 @@ public void run() {

[GitHub] [hbase] Apache-HBase commented on pull request #3090: HBASE-25692 Always try to close the WAL reader when we catch any exce…

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #3090: URL: https://github.com/apache/hbase/pull/3090#issuecomment-806178371 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3087: HBASE-25691 Test failure: TestVerifyBucketCacheFile.testRetrieveFromFile

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #3087: URL: https://github.com/apache/hbase/pull/3087#issuecomment-806175888 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3088: HBASE-25691 Test failure: TestVerifyBucketCacheFile.testRetrieveFromFile

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #3088: URL: https://github.com/apache/hbase/pull/3088#issuecomment-806175197 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #3089: HBASE-25691 Test failure: TestVerifyBucketCacheFile.testRetrieveFromFile

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #3089: URL: https://github.com/apache/hbase/pull/3089#issuecomment-806165811 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #3088: HBASE-25691 Test failure: TestVerifyBucketCacheFile.testRetrieveFromFile

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #3088: URL: https://github.com/apache/hbase/pull/3088#issuecomment-806155898 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-25692) Failure to instantiate WALCellCodec leaks socket in replication

2021-03-24 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-25692: --- Status: Patch Available (was: Open) > Failure to instantiate WALCellCodec leaks socket in

[GitHub] [hbase] joshelser opened a new pull request #3090: HBASE-25692 Always try to close the WAL reader when we catch any exce…

2021-03-24 Thread GitBox
joshelser opened a new pull request #3090: URL: https://github.com/apache/hbase/pull/3090 …ption There are code paths in which we throw non-IOExceptions when initializing a WAL reader. However, we only close the InputStream to the WAL filesystem when the exception is an

[GitHub] [hbase] Apache-HBase commented on pull request #3085: HBASE-25568 Upgrade Thrift jar to fix CVE-2020-13949 (branch-2.3)

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #3085: URL: https://github.com/apache/hbase/pull/3085#issuecomment-806146905 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3084: HBASE-25568 Upgrade Thrift jar to fix CVE-2020-13949 (branch-2.4)

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #3084: URL: https://github.com/apache/hbase/pull/3084#issuecomment-806125199 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-806113916 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-25593) Backport changes from HBASE-24418 to branch-1

2021-03-24 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-25593. -- Hadoop Flags: Reviewed Resolution: Fixed Thanks for the contribution [~mnpoonia]. >

[GitHub] [hbase] virajjasani merged pull request #2991: HBASE-25593 Backport changes from HBASE-24418 to branch-1

2021-03-24 Thread GitBox
virajjasani merged pull request #2991: URL: https://github.com/apache/hbase/pull/2991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] Apache-HBase commented on pull request #3083: HBASE-25568 Upgrade Thrift jar to fix CVE-2020-13949 (branch-2)

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #3083: URL: https://github.com/apache/hbase/pull/3083#issuecomment-806106171 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3087: HBASE-25691 Test failure: TestVerifyBucketCacheFile.testRetrieveFromFile

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #3087: URL: https://github.com/apache/hbase/pull/3087#issuecomment-806077707 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3089: HBASE-25691 Test failure: TestVerifyBucketCacheFile.testRetrieveFromFile

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #3089: URL: https://github.com/apache/hbase/pull/3089#issuecomment-806075665 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3086: HBASE-25568 Upgrade Thrift jar to fix CVE-2020-13949 (branch-2.2)

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #3086: URL: https://github.com/apache/hbase/pull/3086#issuecomment-806052753 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Commented] (HBASE-25019) check if we're impacted by MASSEMBLY-941 and mitigate if needed

2021-03-24 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308072#comment-17308072 ] Huaxiang Sun commented on HBASE-25019: -- move out to 2.3.6. > check if we're impacted by

[jira] [Updated] (HBASE-25019) check if we're impacted by MASSEMBLY-941 and mitigate if needed

2021-03-24 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-25019: - Fix Version/s: (was: 2.3.5) 2.3.6 > check if we're impacted by

[jira] [Commented] (HBASE-24792) return value of LogRoller.walRollFinished may be wrong

2021-03-24 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308070#comment-17308070 ] Huaxiang Sun commented on HBASE-24792: -- Move out to 2.3.6 > return value of

[jira] [Updated] (HBASE-24792) return value of LogRoller.walRollFinished may be wrong

2021-03-24 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-24792: - Fix Version/s: (was: 2.3.5) 2.3.6 > return value of

[jira] [Updated] (HBASE-25691) Test failure: TestVerifyBucketCacheFile.testRetrieveFromFile

2021-03-24 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-25691: - Fix Version/s: 2.4.3 2.3.5 3.0.0-alpha-1 > Test failure:

[jira] [Commented] (HBASE-25685) asyncprofiler2.0 no longer supports svg; wants html

2021-03-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308065#comment-17308065 ] Andrew Kyle Purtell commented on HBASE-25685: - Thanks [~stack] for already tackling this

[GitHub] [hbase] Apache-HBase commented on pull request #3085: HBASE-25568 Upgrade Thrift jar to fix CVE-2020-13949 (branch-2.3)

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #3085: URL: https://github.com/apache/hbase/pull/3085#issuecomment-806009917 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3089: HBASE-25691 Test failure: TestVerifyBucketCacheFile.testRetrieveFromFile

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #3089: URL: https://github.com/apache/hbase/pull/3089#issuecomment-806009413 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #3088: HBASE-25691 Test failure: TestVerifyBucketCacheFile.testRetrieveFromFile

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #3088: URL: https://github.com/apache/hbase/pull/3088#issuecomment-806001260 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3087: HBASE-25691 Test failure: TestVerifyBucketCacheFile.testRetrieveFromFile

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #3087: URL: https://github.com/apache/hbase/pull/3087#issuecomment-805998568 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2901: HBASE-22120 Replace HTrace with OpenTelemetry

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #2901: URL: https://github.com/apache/hbase/pull/2901#issuecomment-805995572 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-25692) Failure to instantiate WALCellCodec leaks socket in replication

2021-03-24 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-25692: --- Description: I was looking at an HBase user's cluster with [~danilocop] where they saw two

[jira] [Updated] (HBASE-25692) Failure to instantiate WALCellCodec leaks socket in replication

2021-03-24 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-25692: --- Summary: Failure to instantiate WALCellCodec leaks socket in replication (was: Failure to

[jira] [Commented] (HBASE-25692) Failure to instantiate WALCellCodec leaks socket in replication

2021-03-24 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307996#comment-17307996 ] Josh Elser commented on HBASE-25692: I've verified that all 2.x and master branches have this

[jira] [Created] (HBASE-25692) Failure to instantiate WALCellCodec leaks socket

2021-03-24 Thread Josh Elser (Jira)
Josh Elser created HBASE-25692: -- Summary: Failure to instantiate WALCellCodec leaks socket Key: HBASE-25692 URL: https://issues.apache.org/jira/browse/HBASE-25692 Project: HBase Issue Type: Bug

[GitHub] [hbase] huaxiangsun opened a new pull request #3089: HBASE-25691 Test failure: TestVerifyBucketCacheFile.testRetrieveFromFile

2021-03-24 Thread GitBox
huaxiangsun opened a new pull request #3089: URL: https://github.com/apache/hbase/pull/3089 The issue is that FileInputStream is created with try-with-resources, so its close() is called right after the try sentence. FileInputStream is a finalize class, when this object is garbage

[GitHub] [hbase] huaxiangsun opened a new pull request #3088: HBASE-25691 Test failure: TestVerifyBucketCacheFile.testRetrieveFromFile

2021-03-24 Thread GitBox
huaxiangsun opened a new pull request #3088: URL: https://github.com/apache/hbase/pull/3088 The issue is that FileInputStream is created with try-with-resources, so its close() is called right after the try sentence. FileInputStream is a finalize class, when this object is garbage

[GitHub] [hbase] huaxiangsun opened a new pull request #3087: HBASE-25691 Test failure: TestVerifyBucketCacheFile.testRetrieveFromFile

2021-03-24 Thread GitBox
huaxiangsun opened a new pull request #3087: URL: https://github.com/apache/hbase/pull/3087 The issue is that FileInputStream is created with try-with-resources, so its close() is called right after the try sentence. FileInputStream is a finalize class, when this object is garbage

[GitHub] [hbase] Apache-HBase commented on pull request #3084: HBASE-25568 Upgrade Thrift jar to fix CVE-2020-13949 (branch-2.4)

2021-03-24 Thread GitBox
Apache-HBase commented on pull request #3084: URL: https://github.com/apache/hbase/pull/3084#issuecomment-805957566 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] huaxiangsun merged pull request #3081: HBASE-25691 Test failure: TestVerifyBucketCacheFile.testRetrieveFromFile

2021-03-24 Thread GitBox
huaxiangsun merged pull request #3081: URL: https://github.com/apache/hbase/pull/3081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] bharathv commented on a change in pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-03-24 Thread GitBox
bharathv commented on a change in pull request #2769: URL: https://github.com/apache/hbase/pull/2769#discussion_r600625117 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java ## @@ -1084,7 +1084,15 @@ public void run() { }

  1   2   >