[GitHub] [hbase] Apache-HBase commented on pull request #3112: HBASE-25696 Need to initialize SLF4JBridgeHandler in jul-to-slf4j for…
Apache-HBase commented on pull request #3112: URL: https://github.com/apache/hbase/pull/3112#issuecomment-811665471 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 41s | branch-2 passed | | +1 :green_heart: | compile | 2m 13s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 1s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 19s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 21s | the patch passed | | +1 :green_heart: | compile | 2m 14s | the patch passed | | +1 :green_heart: | javac | 2m 14s | the patch passed | | +1 :green_heart: | shadedjars | 5m 57s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 15s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 238m 43s | root in the patch failed. | | | | 273m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3112 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 15f10c31738e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / b051ad5594 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/2/testReport/ | | Max. process+thread count | 3726 (vs. ulimit of 12500) | | modules | C: hbase-logging hbase-common hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] YutSean commented on pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1
YutSean commented on pull request #2941: URL: https://github.com/apache/hbase/pull/2941#issuecomment-811610482 I have removed the redundant whitespace and trigger the QA again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] YutSean commented on pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1
YutSean commented on pull request #2941: URL: https://github.com/apache/hbase/pull/2941#issuecomment-811610210 Right, the complaint means the thrift 0.13 package is complied by java 8. The whitespace is just for triggering the QA. The unit tests also report the java version problem of thrift 0.13. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-25721) Add 2.3.5 to the downloads page
[ https://issues.apache.org/jira/browse/HBASE-25721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun resolved HBASE-25721. -- Resolution: Fixed > Add 2.3.5 to the downloads page > --- > > Key: HBASE-25721 > URL: https://issues.apache.org/jira/browse/HBASE-25721 > Project: HBase > Issue Type: Task > Components: community >Reporter: Huaxiang Sun >Assignee: Huaxiang Sun >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25658) Basic benchmark to show the impact on performance for tracing
[ https://issues.apache.org/jira/browse/HBASE-25658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312822#comment-17312822 ] Duo Zhang commented on HBASE-25658: --- You can see that, for scan and read, enabling tracing for every request does not effect the performance too much, but for write, enable tracing will cause a big performance downgrade. Need to dig more. > Basic benchmark to show the impact on performance for tracing > - > > Key: HBASE-25658 > URL: https://issues.apache.org/jira/browse/HBASE-25658 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1
Apache-HBase commented on pull request #2941: URL: https://github.com/apache/hbase/pull/2941#issuecomment-811607801 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 12m 53s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. | | +0 :ok: | jshint | 0m 0s | jshint was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 9 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +0 :ok: | mvndep | 2m 30s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 8m 19s | branch-1 passed | | +1 :green_heart: | compile | 0m 45s | branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19 | | +1 :green_heart: | compile | 0m 56s | branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10 | | +1 :green_heart: | checkstyle | 1m 9s | branch-1 passed | | +1 :green_heart: | shadedjars | 3m 3s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 53s | branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19 | | +1 :green_heart: | javadoc | 1m 51s | branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10 | | +0 :ok: | spotbugs | 1m 40s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 3m 0s | branch-1 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 57s | the patch passed | | +1 :green_heart: | compile | 0m 47s | the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19 | | +1 :green_heart: | javac | 0m 47s | the patch passed | | +1 :green_heart: | compile | 0m 58s | the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10 | | -1 :x: | javac | 0m 35s | hbase-thrift-jdkAzulSystems,Inc.-1.7.0_272-b10 with JDK Azul Systems, Inc.-1.7.0_272-b10 generated 41 new + 64 unchanged - 38 fixed = 105 total (was 102) | | +1 :green_heart: | checkstyle | 0m 30s | The patch passed checkstyle in hbase-common | | +1 :green_heart: | checkstyle | 0m 35s | hbase-thrift: The patch generated 0 new + 82 unchanged - 77 fixed = 82 total (was 159) | | +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 2m 51s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 4m 50s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | -1 :x: | javadoc | 0m 29s | hbase-thrift-jdkAzulSystems,Inc.-1.8.0_262-b19 with JDK Azul Systems, Inc.-1.8.0_262-b19 generated 13 new + 0 unchanged - 0 fixed = 13 total (was 0) | | -1 :x: | javadoc | 2m 41s | hbase-thrift-jdkAzulSystems,Inc.-1.7.0_272-b10 with JDK Azul Systems, Inc.-1.7.0_272-b10 generated 13 new + 0 unchanged - 0 fixed = 13 total (was 0) | | +1 :green_heart: | findbugs | 3m 18s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 45s | hbase-common in the patch passed. | | -1 :x: | unit | 0m 35s | hbase-thrift in the patch failed. | | +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. | | | | 65m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2941/7/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2941 | | JIRA Issue | HBASE-21674 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile jshint | | uname | Linux 542e07c495b5 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2941/out/precommit/personality/provided.sh | | git revision | branch-1 / d07ef8f | | Default Java | Azul Systems, Inc.-1.7.0_272-b10 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10 | | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2941/7/artifact/out/diff-compile-javac-hbase-thrift-jdkAzulSystems,Inc.-1.7.0_272-b10.txt | | javadoc |
[GitHub] [hbase] huaxiangsun merged pull request #3114: HBASE-25721 Add 2.3.5 to the downloads page
huaxiangsun merged pull request #3114: URL: https://github.com/apache/hbase/pull/3114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25658) Basic benchmark to show the impact on performance for tracing
[
https://issues.apache.org/jira/browse/HBASE-25658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312820#comment-17312820
]
Duo Zhang commented on HBASE-25658:
---
I set up a all-in-one jaeger receiver with downsampling 1.0, which means drop
all the received tracing data, to minimum the effect on the receiver side.
I modified the tracing code a bit, where I removed the tracing on
RegionScanner.next, because a scan rpc call from client side could lead to
thousands of RegionScanner.next, so it is not a good idea to trace every
RegionScanner.next call.
Still execute the same command, for HBASE-22120 with trace disabled
{noformat}
Write: 224758 row per second
[ Avg TPS/QPS] 205061 row per second
[ Avg TPS/QPS] 242453 row per second
[ Avg TPS/QPS] 226761 row per second
Scan: 86981 row per second
[ Avg TPS/QPS] 86042row per second
[ Avg TPS/QPS] 86582row per second
[ Avg TPS/QPS] 88319row per second
Read: 2807 row per second
[ Avg TPS/QPS] 2770 row per second
[ Avg TPS/QPS] 2776 row per second
[ Avg TPS/QPS] 2876 row per second
{noformat}
For HBASE-22120 with trace enabled and sampling ratio as 1.0, which means trace
all, the result is
{noformat}
-Dotel.traces.exporter=jaeger -Dotel.exporter.jaeger.endpoint=x:14250
-Dotel.metrics.exporter=none -Dotel.traces.sampler=parentbased_traceidratio
-Dotel.traces.sampler.arg=1.0 -Dotel.resource.attributes=service.name=hbase
{noformat}
{noformat}
Write: 89618 row per second
[ Avg TPS/QPS] 84689row per second
[ Avg TPS/QPS] 85225row per second
[ Avg TPS/QPS] 98941row per second
Scan: 86075 row per second
[ Avg TPS/QPS] 84201row per second
[ Avg TPS/QPS] 87094row per second
[ Avg TPS/QPS] 86929row per second
Read: 2890 row per second
[ Avg TPS/QPS] 2900 row per second
[ Avg TPS/QPS] 2776 row per second
[ Avg TPS/QPS] 2876 row per second
{noformat}
> Basic benchmark to show the impact on performance for tracing
> -
>
> Key: HBASE-25658
> URL: https://issues.apache.org/jira/browse/HBASE-25658
> Project: HBase
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-25715) Add a basic CompactionServer which only keep heartbeat with HMaster
[ https://issues.apache.org/jira/browse/HBASE-25715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yulin Niu updated HBASE-25715: -- Summary: Add a basic CompactionServer which only keep heartbeat with HMaster (was: Add a basic CompactionServer which only implement status report to HMaster) > Add a basic CompactionServer which only keep heartbeat with HMaster > --- > > Key: HBASE-25715 > URL: https://issues.apache.org/jira/browse/HBASE-25715 > Project: HBase > Issue Type: Sub-task >Reporter: Yulin Niu >Assignee: Yulin Niu >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3112: HBASE-25696 Need to initialize SLF4JBridgeHandler in jul-to-slf4j for…
Apache-HBase commented on pull request #3112: URL: https://github.com/apache/hbase/pull/3112#issuecomment-811595569 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 35s | branch-2 passed | | +1 :green_heart: | compile | 8m 48s | branch-2 passed | | +1 :green_heart: | checkstyle | 2m 2s | branch-2 passed | | +1 :green_heart: | spotbugs | 10m 9s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 16s | the patch passed | | +1 :green_heart: | compile | 8m 44s | the patch passed | | +1 :green_heart: | javac | 8m 44s | the patch passed | | +1 :green_heart: | checkstyle | 2m 5s | the patch passed | | +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 5s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 11m 49s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 11m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 6s | The patch does not generate ASF License warnings. | | | | 73m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3112 | | Optional Tests | dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle | | uname | Linux 999f1987df84 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / b051ad5594 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 141 (vs. ulimit of 12500) | | modules | C: hbase-logging hbase-common hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/2/console | | versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1
Apache-HBase commented on pull request #2941: URL: https://github.com/apache/hbase/pull/2941#issuecomment-811584301 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker mode activated. | | -1 :x: | patch | 0m 10s | https://github.com/apache/hbase/pull/2941 does not apply to branch-1. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/2941 | | JIRA Issue | HBASE-21674 | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2941/6/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3114: HBASE-25721 Add 2.3.5 to the downloads page
Apache-HBase commented on pull request #3114: URL: https://github.com/apache/hbase/pull/3114#issuecomment-811573571 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 59s | master passed | | +1 :green_heart: | mvnsite | 8m 56s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 34s | the patch passed | | +1 :green_heart: | mvnsite | 8m 55s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 20s | The patch does not generate ASF License warnings. | | | | 28m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3114/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3114 | | Optional Tests | dupname asflicense mvnsite xml | | uname | Linux 9145f9565352 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e14ec57eee | | Max. process+thread count | 89 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3114/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25722) Update reporter tool with new release, 2.3.5
[ https://issues.apache.org/jira/browse/HBASE-25722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312801#comment-17312801 ] Huaxiang Sun commented on HBASE-25722: -- Hi [~vjasani], can you help to update the reporter website for 2.3.5? Thanks. > Update reporter tool with new release, 2.3.5 > > > Key: HBASE-25722 > URL: https://issues.apache.org/jira/browse/HBASE-25722 > Project: HBase > Issue Type: Sub-task >Reporter: Huaxiang Sun >Assignee: Viraj Jasani >Priority: Major > > Reporter tool: [https://reporter.apache.org/addrelease.html?hbase] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-25722) Update reporter tool with new release, 2.3.5
Huaxiang Sun created HBASE-25722: Summary: Update reporter tool with new release, 2.3.5 Key: HBASE-25722 URL: https://issues.apache.org/jira/browse/HBASE-25722 Project: HBase Issue Type: Sub-task Reporter: Huaxiang Sun Assignee: Viraj Jasani Reporter tool: [https://reporter.apache.org/addrelease.html?hbase] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3114: HBASE-25721 Add 2.3.5 to the downloads page
Apache-HBase commented on pull request #3114: URL: https://github.com/apache/hbase/pull/3114#issuecomment-811565215 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 41s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 2m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3114/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3114 | | Optional Tests | | | uname | Linux 62a504fe76c5 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e14ec57eee | | Max. process+thread count | 49 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3114/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3114: HBASE-25721 Add 2.3.5 to the downloads page
Apache-HBase commented on pull request #3114: URL: https://github.com/apache/hbase/pull/3114#issuecomment-811565045 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 2m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3114/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3114 | | Optional Tests | | | uname | Linux 2b22d6912242 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e14ec57eee | | Max. process+thread count | 42 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3114/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] huaxiangsun opened a new pull request #3114: HBASE-25721 Add 2.3.5 to the downloads page
huaxiangsun opened a new pull request #3114: URL: https://github.com/apache/hbase/pull/3114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-25721) Add 2.3.5 to the downloads page
Huaxiang Sun created HBASE-25721: Summary: Add 2.3.5 to the downloads page Key: HBASE-25721 URL: https://issues.apache.org/jira/browse/HBASE-25721 Project: HBase Issue Type: Task Components: community Reporter: Huaxiang Sun Assignee: Huaxiang Sun -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3105: HBASE-25713 Make an hbase-wal module
Apache-HBase commented on pull request #3105: URL: https://github.com/apache/hbase/pull/3105#issuecomment-811539332 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 37s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 46s | branch-2 passed | | +1 :green_heart: | compile | 9m 13s | branch-2 passed | | +1 :green_heart: | checkstyle | 2m 34s | branch-2 passed | | +1 :green_heart: | spotbugs | 15m 28s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 1m 0s | root in the patch failed. | | -1 :x: | compile | 2m 18s | root in the patch failed. | | -0 :warning: | javac | 2m 18s | root in the patch failed. | | -0 :warning: | checkstyle | 0m 29s | The patch fails to run checkstyle in root | | -0 :warning: | whitespace | 0m 0s | The patch has 13 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 :green_heart: | xml | 0m 6s | The patch has no ill-formed XML file. | | -1 :x: | hadoopcheck | 1m 27s | The patch causes 42 errors with Hadoop v3.1.2. | | -1 :x: | hadoopcheck | 2m 53s | The patch causes 42 errors with Hadoop v3.2.1. | | -1 :x: | spotbugs | 0m 13s | hbase-wal in the patch failed. | | -1 :x: | spotbugs | 3m 17s | root in the patch failed. | | -1 :x: | spotbugs | 0m 9s | hbase-client in the patch failed. | | -1 :x: | spotbugs | 0m 23s | hbase-mapreduce in the patch failed. | | -1 :x: | spotbugs | 0m 8s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 31s | The patch does not generate ASF License warnings. | | | | 53m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3105 | | Optional Tests | dupname asflicense javac hadoopcheck xml compile spotbugs hbaseanti checkstyle | | uname | Linux bf3d71a31f33 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 1d3ea38f1e | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/patch-compile-root.txt | | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/patch-compile-root.txt | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/buildtool-patch-checkstyle-root.txt | | whitespace | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/whitespace-eol.txt | | hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/patch-javac-3.1.2.txt | | hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/patch-javac-3.2.1.txt | | spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/patch-spotbugs-hbase-wal.txt | | spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/patch-spotbugs-root.txt | | spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/patch-spotbugs-hbase-client.txt | | spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/patch-spotbugs-hbase-mapreduce.txt | | spotbugs |
[GitHub] [hbase] Apache-HBase commented on pull request #3105: HBASE-25713 Make an hbase-wal module
Apache-HBase commented on pull request #3105: URL: https://github.com/apache/hbase/pull/3105#issuecomment-811533565 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 37s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 4s | branch-2 passed | | +1 :green_heart: | compile | 2m 44s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 50s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 5m 19s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 1m 5s | root in the patch failed. | | -1 :x: | compile | 0m 58s | root in the patch failed. | | -0 :warning: | javac | 0m 58s | root in the patch failed. | | -1 :x: | shadedjars | 3m 14s | patch has 42 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 23s | hbase-common generated 1 new + 14 unchanged - 0 fixed = 15 total (was 14) | | -0 :warning: | javadoc | 0m 14s | hbase-coprocessor generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | | -0 :warning: | javadoc | 0m 13s | hbase-wal in the patch failed. | | -0 :warning: | javadoc | 0m 49s | root in the patch failed. | | -0 :warning: | javadoc | 0m 10s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 10s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 3m 56s | root in the patch failed. | | | | 35m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3105 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b3a71ac2a8e7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 1d3ea38f1e | | Default Java | AdoptOpenJDK-11.0.10+9 | | mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt | | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt | | shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-common.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-coprocessor.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-wal.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/testReport/ | | Max. process+thread count | 716 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-coprocessor hbase-hadoop-compat hbase-hadoop2-compat hbase-wal . hbase-client hbase-endpoint hbase-mapreduce
[GitHub] [hbase] Apache-HBase commented on pull request #3105: HBASE-25713 Make an hbase-wal module
Apache-HBase commented on pull request #3105: URL: https://github.com/apache/hbase/pull/3105#issuecomment-811532316 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 40s | branch-2 passed | | +1 :green_heart: | compile | 2m 16s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 2s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 38s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 55s | root in the patch failed. | | -1 :x: | compile | 0m 46s | root in the patch failed. | | -0 :warning: | javac | 0m 46s | root in the patch failed. | | -1 :x: | shadedjars | 2m 52s | patch has 42 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 46s | root in the patch failed. | | -0 :warning: | javadoc | 0m 9s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 9s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 13s | hbase-wal generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0) | ||| _ Other Tests _ | | -1 :x: | unit | 3m 49s | root in the patch failed. | | | | 31m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3105 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 81c5066c8275 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 1d3ea38f1e | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-root.txt | | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-root.txt | | shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk8-hadoop2-check/output/patch-javadoc-root.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk8-hadoop2-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk8-hadoop2-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-wal.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/testReport/ | | Max. process+thread count | 659 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-coprocessor hbase-hadoop-compat hbase-hadoop2-compat . hbase-client hbase-endpoint hbase-mapreduce hbase-server hbase-wal U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-25558) Adding audit log for execMasterService
[
https://issues.apache.org/jira/browse/HBASE-25558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312772#comment-17312772
]
Michael Stack edited comment on HBASE-25558 at 3/31/21, 11:18 PM:
--
Thank you for the improvement [~xiaoheipangzi] Merged to branch-2.4+
was (Author: stack):
Thank you for the improvement [~xiaoheipangzi]
> Adding audit log for execMasterService
> --
>
> Key: HBASE-25558
> URL: https://issues.apache.org/jira/browse/HBASE-25558
> Project: HBase
> Issue Type: Improvement
>Reporter: lujie
>Assignee: lujie
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.3
>
>
> Hi:
> I have found that in APIs, like execProcedure and execProcedureWithRet, have
> audit log to record who execute the master service. The log can be like:
> {code:java}
> LOG.info(master.getClientIdAuditPrefix() + " procedure request for: " +
> desc.getSignature());
> {code}
> But it seems that we forget to audit execMasterService. We should add one.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-25558) Adding audit log for execMasterService
[
https://issues.apache.org/jira/browse/HBASE-25558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack resolved HBASE-25558.
---
Fix Version/s: 2.4.3
2.5.0
3.0.0-alpha-1
Hadoop Flags: Reviewed
Resolution: Fixed
Thank you for the improvement [~xiaoheipangzi]
> Adding audit log for execMasterService
> --
>
> Key: HBASE-25558
> URL: https://issues.apache.org/jira/browse/HBASE-25558
> Project: HBase
> Issue Type: Improvement
>Reporter: lujie
>Assignee: lujie
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.3
>
>
> Hi:
> I have found that in APIs, like execProcedure and execProcedureWithRet, have
> audit log to record who execute the master service. The log can be like:
> {code:java}
> LOG.info(master.getClientIdAuditPrefix() + " procedure request for: " +
> desc.getSignature());
> {code}
> But it seems that we forget to audit execMasterService. We should add one.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] saintstack merged pull request #3101: HBASE-25558:Adding audit log for execMasterService
saintstack merged pull request #3101: URL: https://github.com/apache/hbase/pull/3101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #3105: HBASE-25713 Make an hbase-wal module
saintstack commented on pull request #3105: URL: https://github.com/apache/hbase/pull/3105#issuecomment-811522147 I wrote a note up in the JIRA. I don't this experiment is going to go any further. Will close it out as unable to break out enough of hbase-coprocessor to call the module hbase-coprocessor and ditto for hbase-wal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25713) Make an hbase-wal module
[
https://issues.apache.org/jira/browse/HBASE-25713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312764#comment-17312764
]
Michael Stack commented on HBASE-25713:
---
I pushed up my latest changes to the branch and updated the PR. I think this
experiment is done. See below for what I was able to break out for an
hbase-coprocessor and hbase-wal module. Neither is coherent enough to earn
their names
hbase-coprocessor has a few of the base classes in it only and no tests to
speak of:
{{hbase-coprocessor/src/test/java/org/apache/hadoop/hbase/coprocessor/TestReadOnlyConfiguration.java
hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/CoprocessorEnvironment.java
hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseEnvironment.java
hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/MetricsCoprocessor.java
hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/ObserverContext.java
hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/ObserverContextImpl.java
hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/CoreCoprocessor.java
hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/ReadOnlyConfiguration.java
hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/Coprocessor.java}}
Can't move anything else because needs internals context.
For the hbase-wal, I was not able to move an actual implementation. They are
too entwined in rpc and region. Here is what I was able to break out:
{{hbase-wal/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestMetricsWAL.java
hbase-wal/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestMetricsWALSource.java
hbase-wal/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestCustomWALCellCodec.java
hbase-wal/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestMetricsWALSourceImpl.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/wal/WALProvider.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/wal/WALKey.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/wal/WALKeyImpl.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/wal/DisabledWALProvider.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/wal/WAL.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/wal/WALEdit.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/coprocessor/WALCoprocessorEnvironment.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/coprocessor/WALCoprocessor.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/coprocessor/WALObserver.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FailedLogCloseException.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/regionserver/wal/MetricsWAL.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALActionsListener.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/regionserver/wal/MetricsWALSource.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/regionserver/wal/DamagedWALException.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/regionserver/wal/MetricsWALSourceImpl.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/regionserver/SequenceId.java
hbase-wal/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALFileLengthProvider.java}}
Its not enough I think for the module to be called the hbase-wal module.
> Make an hbase-wal module
>
>
> Key: HBASE-25713
> URL: https://issues.apache.org/jira/browse/HBASE-25713
> Project: HBase
> Issue Type: Sub-task
>Reporter: Michael Stack
>Priority: Major
>
> Extract an hbase-wal module upon which hbase-server can depend; makes
> hbase-server smaller and maybe we could do an hbase-wal standalone... This is
> an experiment.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3113: HBASE-25640 Support hbase rpc compression for remote rpc only
Apache-HBase commented on pull request #3113: URL: https://github.com/apache/hbase/pull/3113#issuecomment-811497779 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 19s | master passed | | +1 :green_heart: | compile | 0m 58s | master passed | | +1 :green_heart: | checkstyle | 0m 28s | master passed | | +1 :green_heart: | spotbugs | 1m 3s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 58s | the patch passed | | +1 :green_heart: | compile | 0m 53s | the patch passed | | +1 :green_heart: | javac | 0m 53s | the patch passed | | -0 :warning: | checkstyle | 0m 26s | hbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 19m 46s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 1m 12s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 42m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3113/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3113 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9c01c0b537d5 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 024248994f | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3113/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt | | Max. process+thread count | 86 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3113/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3113: HBASE-25640 Support hbase rpc compression for remote rpc only
Apache-HBase commented on pull request #3113: URL: https://github.com/apache/hbase/pull/3113#issuecomment-811492729 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 18s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 47s | master passed | | +1 :green_heart: | compile | 0m 31s | master passed | | +1 :green_heart: | shadedjars | 8m 34s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 30s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 42s | the patch passed | | +1 :green_heart: | compile | 0m 33s | the patch passed | | +1 :green_heart: | javac | 0m 33s | the patch passed | | +1 :green_heart: | shadedjars | 8m 40s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 28s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 21s | hbase-client in the patch passed. | | | | 32m 44s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3113/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3113 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 187c557ce316 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 024248994f | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3113/1/testReport/ | | Max. process+thread count | 298 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3113/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3113: HBASE-25640 Support hbase rpc compression for remote rpc only
Apache-HBase commented on pull request #3113: URL: https://github.com/apache/hbase/pull/3113#issuecomment-811490051 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 58s | master passed | | +1 :green_heart: | compile | 0m 26s | master passed | | +1 :green_heart: | shadedjars | 7m 39s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 41s | the patch passed | | +1 :green_heart: | compile | 0m 26s | the patch passed | | +1 :green_heart: | javac | 0m 26s | the patch passed | | +1 :green_heart: | shadedjars | 7m 37s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 12s | hbase-client in the patch passed. | | | | 27m 28s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3113/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3113 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2cc05d3d31b2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 024248994f | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3113/1/testReport/ | | Max. process+thread count | 335 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3113/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] huaxiangsun opened a new pull request #3113: HBASE-25640 Support hbase rpc compression for remote rpc only
huaxiangsun opened a new pull request #3113: URL: https://github.com/apache/hbase/pull/3113 I did manual test to make sure this change works, it is hard to put up a unittest for this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-22078) corrupted procs in proc WAL
[
https://issues.apache.org/jira/browse/HBASE-22078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Elser resolved HBASE-22078.
Resolution: Incomplete
Goin' looking at missing stacks for an instance I've just run into. Came across
this -- expect it to not go anywhere after 2 years and no logs.
> corrupted procs in proc WAL
> ---
>
> Key: HBASE-22078
> URL: https://issues.apache.org/jira/browse/HBASE-22078
> Project: HBase
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Priority: Major
>
> Not sure what the root cause is... there are ~500 proc wal files (I actually
> wonder if cleanup is also blocked by this, since I see these lines on master
> restart, do WALs with abandoned procedures like that get deleted?).
> {noformat}
> 2019-03-20 07:37:53,212 ERROR [master/...:17000:becomeActiveMaster]
> wal.WALProcedureTree: Missing stack id 7571, max stack id is 7754, root
> procedure is Procedure(pid=66829, ppid=-1,
> class=org.apache.hadoop.hbase.master.procedure.DisableTableProcedure)
> 2019-03-20 07:37:53,213 ERROR [master/...:17000:becomeActiveMaster]
> wal.WALProcedureTree: Missing stack id 7600, max stack id is 7754, root
> procedure is Procedure(pid=66829, ppid=-1,
> class=org.apache.hadoop.hbase.master.procedure.DisableTableProcedure)
> 2019-03-20 07:37:53,213 ERROR [master/...:17000:becomeActiveMaster]
> wal.WALProcedureTree: Missing stack id 7610, max stack id is 7754, root
> procedure is Procedure(pid=66829, ppid=-1,
> class=org.apache.hadoop.hbase.master.procedure.DisableTableProcedure)
> 2019-03-20 07:37:53,213 ERROR [master/...:17000:becomeActiveMaster]
> wal.WALProcedureTree: Missing stack id 7631, max stack id is 7754, root
> procedure is Procedure(pid=66829, ppid=-1,
> class=org.apache.hadoop.hbase.master.procedure.DisableTableProcedure)
> 2019-03-20 07:37:53,213 ERROR [master/...:17000:becomeActiveMaster]
> wal.WALProcedureTree: Missing stack id 7650, max stack id is 7754, root
> procedure is Procedure(pid=66829, ppid=-1,
> class=org.apache.hadoop.hbase.master.procedure.DisableTableProcedure)
> 2019-03-20 07:37:53,213 ERROR [master/...:17000:becomeActiveMaster]
> wal.WALProcedureTree: Missing stack id 7651, max stack id is 7754, root
> procedure is Procedure(pid=66829, ppid=-1,
> class=org.apache.hadoop.hbase.master.procedure.DisableTableProcedure)
> 2019-03-20 07:37:53,213 ERROR [master/...:17000:becomeActiveMaster]
> wal.WALProcedureTree: Missing stack id 7657, max stack id is 7754, root
> procedure is Procedure(pid=66829, ppid=-1,
> class=org.apache.hadoop.hbase.master.procedure.DisableTableProcedure)
> 2019-03-20 07:37:53,213 ERROR [master/...:17000:becomeActiveMaster]
> wal.WALProcedureTree: Missing stack id 7683, max stack id is 7754, root
> procedure is Procedure(pid=66829, ppid=-1,
> class=org.apache.hadoop.hbase.master.procedure.DisableTableProcedure)
> {noformat}
> Followed by
> {noformat}
> 2019-03-20 07:37:53,751 ERROR [master/...:17000:becomeActiveMaster]
> procedure2.ProcedureExecutor: Corrupt pid=66829,
> state=WAITING:DISABLE_TABLE_ADD_REPLICATION_BARRIER, hasLock=false;
> DisableTableProcedure table=...
> {noformat}
> And 1000s of child procedures and grandchild procedures of this procedure.
> I think this area needs general review... we should have a record for the
> procedure durably persisted before we create any child procedures, so I'm not
> sure how this could happen. Actually, I also wonder why we even have separate
> proc WAL when HBase already has a working WAL that's more or less time
> tested...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25703) Support conditional update in MultiRowMutationEndpoint
[
https://issues.apache.org/jira/browse/HBASE-25703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312599#comment-17312599
]
Hudson commented on HBASE-25703:
Results for branch branch-2
[build #215 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/215/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/215/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/215/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/215/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/215/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Support conditional update in MultiRowMutationEndpoint
> --
>
> Key: HBASE-25703
> URL: https://issues.apache.org/jira/browse/HBASE-25703
> Project: HBase
> Issue Type: Improvement
> Components: Coprocessors
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.3
>
>
> In some use cases, I think it will be useful that we can perform conditional
> update in MultiRowMutationEndpoint. In this Jira, we can add support
> conditional update in MultiRowMutationEndpoint.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] virajjasani commented on a change in pull request #3105: HBASE-25713 Make an hbase-wal module
virajjasani commented on a change in pull request #3105: URL: https://github.com/apache/hbase/pull/3105#discussion_r605054619 ## File path: hbase-client/pom.xml ## @@ -72,6 +72,10 @@ test-jar test + Review comment: > We depend on hbase-wal in hbase-client JUST because of FailedLogCloseException... I'll probably undo this dependency in a later version. Oh, that's better than expected. Good to know. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #3105: HBASE-25713 Make an hbase-wal module
saintstack commented on pull request #3105: URL: https://github.com/apache/hbase/pull/3105#issuecomment-811170552 Thanks for taking a look @virajjasani -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on a change in pull request #3105: HBASE-25713 Make an hbase-wal module
saintstack commented on a change in pull request #3105: URL: https://github.com/apache/hbase/pull/3105#discussion_r605013678 ## File path: hbase-client/pom.xml ## @@ -72,6 +72,10 @@ test-jar test + Review comment: I'll be back here. Its an odd one. We depend on hbase-wal in hbase-client JUST because of FailedLogCloseException... I'll probably undo this dependency in a later version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on a change in pull request #3105: HBASE-25713 Make an hbase-wal module
saintstack commented on a change in pull request #3105:
URL: https://github.com/apache/hbase/pull/3105#discussion_r605012266
##
File path:
hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/ObserverContextImpl.java
##
@@ -87,19 +89,5 @@ public boolean shouldBypass() {
return Optional.ofNullable(caller);
}
- /**
- * Instantiates a new ObserverContext instance if the passed reference is
null and
- * sets the environment in the new or existing instance. This allows
deferring the instantiation
- * of a ObserverContext until it is actually needed.
- * @param The environment type for the context
- * @param env The coprocessor environment to set
- * @return An instance of ObserverContext with the environment
set
- */
- @Deprecated
Review comment:
Sorry for confusion @virajjasani ... This exploratory work is against
branch-2 but target is master branch. We cannot remove these methods as you
suggest in branch-2 but we could in master. Odd is that these methods are
deprecated but without an alternative I need to provide something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #3105: HBASE-25713 Make an hbase-wal module
saintstack commented on pull request #3105: URL: https://github.com/apache/hbase/pull/3105#issuecomment-811166582 @Apache9 Hey. Here is what I wrote in the JIRA description: "Extract an hbase-wal module upon which hbase-server can depend; makes hbase-server smaller and maybe we could do an hbase-wal standalone... This is an experiment." I'm trying to see how far I can get extracting WAL from hbase-server. So far, it looks like I need to pull out the basic hbase-coprocessor classes too into their own module. Was trying to shrink hbase-server size. Also trying to make WAL more distinct such that it could live apart from the rest of HBase. At least the basic classes and Interfaces can be extracted. Will see how much further I can get. Thanks for taking a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #3105: HBASE-25713 Make an hbase-wal module
saintstack commented on pull request #3105: URL: https://github.com/apache/hbase/pull/3105#issuecomment-811167368 To clarify, I'm doing this exploratory work on a branch against branch-2 but when comes time to put up a branch, will do it against master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani edited a comment on pull request #3108: HBASE-25717 RegionServer aborted with due to ClassCastException
virajjasani edited a comment on pull request #3108: URL: https://github.com/apache/hbase/pull/3108#issuecomment-810900300 +1 for code change, is there anyways we can add test? If we can produce CCE not happening with some looping of concurrent addition and removal of metrics from the set, that should be good enough? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3112: HBASE-25696 Need to initialize SLF4JBridgeHandler in jul-to-slf4j for…
Apache-HBase commented on pull request #3112: URL: https://github.com/apache/hbase/pull/3112#issuecomment-811040655 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 58s | branch-2 passed | | +1 :green_heart: | compile | 2m 25s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 38s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 56s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 37s | the patch passed | | +1 :green_heart: | compile | 2m 26s | the patch passed | | +1 :green_heart: | javac | 2m 26s | the patch passed | | +1 :green_heart: | shadedjars | 6m 41s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 57s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 327m 16s | root in the patch failed. | | | | 363m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3112 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 88280710573e 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 1d3ea38f1e | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/1/testReport/ | | Max. process+thread count | 2324 (vs. ulimit of 12500) | | modules | C: hbase-logging hbase-common . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3111: HBASE-25716 The configured loggers in log4j2.xml will always be created
Apache-HBase commented on pull request #3111: URL: https://github.com/apache/hbase/pull/3111#issuecomment-811021560 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 47s | master passed | | +1 :green_heart: | javadoc | 2m 37s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 33s | the patch passed | | +1 :green_heart: | javadoc | 2m 38s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 346m 50s | root in the patch failed. | | | | 364m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3111/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3111 | | Optional Tests | javac javadoc unit | | uname | Linux 2ccea1430f78 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 024248994f | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3111/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3111/1/testReport/ | | Max. process+thread count | 6977 (vs. ulimit of 3) | | modules | C: hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3111/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-25720) Sync WAL stuck when prepare flush cache will prevent flush cache and cause OOM
Xiaolin Ha created HBASE-25720: -- Summary: Sync WAL stuck when prepare flush cache will prevent flush cache and cause OOM Key: HBASE-25720 URL: https://issues.apache.org/jira/browse/HBASE-25720 Project: HBase Issue Type: Improvement Affects Versions: 1.4.13 Reporter: Xiaolin Ha Assignee: Xiaolin Ha Attachments: prepare-flush-cache-stuck.png We call HRegion#doSyncOfUnflushedWALChanges when preparing to flush cache. But this WAL sync may stuck, and abort the flush of cache. !prepare-flush-cache-stuck.png|width=519,height=246! If we cannot aware of this problem in time, RS will OOM kill. I think we should force abort RS when sync stuck in preparing, like in committing snapshots. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3112: HBASE-25696 Need to initialize SLF4JBridgeHandler in jul-to-slf4j for…
Apache-HBase commented on pull request #3112: URL: https://github.com/apache/hbase/pull/3112#issuecomment-810991848 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 18s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 47s | branch-2 passed | | +1 :green_heart: | compile | 3m 6s | branch-2 passed | | +1 :green_heart: | shadedjars | 7m 34s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 44s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 26s | the patch passed | | +1 :green_heart: | compile | 3m 2s | the patch passed | | +1 :green_heart: | javac | 3m 2s | the patch passed | | +1 :green_heart: | shadedjars | 7m 31s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 37s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 243m 13s | root in the patch failed. | | | | 285m 42s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3112 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 5c73d87feb29 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 1d3ea38f1e | | Default Java | AdoptOpenJDK-11.0.10+9 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/1/testReport/ | | Max. process+thread count | 4202 (vs. ulimit of 12500) | | modules | C: hbase-logging hbase-common . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ZhaoBQ commented on pull request #3080: HBASE-25682 Add a new command to update the configuration of all RSs in a RSGroup
ZhaoBQ commented on pull request #3080: URL: https://github.com/apache/hbase/pull/3080#issuecomment-810946716 Thanks for review @pankaj72981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-25701) RegionServer JVM crash when append wal entry
[ https://issues.apache.org/jira/browse/HBASE-25701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312243#comment-17312243 ] Juanjuan Tian edited comment on HBASE-25701 at 3/31/21, 9:50 AM: -- [~anoop.hbase] I don't think they are same case, since I'm using habse 2.2.6 version which is already with fix from HBASE-22539, but issue still happen when append wal Entry was (Author: jutia): [~anoop.hbase] I don't think they are same case, since I'm using habse 2.2.6 version which is already with fix from HBASE-22539, but issue still happen when appendEntry > RegionServer JVM crash when append wal entry > > > Key: HBASE-25701 > URL: https://issues.apache.org/jira/browse/HBASE-25701 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.2.6 >Reporter: Juanjuan Tian >Priority: Major > > Region Server JVM crash when append wal entry, JVM crash log: > # > # A fatal error has been detected by the Java Runtime Environment: > # > # EXCEPTION_ACCESS_VIOLATION (0xc005) at pc=0x027af93f, > pid=17992, tid=0x2d54 > # > # JRE version: Java(TM) SE Runtime Environment (8.0_202-b08) (build > 1.8.0_202-b08) > # Java VM: Java HotSpot(TM) 64-Bit Server VM (25.202-b08 mixed mode > windows-amd64 compressed oops) > # Problematic frame: > # J 10214 C2 org.apache.hadoop.hbase.ByteBufferKeyValue.getFamilyLength()B (9 > bytes) @ 0x027af93f [0x027af860+0xdf] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25701) RegionServer JVM crash when append wal entry
[ https://issues.apache.org/jira/browse/HBASE-25701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312243#comment-17312243 ] Juanjuan Tian commented on HBASE-25701: [~anoop.hbase] I don't think they are same case, since I'm using habse 2.2.6 version which is already with fix from HBASE-22539, but issue still happen when appendEntry > RegionServer JVM crash when append wal entry > > > Key: HBASE-25701 > URL: https://issues.apache.org/jira/browse/HBASE-25701 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.2.6 >Reporter: Juanjuan Tian >Priority: Major > > Region Server JVM crash when append wal entry, JVM crash log: > # > # A fatal error has been detected by the Java Runtime Environment: > # > # EXCEPTION_ACCESS_VIOLATION (0xc005) at pc=0x027af93f, > pid=17992, tid=0x2d54 > # > # JRE version: Java(TM) SE Runtime Environment (8.0_202-b08) (build > 1.8.0_202-b08) > # Java VM: Java HotSpot(TM) 64-Bit Server VM (25.202-b08 mixed mode > windows-amd64 compressed oops) > # Problematic frame: > # J 10214 C2 org.apache.hadoop.hbase.ByteBufferKeyValue.getFamilyLength()B (9 > bytes) @ 0x027af93f [0x027af860+0xdf] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25703) Support conditional update in MultiRowMutationEndpoint
[
https://issues.apache.org/jira/browse/HBASE-25703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312223#comment-17312223
]
Hudson commented on HBASE-25703:
Results for branch branch-2.4
[build #85 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/85/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/85/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/85/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/85/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/85/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Support conditional update in MultiRowMutationEndpoint
> --
>
> Key: HBASE-25703
> URL: https://issues.apache.org/jira/browse/HBASE-25703
> Project: HBase
> Issue Type: Improvement
> Components: Coprocessors
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.3
>
>
> In some use cases, I think it will be useful that we can perform conditional
> update in MultiRowMutationEndpoint. In this Jira, we can add support
> conditional update in MultiRowMutationEndpoint.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25692) Failure to instantiate WALCellCodec leaks socket in replication
[
https://issues.apache.org/jira/browse/HBASE-25692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1731#comment-1731
]
Hudson commented on HBASE-25692:
Results for branch branch-2.4
[build #85 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/85/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/85/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/85/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/85/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/85/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Failure to instantiate WALCellCodec leaks socket in replication
> ---
>
> Key: HBASE-25692
> URL: https://issues.apache.org/jira/browse/HBASE-25692
> Project: HBase
> Issue Type: Bug
> Components: Replication
>Affects Versions: 2.1.0, 2.2.0, 2.1.1, 2.1.2, 2.1.3, 2.3.0, 2.3.1, 2.1.4,
> 2.0.6, 2.1.5, 2.2.1, 2.1.6, 2.1.7, 2.2.2, 2.1.8, 2.2.3, 2.3.3, 2.1.9, 2.2.4,
> 2.4.0, 2.2.5, 2.2.6, 2.3.2, 2.3.4, 2.4.1, 2.4.2
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.2.7, 2.5.0, 2.4.3, 2.3.6
>
>
> I was looking at an HBase user's cluster with [~danilocop] where they saw two
> otherwise identical clusters where one of them was regularly had sockets in
> CLOSE_WAIT going from RegionServers to a distributed storage appliance.
> After a lot of analysis, we eventually figured out that these sockets in
> CLOSE_WAIT were directly related to an FSDataInputStream which we forgot to
> close inside of the RegionServer. The subtlety was that only one of these
> HBase clusters was set up to do replication (to the other cluster). The HBase
> cluster experiencing this problem was shipping edits to a peer, and had
> previously been using Phoenix. At some point, the cluster had Phoenix removed
> from it.
> What we found was that replication still had WALs to ship which were for
> Phoenix tables. Phoenix, in this version, still used the custom WALCellCodec;
> however, this codec class was missing from the RS classpath after the owner
> of the cluster removed Phoenix.
> When we try to instantiate the Codec implementation via ReflectionUtils, we
> end up throwing an UnsupportedOperationException which wraps a
> NoClassDefFoundException. However, in WALFactory, we _only_ close the
> FSDataInputStream when we catch an IOException.
> Thus, replication sits in a "fast" loop, trying to ship these edits, each
> time leaking a new socket because of the InputStream not being closed. There
> is an obvious workaround for this specific issue, but we should not leak this
> inside HBase.
> Approximate, 2.1.x stack trace which lead us to this is below.
> {noformat}
> 2021-03-11 18:19:20,364 ERROR
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader:
> Failed to read stream of replication entries
> java.io.IOException: Cannot get log reader
> at
> org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:366)
> at
> org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:303)
> at
> org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:291)
> at
> org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:427)
> at
> org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.openReader(WALEntryStream.java:354)
> at
> org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.openNextLog(WALEntryStream.java:302)
> at
> org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.checkReader(WALEntryStream.java:293)
> at
> org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:174)
> at
> org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:100)
> at
>
[GitHub] [hbase] Apache-HBase commented on pull request #3111: HBASE-25716 The configured loggers in log4j2.xml will always be created
Apache-HBase commented on pull request #3111: URL: https://github.com/apache/hbase/pull/3111#issuecomment-810918092 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 27s | master passed | | +1 :green_heart: | javadoc | 3m 13s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 7s | the patch passed | | +1 :green_heart: | javadoc | 3m 21s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 175m 1s | root in the patch failed. | | | | 194m 54s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3111/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3111 | | Optional Tests | javac javadoc unit | | uname | Linux a492283ae459 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 024248994f | | Default Java | AdoptOpenJDK-11.0.10+9 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3111/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3111/1/testReport/ | | Max. process+thread count | 6593 (vs. ulimit of 3) | | modules | C: hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3111/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani edited a comment on pull request #3108: HBASE-25717 RegionServer aborted with due to ClassCastException
virajjasani edited a comment on pull request #3108: URL: https://github.com/apache/hbase/pull/3108#issuecomment-810900300 +1 for code change, is there anyways we can add test? Test might not necessarily have to abort RegionServer for the exact same reason but even if we can produce CCE not happening with concurrent addition and removal of metrics, that should be good enough? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #3108: HBASE-25717 RegionServer aborted with due to ClassCastException
virajjasani commented on pull request #3108: URL: https://github.com/apache/hbase/pull/3108#issuecomment-810900300 +1 for code change, is there anyways we can add test? Test might not necessarily have to abort RegionServer for the exact same reason but even if we can produce CCE, that should be good enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #3105: HBASE-25713 Make an hbase-wal module
Apache9 commented on pull request #3105: URL: https://github.com/apache/hbase/pull/3105#issuecomment-810858972 Mind explain the plan first? I guess the problem here is that the WAL implementation may depend on some HRegion stuff, and yes coprocessor could be a problem if in the implementation we need to call something like CoprocessorHost. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3112: HBASE-25696 Need to initialize SLF4JBridgeHandler in jul-to-slf4j for…
Apache-HBase commented on pull request #3112: URL: https://github.com/apache/hbase/pull/3112#issuecomment-810858940 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 36s | branch-2 passed | | +1 :green_heart: | compile | 8m 41s | branch-2 passed | | +1 :green_heart: | checkstyle | 2m 1s | branch-2 passed | | +1 :green_heart: | spotbugs | 9m 11s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 19s | the patch passed | | +1 :green_heart: | compile | 8m 56s | the patch passed | | +1 :green_heart: | javac | 8m 56s | the patch passed | | +1 :green_heart: | checkstyle | 2m 1s | the patch passed | | +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 12m 25s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 9m 45s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 41s | The patch does not generate ASF License warnings. | | | | 70m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3112 | | Optional Tests | dupname asflicense shellcheck shelldocs javac spotbugs hadoopcheck hbaseanti checkstyle compile xml | | uname | Linux 9af980777e1d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 1d3ea38f1e | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 141 (vs. ulimit of 12500) | | modules | C: hbase-logging hbase-common . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3112/1/console | | versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #2543: HBASE-25184 Move RegionLocationFinder to hbase-balancer
Apache9 commented on pull request #2543: URL: https://github.com/apache/hbase/pull/2543#issuecomment-810857096 Oh, forget this one. Any other concerns? @saintstack Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 opened a new pull request #3112: HBASE-25696 Need to initialize SLF4JBridgeHandler in jul-to-slf4j for…
Apache9 opened a new pull request #3112: URL: https://github.com/apache/hbase/pull/3112 … redirecting jul to slf4j (#3093) Signed-off-by: Michael Stack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25696) Need to initialize SLF4JBridgeHandler in jul-to-slf4j for redirecting jul to slf4j
[
https://issues.apache.org/jira/browse/HBASE-25696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312112#comment-17312112
]
Hudson commented on HBASE-25696:
Results for branch master
[build #251 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/251/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/251/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/251/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/251/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Need to initialize SLF4JBridgeHandler in jul-to-slf4j for redirecting jul to
> slf4j
> --
>
> Key: HBASE-25696
> URL: https://issues.apache.org/jira/browse/HBASE-25696
> Project: HBase
> Issue Type: Sub-task
> Components: logging
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> When testing HBASE-22120 with logging exporter, the trace log messages were
> all redirected to console...
> They use jul to log the spans and we have jul-to-slf4j on classpath.
> Then I found out that we need to call SLF4JBridgeHandler.install...
> Let me find a way to do this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3111: HBASE-25716 The configured loggers in log4j2.xml will always be created
Apache-HBase commented on pull request #3111: URL: https://github.com/apache/hbase/pull/3111#issuecomment-810805652 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 16s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 36s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 4s | The patch has no ill-formed XML file. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 51s | The patch does not generate ASF License warnings. | | | | 13m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3111/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3111 | | Optional Tests | dupname asflicense xml javac | | uname | Linux 11f18f81f1eb 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 024248994f | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 65 (vs. ulimit of 3) | | modules | C: hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3111/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 opened a new pull request #3111: HBASE-25716 The configured loggers in log4j2.xml will always be created
Apache9 opened a new pull request #3111: URL: https://github.com/apache/hbase/pull/3111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
