[GitHub] [hbase] Apache-HBase commented on pull request #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #251: URL: https://github.com/apache/hbase/pull/251#issuecomment-865595259 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s

[GitHub] [hbase] Apache-HBase commented on pull request #3352: HBASE-25913 Introduce EnvironmentEdge.Clock and Clock.currentTimeAdvancing

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3352: URL: https://github.com/apache/hbase/pull/3352#issuecomment-865576313 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] YutSean opened a new pull request #3410: HBASE-26013 Get operations readRows metrics becomes zero after HBASE-25677

2021-06-21 Thread GitBox
YutSean opened a new pull request #3410: URL: https://github.com/apache/hbase/pull/3410 https://issues.apache.org/jira/browse/HBASE-26013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (HBASE-26021) HBase 1.7 to 2.4 upgrade issue

2021-06-21 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367001#comment-17367001 ] Anoop Sam John commented on HBASE-26021: Specific to 2.4.x upgrade? Did u check with 2.3.x? >

[GitHub] [hbase] Apache-HBase commented on pull request #3360: HBASE-25975 Row Commit Sequencer

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3360: URL: https://github.com/apache/hbase/pull/3360#issuecomment-865513770 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3360: HBASE-25975 Row Commit Sequencer

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3360: URL: https://github.com/apache/hbase/pull/3360#issuecomment-865508830 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Reidddddd merged pull request #3404: HBASE-26013 Get operations readRows metrics becomes zero after HBASE-25677

2021-06-21 Thread GitBox
Reidd merged pull request #3404: URL: https://github.com/apache/hbase/pull/3404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (HBASE-26013) Get operations readRows metrics becomes zero after HBASE-25677

2021-06-21 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366987#comment-17366987 ] Reid Chan commented on HBASE-26013: --- Can you provide patches for other branches? thx > Get operations

[jira] [Updated] (HBASE-21674) Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-06-21 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21674: -- Component/s: Thrift > Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from >

[jira] [Resolved] (HBASE-21674) Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-06-21 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-21674. --- Hadoop Flags: Reviewed Resolution: Resolved > Port HBASE-21652 (Refactor ThriftServer making

[jira] [Commented] (HBASE-21674) Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-06-21 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366977#comment-17366977 ] Reid Chan commented on HBASE-21674: --- Merged. Great efforts, thanks [~xytss123] > Port HBASE-21652

[jira] [Updated] (HBASE-21674) Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-06-21 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21674: -- Fix Version/s: (was: 1.8.0) 1.7.1 > Port HBASE-21652 (Refactor ThriftServer

[GitHub] [hbase] Reidddddd merged pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-06-21 Thread GitBox
Reidd merged pull request #2941: URL: https://github.com/apache/hbase/pull/2941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (HBASE-25698) Persistent IllegalReferenceCountException at scanner open when using TinyLfuBlockCache

2021-06-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366962#comment-17366962 ] Hudson commented on HBASE-25698: Results for branch branch-2.4 [build #147 on

[jira] [Commented] (HBASE-25992) Polish the ReplicationSourceWALReader code for 2.x after HBASE-25596

2021-06-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366964#comment-17366964 ] Hudson commented on HBASE-25992: Results for branch branch-2.4 [build #147 on

[jira] [Commented] (HBASE-26001) When turn on access control, the cell level TTL of Increment and Append operations is invalid.

2021-06-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366963#comment-17366963 ] Hudson commented on HBASE-26001: Results for branch branch-2.4 [build #147 on

[jira] [Commented] (HBASE-26021) HBase 1.7 to 2.4 upgrade issue

2021-06-21 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366953#comment-17366953 ] Reid Chan commented on HBASE-26021: --- Thanks [~vjasani] for raising this issue! > HBase 1.7 to 2.4

[GitHub] [hbase] Apache-HBase commented on pull request #3352: HBASE-25913 Introduce EnvironmentEdge.Clock and Clock.currentTimeAdvancing

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3352: URL: https://github.com/apache/hbase/pull/3352#issuecomment-865464340 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3360: HBASE-25975 Row Commit Sequencer

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3360: URL: https://github.com/apache/hbase/pull/3360#issuecomment-865461147 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] ndimiduk commented on a change in pull request #3396: HBASE-26010 Backport HBASE-25703 and HBASE-26002 to branch-2.3

2021-06-21 Thread GitBox
ndimiduk commented on a change in pull request #3396: URL: https://github.com/apache/hbase/pull/3396#discussion_r655805429 ## File path: hbase-protocol/src/main/protobuf/MultiRowMutation.proto ## @@ -37,9 +37,11 @@ message MutateRowsRequest { optional uint64 nonce_group =

[GitHub] [hbase] ndimiduk commented on pull request #3396: HBASE-26010 Backport HBASE-25703 and HBASE-26002 to branch-2.3

2021-06-21 Thread GitBox
ndimiduk commented on pull request #3396: URL: https://github.com/apache/hbase/pull/3396#issuecomment-865448897 I'm nervous to make non-bug-fix changes on patch releases, especially because, to the best of my knowledge, the `MultiRowMutationEndpoint` is an "undocumented/internal"

[GitHub] [hbase] ndimiduk commented on pull request #3396: HBASE-26010 Backport HBASE-25703 and HBASE-26002 to branch-2.3

2021-06-21 Thread GitBox
ndimiduk commented on pull request #3396: URL: https://github.com/apache/hbase/pull/3396#issuecomment-865447040 I prefer that we reopen the original jiras and backport them one-by-one. The reason being that it's easier to tell directly if a JIRA has been applied to a branch. "One JIRA,

[GitHub] [hbase] ndimiduk commented on a change in pull request #3395: HBASE-26009 Backport HBASE-25766 "Introduce RegionSplitRestriction that restricts the pattern of the split point" to branch-2.3

2021-06-21 Thread GitBox
ndimiduk commented on a change in pull request #3395: URL: https://github.com/apache/hbase/pull/3395#discussion_r655802538 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DelimitedKeyPrefixRegionSplitPolicy.java ## @@ -37,7 +37,11 @@ *

[GitHub] [hbase] ndimiduk commented on pull request #3395: HBASE-26009 Backport HBASE-25766 "Introduce RegionSplitRestriction that restricts the pattern of the split point" to branch-2.3

2021-06-21 Thread GitBox
ndimiduk commented on pull request #3395: URL: https://github.com/apache/hbase/pull/3395#issuecomment-865443807 I personally think this cannot be applied to any patch release. It introduces a new table configuration, which may cause problems during a rollback. What are the "Server-Server"

[jira] [Comment Edited] (HBASE-25975) Row commit sequencer

2021-06-21 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366919#comment-17366919 ] Andrew Kyle Purtell edited comment on HBASE-25975 at 6/22/21, 1:01 AM:

[jira] [Commented] (HBASE-25975) Row commit sequencer

2021-06-21 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366919#comment-17366919 ] Andrew Kyle Purtell commented on HBASE-25975: - As of version 90bf60d7: - Reduced time under

[GitHub] [hbase] brfrn169 commented on pull request #3395: HBASE-26009 Backport HBASE-25766 "Introduce RegionSplitRestriction that restricts the pattern of the split point" to branch-2.3

2021-06-21 Thread GitBox
brfrn169 commented on pull request #3395: URL: https://github.com/apache/hbase/pull/3395#issuecomment-865434495 This may be a new feature but it doesn't break any compatibilities. So I thought we could put it into the next 2.3.x release. What do you guys think? Thanks. -- This is an

[GitHub] [hbase] z-york commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-21 Thread GitBox
z-york commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r655784451 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DirectInStoreCompactor.java ## @@ -0,0 +1,90 @@ +/** + * Licensed

[GitHub] [hbase] Apache-HBase commented on pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3389: URL: https://github.com/apache/hbase/pull/3389#issuecomment-865421394 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3389: URL: https://github.com/apache/hbase/pull/3389#issuecomment-865393014 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3407: HBASE-26018. Perf improvement in L1 cache

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3407: URL: https://github.com/apache/hbase/pull/3407#issuecomment-865353410 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3407: HBASE-26018. Perf improvement in L1 cache

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3407: URL: https://github.com/apache/hbase/pull/3407#issuecomment-865349287 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3389: URL: https://github.com/apache/hbase/pull/3389#issuecomment-865329254 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3409: HBASE-26020 Split TestWALEntryStream.testDifferentCounts out

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3409: URL: https://github.com/apache/hbase/pull/3409#issuecomment-865313093 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3409: HBASE-26020 Split TestWALEntryStream.testDifferentCounts out

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3409: URL: https://github.com/apache/hbase/pull/3409#issuecomment-865310944 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] clarax commented on pull request #3356: HBASE-25973 Balancer should explain progress in a better way in log

2021-06-21 Thread GitBox
clarax commented on pull request #3356: URL: https://github.com/apache/hbase/pull/3356#issuecomment-865302988 Any more concerns? @busbey @saintstack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] vli02 commented on pull request #3402: HBASE-25130 - Fix master in-memory server holding map after:

2021-06-21 Thread GitBox
vli02 commented on pull request #3402: URL: https://github.com/apache/hbase/pull/3402#issuecomment-865300183 @virajjasani @apurtell Can you please help review and merge this if everything looks good? thanks! -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HBASE-26021) HBase 1.7 to 2.4 upgrade issue

2021-06-21 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366812#comment-17366812 ] Viraj Jasani commented on HBASE-26021: -- The above Exception comes up regardless of the upgrade

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-21 Thread GitBox
wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r655657711 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestDefaultCompactor.java ## @@ -0,0 +1,123 @@ +/** + *

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-21 Thread GitBox
wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r655657218 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -533,4 +549,46 @@ protected

[jira] [Created] (HBASE-26021) HBase 1.7 to 2.4 upgrade issue

2021-06-21 Thread Viraj Jasani (Jira)
Viraj Jasani created HBASE-26021: Summary: HBase 1.7 to 2.4 upgrade issue Key: HBASE-26021 URL: https://issues.apache.org/jira/browse/HBASE-26021 Project: HBase Issue Type: Bug Affects

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-21 Thread GitBox
wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r655650248 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -266,6 +266,7 @@ public InternalScanner

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-21 Thread GitBox
wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r655650248 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -266,6 +266,7 @@ public InternalScanner

[GitHub] [hbase] Apache-HBase commented on pull request #3407: HBASE-26018. Perf improvement in L1 cache

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3407: URL: https://github.com/apache/hbase/pull/3407#issuecomment-865279962 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3405: HBASE-26011 Introduce a new API to sync the live region server list m…

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3405: URL: https://github.com/apache/hbase/pull/3405#issuecomment-865277400 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3405: HBASE-26011 Introduce a new API to sync the live region server list m…

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3405: URL: https://github.com/apache/hbase/pull/3405#issuecomment-865274795 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[jira] [Commented] (HBASE-26001) When turn on access control, the cell level TTL of Increment and Append operations is invalid.

2021-06-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366771#comment-17366771 ] Hudson commented on HBASE-26001: Results for branch branch-2 [build #282 on

[jira] [Commented] (HBASE-25698) Persistent IllegalReferenceCountException at scanner open when using TinyLfuBlockCache

2021-06-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366772#comment-17366772 ] Hudson commented on HBASE-25698: Results for branch branch-2 [build #282 on

[GitHub] [hbase] Apache-HBase commented on pull request #3407: HBASE-26018. Perf improvement in L1 cache

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3407: URL: https://github.com/apache/hbase/pull/3407#issuecomment-865238770 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3407: HBASE-26018. Perf improvement in L1 cache

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3407: URL: https://github.com/apache/hbase/pull/3407#issuecomment-865236347 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] z-york commented on pull request #2114: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2021-06-21 Thread GitBox
z-york commented on pull request #2114: URL: https://github.com/apache/hbase/pull/2114#issuecomment-865234155 @petersomogyi It's probably worth pinging on https://github.com/apache/hbase/pull/2113 and subsequent PRs as that's where most of the conversation happened. I thought Stephen had

[GitHub] [hbase] Apache-HBase commented on pull request #3405: HBASE-26011 Introduce a new API to sync the live region server list m…

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3405: URL: https://github.com/apache/hbase/pull/3405#issuecomment-865220138 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3409: HBASE-26020 Split TestWALEntryStream.testDifferentCounts out

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3409: URL: https://github.com/apache/hbase/pull/3409#issuecomment-865198406 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] virajjasani commented on a change in pull request #3397: HBASE-26012 Improve logging and dequeue logic in DelayQueue

2021-06-21 Thread GitBox
virajjasani commented on a change in pull request #3397: URL: https://github.com/apache/hbase/pull/3397#discussion_r655538100 ## File path: hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/util/DelayedUtil.java ## @@ -79,7 +84,13 @@ public String toString() {

[jira] [Commented] (HBASE-26001) When turn on access control, the cell level TTL of Increment and Append operations is invalid.

2021-06-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366707#comment-17366707 ] Hudson commented on HBASE-26001: Results for branch branch-2.3 [build #241 on

[jira] [Commented] (HBASE-25698) Persistent IllegalReferenceCountException at scanner open when using TinyLfuBlockCache

2021-06-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366708#comment-17366708 ] Hudson commented on HBASE-25698: Results for branch branch-2.3 [build #241 on

[GitHub] [hbase] Apache9 opened a new pull request #3409: HBASE-26020 Split TestWALEntryStream.testDifferentCounts out

2021-06-21 Thread GitBox
Apache9 opened a new pull request #3409: URL: https://github.com/apache/hbase/pull/3409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Resolved] (HBASE-25992) Polish the ReplicationSourceWALReader code for 2.x after HBASE-25596

2021-06-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25992. --- Resolution: Fixed Pushed an addendum to add the 'catch WALEntryFilterRetryableException' back. >

[GitHub] [hbase] Apache-HBase commented on pull request #3407: HBASE-26018. Perf improvement in L1 cache

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3407: URL: https://github.com/apache/hbase/pull/3407#issuecomment-865151240 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] joshelser commented on pull request #2114: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2021-06-21 Thread GitBox
joshelser commented on pull request #2114: URL: https://github.com/apache/hbase/pull/2114#issuecomment-865145985 > I'm suggesting to hide this behind a feature flag Makes sense to me. I think that addresses some of the other concerns from @Apache9 (mentioning him to make sure that's

[jira] [Commented] (HBASE-26001) When turn on access control, the cell level TTL of Increment and Append operations is invalid.

2021-06-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366679#comment-17366679 ] Hudson commented on HBASE-26001: Results for branch branch-1 [build #136 on

[jira] [Commented] (HBASE-26004) Port HBASE-26001 (cell level tags invisible in atomic operations when access control is on) to branch-1

2021-06-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366678#comment-17366678 ] Hudson commented on HBASE-26004: Results for branch branch-1 [build #136 on

[jira] [Reopened] (HBASE-25992) Polish the ReplicationSourceWALReader code for 2.x after HBASE-25596

2021-06-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reopened HBASE-25992: --- This breaks TestWALEntryStream.testReplicationSourceWALReaderWithFailingFilter. > Polish the

[GitHub] [hbase] petersomogyi commented on pull request #2114: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2021-06-21 Thread GitBox
petersomogyi commented on pull request #2114: URL: https://github.com/apache/hbase/pull/2114#issuecomment-865087242 I've made some testing recently using this patch to be able to start an HBase cluster on a pre-existing HBase root directory. Currently I have to use `HBCK2 recoverUnknown`

[GitHub] [hbase] Apache-HBase commented on pull request #3408: HBASE-26019 Remove reflections used in HBaseConfiguration.getPassword()

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3408: URL: https://github.com/apache/hbase/pull/3408#issuecomment-865074858 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3408: HBASE-26019 Remove reflections used in HBaseConfiguration.getPassword()

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3408: URL: https://github.com/apache/hbase/pull/3408#issuecomment-865074403 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3408: HBASE-26019 Remove reflections used in HBaseConfiguration.getPassword()

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3408: URL: https://github.com/apache/hbase/pull/3408#issuecomment-865072654 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[jira] [Created] (HBASE-26020) Split TestWALEntryStream.testDifferentCounts out

2021-06-21 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-26020: - Summary: Split TestWALEntryStream.testDifferentCounts out Key: HBASE-26020 URL: https://issues.apache.org/jira/browse/HBASE-26020 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #3407: HBASE-26018. Perf improvement in L1 cache

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3407: URL: https://github.com/apache/hbase/pull/3407#issuecomment-865067631 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] petersomogyi commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-21 Thread GitBox
petersomogyi commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r651901792 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -266,6 +266,7 @@ public

[GitHub] [hbase] jojochuang opened a new pull request #3408: HBASE-26019 Remove reflections used in HBaseConfiguration.getPassword()

2021-06-21 Thread GitBox
jojochuang opened a new pull request #3408: URL: https://github.com/apache/hbase/pull/3408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Assigned] (HBASE-26019) Remove reflections used in HBaseConfiguration.getPassword()

2021-06-21 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang reassigned HBASE-26019: --- Assignee: Wei-Chiu Chuang > Remove reflections used in

[jira] [Created] (HBASE-26019) Remove reflections used in HBaseConfiguration.getPassword()

2021-06-21 Thread Wei-Chiu Chuang (Jira)
Wei-Chiu Chuang created HBASE-26019: --- Summary: Remove reflections used in HBaseConfiguration.getPassword() Key: HBASE-26019 URL: https://issues.apache.org/jira/browse/HBASE-26019 Project: HBase

[jira] [Updated] (HBASE-26019) Remove reflections used in HBaseConfiguration.getPassword()

2021-06-21 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HBASE-26019: Fix Version/s: 2.5.0 3.0.0-alpha-1 > Remove reflections used in

[GitHub] [hbase] GeorryHuang commented on a change in pull request #3373: HBASE-25980 Master table.jsp pointed at meta throws 500 when no all r…

2021-06-21 Thread GitBox
GeorryHuang commented on a change in pull request #3373: URL: https://github.com/apache/hbase/pull/3373#discussion_r655369081 ## File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp ## @@ -268,7 +269,12 @@ for (int j = 0; j <

[jira] [Updated] (HBASE-26013) Get operations readRows metrics becomes zero after HBASE-25677

2021-06-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26013: -- Component/s: metrics > Get operations readRows metrics becomes zero after HBASE-25677 >

[GitHub] [hbase] Apache9 commented on pull request #3396: HBASE-26010 Backport HBASE-25703 and HBASE-26002 to branch-2.3

2021-06-21 Thread GitBox
Apache9 commented on pull request #3396: URL: https://github.com/apache/hbase/pull/3396#issuecomment-865016704 Ping @ndimiduk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hbase] Apache9 commented on pull request #3395: HBASE-26009 Backport HBASE-25766 "Introduce RegionSplitRestriction that restricts the pattern of the split point" to branch-2.3

2021-06-21 Thread GitBox
Apache9 commented on pull request #3395: URL: https://github.com/apache/hbase/pull/3395#issuecomment-865015410 This is a new feature? Is it suitable to be backported to 2.3? @ndimiduk -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Work started] (HBASE-26018) Perf improvement in L1 cache

2021-06-21 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-26018 started by Viraj Jasani. > Perf improvement in L1 cache > > >

[GitHub] [hbase] mnpoonia edited a comment on pull request #3372: HBASE-25986 set default value of normalization enabled from hbase site

2021-06-21 Thread GitBox
mnpoonia edited a comment on pull request #3372: URL: https://github.com/apache/hbase/pull/3372#issuecomment-864997682 > I think rather than site config, having a switch command would be more beneficial. > Something like `switch_cluster_normalizer /` would not require us to re-deploy

[GitHub] [hbase] mnpoonia commented on pull request #3372: HBASE-25986 set default value of normalization enabled from hbase site

2021-06-21 Thread GitBox
mnpoonia commented on pull request #3372: URL: https://github.com/apache/hbase/pull/3372#issuecomment-864997682 > I think rather than site config, having a switch command would be more beneficial. > Something like `switch_cluster_normalizer /` would not require us to re-deploy with

[GitHub] [hbase] Apache-HBase commented on pull request #3407: HBASE-26018. Perf improvement in L1 cache

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3407: URL: https://github.com/apache/hbase/pull/3407#issuecomment-864984371 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3405: HBASE-26011 Introduce a new API to sync the live region server list m…

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3405: URL: https://github.com/apache/hbase/pull/3405#issuecomment-864976437 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3405: HBASE-26011 Introduce a new API to sync the live region server list m…

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3405: URL: https://github.com/apache/hbase/pull/3405#issuecomment-864974494 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] tomscut edited a comment on pull request #3325: HBASE-25934 Add username for RegionScannerHolder

2021-06-21 Thread GitBox
tomscut edited a comment on pull request #3325: URL: https://github.com/apache/hbase/pull/3325#issuecomment-864964892 > I see +1 already from @Apache9. Are we waiting for some one else's comments to be addressed? > Agree the test failures look unrelated. Rerunning tests just to be

[GitHub] [hbase] tomscut removed a comment on pull request #3325: HBASE-25934 Add username for RegionScannerHolder

2021-06-21 Thread GitBox
tomscut removed a comment on pull request #3325: URL: https://github.com/apache/hbase/pull/3325#issuecomment-864965924 > Agree the test failures look unrelated. Rerunning tests just to be sure. We can look at this. @anoopsjohn -- This is an automated message from the Apache Git

[GitHub] [hbase] tomscut commented on pull request #3325: HBASE-25934 Add username for RegionScannerHolder

2021-06-21 Thread GitBox
tomscut commented on pull request #3325: URL: https://github.com/apache/hbase/pull/3325#issuecomment-864965924 > Agree the test failures look unrelated. Rerunning tests just to be sure. We can look at this. @anoopsjohn -- This is an automated message from the Apache Git Service.

[GitHub] [hbase] tomscut commented on pull request #3325: HBASE-25934 Add username for RegionScannerHolder

2021-06-21 Thread GitBox
tomscut commented on pull request #3325: URL: https://github.com/apache/hbase/pull/3325#issuecomment-864964892 > I see +1 already from @Apache9. Are we waiting for some one else's comments to be addressed? > Agree the test failures look unrelated. Rerunning tests just to be sure.

[GitHub] [hbase] anoopsjohn commented on pull request #3325: HBASE-25934 Add username for RegionScannerHolder

2021-06-21 Thread GitBox
anoopsjohn commented on pull request #3325: URL: https://github.com/apache/hbase/pull/3325#issuecomment-864961454 I see +1 already from @Apache9. Are we waiting for some one else's comments to be addressed? -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (HBASE-25596) Fix NPE in ReplicationSourceManager as well as avoid permanently unreplicated data due to EOFException from WAL

2021-06-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366546#comment-17366546 ] Hudson commented on HBASE-25596: Results for branch master [build #328 on

[jira] [Commented] (HBASE-25992) Polish the ReplicationSourceWALReader code for 2.x after HBASE-25596

2021-06-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366545#comment-17366545 ] Hudson commented on HBASE-25992: Results for branch master [build #328 on

[jira] [Updated] (HBASE-26013) Get operations readRows metrics becomes zero after HBASE-25677

2021-06-21 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-26013: --- Priority: Major (was: Minor) > Get operations readRows metrics becomes zero after

[GitHub] [hbase] tomscut commented on pull request #3325: HBASE-25934 Add username for RegionScannerHolder

2021-06-21 Thread GitBox
tomscut commented on pull request #3325: URL: https://github.com/apache/hbase/pull/3325#issuecomment-864953216 Hi @virajjasani , could you please help to review the code? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (HBASE-26018) Perf improvement in L1 cache

2021-06-21 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-26018: - Description: After HBASE-25698 is in, all L1 caching strategies perform buffer.retain() in

[GitHub] [hbase] virajjasani commented on pull request #3407: HBASE-26018. Perf improvement in L1 cache

2021-06-21 Thread GitBox
virajjasani commented on pull request #3407: URL: https://github.com/apache/hbase/pull/3407#issuecomment-864949628 FYI @ben-manes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hbase] virajjasani opened a new pull request #3407: HBASE-26018. Perf improvement in L1 cache

2021-06-21 Thread GitBox
virajjasani opened a new pull request #3407: URL: https://github.com/apache/hbase/pull/3407 * CHM#computeIfPresent takes lock on bucket but CHM#get is lockless * Atomically retaining refCount is coming up bit expensive in terms of performance issues * When we see aggressive cache

[jira] [Updated] (HBASE-26018) Perf improvement in L1 cache

2021-06-21 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-26018: - Attachment: computeIfPresent.png > Perf improvement in L1 cache >

[jira] [Created] (HBASE-26018) Perf improvement in L1 cache

2021-06-21 Thread Viraj Jasani (Jira)
Viraj Jasani created HBASE-26018: Summary: Perf improvement in L1 cache Key: HBASE-26018 URL: https://issues.apache.org/jira/browse/HBASE-26018 Project: HBase Issue Type: Improvement

[GitHub] [hbase] Apache-HBase commented on pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #2941: URL: https://github.com/apache/hbase/pull/2941#issuecomment-864930429 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3405: HBASE-26011 Introduce a new API to sync the live region server list m…

2021-06-21 Thread GitBox
Apache-HBase commented on pull request #3405: URL: https://github.com/apache/hbase/pull/3405#issuecomment-864915997 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

  1   2   >