[GitHub] [hbase] Apache-HBase commented on pull request #3434: HBASE-21946 Use ByteBuffer pread instead of byte[] pread in HFileBlock when applicable

2021-06-28 Thread GitBox
Apache-HBase commented on pull request #3434: URL: https://github.com/apache/hbase/pull/3434#issuecomment-870247452 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #3434: HBASE-21946 Use ByteBuffer pread instead of byte[] pread in HFileBlock when applicable

2021-06-28 Thread GitBox
Apache-HBase commented on pull request #3434: URL: https://github.com/apache/hbase/pull/3434#issuecomment-870245104 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 commented on a change in pull request #3434: HBASE-21946 Use ByteBuffer pread instead of byte[] pread in HFileBlock when applicable

2021-06-28 Thread GitBox
Apache9 commented on a change in pull request #3434: URL: https://github.com/apache/hbase/pull/3434#discussion_r660287517 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/BlockIOUtils.java ## @@ -207,6 +234,17 @@ public static boolean

[GitHub] [hbase] Apache9 commented on a change in pull request #3430: HBASE-26029 It is not reliable to use nodeDeleted event to track regi…

2021-06-28 Thread GitBox
Apache9 commented on a change in pull request #3430: URL: https://github.com/apache/hbase/pull/3430#discussion_r660286508 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ClaimReplicationQueuesProcedure.java ## @@ -0,0 +1,140 @@ +/** + *

[jira] [Commented] (HBASE-26029) It is not reliable to use nodeDeleted event to track region server's death

2021-06-28 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371044#comment-17371044 ] Bharath Vissapragada commented on HBASE-26029: -- Hooking this up with SCP is neat, should

[jira] [Commented] (HBASE-26021) HBase 1.7 to 2.4 upgrade issue due to incompatible deserialization

2021-06-28 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371034#comment-17371034 ] Bharath Vissapragada commented on HBASE-26021: -- https://github.com/apache/hbase/pull/3435 I

[GitHub] [hbase] bharathv opened a new pull request #3435: HBASE-26021: Undo the incompatible serialization change in HBASE-7767

2021-06-28 Thread GitBox
bharathv opened a new pull request #3435: URL: https://github.com/apache/hbase/pull/3435 Revert "HBASE-7767 Get rid of ZKTable, and table enable/disable state in ZK (Andrey Stepachev)" Fixes the ConnectionRegistry and dependencies due to the revert. -- This is an automated

[GitHub] [hbase] ddupg commented on a change in pull request #3430: HBASE-26029 It is not reliable to use nodeDeleted event to track regi…

2021-06-28 Thread GitBox
ddupg commented on a change in pull request #3430: URL: https://github.com/apache/hbase/pull/3430#discussion_r660247427 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java ## @@ -838,185 +795,116 @@ public

[GitHub] [hbase] Apache-HBase commented on pull request #3434: HBASE-21946 Use ByteBuffer pread instead of byte[] pread in HFileBlock when applicable

2021-06-28 Thread GitBox
Apache-HBase commented on pull request #3434: URL: https://github.com/apache/hbase/pull/3434#issuecomment-870201695 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25130) [branch-1] Masters in-memory serverHoldings map is not cleared during hbck repair

2021-06-28 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-25130: -- Fix Version/s: 1.7.1 > [branch-1] Masters in-memory serverHoldings map is not cleared during hbck >

[GitHub] [hbase] jojochuang opened a new pull request #3434: HBASE-21946. Use hasCapabilities() to detect and switch pread API accordingly.

2021-06-28 Thread GitBox
jojochuang opened a new pull request #3434: URL: https://github.com/apache/hbase/pull/3434 Use StreamCapabilities.hasCapabilities() to determine if the pread is supported by the input stream. Use reflection to invoke the bytebuffer pread method when it is available (because the

[jira] [Updated] (HBASE-21946) Use ByteBuffer pread instead of byte[] pread in HFileBlock when applicable

2021-06-28 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HBASE-21946: Summary: Use ByteBuffer pread instead of byte[] pread in HFileBlock when applicable

[GitHub] [hbase] Apache-HBase commented on pull request #3433: HBASE-26035 Redundant null check in the compareTo function

2021-06-28 Thread GitBox
Apache-HBase commented on pull request #3433: URL: https://github.com/apache/hbase/pull/3433#issuecomment-870124268 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3433: HBASE-26035 Redundant null check in the compareTo function

2021-06-28 Thread GitBox
Apache-HBase commented on pull request #3433: URL: https://github.com/apache/hbase/pull/3433#issuecomment-870122757 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3433: HBASE-26035 Redundant null check in the compareTo function

2021-06-28 Thread GitBox
Apache-HBase commented on pull request #3433: URL: https://github.com/apache/hbase/pull/3433#issuecomment-870121257 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-26035) Redundant null check in the compareTo function

2021-06-28 Thread Almog Tavor (Jira)
Almog Tavor created HBASE-26035: --- Summary: Redundant null check in the compareTo function Key: HBASE-26035 URL: https://issues.apache.org/jira/browse/HBASE-26035 Project: HBase Issue Type:

[jira] [Updated] (HBASE-25396) Integration with direct insert into data/cf directory

2021-06-28 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25396: -- Summary: Integration with direct insert into data/cf directory (was: Integtration with

[GitHub] [hbase] almogtavor opened a new pull request #3433: Remove redundant comparison

2021-06-28 Thread GitBox
almogtavor opened a new pull request #3433: URL: https://github.com/apache/hbase/pull/3433 Useless check, impl cannot be null (guarded by instanceof) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (HBASE-25392) Direct insert compacted HFiles into data directory.

2021-06-28 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25392: -- Description: {color:#00}when performing compaction, write directly to the data directory

[GitHub] [hbase] saintstack commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-28 Thread GitBox
saintstack commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r660167381 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java ## @@ -291,12 +291,36 @@ public void

[jira] [Commented] (HBASE-25902) 1.x to 2.3.x upgrade does not work; you must install an hbase2 that is earlier than hbase-2.3.0 first

2021-06-28 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370927#comment-17370927 ] Michael Stack commented on HBASE-25902: --- Thanks for working on this [~vjasani] I looked at the

[GitHub] [hbase] saintstack commented on a change in pull request #3417: HBASE-25902 Add missing CFs in meta during HBase 1 to 2 Upgrade

2021-06-28 Thread GitBox
saintstack commented on a change in pull request #3417: URL: https://github.com/apache/hbase/pull/3417#discussion_r660162631 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -1047,6 +1074,29 @@ private void

[jira] [Resolved] (HBASE-25130) [branch-1] Masters in-memory serverHoldings map is not cleared during hbck repair

2021-06-28 Thread Victor Li (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victor Li resolved HBASE-25130. --- Release Note: Fixed on branch-1. Resolution: Fixed https://github.com/apache/hbase/pull/3402

[jira] [Commented] (HBASE-22923) hbase:meta is assigned to localhost when we downgrade the hbase version

2021-06-28 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370843#comment-17370843 ] Andrew Kyle Purtell commented on HBASE-22923: - [~vjasani] Way back when RSGroups was first

[jira] [Commented] (HBASE-26031) Validate nightly builds run on new ci workers hbase11-hbase15

2021-06-28 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370838#comment-17370838 ] Michael Stack commented on HBASE-26031: --- Thanks [~busbey]   > Validate nightly builds run on new

[jira] [Commented] (HBASE-25761) POC: hbase:meta,,1 as ROOT

2021-06-28 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370837#comment-17370837 ] Michael Stack commented on HBASE-25761: --- I took a look at the one-pager [~toffer] . Suggest you

[jira] [Comment Edited] (HBASE-26031) Validate nightly builds run on new ci workers hbase11-hbase15

2021-06-28 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370830#comment-17370830 ] Sean Busbey edited comment on HBASE-26031 at 6/28/21, 8:20 PM: --- looking

[jira] [Commented] (HBASE-26031) Validate nightly builds run on new ci workers hbase11-hbase15

2021-06-28 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370834#comment-17370834 ] Sean Busbey commented on HBASE-26031: - I just moved hbase11 into the normal pool. presuming nothing

[jira] [Commented] (HBASE-26031) Validate nightly builds run on new ci workers hbase11-hbase15

2021-06-28 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370832#comment-17370832 ] Sean Busbey commented on HBASE-26031: - if no-one objects I'm going to phase these into the normal

[jira] [Commented] (HBASE-26031) Validate nightly builds run on new ci workers hbase11-hbase15

2021-06-28 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370830#comment-17370830 ] Sean Busbey commented on HBASE-26031: - looking through the logs on the builds that ran on

[jira] [Commented] (HBASE-26031) Validate nightly builds run on new ci workers hbase11-hbase15

2021-06-28 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370824#comment-17370824 ] Sean Busbey commented on HBASE-26031: - I put hbase10 back into the usual rotation over the weekend

[jira] [Commented] (HBASE-22923) hbase:meta is assigned to localhost when we downgrade the hbase version

2021-06-28 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370820#comment-17370820 ] Viraj Jasani commented on HBASE-22923: -- Here is what can reproduce this easily (and it can happen

[jira] [Commented] (HBASE-25980) Master table.jsp pointed at meta throws 500 when no all replicas are online

2021-06-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370818#comment-17370818 ] Hudson commented on HBASE-25980: Results for branch branch-2 [build #288 on

[jira] [Commented] (HBASE-25914) Provide slow/large logs on RegionServer UI

2021-06-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370817#comment-17370817 ] Hudson commented on HBASE-25914: Results for branch branch-2 [build #288 on

[jira] [Commented] (HBASE-26015) Should implement getRegionServers(boolean) method in AsyncAdmin

2021-06-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370816#comment-17370816 ] Hudson commented on HBASE-26015: Results for branch branch-2 [build #288 on

[jira] [Commented] (HBASE-26021) HBase 1.7 to 2.4 upgrade issue due to incompatible deserialization

2021-06-28 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370785#comment-17370785 ] Andrew Kyle Purtell commented on HBASE-26021: - The revert is not difficult to identify.

[GitHub] [hbase] Apache-HBase commented on pull request #3425: HBASE-25991 Do compaction on compaction server

2021-06-28 Thread GitBox
Apache-HBase commented on pull request #3425: URL: https://github.com/apache/hbase/pull/3425#issuecomment-869918972 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3425: HBASE-25991 Do compaction on compaction server

2021-06-28 Thread GitBox
Apache-HBase commented on pull request #3425: URL: https://github.com/apache/hbase/pull/3425#issuecomment-869891540 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 14m

[jira] [Commented] (HBASE-25980) Master table.jsp pointed at meta throws 500 when no all replicas are online

2021-06-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370757#comment-17370757 ] Hudson commented on HBASE-25980: Results for branch branch-2.3 [build #246 on

[jira] [Commented] (HBASE-26015) Should implement getRegionServers(boolean) method in AsyncAdmin

2021-06-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370756#comment-17370756 ] Hudson commented on HBASE-26015: Results for branch branch-2.3 [build #246 on

[GitHub] [hbase] saintstack commented on a change in pull request #3425: HBASE-25991 Do compaction on compaction server

2021-06-28 Thread GitBox
saintstack commented on a change in pull request #3425: URL: https://github.com/apache/hbase/pull/3425#discussion_r659933917 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/compactionserver/CSRpcServices.java ## @@ -88,8 +93,18 @@ void start() { public

[GitHub] [hbase] apurtell merged pull request #3402: HBASE-25130 - Fix master in-memory server holding map after:

2021-06-28 Thread GitBox
apurtell merged pull request #3402: URL: https://github.com/apache/hbase/pull/3402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HBASE-25714) Offload the compaction job to independent Compaction Server

2021-06-28 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370688#comment-17370688 ] Michael Stack commented on HBASE-25714: --- Looks great. Left some comments on the design doc (sorry

[jira] [Commented] (HBASE-26025) Add a flag to mark if the IOError can be solved by retry in thrift IOError

2021-06-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370664#comment-17370664 ] Hudson commented on HBASE-26025: Results for branch branch-1 [build #139 on

[GitHub] [hbase] Apache-HBase commented on pull request #3372: HBASE-25986 set default value of normalization enabled from hbase site

2021-06-28 Thread GitBox
Apache-HBase commented on pull request #3372: URL: https://github.com/apache/hbase/pull/3372#issuecomment-869785498 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3425: HBASE-25991 Do compaction on compaction server

2021-06-28 Thread GitBox
Apache-HBase commented on pull request #3425: URL: https://github.com/apache/hbase/pull/3425#issuecomment-869768347 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3372: HBASE-25986 set default value of normalization enabled from hbase site

2021-06-28 Thread GitBox
Apache-HBase commented on pull request #3372: URL: https://github.com/apache/hbase/pull/3372#issuecomment-869737381 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-26015) Should implement getRegionServers(boolean) method in AsyncAdmin

2021-06-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370621#comment-17370621 ] Hudson commented on HBASE-26015: Results for branch branch-2.4 [build #153 on

[jira] [Commented] (HBASE-25980) Master table.jsp pointed at meta throws 500 when no all replicas are online

2021-06-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370622#comment-17370622 ] Hudson commented on HBASE-25980: Results for branch branch-2.4 [build #153 on

[GitHub] [hbase] catalin-luca commented on pull request #3369: [BACKPORT] HBASE-25859 Reference class incorrectly parses the protobuf magic marker

2021-06-28 Thread GitBox
catalin-luca commented on pull request #3369: URL: https://github.com/apache/hbase/pull/3369#issuecomment-869724807 @busbey Any idea how I can re-trigger the build? Current failure is un-related to the changes in the patch. -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (HBASE-25914) Provide slow/large logs on RegionServer UI

2021-06-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370601#comment-17370601 ] Hudson commented on HBASE-25914: Results for branch master [build #334 on

[jira] [Commented] (HBASE-26015) Should implement getRegionServers(boolean) method in AsyncAdmin

2021-06-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370600#comment-17370600 ] Hudson commented on HBASE-26015: Results for branch master [build #334 on

[jira] [Commented] (HBASE-25980) Master table.jsp pointed at meta throws 500 when no all replicas are online

2021-06-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370602#comment-17370602 ] Hudson commented on HBASE-25980: Results for branch master [build #334 on

[GitHub] [hbase] nyl3532016 edited a comment on pull request #3425: HBASE-25991 Do compaction on compaction server

2021-06-28 Thread GitBox
nyl3532016 edited a comment on pull request #3425: URL: https://github.com/apache/hbase/pull/3425#issuecomment-869608162 > Please add more javadoc for CompactionServer related class on how to share the same logic with HRegionServer? I do not think we want to duplicate the code twice...

[GitHub] [hbase] Apache-HBase commented on pull request #3426: HBASE-26032 Make HRegion.getStores() an O(1) operation

2021-06-28 Thread GitBox
Apache-HBase commented on pull request #3426: URL: https://github.com/apache/hbase/pull/3426#issuecomment-869678634 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3426: HBASE-26032 Make HRegion.getStores() an O(1) operation

2021-06-28 Thread GitBox
Apache-HBase commented on pull request #3426: URL: https://github.com/apache/hbase/pull/3426#issuecomment-869664047 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3372: HBASE-25986 set default value of normalization enabled from hbase site

2021-06-28 Thread GitBox
Apache-HBase commented on pull request #3372: URL: https://github.com/apache/hbase/pull/3372#issuecomment-869659741 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Assigned] (HBASE-21946) Replace the byte[] pread by ByteBuffer pread in HFileBlock reading once HDFS-3246 prepared

2021-06-28 Thread Zheng Hu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Hu reassigned HBASE-21946: Assignee: Wei-Chiu Chuang (was: Zheng Hu) > Replace the byte[] pread by ByteBuffer pread in

[jira] [Commented] (HBASE-21946) Replace the byte[] pread by ByteBuffer pread in HFileBlock reading once HDFS-3246 prepared

2021-06-28 Thread Zheng Hu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370564#comment-17370564 ] Zheng Hu commented on HBASE-21946: -- [~weichiu] Please just go ahead, i would like to review your patch

[GitHub] [hbase] Apache-HBase commented on pull request #3372: HBASE-25986 set default value of normalization enabled from hbase site

2021-06-28 Thread GitBox
Apache-HBase commented on pull request #3372: URL: https://github.com/apache/hbase/pull/3372#issuecomment-869614204 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] nyl3532016 commented on pull request #3425: HBASE-25991 Do compaction on compaction server

2021-06-28 Thread GitBox
nyl3532016 commented on pull request #3425: URL: https://github.com/apache/hbase/pull/3425#issuecomment-869608162 > Please add more javadoc for CompactionServer related class on how to share the same logic with HRegionServer? I do not think we want to duplicate the code twice...

[GitHub] [hbase] Apache-HBase commented on pull request #3426: HBASE-26032 Make HRegion.getStores() an O(1) operation

2021-06-28 Thread GitBox
Apache-HBase commented on pull request #3426: URL: https://github.com/apache/hbase/pull/3426#issuecomment-869597221 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3372: HBASE-25986 set default value of normalization enabled from hbase site

2021-06-28 Thread GitBox
Apache-HBase commented on pull request #3372: URL: https://github.com/apache/hbase/pull/3372#issuecomment-869575765 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] jojochuang commented on pull request #3426: HBASE-26032 Make HRegion.getStores() an O(1) operation

2021-06-28 Thread GitBox
jojochuang commented on pull request #3426: URL: https://github.com/apache/hbase/pull/3426#issuecomment-869568788 Ok I came up with a hack to maintain backward compat: We can retain the return type of getStores. For HRegion, it returns a special List subclass that behaves just like

[jira] [Resolved] (HBASE-25985) ReplicationSourceWALReader#run - Reset sleepMultiplier in loop once out of any IOE

2021-06-28 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John resolved HBASE-25985. Resolution: Invalid > ReplicationSourceWALReader#run - Reset sleepMultiplier in loop once

[GitHub] [hbase] Apache-HBase commented on pull request #3372: HBASE-25986 set default value of normalization enabled from hbase site

2021-06-28 Thread GitBox
Apache-HBase commented on pull request #3372: URL: https://github.com/apache/hbase/pull/3372#issuecomment-869507843 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3430: HBASE-26029 It is not reliable to use nodeDeleted event to track regi…

2021-06-28 Thread GitBox
Apache-HBase commented on pull request #3430: URL: https://github.com/apache/hbase/pull/3430#issuecomment-869480710 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-21946) Replace the byte[] pread by ByteBuffer pread in HFileBlock reading once HDFS-3246 prepared

2021-06-28 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370485#comment-17370485 ] Wei-Chiu Chuang commented on HBASE-21946: - I have a patch that uses

[GitHub] [hbase] Apache-HBase commented on pull request #3431: HBASE-26021 Fix TableDescriptor serialization to maintain compatibility with HBase 2

2021-06-28 Thread GitBox
Apache-HBase commented on pull request #3431: URL: https://github.com/apache/hbase/pull/3431#issuecomment-869456579 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[jira] [Updated] (HBASE-26018) Perf improvement in L1 cache

2021-06-28 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-26018: - Status: Patch Available (was: In Progress) > Perf improvement in L1 cache >

[GitHub] [hbase] Apache-HBase commented on pull request #3425: HBASE-25991 Do compaction on compaction server

2021-06-28 Thread GitBox
Apache-HBase commented on pull request #3425: URL: https://github.com/apache/hbase/pull/3425#issuecomment-869451882 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #3430: HBASE-26029 It is not reliable to use nodeDeleted event to track regi…

2021-06-28 Thread GitBox
Apache-HBase commented on pull request #3430: URL: https://github.com/apache/hbase/pull/3430#issuecomment-869441656 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #3425: HBASE-25991 Do compaction on compaction server

2021-06-28 Thread GitBox
Apache-HBase commented on pull request #3425: URL: https://github.com/apache/hbase/pull/3425#issuecomment-869441238 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-26027) The calling of HTable.batch blocked at AsyncRequestFutureImpl.waitUntilDone caused by ArrayStoreException

2021-06-28 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang updated HBASE-26027: --- Description: The batch api of HTable contains a param named results to store result or exception,

[GitHub] [hbase] virajjasani closed pull request #3431: HBASE-26021 Fix TableDescriptor serialization to maintain compatibility with HBase 2

2021-06-28 Thread GitBox
virajjasani closed pull request #3431: URL: https://github.com/apache/hbase/pull/3431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HBASE-26021) HBase 1.7 to 2.4 upgrade issue due to incompatible deserialization

2021-06-28 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370439#comment-17370439 ] Viraj Jasani commented on HBASE-26021: -- {quote}Coming to the fix, isn't the patch incomplete ? If