[GitHub] [hbase] Apache-HBase commented on pull request #3732: HBASE-26337 Optimization for weighted random generators

2021-11-06 Thread GitBox
Apache-HBase commented on pull request #3732: URL: https://github.com/apache/hbase/pull/3732#issuecomment-962550283 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3732: HBASE-26337 Optimization for weighted random generators

2021-11-06 Thread GitBox
Apache-HBase commented on pull request #3732: URL: https://github.com/apache/hbase/pull/3732#issuecomment-962550172 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3732: HBASE-26337 Optimization for weighted random generators

2021-11-06 Thread GitBox
Apache-HBase commented on pull request #3732: URL: https://github.com/apache/hbase/pull/3732#issuecomment-962549944 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3732: HBASE-26337 Optimization for weighted random generators

2021-11-06 Thread GitBox
Apache-HBase commented on pull request #3732: URL: https://github.com/apache/hbase/pull/3732#issuecomment-962540387 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3732: HBASE-26337 Optimization for weighted random generators

2021-11-06 Thread GitBox
Apache-HBase commented on pull request #3732: URL: https://github.com/apache/hbase/pull/3732#issuecomment-962540145 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3820: HBASE-26430 Increase log level in DefaultHeapMemoryTuner from DEBUG to INFO

2021-11-06 Thread GitBox
Apache-HBase commented on pull request #3820: URL: https://github.com/apache/hbase/pull/3820#issuecomment-962539918 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3732: HBASE-26337 Optimization for weighted random generators

2021-11-06 Thread GitBox
Apache-HBase commented on pull request #3732: URL: https://github.com/apache/hbase/pull/3732#issuecomment-962539152 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3820: HBASE-26430 Increase log level in DefaultHeapMemoryTuner from DEBUG to INFO

2021-11-06 Thread GitBox
Apache-HBase commented on pull request #3820: URL: https://github.com/apache/hbase/pull/3820#issuecomment-962539080 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] clarax commented on pull request #3732: HBASE-26337 Optimization for weighted random generators

2021-11-06 Thread GitBox
clarax commented on pull request #3732: URL: https://github.com/apache/hbase/pull/3732#issuecomment-962535574 @Apache9 thank you for review. Sorry for missing a commit during rebase. added it back and updated for review feedback. -- This is an automated message from the Apache Git

[GitHub] [hbase] Apache9 commented on pull request #3815: HBASE-26412 Handle sink failure in RegionReplicationSink

2021-11-06 Thread GitBox
Apache9 commented on pull request #3815: URL: https://github.com/apache/hbase/pull/3815#issuecomment-962524390 OK, we have 3 +1s on the pre commit result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase] Apache-HBase commented on pull request #3820: HBASE-26430 Increase log level in DefaultHeapMemoryTuner from DEBUG to INFO

2021-11-06 Thread GitBox
Apache-HBase commented on pull request #3820: URL: https://github.com/apache/hbase/pull/3820#issuecomment-962521627 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3820: HBASE-26430 Increase log level in DefaultHeapMemoryTuner from DEBUG to INFO

2021-11-06 Thread GitBox
Apache-HBase commented on pull request #3820: URL: https://github.com/apache/hbase/pull/3820#issuecomment-962515734 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3820: HBASE-26430 Increase log level in DefaultHeapMemoryTuner from DEBUG to INFO

2021-11-06 Thread GitBox
Apache-HBase commented on pull request #3820: URL: https://github.com/apache/hbase/pull/3820#issuecomment-96250 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3815: HBASE-26412 Handle sink failure in RegionReplicationSink

2021-11-06 Thread GitBox
Apache-HBase commented on pull request #3815: URL: https://github.com/apache/hbase/pull/3815#issuecomment-962497368 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3820: HBASE-26430 Increase log level in DefaultHeapMemoryTuner from DEBUG to INFO

2021-11-06 Thread GitBox
Apache-HBase commented on pull request #3820: URL: https://github.com/apache/hbase/pull/3820#issuecomment-962494451 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3815: HBASE-26412 Handle sink failure in RegionReplicationSink

2021-11-06 Thread GitBox
Apache-HBase commented on pull request #3815: URL: https://github.com/apache/hbase/pull/3815#issuecomment-962492470 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3822: HBASE-26431 Add hadoop 3.3.x to our hadoop version support matrix

2021-11-06 Thread GitBox
Apache-HBase commented on pull request #3822: URL: https://github.com/apache/hbase/pull/3822#issuecomment-962473693 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #3822: HBASE-26431 Add hadoop 3.3.x to our hadoop version support matrix

2021-11-06 Thread GitBox
Apache-HBase commented on pull request #3822: URL: https://github.com/apache/hbase/pull/3822#issuecomment-962470976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Created] (HBASE-26431) Add hadoop 3.3.x to our hadoop version support matrix

2021-11-06 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-26431: - Summary: Add hadoop 3.3.x to our hadoop version support matrix Key: HBASE-26431 URL: https://issues.apache.org/jira/browse/HBASE-26431 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #3821: HBASE-26428 Add hadoop 2.10.1, 3.2.2 and 3.3.1 to our hadoop checks

2021-11-06 Thread GitBox
Apache-HBase commented on pull request #3821: URL: https://github.com/apache/hbase/pull/3821#issuecomment-962469869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] Apache-HBase commented on pull request #3821: HBASE-26428 Add hadoop 2.10.1, 3.2.2 and 3.3.1 to our hadoop checks

2021-11-06 Thread GitBox
Apache-HBase commented on pull request #3821: URL: https://github.com/apache/hbase/pull/3821#issuecomment-962469782 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3821: HBASE-26428 Add hadoop 2.10.1, 3.2.2 and 3.3.1 to our hadoop checks

2021-11-06 Thread GitBox
Apache-HBase commented on pull request #3821: URL: https://github.com/apache/hbase/pull/3821#issuecomment-962469650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (HBASE-26428) Add hadoop 2.10.1, 3.2.2 and 3.3.1 to our hadoop checks

2021-11-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26428: -- Summary: Add hadoop 2.10.1, 3.2.2 and 3.3.1 to our hadoop checks (was: Add hadoop-3.3.1 to our

[GitHub] [hbase] Apache9 commented on pull request #3786: HBASE-26271: Cleanup the broken store files under data directory

2021-11-06 Thread GitBox
Apache9 commented on pull request #3786: URL: https://github.com/apache/hbase/pull/3786#issuecomment-962466544 #3700 has been merged and I rebased HBASE-26067 with the newest master. Please rebase the PR too. Thanks for your patient. We are very close to merge this PR. -- This is

[jira] [Commented] (HBASE-26262) Implement a region based store file tracker

2021-11-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17439699#comment-17439699 ] Duo Zhang commented on HBASE-26262: --- [~wchevreuil] [~elserj] Do we still want to include this in the

[jira] [Commented] (HBASE-26265) Update ref guide to mention the new store file tracker implementations

2021-11-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17439698#comment-17439698 ] Duo Zhang commented on HBASE-26265: --- [~elserj] [~wchevreuil] [~bszabolcs] Do you guys have interest in

[GitHub] [hbase] Apache-HBase commented on pull request #3815: HBASE-26412 Handle sink failure in RegionReplicationSink

2021-11-06 Thread GitBox
Apache-HBase commented on pull request #3815: URL: https://github.com/apache/hbase/pull/3815#issuecomment-962465529 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-26286) Add support for specifying store file tracker when restoring or cloning snapshot

2021-11-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17439696#comment-17439696 ] Duo Zhang commented on HBASE-26286: --- {quote} For the two SFT impls available now, I think the main

[jira] [Commented] (HBASE-26286) Add support for specifying store file tracker when restoring or cloning snapshot

2021-11-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17439695#comment-17439695 ] Duo Zhang commented on HBASE-26286: --- Sorry guys, in fact I'm always confusing about the difference

[jira] [Resolved] (HBASE-26402) Remove branch-1.4 from compatibility matrix and release manager section in our ref guide

2021-11-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26402. --- Fix Version/s: 3.0.0-alpha-2 Hadoop Flags: Reviewed Resolution: Fixed Merged to master.

[GitHub] [hbase] Apache9 merged pull request #3818: HBASE-26402 Remove branch-1.4 from compatibility matrix and release m…

2021-11-06 Thread GitBox
Apache9 merged pull request #3818: URL: https://github.com/apache/hbase/pull/3818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HBASE-26428) Add hadoop-3.3.1 to our hadoop checks

2021-11-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26428: -- Summary: Add hadoop-3.3.1 to our hadoop checks (was: Add 3.3.1 for our hadoop checks) > Add

[jira] [Assigned] (HBASE-26428) Add 3.3.1 for our hadoop checks

2021-11-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-26428: - Assignee: Duo Zhang > Add 3.3.1 for our hadoop checks > --- > >

[GitHub] [hbase] Apache9 commented on a change in pull request #3732: HBASE-26337 Optimization for weighted random generators

2021-11-06 Thread GitBox
Apache9 commented on a change in pull request #3732: URL: https://github.com/apache/hbase/pull/3732#discussion_r744130876 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/CostFunction.java ## @@ -83,6 +83,10 @@ protected void regionMoved(int

[jira] [Resolved] (HBASE-26263) [Rolling Upgrading] Persist the StoreFileTracker configurations to TableDescriptor for existing tables

2021-11-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26263. --- Fix Version/s: HBASE-26067 Hadoop Flags: Reviewed Resolution: Fixed Merged to branch

[GitHub] [hbase] Apache9 merged pull request #3700: HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur…

2021-11-06 Thread GitBox
Apache9 merged pull request #3700: URL: https://github.com/apache/hbase/pull/3700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache9 commented on pull request #3700: HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur…

2021-11-06 Thread GitBox
Apache9 commented on pull request #3700: URL: https://github.com/apache/hbase/pull/3700#issuecomment-962458105 The failed UTs seems not related. Let me merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (HBASE-26402) Remove branch-1.4 from compatibility matrix and release manager section in our ref guide

2021-11-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17439684#comment-17439684 ] Hudson commented on HBASE-26402: Results for branch master [build #434 on

[jira] [Commented] (HBASE-26427) Modify download page to mention that 2.4.x is the stable release line

2021-11-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17439685#comment-17439685 ] Hudson commented on HBASE-26427: Results for branch master [build #434 on

[jira] [Commented] (HBASE-25322) Redundant Reference file in bottom region of split

2021-11-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17439683#comment-17439683 ] Hudson commented on HBASE-25322: Results for branch master [build #434 on

[jira] [Commented] (HBASE-25322) Redundant Reference file in bottom region of split

2021-11-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17439644#comment-17439644 ] Hudson commented on HBASE-25322: Results for branch branch-2 [build #387 on

[GitHub] [hbase] Apache-HBase commented on pull request #3820: HBASE-26430 Increase log level in DefaultHeapMemoryTuner from DEBUG to INFO

2021-11-06 Thread GitBox
Apache-HBase commented on pull request #3820: URL: https://github.com/apache/hbase/pull/3820#issuecomment-962427360 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #3820: HBASE-26430 Increase log level in DefaultHeapMemoryTuner from DEBUG to INFO

2021-11-06 Thread GitBox
Apache-HBase commented on pull request #3820: URL: https://github.com/apache/hbase/pull/3820#issuecomment-962426730 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3820: HBASE-26430 Increase log level in DefaultHeapMemoryTuner from DEBUG to INFO

2021-11-06 Thread GitBox
Apache-HBase commented on pull request #3820: URL: https://github.com/apache/hbase/pull/3820#issuecomment-962405134 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m