[jira] [Commented] (HBASE-26691) Replacing log4j with reload4j for branch-2.x
[ https://issues.apache.org/jira/browse/HBASE-26691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479838#comment-17479838 ] Wei-Chiu Chuang commented on HBASE-26691: - There's a DISCUSS thread in Hadoop's dev ML. We should start one in HBase's dev ML. > Replacing log4j with reload4j for branch-2.x > > > Key: HBASE-26691 > URL: https://issues.apache.org/jira/browse/HBASE-26691 > Project: HBase > Issue Type: Task > Components: logging >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Fix For: 2.5.0, 2.4.10 > > > There are several new CVEs for log4j1 now. > As it is not suitable to upgrade to log4j2 for 2.x releases, let's replace > the log4j1 dependencies with reload4j. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-26691) Replacing log4j with reload4j for branch-2.x
[ https://issues.apache.org/jira/browse/HBASE-26691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479836#comment-17479836 ] Wei-Chiu Chuang commented on HBASE-26691: - The reload4j is a drop-in replacement of log4j1. Although in reality, the shading makes it not so trivial as it sounds... > Replacing log4j with reload4j for branch-2.x > > > Key: HBASE-26691 > URL: https://issues.apache.org/jira/browse/HBASE-26691 > Project: HBase > Issue Type: Task > Components: logging >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Fix For: 2.5.0, 2.4.10 > > > There are several new CVEs for log4j1 now. > As it is not suitable to upgrade to log4j2 for 2.x releases, let's replace > the log4j1 dependencies with reload4j. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-26691) Replacing log4j with reload4j for branch-2.x
[ https://issues.apache.org/jira/browse/HBASE-26691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479809#comment-17479809 ] Duo Zhang commented on HBASE-26691: --- The logj41 shim is not enough to make hadoop work. It does not include all the appender implementations but there are several customized appender implementations so at least, when running UTs we will fail with class not found... > Replacing log4j with reload4j for branch-2.x > > > Key: HBASE-26691 > URL: https://issues.apache.org/jira/browse/HBASE-26691 > Project: HBase > Issue Type: Task > Components: logging >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Fix For: 2.5.0, 2.4.10 > > > There are several new CVEs for log4j1 now. > As it is not suitable to upgrade to log4j2 for 2.x releases, let's replace > the log4j1 dependencies with reload4j. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-24443) Refactor TestCustomSaslAuthenticationProvider
[
https://issues.apache.org/jira/browse/HBASE-24443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479796#comment-17479796
]
Hudson commented on HBASE-24443:
Results for branch branch-2.4
[build #276 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/276/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/276/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/276/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/276/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/276/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Refactor TestCustomSaslAuthenticationProvider
> -
>
> Key: HBASE-24443
> URL: https://issues.apache.org/jira/browse/HBASE-24443
> Project: HBase
> Issue Type: Improvement
> Components: test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-1
>
>
> As now it will restart the cluster after every single test, which is not
> necessary, as we only need to restart the cluster when we change the rpc
> server implementation, it is better to split it into two files.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (HBASE-26689) Backport HBASE-24443 Refactor TestCustomSaslAuthenticationProvider
[
https://issues.apache.org/jira/browse/HBASE-26689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479795#comment-17479795
]
Hudson commented on HBASE-26689:
Results for branch branch-2.4
[build #276 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/276/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/276/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/276/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/276/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/276/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Backport HBASE-24443 Refactor TestCustomSaslAuthenticationProvider
> --
>
> Key: HBASE-26689
> URL: https://issues.apache.org/jira/browse/HBASE-26689
> Project: HBase
> Issue Type: Test
> Components: test
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Minor
> Fix For: 2.5.0, 2.4.10
>
>
> Test execution times for TestCustomSaslAuthenticationProvider on branch-2
> takes 24 minutes. The refactored tests after HBASE-24443 on master succeed in
> just under 2 * 2 minutes.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (HBASE-26691) Replacing log4j with reload4j for branch-2.x
[ https://issues.apache.org/jira/browse/HBASE-26691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479788#comment-17479788 ] Sean Busbey commented on HBASE-26691: - (if there was a DISCUSS thread I've overlooked please point me there) > Replacing log4j with reload4j for branch-2.x > > > Key: HBASE-26691 > URL: https://issues.apache.org/jira/browse/HBASE-26691 > Project: HBase > Issue Type: Task > Components: logging >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Fix For: 2.5.0, 2.4.10 > > > There are several new CVEs for log4j1 now. > As it is not suitable to upgrade to log4j2 for 2.x releases, let's replace > the log4j1 dependencies with reload4j. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-26691) Replacing log4j with reload4j for branch-2.x
[ https://issues.apache.org/jira/browse/HBASE-26691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479787#comment-17479787 ] Sean Busbey commented on HBASE-26691: - What's the tradeoff compared to using the log4j 1 shim provided by the asf logging pmc? > Replacing log4j with reload4j for branch-2.x > > > Key: HBASE-26691 > URL: https://issues.apache.org/jira/browse/HBASE-26691 > Project: HBase > Issue Type: Task > Components: logging >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Fix For: 2.5.0, 2.4.10 > > > There are several new CVEs for log4j1 now. > As it is not suitable to upgrade to log4j2 for 2.x releases, let's replace > the log4j1 dependencies with reload4j. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-26691) Replacing log4j with reload4j for branch-2.x
[ https://issues.apache.org/jira/browse/HBASE-26691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479781#comment-17479781 ] Wei-Chiu Chuang commented on HBASE-26691: - +1 > Replacing log4j with reload4j for branch-2.x > > > Key: HBASE-26691 > URL: https://issues.apache.org/jira/browse/HBASE-26691 > Project: HBase > Issue Type: Task > Components: logging >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Fix For: 2.5.0, 2.4.10 > > > There are several new CVEs for log4j1 now. > As it is not suitable to upgrade to log4j2 for 2.x releases, let's replace > the log4j1 dependencies with reload4j. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (HBASE-26691) Replacing log4j with reload4j for branch-2.x
Duo Zhang created HBASE-26691: - Summary: Replacing log4j with reload4j for branch-2.x Key: HBASE-26691 URL: https://issues.apache.org/jira/browse/HBASE-26691 Project: HBase Issue Type: Task Components: logging Reporter: Duo Zhang There are several new CVEs for log4j1 now. As it is not suitable to upgrade to log4j2 for 2.x releases, let's replace the log4j1 dependencies with reload4j. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (HBASE-26691) Replacing log4j with reload4j for branch-2.x
[ https://issues.apache.org/jira/browse/HBASE-26691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-26691: - Assignee: Duo Zhang > Replacing log4j with reload4j for branch-2.x > > > Key: HBASE-26691 > URL: https://issues.apache.org/jira/browse/HBASE-26691 > Project: HBase > Issue Type: Task > Components: logging >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Fix For: 2.5.0, 2.4.10 > > > There are several new CVEs for log4j1 now. > As it is not suitable to upgrade to log4j2 for 2.x releases, let's replace > the log4j1 dependencies with reload4j. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26691) Replacing log4j with reload4j for branch-2.x
[ https://issues.apache.org/jira/browse/HBASE-26691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26691: -- Fix Version/s: 2.5.0 2.4.10 > Replacing log4j with reload4j for branch-2.x > > > Key: HBASE-26691 > URL: https://issues.apache.org/jira/browse/HBASE-26691 > Project: HBase > Issue Type: Task > Components: logging >Reporter: Duo Zhang >Priority: Critical > Fix For: 2.5.0, 2.4.10 > > > There are several new CVEs for log4j1 now. > As it is not suitable to upgrade to log4j2 for 2.x releases, let's replace > the log4j1 dependencies with reload4j. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-26007) java.io.IOException: Invalid token in javax.security.sasl.qop: ^DDI
[ https://issues.apache.org/jira/browse/HBASE-26007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479746#comment-17479746 ] Josh Elser commented on HBASE-26007: Maybe Venkat can report if recompiling HBase against his version of Hadoop will fix the issue for him too. IIRC, we have documented in the HBase book that it's a best practice to compile HBase against the specific version of Hadoop you're using. > java.io.IOException: Invalid token in javax.security.sasl.qop: ^DDI > --- > > Key: HBASE-26007 > URL: https://issues.apache.org/jira/browse/HBASE-26007 > Project: HBase > Issue Type: Bug > Components: master >Affects Versions: 2.3.5 >Reporter: Venkat A >Priority: Major > > Hi All, > We have Hadoop 3.2.2 and HBase 2.3.5 Versions installed. (java version > "1.8.0_291") > > While bringing up HBase master, I'm seeing following error messages in HBase > master log. > > Other HDFS. clients like Spark,MapReduce,Solr etc are able to write HDFS but > HBase is unable to write its meta files in HDFS with following exceptions. > > > Summary of Error logs from hbase master > 2021-06-15 03:57:45,968 INFO [Thread-7] hdfs.DataStreamer: Exception in > createBlockOutputStream > java.io.IOException: Invalid token in javax.security.sasl.qop: ^DD > 2021-06-15 03:57:45,939 WARN [Thread-7] hdfs.DataStreamer: Abandoning > BP-1583998547-10.10.10.3-1622148262434:blk_1073743393_2570 > 2021-06-15 03:57:45,946 WARN [Thread-7] hdfs.DataStreamer: Excluding > datanode > DatanodeInfoWithStorage[10.10.10.3:50010,DS-281c3377-2bc1-47ea-8302-43108ee69430,DISK] > 2021-06-15 03:57:45,994 WARN [Thread-7] hdfs.DataStreamer: DataStreamer > Exception > org.apache.hadoop.ipc.RemoteException(java.io.IOException): File > /hbase/data/data/hbase/meta/.tmp/.tableinfo.01 could only be written > to 0 of the 1 minReplication nodes. There are 3 datanode(s) running and 3 > node(s) are excluded in this operation. > 2021-06-15 03:57:46,023 INFO [Thread-9] hdfs.DataStreamer: Exception in > createBlockOutputStream > java.io.IOException: Invalid token in javax.security.sasl.qop: ^DDI > 2021-06-15 03:57:46,035 INFO [Thread-9] hdfs.DataStreamer: Exception in > createBlockOutputStream > java.io.IOException: Invalid token in javax.security.sasl.qop: ^DD > 2021-06-15 03:57:46,508 ERROR [main] regionserver.HRegionServer: Failed > construction RegionServer > java.io.IOException: Failed update hbase:meta table descriptor > 2021-06-15 03:57:46,509 ERROR [main] master.HMasterCommandLine: Master > exiting > java.lang.RuntimeException: Failed construction of Master: class > org.apache.hadoop.hbase.master.HMaster. > Caused by: java.io.IOException: Failed update hbase:meta table descriptor > > Not sure what is the root cause behind this. Any comments/suggestions on this > is much appreciated. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (HBASE-26655) Initial commit with basic functionality and example code
[ https://issues.apache.org/jira/browse/HBASE-26655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser resolved HBASE-26655. Hadoop Flags: Reviewed Resolution: Fixed > Initial commit with basic functionality and example code > > > Key: HBASE-26655 > URL: https://issues.apache.org/jira/browse/HBASE-26655 > Project: HBase > Issue Type: Sub-task > Components: security >Reporter: Andor Molnar >Assignee: Andor Molnar >Priority: Major > Fix For: HBASE-26553 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] joshelser closed pull request #4019: HBASE-26553 OAuth Bearer authentication mech plugin for SASL (initial commit)
joshelser closed pull request #4019: URL: https://github.com/apache/hbase/pull/4019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] joshelser commented on pull request #4019: HBASE-26553 OAuth Bearer authentication mech plugin for SASL (initial commit)
joshelser commented on pull request #4019: URL: https://github.com/apache/hbase/pull/4019#issuecomment-1018016239 Merged into HBASE-26553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] joshelser commented on pull request #4019: HBASE-26553 OAuth Bearer authentication mech plugin for SASL (initial commit)
joshelser commented on pull request #4019: URL: https://github.com/apache/hbase/pull/4019#issuecomment-1018015952 Fixing the javadoc warning as I merge this. I think javadoc is wrong in its warning, but I'm just removing the `@see` tag and replacing it as `See` :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26007) java.io.IOException: Invalid token in javax.security.sasl.qop: ^DDI
[ https://issues.apache.org/jira/browse/HBASE-26007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479665#comment-17479665 ] HERINIAINA DESLANDES commented on HBASE-26007: -- Hello I do not know if it is still relevant. I had the same issue.with habse 2.4.9 and hadoop 3.3.1 To resolve it: * I compile hbase with hadoop 3.3.1 * I move to jdk 11 regards > java.io.IOException: Invalid token in javax.security.sasl.qop: ^DDI > --- > > Key: HBASE-26007 > URL: https://issues.apache.org/jira/browse/HBASE-26007 > Project: HBase > Issue Type: Bug > Components: master >Affects Versions: 2.3.5 >Reporter: Venkat A >Priority: Major > > Hi All, > We have Hadoop 3.2.2 and HBase 2.3.5 Versions installed. (java version > "1.8.0_291") > > While bringing up HBase master, I'm seeing following error messages in HBase > master log. > > Other HDFS. clients like Spark,MapReduce,Solr etc are able to write HDFS but > HBase is unable to write its meta files in HDFS with following exceptions. > > > Summary of Error logs from hbase master > 2021-06-15 03:57:45,968 INFO [Thread-7] hdfs.DataStreamer: Exception in > createBlockOutputStream > java.io.IOException: Invalid token in javax.security.sasl.qop: ^DD > 2021-06-15 03:57:45,939 WARN [Thread-7] hdfs.DataStreamer: Abandoning > BP-1583998547-10.10.10.3-1622148262434:blk_1073743393_2570 > 2021-06-15 03:57:45,946 WARN [Thread-7] hdfs.DataStreamer: Excluding > datanode > DatanodeInfoWithStorage[10.10.10.3:50010,DS-281c3377-2bc1-47ea-8302-43108ee69430,DISK] > 2021-06-15 03:57:45,994 WARN [Thread-7] hdfs.DataStreamer: DataStreamer > Exception > org.apache.hadoop.ipc.RemoteException(java.io.IOException): File > /hbase/data/data/hbase/meta/.tmp/.tableinfo.01 could only be written > to 0 of the 1 minReplication nodes. There are 3 datanode(s) running and 3 > node(s) are excluded in this operation. > 2021-06-15 03:57:46,023 INFO [Thread-9] hdfs.DataStreamer: Exception in > createBlockOutputStream > java.io.IOException: Invalid token in javax.security.sasl.qop: ^DDI > 2021-06-15 03:57:46,035 INFO [Thread-9] hdfs.DataStreamer: Exception in > createBlockOutputStream > java.io.IOException: Invalid token in javax.security.sasl.qop: ^DD > 2021-06-15 03:57:46,508 ERROR [main] regionserver.HRegionServer: Failed > construction RegionServer > java.io.IOException: Failed update hbase:meta table descriptor > 2021-06-15 03:57:46,509 ERROR [main] master.HMasterCommandLine: Master > exiting > java.lang.RuntimeException: Failed construction of Master: class > org.apache.hadoop.hbase.master.HMaster. > Caused by: java.io.IOException: Failed update hbase:meta table descriptor > > Not sure what is the root cause behind this. Any comments/suggestions on this > is much appreciated. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #4030: HBASE-26587 Introduce a new Admin API to change SFT implementation
Apache-HBase commented on pull request #4030: URL: https://github.com/apache/hbase/pull/4030#issuecomment-1017830969 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 28s | master passed | | +1 :green_heart: | compile | 2m 55s | master passed | | +1 :green_heart: | shadedjars | 9m 6s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 48s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 19s | the patch passed | | +1 :green_heart: | compile | 2m 55s | the patch passed | | +1 :green_heart: | javac | 2m 55s | the patch passed | | +1 :green_heart: | shadedjars | 9m 7s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 47s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 49s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 31s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 211m 56s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 8m 51s | hbase-thrift in the patch passed. | | | | 263m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4030/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4030 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 13ac98a95122 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1d2b8a033d | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4030/8/testReport/ | | Max. process+thread count | 3346 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4030/8/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4019: HBASE-26553 OAuth Bearer authentication mech plugin for SASL (initial commit)
Apache-HBase commented on pull request #4019: URL: https://github.com/apache/hbase/pull/4019#issuecomment-1017808818 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-26553 Compile Tests _ | | +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 24s | HBASE-26553 passed | | +1 :green_heart: | compile | 2m 52s | HBASE-26553 passed | | +1 :green_heart: | shadedjars | 8m 23s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 26s | HBASE-26553 passed | | -0 :warning: | patch | 13m 48s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 8s | the patch passed | | +1 :green_heart: | compile | 3m 8s | the patch passed | | +1 :green_heart: | javac | 3m 8s | the patch passed | | +1 :green_heart: | shadedjars | 8m 51s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 23s | hbase-client generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3) | | -0 :warning: | javadoc | 2m 26s | root generated 1 new + 57 unchanged - 0 fixed = 58 total (was 57) | ||| _ Other Tests _ | | -1 :x: | unit | 310m 43s | root in the patch failed. | | | | 355m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4019/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4019 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e0867940466d 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-26553 / 803afee777 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4019/8/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-client.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4019/8/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-root.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4019/8/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4019/8/testReport/ | | Max. process+thread count | 3389 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-resource-bundle hbase-server hbase-examples . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4019/8/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4030: HBASE-26587 Introduce a new Admin API to change SFT implementation
Apache-HBase commented on pull request #4030: URL: https://github.com/apache/hbase/pull/4030#issuecomment-1017767624 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 27s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 49s | master passed | | +1 :green_heart: | compile | 3m 45s | master passed | | +1 :green_heart: | shadedjars | 9m 19s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 20s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 45s | the patch passed | | +1 :green_heart: | compile | 3m 31s | the patch passed | | +1 :green_heart: | javac | 3m 31s | the patch passed | | +1 :green_heart: | shadedjars | 8m 53s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 16s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 0s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 23s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 139m 46s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 6m 27s | hbase-thrift in the patch passed. | | | | 192m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4030/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4030 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 156449920d71 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1d2b8a033d | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4030/8/testReport/ | | Max. process+thread count | 4500 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4030/8/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4030: HBASE-26587 Introduce a new Admin API to change SFT implementation
Apache-HBase commented on pull request #4030: URL: https://github.com/apache/hbase/pull/4030#issuecomment-1017657812 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 13s | master passed | | +1 :green_heart: | compile | 6m 44s | master passed | | +1 :green_heart: | checkstyle | 2m 37s | master passed | | +1 :green_heart: | spotbugs | 8m 33s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 56s | the patch passed | | +1 :green_heart: | compile | 6m 43s | the patch passed | | +1 :green_heart: | cc | 6m 43s | the patch passed | | +1 :green_heart: | javac | 6m 43s | the patch passed | | +1 :green_heart: | checkstyle | 0m 12s | The patch passed checkstyle in hbase-protocol-shaded | | +1 :green_heart: | checkstyle | 0m 30s | hbase-client: The patch generated 0 new + 110 unchanged - 2 fixed = 110 total (was 112) | | +1 :green_heart: | checkstyle | 1m 8s | hbase-server: The patch generated 0 new + 200 unchanged - 2 fixed = 200 total (was 202) | | +1 :green_heart: | checkstyle | 0m 43s | The patch passed checkstyle in hbase-thrift | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 19m 41s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | hbaseprotoc | 2m 37s | the patch passed | | +1 :green_heart: | spotbugs | 9m 41s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 54s | The patch does not generate ASF License warnings. | | | | 79m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4030/8/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4030 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool | | uname | Linux 4cd633146e98 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1d2b8a033d | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 96 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4030/8/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26689) Backport HBASE-24443 Refactor TestCustomSaslAuthenticationProvider
[ https://issues.apache.org/jira/browse/HBASE-26689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479435#comment-17479435 ] Peter Somogyi commented on HBASE-26689: --- Seems so. There is no 2.3.8 version in Jira but I was not able to find the EOL email on the dev list. > Backport HBASE-24443 Refactor TestCustomSaslAuthenticationProvider > -- > > Key: HBASE-26689 > URL: https://issues.apache.org/jira/browse/HBASE-26689 > Project: HBase > Issue Type: Test > Components: test >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Minor > Fix For: 2.5.0, 2.4.10 > > > Test execution times for TestCustomSaslAuthenticationProvider on branch-2 > takes 24 minutes. The refactored tests after HBASE-24443 on master succeed in > just under 2 * 2 minutes. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-26689) Backport HBASE-24443 Refactor TestCustomSaslAuthenticationProvider
[ https://issues.apache.org/jira/browse/HBASE-26689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479427#comment-17479427 ] Duo Zhang commented on HBASE-26689: --- I think branch-2.3 is already EOL? > Backport HBASE-24443 Refactor TestCustomSaslAuthenticationProvider > -- > > Key: HBASE-26689 > URL: https://issues.apache.org/jira/browse/HBASE-26689 > Project: HBase > Issue Type: Test > Components: test >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Minor > Fix For: 2.5.0, 2.4.10 > > > Test execution times for TestCustomSaslAuthenticationProvider on branch-2 > takes 24 minutes. The refactored tests after HBASE-24443 on master succeed in > just under 2 * 2 minutes. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-26690) Modify FSTableDescriptors to not rely on renaming when writing TableDescriptor
[ https://issues.apache.org/jira/browse/HBASE-26690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479426#comment-17479426 ] Duo Zhang commented on HBASE-26690: --- I think what could be done is to catch DeserializationException(which could only be caused by InvalidProtocolBufferException since we pass a byte array), and then skip loading this table descriptor. > Modify FSTableDescriptors to not rely on renaming when writing TableDescriptor > -- > > Key: HBASE-26690 > URL: https://issues.apache.org/jira/browse/HBASE-26690 > Project: HBase > Issue Type: Sub-task > Components: master >Reporter: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (HBASE-24048) [Flakey Tests] Re-enable TestCustomSaslAuthenticationProvider#testNegativeAuthentication
[ https://issues.apache.org/jira/browse/HBASE-24048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-24048. --- Resolution: Duplicate Fixed with HBASE-26689. > [Flakey Tests] Re-enable > TestCustomSaslAuthenticationProvider#testNegativeAuthentication > > > Key: HBASE-24048 > URL: https://issues.apache.org/jira/browse/HBASE-24048 > Project: HBase > Issue Type: Sub-task > Components: flakies >Reporter: Michael Stack >Priority: Major > > See parent issue which disables flakey test. This task is to reenable once > flakey-ness has been cleared. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (HBASE-26689) Backport HBASE-24443 Refactor TestCustomSaslAuthenticationProvider
[ https://issues.apache.org/jira/browse/HBASE-26689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-26689. --- Fix Version/s: 2.5.0 2.4.10 Resolution: Fixed Thanks for the review [~zhangduo]! Merged to branch-2, branch-2.5, branch-2.4, and branch-2.3. > Backport HBASE-24443 Refactor TestCustomSaslAuthenticationProvider > -- > > Key: HBASE-26689 > URL: https://issues.apache.org/jira/browse/HBASE-26689 > Project: HBase > Issue Type: Test > Components: test >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Minor > Fix For: 2.5.0, 2.4.10 > > > Test execution times for TestCustomSaslAuthenticationProvider on branch-2 > takes 24 minutes. The refactored tests after HBASE-24443 on master succeed in > just under 2 * 2 minutes. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-26690) Modify FSTableDescriptors to not rely on renaming when writing TableDescriptor
[ https://issues.apache.org/jira/browse/HBASE-26690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479417#comment-17479417 ] Duo Zhang commented on HBASE-26690: --- [~wchevreuil] FYI. > Modify FSTableDescriptors to not rely on renaming when writing TableDescriptor > -- > > Key: HBASE-26690 > URL: https://issues.apache.org/jira/browse/HBASE-26690 > Project: HBase > Issue Type: Sub-task > Components: master >Reporter: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (HBASE-26690) Modify FSTableDescriptors to not rely on renaming when writing TableDescriptor
Duo Zhang created HBASE-26690: - Summary: Modify FSTableDescriptors to not rely on renaming when writing TableDescriptor Key: HBASE-26690 URL: https://issues.apache.org/jira/browse/HBASE-26690 Project: HBase Issue Type: Sub-task Components: master Reporter: Duo Zhang -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26670) HFileLinkCleaner should be added even if snapshot is disabled
[ https://issues.apache.org/jira/browse/HBASE-26670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26670: -- Component/s: snapshots > HFileLinkCleaner should be added even if snapshot is disabled > - > > Key: HBASE-26670 > URL: https://issues.apache.org/jira/browse/HBASE-26670 > Project: HBase > Issue Type: Bug > Components: snapshots >Reporter: Yi Mei >Priority: Critical > > We encountered a problem in our cluster: > 1. Cluster has many snapshots, cause the archive directory is too big. > 2. We delete some snapshots, but the cleaner runs slowly because this is a > race in synchronized method of SnapshotHFileCleaner. > 3. We delete all snapshots, and disable snapshot > feature(hbase.snapshot.enabled=false), so the cleaner will skip the > synchronized method in SnapshotHFileCleaner. > 4. After cleaner runs, some back reference and data files under archive > directory are deleted, but they are still used by some restored tables. This > does not meet expectations. > One solution is add HFileLinkCleaner even if snapshot is disabled. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26670) HFileLinkCleaner should be added even if snapshot is disabled
[ https://issues.apache.org/jira/browse/HBASE-26670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26670: -- Priority: Critical (was: Minor) > HFileLinkCleaner should be added even if snapshot is disabled > - > > Key: HBASE-26670 > URL: https://issues.apache.org/jira/browse/HBASE-26670 > Project: HBase > Issue Type: Bug >Reporter: Yi Mei >Priority: Critical > > We encountered a problem in our cluster: > 1. Cluster has many snapshots, cause the archive directory is too big. > 2. We delete some snapshots, but the cleaner runs slowly because this is a > race in synchronized method of SnapshotHFileCleaner. > 3. We delete all snapshots, and disable snapshot > feature(hbase.snapshot.enabled=false), so the cleaner will skip the > synchronized method in SnapshotHFileCleaner. > 4. After cleaner runs, some back reference and data files under archive > directory are deleted, but they are still used by some restored tables. This > does not meet expectations. > One solution is add HFileLinkCleaner even if snapshot is disabled. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-26670) HFileLinkCleaner should be added even if snapshot is disabled
[ https://issues.apache.org/jira/browse/HBASE-26670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479415#comment-17479415 ] Duo Zhang commented on HBASE-26670: --- So the problem here is that, if we set hbase.snapshot.enabled=false, then some restored tables may loss data? Seems a dangeours bug... > HFileLinkCleaner should be added even if snapshot is disabled > - > > Key: HBASE-26670 > URL: https://issues.apache.org/jira/browse/HBASE-26670 > Project: HBase > Issue Type: Bug >Reporter: Yi Mei >Priority: Minor > > We encountered a problem in our cluster: > 1. Cluster has many snapshots, cause the archive directory is too big. > 2. We delete some snapshots, but the cleaner runs slowly because this is a > race in synchronized method of SnapshotHFileCleaner. > 3. We delete all snapshots, and disable snapshot > feature(hbase.snapshot.enabled=false), so the cleaner will skip the > synchronized method in SnapshotHFileCleaner. > 4. After cleaner runs, some back reference and data files under archive > directory are deleted, but they are still used by some restored tables. This > does not meet expectations. > One solution is add HFileLinkCleaner even if snapshot is disabled. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] Apache9 commented on pull request #4030: HBASE-26587 Introduce a new Admin API to change SFT implementation
Apache9 commented on pull request #4030: URL: https://github.com/apache/hbase/pull/4030#issuecomment-1017578816 Ping @joshelser . I think this is an important feature. After this we could introduce new shell command to migrate the all the tables for a cluster. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4019: HBASE-26553 OAuth Bearer authentication mech plugin for SASL (initial commit)
Apache-HBase commented on pull request #4019: URL: https://github.com/apache/hbase/pull/4019#issuecomment-1017554302 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-26553 Compile Tests _ | | +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 47s | HBASE-26553 passed | | +1 :green_heart: | compile | 8m 58s | HBASE-26553 passed | | +1 :green_heart: | checkstyle | 1m 59s | HBASE-26553 passed | | +1 :green_heart: | spotbugs | 15m 6s | HBASE-26553 passed | | -0 :warning: | patch | 11m 29s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 56s | the patch passed | | +1 :green_heart: | compile | 9m 45s | the patch passed | | +1 :green_heart: | javac | 9m 45s | the patch passed | | +1 :green_heart: | checkstyle | 2m 4s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 20m 7s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotbugs | 17m 6s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 17s | The patch does not generate ASF License warnings. | | | | 95m 30s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4019/8/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4019 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml | | uname | Linux 293611f1f456 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-26553 / 803afee777 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 141 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-resource-bundle hbase-server hbase-examples . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4019/8/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] petersomogyi merged pull request #4049: HBASE-26689 Backport HBASE-24443 Refactor TestCustomSaslAuthenticationProvider
petersomogyi merged pull request #4049: URL: https://github.com/apache/hbase/pull/4049 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4019: HBASE-26553 OAuth Bearer authentication mech plugin for SASL (initial commit)
Apache-HBase commented on pull request #4019: URL: https://github.com/apache/hbase/pull/4019#issuecomment-1017516837 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-26553 Compile Tests _ | | +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 50s | HBASE-26553 passed | | +1 :green_heart: | compile | 3m 22s | HBASE-26553 passed | | +1 :green_heart: | shadedjars | 8m 45s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 5m 18s | HBASE-26553 passed | | -0 :warning: | patch | 15m 6s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 51s | the patch passed | | +1 :green_heart: | compile | 3m 32s | the patch passed | | +1 :green_heart: | javac | 3m 32s | the patch passed | | +1 :green_heart: | shadedjars | 9m 4s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 5m 17s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 6m 29s | root in the patch failed. | | | | 56m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4019/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4019 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 935a6f3fa630 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-26553 / 803afee777 | | Default Java | AdoptOpenJDK-11.0.10+9 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4019/8/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4019/8/testReport/ | | Max. process+thread count | 814 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-resource-bundle hbase-server hbase-examples . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4019/8/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] petersomogyi commented on pull request #4049: HBASE-26689 Backport HBASE-24443 Refactor TestCustomSaslAuthenticationProvider
petersomogyi commented on pull request #4049: URL: https://github.com/apache/hbase/pull/4049#issuecomment-1017505091 The mvninstall failure on branch-2 is unrelated. Might have been caused by some network issues on the build machine. Build with the commit succeeded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4049: HBASE-26689 Backport HBASE-24443 Refactor TestCustomSaslAuthenticationProvider
Apache-HBase commented on pull request #4049: URL: https://github.com/apache/hbase/pull/4049#issuecomment-1017502116 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 22s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 2s | branch-2 passed | | +1 :green_heart: | compile | 1m 3s | branch-2 passed | | +1 :green_heart: | shadedjars | 7m 11s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 2s | the patch passed | | +1 :green_heart: | compile | 1m 2s | the patch passed | | +1 :green_heart: | javac | 1m 2s | the patch passed | | +1 :green_heart: | shadedjars | 7m 13s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 218m 38s | hbase-server in the patch passed. | | | | 247m 44s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4049/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4049 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 9797189040d3 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / c2b4ccdc1d | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4049/2/testReport/ | | Max. process+thread count | 2743 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4049/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4049: HBASE-26689 Backport HBASE-24443 Refactor TestCustomSaslAuthenticationProvider
Apache-HBase commented on pull request #4049: URL: https://github.com/apache/hbase/pull/4049#issuecomment-1017429971 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | -1 :x: | mvninstall | 4m 20s | root in branch-2 failed. | | +1 :green_heart: | compile | 1m 8s | branch-2 passed | | +1 :green_heart: | shadedjars | 7m 20s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 15s | the patch passed | | +1 :green_heart: | compile | 1m 10s | the patch passed | | +1 :green_heart: | javac | 1m 10s | the patch passed | | +1 :green_heart: | shadedjars | 7m 15s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 42s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 138m 14s | hbase-server in the patch passed. | | | | 167m 49s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4049/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4049 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c79aa4b210fe 4.15.0-161-generic #169-Ubuntu SMP Fri Oct 15 13:41:54 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / c2b4ccdc1d | | Default Java | AdoptOpenJDK-11.0.10+9 | | mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4049/2/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4049/2/testReport/ | | Max. process+thread count | 3768 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4049/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4049: HBASE-26689 Backport HBASE-24443 Refactor TestCustomSaslAuthenticationProvider
Apache-HBase commented on pull request #4049: URL: https://github.com/apache/hbase/pull/4049#issuecomment-1017314221 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 38s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 46s | branch-2 passed | | +1 :green_heart: | compile | 3m 41s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 19s | branch-2 passed | | +1 :green_heart: | spotbugs | 2m 30s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 22s | the patch passed | | +1 :green_heart: | compile | 3m 36s | the patch passed | | +1 :green_heart: | javac | 3m 36s | the patch passed | | +1 :green_heart: | checkstyle | 1m 19s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 16m 45s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 34s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 52m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4049/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4049 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux da3931ab71e2 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / c2b4ccdc1d | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 86 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4049/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4048: HBASE-26688 Result#advance, current are not thread safe. But the precreated EMPTY_RESULT like objects can be shared by multi client threa
Apache-HBase commented on pull request #4048: URL: https://github.com/apache/hbase/pull/4048#issuecomment-1017288044 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 50s | master passed | | +1 :green_heart: | compile | 0m 58s | master passed | | +1 :green_heart: | checkstyle | 0m 28s | master passed | | +1 :green_heart: | spotbugs | 1m 1s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 53s | the patch passed | | +1 :green_heart: | compile | 0m 57s | the patch passed | | +1 :green_heart: | javac | 0m 57s | the patch passed | | +1 :green_heart: | checkstyle | 0m 28s | hbase-client: The patch generated 0 new + 11 unchanged - 2 fixed = 11 total (was 13) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 19m 29s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotbugs | 1m 12s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 41m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4048 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8261bf61cd2c 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1d2b8a033d | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 95 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4048: HBASE-26688 Result#advance, current are not thread safe. But the precreated EMPTY_RESULT like objects can be shared by multi client threa
Apache-HBase commented on pull request #4048: URL: https://github.com/apache/hbase/pull/4048#issuecomment-1017279045 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 52s | master passed | | +1 :green_heart: | compile | 0m 31s | master passed | | +1 :green_heart: | shadedjars | 8m 24s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 29s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 37s | the patch passed | | +1 :green_heart: | compile | 0m 31s | the patch passed | | +1 :green_heart: | javac | 0m 31s | the patch passed | | +1 :green_heart: | shadedjars | 8m 22s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 23s | hbase-client in the patch passed. | | | | 31m 9s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4048 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 6c9f8f7b8a60 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1d2b8a033d | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/2/testReport/ | | Max. process+thread count | 301 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4048: HBASE-26688 Result#advance, current are not thread safe. But the precreated EMPTY_RESULT like objects can be shared by multi client threa
Apache-HBase commented on pull request #4048: URL: https://github.com/apache/hbase/pull/4048#issuecomment-1017277612 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 11s | master passed | | +1 :green_heart: | compile | 0m 27s | master passed | | +1 :green_heart: | shadedjars | 8m 19s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 56s | the patch passed | | +1 :green_heart: | compile | 0m 27s | the patch passed | | +1 :green_heart: | javac | 0m 27s | the patch passed | | +1 :green_heart: | shadedjars | 8m 16s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 19s | hbase-client in the patch passed. | | | | 29m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4048 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 872c58e2a6ca 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1d2b8a033d | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/2/testReport/ | | Max. process+thread count | 341 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26689) Backport HBASE-24443 Refactor TestCustomSaslAuthenticationProvider
[ https://issues.apache.org/jira/browse/HBASE-26689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479206#comment-17479206 ] Peter Somogyi commented on HBASE-26689: --- The backport also fixes and reenables the ignored negative tests. HBASE-24048 > Backport HBASE-24443 Refactor TestCustomSaslAuthenticationProvider > -- > > Key: HBASE-26689 > URL: https://issues.apache.org/jira/browse/HBASE-26689 > Project: HBase > Issue Type: Test > Components: test >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Minor > > Test execution times for TestCustomSaslAuthenticationProvider on branch-2 > takes 24 minutes. The refactored tests after HBASE-24443 on master succeed in > just under 2 * 2 minutes. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (HBASE-26689) Backport HBASE-24443 Refactor TestCustomSaslAuthenticationProvider
Peter Somogyi created HBASE-26689: - Summary: Backport HBASE-24443 Refactor TestCustomSaslAuthenticationProvider Key: HBASE-26689 URL: https://issues.apache.org/jira/browse/HBASE-26689 Project: HBase Issue Type: Test Components: test Reporter: Peter Somogyi Assignee: Peter Somogyi Test execution times for TestCustomSaslAuthenticationProvider on branch-2 takes 24 minutes. The refactored tests after HBASE-24443 on master succeed in just under 2 * 2 minutes. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26688) Result#advance, current are not thread safe. But the pre-created EMPTY_RESULT like objects can be shared by multi client threads.
[
https://issues.apache.org/jira/browse/HBASE-26688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yutong Xiao updated HBASE-26688:
Description:
Currently, we use a pre-created EMPTY_RESULT in the ProtoBuf.util to reduce the
object creation. But these objects could be shared by multi client threads. The
Result#cellScannerIndex related methods could throw confusing exception and
make the client job down. Could refine the logic of these methods.
The precreated objects in ProtoBufUtil.java:
{code:java}
private final static Cell[] EMPTY_CELL_ARRAY = new Cell[]{};
private final static Result EMPTY_RESULT = Result.create(EMPTY_CELL_ARRAY);
final static Result EMPTY_RESULT_EXISTS_TRUE = Result.create(null, true);
final static Result EMPTY_RESULT_EXISTS_FALSE = Result.create(null, false);
private final static Result EMPTY_RESULT_STALE =
Result.create(EMPTY_CELL_ARRAY, null, true);
{code}
Result#advance
{code:java}
public boolean advance() {
if (cells == null) return false;
cellScannerIndex++;
if (cellScannerIndex < this.cells.length) {
return true;
} else if (cellScannerIndex == this.cells.length) {
return false;
}
// The index of EMPTY_RESULT could be incremented by multi threads and
throw this exception.
throw new NoSuchElementException("Cannot advance beyond the last cell");
}
{code}
Result#current
{code:java}
public Cell current() {
if (cells == null
|| cellScannerIndex == INITIAL_CELLSCANNER_INDEX
|| cellScannerIndex >= cells.length)
return null;
// Although it is almost impossible,
// We can arrive here when the client threads share the common reused
EMPTY_RESULT.
return this.cells[cellScannerIndex];
}
{code}
In this case, the client can easily got confusing exceptions even if they use
different connections, tables in different threads.
We should change the if condition cells == null to isEmpty() to avoid the
client crashed from these exception.
was:
Currently, we use a pre-created EMPTY_RESULT in the ProtoBuf.util to reduce the
object creation. But these objects could be shared by multi client threads. The
Result#cellScannerIndex related methods could throw confusing exception and
make the client job down. Could refine the logic of these methods.
The precreated objects in ProtoBufUtil.java:
{code:java}
private final static Cell[] EMPTY_CELL_ARRAY = new Cell[]{};
private final static Result EMPTY_RESULT = Result.create(EMPTY_CELL_ARRAY);
final static Result EMPTY_RESULT_EXISTS_TRUE = Result.create(null, true);
final static Result EMPTY_RESULT_EXISTS_FALSE = Result.create(null, false);
private final static Result EMPTY_RESULT_STALE =
Result.create(EMPTY_CELL_ARRAY, null, true);
{code}
Result#advance
{code:java}
public boolean advance() {
if (cells == null) return false;
cellScannerIndex++;
if (cellScannerIndex < this.cells.length) {
return true;
} else if (cellScannerIndex == this.cells.length) {
return false;
}
// The index of EMPTY_RESULT could be incremented and throw this exception.
throw new NoSuchElementException("Cannot advance beyond the last cell");
}
{code}
Result#current
{code:java}
public Cell current() {
if (cells == null
|| cellScannerIndex == INITIAL_CELLSCANNER_INDEX
|| cellScannerIndex >= cells.length)
return null;
// Although it is almost impossible,
// We can arrive here when the client threads share the common reused
EMPTY_RESULT.
return this.cells[cellScannerIndex];
}
{code}
In this case, the client can easily got confusing exceptions even if they use
different connections, tables in different threads.
We should change the if condition cells == null to isEmpty() to avoid the
client crashed from these exception.
> Result#advance, current are not thread safe. But the pre-created EMPTY_RESULT
> like objects can be shared by multi client threads.
> -
>
> Key: HBASE-26688
> URL: https://issues.apache.org/jira/browse/HBASE-26688
> Project: HBase
> Issue Type: Bug
>Reporter: Yutong Xiao
>Assignee: Yutong Xiao
>Priority: Major
>
> Currently, we use a pre-created EMPTY_RESULT in the ProtoBuf.util to reduce
> the object creation. But these objects could be shared by multi client
> threads. The Result#cellScannerIndex related methods could throw confusing
> exception and make the client job down. Could refine the logic of these
> methods.
> The precreated objects in ProtoBufUtil.java:
> {code:java}
> private final static Cell[] EMPTY_CELL_ARRAY = new Cell[]{};
> private final static Result EMPTY_RESULT = Result.create(EMPTY_CELL_ARRAY);
> final static Result EMPTY_RESULT_EXISTS_TRUE = Result.create(null,
[jira] [Updated] (HBASE-26688) Result#advance, current are not thread safe. But the pre-created EMPTY_RESULT like objects can be shared by multi client threads.
[
https://issues.apache.org/jira/browse/HBASE-26688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yutong Xiao updated HBASE-26688:
Description:
Currently, we use a pre-created EMPTY_RESULT in the ProtoBuf.util to reduce the
object creation. But these objects could be shared by multi client threads. The
Result#cellScannerIndex related methods could throw confusing exception and
make the client job down. Could refine the logic of these methods.
The precreated objects in ProtoBufUtil.java:
{code:java}
private final static Cell[] EMPTY_CELL_ARRAY = new Cell[]{};
private final static Result EMPTY_RESULT = Result.create(EMPTY_CELL_ARRAY);
final static Result EMPTY_RESULT_EXISTS_TRUE = Result.create(null, true);
final static Result EMPTY_RESULT_EXISTS_FALSE = Result.create(null, false);
private final static Result EMPTY_RESULT_STALE =
Result.create(EMPTY_CELL_ARRAY, null, true);
{code}
Result#advance
{code:java}
public boolean advance() {
if (cells == null) return false;
cellScannerIndex++;
if (cellScannerIndex < this.cells.length) {
return true;
} else if (cellScannerIndex == this.cells.length) {
return false;
}
// The index of EMPTY_RESULT could be incremented and throw this exception.
throw new NoSuchElementException("Cannot advance beyond the last cell");
}
{code}
Result#current
{code:java}
public Cell current() {
if (cells == null
|| cellScannerIndex == INITIAL_CELLSCANNER_INDEX
|| cellScannerIndex >= cells.length)
return null;
// Although it is almost impossible,
// We can arrive here when the client threads share the common reused
EMPTY_RESULT.
return this.cells[cellScannerIndex];
}
{code}
In this case, the client can easily got confusing exceptions even if they use
different connections, tables in different threads.
We should change the if condition cells == null to isEmpty() to avoid the
client crashed from these exception.
was:
Currently, we use a pre-created EMPTY_RESULT in the ProtoBuf.util to reduce the
object creation. But these objects could be shared by multi client threads. The
Result#cellScannerIndex related methods could throw confusing exception and
make the client job down. Could refine the logic of these methods.
The precreated objects in ProtoBufUtil.java:
{code:java}
private final static Cell[] EMPTY_CELL_ARRAY = new Cell[]{};
private final static Result EMPTY_RESULT = Result.create(EMPTY_CELL_ARRAY);
final static Result EMPTY_RESULT_EXISTS_TRUE = Result.create(null, true);
final static Result EMPTY_RESULT_EXISTS_FALSE = Result.create(null, false);
private final static Result EMPTY_RESULT_STALE =
Result.create(EMPTY_CELL_ARRAY, null, true);
{code}
Result#advance
{code:java}
public boolean advance() {
if (cells == null) return false;
cellScannerIndex++;
if (cellScannerIndex < this.cells.length) {
return true;
} else if (cellScannerIndex == this.cells.length) {
return false;
}
// The index of EMPTY_RESULT could be incremented and throw this exception.
throw new NoSuchElementException("Cannot advance beyond the last cell");
}
{code}
Result#current
{code:java}
public Cell current() {
if (cells == null
|| cellScannerIndex == INITIAL_CELLSCANNER_INDEX
|| cellScannerIndex >= cells.length)
return null;
// Although it is almost impossible,
// We can arrive here when the client threads share the common reused
EMPTY_RESULT.
return this.cells[cellScannerIndex];
}
{code}
We should change the if condition cells == null to isEmpty() to avoid the
client crashed from these exception.
> Result#advance, current are not thread safe. But the pre-created EMPTY_RESULT
> like objects can be shared by multi client threads.
> -
>
> Key: HBASE-26688
> URL: https://issues.apache.org/jira/browse/HBASE-26688
> Project: HBase
> Issue Type: Bug
>Reporter: Yutong Xiao
>Assignee: Yutong Xiao
>Priority: Major
>
> Currently, we use a pre-created EMPTY_RESULT in the ProtoBuf.util to reduce
> the object creation. But these objects could be shared by multi client
> threads. The Result#cellScannerIndex related methods could throw confusing
> exception and make the client job down. Could refine the logic of these
> methods.
> The precreated objects in ProtoBufUtil.java:
> {code:java}
> private final static Cell[] EMPTY_CELL_ARRAY = new Cell[]{};
> private final static Result EMPTY_RESULT = Result.create(EMPTY_CELL_ARRAY);
> final static Result EMPTY_RESULT_EXISTS_TRUE = Result.create(null, true);
> final static Result EMPTY_RESULT_EXISTS_FALSE = Result.create(null, false);
> private final static Result EMPTY_RESULT_STALE =
>
