[GitHub] [hbase] Apache-HBase commented on pull request #4075: HBASE-26713 Default to LATEST_TIMESTAMP if no timestamp sent along on Increment/Append

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #4075: URL: https://github.com/apache/hbase/pull/4075#issuecomment-1023954846 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4038: HBASE-26552 Introduce retry to logroller when encounters IOException

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #4038: URL: https://github.com/apache/hbase/pull/4038#issuecomment-1023941678 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] taklwu commented on pull request #4069: HBASE-26714 Introduce path configuration for system coprocessors

2022-01-27 Thread GitBox
taklwu commented on pull request #4069: URL: https://github.com/apache/hbase/pull/4069#issuecomment-1023932127 i need to check why `TestCheckAndMutate` and `TestAsyncTableBatch` are failing with `java.lang.StackOverflowError` ``` [ERROR] Tests run: 10, Failures: 0, Errors: 1,

[GitHub] [hbase] Apache9 merged pull request #4039: HBASE-26679 Wait on the future returned by FanOutOneBlockAsyncDFSOutp…

2022-01-27 Thread GitBox
Apache9 merged pull request #4039: URL: https://github.com/apache/hbase/pull/4039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache9 commented on pull request #4039: HBASE-26679 Wait on the future returned by FanOutOneBlockAsyncDFSOutp…

2022-01-27 Thread GitBox
Apache9 commented on pull request #4039: URL: https://github.com/apache/hbase/pull/4039#issuecomment-1023902846 The javac warning is a FutureReturnValueIgnored in test code, not very important. Let me merge. Thanks @comnetwork for the great finding and fixing! -- This is an automated

[jira] [Commented] (HBASE-26717) [hbase-thirdparty] hbase-shaded-jersey packages unshaded classes

2022-01-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483566#comment-17483566 ] Andrew Kyle Purtell commented on HBASE-26717: - I did the check in the local maven cache. I

[GitHub] [hbase] Apache-HBase commented on pull request #4024: HBASE-26521 Name RPC spans as `$package.$service/$method`

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #4024: URL: https://github.com/apache/hbase/pull/4024#issuecomment-1023891568 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-25918) Upgrade hbase-thirdparty dependency to 3.5.1

2022-01-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell resolved HBASE-25918. - Resolution: Fixed > Upgrade hbase-thirdparty dependency to 3.5.1 >

[GitHub] [hbase] Apache-HBase commented on pull request #4038: HBASE-26552 Introduce retry to logroller when encounters IOException

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #4038: URL: https://github.com/apache/hbase/pull/4038#issuecomment-1023889115 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Assigned] (HBASE-26046) [JDK17] Add a JDK17 profile

2022-01-27 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang reassigned HBASE-26046: --- Assignee: (was: Wei-Chiu Chuang) > [JDK17] Add a JDK17 profile >

[jira] [Commented] (HBASE-26046) [JDK17] Add a JDK17 profile

2022-01-27 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483558#comment-17483558 ] Wei-Chiu Chuang commented on HBASE-26046: - I had worked on it but it's a shame I thought the PR

[GitHub] [hbase] Apache-HBase commented on pull request #4039: HBASE-26679 Wait on the future returned by FanOutOneBlockAsyncDFSOutp…

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #4039: URL: https://github.com/apache/hbase/pull/4039#issuecomment-1023877389 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4039: HBASE-26679 Wait on the future returned by FanOutOneBlockAsyncDFSOutp…

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #4039: URL: https://github.com/apache/hbase/pull/4039#issuecomment-1023876908 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4039: HBASE-26679 Wait on the future returned by FanOutOneBlockAsyncDFSOutp…

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #4039: URL: https://github.com/apache/hbase/pull/4039#issuecomment-1023873453 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4039: HBASE-26679 Wait on the future returned by FanOutOneBlockAsyncDFSOutp…

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #4039: URL: https://github.com/apache/hbase/pull/4039#issuecomment-1023860909 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4069: HBASE-26714 Introduce path configuration for system coprocessors

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #4069: URL: https://github.com/apache/hbase/pull/4069#issuecomment-1023860628 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4039: HBASE-26679 Wait on the future returned by FanOutOneBlockAsyncDFSOutp…

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #4039: URL: https://github.com/apache/hbase/pull/4039#issuecomment-1023860529 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4039: HBASE-26679 Wait on the future returned by FanOutOneBlockAsyncDFSOutp…

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #4039: URL: https://github.com/apache/hbase/pull/4039#issuecomment-1023857278 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] comnetwork edited a comment on pull request #4039: HBASE-26679 Wait on the future returned by FanOutOneBlockAsyncDFSOutp…

2022-01-27 Thread GitBox
comnetwork edited a comment on pull request #4039: URL: https://github.com/apache/hbase/pull/4039#issuecomment-1023827321 @Apache9, ok, I have already introduce a separated test class `TestFanOutOneBlockAsyncDFSOutputHang` for maintainability, thank you very much for reminding me. --

[GitHub] [hbase] comnetwork edited a comment on pull request #4039: HBASE-26679 Wait on the future returned by FanOutOneBlockAsyncDFSOutp…

2022-01-27 Thread GitBox
comnetwork edited a comment on pull request #4039: URL: https://github.com/apache/hbase/pull/4039#issuecomment-1023827321 @Apache9, ok, I have already introduce a separated test class `TestFanOutOneBlockAsyncDFSOutputHang` following your patch for maintainability, thank you very much for

[GitHub] [hbase] comnetwork edited a comment on pull request #4039: HBASE-26679 Wait on the future returned by FanOutOneBlockAsyncDFSOutp…

2022-01-27 Thread GitBox
comnetwork edited a comment on pull request #4039: URL: https://github.com/apache/hbase/pull/4039#issuecomment-1023827321 @Apache9, ok, I have already introduce a separated test class `TestFanOutOneBlockAsyncDFSOutputHang` for maintainability, thank you very much for reminding. -- This

[GitHub] [hbase] comnetwork edited a comment on pull request #4039: HBASE-26679 Wait on the future returned by FanOutOneBlockAsyncDFSOutp…

2022-01-27 Thread GitBox
comnetwork edited a comment on pull request #4039: URL: https://github.com/apache/hbase/pull/4039#issuecomment-1023827321 @Apache9, ok, I have already introduce a separated test class `TestFanOutOneBlockAsyncDFSOutputHang` for maintainability, thank you very much for remind. -- This is

[GitHub] [hbase] Apache-HBase commented on pull request #4069: HBASE-26714 Introduce path configuration for system coprocessors

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #4069: URL: https://github.com/apache/hbase/pull/4069#issuecomment-1023845655 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4024: HBASE-26521 Name RPC spans as `$package.$service/$method`

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #4024: URL: https://github.com/apache/hbase/pull/4024#issuecomment-1023836708 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4075: HBASE-26713 Default to LATEST_TIMESTAMP if no timestamp sent along on Increment/Append

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #4075: URL: https://github.com/apache/hbase/pull/4075#issuecomment-1023830708 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] bbeaudreault commented on pull request #4075: HBASE-26713 Default to LATEST_TIMESTAMP if no timestamp sent along on Increment/Append

2022-01-27 Thread GitBox
bbeaudreault commented on pull request #4075: URL: https://github.com/apache/hbase/pull/4075#issuecomment-1023828225 Hmm looks like an unrelated StackOverflowError in TableOperationSpanBuilder. I think it originated in https://issues.apache.org/jira/browse/HBASE-26473, which I've pinged.

[jira] [Commented] (HBASE-26473) Introduce `db.hbase.container_operations` span attribute

2022-01-27 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483525#comment-17483525 ] Bryan Beaudreault commented on HBASE-26473: --- [~ndimiduk] just making sure you see the above

[jira] [Commented] (HBASE-25918) Upgrade hbase-thirdparty dependency to 3.5.1

2022-01-27 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483523#comment-17483523 ] Duo Zhang commented on HBASE-25918: --- HBASE-25918 has already been released in several 2.4.x releases,

[GitHub] [hbase] comnetwork commented on pull request #4039: HBASE-26679 Wait on the future returned by FanOutOneBlockAsyncDFSOutp…

2022-01-27 Thread GitBox
comnetwork commented on pull request #4039: URL: https://github.com/apache/hbase/pull/4039#issuecomment-1023827321 @Apache9, ok, I would try to introduce a separated test class for maintainability, thank you very much for remind. -- This is an automated message from the Apache Git

[jira] [Commented] (HBASE-26688) Threads shared EMPTY_RESULT may lead to unexpected client job down.

2022-01-27 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483521#comment-17483521 ] Duo Zhang commented on HBASE-26688: --- For me I would define this as a bug and the old behavior is

[jira] [Updated] (HBASE-26717) [hbase-thirdparty] hbase-shaded-jersey packages unshaded classes

2022-01-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26717: Description: Found artifact with unexpected contents:

[jira] [Comment Edited] (HBASE-26717) [hbase-thirdparty] hbase-shaded-jersey packages unshaded classes

2022-01-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483511#comment-17483511 ] Andrew Kyle Purtell edited comment on HBASE-26717 at 1/28/22, 1:43 AM:

[jira] [Commented] (HBASE-26717) [hbase-thirdparty] hbase-shaded-jersey packages unshaded classes

2022-01-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483511#comment-17483511 ] Andrew Kyle Purtell commented on HBASE-26717: - branch-2 is not affected because it includes

[jira] [Updated] (HBASE-26717) [hbase-thirdparty] hbase-shaded-jersey packages unshaded classes

2022-01-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26717: Fix Version/s: 2.4.10 > [hbase-thirdparty] hbase-shaded-jersey packages unshaded

[jira] [Comment Edited] (HBASE-26688) Threads shared EMPTY_RESULT may lead to unexpected client job down.

2022-01-27 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483509#comment-17483509 ] Yutong Xiao edited comment on HBASE-26688 at 1/28/22, 1:33 AM: --- For

[jira] [Comment Edited] (HBASE-26688) Threads shared EMPTY_RESULT may lead to unexpected client job down.

2022-01-27 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483509#comment-17483509 ] Yutong Xiao edited comment on HBASE-26688 at 1/28/22, 1:33 AM: --- For

[jira] [Comment Edited] (HBASE-26717) [hbase-thirdparty] hbase-shaded-jersey packages unshaded classes

2022-01-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483508#comment-17483508 ] Andrew Kyle Purtell edited comment on HBASE-26717 at 1/28/22, 1:31 AM:

[jira] [Commented] (HBASE-26688) Threads shared EMPTY_RESULT may lead to unexpected client job down.

2022-01-27 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483509#comment-17483509 ] Yutong Xiao commented on HBASE-26688: - For non-empty Result objects, the logic is the same after the

[jira] [Updated] (HBASE-26717) [hbase-thirdparty] hbase-shaded-jersey packages unshaded classes

2022-01-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26717: Affects Version/s: hbase-thirdparty-3.5.1 (was: 2.5.0)

[jira] [Updated] (HBASE-26717) [hbase-thirdparty] hbase-shaded-jersey packages unshaded classes

2022-01-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26717: Fix Version/s: hbase-thirdparty-3.5.2 (was: 2.5.0) >

[jira] [Updated] (HBASE-26717) [hbase-thirdparty] hbase-shaded-jersey packages unshaded classes

2022-01-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26717: Summary: [hbase-thirdparty] hbase-shaded-jersey packages unshaded classes (was:

[jira] [Commented] (HBASE-26717) [branch-2.5] hbase-shaded-check-invariants check fails

2022-01-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483508#comment-17483508 ] Andrew Kyle Purtell commented on HBASE-26717: - The problem is in hbase-shaded-jersey 3.5.1's

[GitHub] [hbase] Apache-HBase commented on pull request #4075: HBASE-26713 Default to LATEST_TIMESTAMP if no timestamp sent along on Increment/Append

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #4075: URL: https://github.com/apache/hbase/pull/4075#issuecomment-1023798759 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Comment Edited] (HBASE-26717) [branch-2.5] hbase-shaded-check-invariants check fails

2022-01-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483506#comment-17483506 ] Andrew Kyle Purtell edited comment on HBASE-26717 at 1/28/22, 1:21 AM:

[jira] [Reopened] (HBASE-25918) Upgrade hbase-thirdparty dependency to 3.5.1

2022-01-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell reopened HBASE-25918: - Reopening, see HBASE-26717 > Upgrade hbase-thirdparty dependency to 3.5.1 >

[jira] [Commented] (HBASE-26717) [branch-2.5] hbase-shaded-check-invariants check fails

2022-01-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483506#comment-17483506 ] Andrew Kyle Purtell commented on HBASE-26717: - Git bisect finds this is the commit that

[jira] [Created] (HBASE-26720) ExportSnapshot should validate the source snapshot before copying files

2022-01-27 Thread David Manning (Jira)
David Manning created HBASE-26720: - Summary: ExportSnapshot should validate the source snapshot before copying files Key: HBASE-26720 URL: https://issues.apache.org/jira/browse/HBASE-26720 Project:

[jira] (HBASE-26717) [branch-2.5] hbase-shaded-check-invariants check fails

2022-01-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26717 ] Andrew Kyle Purtell deleted comment on HBASE-26717: - was (Author: apurtell): Please check the following and either correct the build or update the allowed list with

[jira] [Updated] (HBASE-26718) HFileArchiver can remove referenced StoreFiles from the archive

2022-01-27 Thread David Manning (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Manning updated HBASE-26718: -- Affects Version/s: 0.95.0 > HFileArchiver can remove referenced StoreFiles from the archive >

[jira] [Commented] (HBASE-26719) Remove 'patch' file added as part of commit for HBASE-25973

2022-01-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483494#comment-17483494 ] Andrew Kyle Purtell commented on HBASE-26719: - Removed 'patch' file added by mistake as part

[jira] [Resolved] (HBASE-26719) Remove 'patch' file added as part of commit for HBASE-25973

2022-01-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell resolved HBASE-26719. - Resolution: Fixed > Remove 'patch' file added as part of commit for HBASE-25973

[jira] [Updated] (HBASE-26719) Remove 'patch' file added as part of commit for HBASE-25973

2022-01-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26719: Fix Version/s: 2.6.0 (was: 2.4.10) > Remove 'patch' file

[jira] [Updated] (HBASE-26719) Remove 'patch' file added as part of commit for HBASE-25973

2022-01-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26719: Affects Version/s: 2.6.0 (was: 2.4.9) > Remove 'patch'

[jira] [Created] (HBASE-26719) Remove 'patch' file added as part of commit for HBASE-25973

2022-01-27 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-26719: --- Summary: Remove 'patch' file added as part of commit for HBASE-25973 Key: HBASE-26719 URL: https://issues.apache.org/jira/browse/HBASE-26719 Project:

[jira] [Created] (HBASE-26718) HFileArchiver can remove referenced StoreFiles from the archive

2022-01-27 Thread David Manning (Jira)
David Manning created HBASE-26718: - Summary: HFileArchiver can remove referenced StoreFiles from the archive Key: HBASE-26718 URL: https://issues.apache.org/jira/browse/HBASE-26718 Project: HBase

[jira] [Commented] (HBASE-26717) [branch-2.5] hbase-shaded-check-invariants check fails

2022-01-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483491#comment-17483491 ] Andrew Kyle Purtell commented on HBASE-26717: - Please check the following and either

[GitHub] [hbase] Apache-HBase commented on pull request #4024: HBASE-26521 Name RPC spans as `$package.$service/$method`

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #4024: URL: https://github.com/apache/hbase/pull/4024#issuecomment-1023774338 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Comment Edited] (HBASE-26717) [branch-2.5] hbase-shaded-check-invariants check fails

2022-01-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483487#comment-17483487 ] Andrew Kyle Purtell edited comment on HBASE-26717 at 1/28/22, 12:40 AM:

[jira] [Reopened] (HBASE-26688) Threads shared EMPTY_RESULT may lead to unexpected client job down.

2022-01-27 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reopened HBASE-26688: -- > Threads shared EMPTY_RESULT may lead to unexpected client job down. >

[jira] [Commented] (HBASE-26688) Threads shared EMPTY_RESULT may lead to unexpected client job down.

2022-01-27 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483489#comment-17483489 ] Nick Dimiduk commented on HBASE-26688: -- Exceptions are part of our API, and thus subject to our API

[GitHub] [hbase] Apache-HBase commented on pull request #4069: HBASE-26714 Introduce path configuration for system coprocessors

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #4069: URL: https://github.com/apache/hbase/pull/4069#issuecomment-1023772357 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-26717) [branch-2.5] hbase-shaded-check-invariants check fails

2022-01-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26717: Description: Found artifact with unexpected contents:

[GitHub] [hbase] Apache-HBase commented on pull request #3563: HBASE-26171 Fix MetricsRegionServer may throws NullPointerException when optional.get() is called

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3563: URL: https://github.com/apache/hbase/pull/3563#issuecomment-1023771600 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4074: HBASE-26713 Default to LATEST_TIMESTAMP if no timestamp sent along on Increment/Append

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #4074: URL: https://github.com/apache/hbase/pull/4074#issuecomment-1023771217 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-26717) [branch-2.5] hbase-shaded-check-invariants check fails

2022-01-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483487#comment-17483487 ] Andrew Kyle Purtell commented on HBASE-26717: - I've tried a few things and it makes no

[GitHub] [hbase] Apache-HBase commented on pull request #3518: HBASE-25881: Create a chore to update age related metrics

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3518: URL: https://github.com/apache/hbase/pull/3518#issuecomment-1023770351 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4074: HBASE-26713 Default to LATEST_TIMESTAMP if no timestamp sent along on Increment/Append

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #4074: URL: https://github.com/apache/hbase/pull/4074#issuecomment-1023763954 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3644: HBASE-26333 Clean shared state pollution to avoid flaky tests.

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3644: URL: https://github.com/apache/hbase/pull/3644#issuecomment-1023753613 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4074: HBASE-26713 Default to LATEST_TIMESTAMP if no timestamp sent along on Increment/Append

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #4074: URL: https://github.com/apache/hbase/pull/4074#issuecomment-1023753305 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-26717) [branch-2.5] hbase-shaded-check-invariants check fails

2022-01-27 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-26717: --- Summary: [branch-2.5] hbase-shaded-check-invariants check fails Key: HBASE-26717 URL: https://issues.apache.org/jira/browse/HBASE-26717 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #3447: HBASE-26055 Master local region "table" should be considered a system…

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3447: URL: https://github.com/apache/hbase/pull/3447#issuecomment-1023748522 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3615: HBASE-26217 Clean shared state pollution to avoid flaky tests.

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3615: URL: https://github.com/apache/hbase/pull/3615#issuecomment-1023743994 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3518: HBASE-25881: Create a chore to update age related metrics

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3518: URL: https://github.com/apache/hbase/pull/3518#issuecomment-1023737561 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4075: HBASE-26713 Default to LATEST_TIMESTAMP if no timestamp sent along on Increment/Append

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #4075: URL: https://github.com/apache/hbase/pull/4075#issuecomment-1023733665 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4076: HBASE-26472 Adhere to semantic conventions regarding table data operations (addendum)

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #4076: URL: https://github.com/apache/hbase/pull/4076#issuecomment-1023731296 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4076: HBASE-26472 Adhere to semantic conventions regarding table data operations (addendum)

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #4076: URL: https://github.com/apache/hbase/pull/4076#issuecomment-1023726363 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4076: HBASE-26472 Adhere to semantic conventions regarding table data operations (addendum)

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #4076: URL: https://github.com/apache/hbase/pull/4076#issuecomment-1023721531 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3644: HBASE-26333 Clean shared state pollution to avoid flaky tests.

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3644: URL: https://github.com/apache/hbase/pull/3644#issuecomment-1023720275 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3563: HBASE-26171 Fix MetricsRegionServer may throws NullPointerException when optional.get() is called

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3563: URL: https://github.com/apache/hbase/pull/3563#issuecomment-1023719634 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3615: HBASE-26217 Clean shared state pollution to avoid flaky tests.

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3615: URL: https://github.com/apache/hbase/pull/3615#issuecomment-1023709880 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3423: HBASE-26017 fix pe tool totalRows exceed maximum of int

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3423: URL: https://github.com/apache/hbase/pull/3423#issuecomment-1023686922 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3423: HBASE-26017 fix pe tool totalRows exceed maximum of int

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3423: URL: https://github.com/apache/hbase/pull/3423#issuecomment-1023686617 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #3423: HBASE-26017 fix pe tool totalRows exceed maximum of int

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3423: URL: https://github.com/apache/hbase/pull/3423#issuecomment-1023680419 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-26713) Increments submitted by 1.x clients will be stored with timestamp 0 on 2.x+ clusters

2022-01-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483453#comment-17483453 ] Andrew Kyle Purtell commented on HBASE-26713: - I approved the PRs and are just waiting for

[GitHub] [hbase] apurtell commented on pull request #4074: HBASE-26713 Default to LATEST_TIMESTAMP if no timestamp sent along on Increment/Append

2022-01-27 Thread GitBox
apurtell commented on pull request #4074: URL: https://github.com/apache/hbase/pull/4074#issuecomment-1023677736 Changes look good, approved, waiting for precommit results before committing. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] Apache-HBase commented on pull request #3447: HBASE-26055 Master local region "table" should be considered a system…

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3447: URL: https://github.com/apache/hbase/pull/3447#issuecomment-1023659757 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3360: HBASE-25975 Row Commit Sequencer

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3360: URL: https://github.com/apache/hbase/pull/3360#issuecomment-1023653641 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3360: HBASE-25975 Row Commit Sequencer

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3360: URL: https://github.com/apache/hbase/pull/3360#issuecomment-1023653745 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3360: HBASE-25975 Row Commit Sequencer

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3360: URL: https://github.com/apache/hbase/pull/3360#issuecomment-1023652570 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3515: Hbase-26097 to resolve hbase version 2.x protobuf version conflict

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3515: URL: https://github.com/apache/hbase/pull/3515#issuecomment-1023649028 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3515: Hbase-26097 to resolve hbase version 2.x protobuf version conflict

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3515: URL: https://github.com/apache/hbase/pull/3515#issuecomment-1023643874 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3515: Hbase-26097 to resolve hbase version 2.x protobuf version conflict

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3515: URL: https://github.com/apache/hbase/pull/3515#issuecomment-1023639511 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #3518: HBASE-25881: Create a chore to update age related metrics

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3518: URL: https://github.com/apache/hbase/pull/3518#issuecomment-1023635227 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3562: HBASE-26169 Fix MapReduceBackupCopyJob.BackupDistCp.getKey() concatenates strings

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3562: URL: https://github.com/apache/hbase/pull/3562#issuecomment-1023630799 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3562: HBASE-26169 Fix MapReduceBackupCopyJob.BackupDistCp.getKey() concatenates strings

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3562: URL: https://github.com/apache/hbase/pull/3562#issuecomment-1023626810 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3562: HBASE-26169 Fix MapReduceBackupCopyJob.BackupDistCp.getKey() concatenates strings

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3562: URL: https://github.com/apache/hbase/pull/3562#issuecomment-1023619489 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3563: HBASE-26171 Fix MetricsRegionServer may throws NullPointerException when optional.get() is called

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3563: URL: https://github.com/apache/hbase/pull/3563#issuecomment-1023609449 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3615: HBASE-26217 Clean shared state pollution to avoid flaky tests.

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3615: URL: https://github.com/apache/hbase/pull/3615#issuecomment-1023594775 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3626: HBASE-26208 Supports revoke @ns single permission

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3626: URL: https://github.com/apache/hbase/pull/3626#issuecomment-1023593510 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #3626: HBASE-26208 Supports revoke @ns single permission

2022-01-27 Thread GitBox
Apache-HBase commented on pull request #3626: URL: https://github.com/apache/hbase/pull/3626#issuecomment-1023591167 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

  1   2   >