[GitHub] [hbase] Apache-HBase commented on pull request #4549: HBASE-27131 Fix typos in ZKUtil

2022-06-17 Thread GitBox


Apache-HBase commented on PR #4549:
URL: https://github.com/apache/hbase/pull/4549#issuecomment-1159368750

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 38s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m  7s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 17s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m  7s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 40s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   0m 18s |  master passed  |
   | -0 :warning: |  patch  |   0m 23s |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m  7s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 17s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 17s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m  6s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  11m 50s |  Patch does not cause any 
errors with Hadoop 3.1.2 3.2.2 3.3.1.  |
   | -1 :x: |  spotless  |   0m 16s |  patch has 24 errors when running 
spotless:check, run spotless:apply to fix.  |
   | +1 :green_heart: |  spotbugs  |   0m 24s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m  7s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  24m 43s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4549/3/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4549 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux d208d46aff45 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 
28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 89bda2c322 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | spotless | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4549/3/artifact/yetus-general-check/output/patch-spotless.txt
 |
   | Max. process+thread count | 65 (vs. ulimit of 3) |
   | modules | C: hbase-zookeeper U: hbase-zookeeper |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4549/3/console 
|
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4549: HBASE-27131 Fix typos in ZKUtil

2022-06-17 Thread GitBox


Apache-HBase commented on PR #4549:
URL: https://github.com/apache/hbase/pull/4549#issuecomment-1159367692

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 18s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 25s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 14s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   3m 40s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 13s |  master passed  |
   | -0 :warning: |  patch  |   4m  1s |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 15s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 14s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 14s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 46s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 11s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 37s |  hbase-zookeeper in the patch 
passed.  |
   |  |   |  15m 52s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4549/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4549 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 3116abc3d48b 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 
20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 89bda2c322 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4549/3/testReport/
 |
   | Max. process+thread count | 213 (vs. ulimit of 3) |
   | modules | C: hbase-zookeeper U: hbase-zookeeper |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4549/3/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4549: HBASE-27131 Fix typos in ZKUtil

2022-06-17 Thread GitBox


Apache-HBase commented on PR #4549:
URL: https://github.com/apache/hbase/pull/4549#issuecomment-1159367634

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 39s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 25s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 11s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   3m 46s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m  9s |  master passed  |
   | -0 :warning: |  patch  |   4m  2s |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 27s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 12s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 12s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 45s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 10s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 37s |  hbase-zookeeper in the patch 
passed.  |
   |  |   |  15m 20s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4549/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4549 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 4ec3dc33e219 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 
28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 89bda2c322 |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4549/3/testReport/
 |
   | Max. process+thread count | 247 (vs. ulimit of 3) |
   | modules | C: hbase-zookeeper U: hbase-zookeeper |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4549/3/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-27128) when open archiveRetries totalLogSize calculation mistake

2022-06-17 Thread zhengsicheng (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555837#comment-17555837
 ] 

zhengsicheng commented on HBASE-27128:
--

[~zhangduo]  Thanks your review code.

> when open archiveRetries totalLogSize calculation mistake
> -
>
> Key: HBASE-27128
> URL: https://issues.apache.org/jira/browse/HBASE-27128
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 2.5.0
>Reporter: zhengsicheng
>Assignee: zhengsicheng
>Priority: Minor
>
> When open archiveRetries archiveLogFile() retrun IOException "totalLogSize" 
> calculation mistake



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [hbase] Apache-HBase commented on pull request #4523: HBASE-27104 Add a tool command list_unknownservers

2022-06-17 Thread GitBox


Apache-HBase commented on PR #4523:
URL: https://github.com/apache/hbase/pull/4523#issuecomment-1159366692

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  6s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 14s |  master passed  |
   | +1 :green_heart: |  compile  |   1m 43s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   3m 40s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  0s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 11s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 42s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 42s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 40s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 56s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 31s |  hbase-protocol-shaded in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   1m  0s |  hbase-client in the patch passed.  
|
   | -1 :x: |  unit  | 213m 42s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  unit  |   7m 48s |  hbase-shell in the patch passed.  |
   |  |   | 243m 23s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4523/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4523 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 66ed1ce047f3 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 
20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 89bda2c322 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4523/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4523/3/testReport/
 |
   | Max. process+thread count | 2603 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell 
U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4523/3/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4523: HBASE-27104 Add a tool command list_unknownservers

2022-06-17 Thread GitBox


Apache-HBase commented on PR #4523:
URL: https://github.com/apache/hbase/pull/4523#issuecomment-1159366057

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 43s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 52s |  master passed  |
   | +1 :green_heart: |  compile  |   1m 49s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m  8s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 58s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 38s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 52s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 52s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m  4s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 56s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 34s |  hbase-protocol-shaded in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   1m 24s |  hbase-client in the patch passed.  
|
   | -1 :x: |  unit  | 204m 30s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  unit  |   7m 46s |  hbase-shell in the patch passed.  |
   |  |   | 236m 48s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4523/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4523 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 6aeca85d12a7 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 
11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 89bda2c322 |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4523/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4523/3/testReport/
 |
   | Max. process+thread count | 2697 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell 
U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4523/3/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4549: HBASE-27131 Fix typos in ZKUtil

2022-06-17 Thread GitBox


Apache-HBase commented on PR #4549:
URL: https://github.com/apache/hbase/pull/4549#issuecomment-1159365849

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 38s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 28s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 19s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m  8s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 50s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   0m 22s |  master passed  |
   | -0 :warning: |  patch  |   0m 28s |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m  9s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 16s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 16s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m  6s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  12m  3s |  Patch does not cause any 
errors with Hadoop 3.1.2 3.2.2 3.3.1.  |
   | -1 :x: |  spotless  |   0m 16s |  patch has 24 errors when running 
spotless:check, run spotless:apply to fix.  |
   | +1 :green_heart: |  spotbugs  |   0m 24s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m  9s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  25m  4s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4549/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4549 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 9cd65bcabfff 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 
28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 89bda2c322 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | spotless | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4549/2/artifact/yetus-general-check/output/patch-spotless.txt
 |
   | Max. process+thread count | 64 (vs. ulimit of 3) |
   | modules | C: hbase-zookeeper U: hbase-zookeeper |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4549/2/console 
|
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4549: HBASE-27131 Fix typos in ZKUtil

2022-06-17 Thread GitBox


Apache-HBase commented on PR #4549:
URL: https://github.com/apache/hbase/pull/4549#issuecomment-1159364874

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 39s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 47s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 12s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   3m 48s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 13s |  master passed  |
   | -0 :warning: |  patch  |   4m  7s |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 28s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 12s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 12s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 47s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 10s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 35s |  hbase-zookeeper in the patch 
passed.  |
   |  |   |  15m 49s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4549/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4549 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 9594f9b0e657 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 
28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 89bda2c322 |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4549/2/testReport/
 |
   | Max. process+thread count | 270 (vs. ulimit of 3) |
   | modules | C: hbase-zookeeper U: hbase-zookeeper |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4549/2/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4549: HBASE-27131 Fix typos in ZKUtil

2022-06-17 Thread GitBox


Apache-HBase commented on PR #4549:
URL: https://github.com/apache/hbase/pull/4549#issuecomment-1159364868

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 19s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 22s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 13s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   3m 43s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 13s |  master passed  |
   | -0 :warning: |  patch  |   4m  5s |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 14s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 13s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 13s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 41s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 11s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 37s |  hbase-zookeeper in the patch 
passed.  |
   |  |   |  15m 47s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4549/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4549 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 25f416e0eba4 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 
20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 89bda2c322 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4549/2/testReport/
 |
   | Max. process+thread count | 289 (vs. ulimit of 3) |
   | modules | C: hbase-zookeeper U: hbase-zookeeper |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4549/2/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4463: HBASE-27062 ThreadPool is unnecessary in HBaseInterClusterReplication…

2022-06-17 Thread GitBox


Apache-HBase commented on PR #4463:
URL: https://github.com/apache/hbase/pull/4463#issuecomment-1159364105

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 45s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 13s |  master passed  |
   | +1 :green_heart: |  compile  |   3m 22s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 41s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 57s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 48s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 51s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 36s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 36s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 34s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  12m 51s |  Patch does not cause any 
errors with Hadoop 3.1.2 3.2.2 3.3.1.  |
   | +1 :green_heart: |  spotless  |   0m 42s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 25s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m  8s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  37m 48s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4463/9/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4463 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux f72f4bc54eb3 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 
20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 89bda2c322 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | Max. process+thread count | 64 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4463/9/console 
|
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-27125) The batch size of cleaning expired mob files should have an upper bound

2022-06-17 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555833#comment-17555833
 ] 

Hudson commented on HBASE-27125:


Results for branch branch-2
[build #571 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/571/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/571/General_20Nightly_20Build_20Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/571/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/571/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/571/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> The batch size of cleaning expired mob files should have an upper bound
> ---
>
> Key: HBASE-27125
> URL: https://issues.apache.org/jira/browse/HBASE-27125
> Project: HBase
>  Issue Type: Improvement
>  Components: mob
>Affects Versions: 2.4.12
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Minor
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3, 2.4.14
>
>
> Currently the cleaning logic for expired mob files is adding all the 
> deletable files in one directory to a list in memory and then archiving all 
> the files in the list. But when there are millions of files need to delete, 
> the list will be huge and make great heap memory pressure to the master.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [hbase] Apache-HBase commented on pull request #4523: HBASE-27104 Add a tool command list_unknownservers

2022-06-17 Thread GitBox


Apache-HBase commented on PR #4523:
URL: https://github.com/apache/hbase/pull/4523#issuecomment-1159340457

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 50s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  prototool  |   0m  0s |  prototool was not available.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m  7s |  master passed  |
   | +1 :green_heart: |  compile  |   3m 49s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 48s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 38s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   4m 21s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m  4s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 50s |  the patch passed  |
   | +1 :green_heart: |  cc  |   3m 50s |  the patch passed  |
   | -0 :warning: |  javac  |   0m 34s |  hbase-client generated 1 new + 122 
unchanged - 1 fixed = 123 total (was 123)  |
   | -0 :warning: |  javac  |   2m 12s |  hbase-server generated 2 new + 191 
unchanged - 2 fixed = 193 total (was 193)  |
   | +1 :green_heart: |  checkstyle  |   0m 48s |  the patch passed  |
   | -0 :warning: |  rubocop  |   0m  7s |  The patch generated 3 new + 427 
unchanged - 0 fixed = 430 total (was 427)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  11m 30s |  Patch does not cause any 
errors with Hadoop 3.1.2 3.2.2 3.3.1.  |
   | +1 :green_heart: |  hbaseprotoc  |   1m 29s |  the patch passed  |
   | +1 :green_heart: |  spotless  |   0m 39s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   4m 46s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 27s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  43m 58s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4523/3/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4523 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile cc hbaseprotoc prototool rubocop |
   | uname | Linux e394c4724dcc 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 
28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 89bda2c322 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4523/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4523/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
 |
   | rubocop | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4523/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt
 |
   | Max. process+thread count | 60 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell 
U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4523/3/console 
|
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] virajjasani commented on pull request #4486: HBASE-27085 Create REPLICATION_SINK_TRACKER table to persist marker rows coming from source cluster

2022-06-17 Thread GitBox


virajjasani commented on PR #4486:
URL: https://github.com/apache/hbase/pull/4486#issuecomment-1159327922

   @shahrs87 could you once pull in latest changes from 
`HBASE-26913-replication-observability-framework` branch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-06-17 Thread GitBox


bbeaudreault commented on code in PR #4125:
URL: https://github.com/apache/hbase/pull/4125#discussion_r900591657


##
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java:
##
@@ -0,0 +1,310 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.io.crypto.tls;
+
+import java.io.BufferedInputStream;
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.file.Files;
+import java.security.GeneralSecurityException;
+import java.security.KeyManagementException;
+import java.security.KeyStore;
+import java.security.NoSuchAlgorithmException;
+import java.security.Security;
+import java.security.cert.PKIXBuilderParameters;
+import java.security.cert.X509CertSelector;
+import java.util.Objects;
+import java.util.concurrent.atomic.AtomicReference;
+import javax.net.ssl.CertPathTrustManagerParameters;
+import javax.net.ssl.KeyManager;
+import javax.net.ssl.KeyManagerFactory;
+import javax.net.ssl.SSLContext;
+import javax.net.ssl.TrustManager;
+import javax.net.ssl.TrustManagerFactory;
+import javax.net.ssl.X509ExtendedTrustManager;
+import javax.net.ssl.X509KeyManager;
+import javax.net.ssl.X509TrustManager;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.exceptions.X509Exception;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Utility code for X509 handling Default cipher suites: Performance testing 
done by Facebook
+ * engineers shows that on Intel x86_64 machines, Java9 performs better with 
GCM and Java8 performs
+ * better with CBC, so these seem like reasonable defaults.
+ */
+@InterfaceAudience.Private
+public class X509Util {
+
+  private static final Logger LOG = LoggerFactory.getLogger(X509Util.class);
+
+  // Config
+  static final String CONFIG_PREFIX = "hbase.rpc.tls.";

Review Comment:
   In hbase a server can also be a client of other servers (either in the 
cluster or in another cluster). But let's just leave this as is for now and not 
over complicate it. I think one can simply create keystores and truststores 
with the necessary cert chains to authenticate these mixed modes. If necessary 
we can add differentiation in a later jira 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4525: HBASE-27111 Make Netty channel bytebuf allocator configurable.

2022-06-17 Thread GitBox


Apache-HBase commented on PR #4525:
URL: https://github.com/apache/hbase/pull/4525#issuecomment-1159312080

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 19s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 19s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 42s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m 23s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 29s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 57s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 45s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 45s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 17s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 20s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 199m 39s |  hbase-server in the patch passed.  
|
   |  |   | 220m 50s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4525/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4525 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 4799b57cf871 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 
23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 89bda2c322 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4525/2/testReport/
 |
   | Max. process+thread count | 2594 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4525/2/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4525: HBASE-27111 Make Netty channel bytebuf allocator configurable.

2022-06-17 Thread GitBox


Apache-HBase commented on PR #4525:
URL: https://github.com/apache/hbase/pull/4525#issuecomment-1159310242

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 24s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 33s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 47s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   3m 38s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 26s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 34s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 47s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 47s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 40s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 26s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 197m 11s |  hbase-server in the patch passed.  
|
   |  |   | 214m 17s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4525/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4525 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 27ba70c19447 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 
16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 89bda2c322 |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4525/2/testReport/
 |
   | Max. process+thread count | 2627 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4525/2/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-27125) The batch size of cleaning expired mob files should have an upper bound

2022-06-17 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555770#comment-17555770
 ] 

Hudson commented on HBASE-27125:


Results for branch branch-2.4
[build #373 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/373/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/373/General_20Nightly_20Build_20Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/373/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/373/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/373/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console 
output|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/373//console].


> The batch size of cleaning expired mob files should have an upper bound
> ---
>
> Key: HBASE-27125
> URL: https://issues.apache.org/jira/browse/HBASE-27125
> Project: HBase
>  Issue Type: Improvement
>  Components: mob
>Affects Versions: 2.4.12
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Minor
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3, 2.4.14
>
>
> Currently the cleaning logic for expired mob files is adding all the 
> deletable files in one directory to a list in memory and then archiving all 
> the files in the list. But when there are millions of files need to delete, 
> the list will be huge and make great heap memory pressure to the master.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [hbase] Apache-HBase commented on pull request #4525: HBASE-27111 Make Netty channel bytebuf allocator configurable.

2022-06-17 Thread GitBox


Apache-HBase commented on PR #4525:
URL: https://github.com/apache/hbase/pull/4525#issuecomment-1159224874

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  5s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   5m 14s |  master passed  |
   | +1 :green_heart: |  compile  |   2m 37s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 42s |  master passed  |
   | +1 :green_heart: |  spotless  |   1m  3s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 39s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 33s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 36s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 36s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 28s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  11m 55s |  Patch does not cause any 
errors with Hadoop 3.1.2 3.2.2 3.3.1.  |
   | +1 :green_heart: |  spotless  |   0m 41s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 20s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 10s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  37m 23s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4525/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4525 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 4ff3cb61133b 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 
28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 89bda2c322 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | Max. process+thread count | 69 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4525/2/console 
|
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4488: HBASE-27088 IntegrationLoadTestCommonCrawl async load improvements

2022-06-17 Thread GitBox


Apache-HBase commented on PR #4488:
URL: https://github.com/apache/hbase/pull/4488#issuecomment-1159219167

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 24s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m  5s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 25s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m  8s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 41s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   0m 20s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m  7s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 25s |  the patch passed  |
   | -0 :warning: |  javac  |   0m 25s |  hbase-it generated 3 new + 100 
unchanged - 3 fixed = 103 total (was 103)  |
   | +1 :green_heart: |  checkstyle  |   0m  7s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  12m  3s |  Patch does not cause any 
errors with Hadoop 3.1.2 3.2.2 3.3.1.  |
   | +1 :green_heart: |  spotless  |   0m 40s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   0m 25s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m  7s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  25m 57s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4488/8/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4488 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 6debdcb7560a 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 
11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 89bda2c322 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4488/8/artifact/yetus-general-check/output/diff-compile-javac-hbase-it.txt
 |
   | Max. process+thread count | 64 (vs. ulimit of 3) |
   | modules | C: hbase-it U: hbase-it |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4488/8/console 
|
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4470: HBASE-26192 Master UI hbck should provide a JSON formatted output option

2022-06-17 Thread GitBox


Apache-HBase commented on PR #4470:
URL: https://github.com/apache/hbase/pull/4470#issuecomment-1159216288

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  5s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 53s |  master passed  |
   | +1 :green_heart: |  compile  |   2m 25s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 34s |  master passed  |
   | +1 :green_heart: |  spotless  |   1m  3s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   2m  2s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | -1 :x: |  mvninstall  |   1m 35s |  root in the patch failed.  |
   | -1 :x: |  compile  |   0m 35s |  hbase-server in the patch failed.  |
   | -0 :warning: |  javac  |   0m 35s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  checkstyle  |   0m 33s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | -1 :x: |  hadoopcheck  |   1m 32s |  The patch causes 28 errors with 
Hadoop v3.1.2.  |
   | -1 :x: |  hadoopcheck  |   3m  4s |  The patch causes 28 errors with 
Hadoop v3.2.2.  |
   | -1 :x: |  hadoopcheck  |   4m 50s |  The patch causes 28 errors with 
Hadoop v3.3.1.  |
   | +1 :green_heart: |  spotless  |   0m 49s |  patch has no errors when 
running spotless:check.  |
   | -1 :x: |  spotbugs  |   0m 29s |  hbase-server in the patch failed.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 13s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  20m  9s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4470 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 10ed3d446574 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 
20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 89bda2c322 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | mvninstall | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/artifact/yetus-general-check/output/patch-mvninstall-root.txt
 |
   | compile | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
 |
   | hadoopcheck | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
 |
   | hadoopcheck | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/artifact/yetus-general-check/output/patch-javac-3.2.2.txt
 |
   | hadoopcheck | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/artifact/yetus-general-check/output/patch-javac-3.3.1.txt
 |
   | spotbugs | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt
 |
   | Max. process+thread count | 64 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/console 
|
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4470: HBASE-26192 Master UI hbck should provide a JSON formatted output option

2022-06-17 Thread GitBox


Apache-HBase commented on PR #4470:
URL: https://github.com/apache/hbase/pull/4470#issuecomment-1159215656

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 20s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 37s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 56s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m 12s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 31s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | -1 :x: |  mvninstall  |   1m 54s |  root in the patch failed.  |
   | -1 :x: |  compile  |   0m 29s |  hbase-server in the patch failed.  |
   | -0 :warning: |  javac  |   0m 29s |  hbase-server in the patch failed.  |
   | -1 :x: |  shadedjars  |   3m  9s |  patch has 28 errors when building our 
shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 16s |  hbase-server in the patch failed.  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   0m 31s |  hbase-server in the patch failed.  |
   |  |   |  18m 57s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4470 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux a99f63ebd95f 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 
23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 89bda2c322 |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   | mvninstall | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
 |
   | compile | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
 |
   | shadedjars | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
 |
   | javadoc | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/testReport/
 |
   | Max. process+thread count | 79 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4488: HBASE-27088 IntegrationLoadTestCommonCrawl async load improvements

2022-06-17 Thread GitBox


Apache-HBase commented on PR #4488:
URL: https://github.com/apache/hbase/pull/4488#issuecomment-1159215372

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  6s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 41s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 21s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m 43s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 13s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 39s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 23s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 23s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 48s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 10s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 40s |  hbase-it in the patch passed.  |
   |  |   |  18m 32s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4488/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4488 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux f41c250d2668 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 
28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 89bda2c322 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4488/8/testReport/
 |
   | Max. process+thread count | 558 (vs. ulimit of 3) |
   | modules | C: hbase-it U: hbase-it |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4488/8/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4470: HBASE-26192 Master UI hbck should provide a JSON formatted output option

2022-06-17 Thread GitBox


Apache-HBase commented on PR #4470:
URL: https://github.com/apache/hbase/pull/4470#issuecomment-1159214296

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 13s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 27s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 43s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m 14s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 39s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | -1 :x: |  mvninstall  |   1m 43s |  root in the patch failed.  |
   | -1 :x: |  compile  |   0m 35s |  hbase-server in the patch failed.  |
   | -0 :warning: |  javac  |   0m 35s |  hbase-server in the patch failed.  |
   | -1 :x: |  shadedjars  |   3m 18s |  patch has 28 errors when building our 
shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 24s |  hbase-server generated 2 new + 23 
unchanged - 0 fixed = 25 total (was 23)  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   0m 25s |  hbase-server in the patch failed.  |
   |  |   |  16m 22s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4470 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux aa39db64e54a 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 
20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 89bda2c322 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | mvninstall | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
 |
   | compile | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
 |
   | shadedjars | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
 |
   | javadoc | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/testReport/
 |
   | Max. process+thread count | 64 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4470/6/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4488: HBASE-27088 IntegrationLoadTestCommonCrawl async load improvements

2022-06-17 Thread GitBox


Apache-HBase commented on PR #4488:
URL: https://github.com/apache/hbase/pull/4488#issuecomment-1159213801

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 32s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 36s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 21s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   3m 44s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 13s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 28s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 21s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 21s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 41s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 13s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 38s |  hbase-it in the patch passed.  |
   |  |   |  15m 38s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4488/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4488 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux d3811eb6660b 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 
20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 89bda2c322 |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4488/8/testReport/
 |
   | Max. process+thread count | 596 (vs. ulimit of 3) |
   | modules | C: hbase-it U: hbase-it |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4488/8/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-06-17 Thread GitBox


bbeaudreault commented on code in PR #4125:
URL: https://github.com/apache/hbase/pull/4125#discussion_r900484593


##
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java:
##
@@ -0,0 +1,310 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.io.crypto.tls;
+
+import java.io.BufferedInputStream;
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.file.Files;
+import java.security.GeneralSecurityException;
+import java.security.KeyManagementException;
+import java.security.KeyStore;
+import java.security.NoSuchAlgorithmException;
+import java.security.Security;
+import java.security.cert.PKIXBuilderParameters;
+import java.security.cert.X509CertSelector;
+import java.util.Objects;
+import java.util.concurrent.atomic.AtomicReference;
+import javax.net.ssl.CertPathTrustManagerParameters;
+import javax.net.ssl.KeyManager;
+import javax.net.ssl.KeyManagerFactory;
+import javax.net.ssl.SSLContext;
+import javax.net.ssl.TrustManager;
+import javax.net.ssl.TrustManagerFactory;
+import javax.net.ssl.X509ExtendedTrustManager;
+import javax.net.ssl.X509KeyManager;
+import javax.net.ssl.X509TrustManager;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.exceptions.X509Exception;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Utility code for X509 handling Default cipher suites: Performance testing 
done by Facebook
+ * engineers shows that on Intel x86_64 machines, Java9 performs better with 
GCM and Java8 performs
+ * better with CBC, so these seem like reasonable defaults.
+ */
+@InterfaceAudience.Private
+public class X509Util {
+
+  private static final Logger LOG = LoggerFactory.getLogger(X509Util.class);
+
+  // Config
+  static final String CONFIG_PREFIX = "hbase.rpc.tls.";
+  static final String TLS_CONFIG_PROTOCOL = CONFIG_PREFIX + "protocol";
+  static final String TLS_CONFIG_KEYSTORE_LOCATION = CONFIG_PREFIX + 
"keystore.location";
+  static final String TLS_CONFIG_KEYSTORE_TYPE = CONFIG_PREFIX + 
"keystore.type";
+  static final String TLS_CONFIG_KEYSTORE_PASSWORD = CONFIG_PREFIX + 
"keystore.password";
+  static final String TLS_CONFIG_TRUSTSTORE_LOCATION = CONFIG_PREFIX + 
"truststore.location";
+  static final String TLS_CONFIG_TRUSTSTORE_TYPE = CONFIG_PREFIX + 
"truststore.type";
+  static final String TLS_CONFIG_TRUSTSTORE_PASSWORD = CONFIG_PREFIX + 
"truststore.password";
+  static final String TLS_CONFIG_CLR = CONFIG_PREFIX + "clr";
+  static final String TLS_CONFIG_OCSP = CONFIG_PREFIX + "ocsp";
+
+  public static final String HBASE_NETTY_RPCSERVER_TLS_ENABLED =
+"hbase.netty.rpcserver.tls.enabled";

Review Comment:
   I suggest providing two config: `hbase.client.netty.tls.enabled` and 
`hbase.server.netty.tls.enabled`
   
   I think there's a case to be made for removing netty from the name. Netty is 
the only implementation in master branch I believe, so it might be confusing 
eventually.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-06-17 Thread GitBox


bbeaudreault commented on code in PR #4125:
URL: https://github.com/apache/hbase/pull/4125#discussion_r900481292


##
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java:
##
@@ -0,0 +1,310 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.io.crypto.tls;
+
+import java.io.BufferedInputStream;
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.file.Files;
+import java.security.GeneralSecurityException;
+import java.security.KeyManagementException;
+import java.security.KeyStore;
+import java.security.NoSuchAlgorithmException;
+import java.security.Security;
+import java.security.cert.PKIXBuilderParameters;
+import java.security.cert.X509CertSelector;
+import java.util.Objects;
+import java.util.concurrent.atomic.AtomicReference;
+import javax.net.ssl.CertPathTrustManagerParameters;
+import javax.net.ssl.KeyManager;
+import javax.net.ssl.KeyManagerFactory;
+import javax.net.ssl.SSLContext;
+import javax.net.ssl.TrustManager;
+import javax.net.ssl.TrustManagerFactory;
+import javax.net.ssl.X509ExtendedTrustManager;
+import javax.net.ssl.X509KeyManager;
+import javax.net.ssl.X509TrustManager;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.exceptions.X509Exception;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Utility code for X509 handling Default cipher suites: Performance testing 
done by Facebook
+ * engineers shows that on Intel x86_64 machines, Java9 performs better with 
GCM and Java8 performs
+ * better with CBC, so these seem like reasonable defaults.
+ */
+@InterfaceAudience.Private
+public class X509Util {
+
+  private static final Logger LOG = LoggerFactory.getLogger(X509Util.class);
+
+  // Config
+  static final String CONFIG_PREFIX = "hbase.rpc.tls.";
+  static final String TLS_CONFIG_PROTOCOL = CONFIG_PREFIX + "protocol";
+  static final String TLS_CONFIG_KEYSTORE_LOCATION = CONFIG_PREFIX + 
"keystore.location";
+  static final String TLS_CONFIG_KEYSTORE_TYPE = CONFIG_PREFIX + 
"keystore.type";
+  static final String TLS_CONFIG_KEYSTORE_PASSWORD = CONFIG_PREFIX + 
"keystore.password";
+  static final String TLS_CONFIG_TRUSTSTORE_LOCATION = CONFIG_PREFIX + 
"truststore.location";
+  static final String TLS_CONFIG_TRUSTSTORE_TYPE = CONFIG_PREFIX + 
"truststore.type";
+  static final String TLS_CONFIG_TRUSTSTORE_PASSWORD = CONFIG_PREFIX + 
"truststore.password";
+  static final String TLS_CONFIG_CLR = CONFIG_PREFIX + "clr";
+  static final String TLS_CONFIG_OCSP = CONFIG_PREFIX + "ocsp";
+
+  public static final String HBASE_NETTY_RPCSERVER_TLS_ENABLED =
+"hbase.netty.rpcserver.tls.enabled";

Review Comment:
   So unfortunately that process will not work. Since there is a single config 
for enabling both client and server side TLS. The moment you do step 1, the 
HMasters will try sending RPCs to RSs using TLS. But the RSs will not have TLS 
enabled and will not understand the encrypted requests. Example is 
OpenRegion/CloseRegion requests. 
   
   That said, I agree that would be a reasonable approach to aim for. I think 
we need to provide a separate config for clients to make that work though. In 
which case the final step would be to restart HMaster one more time with 
client-side TLS enabled. 
   
   If region replication is used, might need to do RSs in two phases (server 
enabled then client) too. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-06-17 Thread GitBox


bbeaudreault commented on code in PR #4125:
URL: https://github.com/apache/hbase/pull/4125#discussion_r900481292


##
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java:
##
@@ -0,0 +1,310 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.io.crypto.tls;
+
+import java.io.BufferedInputStream;
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.file.Files;
+import java.security.GeneralSecurityException;
+import java.security.KeyManagementException;
+import java.security.KeyStore;
+import java.security.NoSuchAlgorithmException;
+import java.security.Security;
+import java.security.cert.PKIXBuilderParameters;
+import java.security.cert.X509CertSelector;
+import java.util.Objects;
+import java.util.concurrent.atomic.AtomicReference;
+import javax.net.ssl.CertPathTrustManagerParameters;
+import javax.net.ssl.KeyManager;
+import javax.net.ssl.KeyManagerFactory;
+import javax.net.ssl.SSLContext;
+import javax.net.ssl.TrustManager;
+import javax.net.ssl.TrustManagerFactory;
+import javax.net.ssl.X509ExtendedTrustManager;
+import javax.net.ssl.X509KeyManager;
+import javax.net.ssl.X509TrustManager;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.exceptions.X509Exception;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Utility code for X509 handling Default cipher suites: Performance testing 
done by Facebook
+ * engineers shows that on Intel x86_64 machines, Java9 performs better with 
GCM and Java8 performs
+ * better with CBC, so these seem like reasonable defaults.
+ */
+@InterfaceAudience.Private
+public class X509Util {
+
+  private static final Logger LOG = LoggerFactory.getLogger(X509Util.class);
+
+  // Config
+  static final String CONFIG_PREFIX = "hbase.rpc.tls.";
+  static final String TLS_CONFIG_PROTOCOL = CONFIG_PREFIX + "protocol";
+  static final String TLS_CONFIG_KEYSTORE_LOCATION = CONFIG_PREFIX + 
"keystore.location";
+  static final String TLS_CONFIG_KEYSTORE_TYPE = CONFIG_PREFIX + 
"keystore.type";
+  static final String TLS_CONFIG_KEYSTORE_PASSWORD = CONFIG_PREFIX + 
"keystore.password";
+  static final String TLS_CONFIG_TRUSTSTORE_LOCATION = CONFIG_PREFIX + 
"truststore.location";
+  static final String TLS_CONFIG_TRUSTSTORE_TYPE = CONFIG_PREFIX + 
"truststore.type";
+  static final String TLS_CONFIG_TRUSTSTORE_PASSWORD = CONFIG_PREFIX + 
"truststore.password";
+  static final String TLS_CONFIG_CLR = CONFIG_PREFIX + "clr";
+  static final String TLS_CONFIG_OCSP = CONFIG_PREFIX + "ocsp";
+
+  public static final String HBASE_NETTY_RPCSERVER_TLS_ENABLED =
+"hbase.netty.rpcserver.tls.enabled";

Review Comment:
   So unfortunately that process will not work. Since there is a single config 
for enabling both client and server side TLS. The moment you do step 1, the 
HMasters will try sending RPCs to RSs using TLS. But the RSs will not have TLS 
enabled and will not understand the encrypted requests. Example is 
OpenRegion/CloseRegion requests. 
   
   That said, I agree that would be a reasonable approach to aim for. I think 
we need to provide a separate config for clients to make that work though. In 
which case the final step would be to restart HMaster one more time with client 
enabled. 
   
   If region replication is used, might need to do RSs in two phases (server 
enabled then client) too. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (HBASE-12952) Seek with prefixtree may hang

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12952.
---

> Seek with prefixtree may hang
> -
>
> Key: HBASE-12952
> URL: https://issues.apache.org/jira/browse/HBASE-12952
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 1.0.0, 0.98.7, 0.98.8, 0.98.6.1, 0.98.9, 0.98.10
>Reporter: signifox
>Priority: Major
> Attachments: hbase_0.98.6.1.patch
>
>
> I have upgraded my hbase cluster from hbase-0.96 to hbase-0.98.6.1,then i 
> found some compaction hang on many regionserver, and the cpu costed100%.
> It looks like there is an infinite loop somewhere. 
> From the log, i found StoreFileScanner.java : reseekAtOrAfter(HFileScanner s, 
> KeyValue k) enterd an infinite loop.
> Read source code, I found en error on PrefixTreeArrayReversibleScanner.java : 
> previousRowInternal()
> eg:  
>   A:fan:12, numCell:1
>   A : 1  -> B
>   A : 2  -> C
>   
>   C: 3  -> D
>   C: 4  -> E
>   
> A: fan:12, numCell:1
> B: fan,numCell:1
> C: fan:34,numCell: 0
> D: fan,numCell:1
> E: fan,numCell:1
> when currentNode is D, its previous node is B , but this function will return 
> A.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12838) After HBASE-5162 RSRpcServices accidentally applies mutations twice

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12838.
---

> After HBASE-5162 RSRpcServices accidentally applies mutations twice
> ---
>
> Key: HBASE-12838
> URL: https://issues.apache.org/jira/browse/HBASE-12838
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: HBASE-12838.patch
>
>
> After HBASE-5162 RSRpcServices accidentally applies mutations twice. Fix is a 
> one-liner. 



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12883) Support block encoding based on knowing set of column qualifiers up front

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12883.
---

> Support block encoding based on knowing set of column qualifiers up front
> -
>
> Key: HBASE-12883
> URL: https://issues.apache.org/jira/browse/HBASE-12883
> Project: HBase
>  Issue Type: Bug
>Reporter: James R. Taylor
>Priority: Major
>  Labels: Phoenix
>
> Phoenix knows up front the set of column qualifiers a row will have. We could 
> likely get some good compression with little CPU based on this by having a 
> block encoding scheme that leverages this information. It could be made 
> non-Phoenix specific by identifying the set of column qualifiers through meta 
> data to the block encoder.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12884) Asynchronous Event Notification in HBase

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12884.
---

>  Asynchronous Event Notification in HBase
> -
>
> Key: HBASE-12884
> URL: https://issues.apache.org/jira/browse/HBASE-12884
> Project: HBase
>  Issue Type: New Feature
>Reporter: Shaohui Liu
>Priority: Major
>
> *Background*
> In many scenarios, we need an asynchronous event notification 
> mechanism on HBase to know which data have been changed and users can do some 
> pre-defined reactions to these events.
> For example: 
> * Incremental statistics of data in HBase
> * Audit about change of important data
> * To clean invalid data in other cache systems
> *Features maybe*
> * The mechanism is scalable.
> * The notification is asynchronous. We don't want to affect the write 
> performance of HBase.
> * The notification is reliable. The events can't be lost, but we can tolerate 
> duplicated events.
> *Solution Maybe*
> * Event notification based on replication. Transform the WAL edits to events, 
> and replicates a special peer that users implements.
> This is just a brief thought about this feature. Discussions and suggestions 
> are welcomed! Thanks.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12882) Log level for org.apache.hadoop.hbase package should be configurable

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12882.
---

> Log level for org.apache.hadoop.hbase package should be configurable 
> -
>
> Key: HBASE-12882
> URL: https://issues.apache.org/jira/browse/HBASE-12882
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.0.0, 0.94.26, 0.98.9
>Reporter: Adrian Muraru
>Assignee: Jan Hentschel
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.1.0, 2.0.1
>
> Attachments: HBASE-12882.master.001.patch, 
> HBASE-12882.master.002.patch
>
>
> {{conf/log4j.properties}} hardcodes log level for the top hbase package to 
> DEBUG: {{log4j.logger.org.apache.hadoop.hbase=DEBUG}}
> and there is no easy way to override it without modifying this file.
> It would be useful to have a variable, say {{hbase.log.level}}m in this file 
> so it can be passed from site environment: {{-Dhbase.log.level=INFO}}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12888) Display number of regions on the table jsp page.

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12888.
---
Assignee: (was: Manukranth Kolloju)

> Display number of regions on the table jsp page.
> 
>
> Key: HBASE-12888
> URL: https://issues.apache.org/jira/browse/HBASE-12888
> Project: HBase
>  Issue Type: Improvement
>  Components: regionserver
>Affects Versions: 1.0.0
>Reporter: Manukranth Kolloju
>Priority: Trivial
> Fix For: 2.0.0
>
> Attachments: 
> 0001-NUM_REGIONS-Updated-table.jsp-to-display-number-of-r.patch, 
> HBASE-12888.01.patch, num_regions_display.png
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> This is a simple patch to display the number of regions in the table jsp page 
> in the info web page. Currently we have only the total number of regions in 
> the regionserver. This adds the per table count of the regions. 



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12887) Cleanup many checkstyle errors in o.a.h.h.client

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12887.
---
Assignee: (was: Nick Dimiduk)

> Cleanup many checkstyle errors in o.a.h.h.client
> 
>
> Key: HBASE-12887
> URL: https://issues.apache.org/jira/browse/HBASE-12887
> Project: HBase
>  Issue Type: Improvement
>  Components: build, Client
>Reporter: Nick Dimiduk
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-12887.00.patch
>
>
> The volume of checkstyle bugs makes it difficult to find what my patch 
> introduces. Clean some of them up.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12889) Add scanner caching and batching options for the CopyTable job.

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12889.
---
Assignee: (was: churro morales)

> Add scanner caching and batching options for the CopyTable job.
> ---
>
> Key: HBASE-12889
> URL: https://issues.apache.org/jira/browse/HBASE-12889
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 0.98.10, 1.1.0, 2.0.0
>Reporter: churro morales
>Priority: Minor
> Attachments: HBASE-12889.0.98.patch, HBASE-12889.patch
>
>
> We use the copy table job to ship data between clusters.  Sometimes we have 
> very wide rows and it is nice to be able to set the batching and caching.  
> I'll attach trivial patches for you guys.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12902) Post-asciidoc conversion fix-ups

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12902.
---

> Post-asciidoc conversion fix-ups
> 
>
> Key: HBASE-12902
> URL: https://issues.apache.org/jira/browse/HBASE-12902
> Project: HBase
>  Issue Type: Bug
>  Components: documentation
>Reporter: M Linville
>Assignee: M Linville
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: HBASE-12902.patch
>
>
> - Put HBase logo back on book
> - Remove docbkx building instructions and make sure asciidoc building 
> instructions are solid
> - Several feedback items from [~larsgeorge]:
> {quote}
> Lars George
> Jan-19 8:45 pm
> @misty Something is off with Table1, no? 
> https://github.com/apache/hbase/blob/master/src/main/asciidoc/_chapters/getting_started.adoc#24-adva...
> Lars George
> Jan-19 8:45 pm
> Is seems like a header for a table, but has no content
> Misty Stanley-Jones
> Jan-19 8:47 pm
> yes you are right
> Lars George
> Jan-19 8:47 pm
> @misty yeah, it is missing the node-a etc in the first column and the Xs (I 
> presume) in the others for the assignment
> {quote}
> {quote}
> Lars George
> Jan-19 11:53 pm
> @misty 2.4 (or was it 2.3, but it is at the end of that section) and 5. are 
> messing up the ports for the UIs
> Lars George
> Jan-19 11:56 pm
> @misty there is a stray section between 2.5 and 3. that seems lost and out of 
> place.
> Tuesday January 20, 2015
> Lars George
> Jan-20 12:04 am
> @misty hbase.balancer.period in the section with the parsed hbase-default.xml 
> is borked
> Lars George
> Jan-20 12:05 am
> A few more below that are also borked
> Lars George
> Jan-20 12:15 am
> This is 6.2 btw
> Lars George
> Jan-20 12:16 am
> There are quite a few where "Description" is missing and the actual 
> description is printed as Courier font text, like the property name
> Lars George
> Jan-20 12:17 am
> @misty That dangling section between 2.5 and 3. seems redundant, as 6.x 
> explain them all. Unless the former is for the quickstart section?
> Lars George
> Jan-20 12:41 am
> @misty 11.1 also stuffs up the ports, the new master port in this case
> Lars George
> Jan-20 12:43 am
> @misty in general the upgrading sections should be subsections (11, 12, 13, 
> etc should be no major sections)
> Lars George
> Jan-20 12:45 am
> @misty between 17. and 18. is another dangling section with no numbering
> Lars George
> Jan-20 12:47 am
> And again, 18., 19., 20. etc should be one major section with subsections, 
> not all major section on their own
> Lars George
> Jan-20 12:47 am
> I presume now that that dangling section between 17. and 18. is the Intro and 
> the other should be beneath it. I guess also then this is the same for 
> earlier issues with section placements.
> Lars George
> Jan-20 12:51 am
> Yeah, same for 23.5 to 24., the Data Model is the intro but shows up dangling 
> and all else is moved up the hierarchy
> Lars George
> Jan-20 1:19 am
> @misty 38. (or whatever that really is now that I noticed the broken 
> hierarchy) is also out of date.
> Lars George
> Jan-20 1:20 am
> (well decoupled flushing is still being worked on though)
> {quote}
> {quote}
> Lars George
> Jan-20 8:05 pm
> @misty 70.5 the lead into the bulleted list is borked, it appears as part of 
> the first item
> Lars George
> Jan-20 8:06 pm
> @misty and did you see those other 20+ message I sent earlier? Just checking 
> you se them
> Lars George
> Jan-20 8:08 pm
> oh, and a spell check run would not be the worst idea. Some later content is 
> off.
> Lars George
> Jan-20 8:27 pm
> @misty Same issue with bulleted list in 70.7.7 - I assume this is a wider 
> issue after conversion?
> Lars George
> Jan-20 8:39 pm
> @misty "Parameters Used by Compaction Algorithm" the table is broken
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12894) Upgrade Jetty to 9.2.6

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12894.
---

> Upgrade Jetty to 9.2.6
> --
>
> Key: HBASE-12894
> URL: https://issues.apache.org/jira/browse/HBASE-12894
> Project: HBase
>  Issue Type: Improvement
>  Components: REST, UI
>Affects Versions: 0.98.0
>Reporter: Rick Hallihan
>Assignee: Guang Yang
>Priority: Critical
>  Labels: MicrosoftSupport
> Fix For: 2.0.0
>
> Attachments: HBASE-12894.master.001.patch, 
> HBASE-12894.master.002.patch, HBASE-12894.master.003.patch, 
> HBASE-12894.master.004.patch, HBASE-12894.master.004.patch, 
> HBASE-12894.master.005.patch, HBASE-12894.master.005.patch, 
> HBASE-12894_Jetty9_v0.patch, HBASE-12894_Jetty9_v1.patch, 
> HBASE-12894_Jetty9_v1.patch, HBASE-12894_Jetty9_v10.patch, 
> HBASE-12894_Jetty9_v2.patch, HBASE-12894_Jetty9_v3.patch, 
> HBASE-12894_Jetty9_v4.patch, HBASE-12894_Jetty9_v5.patch, 
> HBASE-12894_Jetty9_v6.patch, HBASE-12894_Jetty9_v7.patch, 
> HBASE-12894_Jetty9_v8.patch, dependency_list_after, dependency_list_before, 
> hbase-12894.patch
>
>
> The Jetty component that is used for the HBase Stargate REST endpoint is 
> version 6.1.26 and is fairly outdated. We recently had a customer inquire 
> about enabling cross-origin resource sharing (CORS) for the REST endpoint and 
> found that this older version does not include the necessary filter or 
> configuration options, highlighted at: 
> http://wiki.eclipse.org/Jetty/Feature/Cross_Origin_Filter
> The Jetty project has had significant updates through versions 7, 8 and 9, 
> including a transition to be an Eclipse subproject, so updating to the latest 
> version may be non-trivial. The last update to the Jetty component in 
> https://issues.apache.org/jira/browse/HBASE-3377 was a minor version update 
> and did not require significant work. This update will include a package 
> namespace update so there will likely be a larger number of required changes. 



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12896) checkstyle report diff tool

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12896.
---

> checkstyle report diff tool
> ---
>
> Key: HBASE-12896
> URL: https://issues.apache.org/jira/browse/HBASE-12896
> Project: HBase
>  Issue Type: Improvement
>  Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-12896.00.patch
>
>
> The new check style stuff is great, but digging through all of our brokenness 
> in the report to track down what 3 things my patch broke is painful. So 
> here's a script that does the work for me.
> Maybe one of you Jenkins-aware folks can help me wire it into test-patch.sh 
> so the output gets posted all nice like in the buildbot output. Save me the 
> trouble of running it by hand all the time.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-17178) Add region balance throttling

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-17178.
---

> Add region balance throttling
> -
>
> Key: HBASE-17178
> URL: https://issues.apache.org/jira/browse/HBASE-17178
> Project: HBase
>  Issue Type: Improvement
>  Components: Balancer
>Affects Versions: 1.4.0, 2.0.0
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 1.4.0, 2.0.0
>
> Attachments: HBASE-17178-branch-1-v1.patch, 
> HBASE-17178-branch-1.patch, HBASE-17178-v1.patch, HBASE-17178-v2.patch, 
> HBASE-17178-v3.patch, HBASE-17178-v4.patch, HBASE-17178-v5.patch, 
> HBASE-17178-v6.patch
>
>
> Our online cluster serves dozens of  tables and different tables serve for 
> different services. If the balancer moves too many regions in the same time, 
> it will decrease the availability for some table or some services. So we add 
> region balance throttling on our online serve cluster. 
> We introduce a new config hbase.balancer.max.balancing.regions, which means 
> the max number of regions in transition when balancing.
> If we config this to 1 and a table have 100 regions, then the table will have 
> 99 regions available at any time. It helps a lot for our use case and it has 
> been running a long time
> our production cluster.
> But for some use case, we need the balancer run faster. If a cluster has 100 
> regionservers, then it add 50 new regionservers for peak requests. Then it 
> need balancer run as soon as
> possible and let the cluster reach a balance state soon. Our idea is compute 
> max number of regions in transition by the max balancing time and the average 
> time of region in transition.
> Then the balancer use the computed value to throttling.
> Examples for understanding.
> A cluster has 100 regionservers, each regionserver has 200 regions and the 
> average time of region in transition is 1 seconds, we config the max 
> balancing time is 10 * 60 seconds.
> Case 1. One regionserver crash, the cluster at most need balance 200 regions. 
> Then 200 / (10 * 60s / 1s) < 1, it means the max number of regions in 
> transition is 1 when balancing. Then the balancer can move region one by one 
> and the cluster will have high availability  when balancing.
> Case 2. Add other 100 regionservers, the cluster at most need balance 1 
> regions. Then 1 / (10 * 60s / 1s) = 16.7, it means the max number of 
> regions in transition is 17 when balancing. Then the cluster can reach a 
> balance state within the max balancing time.
> Any suggestions are welcomed.
> Review board: https://reviews.apache.org/r/54191/



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12900) AbstractHBaseTool prints the missing args incorrectly

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12900.
---

> AbstractHBaseTool prints the missing args incorrectly
> -
>
> Key: HBASE-12900
> URL: https://issues.apache.org/jira/browse/HBASE-12900
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Neil Clark
>Priority: Major
>
> The error message is:
> {code}
> 2015-01-21 15:31:21,156 ERROR [main] util.AbstractHBaseTool: Required option 
> -name is missing
> {code}
> while the usage prints:
> {code}
>  -n,--name The name of the created snapshot
> {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Resolved] (HBASE-12906) Document the new load pushback mechanism and available policies

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell resolved HBASE-12906.
-
Resolution: Not A Problem

> Document the new load pushback mechanism and available policies
> ---
>
> Key: HBASE-12906
> URL: https://issues.apache.org/jira/browse/HBASE-12906
> Project: HBase
>  Issue Type: Task
>  Components: documentation
>Reporter: Andrew Kyle Purtell
>Priority: Major
>
> HBASE-5162 introduced a new mechanism for supplying the client with server 
> side load information in response to mutations, and new configurable client 
> side policies for responding to this information with behavioral changes. 
> Document the new available configuration options and per-policy options.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12890) Provide a way to throttle the number of regions moved by the balancer

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12890.
---
Assignee: (was: churro morales)

> Provide a way to throttle the number of regions moved by the balancer
> -
>
> Key: HBASE-12890
> URL: https://issues.apache.org/jira/browse/HBASE-12890
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 0.98.10
>Reporter: churro morales
>Priority: Major
> Attachments: HBASE-12890.patch
>
>
> We have a very large cluster and we frequently add remove quite a few 
> regionservers from our cluster.  Whenever we do this the balancer moves 
> thousands of regions at once.  Instead we provide a configuration parameter: 
> hbase.balancer.max.regions.  This limits the number of regions that are 
> balanced per iteration.  



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12909) Junit listed at compile scope instead of test

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12909.
---

> Junit listed at compile scope instead of test
> -
>
> Key: HBASE-12909
> URL: https://issues.apache.org/jira/browse/HBASE-12909
> Project: HBase
>  Issue Type: Bug
>  Components: build
>Affects Versions: 1.0.0
>Reporter: Sean Busbey
>Priority: Major
> Attachments: HBASE-12909.1.patch.txt
>
>
> Right now our top level pom lists junit as a dependency for every module in 
> the compile scope, which makes it subject to our compatibility promises.
> It should instead be test scope.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Resolved] (HBASE-12907) Test patch should look for undeclared dependencies

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell resolved HBASE-12907.
-
  Assignee: (was: Sean Busbey)
Resolution: Incomplete

> Test patch should look for undeclared dependencies
> --
>
> Key: HBASE-12907
> URL: https://issues.apache.org/jira/browse/HBASE-12907
> Project: HBase
>  Issue Type: Improvement
>  Components: build
>Reporter: Sean Busbey
>Priority: Major
>
> Given the breadth of used undeclared dependencies in HBASE-12898, we should 
> expand the QA patch tester to look for them as they show up.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Resolved] (HBASE-12900) AbstractHBaseTool prints the missing args incorrectly

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell resolved HBASE-12900.
-
  Assignee: (was: Pankaj Kumar)
Resolution: Incomplete

> AbstractHBaseTool prints the missing args incorrectly
> -
>
> Key: HBASE-12900
> URL: https://issues.apache.org/jira/browse/HBASE-12900
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Neil Clark
>Priority: Major
>
> The error message is:
> {code}
> 2015-01-21 15:31:21,156 ERROR [main] util.AbstractHBaseTool: Required option 
> -name is missing
> {code}
> while the usage prints:
> {code}
>  -n,--name The name of the created snapshot
> {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12907) Test patch should look for undeclared dependencies

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12907.
---

> Test patch should look for undeclared dependencies
> --
>
> Key: HBASE-12907
> URL: https://issues.apache.org/jira/browse/HBASE-12907
> Project: HBase
>  Issue Type: Improvement
>  Components: build
>Reporter: Sean Busbey
>Priority: Major
>
> Given the breadth of used undeclared dependencies in HBASE-12898, we should 
> expand the QA patch tester to look for them as they show up.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12906) Document the new load pushback mechanism and available policies

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12906.
---

> Document the new load pushback mechanism and available policies
> ---
>
> Key: HBASE-12906
> URL: https://issues.apache.org/jira/browse/HBASE-12906
> Project: HBase
>  Issue Type: Task
>  Components: documentation
>Reporter: Andrew Kyle Purtell
>Priority: Major
>
> HBASE-5162 introduced a new mechanism for supplying the client with server 
> side load information in response to mutations, and new configurable client 
> side policies for responding to this information with behavioral changes. 
> Document the new available configuration options and per-policy options.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12903) Fix configuration which enables secure bulk load

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12903.
---

> Fix configuration which enables secure bulk load
> 
>
> Key: HBASE-12903
> URL: https://issues.apache.org/jira/browse/HBASE-12903
> Project: HBase
>  Issue Type: Bug
>  Components: Coprocessors, documentation
>Affects Versions: 0.98.6, 2.0.0
>Reporter: Weichen Ye
>Assignee: Weichen Ye
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: HBASE-12903-v2.patch, HBASE-12903-v3.patch
>
>
> In Section "62.5. Secure Bulk Load", the doc tell us to enable secure 
> bulkload with the configuration:
> {code}
> 
> hbase.coprocessor.regionserver.classes
> org.apache.hadoop.hbase.security.token.TokenProvider,org.apache.hadoop.hbase.security.access.AccessController,
> org.apache.hadoop.hbase.security.access.SecureBulkLoadEndpoint
> 
> {code}
> When we set the configuration like this, the regionserver can not start due 
> to this ERROR:
> {code}
> 2015-01-22 15:55:46,395 FATAL 
> org.apache.hadoop.hbase.regionserver.HRegionServer: ABORTING region server 
> hadoop-node-x: The coprocessor 
> org.apache.hadoop.hbase.security.access.SecureBulkLoadEndpoint threw 
> java.lang.ClassCastException: 
> org.apache.hadoop.hbase.regionserver.RegionServerCoprocessorHost$RegionServerEnvironment
>  can not be cast to 
> org.apache.hadoop.hbase.coprocessor.RegionCoprocessorEnvironment
> java.lang.ClassCastException: 
> org.apache.hadoop.hbase.regionserver.RegionServerCoprocessorHost$RegionServerEnvironment
>  cannot be cast to 
> org.apache.hadoop.hbase.coprocessor.RegionCoprocessorEnvironment
> at 
> org.apache.hadoop.hbase.security.access.SecureBulkLoadEndpoint.start(SecureBulkLoadEndpoint.java:125)
> at 
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost$Environment.startup(CoprocessorHost.java:673)
> at 
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.loadInstance(CoprocessorHost.java:265)
> at 
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.loadSystemCoprocessors(CoprocessorHost.java:168)
> at 
> org.apache.hadoop.hbase.regionserver.RegionServerCoprocessorHost.(RegionServerCoprocessorHost.java:46)
> at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:883)
> at java.lang.Thread.run(Thread.java:745)
> {code}
> In source code org.apache.hadoop.hbase.security.access.SecureBulkLoadEndpoint 
> we can see, the environment for this coprocessor is 
> "RegionCoprocessorEnvironment". So the coprocessor "SecureBulkLoadEndpoint" 
> should be put into "hbase.coprocessor.region.classes", instead of 
> "hbase.coprocessor.regionserver.classes"
> The correct configuration to enable secure bulk load is:
> {code}
> 
> hbase.coprocessor.region.classes  
> org.apache.hadoop.hbase.security.token.TokenProvider,org.apache.hadoop.hbase.security.access.AccessController,
> org.apache.hadoop.hbase.security.access.SecureBulkLoadEndpoint
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-16555) JUnit dependency not scoped as test

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-16555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-16555.
---
Assignee: (was: Jan Hentschel)

> JUnit dependency not scoped as test
> ---
>
> Key: HBASE-16555
> URL: https://issues.apache.org/jira/browse/HBASE-16555
> Project: HBase
>  Issue Type: Bug
>  Components: build
>Affects Versions: 1.2.2
>Reporter: Robert G Duncan
>Priority: Major
> Attachments: HBASE-16555.master.001.patch
>
>
> *Issue*
> JUnit is included as a compile scope dependency. This increases the size of 
> dependent project shaded/Uber JARs unnecessarily.
> *Actual Entry*
> {code:xml}
>   
> junit
> junit
> ${junit.version}
>   
> {code}
> *Expected Entry*
> {code:xml}
> 
> junit
> junit
> ${junit.version}
> test
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-14266) RegionServers have a lock contention of Configuration.getProps

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-14266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-14266.
---

> RegionServers have a lock contention of Configuration.getProps
> --
>
> Key: HBASE-14266
> URL: https://issues.apache.org/jira/browse/HBASE-14266
> Project: HBase
>  Issue Type: Improvement
>  Components: regionserver
> Environment: hbase-0.98.6-cdh5.3.1
>Reporter: Toshihiro Suzuki
>Assignee: Andrew Kyle Purtell
>Priority: Critical
> Fix For: 1.2.0, 1.3.0, 2.0.0
>
> Attachments: 14266v2.patch, 14266v3.patch, 14266v3.txt, 
> HBASE-14266.patch, Screen Shot 2015-10-23 at 5.11.46 PM.png, Screen Shot 
> 2015-10-23 at 5.24.03 PM.png, thread_dump.txt
>
>
> Here's an extract from thread dump of the RegionServer of my cluster:
> {code}
> ...
> Thread 267 (RW.default.readRpcServer.handler=184,queue=15,port=60020):
>   State: BLOCKED
>   Blocked count: 204028
>   Waited count: 9702639
>   Blocked on org.apache.hadoop.conf.Configuration@5a5e3da
>   Blocked by 250 (RW.default.readRpcServer.handler=167,queue=18,port=60020)
>   Stack:
> org.apache.hadoop.conf.Configuration.getProps(Configuration.java:2250)
> org.apache.hadoop.conf.Configuration.get(Configuration.java:861)
> org.apache.hadoop.conf.Configuration.getTrimmed(Configuration.java:880)
> org.apache.hadoop.conf.Configuration.getBoolean(Configuration.java:1281)
> 
> org.apache.hadoop.hbase.regionserver.StoreScanner.(StoreScanner.java:138)
> 
> org.apache.hadoop.hbase.regionserver.StoreScanner.(StoreScanner.java:157)
> 
> org.apache.hadoop.hbase.regionserver.HStore.createScanner(HStore.java:1804)
> org.apache.hadoop.hbase.regionserver.HStore.getScanner(HStore.java:1794)
> 
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.(HRegion.java:3852)
> 
> org.apache.hadoop.hbase.regionserver.HRegion.instantiateRegionScanner(HRegion.java:1952)
> org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:1938)
> org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:1915)
> org.apache.hadoop.hbase.regionserver.HRegion.get(HRegion.java:4872)
> org.apache.hadoop.hbase.regionserver.HRegion.get(HRegion.java:4847)
> 
> org.apache.hadoop.hbase.regionserver.HRegionServer.get(HRegionServer.java:2918)
> 
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:29921)
> org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2031)
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:108)
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:116)
> org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:96)
> ...
> {code}
> There are such many threads in the thread dump.
> I think that RegionServers have a lock contention which causes performance 
> issue.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12921) Port HBASE-5356 'region_mover.rb can hang if table region it belongs to is deleted' to 0.94

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12921.
---

> Port HBASE-5356 'region_mover.rb can hang if table region it belongs to is 
> deleted' to 0.94
> ---
>
> Key: HBASE-12921
> URL: https://issues.apache.org/jira/browse/HBASE-12921
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.94.11
> Environment: 
>Reporter: Shaohui Liu
>Assignee: Shaohui Liu
>Priority: Minor
> Fix For: 0.94.28
>
> Attachments: HBASE-12921-v1.diff
>
>
> This is backport of HBASE-5356 'region_mover.rb can hang if table region it 
> belongs to is deleted' to 0.94.
> [~lhofhansl]



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Resolved] (HBASE-12909) Junit listed at compile scope instead of test

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell resolved HBASE-12909.
-
  Assignee: (was: Sean Busbey)
Resolution: Abandoned

> Junit listed at compile scope instead of test
> -
>
> Key: HBASE-12909
> URL: https://issues.apache.org/jira/browse/HBASE-12909
> Project: HBase
>  Issue Type: Bug
>  Components: build
>Affects Versions: 1.0.0
>Reporter: Sean Busbey
>Priority: Major
> Attachments: HBASE-12909.1.patch.txt
>
>
> Right now our top level pom lists junit as a dependency for every module in 
> the compile scope, which makes it subject to our compatibility promises.
> It should instead be test scope.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12912) Cache Configuration used during scanner creation

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12912.
---

> Cache Configuration used during scanner creation
> 
>
> Key: HBASE-12912
> URL: https://issues.apache.org/jira/browse/HBASE-12912
> Project: HBase
>  Issue Type: Sub-task
>Reporter: John Leach
>Priority: Major
> Attachments: StoreScannerStall.tiff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> There is a clear CPU drain and iterator creation when creating store scanners 
> under high load.  Splice was running a TPCC test of our database and we are 
> seeing object creation and CPU waste on the boolean check
> Code Snippet...
> if (store != null && ((HStore)store).getHRegion() != null
> && store.getStorefilesCount() > 1) {
>   RegionServerServices rsService = 
> ((HStore)store).getHRegion().getRegionServerServices();
>   if (rsService == null || !rsService.getConfiguration().getBoolean(
> STORESCANNER_PARALLEL_SEEK_ENABLE, false)) return;
>   isParallelSeekEnabled = true;
>   executor = rsService.getExecutorService();
> }
> Will attach profile...



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12913) [0.98] Backport HBASE-12892 Add a class to allow taking a snapshot from the command line

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12913.
---

> [0.98] Backport HBASE-12892 Add a class to allow taking a snapshot from the 
> command line
> 
>
> Key: HBASE-12913
> URL: https://issues.apache.org/jira/browse/HBASE-12913
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Priority: Major
>
> See parent. 



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12920) hadoopqa should compile with different hadoop versions

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12920.
---

> hadoopqa should compile with different hadoop versions 
> ---
>
> Key: HBASE-12920
> URL: https://issues.apache.org/jira/browse/HBASE-12920
> Project: HBase
>  Issue Type: Bug
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: hbase-12920_v1.patch
>
>
> From time to time, we break compilation with hadoop-2.4 or other earlier 
> versions, and only realize that at the time of a release candidate. 
> We should fix hadoopqa to do the compilation for us. 
> What I have locally is something like this: 
> {code}
> HADOOP2_VERSIONS="2.2.0 2.3.0 2.4.0 2.5.0 2.6.0"
> function buildWithHadoop2 {
>   for HADOOP2_VERSION in $HADOOP2_VERSIONS ; do
> echo ""
> echo "# BUILDING $ARTIFACT WITH HADOOP 2 VERSION $HADOOP2_VERSION 
> #"
> echo ""
> echo mvn clean install -DskipTests -Dhadoop-two.version=$HADOOP2_VERSION
> mvn clean install -DskipTests -Dhadoop-two.version=$HADOOP2_VERSION
>   done
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12923) ResultScanner is not closed in ModifyTableHandler#removeReplicaColumnsIfNeeded()

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12923.
---

> ResultScanner is not closed in 
> ModifyTableHandler#removeReplicaColumnsIfNeeded()
> 
>
> Key: HBASE-12923
> URL: https://issues.apache.org/jira/browse/HBASE-12923
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Priority: Trivial
> Attachments: 12923-v1.txt
>
>
> In ModifyTableHandler#removeReplicaColumnsIfNeeded():
> {code}
>   ResultScanner resScanner = metaTable.getScanner(scan);
>   for (Result result : resScanner) {
> {code}
> The ResultScanner is not closed upon exit from the method.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12922) Post-asciidoc conversion fix-ups part 2

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12922.
---

> Post-asciidoc conversion fix-ups part 2
> ---
>
> Key: HBASE-12922
> URL: https://issues.apache.org/jira/browse/HBASE-12922
> Project: HBase
>  Issue Type: Bug
>  Components: documentation
>Reporter: Lars Francke
>Assignee: Lars Francke
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: HBASE-12922.1.patch
>
>
> I did read through large parts of the documentation and fixed what I found. 
> Some of it is AsciiDoc stuff, some is contents, some is grammar, some typos 
> fixed etc.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Resolved] (HBASE-12923) ResultScanner is not closed in ModifyTableHandler#removeReplicaColumnsIfNeeded()

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell resolved HBASE-12923.
-
  Assignee: (was: Ted Yu)
Resolution: Abandoned

> ResultScanner is not closed in 
> ModifyTableHandler#removeReplicaColumnsIfNeeded()
> 
>
> Key: HBASE-12923
> URL: https://issues.apache.org/jira/browse/HBASE-12923
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Priority: Trivial
> Attachments: 12923-v1.txt
>
>
> In ModifyTableHandler#removeReplicaColumnsIfNeeded():
> {code}
>   ResultScanner resScanner = metaTable.getScanner(scan);
>   for (Result result : resScanner) {
> {code}
> The ResultScanner is not closed upon exit from the method.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Resolved] (HBASE-12930) Check single row size not exceed configured max row size across families for Get/Scan

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell resolved HBASE-12930.
-
Resolution: Incomplete

> Check single row size not exceed configured max row size across families for 
> Get/Scan
> -
>
> Key: HBASE-12930
> URL: https://issues.apache.org/jira/browse/HBASE-12930
> Project: HBase
>  Issue Type: Improvement
>  Components: Scanners
>Reporter: Jianwei Cui
>Priority: Minor
>
> StoreScanner#next will check the 'totalBytesRead' not exceed configured 
> ‘hbase.table.max.rowsize’ for each family. However, if there are several 
> families, the single row will also achieve unexpected big size even if 
> 'totalBytesRead' of each family not exceed 'hbase.table.max.rowsize'. This 
> may cause the region server fail because of OOM. What about checking single 
> row size across families in StoreScanner#next(List, int)?
> {code}
> long totalBytesRead = 0;
> // ==> compute the size of cells have been read
> for (Cell cell : outResult) {
>   totalBytesRead += CellUtil.estimatedSerializedSizeOf(old);
> }
> LOOP: while((cell = this.heap.peek()) != null) {
> ...
> {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12928) BaseLoadBalancer#needsBalance only checks the sloppiness of region count before balancing

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12928.
---

> BaseLoadBalancer#needsBalance only checks the sloppiness of region count 
> before balancing
> -
>
> Key: HBASE-12928
> URL: https://issues.apache.org/jira/browse/HBASE-12928
> Project: HBase
>  Issue Type: Improvement
>  Components: Balancer
>Affects Versions: 0.99.2
>Reporter: Jianwei Cui
>Priority: Minor
>
> BaseLoadBalancer#needsBalance will be invoked to judge whether needs to do 
> balancing. StochasticLoadBalancer do balancing by considering region count 
> skew cost, read/write request cost, locality cost, etc. However, it seems 
> that only sloppiness of region count is checked in 
> BaseLoadBalancer#needsBalance, there may be cases that request/locality cost 
> is high when region count is even, this will skip the actual balancing so 
> that can't achieve lower cost. There, Do we need to check sloppiness of other 
> factors(read/write request, locality, etc) in needsBalance?



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Resolved] (HBASE-12928) BaseLoadBalancer#needsBalance only checks the sloppiness of region count before balancing

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell resolved HBASE-12928.
-
Resolution: Incomplete

> BaseLoadBalancer#needsBalance only checks the sloppiness of region count 
> before balancing
> -
>
> Key: HBASE-12928
> URL: https://issues.apache.org/jira/browse/HBASE-12928
> Project: HBase
>  Issue Type: Improvement
>  Components: Balancer
>Affects Versions: 0.99.2
>Reporter: Jianwei Cui
>Priority: Minor
>
> BaseLoadBalancer#needsBalance will be invoked to judge whether needs to do 
> balancing. StochasticLoadBalancer do balancing by considering region count 
> skew cost, read/write request cost, locality cost, etc. However, it seems 
> that only sloppiness of region count is checked in 
> BaseLoadBalancer#needsBalance, there may be cases that request/locality cost 
> is high when region count is even, this will skip the actual balancing so 
> that can't achieve lower cost. There, Do we need to check sloppiness of other 
> factors(read/write request, locality, etc) in needsBalance?



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12938) Upgrade HTrace to a recent supportable incubating version

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12938.
---

> Upgrade HTrace to a recent supportable incubating version
> -
>
> Key: HBASE-12938
> URL: https://issues.apache.org/jira/browse/HBASE-12938
> Project: HBase
>  Issue Type: Bug
>Reporter: Andrew Kyle Purtell
>Priority: Major
>
> In 0.98 we have an old htrace (still using the org.cloudera.htrace package) 
> and since the introduction of htrace code, htrace itself first moved to 
> org.htrace, then became an incubating project. I filed this as a bug because 
> the HTrace version we reference in 0.98 is of little to no use going forward. 
> Unfortunately we must make a disruptive change, although it looks to be 
> mostly fixing up imports, we expose no HTrace classes to HBase configuration, 
> and where we extend HTrace classes in our code, those HBase classes are in 
> hbase-server and not tagged for public consumption.   



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12934) Utilize Flash storage for flushing

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12934.
---
Assignee: (was: Ted Yu)

> Utilize Flash storage for flushing
> --
>
> Key: HBASE-12934
> URL: https://issues.apache.org/jira/browse/HBASE-12934
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Priority: Major
> Attachments: 12934-001.txt
>
>
> Store flushing should be able to make use of hdfs storage policy.
> One option is to allow setting storage policy for the directory path of the 
> specified column family.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12935) Does any one consider the performance of HBase on SSD?

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12935.
---

> Does any one consider the performance of HBase on SSD? 
> ---
>
> Key: HBASE-12935
> URL: https://issues.apache.org/jira/browse/HBASE-12935
> Project: HBase
>  Issue Type: Improvement
>Reporter: Liang Lee
>Priority: Major
>
> Some features of HBase doesn't mathch features of SSD. Such as compaction is 
> harmful for SSD life span.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12930) Check single row size not exceed configured max row size across families for Get/Scan

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12930.
---

> Check single row size not exceed configured max row size across families for 
> Get/Scan
> -
>
> Key: HBASE-12930
> URL: https://issues.apache.org/jira/browse/HBASE-12930
> Project: HBase
>  Issue Type: Improvement
>  Components: Scanners
>Reporter: Jianwei Cui
>Priority: Minor
>
> StoreScanner#next will check the 'totalBytesRead' not exceed configured 
> ‘hbase.table.max.rowsize’ for each family. However, if there are several 
> families, the single row will also achieve unexpected big size even if 
> 'totalBytesRead' of each family not exceed 'hbase.table.max.rowsize'. This 
> may cause the region server fail because of OOM. What about checking single 
> row size across families in StoreScanner#next(List, int)?
> {code}
> long totalBytesRead = 0;
> // ==> compute the size of cells have been read
> for (Cell cell : outResult) {
>   totalBytesRead += CellUtil.estimatedSerializedSizeOf(old);
> }
> LOOP: while((cell = this.heap.peek()) != null) {
> ...
> {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12937) Infinite tracing loop brings down region server

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12937.
---

> Infinite tracing loop brings down region server
> ---
>
> Key: HBASE-12937
> URL: https://issues.apache.org/jira/browse/HBASE-12937
> Project: HBase
>  Issue Type: Bug
>Reporter: James R. Taylor
>Priority: Major
>
> See HTRACE-92 for more detail. I'm hoping that adding calls to 
> Tracer.getInstance().continueSpan(null) in the correct place(s) will do the 
> trick. This is rendering tracing unusable by Phoenix. Not sure if it impact 
> general HTrace use in HBase or not.
> FYI, [~samarthjain], [~jesse_yates].



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Resolved] (HBASE-12939) Make assembly plugin respect exclude list for /dev-support folder

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell resolved HBASE-12939.
-
Resolution: Not A Problem

> Make assembly plugin respect exclude list for /dev-support folder
> -
>
> Key: HBASE-12939
> URL: https://issues.apache.org/jira/browse/HBASE-12939
> Project: HBase
>  Issue Type: Bug
>  Components: build
>Reporter: Dima Spivak
>Priority: Major
>
> This is a follow-up to [~busbey]'s point in HBASE-12808 about the need for 
> the configuration in hbase-assembly/src/main/assembly/src.xml to properly 
> handle the dev-support folder.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12939) Make assembly plugin respect exclude list for /dev-support folder

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12939.
---

> Make assembly plugin respect exclude list for /dev-support folder
> -
>
> Key: HBASE-12939
> URL: https://issues.apache.org/jira/browse/HBASE-12939
> Project: HBase
>  Issue Type: Bug
>  Components: build
>Reporter: Dima Spivak
>Priority: Major
>
> This is a follow-up to [~busbey]'s point in HBASE-12808 about the need for 
> the configuration in hbase-assembly/src/main/assembly/src.xml to properly 
> handle the dev-support folder.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12940) Expose listPeerConfigs and getPeerConfig to the HBase shell

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12940.
---

> Expose listPeerConfigs and getPeerConfig to the HBase shell
> ---
>
> Key: HBASE-12940
> URL: https://issues.apache.org/jira/browse/HBASE-12940
> Project: HBase
>  Issue Type: Improvement
>  Components: shell
>Reporter: Kevin Risden
>Assignee: Geoffrey Jacoby
>Priority: Major
> Fix For: 1.3.0, 0.98.18, 2.0.0
>
> Attachments: HBASE-12940-v1.patch, HBASE-12940.patch
>
>
> In HBASE-12867 found that listPeerConfigs and getPeerConfig from 
> ReplicationAdmin are not exposed to the HBase shell. This makes looking at 
> details for custom replication endpoints and testing of add_peer from 
> HBASE-12867 impossible.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12941) CompactionRequestor - a private interface class with no users

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12941.
---

> CompactionRequestor - a private interface class with no users
> -
>
> Key: HBASE-12941
> URL: https://issues.apache.org/jira/browse/HBASE-12941
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Reporter: ryan rawson
>Priority: Major
> Attachments: HBASE-12941-master.patch, HBASE-12941.patch
>
>
> CompactionRequestor is a 'interface audience private' class with no users in 
> the HBase code base.  Unused things should be deleted.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12943) Set sun.net.inetaddr.ttl in HBase

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12943.
---

> Set sun.net.inetaddr.ttl in HBase
> -
>
> Key: HBASE-12943
> URL: https://issues.apache.org/jira/browse/HBASE-12943
> Project: HBase
>  Issue Type: Bug
>Reporter: Shaohui Liu
>Priority: Major
> Attachments: 12943-1-master.txt
>
>
> The default value of config: sun.net.inetaddr.ttl is -1 and the java 
> processes will cache the mapping of hostname to ip address  forever, See: 
> http://docs.oracle.com/javase/7/docs/technotes/guides/net/properties.html
> But things go wrong when a regionserver with same hostname and different ip 
> address rejoins the hbase cluster. The HMaster will get wrong ip address of 
> the regionserver from this cache and every region assignment to this 
> regionserver will be blocked for a time because the HMaster can't communicate 
> with the regionserver.
> A tradeoff is to set the sun.net.inetaddr.ttl to 10m or 1h and make the wrong 
> cache expired.
> Suggestions are welcomed. Thanks~



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12959) Compact never end when table's dataBlockEncoding using PREFIX_TREE

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12959.
---
Assignee: (was: Zheng Hu)

>  Compact never end when table's dataBlockEncoding using  PREFIX_TREE
> 
>
> Key: HBASE-12959
> URL: https://issues.apache.org/jira/browse/HBASE-12959
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.98.7
> Environment: hbase 0.98.7
> hadoop 2.5.1
>Reporter: wuchengzhi
>Priority: Critical
> Attachments: PrefixTreeCompact.java, txtfile-part1.txt.gz, 
> txtfile-part2.txt.gz, txtfile-part4.txt.gz, txtfile-part5.txt.gz, 
> txtfile-part6.txt.gz, txtfile-part7.txt.gz
>
>
> I upgraded the hbase from 0.96.1.1 to 0.98.7 and hadoop from 2.2.0 to 
> 2.5.1,some table encoding using prefix-tree was abnormal for compacting,  the 
> gui shows the table's Compaction status is MAJOR_AND_MINOR(MAJOR) all the 
> time.
> in the regionserver dump , there are some logs as below:
> Tasks:
> ===
> Task: Compacting info in 
> PREFIX_NOT_COMPACT,,1421954285670.41ef60e2c221772626e141d5080296c5.
> Status: RUNNING:Compacting store info
> Running for 1097s  (on the  site running more than 3 days)
> 
> Thread 197 (regionserver60020-smallCompactions-1421954341530):
>   State: RUNNABLE
>   Blocked count: 7
>   Waited count: 3
>   Stack:
> 
> org.apache.hadoop.hbase.codec.prefixtree.decode.PrefixTreeArrayScanner.followFan(PrefixTreeArrayScanner.java:329)
> 
> org.apache.hadoop.hbase.codec.prefixtree.decode.PrefixTreeArraySearcher.positionAtOrAfter(PrefixTreeArraySearcher.java:149)
> 
> org.apache.hadoop.hbase.codec.prefixtree.decode.PrefixTreeArraySearcher.seekForwardToOrAfter(PrefixTreeArraySearcher.java:183)
> 
> org.apache.hadoop.hbase.codec.prefixtree.PrefixTreeSeeker.seekToOrBeforeUsingPositionAtOrAfter(PrefixTreeSeeker.java:199)
> 
> org.apache.hadoop.hbase.codec.prefixtree.PrefixTreeSeeker.seekToKeyInBlock(PrefixTreeSeeker.java:162)
> 
> org.apache.hadoop.hbase.io.hfile.HFileReaderV2$EncodedScannerV2.loadBlockAndSeekToKey(HFileReaderV2.java:1172)
> 
> org.apache.hadoop.hbase.io.hfile.HFileReaderV2$AbstractScannerV2.reseekTo(HFileReaderV2.java:573)
> 
> org.apache.hadoop.hbase.regionserver.StoreFileScanner.reseekAtOrAfter(StoreFileScanner.java:257)
> 
> org.apache.hadoop.hbase.regionserver.StoreFileScanner.reseek(StoreFileScanner.java:173)
> 
> org.apache.hadoop.hbase.regionserver.NonLazyKeyValueScanner.doRealSeek(NonLazyKeyValueScanner.java:55)
> 
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.generalizedSeek(KeyValueHeap.java:313)
> 
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.reseek(KeyValueHeap.java:257)
> 
> org.apache.hadoop.hbase.regionserver.StoreScanner.reseek(StoreScanner.java:697)
> 
> org.apache.hadoop.hbase.regionserver.StoreScanner.seekAsDirection(StoreScanner.java:683)
> 
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:533)
> 
> org.apache.hadoop.hbase.regionserver.compactions.Compactor.performCompaction(Compactor.java:222)
> 
> org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(DefaultCompactor.java:77)
> 
> org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:110)
> org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1099)
> org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:1482)
> Thread 177 (regionserver60020-smallCompactions-1421954314809):
>   State: RUNNABLE
>   Blocked count: 40
>   Waited count: 60
>   Stack:
> 
> org.apache.hadoop.hbase.codec.prefixtree.decode.column.ColumnReader.populateBuffer(ColumnReader.java:81)
> 
> org.apache.hadoop.hbase.codec.prefixtree.decode.PrefixTreeArrayScanner.populateQualifier(PrefixTreeArrayScanner.java:471)
> 
> org.apache.hadoop.hbase.codec.prefixtree.decode.PrefixTreeArrayScanner.populateNonRowFields(PrefixTreeArrayScanner.java:452)
> 
> org.apache.hadoop.hbase.codec.prefixtree.decode.PrefixTreeArrayScanner.nextRow(PrefixTreeArrayScanner.java:226)
> 
> org.apache.hadoop.hbase.codec.prefixtree.decode.PrefixTreeArrayScanner.advance(PrefixTreeArrayScanner.java:208)
> 
> org.apache.hadoop.hbase.codec.prefixtree.decode.PrefixTreeArraySearcher.positionAtQualifierTimestamp(PrefixTreeArraySearcher.java:244)
> 
> org.apache.hadoop.hbase.codec.prefixtree.decode.PrefixTreeArraySearcher.positionAtOrAfter(PrefixTreeArraySearcher.java:123)
> 
> org.apache.hadoop.hbase.codec.prefixtree.decode.PrefixTreeArraySearcher.seekForwardToOrAfter(PrefixTreeArraySearcher.java:183)
> 
> 

[jira] [Updated] (HBASE-17375) PrefixTreeArrayReversibleScanner#previousRowInternal doesn't work correctly

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-17375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell updated HBASE-17375:

Fix Version/s: (was: 2.0.0)

> PrefixTreeArrayReversibleScanner#previousRowInternal doesn't work correctly
> ---
>
> Key: HBASE-17375
> URL: https://issues.apache.org/jira/browse/HBASE-17375
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.1.7, 0.98.23, 0.98.24
>Reporter: Chang chen
>Priority: Major
> Attachments: HBASE_17375_master_v1.patch, row trie example.PNG
>
>
> Recently, we find our hbase compaction thread never end.  Assume we have 
> following cells:
> {quote}
>  1
>  1
>  1
>  1
>  1
>  1
>  1
>  1
> {quote}
> If we encode above datas into prefix tree block, then it looks like:
> !row trie example.PNG!
> Assume the current row is {color:red}Abc{color} (e.g. the current row node is 
> 4), then the previous row should be *Aa* (e.g. 2). However 
> previousRowInternal return {color:red}A{color}(e.g. 1)
> After investigation, I believe it's the bug of 
> PrefixTreeArrayReversibleScanner#previousRowInternal.
> {code}
>   private boolean previousRowInternal() {
> //...
> while (!beforeFirst) {
>   //
>   // what if currentRowNode is nub?
>   if (currentRowNode.hasOccurrences()) {// escape clause
> currentRowNode.resetFanIndex();
> return true;// found some values
>   }
> }
> {code}
> currentRowNode.hasOccurrences() only test whether it has cell or not. But in 
> the case of  currentRowNode.isNub() is true, previousRowInternal should 
> follow the previous fan instead of return.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-17375) PrefixTreeArrayReversibleScanner#previousRowInternal doesn't work correctly

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-17375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-17375.
---
Assignee: (was: Chang chen)

> PrefixTreeArrayReversibleScanner#previousRowInternal doesn't work correctly
> ---
>
> Key: HBASE-17375
> URL: https://issues.apache.org/jira/browse/HBASE-17375
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.1.7, 0.98.23, 0.98.24
>Reporter: Chang chen
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: HBASE_17375_master_v1.patch, row trie example.PNG
>
>
> Recently, we find our hbase compaction thread never end.  Assume we have 
> following cells:
> {quote}
>  1
>  1
>  1
>  1
>  1
>  1
>  1
>  1
> {quote}
> If we encode above datas into prefix tree block, then it looks like:
> !row trie example.PNG!
> Assume the current row is {color:red}Abc{color} (e.g. the current row node is 
> 4), then the previous row should be *Aa* (e.g. 2). However 
> previousRowInternal return {color:red}A{color}(e.g. 1)
> After investigation, I believe it's the bug of 
> PrefixTreeArrayReversibleScanner#previousRowInternal.
> {code}
>   private boolean previousRowInternal() {
> //...
> while (!beforeFirst) {
>   //
>   // what if currentRowNode is nub?
>   if (currentRowNode.hasOccurrences()) {// escape clause
> currentRowNode.resetFanIndex();
> return true;// found some values
>   }
> }
> {code}
> currentRowNode.hasOccurrences() only test whether it has cell or not. But in 
> the case of  currentRowNode.isNub() is true, previousRowInternal should 
> follow the previous fan instead of return.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12944) Support patches to branches in precommit jenkins build

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12944.
---

> Support patches to branches in precommit jenkins build 
> ---
>
> Key: HBASE-12944
> URL: https://issues.apache.org/jira/browse/HBASE-12944
> Project: HBase
>  Issue Type: New Feature
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: hbase-12944.patch, hbase-12944.patch, 
> test-hadoopqa-0.94.patch, test-hadoopqa-0.94.patch, test-hadoopqa-0.98.patch, 
> test-hadoopqa-0.98.patch, test-hadoopqa-branch-1.patch, 
> test-hadoopqa-branch-1.patch, test-hadoopqa-branch-1.patch, 
> test-hadoopqa-branch-1.patch
>
>
> We have a quite a few active branches now, which makes backporting a full 
> time job. 
> I was thinking about whether we can get hadoopqa to test the patches specific 
> to branches with the code from that branch. I think we can grab the branch 
> name from the patch file name and check out that branch prior to running the 
> tests. I have a patch, but not sure whether it will work. Let me experiment a 
> bit.   If hadoopqa gets broken, it is probably this issue. 



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12945) Port: New master API to track major compaction completion to 0.98

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12945.
---

> Port: New master API to track major compaction completion to 0.98
> -
>
> Key: HBASE-12945
> URL: https://issues.apache.org/jira/browse/HBASE-12945
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Lars Hofhansl
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-13081) Branch precommit builds are not updating to branch head before patch application

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-13081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-13081.
---

> Branch precommit builds are not updating to branch head before patch 
> application
> 
>
> Key: HBASE-13081
> URL: https://issues.apache.org/jira/browse/HBASE-13081
> Project: HBase
>  Issue Type: Bug
>Reporter: Andrew Kyle Purtell
>Assignee: Enis Soztutar
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: foo_0.98.patch, foo_branch-1.patch, hbase-13081.patch
>
>
> See for example 
> https://builds.apache.org/job/PreCommit-HBASE-Build/12922//console
> {noformat}
> git checkout 0.98
> Previous HEAD position was 03d8918... HBASE-13069 Thrift Http Server returns 
> an error code of 500 instead of 401 when authentication fails (Srikanth 
> Srungarapu)
> Switched to branch '0.98'
> Your branch is behind 'origin/0.98' by 48 commits, and can be fast-forwarded.
>   (use "git pull" to update your local branch)
> git status
> On branch 0.98
> Your branch is behind 'origin/0.98' by 48 commits, and can be fast-forwarded.
>   (use "git pull" to update your local branch)
> Untracked files:
>   (use "git add ..." to include in what will be committed)
>   patchprocess/
> nothing added to commit but untracked files present (use "git add" to track)
> {noformat}
> Because the local tree is 48 commits behind the head of the 0.98 branch, the 
> contributor's patch based on the head of 0.98 branch cannot cleanly apply. 



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12947) Replicating DDL statements like create from one cluster to another

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12947.
---

> Replicating DDL statements like create  from one cluster to another
> ---
>
> Key: HBASE-12947
> URL: https://issues.apache.org/jira/browse/HBASE-12947
> Project: HBase
>  Issue Type: New Feature
>  Components: Replication
>Affects Versions: 2.0.0
>Reporter: Prabhu Joseph
>Priority: Critical
>
> Problem:
>   When tables are created dynamically in Hbase cluster, the Replication 
> feature can't be used as the new table does not exist in peer cluster. To use 
> the replication, we need to create same table in peer cluster also.
>Having API to replicate the create table statement at peer cluster will be 
> more helpful in such cases.
> Solution:
> create 'table','cf',replication => true , peerFlag => true
> if peerFlag = true, the table with the column family has to be created at 
> peer
> cluster.
>Special cases like enabling replication at peer cluster also for cyclic 
> replication has to be considered.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Resolved] (HBASE-12950) Extend the truncate command to handle region ranges and not just the whole table

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell resolved HBASE-12950.
-
  Assignee: (was: Esteban Gutierrez)
Resolution: Not A Problem

> Extend the truncate command to handle region ranges and not just the whole 
> table
> 
>
> Key: HBASE-12950
> URL: https://issues.apache.org/jira/browse/HBASE-12950
> Project: HBase
>  Issue Type: New Feature
>  Components: Region Assignment, regionserver, shell
>Affects Versions: 2.0.0
>Reporter: Esteban Gutierrez
>Priority: Major
>
> We have seen many times during the last few years that when key prefixes are 
> time based and the access pattern only consists of writes to recent KVs we 
> can end up with tens of thousands of regions and some of those regions will 
> not be longer used. Even if users use TTLs and data is eventually deleted we 
> still have the old regions around and only performing an online merge can 
> help to reduce the excess of regions. Extending the truncate command to 
> handle also region ranges can help user that experience this issue to trim 
> the old regions if required.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Commented] (HBASE-27117) Update the method comments for RegionServerAccounting

2022-06-17 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555738#comment-17555738
 ] 

Hudson commented on HBASE-27117:


Results for branch branch-2.5
[build #145 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/145/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/145/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/145/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/145/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/145/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Update the method comments for RegionServerAccounting
> -
>
> Key: HBASE-27117
> URL: https://issues.apache.org/jira/browse/HBASE-27117
> Project: HBase
>  Issue Type: Bug
>Reporter: Tao Li
>Assignee: Tao Li
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.13
>
>
> After HBASE-15787, the return value type of 
> RegionServerAccounting#isAboveHighWaterMark and 
> RegionServerAccounting#isAboveLowWaterMark are no longer boolean.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12949) Scanner can be stuck in infinite loop if the HFile is corrupted

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12949.
---

> Scanner can be stuck in infinite loop if the HFile is corrupted
> ---
>
> Key: HBASE-12949
> URL: https://issues.apache.org/jira/browse/HBASE-12949
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.94.3, 0.98.10
>Reporter: Jerry He
>Assignee: Jerry He
>Priority: Major
> Fix For: 1.4.0, 2.0.0
>
> Attachments: HBASE-12949-branch-1-v3.patch, HBASE-12949-master-v2 
> (1).patch, HBASE-12949-master-v2.patch, HBASE-12949-master-v2.patch, 
> HBASE-12949-master-v2.patch, HBASE-12949-master-v3.patch, 
> HBASE-12949-master.patch
>
>
> We've encountered problem where compaction hangs and never completes.
> After looking into it further, we found that the compaction scanner was stuck 
> in a infinite loop. See stack below.
> {noformat}
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.generalizedSeek(KeyValueHeap.java:296)
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.reseek(KeyValueHeap.java:257)
> org.apache.hadoop.hbase.regionserver.StoreScanner.reseek(StoreScanner.java:697)
> org.apache.hadoop.hbase.regionserver.StoreScanner.seekToNextRow(StoreScanner.java:672)
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:529)
> org.apache.hadoop.hbase.regionserver.compactions.Compactor.performCompaction(Compactor.java:223)
> {noformat}
> We identified the hfile that seems to be corrupted.  Using HFile tool shows 
> the following:
> {noformat}
> [biadmin@hdtest009 bin]$ hbase org.apache.hadoop.hbase.io.hfile.HFile -v -k 
> -m -f 
> /user/biadmin/CUMMINS_INSITE_V1/7106432d294dd844be15996ccbf2ba84/attributes/f1a7e3113c2c4047ac1fc8fbcb41d8b7
> 15/01/23 11:53:17 INFO Configuration.deprecation: hadoop.native.lib is 
> deprecated. Instead, use io.native.lib.available
> 15/01/23 11:53:18 INFO util.ChecksumType: Checksum using 
> org.apache.hadoop.util.PureJavaCrc32
> 15/01/23 11:53:18 INFO util.ChecksumType: Checksum can use 
> org.apache.hadoop.util.PureJavaCrc32C
> 15/01/23 11:53:18 INFO Configuration.deprecation: fs.default.name is 
> deprecated. Instead, use fs.defaultFS
> Scanning -> 
> /user/biadmin/CUMMINS_INSITE_V1/7106432d294dd844be15996ccbf2ba84/attributes/f1a7e3113c2c4047ac1fc8fbcb41d8b7
> WARNING, previous row is greater then current row
> filename -> 
> /user/biadmin/CUMMINS_INSITE_V1/7106432d294dd844be15996ccbf2ba84/attributes/f1a7e3113c2c4047ac1fc8fbcb41d8b7
> previous -> 
> \x00/20110203-094231205-79442793-1410161293068203000\x0Aattributes16794406\x00\x00\x01\x00\x00\x00\x00\x00\x00
> current  ->
> Exception in thread "main" java.nio.BufferUnderflowException
> at java.nio.Buffer.nextGetIndex(Buffer.java:489)
> at java.nio.HeapByteBuffer.getInt(HeapByteBuffer.java:347)
> at 
> org.apache.hadoop.hbase.io.hfile.HFileReaderV2$ScannerV2.readKeyValueLen(HFileReaderV2.java:856)
> at 
> org.apache.hadoop.hbase.io.hfile.HFileReaderV2$ScannerV2.next(HFileReaderV2.java:768)
> at 
> org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter.scanKeysValues(HFilePrettyPrinter.java:362)
> at 
> org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter.processFile(HFilePrettyPrinter.java:262)
> at 
> org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter.run(HFilePrettyPrinter.java:220)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at 
> org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter.main(HFilePrettyPrinter.java:539)
> at org.apache.hadoop.hbase.io.hfile.HFile.main(HFile.java:802)
> {noformat}
> Turning on Java Assert shows the following:
> {noformat}
> Exception in thread "main" java.lang.AssertionError: Key 
> 20110203-094231205-79442793-1410161293068203000/attributes:16794406/1099511627776/Minimum/vlen=15/mvcc=0
>  followed by a smaller key //0/Minimum/vlen=0/mvcc=0 in cf attributes
> at 
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:672)
> {noformat}
> It shows that the hfile seems to be corrupted -- the keys don't seem to be 
> right.
> But Scanner is not able to give a meaningful error, but stuck in an infinite 
> loop in here:
> {code}
> KeyValueHeap.generalizedSeek()
> while ((scanner = heap.poll()) != null) {
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12950) Extend the truncate command to handle region ranges and not just the whole table

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12950.
---

> Extend the truncate command to handle region ranges and not just the whole 
> table
> 
>
> Key: HBASE-12950
> URL: https://issues.apache.org/jira/browse/HBASE-12950
> Project: HBase
>  Issue Type: New Feature
>  Components: Region Assignment, regionserver, shell
>Affects Versions: 2.0.0
>Reporter: Esteban Gutierrez
>Priority: Major
>
> We have seen many times during the last few years that when key prefixes are 
> time based and the access pattern only consists of writes to recent KVs we 
> can end up with tens of thousands of regions and some of those regions will 
> not be longer used. Even if users use TTLs and data is eventually deleted we 
> still have the old regions around and only performing an online merge can 
> help to reduce the excess of regions. Extending the truncate command to 
> handle also region ranges can help user that experience this issue to trim 
> the old regions if required.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12812) Update Netty dependency to latest release

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12812.
---

> Update Netty dependency to latest release
> -
>
> Key: HBASE-12812
> URL: https://issues.apache.org/jira/browse/HBASE-12812
> Project: HBase
>  Issue Type: Improvement
>Reporter: Jurriaan Mous
>Assignee: Jurriaan Mous
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: 12812v2.txt, HBASE-12812.patch
>
>
> Netty version was 4.0.23.Release of august 15th. 
> Lets update to 4.0.25 which contains some performance improvements and bug 
> fixes.
> http://netty.io/news/2014/10/29/4-0-24-Final.html
> http://netty.io/news/2014/12/31/4-0-25-Final.html



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12813) Reporting region in transition shouldn't loop forever

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12813.
---
Assignee: (was: Elliott Neil Clark)

> Reporting region in transition shouldn't loop forever
> -
>
> Key: HBASE-12813
> URL: https://issues.apache.org/jira/browse/HBASE-12813
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Neil Clark
>Priority: Major
>
> We had an issue where a region server wasn't able to send the report region 
> in transition request. Well after failing it just retries forever.
> At some point it would have been better to just abort the region server if it 
> can't talk to master.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12816) GC logs are lost upon Region Server restart if GCLogFileRotation is enabled

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12816.
---

> GC logs are lost upon Region Server restart if GCLogFileRotation is enabled
> ---
>
> Key: HBASE-12816
> URL: https://issues.apache.org/jira/browse/HBASE-12816
> Project: HBase
>  Issue Type: Bug
>  Components: scripts
>Reporter: Abhishek Singh Chouhan
>Priority: Minor
> Attachments: HBASE-12816.patch
>
>
> When -XX:+UseGCLogFileRotation is used gc log files end with .gc.0 instead of 
> .gc.  hbase_rotate_log () in hbase-daemon.sh does not handle this correctly 
> and hence when a RS is restarted old gc logs are lost(overwritten).



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Resolved] (HBASE-14927) Backport HBASE-13014 (Java Tool For Region Moving) to branch-1

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell resolved HBASE-14927.
-
Fix Version/s: (was: 1.8.0)
 Assignee: (was: Abhishek Singh Chouhan)
   Resolution: Won't Fix

> Backport HBASE-13014 (Java Tool For Region Moving) to branch-1
> --
>
> Key: HBASE-14927
> URL: https://issues.apache.org/jira/browse/HBASE-14927
> Project: HBase
>  Issue Type: Improvement
>Reporter: Abhishek Singh Chouhan
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-19456) RegionMover's region server hostname option is no longer case insensitive

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-19456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-19456.
---

> RegionMover's region server hostname option is no longer case insensitive
> -
>
> Key: HBASE-19456
> URL: https://issues.apache.org/jira/browse/HBASE-19456
> Project: HBase
>  Issue Type: Bug
>  Components: tooling
>Reporter: Romil Choksi
>Assignee: Sergey Soldatov
>Priority: Major
> Fix For: 2.0.0-beta-1, 2.0.0
>
> Attachments: HBASE-19456.v1-master.patch, HBASE-19456.v2-master.patch
>
>
> With the move from the ruby-based to java-based RegionMover implementation, 
> it appears that the case-insensitivity "feature" was dropped. If the user 
> provides a RS hostname in the wrong case, the class will fail to perform its 
> actions.
> DNS hostnames are case insensitive, so this would be nice to restore.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-14749) Make changes to region_mover.rb to use RegionMover Java tool

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-14749.
---

> Make changes to region_mover.rb to use RegionMover Java tool
> 
>
> Key: HBASE-14749
> URL: https://issues.apache.org/jira/browse/HBASE-14749
> Project: HBase
>  Issue Type: Improvement
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: HBASE-14749-v2.patch, HBASE-14749-v3.patch, 
> HBASE-14749-v3.patch, HBASE-14749-v4.patch, HBASE-14749-v5.patch, 
> HBASE-14749.patch, HBASE-14749.patch
>
>
> With HBASE-13014 in, we can now replace the ruby script such that it invokes 
> the Java Tool. Also expose timeout and no-ack mode which were added.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12823) Visibility label security at limited localized level

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12823.
---

> Visibility label security at limited localized level
> 
>
> Key: HBASE-12823
> URL: https://issues.apache.org/jira/browse/HBASE-12823
> Project: HBase
>  Issue Type: Improvement
>  Components: security
>Affects Versions: 1.0.0, 0.98.10, 2.0.0
>Reporter: Jerry He
>Priority: Major
>
> Currently, if visibility label security is enabled for a HBase instance, 
> after VisibilityController is configured, the cell level visibility label 
> filtering will kick in across the HBase instance.
> Cell level visibility label filtering has non-negligible performance impact.
> On the other hand, in many use cases, only a small portion of the overall 
> data needs visibility label protection.
> If we can support  visibility label security at a limited and localized 
> level, we will broaden the use cases and the adoption of this feature.
> We should be able to support visibility label security at per table or per 
> column family level. This is quite common in many other HBase features.
> Cell level visibility label filtering will only be enabled and kick in for 
> the tables or column families that the user designates.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-13014) Java Tool For Region Moving

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-13014.
---

> Java Tool For Region Moving 
> 
>
> Key: HBASE-13014
> URL: https://issues.apache.org/jira/browse/HBASE-13014
> Project: HBase
>  Issue Type: Improvement
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: HBASE-13014-master-v2.patch, HBASE-13014-master-v3 
> (1).patch, HBASE-13014-master-v3 (1).patch, HBASE-13014-master-v3 (1).patch, 
> HBASE-13014-master-v3.patch, HBASE-13014-master-v3.patch, 
> HBASE-13014-master-v3.patch, HBASE-13014-master.patch, HBASE-13014-v2.patch, 
> HBASE-13014-v3.patch, HBASE-13014-v4.patch, HBASE-13014-v5.patch, 
> HBASE-13014-v6.patch, HBASE-13014.patch
>
>
> As per discussion on HBASE-12989 we should move the functionality of 
> region_mover.rb into a Java tool and use region_mover.rb only only as a 
> wrapper around it.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-14927) Backport HBASE-13014 (Java Tool For Region Moving) to branch-1

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-14927.
---

> Backport HBASE-13014 (Java Tool For Region Moving) to branch-1
> --
>
> Key: HBASE-14927
> URL: https://issues.apache.org/jira/browse/HBASE-14927
> Project: HBase
>  Issue Type: Improvement
>Reporter: Abhishek Singh Chouhan
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12822) Option for Unloading regions through region_mover.rb without Acknowledging

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12822.
---

> Option for Unloading regions through region_mover.rb without Acknowledging
> --
>
> Key: HBASE-12822
> URL: https://issues.apache.org/jira/browse/HBASE-12822
> Project: HBase
>  Issue Type: Improvement
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
>Priority: Minor
> Fix For: 2.0.0
>
>
> Currently we acknowledge if region is up in Target RS after being moved.We 
> can improve performance of Graceful Stop/Rolling restarts if we introduce a 
> flag based mode which does not Acknowledge if regions are successfully up on 
> the Target region server.This would work fine as Regions will be moved once 
> Region Server shuts down anyways.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12821) Describe on table doesn't show table attributes on hbase shell

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12821.
---

> Describe on table doesn't show table attributes on hbase shell
> --
>
> Key: HBASE-12821
> URL: https://issues.apache.org/jira/browse/HBASE-12821
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.98.8
>Reporter: Amit Kabra
>Priority: Minor
>
> 1) hbase(main):003:0> create 'test','CF'
> 2) hbase(main):006:0> alter 'test', METADATA => {'TEST_PROPERTY' => 
> 'TEST_VALUE'}
> 3) hbase(main):007:0> describe 'test'
> {NAME => 'CF', DATA_BLOCK_ENCODING => 'NONE', BLOOMFILTER => 'ROW', 
> REPLICATION_SCOPE => '0', VERSIONS => '1', COMPRESSION => 'NONE', 
> MIN_VERSIONS => '0', TTL => 'FOREVER', KEEP_DELETED_CELLS => 'FALSE', 
> BLOCKSIZE => '65536', IN_MEMORY => 'false', BLOCKCACHE => 'true'}   
> Issue : The added property , table attribute, isn't getting displayed.
> Note : If we check the table description from master page, we can see the 
> changed property.
> 'test', {TABLE_ATTRIBUTES => {METADATA => {'TEST_PROPERTY' => 'TEST_VALUE'}}, 
> {NAME => 'CF'}  



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12818) TestSnapshotFromMaster#testSnapshotHFileArchiving is failing occasionally

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12818.
---

> TestSnapshotFromMaster#testSnapshotHFileArchiving is failing occasionally
> -
>
> Key: HBASE-12818
> URL: https://issues.apache.org/jira/browse/HBASE-12818
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Affects Versions: 1.1.0
>Reporter: Dima Spivak
>Priority: Major
>
> Starting in late December, our internal runs on branch-1 have failed every 
> few days with the following:
> {code}
> java.lang.AssertionError: Archived hfiles [] is missing snapshot 
> file:c7ed21029d4e4cb28fdd138a28c8f3e7
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.assertTrue(Assert.java:41)
>   at 
> org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster.testSnapshotHFileArchiving(TestSnapshotFromMaster.java:347)
> {code}
> A full log of the stdout from one of these runs can be found [on 
> Gist|https://gist.github.com/dimaspivak/1c27a5d95e26c4bedc4f]; the relevant 
> portion seems to be
> {code}
> 2015-01-07 05:04:06,015 DEBUG 
> [B.defaultRpcServer.handler=3,queue=0,port=55325] 
> util.FSTableDescriptors(177): Exception during readTableDecriptor. Current 
> table name = test
> org.apache.hadoop.hbase.TableInfoMissingException: No table descriptor file 
> under 
> hdfs://localhost:42974/user/jenkins/test-data/ce542e14-a8e7-4764-8a68-8fb6401ebeb8/data/default/test
>   at 
> org.apache.hadoop.hbase.util.FSTableDescriptors.getTableDescriptorFromFs(FSTableDescriptors.java:509)
>   at 
> org.apache.hadoop.hbase.util.FSTableDescriptors.getTableDescriptorFromFs(FSTableDescriptors.java:487)
>   at 
> org.apache.hadoop.hbase.util.FSTableDescriptors.get(FSTableDescriptors.java:172)
>   at 
> org.apache.hadoop.hbase.master.HMaster.listTableDescriptors(HMaster.java:2165)
>   at 
> org.apache.hadoop.hbase.master.MasterRpcServices.getTableDescriptors(MasterRpcServices.java:787)
>   at 
> org.apache.hadoop.hbase.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java:42402)
>   at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2028)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:108)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
>   at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
>   at java.lang.Thread.run(Thread.java:744)
> {code}
> I've yet to see this on upstream runs, but I'll keep an eye out. Also, note 
> that this is unrelated to HBASE-9072, which had the same test failing for 
> other reasons back in 2013.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Resolved] (HBASE-12826) Expose draining servers into ClusterStatus

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell resolved HBASE-12826.
-
  Assignee: (was: Esteban Gutierrez)
Resolution: Incomplete

> Expose draining servers into ClusterStatus
> --
>
> Key: HBASE-12826
> URL: https://issues.apache.org/jira/browse/HBASE-12826
> Project: HBase
>  Issue Type: Improvement
>Reporter: Esteban Gutierrez
>Priority: Major
>
> We currently keep track of dead, live and in-transition RegionServers I think 
> we should expose also the list of servers that are being decommissioned via 
> draining.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12827) set rowOffsetPerColumnFamily on ClientSmallScanner if lastResult is not null.

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12827.
---

> set rowOffsetPerColumnFamily on ClientSmallScanner if lastResult is not null.
> -
>
> Key: HBASE-12827
> URL: https://issues.apache.org/jira/browse/HBASE-12827
> Project: HBase
>  Issue Type: Bug
>  Components: Client, Scanners
>Reporter: Toshimasa NASU
>Priority: Major
> Attachments: HBASE-12827-v1.patch
>
>
> When you use the ClientSmallScanner, same Result has been acquired. And will 
> be infinite loop.
> Cause to occur if you iterations beyond the (batch size * caching size) of 
> Scan.
> Solution I think would be to correctly set the rowOffsetPerColumnFamily.
> I can be resolved by the following patch work.
> https://github.com/toshimasa-nasu/hbase/commit/2c35914624d3494c79114926d35fc886c9a235ec
> {code}
>// When fetching results from server, skip the first result if it has the 
> same
>// row with this one
>private byte[] skipRowOfFirstResult = null;
> +  private boolean alreadyGetRowOfFirstResult = false;
> +  private int nextRowOffsetPerColumnFamily = 0;
>  
>/**
> * Create a new ClientSmallScanner for the specified table. An HConnection
>  @@ -142,10 +144,19 @@ private boolean nextScanner(int nbRows, final boolean 
> done,
>  LOG.debug("Finished with region " + this.currentRegion);
>}
>  } else if (this.lastResult != null) {
> +  if (alreadyGetRowOfFirstResult) {
> +nextRowOffsetPerColumnFamily += (this.scan.getBatch() * 
> this.caching);
> +  } else {
> +nextRowOffsetPerColumnFamily = (this.scan.getBatch() * (this.caching 
> - 1));
> +  }
> +  this.scan.setRowOffsetPerColumnFamily(nextRowOffsetPerColumnFamily);
> +  alreadyGetRowOfFirstResult = true;
>localStartKey = this.lastResult.getRow();
>skipRowOfFirstResult = this.lastResult.getRow();
>cacheNum++;
>  } else {
> +  alreadyGetRowOfFirstResult = false;
> +  nextRowOffsetPerColumnFamily = 0;
>localStartKey = this.scan.getStartRow();
>  }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12829) Request count in RegionLoad may not accurate to compute the load cost for region

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12829.
---

> Request count in RegionLoad may not accurate to compute the load cost for 
> region
> 
>
> Key: HBASE-12829
> URL: https://issues.apache.org/jira/browse/HBASE-12829
> Project: HBase
>  Issue Type: Improvement
>  Components: Balancer
>Affects Versions: 0.99.2
>Reporter: Jianwei Cui
>Priority: Minor
>
> StochasticLoadBalancer#RequestCostFunction(ReadRequestCostFunction and 
> WriteRequestCostFunction) will compute load cost for a region based on a 
> number of remembered region loads. Each region load records the total count 
> for read/write request at reported time since it opened. However, the request 
> count will be reset if region moved, making the new reported count could not 
> represent the total request. For example, if a region has high write 
> throughput, the WrtieRequest in region load will be very big after onlined 
> for a long time, then if the region moved, the new WriteRequest will be much 
> smaller, making the region contributes much smaller to the cost of its 
> belonging rs. We may need to consider the region open time to get more 
> accurate region load. 
> As another way, how about using read/write request count at each time slots 
> instead of total request count? The total count will make older read/write 
> request throughput contribute more to the cost by 
> CostFromRegionLoadFunction#getRegionLoadCost:
> {code}
> protected double getRegionLoadCost(Collection regionLoadList) 
> {
>   double cost = 0;
>   for (RegionLoad rl : regionLoadList) {
> double toAdd = getCostFromRl(rl);
> if (cost == 0) {
>   cost = toAdd;
> } else {
>   cost = (.5 * cost) + (.5 * toAdd);
> }
>   }
>   return cost;
> }
> {code}
> For example, assume the balancer now remembers three loads for a region at 
> time t1, t2, t3(t1 < t2 < t3), the write request is w1, w2, w3 respectively 
> for time slots [0, t1), [t1, t2), [t2, t3), so the WriteRequest in the region 
> load at t1, t2, t3 will be w1, w1 + w2, w1 + w2 + w3 and the WriteRequest 
> cost will be:
> {code}
> 0.5 * (w1 + w2 + w3) + 0.25 * (w1 + w2)  + 0.25 * w1 = w1 + 0.75 * w2 + 
> 0.5 * w3
> {code}
> The w1 contributes more to the cost than w2 and w3. However, intuitively, I 
> think the recent read/write throughput should represent the current load of 
> the region better than the older ones. Therefore, how about using w1, w2 and 
> w3 directly when computing? Then, the cost will become:
> {code}
> 0.25 * w1 + 0.25 * w2 + 0.5 * w3
> {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12826) Expose draining servers into ClusterStatus

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12826.
---

> Expose draining servers into ClusterStatus
> --
>
> Key: HBASE-12826
> URL: https://issues.apache.org/jira/browse/HBASE-12826
> Project: HBase
>  Issue Type: Improvement
>Reporter: Esteban Gutierrez
>Priority: Major
>
> We currently keep track of dead, live and in-transition RegionServers I think 
> we should expose also the list of servers that are being decommissioned via 
> draining.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12828) Add getTableAttributes API to HBaseAdmin class.

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12828.
---

> Add getTableAttributes API to HBaseAdmin class. 
> 
>
> Key: HBASE-12828
> URL: https://issues.apache.org/jira/browse/HBASE-12828
> Project: HBase
>  Issue Type: Improvement
>Reporter: Amit Kabra
>Priority: Minor
>
> At present, there is no api/function to get table attributes. It would be 
> nice to have a function that returns table attributes given the table name.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (HBASE-12843) TestAssignmentManager.testOpenCloseRegionRPCIntendedForPreviousServer failing frequently in 0.98 builds

2022-06-17 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-12843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-12843.
---

> TestAssignmentManager.testOpenCloseRegionRPCIntendedForPreviousServer failing 
> frequently in 0.98 builds
> ---
>
> Key: HBASE-12843
> URL: https://issues.apache.org/jira/browse/HBASE-12843
> Project: HBase
>  Issue Type: Bug
>Reporter: Andrew Kyle Purtell
>Priority: Major
>
> TestAssignmentManager.testOpenCloseRegionRPCIntendedForPreviousServer has 
> started failing intermittently in 0.98 builds:
> {noformat}
> java.lang.AssertionError: expected: but 
> was:
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:743)
>   at org.junit.Assert.assertEquals(Assert.java:118)
>   at org.junit.Assert.assertEquals(Assert.java:144)
>   at 
> org.apache.hadoop.hbase.master.TestAssignmentManager.testOpenCloseRegionRPCIntendedForPreviousServer(TestAssignmentManager.java:1425)
> {noformat}
> For example, in 
> https://builds.apache.org/job/HBase-0.98/789/testReport/junit/org.apache.hadoop.hbase.master/TestAssignmentManager/testOpenCloseRegionRPCIntendedForPreviousServer/



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


  1   2   3   4   5   6   7   8   9   10   >