[
https://issues.apache.org/jira/browse/HBASE-27710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702058#comment-17702058
]
Hudson commented on HBASE-27710:
Results for branch branch-2.4
[build #531 on
Apache-HBase commented on PR #5114:
URL: https://github.com/apache/hbase/pull/5114#issuecomment-1474690296
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 23s |
Apache-HBase commented on PR #5114:
URL: https://github.com/apache/hbase/pull/5114#issuecomment-1474689622
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
[
https://issues.apache.org/jira/browse/HBASE-27710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702056#comment-17702056
]
Hudson commented on HBASE-27710:
Results for branch branch-2
[build #770 on
Apache-HBase commented on PR #5114:
URL: https://github.com/apache/hbase/pull/5114#issuecomment-1474558599
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
vli02 commented on PR #5081:
URL: https://github.com/apache/hbase/pull/5081#issuecomment-1474550164
Jenkins test me please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Apache-HBase commented on PR #5117:
URL: https://github.com/apache/hbase/pull/5117#issuecomment-1474527985
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
Apache-HBase commented on PR #5117:
URL: https://github.com/apache/hbase/pull/5117#issuecomment-1474525492
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
Apache-HBase commented on PR #5116:
URL: https://github.com/apache/hbase/pull/5116#issuecomment-1474487716
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 56s |
Apache-HBase commented on PR #5116:
URL: https://github.com/apache/hbase/pull/5116#issuecomment-1474443638
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 20s |
Apache-HBase commented on PR #5117:
URL: https://github.com/apache/hbase/pull/5117#issuecomment-1474395900
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 2s |
virajjasani commented on PR #5117:
URL: https://github.com/apache/hbase/pull/5117#issuecomment-1474371993
Thanks @NihalJain!
I guess so, let me try to add the labels, but perhaps yeah that might be the
reason.
--
This is an automated message from the Apache Git Service.
To respond to
NihalJain commented on PR #5117:
URL: https://github.com/apache/hbase/pull/5117#issuecomment-1474351400
@virajjasani created backport jira here.
Out of context, but had a question. I am not able to add labels nor assign
reviewers. Are only committers allowed to do so?
--
This is
NihalJain opened a new pull request, #5117:
URL: https://github.com/apache/hbase/pull/5117
…er it has TTL expired it's TTL has expired
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/HBASE-27708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701970#comment-17701970
]
Hudson commented on HBASE-27708:
Results for branch branch-2.5
[build #319 on
[
https://issues.apache.org/jira/browse/HBASE-27710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Beaudreault updated HBASE-27710:
--
Labels: (was: patch-available)
> ByteBuff ref counting is too expensive for on-heap
[
https://issues.apache.org/jira/browse/HBASE-27710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Beaudreault updated HBASE-27710:
--
Fix Version/s: 2.6.0
3.0.0-alpha-4
2.4.17
[
https://issues.apache.org/jira/browse/HBASE-27686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701962#comment-17701962
]
Hudson commented on HBASE-27686:
Results for branch master
[build #798 on
bbeaudreault merged PR #5115:
URL: https://github.com/apache/hbase/pull/5115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache-HBase commented on PR #5051:
URL: https://github.com/apache/hbase/pull/5051#issuecomment-1474272114
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 23s |
Apache-HBase commented on PR #5051:
URL: https://github.com/apache/hbase/pull/5051#issuecomment-1474271064
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 23s |
Apache-HBase commented on PR #5051:
URL: https://github.com/apache/hbase/pull/5051#issuecomment-1474271038
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 59s |
NihalJain commented on PR #5109:
URL: https://github.com/apache/hbase/pull/5109#issuecomment-1474261946
> @NihalJain you also want to create branch-2 backport PR?
Sure let me raise one for branch-2.
--
This is an automated message from the Apache Git Service.
To respond to the
Apache-HBase commented on PR #4966:
URL: https://github.com/apache/hbase/pull/4966#issuecomment-1474204862
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 55s |
Apache-HBase commented on PR #5116:
URL: https://github.com/apache/hbase/pull/5116#issuecomment-1474185956
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 19s |
virajjasani commented on PR #5109:
URL: https://github.com/apache/hbase/pull/5109#issuecomment-1474172594
@NihalJain you also want to create branch-2 backport PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
wesiq opened a new pull request, #5116:
URL: https://github.com/apache/hbase/pull/5116
Upgrade commons-validator to 1.7 to address CVE-2014-0114 and CVE-2019-10086
brought in by commons-beanutils 1.9.2
--
This is an automated message from the Apache Git Service.
To respond to the
Wes Schuitema created HBASE-27731:
-
Summary: Upgrade commons-validator to version 1.7
Key: HBASE-27731
URL: https://issues.apache.org/jira/browse/HBASE-27731
Project: HBase
Issue Type: Task
ndimiduk commented on code in PR #5035:
URL: https://github.com/apache/hbase/pull/5035#discussion_r1140465808
##
bin/hbase-daemon.sh:
##
@@ -78,22 +78,33 @@ hbase_rotate_log ()
fi
}
-cleanAfterRun() {
- if [ -f ${HBASE_PID} ]; then
-# If the process is still
ndimiduk commented on PR #5035:
URL: https://github.com/apache/hbase/pull/5035#issuecomment-1474100486
Looks like this works as we expect. Running in a kubernetes pod, launching
the region server container with `bash -x hbase-daemon.sh foreground_start`, I
see
```
++
Apache-HBase commented on PR #5115:
URL: https://github.com/apache/hbase/pull/5115#issuecomment-1474074389
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 5m 43s |
Apache-HBase commented on PR #5115:
URL: https://github.com/apache/hbase/pull/5115#issuecomment-1474055223
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s |
Apache-HBase commented on PR #5114:
URL: https://github.com/apache/hbase/pull/5114#issuecomment-1474028056
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 4s |
Apache-HBase commented on PR #5114:
URL: https://github.com/apache/hbase/pull/5114#issuecomment-1474009402
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
Apache-HBase commented on PR #5035:
URL: https://github.com/apache/hbase/pull/5035#issuecomment-1474002293
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 49s |
[
https://issues.apache.org/jira/browse/HBASE-27537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang reassigned HBASE-27537:
-
Assignee: mahuacai
> Optimize the compaction triggering logic if table has set TTL
>
Apache-HBase commented on PR #5035:
URL: https://github.com/apache/hbase/pull/5035#issuecomment-1474001511
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
Apache-HBase commented on PR #5035:
URL: https://github.com/apache/hbase/pull/5035#issuecomment-1474000480
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 53s |
Apache-HBase commented on PR #4966:
URL: https://github.com/apache/hbase/pull/4966#issuecomment-1473933271
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 4s |
[
https://issues.apache.org/jira/browse/HBASE-27730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701791#comment-17701791
]
Duo Zhang commented on HBASE-27730:
---
Let's go with the null check solution first. Copying
[
https://issues.apache.org/jira/browse/HBASE-27730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701774#comment-17701774
]
Bryan Beaudreault edited comment on HBASE-27730 at 3/17/23 2:02 PM:
[
https://issues.apache.org/jira/browse/HBASE-27730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701773#comment-17701773
]
Bryan Beaudreault commented on HBASE-27730:
---
[~zhangduo] I tested it out copying
[
https://issues.apache.org/jira/browse/HBASE-27730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701774#comment-17701774
]
Bryan Beaudreault commented on HBASE-27730:
---
Good idea, that makes sense for sure.
> Optimize
[
https://issues.apache.org/jira/browse/HBASE-27730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701767#comment-17701767
]
Duo Zhang commented on HBASE-27730:
---
I prefer to implement deallocate like this
{code}
Recycler r =
[
https://issues.apache.org/jira/browse/HBASE-27730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701755#comment-17701755
]
Bryan Beaudreault commented on HBASE-27730:
---
I wasn't sure if we wanted to go down that path
Apache9 commented on PR #4966:
URL: https://github.com/apache/hbase/pull/4966#issuecomment-1473861054
I triggered a build again. Let's wait for the result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Apache9 commented on PR #5114:
URL: https://github.com/apache/hbase/pull/5114#issuecomment-1473860542
Please run `mvn spotless:apply` and commit the changes to fix the style
issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/HBASE-27730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701740#comment-17701740
]
Duo Zhang commented on HBASE-27730:
---
I think we could copy the code in AbstractReferenceCounted into
Bryan Beaudreault created HBASE-27730:
-
Summary: Optimize reference counting in off-heap ByteBuff
Key: HBASE-27730
URL: https://issues.apache.org/jira/browse/HBASE-27730
Project: HBase
Apache-HBase commented on PR #5115:
URL: https://github.com/apache/hbase/pull/5115#issuecomment-1473801544
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 5s |
2005hithlj commented on code in PR #4966:
URL: https://github.com/apache/hbase/pull/4966#discussion_r1100914426
##
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSyncUp.java:
##
@@ -69,41 +80,103 @@ public static void main(String[] args)
Apache-HBase commented on PR #5114:
URL: https://github.com/apache/hbase/pull/5114#issuecomment-1473740620
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 23s |
Apache-HBase commented on PR #5104:
URL: https://github.com/apache/hbase/pull/5104#issuecomment-1473734643
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
Apache-HBase commented on PR #5104:
URL: https://github.com/apache/hbase/pull/5104#issuecomment-1473733250
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
Apache-HBase commented on PR #5104:
URL: https://github.com/apache/hbase/pull/5104#issuecomment-1473733448
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
[
https://issues.apache.org/jira/browse/HBASE-27706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701678#comment-17701678
]
Frens Jan Rumph commented on HBASE-27706:
-
Thanks for the feedback [~apurtell]. I understand the
bbeaudreault merged PR #5104:
URL: https://github.com/apache/hbase/pull/5104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/HBASE-27717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaolin Ha reassigned HBASE-27717:
--
Assignee: Xiaolin Ha
> Add rsgroup name for dead region servers on master UI
>
[
https://issues.apache.org/jira/browse/HBASE-24762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701645#comment-17701645
]
Frens Jan Rumph commented on HBASE-24762:
-
Thanks [~zhangduo], I'm a bit new to the ecosystem
Apache-HBase commented on PR #5114:
URL: https://github.com/apache/hbase/pull/5114#issuecomment-1473618212
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 4s |
Apache-HBase commented on PR #5114:
URL: https://github.com/apache/hbase/pull/5114#issuecomment-1473617904
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
Apache-HBase commented on PR #5114:
URL: https://github.com/apache/hbase/pull/5114#issuecomment-1473616017
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 23s |
[
https://issues.apache.org/jira/browse/HBASE-27723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701633#comment-17701633
]
Frens Jan Rumph commented on HBASE-27723:
-
Correct! There were entries already for linux on ARM
slfan1989 commented on PR #5114:
URL: https://github.com/apache/hbase/pull/5114#issuecomment-1473579093
@slfan1989 Can you help review this pr? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
slfan1989 opened a new pull request, #5114:
URL: https://github.com/apache/hbase/pull/5114
JIRA: https://issues.apache.org/jira/browse/HBASE-27729.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/HBASE-27729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701620#comment-17701620
]
Shilun Fan commented on HBASE-27729:
[~zhangduo] Thank you very much! I will submit the pr as soon
[
https://issues.apache.org/jira/browse/HBASE-27729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-27729 started by Shilun Fan.
--
> Missed one parameter when logging exception in StoreFileListFile
>
[
https://issues.apache.org/jira/browse/HBASE-27729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701616#comment-17701616
]
Duo Zhang commented on HBASE-27729:
---
[~slfan1989] Done.
> Missed one parameter when logging exception
[
https://issues.apache.org/jira/browse/HBASE-27729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang reassigned HBASE-27729:
-
Assignee: Shilun Fan
> Missed one parameter when logging exception in StoreFileListFile
>
[ https://issues.apache.org/jira/browse/HBASE-27729 ]
Jeff Yang deleted comment on HBASE-27729:
---
was (Author: highfei2...@126.com):
I can try it. Thanks [~zhangduo]
> Missed one parameter when logging exception in StoreFileListFile
>
[
https://issues.apache.org/jira/browse/HBASE-27729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701614#comment-17701614
]
Jeff Yang commented on HBASE-27729:
---
I can try it. Thanks [~zhangduo]
> Missed one parameter when
[
https://issues.apache.org/jira/browse/HBASE-27729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701611#comment-17701611
]
Shilun Fan edited comment on HBASE-27729 at 3/17/23 9:50 AM:
-
[~zhangduo]
[
https://issues.apache.org/jira/browse/HBASE-27729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701611#comment-17701611
]
Shilun Fan commented on HBASE-27729:
[~zhangduo] Can you help to assign this pr to me?
> Missed one
[
https://issues.apache.org/jira/browse/HBASE-27729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-27729:
--
Labels: beginner trivial (was: )
> Missed one parameter when logging exception in StoreFileListFile
Duo Zhang created HBASE-27729:
-
Summary: Missed one parameter when logging exception in
StoreFileListFile
Key: HBASE-27729
URL: https://issues.apache.org/jira/browse/HBASE-27729
Project: HBase
[
https://issues.apache.org/jira/browse/HBASE-27725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701555#comment-17701555
]
Bryan Beaudreault commented on HBASE-27725:
---
See if HBASE-27681 solves this for you. In there
bbeaudreault commented on PR #5104:
URL: https://github.com/apache/hbase/pull/5104#issuecomment-1473288298
Agreed, thanks for discussing and review.
I had another idea that we could null out the recycler after calling it, so
isAccessible would be a null check on that existing
[
https://issues.apache.org/jira/browse/HBASE-27528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Beibei Zhao updated HBASE-27528:
Description:
MasterRpcServices record audit log in privileged operations (grant, revoke) and
Apache9 commented on PR #5104:
URL: https://github.com/apache/hbase/pull/5104#issuecomment-1473194958
Just commit it as is for now, can open another issue for improvement
performance for off heap ByteBuff.
--
This is an automated message from the Apache Git Service.
To respond to the
79 matches
Mail list logo
