[jira] [Resolved] (HBASE-27535) Separate slowlog thresholds for scans vs other requests
[ https://issues.apache.org/jira/browse/HBASE-27535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-27535. -- Fix Version/s: 2.6.0 3.0.0-alpha-4 Hadoop Flags: Reviewed Resolution: Fixed > Separate slowlog thresholds for scans vs other requests > --- > > Key: HBASE-27535 > URL: https://issues.apache.org/jira/browse/HBASE-27535 > Project: HBase > Issue Type: Improvement >Reporter: Bryan Beaudreault >Assignee: Ray Mattingly >Priority: Major > Labels: slowlog > Fix For: 2.6.0, 3.0.0-alpha-4 > > > Scans by their nature are able to more efficiently pull back larger response > sizes than gets. They also may take longer to execute than other request > types. We should make it possible to configure a separate threshold for > response time and response time for scans. This will allow us to tune down > the thresholds for others without adding unnecessary noise for requests which > are known to be slower/bigger. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (HBASE-27536) Include more request information in slowlog for Scans
[
https://issues.apache.org/jira/browse/HBASE-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani resolved HBASE-27536.
--
Fix Version/s: 2.6.0
3.0.0-alpha-4
Hadoop Flags: Reviewed
Resolution: Fixed
> Include more request information in slowlog for Scans
> -
>
> Key: HBASE-27536
> URL: https://issues.apache.org/jira/browse/HBASE-27536
> Project: HBase
> Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Ray Mattingly
>Priority: Major
> Labels: slowlog
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> Currently the slowlog only includes a barebones text format of the underlying
> protobuf Message fields. This is not a great UX for 2 reasons:
> # Most of the proto fields dont mirror the actual API names in our requests
> (Scan, Get, etc).
> # The chosen data is often not enough to actually infer anything about the
> request
> Any of the API class's toString method would be a much better representation
> of the request. On the server side, we already have to turn the protobuf
> Message into an actual API class in order to serve the request in
> RSRpcServices. Given slow logs should be a very small percent of total
> requests, I think we should do a similar parsing in SlowLogQueueService. Or
> better yet, perhaps we can pass the already parsed request into the queue at
> the start to avoid the extra work.
> When hydrating a SlowLogPayload with this request information, I believe we
> should use {{Operation's toMap(int maxCols)}} method. Adding this onto the
> SlowLogPayload as a map (or list of key/values) will make it easier to
> consume via downstream automation. Alternatively we could use
> {{{}toJSON(){}}}.
> We should also include any attributes from the queries, as those made aid
> tracing at the client level.
> Edit: because of nuance related to handling multis and the adequacy of info
> available for gets/puts, we're scoping this issue down to focus on improving
> the information available on Scan slowlogs
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (HBASE-27536) Include more request information in slowlog for Scans
[
https://issues.apache.org/jira/browse/HBASE-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani reassigned HBASE-27536:
Assignee: Ray Mattingly
> Include more request information in slowlog for Scans
> -
>
> Key: HBASE-27536
> URL: https://issues.apache.org/jira/browse/HBASE-27536
> Project: HBase
> Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Ray Mattingly
>Priority: Major
> Labels: slowlog
>
> Currently the slowlog only includes a barebones text format of the underlying
> protobuf Message fields. This is not a great UX for 2 reasons:
> # Most of the proto fields dont mirror the actual API names in our requests
> (Scan, Get, etc).
> # The chosen data is often not enough to actually infer anything about the
> request
> Any of the API class's toString method would be a much better representation
> of the request. On the server side, we already have to turn the protobuf
> Message into an actual API class in order to serve the request in
> RSRpcServices. Given slow logs should be a very small percent of total
> requests, I think we should do a similar parsing in SlowLogQueueService. Or
> better yet, perhaps we can pass the already parsed request into the queue at
> the start to avoid the extra work.
> When hydrating a SlowLogPayload with this request information, I believe we
> should use {{Operation's toMap(int maxCols)}} method. Adding this onto the
> SlowLogPayload as a map (or list of key/values) will make it easier to
> consume via downstream automation. Alternatively we could use
> {{{}toJSON(){}}}.
> We should also include any attributes from the queries, as those made aid
> tracing at the client level.
> Edit: because of nuance related to handling multis and the adequacy of info
> available for gets/puts, we're scoping this issue down to focus on improving
> the information available on Scan slowlogs
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27536) Include more request information in slowlog for Scans
[
https://issues.apache.org/jira/browse/HBASE-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715221#comment-17715221
]
Viraj Jasani commented on HBASE-27536:
--
Closing this Jira. Thanks [~rmdmattingly] for the contribution and
[~bbeaudreault] for the review!
> Include more request information in slowlog for Scans
> -
>
> Key: HBASE-27536
> URL: https://issues.apache.org/jira/browse/HBASE-27536
> Project: HBase
> Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Priority: Major
> Labels: slowlog
>
> Currently the slowlog only includes a barebones text format of the underlying
> protobuf Message fields. This is not a great UX for 2 reasons:
> # Most of the proto fields dont mirror the actual API names in our requests
> (Scan, Get, etc).
> # The chosen data is often not enough to actually infer anything about the
> request
> Any of the API class's toString method would be a much better representation
> of the request. On the server side, we already have to turn the protobuf
> Message into an actual API class in order to serve the request in
> RSRpcServices. Given slow logs should be a very small percent of total
> requests, I think we should do a similar parsing in SlowLogQueueService. Or
> better yet, perhaps we can pass the already parsed request into the queue at
> the start to avoid the extra work.
> When hydrating a SlowLogPayload with this request information, I believe we
> should use {{Operation's toMap(int maxCols)}} method. Adding this onto the
> SlowLogPayload as a map (or list of key/values) will make it easier to
> consume via downstream automation. Alternatively we could use
> {{{}toJSON(){}}}.
> We should also include any attributes from the queries, as those made aid
> tracing at the client level.
> Edit: because of nuance related to handling multis and the adequacy of info
> available for gets/puts, we're scoping this issue down to focus on improving
> the information available on Scan slowlogs
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] virajjasani commented on pull request #5188: HBASE-27535: Separate slowlog thresholds for scans vs other requests
virajjasani commented on PR #5188: URL: https://github.com/apache/hbase/pull/5188#issuecomment-1518503210 Thanks @rmdmattingly and @bbeaudreault !! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani merged pull request #5188: HBASE-27535: Separate slowlog thresholds for scans vs other requests
virajjasani merged PR #5188: URL: https://github.com/apache/hbase/pull/5188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5188: HBASE-27535: Separate slowlog thresholds for scans vs other requests
Apache-HBase commented on PR #5188: URL: https://github.com/apache/hbase/pull/5188#issuecomment-1518494579 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 55s | master passed | | +1 :green_heart: | compile | 1m 34s | master passed | | +1 :green_heart: | shadedjars | 4m 15s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 46s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 48s | the patch passed | | +1 :green_heart: | compile | 1m 34s | the patch passed | | +1 :green_heart: | javac | 1m 34s | the patch passed | | +1 :green_heart: | shadedjars | 4m 15s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 46s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 351m 26s | root in the patch passed. | | | | 380m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5188/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5188 | | JIRA Issue | HBASE-27535 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3c0c33e01ca9 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 269586c4cf | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5188/4/testReport/ | | Max. process+thread count | 4362 (vs. ulimit of 3) | | modules | C: hbase-server . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5188/4/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-27788) Skip family comparing when compare cells inner the store
[ https://issues.apache.org/jira/browse/HBASE-27788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712226#comment-17712226 ] Zheng Wang edited comment on HBASE-27788 at 4/22/23 3:34 AM: - Test Env: linux5.4, jdk8, jmh1.36, 8c16g Test Cmd: java -jar benchmarks.jar -i 5 -r 10 -wi 5 -w 10 -o result.out Test Mode: throughput, the more the better |Benchmark|(p1)|(p2)|Mode|Cnt|Score|Error|Units|Diff| |BenchmarkForInnerStore.new_compareBBKV| | |thrpt|5|28025769|± 85837.894|ops/s|1.00%| |BenchmarkForInnerStore.new_compareBBKV| |fam1|thrpt|5|45988795|± 743418.588|ops/s|14.00%| |BenchmarkForInnerStore.new_compareBBKV|fam1| |thrpt|5|46169746|± 313848.117|ops/s|15.00%| |BenchmarkForInnerStore.new_compareBBKV|fam1|fam1|thrpt|5|28340570|± 110743.597|ops/s|19.00%| |BenchmarkForInnerStore.new_compareKV| | |thrpt|5|28555080|± 137117.752|ops/s|1.00%| |BenchmarkForInnerStore.new_compareKV| |fam1|thrpt|5|48428310|± 457635.029|ops/s|12.00%| |BenchmarkForInnerStore.new_compareKV|fam1| |thrpt|5|48493949|± 251767.842|ops/s|12.00%| |BenchmarkForInnerStore.new_compareKV|fam1|fam1|thrpt|5|28550667|± 115741.387|ops/s|27.00%| |BenchmarkForInnerStore.new_compareKVVsBBKV| | |thrpt|5|29217290|± 101649.947|ops/s|6.00%| |BenchmarkForInnerStore.new_compareKVVsBBKV| |fam1|thrpt|5|46949029|± 215794.996|ops/s|7.00%| |BenchmarkForInnerStore.new_compareKVVsBBKV|fam1| |thrpt|5|46946670|± 146710.467|ops/s|7.00%| |BenchmarkForInnerStore.new_compareKVVsBBKV|fam1|fam1|thrpt|5|29148782|± 206963.662|ops/s|20.00%| |BenchmarkForInnerStore.old_compareBBKV| | |thrpt|5|27675873|± 276983.891|ops/s| | |BenchmarkForInnerStore.old_compareBBKV| |fam1|thrpt|5|40225985|± 333777.174|ops/s| | |BenchmarkForInnerStore.old_compareBBKV|fam1| |thrpt|5|40187512|± 242635.903|ops/s| | |BenchmarkForInnerStore.old_compareBBKV|fam1|fam1|thrpt|5|23719010|± 78500.923|ops/s| | |BenchmarkForInnerStore.old_compareKV| | |thrpt|5|28263508|± 80403.361|ops/s| | |BenchmarkForInnerStore.old_compareKV| |fam1|thrpt|5|43253529|± 227223.861|ops/s| | |BenchmarkForInnerStore.old_compareKV|fam1| |thrpt|5|43251637|± 370669.972|ops/s| | |BenchmarkForInnerStore.old_compareKV|fam1|fam1|thrpt|5|22556530|± 131922.278|ops/s| | |BenchmarkForInnerStore.old_compareKVVsBBKV| | |thrpt|5|27607601|± 181466.155|ops/s| | |BenchmarkForInnerStore.old_compareKVVsBBKV| |fam1|thrpt|5|43838946|± 147828.804|ops/s| | |BenchmarkForInnerStore.old_compareKVVsBBKV|fam1| |thrpt|5|43853799|± 159898.926|ops/s| | |BenchmarkForInnerStore.old_compareKVVsBBKV|fam1|fam1|thrpt|5|24349838|± 233577.807|ops/s| | |BenchmarkForNormal.new_compareBBKV|fam|fam|thrpt|5|24232184|± 119228.533|ops/s|-1.00%| |BenchmarkForNormal.new_compareBBKV|fam|fam1|thrpt|5|35397671|± 87148.764|ops/s|-3.00%| |BenchmarkForNormal.new_compareBBKV|fam1|fam|thrpt|5|34853758|± 181728.193|ops/s|-4.00%| |BenchmarkForNormal.new_compareBBKV|fam1|fam1|thrpt|5|23348288|± 210662.654|ops/s|-2.00%| |BenchmarkForNormal.new_compareKV|fam|fam|thrpt|5|23545532|± 300722.638|ops/s|0.00%| |BenchmarkForNormal.new_compareKV|fam|fam1|thrpt|5|36379792|± 103787.745|ops/s|0.00%| |BenchmarkForNormal.new_compareKV|fam1|fam|thrpt|5|36389642|± 215220.231|ops/s|0.00%| |BenchmarkForNormal.new_compareKV|fam1|fam1|thrpt|5|22781448|± 334278.380|ops/s|1.00%| |BenchmarkForNormal.new_compareKVVsBBKV|fam|fam|thrpt|5|24419066|± 178926.313|ops/s|-3.00%| |BenchmarkForNormal.new_compareKVVsBBKV|fam|fam1|thrpt|5|39477917|± 116925.262|ops/s|0.00%| |BenchmarkForNormal.new_compareKVVsBBKV|fam1|fam|thrpt|5|39381461|± 196771.635|ops/s|0.00%| |BenchmarkForNormal.new_compareKVVsBBKV|fam1|fam1|thrpt|5|23624400|± 402220.882|ops/s|-3.00%| |BenchmarkForNormal.old_compareBBKV|fam|fam|thrpt|5|24485218|± 95396.313|ops/s| | |BenchmarkForNormal.old_compareBBKV|fam|fam1|thrpt|5|36419133|± 159715.504|ops/s| | |BenchmarkForNormal.old_compareBBKV|fam1|fam|thrpt|5|36422202|± 86247.635|ops/s| | |BenchmarkForNormal.old_compareBBKV|fam1|fam1|thrpt|5|23734773|± 210072.328|ops/s| | |BenchmarkForNormal.old_compareKV|fam|fam|thrpt|5|23534333|± 57022.884|ops/s| | |BenchmarkForNormal.old_compareKV|fam|fam1|thrpt|5|36247387|± 95109.893|ops/s| | |BenchmarkForNormal.old_compareKV|fam1|fam|thrpt|5|36260304|± 63266.840|ops/s| | |BenchmarkForNormal.old_compareKV|fam1|fam1|thrpt|5|22582939|± 50450.874|ops/s| | |BenchmarkForNormal.old_compareKVVsBBKV|fam|fam|thrpt|5|25144704|± 291029.655|ops/s| | |BenchmarkForNormal.old_compareKVVsBBKV|fam|fam1|thrpt|5|39326233|± 218927.739|ops/s| | |BenchmarkForNormal.old_compareKVVsBBKV|fam1|fam|thrpt|5|39297932|± 487026.618|ops/s| | |BenchmarkForNormal.old_compareKVVsBBKV|fam1|fam1|thrpt|5|24395274|± 149132.118|ops/s| | was (Author: filtertip): Perf test report, copied from PR.(see PerfTestCellComparator.java, set compareCnt as 1 billion) |compareMethod|leftFamLen|rightFamLen|comparator|cost(ms)|diff| |compareKV|0|0|CellComparatorImpl|28850| |
[GitHub] [hbase] bsglz commented on pull request #5171: HBASE-27788 Skip family comparing when compare cells inner the store
bsglz commented on PR #5171:
URL: https://github.com/apache/hbase/pull/5171#issuecomment-1518476388
Test code:
```
/*
* Copyright (c) 2014, Oracle America, Inc.
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
met:
*
* * Redistributions of source code must retain the above copyright notice,
*this list of conditions and the following disclaimer.
*
* * Redistributions in binary form must reproduce the above copyright
*notice, this list of conditions and the following disclaimer in the
*documentation and/or other materials provided with the distribution.
*
* * Neither the name of Oracle nor the names of its contributors may be
used
*to endorse or promote products derived from this software without
*specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
IS"
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
* THE POSSIBILITY OF SUCH DAMAGE.
*/
package org.yihong;
import org.apache.hadoop.hbase.*;
import org.apache.hadoop.hbase.util.Bytes;
import org.apache.hadoop.hbase.util.Pair;
import org.openjdk.jmh.annotations.*;
import org.openjdk.jmh.runner.Runner;
import org.openjdk.jmh.runner.RunnerException;
import org.openjdk.jmh.runner.options.Options;
import org.openjdk.jmh.runner.options.OptionsBuilder;
import java.nio.ByteBuffer;
import java.util.concurrent.TimeUnit;
@Fork(1)
@State(Scope.Thread)
@BenchmarkMode(Mode.Throughput)
@OutputTimeUnit(TimeUnit.SECONDS)
public class BenchmarkForNormal {
@Param({"fam", "fam1"})
String p1;
@Param({"fam", "fam1"})
String p2;
byte[] row1 = Bytes.toBytes("row1");
byte[] qual1 = Bytes.toBytes("qual1");
byte[] val = Bytes.toBytes("val");
KeyValue kv1;
KeyValue kv2;
Cell bbCell1;
Cell bbCell2;
@Setup
public void initParams() {
byte[] fam0 = Bytes.toBytes(p1);
byte[] fam1 = Bytes.toBytes(p2);
Pair famPair = new Pair(fam0, fam1);
kv1 = new KeyValue(row1, famPair.getFirst(), qual1, val);
kv2 = new KeyValue(row1, famPair.getSecond(), qual1, val);
ByteBuffer buffer = ByteBuffer.wrap(kv1.getBuffer());
bbCell1 = new ByteBufferKeyValue(buffer, 0, buffer.remaining());
buffer = ByteBuffer.wrap(kv2.getBuffer());
bbCell2 = new ByteBufferKeyValue(buffer, 0, buffer.remaining());
}
@Benchmark
public void old_compareKV() {
CellComparatorOld.OLD_COMPARATOR.compare(kv1, kv2);
}
@Benchmark
public void new_compareKV() {
CellComparatorImpl.COMPARATOR.compare(kv1, kv2);
}
@Benchmark
public void old_compareBBKV() {
CellComparatorOld.OLD_COMPARATOR.compare(bbCell1, bbCell2);
}
@Benchmark
public void new_compareBBKV() {
CellComparatorImpl.COMPARATOR.compare(bbCell1, bbCell2);
}
@Benchmark
public void old_compareKVVsBBKV() {
CellComparatorOld.OLD_COMPARATOR.compare(kv1, bbCell2);
}
@Benchmark
public void new_compareKVVsBBKV() {
CellComparatorImpl.COMPARATOR.compare(kv1, bbCell2);
}
public static void main(String[] args) throws RunnerException {
Options opt = new OptionsBuilder()
.include(BenchmarkForNormal.class.getSimpleName())
.build();
new Runner(opt).run();
}
}
/*
* Copyright (c) 2014, Oracle America, Inc.
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
met:
*
* * Redistributions of source code must retain the above copyright notice,
*this list of conditions and the following disclaimer.
*
* * Redistributions in binary form must reproduce the above copyright
*notice, this list of conditions and the following disclaimer in the
*
[GitHub] [hbase] Apache-HBase commented on pull request #5188: HBASE-27535: Separate slowlog thresholds for scans vs other requests
Apache-HBase commented on PR #5188: URL: https://github.com/apache/hbase/pull/5188#issuecomment-1518471533 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 21s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 17s | master passed | | +1 :green_heart: | compile | 1m 47s | master passed | | +1 :green_heart: | shadedjars | 4m 37s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 7s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 18s | the patch passed | | +1 :green_heart: | compile | 1m 49s | the patch passed | | +1 :green_heart: | javac | 1m 49s | the patch passed | | +1 :green_heart: | shadedjars | 4m 38s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 4s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 260m 34s | root in the patch passed. | | | | 290m 48s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5188/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5188 | | JIRA Issue | HBASE-27535 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4baa890ecfee 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 269586c4cf | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5188/4/testReport/ | | Max. process+thread count | 4885 (vs. ulimit of 3) | | modules | C: hbase-server . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5188/4/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
bbeaudreault commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1518440268 i dont have time to handle merging right now, but will try to do it in the next couple days. thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5197: HBASE-27809 Attach move replication queue storage from zookeeper to a separated HBase table design doc to git repo
Apache-HBase commented on PR #5197: URL: https://github.com/apache/hbase/pull/5197#issuecomment-1518435960 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 57s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +1 :green_heart: | spotless | 0m 37s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | spotless | 0m 38s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 8s | The patch does not generate ASF License warnings. | | | | 3m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5197/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5197 | | Optional Tests | dupname asflicense spotless shellcheck shelldocs | | uname | Linux 21b09a6041e2 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 3193cffc9a | | Max. process+thread count | 44 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5197/2/console | | versions | git=2.34.1 maven=3.8.6 shellcheck=0.8.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5197: HBASE-27809 Attach move replication queue storage from zookeeper to a separated HBase table design doc to git repo
Apache-HBase commented on PR #5197: URL: https://github.com/apache/hbase/pull/5197#issuecomment-1518435406 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 2m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5197/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5197 | | Optional Tests | | | uname | Linux e464fe19a274 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 3193cffc9a | | Max. process+thread count | 29 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5197/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5197: HBASE-27809 Attach move replication queue storage from zookeeper to a separated HBase table design doc to git repo
Apache-HBase commented on PR #5197: URL: https://github.com/apache/hbase/pull/5197#issuecomment-1518435276 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 1m 58s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5197/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5197 | | Optional Tests | | | uname | Linux e3e3b1c06826 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 3193cffc9a | | Max. process+thread count | 39 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5197/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5188: HBASE-27535: Separate slowlog thresholds for scans vs other requests
Apache-HBase commented on PR #5188: URL: https://github.com/apache/hbase/pull/5188#issuecomment-1518387847 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 49s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 27s | master passed | | +1 :green_heart: | compile | 4m 45s | master passed | | +1 :green_heart: | checkstyle | 1m 4s | master passed | | +0 :ok: | refguide | 2m 13s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 8m 44s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 21s | the patch passed | | +1 :green_heart: | compile | 4m 46s | the patch passed | | +1 :green_heart: | javac | 4m 46s | the patch passed | | +1 :green_heart: | checkstyle | 1m 9s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +0 :ok: | refguide | 2m 19s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | hadoopcheck | 12m 20s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 9m 10s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 21s | The patch does not generate ASF License warnings. | | | | 64m 5s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5188/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5188 | | JIRA Issue | HBASE-27535 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile refguide | | uname | Linux d938a64daf9f 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 269586c4cf | | Default Java | Eclipse Adoptium-11.0.17+8 | | refguide | https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5188/4/yetus-general-check/output/branch-site/book.html | | refguide | https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5188/4/yetus-general-check/output/patch-site/book.html | | Max. process+thread count | 178 (vs. ulimit of 3) | | modules | C: hbase-server . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5188/4/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5188: HBASE-27535: Separate slowlog thresholds for scans vs other requests
Apache-HBase commented on PR #5188: URL: https://github.com/apache/hbase/pull/5188#issuecomment-1518342925 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 22s | master passed | | +1 :green_heart: | compile | 1m 32s | master passed | | +1 :green_heart: | shadedjars | 4m 14s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 45s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 48s | the patch passed | | +1 :green_heart: | compile | 1m 36s | the patch passed | | +1 :green_heart: | javac | 1m 36s | the patch passed | | +1 :green_heart: | shadedjars | 4m 15s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 45s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 297m 29s | root in the patch failed. | | | | 325m 48s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5188/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5188 | | JIRA Issue | HBASE-27535 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 71aa888cc99d 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 269586c4cf | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5188/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5188/3/testReport/ | | Max. process+thread count | 2603 (vs. ulimit of 3) | | modules | C: hbase-server . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5188/3/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5188: HBASE-27535: Separate slowlog thresholds for scans vs other requests
Apache-HBase commented on PR #5188: URL: https://github.com/apache/hbase/pull/5188#issuecomment-1518282093 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 33s | master passed | | +1 :green_heart: | compile | 1m 44s | master passed | | +1 :green_heart: | shadedjars | 4m 38s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 6s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 28s | the patch passed | | +1 :green_heart: | compile | 1m 44s | the patch passed | | +1 :green_heart: | javac | 1m 44s | the patch passed | | +1 :green_heart: | shadedjars | 4m 33s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 2s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 224m 5s | root in the patch failed. | | | | 253m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5188/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5188 | | JIRA Issue | HBASE-27535 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 85d84fc1fdea 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 269586c4cf | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5188/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5188/3/testReport/ | | Max. process+thread count | 2463 (vs. ulimit of 3) | | modules | C: hbase-server . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5188/3/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5195: HBASE-27806 Support dynamic reinitializing replication peer storage
Apache-HBase commented on PR #5195: URL: https://github.com/apache/hbase/pull/5195#issuecomment-151890 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 19s | master passed | | +1 :green_heart: | compile | 1m 4s | master passed | | +1 :green_heart: | shadedjars | 5m 10s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 44s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 4s | the patch passed | | +1 :green_heart: | compile | 1m 17s | the patch passed | | +1 :green_heart: | javac | 1m 17s | the patch passed | | +1 :green_heart: | shadedjars | 5m 6s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 44s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 22s | hbase-replication in the patch passed. | | +1 :green_heart: | unit | 213m 27s | hbase-server in the patch passed. | | | | 241m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5195/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5195 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b3254f618f51 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 269586c4cf | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5195/2/testReport/ | | Max. process+thread count | 2583 (vs. ulimit of 3) | | modules | C: hbase-replication hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5195/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5195: HBASE-27806 Support dynamic reinitializing replication peer storage
Apache-HBase commented on PR #5195: URL: https://github.com/apache/hbase/pull/5195#issuecomment-1518206734 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 18s | master passed | | +1 :green_heart: | compile | 0m 52s | master passed | | +1 :green_heart: | shadedjars | 4m 35s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 31s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 17s | the patch passed | | +1 :green_heart: | compile | 0m 52s | the patch passed | | +1 :green_heart: | javac | 0m 52s | the patch passed | | +1 :green_heart: | shadedjars | 4m 35s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 31s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 38s | hbase-replication in the patch passed. | | -1 :x: | unit | 202m 46s | hbase-server in the patch failed. | | | | 226m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5195/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5195 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 48c359a0d492 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 269586c4cf | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5195/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5195/2/testReport/ | | Max. process+thread count | 2442 (vs. ulimit of 3) | | modules | C: hbase-replication hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5195/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5188: HBASE-27535: Separate slowlog thresholds for scans vs other requests
Apache-HBase commented on PR #5188: URL: https://github.com/apache/hbase/pull/5188#issuecomment-1518102828 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 27s | master passed | | +1 :green_heart: | compile | 5m 41s | master passed | | +1 :green_heart: | checkstyle | 1m 14s | master passed | | +0 :ok: | refguide | 3m 21s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | spotless | 0m 46s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 9m 51s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 44s | the patch passed | | +1 :green_heart: | compile | 4m 53s | the patch passed | | +1 :green_heart: | javac | 4m 53s | the patch passed | | +1 :green_heart: | checkstyle | 1m 5s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +0 :ok: | refguide | 2m 19s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | hadoopcheck | 12m 23s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 42s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 8m 59s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 22s | The patch does not generate ASF License warnings. | | | | 69m 5s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5188/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5188 | | JIRA Issue | HBASE-27535 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile refguide | | uname | Linux 67438dee7dba 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 269586c4cf | | Default Java | Eclipse Adoptium-11.0.17+8 | | refguide | https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5188/3/yetus-general-check/output/branch-site/book.html | | refguide | https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5188/3/yetus-general-check/output/patch-site/book.html | | Max. process+thread count | 178 (vs. ulimit of 3) | | modules | C: hbase-server . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5188/3/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5188: HBASE-27535: Separate slowlog thresholds for scans vs other requests
bbeaudreault commented on code in PR #5188: URL: https://github.com/apache/hbase/pull/5188#discussion_r1173963970 ## src/main/asciidoc/_chapters/ops_mgt.adoc: ## @@ -1904,14 +1904,20 @@ It is also prepended with identifying tags `(responseTooSlow)`, `(responseTooLar Configuration -There are two configuration knobs that can be used to adjust the thresholds for when queries are logged. +There are four configuration knobs that can be used to adjust the thresholds for when queries are logged. Review Comment: Can you add 1-2 more sentences here explaining why Scan gets its own? For example "Two knobs allow controlling the size and time threshold for all queries. Since Scans can often be larger and slower than other queries, there is an additional two knobs for setting a different threshold for those." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5197: HBASE-27809 Attach move replication queue storage from zookeeper to a separated HBase table design doc to git repo
Apache-HBase commented on PR #5197: URL: https://github.com/apache/hbase/pull/5197#issuecomment-1518065806 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +1 :green_heart: | spotless | 0m 45s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | spotless | 0m 37s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 3m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5197/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5197 | | Optional Tests | dupname asflicense spotless shellcheck shelldocs | | uname | Linux f35cdf83f7a0 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 3193cffc9a | | Max. process+thread count | 44 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5197/1/console | | versions | git=2.34.1 maven=3.8.6 shellcheck=0.8.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5197: HBASE-27809 Attach move replication queue storage from zookeeper to a separated HBase table design doc to git repo
Apache-HBase commented on PR #5197: URL: https://github.com/apache/hbase/pull/5197#issuecomment-1518064004 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 2m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5197/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5197 | | Optional Tests | | | uname | Linux 8fb8e4db3a6c 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 3193cffc9a | | Max. process+thread count | 41 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5197/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5197: HBASE-27809 Attach move replication queue storage from zookeeper to a separated HBase table design doc to git repo
Apache-HBase commented on PR #5197: URL: https://github.com/apache/hbase/pull/5197#issuecomment-1518063803 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 2m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5197/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5197 | | Optional Tests | | | uname | Linux dc16cb916458 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 3193cffc9a | | Max. process+thread count | 34 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5197/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
Apache-HBase commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1518054219 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 22s | master passed | | +1 :green_heart: | compile | 0m 39s | master passed | | +1 :green_heart: | checkstyle | 0m 16s | master passed | | +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 0m 44s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 21s | the patch passed | | +1 :green_heart: | compile | 0m 39s | the patch passed | | +1 :green_heart: | javac | 0m 39s | the patch passed | | +1 :green_heart: | checkstyle | 0m 16s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 15m 59s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 1m 10s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 6s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 38m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5192 | | JIRA Issue | HBASE-27799 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 999af5f7ff08 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 269586c4cf | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 85 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/5/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] 2005hithlj opened a new pull request, #5197: HBASE-27809 Attach move replication queue storage from zookeeper to a separated HBase table design doc to git repo
2005hithlj opened a new pull request, #5197: URL: https://github.com/apache/hbase/pull/5197 https://issues.apache.org/jira/browse/HBASE-27809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
Apache-HBase commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1518030776 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 15s | master passed | | +1 :green_heart: | compile | 0m 16s | master passed | | +1 :green_heart: | shadedjars | 4m 34s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 13s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 17s | the patch passed | | +1 :green_heart: | compile | 0m 17s | the patch passed | | +1 :green_heart: | javac | 0m 17s | the patch passed | | +1 :green_heart: | shadedjars | 4m 38s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 23s | hbase-client in the patch passed. | | | | 19m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5192 | | JIRA Issue | HBASE-27799 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3dd7d4dfb05e 5.4.0-1099-aws #107~18.04.1-Ubuntu SMP Fri Mar 17 16:49:05 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 269586c4cf | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/5/testReport/ | | Max. process+thread count | 187 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/5/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
Apache-HBase commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1518030132 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 41s | master passed | | +1 :green_heart: | compile | 0m 18s | master passed | | +1 :green_heart: | shadedjars | 4m 16s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 14s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 49s | the patch passed | | +1 :green_heart: | compile | 0m 19s | the patch passed | | +1 :green_heart: | javac | 0m 19s | the patch passed | | +1 :green_heart: | shadedjars | 4m 25s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 18s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 42s | hbase-client in the patch passed. | | | | 19m 15s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5192 | | JIRA Issue | HBASE-27799 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 65c75cef31ed 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 269586c4cf | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/5/testReport/ | | Max. process+thread count | 167 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/5/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5195: HBASE-27806 Support dynamic reinitializing replication peer storage
Apache-HBase commented on PR #5195: URL: https://github.com/apache/hbase/pull/5195#issuecomment-1518023218 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 1s | master passed | | +1 :green_heart: | compile | 3m 10s | master passed | | +1 :green_heart: | checkstyle | 0m 46s | master passed | | +1 :green_heart: | spotless | 0m 44s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 14s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 43s | the patch passed | | +1 :green_heart: | compile | 3m 5s | the patch passed | | +1 :green_heart: | javac | 3m 5s | the patch passed | | +1 :green_heart: | checkstyle | 0m 45s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 19m 0s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 1m 4s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 3m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 21s | The patch does not generate ASF License warnings. | | | | 55m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5195/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5195 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 6a0b2a6744f9 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 269586c4cf | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 84 (vs. ulimit of 3) | | modules | C: hbase-replication hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5195/2/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-27809) Attach move replication queue storage from zookeeper to a separated HBase table design doc to git repo
Liangjun He created HBASE-27809: --- Summary: Attach move replication queue storage from zookeeper to a separated HBase table design doc to git repo Key: HBASE-27809 URL: https://issues.apache.org/jira/browse/HBASE-27809 Project: HBase Issue Type: Sub-task Components: documentation, Replication Reporter: Liangjun He Assignee: Liangjun He -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27808) Change flatten mode for oss in our pom file
Duo Zhang created HBASE-27808: - Summary: Change flatten mode for oss in our pom file Key: HBASE-27808 URL: https://issues.apache.org/jira/browse/HBASE-27808 Project: HBase Issue Type: Improvement Components: community, pom Reporter: Duo Zhang Per the discussion here: https://lists.apache.org/thread/b971svby2js6qgzcbso71dfh8t4mly6j We plan to change the flatten mode to oss instead of default, to retain more sections in our pom file. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] wchevreuil commented on a diff in pull request #5194: HBASE-27752: Update the block cache and list of prefetched files upon region movement
wchevreuil commented on code in PR #5194:
URL: https://github.com/apache/hbase/pull/5194#discussion_r1173851733
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/CloseRegionHandler.java:
##
@@ -101,6 +105,19 @@ public void process() throws IOException {
return;
}
+ rsServices.getBlockCache().ifPresent(blockCache -> {
+if (blockCache instanceof CombinedBlockCache) {
+ BlockCache l2 =
((CombinedBlockCache)blockCache).getSecondLevelCache();
+ if (l2 instanceof BucketCache) {
+if
(region.getReadOnlyConfiguration().get(PREFETCH_PERSISTENCE_PATH_KEY) != null) {
+ LOG.info("Closing region {} during a graceful stop, and prefetch
persistence is on, "
++ "so setting evict on close to false. ",
region.getRegionInfo().getEncodedName());
+ region.getStores().forEach(s ->
s.getCacheConfig().setEvictOnClose(false));
+}
+ }
+}
+ });
+
Review Comment:
I know I've done something similar in UnassignRegionHandler for HBASE-27474,
but I wonder now if we should move these logic about evict decision to a
related methods in HRegion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5195: HBASE-27806 Support dynamic reinitializing replication peer storage
Apache-HBase commented on PR #5195: URL: https://github.com/apache/hbase/pull/5195#issuecomment-1517953579 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 25s | master passed | | +1 :green_heart: | compile | 1m 4s | master passed | | +1 :green_heart: | shadedjars | 5m 8s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 42s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 1s | the patch passed | | +1 :green_heart: | compile | 1m 13s | the patch passed | | +1 :green_heart: | javac | 1m 13s | the patch passed | | +1 :green_heart: | shadedjars | 5m 12s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 24s | hbase-replication in the patch passed. | | -1 :x: | unit | 212m 45s | hbase-server in the patch failed. | | | | 240m 48s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5195/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5195 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3feeeb370e79 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f5ee958ead | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5195/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5195/1/testReport/ | | Max. process+thread count | 2359 (vs. ulimit of 3) | | modules | C: hbase-replication hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5195/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5195: HBASE-27806 Support dynamic reinitializing replication peer storage
Apache-HBase commented on PR #5195: URL: https://github.com/apache/hbase/pull/5195#issuecomment-1517929157 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 32s | master passed | | +1 :green_heart: | compile | 0m 53s | master passed | | +1 :green_heart: | shadedjars | 4m 37s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 32s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 16s | the patch passed | | +1 :green_heart: | compile | 0m 53s | the patch passed | | +1 :green_heart: | javac | 0m 53s | the patch passed | | +1 :green_heart: | shadedjars | 4m 36s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 31s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 28s | hbase-replication in the patch passed. | | +1 :green_heart: | unit | 200m 31s | hbase-server in the patch passed. | | | | 224m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5195/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5195 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f6f21434471f 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f5ee958ead | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5195/1/testReport/ | | Max. process+thread count | 2516 (vs. ulimit of 3) | | modules | C: hbase-replication hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5195/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
bbeaudreault commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1517902202 @rmdmattingly can you fix the javac warnings? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27785) Encapsulate and centralize totalBufferUsed in ReplicationSourceManager
[
https://issues.apache.org/jira/browse/HBASE-27785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated HBASE-27785:
-
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Encapsulate and centralize totalBufferUsed in ReplicationSourceManager
> --
>
> Key: HBASE-27785
> URL: https://issues.apache.org/jira/browse/HBASE-27785
> Project: HBase
> Issue Type: Improvement
> Components: Replication
>Affects Versions: 3.0.0-alpha-3
>Reporter: chenglei
>Assignee: chenglei
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> {{ReplicationSourceManager.totalBufferUsed}} is a counter, and is scoped to
> {{ReplicationSourceManager}}, but it is copied to {{ReplicationSource}} and
> {{ReplicationSourceWALReader}}, which makes the logic about
> {{ReplicationSourceManager.totalBufferUsed}} is scattered throughout
> {{ReplicationSourceManager}},{{ReplicationSource}},{{ReplicationSourceWALReader}}
> and {{ReplicationSourceShipper}}. It causes duplicated code and would make
> tracing the buffer usage somewhat difficult when there is problem about
> {{totalBufferUsed}}. I think we should encapsulate and centralize it in
> {{ReplicationSourceManager}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-27785) Encapsulate and centralize totalBufferUsed in ReplicationSourceManager
[
https://issues.apache.org/jira/browse/HBASE-27785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated HBASE-27785:
-
Fix Version/s: 2.6.0
3.0.0-alpha-4
> Encapsulate and centralize totalBufferUsed in ReplicationSourceManager
> --
>
> Key: HBASE-27785
> URL: https://issues.apache.org/jira/browse/HBASE-27785
> Project: HBase
> Issue Type: Improvement
> Components: Replication
>Affects Versions: 3.0.0-alpha-3
>Reporter: chenglei
>Assignee: chenglei
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> {{ReplicationSourceManager.totalBufferUsed}} is a counter, and is scoped to
> {{ReplicationSourceManager}}, but it is copied to {{ReplicationSource}} and
> {{ReplicationSourceWALReader}}, which makes the logic about
> {{ReplicationSourceManager.totalBufferUsed}} is scattered throughout
> {{ReplicationSourceManager}},{{ReplicationSource}},{{ReplicationSourceWALReader}}
> and {{ReplicationSourceShipper}}. It causes duplicated code and would make
> tracing the buffer usage somewhat difficult when there is problem about
> {{totalBufferUsed}}. I think we should encapsulate and centralize it in
> {{ReplicationSourceManager}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27785) Encapsulate and centralize totalBufferUsed in ReplicationSourceManager
[
https://issues.apache.org/jira/browse/HBASE-27785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715018#comment-17715018
]
chenglei commented on HBASE-27785:
--
Pushed to 2.6+, thanks [~zhangduo] for reviewing!
> Encapsulate and centralize totalBufferUsed in ReplicationSourceManager
> --
>
> Key: HBASE-27785
> URL: https://issues.apache.org/jira/browse/HBASE-27785
> Project: HBase
> Issue Type: Improvement
> Components: Replication
>Affects Versions: 3.0.0-alpha-3
>Reporter: chenglei
>Assignee: chenglei
>Priority: Major
>
> {{ReplicationSourceManager.totalBufferUsed}} is a counter, and is scoped to
> {{ReplicationSourceManager}}, but it is copied to {{ReplicationSource}} and
> {{ReplicationSourceWALReader}}, which makes the logic about
> {{ReplicationSourceManager.totalBufferUsed}} is scattered throughout
> {{ReplicationSourceManager}},{{ReplicationSource}},{{ReplicationSourceWALReader}}
> and {{ReplicationSourceShipper}}. It causes duplicated code and would make
> tracing the buffer usage somewhat difficult when there is problem about
> {{totalBufferUsed}}. I think we should encapsulate and centralize it in
> {{ReplicationSourceManager}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] comnetwork merged pull request #5196: HBASE-27785 Encapsulate and centralize totalBufferUsed in Replication…
comnetwork merged PR #5196: URL: https://github.com/apache/hbase/pull/5196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] comnetwork opened a new pull request, #5196: HBASE-27785 Encapsulate and centralize totalBufferUsed in Replication…
comnetwork opened a new pull request, #5196: URL: https://github.com/apache/hbase/pull/5196 …SourceManager -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a diff in pull request #5195: HBASE-27806 Support dynamic reinitializing replication peer storage
Apache9 commented on code in PR #5195: URL: https://github.com/apache/hbase/pull/5195#discussion_r1173783821 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java: ## @@ -67,15 +68,18 @@ /** * Manages and performs all replication admin operations. - * + * Review Comment: Ah, I googled about unclosed html tags, it seems that p tag is allowed to be unclosed, as well as the li tag. Let me change them back to p. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] 2005hithlj commented on a diff in pull request #5195: HBASE-27806 Support dynamic reinitializing replication peer storage
2005hithlj commented on code in PR #5195: URL: https://github.com/apache/hbase/pull/5195#discussion_r1173706346 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java: ## @@ -67,15 +68,18 @@ /** * Manages and performs all replication admin operations. - * + * Review Comment: `It should be "" ?` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] comnetwork merged pull request #5168: HBASE-27785 Encapsulate and centralize totalBufferUsed in Replication…
comnetwork merged PR #5168: URL: https://github.com/apache/hbase/pull/5168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] comnetwork commented on a diff in pull request #5168: HBASE-27785 Encapsulate and centralize totalBufferUsed in Replication…
comnetwork commented on code in PR #5168:
URL: https://github.com/apache/hbase/pull/5168#discussion_r1173738044
##
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceShipper.java:
##
@@ -366,20 +352,17 @@ void clearWALEntryBatch() {
return;
}
}
-LongAccumulator totalToDecrement = new LongAccumulator((a, b) -> a + b, 0);
-entryReader.entryBatchQueue.forEach(w -> {
- entryReader.entryBatchQueue.remove(w);
- w.getWalEntries().forEach(e -> {
-long entrySizeExcludeBulkLoad =
ReplicationSourceWALReader.getEntrySizeExcludeBulkLoad(e);
-totalToDecrement.accumulate(entrySizeExcludeBulkLoad);
- });
-});
+long totalToDecrement = 0;
Review Comment:
@Apache9 , thanks for suggestion, already fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5195: HBASE-27806 Support dynamic reinitializing replication peer storage
Apache-HBase commented on PR #5195: URL: https://github.com/apache/hbase/pull/5195#issuecomment-1517701821 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 14s | master passed | | +1 :green_heart: | compile | 3m 10s | master passed | | +1 :green_heart: | checkstyle | 0m 48s | master passed | | +1 :green_heart: | spotless | 0m 47s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 22s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 43s | the patch passed | | +1 :green_heart: | compile | 3m 6s | the patch passed | | +1 :green_heart: | javac | 3m 6s | the patch passed | | +1 :green_heart: | checkstyle | 0m 43s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 19m 1s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 1m 9s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 3m 23s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 21s | The patch does not generate ASF License warnings. | | | | 56m 5s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5195/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5195 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 7e5d20413df2 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f5ee958ead | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 85 (vs. ulimit of 3) | | modules | C: hbase-replication hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5195/1/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a diff in pull request #5189: HBASE-27746 Check if the file system supports storage policy before invoking setStoragePolicy()
Apache9 commented on code in PR #5189:
URL: https://github.com/apache/hbase/pull/5189#discussion_r1173627795
##
hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestFSUtils.java:
##
@@ -415,8 +417,9 @@ public void testSetStoragePolicyDefault() throws Exception {
* Note: currently the default policy is set to defer to HDFS and this case
is to verify the
* logic, will need to remove the check if the default policy is changed
*/
- private void verifyNoHDFSApiInvocationForDefaultPolicy() {
+ private void verifyNoHDFSApiInvocationForDefaultPolicy() throws
URISyntaxException, IOException {
FileSystem testFs = new AlwaysFailSetStoragePolicyFileSystem();
+testFs.initialize(new URI("hdfs://localhost/"), conf);
Review Comment:
Can we not use the 'hdfs' scheme here? It is not HDFS, actually...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-27807) PressureAwareCompactionThroughputController#tune log the opposite of the actual scenario
[ https://issues.apache.org/jira/browse/HBASE-27807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714867#comment-17714867 ] haosen chen commented on HBASE-27807: - Available patch is uploaded. > PressureAwareCompactionThroughputController#tune log the opposite of the > actual scenario > > > Key: HBASE-27807 > URL: https://issues.apache.org/jira/browse/HBASE-27807 > Project: HBase > Issue Type: Bug > Components: Compaction >Affects Versions: 3.0.0-alpha-1, 1.5.0, 2.3.0 >Reporter: haosen chen >Priority: Trivial > Attachments: > 0001-HBASE-27807-PressureAwareCompactionThroughputControl.patch, > image-2023-04-21-14-28-19-766.png > > > In > [https://github.com/apache/hbase/commit/07c71d630cd293ab55ac85e9bfa06033598134c4] > , the condition of the if statement is incorrectly modified. > !image-2023-04-21-14-28-19-766.png! > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27807) PressureAwareCompactionThroughputController#tune log the opposite of the actual scenario
[ https://issues.apache.org/jira/browse/HBASE-27807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] haosen chen updated HBASE-27807: Attachment: 0001-HBASE-27807-PressureAwareCompactionThroughputControl.patch > PressureAwareCompactionThroughputController#tune log the opposite of the > actual scenario > > > Key: HBASE-27807 > URL: https://issues.apache.org/jira/browse/HBASE-27807 > Project: HBase > Issue Type: Bug > Components: Compaction >Affects Versions: 3.0.0-alpha-1, 1.5.0, 2.3.0 >Reporter: haosen chen >Priority: Trivial > Attachments: > 0001-HBASE-27807-PressureAwareCompactionThroughputControl.patch, > image-2023-04-21-14-28-19-766.png > > > In > [https://github.com/apache/hbase/commit/07c71d630cd293ab55ac85e9bfa06033598134c4] > , the condition of the if statement is incorrectly modified. > !image-2023-04-21-14-28-19-766.png! > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27807) PressureAwareCompactionThroughputController#tune log the opposite of the actual scenario
[
https://issues.apache.org/jira/browse/HBASE-27807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
haosen chen updated HBASE-27807:
Attachment: image-2023-04-21-14-28-19-766.png
> PressureAwareCompactionThroughputController#tune log the opposite of the
> actual scenario
>
>
> Key: HBASE-27807
> URL: https://issues.apache.org/jira/browse/HBASE-27807
> Project: HBase
> Issue Type: Bug
> Components: Compaction
>Affects Versions: 3.0.0-alpha-1, 1.5.0, 2.3.0
>Reporter: haosen chen
>Priority: Trivial
> Attachments: image-2023-04-21-14-28-19-766.png
>
>
> In
> [https://github.com/apache/hbase/commit/07c71d630cd293ab55ac85e9bfa06033598134c4]
> , the condition of the if statement is incorrectly modified.
>
> {code:java}
> if (maxThroughputToSet != getMaxThroughput()) { if
> (Math.abs(maxThroughputToSet - getMaxThroughput()) < .001) {
> LOG.debug("CompactionPressure is " + compactionPressure + ", tune throughput
> to "+ throughputDesc(maxThroughputToSet)); } else if
> (LOG.isTraceEnabled()) {{code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-27807) PressureAwareCompactionThroughputController#tune log the opposite of the actual scenario
[
https://issues.apache.org/jira/browse/HBASE-27807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
haosen chen updated HBASE-27807:
Description:
In
[https://github.com/apache/hbase/commit/07c71d630cd293ab55ac85e9bfa06033598134c4]
, the condition of the if statement is incorrectly modified.
!image-2023-04-21-14-28-19-766.png!
was:
In
[https://github.com/apache/hbase/commit/07c71d630cd293ab55ac85e9bfa06033598134c4]
, the condition of the if statement is incorrectly modified.
{code:java}
if (maxThroughputToSet != getMaxThroughput()) { if
(Math.abs(maxThroughputToSet - getMaxThroughput()) < .001) {
LOG.debug("CompactionPressure is " + compactionPressure + ", tune throughput to
"+ throughputDesc(maxThroughputToSet)); } else if
(LOG.isTraceEnabled()) {{code}
> PressureAwareCompactionThroughputController#tune log the opposite of the
> actual scenario
>
>
> Key: HBASE-27807
> URL: https://issues.apache.org/jira/browse/HBASE-27807
> Project: HBase
> Issue Type: Bug
> Components: Compaction
>Affects Versions: 3.0.0-alpha-1, 1.5.0, 2.3.0
>Reporter: haosen chen
>Priority: Trivial
> Attachments: image-2023-04-21-14-28-19-766.png
>
>
> In
> [https://github.com/apache/hbase/commit/07c71d630cd293ab55ac85e9bfa06033598134c4]
> , the condition of the if statement is incorrectly modified.
> !image-2023-04-21-14-28-19-766.png!
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-27807) PressureAwareCompactionThroughputController#tune log the opposite of the actual scenario
[
https://issues.apache.org/jira/browse/HBASE-27807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
haosen chen updated HBASE-27807:
Description:
In
[https://github.com/apache/hbase/commit/07c71d630cd293ab55ac85e9bfa06033598134c4]
, the condition of the if statement is incorrectly modified.
{code:java}
if (maxThroughputToSet != getMaxThroughput()) { if
(Math.abs(maxThroughputToSet - getMaxThroughput()) < .001) {
LOG.debug("CompactionPressure is " + compactionPressure + ", tune throughput to
"+ throughputDesc(maxThroughputToSet)); } else if
(LOG.isTraceEnabled()) {{code}
was:
In
[https://github.com/apache/hbase/commit/07c71d630cd293ab55ac85e9bfa06033598134c4]
, the condition of the if statement is incorrectly modified.
{code:java}
if (LOG.isDebugEnabled()) {
if (Math.abs(maxThroughputToSet - getMaxThroughput()) < .001) {
LOG.debug("CompactionPressure is " + compactionPressure + ",
tune throughput to "+ throughputDesc(maxThroughputToSet));
} {code}
> PressureAwareCompactionThroughputController#tune log the opposite of the
> actual scenario
>
>
> Key: HBASE-27807
> URL: https://issues.apache.org/jira/browse/HBASE-27807
> Project: HBase
> Issue Type: Bug
> Components: Compaction
>Affects Versions: 3.0.0-alpha-1, 1.5.0, 2.3.0
>Reporter: haosen chen
>Priority: Trivial
>
> In
> [https://github.com/apache/hbase/commit/07c71d630cd293ab55ac85e9bfa06033598134c4]
> , the condition of the if statement is incorrectly modified.
>
> {code:java}
> if (maxThroughputToSet != getMaxThroughput()) { if
> (Math.abs(maxThroughputToSet - getMaxThroughput()) < .001) {
> LOG.debug("CompactionPressure is " + compactionPressure + ", tune throughput
> to "+ throughputDesc(maxThroughputToSet)); } else if
> (LOG.isTraceEnabled()) {{code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (HBASE-27807) PressureAwareCompactionThroughputController#tune log the opposite of the actual scenario
haosen chen created HBASE-27807:
---
Summary: PressureAwareCompactionThroughputController#tune log the
opposite of the actual scenario
Key: HBASE-27807
URL: https://issues.apache.org/jira/browse/HBASE-27807
Project: HBase
Issue Type: Bug
Components: Compaction
Affects Versions: 2.3.0, 1.5.0, 3.0.0-alpha-1
Reporter: haosen chen
In
[https://github.com/apache/hbase/commit/07c71d630cd293ab55ac85e9bfa06033598134c4]
, the condition of the if statement is incorrectly modified.
{code:java}
if (LOG.isDebugEnabled()) {
if (Math.abs(maxThroughputToSet - getMaxThroughput()) < .001) {
LOG.debug("CompactionPressure is " + compactionPressure + ",
tune throughput to "+ throughputDesc(maxThroughputToSet));
} {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
