Re: [PR] HBASE-28379 Upgrade thirdparty dep to 4.1.6 [hbase]
ndimiduk commented on PR #5693: URL: https://github.com/apache/hbase/pull/5693#issuecomment-1956075876 jdk8 we get, ``` [INFO] Results: [INFO] [ERROR] Errors: [ERROR] org.apache.hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush.null [ERROR] Run 1: TestHRegionWithInMemoryFlush>TestHRegion.testMutateRowInParallel:7456->Object.wait:-2 » TestTimedOut test timed out after 780 seconds [ERROR] Run 2: TestHRegionWithInMemoryFlush>TestHRegion.lambda$testMutateRowInParallel$3:7428 » Appears to be stuck in thread Thread-6326 [INFO] [INFO] [ERROR] Tests run: 6937, Failures: 0, Errors: 1, Skipped: 36 ``` jdk11 give us ``` [INFO] Results: [INFO] [ERROR] Errors: [ERROR] org.apache.hadoop.hbase.TestAcidGuaranteesWithBasicPolicy.null [ERROR] Run 1: TestAcidGuaranteesWithBasicPolicy>AcidGuaranteesTestBase.testMobGetAtomicity:122->AcidGuaranteesTestBase.runTestAtomicity:102->Object.wait:-2 » TestTimedOut test timed out after 780 seconds [ERROR] Run 2: TestAcidGuaranteesWithBasicPolicy » Appears to be stuck in thread MiniHBaseClusterRegionServer-EventLoopGroup-3-1 [INFO] [WARNING] Flakes: [WARNING] org.apache.hadoop.hbase.replication.TestReplicationEmptyWALRecovery.testReplicationOfEmptyWALSurroundedNonEmptyWAL [ERROR] Run 1: TestReplicationEmptyWALRecovery.testReplicationOfEmptyWALSurroundedNonEmptyWAL:313 Replicated entries are not correct expected:<40> but was:<20> [INFO] Run 2: PASS [INFO] [WARNING] org.apache.hadoop.hbase.replication.multiwal.TestReplicationEndpointWithMultipleAsyncWAL.testInterClusterReplication [ERROR] Run 1: TestReplicationEndpointWithMultipleAsyncWAL>TestReplicationEndpoint.testInterClusterReplication:244 Waiting timed out after [30,000] msec Failed to replicate all edits, expected = 2500 replicated = 2488 [INFO] Run 2: PASS [INFO] [INFO] [ERROR] Tests run: 6941, Failures: 0, Errors: 1, Skipped: 36, Flakes: 2 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28340) Add trust/key store type to ZK TLS settings handled by HBase
[
https://issues.apache.org/jira/browse/HBASE-28340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819070#comment-17819070
]
Hudson commented on HBASE-28340:
Results for branch branch-2.4
[build #697 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/697/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/697/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/697/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/697/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/697/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add trust/key store type to ZK TLS settings handled by HBase
>
>
> Key: HBASE-28340
> URL: https://issues.apache.org/jira/browse/HBASE-28340
> Project: HBase
> Issue Type: Sub-task
> Components: Zookeeper
>Affects Versions: 2.4.17, 3.0.0-beta-1, 2.5.7
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 4.0.0-alpha-1, 2.5.8, 3.0.0-beta-2
>
>
> Let's add the following settings as well. Last time we missed it.
> {noformat}
> zookeeper.ssl.keyStore.type
> zookeeper.ssl.trustStore.type{noformat}
> Handle them in hbase-site.xml as:
> {noformat}
> hbase.zookeeper.property.ssl.keyStore.type
> hbase.zookeeper.property.ssl.trustStore.type{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-28379 Upgrade thirdparty dep to 4.1.6 [hbase]
NihalJain commented on code in PR #5693: URL: https://github.com/apache/hbase/pull/5693#discussion_r1496884707 ## pom.xml: ## @@ -909,7 +909,7 @@ 1.1.10.4 1.9 1.5.5-2 -4.1.5 + 4.1.6-28374-d2c399f-SNAPSHOT Review Comment: Yes we do same for Jackson. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]
chrajeshbabu commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1955861779 > And better start a discussion thread on dev list about this change? Sure will start discussion thread. Will add when section to run this phase with master at this moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28376) Column family ns does not exist in region during upgrade to 3.0.0-beta-2
[ https://issues.apache.org/jira/browse/HBASE-28376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819046#comment-17819046 ] Duo Zhang commented on HBASE-28376: --- I think this is partly because of HBASE-23055, where we change the hard coded meta table descriptor so we can alter meta table to change some configs. Before HBASE-23055. the meta table will have the ns family automatically after upgrading, but now, we need an alter table operation to add a family. Let me think how to do this. Thanks. > Column family ns does not exist in region during upgrade to 3.0.0-beta-2 > > > Key: HBASE-28376 > URL: https://issues.apache.org/jira/browse/HBASE-28376 > Project: HBase > Issue Type: Bug > Components: meta >Affects Versions: 3.0.0-beta-1 >Reporter: Bryan Beaudreault >Assignee: Duo Zhang >Priority: Blocker > > Upgrading from 2.5.x to 3.0.0-alpha-2, migrateNamespaceTable kicks in to copy > data from the namespace table to an "ns" family of the meta table. If you > don't have an "ns" family, the migration fails and the hmaster will crash > loop. You then can't rollback, because the briefly alive upgraded hmaster > created a procedure that can't be deserialized by 2.x (I don't have this log > handy unfortunately). I tried pushing code to create the ns family on > startup, but it doesnt work becuase the migration happens while the hmaster > is still initializing. > So it seems imperative that you create the ns family before upgrading. We > should handle this more gracefully. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-28386) Potential Data loss issue for the HFLog
Dong0829 created HBASE-28386: Summary: Potential Data loss issue for the HFLog Key: HBASE-28386 URL: https://issues.apache.org/jira/browse/HBASE-28386 Project: HBase Issue Type: Bug Components: wal Reporter: Dong0829 Attachments: Screenshot 2024-02-19 at 10.53.20.png I am going through the WAL implementation HFLog, and based on the code reading, as my understanding there maybe potential data loss for example in below scenarios: # Append record A3 already into the stream, and but the syncFuture S3 does not reach to the SyncRunner yet # The SyncRunner run the sync and call sync on writer, but failed, all the data in stream lost including A3 # Because the syncFuture S3 does not reach to the syncRunner, it can not release it and mark it failed # In next run() of the SyncRunner, the new sync() succeeded, it will release and mark S3 as succeeded, but actually it should failed which cause data loss. Can anyone help to check above above is true? Am I missing anything regarding this process? !Screenshot 2024-02-19 at 10.53.20.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28342 Decommissioned hosts should be rejected by the HMaster [hbase]
Apache-HBase commented on PR #5681: URL: https://github.com/apache/hbase/pull/5681#issuecomment-1955165925 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 15s | master passed | | +1 :green_heart: | compile | 1m 7s | master passed | | +1 :green_heart: | shadedjars | 5m 57s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | master passed | | -0 :warning: | patch | 6m 52s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 2s | the patch passed | | +1 :green_heart: | compile | 1m 7s | the patch passed | | +1 :green_heart: | javac | 1m 7s | the patch passed | | +1 :green_heart: | shadedjars | 6m 1s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 24s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 245m 8s | hbase-server in the patch passed. | | | | 276m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5681/10/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5681 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c4f38a6a5f66 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 7be588e0d4 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5681/10/testReport/ | | Max. process+thread count | 4587 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5681/10/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28342 Decommissioned hosts should be rejected by the HMaster [hbase]
Apache-HBase commented on PR #5681: URL: https://github.com/apache/hbase/pull/5681#issuecomment-195514 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 26s | master passed | | +1 :green_heart: | compile | 1m 1s | master passed | | +1 :green_heart: | shadedjars | 5m 5s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | master passed | | -0 :warning: | patch | 6m 4s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 25s | the patch passed | | +1 :green_heart: | compile | 0m 59s | the patch passed | | +1 :green_heart: | javac | 0m 59s | the patch passed | | +1 :green_heart: | shadedjars | 5m 5s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 21s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 238m 5s | hbase-server in the patch passed. | | | | 265m 33s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5681/10/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5681 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4b6dd8486f18 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 7be588e0d4 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5681/10/testReport/ | | Max. process+thread count | 5145 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5681/10/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28370) Default user quotas are refreshing too frequently
[
https://issues.apache.org/jira/browse/HBASE-28370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818985#comment-17818985
]
Hudson commented on HBASE-28370:
Results for branch branch-3
[build #151 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/151/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/151/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/151/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/151/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Default user quotas are refreshing too frequently
> -
>
> Key: HBASE-28370
> URL: https://issues.apache.org/jira/browse/HBASE-28370
> Project: HBase
> Issue Type: Improvement
>Reporter: Ray Mattingly
>Assignee: Ray Mattingly
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 3.0.0-beta-2
>
>
> In [https://github.com/apache/hbase/pull/5666] we introduced default user
> quotas, but I accidentally called UserQuotaState's default constructor rather
> than passing in the current timestamp. The consequence is that we're
> constantly refreshing these default user quotas, and this can be a bottleneck
> for horizontal cluster scalability.
> This should be a 1 line fix in QuotaUtil's buildDefaultUserQuotaState method.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28377) Fallback to simple is broken for blocking rpc client
[
https://issues.apache.org/jira/browse/HBASE-28377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818984#comment-17818984
]
Hudson commented on HBASE-28377:
Results for branch branch-3
[build #151 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/151/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/151/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/151/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/151/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fallback to simple is broken for blocking rpc client
>
>
> Key: HBASE-28377
> URL: https://issues.apache.org/jira/browse/HBASE-28377
> Project: HBase
> Issue Type: Bug
> Components: IPC/RPC
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 2.5.8, 3.0.0-beta-2
>
>
> Found this when implementing HBASE-28321, we do not have a test for fallback
> to simple with blocking rpc client...
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (HBASE-28385) Quota estimates are too optimistic for large scans
Ray Mattingly created HBASE-28385: - Summary: Quota estimates are too optimistic for large scans Key: HBASE-28385 URL: https://issues.apache.org/jira/browse/HBASE-28385 Project: HBase Issue Type: Improvement Reporter: Ray Mattingly Fix For: 2.6.0 Let's say you're running a table scan with a throttle of 100MB/sec per RegionServer. Ideally your scans are going to pull down large results, often containing hundreds or thousands of blocks. You will estimate each scan as costing a single block of read capacity, and if your quota is already exhausted then the server will evaluate the backoff required for your estimated consumption (1 block) to be available. This will often be ~1ms, causing your retries to basically be immediate. Obviously it will routinely take much longer than 1ms for 100MB of IO to become available in the given configuration, so your retries will be destined to fail. At worst this can cause a saturation of your server's RPC layer, and at best this causes erroneous exhaustion of the client's retries. We should find a way to make these estimates a bit smarter for large scans. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HBASE-28385) Quota estimates are too optimistic for large scans
[ https://issues.apache.org/jira/browse/HBASE-28385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Mattingly reassigned HBASE-28385: - Assignee: Ray Mattingly > Quota estimates are too optimistic for large scans > -- > > Key: HBASE-28385 > URL: https://issues.apache.org/jira/browse/HBASE-28385 > Project: HBase > Issue Type: Improvement >Reporter: Ray Mattingly >Assignee: Ray Mattingly >Priority: Major > Fix For: 2.6.0 > > > Let's say you're running a table scan with a throttle of 100MB/sec per > RegionServer. Ideally your scans are going to pull down large results, often > containing hundreds or thousands of blocks. > You will estimate each scan as costing a single block of read capacity, and > if your quota is already exhausted then the server will evaluate the backoff > required for your estimated consumption (1 block) to be available. This will > often be ~1ms, causing your retries to basically be immediate. > Obviously it will routinely take much longer than 1ms for 100MB of IO to > become available in the given configuration, so your retries will be destined > to fail. At worst this can cause a saturation of your server's RPC layer, and > at best this causes erroneous exhaustion of the client's retries. > We should find a way to make these estimates a bit smarter for large scans. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-28370) Default user quotas are refreshing too frequently
[
https://issues.apache.org/jira/browse/HBASE-28370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818955#comment-17818955
]
Hudson commented on HBASE-28370:
Results for branch master
[build #1017 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1017/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1017/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1017/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1017/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Default user quotas are refreshing too frequently
> -
>
> Key: HBASE-28370
> URL: https://issues.apache.org/jira/browse/HBASE-28370
> Project: HBase
> Issue Type: Improvement
>Reporter: Ray Mattingly
>Assignee: Ray Mattingly
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 3.0.0-beta-2
>
>
> In [https://github.com/apache/hbase/pull/5666] we introduced default user
> quotas, but I accidentally called UserQuotaState's default constructor rather
> than passing in the current timestamp. The consequence is that we're
> constantly refreshing these default user quotas, and this can be a bottleneck
> for horizontal cluster scalability.
> This should be a 1 line fix in QuotaUtil's buildDefaultUserQuotaState method.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28377) Fallback to simple is broken for blocking rpc client
[
https://issues.apache.org/jira/browse/HBASE-28377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818954#comment-17818954
]
Hudson commented on HBASE-28377:
Results for branch master
[build #1017 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1017/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1017/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1017/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1017/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fallback to simple is broken for blocking rpc client
>
>
> Key: HBASE-28377
> URL: https://issues.apache.org/jira/browse/HBASE-28377
> Project: HBase
> Issue Type: Bug
> Components: IPC/RPC
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 2.5.8, 3.0.0-beta-2
>
>
> Found this when implementing HBASE-28321, we do not have a test for fallback
> to simple with blocking rpc client...
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (HBASE-28242) Move ProfileServlet to support async-profiler 2.x only
[ https://issues.apache.org/jira/browse/HBASE-28242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang reassigned HBASE-28242: --- Assignee: Lars Francke > Move ProfileServlet to support async-profiler 2.x only > -- > > Key: HBASE-28242 > URL: https://issues.apache.org/jira/browse/HBASE-28242 > Project: HBase > Issue Type: Improvement >Reporter: Lars Francke >Assignee: Lars Francke >Priority: Minor > Labels: pull-request-available > > async-profiler 2.0 has been out since March 2021 now. > This issue/PR is about supporting its new features and removing the 1.x > functionality. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28242: Adapts ProfileServlet for async-profiler 2.x [hbase]
lfrancke commented on PR #5566: URL: https://github.com/apache/hbase/pull/5566#issuecomment-1954881153 Yeah, I did start a [thread](https://lists.apache.org/thread/smz4ttn5fdrqnow94jrhz6sbt2crs8kj) on the mailing list and need to get around to update this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-28242) Move ProfileServlet to support async-profiler 2.x only
[ https://issues.apache.org/jira/browse/HBASE-28242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28242: --- Labels: pull-request-available (was: ) > Move ProfileServlet to support async-profiler 2.x only > -- > > Key: HBASE-28242 > URL: https://issues.apache.org/jira/browse/HBASE-28242 > Project: HBase > Issue Type: Improvement >Reporter: Lars Francke >Priority: Minor > Labels: pull-request-available > > async-profiler 2.0 has been out since March 2021 now. > This issue/PR is about supporting its new features and removing the 1.x > functionality. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28242: Adapts ProfileServlet for async-profiler 2.x [hbase]
jojochuang commented on PR #5566: URL: https://github.com/apache/hbase/pull/5566#issuecomment-195483 Yeah makes sense, even 3.0 is released. the last 1.x release was 2+ years ago. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28321 RpcConnectionRegistry is broken when security is enabled … [hbase]
Apache-HBase commented on PR #5688: URL: https://github.com/apache/hbase/pull/5688#issuecomment-1954820003 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 26s | master passed | | +1 :green_heart: | compile | 1m 48s | master passed | | +1 :green_heart: | shadedjars | 5m 9s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 7s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 31s | the patch passed | | +1 :green_heart: | compile | 1m 49s | the patch passed | | +1 :green_heart: | javac | 1m 49s | the patch passed | | +1 :green_heart: | shadedjars | 5m 6s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 7s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 31s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 20s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 230m 36s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 2m 17s | hbase-examples in the patch passed. | | | | 261m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5688 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 77f7670f9b4b 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 7be588e0d4 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/5/testReport/ | | Max. process+thread count | 5949 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-examples U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/5/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28321 RpcConnectionRegistry is broken when security is enabled … [hbase]
Apache-HBase commented on PR #5688: URL: https://github.com/apache/hbase/pull/5688#issuecomment-1954807907 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 13s | master passed | | +1 :green_heart: | compile | 2m 4s | master passed | | +1 :green_heart: | shadedjars | 5m 52s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 3s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 53s | the patch passed | | +1 :green_heart: | compile | 1m 58s | the patch passed | | +1 :green_heart: | javac | 1m 58s | the patch passed | | +1 :green_heart: | shadedjars | 5m 48s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 2s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 35s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 35s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 220m 28s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 2m 10s | hbase-examples in the patch passed. | | | | 254m 17s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5688 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 9a6a5d34907e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 7be588e0d4 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/5/testReport/ | | Max. process+thread count | 5789 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-examples U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/5/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28342 Decommissioned hosts should be rejected by the HMaster [hbase]
Apache-HBase commented on PR #5681: URL: https://github.com/apache/hbase/pull/5681#issuecomment-1954715527 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 8s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 53s | master passed | | +1 :green_heart: | compile | 3m 6s | master passed | | +1 :green_heart: | checkstyle | 0m 53s | master passed | | +1 :green_heart: | spotless | 0m 44s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 9s | master passed | | -0 :warning: | patch | 1m 46s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 47s | the patch passed | | +1 :green_heart: | compile | 2m 58s | the patch passed | | +1 :green_heart: | javac | 2m 58s | the patch passed | | -0 :warning: | checkstyle | 0m 36s | hbase-server: The patch generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 4m 52s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 0m 43s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 19s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 21s | The patch does not generate ASF License warnings. | | | | 32m 5s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5681/10/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5681 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux ae4b122394e9 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 7be588e0d4 | | Default Java | Eclipse Adoptium-11.0.17+8 | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5681/10/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 82 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5681/10/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28379 Upgrade thirdparty dep to 4.1.6 [hbase]
Apache-HBase commented on PR #5693: URL: https://github.com/apache/hbase/pull/5693#issuecomment-1954623272 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 57s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 41s | master passed | | +1 :green_heart: | compile | 2m 20s | master passed | | +1 :green_heart: | shadedjars | 6m 3s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 32s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 18s | the patch passed | | +1 :green_heart: | compile | 2m 14s | the patch passed | | +1 :green_heart: | javac | 2m 14s | the patch passed | | +1 :green_heart: | shadedjars | 6m 24s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 13s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 453m 29s | root in the patch failed. | | | | 490m 4s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5693 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a5c6389a40de 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 7be588e0d4 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/2/testReport/ | | Max. process+thread count | 5381 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-examples . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28379 Upgrade thirdparty dep to 4.1.6 [hbase]
Apache-HBase commented on PR #5693: URL: https://github.com/apache/hbase/pull/5693#issuecomment-1954447611 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 57s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 11s | master passed | | +1 :green_heart: | compile | 2m 44s | master passed | | +1 :green_heart: | shadedjars | 6m 16s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 14s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 48s | the patch passed | | +1 :green_heart: | compile | 2m 32s | the patch passed | | +1 :green_heart: | javac | 2m 32s | the patch passed | | +1 :green_heart: | shadedjars | 6m 35s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 38s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 364m 3s | root in the patch failed. | | | | 404m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5693 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 32e5e6a74665 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 7be588e0d4 | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/2/testReport/ | | Max. process+thread count | 5524 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-examples . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28321 RpcConnectionRegistry is broken when security is enabled … [hbase]
Apache-HBase commented on PR #5688: URL: https://github.com/apache/hbase/pull/5688#issuecomment-1954376988 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 59s | master passed | | +1 :green_heart: | compile | 4m 18s | master passed | | +1 :green_heart: | checkstyle | 1m 13s | master passed | | +1 :green_heart: | spotless | 0m 44s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 5m 7s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 42s | the patch passed | | +1 :green_heart: | compile | 4m 10s | the patch passed | | +1 :green_heart: | cc | 4m 10s | the patch passed | | +1 :green_heart: | javac | 4m 10s | the patch passed | | +1 :green_heart: | checkstyle | 1m 11s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 4m 53s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | hbaseprotoc | 1m 47s | the patch passed | | +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 5m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 41s | The patch does not generate ASF License warnings. | | | | 44m 2s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5688 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool | | uname | Linux a526f8e0aaca 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 7be588e0d4 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 83 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-examples U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/5/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work started] (HBASE-28376) Column family ns does not exist in region during upgrade to 3.0.0-beta-2
[ https://issues.apache.org/jira/browse/HBASE-28376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-28376 started by Duo Zhang. - > Column family ns does not exist in region during upgrade to 3.0.0-beta-2 > > > Key: HBASE-28376 > URL: https://issues.apache.org/jira/browse/HBASE-28376 > Project: HBase > Issue Type: Bug > Components: meta >Affects Versions: 3.0.0-beta-1 >Reporter: Bryan Beaudreault >Assignee: Duo Zhang >Priority: Blocker > > Upgrading from 2.5.x to 3.0.0-alpha-2, migrateNamespaceTable kicks in to copy > data from the namespace table to an "ns" family of the meta table. If you > don't have an "ns" family, the migration fails and the hmaster will crash > loop. You then can't rollback, because the briefly alive upgraded hmaster > created a procedure that can't be deserialized by 2.x (I don't have this log > handy unfortunately). I tried pushing code to create the ns family on > startup, but it doesnt work becuase the migration happens while the hmaster > is still initializing. > So it seems imperative that you create the ns family before upgrading. We > should handle this more gracefully. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HBASE-28376) Column family ns does not exist in region during upgrade to 3.0.0-beta-2
[ https://issues.apache.org/jira/browse/HBASE-28376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-28376: - Assignee: Duo Zhang > Column family ns does not exist in region during upgrade to 3.0.0-beta-2 > > > Key: HBASE-28376 > URL: https://issues.apache.org/jira/browse/HBASE-28376 > Project: HBase > Issue Type: Bug > Components: meta >Affects Versions: 3.0.0-beta-1 >Reporter: Bryan Beaudreault >Assignee: Duo Zhang >Priority: Blocker > > Upgrading from 2.5.x to 3.0.0-alpha-2, migrateNamespaceTable kicks in to copy > data from the namespace table to an "ns" family of the meta table. If you > don't have an "ns" family, the migration fails and the hmaster will crash > loop. You then can't rollback, because the briefly alive upgraded hmaster > created a procedure that can't be deserialized by 2.x (I don't have this log > handy unfortunately). I tried pushing code to create the ns family on > startup, but it doesnt work becuase the migration happens while the hmaster > is still initializing. > So it seems imperative that you create the ns family before upgrading. We > should handle this more gracefully. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-28376) Column family ns does not exist in region during upgrade to 3.0.0-beta-2
[ https://issues.apache.org/jira/browse/HBASE-28376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-28376: -- Component/s: meta > Column family ns does not exist in region during upgrade to 3.0.0-beta-2 > > > Key: HBASE-28376 > URL: https://issues.apache.org/jira/browse/HBASE-28376 > Project: HBase > Issue Type: Bug > Components: meta >Affects Versions: 3.0.0-beta-1 >Reporter: Bryan Beaudreault >Priority: Blocker > > Upgrading from 2.5.x to 3.0.0-alpha-2, migrateNamespaceTable kicks in to copy > data from the namespace table to an "ns" family of the meta table. If you > don't have an "ns" family, the migration fails and the hmaster will crash > loop. You then can't rollback, because the briefly alive upgraded hmaster > created a procedure that can't be deserialized by 2.x (I don't have this log > handy unfortunately). I tried pushing code to create the ns family on > startup, but it doesnt work becuase the migration happens while the hmaster > is still initializing. > So it seems imperative that you create the ns family before upgrading. We > should handle this more gracefully. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-28384) Client ingegration tests fails for branch-2/branch-2.6
[ https://issues.apache.org/jira/browse/HBASE-28384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818817#comment-17818817 ] Duo Zhang commented on HBASE-28384: --- I think we can change the hbase_nightly_source-artifact.sh script, to also generate hadoop3 related tarballs when building against branch-2.x, and use it when running with hadoop-3. > Client ingegration tests fails for branch-2/branch-2.6 > -- > > Key: HBASE-28384 > URL: https://issues.apache.org/jira/browse/HBASE-28384 > Project: HBase > Issue Type: Bug > Components: hadoop3, jenkins >Reporter: Duo Zhang >Priority: Major > > In HBASE-28331, we fixed the problem that we should use the latest hadoop3 > tarballs, for generating hdfs-site.xml. > But for branch-2.x, we still use hadoop2 when compiling hbase by default, so > there is no org.apache.hadoop.ipc.ProtobufRpcEngine2 class. But the hadoop > 3.3.x will generate hdfs-site.xml with this config, then leads to the failure > of hbase start up. > Should we change to build with hadoop3 while running on top of hadoop3? Since > for branch-2.x, we will publish artifacts for hadoop3. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]
Apache9 commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1954285804 And better start a discussion thread on dev list about this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]
Apache9 commented on code in PR #5689:
URL: https://github.com/apache/hbase/pull/5689#discussion_r1495878226
##
dev-support/Jenkinsfile:
##
@@ -628,6 +630,118 @@ pipeline {
}
}
}
+
+stage ('yetus jdk17 hadoop3 checks') {
Review Comment:
I just mean whether we should add a 'when' section to only run this step for
some branches.
At least I tried to run UTs with JDK17 on branch-2.5, there are failures...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (HBASE-28384) Client ingegration tests fails for branch-2/branch-2.6
Duo Zhang created HBASE-28384: - Summary: Client ingegration tests fails for branch-2/branch-2.6 Key: HBASE-28384 URL: https://issues.apache.org/jira/browse/HBASE-28384 Project: HBase Issue Type: Bug Components: hadoop3, jenkins Reporter: Duo Zhang In HBASE-28331, we fixed the problem that we should use the latest hadoop3 tarballs, for generating hdfs-site.xml. But for branch-2.x, we still use hadoop2 when compiling hbase by default, so there is no org.apache.hadoop.ipc.ProtobufRpcEngine2 class. But the hadoop 3.3.x will generate hdfs-site.xml with this config, then leads to the failure of hbase start up. Should we change to build with hadoop3 while running on top of hadoop3? Since for branch-2.x, we will publish artifacts for hadoop3. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28340 Add trust/key store type to ZK TLS settings handled by HBase (branch-2.4) [hbase]
meszibalu merged PR #5684: URL: https://github.com/apache/hbase/pull/5684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28342 Decommissioned hosts should be rejected by the HMaster [hbase]
aalhour commented on code in PR #5681:
URL: https://github.com/apache/hbase/pull/5681#discussion_r1495688692
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HostIsConsideredDecommissionedException.java:
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master;
+
+import org.apache.hadoop.hbase.HBaseIOException;
+import org.apache.yetus.audience.InterfaceAudience;
+
+@InterfaceAudience.Private
+public class HostIsConsideredDecommissionedException extends HBaseIOException {
Review Comment:
I like it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28342 Decommissioned hosts should be rejected by the HMaster [hbase]
aalhour commented on code in PR #5681:
URL: https://github.com/apache/hbase/pull/5681#discussion_r1495687463
##
hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java:
##
@@ -1622,6 +1622,20 @@ public enum OperationStatusCode {
*/
public final static boolean HBASE_SERVER_USEIP_ENABLED_DEFAULT = false;
+ /**
+ * Should the HMaster reject hosts of decommissioned RegionServers,
bypassing matching their port
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28342 Decommissioned hosts should be rejected by the HMaster [hbase]
aalhour commented on code in PR #5681:
URL: https://github.com/apache/hbase/pull/5681#discussion_r1495683944
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java:
##
@@ -293,6 +330,36 @@ public void regionServerReport(ServerName sn,
ServerMetrics sl) throws YouAreDea
updateLastFlushedSequenceIds(sn, sl);
}
+ /**
+ * Checks if the Master is configured to reject decommissioned hosts or not.
When it's configured
+ * to do so, any RegionServer trying to join the cluster will have it's host
checked against the
+ * list of hosts of currently decommissioned servers and potentially get
prevented from reporting
+ * for duty; otherwise, we do nothing and we let them pass to the next
check. See HBASE-28342 for
+ * details.
+ * @param sn The ServerName to check for
+ * @throws HostIsConsideredDecommissionedException if the Master is
configured to reject
+ * decommissioned hosts and
this host exists in
+ * the list of the
decommissioned servers
+ */
+ private void checkRejectableDecommissionedStatus(ServerName sn)
+throws HostIsConsideredDecommissionedException {
+// If the Master is not configured to reject decommissioned hosts, return
early.
+if (!rejectDecommissionedHostsConfig) {
+ return;
+}
+
+// Look for a match for the hostname in the list of decommissioned servers
+for (ServerName server : getDrainingServersList()) {
+ if (Objects.equals(server.getHostname(), sn.getHostname())) {
+// Found a match and master is configured to reject decommissioned
hosts, throw exception!
+LOG.warn("Rejecting RegionServer {} from reporting for duty because
Master is configured "
+ + "to reject decommissioned hosts and this host was marked as such
in the past.", sn);
+throw new HostIsConsideredDecommissionedException(
+ "Master is configured to reject decommissioned hosts");
Review Comment:
I'll re-write that exception message and include the hostname. However, I'm
not sure about including it as a field in the Exception class since it get's
handled as an IOException in the `HRegionServer.reportForDuty()` instance
method. The exception gets printed as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-28377) Fallback to simple is broken for blocking rpc client
[
https://issues.apache.org/jira/browse/HBASE-28377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818770#comment-17818770
]
Hudson commented on HBASE-28377:
Results for branch branch-2
[build #992 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/992/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/992/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/992/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/992/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/992/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/992//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> Fallback to simple is broken for blocking rpc client
>
>
> Key: HBASE-28377
> URL: https://issues.apache.org/jira/browse/HBASE-28377
> Project: HBase
> Issue Type: Bug
> Components: IPC/RPC
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 2.5.8, 3.0.0-beta-2
>
>
> Found this when implementing HBASE-28321, we do not have a test for fallback
> to simple with blocking rpc client...
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28142) Region Server Logs getting spammed with warning when storefile has no reader
[
https://issues.apache.org/jira/browse/HBASE-28142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818769#comment-17818769
]
Hudson commented on HBASE-28142:
Results for branch branch-2
[build #992 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/992/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/992/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/992/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/992/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/992/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/992//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> Region Server Logs getting spammed with warning when storefile has no reader
>
>
> Key: HBASE-28142
> URL: https://issues.apache.org/jira/browse/HBASE-28142
> Project: HBase
> Issue Type: Improvement
>Reporter: Nikita Pande
>Assignee: Anchal Kejriwal
>Priority: Minor
> Labels: pull-request-available
> Fix For: 2.6.0, 2.7.0, 3.0.0-beta-2
>
>
> Hbase tables which have IS_MOB set as TRUE and table metrics is enabled,
> there are warning logs getting generated "StoreFile has a null
> Reader on hbase region server.
> After setting IS_MOB as false for a table, this logs are not visible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-28342 Decommissioned hosts should be rejected by the HMaster [hbase]
aalhour commented on code in PR #5681:
URL: https://github.com/apache/hbase/pull/5681#discussion_r1495672812
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java:
##
@@ -293,6 +330,36 @@ public void regionServerReport(ServerName sn,
ServerMetrics sl) throws YouAreDea
updateLastFlushedSequenceIds(sn, sl);
}
+ /**
+ * Checks if the Master is configured to reject decommissioned hosts or not.
When it's configured
+ * to do so, any RegionServer trying to join the cluster will have it's host
checked against the
+ * list of hosts of currently decommissioned servers and potentially get
prevented from reporting
+ * for duty; otherwise, we do nothing and we let them pass to the next
check. See HBASE-28342 for
+ * details.
+ * @param sn The ServerName to check for
+ * @throws HostIsConsideredDecommissionedException if the Master is
configured to reject
+ * decommissioned hosts and
this host exists in
+ * the list of the
decommissioned servers
+ */
+ private void checkRejectableDecommissionedStatus(ServerName sn)
+throws HostIsConsideredDecommissionedException {
+// If the Master is not configured to reject decommissioned hosts, return
early.
+if (!rejectDecommissionedHostsConfig) {
+ return;
+}
+
+// Look for a match for the hostname in the list of decommissioned servers
+for (ServerName server : getDrainingServersList()) {
+ if (Objects.equals(server.getHostname(), sn.getHostname())) {
+// Found a match and master is configured to reject decommissioned
hosts, throw exception!
+LOG.warn("Rejecting RegionServer {} from reporting for duty because
Master is configured "
+ + "to reject decommissioned hosts and this host was marked as such
in the past.", sn);
Review Comment:
Actually, I think I will go with your proposal, it's better to be explicit
than implicit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28342 Decommissioned hosts should be rejected by the HMaster [hbase]
aalhour commented on code in PR #5681:
URL: https://github.com/apache/hbase/pull/5681#discussion_r1495672476
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java:
##
@@ -293,6 +330,36 @@ public void regionServerReport(ServerName sn,
ServerMetrics sl) throws YouAreDea
updateLastFlushedSequenceIds(sn, sl);
}
+ /**
+ * Checks if the Master is configured to reject decommissioned hosts or not.
When it's configured
+ * to do so, any RegionServer trying to join the cluster will have it's host
checked against the
+ * list of hosts of currently decommissioned servers and potentially get
prevented from reporting
+ * for duty; otherwise, we do nothing and we let them pass to the next
check. See HBASE-28342 for
+ * details.
+ * @param sn The ServerName to check for
+ * @throws HostIsConsideredDecommissionedException if the Master is
configured to reject
+ * decommissioned hosts and
this host exists in
+ * the list of the
decommissioned servers
+ */
+ private void checkRejectableDecommissionedStatus(ServerName sn)
+throws HostIsConsideredDecommissionedException {
+// If the Master is not configured to reject decommissioned hosts, return
early.
+if (!rejectDecommissionedHostsConfig) {
+ return;
+}
+
+// Look for a match for the hostname in the list of decommissioned servers
+for (ServerName server : getDrainingServersList()) {
+ if (Objects.equals(server.getHostname(), sn.getHostname())) {
+// Found a match and master is configured to reject decommissioned
hosts, throw exception!
+LOG.warn("Rejecting RegionServer {} from reporting for duty because
Master is configured "
+ + "to reject decommissioned hosts and this host was marked as such
in the past.", sn);
Review Comment:
Wouldn't passing the `sn` object be sufficient? Its `toString()` method
calls `getServerName()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28342 Decommissioned hosts should be rejected by the HMaster [hbase]
aalhour commented on code in PR #5681:
URL: https://github.com/apache/hbase/pull/5681#discussion_r1495664151
##
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerReportForDuty.java:
##
@@ -241,6 +243,136 @@ public void run() {
waitForClusterOnline(master);
}
+ /**
+ * Tests that the RegionServer's reportForDuty gets rejected by the master
when the master is
+ * configured to reject decommissioned hosts and when there is a match for
the joining
+ * RegionServer in the list of decommissioned servers. Test case for
HBASE-28342.
+ */
+ @Test
+ public void
testReportForDutyGetsRejectedByMasterWhenConfiguredToRejectDecommissionedHosts()
+throws Exception {
+// Start a master and wait for it to become the active/primary master.
+// Use a random unique port
+cluster.getConfiguration().setInt(HConstants.MASTER_PORT,
HBaseTestingUtil.randomFreePort());
+
cluster.getConfiguration().setInt(ServerManager.WAIT_ON_REGIONSERVERS_MINTOSTART,
1);
+
cluster.getConfiguration().setInt(ServerManager.WAIT_ON_REGIONSERVERS_MAXTOSTART,
1);
+
+// Set the cluster to reject decommissioned hosts
+
cluster.getConfiguration().setBoolean(HConstants.REJECT_DECOMMISSIONED_HOSTS_KEY,
true);
+
+master = cluster.addMaster();
+rs = cluster.addRegionServer();
+LOG.debug("Starting master: " + master.getMaster().getServerName());
+master.start();
+rs.start();
+waitForClusterOnline(master);
+
+assertEquals(0,
master.getMaster().listDecommissionedRegionServers().size());
+assertEquals(0,
master.getMaster().getServerManager().getDrainingServersList().size());
+assertEquals(1,
master.getMaster().getServerManager().getOnlineServers().size());
+
+// Decommission the region server and tries to re-add it
+List serversToDecommission = new ArrayList();
+serversToDecommission.add(rs.getRegionServer().getServerName());
+master.getMaster().decommissionRegionServers(serversToDecommission, true);
Review Comment:
Nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28342 Decommissioned hosts should be rejected by the HMaster [hbase]
aalhour commented on code in PR #5681:
URL: https://github.com/apache/hbase/pull/5681#discussion_r1495661072
##
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerReportForDuty.java:
##
@@ -241,6 +243,136 @@ public void run() {
waitForClusterOnline(master);
}
+ /**
+ * Tests that the RegionServer's reportForDuty gets rejected by the master
when the master is
+ * configured to reject decommissioned hosts and when there is a match for
the joining
+ * RegionServer in the list of decommissioned servers. Test case for
HBASE-28342.
+ */
+ @Test
+ public void
testReportForDutyGetsRejectedByMasterWhenConfiguredToRejectDecommissionedHosts()
+throws Exception {
+// Start a master and wait for it to become the active/primary master.
+// Use a random unique port
+cluster.getConfiguration().setInt(HConstants.MASTER_PORT,
HBaseTestingUtil.randomFreePort());
Review Comment:
I tried to stick to the same approach of starting master servers in this
test suite, you can see it in `testReportForDutyWithMasterChange` and
`testReportForDutyWithEnvironmentEdge`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28342 Decommissioned hosts should be rejected by the HMaster [hbase]
ndimiduk commented on code in PR #5681:
URL: https://github.com/apache/hbase/pull/5681#discussion_r1495549953
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java:
##
@@ -293,6 +330,36 @@ public void regionServerReport(ServerName sn,
ServerMetrics sl) throws YouAreDea
updateLastFlushedSequenceIds(sn, sl);
}
+ /**
+ * Checks if the Master is configured to reject decommissioned hosts or not.
When it's configured
+ * to do so, any RegionServer trying to join the cluster will have it's host
checked against the
+ * list of hosts of currently decommissioned servers and potentially get
prevented from reporting
+ * for duty; otherwise, we do nothing and we let them pass to the next
check. See HBASE-28342 for
+ * details.
+ * @param sn The ServerName to check for
+ * @throws HostIsConsideredDecommissionedException if the Master is
configured to reject
+ * decommissioned hosts and
this host exists in
+ * the list of the
decommissioned servers
+ */
+ private void checkRejectableDecommissionedStatus(ServerName sn)
+throws HostIsConsideredDecommissionedException {
+// If the Master is not configured to reject decommissioned hosts, return
early.
+if (!rejectDecommissionedHostsConfig) {
+ return;
+}
+
+// Look for a match for the hostname in the list of decommissioned servers
+for (ServerName server : getDrainingServersList()) {
+ if (Objects.equals(server.getHostname(), sn.getHostname())) {
+// Found a match and master is configured to reject decommissioned
hosts, throw exception!
+LOG.warn("Rejecting RegionServer {} from reporting for duty because
Master is configured "
+ + "to reject decommissioned hosts and this host was marked as such
in the past.", sn);
Review Comment:
Might as well print out the full `ServerName` of the applicable
decommissioned host entry in the log message. That way an operator can paste it
directly into a shell command to remove it, if they so choose.
##
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerReportForDuty.java:
##
@@ -241,6 +243,136 @@ public void run() {
waitForClusterOnline(master);
}
+ /**
+ * Tests that the RegionServer's reportForDuty gets rejected by the master
when the master is
+ * configured to reject decommissioned hosts and when there is a match for
the joining
+ * RegionServer in the list of decommissioned servers. Test case for
HBASE-28342.
+ */
+ @Test
+ public void
testReportForDutyGetsRejectedByMasterWhenConfiguredToRejectDecommissionedHosts()
+throws Exception {
+// Start a master and wait for it to become the active/primary master.
+// Use a random unique port
+cluster.getConfiguration().setInt(HConstants.MASTER_PORT,
HBaseTestingUtil.randomFreePort());
+
cluster.getConfiguration().setInt(ServerManager.WAIT_ON_REGIONSERVERS_MINTOSTART,
1);
+
cluster.getConfiguration().setInt(ServerManager.WAIT_ON_REGIONSERVERS_MAXTOSTART,
1);
+
+// Set the cluster to reject decommissioned hosts
+
cluster.getConfiguration().setBoolean(HConstants.REJECT_DECOMMISSIONED_HOSTS_KEY,
true);
+
+master = cluster.addMaster();
+rs = cluster.addRegionServer();
+LOG.debug("Starting master: " + master.getMaster().getServerName());
+master.start();
+rs.start();
+waitForClusterOnline(master);
+
+assertEquals(0,
master.getMaster().listDecommissionedRegionServers().size());
+assertEquals(0,
master.getMaster().getServerManager().getDrainingServersList().size());
+assertEquals(1,
master.getMaster().getServerManager().getOnlineServers().size());
+
+// Decommission the region server and tries to re-add it
+List serversToDecommission = new ArrayList();
+serversToDecommission.add(rs.getRegionServer().getServerName());
Review Comment:
You're adding the single region server to the decommissioned servers list,
and you have `draining=true`. An HBase cluster cannot operate without any
region servers. I would be very surprised if this test is stable.
Better to add the second server to the decommission list.
Also, all these processes (master, both region servers) are going to have
the same hostname -- `localhost`, I would imagine. I think that this test will
not behave the way that you want it to.
##
hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java:
##
@@ -1622,6 +1622,20 @@ public enum OperationStatusCode {
*/
public final static boolean HBASE_SERVER_USEIP_ENABLED_DEFAULT = false;
+ /**
+ * Should the HMaster reject hosts of decommissioned RegionServers,
bypassing matching their port
Review Comment:
nit: s/bypassing/bypass/
##
[jira] [Commented] (HBASE-28367) Backport "HBASE-27811 Enable cache control for logs endpoint and set max age as 0" to branch-2
[
https://issues.apache.org/jira/browse/HBASE-28367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818722#comment-17818722
]
Hudson commented on HBASE-28367:
Results for branch branch-2.6
[build #59 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/59/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/59/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/59/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/59/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/59/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/59//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> Backport "HBASE-27811 Enable cache control for logs endpoint and set max age
> as 0" to branch-2
> ---
>
> Key: HBASE-28367
> URL: https://issues.apache.org/jira/browse/HBASE-28367
> Project: HBase
> Issue Type: Improvement
>Reporter: Yash Dodeja
>Assignee: Nihal Jain
>Priority: Minor
> Labels: pull-request-available
> Fix For: 2.6.0, 2.7.0
>
>
> Not setting the proper header values may cause browsers to store pages within
> their respective caches. On public, shared, or any other non-private
> computers, a malicious person may search through the browser cache to locate
> sensitive information cached during another user's session.
> /logs endpoint contains sensitive information that an attacker can exploit.
> Any page with sensitive information needs to have the following headers in
> response:
> Cache-Control: no-cache, no-store, max-age=0
> Pragma: no-cache
> Expires: -1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28142) Region Server Logs getting spammed with warning when storefile has no reader
[
https://issues.apache.org/jira/browse/HBASE-28142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818724#comment-17818724
]
Hudson commented on HBASE-28142:
Results for branch branch-2.6
[build #59 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/59/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/59/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/59/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/59/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/59/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/59//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> Region Server Logs getting spammed with warning when storefile has no reader
>
>
> Key: HBASE-28142
> URL: https://issues.apache.org/jira/browse/HBASE-28142
> Project: HBase
> Issue Type: Improvement
>Reporter: Nikita Pande
>Assignee: Anchal Kejriwal
>Priority: Minor
> Labels: pull-request-available
> Fix For: 2.6.0, 2.7.0, 3.0.0-beta-2
>
>
> Hbase tables which have IS_MOB set as TRUE and table metrics is enabled,
> there are warning logs getting generated "StoreFile has a null
> Reader on hbase region server.
> After setting IS_MOB as false for a table, this logs are not visible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27811) Enable cache control for logs endpoint and set max age as 0
[
https://issues.apache.org/jira/browse/HBASE-27811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818723#comment-17818723
]
Hudson commented on HBASE-27811:
Results for branch branch-2.6
[build #59 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/59/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/59/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/59/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/59/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/59/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/59//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> Enable cache control for logs endpoint and set max age as 0
> ---
>
> Key: HBASE-27811
> URL: https://issues.apache.org/jira/browse/HBASE-27811
> Project: HBase
> Issue Type: Improvement
>Reporter: Yash Dodeja
>Assignee: Yash Dodeja
>Priority: Minor
> Fix For: 3.0.0-alpha-4
>
>
> Not setting the proper header values may cause browsers to store pages within
> their respective caches. On public, shared, or any other non-private
> computers, a malicious person may search through the browser cache to locate
> sensitive information cached during another user's session.
> /logs endpoint contains sensitive information that an attacker can exploit.
> Any page with sensitive information needs to have the following headers in
> response:
> Cache-Control: no-cache, no-store, max-age=0
> Pragma: no-cache
> Expires: -1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-28379 Upgrade thirdparty dep to 4.1.6 [hbase]
Apache-HBase commented on PR #5693: URL: https://github.com/apache/hbase/pull/5693#issuecomment-1953761206 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 44s | master passed | | +1 :green_heart: | compile | 4m 59s | master passed | | +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 47s | the patch passed | | +1 :green_heart: | compile | 4m 52s | the patch passed | | +1 :green_heart: | javac | 4m 52s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 4m 47s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 0m 43s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 29s | The patch does not generate ASF License warnings. | | | | 29m 25s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5693 | | Optional Tests | dupname asflicense javac hadoopcheck spotless xml compile | | uname | Linux 2ad7d59f2e89 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 7be588e0d4 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 78 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-examples . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28374 [hbase-thirdparty] bump remaining deps for 4.1.6 release [hbase-thirdparty]
ndimiduk commented on PR #112: URL: https://github.com/apache/hbase-thirdparty/pull/112#issuecomment-1953710727 I published a SNAPSHOT build of this change to Apache's maven repo. The PR against hbase is pointed at that version. For your reference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28379 Upgrade thirdparty dep to 4.1.6 [hbase]
ndimiduk commented on code in PR #5693: URL: https://github.com/apache/hbase/pull/5693#discussion_r1495410026 ## pom.xml: ## @@ -909,7 +909,7 @@ 1.1.10.4 1.9 1.5.5-2 -4.1.5 + 4.1.6-28374-d2c399f-SNAPSHOT Review Comment: Ah, so it seems from [HBASE-27578](https://issues.apache.org/jira/browse/HBASE-27578). Are there any other related dependencies? cc @Apache9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-28383) [JDK17] Update hbase-env.sh with alternates to JVM flags which are no longer supported
[
https://issues.apache.org/jira/browse/HBASE-28383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nihal Jain updated HBASE-28383:
---
Summary: [JDK17] Update hbase-env.sh with alternates to JVM flags which are
no longer supported (was: Update hbase-env.sh with alternates to JVM flags
which are no longer supported with JDK17)
> [JDK17] Update hbase-env.sh with alternates to JVM flags which are no longer
> supported
> --
>
> Key: HBASE-28383
> URL: https://issues.apache.org/jira/browse/HBASE-28383
> Project: HBase
> Issue Type: Sub-task
> Components: java, scripts
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
>
> Some JVM flags like {{{}-XX:+PrintGCDetails{}}}, {{-XX:+PrintGCDateStamps}}
> etc. are no longer supported with JDK 17 and hbase would fail to start if
> these are passed.
> We should do an audit and update
> [https://github.com/apache/hbase/blob/master/conf/hbase-env.sh] to capture
> alternate/fix.
> Will refer following for a fix/repalacement:
> *
> [https://stackoverflow.com/questions/54144713/is-there-a-replacement-for-the-garbage-collection-jvm-args-in-java-11]
> *
> [https://docs.oracle.com/javase/9/tools/java.htm#GUID-BE93ABDC-999C-4CB5-A88B-1994AAAC74D5__CONVERTGCLOGGINGFLAGSTOXLOG-A5046BD1]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-28383) Update hbase-env.sh with alternates to JVM flags which are no longer supported with JDK17
[
https://issues.apache.org/jira/browse/HBASE-28383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nihal Jain updated HBASE-28383:
---
Parent: HBASE-26038
Issue Type: Sub-task (was: Improvement)
> Update hbase-env.sh with alternates to JVM flags which are no longer
> supported with JDK17
> -
>
> Key: HBASE-28383
> URL: https://issues.apache.org/jira/browse/HBASE-28383
> Project: HBase
> Issue Type: Sub-task
> Components: java, scripts
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
>
> Some JVM flags like {{{}-XX:+PrintGCDetails{}}}, {{-XX:+PrintGCDateStamps}}
> etc. are no longer supported with JDK 17 and hbase would fail to start if
> these are passed.
> We should do an audit and update
> [https://github.com/apache/hbase/blob/master/conf/hbase-env.sh] to capture
> alternate/fix.
> Will refer following for a fix/repalacement:
> *
> [https://stackoverflow.com/questions/54144713/is-there-a-replacement-for-the-garbage-collection-jvm-args-in-java-11]
> *
> [https://docs.oracle.com/javase/9/tools/java.htm#GUID-BE93ABDC-999C-4CB5-A88B-1994AAAC74D5__CONVERTGCLOGGINGFLAGSTOXLOG-A5046BD1]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-28383) Update hbase-env.sh with alternates to JVM flags which are no longer supported with JDK17
[
https://issues.apache.org/jira/browse/HBASE-28383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nihal Jain updated HBASE-28383:
---
Component/s: java
scripts
> Update hbase-env.sh with alternates to JVM flags which are no longer
> supported with JDK17
> -
>
> Key: HBASE-28383
> URL: https://issues.apache.org/jira/browse/HBASE-28383
> Project: HBase
> Issue Type: Improvement
> Components: java, scripts
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
>
> Some JVM flags like {{{}-XX:+PrintGCDetails{}}}, {{-XX:+PrintGCDateStamps}}
> etc. are no longer supported with JDK 17 and hbase would fail to start if
> these are passed.
> We should do an audit and update
> [https://github.com/apache/hbase/blob/master/conf/hbase-env.sh] to capture
> alternate/fix.
> Will refer following for a fix/repalacement:
> *
> [https://stackoverflow.com/questions/54144713/is-there-a-replacement-for-the-garbage-collection-jvm-args-in-java-11]
> *
> [https://docs.oracle.com/javase/9/tools/java.htm#GUID-BE93ABDC-999C-4CB5-A88B-1994AAAC74D5__CONVERTGCLOGGINGFLAGSTOXLOG-A5046BD1]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (HBASE-28383) Update hbase-env.sh with alternates to JVM flags which are no longer supported with JDK17
Nihal Jain created HBASE-28383:
--
Summary: Update hbase-env.sh with alternates to JVM flags which
are no longer supported with JDK17
Key: HBASE-28383
URL: https://issues.apache.org/jira/browse/HBASE-28383
Project: HBase
Issue Type: Improvement
Reporter: Nihal Jain
Assignee: Nihal Jain
Some JVM flags like {{{}-XX:+PrintGCDetails{}}}, {{-XX:+PrintGCDateStamps}}
etc. are no longer supported with JDK 17 and hbase would fail to start if these
are passed.
We should do an audit and update
[https://github.com/apache/hbase/blob/master/conf/hbase-env.sh] to capture
alternate/fix.
Will refer following for a fix/repalacement:
*
[https://stackoverflow.com/questions/54144713/is-there-a-replacement-for-the-garbage-collection-jvm-args-in-java-11]
*
[https://docs.oracle.com/javase/9/tools/java.htm#GUID-BE93ABDC-999C-4CB5-A88B-1994AAAC74D5__CONVERTGCLOGGINGFLAGSTOXLOG-A5046BD1]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
