[jira] [Commented] (HBASE-15222) Use less contended classes for metrics

2016-02-22 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157996#comment-15157996 ] Elliott Clark commented on HBASE-15222: --- Even on a more beefy server with 32 cores the trend seems

[jira] [Commented] (HBASE-15222) Use less contended classes for metrics

2016-02-22 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157987#comment-15157987 ] Elliott Clark commented on HBASE-15222: --- Yeah, fastLong is continually much faster than Yammer and

[jira] [Updated] (HBASE-15222) Use less contended classes for metrics

2016-02-22 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Attachment: HBASE-15222-v11.patch I had left some debug numbers in when creating buckets. So

[jira] [Updated] (HBASE-15222) Use less contended classes for metrics

2016-02-22 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Attachment: HBASE-15222-v10.patch Updated commit message to reflect the correct class used for

[jira] [Updated] (HBASE-15222) Use less contended classes for metrics

2016-02-22 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Attachment: HBASE-15222-v9.patch Not sure why the last patch didn't trigger HadoopQA > Use

[jira] [Commented] (HBASE-15135) Add metrics for storefile age

2016-02-22 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157300#comment-15157300 ] Elliott Clark commented on HBASE-15135: --- -1 on 1.2 line. This is a feature, we should try and move

[jira] [Updated] (HBASE-15222) Use less contended classes for metrics

2016-02-19 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Attachment: HBASE-15222-v8.patch Use fast long histogram for both histogram and for

[jira] [Commented] (HBASE-15222) Use less contended classes for metrics

2016-02-19 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155182#comment-15155182 ] Elliott Clark commented on HBASE-15222: --- I think I have a solution that's just as fast as possible,

[jira] [Commented] (HBASE-15222) Use less contended classes for metrics

2016-02-19 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155181#comment-15155181 ] Elliott Clark commented on HBASE-15222: --- Almost every histogram in HBase uses them.

[jira] [Commented] (HBASE-15222) Use less contended classes for metrics

2016-02-19 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154903#comment-15154903 ] Elliott Clark commented on HBASE-15222: --- So the MutableRangeHistogram is really slow. It gets us

[jira] [Updated] (HBASE-15222) Use less contended classes for metrics

2016-02-19 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Attachment: HBASE-15222-v6.patch > Use less contended classes for metrics >

[jira] [Commented] (HBASE-15222) Use less contended classes for metrics

2016-02-19 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154728#comment-15154728 ] Elliott Clark commented on HBASE-15222: --- New quick run benchmarks for histograms: {code} Benchmark

[jira] [Commented] (HBASE-15222) Use less contended classes for metrics

2016-02-19 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154668#comment-15154668 ] Elliott Clark commented on HBASE-15222: --- I pushed a new benchmark for Counter/AtomicLong/LongAdder.

[jira] [Updated] (HBASE-15222) Use less contended classes for metrics

2016-02-19 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Attachment: HBASE-15222-v5.patch > Use less contended classes for metrics >

[jira] [Updated] (HBASE-15222) Use less contended classes for metrics

2016-02-19 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Summary: Use less contended classes for metrics (was: Use HDR histograms rather than hadoop

[jira] [Updated] (HBASE-15222) Use HDR histograms rather than hadoop or yammer's

2016-02-18 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Attachment: HBASE-15222-v3.patch > Use HDR histograms rather than hadoop or yammer's >

[jira] [Commented] (HBASE-15137) CallTimeoutException should be grounds for PFFE

2016-02-18 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15153441#comment-15153441 ] Elliott Clark commented on HBASE-15137: --- Probably needs a rebase with the re-working of exceptions.

[jira] [Commented] (HBASE-15135) Add metrics for storefile age

2016-02-18 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15153440#comment-15153440 ] Elliott Clark commented on HBASE-15135: --- +1 commit to the world. > Add metrics for storefile age >

[jira] [Updated] (HBASE-15222) Use HDR histograms rather than hadoop or yammer's

2016-02-18 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Status: Patch Available (was: Open) > Use HDR histograms rather than hadoop or yammer's >

[jira] [Updated] (HBASE-15222) Use HDR histograms rather than hadoop or yammer's

2016-02-18 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Attachment: HBASE-15222-v2.patch Deprecate the FastLongHistogram and remove the quantile

[jira] [Updated] (HBASE-15222) Use HDR histograms rather than hadoop or yammer's

2016-02-18 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Attachment: HBASE-15222-v1.patch > Use HDR histograms rather than hadoop or yammer's >

[jira] [Commented] (HBASE-15222) Use HDR histograms rather than hadoop or yammer's

2016-02-18 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15153036#comment-15153036 ] Elliott Clark commented on HBASE-15222: --- https://reviews.facebook.net/D54381 I added the

[jira] [Commented] (HBASE-15136) Explore different queuing behaviors while busy

2016-02-18 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15152908#comment-15152908 ] Elliott Clark commented on HBASE-15136: --- https://reviews.facebook.net/D54351 Comments up on web

[jira] [Updated] (HBASE-15222) Use HDR histograms rather than hadoop or yammer's

2016-02-18 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Attachment: HBASE-15222.patch Still needs some clean up but it should make the idea known. >

[jira] [Updated] (HBASE-15281) Allow the FileSystem inside HFileSystem to be wrapped

2016-02-17 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15281: -- Fix Version/s: 1.3.0 2.0.0 > Allow the FileSystem inside HFileSystem to be

[jira] [Updated] (HBASE-15281) Allow the FileSystem inside HFileSystem to be wrapped

2016-02-17 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15281: -- Affects Version/s: 1.2.0 2.0.0 > Allow the FileSystem inside

[jira] [Commented] (HBASE-15267) Read requests count metric is increased when Get operation does not return any record

2016-02-14 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146829#comment-15146829 ] Elliott Clark commented on HBASE-15267: --- Seems like the metric is correct. It's all about how many

[jira] [Commented] (HBASE-6721) RegionServer Group based Assignment

2016-02-12 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145843#comment-15145843 ] Elliott Clark commented on HBASE-6721: -- bq.Took a quick look at how the NN publishes metadata via

[jira] [Commented] (HBASE-15232) Exceptions returned over multi RPC don't automatically trigger region location reloads

2016-02-12 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145854#comment-15145854 ] Elliott Clark commented on HBASE-15232: --- lgtm > Exceptions returned over multi RPC don't

[jira] [Commented] (HBASE-15232) Exceptions returned over multi RPC don't automatically trigger region location reloads

2016-02-12 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145395#comment-15145395 ] Elliott Clark commented on HBASE-15232: --- -1 Don't clear the cache on multi's if the exception isn't

[jira] [Commented] (HBASE-15232) Exceptions returned over multi RPC don't automatically trigger region location reloads

2016-02-12 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145435#comment-15145435 ] Elliott Clark commented on HBASE-15232: --- Yeah sorry

[jira] [Commented] (HBASE-6721) RegionServer Group based Assignment

2016-02-12 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145632#comment-15145632 ] Elliott Clark commented on HBASE-6721: -- bq.That is up for the users to decide. And up the the PMC to

[jira] [Commented] (HBASE-15224) Undo "hbase.increment.fast.but.narrow.consistency" option; it is not necessary since HBASE-15213

2016-02-11 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143387#comment-15143387 ] Elliott Clark commented on HBASE-15224: --- +1 on the addendum > Undo

[jira] [Commented] (HBASE-14490) [RpcServer] reuse request read buffer

2016-02-11 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143877#comment-15143877 ] Elliott Clark commented on HBASE-14490: --- Unless there is a noticeable benefit, is there a reason to

[jira] [Commented] (HBASE-14490) [RpcServer] reuse request read buffer

2016-02-11 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144051#comment-15144051 ] Elliott Clark commented on HBASE-14490: --- Haha not really sure that java 8's that cutting edge

[jira] [Commented] (HBASE-14790) Implement a new DFSOutputStream for logging WAL only

2016-02-08 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136961#comment-15136961 ] Elliott Clark commented on HBASE-14790: --- For any data that HBase will ever consider to be durable

[jira] [Updated] (HBASE-15211) Don't run the CatalogJanitor if there are regions in transition

2016-02-08 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15211: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Don't run the

[jira] [Commented] (HBASE-14790) Implement a new DFSOutputStream for logging WAL only

2016-02-08 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136991#comment-15136991 ] Elliott Clark commented on HBASE-14790: --- I was looking at WALProcedure rather than protobuf. Yeah

[jira] [Commented] (HBASE-12751) Allow RowLock to be reader writer

2016-02-08 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15137925#comment-15137925 ] Elliott Clark commented on HBASE-12751: --- Yeah that was something I did to try and really only have

[jira] [Commented] (HBASE-15046) Perf test doing all mutation steps under row lock

2016-02-08 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15137929#comment-15137929 ] Elliott Clark commented on HBASE-15046: --- If we spend the time between append and sync putting the

[jira] [Commented] (HBASE-15211) Don't run the CatalogJanitor if there are regions in transition

2016-02-08 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15137812#comment-15137812 ] Elliott Clark commented on HBASE-15211: --- We have lost data from this janitor. Until we have a

[jira] [Updated] (HBASE-15222) Use HDR histograms rather than hadoop or yammer's

2016-02-05 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Affects Version/s: 1.3.0 1.2.0 2.0.0 > Use HDR

[jira] [Updated] (HBASE-15222) Use HDR histograms rather than hadoop or yammer's

2016-02-05 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Fix Version/s: 1.3.0 2.0.0 > Use HDR histograms rather than hadoop or

[jira] [Assigned] (HBASE-15222) Use HDR histograms rather than hadoop or yammer's

2016-02-05 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark reassigned HBASE-15222: - Assignee: Elliott Clark > Use HDR histograms rather than hadoop or yammer's >

[jira] [Updated] (HBASE-15222) Use HDR histograms rather than hadoop or yammer's

2016-02-05 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Component/s: metrics > Use HDR histograms rather than hadoop or yammer's >

[jira] [Created] (HBASE-15222) Use HDR histograms rather than hadoop or yammer's

2016-02-05 Thread Elliott Clark (JIRA)
Elliott Clark created HBASE-15222: - Summary: Use HDR histograms rather than hadoop or yammer's Key: HBASE-15222 URL: https://issues.apache.org/jira/browse/HBASE-15222 Project: HBase Issue

[jira] [Commented] (HBASE-15222) Use HDR histograms rather than hadoop or yammer's

2016-02-05 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135084#comment-15135084 ] Elliott Clark commented on HBASE-15222: --- Initial results: {code} Benchmark

[jira] [Commented] (HBASE-15222) Use HDR histograms rather than hadoop or yammer's

2016-02-05 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135040#comment-15135040 ] Elliott Clark commented on HBASE-15222: --- We recently saw a lot of contention on a loaded server.

[jira] [Commented] (HBASE-15222) Use HDR histograms rather than hadoop or yammer's

2016-02-05 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135301#comment-15135301 ] Elliott Clark commented on HBASE-15222: --- Longer benchmark run: {code} Benchmark

[jira] [Commented] (HBASE-14790) Implement a new DFSOutputStream for logging WAL only

2016-02-05 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135272#comment-15135272 ] Elliott Clark commented on HBASE-14790: --- bq.or three DNs and RS crash at the same time This isn't

[jira] [Commented] (HBASE-15158) Change order in which we do write pipeline operations; do all under row locks!

2016-02-05 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135299#comment-15135299 ] Elliott Clark commented on HBASE-15158: --- +1 thanks for the nudge in the correct direction. lgtm >

[jira] [Updated] (HBASE-15211) Don't run the CatalogJanitor if there are regions in transition

2016-02-04 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15211: -- Fix Version/s: 1.1.4 1.2.1 1.3.0 2.0.0

[jira] [Commented] (HBASE-15212) RRCServer should enforce max request size

2016-02-04 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133413#comment-15133413 ] Elliott Clark commented on HBASE-15212: --- Yeah that's wy too aggressive. We shouldn't be

[jira] [Commented] (HBASE-15211) Don't run the CatalogJanitor if there are regions in transition

2016-02-04 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132560#comment-15132560 ] Elliott Clark commented on HBASE-15211: --- Both tests passed locally twice, so likely flakey. Thanks

[jira] [Commented] (HBASE-15158) Change order in which we do write pipeline operations; do all under row locks!

2016-02-04 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132657#comment-15132657 ] Elliott Clark commented on HBASE-15158: --- Reviewing now. Is it possible to double release a row

[jira] [Commented] (HBASE-15158) Change order in which we do write pipeline operations; do all under row locks!

2016-02-04 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132738#comment-15132738 ] Elliott Clark commented on HBASE-15158: --- doMiniBatchMutation if step 7 releases the locks and we do

[jira] [Updated] (HBASE-15211) Don't run the CatalogJanitor if there are regions in transition

2016-02-03 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15211: -- Attachment: HBASE-15211.patch > Don't run the CatalogJanitor if there are regions in

[jira] [Created] (HBASE-15211) Don't run the CatalogJanitor if there are regions in transition

2016-02-03 Thread Elliott Clark (JIRA)
Elliott Clark created HBASE-15211: - Summary: Don't run the CatalogJanitor if there are regions in transition Key: HBASE-15211 URL: https://issues.apache.org/jira/browse/HBASE-15211 Project: HBase

[jira] [Updated] (HBASE-15211) Don't run the CatalogJanitor if there are regions in transition

2016-02-03 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15211: -- Status: Patch Available (was: Open) > Don't run the CatalogJanitor if there are regions in

[jira] [Commented] (HBASE-15196) HBASE-15158 Preamble 2 of 2:Add Increment tests

2016-02-02 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128801#comment-15128801 ] Elliott Clark commented on HBASE-15196: --- +1 with one nit. You have some debug logging left in but

[jira] [Commented] (HBASE-15206) Flakey testSplitDaughtersNotInMeta test

2016-02-02 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129503#comment-15129503 ] Elliott Clark commented on HBASE-15206: --- Can this happen on a real cluster resulting in the same

[jira] [Updated] (HBASE-15146) Don't block on Reader threads queueing to a scheduler queue

2016-01-28 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15146: -- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 1.3.0

[jira] [Commented] (HBASE-15160) Put back HFile's HDFS op latency sampling code and add metrics for monitoring

2016-01-27 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119317#comment-15119317 ] Elliott Clark commented on HBASE-15160: --- The actual removal was done by me when moving to metrics2.

[jira] [Commented] (HBASE-15146) Don't block on Reader threads queueing to a scheduler queue

2016-01-27 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119321#comment-15119321 ] Elliott Clark commented on HBASE-15146: --- Not a single unit test repeats between the sets. :-/ Looks

[jira] [Commented] (HBASE-6721) RegionServer Group based Assignment

2016-01-27 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119284#comment-15119284 ] Elliott Clark commented on HBASE-6721: -- bq.I think the current patch covers the already-agreed-upon

[jira] [Commented] (HBASE-15165) AsyncProcess can spin wait indefinitly

2016-01-26 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117023#comment-15117023 ] Elliott Clark commented on HBASE-15165: --- bq.I met similar problem in our production cluster. I am

[jira] [Updated] (HBASE-14526) Remove delayed rpc

2016-01-26 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-14526: -- Attachment: HBASE-14526-v4.patch Need to get the name right or the test fails. > Remove

[jira] [Updated] (HBASE-14526) Remove delayed rpc

2016-01-26 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-14526: -- Attachment: HBASE-14526-branch-1.patch Branch 1 version that I'm going to commit, in order to

[jira] [Updated] (HBASE-14526) Remove delayed rpc

2016-01-26 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-14526: -- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 1.3.0

[jira] [Updated] (HBASE-15146) Don't block on Reader threads queueing to a scheduler queue

2016-01-26 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15146: -- Attachment: HBASE-15146-v8.patch Rebased patch. Nothing really changed, just no changes to

[jira] [Commented] (HBASE-15160) Put back HFile's HDFS op latency sampling code and add metrics for monitoring

2016-01-26 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118094#comment-15118094 ] Elliott Clark commented on HBASE-15160: --- So one of the reasons that the metrics in the deep read

[jira] [Updated] (HBASE-15146) Don't block on Reader threads queueing to a scheduler queue

2016-01-26 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15146: -- Attachment: HBASE-15146-v8.patch Re-attaching to try flakies again. These don't seem to

[jira] [Updated] (HBASE-14526) Remove delayed rpc

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-14526: -- Attachment: HBASE-14526-v1.patch Missed some strings. > Remove delayed rpc >

[jira] [Updated] (HBASE-14526) Remove delayed rpc

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-14526: -- Status: Patch Available (was: Open) > Remove delayed rpc > -- > >

[jira] [Updated] (HBASE-14526) Remove delayed rpc

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-14526: -- Attachment: HBASE-14526-v2.patch > Remove delayed rpc > -- > >

[jira] [Commented] (HBASE-15163) Add sampling code and metrics for get/scan/multi/mutate count separately

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116687#comment-15116687 ] Elliott Clark commented on HBASE-15163: --- bq.Yes but they are not histogram, so still have the

[jira] [Commented] (HBASE-15163) Add sampling code and metrics for get/scan/multi/mutate count separately

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116661#comment-15116661 ] Elliott Clark commented on HBASE-15163: --- The user has very little control over the batching so I

[jira] [Commented] (HBASE-15163) Add sampling code and metrics for get/scan/multi/mutate count separately

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116659#comment-15116659 ] Elliott Clark commented on HBASE-15163: --- readRequestCount and writeRequestCount are both just

[jira] [Commented] (HBASE-15166) Remove delayed rpc

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116713#comment-15116713 ] Elliott Clark commented on HBASE-15166: --- Ahhh correct you are. Oooops. Thanks > Remove delayed rpc

[jira] [Comment Edited] (HBASE-15163) Add sampling code and metrics for get/scan/multi/mutate count separately

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116793#comment-15116793 ] Elliott Clark edited comment on HBASE-15163 at 1/26/16 6:54 AM:

[jira] [Commented] (HBASE-15163) Add sampling code and metrics for get/scan/multi/mutate count separately

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116793#comment-15116793 ] Elliott Clark commented on HBASE-15163: --- bq.Regarding the screenshot I pasted, the rate is computed

[jira] [Resolved] (HBASE-15166) Remove delayed rpc

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark resolved HBASE-15166. --- Resolution: Duplicate > Remove delayed rpc > -- > > Key:

[jira] [Updated] (HBASE-14526) Remove delayed rpc

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-14526: -- Attachment: HBASE-14526.patch > Remove delayed rpc > -- > >

[jira] [Assigned] (HBASE-14526) Remove delayed rpc

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark reassigned HBASE-14526: - Assignee: Elliott Clark > Remove delayed rpc > -- > >

[jira] [Commented] (HBASE-15163) Add sampling code and metrics for get/scan/multi/mutate count separately

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116755#comment-15116755 ] Elliott Clark commented on HBASE-15163: --- bq.This is what you mean 'continuous couting', right? It

[jira] [Created] (HBASE-15166) Remove delayed rpc

2016-01-25 Thread Elliott Clark (JIRA)
Elliott Clark created HBASE-15166: - Summary: Remove delayed rpc Key: HBASE-15166 URL: https://issues.apache.org/jira/browse/HBASE-15166 Project: HBase Issue Type: Bug Reporter:

[jira] [Updated] (HBASE-15166) Remove delayed rpc

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15166: -- Attachment: HBASE-14526-v2.patch try with resources. > Remove delayed rpc >

[jira] [Assigned] (HBASE-15166) Remove delayed rpc

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark reassigned HBASE-15166: - Assignee: Elliott Clark > Remove delayed rpc > -- > >

[jira] [Commented] (HBASE-15162) Add separate metrics for meta/data block hit ratio in cache

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116717#comment-15116717 ] Elliott Clark commented on HBASE-15162: --- Sure let me try and get the percent gauges on. > Add

[jira] [Updated] (HBASE-14526) Remove delayed rpc

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-14526: -- Attachment: HBASE-14526-v3.patch Missed deletions. > Remove delayed rpc > --

[jira] [Commented] (HBASE-7408) Make compaction to use pread instead of sequential read

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115770#comment-15115770 ] Elliott Clark commented on HBASE-7408: -- I would guess that this was the issue with long running

[jira] [Updated] (HBASE-15146) Don't block on Reader threads queueing to a scheduler queue

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15146: -- Attachment: HBASE-15146-v7.patch > Don't block on Reader threads queueing to a scheduler queue

[jira] [Commented] (HBASE-15163) Add sampling code and metrics for get/scan/multi/mutate count separately

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115585#comment-15115585 ] Elliott Clark commented on HBASE-15163: --- We already have those numbers with the histogram counting.

[jira] [Updated] (HBASE-15137) CallTimeoutException should be grounds for PFFE

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15137: -- Assignee: Mikhail Antonov (was: mik) > CallTimeoutException should be grounds for PFFE >

[jira] [Updated] (HBASE-15137) CallTimeoutException should be grounds for PFFE

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15137: -- Assignee: mik (was: Elliott Clark) > CallTimeoutException should be grounds for PFFE >

[jira] [Commented] (HBASE-15160) Put back HFile's HDFS op latency sampling code and add metrics for monitoring

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116003#comment-15116003 ] Elliott Clark commented on HBASE-15160: --- Rather than storing the times, we should just put them

[jira] [Comment Edited] (HBASE-15162) Add separate metrics for meta/data block hit ratio in cache

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116378#comment-15116378 ] Elliott Clark edited comment on HBASE-15162 at 1/26/16 12:36 AM: - isn't

[jira] [Updated] (HBASE-15165) AsyncProcess can spin wait indefinitly

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15165: -- Affects Version/s: 1.3.0 1.2.0 2.0.0 >

[jira] [Updated] (HBASE-15165) AsyncProcess can spin wait indefinitly

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15165: -- Priority: Critical (was: Major) > AsyncProcess can spin wait indefinitly >

[jira] [Commented] (HBASE-15162) Add separate metrics for meta/data block hit ratio in cache

2016-01-25 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116378#comment-15116378 ] Elliott Clark commented on HBASE-15162: --- isn't this just a dupe of HBASE-14983 ? > Add separate

<    2   3   4   5   6   7   8   9   10   11   >