bbeaudreault commented on code in PR #4125:
URL: https://github.com/apache/hbase/pull/4125#discussion_r897348549
##
hbase-common/src/main/java/org/apache/hadoop/hbase/exceptions/X509Exception.java:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
bbeaudreault commented on code in PR #4125:
URL: https://github.com/apache/hbase/pull/4125#discussion_r897348549
##
hbase-common/src/main/java/org/apache/hadoop/hbase/exceptions/X509Exception.java:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
Apache-HBase commented on PR #4535:
URL: https://github.com/apache/hbase/pull/4535#issuecomment-1155754804
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 39s | Docker
virajjasani commented on PR #4533:
URL: https://github.com/apache/hbase/pull/4533#issuecomment-1155894510
@ujjawal4046 are these tests passing in your local?
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4533/1/testReport/
--
This is an automated message from the Apache
Apache-HBase commented on PR #4533:
URL: https://github.com/apache/hbase/pull/4533#issuecomment-1155919307
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 34s | Docker
Apache9 merged PR #4534:
URL: https://github.com/apache/hbase/pull/4534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.
Apache9 merged PR #4535:
URL: https://github.com/apache/hbase/pull/4535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.
Apache-HBase commented on PR #4351:
URL: https://github.com/apache/hbase/pull/4351#issuecomment-1155931388
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s | Docke
Apache-HBase commented on PR #4351:
URL: https://github.com/apache/hbase/pull/4351#issuecomment-1155929707
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 18s | Docke
Apache-HBase commented on PR #4351:
URL: https://github.com/apache/hbase/pull/4351#issuecomment-1155929330
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 29s | Docke
sunhelly opened a new pull request, #4536:
URL: https://github.com/apache/hbase/pull/4536
…ped most cells read
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
Apache-HBase commented on PR #4536:
URL: https://github.com/apache/hbase/pull/4536#issuecomment-1155980322
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 7s | Docker
Apache-HBase commented on PR #4533:
URL: https://github.com/apache/hbase/pull/4533#issuecomment-1156016575
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 11s | Docker
Apache-HBase commented on PR #4533:
URL: https://github.com/apache/hbase/pull/4533#issuecomment-1156023105
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s | Docker
ddupg merged PR #4351:
URL: https://github.com/apache/hbase/pull/4351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.or
Apache-HBase commented on PR #4536:
URL: https://github.com/apache/hbase/pull/4536#issuecomment-1156121859
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 6m 30s | Docker
steveloughran commented on PR #30:
URL: https://github.com/apache/hbase-filesystem/pull/30#issuecomment-1156164673
thanks. will do this todsy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
251906 commented on PR #4501:
URL: https://github.com/apache/hbase/pull/4501#issuecomment-1156260386
@Apache9 These logs are added to enable Better logging in Canary tool.
Currently CanaryTool logs don't indicate which mode they pertain to. So I
have added the logs for the same
F
Apache-HBase commented on PR #4538:
URL: https://github.com/apache/hbase/pull/4538#issuecomment-1156293201
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s | Docke
Apache-HBase commented on PR #4538:
URL: https://github.com/apache/hbase/pull/4538#issuecomment-1156294024
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 4m 10s | Docke
Apache-HBase commented on PR #4537:
URL: https://github.com/apache/hbase/pull/4537#issuecomment-1156295572
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 4m 17s | Docker
Apache-HBase commented on PR #4538:
URL: https://github.com/apache/hbase/pull/4538#issuecomment-1156303681
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 34s | Docke
wchevreuil commented on code in PR #107:
URL:
https://github.com/apache/hbase-operator-tools/pull/107#discussion_r898065872
##
hbase-hbck2/README.md:
##
@@ -102,7 +102,6 @@ Options:
Command:
addFsRegionsMissingInMeta ...|-i
...
Options:
--d,--force_disable aborts fi
wchevreuil commented on code in PR #107:
URL:
https://github.com/apache/hbase-operator-tools/pull/107#discussion_r898068270
##
hbase-hbck2/pom.xml:
##
@@ -171,16 +171,19 @@
org.apache.logging.log4j
log4j-api
${log4j2.version}
+ provided
Review C
Apache-HBase commented on PR #107:
URL:
https://github.com/apache/hbase-operator-tools/pull/107#issuecomment-1156578222
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache9 commented on code in PR #107:
URL:
https://github.com/apache/hbase-operator-tools/pull/107#discussion_r898110273
##
hbase-hbck2/pom.xml:
##
@@ -171,16 +171,19 @@
org.apache.logging.log4j
log4j-api
${log4j2.version}
+ provided
Review Comm
Apache-HBase commented on PR #4536:
URL: https://github.com/apache/hbase/pull/4536#issuecomment-1156617838
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 30s | Docke
2005hithlj opened a new pull request, #4539:
URL: https://github.com/apache/hbase/pull/4539
https://issues.apache.org/jira/browse/HBASE-27028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
Apache-HBase commented on PR #4539:
URL: https://github.com/apache/hbase/pull/4539#issuecomment-1156692185
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 55s | Docke
Apache-HBase commented on PR #4536:
URL: https://github.com/apache/hbase/pull/4536#issuecomment-1156788956
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 44s | Docke
Apache-HBase commented on PR #4536:
URL: https://github.com/apache/hbase/pull/4536#issuecomment-1156798328
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 34s | Docke
apurtell commented on PR #30:
URL: https://github.com/apache/hbase-filesystem/pull/30#issuecomment-1156923274
Merged #34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
apurtell merged PR #34:
URL: https://github.com/apache/hbase-filesystem/pull/34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase
Apache-HBase commented on PR #4539:
URL: https://github.com/apache/hbase/pull/4539#issuecomment-1156953811
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 9m 47s | Docker
Apache-HBase commented on PR #4539:
URL: https://github.com/apache/hbase/pull/4539#issuecomment-1156968078
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 9m 38s | Docker
virajjasani commented on code in PR #4486:
URL: https://github.com/apache/hbase/pull/4486#discussion_r898605507
##
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationSinkTrackerTableCreator.java:
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache So
Apache-HBase commented on PR #4539:
URL: https://github.com/apache/hbase/pull/4539#issuecomment-1157187319
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 56s | Docke
Apache-HBase commented on PR #4539:
URL: https://github.com/apache/hbase/pull/4539#issuecomment-1157199326
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 45s | Docker
Apache-HBase commented on PR #4537:
URL: https://github.com/apache/hbase/pull/4537#issuecomment-1157210707
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 48s | Docker
2005hithlj commented on PR #4539:
URL: https://github.com/apache/hbase/pull/4539#issuecomment-1157217370
@Apache9 Could you take a look? Thanks.
At the same time, the UT ‘ TestFailedAppendAndSync’ is ok in my environment.
--
This is an automated message from the Apache Git Service.
To
Apache-HBase commented on PR #4539:
URL: https://github.com/apache/hbase/pull/4539#issuecomment-1157298236
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 44s | Docke
anwebanSalesforce opened a new pull request, #4540:
URL: https://github.com/apache/hbase/pull/4540
Added 3 new metrics to MetricsMasterProcSource. Created methods in
MetricsMasterWrapper to fetch those metrics and expose them through jmx.
--
This is an automated message from the Apache Gi
Apache-HBase commented on PR #4540:
URL: https://github.com/apache/hbase/pull/4540#issuecomment-1157340980
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 28s | Docker
tomscut commented on PR #4532:
URL: https://github.com/apache/hbase/pull/4532#issuecomment-1157344178
Thanks @virajjasani for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
tomscut commented on PR #4499:
URL: https://github.com/apache/hbase/pull/4499#issuecomment-1157344651
Hi @apurtell , please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
Apache-HBase commented on PR #4533:
URL: https://github.com/apache/hbase/pull/4533#issuecomment-1157434714
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 18s | Docke
wchevreuil commented on PR #107:
URL:
https://github.com/apache/hbase-operator-tools/pull/107#issuecomment-1157446423
> Mind explaining a bit on what is the problem here? After skimming the PR,
I can not fully understand what is the problem we are trying to fix here...
HBCK2 _replica
ndimiduk commented on PR #107:
URL:
https://github.com/apache/hbase-operator-tools/pull/107#issuecomment-1157493844
FYI @clarax
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
Apache-HBase commented on PR #4540:
URL: https://github.com/apache/hbase/pull/4540#issuecomment-1157510275
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s | Docke
wchevreuil commented on code in PR #107:
URL:
https://github.com/apache/hbase-operator-tools/pull/107#discussion_r898949264
##
hbase-hbck2/pom.xml:
##
@@ -171,16 +171,19 @@
org.apache.logging.log4j
log4j-api
${log4j2.version}
+ provided
Review C
wchevreuil commented on code in PR #107:
URL:
https://github.com/apache/hbase-operator-tools/pull/107#discussion_r898949264
##
hbase-hbck2/pom.xml:
##
@@ -171,16 +171,19 @@
org.apache.logging.log4j
log4j-api
${log4j2.version}
+ provided
Review C
Apache-HBase commented on PR #4541:
URL: https://github.com/apache/hbase/pull/4541#issuecomment-1157522130
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s | Docke
Apache-HBase commented on PR #4540:
URL: https://github.com/apache/hbase/pull/4540#issuecomment-1157523298
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 20s | Docker
petersomogyi merged PR #106:
URL: https://github.com/apache/hbase-operator-tools/pull/106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
bbeaudreault commented on code in PR #4125:
URL: https://github.com/apache/hbase/pull/4125#discussion_r898997275
##
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java:
##
@@ -181,4 +204,80 @@ public int getNumOpenConnections() {
// allChannels also c
dependabot[bot] opened a new pull request, #108:
URL: https://github.com/apache/hbase-operator-tools/pull/108
Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.18 to
8.29.
Release notes
Sourced from https://github.com/checkstyle/checkstyle/releases";>checkstyle's
Apache-HBase commented on PR #108:
URL:
https://github.com/apache/hbase-operator-tools/pull/108#issuecomment-1157585966
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0
Apache-HBase commented on PR #4533:
URL: https://github.com/apache/hbase/pull/4533#issuecomment-1157595361
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s | Docker
Apache-HBase commented on PR #4533:
URL: https://github.com/apache/hbase/pull/4533#issuecomment-1157606884
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 1s | Docker
bbeaudreault commented on code in PR #4125:
URL: https://github.com/apache/hbase/pull/4125#discussion_r899039496
##
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java:
##
@@ -0,0 +1,310 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
bbeaudreault commented on code in PR #4125:
URL: https://github.com/apache/hbase/pull/4125#discussion_r899041119
##
hbase-client/src/test/java/org/apache/hadoop/hbase/ipc/TestNettyRpcConnection.java:
##
@@ -67,6 +68,7 @@ public static void tearDown() throws IOException {
Cl
bbeaudreault commented on code in PR #4125:
URL: https://github.com/apache/hbase/pull/4125#discussion_r899044758
##
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java:
##
@@ -0,0 +1,310 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
bbeaudreault commented on code in PR #4125:
URL: https://github.com/apache/hbase/pull/4125#discussion_r891179372
##
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java:
##
@@ -216,11 +224,16 @@ private void saslNegotiate(final Channel ch) {
fail
Apache-HBase commented on PR #4533:
URL: https://github.com/apache/hbase/pull/4533#issuecomment-1157638569
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 12s | Docke
Apache9 commented on code in PR #107:
URL:
https://github.com/apache/hbase-operator-tools/pull/107#discussion_r899064897
##
hbase-hbck2/pom.xml:
##
@@ -171,16 +171,19 @@
org.apache.logging.log4j
log4j-api
${log4j2.version}
+ provided
Review Comm
Apache9 commented on code in PR #107:
URL:
https://github.com/apache/hbase-operator-tools/pull/107#discussion_r899076432
##
hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java:
##
@@ -1330,19 +1334,44 @@ private List stringArrayToList(String...
nameSpaceOrTable) {
* @par
Apache-HBase commented on PR #4541:
URL: https://github.com/apache/hbase/pull/4541#issuecomment-1157681588
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s | Docke
Apache-HBase commented on PR #4541:
URL: https://github.com/apache/hbase/pull/4541#issuecomment-1157693788
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 19s | Docke
wchevreuil commented on code in PR #107:
URL:
https://github.com/apache/hbase-operator-tools/pull/107#discussion_r899135897
##
hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java:
##
@@ -1330,19 +1334,44 @@ private List stringArrayToList(String...
nameSpaceOrTable) {
* @
wchevreuil commented on PR #107:
URL:
https://github.com/apache/hbase-operator-tools/pull/107#issuecomment-1157731666
> OK, I can partly know what is the problem now, but the whole
implementation seems a mess to me...
>
I'm happy to answer any questions you might still have. If you f
Apache-HBase commented on PR #107:
URL:
https://github.com/apache/hbase-operator-tools/pull/107#issuecomment-1157733733
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0
steveloughran commented on PR #30:
URL: https://github.com/apache/hbase-filesystem/pull/30#issuecomment-1157738627
thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
wchevreuil commented on code in PR #107:
URL:
https://github.com/apache/hbase-operator-tools/pull/107#discussion_r899167670
##
hbase-hbck2/pom.xml:
##
@@ -171,16 +171,19 @@
org.apache.logging.log4j
log4j-api
${log4j2.version}
+ provided
Review C
wchevreuil commented on code in PR #107:
URL:
https://github.com/apache/hbase-operator-tools/pull/107#discussion_r899167670
##
hbase-hbck2/pom.xml:
##
@@ -171,16 +171,19 @@
org.apache.logging.log4j
log4j-api
${log4j2.version}
+ provided
Review C
Apache-HBase commented on PR #107:
URL:
https://github.com/apache/hbase-operator-tools/pull/107#issuecomment-1157755593
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0
Apache9 opened a new pull request, #4542:
URL: https://github.com/apache/hbase/pull/4542
…nd also how to make use of the new TestingHBaseCluster
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
Apache9 commented on code in PR #4541:
URL: https://github.com/apache/hbase/pull/4541#discussion_r899197367
##
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobUtils.java:
##
@@ -314,20 +316,24 @@ public static void cleanExpiredMobFiles(FileSystem fs,
Configuration con
shahrs87 commented on PR #4486:
URL: https://github.com/apache/hbase/pull/4486#issuecomment-1157814949
Thank you @virajjasani for the review feedback. Addressed couple of
comments in the latest patch.
--
This is an automated message from the Apache Git Service.
To respond to the message,
Apache-HBase commented on PR #4533:
URL: https://github.com/apache/hbase/pull/4533#issuecomment-1157842986
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s | Docker
bbeaudreault commented on code in PR #4125:
URL: https://github.com/apache/hbase/pull/4125#discussion_r899258889
##
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java:
##
@@ -342,14 +366,74 @@ public void operationComplete(ChannelFuture future)
throw
Apache-HBase commented on PR #4533:
URL: https://github.com/apache/hbase/pull/4533#issuecomment-1157865971
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 3s | Docker
Apache-HBase commented on PR #4486:
URL: https://github.com/apache/hbase/pull/4486#issuecomment-1157880931
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s | Docker
Apache-HBase commented on PR #4542:
URL: https://github.com/apache/hbase/pull/4542#issuecomment-1157881674
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s | Docke
Apache-HBase commented on PR #4542:
URL: https://github.com/apache/hbase/pull/4542#issuecomment-1157882712
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s | Docke
Apache-HBase commented on PR #4542:
URL: https://github.com/apache/hbase/pull/4542#issuecomment-1157896964
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 18s | Docke
clarax commented on code in PR #107:
URL:
https://github.com/apache/hbase-operator-tools/pull/107#discussion_r899354610
##
hbase-hbck2/README.md:
##
@@ -102,7 +102,6 @@ Options:
Command:
addFsRegionsMissingInMeta ...|-i
...
Options:
--d,--force_disable aborts fix fo
clarax opened a new pull request, #109:
URL: https://github.com/apache/hbase-operator-tools/pull/109
For review only. This is an alternative implementation of fix to
https://github.com/apache/hbase-operator-tools/pull/107
--
This is an automated message from the Apache Git Service.
To res
clarax commented on PR #107:
URL:
https://github.com/apache/hbase-operator-tools/pull/107#issuecomment-1158034440
Thanks a lot for adding the comprehensive UT. Please see an alternative fix
that follows the same pattern for other commands with command options.
https://github.com/apache/hba
Apache-HBase commented on PR #109:
URL:
https://github.com/apache/hbase-operator-tools/pull/109#issuecomment-1158051955
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m
Apache-HBase commented on PR #4486:
URL: https://github.com/apache/hbase/pull/4486#issuecomment-1158057414
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s | Docke
Apache-HBase commented on PR #4486:
URL: https://github.com/apache/hbase/pull/4486#issuecomment-1158070874
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 6s | Docker
Apache-HBase commented on PR #109:
URL:
https://github.com/apache/hbase-operator-tools/pull/109#issuecomment-1158097882
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on PR #4486:
URL: https://github.com/apache/hbase/pull/4486#issuecomment-1158102040
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s | Docke
virajjasani commented on PR #4486:
URL: https://github.com/apache/hbase/pull/4486#issuecomment-1158119157
I think this is good to go soon as positive QA results are posted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
virajjasani merged PR #4504:
URL: https://github.com/apache/hbase/pull/4504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apa
clarax commented on PR #109:
URL:
https://github.com/apache/hbase-operator-tools/pull/109#issuecomment-1158192498
Yes, I preferred that implementation for cleaner code. But I moved away to
make it commands specific options per feedback on user experience.
I see your point and can mov
shahrs87 commented on PR #4486:
URL: https://github.com/apache/hbase/pull/4486#issuecomment-1158238032
The failed test succeeds locally
```
[INFO] --- maven-surefire-plugin:3.0.0-M6:test (default-test) @ hbase-server
---
[INFO] Using configured provider
org.apache.maven.surefire.ju
clarax commented on PR #107:
URL:
https://github.com/apache/hbase-operator-tools/pull/107#issuecomment-1158251680
LGTM. See conversation at
https://github.com/apache/hbase-operator-tools/pull/109.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
Apache-HBase commented on PR #4486:
URL: https://github.com/apache/hbase/pull/4486#issuecomment-1158266653
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 44s | Docke
Apache-HBase commented on PR #4486:
URL: https://github.com/apache/hbase/pull/4486#issuecomment-1158280011
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 9s | Docke
1 - 100 of 68811 matches
Mail list logo