[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-06-14 Thread GitBox
bbeaudreault commented on code in PR #4125: URL: https://github.com/apache/hbase/pull/4125#discussion_r897348549 ## hbase-common/src/main/java/org/apache/hadoop/hbase/exceptions/X509Exception.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-06-14 Thread GitBox
bbeaudreault commented on code in PR #4125: URL: https://github.com/apache/hbase/pull/4125#discussion_r897348549 ## hbase-common/src/main/java/org/apache/hadoop/hbase/exceptions/X509Exception.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [hbase] Apache-HBase commented on pull request #4535: HBASE-27121 Set version as 3.0.0-alpha-3 in master in prep for first …

2022-06-14 Thread GitBox
Apache-HBase commented on PR #4535: URL: https://github.com/apache/hbase/pull/4535#issuecomment-1155754804 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 39s | Docker

[GitHub] [hbase] virajjasani commented on pull request #4533: HBASE-25922 - Disabled sanity checks ignored on snapshot restore

2022-06-14 Thread GitBox
virajjasani commented on PR #4533: URL: https://github.com/apache/hbase/pull/4533#issuecomment-1155894510 @ujjawal4046 are these tests passing in your local? https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4533/1/testReport/ -- This is an automated message from the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #4533: HBASE-25922 - Disabled sanity checks ignored on snapshot restore

2022-06-14 Thread GitBox
Apache-HBase commented on PR #4533: URL: https://github.com/apache/hbase/pull/4533#issuecomment-1155919307 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 34s | Docker

[GitHub] [hbase] Apache9 merged pull request #4534: HBASE-26167 Allow users to not start zookeeper and dfs cluster when u…

2022-06-14 Thread GitBox
Apache9 merged PR #4534: URL: https://github.com/apache/hbase/pull/4534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.

[GitHub] [hbase] Apache9 merged pull request #4535: HBASE-27121 Set version as 3.0.0-alpha-3 in master in prep for first …

2022-06-14 Thread GitBox
Apache9 merged PR #4535: URL: https://github.com/apache/hbase/pull/4535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.

[GitHub] [hbase] Apache-HBase commented on pull request #4351: HBASE-26956 ExportSnapshot tool supports removing TTL

2022-06-14 Thread GitBox
Apache-HBase commented on PR #4351: URL: https://github.com/apache/hbase/pull/4351#issuecomment-1155931388 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4351: HBASE-26956 ExportSnapshot tool supports removing TTL

2022-06-14 Thread GitBox
Apache-HBase commented on PR #4351: URL: https://github.com/apache/hbase/pull/4351#issuecomment-1155929707 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 18s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4351: HBASE-26956 ExportSnapshot tool supports removing TTL

2022-06-14 Thread GitBox
Apache-HBase commented on PR #4351: URL: https://github.com/apache/hbase/pull/4351#issuecomment-1155929330 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 29s | Docke

[GitHub] [hbase] sunhelly opened a new pull request, #4536: HBASE-25709 Close region may stuck when region is compacting and skip…

2022-06-14 Thread GitBox
sunhelly opened a new pull request, #4536: URL: https://github.com/apache/hbase/pull/4536 …ped most cells read -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [hbase] Apache-HBase commented on pull request #4536: HBASE-25709 Close region may stuck when region is compacting and skip…

2022-06-14 Thread GitBox
Apache-HBase commented on PR #4536: URL: https://github.com/apache/hbase/pull/4536#issuecomment-1155980322 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #4533: HBASE-25922 - Disabled sanity checks ignored on snapshot restore

2022-06-14 Thread GitBox
Apache-HBase commented on PR #4533: URL: https://github.com/apache/hbase/pull/4533#issuecomment-1156016575 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 11s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #4533: HBASE-25922 - Disabled sanity checks ignored on snapshot restore

2022-06-14 Thread GitBox
Apache-HBase commented on PR #4533: URL: https://github.com/apache/hbase/pull/4533#issuecomment-1156023105 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker

[GitHub] [hbase] ddupg merged pull request #4351: HBASE-26956 ExportSnapshot tool supports removing TTL

2022-06-15 Thread GitBox
ddupg merged PR #4351: URL: https://github.com/apache/hbase/pull/4351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.or

[GitHub] [hbase] Apache-HBase commented on pull request #4536: HBASE-25709 Close region may stuck when region is compacting and skip…

2022-06-15 Thread GitBox
Apache-HBase commented on PR #4536: URL: https://github.com/apache/hbase/pull/4536#issuecomment-1156121859 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 30s | Docker

[GitHub] [hbase-filesystem] steveloughran commented on pull request #30: HBASE-26483. [HBOSS] add support for openFile(path)

2022-06-15 Thread GitBox
steveloughran commented on PR #30: URL: https://github.com/apache/hbase-filesystem/pull/30#issuecomment-1156164673 thanks. will do this todsy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [hbase] 251906 commented on pull request #4501: HBASE-26218 Add logs in Canary tool

2022-06-15 Thread GitBox
251906 commented on PR #4501: URL: https://github.com/apache/hbase/pull/4501#issuecomment-1156260386 @Apache9 These logs are added to enable Better logging in Canary tool. Currently CanaryTool logs don't indicate which mode they pertain to. So I have added the logs for the same F

[GitHub] [hbase] Apache-HBase commented on pull request #4538: HBASE-26956 ExportSnapshot tool supports removing TTL

2022-06-15 Thread GitBox
Apache-HBase commented on PR #4538: URL: https://github.com/apache/hbase/pull/4538#issuecomment-1156293201 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4538: HBASE-26956 ExportSnapshot tool supports removing TTL

2022-06-15 Thread GitBox
Apache-HBase commented on PR #4538: URL: https://github.com/apache/hbase/pull/4538#issuecomment-1156294024 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 10s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4537: HBASE-27123 Splitting region may become RIT for 20 minutes when meta region is moved during split

2022-06-15 Thread GitBox
Apache-HBase commented on PR #4537: URL: https://github.com/apache/hbase/pull/4537#issuecomment-1156295572 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 17s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #4538: HBASE-26956 ExportSnapshot tool supports removing TTL

2022-06-15 Thread GitBox
Apache-HBase commented on PR #4538: URL: https://github.com/apache/hbase/pull/4538#issuecomment-1156303681 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 34s | Docke

[GitHub] [hbase-operator-tools] wchevreuil commented on a diff in pull request #107: HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587

2022-06-15 Thread GitBox
wchevreuil commented on code in PR #107: URL: https://github.com/apache/hbase-operator-tools/pull/107#discussion_r898065872 ## hbase-hbck2/README.md: ## @@ -102,7 +102,6 @@ Options: Command: addFsRegionsMissingInMeta ...|-i ... Options: --d,--force_disable aborts fi

[GitHub] [hbase-operator-tools] wchevreuil commented on a diff in pull request #107: HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587

2022-06-15 Thread GitBox
wchevreuil commented on code in PR #107: URL: https://github.com/apache/hbase-operator-tools/pull/107#discussion_r898068270 ## hbase-hbck2/pom.xml: ## @@ -171,16 +171,19 @@ org.apache.logging.log4j log4j-api ${log4j2.version} + provided Review C

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #107: HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587

2022-06-15 Thread GitBox
Apache-HBase commented on PR #107: URL: https://github.com/apache/hbase-operator-tools/pull/107#issuecomment-1156578222 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase-operator-tools] Apache9 commented on a diff in pull request #107: HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587

2022-06-15 Thread GitBox
Apache9 commented on code in PR #107: URL: https://github.com/apache/hbase-operator-tools/pull/107#discussion_r898110273 ## hbase-hbck2/pom.xml: ## @@ -171,16 +171,19 @@ org.apache.logging.log4j log4j-api ${log4j2.version} + provided Review Comm

[GitHub] [hbase] Apache-HBase commented on pull request #4536: HBASE-25709 Close region may stuck when region is compacting and skip…

2022-06-15 Thread GitBox
Apache-HBase commented on PR #4536: URL: https://github.com/apache/hbase/pull/4536#issuecomment-1156617838 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 30s | Docke

[GitHub] [hbase] 2005hithlj opened a new pull request, #4539: HBASE-27028 Add a shell command for flushing master local region

2022-06-15 Thread GitBox
2005hithlj opened a new pull request, #4539: URL: https://github.com/apache/hbase/pull/4539 https://issues.apache.org/jira/browse/HBASE-27028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [hbase] Apache-HBase commented on pull request #4539: HBASE-27028 Add a shell command for flushing master local region

2022-06-15 Thread GitBox
Apache-HBase commented on PR #4539: URL: https://github.com/apache/hbase/pull/4539#issuecomment-1156692185 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4536: HBASE-25709 Close region may stuck when region is compacting and skip…

2022-06-15 Thread GitBox
Apache-HBase commented on PR #4536: URL: https://github.com/apache/hbase/pull/4536#issuecomment-1156788956 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 44s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4536: HBASE-25709 Close region may stuck when region is compacting and skip…

2022-06-15 Thread GitBox
Apache-HBase commented on PR #4536: URL: https://github.com/apache/hbase/pull/4536#issuecomment-1156798328 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 34s | Docke

[GitHub] [hbase-filesystem] apurtell commented on pull request #30: HBASE-26483. [HBOSS] add support for openFile(path)

2022-06-15 Thread GitBox
apurtell commented on PR #30: URL: https://github.com/apache/hbase-filesystem/pull/30#issuecomment-1156923274 Merged #34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase-filesystem] apurtell merged pull request #34: HBASE-27076. [HBOSS] compile against hadoop 3.3.2+ only.

2022-06-15 Thread GitBox
apurtell merged PR #34: URL: https://github.com/apache/hbase-filesystem/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase

[GitHub] [hbase] Apache-HBase commented on pull request #4539: HBASE-27028 Add a shell command for flushing master local region

2022-06-15 Thread GitBox
Apache-HBase commented on PR #4539: URL: https://github.com/apache/hbase/pull/4539#issuecomment-1156953811 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 9m 47s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #4539: HBASE-27028 Add a shell command for flushing master local region

2022-06-15 Thread GitBox
Apache-HBase commented on PR #4539: URL: https://github.com/apache/hbase/pull/4539#issuecomment-1156968078 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 9m 38s | Docker

[GitHub] [hbase] virajjasani commented on a diff in pull request #4486: HBASE-27085 Create REPLICATION_SINK_TRACKER table to persist marker rows coming from source cluster

2022-06-15 Thread GitBox
virajjasani commented on code in PR #4486: URL: https://github.com/apache/hbase/pull/4486#discussion_r898605507 ## hbase-server/src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationSinkTrackerTableCreator.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache So

[GitHub] [hbase] Apache-HBase commented on pull request #4539: HBASE-27028 Add a shell command for flushing master local region

2022-06-15 Thread GitBox
Apache-HBase commented on PR #4539: URL: https://github.com/apache/hbase/pull/4539#issuecomment-1157187319 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4539: HBASE-27028 Add a shell command for flushing master local region

2022-06-15 Thread GitBox
Apache-HBase commented on PR #4539: URL: https://github.com/apache/hbase/pull/4539#issuecomment-1157199326 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 45s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #4537: HBASE-27123 Splitting region may become RIT for 20 minutes when meta region is moved during split

2022-06-15 Thread GitBox
Apache-HBase commented on PR #4537: URL: https://github.com/apache/hbase/pull/4537#issuecomment-1157210707 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s | Docker

[GitHub] [hbase] 2005hithlj commented on pull request #4539: HBASE-27028 Add a shell command for flushing master local region

2022-06-15 Thread GitBox
2005hithlj commented on PR #4539: URL: https://github.com/apache/hbase/pull/4539#issuecomment-1157217370 @Apache9 Could you take a look? Thanks. At the same time, the UT ‘ TestFailedAppendAndSync’ is ok in my environment. -- This is an automated message from the Apache Git Service. To

[GitHub] [hbase] Apache-HBase commented on pull request #4539: HBASE-27028 Add a shell command for flushing master local region

2022-06-15 Thread GitBox
Apache-HBase commented on PR #4539: URL: https://github.com/apache/hbase/pull/4539#issuecomment-1157298236 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 44s | Docke

[GitHub] [hbase] anwebanSalesforce opened a new pull request, #4540: HBASE-18678

2022-06-15 Thread GitBox
anwebanSalesforce opened a new pull request, #4540: URL: https://github.com/apache/hbase/pull/4540 Added 3 new metrics to MetricsMasterProcSource. Created methods in MetricsMasterWrapper to fetch those metrics and expose them through jmx. -- This is an automated message from the Apache Gi

[GitHub] [hbase] Apache-HBase commented on pull request #4540: HBASE-18678

2022-06-16 Thread GitBox
Apache-HBase commented on PR #4540: URL: https://github.com/apache/hbase/pull/4540#issuecomment-1157340980 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 28s | Docker

[GitHub] [hbase] tomscut commented on pull request #4532: HBASE-27117 Update the method comments for RegionServerAccounting

2022-06-16 Thread GitBox
tomscut commented on PR #4532: URL: https://github.com/apache/hbase/pull/4532#issuecomment-1157344178 Thanks @virajjasani for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [hbase] tomscut commented on pull request #4499: HBASE-27098 Fix link for field comments

2022-06-16 Thread GitBox
tomscut commented on PR #4499: URL: https://github.com/apache/hbase/pull/4499#issuecomment-1157344651 Hi @apurtell , please take a look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [hbase] Apache-HBase commented on pull request #4533: HBASE-25922 - Disabled sanity checks ignored on snapshot restore

2022-06-16 Thread GitBox
Apache-HBase commented on PR #4533: URL: https://github.com/apache/hbase/pull/4533#issuecomment-1157434714 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 18s | Docke

[GitHub] [hbase-operator-tools] wchevreuil commented on pull request #107: HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587

2022-06-16 Thread GitBox
wchevreuil commented on PR #107: URL: https://github.com/apache/hbase-operator-tools/pull/107#issuecomment-1157446423 > Mind explaining a bit on what is the problem here? After skimming the PR, I can not fully understand what is the problem we are trying to fix here... HBCK2 _replica

[GitHub] [hbase-operator-tools] ndimiduk commented on pull request #107: HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587

2022-06-16 Thread GitBox
ndimiduk commented on PR #107: URL: https://github.com/apache/hbase-operator-tools/pull/107#issuecomment-1157493844 FYI @clarax -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [hbase] Apache-HBase commented on pull request #4540: HBASE-18678

2022-06-16 Thread GitBox
Apache-HBase commented on PR #4540: URL: https://github.com/apache/hbase/pull/4540#issuecomment-1157510275 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docke

[GitHub] [hbase-operator-tools] wchevreuil commented on a diff in pull request #107: HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587

2022-06-16 Thread GitBox
wchevreuil commented on code in PR #107: URL: https://github.com/apache/hbase-operator-tools/pull/107#discussion_r898949264 ## hbase-hbck2/pom.xml: ## @@ -171,16 +171,19 @@ org.apache.logging.log4j log4j-api ${log4j2.version} + provided Review C

[GitHub] [hbase-operator-tools] wchevreuil commented on a diff in pull request #107: HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587

2022-06-16 Thread GitBox
wchevreuil commented on code in PR #107: URL: https://github.com/apache/hbase-operator-tools/pull/107#discussion_r898949264 ## hbase-hbck2/pom.xml: ## @@ -171,16 +171,19 @@ org.apache.logging.log4j log4j-api ${log4j2.version} + provided Review C

[GitHub] [hbase] Apache-HBase commented on pull request #4541: HBASE-27125 The batch size of cleaning expired mob files should have an upper bound

2022-06-16 Thread GitBox
Apache-HBase commented on PR #4541: URL: https://github.com/apache/hbase/pull/4541#issuecomment-1157522130 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4540: HBASE-18678

2022-06-16 Thread GitBox
Apache-HBase commented on PR #4540: URL: https://github.com/apache/hbase/pull/4540#issuecomment-1157523298 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 20s | Docker

[GitHub] [hbase-operator-tools] petersomogyi merged pull request #106: HBASE-26934: Publish code coverage reports to SonarQube

2022-06-16 Thread GitBox
petersomogyi merged PR #106: URL: https://github.com/apache/hbase-operator-tools/pull/106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-06-16 Thread GitBox
bbeaudreault commented on code in PR #4125: URL: https://github.com/apache/hbase/pull/4125#discussion_r898997275 ## hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java: ## @@ -181,4 +204,80 @@ public int getNumOpenConnections() { // allChannels also c

[GitHub] [hbase-operator-tools] dependabot[bot] opened a new pull request, #108: Bump checkstyle from 8.18 to 8.29

2022-06-16 Thread GitBox
dependabot[bot] opened a new pull request, #108: URL: https://github.com/apache/hbase-operator-tools/pull/108 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.18 to 8.29. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases";>checkstyle's

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #108: Bump checkstyle from 8.18 to 8.29

2022-06-16 Thread GitBox
Apache-HBase commented on PR #108: URL: https://github.com/apache/hbase-operator-tools/pull/108#issuecomment-1157585966 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0

[GitHub] [hbase] Apache-HBase commented on pull request #4533: HBASE-25922 - Disabled sanity checks ignored on snapshot restore

2022-06-16 Thread GitBox
Apache-HBase commented on PR #4533: URL: https://github.com/apache/hbase/pull/4533#issuecomment-1157595361 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #4533: HBASE-25922 - Disabled sanity checks ignored on snapshot restore

2022-06-16 Thread GitBox
Apache-HBase commented on PR #4533: URL: https://github.com/apache/hbase/pull/4533#issuecomment-1157606884 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s | Docker

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-06-16 Thread GitBox
bbeaudreault commented on code in PR #4125: URL: https://github.com/apache/hbase/pull/4125#discussion_r899039496 ## hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java: ## @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-06-16 Thread GitBox
bbeaudreault commented on code in PR #4125: URL: https://github.com/apache/hbase/pull/4125#discussion_r899041119 ## hbase-client/src/test/java/org/apache/hadoop/hbase/ipc/TestNettyRpcConnection.java: ## @@ -67,6 +68,7 @@ public static void tearDown() throws IOException { Cl

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-06-16 Thread GitBox
bbeaudreault commented on code in PR #4125: URL: https://github.com/apache/hbase/pull/4125#discussion_r899044758 ## hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java: ## @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-06-16 Thread GitBox
bbeaudreault commented on code in PR #4125: URL: https://github.com/apache/hbase/pull/4125#discussion_r891179372 ## hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java: ## @@ -216,11 +224,16 @@ private void saslNegotiate(final Channel ch) { fail

[GitHub] [hbase] Apache-HBase commented on pull request #4533: HBASE-25922 - Disabled sanity checks ignored on snapshot restore

2022-06-16 Thread GitBox
Apache-HBase commented on PR #4533: URL: https://github.com/apache/hbase/pull/4533#issuecomment-1157638569 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docke

[GitHub] [hbase-operator-tools] Apache9 commented on a diff in pull request #107: HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587

2022-06-16 Thread GitBox
Apache9 commented on code in PR #107: URL: https://github.com/apache/hbase-operator-tools/pull/107#discussion_r899064897 ## hbase-hbck2/pom.xml: ## @@ -171,16 +171,19 @@ org.apache.logging.log4j log4j-api ${log4j2.version} + provided Review Comm

[GitHub] [hbase-operator-tools] Apache9 commented on a diff in pull request #107: HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587

2022-06-16 Thread GitBox
Apache9 commented on code in PR #107: URL: https://github.com/apache/hbase-operator-tools/pull/107#discussion_r899076432 ## hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java: ## @@ -1330,19 +1334,44 @@ private List stringArrayToList(String... nameSpaceOrTable) { * @par

[GitHub] [hbase] Apache-HBase commented on pull request #4541: HBASE-27125 The batch size of cleaning expired mob files should have an upper bound

2022-06-16 Thread GitBox
Apache-HBase commented on PR #4541: URL: https://github.com/apache/hbase/pull/4541#issuecomment-1157681588 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4541: HBASE-27125 The batch size of cleaning expired mob files should have an upper bound

2022-06-16 Thread GitBox
Apache-HBase commented on PR #4541: URL: https://github.com/apache/hbase/pull/4541#issuecomment-1157693788 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 19s | Docke

[GitHub] [hbase-operator-tools] wchevreuil commented on a diff in pull request #107: HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587

2022-06-16 Thread GitBox
wchevreuil commented on code in PR #107: URL: https://github.com/apache/hbase-operator-tools/pull/107#discussion_r899135897 ## hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java: ## @@ -1330,19 +1334,44 @@ private List stringArrayToList(String... nameSpaceOrTable) { * @

[GitHub] [hbase-operator-tools] wchevreuil commented on pull request #107: HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587

2022-06-16 Thread GitBox
wchevreuil commented on PR #107: URL: https://github.com/apache/hbase-operator-tools/pull/107#issuecomment-1157731666 > OK, I can partly know what is the problem now, but the whole implementation seems a mess to me... > I'm happy to answer any questions you might still have. If you f

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #107: HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587

2022-06-16 Thread GitBox
Apache-HBase commented on PR #107: URL: https://github.com/apache/hbase-operator-tools/pull/107#issuecomment-1157733733 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0

[GitHub] [hbase-filesystem] steveloughran commented on pull request #30: HBASE-26483. [HBOSS] add support for openFile(path)

2022-06-16 Thread GitBox
steveloughran commented on PR #30: URL: https://github.com/apache/hbase-filesystem/pull/30#issuecomment-1157738627 thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [hbase-operator-tools] wchevreuil commented on a diff in pull request #107: HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587

2022-06-16 Thread GitBox
wchevreuil commented on code in PR #107: URL: https://github.com/apache/hbase-operator-tools/pull/107#discussion_r899167670 ## hbase-hbck2/pom.xml: ## @@ -171,16 +171,19 @@ org.apache.logging.log4j log4j-api ${log4j2.version} + provided Review C

[GitHub] [hbase-operator-tools] wchevreuil commented on a diff in pull request #107: HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587

2022-06-16 Thread GitBox
wchevreuil commented on code in PR #107: URL: https://github.com/apache/hbase-operator-tools/pull/107#discussion_r899167670 ## hbase-hbck2/pom.xml: ## @@ -171,16 +171,19 @@ org.apache.logging.log4j log4j-api ${log4j2.version} + provided Review C

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #107: HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587

2022-06-16 Thread GitBox
Apache-HBase commented on PR #107: URL: https://github.com/apache/hbase-operator-tools/pull/107#issuecomment-1157755593 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0

[GitHub] [hbase] Apache9 opened a new pull request, #4542: HBASE-26095 Modify our ref guide to mention the deprecation of HBTU a…

2022-06-16 Thread GitBox
Apache9 opened a new pull request, #4542: URL: https://github.com/apache/hbase/pull/4542 …nd also how to make use of the new TestingHBaseCluster -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [hbase] Apache9 commented on a diff in pull request #4541: HBASE-27125 The batch size of cleaning expired mob files should have an upper bound

2022-06-16 Thread GitBox
Apache9 commented on code in PR #4541: URL: https://github.com/apache/hbase/pull/4541#discussion_r899197367 ## hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobUtils.java: ## @@ -314,20 +316,24 @@ public static void cleanExpiredMobFiles(FileSystem fs, Configuration con

[GitHub] [hbase] shahrs87 commented on pull request #4486: HBASE-27085 Create REPLICATION_SINK_TRACKER table to persist marker rows coming from source cluster

2022-06-16 Thread GitBox
shahrs87 commented on PR #4486: URL: https://github.com/apache/hbase/pull/4486#issuecomment-1157814949 Thank you @virajjasani for the review feedback. Addressed couple of comments in the latest patch. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] Apache-HBase commented on pull request #4533: HBASE-25922 - Disabled sanity checks ignored on snapshot restore

2022-06-16 Thread GitBox
Apache-HBase commented on PR #4533: URL: https://github.com/apache/hbase/pull/4533#issuecomment-1157842986 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-06-16 Thread GitBox
bbeaudreault commented on code in PR #4125: URL: https://github.com/apache/hbase/pull/4125#discussion_r899258889 ## hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java: ## @@ -342,14 +366,74 @@ public void operationComplete(ChannelFuture future) throw

[GitHub] [hbase] Apache-HBase commented on pull request #4533: HBASE-25922 - Disabled sanity checks ignored on snapshot restore

2022-06-16 Thread GitBox
Apache-HBase commented on PR #4533: URL: https://github.com/apache/hbase/pull/4533#issuecomment-1157865971 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #4486: HBASE-27085 Create REPLICATION_SINK_TRACKER table to persist marker rows coming from source cluster

2022-06-16 Thread GitBox
Apache-HBase commented on PR #4486: URL: https://github.com/apache/hbase/pull/4486#issuecomment-1157880931 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #4542: HBASE-26095 Modify our ref guide to mention the deprecation of HBTU a…

2022-06-16 Thread GitBox
Apache-HBase commented on PR #4542: URL: https://github.com/apache/hbase/pull/4542#issuecomment-1157881674 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4542: HBASE-26095 Modify our ref guide to mention the deprecation of HBTU a…

2022-06-16 Thread GitBox
Apache-HBase commented on PR #4542: URL: https://github.com/apache/hbase/pull/4542#issuecomment-1157882712 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4542: HBASE-26095 Modify our ref guide to mention the deprecation of HBTU a…

2022-06-16 Thread GitBox
Apache-HBase commented on PR #4542: URL: https://github.com/apache/hbase/pull/4542#issuecomment-1157896964 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 18s | Docke

[GitHub] [hbase-operator-tools] clarax commented on a diff in pull request #107: HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587

2022-06-16 Thread GitBox
clarax commented on code in PR #107: URL: https://github.com/apache/hbase-operator-tools/pull/107#discussion_r899354610 ## hbase-hbck2/README.md: ## @@ -102,7 +102,6 @@ Options: Command: addFsRegionsMissingInMeta ...|-i ... Options: --d,--force_disable aborts fix fo

[GitHub] [hbase-operator-tools] clarax opened a new pull request, #109: HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587

2022-06-16 Thread GitBox
clarax opened a new pull request, #109: URL: https://github.com/apache/hbase-operator-tools/pull/109 For review only. This is an alternative implementation of fix to https://github.com/apache/hbase-operator-tools/pull/107 -- This is an automated message from the Apache Git Service. To res

[GitHub] [hbase-operator-tools] clarax commented on pull request #107: HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587

2022-06-16 Thread GitBox
clarax commented on PR #107: URL: https://github.com/apache/hbase-operator-tools/pull/107#issuecomment-1158034440 Thanks a lot for adding the comprehensive UT. Please see an alternative fix that follows the same pattern for other commands with command options. https://github.com/apache/hba

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #109: HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587

2022-06-16 Thread GitBox
Apache-HBase commented on PR #109: URL: https://github.com/apache/hbase-operator-tools/pull/109#issuecomment-1158051955 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #4486: HBASE-27085 Create REPLICATION_SINK_TRACKER table to persist marker rows coming from source cluster

2022-06-16 Thread GitBox
Apache-HBase commented on PR #4486: URL: https://github.com/apache/hbase/pull/4486#issuecomment-1158057414 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4486: HBASE-27085 Create REPLICATION_SINK_TRACKER table to persist marker rows coming from source cluster

2022-06-16 Thread GitBox
Apache-HBase commented on PR #4486: URL: https://github.com/apache/hbase/pull/4486#issuecomment-1158070874 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s | Docker

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #109: HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587

2022-06-16 Thread GitBox
Apache-HBase commented on PR #109: URL: https://github.com/apache/hbase-operator-tools/pull/109#issuecomment-1158097882 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4486: HBASE-27085 Create REPLICATION_SINK_TRACKER table to persist marker rows coming from source cluster

2022-06-16 Thread GitBox
Apache-HBase commented on PR #4486: URL: https://github.com/apache/hbase/pull/4486#issuecomment-1158102040 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docke

[GitHub] [hbase] virajjasani commented on pull request #4486: HBASE-27085 Create REPLICATION_SINK_TRACKER table to persist marker rows coming from source cluster

2022-06-16 Thread GitBox
virajjasani commented on PR #4486: URL: https://github.com/apache/hbase/pull/4486#issuecomment-1158119157 I think this is good to go soon as positive QA results are posted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [hbase] virajjasani merged pull request #4504: HBASE-27100 Add documentation for Replication Observability Framework in hbase book.

2022-06-16 Thread GitBox
virajjasani merged PR #4504: URL: https://github.com/apache/hbase/pull/4504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apa

[GitHub] [hbase-operator-tools] clarax commented on pull request #109: HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587

2022-06-16 Thread GitBox
clarax commented on PR #109: URL: https://github.com/apache/hbase-operator-tools/pull/109#issuecomment-1158192498 Yes, I preferred that implementation for cleaner code. But I moved away to make it commands specific options per feedback on user experience. I see your point and can mov

[GitHub] [hbase] shahrs87 commented on pull request #4486: HBASE-27085 Create REPLICATION_SINK_TRACKER table to persist marker rows coming from source cluster

2022-06-16 Thread GitBox
shahrs87 commented on PR #4486: URL: https://github.com/apache/hbase/pull/4486#issuecomment-1158238032 The failed test succeeds locally ``` [INFO] --- maven-surefire-plugin:3.0.0-M6:test (default-test) @ hbase-server --- [INFO] Using configured provider org.apache.maven.surefire.ju

[GitHub] [hbase-operator-tools] clarax commented on pull request #107: HBASE-27119 [HBCK2] Some commands are broken after HBASE-24587

2022-06-16 Thread GitBox
clarax commented on PR #107: URL: https://github.com/apache/hbase-operator-tools/pull/107#issuecomment-1158251680 LGTM. See conversation at https://github.com/apache/hbase-operator-tools/pull/109. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [hbase] Apache-HBase commented on pull request #4486: HBASE-27085 Create REPLICATION_SINK_TRACKER table to persist marker rows coming from source cluster

2022-06-16 Thread GitBox
Apache-HBase commented on PR #4486: URL: https://github.com/apache/hbase/pull/4486#issuecomment-1158266653 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4486: HBASE-27085 Create REPLICATION_SINK_TRACKER table to persist marker rows coming from source cluster

2022-06-16 Thread GitBox
Apache-HBase commented on PR #4486: URL: https://github.com/apache/hbase/pull/4486#issuecomment-1158280011 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s | Docke

  1   2   3   4   5   6   7   8   9   10   >