[jira] [Updated] (HBASE-15881) Allow BZIP2 compression

2016-06-03 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-15881: -- Fix Version/s: 1.4.0 > Allow BZIP2 compression > --- > >

[jira] [Commented] (HBASE-15881) Allow BZIP2 compression

2016-06-03 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314842#comment-15314842 ] Lars Hofhansl commented on HBASE-15881: --- I'll make it so: 0.98, branch-1.3, branch-1, and master (I

[jira] [Updated] (HBASE-15881) Allow BZIP2 compression

2016-06-03 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-15881: -- Fix Version/s: (was: 1.1.6) (was: 1.2.2)

[jira] [Commented] (HBASE-15881) Allow BZIP2 compression

2016-06-03 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314377#comment-15314377 ] Lars Hofhansl commented on HBASE-15881: --- [~busbey], [~ndimiduk]? Since this is an absolutely

[jira] [Commented] (HBASE-15881) Allow BZIP2 compression

2016-06-02 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312907#comment-15312907 ] Lars Hofhansl commented on HBASE-15881: --- Committed to master. I was going to put this into all

[jira] [Updated] (HBASE-15881) Allow BZIP2 compression

2016-06-02 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-15881: -- Fix Version/s: 0.98.21 1.3.1 1.1.6

[jira] [Assigned] (HBASE-15881) Allow BZIP2 compression

2016-06-02 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl reassigned HBASE-15881: - Assignee: Lars Hofhansl > Allow BZIP2 compression > --- > >

[jira] [Commented] (HBASE-15881) Allow BZIP2 compression

2016-06-02 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312786#comment-15312786 ] Lars Hofhansl commented on HBASE-15881: --- Thanks for looking guys... I'll commit this today. >

[jira] [Commented] (HBASE-15881) Allow BZIP2 compression

2016-05-23 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297143#comment-15297143 ] Lars Hofhansl commented on HBASE-15881: --- Of course we need to keep concerns such as voice in

[jira] [Updated] (HBASE-15881) Allow BZIP2 compression

2016-05-23 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-15881: -- Attachment: 15881-0.98.txt Trivial patch against 0.98. Will make a trunk patch now. > Allow

[jira] [Created] (HBASE-15881) Allow BZIP2 compression

2016-05-23 Thread Lars Hofhansl (JIRA)
Lars Hofhansl created HBASE-15881: - Summary: Allow BZIP2 compression Key: HBASE-15881 URL: https://issues.apache.org/jira/browse/HBASE-15881 Project: HBase Issue Type: Bug

[jira] [Commented] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization costs

2016-04-27 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260531#comment-15260531 ] Lars Hofhansl commented on HBASE-15716: --- +1 on the earlier patch that just removed the extraneous

[jira] [Commented] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization costs

2016-04-27 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260518#comment-15260518 ] Lars Hofhansl commented on HBASE-15716: --- Yeah, I think that should work. Was thinking about the

[jira] [Commented] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization costs

2016-04-26 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15259354#comment-15259354 ] Lars Hofhansl commented on HBASE-15716: --- How do you know it works? :) > HRegion#RegionScannerImpl

[jira] [Commented] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization costs

2016-04-26 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15259350#comment-15259350 ] Lars Hofhansl commented on HBASE-15716: --- Hmm... As is we need the synchronized I think. Off-hand I

[jira] [Commented] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization costs

2016-04-26 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15259271#comment-15259271 ] Lars Hofhansl commented on HBASE-15716: --- Looking now. > HRegion#RegionScannerImpl

[jira] [Commented] (HBASE-12148) Remove TimeRangeTracker as point of contention when many threads writing a Store

2016-04-13 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15240108#comment-15240108 ] Lars Hofhansl commented on HBASE-12148: --- Seems reply above. I think there is some more discussion

[jira] [Commented] (HBASE-12148) Remove TimeRangeTracker as point of contention when many threads writing a Store

2016-04-13 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15240106#comment-15240106 ] Lars Hofhansl commented on HBASE-12148: --- I still don't get what the problem is. There could be two

[jira] [Commented] (HBASE-7912) HBase Backup/Restore Based on HBase Snapshot

2016-04-03 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15223137#comment-15223137 ] Lars Hofhansl commented on HBASE-7912: -- Pardon my ignorance here, but can somebody briefly explain

[jira] [Commented] (HBASE-15506) FSDataOutputStream.write() allocates new byte buffer on each operation

2016-03-30 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219340#comment-15219340 ] Lars Hofhansl commented on HBASE-15506: --- nginx is implemented in C/C++. We can easily find about as

[jira] [Comment Edited] (HBASE-15506) FSDataOutputStream.write() allocates new byte buffer on each operation

2016-03-29 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217374#comment-15217374 ] Lars Hofhansl edited comment on HBASE-15506 at 3/30/16 4:51 AM: My point

[jira] [Commented] (HBASE-15506) FSDataOutputStream.write() allocates new byte buffer on each operation

2016-03-29 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217374#comment-15217374 ] Lars Hofhansl commented on HBASE-15506: --- My point is that that's a problem as such. That's how Java

[jira] [Commented] (HBASE-15506) FSDataOutputStream.write() allocates new byte buffer on each operation

2016-03-28 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15213853#comment-15213853 ] Lars Hofhansl commented on HBASE-15506: --- Let's be careful, please. Many times when one tries to be

[jira] [Commented] (HBASE-14613) Remove MemStoreChunkPool?

2016-03-26 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212845#comment-15212845 ] Lars Hofhansl commented on HBASE-14613: --- Didn't think my musing about G1 and MSLAB would lead to a

[jira] [Commented] (HBASE-14613) Remove MemStoreChunkPool?

2016-03-26 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212846#comment-15212846 ] Lars Hofhansl commented on HBASE-14613: --- [~apurtell], [~vik.karma], maybe we should redo our G1

[jira] [Commented] (HBASE-15453) [Performance] Considering reverting HBASE-10015 - reinstate synchronized in StoreScanner

2016-03-23 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208984#comment-15208984 ] Lars Hofhansl commented on HBASE-15453: --- So what do we do here? I'll do one more test later... See

[jira] [Commented] (HBASE-12148) Remove TimeRangeTracker as point of contention when many threads writing a Store

2016-03-23 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208954#comment-15208954 ] Lars Hofhansl commented on HBASE-12148: --- So what do we do here?! > Remove TimeRangeTracker as

[jira] [Commented] (HBASE-14613) Remove MemStoreChunkPool?

2016-03-22 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207901#comment-15207901 ] Lars Hofhansl commented on HBASE-14613: --- [~vik.karma], FYI. Interesting bit here about disabling

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-22 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207842#comment-15207842 ] Lars Hofhansl commented on HBASE-15392: --- Yep. > Single Cell Get reads two HFileBlocks >

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-22 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207841#comment-15207841 ] Lars Hofhansl commented on HBASE-15392: --- -v8 is something different. Gigantic 311KB patch. Wrong

[jira] [Commented] (HBASE-14613) Remove MemStoreChunkPool?

2016-03-22 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207757#comment-15207757 ] Lars Hofhansl commented on HBASE-14613: --- Not sure what you are referring to. SLAB making more

[jira] [Commented] (HBASE-12148) Remove TimeRangeTracker as point of contention when many threads writing a Store

2016-03-21 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204915#comment-15204915 ] Lars Hofhansl commented on HBASE-12148: --- If this read load you're applying? Or mixed read-write

[jira] [Commented] (HBASE-12148) Remove TimeRangeTracker as point of contention when many threads writing a Store

2016-03-19 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200977#comment-15200977 ] Lars Hofhansl commented on HBASE-12148: --- Do we see actual contention, as in threads waiting for

[jira] [Commented] (HBASE-12148) Remove TimeRangeTracker as point of contention when many threads writing a Store

2016-03-19 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201088#comment-15201088 ] Lars Hofhansl commented on HBASE-12148: --- I see. So this is at _read_ time from a StoreFile. Is that

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-19 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203085#comment-15203085 ] Lars Hofhansl commented on HBASE-15392: --- [~stack], let's also change the compare condition to >

[jira] [Commented] (HBASE-15479) No more garbage or beware of autoboxing

2016-03-19 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203016#comment-15203016 ] Lars Hofhansl commented on HBASE-15479: --- Ahh... The call is not in the patch but the parameter

[jira] [Commented] (HBASE-15479) No more garbage or beware of autoboxing

2016-03-19 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202988#comment-15202988 ] Lars Hofhansl commented on HBASE-15479: --- Is -v2 complete? I see the signature change for

[jira] [Commented] (HBASE-15452) Consider removing checkScanOrder from StoreScanner.next

2016-03-19 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197603#comment-15197603 ] Lars Hofhansl commented on HBASE-15452: --- Assertion were enabled in all cases. > Consider removing

[jira] [Commented] (HBASE-8458) Support for batch version of checkAndPut() and checkAndDelete()

2016-03-19 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198531#comment-15198531 ] Lars Hofhansl commented on HBASE-8458: -- [~ekundin] which version of HBase are you using. I do agree

[jira] [Updated] (HBASE-15453) [Performance] Considering reverting HBASE-10015 - reinstate synchronized in StoreScanner

2016-03-14 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-15453: -- Summary: [Performance] Considering reverting HBASE-10015 - reinstate synchronized in

[jira] [Commented] (HBASE-15453) [Performance] Considering reverting HBASE-10015 - reinstance synchronized in StoreScanner

2016-03-14 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15194725#comment-15194725 ] Lars Hofhansl commented on HBASE-15453: --- For a Phoenix count\(*) query on the JDK8 machine I

[jira] [Resolved] (HBASE-15452) Consider removing checkScanOrder from StoreScanner.next

2016-03-14 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl resolved HBASE-15452. --- Resolution: Invalid NM... I'm full of @#%^ > Consider removing checkScanOrder from

[jira] [Commented] (HBASE-15453) [Performance] Considering reverting HBASE-10015 - reinstance synchronized in StoreScanner

2016-03-14 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15194697#comment-15194697 ] Lars Hofhansl commented on HBASE-15453: --- Note that HBASE-10015 in had many folks confirm the

[jira] [Commented] (HBASE-15452) Consider removing checkScanOrder from StoreScanner.next

2016-03-14 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15193773#comment-15193773 ] Lars Hofhansl commented on HBASE-15452: --- Wait... We're running the tests with assertions enabled,

[jira] [Commented] (HBASE-15452) Consider removing checkScanOrder from StoreScanner.next

2016-03-14 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15193712#comment-15193712 ] Lars Hofhansl commented on HBASE-15452: --- This patch together with HBASE-15453 (JDK8) 10 runs

[jira] [Commented] (HBASE-15453) Considering reverting HBASE-10015 - reinstance synchronized in StoreScanner

2016-03-14 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15193701#comment-15193701 ] Lars Hofhansl commented on HBASE-15453: --- What's the best way to just commit the perf test? I want

[jira] [Commented] (HBASE-15452) Consider removing checkScanOrder from StoreScanner.next

2016-03-14 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15193690#comment-15193690 ] Lars Hofhansl commented on HBASE-15452: --- Two runs with patch applied (test from HBASE-15453) 10

[jira] [Updated] (HBASE-15452) Consider removing checkScanOrder from StoreScanner.next

2016-03-14 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-15452: -- Attachment: 15452-0.98.txt Oops. Here it is. Trivial. > Consider removing checkScanOrder from

[jira] [Commented] (HBASE-15453) Considering reverting HBASE-10015 - reinstance synchronized in StoreScanner

2016-03-13 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192726#comment-15192726 ] Lars Hofhansl commented on HBASE-15453: --- Work machine (OpenJDK Runtime Environment (IcedTea 2.6.4)

[jira] [Updated] (HBASE-15453) Considering reverting HBASE-10015 - reinstance synchronized in StoreScanner

2016-03-13 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-15453: -- Description: In HBASE-10015 back then I found that intrinsic locks (synchronized) in

[jira] [Commented] (HBASE-15453) Considering reverting HBASE-10015 - reinstance synchronized in StoreScanner

2016-03-13 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192562#comment-15192562 ] Lars Hofhansl commented on HBASE-15453: --- Another 4 runs: Intrinsic: 10 runs mean:1918.1

[jira] [Updated] (HBASE-15453) Considering reverting HBASE-10015 - reinstance synchronized in StoreScanner

2016-03-13 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-15453: -- Attachment: 15453-0.98.txt Here's the patch with test. [~apurtell], [~stack], and anybody

[jira] [Created] (HBASE-15453) Considering reverting HBASE-10015 - reinstance synchronized in StoreScanner

2016-03-13 Thread Lars Hofhansl (JIRA)
Lars Hofhansl created HBASE-15453: - Summary: Considering reverting HBASE-10015 - reinstance synchronized in StoreScanner Key: HBASE-15453 URL: https://issues.apache.org/jira/browse/HBASE-15453

[jira] [Updated] (HBASE-15452) Consider removing checkScanOrder from StoreScanner.next

2016-03-13 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-15452: -- Attachment: (was: 15452-0.98.txt) > Consider removing checkScanOrder from

[jira] [Updated] (HBASE-15452) Consider removing checkScanOrder from StoreScanner.next

2016-03-13 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-15452: -- Attachment: 15452-0.98.txt Patch... Just to park it. Simply removes the cruft. Note that if we

[jira] [Created] (HBASE-15452) Consider removing checkScanOrder from StoreScanner.next

2016-03-13 Thread Lars Hofhansl (JIRA)
Lars Hofhansl created HBASE-15452: - Summary: Consider removing checkScanOrder from StoreScanner.next Key: HBASE-15452 URL: https://issues.apache.org/jira/browse/HBASE-15452 Project: HBase

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-12 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192000#comment-15192000 ] Lars Hofhansl commented on HBASE-15392: --- +1 on -v6. Minor spelling nit in comment: {{It does this

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-12 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191993#comment-15191993 ] Lars Hofhansl commented on HBASE-15392: --- bq. You are not referring to anything in the patch,

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-12 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191834#comment-15191834 ] Lars Hofhansl commented on HBASE-15392: --- -v5 looks good. The comment is too long. :) After a while

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-12 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191791#comment-15191791 ] Lars Hofhansl commented on HBASE-15392: --- Here's the comment that we can add to optimize: {code}

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-10 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190540#comment-15190540 ] Lars Hofhansl commented on HBASE-15392: --- It's because we're comparing against what would be the key

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-10 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190537#comment-15190537 ] Lars Hofhansl commented on HBASE-15392: --- bq. compare the row part only Alas won't work either,

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-10 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190509#comment-15190509 ] Lars Hofhansl commented on HBASE-15392: --- So here's another idea: # we leave the SEEK_TO_COL stuff

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-10 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190505#comment-15190505 ] Lars Hofhansl commented on HBASE-15392: --- Right, it's a heuristic. I'm open for better ideas as to

[jira] [Comment Edited] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-10 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189752#comment-15189752 ] Lars Hofhansl edited comment on HBASE-15392 at 3/10/16 7:16 PM: Yep.

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-10 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189775#comment-15189775 ] Lars Hofhansl commented on HBASE-15392: --- bq. Coming back to reading the whole row. Could we look

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-10 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189752#comment-15189752 ] Lars Hofhansl commented on HBASE-15392: --- Yep. Sorry, I've in this code so much and that this is

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-10 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189755#comment-15189755 ] Lars Hofhansl commented on HBASE-15392: --- Sorry... I'm known for reading the whole comment before

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-10 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189687#comment-15189687 ] Lars Hofhansl commented on HBASE-15392: --- bq. Yes. All cells corresponding to a row are together in

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-10 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189685#comment-15189685 ] Lars Hofhansl commented on HBASE-15392: --- bq. We check rows in both and they are same. So the return

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-10 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189542#comment-15189542 ] Lars Hofhansl commented on HBASE-15392: --- # rows can straddle block boundaries # versions of column

[jira] [Commented] (HBASE-15431) A bunch of methods are hot and too big to be inlined

2016-03-09 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188823#comment-15188823 ] Lars Hofhansl commented on HBASE-15431: --- bq. Was 1010 enough to get the list of methods inlined?

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-09 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188816#comment-15188816 ] Lars Hofhansl commented on HBASE-15392: --- (Maybe it's time to look at HBASE-11811. I started that,

[jira] [Comment Edited] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-09 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188810#comment-15188810 ] Lars Hofhansl edited comment on HBASE-15392 at 3/10/16 7:03 AM: We're

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-09 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188810#comment-15188810 ] Lars Hofhansl commented on HBASE-15392: --- We're optimizing the wrong thing here. Let's fix it for

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-09 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188427#comment-15188427 ] Lars Hofhansl commented on HBASE-15392: --- Lemme try to answer. There seems to be a bunch of

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-09 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188405#comment-15188405 ] Lars Hofhansl commented on HBASE-15392: --- bq. Optimize seems broke to me. We keep SKIPping even

[jira] [Commented] (HBASE-15431) A bunch of methods are hot and too big to be inlined

2016-03-09 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187468#comment-15187468 ] Lars Hofhansl commented on HBASE-15431: --- [~ram_krish] Yeah... 0.98, sorry. Good catch :) Most

[jira] [Updated] (HBASE-15431) A bunch of methods are hot and too big to be inlined

2016-03-08 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-15431: -- Description: I ran HBase with "-XX:+PrintCompilation -XX:+UnlockDiagnosticVMOptions

[jira] [Commented] (HBASE-15431) A bunch of methods are hot and too big to be inlined

2016-03-08 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186345#comment-15186345 ] Lars Hofhansl commented on HBASE-15431: --- * KeyValue::createByteArray ... scary > A bunch of

[jira] [Updated] (HBASE-15431) A bunch of methods are hot and too big to be inlined

2016-03-08 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-15431: -- Summary: A bunch of methods are hot and too big to be inlined (was: A bunch of methods are

[jira] [Commented] (HBASE-15431) A bunch of methods are hot and too big to be inline

2016-03-08 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186342#comment-15186342 ] Lars Hofhansl commented on HBASE-15431: --- The load I ran was a Phoenix count\(*) query. Note that

[jira] [Updated] (HBASE-15431) A bunch of methods are hot and too big to be inline

2016-03-08 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-15431: -- Attachment: hotMethods.txt List of hot and big methods. > A bunch of methods are hot and too

[jira] [Created] (HBASE-15431) A bunch of methods are hot and too big to be inline

2016-03-08 Thread Lars Hofhansl (JIRA)
Lars Hofhansl created HBASE-15431: - Summary: A bunch of methods are hot and too big to be inline Key: HBASE-15431 URL: https://issues.apache.org/jira/browse/HBASE-15431 Project: HBase Issue

[jira] [Comment Edited] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-07 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184524#comment-15184524 ] Lars Hofhansl edited comment on HBASE-15392 at 3/8/16 6:40 AM: --- OK I get it

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-07 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184524#comment-15184524 ] Lars Hofhansl commented on HBASE-15392: --- OK I get it now... It's doing the right thing.

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-07 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184448#comment-15184448 ] Lars Hofhansl commented on HBASE-15392: --- Actually here's another thought. What optimize is trying

[jira] [Commented] (HBASE-15389) Write out multiple files when compaction

2016-03-07 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184018#comment-15184018 ] Lars Hofhansl commented on HBASE-15389: --- 3. Is it possible to refactor compactions to make this

[jira] [Commented] (HBASE-15389) Write out multiple files when compaction

2016-03-07 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184006#comment-15184006 ] Lars Hofhansl commented on HBASE-15389: --- [~Apache9] thanks for looking into this. This is awesome.

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-07 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183924#comment-15183924 ] Lars Hofhansl commented on HBASE-15392: --- [~stack], you cool with this man? If so I'll commit to all

[jira] [Comment Edited] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-06 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182684#comment-15182684 ] Lars Hofhansl edited comment on HBASE-15392 at 3/7/16 7:20 AM: --- Thanks

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-06 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182684#comment-15182684 ] Lars Hofhansl commented on HBASE-15392: --- Thanks [~anoop.hbase]... But you left the important part

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-06 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182623#comment-15182623 ] Lars Hofhansl commented on HBASE-15392: --- Thanks for looking... Generally for Scans we should

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-06 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182407#comment-15182407 ] Lars Hofhansl commented on HBASE-15392: --- I also like your suggestion [~anoop.hbase]. Although, I'm

[jira] [Commented] (HBASE-15243) Utilize the lowest seek value when all Filters in MUST_PASS_ONE FilterList return SEEK_NEXT_USING_HINT

2016-03-06 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182376#comment-15182376 ] Lars Hofhansl commented on HBASE-15243: --- Looks good to me. As for the observation above: bq. This

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-06 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182343#comment-15182343 ] Lars Hofhansl commented on HBASE-15392: --- Strike that... It's not slower. In any case. Please let me

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-06 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182342#comment-15182342 ] Lars Hofhansl commented on HBASE-15392: --- Lastly (maybe) how big are the column? I'm testing the

[jira] [Issue Comment Deleted] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-06 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-15392: -- Comment: was deleted (was: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Updated] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-06 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-15392: -- Attachment: 15392-0.98-looksee.txt Hey [~stack], does -looksee fix the problem for you (sorry

[jira] [Commented] (HBASE-15392) Single Cell Get reads two HFileBlocks

2016-03-06 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182325#comment-15182325 ] Lars Hofhansl commented on HBASE-15392: --- Is this part that's no longer executed: {code}

<    2   3   4   5   6   7   8   9   10   11   >