[jira] [Resolved] (HBASE-23306) Add sanity check for Admin#deleteTables and other operations
[ https://issues.apache.org/jira/browse/HBASE-23306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rahul Kesharwani resolved HBASE-23306. -- Resolution: Not A Bug The submitted behavior is working as expected hence marking this issue resolved. > Add sanity check for Admin#deleteTables and other operations > > > Key: HBASE-23306 > URL: https://issues.apache.org/jira/browse/HBASE-23306 > Project: HBase > Issue Type: Bug > Components: Admin >Reporter: Rahul Kesharwani >Priority: Minor > > h3. Description: > After taking a brief observation, It seems to be the following operation > behaves in the opposite manner of what they should be doing in case `null > argument. > *For example:* `Admin#listTables(Pattern)` If its argument is `null` then all > the tables would be returned. Also this very method is being used by rest of > the listed operation like `deleteTables()`, `enableTables()`, > `disableTables()` etc. > h3. Affected operation: > * Admin.listTables(Pattern) > * Admin.listTableNames(Pattern) > * Admin.deleteTables(Pattern) > * Admin.enableTables(Pattern) > * Admin.disableTables(Pattern) > This could be a very rare scenario but I think it should either throw an > exception or behave opposite of what current behavior is. > *If this was not intentional* then I can quickly put together a patch with > precondition check for these operations. > > Note: I tried to look for answers but I was not able to find any relevant > issue/comments hence logging this issue. Feel free to close if this is > intentional behavior. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23306) Add sanity check for Admin#deleteTables and other operations
[ https://issues.apache.org/jira/browse/HBASE-23306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976245#comment-16976245 ] Rahul Kesharwani commented on HBASE-23306: -- Thanks, [~wchevreuil] for explanation and references. I am closing this issue now. > Add sanity check for Admin#deleteTables and other operations > > > Key: HBASE-23306 > URL: https://issues.apache.org/jira/browse/HBASE-23306 > Project: HBase > Issue Type: Bug > Components: Admin >Reporter: Rahul Kesharwani >Priority: Minor > > h3. Description: > After taking a brief observation, It seems to be the following operation > behaves in the opposite manner of what they should be doing in case `null > argument. > *For example:* `Admin#listTables(Pattern)` If its argument is `null` then all > the tables would be returned. Also this very method is being used by rest of > the listed operation like `deleteTables()`, `enableTables()`, > `disableTables()` etc. > h3. Affected operation: > * Admin.listTables(Pattern) > * Admin.listTableNames(Pattern) > * Admin.deleteTables(Pattern) > * Admin.enableTables(Pattern) > * Admin.disableTables(Pattern) > This could be a very rare scenario but I think it should either throw an > exception or behave opposite of what current behavior is. > *If this was not intentional* then I can quickly put together a patch with > precondition check for these operations. > > Note: I tried to look for answers but I was not able to find any relevant > issue/comments hence logging this issue. Feel free to close if this is > intentional behavior. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23306) Add sanity check for Admin#deleteTables and other operations
[ https://issues.apache.org/jira/browse/HBASE-23306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rahul Kesharwani updated HBASE-23306: - Description: h3. Description: After taking a brief observation, It seems to be the following operation behaves in the opposite manner of what they should be doing in case `null argument. *For example:* `Admin#listTables(Pattern)` If its argument is `null` then all the tables would be returned. Also this very method is being used by rest of the listed operation like `deleteTables()`, `enableTables()`, `disableTables()` etc. h3. Affected operation: * Admin.listTables(Pattern) * Admin.listTableNames(Pattern) * Admin.deleteTables(Pattern) * Admin.enableTables(Pattern) * Admin.disableTables(Pattern) This could be a very rare scenario but I think it should either throw an exception or behave opposite of what current behavior is. *If this was not intentional* then I can quickly put together a patch with precondition check for these operations. Note: I tried to look for answers but I was not able to find any relevant issue/comments hence logging this issue. Feel free to close if this is intentional behavior. was: After taking a brief observation, It seems to be the following operation behaves in the opposite manner of what they should be doing in case `null argument. For example, `Admin#listTables(Pattern)` If its argument is `null` then all the tables would be returned. Also this very method is being used by rest of the listed operation like `deleteTables()`, `enableTables()`, `disableTables()` etc. * Admin.listTables(Pattern) * Admin.listTableNames(Pattern) * Admin.deleteTables(Pattern) * Admin.enableTables(Pattern) * Admin.disableTables(Pattern) * Admin.listSnapshots(Pattern) * Admin.deleteSnapshots(Pattern) This could be a very rare scenario but I think it should either throw an exception or behave opposite of what current behavior is. *If this was not intentional* then I can quickly put together a patch with precondition check for these operations. Note: I tried to look for answers but I was not able to find any relevant issue/comments hence logging this issue. Feel free to close if this is intentional behavior. > Add sanity check for Admin#deleteTables and other operations > > > Key: HBASE-23306 > URL: https://issues.apache.org/jira/browse/HBASE-23306 > Project: HBase > Issue Type: Bug > Components: Admin >Reporter: Rahul Kesharwani >Priority: Minor > > h3. Description: > After taking a brief observation, It seems to be the following operation > behaves in the opposite manner of what they should be doing in case `null > argument. > *For example:* `Admin#listTables(Pattern)` If its argument is `null` then all > the tables would be returned. Also this very method is being used by rest of > the listed operation like `deleteTables()`, `enableTables()`, > `disableTables()` etc. > h3. Affected operation: > * Admin.listTables(Pattern) > * Admin.listTableNames(Pattern) > * Admin.deleteTables(Pattern) > * Admin.enableTables(Pattern) > * Admin.disableTables(Pattern) > This could be a very rare scenario but I think it should either throw an > exception or behave opposite of what current behavior is. > *If this was not intentional* then I can quickly put together a patch with > precondition check for these operations. > > Note: I tried to look for answers but I was not able to find any relevant > issue/comments hence logging this issue. Feel free to close if this is > intentional behavior. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23306) Add sanity check for Admin#deleteTables and other operations
Rahul Kesharwani created HBASE-23306: Summary: Add sanity check for Admin#deleteTables and other operations Key: HBASE-23306 URL: https://issues.apache.org/jira/browse/HBASE-23306 Project: HBase Issue Type: Bug Components: Admin Reporter: Rahul Kesharwani After taking a brief observation, It seems to be the following operation behaves in the opposite manner of what they should be doing in case `null argument. For example, `Admin#listTables(Pattern)` If its argument is `null` then all the tables would be returned. Also this very method is being used by rest of the listed operation like `deleteTables()`, `enableTables()`, `disableTables()` etc. * Admin.listTables(Pattern) * Admin.listTableNames(Pattern) * Admin.deleteTables(Pattern) * Admin.enableTables(Pattern) * Admin.disableTables(Pattern) * Admin.listSnapshots(Pattern) * Admin.deleteSnapshots(Pattern) This could be a very rare scenario but I think it should either throw an exception or behave opposite of what current behavior is. *If this was not intentional* then I can quickly put together a patch with precondition check for these operations. Note: I tried to look for answers but I was not able to find any relevant issue/comments hence logging this issue. Feel free to close if this is intentional behavior. -- This message was sent by Atlassian Jira (v8.3.4#803005)
