[jira] [Commented] (HBASE-5193) Use TBoundedThreadPoolServer in HRegionThriftServer

2012-01-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185913#comment-13185913 ] Zhihong Yu commented on HBASE-5193: --- TBoundedThreadPoolServer.java is in TRUNK.

[jira] [Commented] (HBASE-5150) Failure in a thread may not fail a test, clean up log splitting test

2012-01-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185941#comment-13185941 ] Zhihong Yu commented on HBASE-5150: --- Integrated to TRUNK. Thanks for the patch, Jimmy.

[jira] [Commented] (HBASE-5191) Fix compilation error against hadoop 0.23.1

2012-01-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185974#comment-13185974 ] Zhihong Yu commented on HBASE-5191: --- After the dfsCluster.stopDataNode( i ) call, the

[jira] [Commented] (HBASE-3933) Hmaster throw NullPointerException

2012-01-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185991#comment-13185991 ] Zhihong Yu commented on HBASE-3933: --- @Eugene: Have you run all unit tests ? Normally a

[jira] [Commented] (HBASE-3933) Hmaster throw NullPointerException

2012-01-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13186014#comment-13186014 ] Zhihong Yu commented on HBASE-3933: --- verifyMetaTablesAreUp isn't in HMaster under TRUNK.

[jira] [Commented] (HBASE-5195) [Coprocessors] preGet hook does not allow overriding or wrapping filter on incoming Get

2012-01-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13186021#comment-13186021 ] Zhihong Yu commented on HBASE-5195: --- +1 on patch. [Coprocessors]

[jira] [Commented] (HBASE-5149) getConfiguration() implementation is misleading

2012-01-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13186023#comment-13186023 ] Zhihong Yu commented on HBASE-5149: --- One scenario for region servers to have non-uniform

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13186035#comment-13186035 ] Zhihong Yu commented on HBASE-3584: --- +1 if unit tests pass. Nice work, Lars.

[jira] [Commented] (HBASE-5190) Limit the IPC queue size based on calls' payload size

2012-01-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13186043#comment-13186043 ] Zhihong Yu commented on HBASE-5190: --- Can we utilize Cliff Click Counter to reduce

[jira] [Commented] (HBASE-5190) Limit the IPC queue size based on calls' payload size

2012-01-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13186052#comment-13186052 ] Zhihong Yu commented on HBASE-5190: --- {code} - this.priorityCallQueue = new

[jira] [Commented] (HBASE-5155) ServerShutDownHandler And Disable/Delete should not happen parallely leading to recreation of regions that were deleted

2012-01-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13186089#comment-13186089 ] Zhihong Yu commented on HBASE-5155: --- bq. will tell the user like to ZK is used in

[jira] [Commented] (HBASE-5179) Concurrent processing of processFaileOver and ServerShutdownHandler may cause region to be assigned before log splitting is completed, causing data loss

2012-01-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13186108#comment-13186108 ] Zhihong Yu commented on HBASE-5179: --- Should we decouple HBASE-4748 from this issue ?

[jira] [Commented] (HBASE-5179) Concurrent processing of processFaileOver and ServerShutdownHandler may cause region is assigned before completing split log, it would cause data loss

2012-01-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184843#comment-13184843 ] Zhihong Yu commented on HBASE-5179: --- @Ram: I don't see patch attached to hbase-4748.

[jira] [Commented] (HBASE-5179) Concurrent processing of processFaileOver and ServerShutdownHandler may cause region is assigned before completing split log, it would cause data loss

2012-01-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184956#comment-13184956 ] Zhihong Yu commented on HBASE-5179: --- Since Ram is busy with releasing 0.90.6, I think we

[jira] [Commented] (HBASE-5179) Concurrent processing of processFaileOver and ServerShutdownHandler may cause region is assigned before completing split log, it would cause data loss

2012-01-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185075#comment-13185075 ] Zhihong Yu commented on HBASE-5179: --- For Jinchao's patch v3: I think it makes sense. Let

[jira] [Commented] (HBASE-5155) ServerShutDownHandler And Disable/Delete should not happen parallely leading to recreation of regions that were deleted

2012-01-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185095#comment-13185095 ] Zhihong Yu commented on HBASE-5155: --- In AssignmentManager.java, setEnabledTable():

[jira] [Commented] (HBASE-5153) HConnection re-creation in HTable after HConnection abort

2012-01-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185117#comment-13185117 ] Zhihong Yu commented on HBASE-5153: --- For the trunk patch: {code} + * @param actions +

[jira] [Commented] (HBASE-5160) Backport HBASE-4397 - -ROOT-, .META. tables stay offline for too long in recovery phase after all RSs are shutdown at the same time

2012-01-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185142#comment-13185142 ] Zhihong Yu commented on HBASE-5160: --- Patch looks good. Minor comment: {code} +

[jira] [Commented] (HBASE-5184) Backport HBASE-5152 - Region is on service before completing initialization when doing rollback of split, it will affect read correctness

2012-01-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185143#comment-13185143 ] Zhihong Yu commented on HBASE-5184: --- +1 on patch. Backport HBASE-5152

[jira] [Commented] (HBASE-4720) Implement atomic update operations (checkAndPut, checkAndDelete) for REST client/server

2012-01-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185150#comment-13185150 ] Zhihong Yu commented on HBASE-4720: --- @Andrew: Can you take a look at patch v4, please ?

[jira] [Commented] (HBASE-4720) Implement atomic update operations (checkAndPut, checkAndDelete) for REST client/server

2012-01-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185164#comment-13185164 ] Zhihong Yu commented on HBASE-4720: --- Minor comments: {code} + * Validates the input

[jira] [Commented] (HBASE-5174) Coalesce aborted tasks in the TaskMonitor

2012-01-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185175#comment-13185175 ] Zhihong Yu commented on HBASE-5174: --- Considering ABORTED task would be cleaned up in 1

[jira] [Commented] (HBASE-5155) ServerShutDownHandler And Disable/Delete should not happen parallely leading to recreation of regions that were deleted

2012-01-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185201#comment-13185201 ] Zhihong Yu commented on HBASE-5155: --- Test suite passed based on Ram's patch.

[jira] [Commented] (HBASE-5157) Backport HBASE-4880- Region is on service before openRegionHandler completes, may cause data loss

2012-01-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185247#comment-13185247 ] Zhihong Yu commented on HBASE-5157: --- After backing out this patch, TestZooKeeper doesn't

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185251#comment-13185251 ] Zhihong Yu commented on HBASE-3584: --- Putting the patch on review board would make

[jira] [Commented] (HBASE-3584) We need to atomically put/delete/increment in one call

2012-01-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185265#comment-13185265 ] Zhihong Yu commented on HBASE-3584: --- w.r.t. the coprocessor pre hooks, I think option 2

[jira] [Commented] (HBASE-5177) HTable needs a non cached version of getRegionLocation

2012-01-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185270#comment-13185270 ] Zhihong Yu commented on HBASE-5177: --- TRUNK supports this: {code}

[jira] [Commented] (HBASE-5191) Fix compilation error against hadoop 0.23.1

2012-01-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185428#comment-13185428 ] Zhihong Yu commented on HBASE-5191: --- After fixing the compilation error, the test failed

[jira] [Commented] (HBASE-5191) Fix compilation error against hadoop 0.23.1

2012-01-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185430#comment-13185430 ] Zhihong Yu commented on HBASE-5191: --- After getting over NoSuchMethodException, the test

[jira] [Commented] (HBASE-5157) Backport HBASE-4880- Region is on service before openRegionHandler completes, may cause data loss

2012-01-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185443#comment-13185443 ] Zhihong Yu commented on HBASE-5157: --- Backed out the patch from 0.90 - Ramkrishna doesn't

[jira] [Commented] (HBASE-5153) HConnection re-creation in HTable after HConnection abort

2012-01-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185453#comment-13185453 ] Zhihong Yu commented on HBASE-5153: --- +1 on latest patches. HConnection

[jira] [Commented] (HBASE-5153) HConnection re-creation in HTable after HConnection abort

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184092#comment-13184092 ] Zhihong Yu commented on HBASE-5153: --- @Jieshan: Can you prepare a patch for trunk ?

[jira] [Commented] (HBASE-5163) TestLogRolling#testLogRollOnDatanodeDeath fails sometimes on Jenkins or hadoop QA (The directory is already locked.)

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184113#comment-13184113 ] Zhihong Yu commented on HBASE-5163: --- Integrated to TRUNK. Thanks for the patch, N.

[jira] [Commented] (HBASE-5179) Concurrent processing of processFaileOver and ServerShutdownHandler may cause region is assigned before completing split log, it would cause data loss

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184120#comment-13184120 ] Zhihong Yu commented on HBASE-5179: --- {code} + private final SetServerName

[jira] [Commented] (HBASE-5120) Timeout monitor races with table disable handler

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184205#comment-13184205 ] Zhihong Yu commented on HBASE-5120: --- Can you change LOG.debug() to LOG.error() in

[jira] [Commented] (HBASE-5179) Concurrent processing of processFaileOver and ServerShutdownHandler may cause region is assigned before completing split log, it would cause data loss

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184244#comment-13184244 ] Zhihong Yu commented on HBASE-5179: --- I ran the following on MacBook and they passed:

[jira] [Commented] (HBASE-5120) Timeout monitor races with table disable handler

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184251#comment-13184251 ] Zhihong Yu commented on HBASE-5120: --- +1 on patch v5. Timeout monitor

[jira] [Commented] (HBASE-5139) Compute (weighted) median using AggregateProtocol

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184264#comment-13184264 ] Zhihong Yu commented on HBASE-5139: --- I am going to integrate patch v2 if there is no

[jira] [Commented] (HBASE-3565) Add metrics to keep track of slow HLog appends

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184288#comment-13184288 ] Zhihong Yu commented on HBASE-3565: --- Integrated to TRUNK. Thanks for the patch Mubarak.

[jira] [Commented] (HBASE-5179) Concurrent processing of processFaileOver and ServerShutdownHandler may cause region is assigned before completing split log, it would cause data loss

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184296#comment-13184296 ] Zhihong Yu commented on HBASE-5179: --- @Stack: The following code is for 0.90 branch:

[jira] [Commented] (HBASE-5179) Concurrent processing of processFaileOver and ServerShutdownHandler may cause region is assigned before completing split log, it would cause data loss

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184303#comment-13184303 ] Zhihong Yu commented on HBASE-5179: --- TestRollingRestart fails in 0.90 with patch.

[jira] [Commented] (HBASE-5139) Compute (weighted) median using AggregateProtocol

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184320#comment-13184320 ] Zhihong Yu commented on HBASE-5139: --- Integrated to TRUNK. Compute

[jira] [Commented] (HBASE-5136) Redundant MonitoredTask instances in case of distributed log splitting retry

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184377#comment-13184377 ] Zhihong Yu commented on HBASE-5136: --- Can someone review the patch ? Thanks

[jira] [Commented] (HBASE-5179) Concurrent processing of processFaileOver and ServerShutdownHandler may cause region is assigned before completing split log, it would cause data loss

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184448#comment-13184448 ] Zhihong Yu commented on HBASE-5179: --- I think the reason Chunhui introduced a new Set for

[jira] [Commented] (HBASE-5182) TBoundedThreadPoolServer threadKeepAliveTimeSec is not configured properly

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184474#comment-13184474 ] Zhihong Yu commented on HBASE-5182: --- +1 on patch.

[jira] [Commented] (HBASE-5181) Improve error message when Master fail-over happens and ZK unassigned node contains stale znode(s)

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184472#comment-13184472 ] Zhihong Yu commented on HBASE-5181: --- Thanks for the suggestion, Mubarak. Do you want to

[jira] [Commented] (HBASE-5136) Redundant MonitoredTask instances in case of distributed log splitting retry

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184507#comment-13184507 ] Zhihong Yu commented on HBASE-5136: --- Then this JIRA depends on HBASE-5174. Please

[jira] [Commented] (HBASE-5174) Coalesce aborted tasks in the TaskMonitor

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184547#comment-13184547 ] Zhihong Yu commented on HBASE-5174: --- Looks like I didn't take State of MonitoredTask

[jira] [Commented] (HBASE-5181) Improve error message when Master fail-over happens and ZK unassigned node contains stale znode(s)

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184551#comment-13184551 ] Zhihong Yu commented on HBASE-5181: --- The message is certainly detailed :-) Please

[jira] [Commented] (HBASE-5174) Coalesce aborted tasks in the TaskMonitor

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184562#comment-13184562 ] Zhihong Yu commented on HBASE-5174: --- I think the MonitoredTask display should be placed

[jira] [Commented] (HBASE-5177) HTable needs a non cached version of getRegionLocation

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184595#comment-13184595 ] Zhihong Yu commented on HBASE-5177: --- @Pritam: Can you attach the latest patch here so

[jira] [Commented] (HBASE-5033) Opening/Closing store in parallel to reduce region open/close time

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184608#comment-13184608 ] Zhihong Yu commented on HBASE-5033: --- I doubt: {code} diff --git

[jira] [Commented] (HBASE-5177) HTable needs a non cached version of getRegionLocation

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184617#comment-13184617 ] Zhihong Yu commented on HBASE-5177: --- The patch from Phabricator cannot be applied on

[jira] [Commented] (HBASE-5033) Opening/Closing store in parallel to reduce region open/close time

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184631#comment-13184631 ] Zhihong Yu commented on HBASE-5033: --- Integrated to TRUNK. Thanks for the patch, Liyin.

[jira] [Commented] (HBASE-5179) Concurrent processing of processFaileOver and ServerShutdownHandler may cause region is assigned before completing split log, it would cause data loss

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184697#comment-13184697 ] Zhihong Yu commented on HBASE-5179: --- {code} + * Class to hold dead servers list, utility

[jira] [Commented] (HBASE-4720) Implement atomic update operations (checkAndPut, checkAndDelete) for REST client/server

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184737#comment-13184737 ] Zhihong Yu commented on HBASE-4720: --- Latest patch passed unit tests.

[jira] [Commented] (HBASE-5179) Concurrent processing of processFaileOver and ServerShutdownHandler may cause region is assigned before completing split log, it would cause data loss

2012-01-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184760#comment-13184760 ] Zhihong Yu commented on HBASE-5179: --- You mean hbase-4748, right ? I think we should

[jira] [Commented] (HBASE-5165) Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause deleted region to assign again

2012-01-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183167#comment-13183167 ] Zhihong Yu commented on HBASE-5165: --- As Stack said: bq. now when a table is disabled, we

[jira] [Commented] (HBASE-5120) Timeout monitor races with table disable handler

2012-01-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183319#comment-13183319 ] Zhihong Yu commented on HBASE-5120: --- I think deleteClosingOrClosedNode() should catch

[jira] [Commented] (HBASE-5120) Timeout monitor races with table disable handler

2012-01-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183380#comment-13183380 ] Zhihong Yu commented on HBASE-5120: --- {code} +LOG.debug(The deletion of the

[jira] [Commented] (HBASE-5171) Potential NullPointerException while obtaining row lock

2012-01-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183425#comment-13183425 ] Zhihong Yu commented on HBASE-5171: --- @Yves: Do you want to provide a patch ? I think

[jira] [Commented] (HBASE-5171) Potential NullPointerException while obtaining row lock

2012-01-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183429#comment-13183429 ] Zhihong Yu commented on HBASE-5171: --- One workaround is to increase the value for

[jira] [Commented] (HBASE-5033) Opening/Closing store in parallel to reduce region open/close time

2012-01-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183442#comment-13183442 ] Zhihong Yu commented on HBASE-5033: --- @Liyin: Do you happen to have some performance data

[jira] [Commented] (HBASE-5134) Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface

2012-01-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183463#comment-13183463 ] Zhihong Yu commented on HBASE-5134: --- Feel free to check the script under ./dev-support.

[jira] [Commented] (HBASE-5139) Compute (weighted) median using AggregateProtocol

2012-01-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183480#comment-13183480 ] Zhihong Yu commented on HBASE-5139: --- I want to point out that weighted median

[jira] [Commented] (HBASE-5172) HTableInterface should extend java.io.Closeable

2012-01-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183494#comment-13183494 ] Zhihong Yu commented on HBASE-5172: --- +1 on patch. Thanks Stack.

[jira] [Commented] (HBASE-4608) HLog Compression

2012-01-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183495#comment-13183495 ] Zhihong Yu commented on HBASE-4608: --- I got the following on my MacBook for 4608v9.txt:

[jira] [Commented] (HBASE-5155) ServerShutDownHandler And Disable/Delete should not happen parallely leading to recreation of regions that were deleted

2012-01-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183592#comment-13183592 ] Zhihong Yu commented on HBASE-5155: --- +1 on utilizing TableState.ENABLED Nice finding,

[jira] [Commented] (HBASE-5174) Coalesce aborted tasks in the TaskMonitor

2012-01-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183653#comment-13183653 ] Zhihong Yu commented on HBASE-5174: --- I think this issue is similar to HBASE-5136 in that

[jira] [Commented] (HBASE-5163) TestLogRolling#testLogRollOnDatanodeDeath fails sometimes on central build or hadoop QA on trunk (The directory is already locked.)

2012-01-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183682#comment-13183682 ] Zhihong Yu commented on HBASE-5163: --- +1 on patch. Looped over the test and didn't

[jira] [Commented] (HBASE-3565) Add a metric to keep track of slow HLog appends

2012-01-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183754#comment-13183754 ] Zhihong Yu commented on HBASE-3565: --- Patch looks good to me. Add a

[jira] [Commented] (HBASE-5176) AssignmentManager: getRegion: logging nit adds a redundant '+'

2012-01-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183801#comment-13183801 ] Zhihong Yu commented on HBASE-5176: --- +1 on patch. AssignmentManager:

[jira] [Commented] (HBASE-5176) AssignmentManager: getRegion: logging nit adds a redundant '+'

2012-01-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183814#comment-13183814 ] Zhihong Yu commented on HBASE-5176: --- Most test failures were due to MAPREDUCE-3583.

[jira] [Commented] (HBASE-5174) Coalesce aborted tasks in the TaskMonitor

2012-01-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183851#comment-13183851 ] Zhihong Yu commented on HBASE-5174: --- Maybe we can add the following method to

[jira] [Commented] (HBASE-5153) HConnection re-creation in HTable after HConnection abort

2012-01-09 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182467#comment-13182467 ] Zhihong Yu commented on HBASE-5153: --- Can you add a unit test ? Testing this in cluster

[jira] [Commented] (HBASE-5153) HConnection re-creation in HTable after HConnection abort

2012-01-09 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182552#comment-13182552 ] Zhihong Yu commented on HBASE-5153: --- {code} + if (this.closed) +throw new

[jira] [Commented] (HBASE-5152) Region is on service before completing initialized when doing rollback of split, it will affect read correctness

2012-01-09 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182647#comment-13182647 ] Zhihong Yu commented on HBASE-5152: --- @Stack: Do you want to take a look ?

[jira] [Commented] (HBASE-5155) ServerShutDownHandler And Disable/Delete should not happen parallely leading to recreation of regions that were deleted

2012-01-09 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182653#comment-13182653 ] Zhihong Yu commented on HBASE-5155: --- Then we need to detect whether the table being

[jira] [Commented] (HBASE-5120) Timeout monitor races with table disable handler

2012-01-09 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182673#comment-13182673 ] Zhihong Yu commented on HBASE-5120: --- I see different exception handling w.r.t.

[jira] [Commented] (HBASE-5128) [uber hbck] Enable hbck to automatically repair table integrity problems as well as region consistency problems while online.

2012-01-09 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182693#comment-13182693 ] Zhihong Yu commented on HBASE-5128: --- For problem #1, I think

[jira] [Commented] (HBASE-5137) MasterFileSystem.splitLog() should abort even if waitOnSafeMode() throws IOException

2012-01-09 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182695#comment-13182695 ] Zhihong Yu commented on HBASE-5137: --- Yes. Please don't forget the patch for TRUNK :-)

[jira] [Commented] (HBASE-5155) ServerShutDownHandler And Disable/Delete should not happen parallely leading to recreation of regions that were deleted

2012-01-09 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182715#comment-13182715 ] Zhihong Yu commented on HBASE-5155: --- I think Ram's question @ 09/Jan/12 17:23 hints at

[jira] [Commented] (HBASE-3976) Disable Block Cache On Compactions

2012-01-09 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182732#comment-13182732 ] Zhihong Yu commented on HBASE-3976: --- This was integrated on 17/Jun/11 11:00 and the

[jira] [Commented] (HBASE-5152) Region is on service before completing initialization when doing rollback of split, it will affect read correctness

2012-01-09 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182918#comment-13182918 ] Zhihong Yu commented on HBASE-5152: --- Integrated to 0.92 and TRUNK. Thanks for the

[jira] [Commented] (HBASE-5134) Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface

2012-01-09 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182937#comment-13182937 ] Zhihong Yu commented on HBASE-5134: --- Two tests hung in PreCommit #710: {code} Hanging

[jira] [Commented] (HBASE-5134) Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface

2012-01-09 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182957#comment-13182957 ] Zhihong Yu commented on HBASE-5134: --- Yes, I have a script that can parse test output. I

[jira] [Commented] (HBASE-5163) TestLogRolling#testLogRollOnDatanodeDeath fails sometimes on central build or hadoop QA on trunk (The directory is already locked.)

2012-01-09 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182965#comment-13182965 ] Zhihong Yu commented on HBASE-5163: --- Nice analysis. I like #2 better. We should always

[jira] [Commented] (HBASE-5165) Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause deleted region to assign again

2012-01-09 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183017#comment-13183017 ] Zhihong Yu commented on HBASE-5165: --- This looks like HBASE-5155

[jira] [Commented] (HBASE-5121) MajorCompaction may affect scan's correctness

2012-01-09 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183019#comment-13183019 ] Zhihong Yu commented on HBASE-5121: --- +1 on latest patch going to 0.92 and TRUNK.

[jira] [Commented] (HBASE-5165) Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause deleted region to assign again

2012-01-09 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183026#comment-13183026 ] Zhihong Yu commented on HBASE-5165: --- @Chunhui: Ram hasn't provided patch for HBASE-5155

[jira] [Commented] (HBASE-5165) Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause deleted region to assign again

2012-01-09 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183061#comment-13183061 ] Zhihong Yu commented on HBASE-5165: --- Patch looks interesting. Have you verified that

[jira] [Commented] (HBASE-5134) Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface

2012-01-09 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183068#comment-13183068 ] Zhihong Yu commented on HBASE-5134: --- Script has been attached to HBASE-4480

[jira] [Commented] (HBASE-5120) Timeout monitor races with table disable handler

2012-01-09 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183080#comment-13183080 ] Zhihong Yu commented on HBASE-5120: --- {code} +

[jira] [Commented] (HBASE-5136) Redundant MonitoredTask instances in case of distributed log splitting retry

2012-01-09 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183090#comment-13183090 ] Zhihong Yu commented on HBASE-5136: --- @Prakash: Can you kindly provide your opinion ?

[jira] [Commented] (HBASE-4224) Need a flush by regionserver rather than by table option

2012-01-08 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182234#comment-13182234 ] Zhihong Yu commented on HBASE-4224: --- w.r.t. whether flushAllRegions() should be

[jira] [Commented] (HBASE-4224) Need a flush by regionserver rather than by table option

2012-01-08 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182266#comment-13182266 ] Zhihong Yu commented on HBASE-4224: --- I am not strongly opposed to adding a new method.

[jira] [Commented] (HBASE-5146) Hbase Shell - allow setting config properties

2012-01-08 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182301#comment-13182301 ] Zhihong Yu commented on HBASE-5146: --- Table / column family attribute change is related

[jira] [Commented] (HBASE-5142) Compute standard deviation using AggregateProtocol

2012-01-08 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182308#comment-13182308 ] Zhihong Yu commented on HBASE-5142: --- AggregationClient.std() already provides this

[jira] [Commented] (HBASE-5123) Provide more aggregate functions for Aggregations Protocol

2012-01-08 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182337#comment-13182337 ] Zhihong Yu commented on HBASE-5123: --- AggregationClient.std() already provides this

[jira] [Commented] (HBASE-5137) MasterFileSystem.splitLog() should abort even if waitOnSafeMode() throws IOException

2012-01-07 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182014#comment-13182014 ] Zhihong Yu commented on HBASE-5137: --- Minor comment: {code} +if

<    5   6   7   8   9   10   11   12   13   14   >