[GitHub] [hbase] ragarkar commented on a diff in pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

ragarkar commented on code in PR #5376: URL: https://github.com/apache/hbase/pull/5376#discussion_r1310115419 ## hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtil.java: ## @@ -2906,6 +2907,25 @@ public boolean ensureSomeRegionServersAvailable(final int num)

[GitHub] [hbase] wchevreuil commented on a diff in pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

wchevreuil commented on code in PR #5376: URL: https://github.com/apache/hbase/pull/5376#discussion_r1309943247 ## hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtil.java: ## @@ -3642,6 +3662,110 @@ public boolean evaluate() throws IOException { }; }

[GitHub] [hbase] Apache-HBase commented on pull request #5371: HBASE-28044 Reduce frequency of saving backing map in persistence cache

Apache-HBase commented on PR #5371: URL: https://github.com/apache/hbase/pull/5371#issuecomment-1698926631 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[GitHub] [hbase] wchevreuil commented on a diff in pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

wchevreuil commented on code in PR #5376: URL: https://github.com/apache/hbase/pull/5376#discussion_r1309959061 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -1477,6 +1477,7 @@ private void disableCache() { // If persistent

[GitHub] [hbase] Apache-HBase commented on pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

Apache-HBase commented on PR #5376: URL: https://github.com/apache/hbase/pull/5376#issuecomment-1698853202 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

[GitHub] [hbase] Apache-HBase commented on pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

Apache-HBase commented on PR #5376: URL: https://github.com/apache/hbase/pull/5376#issuecomment-1699051669 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

[GitHub] [hbase] Apache-HBase commented on pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

Apache-HBase commented on PR #5376: URL: https://github.com/apache/hbase/pull/5376#issuecomment-1698843236 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

[GitHub] [hbase-operator-tools] NihalJain commented on pull request #135: HBASE-27961 Running assigns/unassigns command with large number of files/regions throws CallTimeoutException

NihalJain commented on PR #135: URL: https://github.com/apache/hbase-operator-tools/pull/135#issuecomment-1706728002 Rebased code and removed unrelated code format changes as they have already been fixed with https://github.com/apache/hbase-operator-tools/pull/137 @petersomogyi ,

[GitHub] [hbase-operator-tools] petersomogyi merged pull request #136: HBASE-27978 Add spotless in hbase-operator-tools pre-commit check

petersomogyi merged PR #136: URL: https://github.com/apache/hbase-operator-tools/pull/136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #5383: HBASE-28063. Added docs for ZooKeeper TLS connection

Apache-HBase commented on PR #5383: URL: https://github.com/apache/hbase/pull/5383#issuecomment-1706729701 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 11s |

[GitHub] [hbase] Apache-HBase commented on pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

Apache-HBase commented on PR #5376: URL: https://github.com/apache/hbase/pull/5376#issuecomment-1706419568 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 23s |

[GitHub] [hbase-operator-tools] NihalJain commented on pull request #136: HBASE-27978 Add spotless in hbase-operator-tools pre-commit check

NihalJain commented on PR #136: URL: https://github.com/apache/hbase-operator-tools/pull/136#issuecomment-1706558506 Gentle ping @Apache9 @petersomogyi @wchevreuil Please let me know, if this is good to go. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache-HBase commented on pull request #5383: HBASE-28063. Added docs for ZooKeeper TLS connection

Apache-HBase commented on PR #5383: URL: https://github.com/apache/hbase/pull/5383#issuecomment-1706757512 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 28s |

[GitHub] [hbase] NihalJain commented on a diff in pull request #5383: HBASE-28063. Added docs for ZooKeeper TLS connection

NihalJain commented on code in PR #5383: URL: https://github.com/apache/hbase/pull/5383#discussion_r1316001563 ## src/main/asciidoc/_chapters/zookeeper.adoc: ## @@ -441,7 +441,70 @@ This would avoid the need for a separate Hadoop jar that fixes link:https://issu

[GitHub] [hbase] Apache-HBase commented on pull request #5383: HBASE-28063. Added docs for ZooKeeper TLS connection

Apache-HBase commented on PR #5383: URL: https://github.com/apache/hbase/pull/5383#issuecomment-1706731441 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s |

[GitHub] [hbase] anmolnar commented on a diff in pull request #5383: HBASE-28063. Added docs for ZooKeeper TLS connection

anmolnar commented on code in PR #5383: URL: https://github.com/apache/hbase/pull/5383#discussion_r1316101143 ## src/main/asciidoc/_chapters/zookeeper.adoc: ## @@ -441,7 +441,70 @@ This would avoid the need for a separate Hadoop jar that fixes link:https://issu

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #135: HBASE-27961 Running assigns/unassigns command with large number of files/regions throws CallTimeoutException

Apache-HBase commented on PR #135: URL: https://github.com/apache/hbase-operator-tools/pull/135#issuecomment-1706755935 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase] Apache-HBase commented on pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

Apache-HBase commented on PR #5376: URL: https://github.com/apache/hbase/pull/5376#issuecomment-1706426716 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 36s |

[GitHub] [hbase] Apache9 commented on a diff in pull request #5370: HBASE-28038 Add TLS settings to ZooKeeper client

Apache9 commented on code in PR #5370: URL: https://github.com/apache/hbase/pull/5370#discussion_r1314265464 ## hbase-common/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java: ## @@ -330,4 +341,27 @@ public static String getClientZKQuorumServersString(Configuration

[GitHub] [hbase-connectors] dependabot[bot] opened a new pull request, #124: Bump org.apache.kafka:kafka-clients from 2.0.0 to 2.6.3 in /kafka/hbase-kafka-proxy

dependabot[bot] opened a new pull request, #124: URL: https://github.com/apache/hbase-connectors/pull/124 Bumps org.apache.kafka:kafka-clients from 2.0.0 to 2.6.3. [![Dependabot compatibility

[GitHub] [hbase] Apache9 commented on a diff in pull request #5381: HBASE-28058 Adjust the order of acquiring the takeSnapshot locks to r…esolve the deadlock issue.

Apache9 commented on code in PR #5381: URL: https://github.com/apache/hbase/pull/5381#discussion_r1313830693 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java: ## @@ -670,11 +670,13 @@ public void takeSnapshot(SnapshotDescription

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #135: HBASE-27961 Running assigns/unassigns command with large number of files/regions throws CallTimeoutException

Apache-HBase commented on PR #135: URL: https://github.com/apache/hbase-operator-tools/pull/135#issuecomment-1708299818 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase-operator-tools] NihalJain commented on pull request #135: HBASE-27961 Running assigns/unassigns command with large number of files/regions throws CallTimeoutException

NihalJain commented on PR #135: URL: https://github.com/apache/hbase-operator-tools/pull/135#issuecomment-1708419642 > Nice improvement! I only have a minor comment on the log. Fixed the review comment. Thanks for taking time to review this @petersomogyi. I will wait until EOD

[GitHub] [hbase-operator-tools] petersomogyi commented on a diff in pull request #135: HBASE-27961 Running assigns/unassigns command with large number of files/regions throws CallTimeoutException

petersomogyi commented on code in PR #135: URL: https://github.com/apache/hbase-operator-tools/pull/135#discussion_r1316946481 ## hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java: ## @@ -450,42 +461,82 @@ List>> addMissingRegionsInMetaForTables(String... nameSpaceO }

[GitHub] [hbase] NihalJain commented on a diff in pull request #5383: HBASE-28063. Added docs for ZooKeeper TLS connection

NihalJain commented on code in PR #5383: URL: https://github.com/apache/hbase/pull/5383#discussion_r1317087811 ## src/main/asciidoc/_chapters/zookeeper.adoc: ## @@ -441,7 +441,70 @@ This would avoid the need for a separate Hadoop jar that fixes link:https://issu

[GitHub] [hbase] Apache-HBase commented on pull request #5383: HBASE-28063. Added docs for ZooKeeper TLS connection

Apache-HBase commented on PR #5383: URL: https://github.com/apache/hbase/pull/5383#issuecomment-1708043284 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

[GitHub] [hbase] Apache-HBase commented on pull request #5383: HBASE-28063. Added docs for ZooKeeper TLS connection

Apache-HBase commented on PR #5383: URL: https://github.com/apache/hbase/pull/5383#issuecomment-1708042998 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 11s |

[GitHub] [hbase] Apache-HBase commented on pull request #5383: HBASE-28063. Added docs for ZooKeeper TLS connection

Apache-HBase commented on PR #5383: URL: https://github.com/apache/hbase/pull/5383#issuecomment-1708060760 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[GitHub] [hbase] NihalJain merged pull request #5383: HBASE-28063. Added docs for ZooKeeper TLS connection

NihalJain merged PR #5383: URL: https://github.com/apache/hbase/pull/5383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] anmolnar commented on a diff in pull request #5383: HBASE-28063. Added docs for ZooKeeper TLS connection

anmolnar commented on code in PR #5383: URL: https://github.com/apache/hbase/pull/5383#discussion_r1317032561 ## src/main/asciidoc/_chapters/zookeeper.adoc: ## @@ -441,7 +441,70 @@ This would avoid the need for a separate Hadoop jar that fixes link:https://issu

[GitHub] [hbase] ndimiduk commented on a diff in pull request #5352: HBASE-26780 HFileBlock.verifyOnDiskSizeMatchesHeader throw IOException: Passed in onDiskSizeWithHeader= A != 33

ndimiduk commented on code in PR #5352: URL: https://github.com/apache/hbase/pull/5352#discussion_r1315650212 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1729,7 +1729,31 @@ protected HFileBlock readBlockDataInternal(FSDataInputStream

[GitHub] [hbase] Apache-HBase commented on pull request #5379: HBASE-28055 Performance improvement for scan over several stores.

Apache-HBase commented on PR #5379: URL: https://github.com/apache/hbase/pull/5379#issuecomment-1706150887 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 8s |

[GitHub] [hbase] petersomogyi merged pull request #5382: HBASE-28059 Use correct units in RegionLoad#getStoreUncompressedSizeMB()

petersomogyi merged PR #5382: URL: https://github.com/apache/hbase/pull/5382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] ragarkar commented on pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

ragarkar commented on PR #5376: URL: https://github.com/apache/hbase/pull/5376#issuecomment-1706037086 > The term "prefetch" is confusing. What we are really concerned here is how much cached a region is, so we should reflect this on classes, variables, methods and comments. I have

[GitHub] [hbase] Apache-HBase commented on pull request #5379: HBASE-28055 Performance improvement for scan over several stores.

Apache-HBase commented on PR #5379: URL: https://github.com/apache/hbase/pull/5379#issuecomment-1705930341 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 21s |

[GitHub] [hbase] Apache-HBase commented on pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

Apache-HBase commented on PR #5376: URL: https://github.com/apache/hbase/pull/5376#issuecomment-1706084640 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 53s |

[GitHub] [hbase] anmolnar commented on a diff in pull request #5370: HBASE-28038 Add TLS settings to ZooKeeper client

anmolnar commented on code in PR #5370: URL: https://github.com/apache/hbase/pull/5370#discussion_r1315565341 ## hbase-common/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java: ## @@ -330,4 +341,27 @@ public static String

[GitHub] [hbase] anmolnar commented on a diff in pull request #5370: HBASE-28038 Add TLS settings to ZooKeeper client

anmolnar commented on code in PR #5370: URL: https://github.com/apache/hbase/pull/5370#discussion_r1315565341 ## hbase-common/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java: ## @@ -330,4 +341,27 @@ public static String

[GitHub] [hbase] Apache-HBase commented on pull request #5379: HBASE-28055 Performance improvement for scan over several stores.

Apache-HBase commented on PR #5379: URL: https://github.com/apache/hbase/pull/5379#issuecomment-1706132333 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 8s |

[GitHub] [hbase] petersomogyi merged pull request #5370: HBASE-28038 Add TLS settings to ZooKeeper client

petersomogyi merged PR #5370: URL: https://github.com/apache/hbase/pull/5370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] YutSean commented on pull request #5352: HBASE-26780 HFileBlock.verifyOnDiskSizeMatchesHeader throw IOException: Passed in onDiskSizeWithHeader= A != 33

YutSean commented on PR #5352: URL: https://github.com/apache/hbase/pull/5352#issuecomment-1709486972 > How have you tested this? Could we write a unit test which demonstrates the intended behavior? As it is an unreproducible case, it is hard to simulate the error we met. The normal use

[GitHub] [hbase] frostruan commented on pull request #5381: HBASE-28058 Adjust the order of acquiring the takeSnapshot locks to r…esolve the deadlock issue.

frostruan commented on PR #5381: URL: https://github.com/apache/hbase/pull/5381#issuecomment-1709394641 hi @hiping-tech any update here ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hbase] YutSean commented on a diff in pull request #5352: HBASE-26780 HFileBlock.verifyOnDiskSizeMatchesHeader throw IOException: Passed in onDiskSizeWithHeader= A != 33

YutSean commented on code in PR #5352: URL: https://github.com/apache/hbase/pull/5352#discussion_r1318090488 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1729,7 +1729,31 @@ protected HFileBlock readBlockDataInternal(FSDataInputStream

[GitHub] [hbase] nikita15p commented on pull request #5346: HBASE-27991 fixing ClassCastException in multithread client run

nikita15p commented on PR #5346: URL: https://github.com/apache/hbase/pull/5346#issuecomment-1709430963 Gentle Reminder: @Apache9 can u please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #5352: HBASE-26780 HFileBlock.verifyOnDiskSizeMatchesHeader throw IOException: Passed in onDiskSizeWithHeader= A != 33

Apache-HBase commented on PR #5352: URL: https://github.com/apache/hbase/pull/5352#issuecomment-1709516743 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

[GitHub] [hbase] NihalJain commented on pull request #5346: HBASE-27991 fixing ClassCastException in multithread client run

NihalJain commented on PR #5346: URL: https://github.com/apache/hbase/pull/5346#issuecomment-1709880884 > I suspect https://issues.apache.org/jira/browse/HBASE-22244 / https://github.com/apache/hbase/pull/155 might have broken compatibility on what can be passed to ExecutorService as the

[GitHub] [hbase] ndimiduk commented on a diff in pull request #5215: HBASE-27814 Add support for dump and process metrics servlet in REST …

ndimiduk commented on code in PR #5215: URL: https://github.com/apache/hbase/pull/5215#discussion_r1318297654 ## hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/RESTDumpServlet.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [hbase] Apache-HBase commented on pull request #5352: HBASE-26780 HFileBlock.verifyOnDiskSizeMatchesHeader throw IOException: Passed in onDiskSizeWithHeader= A != 33

Apache-HBase commented on PR #5352: URL: https://github.com/apache/hbase/pull/5352#issuecomment-1709791235 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[GitHub] [hbase] Apache-HBase commented on pull request #5352: HBASE-26780 HFileBlock.verifyOnDiskSizeMatchesHeader throw IOException: Passed in onDiskSizeWithHeader= A != 33

Apache-HBase commented on PR #5352: URL: https://github.com/apache/hbase/pull/5352#issuecomment-1709791349 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

[GitHub] [hbase-operator-tools] petersomogyi commented on pull request #135: HBASE-27961 Running assigns/unassigns command with large number of files/regions throws CallTimeoutException

petersomogyi commented on PR #135: URL: https://github.com/apache/hbase-operator-tools/pull/135#issuecomment-1709789938 The outputs should be consistent. I agree the `[425, 426, 427, 428, 429]` output looks better.  -- This is an automated message from the Apache Git Service. To

[GitHub] [hbase] wchevreuil commented on a diff in pull request #5371: HBASE-28044 Reduce frequency of saving backing map in persistence cache

wchevreuil commented on code in PR #5371: URL: https://github.com/apache/hbase/pull/5371#discussion_r1321378222 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -1285,12 +1320,104 @@ void persistToFile() throws IOException {

[GitHub] [hbase] wchevreuil commented on a diff in pull request #5371: HBASE-28044 Reduce frequency of saving backing map in persistence cache

wchevreuil commented on code in PR #5371: URL: https://github.com/apache/hbase/pull/5371#discussion_r1321395417 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -1700,17 +1853,17 @@ public BucketEntry writeToCache(final IOEngine

[GitHub] [hbase] ndimiduk commented on pull request #5379: HBASE-28055 Performance improvement for scan over several stores.

ndimiduk commented on PR #5379: URL: https://github.com/apache/hbase/pull/5379#issuecomment-1713427095 Heya @taklwu @ss77892 this backport broke branch-2.5, maybe others. Please address and consider using PRs for all branch backports as well, just to get pre-commit checks. Thanks! --

[GitHub] [hbase] ndimiduk commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

ndimiduk commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1321481778 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlockHeaderCorruption.java: ## @@ -0,0 +1,533 @@ +/* + * Licensed to the Apache Software

[GitHub] [hbase] Apache-HBase commented on pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

Apache-HBase commented on PR #5384: URL: https://github.com/apache/hbase/pull/5384#issuecomment-1713859062 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

[GitHub] [hbase] Apache-HBase commented on pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

Apache-HBase commented on PR #5384: URL: https://github.com/apache/hbase/pull/5384#issuecomment-1713866984 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s |

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

bbeaudreault commented on code in PR #5228: URL: https://github.com/apache/hbase/pull/5228#discussion_r1321620558 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java: ## @@ -692,6 +711,13 @@ public void updateRpc(MethodDescriptor method, Message

[GitHub] [hbase] ndimiduk commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

ndimiduk commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1321725464 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1721,14 +1765,36 @@ protected HFileBlock readBlockDataInternal(FSDataInputStream

[GitHub] [hbase] Apache-HBase commented on pull request #5388: HBASE-27989. ByteBuffAllocator causes ArithmeticException due to improper poolBufSize value checking

Apache-HBase commented on PR #5388: URL: https://github.com/apache/hbase/pull/5388#issuecomment-1714115981 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

bbeaudreault commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1321537092 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1697,8 +1722,27 @@ protected HFileBlock

[GitHub] [hbase] Apache-HBase commented on pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

Apache-HBase commented on PR #5384: URL: https://github.com/apache/hbase/pull/5384#issuecomment-1713863136 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

bbeaudreault commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1321591860 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1721,14 +1765,36 @@ protected HFileBlock

[GitHub] [hbase] Apache-HBase commented on pull request #5388: HBASE-27989. ByteBuffAllocator causes ArithmeticException due to improper poolBufSize value checking

Apache-HBase commented on PR #5388: URL: https://github.com/apache/hbase/pull/5388#issuecomment-1714112349 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

bbeaudreault commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1321727477 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1721,14 +1765,36 @@ protected HFileBlock

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

bbeaudreault commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1321548711 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1667,7 +1688,11 @@ protected HFileBlock

[GitHub] [hbase] teamconfx opened a new pull request, #5388: HBASE-27989. ByteBuffAllocator causes ArithmeticException due to improper poolBufSize value checking

teamconfx opened a new pull request, #5388: URL: https://github.com/apache/hbase/pull/5388 ### Description of PR https://issues.apache.org/jira/browse/HBASE-27989 This PR prohibits setting `hbase.server.allocator.buffer.size` to 0 or negative. A warning is also added if the minimum

[GitHub] [hbase] Apache-HBase commented on pull request #5388: HBASE-27989. ByteBuffAllocator causes ArithmeticException due to improper poolBufSize value checking

Apache-HBase commented on PR #5388: URL: https://github.com/apache/hbase/pull/5388#issuecomment-1714123549 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

[GitHub] [hbase] ndimiduk commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

ndimiduk commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1321748184 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1667,7 +1688,11 @@ protected HFileBlock readBlockDataInternal(FSDataInputStream

[GitHub] [hbase] Apache-HBase commented on pull request #5388: HBASE-27989. ByteBuffAllocator causes ArithmeticException due to improper poolBufSize value checking

Apache-HBase commented on PR #5388: URL: https://github.com/apache/hbase/pull/5388#issuecomment-1714212178 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

[GitHub] [hbase] teamconfx opened a new pull request, #5389: HBASE-27990. BucketCache causes ArithmeticException due to improper blockSize value checking

teamconfx opened a new pull request, #5389: URL: https://github.com/apache/hbase/pull/5389 ### Description of PR https://issues.apache.org/jira/browse/HBASE-27990 This PR adds a precheck for `hbase.blockcache.minblocksize` such that it must be positive. ### How was this patch

[GitHub] [hbase] ndimiduk commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

ndimiduk commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1321749214 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1721,14 +1765,36 @@ protected HFileBlock readBlockDataInternal(FSDataInputStream

[GitHub] [hbase] Apache-HBase commented on pull request #5388: HBASE-27989. ByteBuffAllocator causes ArithmeticException due to improper poolBufSize value checking

Apache-HBase commented on PR #5388: URL: https://github.com/apache/hbase/pull/5388#issuecomment-1714201162 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s |

[GitHub] [hbase] zhuyaogai commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

zhuyaogai commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714221773 > This is looking good! One more request. > > Also, can you please squash and rebase this PR so that we can clear out the `patch` warning in the pre-commit hook? done. --

[GitHub] [hbase] Apache-HBase commented on pull request #5389: HBASE-27990. BucketCache causes ArithmeticException due to improper blockSize value checking

Apache-HBase commented on PR #5389: URL: https://github.com/apache/hbase/pull/5389#issuecomment-1714221362 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

[GitHub] [hbase] Apache-HBase commented on pull request #5390: HBASE-27993. AbstractFSWAL causes ArithmeticException due to improper logRollSize value checking

Apache-HBase commented on PR #5390: URL: https://github.com/apache/hbase/pull/5390#issuecomment-1714244301 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[GitHub] [hbase] Apache-HBase commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

Apache-HBase commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714269350 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

[GitHub] [hbase] Apache-HBase commented on pull request #5388: HBASE-27989. ByteBuffAllocator causes ArithmeticException due to improper poolBufSize value checking

Apache-HBase commented on PR #5388: URL: https://github.com/apache/hbase/pull/5388#issuecomment-1714204962 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

[GitHub] [hbase] zhuyaogai commented on a diff in pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

zhuyaogai commented on code in PR #5228: URL: https://github.com/apache/hbase/pull/5228#discussion_r1321804040 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java: ## @@ -692,6 +711,13 @@ public void updateRpc(MethodDescriptor method, Message

[GitHub] [hbase] Apache-HBase commented on pull request #5389: HBASE-27990. BucketCache causes ArithmeticException due to improper blockSize value checking

Apache-HBase commented on PR #5389: URL: https://github.com/apache/hbase/pull/5389#issuecomment-1714500571 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

[GitHub] [hbase] Apache-HBase commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

Apache-HBase commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714525287 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

[GitHub] [hbase] Apache-HBase commented on pull request #5390: HBASE-27993. AbstractFSWAL causes ArithmeticException due to improper logRollSize value checking

Apache-HBase commented on PR #5390: URL: https://github.com/apache/hbase/pull/5390#issuecomment-1714525180 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

[GitHub] [hbase] Apache-HBase commented on pull request #5363: HBASE-28008 Add support for netty tcnative

Apache-HBase commented on PR #5363: URL: https://github.com/apache/hbase/pull/5363#issuecomment-1714594299 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

[GitHub] [hbase] Apache-HBase commented on pull request #5390: HBASE-27993. AbstractFSWAL causes ArithmeticException due to improper logRollSize value checking

Apache-HBase commented on PR #5390: URL: https://github.com/apache/hbase/pull/5390#issuecomment-1714535755 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

[GitHub] [hbase] Apache-HBase commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

Apache-HBase commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714535313 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

[GitHub] [hbase] Apache-HBase commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

Apache-HBase commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714579437 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

[GitHub] [hbase] Apache-HBase commented on pull request #5389: HBASE-27990. BucketCache causes ArithmeticException due to improper blockSize value checking

Apache-HBase commented on PR #5389: URL: https://github.com/apache/hbase/pull/5389#issuecomment-1714503081 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[GitHub] [hbase] bbeaudreault commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

bbeaudreault commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714564222 @zhuyaogai unit test failures look related -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #5363: HBASE-28008 Add support for netty tcnative

Apache-HBase commented on PR #5363: URL: https://github.com/apache/hbase/pull/5363#issuecomment-1714595876 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[GitHub] [hbase] Apache-HBase commented on pull request #5363: HBASE-28008 Add support for netty tcnative

Apache-HBase commented on PR #5363: URL: https://github.com/apache/hbase/pull/5363#issuecomment-1714609451 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

[GitHub] [hbase] Apache-HBase commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

Apache-HBase commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714796782 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[GitHub] [hbase] Apache-HBase commented on pull request #5391: HBASE-28050 RSProcedureDispatcher to fail-fast for SaslException

Apache-HBase commented on PR #5391: URL: https://github.com/apache/hbase/pull/5391#issuecomment-1714804454 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

[GitHub] [hbase] Apache-HBase commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

Apache-HBase commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714809656 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

[GitHub] [hbase] zhuyaogai commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

zhuyaogai commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714859323 @bbeaudreault hi, I found that the latest unit test failures seem to be unrelated to me? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] Apache-HBase commented on pull request #5401: HBASE-28061 HBaseTestingUtility failed to start MiniHbaseCluster in c…

Apache-HBase commented on PR #5401: URL: https://github.com/apache/hbase/pull/5401#issuecomment-1718904985 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

[GitHub] [hbase] Apache9 commented on a diff in pull request #5391: HBASE-28050 RSProcedureDispatcher to fail-fast for krb auth failures

Apache9 commented on code in PR #5391: URL: https://github.com/apache/hbase/pull/5391#discussion_r1325293263 ## hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java: ## @@ -347,7 +348,7 @@ public void operationComplete(ChannelFuture future) throws

[GitHub] [hbase] Apache-HBase commented on pull request #5401: HBASE-28061 HBaseTestingUtility failed to start MiniHbaseCluster in c…

Apache-HBase commented on PR #5401: URL: https://github.com/apache/hbase/pull/5401#issuecomment-1718872112 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

[GitHub] [hbase] Apache9 commented on pull request #5401: HBASE-28061 HBaseTestingUtility failed to start MiniHbaseCluster in c…

Apache9 commented on PR #5401: URL: https://github.com/apache/hbase/pull/5401#issuecomment-1718886724 I've searched and removed all the calls to LocatedBlock.getLocations in hbase code base. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] Apache9 commented on a diff in pull request #5401: HBASE-28061 HBaseTestingUtility failed to start MiniHbaseCluster in c…

Apache9 commented on code in PR #5401: URL: https://github.com/apache/hbase/pull/5401#discussion_r1325466758 ## hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java: ## @@ -383,7 +400,7 @@ private static List>

[GitHub] [hbase] Apache-HBase commented on pull request #5401: HBASE-28061 HBaseTestingUtility failed to start MiniHbaseCluster in c…

Apache-HBase commented on PR #5401: URL: https://github.com/apache/hbase/pull/5401#issuecomment-1718953707 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

[GitHub] [hbase] zhangbutao commented on a diff in pull request #5401: HBASE-28061 HBaseTestingUtility failed to start MiniHbaseCluster in c…

zhangbutao commented on code in PR #5401: URL: https://github.com/apache/hbase/pull/5401#discussion_r1325485997 ## hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java: ## @@ -17,6 +17,8 @@ */ package org.apache.hadoop.hbase.fs; +import static

  1   2   3   4   5   6   7   8   9   10   >