Re: [PR] HBASE-28174 [hbase]

2023-11-02 Thread via GitHub
Apache-HBase commented on PR #5501: URL: https://github.com/apache/hbase/pull/5501#issuecomment-1791813930 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s |

Re: [PR] HBASE-24179 Backport fix for "Netty SASL implementation does not wait… [hbase]

2023-11-02 Thread via GitHub
Apache-HBase commented on PR #5496: URL: https://github.com/apache/hbase/pull/5496#issuecomment-1791856280 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] rebase [hbase]

2023-11-02 Thread via GitHub
Apache-HBase commented on PR #5499: URL: https://github.com/apache/hbase/pull/5499#issuecomment-1791716758 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] rebase [hbase]

2023-11-02 Thread via GitHub
Apache-HBase commented on PR #5499: URL: https://github.com/apache/hbase/pull/5499#issuecomment-1791746171 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

Re: [PR] HBASE-28151 Option to allow/disallow bypassing pre transit check for assing/unassign [hbase]

2023-11-03 Thread via GitHub
Apache-HBase commented on PR #5493: URL: https://github.com/apache/hbase/pull/5493#issuecomment-1792030062 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28186 Rebase CacheAwareBalance related commits into master branch [hbase]

2023-11-03 Thread via GitHub
Apache-HBase commented on PR #5500: URL: https://github.com/apache/hbase/pull/5500#issuecomment-1792234552 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

Re: [PR] HBASE-28186 Rebase CacheAwareBalance related commits into master branch [hbase]

2023-11-03 Thread via GitHub
ragarkar commented on PR #5500: URL: https://github.com/apache/hbase/pull/5500#issuecomment-1792050379 > @ragarkar can share more details about his tests results. Added test results information showing that the regions are retained by the region server beyond server restart and the

Re: [PR] rebase [hbase]

2023-11-03 Thread via GitHub
Apache-HBase commented on PR #5499: URL: https://github.com/apache/hbase/pull/5499#issuecomment-1791994564 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-28175: Deep copy RpcLogDetails' param field [hbase]

2023-11-03 Thread via GitHub
rmdmattingly commented on PR #5481: URL: https://github.com/apache/hbase/pull/5481#issuecomment-1792336698 The test failures above are unrelated. I believe this is ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-03 Thread via GitHub
Apache9 commented on code in PR #5494: URL: https://github.com/apache/hbase/pull/5494#discussion_r1381625626 ## hbase-common/src/main/java/org/apache/hadoop/hbase/util/PrettyPrinter.java: ## @@ -184,7 +184,12 @@ private static long humanReadableIntervalToSec(final String

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-03 Thread via GitHub
Apache9 commented on code in PR #5494: URL: https://github.com/apache/hbase/pull/5494#discussion_r1381623510 ## hbase-common/src/main/java/org/apache/hadoop/hbase/util/PrettyPrinter.java: ## @@ -184,7 +184,12 @@ private static long humanReadableIntervalToSec(final String

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-03 Thread via GitHub
Apache-HBase commented on PR #5494: URL: https://github.com/apache/hbase/pull/5494#issuecomment-1792529178 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28151 Option to allow/disallow bypassing pre transit check for assing/unassign [hbase]

2023-11-03 Thread via GitHub
Apache-HBase commented on PR #5493: URL: https://github.com/apache/hbase/pull/5493#issuecomment-1792339747 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28151 Option to allow/disallow bypassing pre transit check for assing/unassign [hbase]

2023-11-03 Thread via GitHub
Apache-HBase commented on PR #5493: URL: https://github.com/apache/hbase/pull/5493#issuecomment-1792431535 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s |

Re: [PR] HBASE-24179 Backport fix for "Netty SASL implementation does not wait… [hbase]

2023-11-03 Thread via GitHub
Apache-HBase commented on PR #5496: URL: https://github.com/apache/hbase/pull/5496#issuecomment-1792489198 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-03 Thread via GitHub
Apache-HBase commented on PR #5494: URL: https://github.com/apache/hbase/pull/5494#issuecomment-1792506942 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-03 Thread via GitHub
Apache-HBase commented on PR #5494: URL: https://github.com/apache/hbase/pull/5494#issuecomment-1792508396 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s |

[PR] HBASE-28150 CreateTableProcedure and DeleteTableProcedure should slee… [hbase]

2023-11-03 Thread via GitHub
chaijunjie0101 opened a new pull request, #5502: URL: https://github.com/apache/hbase/pull/5502 …p a while before retrying -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] HBASE-28186 Rebase CacheAwareBalance related commits into master branch [hbase]

2023-11-03 Thread via GitHub
Apache-HBase commented on PR #5500: URL: https://github.com/apache/hbase/pull/5500#issuecomment-1792567878 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

Re: [PR] HBASE-28151 Option to allow/disallow bypassing pre transit check for assing/unassign [hbase]

2023-11-03 Thread via GitHub
Apache-HBase commented on PR #5493: URL: https://github.com/apache/hbase/pull/5493#issuecomment-1792334120 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-03 Thread via GitHub
chaijunjie0101 commented on code in PR #5494: URL: https://github.com/apache/hbase/pull/5494#discussion_r1381679034 ## hbase-common/src/main/java/org/apache/hadoop/hbase/util/PrettyPrinter.java: ## @@ -184,7 +184,12 @@ private static long humanReadableIntervalToSec(final

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-03 Thread via GitHub
Apache9 commented on code in PR #5494: URL: https://github.com/apache/hbase/pull/5494#discussion_r1381727575 ## hbase-common/src/main/java/org/apache/hadoop/hbase/util/PrettyPrinter.java: ## @@ -184,7 +184,12 @@ private static long humanReadableIntervalToSec(final String

Re: [PR] HBASE-25549 Provide a switch that allows avoiding reopening all regions when modifying a table to prevent RIT storms. [hbase]

2023-11-03 Thread via GitHub
Apache9 commented on PR #2924: URL: https://github.com/apache/hbase/pull/2924#issuecomment-1792375532 We are good to go? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] HBASE-28150 CreateTableProcedure and DeleteTableProcedure should slee… [hbase]

2023-11-03 Thread via GitHub
Apache-HBase commented on PR #5502: URL: https://github.com/apache/hbase/pull/5502#issuecomment-1792587860 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28186 Rebase CacheAwareBalance related commits into master branch [hbase]

2023-11-03 Thread via GitHub
Apache-HBase commented on PR #5500: URL: https://github.com/apache/hbase/pull/5500#issuecomment-1792698415 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28151 Option to allow/disallow bypassing pre transit check for assing/unassign [hbase]

2023-11-03 Thread via GitHub
Apache-HBase commented on PR #5493: URL: https://github.com/apache/hbase/pull/5493#issuecomment-1792808458 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 15s |

Re: [PR] HBASE-28180 Review the usage of RegionStates.getOrCreateServer [hbase]

2023-11-03 Thread via GitHub
Apache-HBase commented on PR #5486: URL: https://github.com/apache/hbase/pull/5486#issuecomment-1792781707 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

Re: [PR] HBASE-28151 Option to allow/disallow bypassing pre transit check for assing/unassign [hbase]

2023-11-03 Thread via GitHub
Apache-HBase commented on PR #5493: URL: https://github.com/apache/hbase/pull/5493#issuecomment-1792835496 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-24179 Backport fix for "Netty SASL implementation does not wait… [hbase]

2023-11-03 Thread via GitHub
Apache-HBase commented on PR #5496: URL: https://github.com/apache/hbase/pull/5496#issuecomment-1792849665 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-24179 Backport fix for "Netty SASL implementation does not wait… [hbase]

2023-11-03 Thread via GitHub
Apache-HBase commented on PR #5496: URL: https://github.com/apache/hbase/pull/5496#issuecomment-1792985965 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28150 CreateTableProcedure and DeleteTableProcedure should slee… [hbase]

2023-11-04 Thread via GitHub
Apache9 commented on code in PR #5502: URL: https://github.com/apache/hbase/pull/5502#discussion_r1382350515 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/DeleteTableProcedure.java: ## @@ -133,7 +137,13 @@ protected Flow executeFromState(final

Re: [PR] HBASE-27769 use LeaseRecoverable and SafeMode introduced in hadoop-co… [hbase]

2023-11-03 Thread via GitHub
taklwu commented on PR #5469: URL: https://github.com/apache/hbase/pull/5469#issuecomment-1793159117

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-04 Thread via GitHub
Apache-HBase commented on PR #5503: URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793497710 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-04 Thread via GitHub
Apache-HBase commented on PR #5503: URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793549379 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-04 Thread via GitHub
shahrs87 commented on PR #5503: URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793489303 Thank you @Apache9 for your feedback and your requested comments are very detailed. Made the changes. Can you please review again? Thank you ! -- This is an automated message from the

Re: [PR] HBASE-28180 Review the usage of RegionStates.getOrCreateServer [hbase]

2023-11-04 Thread via GitHub
Apache-HBase commented on PR #5486: URL: https://github.com/apache/hbase/pull/5486#issuecomment-1793497213 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s |

Re: [PR] HBASE-28180 Review the usage of RegionStates.getOrCreateServer [hbase]

2023-11-04 Thread via GitHub
Apache-HBase commented on PR #5486: URL: https://github.com/apache/hbase/pull/5486#issuecomment-1793495071 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-04 Thread via GitHub
Apache-HBase commented on PR #5503: URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793549851 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-05 Thread via GitHub
Apache9 commented on PR #5494: URL: https://github.com/apache/hbase/pull/5494#issuecomment-1793690523 Please fix the checkstyle issue? The line is too long? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5504: URL: https://github.com/apache/hbase/pull/5504#issuecomment-1797091530 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

Re: [PR] HBASE-28174 [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5501: URL: https://github.com/apache/hbase/pull/5501#issuecomment-1797146012 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5503: URL: https://github.com/apache/hbase/pull/5503#issuecomment-1797071191 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 15s |

Re: [PR] HBASE-28043 Reduce seeks from beginning of block in StoreFileScanner.seekToPreviousRow [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5373: URL: https://github.com/apache/hbase/pull/5373#issuecomment-1796962842 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5503: URL: https://github.com/apache/hbase/pull/5503#issuecomment-1797092976 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28174 [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5501: URL: https://github.com/apache/hbase/pull/5501#issuecomment-1797147320 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5505: URL: https://github.com/apache/hbase/pull/5505#issuecomment-1797074760 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5504: URL: https://github.com/apache/hbase/pull/5504#issuecomment-1797080416 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s |

Re: [PR] HBASE-28189 Fix the miss count in one of CombinedBlockCache getBlock implementations [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5506: URL: https://github.com/apache/hbase/pull/5506#issuecomment-1796864897 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28189 Fix the miss count in one of CombinedBlockCache getBlock implementations [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5506: URL: https://github.com/apache/hbase/pull/5506#issuecomment-1796923893 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s |

Re: [PR] HBASE-28189 Fix the miss count in one of CombinedBlockCache getBlock implementations [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5506: URL: https://github.com/apache/hbase/pull/5506#issuecomment-1796930409 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5505: URL: https://github.com/apache/hbase/pull/5505#issuecomment-1797036623 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-28174 [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5501: URL: https://github.com/apache/hbase/pull/5501#issuecomment-1797146346 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[PR] Add slow sync log rolling test in TestAsyncLogRolling. [hbase]

2023-11-06 Thread via GitHub
zhuyaogai opened a new pull request, #5507: URL: https://github.com/apache/hbase/pull/5507 Detail: https://issues.apache.org/jira/browse/HBASE-28190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Add slow sync log rolling test in TestAsyncLogRolling. [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5507: URL: https://github.com/apache/hbase/pull/5507#issuecomment-1798001038 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] Add slow sync log rolling test in TestAsyncLogRolling. [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5507: URL: https://github.com/apache/hbase/pull/5507#issuecomment-1798332194 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28189 Fix the miss count in one of CombinedBlockCache getBlock implementations [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5506: URL: https://github.com/apache/hbase/pull/5506#issuecomment-1798418203 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-07 Thread via GitHub
ndimiduk commented on code in PR #5488: URL: https://github.com/apache/hbase/pull/5488#discussion_r1384678667 ## hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java: ## @@ -1552,13 +1571,23 @@ public static ComparatorProtos.Comparator

Re: [PR] Add slow sync log rolling test in TestAsyncLogRolling. [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5507: URL: https://github.com/apache/hbase/pull/5507#issuecomment-1798339218 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-07 Thread via GitHub
bbeaudreault commented on code in PR #5488: URL: https://github.com/apache/hbase/pull/5488#discussion_r1384834533 ## hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java: ## @@ -1552,13 +1571,23 @@ public static ComparatorProtos.Comparator

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-07 Thread via GitHub
bbeaudreault commented on code in PR #5488: URL: https://github.com/apache/hbase/pull/5488#discussion_r1384840873 ## hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java: ## @@ -304,6 +305,24 @@ public static boolean isClassLoaderLoaded() {

Re: [PR] Add slow sync log rolling test in TestAsyncLogRolling. [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5507: URL: https://github.com/apache/hbase/pull/5507#issuecomment-1798388115 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-07 Thread via GitHub
bbeaudreault commented on code in PR #5488: URL: https://github.com/apache/hbase/pull/5488#discussion_r1384836073 ## hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java: ## @@ -304,6 +305,24 @@ public static boolean isClassLoaderLoaded() {

[PR] HBASE-28191 : Meta browser can happen NPE when the server or target server of region is null [hbase]

2023-11-07 Thread via GitHub
guluo2016 opened a new pull request, #5508: URL: https://github.com/apache/hbase/pull/5508 Deatils see : [HBASE-28191](https://issues.apache.org/jira/browse/HBASE-28191) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] HBASE-28122: Support TLSv1.3 cipher suites [hbase]

2023-11-07 Thread via GitHub
charlesconnell commented on code in PR #5444: URL: https://github.com/apache/hbase/pull/5444#discussion_r1385133672 ## hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java: ## @@ -219,17 +219,17 @@ static String[] getDefaultCipherSuites(boolean

Re: [PR] HBASE-28191 : Meta browser can happen NPE when the server or target server of region is null [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5508: URL: https://github.com/apache/hbase/pull/5508#issuecomment-1798794286 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s |

Re: [PR] HBASE-28122: Support TLSv1.3 cipher suites [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5444: URL: https://github.com/apache/hbase/pull/5444#issuecomment-1799049095 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 11s |

Re: [PR] HBASE-28189 Fix the miss count in one of CombinedBlockCache getBlock implementations [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5506: URL: https://github.com/apache/hbase/pull/5506#issuecomment-1799066206 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

Re: [PR] HBASE-28189 Fix the miss count in one of CombinedBlockCache getBlock implementations [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5506: URL: https://github.com/apache/hbase/pull/5506#issuecomment-1799064024 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-27638 Get slow/large log response that matched the ‘CLIENT_IP' … [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5087: URL: https://github.com/apache/hbase/pull/5087#issuecomment-1798862679 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

Re: [PR] HBASE-28122: Support TLSv1.3 cipher suites [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5444: URL: https://github.com/apache/hbase/pull/5444#issuecomment-1799066778 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] Add slow sync log rolling test in TestAsyncLogRolling. [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5507: URL: https://github.com/apache/hbase/pull/5507#issuecomment-1798936396 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] Add slow sync log rolling test in TestAsyncLogRolling. [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5507: URL: https://github.com/apache/hbase/pull/5507#issuecomment-1798965898 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

Re: [PR] HBASE-28189 Fix the miss count in one of CombinedBlockCache getBlock implementations [hbase]

2023-11-07 Thread via GitHub
petersomogyi commented on code in PR #5506: URL: https://github.com/apache/hbase/pull/5506#discussion_r1385174911 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java: ## @@ -77,16 +81,49 @@ public void cacheBlock(BlockCacheKey cacheKey,

Re: [PR] HBASE-28122: Support TLSv1.3 cipher suites [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5444: URL: https://github.com/apache/hbase/pull/5444#issuecomment-1799073878 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s |

Re: [PR] HBASE-28191 : Meta browser can happen NPE when the server or target server of region is null [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5508: URL: https://github.com/apache/hbase/pull/5508#issuecomment-1799503614 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s |

Re: [PR] HBASE-27638 Get slow/large log response that matched the ‘CLIENT_IP' … [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5087: URL: https://github.com/apache/hbase/pull/5087#issuecomment-1799602409 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-28043 Reduce seeks from beginning of block in StoreFileScanner.seekToPreviousRow [hbase]

2023-11-07 Thread via GitHub
bbeaudreault commented on code in PR #5373: URL: https://github.com/apache/hbase/pull/5373#discussion_r1385321321 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java: ## @@ -486,52 +500,171 @@ public boolean shouldUseScanner(Scan scan,

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-07 Thread via GitHub
shahrs87 commented on PR #5504: URL: https://github.com/apache/hbase/pull/5504#issuecomment-1799422621 ``` [INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running

Re: [PR] HBASE-28191 : Meta browser can happen NPE when the server or target server of region is null [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5508: URL: https://github.com/apache/hbase/pull/5508#issuecomment-1799538716 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-24687: Use existing HMaster Connection in MobFileCleanerChore [hbase]

2023-11-07 Thread via GitHub
bbeaudreault commented on code in PR #5509: URL: https://github.com/apache/hbase/pull/5509#discussion_r1385476662 ## hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java: ## @@ -92,10 +92,6 @@ private void checkObsoleteConfigurations() { } }

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-07 Thread via GitHub
shahrs87 merged PR #5503: URL: https://github.com/apache/hbase/pull/5503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-07 Thread via GitHub
shahrs87 merged PR #5504: URL: https://github.com/apache/hbase/pull/5504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-07 Thread via GitHub
shahrs87 merged PR #5505: URL: https://github.com/apache/hbase/pull/5505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-24687: Use existing HMaster Connection in MobFileCleanerChore [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5509: URL: https://github.com/apache/hbase/pull/5509#issuecomment-1799581402 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

Re: [PR] HBASE-24687: Use existing HMaster Connection in MobFileCleanerChore [hbase]

2023-11-07 Thread via GitHub
bbeaudreault commented on PR #5509: URL: https://github.com/apache/hbase/pull/5509#issuecomment-1799650213 Also please fix checkstyle and spotless -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HBASE-28043 Reduce seeks from beginning of block in StoreFileScanner.seekToPreviousRow [hbase]

2023-11-07 Thread via GitHub
jbewing commented on code in PR #5373: URL: https://github.com/apache/hbase/pull/5373#discussion_r1385442557 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java: ## @@ -486,52 +500,171 @@ public boolean shouldUseScanner(Scan scan, HStore

Re: [PR] HBASE-27638 Get slow/large log response that matched the ‘CLIENT_IP' … [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5087: URL: https://github.com/apache/hbase/pull/5087#issuecomment-1799674962 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 49s |

Re: [PR] HBASE-24687: Use existing HMaster Connection in MobFileCleanerChore [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5509: URL: https://github.com/apache/hbase/pull/5509#issuecomment-1800288607 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 11s |

Re: [PR] HBASE-27769 use LeaseRecoverable and SafeMode introduced in hadoop-co… [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5469: URL: https://github.com/apache/hbase/pull/5469#issuecomment-1800291991 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

Re: [PR] HBASE-24687: Use existing HMaster Connection in MobFileCleanerChore [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5509: URL: https://github.com/apache/hbase/pull/5509#issuecomment-1800295253 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-24687: Use existing HMaster Connection in MobFileCleanerChore [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5509: URL: https://github.com/apache/hbase/pull/5509#issuecomment-1800328948 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-24687: Use existing HMaster Connection in MobFileCleanerChore [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5509: URL: https://github.com/apache/hbase/pull/5509#issuecomment-1800323334 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-24687: Use existing HMaster Connection in MobFileCleanerChore [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5509: URL: https://github.com/apache/hbase/pull/5509#issuecomment-1800331863 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 10s |

Re: [PR] HBASE-27769 use LeaseRecoverable and SafeMode introduced in hadoop-co… [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5469: URL: https://github.com/apache/hbase/pull/5469#issuecomment-1800408637 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s |

Re: [PR] HBASE-28043 Reduce seeks from beginning of block in StoreFileScanner.seekToPreviousRow [hbase]

2023-11-07 Thread via GitHub
jbewing commented on code in PR #5373: URL: https://github.com/apache/hbase/pull/5373#discussion_r1385605592 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java: ## @@ -486,52 +500,171 @@ public boolean shouldUseScanner(Scan scan, HStore

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-07 Thread via GitHub
bbeaudreault commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1800247752 I deployed this to one of our prod servers, which is an extreme case that typically spends about 12% of time deserializing Filters. With the patch, it spends less than 5% time now.

Re: [PR] HBASE-28043 Reduce seeks from beginning of block in StoreFileScanner.seekToPreviousRow [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5373: URL: https://github.com/apache/hbase/pull/5373#issuecomment-1800276633 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-27769 use LeaseRecoverable and SafeMode introduced in hadoop-co… [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5469: URL: https://github.com/apache/hbase/pull/5469#issuecomment-1800291113 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

Re: [PR] HBASE-27769 use LeaseRecoverable and SafeMode introduced in hadoop-co… [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5469: URL: https://github.com/apache/hbase/pull/5469#issuecomment-1800291723 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

Re: [PR] HBASE-28043 Reduce seeks from beginning of block in StoreFileScanner.seekToPreviousRow [hbase]

2023-11-07 Thread via GitHub
Apache-HBase commented on PR #5373: URL: https://github.com/apache/hbase/pull/5373#issuecomment-1800879769 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

<    3   4   5   6   7   8   9   10   11   12   >