[jira] [Commented] (HBASE-5793) TestHBaseFsck#TestNoHdfsTable test hangs after HBASE-5747
[
https://issues.apache.org/jira/browse/HBASE-5793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254254#comment-13254254
]
David S. Wang commented on HBASE-5793:
--
+1 to patch.
TestHBaseFsck#TestNoHdfsTable test hangs after HBASE-5747
-
Key: HBASE-5793
URL: https://issues.apache.org/jira/browse/HBASE-5793
Project: HBase
Issue Type: Sub-task
Affects Versions: 0.96.0
Reporter: Jonathan Hsieh
Assignee: Jonathan Hsieh
Attachments: hbase-5793.patch
After the HBASE-5747 modification, this one particular case hangs.
{code}
mvn test -PlocalTests -Dtest=TestHBaseFsck
{code}
It was hanging on a scan of a table that the test deleted. It expected a call
to thrown an exception after a timeout. HBASE-5747 changed the timeout to a
larger number of retries which caused mvn to fail the test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250801#comment-13250801 ] David S. Wang commented on HBASE-5645: -- TestReplication passed locally for me. [findbugs] Fix correctness warnings --- Key: HBASE-5645 URL: https://issues.apache.org/jira/browse/HBASE-5645 Project: HBase Issue Type: Sub-task Components: scripts Reporter: Jonathan Hsieh Assignee: David S. Wang Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Fix the warnings in the correctness section. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251306#comment-13251306 ] David S. Wang commented on HBASE-5645: -- Not high priority obviously, but if someone gets a chance to look at the new patch and commit it, I would appreciate it before the patch gets out of sync with trunk again. [findbugs] Fix correctness warnings --- Key: HBASE-5645 URL: https://issues.apache.org/jira/browse/HBASE-5645 Project: HBase Issue Type: Sub-task Components: scripts Reporter: Jonathan Hsieh Assignee: David S. Wang Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Fix the warnings in the correctness section. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5213) hbase master stop does not bring down backup masters
[ https://issues.apache.org/jira/browse/HBASE-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248416#comment-13248416 ] David S. Wang commented on HBASE-5213: -- Greg is out of town for the next week or so ... IMHO if it's breaking 0.90, we should revert for now and Greg can look at it when he gets back. hbase master stop does not bring down backup masters -- Key: HBASE-5213 URL: https://issues.apache.org/jira/browse/HBASE-5213 Project: HBase Issue Type: Bug Affects Versions: 0.90.5, 0.92.0, 0.94.0, 0.96.0 Reporter: Gregory Chanan Assignee: Gregory Chanan Priority: Minor Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0 Attachments: HBASE-5213-v0-trunk.patch, HBASE-5213-v1-trunk.patch, HBASE-5213-v2-90.patch, HBASE-5213-v2-92.patch, HBASE-5213-v2-trunk.patch Typing hbase master stop produces the following message: stop Start cluster shutdown; Master signals RegionServer shutdown It seems like backup masters should be considered part of the cluster, but they are not brought down by hbase master stop. stop-hbase.sh does correctly bring down the backup masters. The same behavior is observed when a client app makes use of the client API HBaseAdmin.shutdown() http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/HBaseAdmin.html#shutdown() -- this isn't too surprising since I think hbase master stop just calls this API. It seems like HBASE-1448 address this; perhaps there was a regression? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247621#comment-13247621 ] David S. Wang commented on HBASE-5645: -- OK I did get a timeout locally; I just didn't recognize it. However, I don't know where to get the information about which test timedout. It doesn't report it in the console output, and the surefire-reports stuff just contains the tests that were run to some sort of completion. Is there some place to see what was currently running when the test run timed out? [findbugs] Fix correctness warnings --- Key: HBASE-5645 URL: https://issues.apache.org/jira/browse/HBASE-5645 Project: HBase Issue Type: Sub-task Components: scripts Reporter: Jonathan Hsieh Assignee: David S. Wang Attachments: HBASE-5645.patch, HBASE-5645.patch See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Fix the warnings in the correctness section. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247730#comment-13247730 ] David S. Wang commented on HBASE-5645: -- Thanks for the pointer. Unfortunately, this doesn't seem to help: [dsw@c1502 hbase]$ dev-support/findHangingTest.sh https://builds.apache.org/job/PreCommit-HBASE-Build/1385//console % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 100 142k0 142k0 0 315k 0 --:--:-- --:--:-- --:--:-- 619k [dsw@c1502 hbase]$ Looking at findHangingTest.sh, it seems to look for Forking command line which I do not see, though we know this test run times out. [findbugs] Fix correctness warnings --- Key: HBASE-5645 URL: https://issues.apache.org/jira/browse/HBASE-5645 Project: HBase Issue Type: Sub-task Components: scripts Reporter: Jonathan Hsieh Assignee: David S. Wang Attachments: HBASE-5645.patch, HBASE-5645.patch See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Fix the warnings in the correctness section. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246454#comment-13246454 ] David S. Wang commented on HBASE-5645: -- Thanks for the review, Stack. Can this be committed now? [findbugs] Fix correctness warnings --- Key: HBASE-5645 URL: https://issues.apache.org/jira/browse/HBASE-5645 Project: HBase Issue Type: Sub-task Components: scripts Reporter: Jonathan Hsieh Assignee: David S. Wang Attachments: HBASE-5645.patch See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Fix the warnings in the correctness section. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246468#comment-13246468 ] David S. Wang commented on HBASE-5645: -- I didn't see any actual failures in the results, though the summary says that something failed. Perhaps a bug in the summary code? [findbugs] Fix correctness warnings --- Key: HBASE-5645 URL: https://issues.apache.org/jira/browse/HBASE-5645 Project: HBase Issue Type: Sub-task Components: scripts Reporter: Jonathan Hsieh Assignee: David S. Wang Attachments: HBASE-5645.patch, HBASE-5645.patch See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Fix the warnings in the correctness section. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246520#comment-13246520 ] David S. Wang commented on HBASE-5645: -- OK I see that the tests timedout. Unfortunately, I cannot tell from the output what test actually timed out. Does anyone know what command I can use locally to try and reproduce this? I didn't see any timeouts when I can mvn -PrunAllTests test before but perhaps that is not the right command. [findbugs] Fix correctness warnings --- Key: HBASE-5645 URL: https://issues.apache.org/jira/browse/HBASE-5645 Project: HBase Issue Type: Sub-task Components: scripts Reporter: Jonathan Hsieh Assignee: David S. Wang Attachments: HBASE-5645.patch, HBASE-5645.patch See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Fix the warnings in the correctness section. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5655) Cap space usage of default log4j rolling policy
[ https://issues.apache.org/jira/browse/HBASE-5655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241894#comment-13241894 ] David S. Wang commented on HBASE-5655: -- There is already a JIRA filed for this: HBASE-5608. I highly doubt that your patch is causing these tests to fail. Cap space usage of default log4j rolling policy --- Key: HBASE-5655 URL: https://issues.apache.org/jira/browse/HBASE-5655 Project: HBase Issue Type: Improvement Affects Versions: 0.92.1 Reporter: Himanshu Vashishtha Assignee: Himanshu Vashishtha Attachments: 5655-v1.patch, HBase-5655-v2.patch The current default log4j policy is to use Daily Rolling File Appender (DRFA). At times, its good to have a cap on the maximum size of the logs in order to limit its disk usage. Here is a proposal to set a new file appemder (RFA) as the default appender. It can be configured via env so that existing tools can use the current behavior of using DRFA instead. This is in parallel with jira Hadoop-8149. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5637) Fix failing 0.90 TestHMsg testcase introduced by HBASE-5563.
[ https://issues.apache.org/jira/browse/HBASE-5637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238571#comment-13238571 ] David S. Wang commented on HBASE-5637: -- This looks good to me. Fix failing 0.90 TestHMsg testcase introduced by HBASE-5563. Key: HBASE-5637 URL: https://issues.apache.org/jira/browse/HBASE-5637 Project: HBase Issue Type: Bug Affects Versions: 0.90.7 Reporter: Jonathan Hsieh Assignee: Jonathan Hsieh Attachments: hbase-5637.patch After committing HBASE-5128 and HBASE-5563 to the 0.90 branch, Ted noticed that TestHMsg#getList started to fail consistently. This updates the test to deal with the updated equality semantics in HBASE-5563. This fixes that. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5596) Few minor bugs from HBASE-5209
[ https://issues.apache.org/jira/browse/HBASE-5596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236676#comment-13236676 ] David S. Wang commented on HBASE-5596: -- Stack, this patch is to address Jon's comments in the reviewboard. I'll move UNKNOWN_SERVERNAME up into ServerName and resubmit shortly. Few minor bugs from HBASE-5209 -- Key: HBASE-5596 URL: https://issues.apache.org/jira/browse/HBASE-5596 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.92.1, 0.94.0 Reporter: David S. Wang Assignee: David S. Wang Priority: Minor Attachments: HBASE-5596.patch A few leftover bugs from HBASE-5209. Comments are documented here: https://reviews.apache.org/r/3892/ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5596) Few minor bugs from HBASE-5209
[ https://issues.apache.org/jira/browse/HBASE-5596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236764#comment-13236764 ] David S. Wang commented on HBASE-5596: -- Moved UNKNOWN_SERVERNAME to ServerName. Otherwise same patch. Passed all unit tests. Few minor bugs from HBASE-5209 -- Key: HBASE-5596 URL: https://issues.apache.org/jira/browse/HBASE-5596 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.92.1, 0.94.0 Reporter: David S. Wang Assignee: David S. Wang Priority: Minor Attachments: HBASE_5596.patch A few leftover bugs from HBASE-5209. Comments are documented here: https://reviews.apache.org/r/3892/ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5596) Few minor bugs from HBASE-5209
[ https://issues.apache.org/jira/browse/HBASE-5596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233500#comment-13233500 ] David S. Wang commented on HBASE-5596: -- I'm looking ... probably need to make some changes around the getVersionedBytes()-related calls, as stringifying them seems to be causing the problems. I might end up just putting the versioned info into the ZNode itself similar to how it is done for the masterZNode. Few minor bugs from HBASE-5209 -- Key: HBASE-5596 URL: https://issues.apache.org/jira/browse/HBASE-5596 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.92.1, 0.94.0 Reporter: David S. Wang Assignee: David S. Wang Priority: Minor Attachments: HBASE_5596.patch A few leftover bugs from HBASE-5209. Comments are documented here: https://reviews.apache.org/r/3892/ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot
[ https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233685#comment-13233685 ] David S. Wang commented on HBASE-5593: -- There is no prefix on this patch. Note that this patch only applies to 0.90 branch as that is the only branch that has this problem. Reverse DNS resolution in regionServerStartup() does not strip trailing dot --- Key: HBASE-5593 URL: https://issues.apache.org/jira/browse/HBASE-5593 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.6 Reporter: David S. Wang Assignee: David S. Wang Fix For: 0.90.7 Attachments: HBASE-5593.patch HBASE-4109 covered the removal of trailing dots in PTR records from reverse DNS lookups. We seem to have missed a case in HMaster#regionServerStartup(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot
[ https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233867#comment-13233867 ] David S. Wang commented on HBASE-5593: -- Stack, Looks like you left in the TestMaster change, and left out the TestStrings change. Is that what you meant? I'm fine either way; just want to make sure this is what you meant. Reverse DNS resolution in regionServerStartup() does not strip trailing dot --- Key: HBASE-5593 URL: https://issues.apache.org/jira/browse/HBASE-5593 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.6 Reporter: David S. Wang Assignee: David S. Wang Fix For: 0.90.7 Attachments: 5593-v2.txt, HBASE-5593.patch HBASE-4109 covered the removal of trailing dots in PTR records from reverse DNS lookups. We seem to have missed a case in HMaster#regionServerStartup(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot
[ https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232454#comment-13232454 ] David S. Wang commented on HBASE-5593: -- Ted, The patch is meant to be applied to 0.90.x branch only. The QA robot tries to apply to trunk even though I marked this bug as only for 0.90.x, so it will fail the application. Also, I do not see any @Category tags in 0.90.x branch tests, though I see them in trunk. Do you still want me to add this tag? I will change the name of the test to testMasterOnlineRegionsCorrectFormat and upload a new patch with that change as soon as I get a response to the two aforementioned observations. Reverse DNS resolution in regionServerStartup() does not strip trailing dot --- Key: HBASE-5593 URL: https://issues.apache.org/jira/browse/HBASE-5593 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.6 Reporter: David S. Wang Assignee: David S. Wang Fix For: 0.90.7 Attachments: HBASE-5593-2.patch, HBASE-5593-3.patch, HBASE-5593.patch HBASE-4109 covered the removal of trailing dots in PTR records from reverse DNS lookups. We seem to have missed a case in HMaster#regionServerStartup(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5597) Findbugs check in test-patch.sh always fails
[ https://issues.apache.org/jira/browse/HBASE-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232032#comment-13232032 ] David S. Wang commented on HBASE-5597: -- My original goal is to get test-patch.sh to pass. Actually, it would be great to just fix all of the findbugs errors, instead of having either this count or the exclude files. But evidently it has not been important enough to fix so far, or else we would not have an OK findbugs count in the first place. So I am fine with either bumping the OK findbugs count, or creating a findbugs exclusion file. Others can chime in. Findbugs check in test-patch.sh always fails Key: HBASE-5597 URL: https://issues.apache.org/jira/browse/HBASE-5597 Project: HBase Issue Type: Bug Components: scripts Affects Versions: 0.92.1, 0.94.0, 0.96.0 Reporter: David S. Wang Assignee: David S. Wang Attachments: HBASE-5597.patch Fix is to bump up OK findbugs count in test-patch.properties. Agreed to on the list. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot
[ https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231370#comment-13231370 ] David S. Wang commented on HBASE-5593: -- This will not apply to trunk as the robot is trying to do, because the fix is only applicable to 0.90.x. Also, I can add a test case if necessary, though I think the fix is fairly obvious in this case. Let me know. Reverse DNS resolution in regionServerStartup() does not strip trailing dot --- Key: HBASE-5593 URL: https://issues.apache.org/jira/browse/HBASE-5593 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.6 Reporter: David S. Wang Assignee: David S. Wang Fix For: 0.90.7 Attachments: HBASE-5593.patch HBASE-4109 covered the removal of trailing dots in PTR records from reverse DNS lookups. We seem to have missed a case in HMaster#regionServerStartup(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5567) test-patch.sh has logic error in findbugs check
[ https://issues.apache.org/jira/browse/HBASE-5567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227941#comment-13227941 ] David S. Wang commented on HBASE-5567: -- Sorry I didn't catch this one earlier ... would have included it in the previous patch. test-patch.sh has logic error in findbugs check --- Key: HBASE-5567 URL: https://issues.apache.org/jira/browse/HBASE-5567 Project: HBase Issue Type: Bug Components: scripts Affects Versions: 0.94.0, 0.96.0 Reporter: David S. Wang Assignee: David S. Wang Priority: Trivial Labels: noob Attachments: HBASE_5567.patch Similar bug to HBASE-5562. The wrong operator is used in the check against $OK_FINDBUGS_WARNINGS. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5209) HConnection/HMasterInterface should allow for way to get hostname of currently active master in multi-master HBase setup
[ https://issues.apache.org/jira/browse/HBASE-5209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13212610#comment-13212610 ] David S. Wang commented on HBASE-5209: -- Yes, the commit for 0.92 did not include the: ZKUtil.createAndFailSilent(this, backupMasterAddressesZNode); line from my patch. Stack, can you please add this line into 0.92? That should fix the current test error on 0.92 as well. Thanks. HConnection/HMasterInterface should allow for way to get hostname of currently active master in multi-master HBase setup Key: HBASE-5209 URL: https://issues.apache.org/jira/browse/HBASE-5209 Project: HBase Issue Type: Improvement Components: master Affects Versions: 0.94.0, 0.90.5, 0.92.0 Reporter: Aditya Acharya Assignee: David S. Wang Fix For: 0.94.0, 0.92.1 Attachments: HBASE_5209_v5.diff I have a multi-master HBase set up, and I'm trying to programmatically determine which of the masters is currently active. But the API does not allow me to do this. There is a getMaster() method in the HConnection class, but it returns an HMasterInterface, whose methods do not allow me to find out which master won the last race. The API should have a getActiveMasterHostname() or something to that effect. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5209) HConnection/HMasterInterface should allow for way to get hostname of currently active master in multi-master HBase setup
[ https://issues.apache.org/jira/browse/HBASE-5209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13213068#comment-13213068 ] David S. Wang commented on HBASE-5209: -- Thanks Ted. Looks good to me. This is for 0.92 only I'm assuming, as trunk already has this. HConnection/HMasterInterface should allow for way to get hostname of currently active master in multi-master HBase setup Key: HBASE-5209 URL: https://issues.apache.org/jira/browse/HBASE-5209 Project: HBase Issue Type: Improvement Components: master Affects Versions: 0.94.0, 0.90.5, 0.92.0 Reporter: Aditya Acharya Assignee: David S. Wang Fix For: 0.94.0, 0.92.1 Attachments: 5209.addendum, HBASE_5209_v5.diff I have a multi-master HBase set up, and I'm trying to programmatically determine which of the masters is currently active. But the API does not allow me to do this. There is a getMaster() method in the HConnection class, but it returns an HMasterInterface, whose methods do not allow me to find out which master won the last race. The API should have a getActiveMasterHostname() or something to that effect. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5209) HConnection/HMasterInterface should allow for way to get hostname of currently active master in multi-master HBase setup
[ https://issues.apache.org/jira/browse/HBASE-5209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13210818#comment-13210818 ] David S. Wang commented on HBASE-5209: -- Stack, Thanks for the review. I am a bit confused about your previous comment though: I do not update HMasterInterface in my latest patch, nor do I change anything related to isActiveMaster. The only version that I update is VERSION for ClusterStatus, and I already add the new fields to the end with my current patch. I think perhaps that is what you are referring to. I did two tests with hbase hbck -details to test ClusterStatus: 1. I tested old client (top of trunk 0.92) with new server (0.92 with my patch but without bumping VERSION), and things worked fine. 2. I tested new client (0.92 with my patch but without bumping VERSION), with old server (top of trunk 0.92), and got the following error. I'm thinking because the new client expects the new fields I added that the old server never sends. Is this OK behavior? INFO zookeeper.ClientCnxn: Session establishment complete on server haus02.sf.cloudera.com/172.29.5.33:30181, sessionid = 0x1358ef9f91b000b, negotiated timeout = 5000 [... pauses for some time ...] 12/02/17 15:51:46 ERROR io.HbaseObjectWritable: Error in readFields java.net.SocketTimeoutException: 6 millis timeout while waiting for channel to be ready for read. ch : java.nio.channels.SocketChannel[connected local=/172.29.5.33:41223 remote=haus04.sf.cloudera.com/172.29.5.35:31000] at org.apache.hadoop.net.SocketIOWithTimeout.doIO(SocketIOWithTimeout.java:164) at org.apache.hadoop.net.SocketInputStream.read(SocketInputStream.java:155) at org.apache.hadoop.net.SocketInputStream.read(SocketInputStream.java:128) at java.io.FilterInputStream.read(FilterInputStream.java:116) at org.apache.hadoop.hbase.ipc.HBaseClient$Connection$PingInputStream.read(HBaseClient.java:311) at java.io.BufferedInputStream.fill(BufferedInputStream.java:218) at java.io.BufferedInputStream.read(BufferedInputStream.java:237) at java.io.DataInputStream.readByte(DataInputStream.java:248) at org.apache.hadoop.io.WritableUtils.readVLong(WritableUtils.java:299) at org.apache.hadoop.io.WritableUtils.readVInt(WritableUtils.java:320) at org.apache.hadoop.hbase.util.Bytes.readByteArray(Bytes.java:146) at org.apache.hadoop.hbase.ClusterStatus.readFields(ClusterStatus.java:334) at org.apache.hadoop.hbase.io.HbaseObjectWritable.readObject(HbaseObjectWritable.java:647) at org.apache.hadoop.hbase.io.HbaseObjectWritable.readFields(HbaseObjectWritable.java:311) at org.apache.hadoop.hbase.ipc.HBaseClient$Connection.receiveResponse(HBaseClient.java:593) at org.apache.hadoop.hbase.ipc.HBaseClient$Connection.run(HBaseClient.java:50 HConnection/HMasterInterface should allow for way to get hostname of currently active master in multi-master HBase setup Key: HBASE-5209 URL: https://issues.apache.org/jira/browse/HBASE-5209 Project: HBase Issue Type: Improvement Components: master Affects Versions: 0.94.0, 0.90.5, 0.92.0 Reporter: Aditya Acharya Assignee: David S. Wang Fix For: 0.94.0, 0.90.7, 0.92.1 Attachments: HBASE-5209-v0.diff, HBASE-5209-v1.diff I have a multi-master HBase set up, and I'm trying to programmatically determine which of the masters is currently active. But the API does not allow me to do this. There is a getMaster() method in the HConnection class, but it returns an HMasterInterface, whose methods do not allow me to find out which master won the last race. The API should have a getActiveMasterHostname() or something to that effect. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5209) HConnection/HMasterInterface should allow for way to get hostname of currently active master in multi-master HBase setup
[ https://issues.apache.org/jira/browse/HBASE-5209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205979#comment-13205979 ] David S. Wang commented on HBASE-5209: -- I'm going to take out isActiveMaster and isMasterRunning, which I think will address the bulk of the comments. Agree that we should be able to assume that if master is not null, that it is the active one. When I have a new patch ready, I'll use reviewboard. Thanks for the helpful comments; I appreciate them and ask for your understanding as this is my first upstream commit. HConnection/HMasterInterface should allow for way to get hostname of currently active master in multi-master HBase setup Key: HBASE-5209 URL: https://issues.apache.org/jira/browse/HBASE-5209 Project: HBase Issue Type: Improvement Components: master Affects Versions: 0.94.0, 0.90.5, 0.92.0 Reporter: Aditya Acharya Assignee: David S. Wang Fix For: 0.94.0, 0.90.7, 0.92.1 Attachments: HBASE-5209-v0.diff, HBASE-5209-v1.diff I have a multi-master HBase set up, and I'm trying to programmatically determine which of the masters is currently active. But the API does not allow me to do this. There is a getMaster() method in the HConnection class, but it returns an HMasterInterface, whose methods do not allow me to find out which master won the last race. The API should have a getActiveMasterHostname() or something to that effect. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5209) HConnection/HMasterInterface should allow for way to get hostname of currently active master in multi-master HBase setup
[ https://issues.apache.org/jira/browse/HBASE-5209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205270#comment-13205270 ] David S. Wang commented on HBASE-5209: -- I also ran hbase hbck -details successfully in order to exercise the changes in HBaseFsck.java. HConnection/HMasterInterface should allow for way to get hostname of currently active master in multi-master HBase setup Key: HBASE-5209 URL: https://issues.apache.org/jira/browse/HBASE-5209 Project: HBase Issue Type: Improvement Components: master Affects Versions: 0.94.0, 0.90.5, 0.92.0 Reporter: Aditya Acharya Assignee: David S. Wang Fix For: 0.94.0, 0.92.1 Attachments: HBASE-5209-v0.diff I have a multi-master HBase set up, and I'm trying to programmatically determine which of the masters is currently active. But the API does not allow me to do this. There is a getMaster() method in the HConnection class, but it returns an HMasterInterface, whose methods do not allow me to find out which master won the last race. The API should have a getActiveMasterHostname() or something to that effect. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
