[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-20 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258373#comment-13258373 ] Jimmy Xiang commented on HBASE-5824: Yes, this patch is for 0.96 only.

[jira] [Commented] (HBASE-5621) Convert admin protocol of HRegionInterface to PB

2012-04-20 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258379#comment-13258379 ] Jimmy Xiang commented on HBASE-5621: Looking into the failed unit tests.

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-20 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258381#comment-13258381 ] Jimmy Xiang commented on HBASE-5824: @Ted, I filed HBASE-5845. Thanks for pointing

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-19 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257865#comment-13257865 ] Jimmy Xiang commented on HBASE-5824: If autoFlush is not enabled, Puts are most likely

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-19 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257904#comment-13257904 ] Jimmy Xiang commented on HBASE-5824: I am looking into it.

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-18 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257083#comment-13257083 ] Jimmy Xiang commented on HBASE-5824: I will add a unit test for this and fix it.

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-18 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257143#comment-13257143 ] Jimmy Xiang commented on HBASE-5824: I looked into it and it seems not a bug.

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-17 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255704#comment-13255704 ] Jimmy Xiang commented on HBASE-5620: @Stack, not every invocation will throw an

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-16 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254979#comment-13254979 ] Jimmy Xiang commented on HBASE-5620: I did some testing with YCSB (mostly inserts).

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-15 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254360#comment-13254360 ] Jimmy Xiang commented on HBASE-5620: Thanks for reviewing. Both regular test suite and

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-14 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254153#comment-13254153 ] Jimmy Xiang commented on HBASE-5620: @Stack, thanks. @Ted, I am looking into it now.

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-14 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254216#comment-13254216 ] Jimmy Xiang commented on HBASE-5620: TestForceCacheImportantBlocks is green for me.

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-13 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253377#comment-13253377 ] Jimmy Xiang commented on HBASE-5620: I will take a look at the test failures.

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-13 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253538#comment-13253538 ] Jimmy Xiang commented on HBASE-5620: TestWALPlayer passed for me. I didn't have the

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-13 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253799#comment-13253799 ] Jimmy Xiang commented on HBASE-5620: @Stack, I will move ClientProtocol.java and

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-13 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253840#comment-13253840 ] Jimmy Xiang commented on HBASE-5620: I ran Apache Rat check like mvn apache-rat:check,

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-13 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253852#comment-13253852 ] Jimmy Xiang commented on HBASE-5620: @Stack, thanks a lot! I moved them to top-level

[jira] [Commented] (HBASE-5777) MiniHBaseCluster cannot start multiple region servers

2012-04-12 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252899#comment-13252899 ] Jimmy Xiang commented on HBASE-5777: I see. When I run unit tests in eclipse, the

[jira] [Commented] (HBASE-5740) Compaction interruption may be due to balacing

2012-04-09 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249951#comment-13249951 ] Jimmy Xiang commented on HBASE-5740: @JD, any comments on the second patch?

[jira] [Commented] (HBASE-5740) Compaction interruption may be due to balacing

2012-04-09 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250267#comment-13250267 ] Jimmy Xiang commented on HBASE-5740: @Stack, I am fine with the generic message.

[jira] [Commented] (HBASE-5734) Change hbck sideline root

2012-04-06 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248511#comment-13248511 ] Jimmy Xiang commented on HBASE-5734: It is nice to expose it as an argument. However,

[jira] [Commented] (HBASE-5740) Compaction interruption may be due to balacing

2012-04-06 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249045#comment-13249045 ] Jimmy Xiang commented on HBASE-5740: Add a new patch, and not saying who trigged it

[jira] [Commented] (HBASE-5606) SplitLogManger async delete node hangs log splitting when ZK connection is lost

2012-04-03 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245763#comment-13245763 ] Jimmy Xiang commented on HBASE-5606: It is ok with me. Hopefully, there is no other

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-04-01 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243954#comment-13243954 ] Jimmy Xiang commented on HBASE-5443: The main reason is that the HBase writable RPC

[jira] [Commented] (HBASE-5619) Create PB protocols for HRegionInterface

2012-03-30 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242720#comment-13242720 ] Jimmy Xiang commented on HBASE-5619: @Stack, thanks! Create PB

[jira] [Commented] (HBASE-5619) Create PB protocols for HRegionInterface

2012-03-29 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241374#comment-13241374 ] Jimmy Xiang commented on HBASE-5619: @Stack, could you please commit this patch? I do

[jira] [Commented] (HBASE-5619) Create PB protocols for HRegionInterface

2012-03-29 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241622#comment-13241622 ] Jimmy Xiang commented on HBASE-5619: @Stack, could you please install protoc and give

[jira] [Commented] (HBASE-5619) Create PB protocols for HRegionInterface

2012-03-29 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241819#comment-13241819 ] Jimmy Xiang commented on HBASE-5619: @Stack, so far, I could not find a good protoc

[jira] [Commented] (HBASE-5667) RegexStringComparator supports java.util.regex.Pattern flags

2012-03-29 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241861#comment-13241861 ] Jimmy Xiang commented on HBASE-5667: @Stack, I prefer to change them to pb so we

[jira] [Commented] (HBASE-5667) RegexStringComparator supports java.util.regex.Pattern flags

2012-03-29 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241870#comment-13241870 ] Jimmy Xiang commented on HBASE-5667: For this patch, it changes the constructor of

[jira] [Commented] (HBASE-5619) Create PB protocols for HRegionInterface

2012-03-29 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241880#comment-13241880 ] Jimmy Xiang commented on HBASE-5619: But for proto files, other projects depend on

[jira] [Commented] (HBASE-5667) RegexStringComparator supports java.util.regex.Pattern flags

2012-03-29 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241914#comment-13241914 ] Jimmy Xiang commented on HBASE-5667: Pattern is fine if we can get it.

[jira] [Commented] (HBASE-5619) Create PB protocols for HRegionInterface

2012-03-29 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241954#comment-13241954 ] Jimmy Xiang commented on HBASE-5619: That's what do for thrift now, not avro.

[jira] [Commented] (HBASE-5606) SplitLogManger async delete node hangs log splitting when ZK connection is lost

2012-03-26 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238811#comment-13238811 ] Jimmy Xiang commented on HBASE-5606: @Prakash, could there be other places which

[jira] [Commented] (HBASE-5606) SplitLogManger async delete node hangs log splitting when ZK connection is lost

2012-03-24 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237647#comment-13237647 ] Jimmy Xiang commented on HBASE-5606: This is similar issue as HBASE-5081, right? Will

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-03-22 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235780#comment-13235780 ] Jimmy Xiang commented on HBASE-5443: I have done some code changes, and some tests

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-03-02 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221155#comment-13221155 ] Jimmy Xiang commented on HBASE-5443: I updated the review with new diff, which

[jira] [Commented] (HBASE-5451) Switch RPC call envelope/headers to PBs

2012-03-02 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221166#comment-13221166 ] Jimmy Xiang commented on HBASE-5451: I hope we can. I know the RPC won't be backward

[jira] [Commented] (HBASE-5451) Switch RPC call envelope/headers to PBs

2012-03-01 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13220249#comment-13220249 ] Jimmy Xiang commented on HBASE-5451: I did a quick review last night. Looks ok with

[jira] [Commented] (HBASE-3909) Add dynamic config

2012-03-01 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13220404#comment-13220404 ] Jimmy Xiang commented on HBASE-3909: If they lose them, it could be very bad. It may

[jira] [Commented] (HBASE-5270) Handle potential data loss due to concurrent processing of processFaileOver and ServerShutdownHandler

2012-02-27 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13217364#comment-13217364 ] Jimmy Xiang commented on HBASE-5270: @Stack, I agree. I think we should reuse the

[jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface

2012-02-27 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13217442#comment-13217442 ] Jimmy Xiang commented on HBASE-5443: We can still support multi(MultiAction). Should

[jira] [Commented] (HBASE-3909) Add dynamic config

2012-02-26 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13216758#comment-13216758 ] Jimmy Xiang commented on HBASE-3909: @Stack, we don't have to poll fs to find

[jira] [Commented] (HBASE-3909) Add dynamic config

2012-02-24 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13216095#comment-13216095 ] Jimmy Xiang commented on HBASE-3909: Can we put dynamic configuration somewhere in the

[jira] [Commented] (HBASE-3909) Add dynamic config

2012-02-24 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13216105#comment-13216105 ] Jimmy Xiang commented on HBASE-3909: For these dynamic configurations, we can cache

[jira] [Commented] (HBASE-5270) Handle potential data loss due to concurrent processing of processFaileOver and ServerShutdownHandler

2012-02-24 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13216114#comment-13216114 ] Jimmy Xiang commented on HBASE-5270: Instead of introducing safe mode, can we add

[jira] [Commented] (HBASE-3909) Add dynamic config

2012-02-24 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13216131#comment-13216131 ] Jimmy Xiang commented on HBASE-3909: Yes, I meant transparent to configuration reader.

[jira] [Commented] (HBASE-5472) LoadIncrementalHFiles loops forever if the target table misses a CF

2012-02-24 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13216141#comment-13216141 ] Jimmy Xiang commented on HBASE-5472: In such a case, should the tool ignore the

[jira] [Commented] (HBASE-4403) Adopt interface stability/audience classifications from Hadoop

2012-02-22 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13214146#comment-13214146 ] Jimmy Xiang commented on HBASE-4403: It should use hbase-4403.patch instead of

[jira] [Commented] (HBASE-4403) Adopt interface stability/audience classifications from Hadoop

2012-02-17 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13210666#comment-13210666 ] Jimmy Xiang commented on HBASE-4403: Sounds great. Adopt interface

[jira] [Commented] (HBASE-4403) Adopt interface stability/audience classifications from Hadoop

2012-02-16 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13209738#comment-13209738 ] Jimmy Xiang commented on HBASE-4403: @Stack, thanks a lot for review. I will

[jira] [Commented] (HBASE-4403) Adopt interface stability/audience classifications from Hadoop

2012-02-16 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13209772#comment-13209772 ] Jimmy Xiang commented on HBASE-4403: Cool, thanks. Please add the definitions to the

[jira] [Commented] (HBASE-4403) Adopt interface stability/audience classifications from Hadoop

2012-02-16 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13209901#comment-13209901 ] Jimmy Xiang commented on HBASE-4403: Yes, I will do that in a separate jira.

[jira] [Commented] (HBASE-5394) Add ability to include Protobufs in HbaseObjectWritable

2012-02-15 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208584#comment-13208584 ] Jimmy Xiang commented on HBASE-5394: These tests are passed on my local box.

[jira] [Commented] (HBASE-5398) HBase shell disable_all/enable_all/drop_all promp wrong tables for confirmation

2012-02-14 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207914#comment-13207914 ] Jimmy Xiang commented on HBASE-5398: Yes, it takes a regex pattern and disable all

[jira] [Commented] (HBASE-5312) Closed parent region present in Hlog.lastSeqWritten

2012-02-10 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205596#comment-13205596 ] Jimmy Xiang commented on HBASE-5312: I checked the lock mechanism and it looks fine.

[jira] [Commented] (HBASE-5376) Add more logging to triage HBASE-5312: Closed parent region present in Hlog.lastSeqWritten

2012-02-10 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205636#comment-13205636 ] Jimmy Xiang commented on HBASE-5376: I was thinking to use YCSB to load lots of data

[jira] [Commented] (HBASE-5327) Print a message when an invalid hbase.rootdir is passed

2012-02-10 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205778#comment-13205778 ] Jimmy Xiang commented on HBASE-5327: I looked into it. For new Path(path), the path

[jira] [Commented] (HBASE-5327) Print a message when an invalid hbase.rootdir is passed

2012-02-09 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204714#comment-13204714 ] Jimmy Xiang commented on HBASE-5327: This patch fix two issues: (1) check the root dir

[jira] [Commented] (HBASE-5327) Print a message when an invalid hbase.rootdir is passed

2012-02-09 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205064#comment-13205064 ] Jimmy Xiang commented on HBASE-5327: I prefer the first version actually. If the root

[jira] [Commented] (HBASE-5312) Closed parent region present in Hlog.lastSeqWritten

2012-02-09 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205214#comment-13205214 ] Jimmy Xiang commented on HBASE-5312: Have anyone seen this issue on 0.92 release?

[jira] [Commented] (HBASE-5221) bin/hbase script doesn't look for Hadoop jars in the right place in trunk layout

2012-02-08 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203675#comment-13203675 ] Jimmy Xiang commented on HBASE-5221: Since 0.23, Hadoop re-organized the folder

[jira] [Commented] (HBASE-5221) bin/hbase script doesn't look for Hadoop jars in the right place in trunk layout

2012-02-08 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203807#comment-13203807 ] Jimmy Xiang commented on HBASE-5221: The problem is that when I run hbase shell, it

[jira] [Commented] (HBASE-5221) bin/hbase script doesn't look for Hadoop jars in the right place in trunk layout

2012-02-08 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203810#comment-13203810 ] Jimmy Xiang commented on HBASE-5221: Ok, let me close it as dup. Probably, I just use

[jira] [Commented] (HBASE-5353) HA/Distributed HMaster via RegionServers

2012-02-08 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203909#comment-13203909 ] Jimmy Xiang commented on HBASE-5353: Another option is not to have a master, every

[jira] [Commented] (HBASE-5317) Fix TestHFileOutputFormat to work against hadoop 0.23

2012-02-04 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13200575#comment-13200575 ] Jimmy Xiang commented on HBASE-5317: @Ted, did you run it with Hadoop 0.23?

[jira] [Commented] (HBASE-5310) HConnectionManager server cache key enhancement

2012-02-01 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13197984#comment-13197984 ] Jimmy Xiang commented on HBASE-5310: @Ted, thanks for review and integration.

[jira] [Commented] (HBASE-5281) Should a failure in creating an unassigned node abort the master?

2012-01-31 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13197440#comment-13197440 ] Jimmy Xiang commented on HBASE-5281: I think it is safer to retry certain times before

[jira] [Commented] (HBASE-5281) Should a failure in creating an unassigned node abort the master?

2012-01-31 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13197472#comment-13197472 ] Jimmy Xiang commented on HBASE-5281: The issue Harsh reported is from a customer using

[jira] [Commented] (HBASE-5210) HFiles are missing from an incremental load

2012-01-23 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13191310#comment-13191310 ] Jimmy Xiang commented on HBASE-5210: Any fix in getRandomFilename will just reduce the

[jira] [Commented] (HBASE-5210) HFiles are missing from an incremental load

2012-01-23 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13191351#comment-13191351 ] Jimmy Xiang commented on HBASE-5210: I like this one. It's really simple and clean.

[jira] [Commented] (HBASE-5196) Failure in region split after PONR could cause region hole

2012-01-17 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13187816#comment-13187816 ] Jimmy Xiang commented on HBASE-5196: Yes, the test suite on 0.90 with the patch

[jira] [Commented] (HBASE-5196) Failure in region split after PONR could cause region hole

2012-01-16 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13187318#comment-13187318 ] Jimmy Xiang commented on HBASE-5196: I attached a patch for 0.90 branch:

[jira] [Commented] (HBASE-5196) Failure in region split after PONR could cause region hole

2012-01-16 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13187332#comment-13187332 ] Jimmy Xiang commented on HBASE-5196: @Ted, I ran the test suite, and verified the fix

[jira] [Commented] (HBASE-5136) Redundant MonitoredTask instances in case of distributed log splitting retry

2012-01-13 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185688#comment-13185688 ] Jimmy Xiang commented on HBASE-5136: Instead of reuse the same status object, can we

[jira] [Commented] (HBASE-5174) Coalesce aborted tasks in the TaskMonitor

2012-01-13 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185694#comment-13185694 ] Jimmy Xiang commented on HBASE-5174: Failed or aborted tasks should not be displayed

[jira] [Commented] (HBASE-5174) Coalesce aborted tasks in the TaskMonitor

2012-01-13 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185701#comment-13185701 ] Jimmy Xiang commented on HBASE-5174: I meant we can not just show the failed or

[jira] [Commented] (HBASE-5196) Failure in region split after PONR could cause region hole

2012-01-13 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185760#comment-13185760 ] Jimmy Xiang commented on HBASE-5196: I have a simple fix. When the master starts up,

[jira] [Commented] (HBASE-5196) Failure in region split after PONR could cause region hole

2012-01-13 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185856#comment-13185856 ] Jimmy Xiang commented on HBASE-5196: Yes, it is good. Thanks Ted. These failed tests

[jira] [Commented] (HBASE-5150) Fail in a thread may not fail a test, clean up log splitting test

2012-01-11 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184221#comment-13184221 ] Jimmy Xiang commented on HBASE-5150: Those failed tests passed on my local box.

[jira] [Commented] (HBASE-5150) Fail in a thread may not fail a test, clean up log splitting test

2012-01-11 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184234#comment-13184234 ] Jimmy Xiang commented on HBASE-5150: @Prakash and Ted, are you ok with this patch? I

[jira] [Commented] (HBASE-5081) Distributed log splitting deleteNode races against splitLog retry

2012-01-06 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13181407#comment-13181407 ] Jimmy Xiang commented on HBASE-5081: It turns out all my region servers died. I

[jira] [Commented] (HBASE-5081) Distributed log splitting deleteNode races against splitLog retry

2012-01-06 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13181451#comment-13181451 ] Jimmy Xiang commented on HBASE-5081: Now, all logs are split. I am happy with the

[jira] [Commented] (HBASE-5081) Distributed log splitting deleteNode races against splitLog retry

2012-01-06 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13181457#comment-13181457 ] Jimmy Xiang commented on HBASE-5081: @Stack, yes, it will screw up the cluster (7

[jira] [Commented] (HBASE-5081) Distributed log splitting deleteNode races against splitLog retry

2012-01-05 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13181087#comment-13181087 ] Jimmy Xiang commented on HBASE-5081: It hangs again. In the region server log, I saw

[jira] [Commented] (HBASE-5099) ZK event thread waiting for root region assignment may block server shutdown handler for the region sever the root region was on

2011-12-30 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177847#comment-13177847 ] Jimmy Xiang commented on HBASE-5099: TestReplication is flaky. But it works on my

[jira] [Commented] (HBASE-5099) ZK event thread waiting for root region assignment may block server shutdown handler for the region sever the root region was on

2011-12-30 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177860#comment-13177860 ] Jimmy Xiang commented on HBASE-5099: I tried to debug this testcase but it doesn't

[jira] [Commented] (HBASE-5099) ZK event thread waiting for root region assignment may block server shutdown handler for the region sever the root region was on

2011-12-30 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177886#comment-13177886 ] Jimmy Xiang commented on HBASE-5099: TestReplication#queueFailover has a bug that's

[jira] [Commented] (HBASE-5112) TestReplication#queueFailover flaky due to code error

2011-12-30 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177887#comment-13177887 ] Jimmy Xiang commented on HBASE-5112: @Ted, could you please give this patch a try on

[jira] [Commented] (HBASE-5099) ZK event thread waiting for root region while server shutdown handler waiting for event thread to finish distributed log splitting to recover the region sever the root

2011-12-29 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177417#comment-13177417 ] Jimmy Xiang commented on HBASE-5099: @Ted, thanks! ZK event thread

[jira] [Commented] (HBASE-5099) ZK event thread waiting for root region while server shutdown handler waiting for event thread to finish distributed log splitting to recover the region sever the root

2011-12-29 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177446#comment-13177446 ] Jimmy Xiang commented on HBASE-5099: There is no harm to call shutdownNow() even if

[jira] [Commented] (HBASE-5099) ZK event thread waiting for root region while server shutdown handler waiting for event thread to finish distributed log splitting to recover the region sever the root

2011-12-28 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176778#comment-13176778 ] Jimmy Xiang commented on HBASE-5099: Cool, let me submit a patch. ZK

[jira] [Commented] (HBASE-5099) ZK event thread waiting for root region while server shutdown handler waiting for event thread to finish distributed log splitting to recover the region sever the root

2011-12-27 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176430#comment-13176430 ] Jimmy Xiang commented on HBASE-5099: This is good. If introducing a timeout, I prefer

[jira] [Commented] (HBASE-5099) ZK event thread waiting for root region while server shutdown handler waiting for event thread to finish distributed log splitting to recover the region sever the root

2011-12-27 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176447#comment-13176447 ] Jimmy Xiang commented on HBASE-5099: tryRecoveringExpiredZKSession() is only called by

[jira] [Commented] (HBASE-5081) Distributed log splitting deleteNode races againsth splitLog retry

2011-12-22 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175155#comment-13175155 ] Jimmy Xiang commented on HBASE-5081: @Stack, it is not an orphan task. It happens in

[jira] [Commented] (HBASE-5081) Distributed log splitting deleteNode races againsth splitLog retry

2011-12-22 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175158#comment-13175158 ] Jimmy Xiang commented on HBASE-5081: @Prakash, this one didn't happen when the master

[jira] [Commented] (HBASE-5081) Distributed log splitting deleteNode races againsth splitLog retry

2011-12-21 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13174180#comment-13174180 ] Jimmy Xiang commented on HBASE-5081: I am working on a path now. I think synchronous

[jira] [Commented] (HBASE-5081) Distributed log splitting deleteNode races againsth splitLog retry

2011-12-21 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13174187#comment-13174187 ] Jimmy Xiang commented on HBASE-5081: Can we deleteNode only if it is successfully

[jira] [Commented] (HBASE-5081) Distributed log splitting deleteNode races againsth splitLog retry

2011-12-21 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13174251#comment-13174251 ] Jimmy Xiang commented on HBASE-5081: The patch is for both 0.92 and 0.94 actually.

[jira] [Commented] (HBASE-5081) Distributed log splitting deleteNode races againsth splitLog retry

2011-12-21 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13174357#comment-13174357 ] Jimmy Xiang commented on HBASE-5081: I am thinking about sync delete for the failure

  1   2   >