[jira] [Resolved] (HBASE-5708) [89-fb] Make MiniMapRedCluster directory a subdirectory of target/test
[ https://issues.apache.org/jira/browse/HBASE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Bautin resolved HBASE-5708. --- Resolution: Fixed Closing this as 89-fb is sufficiently different from trunk as far test setup is concerned. Similar work in trunk would require running unit tests there many times and fixing whatever issues come up. > [89-fb] Make MiniMapRedCluster directory a subdirectory of target/test > -- > > Key: HBASE-5708 > URL: https://issues.apache.org/jira/browse/HBASE-5708 > Project: HBase > Issue Type: Bug >Reporter: Mikhail Bautin >Priority: Minor > Attachments: D2601.1.patch, D2601.2.patch, D2601.3.patch, > D2601.4.patch > > > Some map-reduce-based tests are failing when executed concurrently in 89-fb > because mini-map-reduce cluster uses /tmp/hadoop- for temporary > data. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-5730) [89-fb] Make HRegionThriftServer's thread pool bounded
[ https://issues.apache.org/jira/browse/HBASE-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Bautin resolved HBASE-5730. --- Resolution: Fixed Committed internally. > [89-fb] Make HRegionThriftServer's thread pool bounded > -- > > Key: HBASE-5730 > URL: https://issues.apache.org/jira/browse/HBASE-5730 > Project: HBase > Issue Type: Bug >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin > > This JIRA is for a quick fix in 89-fb to reuse TBoundedThreadPoolServer in > HRegionThriftServer. We will address whatever problems HRegionThriftServer > still has in trunk in HBASE-5703. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-5731) Make max line length 100 in linter
[ https://issues.apache.org/jira/browse/HBASE-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Bautin resolved HBASE-5731. --- Resolution: Fixed Committed in 89-fb and trunk. > Make max line length 100 in linter > -- > > Key: HBASE-5731 > URL: https://issues.apache.org/jira/browse/HBASE-5731 > Project: HBase > Issue Type: New Feature >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin >Priority: Minor > Attachments: D2625.1.patch, D2631.1.patch > > > We have switched to 100 characters per line in our Java files. Making the > change in the linter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-5700) [89-fb] Fix TestMiniClusterLoad* test failures
[ https://issues.apache.org/jira/browse/HBASE-5700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Bautin resolved HBASE-5700. --- Resolution: Fixed Committed internally > [89-fb] Fix TestMiniClusterLoad* test failures > -- > > Key: HBASE-5700 > URL: https://issues.apache.org/jira/browse/HBASE-5700 > Project: HBase > Issue Type: Bug >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin >Priority: Minor > Attachments: D2583.1.patch > > > Porting TestMiniClusterLoad* tests to 89-fb in HBASE-5679 uncovered certain > problems with mini-cluster setup in 89-fb that need to be fixed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-5679) [89-fb] Port load test tool and related unit tests from trunk to 89-fb
[ https://issues.apache.org/jira/browse/HBASE-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Bautin resolved HBASE-5679. --- Resolution: Fixed Committed internally. > [89-fb] Port load test tool and related unit tests from trunk to 89-fb > -- > > Key: HBASE-5679 > URL: https://issues.apache.org/jira/browse/HBASE-5679 > Project: HBase > Issue Type: Test >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin > > When open-sourcing LoadTestTool that originated in 89-fb, numerous > improvements to the tool were made, and unit tests based on the tool were > created as part of HBASE-4908. These improvements need to be ported back to > 89-fb. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-5605) compression does not work in Store.java trunk
[ https://issues.apache.org/jira/browse/HBASE-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Bautin resolved HBASE-5605. --- Resolution: Fixed This has been committed into trunk and in 89-fb. > compression does not work in Store.java trunk > - > > Key: HBASE-5605 > URL: https://issues.apache.org/jira/browse/HBASE-5605 > Project: HBase > Issue Type: Bug >Reporter: He Yongqiang >Assignee: He Yongqiang > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-5566) [89-fb] Region server can get stuck in getMaster on master failover
[ https://issues.apache.org/jira/browse/HBASE-5566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Bautin resolved HBASE-5566. --- Resolution: Fixed Patch committed internally, will be synced to 0.89-fb very soon. > [89-fb] Region server can get stuck in getMaster on master failover > --- > > Key: HBASE-5566 > URL: https://issues.apache.org/jira/browse/HBASE-5566 > Project: HBase > Issue Type: Bug >Affects Versions: 0.89-fb >Reporter: Prakash Khemani >Assignee: Mikhail Bautin > > This is specific to the 89-fb master. We have a retry loop in > HRegionServer.getMaster where we do not read the location of the master from > ZK, so a region server can get stuck there on master failover. We need to add > a unit test to reliably catch this, and fix the bug. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-5575) Configure Arcanist lint engine for HBase
[ https://issues.apache.org/jira/browse/HBASE-5575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Bautin resolved HBASE-5575. --- Resolution: Fixed Committed to trunk. > Configure Arcanist lint engine for HBase > > > Key: HBASE-5575 > URL: https://issues.apache.org/jira/browse/HBASE-5575 > Project: HBase > Issue Type: Improvement >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin > Attachments: Enabling-lint-2012-03-16_13_40_37.patch > > > We need to enable Arcanist lint engine in HBase, so that a commit could be > checked by running "arc lint". -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-5576) Configure Arcanist lint engine for HBase
[ https://issues.apache.org/jira/browse/HBASE-5576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Bautin resolved HBASE-5576. --- Resolution: Duplicate See HBASE-5575. For some reason new JIRAs are not immediately visible, so I ended up creating a duplicate. > Configure Arcanist lint engine for HBase > > > Key: HBASE-5576 > URL: https://issues.apache.org/jira/browse/HBASE-5576 > Project: HBase > Issue Type: Improvement >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin > > We need to be able to use "arc lint" to check a patch for code style errors > before submission. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-5557) [89-fb] Fix incorrect reader/writer thread interaction in HBaseTest
[ https://issues.apache.org/jira/browse/HBASE-5557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Bautin resolved HBASE-5557. --- Resolution: Fixed > [89-fb] Fix incorrect reader/writer thread interaction in HBaseTest > --- > > Key: HBASE-5557 > URL: https://issues.apache.org/jira/browse/HBASE-5557 > Project: HBase > Issue Type: Bug >Affects Versions: 0.89-fb >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin >Priority: Minor > Attachments: D2235.1.patch > > > In the HBaseTest load test we have a condition when the writer has not > written any keys but the reader might attempt to read key 0, resulting in a > failure. This bug is specific to 89-fb because it has been fixed while > open-sourcing HBaseTest as LoadTestTool, and those improvements still have > not been back-ported to 89-fb. Doing a temporary fix now and we will get to > the back-port later. > 12/03/09 14:12:52 INFO utils.MultiThreadedReader: Key = > cfcd208495d565ef66e7dff9f98764da:0 > 12/03/09 14:12:52 ERROR utils.MultiThreadedReader: No data returned, tried to > get actions for key = cfcd208495d565ef66e7dff9f98764da:0 > 12/03/09 14:12:52 INFO utils.MultiThreadedReader: Key = > cfcd208495d565ef66e7dff9f98764da:0 > 12/03/09 14:12:52 INFO utils.MultiThreadedReader: Key = > cfcd208495d565ef66e7dff9f98764da:0 > 12/03/09 14:12:52 ERROR utils.MultiThreadedReader: No data returned, tried to > get actions for key = cfcd208495d565ef66e7dff9f98764da:0 > 12/03/09 14:12:52 ERROR utils.MultiThreadedReader: No data returned, tried to > get actions for key = cfcd208495d565ef66e7dff9f98764da:0 > 12/03/09 14:12:52 INFO utils.MultiThreadedReader: Key = > cfcd208495d565ef66e7dff9f98764da:0 > 12/03/09 14:12:52 ERROR utils.MultiThreadedReader: No data returned, tried to > get actions for key = cfcd208495d565ef66e7dff9f98764da:0 > 12/03/09 14:12:52 ERROR utils.MultiThreadedReader: Aborting run -- found more > than three errors -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-5407) Show the per-region level request/sec count in the web ui
[ https://issues.apache.org/jira/browse/HBASE-5407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Bautin resolved HBASE-5407. --- Resolution: Fixed Liyin: it looks like the 89-fb patch has been committed internally. As this is an 89-fb-only JIRA, resolving the issue so that we can sync internal 89-fb changes into the externally visible branch. > Show the per-region level request/sec count in the web ui > - > > Key: HBASE-5407 > URL: https://issues.apache.org/jira/browse/HBASE-5407 > Project: HBase > Issue Type: Improvement >Reporter: Liyin Tang >Assignee: Liyin Tang > Attachments: D1779.1.patch, D1779.1.patch, D1779.1.patch > > > It would be nice to show the per-region level request/sec count in the web > ui, especially when debugging the hot region problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4758) [89-fb] Make test methods independent in TestMasterTransitions
[ https://issues.apache.org/jira/browse/HBASE-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Bautin resolved HBASE-4758. --- Resolution: Fixed Release Note: This issue is specific to 89-fb. The patch will be synced into the official hbase-89-fb-apache branch shortly. > [89-fb] Make test methods independent in TestMasterTransitions > -- > > Key: HBASE-4758 > URL: https://issues.apache.org/jira/browse/HBASE-4758 > Project: HBase > Issue Type: Bug >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin >Priority: Minor > Attachments: D315.1.patch, D315.2.patch > > > Currently TestMasterTransitions is flaky, and one way to hopefully make it > more stable is to create a separate MiniHBaseCluster for every test method, > and get rid of BeforeClass/AfterClass. So far I have successfully run > TestMasterTransitions a few times with the fix, while it was failing without > the fix. > TestMasterTransitions in trunk is a different story (most of the test is > commented out in the trunk) and is out of scope of this JIRA. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4516) HFile-level load tester with compaction and random-read workloads
[ https://issues.apache.org/jira/browse/HBASE-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Bautin resolved HBASE-4516. --- Resolution: Fixed Resolved as part of HBASE-4218. > HFile-level load tester with compaction and random-read workloads > - > > Key: HBASE-4516 > URL: https://issues.apache.org/jira/browse/HBASE-4516 > Project: HBase > Issue Type: Test >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin >Priority: Minor > Fix For: 0.94.0 > > > This is a load testing tool for HFile implementations, which supports two > workloads: > - Compactions (merge the input HFiles). A special case of this is only one > input, which allows to do HFile format conversions. > - Random reads. Launches the specified number of threads that do seeks and > short scans on randomly generated keys. > The original purpose of this tool was to ensure that HFile format v2 did not > introduce performance regressions. > Keys for the read workload are generated randomly between the first and the > last key of the HFile. At each position, instead of precisely calculating the > correct probability for every byte value b, we select a uniformly random byte > between in the allowed [low, high] range. In addition, there is a heuristic > that determines the positions at which the key has hex characters, and the > random key contains hex characters at those positions as well. > Example output for the random read workload: > Time: 120 sec, seek/sec: 8290, kv/sec: 30351, kv bytes/sec: 91868121, > blk/sec: 10147, unique keys: 232779 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-5274) Filter out the expired store file scanner during the compaction
[ https://issues.apache.org/jira/browse/HBASE-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Bautin resolved HBASE-5274. --- Resolution: Fixed Assignee: Mikhail Bautin (was: Liyin Tang) Fix committed to trunk. > Filter out the expired store file scanner during the compaction > --- > > Key: HBASE-5274 > URL: https://issues.apache.org/jira/browse/HBASE-5274 > Project: HBase > Issue Type: Improvement >Reporter: Liyin Tang >Assignee: Mikhail Bautin > Attachments: D1407.1.patch, D1407.1.patch, D1407.1.patch, > D1407.1.patch, D1407.1.patch, D1473.1.patch > > > During the compaction time, HBase will generate a store scanner which will > scan a list of store files. And it would be more efficient to filer out the > expired store file since there is no need to read any key values from these > store files. > This optimization has been already implemented on 89-fb and this is the > building block for HBASE-5199 as well. It is supposed to be no-ops to compact > the expired store files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-3796) Per-Store Entries in Compaction Queue
[ https://issues.apache.org/jira/browse/HBASE-3796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Bautin resolved HBASE-3796. --- Resolution: Fixed Assignee: Nicolas Spiegelberg (was: Mikhail Bautin) Release Note: Sorry, it seems like I re-opened the wrong patch instead of HBASE-3976. Restoring the "Fixed" status. > Per-Store Entries in Compaction Queue > - > > Key: HBASE-3796 > URL: https://issues.apache.org/jira/browse/HBASE-3796 > Project: HBase > Issue Type: Bug >Reporter: Nicolas Spiegelberg >Assignee: Nicolas Spiegelberg >Priority: Minor > Fix For: 0.92.1 > > Attachments: HBASE-3796-fixed.patch, HBASE-3796.patch > > > Although compaction is decided on a per-store basis, right now the > CompactSplitThread only deals at the Region level for queueing. Store-level > compaction queue entries will give us more visibility into compaction > workload + allow us to stop summarizing priorities. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4757) [89-fb] Fix TestHQuorumPeer for non-default values of hbase.tmp.dir
[ https://issues.apache.org/jira/browse/HBASE-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Bautin resolved HBASE-4757. --- Resolution: Fixed Resolved in https://reviews.facebook.net/D297 > [89-fb] Fix TestHQuorumPeer for non-default values of hbase.tmp.dir > > > Key: HBASE-4757 > URL: https://issues.apache.org/jira/browse/HBASE-4757 > Project: HBase > Issue Type: Bug >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin >Priority: Minor > > TestHQuorumPeer currently fails if hbase.tmp.dir is different from > /tmp/hbase-. However, for our internal parallel test runner we use > a different temporary HBase directory. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4824) TestZKLeaderManager is flaky
[ https://issues.apache.org/jira/browse/HBASE-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Bautin resolved HBASE-4824. --- Resolution: Duplicate > TestZKLeaderManager is flaky > > > Key: HBASE-4824 > URL: https://issues.apache.org/jira/browse/HBASE-4824 > Project: HBase > Issue Type: Bug >Reporter: Mikhail Bautin >Priority: Minor > > TestZKLeaderManager is flaky. It failed in a full test suite run for me, then > passed when I reran it locally, but then failed when I ran it in a loop. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4465) Lazy-seek optimization for StoreFile scanners
[ https://issues.apache.org/jira/browse/HBASE-4465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Bautin resolved HBASE-4465. --- Resolution: Fixed > Lazy-seek optimization for StoreFile scanners > - > > Key: HBASE-4465 > URL: https://issues.apache.org/jira/browse/HBASE-4465 > Project: HBase > Issue Type: Improvement >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin > Labels: optimization, seek > Fix For: 0.94.0, 0.89.20100924 > > Attachments: > HBASE-4465_Lazy-seek_optimization_for_St-20111005121052-b2ea8753.patch > > > Previously, if we had several StoreFiles for a column family in a region, we > would seek in each of them and only then merge the results, even though the > row/column we are looking for might only be in the most recent (and the > smallest) file. Now we prioritize our reads from those files so that we check > the most recent file first. This is done by doing a "lazy seek" which > pretends that the next value in the StoreFile is (seekRow, seekColumn, > lastTimestampInStoreFile), which is earlier in the KV order than anything > that might actually occur in the file. So if we don't find the result in > earlier files, that fake KV will bubble up to the top of the KV heap and a > real seek will be done. This is expected to significantly reduce the amount > of disk IO (as of 09/22/2011 we are doing dark launch testing and > measurement). > This is joint work with Liyin Tang -- huge thanks to him for many helpful > discussions on this and the idea of putting fake KVs with the highest > timestamp of the StoreFile in the scanner priority queue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4522) Make hbase-site-custom.xml override the hbase-site.xml
[ https://issues.apache.org/jira/browse/HBASE-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Bautin resolved HBASE-4522. --- Resolution: Not A Problem > Make hbase-site-custom.xml override the hbase-site.xml > -- > > Key: HBASE-4522 > URL: https://issues.apache.org/jira/browse/HBASE-4522 > Project: HBase > Issue Type: Improvement >Reporter: Mikhail Bautin >Assignee: Liyin Tang >Priority: Minor > Fix For: 0.94.0 > > > The motivation for diff is that we want to override some config change for > any specific cluster easily by just adding the config entries in the > hbase-site-custom.xml for that cluster. This change adds the > hbase-site-custom.xml configuration file into HBaseConfiguration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4466) Fix accounting of the number of blocks read for the one-level index case
[ https://issues.apache.org/jira/browse/HBASE-4466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Bautin resolved HBASE-4466. --- Resolution: Fixed This is resolved in HBASE-4496. > Fix accounting of the number of blocks read for the one-level index case > > > Key: HBASE-4466 > URL: https://issues.apache.org/jira/browse/HBASE-4466 > Project: HBase > Issue Type: Improvement >Reporter: Kannan Muthukkaruppan >Assignee: Mikhail Bautin > > In HFileBlockIndex.seekToDataBlock if the current block is the same as the > requested block, then in the 1-level index case, we were read block from > cache again. Although this would be a cache hit, it unnecessarily increases > the block cache read count and block cache hit count, and also makes it > harder to keep the accounting straight for tests like TestBlocksRead > (introduced in HBASE-4450). > Basically, even in the 1-level index case, in > HFileBlockIndex.seekToDataBlock(), if currentBlock.getOffset() == > currentOffset, we can avoid looking up the block in cache. > Assigning to Mikhail (he's already fixed this in our internal branch). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-2794) Utilize ROWCOL bloom filter if multiple columns within same family are requested in a Get
[
https://issues.apache.org/jira/browse/HBASE-2794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Bautin resolved HBASE-2794.
---
Tags: (was: noob)
Resolution: Fixed
Release Note: Resolving (the patch has been committed).
> Utilize ROWCOL bloom filter if multiple columns within same family are
> requested in a Get
> -
>
> Key: HBASE-2794
> URL: https://issues.apache.org/jira/browse/HBASE-2794
> Project: HBase
> Issue Type: Improvement
> Components: performance
>Reporter: Kannan Muthukkaruppan
>Assignee: Mikhail Bautin
> Fix For: 0.92.0
>
>
> Noticed the following snippet in StoreFile.java:Scanner:shouldSeek():
> {code}
> switch(bloomFilterType) {
> case ROW:
> key = row;
> break;
> case ROWCOL:
> if (columns.size() == 1) {
> byte[] col = columns.first();
> key = Bytes.add(row, col);
> break;
> }
> //$FALL-THROUGH$
> default:
> return true;
> }
> {code}
> If columns.size > 1, then we currently don't take advantage of the bloom
> filter. We should optimize this to check bloom for each of columns and if
> none of the columns are present in the bloom avoid opening the file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4062) Multi-column scanner unit test
[ https://issues.apache.org/jira/browse/HBASE-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Bautin resolved HBASE-4062. --- Resolution: Fixed Fix Version/s: 0.94.0 TestMultiColumnScanner has been committed to trunk. > Multi-column scanner unit test > -- > > Key: HBASE-4062 > URL: https://issues.apache.org/jira/browse/HBASE-4062 > Project: HBase > Issue Type: Improvement > Components: regionserver, test >Affects Versions: 0.94.0 >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin >Priority: Minor > Labels: test > Fix For: 0.94.0 > > Attachments: test-multi-column-scanner.patch > > > Adding a unit test for the multi-column scanner. We are using this this to > test an optimization we are making to multi-column scans using row-column > Bloom filters. The scanner creates multiple StoreFiles for a single column > family, each containing a randomized set of columns with different > timestamps, and then tests scanning through the whole region with all > possible sets of columns specified in the query. Point deletes (deletes of a > specific timestamp) are also tested. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
