[jira] [Commented] (HBASE-5604) M/R tool to replay WAL files

2012-04-12 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252537#comment-13252537 ] Ted Yu commented on HBASE-5604: --- If you run the patch through 'arc lint', you would see

[jira] [Commented] (HBASE-5773) HtablePool constructor not reading config files in certain cases

2012-04-12 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252551#comment-13252551 ] Ted Yu commented on HBASE-5773: --- Patch makes sense. HtablePool constructor

[jira] [Commented] (HBASE-5604) M/R tool to replay WAL files

2012-04-12 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252916#comment-13252916 ] Ted Yu commented on HBASE-5604: --- Patch looks good. Minor comment: {code} + HLog.Entry

[jira] [Commented] (HBASE-5780) Fix race in HBase regionserver startup vs ZK SASL authentication

2012-04-12 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253074#comment-13253074 ] Ted Yu commented on HBASE-5780: --- {code} +} catch (InterruptedException e) { +

[jira] [Commented] (HBASE-5604) M/R tool to replay WAL files

2012-04-12 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253085#comment-13253085 ] Ted Yu commented on HBASE-5604: --- TestWALPlayer.java doesn't have test category.

[jira] [Commented] (HBASE-5780) Fix race in HBase regionserver startup vs ZK SASL authentication

2012-04-12 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253102#comment-13253102 ] Ted Yu commented on HBASE-5780: --- I think throwing exception immediately is better. Please

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

2012-04-12 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253107#comment-13253107 ] Ted Yu commented on HBASE-5778: --- {code} + } catch (IndexOutOfBoundsException iobe) { +

[jira] [Commented] (HBASE-5778) Turn on WAL compression by default

2012-04-12 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253127#comment-13253127 ] Ted Yu commented on HBASE-5778: --- The remaining issue is about how the replication sink

[jira] [Commented] (HBASE-5656) LoadIncrementalHFiles createTable should detect and set compression algorithm

2012-04-08 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249555#comment-13249555 ] Ted Yu commented on HBASE-5656: --- Patch looks good. Minor comment: {code} +

[jira] [Commented] (HBASE-5656) LoadIncrementalHFiles createTable should detect and set compression algorithm

2012-04-08 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249602#comment-13249602 ] Ted Yu commented on HBASE-5656: --- Latest patch looks good to me.

[jira] [Commented] (HBASE-5727) secure hbase build broke because of 'HBASE-5451 Switch RPC call envelope/headers to PBs'

2012-04-08 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249612#comment-13249612 ] Ted Yu commented on HBASE-5727: --- TestRowProcessorEndpoint in security profile passed

[jira] [Commented] (HBASE-5689) Skipping RecoveredEdits may cause data loss

2012-04-01 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243743#comment-13243743 ] Ted Yu commented on HBASE-5689: --- Using a TreeMap is common practice. Please attach test

[jira] [Commented] (HBASE-5693) When creating a region, the master initializes it and creates a memstore within the master server

2012-04-01 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243746#comment-13243746 ] Ted Yu commented on HBASE-5693: --- CreateTableHandler isn't initializing the regions. Who will

[jira] [Commented] (HBASE-5677) The master never does balance because duplicate openhandled the one region

2012-04-01 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243747#comment-13243747 ] Ted Yu commented on HBASE-5677: --- Interesting. Chunhui proposed safe mode for Master in

[jira] [Commented] (HBASE-5693) When creating a region, the master initializes it and creates a memstore within the master server

2012-04-01 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243762#comment-13243762 ] Ted Yu commented on HBASE-5693: --- It is called from OpenRegionHandler.openRegion() I once

[jira] [Commented] (HBASE-5693) When creating a region, the master initializes it and creates a memstore within the master server

2012-04-01 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243765#comment-13243765 ] Ted Yu commented on HBASE-5693: --- @N: Can you rebased the patch for trunk ? {code} Hunk #3

[jira] [Commented] (HBASE-5665) Repeated split causes HRegionServer failures and breaks table

2012-04-01 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243842#comment-13243842 ] Ted Yu commented on HBASE-5665: --- HBASE-5665-trunk.patch looks good.

[jira] [Commented] (HBASE-5666) RegionServer doesn't retry to check if base node is available

2012-04-01 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243845#comment-13243845 ] Ted Yu commented on HBASE-5666: --- {code} +if (keeperEx != null) + throw keeperEx;

[jira] [Commented] (HBASE-5666) RegionServer doesn't retry to check if base node is available

2012-04-01 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243863#comment-13243863 ] Ted Yu commented on HBASE-5666: --- Patch v2 looks good. RegionServer doesn't

[jira] [Commented] (HBASE-5436) Right-size the map when reading attributes.

2012-04-01 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243958#comment-13243958 ] Ted Yu commented on HBASE-5436: --- Integrated to 0.92 branch. Right-size the

[jira] [Commented] (HBASE-5623) Race condition when rolling the HLog and hlogFlush

2012-03-26 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238675#comment-13238675 ] Ted Yu commented on HBASE-5623: --- Last patch should be good to go. Race

[jira] [Commented] (HBASE-2600) Change how we do meta tables; from tablename+STARTROW+randomid to instead, tablename+ENDROW+randomid

2012-03-26 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238891#comment-13238891 ] Ted Yu commented on HBASE-2600: --- @Alex: Can you attach hbase-2600-root.dir.tgz to this JIRA

[jira] [Commented] (HBASE-5641) decayingSampleTick1 prevents HBase from shutting down.

2012-03-26 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239139#comment-13239139 ] Ted Yu commented on HBASE-5641: --- +1 on patch. decayingSampleTick1 prevents

[jira] [Commented] (HBASE-5615) the master never does balance because of balancing the parent region

2012-03-25 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238009#comment-13238009 ] Ted Yu commented on HBASE-5615: --- Integrated to 0.92, 0.94 and TRUNK as well.

[jira] [Commented] (HBASE-2600) Change how we do meta tables; from tablename+STARTROW+randomid to instead, tablename+ENDROW+randomid

2012-03-25 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238010#comment-13238010 ] Ted Yu commented on HBASE-2600: --- @Alex: Try this: {code} git diff --no-prefix --binary

[jira] [Commented] (HBASE-5615) the master never does balance because of balancing the parent region

2012-03-25 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238030#comment-13238030 ] Ted Yu commented on HBASE-5615: --- @Xufeng: You're welcome. In the future, please grant

[jira] [Commented] (HBASE-2600) Change how we do meta tables; from tablename+STARTROW+randomid to instead, tablename+ENDROW+randomid

2012-03-25 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238074#comment-13238074 ] Ted Yu commented on HBASE-2600: --- dev-support/test-patch.sh doesn't use '--binary' option

[jira] [Commented] (HBASE-5615) the master never does balance because of balancing the parent region

2012-03-24 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237556#comment-13237556 ] Ted Yu commented on HBASE-5615: --- Integrated to 0.90 branch. Thanks for the patch Xufeng.

[jira] [Commented] (HBASE-5623) Race condition when rolling the HLog and hlogFlush

2012-03-24 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237714#comment-13237714 ] Ted Yu commented on HBASE-5623: --- Adding LOG.debug should be fine. Race

[jira] [Commented] (HBASE-3996) Support multiple tables and scanners as input to the mapper in map/reduce jobs

2012-03-19 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233120#comment-13233120 ] Ted Yu commented on HBASE-3996: --- Eran might be busy. I created

[jira] [Commented] (HBASE-5564) Bulkload is discarding duplicate records

2012-03-19 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233179#comment-13233179 ] Ted Yu commented on HBASE-5564: --- {code} +public int getTimestapKeyColumnIndex() { {code}

[jira] [Commented] (HBASE-5596) Few minor bugs from HBASE-5209

2012-03-19 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233216#comment-13233216 ] Ted Yu commented on HBASE-5596: --- Is this patch ready for integration ? From

[jira] [Commented] (HBASE-5542) Unify HRegion.mutateRowsWithLocks() and HRegion.processRow()

2012-03-12 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227569#comment-13227569 ] Ted Yu commented on HBASE-5542: --- I think we should keep time bound whose default value can

[jira] [Commented] (HBASE-5206) Port HBASE-5155 to 0.92 and TRUNK

2012-03-12 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227661#comment-13227661 ] Ted Yu commented on HBASE-5206: --- Patch v2 looks good. Minor comments: {code} // Call to

[jira] [Commented] (HBASE-5206) Port HBASE-5155 to 0.92 and TRUNK

2012-03-12 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227669#comment-13227669 ] Ted Yu commented on HBASE-5206: --- {code} + String errorMsg = Unable to ensure that the

[jira] [Commented] (HBASE-5206) Port HBASE-5155 to 0.92 and TRUNK

2012-03-12 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227688#comment-13227688 ] Ted Yu commented on HBASE-5206: --- The following error is reproducible on MacBook (patch for

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-12 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227892#comment-13227892 ] Ted Yu commented on HBASE-4608: --- Introducing WAL_VERSION would imply that we may change HLog

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-12 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227901#comment-13227901 ] Ted Yu commented on HBASE-4608: --- bq. try a paragraph of text going in and out LRUDictionary

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-12 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227919#comment-13227919 ] Ted Yu commented on HBASE-4608: --- bq. Its the test of a single entry only Please take a look

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-12 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227946#comment-13227946 ] Ted Yu commented on HBASE-4608: --- I think WAL_VERSION metadata is orthogonal to compression

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-12 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227954#comment-13227954 ] Ted Yu commented on HBASE-4608: --- bq. Should the Compression class in wal package ... I only

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-12 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227961#comment-13227961 ] Ted Yu commented on HBASE-4608: --- Uploaded v23 onto review board. After WAL version metadata

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-12 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227984#comment-13227984 ] Ted Yu commented on HBASE-4608: --- For code specific review, please use

[jira] [Commented] (HBASE-5399) Cut the link between the client and the zookeeper ensemble

2012-03-12 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227997#comment-13227997 ] Ted Yu commented on HBASE-5399: --- TestAtomicOperation failed in latest TRUNK build:

[jira] [Commented] (HBASE-5399) Cut the link between the client and the zookeeper ensemble

2012-03-12 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228009#comment-13228009 ] Ted Yu commented on HBASE-5399: --- From test output: {code} Exception in thread Thread-211

[jira] [Commented] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer

2012-01-15 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13186520#comment-13186520 ] Ted Yu commented on HBASE-5201: --- @Scott: I think you need to mark your work complete before

[jira] [Commented] (HBASE-5174) Coalesce aborted tasks in the TaskMonitor

2012-01-15 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13186527#comment-13186527 ] Ted Yu commented on HBASE-5174: --- A slight variation of my previous proposal:

[jira] [Commented] (HBASE-4951) master process can not be stopped when it is initializing

2011-12-12 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13167581#comment-13167581 ] Ted Yu commented on HBASE-4951: --- +1 on patch. master process can not be

[jira] [Commented] (HBASE-5001) Improve the performance of block cache keys

2011-12-12 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13167947#comment-13167947 ] Ted Yu commented on HBASE-5001: --- In LruBlockCache, please change the javadoc for cacheKey

[jira] [Commented] (HBASE-4994) TestHeapSize broke in trunk

2011-12-09 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166405#comment-13166405 ] Ted Yu commented on HBASE-4994: --- Thanks for fixing this. Hadoop Qa didn't report this

[jira] [Commented] (HBASE-4880) Region is on service before openRegionHandler completes, may cause data loss

2011-12-08 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13165837#comment-13165837 ] Ted Yu commented on HBASE-4880: --- +1 on patch v4. Region is on service

[jira] [Commented] (HBASE-4946) HTable.coprocessorExec (and possibly coprocessorProxy) does not work with dynamically loaded coprocessors (from hdfs or local system), because the RPC system tries to d

2011-12-08 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13165839#comment-13165839 ] Ted Yu commented on HBASE-4946: --- Will commit patch v4 tomorrow.

[jira] [Commented] (HBASE-4120) isolation and allocation

2011-12-08 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13165857#comment-13165857 ] Ted Yu commented on HBASE-4120: --- Please add license to QosRegionObserver.java I think we

[jira] [Commented] (HBASE-4946) HTable.coprocessorExec (and possibly coprocessorProxy) does not work with dynamically loaded coprocessors (from hdfs or local system), because the RPC system tries to d

2011-12-08 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13165870#comment-13165870 ] Ted Yu commented on HBASE-4946: --- Integrated to 0.92 and TRUNK. Thanks for the patch Andrei.

[jira] [Commented] (HBASE-4120) isolation and allocation

2011-12-08 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13165876#comment-13165876 ] Ted Yu commented on HBASE-4120: --- In PriorityFunction.java, several lines are much wider than

[jira] [Commented] (HBASE-4970) Add a parameter to change keepAliveTime of Htable thread pool.

2011-12-07 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164274#comment-13164274 ] Ted Yu commented on HBASE-4970: --- I think there shouldn't be upper case letters in name of

[jira] [Commented] (HBASE-4224) Need a flush by regionserver rather than by table option

2011-12-07 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164599#comment-13164599 ] Ted Yu commented on HBASE-4224: --- @Akash: Do you have a newer patch ? If so, please upload to

[jira] [Commented] (HBASE-4729) Clash between region unassign and splitting kills the master

2011-12-07 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164658#comment-13164658 ] Ted Yu commented on HBASE-4729: --- The HadoopQA report @

[jira] [Commented] (HBASE-4927) CatalogJanior:SplitParentFirstComparator doesn't sort as expected, for the last region when the endkey is empty

2011-12-07 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164695#comment-13164695 ] Ted Yu commented on HBASE-4927: --- Ran through the previously failing tests: {code} 1010 mt

[jira] [Commented] (HBASE-4927) CatalogJanior:SplitParentFirstComparator doesn't sort as expected, for the last region when the endkey is empty

2011-12-07 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164699#comment-13164699 ] Ted Yu commented on HBASE-4927: --- Also ran through the two tests in original patch: {code}

[jira] [Commented] (HBASE-4120) isolation and allocation

2011-12-07 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164960#comment-13164960 ] Ted Yu commented on HBASE-4120: --- But preScannerClose() is only passed one scanner.

[jira] [Commented] (HBASE-4120) isolation and allocation

2011-12-07 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13165017#comment-13165017 ] Ted Yu commented on HBASE-4120: --- Looks like we should expose scanner lease expiration

[jira] [Commented] (HBASE-4980) Null pointer exception in HBaseClient receiveResponse

2011-12-07 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13165021#comment-13165021 ] Ted Yu commented on HBASE-4980: --- The patch changes the semantics of original error handling.

[jira] [Commented] (HBASE-4980) Null pointer exception in HBaseClient receiveResponse

2011-12-07 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13165025#comment-13165025 ] Ted Yu commented on HBASE-4980: --- Please attach patch for trunk last so that HadoopQA can

[jira] [Commented] (HBASE-4980) Null pointer exception in HBaseClient receiveResponse

2011-12-07 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13165031#comment-13165031 ] Ted Yu commented on HBASE-4980: --- Please use --no-prefix to generate patch.

[jira] [Commented] (HBASE-4682) Support deleted rows using Import/Export

2011-12-07 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13165048#comment-13165048 ] Ted Yu commented on HBASE-4682: --- In the new Delete ctor, row key should be included in the

[jira] [Commented] (HBASE-4946) HTable.coprocessorExec (and possibly coprocessorProxy) does not work with dynamically loaded coprocessors (from hdfs or local system), because the RPC system tries to d

2011-12-06 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163819#comment-13163819 ] Ted Yu commented on HBASE-4946: --- The failed tests were due to 'unable to create new native

[jira] [Commented] (HBASE-4946) HTable.coprocessorExec (and possibly coprocessorProxy) does not work with dynamically loaded coprocessors (from hdfs or local system), because the RPC system tries to d

2011-12-06 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163840#comment-13163840 ] Ted Yu commented on HBASE-4946: --- For coprocessor/Exec.java, javadoc doesn't match code:

[jira] [Commented] (HBASE-4120) isolation and allocation

2011-12-06 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163853#comment-13163853 ] Ted Yu commented on HBASE-4120: --- From Andrew Purtell (see 'trip report for Hadoop In China'

[jira] [Commented] (HBASE-4120) isolation and allocation

2011-12-06 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163902#comment-13163902 ] Ted Yu commented on HBASE-4120: --- Andy suggested placing the

[jira] [Commented] (HBASE-4605) Constraints

2011-12-06 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163939#comment-13163939 ] Ted Yu commented on HBASE-4605: --- Renaming IntegrationTestConstraint as described above makes

[jira] [Commented] (HBASE-4880) Region is on service before completing openRegionHanlder, may cause data loss

2011-12-06 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164104#comment-13164104 ] Ted Yu commented on HBASE-4880: --- Did RestAdmin pass for patch v2? Region

[jira] [Commented] (HBASE-4880) Region is on service before completing openRegionHanlder, may cause data loss

2011-12-06 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164168#comment-13164168 ] Ted Yu commented on HBASE-4880: --- Please check failed tests. It seems trunk is broken now.

[jira] [Commented] (HBASE-4946) HTable.coprocessorExec (and possibly coprocessorProxy) does not work with dynamically loaded coprocessors (from hdfs or local system), because the RPC system tries to d

2011-12-05 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162740#comment-13162740 ] Ted Yu commented on HBASE-4946: --- The change in BloomFilterFactory is unrelated, please

[jira] [Commented] (HBASE-4954) IllegalArgumentException in hfile2 blockseek

2011-12-05 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163010#comment-13163010 ] Ted Yu commented on HBASE-4954: --- In our internal Jenkins build which uses hadoop 0.22, there

[jira] [Commented] (HBASE-4954) IllegalArgumentException in hfile2 blockseek

2011-12-05 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163208#comment-13163208 ] Ted Yu commented on HBASE-4954: --- It turns out that we should be using the following command:

[jira] [Commented] (HBASE-4954) IllegalArgumentException in hfile2 blockseek

2011-12-05 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163212#comment-13163212 ] Ted Yu commented on HBASE-4954: --- Stack trace for 0.92 is essentially the same. But I don't

[jira] [Commented] (HBASE-4954) IllegalArgumentException in hfile2 blockseek

2011-12-05 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163380#comment-13163380 ] Ted Yu commented on HBASE-4954: --- Can I mark this issue as Won't fix ?

[jira] [Commented] (HBASE-4605) Constraints

2011-12-04 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162565#comment-13162565 ] Ted Yu commented on HBASE-4605: --- Thanks Gary for the detailed review. For the check() API:

[jira] [Commented] (HBASE-4921) HTable initialization looks for EMPTY_START_ROW

2011-12-03 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162215#comment-13162215 ] Ted Yu commented on HBASE-4921: --- @Pritam: Can you provide a patch and let us know the result

[jira] [Commented] (HBASE-4379) [hbck] Does not complain about tables with no end region [Z,]

2011-12-03 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162224#comment-13162224 ] Ted Yu commented on HBASE-4379: --- @Jonathan: You need to re-attach patch because HadoopQA

[jira] [Commented] (HBASE-4942) HMaster is unable to start of HFile V1 is used

2011-12-03 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162270#comment-13162270 ] Ted Yu commented on HBASE-4942: --- You're right Lars. HMaster is unable to

[jira] [Commented] (HBASE-4936) Cached HRegionInterface connections crash when getting UnknownHost exceptions

2011-12-03 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162272#comment-13162272 ] Ted Yu commented on HBASE-4936: --- +1 on patch. @Andrei: Please re-attach patch using

[jira] [Commented] (HBASE-4945) NPE in HRegion.bulkLoadHFiles(...)

2011-12-03 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162275#comment-13162275 ] Ted Yu commented on HBASE-4945: --- Good catch, Lars. I think the fix should go to 0.92

[jira] [Commented] (HBASE-4880) Region is on service before completing openRegionHanlder, may cause data loss

2011-12-03 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162278#comment-13162278 ] Ted Yu commented on HBASE-4880: --- I think the patch makes sense. I ran TestHCM with patch

[jira] [Commented] (HBASE-4944) Optionally verify bulk loaded HFiles

2011-12-03 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162280#comment-13162280 ] Ted Yu commented on HBASE-4944: --- Minor comments: {code} +KeyValue pkv = null; {code}

[jira] [Commented] (HBASE-4944) Optionally verify bulk loaded HFiles

2011-12-03 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162281#comment-13162281 ] Ted Yu commented on HBASE-4944: --- Looks like the patch should be rebased: {code} 4 out of 5

[jira] [Commented] (HBASE-3373) Allow regions of specific table to be load-balanced

2011-11-30 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13160233#comment-13160233 ] Ted Yu commented on HBASE-3373: --- @Ben: Thanks for trying out 0.94 The code snippet above

[jira] [Commented] (HBASE-4729) Race between online altering and splitting kills the master

2011-11-29 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159180#comment-13159180 ] Ted Yu commented on HBASE-4729: --- For the unexpected zk exception, we should abort the master

[jira] [Commented] (HBASE-4729) Race between online altering and splitting kills the master

2011-11-29 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159410#comment-13159410 ] Ted Yu commented on HBASE-4729: --- Since TestAssignmentManager would be run in a shared JVM

[jira] [Commented] (HBASE-4729) Clash between region unassign and splitting kills the master

2011-11-29 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159426#comment-13159426 ] Ted Yu commented on HBASE-4729: --- +1 on patch v5. Clash between region

[jira] [Commented] (HBASE-4893) HConnectionImplementation closed-but-not-deleted, need a way to find the state of connection

2011-11-29 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159613#comment-13159613 ] Ted Yu commented on HBASE-4893: --- HConnectionManager.deleteStaleConnection() can be utilized

[jira] [Commented] (HBASE-4616) Update hregion encoded name to reduce logic and prevent region collisions in META

2011-11-29 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159676#comment-13159676 ] Ted Yu commented on HBASE-4616: --- Where is MetaSearchRow defined ? What's the difference

[jira] [Commented] (HBASE-4616) Update hregion encoded name to reduce logic and prevent region collisions in META

2011-11-29 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159694#comment-13159694 ] Ted Yu commented on HBASE-4616: --- In HRegionInfo.java: {code} public static final int

[jira] [Commented] (HBASE-4616) Update hregion encoded name to reduce logic and prevent region collisions in META

2011-11-29 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159761#comment-13159761 ] Ted Yu commented on HBASE-4616: --- In SplitTransaction.java, getDaughterRegionIdTimestamp() is

[jira] [Commented] (HBASE-4899) Region would be assigned twice easily with continually killing server and moving region in testing environment

2011-11-29 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159858#comment-13159858 ] Ted Yu commented on HBASE-4899: --- {code} + + because it has been opened in

[jira] [Commented] (HBASE-4899) Region would be assigned twice easily with continually killing server and moving region in testing environment

2011-11-29 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159859#comment-13159859 ] Ted Yu commented on HBASE-4899: --- @Chunhui: Please let us know testing result on your QA

[jira] [Commented] (HBASE-4773) HBaseAdmin may leak ZooKeeper connections

2011-11-28 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13158569#comment-13158569 ] Ted Yu commented on HBASE-4773: --- Integrated to 0.90, 0.92 and TRUNK. Thanks for the patch

[jira] [Commented] (HBASE-4120) isolation and allocation

2011-11-28 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13158589#comment-13158589 ] Ted Yu commented on HBASE-4120: --- The new tests should be placed under

[jira] [Commented] (HBASE-4120) isolation and allocation

2011-11-28 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13158598#comment-13158598 ] Ted Yu commented on HBASE-4120: --- Please also categorize the new tests. See N's email on

  1   2   3   4   5   6   7   >