[jira] [Updated] (HBASE-23089) fix undefined constants in HBaseHTraceConfiguration
[ https://issues.apache.org/jira/browse/HBASE-23089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] cong.han updated HBASE-23089: - Attachment: (was: 0001-fix-undefined-constants.patch) > fix undefined constants in HBaseHTraceConfiguration > --- > > Key: HBASE-23089 > URL: https://issues.apache.org/jira/browse/HBASE-23089 > Project: HBase > Issue Type: Improvement >Reporter: cong.han >Assignee: cong.han >Priority: Trivial > Attachments: 0001-fix-undefined-constants.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23089) fix undefined constants in HBaseHTraceConfiguration
[ https://issues.apache.org/jira/browse/HBASE-23089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] cong.han updated HBASE-23089: - Attachment: 0001-fix-undefined-constants.patch > fix undefined constants in HBaseHTraceConfiguration > --- > > Key: HBASE-23089 > URL: https://issues.apache.org/jira/browse/HBASE-23089 > Project: HBase > Issue Type: Improvement >Reporter: cong.han >Assignee: cong.han >Priority: Trivial > Attachments: 0001-fix-undefined-constants.patch, > 0001-fix-undefined-constants.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23089) fix undefined constants in HBaseHTraceConfiguration
[ https://issues.apache.org/jira/browse/HBASE-23089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] cong.han updated HBASE-23089: - Attachment: (was: 0001-fix-undefined-constants.patch) > fix undefined constants in HBaseHTraceConfiguration > --- > > Key: HBASE-23089 > URL: https://issues.apache.org/jira/browse/HBASE-23089 > Project: HBase > Issue Type: Improvement >Reporter: cong.han >Assignee: cong.han >Priority: Trivial > Attachments: 0001-fix-undefined-constants.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23089) fix undefined constants in HBaseHTraceConfiguration
[ https://issues.apache.org/jira/browse/HBASE-23089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] cong.han updated HBASE-23089: - Attachment: 0001-fix-undefined-constants.patch Status: Patch Available (was: Open) > fix undefined constants in HBaseHTraceConfiguration > --- > > Key: HBASE-23089 > URL: https://issues.apache.org/jira/browse/HBASE-23089 > Project: HBase > Issue Type: Improvement >Reporter: cong.han >Assignee: cong.han >Priority: Trivial > Attachments: 0001-fix-undefined-constants.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-23089) fix undefined constants in HBaseHTraceConfiguration
[ https://issues.apache.org/jira/browse/HBASE-23089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] cong.han reassigned HBASE-23089: Assignee: cong.han > fix undefined constants in HBaseHTraceConfiguration > --- > > Key: HBASE-23089 > URL: https://issues.apache.org/jira/browse/HBASE-23089 > Project: HBase > Issue Type: Improvement >Reporter: cong.han >Assignee: cong.han >Priority: Trivial > Attachments: 0001-fix-undefined-constants.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23089) fix undefined constants in HBaseHTraceConfiguration
[ https://issues.apache.org/jira/browse/HBASE-23089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] cong.han updated HBASE-23089: - Attachment: 0001-fix-undefined-constants.patch > fix undefined constants in HBaseHTraceConfiguration > --- > > Key: HBASE-23089 > URL: https://issues.apache.org/jira/browse/HBASE-23089 > Project: HBase > Issue Type: Improvement >Reporter: cong.han >Priority: Trivial > Attachments: 0001-fix-undefined-constants.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23089) fix undefined constants in HBaseHTraceConfiguration
cong.han created HBASE-23089: Summary: fix undefined constants in HBaseHTraceConfiguration Key: HBASE-23089 URL: https://issues.apache.org/jira/browse/HBASE-23089 Project: HBase Issue Type: Improvement Reporter: cong.han -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-21628) memory leak risk when ClientAsyncPrefetchScanner not close
[ https://issues.apache.org/jira/browse/HBASE-21628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742796#comment-16742796 ] cong.han commented on HBASE-21628: -- [~stack] add prefetch condition to scan is unnecessary, I will delete this part in next patch. the modify of this patch is a little complicated, I write a document to explain the next questions. I should write a document first and discuss if this modify is worth it, sorry. > memory leak risk when ClientAsyncPrefetchScanner not close > -- > > Key: HBASE-21628 > URL: https://issues.apache.org/jira/browse/HBASE-21628 > Project: HBase > Issue Type: Bug >Reporter: cong.han >Assignee: cong.han >Priority: Major > Attachments: HBASE-21328-v1.patch, HBASE-21628-v2.patch, > HBASE-21628-v3.patch, HBASE-21628-v4.patch, HBASE-21628-v5.patch, > HBASE-21628-v5.patch, HBASE-21628-v5.patch > > > When we use ClientAsyncPrefetchScanner and we do two things below > 1 Forgot to call close() method > 2 The result are not full fetched > The prefetch thread will not exit and leave a memory leak risk. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21628) memory leak risk when ClientAsyncPrefetchScanner not close
[ https://issues.apache.org/jira/browse/HBASE-21628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] cong.han updated HBASE-21628: - Attachment: ClientAsyncPrefetchScanner improvement.pdf > memory leak risk when ClientAsyncPrefetchScanner not close > -- > > Key: HBASE-21628 > URL: https://issues.apache.org/jira/browse/HBASE-21628 > Project: HBase > Issue Type: Bug >Reporter: cong.han >Assignee: cong.han >Priority: Major > Attachments: ClientAsyncPrefetchScanner improvement.pdf, > HBASE-21328-v1.patch, HBASE-21628-v2.patch, HBASE-21628-v3.patch, > HBASE-21628-v4.patch, HBASE-21628-v5.patch, HBASE-21628-v5.patch, > HBASE-21628-v5.patch > > > When we use ClientAsyncPrefetchScanner and we do two things below > 1 Forgot to call close() method > 2 The result are not full fetched > The prefetch thread will not exit and leave a memory leak risk. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21628) memory leak risk when ClientAsyncPrefetchScanner not close
[ https://issues.apache.org/jira/browse/HBASE-21628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] cong.han updated HBASE-21628: - Attachment: HBASE-21628-v5.patch > memory leak risk when ClientAsyncPrefetchScanner not close > -- > > Key: HBASE-21628 > URL: https://issues.apache.org/jira/browse/HBASE-21628 > Project: HBase > Issue Type: Bug >Reporter: cong.han >Assignee: cong.han >Priority: Major > Attachments: HBASE-21328-v1.patch, HBASE-21628-v2.patch, > HBASE-21628-v3.patch, HBASE-21628-v4.patch, HBASE-21628-v5.patch, > HBASE-21628-v5.patch, HBASE-21628-v5.patch > > > When we use ClientAsyncPrefetchScanner and we do two things below > 1 Forgot to call close() method > 2 The result are not full fetched > The prefetch thread will not exit and leave a memory leak risk. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21628) memory leak risk when ClientAsyncPrefetchScanner not close
[ https://issues.apache.org/jira/browse/HBASE-21628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] cong.han updated HBASE-21628: - Attachment: HBASE-21628-v5.patch > memory leak risk when ClientAsyncPrefetchScanner not close > -- > > Key: HBASE-21628 > URL: https://issues.apache.org/jira/browse/HBASE-21628 > Project: HBase > Issue Type: Bug >Reporter: cong.han >Assignee: cong.han >Priority: Major > Attachments: HBASE-21328-v1.patch, HBASE-21628-v2.patch, > HBASE-21628-v3.patch, HBASE-21628-v4.patch, HBASE-21628-v5.patch, > HBASE-21628-v5.patch > > > When we use ClientAsyncPrefetchScanner and we do two things below > 1 Forgot to call close() method > 2 The result are not full fetched > The prefetch thread will not exit and leave a memory leak risk. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21628) memory leak risk when ClientAsyncPrefetchScanner not close
[ https://issues.apache.org/jira/browse/HBASE-21628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733136#comment-16733136 ] cong.han commented on HBASE-21628: -- Change type to BUG,It's more like a potential bug. > memory leak risk when ClientAsyncPrefetchScanner not close > -- > > Key: HBASE-21628 > URL: https://issues.apache.org/jira/browse/HBASE-21628 > Project: HBase > Issue Type: Bug >Reporter: cong.han >Assignee: cong.han >Priority: Major > Attachments: HBASE-21328-v1.patch, HBASE-21628-v2.patch, > HBASE-21628-v3.patch, HBASE-21628-v4.patch, HBASE-21628-v5.patch > > > When we use ClientAsyncPrefetchScanner and we do two things below > 1 Forgot to call close() method > 2 The result are not full fetched > The prefetch thread will not exit and leave a memory leak risk. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21628) memory leak risk when ClientAsyncPrefetchScanner not close
[ https://issues.apache.org/jira/browse/HBASE-21628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] cong.han updated HBASE-21628: - Issue Type: Bug (was: Improvement) > memory leak risk when ClientAsyncPrefetchScanner not close > -- > > Key: HBASE-21628 > URL: https://issues.apache.org/jira/browse/HBASE-21628 > Project: HBase > Issue Type: Bug >Reporter: cong.han >Assignee: cong.han >Priority: Major > Attachments: HBASE-21328-v1.patch, HBASE-21628-v2.patch, > HBASE-21628-v3.patch, HBASE-21628-v4.patch, HBASE-21628-v5.patch > > > When we use ClientAsyncPrefetchScanner and we do two things below > 1 Forgot to call close() method > 2 The result are not full fetched > The prefetch thread will not exit and leave a memory leak risk. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21628) memory leak risk when ClientAsyncPrefetchScanner not close
[ https://issues.apache.org/jira/browse/HBASE-21628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731566#comment-16731566 ] cong.han commented on HBASE-21628: -- Was the failed hbase-server tests caused by this patch? > memory leak risk when ClientAsyncPrefetchScanner not close > -- > > Key: HBASE-21628 > URL: https://issues.apache.org/jira/browse/HBASE-21628 > Project: HBase > Issue Type: Improvement >Reporter: cong.han >Assignee: cong.han >Priority: Major > Attachments: HBASE-21328-v1.patch, HBASE-21628-v2.patch, > HBASE-21628-v3.patch, HBASE-21628-v4.patch, HBASE-21628-v5.patch > > > When we use ClientAsyncPrefetchScanner and we do two things below > 1 Forgot to call close() method > 2 The result are not full fetched > The prefetch thread will not exit and leave a memory leak risk. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21628) memory leak risk when ClientAsyncPrefetchScanner not close
[ https://issues.apache.org/jira/browse/HBASE-21628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731562#comment-16731562 ] cong.han commented on HBASE-21628: -- reattach > memory leak risk when ClientAsyncPrefetchScanner not close > -- > > Key: HBASE-21628 > URL: https://issues.apache.org/jira/browse/HBASE-21628 > Project: HBase > Issue Type: Improvement >Reporter: cong.han >Assignee: cong.han >Priority: Major > Attachments: HBASE-21328-v1.patch, HBASE-21628-v2.patch, > HBASE-21628-v3.patch, HBASE-21628-v4.patch, HBASE-21628-v5.patch > > > When we use ClientAsyncPrefetchScanner and we do two things below > 1 Forgot to call close() method > 2 The result are not full fetched > The prefetch thread will not exit and leave a memory leak risk. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21628) memory leak risk when ClientAsyncPrefetchScanner not close
[ https://issues.apache.org/jira/browse/HBASE-21628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] cong.han updated HBASE-21628: - Attachment: HBASE-21628-v5.patch > memory leak risk when ClientAsyncPrefetchScanner not close > -- > > Key: HBASE-21628 > URL: https://issues.apache.org/jira/browse/HBASE-21628 > Project: HBase > Issue Type: Improvement >Reporter: cong.han >Assignee: cong.han >Priority: Major > Attachments: HBASE-21328-v1.patch, HBASE-21628-v2.patch, > HBASE-21628-v3.patch, HBASE-21628-v4.patch, HBASE-21628-v5.patch > > > When we use ClientAsyncPrefetchScanner and we do two things below > 1 Forgot to call close() method > 2 The result are not full fetched > The prefetch thread will not exit and leave a memory leak risk. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21628) memory leak risk when ClientAsyncPrefetchScanner not close
[ https://issues.apache.org/jira/browse/HBASE-21628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] cong.han updated HBASE-21628: - Attachment: HBASE-21628-v4.patch > memory leak risk when ClientAsyncPrefetchScanner not close > -- > > Key: HBASE-21628 > URL: https://issues.apache.org/jira/browse/HBASE-21628 > Project: HBase > Issue Type: Improvement >Reporter: cong.han >Assignee: cong.han >Priority: Major > Attachments: HBASE-21328-v1.patch, HBASE-21628-v2.patch, > HBASE-21628-v3.patch, HBASE-21628-v4.patch > > > When we use ClientAsyncPrefetchScanner and we do two things below > 1 Forgot to call close() method > 2 The result are not full fetched > The prefetch thread will not exit and leave a memory leak risk. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21628) memory leak risk when ClientAsyncPrefetchScanner not close
[ https://issues.apache.org/jira/browse/HBASE-21628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731522#comment-16731522 ] cong.han commented on HBASE-21628: -- Fix the style problem。 > memory leak risk when ClientAsyncPrefetchScanner not close > -- > > Key: HBASE-21628 > URL: https://issues.apache.org/jira/browse/HBASE-21628 > Project: HBase > Issue Type: Improvement >Reporter: cong.han >Assignee: cong.han >Priority: Major > Attachments: HBASE-21328-v1.patch, HBASE-21628-v2.patch, > HBASE-21628-v3.patch, HBASE-21628-v4.patch > > > When we use ClientAsyncPrefetchScanner and we do two things below > 1 Forgot to call close() method > 2 The result are not full fetched > The prefetch thread will not exit and leave a memory leak risk. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21628) memory leak risk when ClientAsyncPrefetchScanner not close
[ https://issues.apache.org/jira/browse/HBASE-21628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] cong.han updated HBASE-21628: - Attachment: (was: HBASE-21628-v4.patch) > memory leak risk when ClientAsyncPrefetchScanner not close > -- > > Key: HBASE-21628 > URL: https://issues.apache.org/jira/browse/HBASE-21628 > Project: HBase > Issue Type: Improvement >Reporter: cong.han >Assignee: cong.han >Priority: Major > Attachments: HBASE-21328-v1.patch, HBASE-21628-v2.patch, > HBASE-21628-v3.patch, HBASE-21628-v4.patch > > > When we use ClientAsyncPrefetchScanner and we do two things below > 1 Forgot to call close() method > 2 The result are not full fetched > The prefetch thread will not exit and leave a memory leak risk. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21628) memory leak risk when ClientAsyncPrefetchScanner not close
[ https://issues.apache.org/jira/browse/HBASE-21628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] cong.han updated HBASE-21628: - Attachment: HBASE-21628-v4.patch > memory leak risk when ClientAsyncPrefetchScanner not close > -- > > Key: HBASE-21628 > URL: https://issues.apache.org/jira/browse/HBASE-21628 > Project: HBase > Issue Type: Improvement >Reporter: cong.han >Assignee: cong.han >Priority: Major > Attachments: HBASE-21328-v1.patch, HBASE-21628-v2.patch, > HBASE-21628-v3.patch, HBASE-21628-v4.patch, HBASE-21628-v4.patch > > > When we use ClientAsyncPrefetchScanner and we do two things below > 1 Forgot to call close() method > 2 The result are not full fetched > The prefetch thread will not exit and leave a memory leak risk. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21628) memory leak risk when ClientAsyncPrefetchScanner not close
[ https://issues.apache.org/jira/browse/HBASE-21628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731139#comment-16731139 ] cong.han commented on HBASE-21628: -- Sorry，I forgot to fix the style of the patch,I will work on it later. > memory leak risk when ClientAsyncPrefetchScanner not close > -- > > Key: HBASE-21628 > URL: https://issues.apache.org/jira/browse/HBASE-21628 > Project: HBase > Issue Type: Improvement >Reporter: cong.han >Assignee: cong.han >Priority: Major > Attachments: HBASE-21328-v1.patch, HBASE-21628-v2.patch, > HBASE-21628-v3.patch > > > When we use ClientAsyncPrefetchScanner and we do two things below > 1 Forgot to call close() method > 2 The result are not full fetched > The prefetch thread will not exit and leave a memory leak risk. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21628) memory leak risk when ClientAsyncPrefetchScanner not close
[ https://issues.apache.org/jira/browse/HBASE-21628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728180#comment-16728180 ] cong.han commented on HBASE-21628: -- [~stack] To the first question, the old version ClientAsyncPrefetchScanner use custom thread to do the async scan work , if user 1 Forgot to call close() method 2 The result are not full fetched the custom thread will not exit until we shutdown the application. and scan is a high-frequency api which increase the risk above. If we replace the custom thread with executors,users can use custom executors which they can close by themselves,or use htable's thread pool which we can handle correctly. To the second question,I checked the LockSupport api，use static object isn't a good choice,I use ClientAsyncPrefetchScanner which block the thread for a replacement,is this ok? to the third question,"We throw DifferentScanThreadException if two threads share a prefetcher " is much clear,fixed. > memory leak risk when ClientAsyncPrefetchScanner not close > -- > > Key: HBASE-21628 > URL: https://issues.apache.org/jira/browse/HBASE-21628 > Project: HBase > Issue Type: Improvement >Reporter: cong.han >Assignee: cong.han >Priority: Major > Attachments: HBASE-21328-v1.patch, HBASE-21628-v2.patch, > HBASE-21628-v3.patch > > > When we use ClientAsyncPrefetchScanner and we do two things below > 1 Forgot to call close() method > 2 The result are not full fetched > The prefetch thread will not exit and leave a memory leak risk. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21628) memory leak risk when ClientAsyncPrefetchScanner not close
[ https://issues.apache.org/jira/browse/HBASE-21628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] cong.han updated HBASE-21628: - Attachment: HBASE-21628-v3.patch > memory leak risk when ClientAsyncPrefetchScanner not close > -- > > Key: HBASE-21628 > URL: https://issues.apache.org/jira/browse/HBASE-21628 > Project: HBase > Issue Type: Improvement >Reporter: cong.han >Assignee: cong.han >Priority: Major > Attachments: HBASE-21328-v1.patch, HBASE-21628-v2.patch, > HBASE-21628-v3.patch > > > When we use ClientAsyncPrefetchScanner and we do two things below > 1 Forgot to call close() method > 2 The result are not full fetched > The prefetch thread will not exit and leave a memory leak risk. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21628) memory leak risk when ClientAsyncPrefetchScanner not close
[ https://issues.apache.org/jira/browse/HBASE-21628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727218#comment-16727218 ] cong.han commented on HBASE-21628: -- reattach, 1 fix check style and license problem 2 check prefetch condition when construct ClientAsyncPrefetchScanner to decide whether or not add PrefetchRunnable to pool 3 add some unit test case > memory leak risk when ClientAsyncPrefetchScanner not close > -- > > Key: HBASE-21628 > URL: https://issues.apache.org/jira/browse/HBASE-21628 > Project: HBase > Issue Type: Improvement >Reporter: cong.han >Assignee: cong.han >Priority: Major > Attachments: HBASE-21328-v1.patch, HBASE-21628-v2.patch > > > When we use ClientAsyncPrefetchScanner and we do two things below > 1 Forgot to call close() method > 2 The result are not full fetched > The prefetch thread will not exit and leave a memory leak risk. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21628) memory leak risk when ClientAsyncPrefetchScanner not close
[ https://issues.apache.org/jira/browse/HBASE-21628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] cong.han updated HBASE-21628: - Attachment: HBASE-21628-v2.patch > memory leak risk when ClientAsyncPrefetchScanner not close > -- > > Key: HBASE-21628 > URL: https://issues.apache.org/jira/browse/HBASE-21628 > Project: HBase > Issue Type: Improvement >Reporter: cong.han >Assignee: cong.han >Priority: Major > Attachments: HBASE-21328-v1.patch, HBASE-21628-v2.patch > > > When we use ClientAsyncPrefetchScanner and we do two things below > 1 Forgot to call close() method > 2 The result are not full fetched > The prefetch thread will not exit and leave a memory leak risk. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
