[jira] [Commented] (HBASE-18726) [C++] Don't compile with -D_GLIBCXX_USE_CXX11_ABI=0

2017-11-08 Thread marco polo (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244637#comment-16244637 ] marco polo commented on HBASE-18726: [~elserj] I specifically recall removing this as I wasn't sure

[jira] [Commented] (HBASE-18901) Support build with CMake

2017-10-12 Thread marco polo (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202695#comment-16202695 ] marco polo commented on HBASE-18901: [~enis] That line should have been removed. I removed it in my

[jira] [Commented] (HBASE-18901) Support build with CMake

2017-10-12 Thread marco polo (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202594#comment-16202594 ] marco polo commented on HBASE-18901: [~elserj] I agree with everything above. I most certainly do

[jira] [Commented] (HBASE-18901) Support build with CMake

2017-10-12 Thread marco polo (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202386#comment-16202386 ] marco polo commented on HBASE-18901: I'll be happy to provide some information in the README

[jira] [Issue Comment Deleted] (HBASE-18901) Support build with CMake

2017-10-12 Thread marco polo (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] marco polo updated HBASE-18901: --- Comment: was deleted (was: uploaded the wrong file) > Support build with CMake >

[jira] [Comment Edited] (HBASE-18901) Support build with CMake

2017-10-12 Thread marco polo (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202351#comment-16202351 ] marco polo edited comment on HBASE-18901 at 10/12/17 6:06 PM: -- My apologies.

[jira] [Updated] (HBASE-18901) Support build with CMake

2017-10-12 Thread marco polo (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] marco polo updated HBASE-18901: --- Attachment: HBASE-18901.v2.HBASE-14850.patch > Support build with CMake > >

[jira] [Updated] (HBASE-18901) Support build with CMake

2017-10-12 Thread marco polo (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] marco polo updated HBASE-18901: --- Attachment: (was: HBASE-18901.v2.HBASE-14850.patch) > Support build with CMake >

[jira] [Commented] (HBASE-18901) Support build with CMake

2017-10-12 Thread marco polo (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202351#comment-16202351 ] marco polo commented on HBASE-18901: My apologies. the previous file was from my Mac where I was

[jira] [Updated] (HBASE-18901) Support build with CMake

2017-10-12 Thread marco polo (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] marco polo updated HBASE-18901: --- Attachment: (was: hbase-18861_v1.patch) > Support build with CMake > >

[jira] [Updated] (HBASE-18901) Support build with CMake

2017-10-12 Thread marco polo (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] marco polo updated HBASE-18901: --- Attachment: HBASE-18901.v2.HBASE-14850.patch V1 was the incorrect file. > Support build with CMake

[jira] [Updated] (HBASE-18901) Support build with CMake

2017-10-12 Thread marco polo (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] marco polo updated HBASE-18901: --- Status: Open (was: Patch Available) uploaded the wrong file > Support build with CMake >

[jira] [Updated] (HBASE-18901) Support build with CMake

2017-10-12 Thread marco polo (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] marco polo updated HBASE-18901: --- Labels: C++ (was: ) Status: Patch Available (was: Open) Patch for CMAKE related changed. Per

[jira] [Updated] (HBASE-18901) Support build with CMake

2017-10-12 Thread marco polo (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] marco polo updated HBASE-18901: --- Attachment: hbase-18861_v1.patch Patch for CMAKE functionality > Support build with CMake >

[jira] [Commented] (HBASE-18861) [C++] Use boost::optional instead of std::experimental::optional

2017-09-21 Thread marco polo (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175675#comment-16175675 ] marco polo commented on HBASE-18861: +1 -- Patch looks good and works on local platforms that don't