[jira] [Commented] (HBASE-14007) Writing to table through MR should fail upfront if table does not exist/is disabled

2016-06-27 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352207#comment-15352207
 ] 

Hudson commented on HBASE-14007:


SUCCESS: Integrated in HBase-1.4 #253 (See 
[https://builds.apache.org/job/HBase-1.4/253/])
HBASE-14007 Writing to table through MR should fail upfront if table (tedyu: 
rev 34d62ecfae4cf79ae2882b91f2ca2a22f68281e0)
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduceBase.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java


> Writing to table through MR should fail upfront if table does not exist/is 
> disabled
> ---
>
> Key: HBASE-14007
> URL: https://issues.apache.org/jira/browse/HBASE-14007
> Project: HBase
>  Issue Type: Improvement
>  Components: mapreduce
>Affects Versions: 1.1.1
>Reporter: Thiruvel Thirumoolan
>Assignee: Thiruvel Thirumoolan
>Priority: Minor
>  Labels: mapreduce
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-14007.branch-1.000.patch, 
> HBASE-14007.branch-1.001.patch, HBASE-14007.branch-1.003.patch, 
> HBASE-14007.master.001.patch, HBASE-14007.master.002.patch, HBASE-14007.patch
>
>
> TableOutputFormat.checkOutputSpecs() needs to be fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-14007) Writing to table through MR should fail upfront if table does not exist/is disabled

2016-06-27 Thread Thiruvel Thirumoolan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351946#comment-15351946
 ] 

Thiruvel Thirumoolan commented on HBASE-14007:
--

Thanks for the guidance [~tedyu]!

> Writing to table through MR should fail upfront if table does not exist/is 
> disabled
> ---
>
> Key: HBASE-14007
> URL: https://issues.apache.org/jira/browse/HBASE-14007
> Project: HBase
>  Issue Type: Improvement
>  Components: mapreduce
>Affects Versions: 1.1.1
>Reporter: Thiruvel Thirumoolan
>Assignee: Thiruvel Thirumoolan
>Priority: Minor
>  Labels: mapreduce
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-14007.branch-1.000.patch, 
> HBASE-14007.branch-1.001.patch, HBASE-14007.branch-1.003.patch, 
> HBASE-14007.master.001.patch, HBASE-14007.master.002.patch, HBASE-14007.patch
>
>
> TableOutputFormat.checkOutputSpecs() needs to be fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-14007) Writing to table through MR should fail upfront if table does not exist/is disabled

2016-06-27 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351847#comment-15351847
 ] 

Hadoop QA commented on HBASE-14007:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 
55s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 50s 
{color} | {color:green} branch-1 passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 43s 
{color} | {color:green} branch-1 passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
14s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
24s {color} | {color:green} branch-1 passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 25s 
{color} | {color:red} hbase-server in branch-1 has 1 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 33s 
{color} | {color:green} branch-1 passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 37s 
{color} | {color:green} branch-1 passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 
57s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 7s 
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 7s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 44s 
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 44s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
11s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
18s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
19m 46s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 
41s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 34s 
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 39s 
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 84m 4s 
{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
15s {color} | {color:green} Patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 122m 28s {color} 
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12813819/HBASE-14007.branch-1.003.patch
 |
| JIRA Issue | HBASE-14007 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | branch-1 / 385a6e8 |
| Default Java | 1.7.0_80 |
| Multi-JDK versions |  /home/jenkins/tools/java/jdk1.8.0:1.8.0 
/home/jenkins/jenkins-slave/tools/hudson.model.JDK/JDK_1.7_latest_:1.7.0_80 |
| findbugs | v3.0.0 |
| findbugs | 

[jira] [Commented] (HBASE-14007) Writing to table through MR should fail upfront if table does not exist/is disabled

2016-06-27 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351637#comment-15351637
 ] 

Hudson commented on HBASE-14007:


FAILURE: Integrated in HBase-Trunk_matrix #1125 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/1125/])
HBASE-14007 Writing to table through MR should fail upfront if table (tedyu: 
rev 424b789e0394fdc074b1725275e30b04e601b486)
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduceBase.java


> Writing to table through MR should fail upfront if table does not exist/is 
> disabled
> ---
>
> Key: HBASE-14007
> URL: https://issues.apache.org/jira/browse/HBASE-14007
> Project: HBase
>  Issue Type: Improvement
>  Components: mapreduce
>Affects Versions: 1.1.1
>Reporter: Thiruvel Thirumoolan
>Assignee: Thiruvel Thirumoolan
>Priority: Minor
>  Labels: mapreduce
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-14007.branch-1.000.patch, 
> HBASE-14007.branch-1.001.patch, HBASE-14007.branch-1.003.patch, 
> HBASE-14007.master.001.patch, HBASE-14007.master.002.patch, HBASE-14007.patch
>
>
> TableOutputFormat.checkOutputSpecs() needs to be fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-14007) Writing to table through MR should fail upfront if table does not exist/is disabled

2016-06-27 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351587#comment-15351587
 ] 

Ted Yu commented on HBASE-14007:


Do you get the following test failure for branch-1 ?
{code}
testWritingToDisabledTable(org.apache.hadoop.hbase.mapreduce.TestTableMapReduce)
  Time elapsed: 0.483 sec  <<< ERROR!
java.lang.Exception: Unexpected exception, 
expected but 
was
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:526)
at 
org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:106)
at 
org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:95)
at 
org.apache.hadoop.hbase.util.ForeignExceptionUtil.toIOException(ForeignExceptionUtil.java:45)
at 
org.apache.hadoop.hbase.client.HBaseAdmin$ProcedureFuture.convertResult(HBaseAdmin.java:4711)
at 
org.apache.hadoop.hbase.client.HBaseAdmin$ProcedureFuture.waitProcedureResult(HBaseAdmin.java:4669)
at 
org.apache.hadoop.hbase.client.HBaseAdmin$ProcedureFuture.get(HBaseAdmin.java:4602)
at 
org.apache.hadoop.hbase.client.HBaseAdmin.disableTable(HBaseAdmin.java:1332)
at 
org.apache.hadoop.hbase.mapreduce.TestTableMapReduce.testWritingToDisabledTable(TestTableMapReduce.java:138)
Caused by: org.apache.hadoop.ipc.RemoteException: testfailuretable
at 
org.apache.hadoop.hbase.master.procedure.DisableTableProcedure.prepareDisable(DisableTableProcedure.java:281)
at 
org.apache.hadoop.hbase.master.procedure.DisableTableProcedure.executeFromState(DisableTableProcedure.java:133)
at 
org.apache.hadoop.hbase.master.procedure.DisableTableProcedure.executeFromState(DisableTableProcedure.java:54)
at 
org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:133)
at 
org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:499)
at 
org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1061)
{code}

> Writing to table through MR should fail upfront if table does not exist/is 
> disabled
> ---
>
> Key: HBASE-14007
> URL: https://issues.apache.org/jira/browse/HBASE-14007
> Project: HBase
>  Issue Type: Improvement
>  Components: mapreduce
>Affects Versions: 1.1.1
>Reporter: Thiruvel Thirumoolan
>Assignee: Thiruvel Thirumoolan
>Priority: Minor
>  Labels: mapreduce
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-14007.branch-1.000.patch, 
> HBASE-14007.branch-1.001.patch, HBASE-14007.master.001.patch, 
> HBASE-14007.master.002.patch, HBASE-14007.patch
>
>
> TableOutputFormat.checkOutputSpecs() needs to be fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-14007) Writing to table through MR should fail upfront if table does not exist/is disabled

2016-06-27 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351548#comment-15351548
 ] 

Ted Yu commented on HBASE-14007:


There is still rejected hunk for:
hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduceBase.java

Can you wrap long lines - limit is 100 characters per line.

Thanks

> Writing to table through MR should fail upfront if table does not exist/is 
> disabled
> ---
>
> Key: HBASE-14007
> URL: https://issues.apache.org/jira/browse/HBASE-14007
> Project: HBase
>  Issue Type: Improvement
>  Components: mapreduce
>Affects Versions: 1.1.1
>Reporter: Thiruvel Thirumoolan
>Assignee: Thiruvel Thirumoolan
>Priority: Minor
>  Labels: mapreduce
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-14007.branch-1.000.patch, 
> HBASE-14007.branch-1.001.patch, HBASE-14007.master.001.patch, 
> HBASE-14007.master.002.patch, HBASE-14007.patch
>
>
> TableOutputFormat.checkOutputSpecs() needs to be fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-14007) Writing to table through MR should fail upfront if table does not exist/is disabled

2016-06-27 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351543#comment-15351543
 ] 

Hadoop QA commented on HBASE-14007:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s {color} 
| {color:red} HBASE-14007 does not apply to branch-1. Rebase required? Wrong 
Branch? See https://yetus.apache.org/documentation/0.2.1/precommit-patchnames 
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12813812/HBASE-14007.branch-1.001.patch
 |
| JIRA Issue | HBASE-14007 |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/2381/console |
| Powered by | Apache Yetus 0.2.1   http://yetus.apache.org |


This message was automatically generated.



> Writing to table through MR should fail upfront if table does not exist/is 
> disabled
> ---
>
> Key: HBASE-14007
> URL: https://issues.apache.org/jira/browse/HBASE-14007
> Project: HBase
>  Issue Type: Improvement
>  Components: mapreduce
>Affects Versions: 1.1.1
>Reporter: Thiruvel Thirumoolan
>Assignee: Thiruvel Thirumoolan
>Priority: Minor
>  Labels: mapreduce
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-14007.branch-1.000.patch, 
> HBASE-14007.branch-1.001.patch, HBASE-14007.master.001.patch, 
> HBASE-14007.master.002.patch, HBASE-14007.patch
>
>
> TableOutputFormat.checkOutputSpecs() needs to be fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-14007) Writing to table through MR should fail upfront if table does not exist/is disabled

2016-06-27 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351472#comment-15351472
 ] 

Hadoop QA commented on HBASE-14007:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s {color} 
| {color:red} HBASE-14007 does not apply to branch-1. Rebase required? Wrong 
Branch? See https://yetus.apache.org/documentation/0.2.1/precommit-patchnames 
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12813806/HBASE-14007.branch-1.000.patch
 |
| JIRA Issue | HBASE-14007 |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/2379/console |
| Powered by | Apache Yetus 0.2.1   http://yetus.apache.org |


This message was automatically generated.



> Writing to table through MR should fail upfront if table does not exist/is 
> disabled
> ---
>
> Key: HBASE-14007
> URL: https://issues.apache.org/jira/browse/HBASE-14007
> Project: HBase
>  Issue Type: Improvement
>  Components: mapreduce
>Affects Versions: 1.1.1
>Reporter: Thiruvel Thirumoolan
>Assignee: Thiruvel Thirumoolan
>Priority: Minor
>  Labels: mapreduce
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-14007.branch-1.000.patch, 
> HBASE-14007.master.001.patch, HBASE-14007.master.002.patch, HBASE-14007.patch
>
>
> TableOutputFormat.checkOutputSpecs() needs to be fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-14007) Writing to table through MR should fail upfront if table does not exist/is disabled

2016-06-27 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351463#comment-15351463
 ] 

Ted Yu commented on HBASE-14007:


Using HTable is fine.

Can you put the HTable instance in the try-with-resource (it implements 
Closeable) ?

> Writing to table through MR should fail upfront if table does not exist/is 
> disabled
> ---
>
> Key: HBASE-14007
> URL: https://issues.apache.org/jira/browse/HBASE-14007
> Project: HBase
>  Issue Type: Improvement
>  Components: mapreduce
>Affects Versions: 1.1.1
>Reporter: Thiruvel Thirumoolan
>Assignee: Thiruvel Thirumoolan
>Priority: Minor
>  Labels: mapreduce
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-14007.branch-1.000.patch, 
> HBASE-14007.master.001.patch, HBASE-14007.master.002.patch, HBASE-14007.patch
>
>
> TableOutputFormat.checkOutputSpecs() needs to be fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-14007) Writing to table through MR should fail upfront if table does not exist/is disabled

2016-06-27 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351005#comment-15351005
 ] 

Ted Yu commented on HBASE-14007:


Mind attaching patch for branch-1 ?

> Writing to table through MR should fail upfront if table does not exist/is 
> disabled
> ---
>
> Key: HBASE-14007
> URL: https://issues.apache.org/jira/browse/HBASE-14007
> Project: HBase
>  Issue Type: Improvement
>  Components: mapreduce
>Affects Versions: 1.1.1
>Reporter: Thiruvel Thirumoolan
>Assignee: Thiruvel Thirumoolan
>Priority: Minor
>  Labels: mapreduce
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-14007.master.001.patch, 
> HBASE-14007.master.002.patch, HBASE-14007.patch
>
>
> TableOutputFormat.checkOutputSpecs() needs to be fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)